[00:03:00] Deskana: are you in office? [00:06:09] (03PS2) 10Brion VIBBER: Fix ToC scrolling to sections near end of page [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146641 (https://bugzilla.wikimedia.org/67633) [00:06:50] vbamba: Yep, just got back to my desk. [00:06:59] (03CR) 10Mhurd: [C: 032 V: 032] "Perfect!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146641 (https://bugzilla.wikimedia.org/67633) (owner: 10Brion VIBBER) [00:07:04] \o/ [00:07:11] if0xx: how’s gerrit treating you :D [00:07:48] dbrant|brb: Are you okay to move the design review to 4:30pm (SF time) tomorrow? [00:07:52] dbrant|brb: It's a bit late for you. [00:08:15] Deskana: Ok im coming over! [00:08:23] Deskana: yep, fine with me! [00:08:29] dbrant|brb: Thanks! [00:15:59] oops, "GET https://gerrit.wikimedia.org/tools/hooks/commit-msg" => 404 while installing git-review ... ? [00:18:48] (03PS1) 10BearND: Minor references pane adjustments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146654 [00:20:49] whaaaaa [00:20:59] (03PS3) 10BearND: Rename menu item Change font and theme -> Display settings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146384 [00:23:04] if0xx: maybe file a bug in bugzilla for that, sounds like something broke :( [00:23:37] if0xx: and if you still have trouble with gerrit feelf ree to toss it up on github or something for now, we’ll figure out how to import it from there :D [00:24:01] ok [00:24:13] (03PS4) 10BearND: Shorter menu item for Font/theme settings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146384 [00:24:34] ok, I'll see what works! [00:24:40] \o/ [01:06:34] (03PS5) 10JGonera: WIP: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 [01:25:23] (03PS1) 10Yurik: Allows settings to set point size of the banner font [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146669 [02:21:23] (03PS1) 10Kaldari: Making sure that clicking on search doesn't trigger history.back() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146684 (https://bugzilla.wikimedia.org/67140) [02:45:19] (03PS1) 10BearND: Checkstyle: Category Design (some) + Sizes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146686 [06:09:01] (03PS2) 10BearND: Checkstyle: Category Coding (some) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146629 [06:09:03] (03PS2) 10BearND: Checkstyle: Category Design (some) + Sizes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146686 [06:09:05] (03PS1) 10BearND: Checkstyle: various Categories + remove unused code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146693 [06:09:07] (03PS1) 10BearND: Checkstyle: Category Design (a few more) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146694 [10:06:56] (03PS1) 10Lokal Profil: License string corrected [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146743 [10:07:06] (03PS1) 10Lokal Profil: License string corrected [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146744 [11:43:46] 3MobileFrontend / 3Feature requests: Feature request: Cannot view source of old revisions - 10https://bugzilla.wikimedia.org/54484 (10Andre Klapper) [13:41:25] (03CR) 10Dbrant: [C: 032] Shorter menu item for Font/theme settings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146384 (owner: 10BearND) [13:43:22] (03CR) 10Dbrant: [C: 032] License string corrected [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146743 (owner: 10Lokal Profil) [13:43:30] (03PS3) 10Yuvipanda: Checkstyle: Category Coding (some) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146629 (owner: 10BearND) [13:45:49] (03CR) 10Yuvipanda: [C: 032] Checkstyle: Category Coding (some) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146629 (owner: 10BearND) [13:46:07] (03Merged) 10jenkins-bot: Checkstyle: Category Coding (some) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146629 (owner: 10BearND) [13:46:09] (03PS3) 10Yuvipanda: Checkstyle: Category Design (some) + Sizes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146686 (owner: 10BearND) [13:48:04] (03CR) 10Yuvipanda: [C: 032] Checkstyle: Category Design (some) + Sizes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146686 (owner: 10BearND) [13:48:24] (03Merged) 10jenkins-bot: Checkstyle: Category Design (some) + Sizes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146686 (owner: 10BearND) [13:48:40] (03PS2) 10Yuvipanda: Checkstyle: various Categories + remove unused code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146693 (owner: 10BearND) [13:51:01] (03CR) 10Yuvipanda: [C: 032] Checkstyle: various Categories + remove unused code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146693 (owner: 10BearND) [13:51:07] (03PS2) 10Yuvipanda: Checkstyle: Category Design (a few more) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146694 (owner: 10BearND) [13:51:22] (03Merged) 10jenkins-bot: Checkstyle: various Categories + remove unused code [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146693 (owner: 10BearND) [13:52:20] * YuviPanda waves [13:55:17] (03CR) 10Yuvipanda: [C: 032] Checkstyle: Category Design (a few more) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146694 (owner: 10BearND) [13:55:36] (03Merged) 10jenkins-bot: Checkstyle: Category Design (a few more) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146694 (owner: 10BearND) [13:57:42] (03PS2) 10Yuvipanda: Manual import of translations from translatewiki.net [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146255 [14:02:07] (03CR) 10Zfilipin: [C: 031] QA make sure watchlist shows correct tab [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146500 (owner: 10Cmcmahon) [14:02:37] (03PS3) 10Yuvipanda: Manual import of translations from translatewiki.net [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146255 [14:02:52] (03CR) 10Zfilipin: QA make sure watchlist shows correct tab (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146500 (owner: 10Cmcmahon) [14:03:47] YuviPanda: (1) i like the release frequency stuff. (2) when will the next stable APK go out? :) [14:03:56] YuviPanda: i'm looking at some preload stuff [14:04:36] dr0ptp4kt: I think we're going to do an 'out of band' release to beta today [14:04:38] and see how it goes [14:05:23] dr0ptp4kt: when do you want 'em? :D [14:05:49] YuviPanda: is that the one that will then get subsequent bugfixes and be released as a production release X days later? [14:06:08] YuviPanda: ha, well you know, if we had a new production release every day that would be great ;D [14:06:21] YuviPanda: yes, i know about ci, just joking around. [14:07:10] dr0ptp4kt: :D [14:07:27] dr0ptp4kt: yeah. I think in this case 'X' will be short, it being the start of the cycle and all. maybe 7 days? [14:09:18] YuviPanda: that sounds great. that reminds me, what's the best way for me to tell which sprint we're in and which day in the sprint we're at? [14:09:41] dr0ptp4kt: ah, hmm. trello.wikimediafoundation has all the boards, but outside of that I don't know [14:09:55] dr0ptp4kt: I've started adding calendar events for the release events, though. wnat me to add you to 'em? [14:10:07] YuviPanda: yeah, thanks! [14:10:11] dr0ptp4kt: cool, will do [14:11:57] YuviPanda: thanks. hey do you know if the zh language variant thing is being worked? i was thinking for preload in that region it will be important to have that ahead of providing oems the apk [14:12:38] dr0ptp4kt: no, it's not on the radar atm (sad, I know). Has bugs in both our code and Translate extension. poke Deskana|Away? [14:13:05] YuviPanda: will do. even just a small hack will do. maybe i could work on that one? [14:13:10] dr0ptp4kt: sure! [14:13:48] dr0ptp4kt: we also have no zh localizations because of an issue in Extension:Translate. Nikerabbit says it's trivial to fix, so you should also poke 'em in #mediawiki-i18n to make that happen :) [14:19:46] 3MobileFrontend / 3stable: beta labs: Watchlist "Modified" view shows no results. - 10https://bugzilla.wikimedia.org/67987#c9 (10Chris McMahon) 5REOP>3PATC https://gerrit.wikimedia.org/r/#/c/146500/ [14:25:36] (03PS6) 10Dbrant: Update overflow menu text when Saved pages are saved/loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146081 [14:26:28] YuviPanda: cool, thanks! [14:27:29] (03PS1) 10Dbrant: Final design refinements for Font/Theme chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146776 [14:32:17] (03CR) 10Dbrant: [C: 032] Manual import of translations from translatewiki.net [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146255 (owner: 10Yuvipanda) [14:33:34] heh, some of our OTRS tickets are fun [14:33:49] > > PLEASE CAN YOU STAND AS MY GUARDIAN? REPLY TO: @GMAIL.COM FOR MORE DETAILS. [14:35:18] (03CR) 10Dbrant: [C: 032] Minor references pane adjustments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146654 (owner: 10BearND) [14:37:30] brion: left comments about map tiles on the ios pull request [14:37:46] yeps [14:40:46] (03PS1) 10Dbrant: Set correct link color in TextViews that have links. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146782 [14:41:03] dr0ptp4kt: btw, I think we need to have a conversation going about supporting non google app stores (amazon, chinese ones, pre-load). That'll also make sure we're aware of any usage of Google specific APIs as well, if we've an agreed commitment to them prior [14:41:44] * brion raises the ghost of Google Play Services [14:42:03] heh yeah :) [14:42:07] “wwoooooooooooooohh I am the ghost of Google Play Services! I cause your app to be incompatible with non-Google devices! whooooooooooaaaaaa" [14:51:15] YuviPanda: agreed. brion, ha! i'm going to loop in you guys on an email [15:03:32] (03PS2) 10Yurik: Cleaned up X-Forward-Proto variance [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146633 [15:03:48] dr0ptp4kt, ^ [15:03:59] yurikJerusalem: ok, thx [15:07:32] (03CR) 10Dr0ptp4kt: [C: 032] Allows settings to set point size of the banner font [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146669 (owner: 10Yurik) [15:07:40] dr0ptp4kt: thanks for getting the threads started! [15:07:43] (03Merged) 10jenkins-bot: Allows settings to set point size of the banner font [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146669 (owner: 10Yurik) [15:07:44] brion: you should cc legal [15:08:32] YuviPanda: i figure i want guidance from manager & PM before we go to legal with questions :) [15:08:53] luis already looks at me funny when i ask about integrating video libraries ;) [15:09:24] “hey let’s just compile in VLC!” “..." [15:09:34] hehe [15:12:53] YuviPanda: sure thing. NOW, here's the question: to make sure we have an updated User-Agent string, in the alternative appstores, i thnk the simplest way to do it is to have a distinct apk per release channel that adds a little extra in the apk. would it be possible when the build script runs for stable to generate a _set_ of apks (one per channel)? my thought is a configuration string in a configuration file would be updated. for exampl [15:12:53] the configuration string would be "Amazon" for the amazon appstore's apk, and the part of the code that builds the User-Agent could be updated to look for that string in the configuration and, if found, put it in the right place in the User-Agent string. [15:14:22] dr0ptp4kt: I'd want them to be different branches as well, but yeah, it should be possible. [15:14:46] dr0ptp4kt: it shouldn't be too hard to add the distribution channel where it came from either in the UA. [15:15:45] YuviPanda: cool, thx. will talk to you later about that. gotta do a code review and then hop in a car pretty soon [15:18:04] 3MobileFrontend / 3General/Unknown: Mobile pages are cached in the file cache - 10https://bugzilla.wikimedia.org/68106 (10Steve) 3UNCO p:3Unprio s:3normal a:3None This is with $wgMFAutodetectMobileView set to the default value of false. With MobileFrontend enabled, clear the HTML cache. On a page, c... [15:18:17] you wanna add mobilevlc into the app ? [15:19:02] yurikJerusalem: did you confirm with the varnish guys if the vary stuff behaves "intelligently" to seek out the most specific matching multikey for the set of potential keys from the given request? [15:19:12] brion: that is quite a license puzzle :) not so much the kit itself, but the codecs that you ship with it mostly. [15:20:31] 3MobileFrontend / 3General/Unknown: Mobile pages are cached in the file cache - 10https://bugzilla.wikimedia.org/68106#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/cY7ZSo2B [15:20:58] thedj: yeah. mobilevlckit and gstreamer in theory can be both built without evil codecs, but either might be too scary for legal in the end, i dunno :) [15:21:18] i save a lot of space by using lower-level libraries directly though, even gstreamer pulls in things like glib which bloat the binary [15:21:26] vlckit just scares me in its build system ;) [15:21:46] yeah vlckit is a bit scary. [15:21:56] if you need help, i have a contact for you. [15:24:21] but vlc ports is... scary :) [15:24:50] hehe [15:25:13] yeah last time i built vlc for ios i had to remove homebrew to get it to talk to its version of autoconf o_O [15:25:19] that might be cleaner now i should check again [15:26:22] yeah one of the reasons it uses it's own contribs systems is that it was so easy to conflict with homebrew/macports to begin with. [15:28:01] scary amount of dependencies. [15:29:31] heh [15:31:57] (03PS1) 10Dbrant: Fix action bar color in 2.3 (typo) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146791 [15:34:58] dr0ptp4kt, go ahead and +2 it i think [15:35:30] dr0ptp4kt, unless we want to make that if even stricter [15:36:15] https://gerrit.wikimedia.org/r/#/c/146633/2/includes/PageRendering.php [15:36:54] like -- if ( !$this->isUnifiedZero() && $this->getConfigId() !== null ) [15:38:48] (03PS1) 10Dbrant: Restrict search EditText to single line (including hint). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146792 [15:39:02] dr0ptp4kt, i think we should do the stricter version [15:39:25] yurikJerusalem: i gather this is based on fgs's feedback on #varnish on irc.linpro.no? i don't know that the additional restriction is necessary, but if you want to add it, that's fine, please do so right away. if i +2 it can you test on beta labs for any regressions on cache output? i'm about to jump in my ride. [15:40:32] (03PS3) 10Yurik: Cleaned up X-Forward-Proto variance [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146633 [15:40:32] dr0ptp4kt, ^ [15:40:56] restriction will keep variance away for non-X-CS users [15:41:50] (03CR) 10BearND: [C: 032] Set correct link color in TextViews that have links. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146782 (owner: 10Dbrant) [15:42:17] (03CR) 10Dr0ptp4kt: [C: 032] Cleaned up X-Forward-Proto variance [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146633 (owner: 10Yurik) [15:42:33] yurikJerusalem: be sure to check on regression for standard non-w0 users as well. i know logically they fall into the same bucket, but just in case... [15:42:46] yurikJerusalem: i just +2'd [15:42:48] dr0ptp4kt, will do, thx! [15:42:57] yurikJerusalem: i'll be back online around 10 am pacific [15:42:59] varnish ppl gave a good read https://www.varnish-cache.org/trac/wiki/ArchitectureVary [15:43:01] yurikJerusalem: ttyl [15:52:34] 3Wikipedia App / 3Android App: App crashes on network error when reloading captcha. - 10https://bugzilla.wikimedia.org/68109 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None Need to handle network errors when loading/reloading captcha. [15:53:38] bearND: dbrant beta release today, after the minor style patches are merged? [15:53:55] YuviPanda: correct!! [15:54:32] 3Wikipedia App / 3Android App: EditPreviewFragment doesn't handle errors - 10https://bugzilla.wikimedia.org/67038#c5 (10Dmitry Brant) I've created Bug 68109 to take care of the report in Comment 4. [15:55:32] YuviPanda: sounds great [15:58:16] 3Wikipedia App / 3Android App: App crashes on network error when reloading captcha. - 10https://bugzilla.wikimedia.org/68109#c1 (10Alex Monk) (Per bug 67038 comment 4, see https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7666254) [15:58:31] 3Wikipedia App / 3Android App: EditPreviewFragment doesn't handle errors - 10https://bugzilla.wikimedia.org/67038#c6 (10Alex Monk) Okay, is this fixed now then? [15:59:40] (03CR) 10BearND: [C: 032] Restrict search EditText to single line (including hint). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146792 (owner: 10Dbrant) [16:04:21] YuviPanda: is jenkins stuck? some of my previous +2's have not been merged [16:04:25] https://integration.wikimedia.org/zuul/ [16:05:08] bearND: hmm, might be. someone in -operations or -dev will restart it soon, I think [16:05:10] bearND: Jenkins is stuck for me too [16:06:52] YuviPanda: I asked on -dev [16:07:15] chrismcmahon: thanks! [16:10:59] (03Merged) 10jenkins-bot: Set correct link color in TextViews that have links. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146782 (owner: 10Dbrant) [16:11:40] (03PS1) 10Dbrant: Handle network errors when reloading captcha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146799 (https://bugzilla.wikimedia.org/68109) [16:12:17] 3Wikipedia App / 3Android App: EditPreviewFragment doesn't handle errors - 10https://bugzilla.wikimedia.org/67038#c7 (10Dmitry Brant) Yes, it is. (although not in the public release yet) [16:12:32] chrismcmahonbrb: yeah, it's moving again [16:16:16] dbrant: is the last if check in ThemedActionBarActivity really necessary? It seems to show the right action bar background color on my DroidX without it. [16:18:29] bearND: it seems to be necessary on my LG G2x (2.3.3)... if it's not doing any harm on other devices, we should have it there. [16:19:00] dbrant: That's fine. Was just wondering. [16:19:18] (03PS2) 10BearND: Restrict search EditText to single line (including hint). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146792 (owner: 10Dbrant) [16:20:15] (03CR) 10BearND: [V: 032] Restrict search EditText to single line (including hint). [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146792 (owner: 10Dbrant) [16:21:21] (03PS2) 10BearND: Fix action bar color in 2.3 (typo) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146791 (owner: 10Dbrant) [16:21:50] (03CR) 10BearND: [C: 032] Fix action bar color in 2.3 (typo) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146791 (owner: 10Dbrant) [16:24:34] 3Wikipedia App / 3Android App: EditPreviewFragment doesn't handle errors - 10https://bugzilla.wikimedia.org/67038 (10Alex Monk) 5PATC>3RESO/FIX [16:30:27] (03PS2) 10BearND: Final design refinements for Font/Theme chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146776 (owner: 10Dbrant) [16:30:52] (03CR) 10BearND: [C: 032] Final design refinements for Font/Theme chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146776 (owner: 10Dbrant) [16:31:13] (03Merged) 10jenkins-bot: Final design refinements for Font/Theme chooser. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146776 (owner: 10Dbrant) [16:32:18] (03CR) 10Yurik: [C: 032] Cleaned up X-Forward-Proto variance [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146633 (owner: 10Yurik) [16:32:27] dbrant: https://gerrit.wikimedia.org/r/#/c/146081/ does not automatically rebase. Would you do that manually? [16:32:43] bearND: roger that... [16:32:49] bearND: release before the prioritization meeting? Either you or dbrant can do it... [16:33:03] just check if res/values-iw is symlinked properly to res/values-he or we won't have hebrew translations... [16:34:09] ok, stepping out for food. brb [16:34:12] YuviPanda: I don't have the prioritization meeting on my calendar. [16:34:15] oh? [16:34:38] bearND: oh, I... uh, thought today was Thursady :| [16:34:40] nevermind me [16:34:53] lol [16:34:58] YuviPanda: tomorrow is iteration review [16:35:07] yeah, tomorrow is also thursday. [16:35:11] I really should fix my sleep cycle [16:35:22] I went to sleep on Wednesday, so I think I assumed I must've woken up on Thursday [16:35:29] while, of course, that didn't hold true... [16:35:30] YuviPanda: lol [16:35:51] YuviPanda: is there any change to the beta release process? [16:36:01] bearND: nope, same ol', same ol' :) [16:36:14] YuviPanda: ok, that's easy then [16:36:21] :D [16:36:27] just check the hebrew translation :D [16:37:06] alright, going out for food for real now. This city stupidly closes down at 11pm... [16:37:07] brb [16:37:14] YuviPanda: ok [16:39:15] (03PS7) 10Dbrant: Update overflow menu text when Saved pages are saved/loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146081 [16:45:32] (03CR) 10BearND: [C: 032] Update overflow menu text when Saved pages are saved/loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146081 (owner: 10Dbrant) [16:45:57] (03PS2) 10BearND: Handle network errors when reloading captcha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146799 (https://bugzilla.wikimedia.org/68109) (owner: 10Dbrant) [16:46:03] (03Merged) 10jenkins-bot: Update overflow menu text when Saved pages are saved/loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146081 (owner: 10Dbrant) [16:46:15] (03PS3) 10BearND: Handle network errors when reloading captcha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146799 (https://bugzilla.wikimedia.org/68109) (owner: 10Dbrant) [16:47:49] (03CR) 10Yurik: [V: 032] Cleaned up X-Forward-Proto variance [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146633 (owner: 10Yurik) [16:52:36] (03CR) 10BearND: [C: 032] Handle network errors when reloading captcha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146799 (https://bugzilla.wikimedia.org/68109) (owner: 10Dbrant) [16:53:24] bearND: yay! all caught up [16:55:37] (03Merged) 10jenkins-bot: Handle network errors when reloading captcha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146799 (https://bugzilla.wikimedia.org/68109) (owner: 10Dbrant) [16:56:11] I was pinged? [16:56:20] dbrant: :) I think I'm going to change the menu item for theme chooser again. Font/theme needs at least spaces around the /. Are you ok with vbamba's suggestion of "Font and Theme"? [16:56:39] bearND: ah yes, I agree with that. [16:58:21] dbrant: Going to make it "Font and theme" since Siebrand would probably -1 the uppercase [16:58:35] bearND: lol yes [16:58:42] (03PS1) 10BearND: Change theme chooser menu title to Font and theme [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146814 [17:00:49] (03CR) 10Dbrant: [C: 032] Change theme chooser menu title to Font and theme [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146814 (owner: 10BearND) [17:16:46] brion: you guys getting set up for the standup ? [17:18:20] 3Wikipedia App / 3Android App: App crashes on network error when reloading captcha. - 10https://bugzilla.wikimedia.org/68109#c4 (10Dan Garry) 5PATC>3RESO/FIX Should be fixed now! [17:18:20] 3Wikipedia App / 3Android App: Common NPE crashes involving not being able to start activities - 10https://bugzilla.wikimedia.org/67718#c7 (10Dan Garry) 5PATC>3RESO/FIX Should be fixed now! [17:28:26] MaxSem do you know anything about this? http://sploid.gizmodo.com/mysterious-hole-discovered-in-siberia-1605872539 [17:29:55] looks like a hole dug by groundwater [17:30:03] not mole people? [17:30:48] we have giant rats, but in Moscow sewers. they live right next to boogeymen [17:30:50] awjr: I thought 'dwarfs' was the politically correct term? :P [17:31:09] * YuviPanda|food gives everyone axes [17:36:11] Maryana, we're pushing VE to stable on July 21? [17:36:28] uh, no.. [17:36:33] ok [17:36:37] where did you see that? [17:36:42] I didn't [17:36:50] what is the date? [17:37:08] july 31, i believe - awjr, did we say 30 or 31? [17:37:15] but anyway, not next week :) [17:37:19] good ;) [17:37:33] 31 i think... have to check notes [17:38:14] pretty sure it's 31 [17:38:22] but can't hurt to double-check [17:41:31] dbrant: rsvg should work on Windows, I think? [17:41:50] I found http://opensourcepack.blogspot.in/2012/06/rsvg-convert-svg-image-conversion-tool.html [17:41:56] dbrant: or is it sh that doesn't work? [17:42:32] dbrant: and he -> iw, we can either have a script that copies it over, or talk to langeng team to see if they can export as he itself [17:42:52] iirc you have to export it as both cause some devices use he and some iw or some shit [17:43:03] maaadness [17:43:21] brion: are you sure? Android docs specifically say iw... [17:43:45] i remember there being weird hacked devices or something… doublehceck with amir :) [17:44:27] YuviPanda: right; it's "sh" that's not supported on Windows [17:44:50] YuviPanda: and yes, how about a pre-build script that copies he -> iw [17:45:10] hmm, we can theoretically just use process, which should work on Windows, but it's just so much more painful... [17:45:51] YuviPanda: couldn't we just do "os.system(...)" [17:46:11] yeah, popen is the 'nicer' and more secure way of doing that [17:48:07] jgonera Maryana yeah, the 31st since that's a thursday (deployment) [17:48:22] cool, thanks for checking [17:48:43] but that means we have to have it merged before deployment branch is cut on the 24th (so it's live on enwiki on the 31st) [17:49:18] dbrant: hmm, https://pypi.python.org/pypi/pbs is an older version that has windows support [17:49:35] awjr: ah, right… hmm [17:50:04] i want to make sure we have this merged concurrently: https://trello.com/c/7SLf1IU7/10-2-send-all-users-to-wikitext-editor-by-default [17:50:26] does this mean we need a ve to stable card for this sprint? [17:51:29] awjr: ^^ [17:53:40] Maryana ah yes [17:53:40] (03PS3) 10Kaldari: Change pagelist placeholder image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145895 (https://bugzilla.wikimedia.org/67471) (owner: 10Florianschmidtwelzow) [17:53:43] oops. [17:53:43] zomg zomg “The status for the following app has changed to Pending Developer Release.” [17:53:49] Maryana i thought we had one :-| [17:53:58] that means we have time to sneak in another update with fixes :D [17:54:07] brion: oh wow, that was fast [17:54:21] we must have caught someone’s eye in the queue :D [17:54:32] Maryana i suggest maybe synching up with jgonera and kaldari about feasibility/effort [17:54:48] :DDD [17:54:51] Maryana and then de-scope existing cards to make room for that [17:55:11] eg if it'll take 5 points worth of work for ve -> stable, remove at least 5 points worth of stories from existing wall [17:55:42] jgonera: kal[tab] damnit [17:55:49] lulz [17:55:50] there we go [17:55:56] jgonera: kaldari - quick huddle? [17:59:26] (03PS4) 10Kaldari: Change pagelist placeholder image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145895 (https://bugzilla.wikimedia.org/67471) (owner: 10Florianschmidtwelzow) [18:00:00] (03CR) 10Kaldari: [C: 032] Change pagelist placeholder image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145895 (https://bugzilla.wikimedia.org/67471) (owner: 10Florianschmidtwelzow) [18:01:02] dbrant: windows also has the symlinks concept, so we could do something like http://stackoverflow.com/questions/5917249/git-symlinks-in-windows [18:01:51] (03Merged) 10jenkins-bot: Change pagelist placeholder image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145895 (https://bugzilla.wikimedia.org/67471) (owner: 10Florianschmidtwelzow) [18:03:19] YuviPanda: sounds more complex than having a pre-build copy event... [18:04:20] dbrant: true. I'm ok with a pre-build copy event. [18:04:29] I suppose that would integrate with mvn? [18:06:12] YuviPanda: probably; but I'm not (yet) well-versed in that. [18:10:09] dbrant: right. since I don't have access to a windows machine, can you move the sh module to popen? I can do that too, but won't be able to test on windows. [18:17:58] YuviPanda: dbrant: I'm hoping we could move from mvn to gradle soon [18:18:07] thoughts? [18:18:31] that's fine by me provided all the libraries we use have aar packages available :) [18:19:49] YuviPanda: good point. i'm going to check that [18:19:57] cool [18:19:59] YuviPanda: dbrant: as far as the sym link is concerned why don't we do the copy step as part of the import from twn? [18:20:06] we could do that too [18:20:25] sure [18:22:18] dbrant: bearND hmm, so I can write a simple script that should be run on translatewiki.net when the imports are being done. Should handle the copying fine, and we can add more tests to it later if we want. [18:22:26] Deskana|Away: you about ? [18:22:40] YuviPanda: that sounds great [18:22:58] YuviPanda: sure! [18:23:07] that's definitely more important than the icon script [18:23:11] dbrant: alright, then I'll handle that :D [18:26:22] YuviPanda, continuing the discussion on stuff from this morning: for oem, we may have the case where they install the app and also have Google Play updateability for the app, meaning that we can't just create a different apk for them to determine the distribution channel by user-agent. my planned approach to handle that case is this: (1) create a different Service app for the purpose of knowing it's a preinstall and (2) have the main [18:26:23] YuviPanda, continuing the discussion on stuff from this morning: for oem, we may have the case where they install the app and also have Google Play updateability for the app, meaning that we can't just create a different apk for them to determine the distribution channel by user-agent. my planned approach to handle that case is this: (1) create a different Service app for the purpose of knowing it's a preinstall and (2) have the main [18:26:43] your message got cut off, dr0ptp4kt [18:26:52] YuviPanda: i'll retry [18:27:05] YuviPanda: YuviPanda, continuing the discussion on stuff from this morning: for oem, we may have the case where they install the app and also have Google Play updateability for the app, meaning that we can't just create a different apk for them to determine the distribution channel by user-agent. my planned approach to handle that case is this: (1) create a different Service app for the purpose of knowing it's a preinstall and ... [18:27:11] ...YuviPanda: (2) have the main Wikipedia app check for the service, augmenting the user-agent depending on whether the service was present (and perhaps whatever value it was emanating). with this approach, we would need to ask the oem to install both the service and the wikipedia app at the same time when burning the image. does that approach make sense? for the alternative appstores i think a customized apk is much simpler, of course, [18:27:11] am trying to cover the bases. [18:27:34] 3MobileFrontend / 3General/Unknown: Search: Disambiguations pages show 'missing image' symbol - 10https://bugzilla.wikimedia.org/67471 (10Florian) 5PATC>3RESO/FIX [18:28:52] dr0ptp4kt: I think having an extra app present feels... ugly. Don't know if we should go that route [18:29:38] jgonera: kaldari - sisig in ~5-10 min? :) [18:29:45] yes [18:30:05] moizsyed, ^ [18:30:17] YuviPanda: i don't know if we can steer the oems on this stuff, but another option is to give them a customized apk, and then ask them to be prepared to have it updated every 6 weeks or something like that. if that wouldn't fly, any other ideas for this oem preload case? [18:30:30] Maryana: kaldari jgonera YESSSS [18:30:38] 10 minutes [18:31:03] dr0ptp4kt: do we *really* need to differentiate by pre-load? [18:31:07] Maryana: a little bit of sisig in my liiiiiife, a little bit of fried egg on the siideeee [18:31:45] jgonera: ok, but let's be ready to go at 11:40 sharp [18:31:49] the line's gonna get crazy [18:32:02] moizsyed: smh [18:32:04] you can go earlier and I'll join you in the line? ;) [18:32:08] haha [18:32:18] https://www.youtube.com/watch?v=YeqOLxRDsV8 [18:33:00] oh that reminds me - have y'all seen this yet? https://www.youtube.com/watch?v=8Gv0H-vPoDc [18:33:07] weird al is back and it makes me so happy [18:33:32] … except then i just get the original songs stuck in my head, and they're terrible [18:33:58] Maryana: we watched that yesterday and both me and anna said this at the same time "i've never liked weird al, is that ok?" [18:33:58] (03PS1) 10Mhurd: Animate splash logo. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146838 [18:34:11] Maryana: and at that moment i knew ive found the one [18:34:18] moizsyed: yeah, that's why you're not my friend [18:34:24] that and the fact that you're not coming to my birthday [18:34:34] YuviPanda: i think doing it on a per-oem basis is what they were hoping for. this helps to guage whether preloading has the expected impact of reaching users in global south markets without determining that through implication from fluctuations in pageview traffic in a given geo. were you thinking of having something more generic for this oem case, like one customized APK for _all_ oems? [18:34:37] Maryana: thats not confirmed, im still gonna try [18:34:44] no, i've given up hope [18:34:46] it's done [18:34:53] in fact, if you show up, i won't let you in [18:35:16] hahaha [18:36:07] dr0ptp4kt: hmm, so one thing we *can* do is to leave a SharedPref or something like that that'll stay across updates [18:37:59] YuviPanda: aha. remind me, does that require that the user launch the app at least once? or can that work even without the app having been launched? it may be an edge case that we don't care about, but i'm thinking about the case where the user gets the device and there's an app update already available. then again, perhaps we can have the oem launch the app once before actually burning in the image. if it's possible to have them burn it [18:37:59] without launching it in order to have a pristine apk, even better. [18:38:51] dr0ptp4kt: ah, good question. I don't know, but worst case we can have a simple service that runs once on startup and sets it [18:39:09] moizsyed: kaldari jgonera ok let's hit it [18:39:19] ok [18:40:00] YuviPanda: okay, so in that case we're talking one APK that has both the launchable app, but that also contains the startup service, right? [18:40:24] dr0ptp4kt: yup, that runs only once, ever. It's an edge case, though [18:41:43] YuviPanda: gotcha. would we want to reuse that for the alternative appstore APKs as well you think? or in the case of the alternative appstore APKs would we rather just have the User-Agent setter read from the native config? [18:42:05] dr0ptp4kt: I think the 'startup service' would only be on for OEM apks [18:45:47] YuviPanda: cool. alright, so to summarize: one apk per appstore, as well as one apk per oem. appstore case, just have the user-agent setter look at the config file. in the oem case, have it look for the value in SharedPreferences set by a one-time service. do i have that right? [18:48:03] dr0ptp4kt: they shouldn't be if/else'd, I think. Everything should look for it in SharedPrefs, and if not found, look at hardcoded. We will just make different builds for different OEMs by changing the strings, but the code itself should all be in master and the same [18:49:18] YuviPanda: got ya. we'll have separate branches per apk as part of standardized build process, but the service and the user-agent setter will be in the mainline master. [18:49:26] yeah [18:49:35] YuviPanda: alright, thank you again! [18:49:42] dr0ptp4kt: :D [18:54:34] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Thanks for the catch!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146744 (owner: 10Lokal Profil) [19:01:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] "kickass :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146838 (owner: 10Mhurd) [19:09:35] 3Wikipedia App / 3Android App: Cannot edit MediaWiki:Common.css - 10https://bugzilla.wikimedia.org/66320#c4 (10Alex Monk) I just checked and I can't seem to edit MediaWiki:Common.css from the app. I just get "Could not reach the network :(" [19:12:30] bearND|food: Downloaded the new apk [19:12:33] cant see any changes [19:13:23] dbrant: hey! [19:13:27] downloaded the latest apk [19:13:34] cant see anything different from the last version [19:14:39] vbamba: checking... [19:16:39] vbamba: i've just verified it. the APK looks correct. [19:18:38] vbamba: same here. make sure you download the apk on your device and install it directly from there [19:19:06] vbamba: you should see also the menu item has changed to Font and theme [19:21:02] bearND: is there a way to automatically insert the current date into the versionName in our Manifest? [19:21:06] iOS people (/me eyes brion): quick and easy i18n question -- is $1 in [[Wikimedia:Wikipedia-ios-wikitext-upload-save-terms-and-license]] (http://translatewiki.net/w/i.php?title=Wikimedia:Wikipedia-ios-wikitext-upload-save-terms-and-license/fi&action=edit&loadgroup=out-wikimedia-mobile-0-all&loadtask=untranslated) the message [[Wikimedia:Wikipedia-ios-wikitext-upload-save-terms-name]]... [19:21:08] ...(http://translatewiki.net/w/i.php?title=Wikimedia:Wikipedia-ios-wikitext-upload-save-terms-name/fi&action=edit&loadgroup=out-wikimedia-mobile-0-all&loadtask=untranslated)? [19:21:44] I seem to have lost track of a bug mentioning NPEs from editing.EditHandler.onMessage [19:21:48] I'm pretty sure I made one, but... [19:22:25] dbrant: well, once we have ci builds that would be done there [19:22:29] Oh, no, I just left a list of tickets about it on etherpad [19:22:36] I should turn those into a bug report at some point [19:26:44] ashley: i believe so, lemme double-check [19:28:07] ashley: yep! [19:28:32] brion: super, thank you :) [19:29:00] ashley: feel free to edit the qqq message to add an explicit reference :) thanks for checking! [19:31:36] YuviPanda: Want to talk about the email you sent about CI stuff? [19:31:42] Deskana: sure! [19:32:09] Deskana: they are all fairly well split out tasks, and I think we can take 'em all next sprint (since it was already light on Android stuff anyway). [19:32:25] YuviPanda: So this is quite technical stuff. How about you create a bunch of cards in sprint 36, then we'll see how they fit in? [19:32:44] Deskana: sure [19:32:47] Deskana: doing now [19:34:02] hmm strange [19:37:31] Deskana: done [19:37:49] YuviPanda: Do you want to break up the dashboard card too? [19:38:19] YuviPanda: It'd be good to break it up before the review. [19:38:22] Deskana: I wonder if I should break 'em up first or modify 'em there and then break 'em up. [19:38:38] YuviPanda: Tomasz and I would like it broken up first, if possible. [19:38:41] Deskana: Page views are not something we can do, for example. And I think reverts should be punted right now - is doable but slow and complicated. [19:38:56] Deskana: ah, cool. then can you just break 'em up for one card each per list? :D [19:39:19] Deskana: I can do that if you don't have the time atm [19:40:02] YuviPanda: It'd be great if you could do it. Lots of iOS stuff going on for me right now. :) [19:40:10] Deskana: :D yeah, moment [19:40:12] YuviPanda: Or ask tfinc, our lovely scrummaster! [19:40:30] YuviPanda: what do you need ? [19:40:45] tfinc: someone to split up https://trello.com/c/nOJDn3zC/7-as-a-mobile-team-member-i-d-like-our-most-popular-metrics-to-be-shown-on-an-analytics-dashboard into individual cards per checklist [19:41:24] dbrant: hey I see it now [19:41:28] YAYYYYY [19:41:31] (03PS1) 10Mhurd: Lower case "u" in terms of use. More menu padding adjustment. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146855 [19:41:42] omg, reference pane looks amazing!!!! [19:41:55] moizsyed: bump - https://trello.com/c/yKR3BZlB/71-wikitinder-v-1 [19:42:02] (03CR) 10Brion VIBBER: [C: 032 V: 032] Lower case "u" in terms of use. More menu padding adjustment. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146855 (owner: 10Mhurd) [19:43:40] dbrant: the 'China' article has ridiculous horizontal scrolling [19:43:43] please check [19:44:07] dbrant: I can swipe right to get a full big black screen which is completely blank [19:45:36] thanks Maryana, gonna update it [19:45:46] (03PS1) 10Mhurd: Removed right carets from more menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146856 [19:45:49] brion: ^ [19:46:12] vbamba: yep, I see it too. No idea why, though. [19:46:19] vbamba: dbrant: it's the big map in the sectionAdministrative divisions [19:46:26] YuviPanda: i can't as i'm in the middle of things [19:46:36] i'd pass it to dbrant or bearND [19:46:40] tfinc: ok [19:46:48] I'll just do it in 5mins [19:46:49] (03PS2) 10Mhurd: Removed right carets from more menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146856 [19:46:56] vbamba: well that's why, then! [19:46:58] YuviPanda: but i figured it would be less typing for your hands [19:47:21] tfinc: yeah, mostly less mousing (which is more harmful than typing) [19:47:56] (03CR) 10Brion VIBBER: [C: 032 V: 032] Removed right carets from more menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146856 (owner: 10Mhurd) [19:48:10] yes mhurd! death to right carets :) [19:48:20] moizsyed: done! [19:49:08] bearND: vbamba: I'm actually able to pinch-to-zoom out on that map.... [19:50:08] dbrant: yeah, pinch to zoom out is how i easily found the culprint in this long article [19:50:15] culprit [19:50:24] vbamba: bearND: hmm, should we be able to pinch-to-zoom anymore? [19:51:14] dbrant: yeah, i think we should still keep that [19:51:22] for zooming images [19:52:42] mhurd: I can't find any better prose and Howie didn't know off the top of his head, so I'm going backlog the prose issue for now. [19:52:46] mhurd: Howie is fine with us doing that. [19:52:54] Deskana: cool! [19:55:34] mhurd: thank you removing carets :) [19:55:41] vbamba: np! :) [20:00:11] Deskana: bearND dbrant Android is good to sign off now [20:00:26] \o/ [20:00:31] vbamba: great! :) [20:01:01] And Deskana and I have added two stories in Sprint 36 for Instrumentation of Font Size and 'Strip out table styling for Night mode in Android' [20:01:12] alright! [20:01:57] dbrant: bearND: References Pane is looking good, its much much easier to read now [20:02:18] vbamba: bearND: agreed [20:02:21] Thank you for being patient through the iterations [20:02:42] moizsyed: awjr - story prio time? [20:03:01] Maryana im at the mediawiki core quarterly review - you're leading this one, right? [20:03:11] oh shit, sorry! [20:03:14] totally slipped my mind [20:03:14] :) [20:03:16] np [20:03:34] 3MobileFrontend / 3General/Unknown: Links to other languages on mobile version don't link to mobile version - 10https://bugzilla.wikimedia.org/68063 (10Andre Klapper) [20:04:05] vbamba: Thanks! Let me just take a final look later this afternoon. Don't see any issues, but I think it's prudent for me to check! [20:04:26] (03PS1) 10Mhurd: Ensure alerts don't show when toc is revealed. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146899 [20:04:52] brion: o hai [20:05:36] 3MobileFrontend / 3General/Unknown: Links to other languages on mobile version don't link to mobile version - 10https://bugzilla.wikimedia.org/68063#c3 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Ab5w0Z9S [20:06:35] brion: ^ another small patch [20:06:46] heh [20:07:21] (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks good" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146899 (owner: 10Mhurd) [20:17:07] (03PS1) 10Mhurd: Slight adjustment to alert hiding to ensure fade interrupted. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146900 [20:17:16] brion: ^ one slight tweak :) [20:18:01] (03CR) 10Brion VIBBER: [C: 032 V: 032] Slight adjustment to alert hiding to ensure fade interrupted. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146900 (owner: 10Mhurd) [20:18:05] \o/ [20:18:29] brion: thx1 [20:40:20] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c11 (10Florian) *** Bug 68063 has been marked as a duplicate of this bug. *** [20:40:20] 3MobileFrontend / 3General/Unknown: Links to other languages on mobile version don't link to mobile version - 10https://bugzilla.wikimedia.org/68063#c4 (10Florian) 5NEW>3RESO/DUP See bug https://bugzilla.wikimedia.org/show_bug.cgi?id=66888, too *** This bug has been marked as a duplicate of bug 65047 *** [21:01:13] YuviPanda: I'm going to add creation of a git tag to the beginning of the make-beta script. Any concerns/thoughts? [21:01:22] bearND: nope, sounds good to me. [21:01:29] bearND: can you or dbrant also do the beta release? :) [21:01:48] YuviPanda: yes i can do that [21:01:53] cool, ty [21:01:59] YuviPanda: bearND: sweet [21:02:53] YuviPanda: any thoughts about git tags. Should we use annotated tags? [21:03:00] inded [21:03:02] or even signed ones? [21:03:02] *indeed [21:03:28] annotated then, right [21:04:38] (03PS1) 10Mhurd: Search field clear icon more distinct. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146929 [21:05:17] brion: ^ think this is the last one :) [21:14:00] (03PS1) 10BearND: Change beta script to git tag releases (pushed to gerrit) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146933 [21:15:01] moment mhurd :D [21:17:40] (03CR) 10Brion VIBBER: [C: 032 V: 032] Search field clear icon more distinct. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146929 (owner: 10Mhurd) [21:17:47] brion: woohoo! [21:18:08] brion: cutting build [21:18:30] awesome [21:21:38] (03PS1) 10BearND: Fix icon replacement in beta script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146936 [21:22:42] brion: woohoo build cut! and we’re back below 3MB! :) [21:22:51] awesommmmmme :D [21:23:29] brion: i’d say submit another one to apple… sound ok? [21:25:36] mhurd: probably yeah i’ll double-check with dan shortly :D [21:25:42] brion: yay! [21:25:53] Deskana: cut a build - you should see email shortly [21:26:09] tfinc: ^ [21:26:16] mhurd: :) [21:27:49] tfinc: sent you a couple of drafts :) [21:27:58] YuviPanda: i saw [21:28:02] will respond to later [21:28:06] tfinc: ok, ty [21:28:10] Deskana: Head upstairs? [21:28:35] vbamba: I'm already in the room for something else. :) [21:28:43] vbamba: ...which just finished. [21:29:23] Deskana: when you’ve signed off on the latest build i can resubmit the updated version to apple if that’s ok [21:30:07] brion: I don't have a build yet. mhurd? :) [21:30:40] Deskana: testflight emails can take a few minutes. i haven’t received the email yet either, but others have... [21:31:14] ok im coming [21:34:09] (03PS1) 10Trevor Parscal: Don't add classes to the context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146940 [21:34:51] Deskana: ok i just got the testflight email. [21:36:36] vbamba: moizsyed just cut build [21:36:59] dr0ptp4kt, any problems? [21:37:38] mhurd: yes [21:41:55] * flyingclimber waits for iOS 7.1.2 to install [21:41:57] yurikJerusalem: i'm not sure. a number of pl.zero.wikipedia.orgs came back with a banner when they weren't expected. for example, for 250-99. in practice, vcl won't pass 250-99 for pl.zero.wikipedia.org, but can you think of a reason why that's showing a banner? [21:43:15] dr0ptp4kt, could you try adding your IP to it? [21:43:31] new Android beta build is on https://releases.wikimedia.org/mobile/android/wikipedia/betas/. Anyone would like to test it (besides me) before I push to the store? [21:43:40] yurikJerusalem: to 250-99? [21:43:46] yep [21:44:00] just don't forget to 1) comment, 2) remove :) [21:44:30] yurikJerusalem: sure. there were several other X-CSes that on pl.zero also showed banners unexpectedly. but most of them did not do so. [21:45:32] yurikJerusalem: there shouldn't be any additional side effects upon hitting "Save page", correct? [21:45:37] (for 250-99) [21:45:41] hope not :) [21:45:48] i think it has been long enough :) [21:46:14] ok, try adding yourself and see how it works, i will check if logs started having proxy issues [21:46:17] yurikJerusalem: okay, here it goes [21:46:24] * yurikJerusalem hides [21:46:51] yurikJerusalem: ha! okay, i just hit save. will wait 7 mins [21:47:15] dr0ptp4kt, i think it is even faster now [21:47:46] (03PS1) 10Mhurd: Slightly slower toc toggle animation. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146944 [21:50:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] Slightly slower toc toggle animation. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146944 (owner: 10Mhurd) [21:54:08] (03PS1) 10Mhurd: Fix for random causing flicker. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146945 [21:54:38] mhurd: brion two crashes within my first use of the app. i can't repo yet. what's the best way of getting you those crash reports if i cant' repo? [21:54:58] :( that’s not good [21:55:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for random causing flicker. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146945 (owner: 10Mhurd) [21:57:19] yurikJerusalem: huh, strange. it seems my ip is in 250-99. when i go to ru.zero it's fine. when i go to pl.zero.wikipedia.org it tries to redirect me to pl.zero.wikipedia (no .org) [21:57:53] dr0ptp4kt, that's seems like a bug with my redirector... [21:58:06] i recently added the global var with ".org" [21:58:13] need to fix that... [21:59:39] dr0ptp4kt, any idea how i can replicate that? [21:59:40] locally [22:01:08] yurikJerusalem: not really off the top of my head. i guess you could name your machine with a .org in it or something as a quick hack [22:01:15] dr0ptp4kt, i see the bug [22:02:44] (03PS1) 10Yurik: Fixed incorrect cluster domain suffix [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146948 [22:02:49] dr0ptp4kt, ^ [22:03:52] yurikJerusalem: pulling for quick test [22:04:39] (03CR) 10Dr0ptp4kt: [C: 032] Fixed incorrect cluster domain suffix [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146948 (owner: 10Yurik) [22:04:42] yurikJerusalem: ^ [22:06:56] mhurd, brion: Testing that build I just received. [22:07:34] YuviPanda: dbrant: Deskana tfinc: just pushed new beta to the store [22:07:43] w00t [22:07:48] bearND: can you also email labs-l? [22:07:49] err [22:07:51] mobile-l? [22:07:59] YuviPanda: sure [22:08:07] HELLO LABS, I AM HERE TO TELL YOU ABOUT OUR LORD AND SAVIOUR MOBILE APPS [22:08:15] YuviPanda, dbrant, bearND: And I just signed off on the night mode story! \o/ [22:08:26] :) [22:08:35] 40 point sprint success, woohoo! [22:08:46] Deskana: :D [22:09:50] * MaxSem changes all cards to 40 points just to make Deskana happy [22:10:09] "As a Max, I would like to troll, so that others cry some moar." [22:16:46] brion, mhurd: All iOS stories signed off on, so we're good to (re)submit to Apple. :) [22:17:18] \o/ [22:22:45] yurikJerusalem: not exactly. if i go to zero.wikipedia.org it tries to send me to ru.zero.wikipedia (.org). if i try to go to pl.zero.wikipedia.org it tries to send me to pl.zero.wikipedia (no .org). m.wikipedia.org tries to send me to ru.m.wikipedia (no .org). it seems there may be some stale objects [22:23:10] awjr: does sello run on toollabs? [22:23:16] YuviPanda yeah [22:23:31] YuviPanda i think jon somehow integrated with bugello but i don't know the details [22:23:35] dr0ptp4kt, probably stale :( [22:23:40] * YuviPanda goes to check [22:23:58] * yurikJerusalem hates stale objects [22:24:00] i took a quick look and didn't see a quick/obvious way to make it stop running [22:24:08] awjr: hmm, let me poke [22:24:24] dr0ptp4kt, i wonder how we can make your tests run on beta [22:24:26] YuviPanda only if you have spare cycles :) it hsoudl be easy for jon to take care of [22:24:27] awjr: what was the tool name for bugello? [22:24:32] bugello [22:24:37] dr0ptp4kt, constantly [22:24:40] awjr: yeah, am finished with today for the most part, just doing random stuff [22:24:42] yurikJerusalem: probably with just a little extra thinking :) [22:24:52] we don't do that [22:24:58] awjr: hmm, I see nothing obvious running either, so I'll let Jon take care of it :) [22:24:58] that's for other teams [22:25:16] :) [22:25:35] awjr: heh, I see *nothing* at http://tools.wmflabs.org/?status for bugello, so unsure how that's even working :) [22:26:08] yurikJerusalem: m.wikipedia.org/?cb=2014 also tries to send me to ru.m.wikipedia (no .org). the header suggest there's no caching going on there. is there another block of code handling that redirect? [22:26:35] yurikJerusalem: you'll need to change your cb param to see it's a cache miss [22:26:37] dr0ptp4kt, not really - it could be that ru is handled by wmf13 - i only deployed 12 [22:26:51] YuviPanda i cant even get that page to load [22:26:54] its syncing 13 now [22:26:56] awjr: it takes a while :) [22:27:06] :-| [22:27:37] awjr: toollabs started with what, 5 machines? is now 20+ [22:27:40] ah there we go [22:27:47] awjr: is on my todolist to fix at some point in the future. [22:27:54] YuviPanda im not clear on what that page is showing - is that just top output or something? [22:28:17] if so you'd only see anything about bugello/bingle when the cronjobs run [22:28:19] awjr: it's all the tools running on the grid from all the jobs. [22:28:21] aaah [22:28:21] cron [22:28:22] nevermind :) [22:28:43] yurikJerusalem: k, lemme know once fully sync'd [22:29:19] yurikJerusalem: we probably should add an outbound header that tells us something about the extension rev that generated the page at some point [22:29:54] dr0ptp4kt, done [22:30:29] (03CR) 10Yuvipanda: [C: 04-1] "I don't think it should automatically push, at least not yet. Will mess up both testing, and will also fail if the branch already exists. " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146933 (owner: 10BearND) [22:31:25] (03CR) 10Yuvipanda: [C: 032] Fix icon replacement in beta script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146936 (owner: 10BearND) [22:31:31] yurikJerusalem: m.wikipedia.org/?cb=201407161531 yields Location: http://ru.m.wikipedia/wiki/Special:ZeroRatedMobileAccess (no .org) [22:31:36] bearND: left comments on one of the python patches, merged the other :) [22:31:44] dr0ptp4kt, looking... grr [22:31:52] YuviPanda: thanks [22:32:17] bearND: I'd say get rid of the push for now, and then add a subcommand (with argparse) that'll do the pushing in another patch. That should also check to make sure the tag doesn't already exist [22:33:10] (03Merged) 10jenkins-bot: Fix icon replacement in beta script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146936 (owner: 10BearND) [22:36:29] dr0ptp4kt, the code didn't update on the server for some reason [22:36:36] trying to re-deploy [22:36:40] yurikJerusalem: :( k [22:36:41] YuviPanda: ok [22:37:16] yurikJerusalem: it seems that gerrit didn't merge it [22:37:20] https://gerrit.wikimedia.org/r/#/c/146948/ [22:38:04] yurikJerusalem: want me to force with verified and publish & submit? [22:38:41] dr0ptp4kt, hold on, something is weird with git [22:38:49] git, you git! [22:38:49] asked MaxSem [22:43:26] (03CR) 10Yurik: [C: 032] Fixed incorrect cluster domain suffix [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146948 (owner: 10Yurik) [22:45:10] tfinc: we think we fixed your bug [22:45:12] :D [22:49:03] (03PS1) 10Mhurd: Fix for repeated random taps eventually crashing. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146968 [22:50:25] (03PS2) 10Mhurd: Fix for repeated random taps eventually crashing. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146968 [22:51:57] alright, I'm going to head off [22:51:58] cya guys [22:51:59] * YuviPanda waves [22:54:25] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Seems to improve stability a lot when pushing random over and over \o/ can get through 30-40 before giving up, versus crashing in the 10-1" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146968 (owner: 10Mhurd) [22:55:07] (03PS1) 10Yurik: fixing info bug take 2 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146971 [22:55:19] (03CR) 10Yurik: [C: 032] fixing info bug take 2 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146971 (owner: 10Yurik) [22:55:36] (03CR) 10Yurik: [V: 032] fixing info bug take 2 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146971 (owner: 10Yurik) [22:57:28] (03Abandoned) 10Yurik: Fixed incorrect cluster domain suffix [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/146948 (owner: 10Yurik) [23:01:04] (03PS1) 10Dbrant: Improve compatibility of convert-icons script. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146976 [23:07:43] brion: mhurd: no crashes on random since i installed the new build [23:07:51] awesome :D [23:08:03] tfinc: ya! [23:14:08] dr0ptp4kt, one more time pls - manual [23:14:29] yurikR2: you saying everything's sync'd? or you saying i need to forge my x-cs? [23:14:40] dr0ptp4kt, synced 12 [23:14:53] dr0ptp4kt, .org should work now [23:15:15] m.wikipedia.org/?cb=201407161615 redirected me to correct special page [23:15:57] zero.wikipedia.org/?cb=<...> redirected me to correct special page [23:16:22] excellent [23:16:25] at least that got fixed [23:16:42] pl.zero.wikipedia.org/?cb=<...> redirected me to warning page [23:17:15] dr0ptp4kt thanks for adding your notes for SoS - quick q tho, can i mark any of those cards as done? [23:17:17] yurikR2: english and russian main pages from special: pages on both mdot and zerodot work as well [23:17:31] awjr, yes [23:17:41] dr0ptp4kt cool - all of em? [23:17:50] dr0ptp4kt, ok, i'm syncing 13, pls run test [23:17:51] awjr, sorry for joinng call late. yeah, all of them [23:17:57] dr0ptp4kt, and thanks! [23:18:00] np [23:18:02] yurikR2: is the sync done for 13? [23:22:14] yurikR2: sync done? [23:22:46] yurikR2: nm, i see in ops channel it sync'd. will run test [23:23:34] yurikR2: running [23:23:51] yurikR2: heads up, i may need to re-run, but wanted to try with defaults first [23:25:09] kaldari, I was wondering if there is no easier way of doing https://gerrit.wikimedia.org/r/#/c/139556/ after all desktop does that and I think it's not using any JS, maybe just a different API call? [23:25:54] (03PS2) 10BearND: Change beta script to git tag releases (pushed to gerrit) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146933 [23:26:16] (03PS3) 10BearND: Change beta script to git tag releases [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146933 [23:27:53] dr0ptp4kt, thx [23:28:44] jgonera: Well, the super easy way to do it is to just remove fulltext from the search parameters. The problem with that, however, is that if a user doesn't have Javascript, there's no way for them to get to the fulltext search results. [23:29:36] kaldari, why don't we remove fulltext from the search parameters using JS? [23:29:40] jgonera: Maybe, we could change it dynamically with JS though [23:30:05] yeah [23:31:25] yurikR2: re-running, with cachebusted urls [23:31:42] jgonera: Not sure why I didn't think of that as well. Should be easy enough to change. Although this version doesn't hurt anything in the meantime. [23:31:45] Deskana: awjr Erik needs to reschedule my review to tomorrow and he's asking to schedule over the iteration review for apps. would one of you be willing to take iteration review for me ? [23:32:20] kaldari, yeah, it's just more complicated. I remember having a look at that patch and thinking about this but didn't have time to comment and now I saw it's already merged ;) [23:32:36] dbrant: Ping! Design review time. :) [23:34:07] https://plus.google.com/115576844812998187455/posts/S4qwEkqkMaU "We're running a quick survey to see how many of you actually use the "phone" part of your phone. " [23:34:09] (03PS1) 10Mhurd: More fixes related to the random crash fix. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146983 [23:34:18] brion: ^ [23:42:51] yurikR2: fixed. logging off, time for dinner. [23:43:02] dr0ptp4kt, awesome, thanks!