[00:04:08] (03PS6) 10JGonera: WIP: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 [00:08:38] (03PS7) 10JGonera: WIP: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 [00:15:51] Maryana: I should be done in 15 minutes or so. [00:15:57] Maryana: Maybe less. [00:17:33] Deskana: i want to write up the notes from that interview while they're fresh in my head.. can we finish up tomorrow morning? before the iteration review, maybe? [00:21:57] Maryana: Sure. 10:30? [00:22:13] sounds great [00:22:15] thanks! [00:31:14] Deskana: awjr Erik needs to reschedule my review to tomorrow and he's asking to schedule over the iteration review for apps. would one of you be willing to take iteration review for me ? [00:32:15] awjr: Can you help us? :) [00:33:26] Deskana: i have to run but respond to me in email and let me know either way [00:35:36] Deskana tfinc can you remind me what goes in your 'iteration review'? [00:35:50] i think this might be out of sync: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Development_cycle [00:36:16] or at least meeting names are off [00:36:47] Deskana tfinc and if you didn't see the email, i am happy to do it [00:45:08] (03PS1) 10Mhurd: Killed the Credits carets. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146997 [06:27:04] 3MobileFrontend / 3General/Unknown: Links to other languages on mobile version don't link to mobile version - 10https://bugzilla.wikimedia.org/68063#c5 (10Andyrom75) I'll continue the discussion of ths bug on bug 65047. PS it should be opened a bug on bugzilla mail, beacuse via email I've correctly received... [06:32:49] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c12 (10Andyrom75) I'm not sure why the new bug 68063 has been considered a duplicate of an unconfirmed bug. If this a duplice, this one too should be at least "new". However, let me copy... [06:35:49] 3MobileFrontend / 3General/Unknown: Links to other languages on mobile version don't link to mobile version - 10https://bugzilla.wikimedia.org/68063#c6 (10Florian) (In reply to Andyrom75 from comment #5) > PS it should be opened a bug on bugzilla mail, beacuse via email I've > correctly received this message... [07:06:35] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c13 (10Florian) 5UNCO>3NEW (In reply to Andyrom75 from comment #12) > I'm not sure why the new bug 68063 has been considered a duplicate of an > unconfirmed bug. If this a duplice, th... [11:11:20] 3MobileFrontend / 3General/Unknown: Links to other languages on mobile version don't link to mobile version - 10https://bugzilla.wikimedia.org/68063#c7 (10Andre Klapper) (In reply to Andyrom75 from comment #5) > PS it should be opened a bug on bugzilla mail Different problem, hence different report please w... [11:22:20] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c14 (10Andyrom75) Point 1: you have perfectly described what I've done and what was my expectation. Technical constraint a part I think is reasonable to keep a certain "view mode" if sele... [11:25:27] (03CR) 10Yuvipanda: [C: 032] Change beta script to git tag releases [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146933 (owner: 10BearND) [11:28:52] (03Merged) 10jenkins-bot: Change beta script to git tag releases [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146933 (owner: 10BearND) [14:13:54] 3Wikipedia App / 3Android App: App crashes when long-pressing in WebView - 10https://bugzilla.wikimedia.org/68166 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None Doesn't even show the ACRA dialog. Seems to be SIGABRT thrown from libc. [14:30:21] (03PS1) 10Dbrant: Fix crash when long-pressing in the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147111 [14:34:20] 3Wikipedia App / 3Android App: App crashes when long-pressing in WebView - 10https://bugzilla.wikimedia.org/68166#c1 (10Dmitry Brant) 5NEW>3PATC https://gerrit.wikimedia.org/r/147111 [15:20:00] (03PS1) 10Dduvall: WIP Refactoring mobilefrontend tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 [15:25:01] (03PS1) 10Dbrant: Update external link indicator for Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147117 [15:26:59] (03PS1) 10BearND: Fix NPE parsing mobileview JSON [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147119 (https://bugzilla.wikimedia.org/67807) [15:35:48] (03CR) 10Cmcmahon: [C: 031] "I like the way this is going." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [15:43:36] woo updated ios submission is in review [15:43:50] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c15 (10fireattack) (In reply to Florian from comment #13) Actually, it's like: 1. Open mobile site on mobile browser (no problem) 2. Try to open interlanguage links in "read in another... [15:47:23] (03CR) 10Yuvipanda: [C: 04-1] "night.css updates should go in Extension:MobileApp (same for the link colors patch which I missed, I think?)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147117 (owner: 10Dbrant) [15:49:23] yuvipanda: ah yes, of course [15:49:53] Anyone know anything about https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7650828 ? Error 'No apps can perform this action' when opening an external link [15:52:37] Krenair: no idea :( I may help to know more about his Android version (and whether it's a custom rom, etc). [15:52:49] *It [15:54:31] dbrant, asked [15:56:05] (03CR) 10Cmcmahon: [C: 032] QA make sure watchlist shows correct tab [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146500 (owner: 10Cmcmahon) [15:56:41] (03Merged) 10jenkins-bot: QA make sure watchlist shows correct tab [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146500 (owner: 10Cmcmahon) [16:02:25] (03PS1) 10Brion VIBBER: Put 'action' before 'format' on API parameters to fix app indexing [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/147134 [16:06:42] yuvipanda: https://gerrit.wikimedia.org/r/#/c/147133/ [16:07:49] yuvipanda: so then, where does the app itself get its css files? [16:12:29] (03PS1) 10Dr0ptp4kt: Make zerodot landing page fast and have search. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 [16:13:13] yurikJerusalem: want to try to work your magic on this? ^ [16:13:14] dbrant: there's a make-css-assets script [16:13:23] dbrant: that gets its CSS from betalabs [16:13:33] dr0ptp4kt, looking [16:13:52] once the code for the extension has been merged [16:14:04] dbrant: I completely forgot that I was going to do a hangout on Extension:MobileApp :| [16:14:34] yuvipanda: that's fine! it's a little clearer now [16:14:41] :) ok [16:15:17] yuvipanda: now, our last-updated date in the app is still set to 2019... should that still be the case? [16:15:52] dbrant: so we should reset it once the patches make it to production [16:15:57] (03PS2) 10Dr0ptp4kt: Make zerodot landing page fast and have search. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 [16:16:05] yurikJerusalem: ^ qqq [16:16:13] dbrant: or we can move it to betalabs again, but I'm reluctant to do that considering how unstable it is [16:16:41] dbrant: we can get the style patches SWAT'd so they live on the cluster sooner. I'll add it to the MobileApp hangout thing [16:17:40] yuvipanda: oh i see; since none of the night-mode stuff is in production yet, it would override whatever is in the app? [16:19:32] dbrant: yup [16:19:40] dbrant: err, it would 404 I believe, since that file won't be there [16:19:54] right [16:20:29] heading in to zee office [16:25:42] (03CR) 10Yurik: "a few minor comments, but i will need to talk to you about overall need of this vs what we can do by collaborating with mobile. Wouldn't t" (034 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 (owner: 10Dr0ptp4kt) [16:26:09] yuvipanda: so who reviews patches for MobileApp? [16:29:57] btw, guys, there are still a lot of tickets in the OTRS queue for you [16:30:01] I have not been responding to everything [16:30:14] Please don't just ignore them [16:41:37] 3Wikipedia App / 3Android App: NPEs from android.support.v7.app.ActionBarImplICS.getThemedConte xt in 2.0-beta-2014-07-16 - 10https://bugzilla.wikimedia.org/68169 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None E.g.: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7674117 ht... [16:42:53] 3Wikipedia App / 3Android App: NPEs from android.support.v7.app.ActionBarImplICS.getThemedContext in 2.0-beta-2014-07-16 - 10https://bugzilla.wikimedia.org/68169#c1 (10Alex Monk) User comments are about highlighting and lots of long presses on text [16:44:06] 3Wikipedia App / 3Android App: NPEs from android.support.v7.app.ActionBarImplICS.getThemedContext in 2.0-beta-2014-07-16 - 10https://bugzilla.wikimedia.org/68169#c2 (10Alex Monk) Possibly a dupe of bug 68166 [16:47:07] 3Wikipedia App / 3Android App: NPE from editing.EditHandler.onMessage - 10https://bugzilla.wikimedia.org/68171 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None *Might* have been fixed in the latest beta, but: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7665137 https://tic... [16:47:34] "THANK YOU THANK YOU THANK YOU!!! The dark theme is back!! Also I am now able to increase the font size!! That and the overall performance of this app is 10 times better then before. Thank you so much! I really needed that dark theme and large font and the developers of this app definitely came though for me and all of us. That 5 stars you see above is doubled so this app got 10 stars from me. Thank You! " [16:48:56] that from google play? [16:49:50] 3Wikipedia App / 3Android App: NPE from editing.EditHandler.onMessage - 10https://bugzilla.wikimedia.org/68171#c1 (10Alex Monk) Something about going back to previous viewed pages. History? Or maybe just browsing with the back button [16:51:08] (03PS6) 10Paladox: Update jquery from 1.7.2 to 1.11.1 [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/140939 [16:51:15] ragesoss, we have a font size changer now? [16:51:22] (03PS7) 10Paladox: Updating certificate [apps/win8/wikipedia] - 10https://gerrit.wikimedia.org/r/141060 [16:51:32] Krenair: in the beta, yes. [16:54:19] 3Wikipedia App / 3Android App: Font size changer - 10https://bugzilla.wikimedia.org/67102#c5 (10Alex Monk) 5NEW>3RESO/FIX I didn't even realise this was done (and released to beta) until ragesoss mentioned it in #wikimedia-mobile [17:06:33] yuvipanda: so who reviews patches for MobileApp? [17:06:48] dbrant|brb: ah, mostly brion or legoktm (or anyone else who usually does MW stuff) [17:27:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] More fixes related to the random crash fix. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146983 (owner: 10Mhurd) [17:27:59] (03CR) 10Brion VIBBER: [C: 032 V: 032] Killed the Credits carets. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/146997 (owner: 10Mhurd) [17:29:21] i wish mac-on-mac virtualization had better gpu support. parallels and vmware fusion both kinda suck with osx guests [17:29:28] but at least i can test old safaris [17:30:40] “The status for the following app has changed to In Review.” [17:31:42] MaxSem see kaldari around? [17:32:23] :) [17:33:35] Is https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7668736 related to https://bugzilla.wikimedia.org/show_bug.cgi?id=67736 ? [17:38:27] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7649313 - question in German, if anyone around speaks it that would be good [17:38:57] * yuvipanda clears some OTRS tickets [17:39:37] dbrant|brb: hmm, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7668736&OTRSAgentInterface=10bfa7295b5a995ee9f63694268e5248eb looks like unbalanced registration... [17:40:59] Krenair: my german’s a little rusty but it looks like they’re asking if it’s ok to use just the beta version or if they need “the older version” also (the…. non-beta one?) [17:41:06] yuvipanda: I think that's been taken care of by one of my patches. [17:42:52] 3Wikipedia App / 3Android App: Some wide tables broken - 10https://bugzilla.wikimedia.org/68177 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None For example, on the [[en:Global cities]] article, some tables just disappear off the edge of the screen and you can't see the rest. The columns which remain a... [17:44:12] awjr: soooo, according to james, there's not actually a deployment window on the 7th -- or at all during wikimania [17:44:48] that's the bad news. the good news is that the critical blocker bugs are fixed on VE's end, so we might actually be able to merge VE to stable next week. [17:44:49] so we need to push it out one more week? [17:45:05] ahha [17:45:06] ok [17:45:18] so Maryana can we stick with original plan and fall back on waiting til after wiimania? [17:45:27] yeah, that's what i'm thinking [17:45:42] i'll add a card to trello for merging VE to stable [17:46:29] armageddon's back on, baby! [17:46:31] :D [17:48:07] awjr: also, i'm going to archive this guy: https://trello.com/c/8ZW72dGm/21-spike-determine-if-we-need-to-specify-which-tablet-devices-will-be-able-to-use-ve [17:48:27] cool Maryana , all sounds good [17:48:30] yay armageddon! [17:48:39] since we're not pushing it out by default to any users, we'll just be able to investigate androidy things when it's live in prod [17:48:50] yeah that sounds great [17:50:23] dbrant|brb: yeah, I think so [17:51:46] yuvipanda: it's kind of difficult to tell which reports are "new", since we've made so many patches that haven't been released yet. [17:52:13] (03CR) 10Dr0ptp4kt: "Update coming shortly. I'm unsure of whether the (to be sure, functional) responsive web design / progressive enhancement / graceful degra" (033 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 (owner: 10Dr0ptp4kt) [17:52:51] Krenair: You still need someone who can speak german? It's my native language :) [17:53:05] can you view and respond to that ticket? [17:53:52] dbrant|brb: Have a question for you when you are back [17:53:55] Krenair: Sorry, no otrs account for now, application is pending. But if it's possible to sent me a unpersonalized version?! :) [17:54:05] vbamba: back! [17:54:12] Not from a language I don't understand, sorry [17:54:35] Krenair: It's ok :) Better to ask as to be quite :P [17:54:48] (03PS3) 10Dr0ptp4kt: Make zerodot landing page fast and have search. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 [17:55:12] FlorianSW, I do notice that you have not requested mobile queue access on http://meta.wikimedia.org/wiki/OTRS/Volunteering#Florianschmidtwelzow [17:55:22] awjr, you're not in SF, right? I'm asking because there's a room assigned to our meeting [17:55:32] So when you do get an otrs account, you still won't be able to see/respond to the ticket. [17:55:37] jgonera correct - i reserved a room for you in case you wanted one ;) [17:56:11] (03PS1) 10Kaldari: Simpler and more reliable solution for bug 66506 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147161 (https://bugzilla.wikimedia.org/66506) [17:56:13] Krenair: I don't know, that there is a mobile queue (not in this list: https://meta.wikimedia.org/wiki/OTRS#Queues) [17:57:17] jgonera: https://gerrit.wikimedia.org/r/#/c/147161/ [17:59:04] dbrant: Quick Question about Android TOC [17:59:12] vbamba: yep [17:59:36] (03CR) 10Florianschmidtwelzow: [C: 031] "Oh :) That's much easier and better, i don't see this field." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147161 (https://bugzilla.wikimedia.org/66506) (owner: 10Kaldari) [17:59:47] oh nvm, figured it out [18:00:52] (03CR) 10Kaldari: "FlorianSW: Yeah, I don't know why I didn't think of this before :P" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147161 (https://bugzilla.wikimedia.org/66506) (owner: 10Kaldari) [18:00:58] ergh sorry jgonera gonna be a min [18:01:03] FlorianSW, hm... we should probably publish the otrs-wiki Queues list on meta... RD: ^ [18:01:04] (maybe it's there and I just forgot about it though) [18:01:12] awjr, ok [18:01:29] yurikJerusalem: ping [18:08:50] 3Wikipedia App / 3Android App: NPE from editing.EditHandler.onMessage - 10https://bugzilla.wikimedia.org/68171#c2 (10Bernd Sitzmann) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7586030 is different from the other ones but it's a very old one, too, from end of April. We can igno... [18:08:51] (03PS1) 10Dbrant: Add progress indicator when changing font size. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147164 [18:08:56] (03PS1) 10BearND: Fix NPE from editing.EditHandler.onMessage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147165 (https://bugzilla.wikimedia.org/68171) [18:11:04] 3Wikipedia App / 3Android App: NPE from editing.EditHandler.onMessage - 10https://bugzilla.wikimedia.org/68171#c4 (10Alex Monk) (In reply to Bernd Sitzmann from comment #2) > https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom; > TicketID=7586030 > is different from the other ones but it's a ve... [18:15:43] (03CR) 10JGonera: [C: 04-1] "Correct me if I'm wrong, but won't this disable full text search for the "Search within pages" button? I think we need to readd this field" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147161 (https://bugzilla.wikimedia.org/66506) (owner: 10Kaldari) [18:17:44] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Okay. See inline comment." (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 (owner: 10Dr0ptp4kt) [18:22:48] FlorianSW, so apparently you're not allowed to apply for the mobile queue [18:23:37] Krenair: You mean? [18:23:41] you can only apply for the queues listed publicly, the others require an invite/appointment [18:23:49] which is handled separately [18:24:16] ah, ok :) [18:24:45] So if mobile approve you for the queue, that's fine. It will give you an account but not access to info-en/info-de, which you'll still need to wait on the public process to get added [18:25:08] ok [18:26:47] dbrant, btw there was a reply to https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7650828 [18:27:56] Krenair: well that's quite odd... [18:29:06] awjr: thanks for jumping in for the iteration review. do you need anything else from me ? [18:29:21] tfinc nah, i think we're good :) [18:30:06] FlorianSW: and yuvipanda is the one to talk to about that. [18:30:39] (03CR) 10Siebrand: Shorter menu item for Font/theme settings (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146384 (owner: 10BearND) [18:30:39] hmm? I can give people access? [18:30:58] dbrant: tfinc hangouts acting up, be there in a minute [18:32:38] yuvipanda mtg? [18:32:59] awjr: hangouts crashing browser, minute [18:33:32] np yuvipanda , still waiting on dan too [18:33:53] yuvipanda, no, but you can tell RD to give people access [18:34:05] RD: do give FlorianSW access! :) [18:34:30] thx yuvipanda :) [18:35:19] (03PS2) 10Kaldari: Simpler and more reliable solution for bug 66506 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147161 (https://bugzilla.wikimedia.org/66506) [18:36:46] https://trello.com/c/zHmmH2xT/74-design [18:37:00] lol [18:37:23] I don't have time atm but yuvipanda - can you put a note on the app on Meta? [18:37:34] I or another admin should be able to get to it later today [18:37:40] sure. FlorianSW can you give me a link to the application? [18:38:03] RD: thanks anyway :) yuvipanda: https://meta.wikimedia.org/wiki/OTRS/Volunteering#Florianschmidtwelzow [18:42:00] http://hatjitsu.wmflabs.org/75686 [18:42:24] http://hatjitsu.wmflabs.org/75686 [18:42:26] mhurd ^ [18:46:53] mhurd: brion: JS code for collecting nearby references: https://gerrit.wikimedia.org/r/#/c/146086/ [18:48:46] (03PS3) 10Kaldari: Simpler and more reliable solution for bug 66506 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147161 (https://bugzilla.wikimedia.org/66506) [18:49:46] (03PS4) 10Kaldari: Simpler and more reliable solution for bug 66506 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147161 (https://bugzilla.wikimedia.org/66506) [18:53:26] dbrant: bearND do bring up any issues you see with potential issues with the cards. I'm mostly going to be silenter :) [18:57:47] awjr: this is *before* splitting cards into iOS and Android, so this is way over 28 :) [19:27:08] (03PS1) 10Kaldari: For now, always default to source editor on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147200 [19:29:35] dbrant: and bearND|food - when do you guys leave for Wikimania? [19:30:06] vbamba: I do not :( [19:30:21] oh me neither [19:30:22] :) [19:30:27] I mean :( [19:30:32] its quite sad [19:30:37] it is... [19:31:21] is bearND|food going? [19:33:22] vba: I don't believe so [19:33:30] * vbamba [19:33:46] I see, ok. [19:34:10] we're too new :) [19:36:36] 3MobileFrontend / 3beta: Talk overlay conflicting with tap event? - 10https://bugzilla.wikimedia.org/64105#c2 (10Florian) *** Bug 67442 has been marked as a duplicate of this bug. *** [19:36:36] 3MobileFrontend / 3beta: MobileFrontend displaying both page and discussion when a talk is opened and closed - 10https://bugzilla.wikimedia.org/67442#c3 (10Florian) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 64105 *** [19:37:41] (03PS2) 10Florianschmidtwelzow: Show talk button only when JS enabled or talk page not empty [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145411 (https://bugzilla.wikimedia.org/67819) [19:50:58] vbamba: dbrant|brb is correct: I'm not going either; too new [20:03:18] brion, mhurd: So we submitted the follow-up build, right? [20:03:20] brion, mhurd: Just making sure I shouldn't panic about that "developer rejected" email I got. [20:03:26] Deskana: true [20:03:30] Deskana: no panic [20:03:31] :) [20:04:35] 3Wikipedia App / 3Android App: Some wide tables broken - 10https://bugzilla.wikimedia.org/68177#c1 (10Brion Vibber) There's some scary inline style usage on these:
...... [20:04:35] Deskana: yeah :) [20:04:49] that just means i canceled the first one and submitted the second :) [20:04:55] last update from this morning is the new one is ‘in review' [20:05:35] hey guys when you going to move MobileFrontend to Mantle? [20:05:41] ^ jgonera kaldari|2 [20:05:59] Also I need a quick merge from one of you on https://gerrit.wikimedia.org/r/142281 for some documentation changes [20:07:55] (03CR) 10Yuvipanda: [C: 032] Fix NPE from editing.EditHandler.onMessage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147165 (https://bugzilla.wikimedia.org/68171) (owner: 10BearND) [20:08:47] (03CR) 10Yuvipanda: [C: 032] "This should theoretically never happen, but oh well. Defense in depth is good :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147119 (https://bugzilla.wikimedia.org/67807) (owner: 10BearND) [20:09:30] (03PS2) 10Yuvipanda: Improve compatibility of convert-icons script. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146976 (owner: 10Dbrant) [20:09:42] dbrant|brb: did you test ^ on Windows? [20:09:58] yuvipanda: yes! it's working [20:10:01] (03Merged) 10jenkins-bot: Fix NPE from editing.EditHandler.onMessage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147165 (https://bugzilla.wikimedia.org/68171) (owner: 10BearND) [20:10:05] (03Merged) 10jenkins-bot: Fix NPE parsing mobileview JSON [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147119 (https://bugzilla.wikimedia.org/67807) (owner: 10BearND) [20:10:06] dbrant|brb: hmm, fails for me on OS X [20:10:12] with [20:10:16] dyld: Library not loaded: /usr/local/lib/libpng15.15.dylib [20:10:16] Referenced from: /usr/local/bin/rsvg-convert [20:10:16] Reason: image not found [20:10:18] · cc_logo.noflip.svg [20:10:20] for all images [20:10:40] library not loaded wtf? [20:10:49] dbrant|brb: hmm, that happens to me on master as well [20:10:53] something fucked up on my end :| [20:10:56] yuvipanda: did your rsvg instance get out of sync with your libraries [20:10:58] homebrew or what? [20:11:01] that's possible [20:11:04] brion: can you test https://gerrit.wikimedia.org/r/#/c/146976/1 [20:11:13] sure lemme pull it up [20:11:42] brion: thanks! feel free to +2 after that [20:11:50] yuvipanda: dbrant|brb: probably should also update the README file about the convert icon script [20:11:55] right [20:11:59] yep! [20:12:37] yuvipanda: interestingly i see the same ! [20:12:40] weeeeeeird [20:12:41] brion: hah! [20:12:46] brion: brew fucked up? [20:13:00] looks ok, if i revert to master it runs [20:13:05] lemme check the diff [20:14:49] hm, ok [20:14:58] I'm wondering if there are path differences, but that doesn't seem to be the case [20:15:32] dbrant|brb: bearND Deskana I'm going to take an early night to try fix my sleep cycle. Anything you guys need from me before that? [20:15:45] don't think so [20:17:28] yuvipanda: i'm good [20:18:32] alright then, I'm off [20:25:44] well i’m baffled by that Popen thingm [20:25:47] it looks legit enough [20:26:06] waaaaaait a minute [20:26:14] i have /usr/local/lib/libpng16.16.dylib [20:26:15] O_O [20:29:15] YuviPanda|zzzzz: try ‘brew reinstall librsvg’, that gets it working for me [20:29:35] 3Wikipedia App / 3Android App: NPEs from page.PageViewFragment.commonSectionFetchOnCatch - 10https://bugzilla.wikimedia.org/67807#c4 (10Alex Monk) 5PATC>3RESO/FIX Should be fixed now, I think [20:30:21] 3Wikipedia App / 3Android App: NPE from editing.EditHandler.onMessage - 10https://bugzilla.wikimedia.org/68171#c6 (10Alex Monk) 5PATC>3RESO/FIX Should be fixed now [20:30:42] (03CR) 10Brion VIBBER: "Note that Yuvi and I saw this update causing a weird failure -- I fixed it on mine with 'brew update' and 'brew reinstall librsvg' -- it l" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146976 (owner: 10Dbrant) [20:33:05] 3Wikipedia App / 3Android App: NPEs from android.support.v7.app.ActionBarImplICS.getThemedContext in 2.0-beta-2014-07-16 - 10https://bugzilla.wikimedia.org/68169 (10Alex Monk) [20:33:06] 3Wikipedia App / 3Android App: App crashes when long-pressing in WebView - 10https://bugzilla.wikimedia.org/68166 (10Alex Monk) [20:34:22] (03CR) 10Florianschmidtwelzow: [C: 031] "All search functionallity (if i don't forget one) works with this + the direct redirect to a match :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147161 (https://bugzilla.wikimedia.org/66506) (owner: 10Kaldari) [20:37:38] jdlrobson didja see my email about selello? [20:57:08] jdlrobson, you previously prepared some patches for moving MF to Mantle, are they up-to-date? [21:26:32] (03PS1) 10Brion VIBBER: Work in progress: EL updates for saved pages [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147311 [21:27:18] (03PS1) 10Brion VIBBER: Updated bits URLs in base CSS [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147313 [21:27:34] (03CR) 10Brion VIBBER: [C: 032 V: 032] Updated bits URLs in base CSS [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147313 (owner: 10Brion VIBBER) [21:27:51] (03PS2) 10Brion VIBBER: Work in progress: EL updates for saved pages [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147311 [21:30:02] dbrant|brb: please ping me when you get back [21:37:48] (03PS4) 10Dr0ptp4kt: Make zerodot landing page fast and have search. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 [21:38:14] kaldari|2: yo [21:38:31] can we get those colors in the style guide somehow on a colors page? [21:40:42] (03CR) 10Dr0ptp4kt: "Updated commit message." (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 (owner: 10Dr0ptp4kt) [21:41:49] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 (owner: 10Dr0ptp4kt) [21:47:37] 3Wikipedia App / 3Android App: Following a link during page save operation marks second page as saved in menu - 10https://bugzilla.wikimedia.org/68192 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: * Load 'Cricket' article in English * Hit 'Save' in menu * Quickly click any li... [21:54:45] (03PS1) 10Jdlrobson: Don't render page actions when none exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147324 [21:56:44] (03CR) 10Jforrester: [C: 032] Don't add classes to the context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146940 (owner: 10Trevor Parscal) [21:57:22] (03Merged) 10jenkins-bot: Don't add classes to the context [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146940 (owner: 10Trevor Parscal) [21:58:28] brion: is the updated binary perhaps in review already? [21:58:50] mhurd: it is [21:59:52] brion: cool - seems to be much faster going from “awaiting review” to “in review” that it used to [22:00:06] maybe we’re just special :D [22:05:46] dbrant: you there? [22:05:55] vbamba: yep! [22:12:06] brion: i may take off a bit early [22:12:12] spiff [22:12:33] mhurd: nooooo [22:12:43] just kidding - you need to get some rest [22:13:17] dbrant|brb: For Android Styling items - Can we just use a white overlay (The default that shows up when you hit share on any app) [22:14:07] vbamba: sorry, my connectivity is not so good at the moment; did you ask something? [22:14:55] dbrant: can you do a quick hangout? [22:14:57] 5 minutes? [22:15:32] I can send you an email with some screenshots and my questions for Sprint 36 if you cant get on hangout [22:15:35] what do you prefer? [22:16:31] ok, nvm, i'm emailing you. [22:27:57] (03CR) 10Jdlrobson: "jgonera can you elaborate what that would look like? I'm not to familiar with how maintenance scripts work in core..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) (owner: 10Jdlrobson) [22:29:05] (03PS1) 10Kaldari: Adding mobile.loggingSchemas dependency to mobile.special.uploads.scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147333 (https://bugzilla.wikimedia.org/68009) [22:34:37] (03PS3) 10Brion VIBBER: Work in progress: EL updates for saved pages [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147311 [22:41:08] (03PS1) 10Kaldari: Hygiene: Some clean-up of mobile Resources.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147340 [22:52:50] 3MobileFrontend / 3General/Unknown: MobileFrontend: VisualEditor loads without a cursor due to blurring of all CE elements - 10https://bugzilla.wikimedia.org/57177#c5 (10Ryan Kaldari) 5ASSI>3RESO/INV According to Juliusz this is on purpose as tablets require an actual tap to activate the virtual keyboard. [23:05:39] dbrant|brb: bearND I Just sent you an email for signoff on Android Specifics for Sprint 36 [23:11:38] jgonera: kaldari|2 - do you have any specific requests for more test devices? [23:11:47] ipads? iphones? androids of some kind? [23:11:53] google glass..? ;) [23:12:02] depends if we can use design's devices or not [23:12:10] assume you can't [23:12:12] if we can, then I see no reason to spend money on more [23:12:16] Maryana: sort of... [23:12:31] Maryana, why should I assume that? did Jared say that? [23:12:35] well, assume design will need to use those devices, and also that the design team is growing [23:12:59] then I guess one new retina iPad wouldn't hurt [23:13:14] ok - how about iphones? [23:13:15] also, did tfinc got that iPhone 4 unlocked? [23:13:21] not sure [23:13:44] I guess we could get an iPhone 5 anyway [23:14:04] or something similar, is there an iPod with specs similar to iPhone 5> [23:14:05] ? [23:14:07] you can have my old 4 when i finally upgrade to a 5 :) [23:14:22] Maryana, when will that happen? [23:14:30] when i'm not lazy [23:14:42] or if you email ryan and tell him to do it for my birthday :D [23:16:34] vbamba: checking out the design you just sent. So the article issues popup is a dialog, right? We don't need that extra whitespace at the bottom of it, I imagine. [23:17:05] every time I want to test on mobile chrome for example, I have to sort though 5 different identical looking samsung phones, find one that isn't dead (or charge one otherwise), set it up from scratch (since they are always wiped), register my google account, download and install chrome from Google Play, try to get wi-fi working, test everything, and then re-wipe the phone because I can't figure... [23:17:21] bearND: I dont know how many templates might be there [23:17:26] some pages have 1 some have like 10 [23:17:43] out any other way to remove my person google account from android. It would be awesome if there was one android phone that was always kept up to date and changed and had all the browsers installed and didn't require anyone's personal data. [23:17:45] vbamba: the list needs to be scrollable [23:17:54] its totally fine if you want to clip the whitespace based on the content. [23:18:08] bearND: - correct [23:18:15] thats why I made it a full length overlay [23:18:22] Maryana: otherwise the entire process takes half an hour or more [23:18:48] vbamba: ok. should there be an affordance for dismissing the dialog? [23:19:03] kaldari|2: duly noted [23:19:12] Maryana: that probably doesn't require buying a new device though :) [23:19:30] just wanted to take the opportunity to ask for it :) [23:19:51] yeah, but it wouldn't be such a problem if people didn't jack them from the device cabinet to use as their personal test device [23:19:55] self included ;) [23:20:10] Most apps dont have an affordance for dismissing the dialogue - except hitting the hardware back button [23:20:23] Im ok with staying consistent there for now [23:20:58] vbamba: that's fine. We can also make the dialog cancellable if one taps outside the area (that's actually the default behavior) [23:22:29] vbamba: All we need in terms of assets is the circled flag icon. I assume you'll send the svg for this [23:23:13] I will provide SVG's for the flag [23:23:27] Is the search layout reusable here - type size/ column width etc [23:23:43] vbamba: and maybe tell us the color(s) [light and dark mode] for the box around the similar titles button [23:23:59] Or do you need a layout spec for the columns in the overlay (specific to page issues only) [23:24:16] oh ya! we need Night Mode also for this. Will Provide that. [23:27:03] (03PS1) 10Kaldari: Removing random and keep going experimental features from mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147345 [23:27:15] bearND: Other than Night mode are we good? [23:27:42] Night Mode values will be consistent with TOC or Reference Pane - nothing new there [23:27:47] But I will include it in the spec [23:30:26] vbamba: probably should rename the title to Page issues. Not using the word article anymore. [23:31:41] Are we consistently using Page everywhere? [23:32:17] bearND: Can I make the changes and upload the files to trello? [23:32:19] vbamba: ok uploading those .psds to google drive, will share the folder with you [23:32:26] Is it mostly signed off on your end? [23:32:33] thanks brion! [23:33:16] ok should be a link to doc in your email [23:33:52] vbamba, ping for Hovercards? (And is Dan around?) [23:34:16] quiddity: I think Dan is caught up with other stuff [23:34:25] Unless settings is reviewed, there is nothing to disucss [23:34:28] am i right? [23:34:32] vbamba:We're using pages almost everywhere, with a very small number of exceptions [23:34:32] I cancelled the meeting [23:34:44] bearND: ok Pages, not articles [23:35:13] brion: Can you also send me the text content from the page? [23:35:19] or show me tomorrow maybe? [23:36:22] vbamba: sure i’ll drop in a pdf printout :) [23:37:31] vbamba, ah, I think the calendar problem, is because we all have disconnected entries. We should ask Dan to recreate the meeting, so that we all share the same item, and if a week's meeting gets cancelled, we all know. [23:38:08] vbamba: we probably need multiple column widths in dp depending on device width but we can figure that one out later [23:39:10] vbamba, On Hovercards, the only thing I wanted to mention, was the request I left for you on the trello card. Hopefully you can take a look at that today or tomorrow. :) [23:39:17] ttfn :) [23:42:11] vbamba: should we use the same blue box as we use for editing ("How did you improve the page") for the similar titles button? [same color/same text size] [23:44:21] bearND: - Yeah that makes sense for consistency [23:44:44] brion: Thanks - pdf will be useful! [23:44:57] quiddity: Something about Flipping? [23:45:05] quiddity: Yes - Will take a look [23:45:12] Settings hasnt been merged yet, has it? [23:45:26] correct. still no reviewer.. :< [23:46:52] vbamba: once you've made the changes you can add that to the Trello card so dbrant|brb is also in the loop [23:48:18] Ok, I just sent you updates [23:48:31] bearND: dbrant|brb - I just emailed you new shiny specs [23:49:27] brion: Got the PDF! Thank You So much!