[00:11:58] (03PS8) 10JGonera: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) [00:13:59] (03PS9) 10JGonera: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) [00:32:27] (03PS10) 10JGonera: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) [00:37:52] vbamba1: bearND: sorry sorry, I was in a place with really bad connectivity... I'm reading through all the stuff now! [01:08:32] (03CR) 10Kaldari: [C: 04-1] "I tested this out and it seems to work fine. There is still one difference from desktop, however. While desktop strips any tags or markup " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [01:51:21] (03PS5) 10JGonera: Simpler and more reliable solution for bug 66506 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147161 (https://bugzilla.wikimedia.org/66506) (owner: 10Kaldari) [01:52:36] (03CR) 10JGonera: [C: 032] Simpler and more reliable solution for bug 66506 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147161 (https://bugzilla.wikimedia.org/66506) (owner: 10Kaldari) [01:53:11] (03Merged) 10jenkins-bot: Simpler and more reliable solution for bug 66506 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147161 (https://bugzilla.wikimedia.org/66506) (owner: 10Kaldari) [04:18:54] (03PS1) 10BearND: Codestyle: Category Coding (tests) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147366 [04:18:56] (03PS1) 10BearND: Codestyle: Category Coding (some Utils) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147367 [04:18:58] (03PS1) 10BearND: Codestyle: Category Design (some in App) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147368 [04:22:49] 3MobileFrontend / 3Feature requests: Go directly to an article if we have an exact search match - 10https://bugzilla.wikimedia.org/66506 (10Florian) 5PATC>3RESO/FIX [05:07:51] MobileApp extension doesn't go to this channel? o.O [12:10:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147345 (owner: 10Kaldari) [14:45:10] bearND: I think we may want to release an update to Beta today... the long-press bug seems to be gaining notoriety. Would you agree? [14:50:15] dbrant: yes, i agree [14:50:50] dbrant: let's get some more of your patches merged first [14:52:30] (03CR) 10Dbrant: "That's pretty weird... could Popen somehow be using a different environment than the previous "sh"?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146976 (owner: 10Dbrant) [14:54:11] (03PS2) 10BearND: Add progress indicator when changing font size. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147164 (owner: 10Dbrant) [14:55:22] bearND: ^ I was kind of on-the-fence about implementing it that way. Let me know if you think it's too hacky. [14:56:00] bearND: it does seem to be the only way of accomplishing the behavior we're looking for. [14:57:41] dbrant: I think it would be nicer to have a horizontal progress bar at the top of the dialog, but that could be a bit harder to implement and therefore come later. The location of the circular progress bar seems to be where my thumb usually hovers. [14:58:07] dbrant: for now I think it's good enough [14:58:37] dbrant: maybe add indentation to the layout file [14:58:53] bearND: I was a little worried about the WebView firing a Bus event every time it invalidates... but it doesn't seem to affect performance. [14:59:52] bearND: ok, i can update the patch with indentation. anything else? [15:01:04] dbrant: nothing else [15:01:35] dbrant: the main thing is to disable the buttons but the progress bar is a nice bonus [15:09:26] (03PS3) 10Dbrant: Add progress indicator when changing font size. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147164 [15:14:00] (03PS2) 10Dbrant: Fix crash when long-pressing in the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147111 [15:14:10] (03CR) 10BearND: [C: 032] Add progress indicator when changing font size. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147164 (owner: 10Dbrant) [15:14:29] (03Merged) 10jenkins-bot: Add progress indicator when changing font size. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147164 (owner: 10Dbrant) [15:15:29] dbrant: i'm going to rebase it again since the other patch got merged [15:15:39] bearND: lol right [15:15:40] (03PS3) 10BearND: Fix crash when long-pressing in the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147111 (owner: 10Dbrant) [15:16:54] (03CR) 10BearND: [C: 032] Fix crash when long-pressing in the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147111 (owner: 10Dbrant) [15:17:14] (03Merged) 10jenkins-bot: Fix crash when long-pressing in the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147111 (owner: 10Dbrant) [15:18:00] dbrant: for https://gerrit.wikimedia.org/r/#/c/147117/ I thought you had an updated png file instead of the css [15:19:04] dbrant: or is that what ended up in the background-image url? [15:19:43] bearND: right, the PNG gets embedded into the CSS. But the "real" patch is in MobileApp: https://gerrit.wikimedia.org/r/#/c/147133/ [15:19:59] dbrant: why did you change some of the colors in the css? [15:21:06] bearND: that was per Vibha's design: change all table backgrounds to black, and table borders the same color as our native borders. [15:21:16] dbrant: ah, i see [15:22:02] dbrant: so, for https://gerrit.wikimedia.org/r/#/c/147133/, we need to wait until brion reviews it? How do we get it into our app then? [15:22:12] * brion looks up [15:22:23] ah mobileapp [15:22:36] (03CR) 10Cmcmahon: [C: 032] QA: Fixed TypeError when MEDIAWIKI_USER variable is not set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146057 (owner: 10Zfilipin) [15:22:38] bearND: right, we'll need to wait for the MobileApp patch to get merged, then run the "make-css-assets" in our repo, which pulls the CSS assets from betalabs, then merge that. [15:23:09] i can merge it but it might have to get pushed live before the app picks it up [15:23:19] (03Merged) 10jenkins-bot: QA: Fixed TypeError when MEDIAWIKI_USER variable is not set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146057 (owner: 10Zfilipin) [15:23:22] yuvi or max would know that process better these days :) [15:23:52] brion: ah, I thought that the act of merging it automatically makes it live on betalabs? [15:24:02] dbrant: looks like the less file has tabs instead of spaces [15:24:10] mmm, i think they do go automatically to betalabs yeah, but not sure how long it takes [15:24:21] are you still fetching from betalabs or from production cluster though? [15:24:33] or is that something that switches automatically on the production build [15:24:35] brion: I think we're fetching from production [15:24:41] (03PS2) 10Cmcmahon: QA: use API to protect page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146328 [15:24:42] brion: for our internal update script, we update from betalabs. [15:24:54] spiff [15:24:57] ok lemme test real quick [15:25:04] within the live app, we update from production [15:25:57] bearND: brion: ah damn it, let me update with spaces, not tabs! (I was using a different editor) [15:26:02] hehe [15:27:41] brion: updated. [15:28:56] dbrant: so, adding the /* @embed */ comment to the less file makes it embed the image to the css? [15:29:50] bearND: yep! it's a nifty feature of ResourceLoader: https://www.mediawiki.org/wiki/ResourceLoader/Features#Embedding [15:29:52] dbrant: I see you have also an RTL variant for the png but it's not used in the less file AFAICS [15:30:13] bearND: RL automatically flips if -ltr suffix found [15:30:31] bearND: that's also automatic, purely because the filename contains "-ltr" [15:30:45] add dir=rtl to the load.php URL and I can confirm it switches which file it embeds :D [15:31:10] bearND: (this was all new to me, too) lol [15:31:23] mediawiki’s resourceloader is maaaaaaaaagic :) [15:31:24] brion: dbrant: cool :) [15:31:30] ok +2’d [15:31:47] brion: thx [15:34:45] (03PS3) 10Cmcmahon: QA: use API to protect page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146328 [15:35:08] (03CR) 10Zfilipin: [C: 032] QA: use API to protect page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146328 (owner: 10Cmcmahon) [15:36:11] (03Merged) 10jenkins-bot: QA: use API to protect page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146328 (owner: 10Cmcmahon) [15:36:22] dbrant, bearND: I notice that styling of inline code samples is broken again in the app. [15:36:57] ragesoss: hmm... screenshot? (or example page?) [15:37:08] [[Python]] [15:37:28] [[Python (programming language)]] rather. [15:37:45] in the Expressions section, for example. [15:39:41] ragesoss: ah yes, are you referring to all the "borders" around the code? [15:39:47] yes. [15:39:57] I remember that from a while ago, but I thought it had been fixed. [15:40:09] maybe I misremember, and just haven't seen it again until now. [15:40:42] ragesoss: hmm, i see the same on MF [15:41:06] ragesoss: not sure what that's about... I haven't dealt much with the page styling. And yes, it's present on MF, too. [15:41:50] I think I filed a bug a while back, maybe against MF. I'll try to dig it up. [15:42:48] ragesoss: looks like MF has more problems. On the [[China]] page most images are broken [15:43:17] ok, not most but the first ones [15:44:59] you mean in the infobox? [15:45:06] bearND: they look okay to me. [15:45:08] ragesoss: yes [15:45:22] ragesoss: maybe it's because I'm on the W0 plan [15:45:38] ah, maybe [15:46:20] i'll send an email to adam since i don't see him here [15:46:35] I can't find a bug from me about the borders issue. might have been something that had a quick fix so I never reported it. [15:52:24] (03PS2) 10Dbrant: Update packaged CSS assets from betalabs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147117 [15:58:19] 3Wikipedia App / 3Android App: App crashes when long-pressing in WebView - 10https://bugzilla.wikimedia.org/68166#c2 (10Alex Monk) Dmitry, is the bug I added to 'See Also' a duplicate of this? [15:59:35] 3Wikipedia App / 3Android App: App crashes when long-pressing in WebView - 10https://bugzilla.wikimedia.org/68166#c3 (10Dmitry Brant) Yes, it appears so. [16:02:19] 3Wikipedia App / 3Android App: IllegalArgumentException: View not attached to window manager causing crashes - 10https://bugzilla.wikimedia.org/67947#c3 (10Alex Monk) I wonder if https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7558041 is related [16:04:04] 3Wikipedia App / 3Android App: App crashes when long-pressing in WebView - 10https://bugzilla.wikimedia.org/68166#c4 (10Alex Monk) *** Bug 68169 has been marked as a duplicate of this bug. *** [16:04:05] 3Wikipedia App / 3Android App: NPEs from android.support.v7.app.ActionBarImplICS.getThemedContext in 2.0-beta-2014-07-16 - 10https://bugzilla.wikimedia.org/68169#c3 (10Alex Monk) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68166 *** [16:06:34] 3Wikipedia App / 3Android App: NPEs from page.PageViewFragment.commonSectionFetchOnCatch - 10https://bugzilla.wikimedia.org/67807#c5 (10Alex Monk) Was https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7562724 resolved by this? [16:08:04] 3Wikipedia App / 3Android App: NPEs from android.support.v4.widget.DrawerLayout.isContentView ? - 10https://bugzilla.wikimedia.org/67808#c1 (10Alex Monk) Is https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7586031 related? If not please tell me so I can create a separate bug for it [16:14:30] dbrant, around? [16:14:41] Krenair: yep [16:14:50] dbrant, are you able to mark bugs as resolved? [16:15:31] Krenair: sure, I believe so. [16:15:33] I just went and checked your account - you don't have editbugs. But I think the WMF-members group *might* grant the same... Not sure [16:15:35] Ah [16:15:49] Okay, never mind then :) [16:16:29] Krenair: I haven't resolved any myself, since I wasn't sure what the etiquette is regarding that. [16:16:42] "If it's fixed, close it" [16:16:43] :P [16:16:53] lol alright! [16:17:06] Specifically, if it's fixed on *master*. [16:17:12] I mean, you could be more rigorous, but the principle I use is "The bug is marked as fixed if the patch that fixes it has been merged, and that patch has been tested to work" [16:17:35] Some people take it to also mean "...and that change is now in the production build" [16:17:47] Yes, ignore those people. ^ [16:18:13] are there some android app devs here? :) [16:19:43] (03CR) 10Dbrant: [C: 032] Codestyle: Category Coding (tests) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147366 (owner: 10BearND) [16:21:19] (03CR) 10Dbrant: [C: 032] Codestyle: Category Coding (some Utils) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147367 (owner: 10BearND) [16:21:52] FlorianSW: there sure are! [16:23:10] dbrant: Are there plans to add an exit button to Android app? [16:24:31] FlorianSW: I would say not. That would fly against one of the most fundamental Android design patterns. [16:25:06] dbrant: ok, so to exit simply hold the back button or go through the entire history? :) [16:25:50] FlorianSW: all devices also have a Home button, which exits the app entirely, and takes the user to the home screen. [16:27:13] dbrant: Yes, but this normaly "only" pause the app and it's saved in ram to don't need to start next time :) But it's ok for me so :) [16:29:10] FlorianSW: compare with the Browser app on Android. It has a very similar behavior. [16:29:50] dbrant: Yes you're right :) Thx [16:35:07] 3Wikipedia App / 3Android App: More crashes related to network issues when querying page info - 10https://bugzilla.wikimedia.org/68220 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None Not sure if all of these are still valid, but: STACK_TRACE=java.lang.RuntimeException: org.mediawiki.api.json.ApiExcept... [16:39:49] 3Wikipedia App / 3Android App: More crashes related to network issues when querying page info - 10https://bugzilla.wikimedia.org/68220#c1 (10Alex Monk) That second link (https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7631332) also has this line: at org.wikipedia.editing.EditPrevie... [16:42:35] ios build approved by apple :D [16:43:03] w00t! [17:04:42] (03PS1) 10Dr0ptp4kt: Support identification of APK channel distribution. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147512 [17:09:26] (03PS2) 10Dr0ptp4kt: Support identification of APK channel distribution. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147512 [17:12:34] 3Wikipedia App / 3Android App: NPEs from page.PageViewFragment.commonSectionFetchOnCatch - 10https://bugzilla.wikimedia.org/67807#c6 (10Bernd Sitzmann) (In reply to Alex Monk from comment #5) > Was > https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom; > TicketID=7562724 resolved by this? The... [17:18:30] jgonera: https://trello.com/c/UwmrWedq/30-styling-tweaks-to-ve [17:19:50] oh wait, kaity had a few more points in her email.. [17:20:35] Maryana: jgonera I can add them to the trello [17:20:44] oh rad [17:20:45] thank you! [17:21:16] also, never leave us again!!! [17:21:32] * Maryana hugs kaity tightly [17:21:50] Maryana: I'll never leave you!! [17:21:57] :) [17:26:49] dbrant|brb: is the css patch ready to get merged? [17:26:58] bearND: yep! [17:27:16] dbrant: ok, will do so. anything else before we release beta? [17:27:30] dbrant, bearND: Any thoughts on the infobox thing? [17:27:34] bearND: don't believe so [17:27:50] (03PS3) 10BearND: Update packaged CSS assets from betalabs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147117 (owner: 10Dbrant) [17:28:32] Deskana: not sure what's going on there; but it looks the same in the production app. So it's not something that has changed recently... [17:29:36] dbrant: Could it be a change in the upstream CSS? [17:29:37] Maryana: jgonera Trello card is updated! [17:29:58] Thanks [17:30:17] thanks, kaity [17:30:48] Deskana: that's possible... but come to think of it, this is how I always remember seeing this article in the mobile app. [17:30:48] (03CR) 10BearND: [C: 032] Update packaged CSS assets from betalabs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147117 (owner: 10Dbrant) [17:31:07] (03Merged) 10jenkins-bot: Update packaged CSS assets from betalabs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147117 (owner: 10Dbrant) [17:32:27] bearND: mind if I do the apk release? I actually haven't yet used the make-beta script. [17:33:10] dbrant: Hmm. [17:33:33] dbrant: https://commons.wikimedia.org/wiki/File:Wikipedia_Android_app_on_Manchester_Arndale.png [17:33:51] dbrant: There's a screenshot I took on 20th July. See the infobox below the lead section? [17:35:16] Deskana: right? It seems to behave correctly in the current app... [17:35:57] Deskana: it must be something specific to the Obama page. [17:36:10] Wow, that's astounding. [17:36:30] dbrant: I wonder is it that "Part of a series on..." template. [17:36:35] See how that's above the infobox? [17:36:36] dbrant: not at all. Make sure you have the link in the res/values-iw/strings.xml file. First run it without arguments, then when it all went fine run it with —push (two dashes) [17:36:43] It's below the infobox in the app. [17:36:50] heading into zee office [17:36:56] *below the infobox on desktop. [17:37:00] brion: See you soon! [17:37:05] wheeeeeeeeee [17:37:38] Deskana: ah yes, it's possible that the app interprets the "part of a series" bit as the "first paragraph" after the infobox! [17:38:01] Deskana: that's a tricky one [17:40:22] dbrant: hmm, i think the beta script should also change the app label to app_name_beta. do you agree? [17:41:30] bearND: yes, agreed [17:44:39] dbrant: Well if it's just happening on a subset of article then I'm not *as* concerned. [17:45:04] 3Wikipedia App / 3Android App: IllegalArgumentException: View not attached to window manager causing crashes - 10https://bugzilla.wikimedia.org/67947#c4 (10Alex Monk) Hmm. I wonder if https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7668736 is this or related to bug https://bugzilla... [17:45:31] Deskana: yeah, other articles with just an infobox followed by text seem fine. [17:46:07] (03PS1) 10BearND: Make beta script also change the app label [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147523 [17:46:28] dbrant: ^ [17:46:29] (03CR) 10jenkins-bot: [V: 04-1] Make beta script also change the app label [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147523 (owner: 10BearND) [17:47:19] dbrant: updating… [17:48:10] (03PS2) 10BearND: Make beta script also change the app label [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147523 [17:48:52] dbrant: now it's happy [17:50:58] (03CR) 10Dbrant: [C: 032] Make beta script also change the app label [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147523 (owner: 10BearND) [17:53:57] (03PS1) 10Mhurd: Fix for onboarding globe flicker. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147525 [17:54:21] 3Wikipedia App / 3Android App: Editing a commons file returns "Could not connect to the network" - 10https://bugzilla.wikimedia.org/66609#c3 (10Alex Monk) (In reply to Yuvi Panda from comment #1) > just hide edit pencils in File: pages. Um, no. That would disable editing local file pages too. You would have... [17:56:50] 3Wikipedia App / 3Android App: More crashes related to network issues when querying page info - 10https://bugzilla.wikimedia.org/68220#c2 (10Bernd Sitzmann) 5NEW>3RESO/FIX I believe this was fixed a while ago, even before we pushed 2.0 to production. Was a missing onCatch. I think that was the fix: http... [18:00:20] 3Wikipedia App / 3Android App: Editing a commons file returns "Could not connect to the network" - 10https://bugzilla.wikimedia.org/66609#c4 (10Bernd Sitzmann) Beta is already hiding edit pencils for File: pages. [18:00:52] bearND, ugh. Who made it do that and where? [18:03:15] Krenair: https://trello.com/c/doQiUtOF/16-as-a-new-user-i-want-the-experience-i-get-when-i-tap-an-image-to-be-a-less-confusing is for iOS; https://trello.com/c/4coMpw3T/3-2-as-a-new-user-i-want-the-experience-i-get-when-i-tap-an-image-to-be-a-less-confusing for Android [18:04:22] Deskana: bearND: beta published! [18:04:32] dbrant: w00t! [18:04:41] Want to make things 'less confusing'? [18:04:45] Better remove features! [18:04:51] bearND, that's really silly. [18:06:00] Krenair: editing the file pages has some issues. I think disabling it is just temporary, but Deskana may know more about future plans for it [18:07:15] Krenair: Sure, but we have a very limited set of developers. If this is you signing up to implement the better solution (a media viewer), then awesome! ;) [18:07:49] Deskana, why do we need extra developers for this? [18:08:09] Krenair: Why do we need extra developer time to implement extra features? [18:08:21] Krenair: Was that your question? I think I'm not understanding. [18:08:28] No, you could edit file pages before. [18:09:30] Krenair: Yes, and now you can't. I'm not understanding what your question is. :) [18:09:39] You removed a feature. [18:09:49] It existed before. [18:09:55] Correct. [18:10:03] You cannot justify requiring an extra developer to fix it. [18:10:53] We removed a feature that was confusing. We're not adding it back in until we've got a better feature that isn't confusing. [18:11:09] That better feature requires developer time to implement. [18:11:16] Our efforts are better focussed elsewhere right now. [18:12:11] Something being confusing doesn't justify removing it. [18:12:25] That's called a regression. [18:12:28] Krenair: In your opinion. Not in mine. :) [18:12:40] The 'confusing' part is that it was allowing editing of the file page, not the file, right? [18:12:50] (03PS1) 10Mhurd: Fine tuned velocity at which scroll hides menu chrome. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147535 [18:13:33] Krenair: Partially, yes. [18:13:40] What else was there? [18:14:03] The experience we give when you tap on an image isn't in line with the experience you get in other apps. [18:14:25] In our app you get this weird page that's horribly formatted and sometimes doesn't even show you a larger version of the picture. [18:14:40] But there's important copyright information that can't be in there. [18:15:05] In the interests of making it as minimally confusing as possible while still getting an MVP out of the door that complies with the legal requirements, we did a minimal pass at the page. [18:16:00] Krenair: IIRC the issue with the edit pencil on a file page was that it threw an exception and showed "Could not reach the network". You can try that on the production app in store. [18:16:00] So what's the question? I'm still a bit confused why we're discussing this. [18:16:30] bearND, the bug specifies images *on commons*. Are you sure this occurs for all images? [18:17:43] Krenair: ah right [18:18:23] Because I'm pretty sure it only affects images loaded from the foreign file repo (in our case, commons) [18:18:50] I quickly went and found an example - load up the stable app and go to en's 'Do The Write Thing' page [18:19:01] Click the image, edit it. Wikitext appears and you should be able to edit it. [18:19:06] save it* [18:21:15] If you go to "File:Billy c.jpg" (which I know has no local description and therefore loads even the file *page* from commons), it breaks with the "Could not reach the network" error you describe [18:22:02] Perhaps a good reason to disable editing of pages for files from foreign repos (where there is no local description override), but not to completely disable editing file pages. [18:23:03] As I said above, that was only part of it. New users have no real model for what editing a file means. Until we can stabilise that, we took it out. [18:23:31] Hmm, while I don't get an error, I see no wikitext when editing the file page linked from 'Do The Write Thing' [18:23:46] The other issue - Confusing in that it edits the description rather than the attached image itself? Maybe, but still does not justify completely removing the ability [18:23:59] Krenair: Well, that's just, like, your opinion, man. :) [18:25:37] bearND: and have we made any specific procedure for bumping the versionCode? I simply amended the new number into the tag commit. [18:26:07] bearND, hmm. I got some just now but now I see nothing. [18:27:49] dbrant: not that i know of, but we should add that requirement to the trello card for updating the release script [18:28:47] Deskana: when do you think we'll push night mode to stable? [18:29:30] tfinc: A bit more testing is needed. We could probably do that Wednesday next week, or so. [18:29:51] Deskana: that would be a nice one to have in place before Wikimania [18:30:13] tfinc: Agreed. Does Wednesday sound good for a push to stable? dbrant, bearND|food [18:30:23] Deskana: tfinc: def. in favor of next Wednesday! [18:31:56] bearND: actually... the script did in fact bump the versionCode correctly! The problem is that the versionCode in Master is 72, but the versionCode of the Beta app is already 73... [18:32:29] bearND|food: ^ we have to somehow keep track of the Beta versionCode independently of the production versionCode... [18:33:08] bearND|food, yeah something more is broken there. [18:33:14] (re: files) [18:33:16] brion: question about build scripts when u have a sec [18:33:22] sec [18:35:43] dr0ptp4kt: Hey Adam [18:36:38] dfoy: hola [18:37:44] dr0ptp4kt: Can you reproduce the problems that Bernd is reporting? [18:38:13] dfoy: i haven't tried. but i'll give it a whirl here in a few minutes [18:38:24] dr0ptp4kt: ok thanks [18:43:44] (03CR) 10OliverKeyes: "Imagine I'm a five year old child. Explain to me what this does and how it impacts me ;p." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147512 (owner: 10Dr0ptp4kt) [18:51:22] (03PS1) 10JGonera: QA: Don't try to create references with external links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147547 [18:51:50] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for onboarding globe flicker. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147525 (owner: 10Mhurd) [18:53:38] dbrant|brb: Is there a build I can use for testing? [18:53:58] dbrant|brb: I don't have one that has the saved pages card in it. [18:54:06] dbrant|brb: This one: https://trello.com/c/x11i0ZNE/5-1-a-saved-page-should-indicate-that-it-has-been-saved-in-the-overflow-menu [18:56:06] (03CR) 10Dr0ptp4kt: "@OliverKeyes ha! I assume by five years old you're reading Proust or finding proofs for Ramanujan's work, so this shouldn't be too bad." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147512 (owner: 10Dr0ptp4kt) [18:56:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fine tuned velocity at which scroll hides menu chrome. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147535 (owner: 10Mhurd) [18:57:15] (03PS1) 10Mhurd: Only run build script for retrieving css update on install. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147552 [18:57:18] brion: ^ [18:58:36] (03CR) 10Brion VIBBER: [C: 032 V: 032] Only run build script for retrieving css update on install. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147552 (owner: 10Mhurd) [18:59:30] (03PS2) 10Dduvall: WIP Refactoring mobilefrontend tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 [18:59:37] 3Wikipedia App / 3Android App: Android app: Update all saved pages displays incorrect text when it's updating - 10https://bugzilla.wikimedia.org/68227 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None 1) Save a bunch of pages 2) Update them all 3) It only ever says "Updating LAST_PAGE_NAME" even though... [18:59:41] (03CR) 10jenkins-bot: [V: 04-1] WIP Refactoring mobilefrontend tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [19:00:48] (03CR) 10OliverKeyes: [C: 031] "You sweetheart ;p." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147512 (owner: 10Dr0ptp4kt) [19:01:31] (03CR) 10JGonera: [C: 032] For now, always default to source editor on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147200 (owner: 10Kaldari) [19:02:08] (03Merged) 10jenkins-bot: For now, always default to source editor on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147200 (owner: 10Kaldari) [19:02:19] Deskana: https://releases.wikimedia.org/mobile/android/wikipedia/betas/wikipedia-2.0-beta-2014-07-18.apk [19:04:32] dbrant|brb: <3 [19:04:52] 3MobileFrontend / 3General/Unknown: Gallery modes "packed-overlay" and "packed-hover" break the page - 10https://bugzilla.wikimedia.org/68228 (10Steve) 3UNCO p:3Unprio s:3normal a:3None I'm running MediaWiki 1.23.1 and MobileFrontend master. Below a gallery with mode="packed-overlay" or mode="packed... [19:05:35] 3MobileFrontend / 3General/Unknown: Gallery modes "packed-overlay" and "packed-hover" break the page - 10https://bugzilla.wikimedia.org/68228#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/5md53gEw [19:11:22] 3Wikipedia App / 3iOS App: iOS App: App sometimes loads cached versions of pages instead of loading new ones - 10https://bugzilla.wikimedia.org/68230 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Created attachment 15975 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15975&action=edit Three... [19:14:04] 3Wikipedia App / 3Android App: Editing a commons file returns "Could not connect to the network" - 10https://bugzilla.wikimedia.org/66609#c5 (10Dan Garry) 5NEW>3RESO/WON WONTFIX per this: https://trello.com/c/4coMpw3T/3-2-as-a-new-user-i-want-the-experience-i-get-when-i-tap-an-image-to-be-a-less-confusing [19:38:10] (03PS1) 10Dr0ptp4kt: Constrain thumbnail downsampling to JPEG types. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147627 [19:46:07] dbrant|brb: Are you going to send an email about the beta release? [19:46:54] bearND: I suppose... was there anything besides bug fixes? [19:47:53] dbrant: no [19:48:54] dbrant: also, have you pushed the tag? I don't see it on my end [19:49:09] (03PS1) 10Mhurd: This appears to not do what it says it does :( [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147629 [19:49:41] bearND: I have pushed it; it's present on my end. [19:50:45] (03CR) 10Mhurd: [C: 032 V: 032] "For some reason this doesn't work as expected." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147629 (owner: 10Mhurd) [19:50:50] brion: ^ [19:50:55] dbrant: great. I see it now [19:51:44] tfinc: Phidippus johnsoni, female [19:51:47] thanks [19:52:09] when i tried a different clone. I guess it would only fetch it when there is a real commit or something like that to fetch [19:53:07] MaxSem, any chance you could review and, if it's semantically correct, +2 https://gerrit.wikimedia.org/r/147627 ? bearND discovered that PNG-ified SVGs weren't being downsampled properly. i noticed that the GIFs and PNGs just don't seem to be getting downsampled reliably, so i think targeting rewrites to jpeg types only probably makes sense. [19:55:17] (03CR) 10MaxSem: [C: 032] Constrain thumbnail downsampling to JPEG types. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147627 (owner: 10Dr0ptp4kt) [19:55:30] MaxSem: thx [19:56:44] dr0ptp4kt, just realized - extensions can be uppercase [19:57:54] MaxSem: i believe the 'i' case insensitivity operator should handle that? other option would be to maybe do [Jj][Pp]([Ee]?][Gg] or something like that, but that's sort of scary! [19:58:30] oh, /i [19:58:36] all is good then:) [20:07:19] 3MobileFrontend / 3General/Unknown: Gallery modes "packed-overlay" and "packed-hover" break the page - 10https://bugzilla.wikimedia.org/68228#c2 (10Florian) Hello! Thanks for fill this bug :) I have tested it locally with MW 1.24 and latest master with this gallery code inside the first section (not main s... [20:12:57] MaxSem: any idea why that patch isn't merging in? i think yurik was having problems with merges the other day, but i don't remember what that was about [20:13:42] (03PS1) 10Brion VIBBER: Fix footer divider to extend on landscape & iPad [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147636 [20:15:39] dr0ptp4kt, jenkins looks slow if not stuck [20:15:39] (03CR) 10Mhurd: [C: 032 V: 032] "It's beauuuuuutiful!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147636 (owner: 10Brion VIBBER) [20:15:45] wheee [20:15:50] MaxSem: blargh [20:16:09] MaxSem: alright, will check on that later...ttyl [20:33:51] 3MobileFrontend / 3General/Unknown: Gallery modes "packed-overlay" and "packed-hover" break the page - 10https://bugzilla.wikimedia.org/68228#c3 (10Steve) Here is mode="packed-overlay": http://www.halopedia.org/index.php?title=Armor_permutations_(Halo_4)&mobileaction=toggle_view_mobile Here is mode="packed... [20:42:13] brion: I have a Quick Question for you [20:42:18] sure [20:48:46] The app files under the same category as the old app? [20:50:07] so that would be Reference? [21:02:05] 3MobileFrontend / 3General/Unknown: Gallery modes "packed-overlay" and "packed-hover" break the page - 10https://bugzilla.wikimedia.org/68228#c4 (10Florian) Still can't reproduce in MW1.24wmf14, will try with MW1.23 :) [21:12:01] (03CR) 10JGonera: [C: 04-1] "grep -nri "keepgoing" says there seem to be some leftovers:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147345 (owner: 10Kaldari) [21:18:58] jdlrobson, do you still use that git review hook for checking the number of patches without review? [21:21:35] (03PS1) 10Mhurd: Fix for toc sometimes jumping to wrong section. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147655 [21:21:38] brion: ^ [21:31:16] (03CR) 10JGonera: [C: 032] Adding mobile.loggingSchemas dependency to mobile.special.uploads.scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147333 (https://bugzilla.wikimedia.org/68009) (owner: 10Kaldari) [21:32:08] (03Merged) 10jenkins-bot: Adding mobile.loggingSchemas dependency to mobile.special.uploads.scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147333 (https://bugzilla.wikimedia.org/68009) (owner: 10Kaldari) [21:36:18] (03PS2) 10Mhurd: Fix for toc sometimes jumping to wrong section. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147655 [21:36:22] brion: ^ [21:39:21] (03PS3) 10Mhurd: Fix for toc sometimes jumping to wrong section. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147655 [21:39:40] brion: ^ alright, no more tweaks :) [21:44:45] (03CR) 10JGonera: [C: 032] Hygiene: Some clean-up of mobile Resources.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147340 (owner: 10Kaldari) [21:45:22] (03Merged) 10jenkins-bot: Hygiene: Some clean-up of mobile Resources.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147340 (owner: 10Kaldari) [21:45:39] (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks good :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147655 (owner: 10Mhurd) [21:46:58] (03CR) 10JGonera: [C: 04-1] Don't render page actions when none exist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147324 (owner: 10Jdlrobson) [21:47:35] (03PS2) 10Kaldari: Removing random and keep going experimental features from mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147345 [21:48:39] jgonera: what was your question? [21:48:55] jdlrobson, do you still use that git review hook for checking the number of patches without review? [21:49:23] (03PS3) 10Kaldari: Removing random and keep going experimental features from mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147345 [21:51:10] Maryana, so we do https://trello.com/c/UwmrWedq/30-styling-tweaks-to-ve without any estimation? [21:51:24] jgonera: yeah [21:51:39] won't Arthur be upset? ;) [21:51:55] it would normally be a bug, but since the VE team decided not to fix it, we're having to do it [21:52:01] think of it that way [21:52:18] rules were meant to be broken [21:54:03] (03CR) 10JGonera: [C: 04-1] "One doubt." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146684 (https://bugzilla.wikimedia.org/67140) (owner: 10Kaldari) [21:56:23] sure, I just really don't want to make Arthur upset and mess up his team bandwidth calculations and what not ;) [21:56:28] jgonera: not being using it recently as i'm in Flow but I was using it before :) [21:56:46] jdlrobson, I see, it doesn't seem to work anymore but I guess you won't know why then ;) [21:57:00] jgonera: what happens? [21:57:16] the "lablels" field is missing in gerrit API response jdlrobson [21:57:21] labels* [21:57:32] jgonera: don't worry about it. arthur's not a crazy agile robot -- these things happen :) [21:57:38] ok [21:57:49] jgonera: i see. [21:57:55] jgonera: so, in order to test this story (https://trello.com/c/7SLf1IU7/10-2-send-all-users-to-wikitext-editor-by-default) is there some way to set beta labs to be VE by default [21:57:55] ? [21:57:59] i can take a look, i use gerrit.py a lot and that's been working fine [21:58:28] Maryana, I think it is set to VE by default [21:58:39] (03CR) 10Kaldari: Making sure that clicking on search doesn't trigger history.back() (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146684 (https://bugzilla.wikimedia.org/67140) (owner: 10Kaldari) [21:58:43] Maryana, so just open a private browser window and see what loads [21:59:02] i thought we set it to wikitext by default? [21:59:05] like enwiki [21:59:08] jgonera: ^ [21:59:36] Maryana, check with James_F, I think when I last checked it was VE by default on beta labs [21:59:41] or maybe not [21:59:46] it's a mess, hard to remember [22:00:08] anyway, there's no way for you to change it unless you deploy a change to beta labs config ;) [22:00:10] yeah, it is -- i just created a new account [22:00:17] it's set to VE by default [22:00:20] Maryana, jgonera: Nope, enwiki Beta Labs mirrors enwiki prod configuration. [22:00:27] But I think accounts… yeah. [22:00:42] hmm.. so which is it? my new account just defaulted to VE [22:00:55] but that shouldn't be happening now per https://trello.com/c/7SLf1IU7/10-2-send-all-users-to-wikitext-editor-by-default [22:02:13] Maryana, defaulted to VE on mobile or desktop? anyway, I don't know if that change hit beta labs yet [22:02:25] (03CR) 10JGonera: [C: 032] Removing random and keep going experimental features from mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147345 (owner: 10Kaldari) [22:03:32] jgonera: then why is it in ready for signoff? :-P [22:03:34] (03CR) 10Kaldari: [C: 032] QA: Don't try to create references with external links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147547 (owner: 10JGonera) [22:03:53] Maryana, because I merged it [22:03:59] (03Merged) 10jenkins-bot: Removing random and keep going experimental features from mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147345 (owner: 10Kaldari) [22:04:10] Maryana, if I'm to check if it hit beta labs too then wee'll be doing the same work twice [22:04:10] (03Merged) 10jenkins-bot: QA: Don't try to create references with external links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147547 (owner: 10JGonera) [22:07:35] ok, it works [22:40:56] (03PS1) 10BearND: Share auto-formatting code settings for IntelliJ [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147671 [23:01:27] (03PS1) 10Mhurd: Added "today" to main menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147676 [23:01:30] brion: ^ [23:16:49] (03PS3) 10Dduvall: WIP Refactoring mobilefrontend tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 [23:18:49] moizsyed: have a sec? [23:18:56] sure [23:19:03] where are you? [23:19:07] moizsyed: desk [23:19:11] ok [23:43:07] (03CR) 10JGonera: [C: 032] QA: Deleted empty page file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146058 (owner: 10Zfilipin) [23:43:47] (03Merged) 10jenkins-bot: QA: Deleted empty page file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146058 (owner: 10Zfilipin) [23:43:48] MaxSem, https://gerrit.wikimedia.org/r/#/c/141576/ is still failing tests, is it something we want to get merged soon? [23:45:04] jgonera, it's a problem with test isolation that I can't repro locally [23:45:14] the change itself is not a bugfix [23:45:39] so probably not urgent [23:56:53] (03CR) 10JGonera: [C: 032] Syncing mobile blues and greens with official design palette [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145048 (owner: 10Kaldari) [23:57:29] (03Merged) 10jenkins-bot: Syncing mobile blues and greens with official design palette [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145048 (owner: 10Kaldari) [23:58:14] arrg it's the return of the site navigation bug on beta labs in beta >:( [23:58:38] jdlrobson, do you use hyphens for LESS variables in Flow? [23:58:56] Maryana, what is it exactly?