[00:39:52] 3Wikipedia App / 3Android App: Crash reports with null values? - 10https://bugzilla.wikimedia.org/68308 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None A few of these have come up before, but there's been a couple within the past 24 hours: USER_COMMENT=[some actual text from the user here] ANDROID_VE... [01:37:05] 3Wikipedia App / 3Android App: Allow change of interface language - 10https://bugzilla.wikimedia.org/68299 (10praveenp) [05:22:07] 3Wikipedia App / 3Android App: Add a magnify image to search bar - 10https://bugzilla.wikimedia.org/68309 (10Florian) 3NEW p:3Unprio s:3enhanc a:3None Comes from: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7679008 The search input field has atm only a text to identify... [06:27:19] (03PS2) 10Florianschmidtwelzow: Use canUseWikiPage before getWikiPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147756 (https://bugzilla.wikimedia.org/68249) [06:27:49] 3MobileFrontend / 3General/Unknown: Editing redlinks is broken (in any mode) on mobile - 10https://bugzilla.wikimedia.org/68249#c3 (10Florian) btw: caused by Change-Id: I509f7dac52b7837bf8b07a790c87f83208568e70 [11:06:45] (03PS1) 10Yuvipanda: Remove inline colors from within tables [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148047 [11:10:00] (03CR) 10jenkins-bot: [V: 04-1] Remove inline colors from within tables [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148047 (owner: 10Yuvipanda) [11:18:32] (03PS2) 10Yuvipanda: Remove inline colors from within tables [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148047 [11:18:52] (03CR) 10jenkins-bot: [V: 04-1] Remove inline colors from within tables [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148047 (owner: 10Yuvipanda) [11:23:08] (03PS3) 10Yuvipanda: Remove inline colors from within tables [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148047 [11:28:13] (03PS4) 10Yuvipanda: Remove inline colors from within tables in night mode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148047 [11:46:36] so I put a new navigation bar on the top of a number of key wikimania pages: https://wikimania2014.wikimedia.org/wiki/Hotel_Transport [11:46:48] but it doesn't look so good on mobile [11:47:11] please could someone take a look at it and see if you can fix it? :) [14:01:52] 3MobileFrontend / 3stable: Some Mobile/Web uploads without or with corrupted information - 10https://bugzilla.wikimedia.org/68321 (10Lupo) 3NEW p:3Unprio s:3normal a:3None From July 19: https://commons.wikimedia.org/wiki/File:Keilana_portrait.jpeg https://commons.wikimedia.org/wiki/File:Noratramloro... [14:02:54] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c69 (10Lupo) (In reply to Lupo from comment #67) > BTW, on July 19, 2014, I've seen three uploads through Mobile/Web without > proper {{information}} template: ... Happened again. Opened bug 68321 fo... [14:05:37] 3MobileFrontend / 3stable: Some Mobile/Web uploads without or with corrupted information - 10https://bugzilla.wikimedia.org/68321#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Gd2wKMfP [14:16:20] 3MobileFrontend / 3stable: Some Mobile/Web uploads without or with corrupted information - 10https://bugzilla.wikimedia.org/68321#c2 (10Jon) According to the edit summary they may have just gone to the file page and not gone through the upload button... [14:43:20] 3MobileFrontend / 3stable: Some Mobile/Web uploads without or with corrupted information - 10https://bugzilla.wikimedia.org/68321#c3 (10Lupo) Then why are they tagged as mobile web edit in the upload log? I thought that did mark the Mobile/Web uploads? https://commons.wikimedia.org/w/index.php?title=Special... [15:00:25] 3Wikipedia App / 3Android App: Click on link or search result results in nothing - 10https://bugzilla.wikimedia.org/68323 (10Florian) 3NEW p:3Unprio s:3major a:3None Comes from: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7664665 Device: Samsung Galaxy Stratosphere II... [15:01:21] 3Wikipedia App / 3Android App: Click on link or search result results in nothing - 10https://bugzilla.wikimedia.org/68323 (10Florian) [15:50:44] bearND: have you upgraded your IntelliJ to the latest release? [15:52:07] dbrant: it depends on the update settings (stable, milestone builds, …): right now I'm on 13.1.3 Build 135.909 [15:52:32] dbrant: i haven't updated to 13.1.4 yet [15:52:59] dbrant: do you see any issues? [15:53:24] bearND: I just upgraded to 13.1.4, and it won't let me build the project anymore! [15:53:31] bearND: http://youtrack.jetbrains.com/issue/IDEA-127374 [16:02:23] dbrant: thanks for the warning. Hmm, there doesn't seem to be a newer EAP version out. You still should be able to build from command line. Or you could reinstall older bits (either from your downloads folder if you still have it or http://confluence.jetbrains.com/display/IntelliJIDEA/Previous+IntelliJ+IDEA+Releases). I've got the 13.1.3 dmg if you want. [16:04:16] bearND: yeah, I was able to downgrade successfully. It's just curious that they'd release a 'stable' update with this kind of bug. [16:05:06] dbrant: good. How did you downgrade? [16:05:44] bearND: I also kept the previous dmg ;) [16:06:15] dbrant: ahh, good :) [16:30:05] 3MobileFrontend / 3stable: Some Mobile/Web uploads without or with corrupted information - 10https://bugzilla.wikimedia.org/68321#c4 (10Jon) The mobile edit tag is added to any edit coming from a mobile device. In mobile we try to steer users in the correct direction by adding workflows that add appropriate... [16:53:50] 3Wikipedia App / 3Android App: Android app: Update all saved pages displays incorrect text when it's updating - 10https://bugzilla.wikimedia.org/68227#c1 (10Dmitry Brant) 5NEW>3PATC This should be fixed in the latest Beta release. https://gerrit.wikimedia.org/r/145410 [16:57:20] 3MobileFrontend / 3stable: Some Mobile/Web uploads without or with corrupted information - 10https://bugzilla.wikimedia.org/68321#c5 (10Lupo) They get marked as "no source"/"no license" and the uploader is notified. After 7 days such files are deleted if the info is not forthcoming, which is usually the case... [16:58:05] * YuviPanda waves [16:58:39] YuviPanda: do not update your IntelliJ!!!11 [16:58:44] oh? [16:58:44] http://youtrack.jetbrains.com/issue/IDEA-127374 [16:59:10] I... see [16:59:13] dbrant: thnks for the headsup [17:01:39] YuviPanda: Any hint about how to do https://trello.com/c/AvH6dtUG/15-5-as-a-new-user-i-d-like-article-issues-wrapped-up-into-a-button-so-that-i-can-see-what-problems-an-article-might-have? This sounded interesting but I don't know how to detect when to display the article issues and disambig buttons [17:02:05] bearND: ah, mobile frontend does it, look at their js code? [17:06:55] Morning, gents! [17:07:57] hello! [17:12:05] Deskana: morning is good :P [17:12:24] (03CR) 10Dbrant: "Works for most tables, but not all: e.g. [[Barack Obama]]" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148047 (owner: 10Yuvipanda) [17:15:28] Deskana: brion standup! [17:15:50] i’m on :) [17:15:54] will be in after standup [17:15:56] As am I! [17:16:14] Deskana: my net cut out at this moment [17:16:23] :) [17:25:06] :-/ [17:25:21] somebody's cruising for a kickban.. [17:27:33] Maryana: I sent Erik a message. [17:29:44] He says he's fixed it. [17:42:21] 3MobileFrontend / 3stable: Some Mobile/Web uploads without or with corrupted information - 10https://bugzilla.wikimedia.org/68321#c6 (10Jon) Well that might be it then - Special:Upload doesn't load JavaScript in mobile. Sounds like a bug with Special:Upload on desktop too ... [17:53:11] (03CR) 10Kaldari: [C: 04-1] Use canUseWikiPage before getWikiPage (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147756 (https://bugzilla.wikimedia.org/68249) (owner: 10Florianschmidtwelzow) [17:53:24] YuviPanda: hey! [17:54:02] mhurd: heya [17:54:04] 'sup [17:54:36] YuviPanda: congrats on the new position! :) [17:54:36] yo team, I'm not entirely sure but shit might have hit fan [17:55:11] ? [17:55:26] mhurd: :) ty [17:55:55] mhurd: dbrant|brb also has a new position :D [17:56:09] indeed [17:56:16] * YuviPanda congratulates dbrant|brb [17:56:30] go to logstash and enter the following in search bar: type:exception AND "Invalid or virtual namespace -1 given." [17:56:37] YuviPanda: yes! congrats dbrant|brb! [17:56:40] they seem all to be coming from mobile site [17:56:46] kaldari, jgonera ^^^ [17:57:15] * bearND congrats YuviPanda and dbrant|brb [17:57:24] MaxSem, where's logstash? [17:57:34] https://logstash.wikimedia.org [17:58:02] dbrant|brb: Looking forward to working with you! [17:58:07] MaxSem: might be from bug https://bugzilla.wikimedia.org/show_bug.cgi?id=68249 [17:58:08] YuviPanda: Not looking forward to not working with you! [17:58:10] YuviPanda, what new position? [17:58:10] :P [17:58:19] MaxSem: email going out to mobile-tech momentarily [17:59:49] MaxSem, that's probably related to 404 redlinks, isn't it? [17:59:57] yup [18:00:02] redlinks of doooooooooom [18:00:19] E SOULD JUST ENABLE THEM EVERYWHERE [18:01:32] 404 redlinks? that's a lot of redlinks.. [18:01:51] :) [18:01:54] *rimshot* [18:01:55] Maryana, баян [18:02:01] :D [18:04:27] (03CR) 10Jdlrobson: Don't render page actions when none exist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147324 (owner: 10Jdlrobson) [18:05:35] (03CR) 10Kaldari: [C: 032] Fix and clean up pre git-review hook script [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147696 (owner: 10JGonera) [18:06:22] (03Merged) 10jenkins-bot: Fix and clean up pre git-review hook script [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147696 (owner: 10JGonera) [18:08:13] YuviPanda: does https://gerrit.wikimedia.org/r/#/c/147512/ look okay for your approval? [18:08:32] dr0ptp4kt: I'll take a look in 15m? doing some emails now :) [18:08:52] YuviPanda: sounds good, thx! [18:09:42] bearND: for the issues, look at issues.js in mobilefrontend [18:11:34] (03CR) 10Florianschmidtwelzow: Use canUseWikiPage before getWikiPage (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147756 (https://bugzilla.wikimedia.org/68249) (owner: 10Florianschmidtwelzow) [18:11:59] (03PS3) 10Florianschmidtwelzow: Use canUseWikiPage before getWikiPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147756 (https://bugzilla.wikimedia.org/68249) [18:13:42] YuviPanda: thx. I had already found that. Question: why are we not using jquery in the app? [18:14:25] bearND: because 1. we're running on modern versions of webkit only, which has querySelectorAll, 2. It is a fair bit of memory overhead per-tab [18:14:34] bearND: and because of (1) it doesn't buy us too much, tbh. [18:14:41] since we also don't do any AJAX what so ever [18:14:55] nor do we do complex event handling [18:17:04] (03CR) 10Kaldari: [C: 032] Use canUseWikiPage before getWikiPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147756 (https://bugzilla.wikimedia.org/68249) (owner: 10Florianschmidtwelzow) [18:17:39] YuviPanda: ok, that helps. also with translating the MF code for our needs ;) [18:17:46] (03Merged) 10jenkins-bot: Use canUseWikiPage before getWikiPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147756 (https://bugzilla.wikimedia.org/68249) (owner: 10Florianschmidtwelzow) [18:17:52] ok heading into office, see y’all in a bit [18:17:52] (03CR) 10MaxSem: Use canUseWikiPage before getWikiPage (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147756 (https://bugzilla.wikimedia.org/68249) (owner: 10Florianschmidtwelzow) [18:18:04] bearND: :D yeah, but I suspect we won't be translating too much of it :) MF is a far more complicated JS beast than the app [18:18:20] 3MobileFrontend / 3General/Unknown: Editing redlinks is broken (in any mode) on mobile - 10https://bugzilla.wikimedia.org/68249 (10Max Semenik) 5PATC>3RESO/FIX [18:18:38] (03PS1) 10MaxSem: Use canUseWikiPage before getWikiPage [extensions/MobileFrontend] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148126 (https://bugzilla.wikimedia.org/68249) [18:18:55] (03CR) 10MaxSem: [C: 032] Use canUseWikiPage before getWikiPage [extensions/MobileFrontend] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148126 (https://bugzilla.wikimedia.org/68249) (owner: 10MaxSem) [18:18:56] Yuvi: You should have made a joke that you were going to go join OneTaste. [18:19:14] jorm: DoubleTouch was the closest I could get without explicitly naming it :) [18:19:54] "I'm leaving to join a sex-cult start up..." [18:21:23] lololol [18:21:47] (03Merged) 10jenkins-bot: Use canUseWikiPage before getWikiPage [extensions/MobileFrontend] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148126 (https://bugzilla.wikimedia.org/68249) (owner: 10MaxSem) [18:23:35] 3MobileFrontend / 3General/Unknown: Editing redlinks is broken (in any mode) on mobile - 10https://bugzilla.wikimedia.org/68249 (10Florian) 5PATC>3RESO/FIX [18:23:38] YuviPanda, you're leaving us! [18:23:43] you lucky bastard [18:23:46] MaxSem: :D [18:26:11] (03PS1) 10Florianschmidtwelzow: Remove unneeded isArticleRelated [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148127 [18:26:25] No widgets! [18:26:33] (scroll to the bottom of http://onetaste.us/) [18:26:49] Deskana: haha [18:27:18] So I have a beta release on my calendar. [18:27:23] But dbrant|brb said we did it on Friday. [18:27:52] Deskana: right, we probably don't need to do another one today, then [18:28:21] Let me schedule something for Wednesday so we can do our market release of references and night mode/font size. [18:28:34] excellent [18:29:17] Right after the standup! [18:29:18] That'll do. [18:29:30] Bernd will have to miss the last little bit, but that's okay. [18:29:42] Deskana: can you schedule it to repeat every two weeks? [18:29:54] YuviPanda: Sure can. [18:30:51] 3Wikipedia App / 3iOS App: [iOS] webview Wikipedia link long press convert to HTTPS - 10https://bugzilla.wikimedia.org/68330 (10dr0ptp4kt) [18:30:53] 3Wikipedia App / 3iOS App: [iOS] webview Wikipedia link long press conver to HTTPS - 10https://bugzilla.wikimedia.org/68330 (10dr0ptp4kt) 3NEW p:3Unprio s:3enhanc a:3None This is a feature request to have longpresses on hyperlinks that are on Wikipedia domains show as HTTPS in the flyup and use HTTPS... [18:35:50] vbamba: Do you have the flag icon (for page issues) ready to go soon? [18:36:22] (03PS8) 10Jdlrobson: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 [18:37:48] dbrant: are you talking about the greys? [18:37:57] dbrant: I think those would be fixed by amending colors in night.css [18:38:12] dbrant: background vs background-color is handled. .style reports them properly as background-color :D [18:38:23] which is why I'm using .style and not .getAttribute("style") [18:39:27] YuviPanda: well I'll be dipped! You are correct. [18:39:32] dbrant: :D [18:43:51] (03CR) 10Dbrant: [C: 032] Remove inline colors from within tables in night mode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148047 (owner: 10Yuvipanda) [18:43:57] dbrant: w00t [18:44:02] dbrant: I'll make the night.css change shortly [18:47:55] bearND: Flag Icon can be ready soon! [18:49:36] vbamba: thanks :) [18:55:36] dbrant: we should always add mobile-l to any questions / discussions that don't have a problem being public :) [18:55:50] YuviPanda: ah, of course! [18:56:25] YuviPanda: i keep forgetting how transparent we are! [18:56:33] dbrant: :D [19:02:13] dbrant: Sue always said that in most organisations, you'd never be chastised for keeping something private if you weren't sure, and that she was pleased we were totally the other way around. :P [19:07:01] kaldari: MaxSem lunch? [19:07:10] yup! [19:13:04] vbamba: sure, hangout at 2pst [19:17:03] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Nice addition, tested on the subway this morning to switch to today's headlines :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/147676 (owner: 10Mhurd) [19:17:09] dbrant: Invite me, please. :) [19:17:30] dbrant: These hangouts for feature related stuff should always have the product owner in, where possible. [19:17:42] Deskana: of course [19:17:52] dbrant: Thanks! [19:24:22] 3Wikipedia App / 3iOS App: [iOS] webview Wikipedia link long press convert to HTTPS - 10https://bugzilla.wikimedia.org/68330#c1 (10Brion Vibber) 5NEW>3ASSI a:3Brion Vibber This is a one-character fix. :D Testing now... [19:25:35] Time to do a software update I guess... [19:25:42] Be back whenever Apple thinks I can be back. [19:28:02] (03PS1) 10Brion VIBBER: Use https: base address for long-press link menu [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148162 (https://bugzilla.wikimedia.org/68330) [19:28:55] Apparently "Download and restart" doesn't mean restart now, it means "restart some time later". [19:29:02] * Deskana cries tears of product pain. [19:29:34] well, it didn’t say “restart and download” [19:29:54] brion: Shush! [19:29:57] :P [19:30:22] The frustrating thing is I'm kind of left hanging. Is it just going to shut down now when it's done, or will it at least ask me? [19:32:22] i never know [19:38:05] Now it restarts. [19:38:07] Farewell! [19:39:07] Error:Android Source Generator: Cannot parse SDK 'Maven Android API 20, L preview Platform': unknown target android-L [19:39:14] hmm [19:39:14] heh [19:40:35] *tweak project settings* [19:41:36] oh for …. [19:41:57] try the reference viewer on [[21 Leonis Minoris]] [19:42:13] the links are document-internal and point to more footnotes [19:43:21] even more of those on today’s featured [[Leo Minor]] [19:43:26] *sob* [19:49:37] 3Wikipedia App / 3Android App: Android: "Could not display this link" clicking links in reference viewer on [[Leo Minor]] - 10https://bugzilla.wikimedia.org/68336 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None * Load up [[Leo Minor]] in a current build of the Android app. * Click the [2] or [1] or... [19:53:17] heh i was like “wow there’s no android stories this week what’s up” then realized i had filtering on :D [19:53:33] brion: heh [19:54:56] lol [20:01:05] (03CR) 10MaxSem: Don't render page actions when none exist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147324 (owner: 10Jdlrobson) [20:03:23] 3Wikipedia App / 3Android App: Android app: following on-wiki link from reference doesn't close reference view - 10https://bugzilla.wikimedia.org/68337 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None * Open [[Oral tradition]] in Android app current build * Click on "[3]" * Click on the link "Henige... [20:08:02] hello everyone [20:08:41] Can anyone help me with a problem regarding MobileFrontEnd Extension? [20:09:16] hey richardwakefield what's up? [20:09:26] hey jdl, thanks for the response [20:10:42] I am using MFE with my mediawiki. The problem is that when I search for with Nearby function the pictures of articles does not appear on the little boxes to the left of each [20:11:21] instead that blue icon with "+" appears, although I have images on the article [20:11:26] but in normal search they appear? @richardwakefield [20:12:06] in normal search of Mobile version only text comes up [20:12:21] 3Wikipedia App / 3Android App: Saved pages are not ordered in a useful way - 10https://bugzilla.wikimedia.org/67028 (10Dan Garry) 5PATC>3RESO/FIX [20:12:35] 3Wikipedia App / 3Android App: Android app: Update all saved pages displays incorrect text when it's updating - 10https://bugzilla.wikimedia.org/68227 (10Dan Garry) 5PATC>3RESO/FIX [20:13:13] I don't think the extension has image feature for normal search [20:13:37] richardwakefield: mmmm [20:13:39] because those blue icons "+" doesn't appear either [20:13:47] richardwakefield: do you have PageImages extension installed [20:13:50] it's an optional dependency [20:13:52] i mean the search suggestions :) E.g. you type in "Example" then it comes "Example page" if "Example page" exists :) [20:13:53] only in nearby they exist [20:13:59] If not, then PageImages isn't installed [20:14:08] oops :/ jdlrobson was faster :D [20:14:29] ach, sorry florian just got you. also only article names as text come up [20:14:31] in such search [20:14:31] -> https://www.mediawiki.org/wiki/Extension:PageImages [20:14:40] Let me check that extension [20:14:52] thank you very much! [20:15:52] richardwakefield: yey [20:15:56] richardwakefield: i'm updating the docs [20:17:16] richardwakefield: thanks for pointing that out :) https://m.mediawiki.org/wiki/Special:MobileDiff/1071298...1072179 [20:23:28] I'm glad to have a contribution:) [20:23:41] I installed the extension but the problem remains [20:24:01] should I make any extra settings apart from require once addition to localsettings? [20:27:55] (03CR) 10Kaldari: "That's not what I'm seeing. For example, if I go to..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [20:29:16] jdlrobson: So what was that change with the empty issue? [20:30:06] kaldari: https://gerrit.wikimedia.org/r/147324 i'm just keen to know whether everything i learnt about `empty` is wrong - i feel like this is a good opportunity for knowledge sharing [20:31:36] (03CR) 10Kaldari: Don't render page actions when none exist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147324 (owner: 10Jdlrobson) [20:33:27] jdlrobson: The only reason you would ever use empty, AFAIK, is if you need error suppression [20:35:17] jdlrobson: The only reason you would ever use empty, AFAIK, is if you need error suppression [20:35:40] (03CR) 10Jdlrobson: [C: 032] Show No bytes changed on mobile diff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144487 (https://bugzilla.wikimedia.org/64616) (owner: 10Florianschmidtwelzow) [20:35:59] (03CR) 10JGonera: Don't render page actions when none exist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147324 (owner: 10Jdlrobson) [20:36:06] 3MobileFrontend / 3Feature requests: “0 bytes added” should be specially handled and show something better - 10https://bugzilla.wikimedia.org/64616 (10Jon) 5PATC>3RESO/FIX [20:36:48] (03Merged) 10jenkins-bot: Show No bytes changed on mobile diff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144487 (https://bugzilla.wikimedia.org/64616) (owner: 10Florianschmidtwelzow) [20:38:09] (03CR) 10JGonera: "1) might need a follow up patch in VE, I'll check. Could you explain what kind of node you highlight in 2)? A reference?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) (owner: 10JGonera) [20:41:52] (03CR) 10Kaldari: "Yes, I was highlighting a reference node." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) (owner: 10JGonera) [20:51:05] 3Wikipedia App / 3Generic: Content doesn't realign after zooming out - 10https://bugzilla.wikimedia.org/64340#c1 (10Dan Garry) 5NEW>3RESO/INV This is probably invalid now, since it shouldn't be possible to zoom like that any more. [20:52:20] 3Wikipedia App / 3Generic: "Go" to "wp:vpt" on zhwiki crashes the app - 10https://bugzilla.wikimedia.org/64050#c1 (10Dan Garry) 5NEW>3RESO/FIX Unable to reproduce this, so I guess we fixed it. [20:53:25] Deskana: actually, we do still technically allow pinch-to-zoom inside the WebView. Should we disallow it? [20:54:16] Deskana: a plausible argument for keeping it would be to be able to zoom in on images... [20:54:22] 3Wikipedia App / 3Generic: No warning message when I exit edit mode - 10https://bugzilla.wikimedia.org/63951#c1 (10Dan Garry) 5NEW>3RESO/FIX Fixed in the current workflow. [20:56:37] dbrant: Hm. [20:56:42] dbrant: Now that you can increase the font size... [20:57:32] dbrant: Let's get rid of it. [20:57:57] tfinc: Kristen starts tomorrow, right? [20:57:59] (03CR) 10JGonera: [C: 032] Making sure that clicking on search doesn't trigger history.back() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146684 (https://bugzilla.wikimedia.org/67140) (owner: 10Kaldari) [20:58:03] Deskana: yes [20:58:08] (03CR) 10jenkins-bot: [V: 04-1] Making sure that clicking on search doesn't trigger history.back() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146684 (https://bugzilla.wikimedia.org/67140) (owner: 10Kaldari) [20:58:13] Woohoo! [20:58:17] Deskana: even though there's no way to zoom in on images? [20:58:31] i would actually love to have pinch to zoom on images and tables [20:58:56] dbrant: I'm on the fence about it. [20:59:03] though that could be a ‘tap in and then zoooom’ thing [20:59:57] dbrant: Eh, whatever. We can leave it in. I have more important things to worry about than whether this should be in there or not. :P [21:00:04] Deskana: np, probably not high-priority [21:00:05] dbrant: Such as this meeting I'm about to go to! ;) [21:00:28] Deskana: you dont have to come [21:00:40] i just want to see whcih elemets are included in the highlight - discuss the highlight color [21:00:51] Deskana: no fundamental issues with the interaction [21:01:36] dbrant, vbamba1: Since it clashes with something else, I'll skip it. Let me know what the outcome is. :) [21:01:48] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Sorry, i misunderstand you :) I thought you mean, when you manually write it (don't know how i came to this thinking)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [21:01:53] ya im just getting details from dbrant [21:02:11] Deskana: What if the content highighted is in a section of a table thats off screen [21:02:14] things like that [21:02:25] dbrant: and i will post a summary [21:03:06] (03PS2) 10Kaldari: Making sure that clicking on search doesn't trigger history.back() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146684 (https://bugzilla.wikimedia.org/67140) [21:03:11] vbamba1: Oh? I thought this was just about the addition that dbrant suggested, and not more generally about the feature. [21:04:01] vbamba1: Anyway, I'll leave you two to discuss it and catch up later. [21:04:03] Deskana: both are related in my mind [21:05:40] Deskana: ok! talk later! [21:09:22] MaxSem, can you review https://gerrit.wikimedia.org/r/#/c/148127/1 if it's something quick for you? [21:09:52] (03CR) 10MaxSem: [C: 032] Remove unneeded isArticleRelated [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148127 (owner: 10Florianschmidtwelzow) [21:10:32] (03Merged) 10jenkins-bot: Remove unneeded isArticleRelated [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148127 (owner: 10Florianschmidtwelzow) [21:18:52] jgonera: https://gerrit.wikimedia.org/r/#/c/133301/ still needs a small update but otherwise it's good to go. Can we do that starting early next week? [21:19:28] If we can merge it before we leave for Wikimania but after this week's deploys, that would be ideal. Then we don't have to worry about it until after deploys resume after Wikimania. [21:20:54] StevenW, sure, so what should be the color for captions finally? #444 or #555? what was the related bug? [21:21:13] #555 [21:21:37] As noted by Jared and I on the patch. [21:21:46] The related bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=65160 linked from the patch [21:22:55] ok, I just read through the latest comments [21:23:22] StevenW, I can make those changes but since there's so much controversy around this patch, someone else will have to +2 then [21:24:02] Yeah if you update the patch someone else should +2 [21:25:41] (03PS3) 10Dbrant: Show number of matches when finding in page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147761 (owner: 10Alex Monk) [21:26:00] Krenair: ^ not bad at all! [21:26:08] oh good [21:27:19] Doesn't your change disable support for pre-jelly bean devices though? [21:27:48] Or... hm that's just build versions? [21:29:21] (03PS4) 10Dbrant: Show number of matches when finding in page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147761 (owner: 10Alex Monk) [21:29:35] Krenair: ^ lol just spotted that myself! [21:29:43] :) [21:31:31] (03CR) 10Kaldari: [C: 032] Making sure that clicking on search doesn't trigger history.back() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146684 (https://bugzilla.wikimedia.org/67140) (owner: 10Kaldari) [21:32:10] (03Merged) 10jenkins-bot: Making sure that clicking on search doesn't trigger history.back() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/146684 (https://bugzilla.wikimedia.org/67140) (owner: 10Kaldari) [21:33:51] 3MobileFrontend / 3beta: VisualEditor Mobile: When saving a sub page, Mobile Frontend redirects it to the parent page which contains a link to it - 10https://bugzilla.wikimedia.org/67639#c5 (10Ryan Kaldari) Reproducing this bug is currently blocked by bug 68249. [21:35:11] ack, who vandalized our trello? [21:36:27] * MaxSem suspects someone [21:37:38] oh my god [21:38:02] i finally read epic russian novel length discussion about moving special:mylanguages into core [21:38:09] * Maryana shoots self in the face [21:38:53] Guys, does anyone have an idea what might be causing thumbnail images not to appear on mobile search/nearby? [21:39:09] I installed PageImages too, yet its not working. I'm clueless [21:39:12] richardwakefield, it requires PageImages [21:39:17] eh [21:39:20] yeah:) [21:39:28] after installing it, pages need to be re-parsed [21:39:38] what does it mean? [21:40:19] run maintenance/refreshLinks.php from shell [21:40:53] I made maintenance i.e. version update from web updater [21:41:01] (can be slowww for large wikiis) [21:41:04] okay I'll try to learn it [21:41:09] updater can't help [21:41:11] its a very little wiki yet [21:41:33] but I'm really not a profi. I need to figure out what you are talking about [21:41:42] ssh into server [21:41:52] cd into directory where MW is installed [21:42:01] php maintenance/refreshLinks.php [21:42:23] I use cpanelx of godaddy [21:50:37] 3Wikipedia App / 3iOS App: iOS: in-document anchor links display/copy wrong in long-press popup - 10https://bugzilla.wikimedia.org/68345 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None base href is set to just the site which is enough for "/wiki/Foo" links but not for in-document "#Section" or cita... [21:57:50] 3MobileFrontend / 3beta: VisualEditor Mobile: When saving a sub page, Mobile Frontend redirects it to the parent page which contains a link to it - 10https://bugzilla.wikimedia.org/67639#c6 (10Ryan Kaldari) The issue here is that we're adding a hash to the URL when we launch the editor, and then doing histor... [21:59:16] kaldari: so, when i go to mobile frwiki and click on the terms of use link, i get this: https://m.wikimediafoundation.org/wiki/Terms_of_use/fr [21:59:29] this is the issue special:mylangs is trying to solve? [22:00:08] (i'm totally going to be a jerk and pull the legal card to *hopefully* end this ridiculous gerrit war) [22:01:12] Maryana: That's because I hacked it for them on the French Wikipedia: https://fr.m.wikipedia.org/wiki/Sp%C3%A9cial:History/MediaWiki:Mobile-frontend-terms-url [22:08:35] (03CR) 10Nikerabbit: Show No bytes changed on mobile diff (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/144487 (https://bugzilla.wikimedia.org/64616) (owner: 10Florianschmidtwelzow) [22:14:25] 3MobileFrontend / 3General/Unknown: Mobile site not respecting desktop opt-out on iPad - 10https://bugzilla.wikimedia.org/68347 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Copied from English Wikipedia Village pump: Issue: persistently redirected to mobile site despite repeatedly trying to... [22:14:51] (03PS1) 10Brion VIBBER: References click backend: detect link clicks and send data over bridge [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148247 [22:15:39] 3MobileFrontend / 3General/Unknown: Mobile site not respecting desktop opt-out on iPad - 10https://bugzilla.wikimedia.org/68347#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/V0h39q7l [22:39:06] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c70 (10Steinsplitter) (In reply to Steinsplitter from comment #68) > I suggest to allow uploads only by "autopatrolled" users and where global > usercount is +400 edits. ^^ can we do this? @Jon [22:58:51] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c71 (10Jon) http://sustainableman.org/wp-content/uploads/2013/07/DrIanMalcom.jpg Of course, anything is possible, but let's look at this differently. We have significantly more users from mobile upl... [23:02:51] (03PS1) 10Dr0ptp4kt: Expressly set the background color for search results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148262 [23:02:58] richardwakefield, ask that in public, please [23:03:07] surely [23:03:14] dbrant: would you mind reviewing https://gerrit.wikimedia.org/r/148262 ? [23:03:33] So I ran the maintenance script for refreshlinks.php [23:03:47] and I came up with the error: [23:03:52] dr0ptp4kt: will do [23:04:03] Fatal error: Call to a member function getArticleID() on a non-object in /home/r ichardwakefield/public_html/extensions/Comments/CommentsHooks.php on line 72 [23:04:21] and MW is down too [23:04:45] I appreciate any ideas on how to solve this [23:04:52] 3Wikipedia App / 3General/Unknown: iOS and Android apps: pie charts are broken - 10https://bugzilla.wikimedia.org/68354 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Created attachment 15997 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15997&action=edit Pie charts not displaying correctly... [23:05:20] Holy shit. That sad star when you've got no saved pages is depressing. [23:05:38] I feel the star's pity for me. [23:05:57] ragesoss: there's only one way to make the star happy... [23:07:26] the webpage is down aswell, I should add [23:07:39] Saved: MDMA. [23:08:05] But now the star is just gone? [23:08:22] Now I feel even worse. [23:12:30] richardwakefield, Extension:Comments is breaking stuff - is it compatible with your MW version? [23:12:56] yes both are 1.23 [23:13:27] then it's just broken [23:13:36] (03PS2) 10Dr0ptp4kt: Expressly set the background color for search results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148262 [23:13:45] dbrant: ^ made it use resource file color instead of system constants [23:14:02] I repeated it but failed again [23:14:26] what would you suggest for a fix? [23:14:44] Saved: Alcoholic beverage, Cannabis (drug), Advanced Packaging Tool. [23:14:55] (03CR) 10Jdlrobson: Don't render page actions when none exist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147324 (owner: 10Jdlrobson) [23:15:05] 3MobileFrontend / 3beta: VisualEditor Mobile: When saving a sub page, Mobile Frontend redirects it to the parent page which contains a link to it - 10https://bugzilla.wikimedia.org/67639#c7 (10Ryan Kaldari) I think this bug is actually the same as bug 60848 and bug 65041. Bug 60848 was closed by Jon as WONTF... [23:15:23] dbrant: star is still gone, none of the usual things make it come back happy. [23:15:38] jdlrobson: Could you take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=67639 when you have a sec? [23:16:02] specifically the question in the last comment [23:17:51] ragesoss: I was kidding about that; the star is either unhappy, or gone :( [23:18:43] I gave that star everything. It was never good enough. [23:19:06] 3MobileFrontend / 3beta: Mobile: After saving a redlink page, the user is redirected to the previous page (typically the page the redlink was on) rather then the newly created page - 10https://bugzilla.wikimedia.org/67639 (10Ryan Kaldari) [23:20:08] dbrant: sorry, wrong color resources, will amend [23:21:38] (03PS3) 10Dr0ptp4kt: Expressly set the background color for search results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148262 [23:21:44] dbrant: ^ there. again, sorry! [23:26:33] (03PS11) 10Jforrester: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) (owner: 10JGonera) [23:27:59] (03CR) 10jenkins-bot: [V: 04-1] Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) (owner: 10JGonera) [23:34:00] (03CR) 10Kaldari: Don't render page actions when none exist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147324 (owner: 10Jdlrobson) [23:36:08] jdlrobson: Did you see my ping about bug 67739 above? [23:36:32] dr0ptp4kt: mind if I amend with a simpler way of doing it? [23:37:09] dbrant: not at all, please do! [23:39:29] dr0ptp4kt: wait, actually... how is this different from the default appearance? [23:41:01] dbrant: on kindle fire when it's in dark mode the the listview's cells have a translucent background. this makes it so those cells don't have a translucent background. [23:41:24] dbrant: might be easier if i show you on google hangout. wanna do that? [23:41:52] dr0ptp4kt: sure! sounds weird... [23:42:01] dbrant: imagine my surprise... :) [23:42:05] dbrant: one moment [23:42:37] 3MobileFrontend / 3General/Unknown: tapping on the search input in mobile frontend takes you to previous page - 10https://bugzilla.wikimedia.org/67140 (10Ryan Kaldari) 5PATC>3RESO/FIX [23:48:13] kaldari: looking [23:48:20] thanks [23:50:52] jdlrobson: It's obviously possible to fix this with some one-off code that provides an exception to the normal overlay closing behaviour, but considering all the similar bugs, should we revisit the underlying issue (bug 60848)? [23:51:43] kaldari: does it only effect VE or also wikitext eiting [23:51:49] both [23:52:47] mm i'm not quite sure right now. I think the behaviour in the non-edge case is important, so we need to retain that somehow in any fixe [23:53:33] jdlrobson: maybe we should make the behavior of overlay closing more flexible [23:54:04] kaldari: hard to test as beta labs is down, but isn't this to do with Special:MobileEditor ? [23:54:12] partially [23:54:40] jdlrobson: You can also test it on test.wiki or in a user sandbox on en.wiki [23:55:53] jdlrobson: I'm fine with leaving bug 60848 as WONTFIX for now, if you think that's too risky to mess with. Just wanted to get your opinion. [23:56:42] kaldari: i suspect what actually we need to do is when loading a page with editor/0 hash, we push another hash state to the URL. [23:56:56] Would be good to get a page refresh on http://localhost:8080/w/index.php?title=Main_Page#editor/0 working [23:57:08] e.g. allow someone to follow that page, click back and see the article [23:57:13] maybe using replaceState [23:57:20] true, that might be a good solution