[00:00:17] jdlrobson, also, can you merge https://gerrit.wikimedia.org/r/#/c/148551/ ? [00:00:20] (03PS1) 10Dr0ptp4kt: Support Kindle text size change. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148554 [00:00:51] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c117 (10Rainer Rillke @commons.wikimedia) mariadb> select count(log_timestamp) from filearchive, logging where fa_name = log_title and log_action = "upload" and log_timestamp >= '20140701000000'; 1... [00:01:01] there were 3060 mobile web uploads in July. [00:01:04] over half were deleted. [00:01:46] Steinsplitter: your complaint in the bug is that you're overworked.. but it's desktop uploads that are the vast majority of all uploads. so why don't you seem to care about improving the desktop upload workflow? [00:01:57] the multimedia team is working on that... [00:02:14] but in the meantime, no one is clamoring to gate it to users who have 75+ edits on commons :) [00:02:24] desktop had 360236 uploads [00:02:39] [17:02:35] legoktm: 11949/360236 = 11949/360236 (approx. 0.033169921940061515) [00:02:50] so 3% deletion rate on desktop, compared to over 50% on mobile. [00:03:11] Maryana: fact it is that plus 80 get deleted. Ther is no need to do nonsens work. it is a wasting of time. [00:03:47] Steinsplitter: but in terms of absolute hours, it takes you way longer to delete desktop uploads. there are so much more of those [00:04:12] dr0ptp4kt: it worked, i take it? [00:04:24] dbrant: works for me. i'll abandon the other [00:04:32] https://gerrit.wikimedia.org/r/#/c/148554/ < dbrant [00:04:55] dr0ptp4kt: terrific! works across my other devices, too. [00:05:06] (03Abandoned) 10Dr0ptp4kt: Make text resize buttons usable on Kindle after first tap. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148459 (owner: 10Dr0ptp4kt) [00:05:11] legoktm: can you run those numbers for after july 10? [00:05:16] Maryana: on web are also a lot of mass dletions etc. mobile web is awaha work. [00:05:28] that's when we stopped showing the uploads link in the left nav to non auto-confirmed users [00:05:36] sure. [00:05:44] legoktm: thank you :) [00:06:00] and i suggest to change it to autopatrolled OR editcount - 70 (or somthing similar) [00:06:15] (03PS1) 10Jdlrobson: WIP: Use Special:EditWatchlist for A-Z View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148557 [00:06:16] 219237 uploads in desktop [00:06:19] (03CR) 10Dbrant: [C: 032] Support Kindle text size change. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148554 (owner: 10Dr0ptp4kt) [00:06:21] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c118 (10Kunal Mehta (Legoktm)) http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-mobile/20140722.txt and http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-mobile/20140723.txt Mainly focusing on what... [00:06:33] dbrant: thanks! [00:06:40] dbrant: gotta run. ttyle [00:06:44] er, [00:06:49] 219237 uploads overall [00:07:04] 1308 in mobile [00:07:26] 672 mobile deletions, still over half [00:08:06] 6319 deletions overall [00:08:10] Maryana: i can switch it of completly with mobile.js, but i don't (for now) because it is a ugly hack. [00:08:58] thanks, legoktm - we need to update that limn dash [00:09:22] legoktm - could you put those #s in the bug? absolute and % [00:09:29] since clearly people don't trust me with data :-P [00:09:37] sure. [00:09:42] much appreciated! [00:09:54] Steinsplitter: you probably want to use abusefilter, not mobile.js btw [00:10:24] unfortunatly, scanning this with ABF is not possible :( [00:10:31] action=upload? [00:10:47] you'd have to put the mobile.js on the local wiki, so enwp or wherever [00:10:48] there was a but that it don't work [00:10:52] hm. [00:10:58] ummn :/ [00:11:22] i can try it tomorrow. [00:12:48] if AF doesn't work, just run an adminbot or something. that way you don't entirely lose the contributions either. [00:13:13] mobile.js is a bad hack, and would affect the performance of all mobile users, even those not uploading [00:13:25] using mobile.js is bad hack* [00:14:50] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c119 (10Kunal Mehta (Legoktm)) [17:05:11] legoktm: can you run those numbers for after july 10? [17:05:36] sure. [17:06:49] 219237 uploads overall [17:0... [00:14:57] Maryana: ^ [00:15:56] ty [00:16:34] dbrant: sent you the help icon [00:18:24] (03PS1) 10Kaldari: Making sure that upload rights are enforced on lazy-loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148560 (https://bugzilla.wikimedia.org/68414) [00:18:53] (03CR) 10JGonera: "See source code of any of the scripts in maintenance/. One that we contributed is checkLess.php. It seems it has been rewritten to use a T" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) (owner: 10Jdlrobson) [00:22:36] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c120 (10Ryan Kaldari) Patch for lazy-loading bug (bug 68414) checked in: https://gerrit.wikimedia.org/r/#/c/148560/ There's a decent chance this loophole is responsible for the discrepancy in upload... [00:26:21] jgonera, jdlrobson: would be great to get a psuedo-emergency review of https://gerrit.wikimedia.org/r/#/c/148560/ before Commons goes ballistic [00:27:07] (03CR) 10Jdlrobson: Add template dependency to Mantle extension (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [00:27:13] (03PS10) 10Jdlrobson: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 [00:28:15] (03CR) 10jenkins-bot: [V: 04-1] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [00:28:34] kaldari|2, so for normally loaded pages we check it in a different way? [00:29:19] (03CR) 10JGonera: Don't render page actions when none exist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147324 (owner: 10Jdlrobson) [00:29:50] jgonera: Yeah, see https://gerrit.wikimedia.org/r/#/c/143778/2/includes/skins/SkinMinerva.php [00:30:02] (03CR) 10JGonera: [C: 032] Don't render page actions when none exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147324 (owner: 10Jdlrobson) [00:30:25] thanks, d00ds [00:30:56] (03PS11) 10Jdlrobson: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 [00:31:26] kaldari|2, is $user->isAllowed( 'mf-uploadbutton' ) implemented in core? is "mf" mobilefrontend? [00:31:54] yeah, that's mobileFrontend [00:32:38] (03Merged) 10jenkins-bot: Don't render page actions when none exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147324 (owner: 10Jdlrobson) [00:33:01] kaldari|2, I mean, how does isAllowed know what "mf-uploadbutton". I'm asking out of curiosity [00:33:33] kaldari|2, ok, I think I see [00:33:34] MobileFrontend.php:162 [00:33:43] jgonera: See MobileFrontend.php [00:34:42] jgonera: There is an mw.user.getRights() function, but it's just a wrapper for an API call. [00:35:28] yeah, I am just seeing that we keep increasing the number of stuff we put in mw.settings and it begins to worry me, but that's not a problem with this patch in particular [00:35:32] jgonera: I could make an API call from Page.js instead if you think that's more sensible [00:36:50] kaldari|2, I think mw.settings is fine for now, I'm just not sure about the name. why do we use a wg prefix if it's not a global? [00:37:12] eh, nevermind, we do the same with imagesDisabled [00:37:17] jgonera: no idea :) [00:37:32] I guess that part of codebase needs some clean up [00:37:49] (03CR) 10JGonera: [C: 032] Making sure that upload rights are enforced on lazy-loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148560 (https://bugzilla.wikimedia.org/68414) (owner: 10Kaldari) [00:38:01] jgonera: Thanks! [00:38:28] also there's this in this sprint: https://trello.com/c/MuE5Ysov/2-spike-decide-whether-ajax-page-loading-needs-to-be-kept-for-editing-workflow [00:38:30] (03Merged) 10jenkins-bot: Making sure that upload rights are enforced on lazy-loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148560 (https://bugzilla.wikimedia.org/68414) (owner: 10Kaldari) [00:38:33] … just sayin' :) [00:39:53] 3MobileFrontend / 3General/Unknown: Lazy-loaded pages are not enforcing upload restrictions on mobile - 10https://bugzilla.wikimedia.org/68414 (10Ryan Kaldari) 5PATC>3RESO/FIX [00:40:42] 3MobileFrontend / 3General/Unknown: Lazy-loaded pages are not enforcing upload restrictions on mobile - 10https://bugzilla.wikimedia.org/68414 (10Ryan Kaldari) [00:40:42] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598 (10Ryan Kaldari) [00:44:26] (03CR) 10JGonera: [C: 04-1] Add template dependency to Mantle extension (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [00:49:37] * awjr waves to kristenlans [00:50:12] Howdy all! [00:50:56] kristenlans: hey! [00:51:01] (03CR) 10JGonera: "That's not strange at all ;) That's because I scroll the content within a div only on iOS, on Android using position: fixed for the header" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) (owner: 10JGonera) [00:51:46] kristenlans https://meta.wikimedia.org/wiki/IRC/Cloaks [01:12:06] 3MobileFrontend / 3General/Unknown: Mobile site not respecting desktop opt-out on iPad - 10https://bugzilla.wikimedia.org/68347#c3 (10Maryana Pinchuk) Spotted & reported by another user: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#My_preference_for_the_desktop_version_of_Wikipedia_on... [01:27:22] 3Wikipedia App / 3Android App: Some images are not readable after turning on night mode - 10https://bugzilla.wikimedia.org/68408#c1 (10Dan Garry) Mainly an issue with transparent images, I think. [03:41:33] (03PS1) 10Mhurd: Tweaks to the abuse filter alerts. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148592 [03:43:46] brion: ^ [03:46:37] (03PS2) 10Mhurd: Tweaks to the abuse filter alerts. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148592 [05:32:07] 3MobileFrontend / 3General/Unknown: Lazy-loaded pages are not enforcing upload restrictions on mobile - 10https://bugzilla.wikimedia.org/68414#c4 (10Florian) Maybe we should think about to check permission to upload in PhotoApi.js, too? [06:12:35] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c121 (10Lupo) (In reply to Maryana Pinchuk from comment #114) > @Lupo, I'm getting the numbers directly from the Commons database. Here's my > SQL if anyone with access to the database wants to doubl... [06:56:56] (03CR) 10Florianschmidtwelzow: "> Still seeing a link to the following url which references undefined!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [07:06:46] (03PS19) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [07:18:21] 3MobileFrontend / 3General/Unknown: Lazy-loaded pages are not enforcing upload restrictions on mobile - 10https://bugzilla.wikimedia.org/68414#c5 (10Lupo) @Ryan: when will this be live? [07:20:52] (03PS1) 10Florianschmidtwelzow: Making sure that upload rights are enforced on lazy-loaded pages [extensions/MobileFrontend] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148605 (https://bugzilla.wikimedia.org/68414) [07:24:59] (03CR) 10Florianschmidtwelzow: "@MaxSem/Kaldari: Can this be deployed in commons/group1-wikis, too, before wmf15?" [extensions/MobileFrontend] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148605 (https://bugzilla.wikimedia.org/68414) (owner: 10Florianschmidtwelzow) [07:28:51] 3MobileFrontend / 3General/Unknown: Lazy-loaded pages are not enforcing upload restrictions on mobile - 10https://bugzilla.wikimedia.org/68414#c7 (10Florian) > when will this be live? In actual status: on Commons with release of MW1.24wmf15, which will be deployed on at July, 29 2014. Maybe earlier if it wi... [08:14:29] (03PS1) 10Florianschmidtwelzow: Redirect to mobile diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) [08:44:55] 3MobileFrontend / 3Feature requests: configuration variable to turn on or off particular footer links (both on desktop and mobile) - 10https://bugzilla.wikimedia.org/64275#c2 (10Florian) @Mobile-Team: Is it still actual, that privacy message must be an own message key? I ask because for about and disclaimer... [09:33:53] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c122 (10Lupo) BTW, since we're all so focused on "statistics" right now, a cautionary note: If the statistics say X% were deleted, that does *not* mean that the remaining (100-X)% were OK. I just w... [10:05:10] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c123 (10Rainer Rillke @commons.wikimedia) I just want to emphasize that hosting copyright violation is a crime in certain countries. There were a few bills (DMCA safe harbour) that allows WMF to oper... [12:10:35] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c124 (10Florian) (In reply to Gerrit Notification Bot from comment #63) > Change 143822 merged by jenkins-bot: > Show Uploadbutton only when user has the permission > > https://gerrit.wikimedia.org/... [12:16:06] 3MobileFrontend / 3stable: Some Mobile/Web uploads without or with corrupted information - 10https://bugzilla.wikimedia.org/68321#c10 (10Lupo) (In reply to Maryana Pinchuk from comment #9) > I asked Keilana to clarify how she uploaded her image. Here's her response: > > "@Maryana (WMF): Hi Maryana, I was do... [12:16:25] 3MobileFrontend / 3stable: Improve mobile uploads (tracking) - 10https://bugzilla.wikimedia.org/68376 (10Florian) [12:16:25] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598 (10Florian) [12:16:25] 3MobileFrontend / 3stable: Don't hide link Special:Uploads for non-autoconfirmed users - 10https://bugzilla.wikimedia.org/68435 (10Florian) 3NEW p:3Unprio s:3normal a:3None With a patch of Bug #62598 (https://gerrit.wikimedia.org/r/#/c/143778/) we hide the link to page Special:Uploads for users, who... [12:16:25] 3MobileFrontend / 3stable: Upload icon for anon no longer appears - 10https://bugzilla.wikimedia.org/66375 (10Florian) [12:17:50] 3MobileFrontend / 3stable: Don't hide link Special:Uploads for non-autoconfirmed users - 10https://bugzilla.wikimedia.org/68435 (10Florian) [12:17:52] 3MobileFrontend / 3stable: Upload icon for anon no longer appears - 10https://bugzilla.wikimedia.org/66375 (10Florian) [12:19:05] 3MobileFrontend / 3stable: Some Mobile/Web uploads without or with corrupted information - 10https://bugzilla.wikimedia.org/68321#c11 (10Lupo) (In reply to Lupo from comment #10) > (In reply to Maryana Pinchuk from comment #9) > > I asked Keilana to clarify how she uploaded her image. Here's her response: >... [12:20:35] 3MobileFrontend / 3stable: Don't hide link Special:Uploads for non-autoconfirmed users - 10https://bugzilla.wikimedia.org/68435#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/bIhzbqfP [13:18:53] 3Wikipedia App / 3Android App: Add search functionallity - 10https://bugzilla.wikimedia.org/68438 (10Florian) 3NEW p:3Unprio s:3major a:3None There are some tickets for this, see te main one: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7659615 (and connected) The Wikip... [13:52:37] (03PS5) 10Dbrant: Show number of matches when finding in page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147761 (owner: 10Alex Monk) [14:06:50] (03PS6) 10Dbrant: Support identification of APK channel distribution. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147512 (owner: 10Dr0ptp4kt) [14:09:17] YuviPanda: dr0ptp4kt: ^ manually rebased to work with our new PrefKeys scheme. [14:39:06] 3MobileFrontend / 3stable: Improve Mobile/Web upload page Special:Uploads - 10https://bugzilla.wikimedia.org/68375#c2 (10Lupo) (In reply to Lupo from comment #0) > All in all, this looks like a nicely streamlined upload process with only > one (big) problem: how to make users understand that they absolutely... [15:02:44] YuviPanda: Suup. [15:02:59] * YuviPanda waves at Deskana and dbrant [15:03:02] dbrant: looking at that patch now [15:03:04] hi Deskana [15:03:04] 'sup [15:03:18] YuviPanda, dbrant: I may need to miss the standup due to Katherine urgently needing me for iOS comms stuff. [15:03:26] ah, 'tis ok. [15:03:33] np! [15:03:38] Deskana: you might want to mail in an update, that's what we usually do [15:04:03] That's my number 1 priority, especially since the comms for this is unified and much of it won't refer specifically to iOS but to both apps. [15:04:07] Both apps stand to benefit a lot. [15:04:15] So that's more important than a standup. :) [15:04:29] YuviPanda: Sure, I can mail in a status update. I'll just say "Read my mobile-l post from last night :P [15:04:40] Deskana: :D [15:15:37] 3MobileFrontend / 3stable: Improve Mobile/Web upload page Special:Uploads - 10https://bugzilla.wikimedia.org/68375#c3 (10Florian) Maybe it is possible, that we add a link above the upload summary with the title "Please read the notices before upload your media" (like the "This page has issues", e.g. https://... [15:16:46] man, apple needs a better bug tracker. i filed a bug for webgl being completely broken in the latest ios 8 beta; they marked it as a duplicate of bug 17750228 but *i have no way to see any information about that bug* since i didn’t report it myself. [15:16:49] all i know is the number [15:16:50] srsly? [15:24:48] brion: I'm afraid that that issue is a duplicate too, of bug number lolsux2bu. [15:25:00] brion: But you can't check that bug either. :( [15:25:44] * Deskana giggles. [15:25:53] d’oh [16:07:13] (03PS4) 10Dbrant: [WIP] Add first-time editing onboarding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148436 [16:51:17] Hi YuviPanda dbrant: Ran into some issues installing Mediawiki-vagrant on my Mac. The setup script failed to install nokogiri (1.6.3.1). Have you run into something like that? [16:52:09] bearND: i haven't seen that... [16:53:06] bearND: hmm, me neither [16:53:21] bearND: can you pastebin the error? also what is your os x version? [16:55:35] YuviPanda: http://pastebin.com/tvwNMcx9 [16:56:10] bearND: ah, run it as sudo? [16:56:16] seems to be a permission problem [16:56:45] YuviPanda: I tried the setup.sh without and then with sudo [16:57:19] bearND: can you run the code on line 33 of that paste with sudo? [16:57:39] YuviPanda: see line 38 [16:57:47] bah [16:58:04] YuviPanda: i shouldn't have turned on syntax coloring [16:58:33] bearND: http://stackoverflow.com/a/6163052 [16:58:33] ? [16:59:00] YuviPanda: trying... [16:59:48] YuviPanda: 2nd command already fails: brew install libiconv [16:59:48] Error: No available formula for libiconv [17:00:19] bearND: oh? did you do an update first? it works for me [17:00:27] bearND: which os x version are you on? [17:01:42] YuviPanda: yes, I did the update first; I'm on 10.9.4. [17:02:17] bearND: hmm, maybe 'If you're running Mavericks, you may need to install Xcode's command line tools: xcode-select --install. This fixed the problem for me'? [17:02:21] I don't know why it's even using nokigiri [17:02:28] bearND: let's ask the experts, come over to #wikimedia-dev? [17:06:14] (03PS1) 10Bartosz Dziewoński: modules.js: Remove backwards-compatibility mw.loader call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148704 [17:28:12] YuviPanda: bearND: who's ready for a production release? [17:28:18] WEEEEEEE :) [17:28:33] dbrant: I guess we just take the last beta and just release that? [17:29:37] YuviPanda: so how would that work, git-wise? (and script-wise)? [17:31:41] Deskana: sorry, I missed the standup too [17:32:48] FlorianSW: Thanks for creating the deployment branch, I'll go ahead and add it to the SWAT deployment schedule [17:33:14] dr0ptp4kt: you mentioned something about release scripts at the end of standup? Which script are you talking about (make-release.sh or make-beta.py)? [17:33:55] Kaldari: Yeah, np :) But the question is, if this patch will be in wmf13, too (for commons)? [17:34:17] brion, mhurd: Is our new app version 4? [17:34:19] dr0ptp4kt: just wanted to make sure you know that we're not planning on improving the make-release.sh script and making the make-beta.py python script the base for the future release script [17:34:25] Deskana: yes [17:34:38] version 2 on android, 4 on ios [17:37:50] (03CR) 10Brion VIBBER: [C: 031] "Looks good so far -- lemme know when tweaks are ready" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148592 (owner: 10Mhurd) [17:38:03] brion: cool will do! :) [17:38:51] brion: Thanks. [17:39:20] FlorianSW: No need for wmf13, wmf13 should be gone tomorrow [17:39:22] dbrant: bearND sorry, got disconnected again [17:39:24] * YuviPanda reads logs [17:39:46] dbrant: I presume we'll just have a tag named releases/2.0-r- [17:39:58] bearND: and yeah, make-beta should probably be the base [17:40:41] bearND: dbrant Chat quickly about design blockers? [17:40:45] Kaldari: Yeah, but Commons (for what we "really" made this ps) is on wmf14 since yesterday and will be see this ps at wmf15 next week :/ [17:40:55] vbamba: sure [17:41:49] What might be the best way to do this? [17:41:54] Quick Hangout? [17:41:59] yep [17:42:08] vbamba: actually there are no design related blockers for the page issues story on my side [17:42:15] FlorianSW: We should still be fine. wmf15 doesn't get cut until tomorrow so it will have the patch automatically [17:42:20] Tomaz said there were two stories with blockers [17:42:53] Kaldari: yes, i know, but i thought to get the ps faster to commons :D but ok :) [17:43:09] dbrant: do you remember what the blocked stories were? [17:43:10] dbrant: anything on your end? [17:43:15] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148592 (owner: 10Mhurd) [17:43:47] vbamba: bearND: well, one of them is mine (first-time editing), but i'm not sure what the second is. [17:44:29] dbrant: On track for the push to production? [17:44:43] greg-g: Any idea why commons is still on wmf13? Has it been moved to group2? [17:44:44] Deskana: totally! [17:44:48] Yay! [17:45:12] dbrant: i guess it's only one blocker then [17:45:27] FlorianSW: well, one day isn't too long to wait :) [17:45:27] kaldari: "my" commons is on wmf14: https://commons.wikimedia.org/wiki/Special:Version [17:46:24] kaldari: one day? [17:46:40] commons will get the next update at July 29, if i'm right?! :) [17:46:53] hi. who's the best person to pester about Minerva things? [17:47:20] MatmaRex: Just ask :D [17:47:26] We will see who answer :P [17:47:30] i'm wondering if they, whoever that is, saw https://gerrit.wikimedia.org/r/#/c/141259/ in core :D "resourceloader: Allow skins to provide additional styles for any module" [17:47:30] greg-g, FlorianSW: Nevermind, I was looking at a cached version of the Commons main page which still reports as wmf13 :P [17:47:50] kaldari: Cool :P :D [17:47:50] looks like that would let you get rid of $wgMinervaSpecialPageModules [17:48:02] and some other things that are all marked as TODO FIXME [17:48:21] dbrant, sure we can jump on a quick call for first time editing [17:48:22] FlorianSW: so Commons should get the patch today then as soon as the deployment branch you created is deployed by the SWAT team [17:49:03] vbamba: yep! [17:49:27] and further i am wondering if these persons would like to try using the new feature in Minerva and possibly comment on its usefulness, or if i'll have to just do it myself ;) [17:49:29] kaldari: ah, ok :) So a merge into a deployed branch will be deployed to any wikimedia wiki already has the version? :) [17:49:33] I'm exhausted already. [17:49:35] * Deskana sighs. [17:49:41] 3MobileFrontend / 3stable: Don't hide link Special:Uploads for non-autoconfirmed users - 10https://bugzilla.wikimedia.org/68435#c2 (10Maryana Pinchuk) We thought about doing it that way (showing Uploads and simply hiding the upload button). The problem is that the vast majority of non-autoconfirmed users are... [17:49:41] 3MobileFrontend / 3General/Unknown: Lazy-loaded pages are not enforcing upload restrictions on mobile - 10https://bugzilla.wikimedia.org/68414#c8 (10Ryan Kaldari) @Lupo: I put it on the SWAT schedule so it should go out to Commons by the end of today. [17:50:13] FlorianSW: correct [17:50:20] kaldari: ah, ok, thanks :) [17:51:00] YuviPanda: so, are we creating a new script for release builds now, or will we do this one manually? [17:52:39] (03CR) 10Kaldari: [C: 031] Making sure that upload rights are enforced on lazy-loaded pages [extensions/MobileFrontend] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148605 (https://bugzilla.wikimedia.org/68414) (owner: 10Florianschmidtwelzow) [17:53:55] dbrant: let's do this one manually [17:54:25] YuviPanda: dbrant: git checkout releases/2.0-beta-2014-07-18 [17:54:47] yeah, make an increment commit, push it, and publish? [17:54:48] bearND: Do you really have page issues finished? [17:55:55] YuviPanda: dbrant and then increment the versionCode and update versionName manually. Would need to create a local branch if you want to commit [17:56:48] (03CR) 10JGonera: [C: 032] "Thanks! I noticed that just yesterday and was going to push a patch today ;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148704 (owner: 10Bartosz Dziewoński) [17:56:53] vbamba: No, it's not finished. I changed the dialog yesterday to split off the date into a separate TextView to look like you wanted, but I still need to style the link in the WebView to look like a flag button [17:57:26] (03Merged) 10jenkins-bot: modules.js: Remove backwards-compatibility mw.loader call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148704 (owner: 10Bartosz Dziewoński) [17:57:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148436 (owner: 10Dbrant) [17:58:03] jgonera: So bugs 61966, 64686, 65041, and 67639 are all specific effects of bug 60848 (which is marked as WONTFIX). I talked to Jon about it yesterday and he prefers leaving it as WONTFIX since it's risky to change. I'm fine with trying to fix each case individually, but I wanted to get your opinion as well. [17:58:04] vbamba: I'm just saying that I'm not blocked on design since I got the flag icons from you and you already told me what colors to use [17:58:31] YuviPanda: bearND: so the versionName format shall be "2.0-2014-07-23"? [17:58:32] kaldari you're coming tomorrow, rsvp so i can get you lunch? [17:58:40] dbrant: let's put an 'r' in the middle [17:58:46] dbrant: 2.0-r-2014-07-23 [17:58:51] ah right [17:59:02] or 'RTM', or 'release' or some other string, the shorter the better [17:59:14] violetto: tomorrow? [17:59:25] YuviPanda: on your page you skipped the dash after the r [17:59:47] violetto: ah, found it :) [17:59:48] YuviPanda: but this is easier for parsing and scripting [17:59:52] yeah [18:01:42] kaldari: xiexie [18:01:52] jgonera can you add kristen to the code review conversation invite? [18:01:52] ? [18:02:02] awjr, sure [18:02:06] thanks :) [18:02:16] soooo. minerva, anyone? [18:03:07] YuviPanda: dbrant: we should create and push an annotated tag again with releases/2.0-r-2014-07-23 [18:03:14] yup [18:03:15] bearND: thanks, will redirect my energy to the python script instead of the bash script [18:05:06] Where's the APK that has our latest work in it? [18:05:21] yurikSPB: able to get https://gerrit.wikimedia.org/r/#/c/147138/ into the deployment today? [18:05:26] bearND: just for my [ahem] knowledge, what would be the git steps for that? I've checked out the beta release branch, and now updated the versionCode and versionName... [18:05:33] I'd love to take a look at how things are going with the article issues stuff. [18:05:37] dr0ptp4kt, almost [18:06:35] (03PS7) 10Yurik: Make zerodot landing page fast and have search. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 (owner: 10Dr0ptp4kt) [18:07:07] (03CR) 10Yurik: [C: 032] Make zerodot landing page fast and have search. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 (owner: 10Dr0ptp4kt) [18:07:18] (03Merged) 10jenkins-bot: Make zerodot landing page fast and have search. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/147138 (owner: 10Dr0ptp4kt) [18:07:53] omg [18:07:54] Seriously [18:07:58] yurikSPB: thx. sorry about that. i was fixing tabbing manually. then i realized that my phpstorm settings had disappeared. then i reinstated the mediawiki style code editor settings. but didn't fix that. thanks! [18:07:59] I'm going to go and lie on the hammock [18:08:23] dr0ptp4kt, np, btw, are you opening phpstorm from the root dir of vagrant? [18:08:40] yurikSPB: yes [18:08:51] it should have picked it up... strange [18:09:03] dbrant: i think you want to do this directly on the freshly checkout commit: step 1: git tag -a releases/2.0-r-2014-07-23 [18:09:31] dbrant: step 2: (once it all worked): git push gerrit releases/2.0-r-2014-07-23 [18:10:02] dbrant: same is already in the make-beta.py script [18:10:09] mhurd: are you working on references now? [18:10:21] vbamba: starting in a few minutes [18:10:49] brion, mhurd: Our new app is so good that someone cloned it and put ads in it. [18:10:52] 3MobileFrontend / 3General/Unknown: Lazy-loaded pages are not enforcing upload restrictions on mobile - 10https://bugzilla.wikimedia.org/68414#c9 (10Lupo) Cool, thanks! [18:10:54] dbrant: amending step1: also add -m with a commit message [18:10:56] brion, mhurd: Download "wikifu". [18:10:57] awesome [18:10:58] lol [18:11:22] bearND: alright! thanks [18:11:26] dbrant: I think it would be good in the future to use the versionCode as the commit message and maybe the build type, too [18:11:30] It's got onboarding and everything. [18:11:31] haha [18:11:46] ...and the old more menu. [18:11:49] Fail. [18:12:01] YuviPanda: would you be able to do final code review on https://gerrit.wikimedia.org/r/#/c/147512/ ? [18:12:14] YuviPanda: any thoughts about commit message for git tag -a? [18:12:14] Deskana: wow, that was... unexpected. [18:12:41] I told Luis. [18:12:44] I'm not sure I really care. [18:12:58] bearND: 'release '? [18:14:06] Deskana: there are also ads in it [18:14:19] YuviPanda: I said that. :) [18:14:33] oh [18:14:34] (03PS3) 10Mhurd: Tweaks to the abuse filter alerts. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148592 [18:14:40] brion: ^ [18:14:41] Today's been a bad day for reading comprehension [18:14:58] YuviPanda: And for my brain, apparently. I'm totally fried and I only got here an hour ago. [18:15:02] dr0ptp4kt, could you poke at beta for a bit? [18:15:12] just to double check that it works ok? [18:15:46] yurikSPB: will do. caveat emptor: hhvm is purportedly causing some things on beta labs. but i'll test anyway [18:17:24] brion, mhurd, YuviPanda: They point to our git repo in the app description. So, we don't care. :) [18:17:37] :DD [18:17:39] yurikSPB: what headers do i need to forge on en.m.wikipedia.beta.wmflabs.org to test? which x-cs? [18:17:47] Deskana: haha [18:18:03] :) [18:18:11] dr0ptp4kt, don't remember, TEST i think. Check zero.wikimedia.... [18:18:17] (the betalabs one0 [18:18:26] TEST1 exists [18:18:36] dr0ptp4kt, also ZM2-SO [18:18:53] violetto: bú kè qì [18:22:08] Deskana: Shouldn't they change the developer's web site link? [18:22:29] bearND: I doubt they paid that much attention. [18:22:37] kaldari: -blush-! [18:23:18] Got one rating — from the publisher, lol [18:25:01] yurikSPB: do you have any success forging X-Subdomain on http://en.m.wikipedia.beta.wmflabs.org/wiki/San_Francisco ? what's the url for the zero portal on beta labs, and what's the login procedure? [18:25:06] (03CR) 10Brion VIBBER: [C: 032 V: 032] Tweaks to the abuse filter alerts. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148592 (owner: 10Mhurd) [18:25:43] dr0ptp4kt, zero.wikimedia.beta.wmflabs.org [18:26:03] dr0ptp4kt yurikSPB in the SoS notes, someone added '* New card: waiting for analytics to start using Zero API (they know about it, just want to put it into SoS)' - is this in progress/blocked/?? [18:26:22] awjr, i did - we are blocked on that [18:28:19] yurikSPB: i don't think i have a login on zero.wikimedia.beta.wmflabs.org [18:28:28] dr0ptp4kt, create it [18:28:47] yurikSPB okidoke, thanks [18:30:24] yurikSPB: http://zero.wikimedia.beta.wmflabs.org/w/index.php?title=Special:UserLogin&type=signup&returnto=Main+Page&campaign=loginCTA permission denied [18:32:41] (03PS1) 10Bartosz Dziewoński: Make Minerva's skin name translatable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148727 [18:32:54] minerrrrvaaaaaaa [18:33:07] who's working on minerva these days? anyone? [18:34:48] (03PS3) 10Mhurd: References click backend: detect link clicks and send data over bridge [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148247 (owner: 10Brion VIBBER) [18:36:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148727 (owner: 10Bartosz Dziewoński) [18:39:22] 3MobileFrontend / 3stable: Don't hide link Special:Uploads for non-autoconfirmed users - 10https://bugzilla.wikimedia.org/68435#c3 (10Florian) 5NEW>3RESO/WON > the vast majority of non-autoconfirmed users aren't going to have any uploads Ah, ok, yeah, if this is so, then that makes sense :D [18:43:29] YuviPanda: were you planning to work on https://trello.com/c/lADtYeQl ? [18:43:56] dbrant: I did a bit of research on it, but feel free to pick it up [18:44:14] dbrant: I left info and links on the card [18:48:09] (03PS1) 10Dr0ptp4kt: Remove LT and GT symbols around search button on zerodot. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148731 [18:48:20] yurikSPB: ^ [18:48:40] dr0ptp4kt, looking [18:49:20] (03CR) 10Yurik: [C: 032] Remove LT and GT symbols around search button on zerodot. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148731 (owner: 10Dr0ptp4kt) [18:50:59] Deskana: dbrant: when are we promoting the beta today? [18:54:54] tfinc: Deskana: just doing a final run-through before uploading to the Play Store... Will upload within ~30min [19:03:06] (03Merged) 10jenkins-bot: Remove LT and GT symbols around search button on zerodot. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148731 (owner: 10Dr0ptp4kt) [19:08:45] jgonera MaxSem I've seen a few failed saves from MF/VE recently that just say "Error, edit not saved". Nothing in fatal.log. example: https://saucelabs.com/jobs/74308f2ac6074645b1fe45d22c5e6bc1. In dberror.log I see... [19:09:04] WikiPage::doEditContent: Transaction already in progress (from DatabaseBase::begin), performing implicit commit! . Could that be related? [19:18:41] Deskana: would you like to approve the "what's new" text for the Play Store? http://etherpad.wikimedia.org/p/play_store_what%27s_new cc YuviPanda bearND|food [19:18:51] looking [19:19:13] dbrant: night mode isn't back, since it was never there in the released versions (only in beta) [19:19:22] dbrant: other than that looks good [19:19:32] YuviPanda: wasn't it in the PhoneGap app? [19:19:36] dbrant: nope [19:19:38] dbrant: it was in the app in beta [19:19:41] dbrant: it never mde it to prod [19:20:02] YuviPanda: well dip me in butter and call be a biscuit. [19:20:10] * YuviPanda calls dbrant a biscuit [19:20:57] (03CR) 10Nikerabbit: Remove LT and GT symbols around search button on zerodot. (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148731 (owner: 10Dr0ptp4kt) [19:24:23] 3MobileFrontend / 3General/Unknown: edit save failure, no discernible diagnostics - 10https://bugzilla.wikimedia.org/68465 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16017 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16017&action=edit Save error I have seen a num... [19:25:37] 3MobileFrontend / 3General/Unknown: edit save failure, no discernible diagnostics - 10https://bugzilla.wikimedia.org/68465#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/4FzEwxyE [19:28:42] YuviPanda: fyi, filed a bug about the vagrant issues: https://bugzilla.wikimedia.org/show_bug.cgi?id=68453 [19:28:58] bearND: yeah, saw that :D bd808 is looking into it, I think, from the comments there [19:39:35] 3MobileFrontend / 3General/Unknown: edit save failure, no discernible diagnostics - 10https://bugzilla.wikimedia.org/68465#c2 (10Chris McMahon) Happening consistently in this test, regardless of browser: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linu... [19:41:36] (03CR) 10Dr0ptp4kt: Remove LT and GT symbols around search button on zerodot. (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148731 (owner: 10Dr0ptp4kt) [19:41:52] 3MobileFrontend / 3General/Unknown: edit save failure, no discernible diagnostics - 10https://bugzilla.wikimedia.org/68465#c3 (10Chris McMahon) Oh, and the dberror.log seems to be unrelated, sorry about that. [19:42:08] yurikSPB:^ ^ i don't think we technically need this patch, although i do think we need the message cache updated. [19:43:16] yurikSPB: do you wanna revert https://gerrit.wikimedia.org/r/#/c/148731/ ? [19:54:10] Deskana: ping [19:57:52] dr0ptp4kt, interviwing, will be back in a bit [19:58:00] yurikSPB: thx [19:58:02] dbrant: Ssuuuup [19:58:30] dbrant: Oh, you can approve the What's New stuff. I trust you. :) [19:58:44] Deskana: alright! :) [19:59:01] Deskana: then, it is done! [20:00:15] Maryana: will the mobile uploads isuisse fixed in the next days? [20:04:36] 3MobileFrontend / 3General/Unknown: edit save failure, no discernible diagnostics - 10https://bugzilla.wikimedia.org/68465#c4 (10Chris McMahon) Seems likely this is HHVM related, adding Ori and Bryan [20:06:18] dbrant: \o/ [20:14:39] YuviPanda: is there a way to test the Mobile extension without vagrant (since I'm blocked on that)? [20:14:48] MobileApp [20:15:16] bearND: hmm, you can install XAMPP and then setup apache, mysql, php locally and then setup mediawiki and *then* setup extension:mobileapp... [20:18:22] bearND: I could also potentially setup a Labs VM with all of this and you can work there, if you want. still hacky, though [20:18:38] bearND: my suggestion is to finish the rest of it and get it polished and merged, and then come back to this one :) [20:19:09] YuviPanda: Is there a README for the extension? How do I install it? [20:19:15] bearND: Can we please see page issues! If its done ? [20:19:16] Maryana: have you been a user of contacts.wikimedia.org ? [20:19:23] http://hatjitsu.wmflabs.org/76244 [20:19:26] bearND: https://www.mediawiki.org/wiki/Extension:MobileApp [20:20:01] bearND: it also requires that you have https://www.mediawiki.org/wiki/Extension:MobileFrontend installed [20:20:06] bearND: which in turn requires you've other stuff installed [20:20:15] oh dear, my IRC client is swallowing things. brb [20:20:36] ReferenceError: Can’t find variable: flase [20:20:37] *headdesk* [20:20:50] bearND: so you'll need to install https://www.mediawiki.org/wiki/Extension:MobileFrontend as well [20:20:52] bearND: which in turn has other dependencies [20:21:01] dbrant: are you going to push a tagged revision for the prod release to gerrit? i was hoping to fork from there with a build for the amazon appstore. i'll need to cherrypick the user-agent thing and do some amazon appstore-specific stuff, buit otherwise would plan to use the same build [20:22:12] YuviPanda: sorry to be such a pain, but could i get your +2 on https://gerrit.wikimedia.org/r/#/c/147512/ ? [20:22:43] dr0ptp4kt: gah, sorry. I'm doing it now [20:22:49] * YuviPanda has had a terrible week in terms of productivity so far [20:26:21] YuviPanda: thanks for your help [20:26:44] vbamba: I'll send you an apk soon. will need to do the flag button later [20:26:44] bearND: so, I've done the following: checked out the beta branch, made a local branch, bumped the version number, committed it, made a tag from it, and pushed the tag to gerrit. However... [20:26:48] dr0ptp4kt: hmm, adding a value in the bearND: ...when I pull from gerrit on another computer, I don't see the new tag. [20:27:23] bearND: sounds great, whenever you are ready. no rush. looks like you guys are busy right now. [20:27:50] dr0ptp4kt: how did you push the tag? [20:27:52] err [20:27:53] dbrant: [20:28:00] dr0ptp4kt: huh? [20:28:08] dbrant: I think you'll have to tag the commit that is actually pushed to gerrit [20:28:10] i mean YuviPanda , what's this? [20:28:26] Google Play [20:28:34] D/Wikipedia(29573): WikipediaApp/2.0-alpha-2014-07-10 (Android 4.4.4; Phone) [20:28:37] dr0ptp4kt: ^ [20:28:44] YuviPanda: oh. change the "value" field [20:28:46] dr0ptp4kt: on tracking patch [20:28:51] dr0ptp4kt: I... am an idiot [20:29:24] YuviPanda: note, you may need to clear your app data, as its value is probably committed as an empty string :) [20:29:35] YuviPanda: bearND: "git push gerrit releases/2.0-r-2014-07-23" is what I did. [20:29:53] dbrant: I think you need to add a --tags parameter [20:32:57] dbrant: i don't think you can tag a local commit and push it to gerrit later [20:33:12] oh, that as well [20:33:15] unless you push the commit as well [20:33:24] dbrant: you need to push the 'increment' commit and get that merged too [20:37:02] YuviPanda: bearND: ...but it didn't give any errors, and it said " * [new tag] releases/2.0-r-2014-07-23 -> releases/2.0-r-2014-07-23" [20:37:10] oh. [20:37:12] that's... weird [20:37:16] I did a fetch and got no tags [20:37:31] dbrant: perhaps, your tag refers to a commit that doesn't exist in gerrit in a merged state, so gerrit just got confused? [20:38:21] YuviPanda: so then, how do I push just the 'increment' commit? [20:38:41] dbrant: git push gerrit :refs/for/master [20:39:36] yurikSPB: going to a meeting. hit me on my cell if you need me. will let you know when i'm back from the meeting [20:40:50] (03CR) 10Yuvipanda: [C: 032] "Works as advertised!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147512 (owner: 10Dr0ptp4kt) [20:40:52] (03PS1) 10Dbrant: release 73 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148764 [20:40:54] dr0ptp4kt: merged. and apologies for the delay [20:42:06] (03CR) 10Dbrant: [C: 032] release 73 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148764 (owner: 10Dbrant) [20:42:33] MaxSem: kristenlans [20:43:28] (03CR) 10BearND: release 73 (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148764 (owner: 10Dbrant) [20:44:20] bearND: ah damn it; we'll sync up in the next one. [20:44:30] dbrant: yeah, np [20:47:14] jenkins seems stuck [20:47:22] yep... [20:48:08] https://en.wikipedia.org/w/index.php?title=User:KLOLvonJoulupukki&action=edit&redlink=1 [20:48:10] Our lovely new scrum master ^_^ [20:49:04] What a name! [20:52:40] (03Merged) 10jenkins-bot: Support identification of APK channel distribution. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147512 (owner: 10Dr0ptp4kt) [20:52:42] (03Merged) 10jenkins-bot: release 73 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148764 (owner: 10Dbrant) [20:54:37] (03PS1) 10Yurik: Revert "Remove LT and GT symbols around search button on zerodot." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148830 [20:55:02] (03CR) 10Yurik: [C: 032] Revert "Remove LT and GT symbols around search button on zerodot." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148830 (owner: 10Yurik) [20:56:23] 3MobileFrontend / 3stable: Improve Mobile/Web upload page Special:Uploads - 10https://bugzilla.wikimedia.org/68375#c4 (10Jon) I wonder if the design should have some kind of screen saying 'Did you take this photo?" with YES NO buttons. On clicking No, the user could be informed that we don't accept uploads n... [20:57:14] dbrant: hmmm, it got merged but the tag is still not showing up (https://git.wikimedia.org/summary/apps%2Fandroid%2Fwikipedia) [20:57:44] bearND: yep, and I can't push it again (already exists). [20:57:44] dr0ptp4kt, reverted dbl-escaping patch (didn't deploy it, so its ok. Thx nikerabbit on that one) [20:59:00] YuviPanda, remind me what's going on with search in the android app? [20:59:10] It just does a basic prefixsearch right? [20:59:19] Krenair: right now? it uses action=opensearch, which is just a basic prefixsearch, yeah [20:59:30] And we need MW core to fix that [20:59:36] is there a bug for that? [20:59:40] Krenair: probably, or switch to a different method [20:59:54] Krenair: OpenSearch is theoretically a standard, and it's doing what it should do [21:00:04] Krenair: what we should be doing is using the search API with intitle:, but we aren't doing that [21:00:12] Yeah, but a lot of people are annoyed that it's nowhere near as good as the desktop search [21:00:27] (03PS1) 10Brion VIBBER: Apply infobox-moving transform from Android [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148832 [21:00:39] 3MobileFrontend / 3stable: Improve Mobile/Web upload page Special:Uploads - 10https://bugzilla.wikimedia.org/68375#c5 (10Daniel Zahn) mobile or not, there can be photos that the user did not take themselves but that are perfectly fine for upload, like images from public domain sources etc. [21:00:51] Oh, hang on: https://www.mediawiki.org/wiki/API:Search [21:00:55] i don’t think opensearch requires thta you do prefix searches [21:00:57] we could make it better [21:00:58] stronger [21:00:58] Krenair: indeed, so that's what we should be using [21:00:59] faster [21:01:04] chad has the technology [21:01:05] Isn't that what we want? [21:01:06] brion: we should just use what Krenair pointed to [21:01:08] Krenair: indeed [21:01:10] :D [21:01:19] Okay. Who wants to make the changes to the app to do that? [21:01:36] Krenair: we just don't have it implemented, and Deskana|Away says it's not in this sprint... [21:01:42] Krenair: I can take a look tomorrow. I'm worried about speed [21:01:50] but let's give it a shot and see how it performs :) [21:02:29] bearND: should I just make another tag with a slightly different name? [21:03:20] 3MobileFrontend / 3stable: Improve Mobile/Web upload page Special:Uploads - 10https://bugzilla.wikimedia.org/68375#c6 (10Jon) Sure.. but as I understand it the issue here is wanting to stop mobile users uploading photos from the web no? We should fix that problem first. [21:03:45] dbrant: hmm, thinking of this I think we actually don't want to tag the commit you just made and that got merged [21:04:28] dbrant: we want to tag the same commit that was used for the last beta release since that's what the code you used to build is based on [21:04:50] 3MobileFrontend / 3stable: Improve Mobile/Web upload page Special:Uploads - 10https://bugzilla.wikimedia.org/68375#c7 (10Max Semenik) Okay, during today's meting we decided that we will set a hard minimum limit of edits for uploads (we'll try to do that by tomorrow). If that doesn't work after a week or some... [21:05:54] bearND: I thought a "tag" was something that someone could check out, and build precisely what is released at that time? [21:06:01] dbrant: can you delete your old tag? [21:06:43] dbrant: yes, that's true. but if you tag the latest commit that got merged on master the code would be very different [21:06:58] bearND: oh right! it's merged to master. [21:07:33] MaxSem kaldari please respond to the email 'Wikimania travel dates?' - I think we need to adjust our sprint dates, but that will be dependent on your responses [21:07:44] bearND: it won't let me delete the tag from the remote... [21:08:19] dbrant: I can actually see the tag: https://git.wikimedia.org/tags/apps%2Fandroid%2Fwikipedia [21:09:36] but only in the web git ui [21:11:00] well wtf. [21:11:23] dbrant: on a fresh clone i see it. I think you'll only get the tag fetched if there is also a new commit or other git object to be fetched [21:12:28] dbrant: the tag is fine as it is [21:12:55] bearND: so then, that's the one that was based on a local commit, too. [21:13:03] dbrant: did a fresh clone, checkout the tag and looked at history, looks good to me [21:14:43] alright then! my migraine can now stop spreading. [21:14:56] dbrant: i think once you pushed the local commit the tag associated with it started showing up [21:24:36] 3MobileFrontend / 3stable: Improve Mobile/Web upload page Special:Uploads - 10https://bugzilla.wikimedia.org/68375#c8 (10Lupo) Thanks, Max and everybody else. Just a note: the fix for bug 68414 is set to go live tonight. I actually do hope that this has already a beneficial effect. If the hard limit comes... [21:27:24] bearND: very good... appreciate your guidance! [21:28:07] (03Merged) 10jenkins-bot: Revert "Remove LT and GT symbols around search button on zerodot." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148830 (owner: 10Yurik) [21:28:59] dbrant: bearND: i just deleted all the invites during wikimania and vacation time after. do you guys want to keep your standups during this time? its up to you [21:30:18] tfinc: are we the only ones left during this time? [21:31:18] tfinc: bearND: might be a good idea to keep them going, just to stay with the cadence mentally. [21:31:53] tfinc: dbrant: i'm fine either way [21:32:13] bearND: yup. just you guys. i'll re-add them [21:32:33] tfinc: ok, thanks [21:36:22] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c125 (10Ryan Kaldari) Florian: Actually, that change doesn't really take effect until tomorrow. It was deployed to Commons yesterday, but very few mobile users go to Special:Uploads directly on Commo... [21:46:47] these reviews crack me up [21:46:55] kaldari, https://en.wikipedia.org/wiki/Yorsh [21:46:59] "Who would rate this less than 5 Stars? An ignorant one, .. " [21:47:56] ha! [21:50:08] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c126 (10Ryan Kaldari) 5NEW>3RESO/WON Bug 66762 has been fixed, so this bug is no longer needed (by me at least). Reclosing. [21:53:54] kaldari: bah! [21:54:52] kaldari: uhhhh, wrong bug! [21:55:21] violetto: Sorry, I had to back out. I've been invited to meet with my representative about a political issue that is very important to me (saving Knowland Park in Oakland). Unfortunately, the meeting is scheduled for the same time :( [21:55:40] legoktm: lol, oops [21:56:40] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c127 (10Ryan Kaldari) 5RESO/WON>3REOP oops, wrong bug :P [21:56:57] (03PS2) 10BearND: [WIP] Show page issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148506 [21:57:04] kaldari: reason accepted [22:02:52] brion: chat went well [22:02:57] woohoo [22:05:11] mhurd: i’m in the rf cdiscussion over in other channel, but when you have a chance take a peek at the checklist i added on https://trello.com/c/Gu9ipDoR/20-ios-back-button-does-not-always-return-to-the-previous-article and let me know if that sounds sane :D [22:05:26] brion: ah! cool! [22:05:27] will do [22:07:32] brion: i have a couple tweaks to the approach - maybe chat after my next interview? or in morning if that runs too late? [22:07:38] sure [22:08:03] brion: sounds good! my ideas may be silly mind you ;) [22:08:10] :D [22:14:42] (03PS5) 10Dbrant: [WIP] Add first-time editing onboarding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148436 [22:17:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add first-time editing onboarding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148436 (owner: 10Dbrant) [22:17:51] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c128 (10Ryan Kaldari) Had a quick discussion with the PM, design, and the other developers. The outcome of the discussion was to go ahead and implement some minimum local edit count threshold across... [22:22:43] (03PS6) 10Dbrant: [WIP] Add first-time editing onboarding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148436 [22:36:26] dbrant: I've started https://gerrit.wikimedia.org/r/#/c/148866/ in ext/MobileApp. Would you mind testing it when you get a chance? Still blocked on vagrant. [22:39:55] bearND: sure [22:40:08] dbrant: thanks [22:41:12] (03CR) 10JGonera: [C: 032] Make Minerva's skin name translatable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148727 (owner: 10Bartosz Dziewoński) [22:41:50] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c129 (10Lupo) Thank you, Ryan, and all others involved. Max already said so at bug 68375. If you indeed do a sprint on that rather general "improvement" bug, don't forget the (quickly drawn up and s... [22:42:13] kaldari, is https://gerrit.wikimedia.org/r/#/c/148605/1 supposed to be merged now or by whomever is doing SWAT? [22:42:23] (03Merged) 10jenkins-bot: Make Minerva's skin name translatable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148727 (owner: 10Bartosz Dziewoński) [22:42:47] kaldari, if it's the latter then I guess I need to make pre-review hook check only for patches to the master branch [22:43:01] jgonera: By whoever's doing SWAT I assume [22:44:52] MaxSem: Are we supposed to merge our deployment branch changes before they are SWAT deployed or is that customarily left for the deployers to handle? [22:45:14] ala https://gerrit.wikimedia.org/r/#/c/148605 [22:45:54] kaldari, we're supposed to merge extenson changes and present only core submodule updates [22:46:10] ok [22:46:21] also, why only wmf14? [22:47:08] (03PS1) 10JGonera: Ignore non-master branch patches in git review hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148873 [22:47:10] (03CR) 10Kaldari: [C: 032] Making sure that upload rights are enforced on lazy-loaded pages [extensions/MobileFrontend] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148605 (https://bugzilla.wikimedia.org/68414) (owner: 10Florianschmidtwelzow) [22:47:20] kaldari, https://gerrit.wikimedia.org/r/148873 [22:47:37] oh wait [22:47:42] so we should merge them before? [22:47:57] (03PS1) 10MaxSem: Making sure that upload rights are enforced on lazy-loaded pages [extensions/MobileFrontend] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148875 (https://bugzilla.wikimedia.org/68414) [22:48:07] jgonera: sounds like it, so my mistake [22:48:18] (03CR) 10MaxSem: [C: 032] Making sure that upload rights are enforced on lazy-loaded pages [extensions/MobileFrontend] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148875 (https://bugzilla.wikimedia.org/68414) (owner: 10MaxSem) [22:48:18] ok, so I guess I'll abandon this patch? ;) [22:48:26] yeah, sorry :) [22:48:26] kaldari, ^ [22:49:02] (03Merged) 10jenkins-bot: Making sure that upload rights are enforced on lazy-loaded pages [extensions/MobileFrontend] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148605 (https://bugzilla.wikimedia.org/68414) (owner: 10Florianschmidtwelzow) [22:49:09] MaxSem: I didn't bother with wmf13 since it's dying tomorrow, but thanks :) [22:49:17] Maryana, what should we do with https://gerrit.wikimedia.org/r/#/c/138802/ ? Should I mark it with a -1/-2 as it requires more discussion? [22:49:43] it presently contributes to our code review backlog and we set a hard limit of 5 unreviewed patches [22:49:53] if there are more we can't push new patches ;) [22:49:59] i think it's ok if it's just in alpha [22:50:35] jgonera: ^ [22:51:05] (03Merged) 10jenkins-bot: Making sure that upload rights are enforced on lazy-loaded pages [extensions/MobileFrontend] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/148875 (https://bugzilla.wikimedia.org/68414) (owner: 10MaxSem) [22:52:37] Maryana, it's a bigger change though and might require follow ups [22:52:45] ok, I'll leave it as the last one to review maybe [22:54:15] (03Abandoned) 10JGonera: Ignore non-master branch patches in git review hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148873 (owner: 10JGonera) [22:58:41] (03CR) 10JGonera: [C: 031] Redirect to mobile diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [22:58:48] yurikSPB: would you be able to run the messages update? [22:59:07] dr0ptp4kt, should we deploy any fixes before that? [22:59:10] MaxSem, kaldari, whenever you have a minute I'd like a second pair of eyes for https://gerrit.wikimedia.org/r/#/c/148613/ [22:59:28] yurikSPB: i don't know of any others [22:59:44] dr0ptp4kt, i reverted your escaping patch btw [22:59:50] yurikSPB: saw that, thx [23:00:09] MaxSem: Thanks for creating the updates to core [23:01:10] dr0ptp4kt, MaxSem will scap later if he can, there might not be enough time [23:02:47] bearND: working for me! [23:03:27] dbrant|brb: cool. Thank you! [23:05:20] dbrant|brb: just need to add the blue border around it [23:07:07] (03PS12) 10Jdlrobson: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 [23:08:47] bearND|bbl: Styling looks sturdy! Thanks for screenshots and apk! [23:08:48] This phone seems broken. [23:15:18] MaxSem i see https://gerrit.wikimedia.org/r/#/c/140765/ was merged :) [23:15:27] \o/ [23:16:29] (03CR) 10JGonera: [C: 032] Move bottom border to page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148504 (owner: 10Jdlrobson) [23:20:12] jdlrobson, is the version of Hogan in Mantle newer than the one we were using in MF so far? [23:20:25] jgonera: it shouldn't be [23:20:30] it should be a like for like replacement [23:20:42] jgonera: is it not? [23:20:45] ok, so you didn't update it [23:20:57] I just noticed 1-2KB difference in page load before/after your patch [23:21:02] and was wondering what that could be [23:21:16] doesn't seem to be significant though [23:21:34] jgonera: oh that will be support for multiple compilers [23:21:45] mw.mantle.template supports handlebars and hogan [23:21:45] jdlrobson, that's in JS too? [23:21:49] oh, ok [23:21:58] (03CR) 10JGonera: [C: 032] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [23:22:00] boom [23:22:02] jgonera: yeh it allows us to run 2 template languages at same time [23:22:05] \o/ thanks jgonera [23:22:41] jdlrobson, https://gerrit.wikimedia.org/r/#/c/148504/ needs a rebase [23:22:57] (03Merged) 10jenkins-bot: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [23:23:29] MaxSem: confirmed it is fixed now. Thanks! [23:24:33] (03PS12) 10JGonera: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) [23:24:35] (03PS1) 10JGonera: Let VE know if we are running on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148888 [23:25:42] kaldari, I rebased https://gerrit.wikimedia.org/r/#/c/145185/ and fixed the scrolling regression in a follow up patch [23:31:41] (03CR) 10Kaldari: [C: 04-1] "Unfortunately, right now, MobileDiff can only properly handle displaying adjacent diffs, i.e. a diff for a single edit. Yes, it can actual" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [23:59:47] dr0ptp4kt, MaxSem finished scaping, any issues on your side?