[00:00:16] <dr0ptp4kt>	 MaxSem, thx. yurikSPB, thx for heads up; checking.
[00:03:52] <dr0ptp4kt>	 yurikSPB: that fixed the button text. now running banner checker
[00:13:55] <dr0ptp4kt>	 yurikSPB: the banner grab came back okay
[00:14:05] <yurikSPB>	 dr0ptp4kt, thx!
[00:18:59] <grrrit-wm>	 (03PS1) 10Jdlrobson: Explicitly identify the template language to use for Watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148900 
[00:19:03] <jdlrobson>	 kaldari: heeyyy
[00:19:17] <jdlrobson>	 kaldari: please merge above ^
[00:19:24] <jdlrobson>	 without that Flow on mobile doesn't look aamzing
[00:24:13] <kristenlans>	 I’m heading out, thanks for a good second day mobile team :-)
[00:27:16] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Explicitly identify the template language to use for Watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148900 (owner: 10Jdlrobson)
[00:28:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Explicitly identify the template language to use for Watchstar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148900 (owner: 10Jdlrobson)
[00:31:44] <grrrit-wm>	 (03PS1) 10Yurik: Include protocol in the log [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148907 
[00:31:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Include protocol in the log [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148907 (owner: 10Yurik)
[00:33:04] <grrrit-wm>	 (03CR) 10Yurik: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148907 (owner: 10Yurik)
[00:34:22] <grrrit-wm>	 (03PS2) 10Yurik: Include protocol in the log. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148907 
[00:34:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Include protocol in the log. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148907 (owner: 10Yurik)
[00:36:28] <yurikSPB>	 is jenkins having issues again? ^
[01:01:55] <grrrit-wm>	 (03PS3) 10Yurik: Include protocol in the log. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148907 
[01:02:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Include protocol in the log. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148907 (owner: 10Yurik)
[01:19:34] <grrrit-wm>	 (03PS1) 10Catrope: Revert "Add template dependency to Mantle extension" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148921 
[01:19:42] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Revert "Add template dependency to Mantle extension" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148921 (owner: 10Catrope)
[01:20:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Add template dependency to Mantle extension" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148921 (owner: 10Catrope)
[01:22:07] <RoanKattouw>	 Mobile people: I had to do this ---^^ because that commit broke beta labs and would have completely broken tomorrow's deployment train
[01:30:53] <grrrit-wm>	 (03PS4) 10Yurik: Better logging, simplify getWikiInfo [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148907 
[01:39:44] <grrrit-wm>	 (03PS1) 10Jforrester: [Reapply] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148927 
[04:27:50] <wikibugs>	 3MobileFrontend / 3General/Unknown: Lazy-loaded pages are not enforcing upload restrictions on mobile - 10https://bugzilla.wikimedia.org/68414 (10Florian) 5PATC>3RESO/FIX
[05:23:51] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: WIP: Add Uploadrestriction using edit count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) 
[05:40:25] <grrrit-wm>	 (03PS4) 10Florianschmidtwelzow: Add Uploadrestriction using edit count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) 
[05:44:45] <grrrit-wm>	 (03PS5) 10Florianschmidtwelzow: Add Uploadrestriction using edit count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) 
[05:46:46] <grrrit-wm>	 (03PS2) 10Florianschmidtwelzow: Redirect to mobile diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) 
[06:01:04] <grrrit-wm>	 (03PS3) 10Florianschmidtwelzow: Redirect to mobile diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) 
[06:02:02] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "Ah, ok, thx for this information Kaldari :) -> Updated to redirect only for "one-diff-views". Maybe it's better to move this into beta fir" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow)
[11:49:23] <wikibugs>	 3MobileFrontend / 3beta: Show details Overlay in MediaViewer instantly - 10https://bugzilla.wikimedia.org/68504 (10Florian) 3NEW p:3Unprio s:3minor a:3None At the moment, the overlay with the "details" button appears after a click (or "tap") on the screen. I would prefer to invert this behavior: Show...
[11:50:37] <wikibugs>	 3MobileFrontend / 3beta: Show details Overlay in MediaViewer instantly - 10https://bugzilla.wikimedia.org/68504#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/OeocUacg
[11:53:22] <wikibugs>	 3MobileFrontend / 3stable: Improve mobile uploads (tracking) - 10https://bugzilla.wikimedia.org/68376 (10Florian)
[14:07:08] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] "self-approving for depl window" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148907 (owner: 10Yurik)
[14:07:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Better logging, simplify getWikiInfo [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/148907 (owner: 10Yurik)
[14:27:27] <grrrit-wm>	 (03PS1) 10Dbrant: Hide reference dialog when on-wiki link is clicked. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149006 (https://bugzilla.wikimedia.org/68337) 
[14:38:48] <grrrit-wm>	 (03PS1) 10Dbrant: Fix background of selected Saved Pages and History items. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149011 (https://bugzilla.wikimedia.org/68409) 
[16:40:03] * YuviPanda waves
[16:40:09] <mhurd>	 YuviPanda: heya!
[16:40:15] <YuviPanda>	 hey mhurd
[16:41:37] * Krenair waves back
[16:42:56] <grrrit-wm>	 (03PS6) 10Dbrant: Show number of matches when finding in page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147761 (owner: 10Alex Monk)
[16:44:38] <YuviPanda>	 dbrant: bearND did you see https://docs.google.com/a/wikimedia.org/spreadsheets/d/1YS9J4DVdCBO8Zaw2Yuq1hHUYhR2WBmKTgAuS1nQQ3LE/edit#gid=0
[16:50:28] <bearND>	 YuviPanda: thanks for sharing the link.
[16:51:07] <dbrant>	 YuviPanda: yes, very insightful! (although not unexpected)
[16:51:13] <YuviPanda>	 dbrant: yeah
[16:52:30] <dbrant>	 I'm curious to see what effect the editing onboarding screen will have.
[16:52:35] <YuviPanda>	 indeed
[16:54:26] <grrrit-wm>	 (03CR) 10Dbrant: [C: 031] "ready for +2 by Yuvipanda or bearND" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147761 (owner: 10Alex Monk)
[17:14:12] <Maryana>	 awjr: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals
[17:27:08] <spagewmf>	 jdlrobson: are you aware of the MobileFrontend Mantle thing? You made MFe use Mantle in 129335 but it wasn't configured, so James_F|Away prepared a config patch to require Mantle 148925 which I mistakenly +2d. It looks like Roan reverted MFe's Mantle conversion.
[17:28:28] <jdlrobson>	 spagewmf: no i wasn't aware.. what happened?
[17:28:39] <jdlrobson>	 so MobileFrontend doesn't depend on Mantle now?
[17:28:41] * jdlrobson confused
[17:28:56] <jdlrobson>	 should i talk to RoanKattouw_away
[17:29:58] <spagewmf>	 him or James_F|Away . The unexpressed MFe dependency on Mantle broke some beta deployment thing
[17:31:23] <grrrit-wm>	 (03CR) 10Jdlrobson: "Thanks, the dependency management in core confuses me somewhat. I'm a little confused though. I checked beta labs after the patch and mobi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148921 (owner: 10Catrope)
[17:39:28] <dbrant>	 brion: got a moment for CR?  https://gerrit.wikimedia.org/r/148995
[17:39:45] <brion>	 lemme take a peek
[17:40:11] <brion>	 ooh clever — inverting the math colors 
[17:40:29] <dbrant>	 yes!
[17:40:58] <dbrant>	 (until we have Mathjax everywhere)
[17:41:38] <brion>	 i wish we could pretransforme verything with mathjax so it’d load faster though :)
[17:41:44] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "@jforrester When does that patch get deployed?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148927 (owner: 10Jforrester)
[17:42:19] <grrrit-wm>	 (03PS2) 10Jdlrobson: [Reapply] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148927 (owner: 10Jforrester)
[17:47:28] <RoanKattouw>	 jdlrobson: Hey
[17:47:41] <RoanKattouw>	 jdlrobson: James_F wrote a config patch that will fix this problem
[17:47:42] <jdlrobson>	 hey RoanKattouw spagewmf briefed me
[17:47:53] <jdlrobson>	 RoanKattouw: so yeh i saw spagewmf also merged that patch
[17:47:59] <RoanKattouw>	 But given that your change crippled beta labs the night before the deployment train I didn't want to take any risks
[17:48:07] <jdlrobson>	 i'm wondering if that means it's safe to reapply the patch?
[17:48:19] <RoanKattouw>	 It should be, but that should be coordinated with Greg
[17:48:30] <RoanKattouw>	 It involves expanding the Mantle deployment from a handful of wikis to almost all
[17:48:43] <jdlrobson>	 RoanKattouw: ah i see.. so should i open a bug?
[17:49:05] <jdlrobson>	 i stupidly figured if deployed in one place deployed everywhere
[17:49:14] <dbrant>	 brion: thanks!
[17:49:24] <brion>	 enjoy :D
[17:49:24] <RoanKattouw>	 If you like, but I don't think that's necessary. The Gerrit change already exists (it was reverted but James staged a re-apply version), so you just need to get Greg to agree that it can be deployed
[17:49:41] <RoanKattouw>	 and coordinate when it can be deployed
[17:49:45] <jdlrobson>	 so i should find  greg-g
[17:49:48] <RoanKattouw>	 Yes
[17:49:56] * jdlrobson looks around
[17:50:14] <RoanKattouw>	 Once that config change is out, reapplying your change to make MF depend on Mantle should be fine
[17:50:39] <RoanKattouw>	 But please don't merge it on a Wednesday afternoon again, that's a bit of a touchy time because the train is on Thursday morning
[17:51:31] <jdlrobson>	 noted. I've been bugging jgonera about it for a week
[17:51:47] <spagewmf>	 RoanKattouw jdlrobson : I made a revert patch but for the config change but it hasn't been  +2d and I will abandon it.  I think we should load Mantle everywhere MFe is in use, then later deploy the MFe patch that uses Mantle
[17:52:02] <jdlrobson>	 greg-g would like to know exactly what needs to happen
[17:52:23] <jdlrobson>	 he seems to think Mantle is installed everywhere, so the config change spagewmf merged should be enough no?
[17:52:28] <greg-g>	 give me a summary when you're done, sorry, can't watch it all right
[17:52:29] <greg-g>	 now
[17:52:30] <jdlrobson>	 spagewmf: i'd abandon that
[17:52:53] <jdlrobson>	 RoanKattouw: when will that config change go out?
[17:54:20] <jdlrobson>	 RoanKattouw: seems greg-g is fine with puttingMantle everywhere
[17:54:35] <jdlrobson>	 not sure what my next step is other than +2ing that repply once the config change goes out
[17:54:36] * greg-g is asking Reedy how things are on prod
[17:55:51] <grrrit-wm>	 (03CR) 10Jforrester: "> @jforrester When does that patch get deployed?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148927 (owner: 10Jforrester)
[17:56:15] <spagewmf>	 jdlrobson: the config change to require Mantle whereever wmgUseMobileFrontEnd is on mw1056, so I guess it was deployed
[17:56:30] <jdlrobson>	 spagewmf: that's what i'm wondering
[17:57:32] <greg-g>	 fyi, scap is still in progress, so, wait until Reedy gives an all clear before doing anything
[17:57:37] <greg-g>	 jdlrobson: ^
[17:58:26] <Maryana>	 kaldari: did this get swatted yesterday? https://trello.com/c/HBlqtUZc/49-implement-edit-threshold-of-10-edits-for-photo-uploads
[17:59:11] <kaldari>	 Maryana: No
[17:59:39] <kaldari>	 Maryana: the things that was swatted yesterday was patching the lazy-loading loophole
[18:00:02] <Maryana>	 ah, ok
[18:00:38] <Maryana>	 kaldari: but there's a patch for that guy already, right?
[18:01:13] <jdlrobson>	 Reedy: i await your confirmation :)
[18:01:44] <awjr>	 jgonera did you get what you needed from trevor for the VE stuff?
[18:03:13] <tfinc>	 Deskana|Away: just waiting on you 
[18:04:05] <Reedy>	 jdlrobson: it's done
[18:05:02] <yurikSPBru>	 dr0ptp4kt, are we meeting?
[18:07:09] <jdlrobson>	 thanks Reedy :D
[18:07:20] <jdlrobson>	 Reedy: it's okay to reapply the patch then?
[18:07:44] <Reedy>	 which patch?
[18:07:54] <Reedy>	 to what?
[18:08:04] <spagewmf>	 jdlrobson Hold on, I think the patch to include Mantle is checking wmgUseMobileFrontend, it should be wmgMobileFrontend
[18:08:27] <jdlrobson>	 Reedy: https://gerrit.wikimedia.org/r/#/c/148927/
[18:08:39] <spagewmf>	 jdlrobson:  https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Version , it loads MobileFrontend but still no Mantle
[18:08:48] <jdlrobson>	 spagewmf: :-/
[18:09:46] <Reedy>	 Wikipedias are still on 1.24wmf13
[18:16:58] <jdlrobson>	 Reedy: yeh seems spagewmf is right  James_F: PHP Notice:  Undefined variable: wmgUseMobileFrontend in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2005
[18:17:19] <jdlrobson>	 are you sure it should be wmgMobileFrontend spagewmf ?
[18:17:38] <Reedy>	 'wmgMobileFrontend' => array(
[18:17:38] <Reedy>	 	'default' => true,
[18:17:38] <Reedy>	 	'wikidata' => false, // Disabled due to lack of mobile domain setup
[18:17:38] <Reedy>	 ),
[18:19:07] <jdlrobson>	 ok so looks like it should be that then :)
[18:19:11] * jdlrobson boots up gerrit
[18:22:21] <YuviPanda>	 Deskana: it should be trivial to extract, I think
[18:22:41] <YuviPanda>	 Deskana: we have EL for ToC as well
[18:22:44] <spagewmf>	 jdlrobson: the fixed config (I hope) is https://gerrit.wikimedia.org/r/#/c/149071/
[18:22:46] <jdlrobson>	 Reedy: https://gerrit.wikimedia.org/r/149074
[18:23:03] <spagewmf>	 snap@!
[18:23:06] <Deskana>	 YuviPanda: Yeah, but we don't know how many people are seeing articles.
[18:23:06] <jdlrobson>	 spagewmf: that works too ;-)
[18:23:09] <Reedy>	 I tink erik beat you to it ;)
[18:23:15] <jdlrobson>	 So yeh let's get one of those merged :)
[18:23:16] <YuviPanda>	 Deskana: we theoretically have that data :)
[18:23:16] <Reedy>	 lol
[18:23:18] <jdlrobson>	 haha 3 patches
[18:23:18] <Reedy>	 there's 3 of htem
[18:23:26] <jdlrobson>	 pick your favourite commit message Reedy
[18:23:27] <jdlrobson>	 ;-)
[18:23:36] * Reedy finds his Amazon wishlist url
[18:23:52] <spagewmf>	 merge the best features of them
[18:23:54] <spagewmf>	 :)
[18:28:33] <grrrit-wm>	 (03PS1) 10Dbrant: Fix appearance of images in Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149076 (https://bugzilla.wikimedia.org/68408) 
[18:31:38] <kaldari>	 MaxSem: We should probably go ahead and request a new project on gerrit for our WikiData augmenter.
[18:32:43] <MaxSem>	 yup, need a name!
[18:32:57] <MaxSem>	 jgonera, ^
[18:39:04] <YuviPanda>	 MaxSem: kaldari I thought it was going to be wikitwitter? :)
[18:39:14] <kaldari>	 beats me
[18:40:05] <wikibugs>	 3MobileFrontend / 3beta: Show details Overlay in MediaViewer instantly - 10https://bugzilla.wikimedia.org/68504#c2 (10Ryan Kaldari) We changed it per design to always show the details overlay. Hiding the overlay on tap is an interesting idea though.
[18:40:42] <MaxSem>	 WikiDataGamification<add a couple more buzzwords here>
[18:45:23] <Deskana>	 dbrant
[18:45:25] <Deskana>	 dbrant
[18:45:29] <Deskana>	 dbrant
[18:45:31] <Deskana>	 Hi!
[18:45:34] <Deskana>	 :)
[18:45:38] <YuviPanda>	 Deskana: 
[18:45:38] <YuviPanda>	 Deskana: 
[18:45:39] <YuviPanda>	 Deskana: 
[18:45:40] <YuviPanda>	 Deskana: 
[18:45:42] <YuviPanda>	 Deskana: 
[18:45:44] <YuviPanda>	 Deskana: 
[18:45:46] <YuviPanda>	 Deskana: 
[18:45:48] <YuviPanda>	 Deskana: 
[18:45:50] <YuviPanda>	 Deskana: Hi
[18:45:56] <dbrant>	 o_0
[18:47:08] <wikibugs>	 3MobileFrontend / 3General/Unknown: Mobile media viewer loads full size image - 10https://bugzilla.wikimedia.org/68524 (10Ryan Kaldari) 3NEW p:3Unprio s:3major a:3None Go to https://en.m.wikipedia.org/wiki/Jebel_ech_Chambi#/image/File:Chambi1.JPG  The media viewer loads a scaled down version of the e...
[18:47:35] <wikibugs>	 3MobileFrontend / 3General/Unknown: Mobile media viewer loads full size image - 10https://bugzilla.wikimedia.org/68524 (10Ryan Kaldari) p:5Unprio>3High
[18:49:54] <MaxSem>	 YuviPanda, parsoid guys are asking for apps' typical API requests
[18:50:35] <wikibugs>	 3MobileFrontend / 3General/Unknown: Mobile media viewer loads full size image - 10https://bugzilla.wikimedia.org/68524#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/C2Hc3nJZ
[18:50:42] <YuviPanda>	 bearND: +1 https://gerrit.wikimedia.org/r/149080?
[18:50:48] <YuviPanda>	 MaxSem: ah, hmm. let me find out
[18:51:24] <jgonera>	 kaldari, so the wikidata thing will be in a separate repo? what do you mean by augmenter?
[18:51:33] <YuviPanda>	 MaxSem: props: lastmodified|normalizedtitle|displaytitle|protection|editable
[18:52:09] <YuviPanda>	 bearND: and we do two requests, first one being props + first section, then another request for just rest of sections
[18:52:17] <bearND>	 YuviPanda: +1'd. Will need some training for this, of course
[18:52:37] <YuviPanda>	 bearND: yeah, I probably won't be able to do that since my account will be removed, but Nikerabbit should be able to help
[18:54:45] <bearND>	 YuviPanda: how about i share my screen with you for that once i get access?
[18:54:55] <YuviPanda>	 bearND: yeah, we'll figure something out :)
[19:05:38] <YuviPanda>	 bearND: can you join #mediawiki-i18n
[19:09:54] <mhurd>	 lunch!
[19:11:34] <gwicke>	 YuviPanda: I added one typical app query to http://etherpad.wikimedia.org/p/Mobile_Parsoid
[19:12:10] <gwicke>	 YuviPanda: am generally interested in what you guys need from the API, so if you could add URLs / info on which props you need that would be awesome
[19:13:13] <wikibugs>	 3MobileFrontend / 3beta: Hide details Overlay in MediaViewer after tap on screen - 10https://bugzilla.wikimedia.org/68504#c3 (10Florian) > We changed it per design to always show the details overlay.  Was there a change i missed? :O
[19:13:16] <YuviPanda>	 gwicke: added
[19:13:37] <gwicke>	 YuviPanda: aha, thanks!
[19:13:57] <YuviPanda>	 gwicke: :D
[19:14:04] <gwicke>	 this is for the app?
[19:14:06] <YuviPanda>	 gwicke: yes
[19:14:12] <gwicke>	 k
[19:15:15] <gwicke>	 is there a page somewhere with sample requests?
[19:15:28] <YuviPanda>	 gwicke: heh, not that I remember
[19:15:39] <gwicke>	 k
[19:18:34] <gwicke>	 YuviPanda: are all these requests via action=mobileview ?
[19:18:53] <YuviPanda>	 gwicke: yup
[19:18:58] <gwicke>	 k
[19:21:34] <gwicke>	 YuviPanda: one thing I might be able to help with is pre-generating this info on edit
[19:22:00] <YuviPanda>	 gwicke: yeah, that'll be awesome. Most of the props are already generated on edit, I guess, though (and cached in the db)
[19:22:01] <gwicke>	 so that page it's fast on page view
[19:22:09] <gwicke>	 s/page//
[19:22:39] <YuviPanda>	 yup
[19:22:45] <YuviPanda>	 gwicke: is this parsoid itself or the content API?
[19:22:58] <gwicke>	 the content API
[19:23:13] <gwicke>	 & storage service
[19:23:22] <YuviPanda>	 gwicke: ah, cool. So it won't have the extra parsoid-based info that's useful for editing?
[19:23:47] <gwicke>	 that'll also be removed from the parsoid HTML
[19:23:54] <gwicke>	 and stored as a separate json blob
[19:23:58] <YuviPanda>	 gwicke: aaah, nice
[19:24:16] <gwicke>	 but generally storage doesn't care where some bit of data comes from
[19:24:27] <YuviPanda>	 gwicke: will it support the 'give me 1 section' and 'give me everything but one section' thing?
[19:24:27] <gwicke>	 could even come from action=mobileview as it exists today
[19:24:33] <YuviPanda>	 ah, nice
[19:24:39] <YuviPanda>	 gwicke: yeah, mobile does some transforms still, IIRC
[19:25:22] <gwicke>	 *nod*
[19:25:51] <gwicke>	 now back to work actually building this..
[19:26:40] <YuviPanda>	 gwicke: \o/
[19:26:57] <YuviPanda>	 gwicke: btw, dbrant is the new Android tech lead. I'll be moving to the ops team in a few months.
[19:27:10] <dbrant>	 heya!
[19:27:21] <gwicke>	 ohh, interesting!
[19:27:37] <gwicke>	 hi dbrant!
[19:27:40] <YuviPanda>	 dbrant: gwicke is working on parsoid/content API, another way to retreive page contents with much better performance. 
[19:28:03] <YuviPanda>	 dbrant: we initially wanted to base the mobile apps on this, but things didn't quite work out. We can hopefully switch to it at some point in the future
[19:28:34] <dbrant>	 I see;  is that what VE uses?
[19:28:39] <gwicke>	 yup
[19:28:48] <gwicke>	 VE & Flow are the main users right now
[19:29:14] <dbrant>	 excellent
[19:29:52] <gwicke>	 I'm now building a REST content API & storage service, so am especially interested in your API needs
[19:31:23] <gwicke>	 see https://www.mediawiki.org/wiki/Services/Roadmap
[19:34:59] <YuviPanda>	 bearND1: can you setup a meeting tomorrow so I can run you through this?
[19:39:18] <bearND1>	 YuviPanda: sent
[19:40:16] <YuviPanda>	 bearND1: cool
[20:57:36] <grrrit-wm>	 (03PS1) 10Brion VIBBER: update css from live [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149118 
[20:57:52] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "self merge automatic change" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149118 (owner: 10Brion VIBBER)
[21:20:32] <jdlrobson>	 tfinc: https://news.ycombinator.com/item?id=8079392
[21:21:13] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Fixing edit eventlogging for abuse filter [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149125 
[21:21:48] <grrrit-wm>	 (03PS2) 10Brion VIBBER: Fixing edit eventlogging for abuse filter [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149125 (https://bugzilla.wikimedia.org/68401) 
[21:24:29] <wikibugs>	 3Wikipedia App / 3General/Unknown: iOS and Android: Fix EventLogging for abuse filter warning/disallow - 10https://bugzilla.wikimedia.org/68401#c3 (10Brion Vibber) With the patch, iOS seems to send events through intact from what I can see.
[21:29:17] <YuviPanda>	 brion: yeah, no need to bump for typoes. Minimize bumps in the code! :D
[21:33:45] <brion>	 \o/
[21:43:46] <wikibugs>	 3Wikipedia App / 3iOS App: iOS 8: ToC zoom-out effect buggy on iOS 8 beta 4 - 10https://bugzilla.wikimedia.org/68536 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None The zoom-out effect we do when opening the ToC doesn't size/position the web view correctly on iOS 8 beta; this has persisted through...
[21:44:45] <tfinc>	 jdlrobson: thanks for the link
[21:58:43] <wikibugs>	 3Wikipedia App / 3Android App: Add full text search functionallity - 10https://bugzilla.wikimedia.org/68438#c1 (10Brion Vibber) (clarified summary)
[21:59:31] <wikibugs>	 3Wikipedia App / 3iOS App: [iOS] webview Wikipedia link long press convert to HTTPS - 10https://bugzilla.wikimedia.org/68330 (10Brion Vibber) 5PATC>3RESO/FIX
[22:03:30] <wikibugs>	 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c14 (10Brion Vibber) 5NEW>3RESO/FIX Assuming the total redesign of the menu has resolved this.
[22:06:47] <wikibugs>	 3Wikipedia App / 3Generic: iOS: When editing a protected page, it should be obvious that the page is protected - 10https://bugzilla.wikimedia.org/64640#c1 (10Brion Vibber) 5NEW>3RESO/FIX We implemented this with at least a basic notice a while ago, if further styling is needed let's add another card or b...
[22:06:47] <wikibugs>	 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c15 (10Vibha Bamba) Addressed for the short term. thank you for closing.
[22:07:15] <wikibugs>	 3Wikipedia App / 3iOS App: iOS app: Missing home / go to Main Page button - 10https://bugzilla.wikimedia.org/64394#c1 (10Brion Vibber) 5NEW>3RESO/FIX In latest builds this exists and is labeled 'Today'.
[22:09:17] <wikibugs>	 3Wikipedia App / 3Generic: Replace floppy disk and trash icons on editing, history screens. - 10https://bugzilla.wikimedia.org/64320#c3 (10Brion Vibber) 5NEW>3RESO/FIX Done some time ago.
[22:12:31] <jgonera>	 kaldari, if you have some time, can you have a second look at https://gerrit.wikimedia.org/r/#/c/145185/ ?
[22:12:44] <wikibugs>	 3Wikipedia App / 3Localization/Translation/Language: Message keys visible instead of UI strings - 10https://bugzilla.wikimedia.org/63546#c5 (10Brion Vibber) 5ASSI>3RESO/FIX This got done some time ago.
[22:15:03] <bearND>	 YuviPanda dbrant: Got vagrant set up. How would you use it to test https://gerrit.wikimedia.org/r/#/c/148866/?
[22:15:23] <YuviPanda>	 bearND: so, in vagrant directory: 1. 'vagrant enable-role mobileapp' 2. vagrant provision
[22:15:34] <YuviPanda>	 bearND: that will give you a mediawiki/extensions/MobileApp
[22:15:44] <YuviPanda>	 bearND: which will be a git repo
[22:16:08] <bearND>	 YuviPanda: done that
[22:16:12] <YuviPanda>	 bearND: second step is to change the url in make-css-assets script to point to 127.0.0.1:8080/w instead of the bits url
[22:16:19] <YuviPanda>	 bearND: then run the script, and test
[22:16:40] <bearND>	 YuviPanda: ah, that's the missing piece
[22:16:47] <YuviPanda>	 bearND: :D
[22:25:49] <awjr>	 jgonera were you able to get what you needed from trevor for the VE cards?
[22:56:30] <grrrit-wm>	 (03PS1) 10Mhurd: Fix for back forward buttons logic. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149184 
[22:56:47] <mhurd>	 brion ^
[23:00:17] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "This should handle most common cases; further issues punted to https://trello.com/c/O5O9A74l/714-ios-handle-cycles-in-back-forward-button" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149184 (owner: 10Mhurd)
[23:14:57] <wikibugs>	 3Wikipedia App / 3iOS App: iOS app: Missing home / go to Main Page button - 10https://bugzilla.wikimedia.org/64394#c2 (10Dan Garry) (In reply to Brion Vibber from comment #1) > In latest builds this exists and is labeled 'Today'.  Note that this won't be in the initial release of the iOS app. That said, it'l...
[23:16:12] <Deskana>	 dbrant, bearND, YuviPanda: How are things going? Anything I can do for you?
[23:16:40] <YuviPanda>	 all good from my end, would like some toast though.
[23:17:26] <Deskana>	 YuviPanda: I'd post you some but it might be quicker if you handled that.
[23:17:41] <YuviPanda>	 Deskana: yeah, I can take ownership of the task, if you're ok with that.
[23:17:56] <Deskana>	 Sure!
[23:18:04] * Deskana promotes Yuvi to Product Manager for Toast.
[23:18:09] <YuviPanda>	 Deskana: can we call that a (13)? I need to find where I put the bread
[23:18:23] <Deskana>	 We need to break that card up.
[23:19:26] <bearND>	 Deskana: now that I have vagrant set up, things are rolling again. one quick question for you about the dialog title name: "page issues" vs "article issues". Originally I told Vibha that we're trying to use the term page throughout the app, but now that I've seen some real-world examples of page issue I see that they use the word article quite often (at least on enwiki: e.g. [[8 mm video format]])
[23:19:47] <bearND>	 doesn't need an answer right now but by tomorrow would be nice
[23:19:57] <YuviPanda>	 Deskana: hmm, right. 1. Find pile in which bread exists (3), 2. Turn on pan + cooker (3), 3. Cook without burning things (2). Down to an 8, nice!
[23:20:03] <YuviPanda>	 Deskana: I'll have to sign off on it myself, though. Is that ok?
[23:20:17] <YuviPanda>	 bearND: I think it's ok. we shouldn't be modifying page contents :)
[23:20:26] <Deskana>	 YuviPanda: 13 = 8.
[23:20:52] <YuviPanda>	 Deskana: hmm we can add a (5) for 'eat toast before it goes cold'
[23:20:55] <Deskana>	 bearND: These templates should never be put on things that aren't articles. Article issues is the correct prose.
[23:21:03] <bearND>	 YuviPanda: wasn't considering messing with the issue text any more than splitting off the date part at the end (if it exists)
[23:21:22] <YuviPanda>	 bearND: it's still super dangerous territory, I think. You'll want to restrict it to only enwiki via some flag
[23:21:26] <bearND>	 YuviPanda: Deskana: this is just for the dialog title itself (native code)
[23:21:54] <YuviPanda>	 bearND: and remember the format of those things can change at any time without the app having notice, so we should gracefull handle any changes in structure
[23:22:15] <YuviPanda>	 I bet if people found out they can crash the app for everyone by editing some popular page and put specifically formatted wikitext in it, they would :D
[23:22:49] <bearND>	 YuviPanda: see updateText() in https://gerrit.wikimedia.org/r/#/c/148506/2/wikipedia/src/main/java/org/wikipedia/page/IssuesHandler.java. If the regex doesn't match I just use the full text
[23:23:07] <YuviPanda>	 hmm, ok (I'll take a closer look tomorrow)>
[23:23:13] <Deskana>	 bearND: Yeah, exactly. It should be "article issues" because these are only on articles.
[23:23:29] <YuviPanda>	 bearND: how's it handling dewiki, etc? just no modifications?
[23:23:30] <bearND>	 YuviPanda: sure. it's super late for you
[23:23:36] <YuviPanda>	 bearND: yeah
[23:23:46] <YuviPanda>	 Deskana: I'm considering moving 'eat toast' to backlog and prioritize 'go to sleep' instead
[23:23:53] <bearND>	 YuviPanda: mentioned dewiki in my email a couple of days ago
[23:24:21] <YuviPanda>	 bearND: yeah, forgot what effect it had :D Can/should we specifically code it to not run any code at all if we're not on enwiki?
[23:24:21] <YuviPanda>	 Deskana: ^
[23:24:30] <bearND>	 YuviPanda: there doesn't seem to be any table.mbox as far as I could find. So page issues don't get hidden and just displayed inline
[23:25:02] <Deskana>	 Wait, I'm now really fucking confused.
[23:25:06] <Deskana>	 What are we even talking about?
[23:25:14] <bearND>	 YuviPanda: i tested on eswiki, which seems ok, except they like using images of checkboxes there
[23:25:23] <YuviPanda>	 bearND: heh
[23:25:31] <YuviPanda>	 Deskana: toast?
[23:25:33] <bearND>	 YuviPanda: which turned the checked checkbox into an empty checkbox, ouch
[23:25:34] <Deskana>	 What are the user-facing aspects of what we're discussing?
[23:26:12] <YuviPanda>	 Deskana: https://trello.com/c/AvH6dtUG/15-5-as-a-new-user-i-d-like-article-issues-wrapped-up-into-a-button-so-that-i-can-see-what-problems-an-article-might-have
[23:26:15] <bearND>	 https://es.wikipedia.org/wiki/Transbarca
[23:26:55] <Deskana>	 YuviPanda: Yes, so. We're talking about what the text on the actual button should be? The one that you tap to see the issues?
[23:27:11] <bearND>	 so instead of the checked checkbox i got an empty rectangle
[23:27:15] <YuviPanda>	 Deskana: that was what we were *first* talking about
[23:27:26] <bearND>	 since i can't display the images
[23:27:26] <YuviPanda>	 Deskana: now we're talking about how it'll work on other wikis (non-enwiki)
[23:27:41] <Deskana>	 Oh, so, that's not really my concern right now, so I'm done here.
[23:27:41] <YuviPanda>	 Deskana: since they have completely different norms, and aren't easily detectable, and also inconsistenly detectable
[23:27:41] <Deskana>	 Cool. :P
[23:27:46] <YuviPanda>	 Deskana: no, it is :)
[23:27:46] <Deskana>	 Yeah.
[23:27:50] <YuviPanda>	 Deskana: I was suggesting we restrict it to enwiki
[23:27:55] <YuviPanda>	 Deskana: and not run that code on other wikis at all
[23:28:03] <YuviPanda>	 Deskana: or at least, just have a 'whitelist' of text to run them on
[23:28:07] <Deskana>	 YuviPanda: As a first pass, I thought we were!
[23:28:11] <YuviPanda>	 Deskana: oh
[23:28:16] <YuviPanda>	 bearND: ^
[23:28:20] <Deskana>	 Maybe I'm just wrong about that.
[23:28:21] <bearND>	 YuviPanda: then we need to restrict hiding the issues as well. i think those two should be consistent
[23:28:27] <YuviPanda>	 bearND: oh completely agree.
[23:28:33] <bearND>	 based on enwiki or not
[23:29:17] <YuviPanda>	 bearND: yeah, I agree. We can introduce a class on <html> that also has the name of the wiki, and we can use that to selectively hide CSS or not
[23:29:31] <Deskana>	 Remember my often quoted data point!
[23:29:40] <Deskana>	 Over 80% of our users read either English or German.
[23:29:43] <YuviPanda>	 Deskana: I have added 'only on enwiki' to acceptance criteria
[23:29:46] <Deskana>	 So if we get it right for that, we get it right for 80% of our users.
[23:30:04] <YuviPanda>	 Deskana: hmm, where's that data coming from? Is that from the play store metrics?
[23:30:24] <YuviPanda>	 Deskana: I'll note that that is the *UI* language, different from Content language. so while it might be an approximation, it's not an accurate estimate.
[23:30:31] <YuviPanda>	 well, very accurate. for that we'll need pageviewdata
[23:30:44] <Deskana>	 Also it's bullshit. The percentages have changed since I last looked.
[23:31:04] <Deskana>	 English and German account for around 46%.
[23:31:42] <YuviPanda>	 heh
[23:31:49] <YuviPanda>	 Deskana: with both the englishes?
[23:32:00] <Deskana>	 YuviPanda: I've got both en-gb and en-us in there.
[23:32:05] <YuviPanda>	 sigh
[23:32:50] <Deskana>	 And yeah, it's an approximation.
[23:32:56] <Deskana>	 But approximations are better than random guesses!
[23:33:06] <YuviPanda>	 Deskana: it's also counting about 33% users on the *old* app
[23:33:11] <YuviPanda>	 Deskana: 33% never upgraded
[23:33:14] <Deskana>	 Yep.
[23:33:55] <YuviPanda>	 Deskana: either way, I added 'only on enwiki' to the acceptance criteria for that card. is that ok or should we reconsider?
[23:34:02] <Deskana>	 No, that's fine.
[23:34:15] <YuviPanda>	 cool
[23:34:17] <Deskana>	 It's what I thought we were doing!
[23:34:25] <YuviPanda>	 Deskana: heh :)
[23:34:42] <YuviPanda>	 Deskana: hopefully, we also enable it for other wikis over time. I'd hate for us to have a bunch of 'enwiki only' features
[23:35:01] <bearND>	 Thanks for looping me in ;) I wasn't aware of that requirement before
[23:35:09] <Deskana>	 YuviPanda: Correct.
[23:35:15] <Deskana>	 bearND: Well I may have just imagined it. I don't know. :P
[23:37:19] <Deskana>	 But yeah
[23:37:22] <Deskana>	 HENCEFORTH IT IS TRUE
[23:37:25] <Deskana>	 SO SAYETH THE PM
[23:38:12] <Deskana>	 You know I'm actually just sat here waiting for it to turn 5pm so I can rerun my Android app registration numbers.
[23:39:07] <YuviPanda>	 Deskana: heh
[23:39:15] <YuviPanda>	 Deskana: OH GOD IT IS 5AM, I should go to sleep
[23:39:25] <YuviPanda>	 I seem to keep saying that on IRC and not doing anything
[23:39:31] * YuviPanda looks squarely at IRC
[23:39:49] <Deskana>	 YuviPanda: Tut tut.
[23:40:03] <Deskana>	 YuviPanda: Would you ever even have a normal sleep pattern even if you were here? :P
[23:40:13] <YuviPanda>	 Deskana: I... somehow doubt it, but it'll probably be better.
[23:40:22] <bearND>	 YuviPanda: yus should get an alarm set for going to sleep ;)
[23:41:23] <YuviPanda>	 bearND: :D
[23:41:28] <bearND>	 YuviPanda: but i'm not really complaining. i like that you're up longer
[23:41:35] <YuviPanda>	 :D