[00:03:33] brion: or YuviPanda: is it possible to embed svg images as well, or just png? [00:04:00] bearND: I'm unsure, I think both? brion or kaldari might know as well [00:04:03] kaldari: ^ with RL [00:07:11] oh never mind, why don't i just try it . sorry. i'm struggling more with getting the black flag image to turn blue. [00:08:04] Deskana: everything's going swimmingly on my end! (just caught up on the conversation) I'm just getting familiar with all the expected responsibilities of "tech lead" ;) [00:08:20] bearND: in css? yes, however beware svg won’t work in android 2.3 [00:09:00] brion: thanks for the warning. That's means no then [00:09:19] you could use one with a fallback to png…. but if you have to do png anyway you may as well just use png :D [00:09:40] brion: agreed [00:10:27] on desktop folks generally use just a 1x PNG and use SVG for the scalable version [00:10:33] bug android 2.3 can be various densities too :( [00:10:35] *but [00:12:22] dbrant: Yay! [00:12:24] (03PS1) 10Mhurd: Fix for updating lastVisited date of article being navigated away from. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149198 [00:12:28] brion: ^ [00:25:59] (03PS2) 10Mhurd: Fix for updating lastVisited date of article being navigated away from. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149198 [00:34:12] (03CR) 10Brion VIBBER: "No longer seems to be hanging in the way it was before \o/" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149198 (owner: 10Mhurd) [00:35:53] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok let's merge this :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149198 (owner: 10Mhurd) [01:50:40] (03PS3) 10BearND: [WIP] Show page issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148506 [01:59:29] 3MobileFrontend / 3General/Unknown: Mobile media viewer loads full size image - 10https://bugzilla.wikimedia.org/68524#c2 (10Ryan Kaldari) 5NEW>3RESO/INV p:5High>3Normal s:5major>3normal Nevermind. It actually just loads an image twice the resolution of the width of your window, which makes sense... [02:34:14] (03CR) 10Mhurd: [C: 032 V: 032] "Yay!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149125 (https://bugzilla.wikimedia.org/68401) (owner: 10Brion VIBBER) [02:40:30] (03CR) 10Mhurd: [C: 032 V: 032] "Seems to work!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148832 (owner: 10Brion VIBBER) [02:50:28] (03PS1) 10Kaldari: Fixing height of image in mobile media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149221 [02:51:35] (03PS2) 10Kaldari: Fixing height of image in mobile media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149221 [03:38:13] 3Wikipedia App / 3Android App: Uninstall leaving things behind for some users? - 10https://bugzilla.wikimedia.org/68275#c2 (10fireattack) Why use links of OTRS in bugzilla? Not everyone can visit it.. [03:41:13] 3Wikipedia App / 3Android App: Uninstall leaving things behind for some users? - 10https://bugzilla.wikimedia.org/68275#c3 (10Alex Monk) Because otherwise it's a massive pain to keep track of what bugzilla reports are based on what user feedback and vice versa. [04:00:58] 3Wikipedia App / 3Android App: Uninstall leaving things behind for some users? - 10https://bugzilla.wikimedia.org/68275#c4 (10fireattack) Understood that. My point is we should at least have some plain text description other than internal links to make everything clear and easy to search for others. I almost... [05:11:44] 3Wikipedia App / 3Android App: Google search links to Wikipedia app still when it was uninstalled - 10https://bugzilla.wikimedia.org/68275#c5 (10Florian) Updates the title. The problem is (i have tested it and verified), that the user becomes deep links in Google search, when he installed the Wikipedia App f... [06:54:59] 3Wikipedia App / 3iOS App: iOS App: "W" menu needs reorganization - 10https://bugzilla.wikimedia.org/65824#c16 (10Kunal Mehta (Legoktm)) Yeah sorry, I haven't had much time recently to play with the updated app, so I was holding off on closing it. I took a quick look at it just now and it looks much better :) [08:52:28] 3Wikipedia App / 3Android App: Google search links to Wikipedia app still when it was uninstalled - 10https://bugzilla.wikimedia.org/68275#c6 (10Yuvi Panda) I don't know if there's anything we can do to fix this - seems completely a thing on Google's side. I think with deeplinking 'open in app' exists even i... [11:51:16] 3Wikipedia App / 3Android App: Google search links to Wikipedia app still when it was uninstalled - 10https://bugzilla.wikimedia.org/68275#c7 (10Florian) > exists even if you've never installed the app @Yuvi Panda: I have tested this with logging out from Google account and there wasn't the link to the app,... [12:53:46] (03PS1) 10Yurik: Logging opera-detection cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/149296 [14:35:14] 3Wikipedia App / 3General/Unknown: iOS and Android: Fix EventLogging for abuse filter warning/disallow - 10https://bugzilla.wikimedia.org/68401#c5 (10Dmitry Brant) From the Android point of view, the dearth of abuse filter events can be explained as follows: The Android app was, in fact, not logging these e... [14:37:06] (03CR) 10Yuvipanda: [C: 032] Fix appearance of images in Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149076 (https://bugzilla.wikimedia.org/68408) (owner: 10Dbrant) [14:38:00] YuviPanda: see my comment on the abuse filter logging bug... [14:38:35] (03Merged) 10jenkins-bot: Fix appearance of images in Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149076 (https://bugzilla.wikimedia.org/68408) (owner: 10Dbrant) [14:38:37] dbrant: yeah, I concur. my events were getting through, Deskana|Away's wasnt (when we were playing with EL a couple days ago) [14:38:42] I was on master he was on prod [14:38:42] so [14:39:05] makes sense [14:44:17] 3Wikipedia App / 3General/Unknown: iOS and Android: Fix EventLogging for abuse filter warning/disallow - 10https://bugzilla.wikimedia.org/68401#c6 (10Dan Garry) 5PATC>3RESO/FIX Then we can consider this resolved! [15:05:12] 3Wikipedia App / 3Android App: Math symbols broken in dark mode - 10https://bugzilla.wikimedia.org/68252#c3 (10Alex Monk) 5PATC>3RESO/FIX Should be fixed now then, I think. [15:05:30] 3Wikipedia App / 3Android App: Some images are not readable after turning on night mode - 10https://bugzilla.wikimedia.org/68408#c5 (10Alex Monk) 5PATC>3RESO/FIX Should be fixed now then, I think. [15:06:43] 3Wikipedia App / 3Android App: Google search links to Wikipedia app still when it was uninstalled - 10https://bugzilla.wikimedia.org/68275#c8 (10fireattack) I think at least it won't show "app installed" and overwrite the default link if you never installed wikipedia app. [15:10:10] (03PS1) 10Dbrant: Fix abuse filter appearance in Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149317 [15:13:28] 3Wikipedia App / 3Android App: Google search links to Wikipedia app still when it was uninstalled - 10https://bugzilla.wikimedia.org/68275#c9 (10Florian) I have tested it with my second account: There isn't a deep link to the app (never installed with this account on Google Play) :/ [15:40:36] bearND: YuviPanda: got some time for CR today? several minor things in the pipeline. [15:41:28] dbrant: yes, what a coincidence. was just thinking about that [15:41:40] anyone know how to edit the toolbox for mobile? [15:52:04] dbrant: yeah, will look :) [15:52:47] (03PS2) 10BearND: Hide reference dialog when on-wiki link is clicked. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149006 (https://bugzilla.wikimedia.org/68337) (owner: 10Dbrant) [15:53:07] (03CR) 10BearND: [C: 032] Hide reference dialog when on-wiki link is clicked. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149006 (https://bugzilla.wikimedia.org/68337) (owner: 10Dbrant) [15:54:39] (03Merged) 10jenkins-bot: Hide reference dialog when on-wiki link is clicked. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149006 (https://bugzilla.wikimedia.org/68337) (owner: 10Dbrant) [15:54:55] (03PS2) 10BearND: Fix background of selected Saved Pages and History items. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149011 (https://bugzilla.wikimedia.org/68409) (owner: 10Dbrant) [15:57:25] (03CR) 10BearND: [C: 032] Fix background of selected Saved Pages and History items. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149011 (https://bugzilla.wikimedia.org/68409) (owner: 10Dbrant) [15:57:42] (03Merged) 10jenkins-bot: Fix background of selected Saved Pages and History items. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149011 (https://bugzilla.wikimedia.org/68409) (owner: 10Dbrant) [15:58:39] (03PS2) 10Jdlrobson: Use Special:EditWatchlist for A-Z View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148557 [15:58:41] (03PS1) 10Jdlrobson: WIP: Make mobile watchlist use core code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149326 [15:59:01] (03CR) 10Jdlrobson: [C: 04-1] "need to deal with the empty case," [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148557 (owner: 10Jdlrobson) [15:59:55] (03CR) 10jenkins-bot: [V: 04-1] WIP: Make mobile watchlist use core code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149326 (owner: 10Jdlrobson) [16:00:10] hey bearND [16:08:33] bearND: php /www/translatewiki.net/w/extensions/Translate/scripts/processMessageChanges.php --group="out-wikimedia-mobile-wikipedia-android-strings" [16:12:23] bearND: php /www/translatewiki.net/w/extensions/Translate/scripts/processMessageChanges.php --group="out-wikimedia-mobile-wikipedia-ios" [16:14:41] bearND: repoexport wikipedia-android [16:16:14] (03PS1) 10Yuvipanda: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149334 [16:16:40] Time to head to the office! [16:17:12] Feeling hot... [16:22:51] (03PS1) 10BearND: Manual translation import from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149336 [16:26:24] (03PS1) 10BearND: Manual import from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149339 [16:26:40] bearND: 'git fetch gerrit' [16:26:45] bearND: git reset --hard gerrit/master [16:55:12] bearND: andre__ [16:55:23] bearND: he should be on #wikimedia-dev in european hours [16:59:40] (03PS2) 10BearND: Fix abuse filter appearance in Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149317 (owner: 10Dbrant) [17:08:10] (03CR) 10BearND: [C: 032] Fix abuse filter appearance in Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149317 (owner: 10Dbrant) [17:08:31] (03Merged) 10jenkins-bot: Fix abuse filter appearance in Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149317 (owner: 10Dbrant) [17:29:45] (03PS3) 10Jdlrobson: Use Special:EditWatchlist for A-Z View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148557 [17:29:45] YuviPanda: bearND: so, which one of your TWN imports should I +2? [17:29:57] dbrant: you can abandon mine :) [17:30:20] dbrant: make sure you run the TranslationTests before you +2 [17:30:38] dbrant: I haven't looked at the imported strings yet [17:30:38] alright! [17:30:40] MaxSem: eek any opinion on what we should do here? 2014-07-25 16:13:43 mw1092 mediawikiwiki: [8b6b3737] /wiki/Special:MobileDiff/1047997 Exception from line 791 of /usr/local/apache/common-local/php-1.24wmf15/includes/diff/DifferenceEngine.php: Diff not implemented for Flow\Content\BoardContent; override generateContentDiffBody to fix this. [17:30:59] (03CR) 10jenkins-bot: [V: 04-1] Use Special:EditWatchlist for A-Z View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148557 (owner: 10Jdlrobson) [17:31:00] dbrant: it's basically straight from the script [17:31:25] jdlrobson, fix it? [17:43:15] 3Wikipedia App / 3General/Unknown: iOS & Android: MobileFrontend styles unconditionally adding borders to tables - 10https://bugzilla.wikimedia.org/68579 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None styles.css unconditionally adds borders on tables in the content area. This causes oddities in so... [17:45:08] (03PS4) 10Jdlrobson: Use Special:EditWatchlist for A-Z View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148557 [17:48:35] (03CR) 10Brion VIBBER: [C: 04-1] "qqq files lost a lot of strings here, did they not get imported into TWN from the updated files ?" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149339 (owner: 10BearND) [17:50:29] Deskana: today at our prioritization will focus on sprint 38. can you add me to it ? [17:50:39] brion: trying the import script again (cc YuviPanda) [17:50:44] tx [17:50:49] tfinc: Done. [17:51:05] thank you [17:51:14] bearND it looks like the updated qqq file didn’t get imported into the TWN system [17:51:28] brion: import to TWN says "No changes found". Same as when YuviPanda did it earlier [17:51:38] i forget which is import and which is export in twn terminology :) [17:51:39] hmmmmm [17:52:08] awjr, jgonera: So the good news is, we know what happened to MobileContext [17:52:11] The bad news is, it's Trevor's fault [17:52:27] https://gerrit.wikimedia.org/r/#/c/146908/ [17:52:27] so what happened? ;) [17:52:33] "* No longer adding context to local overlay (will be added to toolbar in vemw commit)" [17:52:41] That vemw commit? Never happened [17:52:44] ha! is it something you can help untangle RoanKattouw ? [17:52:45] o [17:53:04] do we need to wait til trevor is back, then? [17:53:04] brion: Yeah, it's a bit confusion. YuviPanda explained that when on twn it's from TWN's perspective but in the commit message to our code it's from our code's perspective [17:53:12] Ahm, well [17:53:12] RoanKattouw, interesting... I remember Trevor showing it to me, why wouldn't he push it? [17:53:14] O [17:53:23] I'll ask Trevor if it's just sitting on his laptop unpushed [17:53:30] cool [17:53:34] And otherwise I either need to engage in mind-reading, or partially revert this change [17:54:09] or just explain how DesktopContext is attached to DOM and I can figure out how to attach the Mobile one [17:54:36] bearND: i don’t see other new english strings either [17:54:58] RoanKattouw, or even not how, but where [17:55:15] RoanKattouw, yesterday I couldn't find the place where DesktopContext's $element would be attached to something [17:55:36] jgonera: I found that now [17:55:37] (03PS1) 10Mhurd: Getting "Wikipedia" and "The Free Encyclopedia" into qqq. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149349 [17:55:42] brion: ^ [17:56:06] ve.ui.DesktopSurface constructor [17:56:22] hm, looked there but must have missed it, I was pretty tired [17:56:25] bearND: for instance i see an old message https://translatewiki.net/w/i.php?title=Wikimedia:Wikipedia-ios-history-section-lastmonth/en but no new message https://translatewiki.net/w/i.php?title=Wikimedia:Wikipedia-ios-main-menu-heading-legal/en [17:56:49] OK we've texted Trevor [17:57:02] He's helped us by pushing in forgotten code earlier this week, he may do it again [17:57:06] In the meantime, I'm trying a naive approach [17:57:16] Adding the context to the toolbar in MobileViewTarget [17:57:34] lemme check the twn config [17:58:18] paths look ok... [17:58:46] 3MobileFrontend / 3General/Unknown: edit save failure, no discernible diagnostics - 10https://bugzilla.wikimedia.org/68465#c5 (10Arthur Richards) Per http://lists.wikimedia.org/pipermail/qa/2014-July/001800.html sounds like this is likely related to the replag issues on betalabs; Chris mentioned he'll be che... [17:58:54] bearND: can you see if the git checkout is updated and clean? [17:59:54] brion: both YuviPanda and I did fresh clones this morning. [17:59:56] Ugh how do I get VE to work in mobile again? [17:59:59] weeeeeeird [18:00:00] I'm in alpha but I get the source editor [18:00:10] brion: bearND hmm, yeah, weird :| [18:00:18] maybe the importer’s broken :P [18:00:27] brion: latest commit is d40887a43969385f59a0e5bd6f6f9b02f5fc1c38 Merge "Apply infobox-moving transform from Android" [18:00:28] Oh nm found a switch to visual button [18:00:32] i’ll check and make sure it’s not tripping up on something [18:00:36] after our prioritization meeting [18:00:56] jgonera: You got a minute to come to my desk soon? [18:02:25] (03CR) 10Jdlrobson: [C: 032] "According to Reedy this is now deployed everywhere." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148927 (owner: 10Jforrester) [18:02:59] (03Merged) 10jenkins-bot: [Reapply] Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148927 (owner: 10Jforrester) [18:03:05] RoanKattouw, after lunch? [18:03:37] Uhm, OK [18:03:47] I have something that makes the context appear but it doesn't look right [18:04:03] So I need your help to tell me where in the DOM the context should be [18:04:08] RoanKattouw, push it as WIP and I'll have a look [18:04:19] OK [18:05:43] jgonera: https://gerrit.wikimedia.org/r/149356 [18:06:52] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149349 (owner: 10Mhurd) [18:10:07] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148436 (owner: 10Dbrant) [18:13:38] needs the attention of someone on the team - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7691246 [18:15:31] 3MobileFrontend / 3beta: VisualEditor Mobile: fresh accounts being taken to VE by default on beta labs - 10https://bugzilla.wikimedia.org/68583 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Possible regression: Today I created a few fresh accounts on beta labs (desktop Chrome browser, mobile s... [18:16:16] Krenair: android app or moble web? [18:16:23] we've got 2 teams here :) [18:16:26] android app, sorry [18:16:29] np [18:16:39] * Krenair keeps forgetting that [18:16:54] (03PS1) 10Jdlrobson: WIP: Explicitly name template languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149361 [18:17:35] (03PS2) 10Jdlrobson: Explicitly name template languages as Hogan [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149361 [18:20:29] 3MobileFrontend / 3beta: VisualEditor Mobile: fresh accounts being taken to VE by default on beta labs - 10https://bugzilla.wikimedia.org/68583#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/0AK0U7Nl [18:24:15] brion: ios jenkins stuff: http://www.raywenderlich.com/22590/beginning-automated-testing-with-xcode-part-12 [18:24:25] nice [18:30:55] (03PS2) 10Jdlrobson: Move bottom border to page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148504 [18:30:59] (03CR) 10Jdlrobson: [C: 032] Move bottom border to page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148504 (owner: 10Jdlrobson) [18:31:37] (03Merged) 10jenkins-bot: Move bottom border to page actions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148504 (owner: 10Jdlrobson) [18:34:20] jgonera_: tried out https://gerrit.wikimedia.org/r/#/c/148888 with the VE update, but section scrolling still isn't working for me :( [18:35:18] jgonera_ , jdlrobson: You guys gonna show up for this tech eval meeting in R66? [18:40:39] bearND: dbrant re: steps to run to setup android sdk.... https://gist.github.com/yuvipanda/10408391 :) [18:44:00] bearND: dbrant Deskana I also updated the release management cards with descriptions [18:46:31] (03PS3) 10Jdlrobson: Explicitly name template languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149361 [18:52:54] YuviPanda: fyi, I've been gradually mocking up a full-text search ui in the app. [18:53:09] dbrant: w000t [19:15:46] YuviPanda: commented on your gist [19:16:30] bearND: sure! fork and update? :D [19:16:43] bearND: and test as well! these will be on ubuntu precise machines, though [19:16:51] bearND: probably needs a list of packages to be installed from apt-get as well [19:17:03] bearND: I'll be happy to help you along if you want to pick up that card next week [19:19:09] YuviPanda: updated gist https://gist.github.com/berndsi/8c4f27e63b5d693a1342 [19:19:17] bearND: cool. [19:20:08] YuviPanda: going to test it some more on the weekend. uninstalling the SDK is too disruptive. Once it all works then I'll also update the README [19:20:23] bearND: plus this needs to happen on an unbuntu precise host :) I suggest a VM [19:20:29] dbrant: Hello [19:20:45] vbamba: hey! [19:20:53] dbrant: (embarassingly asks) what is the final night mode hex value we settled on? [19:20:56] YuviPanda: good point. are there base images ready for this? [19:21:08] bearND: indeed. labs has those all setup. [19:21:11] I had it scribbled on a post it, then i set the post it note on fire [19:22:08] vbamba: you mean the background for nav/toc? that's #0C0C0C [19:24:49] https://bugzilla.wikimedia.org/show_bug.cgi?id=68583 vs. https://bugzilla.wikimedia.org/show_bug.cgi?id=68584 :/ [19:25:15] 3MobileFrontend / 3beta: VisualEditor Mobile: fresh accounts being taken to VE by default on beta labs - 10https://bugzilla.wikimedia.org/68583#c2 (10Ryan Kaldari) So far haven't been able to reproduce this. Tested in desktop Chrome on beta labs. [19:25:26] YuviPanda: where do i find the right vm image? [19:26:13] bearND: hmm, so there are two ways to do this [19:26:26] bearND: we could use wikimedia labs :) [19:26:28] dbrant: no no, I mean the link color in night mode [19:26:51] vbamba: ah, that's #2B6FB2 [19:26:56] bearND: have you used wikimedia labs before? [19:27:14] YuviPanda, oh hey did you see https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7691246 ? [19:27:38] YuviPanda: no [19:27:50] Krenair: yeah, I have bought it to the attention of the Zero team (who handle most of this) and Deskana|Away [19:28:15] okay, great, ty [19:28:26] Krenair: :) [19:30:46] bearND: so that's our cluster of VMs hosted on our DC to test things around [19:30:55] bearND: http://wikitech.wikimedia.org/ has info [19:32:47] bearND: I can run you through the actual steps next week :) [19:33:08] YuviPanda: ok, that would work. Thanks [19:33:13] dbrant: thank you (life is saved) [19:33:14] bearND: cool :) [19:33:25] vbamba: all in a day's work. [19:33:52] jdlrobson: can you have a look at https://gerrit.wikimedia.org/r/#/c/138229/ again? :) [19:53:27] YuviPanda: dbrant: would one of you CR https://gerrit.wikimedia.org/r/#/c/148866/? [19:55:09] (03CR) 10Brion VIBBER: "It looks like lots of strings from both en and qqq didn't get imported into TWN from our files, so they're not getting translated and not " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149339 (owner: 10BearND) [19:55:30] bearND: done :) [19:55:44] YuviPanda, bearND: any idea what might be going wrong with the TWN updates? [19:55:56] brion: unsure. poke nikerabbit? [19:55:57] it looks like strings from our en & qqq files are not getting imported [19:56:14] brion: I can't debug now even if i want to since I've no shell anymore. I got 'no changes detected' when we tried to do that [19:56:22] well i’m a spectator too, i have no access :) [19:56:34] brion: indeed, but poking nikerabbit is the thing to do :) [20:01:06] (03CR) 10Kaldari: [C: 04-1] "Tried this with the latest VE but still wasn't able to get section scrolling to work." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148888 (owner: 10JGonera) [20:09:44] (03CR) 10Kaldari: [C: 04-1] Add Uploadrestriction using edit count (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:12:12] (03CR) 10Florianschmidtwelzow: Add Uploadrestriction using edit count (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:15:08] (03CR) 10Kaldari: Add Uploadrestriction using edit count (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:17:05] (03CR) 10Kaldari: Add Uploadrestriction using edit count (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:18:11] (03CR) 10Kaldari: Add Uploadrestriction using edit count (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:20:43] (03CR) 10Florianschmidtwelzow: Add Uploadrestriction using edit count (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:24:37] (03CR) 10Kaldari: Add Uploadrestriction using edit count (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:33:50] (03CR) 10Florianschmidtwelzow: Add Uploadrestriction using edit count (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:34:36] (03PS6) 10Florianschmidtwelzow: Add Uploadrestriction using edit count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) [20:36:09] (03PS2) 10Yurik: Logging opera-detection cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/149296 [20:36:15] (03CR) 10jenkins-bot: [V: 04-1] Logging opera-detection cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/149296 (owner: 10Yurik) [20:38:23] hashar, any thoughts? https://integration.wikimedia.org/ci/job/mwext-ZeroBanner-testextensions-master/146/console [20:40:18] yurikMskRu: some regressn in mobilefrontend ? :D [20:40:39] that jobs fetch @master branch of /srv/deployment/integration/slave-scripts/tools/fetch-mw-ext JsonConfig,MobileFrontend,Mantle [20:41:29] YuviPanda|zzz: any good ideas how to get the table.ambox (page issues) to only work on enwiki? Should I just merge issues.less into enwiki.less? [20:42:05] brion: that's one option, yes. but I'd prefer: 1. in our code, add a 'wiki-' class to the element 2. constrain the CSS to just that [20:42:10] err [20:42:10] bearND: [20:42:13] yurikMskRu: see https://gerrit.wikimedia.org/r/#/c/148927/ you should be able to reproduce with master version of mobilefrontend [20:42:29] hashar, that looks suspiscious - that patch rewrites logging a bit, so either jenkins is having a bad hair day, or MaxSem forced-checked in something :) [20:42:32] yurikMskRu: ideally that mobilefrontend patch should have been rejected because it breaks ZeroBanner :-D [20:42:45] bearND: so if a page is on enwiki, a class called 'wiki-enwiki' would get added to head, and in the CSS rule you can just do .wiki-enwiki table.ambox { [20:42:53] hashar, which patch? [20:42:59] arhh [20:43:10] oh, oops [20:43:13] sry [20:43:24] it didn't show on my screen in times [20:43:35] yeah https://gerrit.wikimedia.org/r/#/c/148927/ [20:43:36] :D [20:43:41] YuviPanda: ok, thanks. So, something like 'wiki-enwiki'? how is enwiki.less used right now? [20:43:41] yurikMskRu, jdlrobson killed that class [20:43:53] that one deletes the class and does not keep back compatibility. I guess it got moved to Mantle [20:43:59] bearND: it's a direct copy of en.wikipedia.org/wiki/Mediawiki:Mobile.css :) [20:44:03] so you'll need to use Mantle too [20:44:04] bearND: so I'd rather not touch it [20:44:32] MaxSem: thanks for confirming :] [20:44:41] hashar, how come jenkins allowed it? does it put zerobanner in the dependency chain for mobile? [20:44:48] nop [20:44:53] it just test mobilefrontend [20:44:58] can we? [20:45:08] I am working on some utility / new system to test all extensions togethers though [20:45:16] oh, nice! [20:45:20] so if one propose a change that break another extension, that will be rejected [20:45:30] YuviPanda: makes sense [20:45:32] if it will take a while, anyway to hardcode it for now? [20:45:44] i mean - set up zero depend on mobile? [20:45:45] bearND: :D [20:46:00] yurikMskRu: don't tell anyone. I hate teasers. [20:46:05] yurikMskRu, not mobile but mantle [20:46:15] what maxsem says [20:46:19] just move to mantle! [20:46:32] (and you guys should get mantle to core eventually if that fits there :D) [20:46:33] disconnecting for a bit, will be back in half an hr or so [20:46:47] yurikMskRu: i will be gone [20:52:54] (03CR) 10Kaldari: [C: 04-1] Add Uploadrestriction using edit count (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:54:07] (03CR) 10Kaldari: Add Uploadrestriction using edit count (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:55:50] (03CR) 10Florianschmidtwelzow: Add Uploadrestriction using edit count (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [20:59:04] (03PS7) 10Florianschmidtwelzow: Add Uploadrestriction using edit count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) [21:03:21] jgonera: http://etherpad.wikimedia.org/p/Lower_end_devices_checkup [21:04:52] (03Abandoned) 10Jdlrobson: Hygiene: Start using models for history and contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/133680 (owner: 10Jdlrobson) [21:07:28] (03CR) 10Jdlrobson: [C: 04-1] "What Max said. I would like to see us move closer to the code in core." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142874 (https://bugzilla.wikimedia.org/52059) (owner: 10Florianschmidtwelzow) [21:09:45] jdlrobson, https://integration.wikimedia.org/ci/job/mwext-ZeroBanner-testextensions-master/146/console [21:13:41] (03PS1) 10Jdlrobson: Use correct RL module class for templates [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/149452 [21:16:23] dbrant: in the future when you're cutting prod builds, are you planning to fork from the beta build only? or will it be beta plus any cherry-picked commits? or something else? just trying to understand if the build script should uprev the versionCode when producing the build, or if by definition the versionCode will already be correct because it's based on the beta. [21:17:28] dr0ptp4kt: we're still ironing that out, but ideally a production build should simply fork from the latest beta build. [21:17:54] dbrant: in other words, tentatively, the versionCode would be the same, right? [21:18:35] dbrant: if the answer is tbd, that's okay, too :) [21:19:04] dr0ptp4kt: I believe that's correct, with about 10% uncertainty for tbd. [21:19:18] dbrant: cool [21:21:31] dbrant: i guess, technically speaking, we probably don't want to be adjusting the package base from org.wikipedia.beta back to org.wikipedia. so i think cutting the build from the commit just prior to the beta cut is probably the way to go? that is to say, it would be uprev'd, but to the same versionCode as the beta. so the person would get checkout ^ and then run the build script as --prod (that's the flag i'm thinking to use) [21:21:57] er....s/get ch/git ch/ [21:24:22] dr0ptp4kt: yeah, that sounds reasonable. And actually, the current make-beta script creates a tag right before changing the package name to "beta." [21:24:33] (03PS4) 10Brion VIBBER: References click backend: detect link clicks and send data over bridge [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148247 [21:24:43] dr0ptp4kt: so, that same tag can be used to build the production release. [21:25:04] dbrant: dr0ptp4kt: I think every beta build should add one tagged commit which only change versionCode, but leaves the rest as is. The remaining changes (package change, versionName, label) should not get pushed to gerrit [21:26:25] bearND: agreed [21:27:06] bearND, would the procedure for someone trying to recreate the beta then be to run the make script to arrive at the code used for the apk? [21:28:01] bearND: that is to say, the signature on the release of course guarantees that the code was signed properly, but to know that the code that's in the apk matches something legitimately reconstructed from source code and build scripts would require reproducibility. [21:28:42] bearND: i think as long as we can reproduce the identical APK with the scripts we should be good, in any case. cc dbrant [21:30:14] dr0ptp4kt: yeah, good point. The versionName would mismatch in the current scenario since that is based on the current date when the script was run. that's a hole [21:30:31] that needs to be plugged [21:30:53] bearND: i'm working on the script right now to cover the amazon case. i'll try to reason through some of this to get us at least part of the way there [21:32:53] dr0ptp4kt: I'm experimenting with Gradle instead of Maven. It has very powerful support for build variants, which could come in handy for beta builds, etc. Could also be usefult for Amazon builds. We could have a special portion of the AndroidManifest in the amazon build flavor and have that merged in. [21:33:08] useful [21:33:59] bearND: sweet. i'm hoping you can give me a tutorial. i've looked at it a little, but it's been a while, and i could really use some training from someone who knows it well :) [21:34:22] dr0ptp4kt: dbrant: that wouldn't help the versionName issue being dependent on current date but I envision we could have a command line switch to override that portion [21:44:49] (03PS8) 10Kaldari: Add Uploadrestriction using edit count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [21:45:22] FlorianSW: I decided to move the check into SkinMinerva since that's the only place it's called from [21:45:49] also added a check for $wgEnableUploads [21:50:09] kaldari, https://gerrit.wikimedia.org/r/#/c/148888/ - what device/browser specifically? [21:50:10] FlorianSW: Also changed 'he' to singular 'they' since the gender of the user is unknown. They probably don't teach you singular they in English class in Germany :) https://en.wikipedia.org/wiki/Singular_they [21:50:50] jgonera: iPad, Mobile Safari [21:51:03] kaldari, ok, will check again soon [21:52:14] (03PS9) 10Kaldari: Add Uploadrestriction using edit count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [21:54:56] (03CR) 10Kaldari: [C: 032] Add Uploadrestriction using edit count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [21:55:30] (03Merged) 10jenkins-bot: Add Uploadrestriction using edit count [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/143751 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [22:00:26] kaldari, indeed it stopped working again for whatever reason... [22:01:21] jgonera: probably related to a recent change in VE. Maybe you could git bisect it. [22:01:34] kaldari, yeah, will do [22:26:21] Kaldari: Ah, ok, i think with "they" there was something :D Thanks! But, know we have the problem, that for Special:Uploads not arent't the same rules to show contribute an image button, like the rules to show the mobilemenu link?! [22:38:15] dbrant|bbl, bearND: Can I get an APK from one of you guys to do my signoff? :) [22:40:12] Deskana: I'll make one for you soon. Just cleaning up some gerrit stuff [22:40:15] (03Abandoned) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149334 (owner: 10Yuvipanda) [22:41:01] (03PS7) 10BearND: Show number of matches when finding in page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147761 (owner: 10Alex Monk) [22:49:17] bearND: Great. Thanks! [22:56:30] Deskana: in your inbox [22:56:58] bearND: Thank you! [22:57:29] dr0ptp4kt: You save out the icons as an Android drawable resource. Is that correct? [22:57:55] bearND: Whatever Deskana gets i would like it also [22:58:15] vbamba: It's on mobile-tech :) [22:58:21] vbamba: there's a drawable folder, but these files are uploaded out of band, not as part of the apk [22:58:25] vbamba: you already got it since I sent it to mobile-tech [22:58:47] Deskana: beat me to it ;) [22:58:52] bearND: Deskana thank you :) [22:59:05] i thought you were getting special goodies, never mind. [22:59:39] dr0ptp4kt: got it [23:01:49] vbamba: Do you have an example of an article that has a table with awful colours in it? [23:02:17] world war 2 [23:02:18] :) [23:03:02] dbrant|bbl, bearND: I'd also like a build that has the engineering groundwork stuff in it, so I can sign off on that as well. [23:04:07] vbamba: That doesn't seem to include one. [23:04:13] hmm one sec [23:05:39] I'll check the standard articles. [23:05:46] Adolf Hitler, Nazi Germany [23:05:47] etc. [23:05:48] :P [23:06:13] which ones were we looking at for night mode last time [23:06:24] oyour approach will also work :) [23:06:35] bearND: this apk has the page issue stuff done? [23:08:32] bearND: See the Vitalyst article - it actually has page issues which dont show up on the app [23:08:35] vbamba: unfortunately we haven't merged the page issues stuff yet [23:08:47] this apk has only what's merged to master [23:10:06] vbamba: would you like to get an apk with page issues included? I've incorporated your blue flag icon. thank you for that. There are discussions between Yuvi and I about what to do about non-enwiki sites. [23:10:36] this is why he hasn't +2'd it yet. [23:11:10] So only ready to Sign off Stories shd be examined in this APK? [23:11:46] So basically table colors in Night Mode? [23:13:30] vbamba: just noticed you sent more flag icons (I'm behind on emails :( ). So, you want me to use a different icon for night mode? [23:15:24] yeah, the blue for night mode has reduced brightness so it doesn't vibrate against the black [23:15:29] Is that going to be a pain? [23:17:21] vbamba: it makes it a bit more complicated but I'll see if I can figure that one out [23:22:57] vbamba: are the other two flag icons the same as before? [23:41:15] kaldari did i see you merge a patch that resolves https://trello.com/c/HBlqtUZc/49-implement-edit-threshold-of-10-edits-for-photo-uploads? [23:41:44] awjr: yeah, that's half of it [23:41:52] awjr: the other half will be a config change [23:42:00] I'll add the change to the card [23:42:27] kaldari ok thanks - was that something to SWAT, or let go out with the train on tues? [23:43:04] Maryana ^^ [23:43:32] which thing is this? [23:44:01] Maryana edit threshold for image uplodas [23:44:18] if we could SWAT it if at all possible, that would be awesome [23:44:30] if it goes out on tuesday, that means it won't go live on commons till after wikimania, correct? [23:44:32] kaldari: ^ [23:44:44] since there's no deployment window on the first week of august [23:45:06] * Maryana is always confused about where the train is [23:45:14] Maryana: I can SWAT it on Monday probably