[01:03:51] (03PS1) 10Deskana: Move legally required policy links. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149598 [01:09:44] (03PS1) 10Deskana: Put underscores in the links, just to be safe. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149599 [01:53:30] 3Wikipedia App / 3Android App: JSONException: Unterminated object - 10https://bugzilla.wikimedia.org/68656 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None Seems to have begun with 2.0-r-2014-07-23 We're getting errors like these: org.json.JSONException: Unterminated object at character 60 of [some JSO... [13:19:46] 3Wikipedia App / 3Android App: Add translation in Korean in description of play store about Wikipedia Android app - 10https://bugzilla.wikimedia.org/68678 (10Myeongjin) 3UNCO p:3Unprio s:3normal a:3None I translated page Wikipedia-android-strings-app store description in Korean, so I want add transla... [16:36:25] 3Wikipedia App / 3iOS App: [iOS] Can't deselect text. - 10https://bugzilla.wikimedia.org/68681 (10brett ohland) 3UNCO p:3Unprio s:3normal a:3None If you select some text in an article you can't tap anywhere on the screen to deselect the text (iOS' default behaviour). Also, scrolling will only sometim... [16:37:26] 3Wikipedia App / 3Android App: Android app: Navigation bar doesn't always collapse when searching - 10https://bugzilla.wikimedia.org/68682 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1) Cold boot the app. 2) Tap W to open the navigation bar. 3) Tap search. 4) Type a query that... [16:39:24] 3Wikipedia App / 3iOS App: [iOS] Rotating device midway through a section will return you to the top of that section - 10https://bugzilla.wikimedia.org/68683 (10brett ohland) 3UNCO p:3Unprio s:3normal a:3None App doesn't remember screen position after rotating. Scroll midway into a long section. Rot... [16:42:43] 3Wikipedia App / 3iOS App: [iOS] Scrolling "dead" area - 10https://bugzilla.wikimedia.org/68685 (10brett ohland) 3UNCO p:3Unprio s:3normal a:3None There is a 5-10pt dead area when starting a scroll. To reproduce, simple begin a scroll in either direction very slowly. You'll notice that your finger... [17:27:07] 3MobileFrontend / 3General/Unknown: Lazy-loaded pages are not enforcing upload restrictions on mobile - 10https://bugzilla.wikimedia.org/68414#c13 (10Lupo) Just a little feedback. This fix has been live now for three days. It has further reduced newbie uploads through Mobile/Web by another 40-50% (compared t... [17:30:05] does anyone have Prateek's contact information [17:30:09] phone number [17:39:27] (03CR) 10Siebrand: [C: 032] "Sounds like a plan." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149599 (owner: 10Deskana) [17:41:42] (03CR) 10Siebrand: [C: 04-1] "This should be merged into the parent patch set." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149599 (owner: 10Deskana) [17:42:36] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149598 (owner: 10Deskana) [17:43:07] 3MobileFrontend / 3General/Unknown: Lazy-loaded pages are not enforcing upload restrictions on mobile - 10https://bugzilla.wikimedia.org/68414#c14 (10Jon) Glad to hear it @Lupo! [17:48:03] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149586 (owner: 10Deskana) [17:49:55] Deskana: nice patch :D [17:50:19] ExcitedPanda: Which one? ;) [17:50:24] Deskana: all of them :) [17:50:35] I'm currently a bit confused though. [17:50:39] Perhaps you could help. [17:50:46] Deskana: note that I -2'd a similar patch to what the 'Today' patch was from Adam a while ago :) [17:50:46] Deskana: sure! [17:50:51] https://gerrit.wikimedia.org/r/#/c/149599/ [17:51:02] That should be in the parent patch. I didn't mean to submit it as a separate one. [17:51:06] Don't really know how to go about that though. [17:51:06] Deskana: ah [17:51:14] Deskana: right, so you'll need to 'squash' them together [17:51:28] Deskana: or you can just check out the first patch and amend it. [17:51:54] That sounds easier. [17:51:56] Deskana: squashing is more complicated, but a good skill to have. amending the other patch is easier at this point. I can show you how to squash if you want. [17:52:12] hmmm, I've had to squash things maybe 3-4 times in the last year, so perhaps not that *useful* :) [17:52:41] To be fair, when I submitted the second patch, it asked me if I wanted to squash. [17:52:46] Right, so. [17:52:48] I checked the patch out. [17:52:51] Now to fix the underscores. [17:53:07] Deskana: :D I'll be around for another 30m, poke if you need anything :) [17:53:16] ExcitedPanda: Now git commit --amend ? [17:53:28] Deskana: try git commit -p --amend [17:53:36] Deskana: it'll ask you which parts you want to add, and you can type 'y' for the ones you want to [17:54:30] (03PS2) 10Deskana: Move legally required policy links. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149598 [17:54:46] There we go. [17:54:54] w00, cool [17:55:10] Deskana: siebrand gave you a -1 for something, you still need to fix that :D [17:55:39] Sieband gave me a -1 on both patches because they need to be merged together, basically [17:55:49] Deskana: also mentioned commit message wrapping [17:55:53] He gave me a -1 on the child for not being part of the parent, and a -1 on the parent for not having underscores (which was in the child) [17:55:53] Deskana: yours is too long on one line [17:56:17] Oh, oops. [17:57:44] ExcitedPanda: Why so excited? [17:58:01] Deskana: haha! [17:58:05] (03Abandoned) 10Siebrand: Put underscores in the links, just to be safe. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149599 (owner: 10Deskana) [17:58:08] Deskana: because http://quarry.wmflabs.org/query/22 works and actually executes queries now :D [17:58:22] Deskana: halfak is excited as well (in -research). [17:58:41] (03CR) 10Siebrand: [C: 04-1] "Please update commit message per comment in https://gerrit.wikimedia.org/r/#/c/149598/1//COMMIT_MSG" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149598 (owner: 10Deskana) [17:59:04] Deskana: democratizing data access :) "What if we made data analysis a lot easier for people to explore, will that generate more fun things?" [17:59:18] (03CR) 10Deskana: "Sorry, I missed that. Fixing now." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149598 (owner: 10Deskana) [17:59:41] Eugh, fuck vim. [17:59:44] I want git to use nano. [18:00:09] Deskana: you can set EDITOR=nano in your bashrc [18:00:13] but ugh, nano :) [18:00:34] (03PS3) 10Deskana: Move legally required policy links. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149598 [18:01:04] So, anyway. [18:01:09] I have a strange problem. [18:01:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=68682 [18:01:18] I'm trying to fix this bug. [18:01:24] I've actually fixed it, but caused another one. [18:01:42] * ExcitedPanda clisk [18:02:14] Deskana: hmm, what did you cause? [18:02:34] Well, I added code to the onFocusListener to close the drawer [18:02:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149598 (owner: 10Deskana) [18:02:46] But now when that code executes, the keyboard doesn't come up when you tap the search bar [18:03:19] Deskana: right, we already had code in onClick (I think?) that showed the keyboard (and also hid the bar, I think?), so possibly attaching to onFocus might mess with that? [18:03:57] ExcitedPanda: Well, onClick doesn't execute at all if onFocus does. [18:04:09] Deskana: that'll explain the keyboard not showing up [18:04:10] I think [18:04:14] ExcitedPanda: That's what's confusing. There was code in the onClick that closes the drawer but the first time you tap the search bar it never even runs. [18:04:33] Because the focus changes, and onFocus gets precedence over onClick [18:04:52] Deskana: hmm, then move the code from click to focus? [18:05:14] But onFocusChange only executes on a focus change, so the onClick stuff won't run every time [18:05:24] onFocusChange runs the first time you tap, onClick any subsequent time [18:05:32] that's... weird [18:05:37] Yeah [18:05:45] I mean we could rip the onFocusChange method out [18:05:47] Deskana: Android and focus are... weird a lot of times. [18:05:49] That'd solve the problem [18:05:58] Deskana: right [18:05:59] Because then onClick would work every time [18:06:02] Let's see if that's true [18:07:20] I mean, there is code in there that would need to be moved [18:07:22] But we can do that [18:07:45] Hmm, this doesn't really do it. [18:08:00] I guess it's still doing the onFocusChange, so onClick doesn't get called [18:08:17] Deskana: hmm, *copy* the code? :D [18:08:34] Well, that's the thing. The code in onClick would do it if it were being executed. [18:08:51] It's not that the code isn't there, it's that it's not getting called at all [18:09:07] It's still doing the onFocusChange, but now it's doing nothing since I commented out the method [18:09:16] I guess we could make the onFocusChange method call the onClick method [18:09:17] Haha [18:09:31] Deskana: haha :D [18:09:36] Deskana: Android sometimes has... issues. [18:09:43] Deskana: I bet the behavior would be totally different on a different version [18:10:16] Probably. [18:10:23] Can we add some code that manually shows the keyboard? [18:10:48] Deskana: there's one in Utils, you should be able to use tha.t [18:10:50] *that [18:11:22] I'm probably being too stringent on myself because I'd been toying with doing that for a while but I felt like I should try and do it properly [18:11:26] For some definition of properly... [18:12:49] Deskana: android UI hacks are kindof everywhere [18:15:56] ExcitedPanda: There's a hide keyboard, but not a show. [18:15:58] I guess I add that too. [18:16:10] What's the convention here? Do I just add that into my patch or do I do it as a separate one? [18:16:44] Deskana: no just add it in your patch [18:16:57] Deskana: we try to keep everything in the Utils class fully documented in the JavaDoc style, so do follow that as well. [18:21:04] I'll come back to it before I get burnt out. [18:22:14] Deskana: :D ok [18:22:16] Deskana: <3 [18:22:59] ExcitedPanda: Why did you -2 Adam's change? [18:23:30] Deskana: my reasoning at that time was 'do not think we should use the limited space in there for something like this without significantly doing more on the main page' [18:25:36] such as stats, numbers of other sorts, a 'welcome' thingy, etc [18:25:42] Deskana: however, you are product, and so can override :) [18:30:47] ExcitedPanda: Yeah, I get that. However, it seems a bit strange to me that there's no way to find out what today's featured article is without typing "Main page" into the search bar. [18:31:21] ExcitedPanda: It's a bit weird making a product decision then going away and implementing it myself, but I only did that because I figured I could do it and it'd be fun (and I could!) [18:31:24] Deskana: maybe. I don't know how much of an use case it is, although it's fairly trivial to do... [18:31:27] Deskana: :D indeed! [18:31:40] Deskana: and the earlier <3 is for a PM who does those kinda things :) [18:38:02] :D [18:39:41] I just wish I had time to do this during work hours rather than that time being taken up by other product stuff [18:39:48] This is way better for my professional development imo [18:40:57] Deskana: +1 [18:41:35] Deskana: the concept of '20% time' has been something vaguely used by me to develop my ops skills. Me and Tomasz put it into the yearly goals as well. Perhaps something you cound try too [18:41:36] *could [18:41:55] My 20% time is SUL finalisation right now [18:42:16] Deskana: ah, hmm. right. I guess after that, maybe [18:42:27] I raised this in my annual review. I am dropping rather essential app-related responsibilities because I've got three products on the go. [18:42:42] Since he's now fully turned on to the idea of me being a mobile PM, he has to make a choice. [18:43:06] Deskana: 'fully turned'? [18:43:37] Yeah, he made out that "going back to platform" is no longer on the cards [18:43:49] So now he's got to actually enforce that properly, which he isn't doing right now [18:44:36] Deskana: ah, right. Hovercard has pretty much stalled at this point anyway. Is someone else in the hiring pipeline now? [18:44:47] I don't know [18:44:58] He is hiring a new product manager [18:45:04] But it's really unclear to me what that person's going to do [18:45:15] Because they're not being hired with a product area in their job title [18:45:29] Deskana: oh [18:45:36] Deskana: maybe platform will just go back to old status quo? [18:46:01] Well, engineering is going to be restructured soon by the new VPE. [18:46:08] So I dn't think that's going to happen either way. [18:46:28] Deskana: oh, hmm. that's going to be interesting [18:46:32] * ExcitedPanda didn't know [18:46:36] things you miss when not in the office :) [18:50:01] I think it might be need-to-know. [18:50:02] So, oops. [18:50:04] Oh well. [18:51:12] Deskana: well, a lot of times things that are common knowledge in the office rarely get transmitted on the internet. [18:51:23] 3Wikipedia App / 3Android App: Android app: Navigation bar doesn't always collapse when searching - 10https://bugzilla.wikimedia.org/68682#c1 (10Dan Garry) *takes off his product hat and puts on his junior engineer hat* I took a look at this. There is code in the onClickListener that collapses the navigatio... [18:51:27] Deskana: all my Wikimania / Hackathon / All Staff visits are full of surprises [18:51:38] Yeah, mainly because it's not "official official" yet so no formal email has been sent [18:51:50] Which is fairly understandable, albeit sucky [18:52:19] Wow, well, reading that bugzilla comment over, it almost sounds like I know what I'm talking about. [18:54:08] 3Wikipedia App / 3Android App: Android app: Navigation bar doesn't always collapse when searching - 10https://bugzilla.wikimedia.org/68682#c2 (10Yuvi Panda) :D Soft Keyboard and Focus are kindof weird in Android - we explicitly hide the keyboard after activity closes, even though there should be no reason w... [19:03:07] 3Wikipedia App / 3Android App: Android app: Navigation bar doesn't always collapse when searching - 10https://bugzilla.wikimedia.org/68682#c3 (10Dan Garry) (In reply to Yuvi Panda from comment #2) > :D > > Soft Keyboard and Focus are kindof weird in Android - we explicitly hide the > keyboard after activity... [19:03:46] Deskana: there's a hideSoftKeyboard method, which in turn calls a hideSoftInput method. You can just copy that and change the hide to show [19:04:01] ExcitedPanda: I tried that but I don't think it worked. Let's see. [19:04:11] Deskana: oh :| [19:04:22] ExcitedPanda: I think it needs an extra parameter telling it where the keyboard input is going. [19:04:50] Deskana: hmm? showSoftInput only takes two parameters [19:05:10] Aha. It needs a view. [19:05:48] Right. [19:05:50] Let's see if that works. [19:08:53] Nope. [19:09:25] sigh [19:11:20] I'm going to try calling that new method somewhere else to see if it's the method that's broken, or just where it's being called from [19:11:26] Deskana: ok! [19:11:27] I think the latter is more likely, but I should test it [19:11:31] I've to go in about 5 mins tho. [19:11:55] I think you've given me enough to work on. :) [19:12:40] Deskana: :D \o/ [19:13:38] Yeah, it seems that it's just my method that doesn't work. [19:14:01] hmm, might have been different views to pass to it? [19:14:04] I put it in an onClick somewhere else and it didn't work [19:18:44] Ahhh [19:18:48] I think I had the view wrong [19:19:05] Er, maybe not [21:25:28] YuviPanda|zzzzz: This is just stupid. [21:28:02] (03PS1) 10Bartosz Dziewoński: Use $wgResourceModuleSkinStyles for Minerva's core style overrides [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149780 [22:28:06] 3Wikipedia App / 3Extension:MobileApp: MobileApp tests are failing - 10https://bugzilla.wikimedia.org/65954#c6 (10Kunal Mehta (Legoktm)) I think this is because the extension depends upon MobileFrontend: https://integration.wikimedia.org/ci/job/mwext-MobileApp-testextensions-master/68/console 21:28:23 1) /... [22:51:44] (03PS1) 10Deskana: Add showSoftKeyboard method to Utils. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149786