[01:52:54] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/MobileFrontend.php#L21 grrrrr [01:55:04] (03CR) 10Legoktm: "FIXME" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [02:03:03] (03PS1) 10Legoktm: Move Mantle dependency check into efMobileFrontend_Setup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149797 (https://bugzilla.wikimedia.org/68704) [02:03:44] (03CR) 10Legoktm: Add template dependency to Mantle extension (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [02:08:37] 3MobileFrontend / 3Feature requests: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039#c4 (10Killiondude) (In reply to Liangent from comment #0) > https://en.wikipedia.org/wiki/Special:Contributions sends me to > https://en.m.wikipedia.org/wik... [02:26:22] 3Wikipedia App / 3Android App: Google search links to Wikipedia app still when it was uninstalled - 10https://bugzilla.wikimedia.org/68275#c10 (10Alex Monk) (In reply to fireattack from comment #4) > Understood that. My point is we should at least have some plain text > description other than internal links... [07:44:48] (03CR) 10Florianschmidtwelzow: [C: 031] Move Mantle dependency check into efMobileFrontend_Setup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149797 (https://bugzilla.wikimedia.org/68704) (owner: 10Legoktm) [07:57:38] 3Wikipedia App / 3Extension:MobileApp: MobileApp tests are failing - 10https://bugzilla.wikimedia.org/65954#c9 (10Antoine "hashar" Musso) The MobileApp Jenkins job was missing dependencies MobileFrontend and Mantle. A dummy patch ( https://gerrit.wikimedia.org/r/#/c/149803/ ) pass tests now! Will make it v... [08:01:59] 3Wikipedia App / 3Extension:MobileApp: MobileApp tests are failing - 10https://bugzilla.wikimedia.org/65954#c12 (10Antoine "hashar" Musso) 5PATC>3RESO/FIX Tests are now passing and Zuul is now voting for them. \O/ [08:11:34] (03CR) 10Hashar: [C: 031] "On some other repositories, I fixed a similar issue by using the MediaWiki hook 'SetupAfterCache'. wgExtensionFunctions would work thoug" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149797 (https://bugzilla.wikimedia.org/68704) (owner: 10Legoktm) [09:31:38] (03CR) 10Yurik: [C: 032] Use correct RL module class for templates [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/149452 (owner: 10Jdlrobson) [09:31:50] (03Merged) 10jenkins-bot: Use correct RL module class for templates [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/149452 (owner: 10Jdlrobson) [09:34:11] (03PS3) 10Yurik: Logging opera-detection cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/149296 [13:24:39] 3Wikipedia App / 3Android App: Crash due to JSONException: Unterminated object - 10https://bugzilla.wikimedia.org/68735 (10Dmitry Brant) 3NEW p:3Unprio s:3normal a:3None A number of these have appeared after the references-popup update. It looks like it only happens in Chinese strings... https://tic... [13:45:42] (03PS2) 10Dbrant: Add showSoftKeyboard method to Utils. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149786 (owner: 10Deskana) [13:53:21] (03CR) 10Dbrant: [C: 04-1] "Code looks good, but -1 until we receive the correct icon asset. Also, are we sure about the text "Today"? One might think that it's a l" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149586 (owner: 10Deskana) [14:05:53] (03CR) 10Dbrant: "(Also, dr0ptp4kt had already made a patch for this: https://gerrit.wikimedia.org/r/145402)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149586 (owner: 10Deskana) [14:15:25] (03CR) 10Dbrant: [C: 032] Move legally required policy links. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149598 (owner: 10Deskana) [14:30:56] 3Wikipedia App / 3Android App: JSONException: Unterminated object - 10https://bugzilla.wikimedia.org/68656#c1 (10Dmitry Brant) *** Bug 68735 has been marked as a duplicate of this bug. *** [14:30:56] 3Wikipedia App / 3Android App: Crash due to JSONException: Unterminated object - 10https://bugzilla.wikimedia.org/68735#c1 (10Dmitry Brant) 5NEW>3RESO/DUP Ah sorry; created this bug right before noticing the duplicate. *** This bug has been marked as a duplicate of bug 68656 *** [14:40:08] (03CR) 10Manybubbles: [C: 031] "This issue this is a fix for is currently stopping me from running scripts in beta. Please have a look at this as soon as you can. I rea" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149797 (https://bugzilla.wikimedia.org/68704) (owner: 10Legoktm) [14:43:18] Deskana: you've been busy! [14:44:00] dbrant: Yeah! [14:44:06] dbrant: I had fun this weekend. [14:45:13] very nice! [14:47:03] dbrant: Do you know anything about this? https://trello.com/c/JVuPhTst/59-android-app-navigation-bar-doesn-t-always-collapse-when-searching [14:47:40] dbrant: I fixed it, but in the process caused another issue I couldn't fix... [14:48:52] 3Wikipedia App / 3Android App: Android app: Navigation bar doesn't always collapse when searching - 10https://bugzilla.wikimedia.org/68682#c4 (10Dan Garry) (In reply to Dan Garry from comment #3) > *still has junior engineer hat on* > > Yeah, it probably makes sense to add a generic show soft keyboard metho... [14:50:29] Deskana: hmm, I'll have a look. Also, I added a patch on top of yours, since the showKeyboard function is actually used in other places, and this consolidates it. [14:50:41] w00t [14:54:29] dbrant: It's like the animation of the navigation menu stops the keyboard from coming up somehow. You've used that method elsewhere but it just won't work in the method I want to use it in! [14:54:51] dbrant: Unless I misuse it, actually. I originally had it running on (if !hasFocus) which caused it to come up any time you tapped away from the search bar. :-p [14:55:01] dbrant: But that proved that the method worked, at least... [14:55:12] Deskana: right... Android has some weird behaviors relating to that. [15:17:36] (03CR) 10Hashar: "Load order change in operations/mediawiki-config.git https://gerrit.wikimedia.org/r/149873" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149797 (https://bugzilla.wikimedia.org/68704) (owner: 10Legoktm) [15:26:52] just FYI, trying to load Mantle after MobileFrontend is breaking Beta Cluster: https://gerrit.wikimedia.org/r/#/c/149873/ [15:27:44] in addition to greg-g: https://gerrit.wikimedia.org/r/#/c/149797/ is related to this, too [15:47:42] * YuviPanda waves at Deskana|Away, dbrant and bearND [15:47:55] hello! [15:48:23] dbrant: I see you've merged Deskana|Away's patches and CR'd some more, so yay [15:48:32] yep [15:48:52] YuviPanda, hey. When do you guys next plan to import new translations? [15:49:01] Krenair: we did an import on friday [15:49:18] dbrant: do you want to add an 'import/export' thing to our schedule? [15:49:38] YuviPanda, hmm... [15:49:43] There is https://translatewiki.net/wiki/Wikimedia:Wikipedia-android-strings-menu_themechooser/ru [15:49:54] Krenair: it's not in any release yet... [15:50:03] Yes but [15:50:36] git log on values-ru/strings.xml shows last update as Mon Jul 14 22:31:15 2014 +0200 [15:51:47] Krenair: ah, it didn't get merged https://gerrit.wikimedia.org/r/#/c/149336/ [15:51:56] let me run tests and merge [15:52:13] (03PS2) 10Yuvipanda: Manual translation import from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149336 (owner: 10BearND) [15:52:53] Hey YuviPanda! [15:53:19] hey Deskana [15:56:39] (03PS1) 10Dbrant: Fix possible crash related to JSON encoding in clicking references. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149883 (https://bugzilla.wikimedia.org/68656) [16:00:04] dbrant: hmm, I wonder if that'll help, since we aren't using javascript: urls to pass messages from JS to Java [16:01:53] YuviPanda: yeah, actually I couldn't reproduce the issue, even when looking at the exact articles mentioned in the reports. I just thought that it's most likely some kind of encoding issue, and urlencode is better than nothing... [16:02:08] dbrant: yeah, but I think bridge already encodes them... [16:02:20] dbrant: and from JS to Java we call through the marshaller, and not the javascript: url hack [16:02:27] so we would be double encoding here... [16:03:53] YuviPanda: yeah, it was just a guess. It would be good if someone can reproduce it. [16:04:02] dbrant: true [16:04:33] dbrant: psychic debugging is always fun, if a bit hit-or-miss :) [16:05:03] indeed [16:06:18] * bearND waves at YuviPanda and dbrant [16:06:25] hey bearND [16:06:29] hello! [16:06:36] bearND: am running tests on the translation import patch, will merge shortly [16:08:05] YuviPanda: hmm, should i try to import from twn again? Brion -1 the iOS one and said there seemed to be something missing [16:08:23] like qqq or something iirc [16:08:33] bearND: yeah, I guess maybe that was because we hadn't done an import in a while and so they weren't on translatewiki, and hence won't be exported... [16:15:47] (03CR) 10Brion VIBBER: [C: 04-1] "I think this belongs in the bridge code, not in the high-level usage of the bridge." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149883 (https://bugzilla.wikimedia.org/68656) (owner: 10Dbrant) [16:15:51] YuviPanda: i'm going to abandon that one and redo if that's ok with you [16:15:57] bearND: yeah, sure [16:19:26] (03Abandoned) 10BearND: Manual translation import from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149336 (owner: 10BearND) [16:19:42] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149887 [16:20:06] YuviPanda: ^ [16:20:14] bearND: cool, running now [16:21:23] (03Abandoned) 10BearND: Manual import from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149339 (owner: 10BearND) [16:33:46] (03CR) 10MaxSem: [C: 032] Move Mantle dependency check into efMobileFrontend_Setup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149797 (https://bugzilla.wikimedia.org/68704) (owner: 10Legoktm) [16:34:24] (03Merged) 10jenkins-bot: Move Mantle dependency check into efMobileFrontend_Setup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149797 (https://bugzilla.wikimedia.org/68704) (owner: 10Legoktm) [16:41:10] (03PS1) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149894 [16:41:53] (03PS2) 10Yuvipanda: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149887 (owner: 10BearND) [16:42:16] (03PS3) 10Dbrant: Add showSoftKeyboard method to Utils, and use it where necessary. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149786 (https://bugzilla.wikimedia.org/68682) (owner: 10Deskana) [16:45:04] YuviPanda: why did you remove some of the Czech translations? [16:45:17] bearND: compilation error [16:45:18] s [16:45:34] bearND: first because the % encoding was being interpreted as % formatting [16:46:03] YuviPanda: That's for the first one only though, not the two that follow [16:46:19] bearND: the second one was because android was complaining about 'string not ending properly' [16:46:21] I'm unsure why [16:46:54] YuviPanda: ok [17:17:03] (03CR) 10Yuvipanda: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149887 (owner: 10BearND) [17:20:04] (03Merged) 10jenkins-bot: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149887 (owner: 10BearND) [17:21:07] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c132 (10Ryan Kaldari) @Florian: I think it's fine to let it get deployed normally. FWIW, the uploads graph shows that unique uploaders have been halved again since the lazy-loading loophole was close... [17:30:32] jgonera MaxSem don't forget about today's showcase - add stuff you want to show off to the agenda :) [17:31:29] bearND: yeah, having the enwiki stuff as a separate patch is ok too. I can even take that up :) [17:34:15] YuviPanda: that would be awesome. Thanks! There is another thing I forgot to mention. Vibha would like us to use a different color for the flag and the border around it when in night mode. [17:34:27] bearND: sure. just override it in night.less [17:34:35] hmm, still looks like updates to the iOS qqq file didn’t get imported to twn :( [17:35:02] or the en Main_iPhone file [17:35:32] YuviPanda: if I have both rules in issues.less and night.less than it doesn't show up at all. [17:36:42] bearND: hmm, what do you mean 'doesn't show up at all'? [17:36:52] bearND: doesn't exist in output CSS? or not being affected in display? [17:37:09] brion: ouch! Were those strings updated since Friday morning? [17:37:10] (03CR) 10Brion VIBBER: [C: 04-1] "There are still missing strings from the Main_iPhone.strings file, for instance:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149894 (owner: 10BearND) [17:37:27] YuviPanda: not in CSS [17:37:33] bearND: nope, should be unchanged since a while [17:38:35] bearND: hmm, that's weird. [17:38:56] bearND: can you submit the patch to Extension:MobileApp and I'll take a look? don't let that block the main patch either [17:41:11] YuviPanda: do you mean the try with the different nightmode color or without? [17:41:46] bearND: do one patch with just the plain, 'normal' mode css? [17:42:25] YuviPanda: ok [17:43:52] I'm going afk for a bit to take a very late shower, brb [17:46:21] 3MobileFrontend / 3Feature requests: Internal links cannot be distinguished from interwiki links - 10https://bugzilla.wikimedia.org/62747#c13 (10Maryana Pinchuk) 5NEW>3RESO/WON Closing this as WONTFIX, because it sounds like there's no consensus for how to move forward to make the design consistent and u... [17:46:39] man i wish i knew what was up with that ios translatewiki import. maybe it’s not completing… [17:47:10] bearND: do you have the list of commands you’re running handy? i wonder if only part of the groups are being imported by mistake [17:47:31] the ios app is slightly funky in that it has three strings files which go to subgroups of an aggregate group [17:49:22] brb coffee [17:49:24] 3MobileFrontend / 3stable: Limn statistics are wrong for mobile/web uploads - 10https://bugzilla.wikimedia.org/68755 (10Lupo) 3NEW p:3Unprio s:3normal a:3None As established in bug 62598, the limn statistics for mobile/web uploads are either wrong or severly out of date (for July at least). http://m... [17:50:37] 3MobileFrontend / 3stable: Limn statistics are wrong for mobile/web uploads - 10https://bugzilla.wikimedia.org/68755#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/docJpTe6 [17:51:45] brion: sent you the commands via email [17:52:06] tx taking a look [17:52:29] YuviPanda|brb: the mobile extension patch was already submitted: https://gerrit.wikimedia.org/r/#/c/148866/ [17:53:11] brion: hey! [17:53:13] bearND: yeah i think that’s what’s happening. can you try if ‘out-wikimedia-mobile-wikipedia-ios-0-all’ in place of ‘out-wikimedia-mobile-wikipedia-ios’ works? [17:53:20] hey mhurd [17:55:37] brion: I'm not specifying those on command line at all. I did talk to Nikerabbit on the i18n channel about the error msg related to out-wikimedia-mobile-wikipedia-ios-0-all I got (EE2: Unknown message group out-wikimedia-mobile-wikipedia-ios-0-all.), and he responded with a patch (seemed like we could ignore that at that time): https://gerrit.wikimedia.org/r/149893  [17:55:59] brion: hey dan and vibha were wondering if we could modify the references backend stuff a bit to provide me the id of the anchor elements (so we can highlight the link as the user scrolls between the refs). does this sound doable? [17:56:16] mhurd: yeah that should be pretty easy [17:56:28] bearND: whoa…. :) [17:56:33] brion: since it has been merged I can run it again [17:56:42] aha [17:56:42] let’s try it [17:56:46] brion: but I doubt it would make a difference [17:56:54] if that doesn’t work we can try importing the individual subgroups [17:56:59] brion: would you have a bit of time to hack on this later this morning? [17:57:02] it looks like it’s exporting back to strings files ok, it just isn’t updating [17:57:04] mhurd: sure [17:57:09] brion: yay! [17:58:24] brion: I guess I need to do something to get his patch (still getting the old error msg) [17:58:29] :( [17:58:52] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c133 (10Florian) @Ryan: OK :) [17:59:09] bearND: ok try processing “out-wikimedia-mobile-wikipedia-ios-ui” explicitly [17:59:34] that should be another subgroup like out-wikimedia-mobile-wikipedia-ios and should work *fingers crossed* [18:00:12] it’s always fun to add new workflows to a complex system like translatewiki :D [18:00:13] brion: do I add that as a commandline arg? [18:00:54] bearND: php /…/processMessageChanges.php —group=“out-wikimedia-mobile-wikipedia-ios-ui” [18:01:46] brion: ah, thaaat command. I wasn't running that today since that is for the other direction [18:02:03] ah yeah we still gotta get some of the messages into TWN [18:02:08] before we can get them back out :D [18:02:54] 3MobileFrontend / 3General/Unknown: beta labs Special:Uploads page throwing 503 from varnish - 10https://bugzilla.wikimedia.org/68756 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None as a logged-in user, visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Uploads Error is Request: GET htt... [18:03:08] brion: oh one more thing - if in addition to the id of the link it could also provide the text of the link (ie “[12]” etc) that would be super cool [18:03:27] mhurd: easy enough. :D [18:03:38] brion: woohoo! [18:04:08] chrismcmahon: Did you get a chance to follow-up on https://bugzilla.wikimedia.org/show_bug.cgi?id=68465 ? [18:04:56] Deskana: for the app listings, what do you think about changing 'come fork us' to 'we look forward to your pull requests', so as to encourage code going into the mainline? [18:05:06] 3MobileFrontend / 3General/Unknown: edit save failure, no discernible diagnostics - 10https://bugzilla.wikimedia.org/68465#c6 (10Chris McMahon) I believe this is fixed with the change to allow longer replag. [18:05:14] kaldari: thanks, closed it [18:05:20] dr0ptp4kt: Sure. [18:05:22] 3MobileFrontend / 3General/Unknown: edit save failure, no discernible diagnostics - 10https://bugzilla.wikimedia.org/68465 (10Chris McMahon) 5NEW>3RESO/FIX [18:05:25] cool, thanks! [18:05:33] Deskana: thx, will update [18:05:37] dr0ptp4kt: I think the description might be on twn too. [18:05:39] dr0ptp4kt: Let me check. [18:05:40] 3MobileFrontend / 3General/Unknown: beta labs Special:Uploads page throwing 503 from varnish - 10https://bugzilla.wikimedia.org/68756#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/C5s7Hu6n [18:05:49] Deskana: cool, thank you [18:06:26] Deskana: looks like the play console now has a 'short description' as well. more work for you! [18:06:45] dr0ptp4kt: So it is on translatewiki.net, but I don't know where. [18:07:10] dr0ptp4kt: o rly. Let me write that down so I remember. [18:07:11] dr0ptp4kt: Thanks for letting me know! [18:08:52] 3MobileFrontend / 3Feature requests: Use jQuery JavaScript Library v2.1.1 in mobile - 10https://bugzilla.wikimedia.org/65865#c8 (10Juliusz Gonera) 5NEW>3RESO/WON This will potentially cause more problems than benefits. Closing, let's wait until we can use jQuery 2.x on desktop too. [18:08:53] Deskana: cool. the amazon appstore has a similar thing. there i just used the first paragraph with a small modification at the end to put the key features front and center: 'Official Wikipedia App. Wikipedia is the free encyclopedia containing more than 32 million articles in 280 languages, and is the most comprehensive and widely used reference work humans have ever compiled. The app has been rewritten from scratch. Read, save, and edit [18:08:53] articles faster than ever before.' [18:09:10] (that is i updated the amazon appstore thing...haven't set the short description on play) [18:09:17] This pen is awful. [18:11:36] 3MobileFrontend / 3beta: Visual inconsistencies between OOJS and VisualEditorOverlay - 10https://bugzilla.wikimedia.org/65957#c3 (10Juliusz Gonera) 5NEW>3RESO/INV Presently OOUI forms look completely different because of a few refactorings that happened in OOUI since that bug was reported. Visual consist... [18:13:07] (03Abandoned) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149894 (owner: 10BearND) [18:13:51] 3MobileFrontend / 3Feature requests: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039#c5 (10Maryana Pinchuk) 5NEW>3RESO/WON So, from both an experienced and new user perspective, this doesn't seem like an issue. If you've navigated to Spe... [18:14:12] (03PS1) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149914 [18:15:01] (03PS3) 10Kaldari: Fixing height of image in mobile media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149221 [18:15:05] (03PS1) 10Kaldari: Fixing fatal error on Special:Uploads for mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149915 (https://bugzilla.wikimedia.org/68756) [18:15:14] mhurd: to check — do you need the id of the thing being linked to or the id of the [1] marker? [18:15:21] either is easy enough :D [18:15:24] or both [18:15:26] the [1]marker [18:15:27] (03CR) 10Kaldari: [C: 032] Fixing fatal error on Special:Uploads for mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149915 (https://bugzilla.wikimedia.org/68756) (owner: 10Kaldari) [18:15:29] 3MobileFrontend / 3General/Unknown: beta labs Special:Uploads page throwing 503 from varnish - 10https://bugzilla.wikimedia.org/68756 (10Chris McMahon) [18:15:29] ok [18:15:36] brion: ^^ new patch for translations [18:15:45] \o/ [18:15:53] 3MobileFrontend / 3Feature requests: Adds specific support for ProofreadPage Page: namespace - 10https://bugzilla.wikimedia.org/65165#c6 (10Juliusz Gonera) 5NEW>3RESO/WON I don't think it's feasible to provide this feature on small mobile screens at all. Closing unless someone proposes a really good UI f... [18:16:02] bearND: yessssssss looks good :DDDD thanks! [18:16:46] brion: oh also this should be good to go: https://gerrit.wikimedia.org/r/#/c/149349/ [18:16:57] brion: https://gerrit.wikimedia.org/r/149914 . looks like it didn't delete anything from qqq this time :) yw [18:17:12] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Woohoo! We fixed the import problems in the Main_iPhone.strings by manually running a second manual import on the *-ui subgroup. Thanks!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149914 (owner: 10BearND) [18:17:29] (03PS2) 10Brion VIBBER: Getting "Wikipedia" and "The Free Encyclopedia" into qqq. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149349 (owner: 10Mhurd) [18:17:41] (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks clean" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/149349 (owner: 10Mhurd) [18:17:48] yay! [18:20:07] (03PS4) 10BearND: Show page issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148506 [18:21:58] dbrant, bearND, YuviPanda, mhurd, brion: In case you're wondering why I'm sometimes very absent, this is the other major time commitment I have: https://www.mediawiki.org/w/index.php?title=SUL_finalisation/status&diff=prev&oldid=1081226 [18:22:08] 3MobileFrontend / 3alpha: Tasks suggestion campaign for adding links not specific enough - 10https://bugzilla.wikimedia.org/67674 (10Maryana Pinchuk) 5NEW>3RESO/FIX [18:22:24] dbrant, bearND, YuviPanda, mhurd, brion: I really really hope to have this finished by September so I can start focussing on the apps full time. [18:22:44] Deskana: yay! evil-plans.txt finally comes to fruition ;) [18:23:14] brion: Until I run rm -f evil-plans.txt out of frustration. :P [18:23:23] haha [18:23:39] ah, i see! [18:23:50] Deskana: :) [18:27:39] (03PS2) 10Kaldari: Fixing fatal error on Special:Uploads for mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149915 (https://bugzilla.wikimedia.org/68756) [18:29:57] (03PS5) 10Brion VIBBER: References click backend: detect link clicks and send data over bridge [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148247 [18:30:02] lemme also rebase that [18:30:09] MaxSem: Can you review https://gerrit.wikimedia.org/r/#/c/149915 for me? It needs to be merged today and it's only PHP code. [18:30:12] (03PS6) 10Brion VIBBER: References click backend: detect link clicks and send data over bridge [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148247 [18:30:49] mhurd: ok that should give you the bits like this: https://gist.github.com/brion/127dfc1f1d8b2f74f3fd [18:31:16] brion: no way! that’s awesome! [18:31:21] :D [18:31:27] (03CR) 10MaxSem: [C: 032] Fixing fatal error on Special:Uploads for mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149915 (https://bugzilla.wikimedia.org/68756) (owner: 10Kaldari) [18:31:30] i love it when a plan comes together [18:31:34] :) [18:31:39] thanks [18:31:56] awjr: https://trello.com/c/PWnBPhuT/72-mobile-reportcard-revamp [18:32:46] (03CR) 10Kaldari: [C: 032] Fixing height of image in mobile media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149221 (owner: 10Kaldari) [18:33:20] (03Merged) 10jenkins-bot: Fixing height of image in mobile media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149221 (owner: 10Kaldari) [18:33:31] (03Merged) 10jenkins-bot: Fixing fatal error on Special:Uploads for mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149915 (https://bugzilla.wikimedia.org/68756) (owner: 10Kaldari) [18:33:40] YuviPanda: will you keep me in the loop regarding the things we need from the Ops team? [18:34:06] 3MobileFrontend / 3Feature requests: Difficult or impossible to copy and paste file link from commons "use this image" - 10https://bugzilla.wikimedia.org/67618#c5 (10Maryana Pinchuk) 5NEW>3RESO/WON So, it actually is possible to copy and paste image code -- you just have to navigate to a file page and co... [18:34:07] dbrant: ah, right. so I'm thinking of another method that won't require anything from the ops team [18:34:38] YuviPanda: well that's certainly better! [18:34:53] 3MobileFrontend / 3General/Unknown: beta labs Special:Uploads page throwing 503 from varnish - 10https://bugzilla.wikimedia.org/68756 (10Ryan Kaldari) 5PATC>3RESO/FIX [18:34:57] awjr, can I skip the showcase? my home craptop gets overheated too quckly from hangouts [18:34:58] YuviPanda: me too, please [18:35:00] dbrant: bearND using toollabs (tools.wmflabs.org) which is shared infrastructure that everyone can use (we're using it for our android maven repo). setup a cron job that does a git pull every 30m, and makes an apk if there's a new commit [18:35:57] ok gotta run and play rotating bank cards to make sure cat sitters get st up :D brb [18:36:16] YuviPanda: that would make it harder to map to a particular commit [18:36:26] bearND: why? [18:36:32] bearND: commits will have the same sha1 everywhere [18:36:52] 3MobileFrontend / 3alpha: Tasks suggestion campaign for adding links not specific enough - 10https://bugzilla.wikimedia.org/67674#c3 (10Ryan Kaldari) This feature was removed in https://gerrit.wikimedia.org/r/#/c/147345/ [18:37:09] what if there are multiple commits in the last 30 min. [18:37:44] bearND: we can do a git log ..HEAD, and do one for each? [18:37:57] bearND: dbrant also, I don't think it's important to have one for all the commits as long as we have them for the latest commit [18:38:32] YuviPanda: so, that one is for things getting merged to master, right? [18:38:40] kaity: where did ya go [18:38:41] kaldari, do you think we have anything worth of showing in the showcase? nothing comes to my mind [18:38:49] hmm [18:38:59] bearND: yeah. [18:39:31] jgonera: We could show the new version of the mobile media viewer (that is more like the desktop version) [18:39:43] kaldari, oh, ok [18:39:46] but that's kind of minor [18:39:53] kaldari, do you want to show that? [18:39:58] sure [18:40:28] (03CR) 10Florianschmidtwelzow: "Damn :/, thanks for this patch!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149915 (https://bugzilla.wikimedia.org/68756) (owner: 10Kaldari) [18:40:33] jgonera: are there any new VE features we could show? [18:40:48] kaldari: lunch before showcase? [18:41:00] kaldari, not really, just fighting with bugs, and actually it looks worse than it used to dues to dialog.window changes [18:42:01] bearND: dbrant what do you think of this solution? [18:42:15] dbrant: bearND should simplify thigs greatly, and put more things into our control [18:42:28] YuviPanda: sounds fine to me! [18:42:30] YuviPanda: I think it's a great start to get things in the right direction [18:43:19] YuviPanda: eventually it would be great to have builds for commits in code review, and also running tests, but one thing at a time [18:43:49] bearND: yeah, running tests is going to be a bit... hard :) [18:43:58] bearND: since our testing infrastructure is going to be on VMs, and then we'll have to run a VM in a VM [18:44:55] dbrant: bearND cool. I can help with the toollabs side of stuff (that's where I'm moving to in a few months :)). I've also done a lot of similar stuff with git, so this should take less than half the time of the previous approach [18:48:57] YuviPanda: are we not doing the builds right when one submits a patch because of capacity concerns? [18:49:08] bearND: no, mostly because of complexity concerns. [18:49:33] bearND: also, the only way to install android sdk is a direct download from google. Direct downloads from the internet on the cluster are pretty much non-allowed, so we'd have to find another solution for that [18:49:49] bearND: toollabs is not considered 'cluster', so it is ok there [18:50:47] YuviPanda: ok, that explains why you prefer toollabs. I still don't under stand the complexity concern [18:51:51] bearND: 1. puppet, 2. the android sdk download problem, 3. only ops have +2 on the puppet repo, and they're usually rather busy, so review takes time, 4. jenkins! (complexity penalty) 5. getting things out of jenkins to a place that's publicly visible [18:52:06] 3MobileFrontend / 3General/Unknown: beta labs Special:Uploads page throwing 503 from varnish - 10https://bugzilla.wikimedia.org/68756#c4 (10Antoine "hashar" Musso) Yet another fatal error that is not going to land in production! [18:52:34] bearND: YuviPanda: so, regarding building releases, tell me if I've got the right idea of how we'll move forward: [18:52:50] (1) When we're ready to do a Beta release, we make a commit that bumps the versionCode, and merge it. (2) From that commit, we create a tag. (3) Based on that tag, we'll have scripts that will generate either (i) a Beta apk, (ii) a production apk, or (iii) apks for other app stores. The scripts will modify the versionName only, but the versionCode will remain the same. [18:54:31] dbrant: sounds accurate to me, except that whenever we do a production APK or apk for other appstore, we'll do the version-name-changing in a new commit, put that in a branch with the same name as the tag, and then tag that as wlel [18:54:45] dbrant: so if we have 2.0-r-2014-09-91, there will be a tag and a branch with that name [18:55:33] dbrant: YuviPanda: yeah, tag for each official build (one for beta, one for production, etc.) [19:00:02] YuviPanda: when i asked about complexity concern i was wondering why no doing real ci builds, like when a patch gets pushed to gerrit (vs. every 30 min. check). Gerrit could kick off a build right away instead of having to wait for up to e 30 min. [19:00:41] bearND: gerrit is in prod as well. jenkins (+ zuul) is the thing we use to kick off builds, and that's in prod too [19:00:44] (prod = production cluster0 [19:00:51] bearND: no post-merge actions in gerrit [19:02:58] MaxSem i think it's fine - don't sweat it [19:04:27] nice Maryana - should we break out any of the broken graph issues for the next iteration, or just hold off til later? [19:04:52] awjr: looks like someone filed a separate uploads bug, which is probably the most high priority graphs issue [19:04:59] so let's just do that one next sprint [19:05:05] sounds perfect Maryana [19:05:40] bearND: so there are no capacity concerns, only complexity ones [19:10:03] dbrant: bearND if we agree on this, I can rejig the cards on sprint 38 to reflect [19:11:55] jdlrobson: I wouldn't be surprised if there isn't much of an improvement on mobile web for lazy loading. http page caching performance on varnish would probably be better than action=mobileview caching, plus connection overhead [19:11:59] jgonera kaldari any new VE stuff or experimentation stuff to show off? [19:12:14] YuviPanda: but you're still reloading an entire page [19:12:14] awjr, we can show off new bugs ;) [19:12:26] :p [19:12:39] for comparison check out the calculations i did about a year ago https://docs.google.com/spreadsheet/ccc?key=0ArbzKvV50qF6dEFzR0pCbUxfVy1ybGVPZU9yRTU0OUE#gid=0 [19:13:02] jdlrobson: also if you're logged in, action=mobileview doesn't really hit the cache, maybe that's also a consideration? [19:13:27] YuviPanda: definitely. My main concern was around the method to reach that conclusion. [19:13:36] i was expecting a larger summary from kaldari :) [19:13:47] jdlrobson: oh yeah, that :) I was just putting forward other alternatives :) [19:17:26] YuviPanda: Don't we track device install ID in the edit schema? [19:17:59] Deskana: no, we don't. It was an explicit decision made at that time with good reason but... uh... I don't remember the reason X.X [19:18:08] Well that sucks. [19:18:26] Deskana: I know, it was something something privacy. [19:18:59] Deskana: this happened at wikimania with halfak, so didn't leave a written record. sorry :| I'll try to track that down [19:20:17] dr0ptp4kt: I'm CRing your patch now [19:20:45] dbrant: Does that patch you just submitted successfully get the search/nav bar interaction working? [19:20:52] (03PS8) 10Yuvipanda: Show number of matches when finding in page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147761 (owner: 10Alex Monk) [19:21:24] Deskana: I believe so! Are you able to try it? [19:21:38] dbrant: Weird. I wonder what I was doing wrong... [19:21:56] dbrant: Let me pull the patch and test it. [19:22:39] (03CR) 10Yuvipanda: [C: 032] Show number of matches when finding in page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147761 (owner: 10Alex Monk) [19:23:37] (03Merged) 10jenkins-bot: Show number of matches when finding in page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/147761 (owner: 10Alex Monk) [19:23:59] Krenair: ty for the patch :) sorry it took a while to get merged [19:24:35] (03CR) 10Yuvipanda: [C: 04-1] "Needs manual rebas" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149786 (https://bugzilla.wikimedia.org/68682) (owner: 10Deskana) [19:25:10] 3MobileFrontend / 3stable: No placeholders on account creation or login forms in Opera Mini - 10https://bugzilla.wikimedia.org/68758 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Navigate to Login on Opera Mini browser – you'll see two blank fields that don't indicate where to enter your usern... [19:25:33] dbrant: That didn't work on my tablet... [19:25:38] 3MobileFrontend / 3stable: No placeholders on account creation or login forms in Opera Mini - 10https://bugzilla.wikimedia.org/68758#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/jt1O10K2 [19:25:58] Deskana: poppycock. [19:26:20] YuviPanda, It's been like 9 days. [19:26:33] YuviPanda, some of my Gerrit changes have been there for 2 years [19:26:40] Krenair: heh :) [19:26:51] dbrant: Wait... [19:27:04] dbrant: Oh, it did. There was just a delay. [19:27:18] dbrant: A long enough delay that I put my tablet down thinking it hadn't worked, mind... [19:27:29] Deskana: hmm, curious [19:27:31] dbrant: Although now I test it, it's not that bad. [19:28:22] Ahh, I see. [19:28:27] (03CR) 10Yuvipanda: [C: 04-1] Improve compatibility of convert-icons script. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/146976 (owner: 10Dbrant) [19:28:46] Deskana: dbrant that patch also needs a manual rebase now :( [19:29:00] YuviPanda: Explain like I'm 5. Rebase. [19:29:44] Deskana: some of the lines you changed in your patch were also changed in Krenair's patch, which I just merged. git doesn't know which line to keep if I were to merge yours, so you have to manually tell it [19:30:14] YuviPanda: So you pull master, then do some voodoo to merge what you want and throw what you don't, then resubmit it? [19:30:49] Deskana: 'git fetch gerrit', 'git rebase -i gerrit/master', 'it tells you what is the conflict, you merge it', 'git rebase --continue', 'resubmit' [19:31:06] (03CR) 10Deskana: [C: 031] "Once this is rebased it looks good to go, but as I submitted the first patch I'd rather not +1 it myself." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149786 (https://bugzilla.wikimedia.org/68682) (owner: 10Deskana) [19:31:21] Deskana: it tells you what is the conflict by essentially putting both the conflicting lines between >>>>> <<<<<<< markers in the files that were changed. you can do a 'git diff' to see them [19:31:26] (03CR) 10Deskana: "And by "rather not +1 it" I meant "rather not +2 it". :-)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149786 (https://bugzilla.wikimedia.org/68682) (owner: 10Deskana) [19:31:41] Deskana: I can do it if you want, but this should be a trivial rebase, so good to do it with this than with a gnarly one :) [19:32:08] YuviPanda: I don't have time to do that right now. Too much other stuff. [19:32:20] Deskana: mind if I do it for you, or should I let it be so you can practice later? [19:32:26] YuviPanda: You can go for it. [19:32:29] Deskana: cool [19:32:31] YuviPanda: I'll have other opportunities later. [19:32:37] Deskana: indeed. [19:32:43] YuviPanda: I had to decline some meetings so that I only have a "manageable" six hours of meetings. [19:32:54] Deskana: heh, use a time turner? :) [19:33:14] Deskana: good luck, and hopefully the load reduces after a few months [19:37:27] brion: drop your share so that we can see you [19:37:59] https://gerrit.wikimedia.org/r/#/c/145756/ [19:45:11] fooooood! [19:45:18] OM NOM NOM [19:48:35] Deskana: can't nail down the reason, unfortunately. we can add it back easily, but would like someone to ping analytics about it first (and check privacy implications) [19:53:03] YuviPanda: why is scratch app not localized ? [19:53:16] matanya: 'scratch app'? [19:53:42] releases.wm.o mobile/android/wikipedia/scratch [19:54:57] matanya: oh, those should probably be removed. were just one off builds [19:56:12] matanya: we use those pretty much internally, for testing / signing-off on features. [19:56:58] YuviPanda: It's not a priority right now. [19:57:05] Deskana: ok [19:57:06] 3MobileFrontend / 3stable: No placeholders on account creation or login forms in Opera Mini - 10https://bugzilla.wikimedia.org/68758#c2 (10Ryan Kaldari) This is because Opera Mini is the only browser that doesn't support the 'placeholder' attribute. Should we build a fallback just for Opera Mini? [20:00:57] thanks YuviPanda [20:01:09] dr0ptp4kt, hi, have you had a chance to look at https://gerrit.wikimedia.org/r/#/c/149296/ ? if not, i want to make another logging case there, if you are about to commit, i will make a separate patch [20:04:38] 3MobileFrontend / 3Feature requests: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039#c6 (10Killiondude) 5RESO/WON>3REOP What? There are multiple things wrong with the Android Wikipedia web platform involving "contributions" pages. 1)... [20:05:19] I can post screencaps in a moment. [20:05:26] (03PS1) 10Dbrant: [WIP] Implement full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 [20:06:38] grr. I hate that we can't edit comments on bugzilla. [20:06:49] dbrant: \o/ [20:11:21] 3MobileFrontend / 3Feature requests: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039#c7 (10Killiondude) Here are some screencaps for the above cases. 1) http://imgur.com/00lkkAz 2) (I meant to say Special:Contributions/Killiondude) in #c6... [20:25:29] YuviPanda: were you going to rebase Deskana's patch? Or shall I? (it's pretty trivial) [20:30:41] dbrant: oh yeah, rebased it already. moment [20:31:17] kaldari & Maryana, do we need to swat anything today? [20:31:36] (upload restrictions and fatal come into mind) [20:31:48] yurikR: feel free to make changes, and then add me and lemme know if you need a review [20:31:49] (03PS4) 10Yuvipanda: Add showSoftKeyboard method to Utils, and use it where necessary. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149786 (https://bugzilla.wikimedia.org/68682) (owner: 10Deskana) [20:32:59] (03CR) 10Yuvipanda: [C: 032] Add showSoftKeyboard method to Utils, and use it where necessary. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149786 (https://bugzilla.wikimedia.org/68682) (owner: 10Deskana) [20:33:18] dbrant: :) can you look at bearND'd show issues patch? [20:33:33] YuviPanda: yep! [20:33:38] \o/ cool [20:34:24] (03Merged) 10jenkins-bot: Add showSoftKeyboard method to Utils, and use it where necessary. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149786 (https://bugzilla.wikimedia.org/68682) (owner: 10Deskana) [20:34:37] dbrant: YuviPanda: about to send another amended patch set [20:34:44] cool [20:35:45] YuviPanda: dbrant: what's the best way to refactor the css rule for the issues button (I have one for light and one for dark mode, most attributes are the same except the backgroundimage/color) [20:36:07] bearND: so the night mode colors are applied *on top of* the regular ones. [20:36:15] bearND: so just specify the different one in both and leave the others in the base one [20:36:23] bearND: night.less is just overrides [20:36:49] YuviPanda: ok, ty, will do that in my patch [20:38:25] dbrant: some of the css rules in night.less have comments like "Same specificity as in less/content/hacks.less". I don't have a less/content folder [20:38:37] bearND: that's from MobileFrontend :) [20:38:41] bearND: we're reusing most of their styles [20:38:56] YuviPanda: ah , i see [20:39:25] bearND: essentially, whatever rule the rule in night mode is replacing should have the same specificity [20:39:46] YuviPanda: dbrant: https://gerrit.wikimedia.org/r/148866  [20:39:54] cool :) [20:40:08] 3Wikipedia App / 3iOS App: [iOS] Can't deselect text. - 10https://bugzilla.wikimedia.org/68681 (10Dan Garry) 5UNCO>3NEW [20:40:21] MaxSem kaldari - hmm, florian's patch for upload threshold? is that ready to go? [20:40:26] for swatting [20:40:54] yes [20:40:57] it's merged [20:41:21] should we SWAT deploy it? [20:42:07] 3Wikipedia App / 3iOS App: [iOS] Rotating device midway through a section will return you to the top of that section - 10https://bugzilla.wikimedia.org/68683 (10Dan Garry) 5UNCO>3NEW [20:42:17] Maryana, MaxSem: We also should probably swat deploy the fix for mobile banners so fundrasiing can start testing again on mobile [20:42:25] as well [20:42:36] swat all the things! [20:42:51] note that I [20:43:02] m not sure if i'll be back by then [20:43:28] noted [20:44:03] (03PS5) 10BearND: Show page issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148506 [20:44:10] 3Wikipedia App / 3iOS App: [iOS] Scrolling "dead" area - 10https://bugzilla.wikimedia.org/68685 (10Dan Garry) 5UNCO>3NEW [20:44:17] (03PS6) 10BearND: Show page issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148506 [20:45:04] dbrant: YuviPanda: since I need to grab the css from my local mw install i still have the localhost url for the new flag images [20:45:30] bearND: yeah, that's fine. those URLs are never actually used anywhere in webkit (they're generated by mw as fallback for IE) [20:45:33] dbrant: YuviPanda: other than that the patches are ready for review [20:45:46] nice!! [20:47:00] cool :) [20:47:07] 3Wikipedia App / 3iOS App: [iOS] Scrolling "dead" area - 10https://bugzilla.wikimedia.org/68685#c1 (10Monte Hurd) Known issue. Has to do with the fail-over relationship between the horizonal (toc) gesture recognizer and the vertical (web view) recognizer. I think we can tune these better to help with this is... [20:47:36] (03PS7) 10Dr0ptp4kt: Support multichannel builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 [20:47:49] YuviPanda: i added some utility modes ^ [20:48:04] dr0ptp4kt: ah, cool! let me look [20:48:27] (03CR) 10jenkins-bot: [V: 04-1] Support multichannel builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 (owner: 10Dr0ptp4kt) [20:48:41] YuviPanda: style check gripe i bet [20:48:47] dr0ptp4kt: heh, yeah, pyflakes [20:48:50] pep8! [20:48:55] except for the stupid 80col rule! [20:49:07] 3Wikipedia App / 3iOS App: [iOS] Scrolling "dead" area - 10https://bugzilla.wikimedia.org/68685#c2 (10Monte Hurd) Good catch though! :) [20:52:49] YuviPanda: it's whining about the previous commit. should i just get the latest master and rebase unto that? [20:52:56] YuviPanda: dbrant: Deskana: added a new card https://trello.com/c/HZjqc3gS/63-android-make-page-issues-button-show-up-on-enwiki-only [20:52:57] dr0ptp4kt: yeah, that sounds reasonable [20:53:05] YuviPanda: ok, i'll try that [20:53:24] (03PS8) 10Dr0ptp4kt: Support multichannel builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 [20:53:45] (03CR) 10jenkins-bot: [V: 04-1] Support multichannel builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 (owner: 10Dr0ptp4kt) [20:56:17] (03PS9) 10Dr0ptp4kt: Support multichannel builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 [20:56:33] (03CR) 10Yuvipanda: Support multichannel builds. (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 (owner: 10Dr0ptp4kt) [20:57:09] mhurd: hello [20:57:15] vbamba: heya! [20:57:16] YuviPanda: updated [20:57:45] I have a resolution for reference link color. Can we chat it over? I expect to eat into 5 minutes of your afternoon. [20:57:57] vbamba: ya! [20:58:42] dr0ptp4kt: cool :) I think I commented just as you were fixing :) [20:58:47] dr0ptp4kt: I'll test and merge now [20:59:00] YuviPanda: okay, cool. thanks. [21:03:52] YuviPanda: gah, i messed something up. hang on [21:04:04] :D [21:04:06] dr0ptp4kt: ok [21:04:44] brion, mhurd: I have a list of people for you to send invites for the app to. [21:04:55] Deskana: cool! [21:05:28] (03PS10) 10Dr0ptp4kt: Support multichannel builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 [21:05:34] YuviPanda: there [21:05:53] dr0ptp4kt: :D ok [21:06:00] Deskana: lets chat when u have a minute [21:06:36] mhurd: I'm fully booked until 6pm. But I'm only a passive participant in this meeting, so I could chat over IRC now. [21:08:26] Deskana: so i think we should cut new beta and send them invite to that even though it won’t be in the wild until ~2 days after first cut goes live. the reason is, why give them something to review that has known problems which will be solved 2 days after first release? bad press will live on far longer than those 2 days. [21:09:07] mhurd: I see your point but I think it's more important for us to send the correct build, otherwise we run the risk of "Why did they send us a different one from the one that's live on the day?" [21:09:17] They're writing about the app that goes live, not the bug fix build [21:09:22] YuviPanda: oh man. one more. hang on again. sorry [21:09:29] dr0ptp4kt: :D it's ok [21:10:02] Deskana: i still say it’s a bad idea [21:10:31] mhurd: Well, let's think about what's in the bug fix build that isn't in the actual release. [21:10:41] mhurd: What does that list look like? [21:12:17] (03PS11) 10Dr0ptp4kt: Support multichannel builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 [21:12:34] YuviPanda: alright, i believe that does it. that said, want to hop on google hangouts for a little bit? [21:13:18] dr0ptp4kt: oh, sure [21:13:24] dr0ptp4kt: gimme a min, finding my headphones [21:13:36] YuviPanda: ready when you are [21:13:44] dr0ptp4kt: :D [21:13:48] dr0ptp4kt: yeah, now is good [21:13:48] mhurd: I'm not certain what the difference between the builds is. [21:17:02] http://etherpad.wikimedia.org/p/MobileWeb_Iteration_name [21:17:06] kaity ^ [21:22:19] mhurd: We need to resolve this fairly quickly though because we need to send the builds ASAP. :) [21:22:26] *send the beta invites [21:23:04] Deskana: sry was reviewing refs styling w vibha [21:23:12] mhurd: It's okay. :) [21:23:52] (03PS4) 10Yurik: Logging opera-detection cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/149296 [21:24:09] so Maryana i'm running my own little test and with lazy loading from save finishing to page reloading i'm getting very significantly different results to kaldari.. [21:24:22] 3162ms without using JavaScript [21:24:26] 626ms with JavaScript [21:24:35] that's on a small page [21:24:47] mhurd: This finished early so I can come and chat. [21:26:46] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/149296 when you have time. I won't do a depl this week due to mobile's depl of the new extension, as i supsect i might break things. So riding the chu chu train [21:27:45] (03PS12) 10Dr0ptp4kt: Support multichannel builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 [21:30:03] jdlrobson: we decided that jgonera is going to settle this dispute :) [21:30:12] he'll sync up with you in the next couple of days [21:33:00] (03PS1) 10Jdlrobson: DONOTMERGE: Instrumentation demonstrating benefits of lazy loading in editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150044 [21:33:02] Maryana: okay. i'm glad you are not making a rushed decision :) [21:38:40] 3MobileFrontend / 3General/Unknown: Use GPS location to deliver locally relevant messages about copyright (for people uploading pictures) - 10https://bugzilla.wikimedia.org/68770 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None User:NotASpy made a suggestion about two-thirds of the way through this... [21:40:37] 3MobileFrontend / 3General/Unknown: Use GPS location to deliver locally relevant messages about copyright (for people uploading pictures) - 10https://bugzilla.wikimedia.org/68770#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/mdUSvjce [21:40:57] YuviPanda: got a question about transformer.register() calls in our JS code. In https://gerrit.wikimedia.org/r/#/c/148506/6/www/js/issues.js I've added one but it only seems to be invoked for the first section. [21:41:12] is there some background about that you could give? [21:41:28] * YuviPanda looks [21:43:04] bearND: you're calling it from displayLeadSection, which is invoked only for the first section [21:43:23] YuviPanda: doh [21:43:32] bearND: :D [21:44:59] YuviPanda: vbamba: hmm, need to rethink that one a bit. I just found some articles that have issues marker in a later section. should there be multiple issues buttons then? [21:48:40] Deskana: done! [21:48:59] bearND: ask Deskana as well. personally, I'd be ok with just doing this on the first section [21:49:42] The scope of this is page-level stuff. [21:50:08] Let's not worry about the section-level stuff yet. [21:50:57] Deskana: was looking at https://es.wikipedia.org/wiki/S%C3%A3o_Paulo. There the issues is in the Historia section. Are you saying that in that case you don't want an issues button? [21:51:21] For now, yes. [21:51:34] Deskana: ok, works for me ;) [21:51:48] YuviPanda: i'm done with my meeting in case of any further questions [21:52:03] dr0ptp4kt: nah, 'tis fine. am testing things around now [21:54:29] (03PS7) 10BearND: Show page issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148506 [21:54:39] dbrant|bbl: ^ minor formatting change [21:55:06] still getting used to adding spaces inside parentheses in JS code [21:55:43] 3MobileFrontend / 3stable: Limn statistics are wrong for mobile/web uploads - 10https://bugzilla.wikimedia.org/68755#c2 (10Lupo) (In reply to Lupo from comment #0) > http://mobile-reportcard.wmflabs.org/#uploads_daily-graphs-tab Sorry, I meant http://mobile-reportcard.wmflabs.org/graphs/successful-uploads... [21:57:33] (03PS2) 10JGonera: Let VE know if we are running on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148888 [21:57:43] kaldari, check this when you have a moment ^ [21:57:58] ok [21:58:55] kaldari, related new patch to VE is https://gerrit.wikimedia.org/r/#/c/150052/ [22:03:12] 3MobileFrontend / 3Feature requests: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039#c8 (10Jon) Both are case sensitive. Your contributions page works fine for me https://en.m.wikipedia.org/wiki/Special:Contributions/Killiondude What you se... [22:07:15] James_F: Can you give me 15 minutes? [22:08:53] Deskana: For you, 20! [22:09:48] Deskana: oh i got the long doi reference urls to wrap neatly! [22:09:55] mhurd: Yay! [22:10:04] Deskana: couple css lines and boom! nice wrapping. [22:13:38] 3MobileFrontend / 3Feature requests: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039#c9 (10Killiondude) (In reply to Jon from comment #8) > Both are case sensitive. I just tested and you are correct. However, scenarios 1 and 3 from comment... [22:22:48] mhurd: where is the patch for that. maybe we could use that in Android as well? What's the doi reference? [22:23:05] bearND: ah just a sec... [22:23:40] bearND: i used: “-webkit-hyphens: auto;” and “word-break: break-word;” [22:23:55] 3MobileFrontend / 3Feature requests: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039#c10 (10Jon) scenario 3 should be a separate bug and easy to fix. scenario 1 is consistent with what the original bug report asks for but as mentioned above... [22:23:56] bearND: let me know if those work! [22:24:21] mhurd: first I need to repro: which page has the issue [22:24:26] ? [22:24:33] bearND: to see a doi and reproduce go to... [22:24:54] bearND: tyrannosaurus article [22:25:06] and “description” section [22:25:26] bearND: ref [11] [22:25:58] bearND: [5][13][14][15] [22:26:29] mhurd: hmm, on Android it already seems to wrap [22:26:39] bearND: dan says doi is like a universal locator id for papers [22:26:45] bearND: nice! :) [22:27:04] all good then. Thaks for sharing. HAd no idea what a doi was [22:27:10] kaldari, when you wrote coding tasks, on which wiki did you publish them? [22:27:11] doi? d’oh! [22:27:19] lol [22:27:29] bearND: on ios when i’d try to swipe side to side the overflow from these urls was making it clunky [22:27:40] mhurd: bearND yeah, mobilefrontend itself has word-break: break-word; set, so theoretically it should've 'just worked' on iOS too [22:27:43] bearND: me neither [22:27:57] hey brion: do you remember how you reproduced the issue that dbrant|bbl tried to fix in https://gerrit.wikimedia.org/r/#/c/149883/1/www/js/actions.js? [22:28:12] jgonera: mediawiki.org [22:28:23] bearND: on iOS it was any reference that contained links, thus had “ in its html [22:28:27] YuviPanda: ah, that may explain it! i was styling references separately. lemme switch over [22:28:34] might be a different detail here though, your bridge is different system [22:28:52] kaldari, can you give me an example url? [22:28:59] mhurd: :D yeah, that'd explain it [22:29:07] afaik the prompt() system should not be mucking up characters, but it’s possible it’s doing something odd too [22:29:08] brion: ah, thanks :) [22:29:15] might try a similar extra encoding on the bridge and see if it helps [22:31:10] brion: our main blocker for this fix was actually that we couldn't repro it. all the examples from the OTRS reports are in Japanese, and while it shows the text is referenced I don't know from what page that reference was from. Then going to find the pages that link to there, … needle in a haystacky [22:31:27] Maryana you may have done this already, but just wanted to poke in case it fell off your radar - can you verify the priority order of stuff in ready for dev on the new iteration wall? [22:32:38] yeah, i couldn’t repro the bug on my nexus 5 even switched to japanese [22:32:51] but i do notice that the two examples given had links in their texts so i’m suspicious [22:33:13] (03PS2) 10Kaldari: Instrumentation to test benefits of lazy loading in editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150044 (owner: 10Jdlrobson) [22:33:28] awjr: thanks for the reminder :) done now [22:33:41] :D [22:37:39] kaldari, I asked because I'm wondering where I could put the task review guidelines that jdlrobson, Roan, Bryan and I came up with [22:38:28] jgonera: if you want them to be non-publicly accessible, you can put them on officewiki [22:38:56] kaldari, that's a good point, I probably don't want them to be viewable by candidates [22:39:01] hm [22:39:47] bearND: there's a tool called mwsearch that can search for things like this, but needs cluster access to run. [22:39:50] * YuviPanda pokes Reedy [22:39:58] Reedy: can you run an mwgrep on jawiki for bearND? [22:40:11] What am I looking for? [22:40:13] mwgrep, not mwsearch, sorry [22:40:17] bearND: can you give Reedy the string? [22:42:07] YuviPanda: Reedy: we've got multiple reports with different strings. but here's the first one: [22:42:08] "United Nations (2006年4月4日). “ href=\"http://unstats.un.org/unsd/geoinfo/UNGEGN/docs/23-gegn/wp/gegn23wp61.pdf\">United [22:42:09] Nations, Historical, Geographical and Legal Validity of the Name: PERSIAN GULF（英語）”. [22:42:09] 2011年4月21日閲覧。"}} [22:42:33] Reedy: I guess mwgrepping for that link should work? [22:44:10] Reedy: here's another one: [22:44:11] "当時、押井守監督が溺愛していた雌のバセットハウンド・ガブリエルにちなんだもの。原作1巻では、ガブリエルの女性名であるガブリエラと名づけられた留守番装置が登場�� [22:44:33] oh wow, that looks so corrupt [22:45:14] disclaimer: not sure what this mean what i just posted. I hope it's nothing offensive [22:45:22] means [22:45:33] bearND: heh, the title='' just looks like corrupt unicode to me [22:45:52] YuviPanda: mwgrep doesn't seem to have a wiki parameter... [22:45:52] bearND: oh wow :) [22:45:55] 3MobileFrontend / 3General/Unknown: Use GPS location to deliver locally relevant messages about copyright (for people uploading pictures) - 10https://bugzilla.wikimedia.org/68770#c2 (10Ryan Kaldari) That sounds like a great idea, but quite ambitious. Keeping the software up to date with what to show where wo... [22:46:03] YuviPanda: yeah, the yen like symbol before the " seems to mess things up [22:46:17] Reedy: ow, so we can't search just a wiki? that sounds... lame. [22:46:20] and kinda pointless? [22:46:26] Reedy: wanna run it anyway? :D [22:46:40] I think it was said before as it gives the same result as searching normally [22:46:57] Reedy: oh? :| [22:47:29] Also, it's for NS_MEDIAWIKI/NS_USER/NS_MODULE [22:47:38] oh, bah [22:47:41] then nevermind [22:47:46] just use normal CirrusSearch onwiki [22:52:32] (03PS1) 10Kaldari: Add Uploadrestriction using edit count [extensions/MobileFrontend] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150075 (https://bugzilla.wikimedia.org/62598) [22:52:47] (03PS1) 10Kaldari: Fixing fatal error on Special:Uploads for mobile [extensions/MobileFrontend] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150076 (https://bugzilla.wikimedia.org/68756) [22:53:19] (03CR) 10Kaldari: [C: 032] Add Uploadrestriction using edit count [extensions/MobileFrontend] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150075 (https://bugzilla.wikimedia.org/62598) (owner: 10Kaldari) [22:53:26] 3MobileFrontend / 3stable: IP link in diff shouldn't take you to IP's user page - 10https://bugzilla.wikimedia.org/68775 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None From the watchlist or history, visit the diff of a change made by an IP editor – when you click on the IP, you're taken to the... [22:53:50] (03Merged) 10jenkins-bot: Add Uploadrestriction using edit count [extensions/MobileFrontend] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150075 (https://bugzilla.wikimedia.org/62598) (owner: 10Kaldari) [22:54:11] (03CR) 10Kaldari: [C: 032] Fixing fatal error on Special:Uploads for mobile [extensions/MobileFrontend] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150076 (https://bugzilla.wikimedia.org/68756) (owner: 10Kaldari) [22:55:33] (03Merged) 10jenkins-bot: Fixing fatal error on Special:Uploads for mobile [extensions/MobileFrontend] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150076 (https://bugzilla.wikimedia.org/68756) (owner: 10Kaldari) [22:55:42] 3MobileFrontend / 3stable: IP link in diff shouldn't take you to IP's user page - 10https://bugzilla.wikimedia.org/68775#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/dSh05fJJ [22:55:49] dr0ptp4kt: got distracted by a couple of other things, I'll merge your patch tomorrow? sorry! [22:56:37] YuviPanda: sounds good. thanks. have a good day's sleep :) [22:56:54] dr0ptp4kt: :D will do [22:57:54] YuviPanda: what dr0ptp4kt said ;) [22:58:05] :D [23:01:33] bearND: Deskana Agree, that we only want a button for the page level stuff for now [23:02:56] vbamba: ok. I don't think it would be too difficult to implement page issues in other sections, too I agree with you here, and also don't want to drag this out [23:04:53] Deskana: Regarding the label + flag or just flag, I want to wait till bearND & dbrant|bbl finish the diambiguaton stuff and then examine the two controls togethr [23:05:54] Deskana: More hollistic that way, adding a label is not going to be a lot of work [23:06:05] vbamba: Sure. [23:06:31] kaity: VE meeting? [23:06:55] oops on my way [23:07:00] np :) [23:08:46] (03PS1) 10Kaldari: Fixing merge conflict bettween 2 cherry-picks for wmf15 [extensions/MobileFrontend] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150077 [23:10:53] (03PS2) 10Kaldari: Fixing merge conflict bettween 2 cherry-picks for wmf15 [extensions/MobileFrontend] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150077 [23:11:17] (03CR) 10Hoo man: "This is lying around for almost week now, although it's *really* simple... :S" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [23:11:25] (03PS3) 10Kaldari: Fixing merge conflict between 2 cherry-picks for wmf15 [extensions/MobileFrontend] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150077 [23:11:40] (03CR) 10Kaldari: [C: 032] Fixing merge conflict between 2 cherry-picks for wmf15 [extensions/MobileFrontend] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150077 (owner: 10Kaldari) [23:12:11] (03Merged) 10jenkins-bot: Fixing merge conflict between 2 cherry-picks for wmf15 [extensions/MobileFrontend] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150077 (owner: 10Kaldari) [23:20:19] violetto: yo #wikimedia-growth [23:21:57] Sup jdlrobson [23:22:09] violetto: need your thoughts on mw-ui-input [23:22:14] violetto: are you in office? [23:22:37] jdlrobson: won't be in until weds [23:22:44] The reply fields? [23:29:06] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c136 (10Ryan Kaldari) @Florian: Actually, Maryana asked me to go ahead and deploy it to wmf15 so it should be live on the Wikipedias on July 31. We'll also have to deploy a config update sometime bet... [23:36:52] mhurd: What time will you be leaving today? [23:37:07] vbamba: 6ish? [23:41:26] ok, Can we do ref's at 5:20? Ill come over to your desk [23:42:04] vbamba: ya! [23:52:41] (03PS1) 10Dr0ptp4kt: Update app description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 [23:59:37] 3Wikipedia App / 3Android App: JSONException: Unterminated object - 10https://bugzilla.wikimedia.org/68656#c3 (10Bernd Sitzmann) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=7695568 Unterminated object at > character 55 of {"type":"referenceClicked","payload":{"ref":"