[00:01:00] bearND: mind reviewing and approving https://gerrit.wikimedia.org/r/150088 for twn niceness? also, is it right that strings.xml for english should be updated via the repo, or do you want for that to be done via some other means? i cleared these additions with Deskana in this change. silly question: where's the what's new stuff located? [00:04:40] (03CR) 10BearND: "see inline comment" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 (owner: 10Dr0ptp4kt) [00:05:32] dr0ptp4kt: ^ looks good from a twn perspective I think. Just minor comment. I think Deskana should approve this since this is going to end up in the store description [00:06:31] dr0ptp4kt: how does a pull request work with our gerrit setup? [00:20:06] (03CR) 10Dr0ptp4kt: "Updating shortly." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 (owner: 10Dr0ptp4kt) [00:21:31] Deskana, would you pleae review the verbiage changes in https://gerrit.wikimedia.org/r/#/c/150088 ? bearND was hoping you could approve. bearND: i believe yuvi was updating the bot for pull requests per http://lists.wikimedia.org/pipermail/wikitech-l/2014-July/077545.html, but maybe we should check on that. [00:21:38] bearND: i'll email yuvi [00:23:44] (03PS2) 10Dr0ptp4kt: Update app description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 [00:24:02] (03CR) 10Jforrester: [C: 032] "Moving de-registration from MW-core to here." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149780 (owner: 10Bartosz Dziewoński) [00:24:37] (03Merged) 10jenkins-bot: Use $wgResourceModuleSkinStyles for Minerva's core style overrides [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149780 (owner: 10Bartosz Dziewoński) [00:28:05] bearND: oh right, the what's new stuff happens when uploading the document. awesome it looks like https://support.google.com/googleplay/android-developer/answer/189724 will even autotranslate the what's new stuff! [00:28:11] s/document/apk/ [00:33:32] Maryana: where'd you go? [00:33:59] meeting :) [00:35:00] Maryana: Quick question. For https://trello.com/c/dX5ZgT5Y/6-1-promote-left-nav-edit-guider-to-stable should I leave the A/B test or tend the test and just have it always work? [00:35:11] tend=end [00:35:41] leave it & let's collect a week or two of data, plz [00:36:20] Maryana: well, funny enough it seems to already be promoted to stable. So we should have a shitload of data [00:36:41] wuut [00:36:48] let's talk after i get out of this [00:36:51] round 6ish [00:37:58] Maryana: 10-4 [00:53:21] (03CR) 10Kaldari: [C: 04-1] Show talk button only when JS enabled or talk page not empty (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145411 (https://bugzilla.wikimedia.org/67819) (owner: 10Florianschmidtwelzow) [00:56:09] 3MobileFrontend / 3stable: No placeholders on account creation or login forms in Opera Mini - 10https://bugzilla.wikimedia.org/68758#c3 (10Jon) There was a bug about placeholder support in opera mini for search overlay that got won't fixed. Good reasons in that bug where ever it might be about why we shouldn... [01:07:26] kaldari: looking more like 6:15, sorry.. :-/ [01:08:05] :( [01:11:34] we could chat tomorrow if you wanna split.. don't wanna keep ya [03:23:54] (03PS1) 10MaxSem: Fix stopMobileRedirect cookie being HTTPS-only [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150126 (https://bugzilla.wikimedia.org/68347) [05:10:36] 3MobileFrontend / 3General/Unknown: beta labs Special:Uploads page throwing 503 from varnish - 10https://bugzilla.wikimedia.org/68756 (10Florian) 5PATC>3RESO/FIX [05:14:23] (03CR) 10Florianschmidtwelzow: [C: 031] "?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [05:19:11] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c137 (10Florian) 5PATC>3ASSI a:3Florian @ryan: Thanks for info! > We'll also have to deploy a config update sometime between now and then for it to actually have an effect though. Working on... [05:47:22] 3MobileFrontend / 3Feature requests: Bare Special:Contributions (without subpage) shouldn't be caught by mobile - 10https://bugzilla.wikimedia.org/65039#c11 (10Liangent) (In reply to Jon from comment #10) > scenario 1 is consistent with what the original bug report asks for but as > mentioned above it is not... [05:55:37] (03PS1) 10BearND: Bring back some translated strings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150147 [06:19:52] (03PS3) 10Florianschmidtwelzow: Show talk button only when JS enabled or talk page not empty [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145411 (https://bugzilla.wikimedia.org/67819) [06:20:10] (03CR) 10Florianschmidtwelzow: Show talk button only when JS enabled or talk page not empty (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145411 (https://bugzilla.wikimedia.org/67819) (owner: 10Florianschmidtwelzow) [06:20:15] (03PS4) 10Florianschmidtwelzow: Show talk button only when JS enabled or talk page not empty [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145411 (https://bugzilla.wikimedia.org/67819) [07:11:39] 3MobileFrontend / 3stable: IP link in diff shouldn't take you to IP's user page - 10https://bugzilla.wikimedia.org/68775 (10Florian) [07:11:39] 3MobileFrontend / 3Feature requests: On MobileDiff, anonymous user's IP address is not clickable - 10https://bugzilla.wikimedia.org/56814 (10Florian) [07:11:39] 3MobileFrontend / 3Feature requests: On MobileDiff, anonymous user's IP address is not clickable - 10https://bugzilla.wikimedia.org/56814#c9 (10Florian) 5NEW>3RESO/FIX Setting as fixed, because there is a link to anonymous users since... (yeah, don't know when, sorry). Maryana opened a new bug to fix the... [08:54:53] 3MobileFrontend / 3stable: Some Mobile/Web uploads without or with corrupted information - 10https://bugzilla.wikimedia.org/68321#c12 (10Lupo) Another approach might be to put some simple JavaScript in mobile.js on Commons to * Pre-fill the description at Special:Upload with an empty {{information}} templat... [08:58:07] 3MobileFrontend / 3stable: Limn statistics are wrong for mobile/web uploads - 10https://bugzilla.wikimedia.org/68755#c3 (10Lupo) Today, http://mobile-reportcard.wmflabs.org/graphs/successful-uploads has for July 28 2014: 62 uploads. This matches my count in the upload log, which also lists 62. A few of thes... [12:14:59] (03CR) 10TheDJ: [C: 04-1] "Actually, it is not THAT simple." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [15:11:09] 3Wikipedia App / 3Android App: Add config to set the duration time of display screen on - 10https://bugzilla.wikimedia.org/68805 (10Florian) 3NEW p:3Unprio s:3minor a:3None Comes from: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7698122; Wikipedia is like a e-book read... [16:59:22] (03CR) 10Dr0ptp4kt: [C: 032] Logging opera-detection cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/149296 (owner: 10Yurik) [16:59:34] (03Merged) 10jenkins-bot: Logging opera-detection cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/149296 (owner: 10Yurik) [17:03:12] bearND: see comment on your MobileApp patch [17:09:47] dbrant: ok, i'll use a higher res image for the flag [17:14:58] (03CR) 10Dbrant: "Excellent; just some *really* minor nits." (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148506 (owner: 10BearND) [17:26:17] dbrant: https://gerrit.wikimedia.org/r/148866  used xhdpi instead o mdpi versions of the flag [17:26:20] of [17:26:35] I mean the updated patch set [17:26:55] bearND: will try [17:27:14] dbrant: going to update the app patch as well [17:28:09] (03PS8) 10BearND: Show page issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148506 [17:28:25] dbrant: this one is just for the flag update [17:33:51] (03PS9) 10BearND: Show page issues [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148506 [17:34:06] dbrant: that one addresses your comments. Good catches! [17:34:34] bearND: great! [17:38:37] Is it intentional that the mobile search field does not support interwiki prefixes? [17:38:41] http://en.m.wikipedia.org/w/index.php?search=nl%3AZandbak&fulltext=search [17:39:30] http://i.imgur.com/8NK3GRX.png [17:39:33] @Krinkle: It's the "normal" Search: https://en.wikipedia.org/w/index.php?search=nl%3AZandbak&fulltext=search [17:39:49] so it's a topic for cirrussearch i think :) [17:40:10] FlorianSW: in the normal search, when entering it from an article (not the search results page), the first attempt is to find an article by that name. On desktop it will then go to that other wiki immediately. [17:40:30] FlorianSW: and on the link you sent it does render a link to nl.wikipedia.org [17:41:14] albeit in a confusing way, it's kind of an ancient thing that I think a fair few power users use (it's one of the new ways you can quickly to to another wiki from any wiki without tempering with the url manually which can be tedious on mobile (scroll t the front, select subdomain etc.) [17:41:17] Krinkle: You mean, when i type it into searchbar and hit enter? [17:41:21] Yep [17:41:28] ah, ok, then i misunderstand you :) [17:41:56] but also on the result page itself (on the two links we exchanged) on desktop it shows a clickable link [17:42:40] Yeah, the clickable link is removed, because it will show a non-clickable redlink if the page doesn't exist [17:42:50] (for now redlinks will be removed for performance). [17:45:03] Krinkle: The decision if you will be redirected to an existing destination page will be made after the list of proposal sites is loaded [17:45:20] if there isn't a result, you see the search result page [17:47:24] FlorianSW: I'm not sure I follow. Are you saying mobile does or does not display a clickable link? Or only a non-clickable link? Right now it doesn't display a link of any kind (what is a non-clickable link?). In what way would a red link to create the page be bad performant? And this is a blue link btw, not red link. [17:47:31] awjr, can we move the code review meeting by 15 minutes? [17:48:19] @Krinkle: The "There is a page with this name" is hidden everytime on mobile [17:48:29] that's because: [17:48:44] if there isn't a page with this name, there will be a redlink (to create this page) [17:49:16] on mobile, redlinks will be removed and replaced with only a text (what i mean withnon-clickabl :)) [17:50:43] kristenlans, can we move the code review meeting by 15 minutes? [17:51:20] Fine with me jgonera :-) [17:51:36] FlorianSW: I don't know why mobile wouldn't want to display that red link (I guess we don't want mobile users to create pages?), but one could display that header only if the page does exist and hide it otherwise. They're quite different types of content (search result, and call to action) that happen to be generated by the same code but I think it's fine to hide only one branch. [17:51:40] thanks [17:52:01] Kaldari, jdlrobson ^ [17:52:35] Krinkle: My point of knowledge is for performance :/ [17:53:02] FlorianSW: performance how? Making that sql query? The php logic to omit that html? The css to hide that section? [17:54:11] Krinkle: https://gerrit.wikimedia.org/r/#/c/126723/ i think this explain it better as i :) [17:55:39] Krinkle: somewhere was a bugreport for the search result page behavior... [17:56:07] jgonera_ to 1115? [17:56:10] FlorianSW: Right, but like I said, red links aren't relevant to that section on the search page. It's about displaying the link to the other wiki, the blue link saying "your query is a valid title, click here". Not the section "click here to create page x" [17:56:12] (03CR) 10Dbrant: [C: 032] "for great justice." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148506 (owner: 10BearND) [17:56:20] the latter could be omitted if we don't want those kind of red links. [17:56:26] bearND: dbrant w00t [17:56:28] jgonera_ if so that's fine with me :) [17:56:30] (sorry, meetings) [17:56:47] a valid title that already exists. [17:57:46] jgonera_, the meeting isn't going to happen? [17:58:25] Krinkle: (first here the bug report :) https://bugzilla.wikimedia.org/show_bug.cgi?id=68289) The problem is: The search result page comes directly from core/cirrsusearch, and the id's of a "create page" div is the same as "here is a page with this title" [18:00:56] Krinkle jgonera maxsem kaldari jdlrobosn maybe we can rethink "redlinks"? [18:01:16] jgonera moving the mtg to 1115? [18:01:16] like what? [18:01:51] I think most decisions like that depend on Maryana, FlorianSW [18:01:57] FlorianSW: If mobile is using the search result html straight as-is, we could fix core to provide a different class name. Seems sensible. Right now it uses p.mw-search-createlink for both which is wrong. [18:02:05] awjr already did [18:02:23] I figured mobile was using custom html though. [18:02:26] jgonera ok cool - i dont see it on my calendar anymore [18:02:33] .mw-search-createlink, #search { [18:02:33] display: none; [18:02:33] } [18:02:35] guess not :) [18:02:41] jgonera: is this meeting still happening? I've got a confusing calendar [18:02:41] awjr huh weird [18:02:51] Krinkle: Yes, i would prefer this change :) [18:02:54] jdlrobson it is, 11:15 [18:03:02] ahh okay, i didn't get an update for some reason [18:03:02] jgonera: Thanks :) [18:03:31] Krinkle, we don't rewrite HTML anymore [18:03:40] exxcept on main pages [18:04:09] i think krinkle mean to change the html delivery of core [18:04:26] code review mtg disappeared from calendar [18:04:50] I know, it seems Google calendar for android is crap [18:04:59] Is it back on your calendars? [18:05:44] nope [18:06:11] jgonera i know it - i have screwed up so many mtgs due to gcal on android [18:06:15] jgonera i see it there now :) [18:06:18] thanks [18:06:24] Krinkle: What do you mean: Open a bug to implement a difference to SpecialSearch or "just do it"? :) [18:09:15] (03CR) 10Krinkle: "A few things to look out for. As good practice: Be very suspicious of anything doing get html() or set html(). Almost always it is wrong. " (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126723 (owner: 10Jdlrobson) [18:09:28] dbrant: would you mind CRing this too: Add gitignore [extensions/MobileApp] - https://gerrit.wikimedia.org/r/150280 [18:09:32] FlorianSW: Either. Should be a simple patch and I'll just +2 it. [18:10:03] there's probably an if/else branch in core search right now that displays one section or the other. Simply change the class (or add a class) in one of the branches. [18:10:07] If you want to that is. [18:10:17] If you want to display the blue link in mobile, that is. [18:10:22] Krinkle: Yeah, i have the code before me ;) Just to be clear := [18:10:50] will upload it right away [18:11:38] cool [18:12:00] bearND: done [18:12:06] dbrant: ty [18:12:08] jdlrobson: When you have a minute, a few tips about .html(): https://gerrit.wikimedia.org/r/#/c/126723/1/javascripts/modules/redlinks/redlinks.js [18:12:34] bearND: but how would intellij project files get in there? [18:12:45] (03CR) 10Jdlrobson: "Yep this is a complete hack and not intended to hang around for too long. It was better than the PHP alternative though." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126723 (owner: 10Jdlrobson) [18:13:18] dbrant: because I use IntelliJ to edit the js + less files [18:13:54] ah i see [18:14:21] 3Wikipedia App / 3iOS App: [iOS] Rotating device midway through a section will return you to the top of that section - 10https://bugzilla.wikimedia.org/68683#c1 (10Brion Vibber) So this behavior is believed to be better than the default WebView behavior of sending you to some other semi-random location in th... [18:14:29] dbryou can import the extension into IntelliJ. I guess PhpStorm or WebStorm would be more appropriate if I had the license [18:14:35] (03CR) 10Krinkle: "Sure, but I'm not doubting the choice to use js here. That's fine. But I noticed you have a tendency to use html() in this way which looks" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126723 (owner: 10Jdlrobson) [18:14:37] dbrant: [18:15:36] 3Wikipedia App / 3iOS App: [iOS] Can't deselect text. - 10https://bugzilla.wikimedia.org/68681#c1 (10Brion Vibber) This is probably related to some of our funky event handlers, will take a look. [18:15:52] mtg? [18:18:22] Krinkle: https://gerrit.wikimedia.org/r/#/c/150282/1 [18:18:33] jgonera, are you starting? [18:20:23] FlorianSW: can you put the full class name in the variable for searchability? [18:20:32] Krinkle: Sure :) [18:20:41] looks good otherwise [18:20:51] Krinkle: Is there a use case i don't see ... oh, ok :D [18:21:37] that way we can grep for the class name e.g. if it's unused, or when trying to find out what the stylesheet in mobilefrontend is doing (so that mw-search-createlink actually yields a result, e.g. SpecialSearch) [18:21:49] MaxSem: jgonera: kaldari awjr kristenlans https://www.mediawiki.org/wiki/Code_review#Review_checklist [18:22:00] https://etherpad.wikimedia.org/p/MobileWeb-CodeReview-Discussion [18:22:19] Krinkle: Ah, ok, that makes sense :) [18:22:23] Alternatively, what we often do in this case if the class is dynamic, add a comment listing the differnet options. Eg. like https://gerrit.wikimedia.org/r/#/c/149856/1/modules/ve/ce/ve.ce.ResizableNode.js [18:22:36] but that seems overkill for this one :) [18:22:59] Krinkle: and changed :P [18:23:35] kaldari? [18:24:12] MaxSem are you hearing us ok? [18:24:24] crappy, but I can hear [18:25:11] MaxSem k yeah this room sucks :( [18:25:16] for remote at least [18:30:01] krinkle: thx for merge :) [18:30:07] Deskana: looks like he was able to install it :) [18:30:22] (03PS1) 10Brion VIBBER: Avoid disabling deselection of text with a tap [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/150286 (https://bugzilla.wikimedia.org/68681) [18:30:23] mhurd: Great. [18:30:49] Deskana: btw, I talked to bearND and dbrant, we found another way to get CI builds that doesn't have as much ops involvement :) [18:31:01] Deskana: so now it should be able to be done next sprint [18:31:07] Great. [18:31:37] Deskana: dbrant bearND do you guys want me to rejig the cards to follow the newer plan? [18:32:07] YuviPanda: sure! [18:32:14] dbrant: cool [18:44:25] > https://www.mediawiki.org/wiki/MobileFrontend/Coding_conventions [18:59:03] (03CR) 10BearND: Support multichannel builds. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 (owner: 10Dr0ptp4kt) [19:15:35] mhurd, brion: I was asked the question "the existing Wikipedia app, is that just an HTML 5 wrapper then?" [19:15:51] Deskana: as in a wrapper around the site? no [19:16:01] Deskana: it isn't a wrapper, it's separate from the website, but uses HTML5 [19:16:05] yep [19:16:14] brion: oh the old phonegap app? [19:17:13] Let me know if this reply is correct. [19:17:31] Erm, never mind. [19:17:31] YuviPanda: the phonegap app was, in a sense all html, though, right? [19:17:54] more or less :D [19:17:55] mhurd: yeah, but had some Objective-C and Java code [19:17:59] I'll just say no, it's not a wrapper, it was written in PhoneGap. [19:18:00] a few native plugins [19:18:07] Deskana: that sounds right yes :D [19:18:15] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 (owner: 10Dr0ptp4kt) [19:20:04] Journalists ask the most random questions... [19:20:53] (03CR) 10Dr0ptp4kt: "@Deskana, feedback on the feedback mechanism?" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 (owner: 10Dr0ptp4kt) [19:27:04] (03CR) 10Deskana: Update app description. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 (owner: 10Dr0ptp4kt) [19:28:54] mhurd, brion: o hai guise [19:28:59] mhurd, brion: Didn't see you back there! [19:29:16] haiiiii [19:30:31] (03CR) 10Siebrand: Update app description. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 (owner: 10Dr0ptp4kt) [19:33:50] Haha [19:33:57] So we used [[Atlantic puffin]] for our screenshots [19:34:03] Guess what today's featured picture is on Commons? [19:34:07] The lead image of [[Atlantic puffin]]. [19:34:27] \o/ [19:35:35] Deskana: the last time I did the screenshots, I think I used 'Serial killer', followed by 'Jimmy Wales' and similar things. I think that's why I'm no longer doing screenshots :) [19:35:49] Deskana: woooo I can see you [19:35:52] YuviPanda: At least you didn't choose [[Nazi Germany]] or something :P [19:36:00] Deskana: oh, yeah, I think that was the other one [19:36:03] YuviPanda: I'm so tempted to turn to the camera and give a creepy look. [19:36:08] Deskana: Hitler, then Serial Killer, and Jimmy Wales [19:36:29] You can see me facepalm in almost real-time! [19:36:40] Deskana: missed it, can you do it again? [19:38:28] Deskana: i think i got two, yay [19:38:49] YuviPanda: You did. :P [19:39:04] Deskana: got an ear scratch now! :) [19:42:30] YuviPanda: Deskana: the lead image on mobile for small pox traumatised me. [19:42:46] jdlrobson2: Wikipedia is not censored. :) [19:43:03] https://en.wikipedia.org/wiki/Wikipedia:CENSORED [19:43:54] jdlrobson2: Deskana yeah, we need to implement a Personal Image Filter! [19:45:17] YEAH [19:45:29] This is both new and interesting. [19:45:34] And also noncontroversial! [19:46:20] Deskana: yes, totally. You get to be PM and community liason rolled into one. [19:46:34] And my head can roll, too! [19:46:48] That's good, right? [19:47:03] Deskana: yes, totally. We should also hire the contractors who did AFTv5 to write it. [19:53:04] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 (owner: 10Dbrant) [20:01:00] (03PS1) 10Kaldari: Making sure that clicking on search doesn't trigger history.back() [extensions/MobileFrontend] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150368 (https://bugzilla.wikimedia.org/67140) [20:02:50] (03CR) 10Kaldari: [C: 032] Making sure that clicking on search doesn't trigger history.back() [extensions/MobileFrontend] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150368 (https://bugzilla.wikimedia.org/67140) (owner: 10Kaldari) [20:03:54] (03Merged) 10jenkins-bot: Making sure that clicking on search doesn't trigger history.back() [extensions/MobileFrontend] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150368 (https://bugzilla.wikimedia.org/67140) (owner: 10Kaldari) [20:37:18] dbrant: bearND Quick Question for you guys [20:37:32] vbamba: hi [20:37:35] What is the canvas vs focus area for icons in the left nav? [20:37:51] is it 32dp canvas, 24 dp focua area? [20:38:25] Deskana: and I were chatting about an icon for 'TODAY' [20:38:35] applies to android only [20:40:12] vbamba: not sure what you mean by focus area. The images are 24dpx24dp [20:42:18] vbamba: I can send you some png's if that helps [20:42:23] vbamba: generally when creating icons for Android, we don't want any padding inside the SVG itself (the image should fill up the whole canvas). We establish the padding on our side using the layout xml. [20:48:55] (03PS1) 10Dbrant: Add disambiguation button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150385 [20:49:24] bearND: YuviPanda: ^^ swoosh [20:49:38] dbrant: nice [20:49:39] dbrant: niice :) [20:51:40] bearND: But all the action bar icons do have apdding [20:51:43] padding* [20:57:36] (03CR) 10jenkins-bot: [V: 04-1] Add disambiguation button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150385 (owner: 10Dbrant) [20:57:45] :( [20:58:18] Jenkins says no. [20:59:02] that's probably javascript [20:59:07] mediawiki JS has insane spacing conventions [20:59:20] yep, looking... [20:59:25] dbrant: the good old === and !== [21:00:04] vbamba: The today icon is for the nav drawer, where we add the padding in the layout xml file, like dbrant said [21:01:52] (03PS2) 10Dbrant: Add disambiguation button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150385 [21:02:25] So I just got that asset from Vibha at the same time that I have a meeting cancelled to try it add it in to the repo. [21:02:26] Yay! [21:02:38] Deskana: yay to meetings being cancelled [21:03:06] Hmm. [21:03:18] "you are 1 commit behind" [21:03:36] It suggests creating a new branch. [21:03:42] Halp. [21:03:51] Deskana: when does it tell you that? [21:04:04] dan-garry:android-wikipedia dgarry$ git checkout today [21:04:04] Warning: you are leaving 1 commit behind, not connected to [21:04:05] any of your branches: [21:04:33] Deskana: that's ok, you can ignore that :) [21:05:54] So I'm a little bit confused what to actually do with the svg. [21:06:27] Do I have to convert it into a series of PNGs? [21:06:41] Deskana: yes, but we have a build process for that! [21:07:19] Deskana: put the svg into icon-sources/24, then run 'python scripts/convert-icons.py', and viola! you shall have pngs in the appropriate places [21:07:29] icon-svgs/24 [21:08:23] Deskana: if the python script complains about missing libraries there is a write up in the README file about that [21:08:58] dan-garry:android-wikipedia dgarry$ python scripts/convert-icons.py [21:08:58] Traceback (most recent call last): [21:08:58] File "scripts/convert-icons.py", line 2, in [21:09:00] import sh [21:09:02] ImportError: No module named sh [21:09:16] pip install sh [21:09:32] pip pip [21:10:02] YuviPanda: mind finishing the review on https://gerrit.wikimedia.org/r/#/c/149483/ ? [21:10:06] Eugh. [21:10:10] Deskana: the details are in the README.mediawiki on the root of the repo [21:10:18] Deskana: sudo pip install sh :) [21:10:26] YuviPanda: I figured that bit out. :P [21:10:27] Deskana: go to the end of it, there's a section called Updating icons from SVG [21:10:32] dr0ptp4kt: will try, but finishing up some H1B stuff right now. [21:11:45] sh.CommandNotFound: rsvg_convert [21:12:05] Deskana: 'brew install rsvg-convert' [21:12:10] assuming you use homebrew. [21:12:23] I thought I did, but apparently not. [21:12:27] Deskana: if not, http://brew.sh/ [21:12:59] This is my least favourite bit. [21:13:04] run X, but install Y first [21:13:09] To install Y run Z [21:13:12] to run Z install A [21:13:22] chop down the mightiest tree in the forest, with... a herring. [21:13:58] dan-garry:android-wikipedia dgarry$ brew install rsvg-convert [21:13:59] Error: No available formula for rsvg-convert [21:14:00] :( [21:14:04] to install A, run B [21:14:20] Deskana: ah, hmm [21:14:24] (03PS1) 10Bsitu: Only trigger 'mark as read' API if unread notification is not 0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150394 [21:14:43] try "brew install librsvg" [21:15:07] Homebrew does not package XQuartz. Installers may be found at: [21:15:07] https://xquartz.macosforge.org [21:15:14] to run B, install C [21:15:18] well that's just common sense! [21:15:27] lol [21:15:45] Deskana: really? librsvg just installs for me without XQuartza [21:16:10] Deskana: feel free to update the README.mediawiki if the steps are not already included there [21:16:31] All this for an icon. [21:16:34] REMOVE ICONS [21:17:27] Deskana: :D one of us can run rsvg-convert for you if you want. [21:17:34] Nope. [21:17:37] I want to do it. :) [21:17:51] I know I'll feel good for seeing this through. [21:17:52] Deskana: :D [21:17:54] Deskana: yeah [21:19:10] I may have to pick this up later though. [21:20:37] (03PS1) 10Kaldari: WIP: Make LeftNavEditTutorial not an A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150396 [21:22:38] It's still running that command I started all that time ago. [21:22:38] zzz [21:28:22] Deskana: he heeee :) [21:28:32] vbamba: ok ready [21:28:58] ill be there in 2 mts [21:29:41] wait - actually 5 [21:29:50] vbamba: no rush :) [21:29:52] 3MobileFrontend / 3General/Unknown: tapping on the search input in mobile frontend takes you to previous page - 10https://bugzilla.wikimedia.org/67140#c21 (10Andre Klapper) 5PATC>3RESO/FIX Backport to 1.24wmf14 merged; closing again. [21:39:20] dbrant|brb: im in shock and you can help [21:39:41] https://trello.com/c/lADtYeQl/29-as-a-user-i-d-like-the-start-of-an-article-to-be-formatted-better-so-the-articles-are-more-readable-disambiguation-styling-fix this card is ready for review? [21:39:45] that was lightning fast [22:03:40] (03PS2) 10Kaldari: Make LeftNavEditTutorial no longer an A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150396 [22:10:44] (03PS13) 10Kaldari: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) (owner: 10JGonera) [22:11:01] (03PS3) 10Kaldari: Let VE know if we are running on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148888 (owner: 10JGonera) [22:20:41] Deskana: Let me know if there were any issues with plugging the Today Icon in [22:21:14] vbamba: There were but I think they were on my end. I had to drop it for now. [22:23:01] vbamba: Katherine wanted to brief us about the interview. I said I'd be free at 4:10pm. [22:28:52] (03CR) 10Kaldari: [C: 04-1] Show talk button only when JS enabled or talk page not empty (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145411 (https://bugzilla.wikimedia.org/67819) (owner: 10Florianschmidtwelzow) [22:44:44] (03CR) 10Kaldari: [C: 04-1] Improve fixed header in overlays on iOS (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) (owner: 10JGonera) [22:45:56] Deskana: ok [22:47:20] jgonera: found lots of bugs in Android 2, but non related to your patch :) [22:47:25] none [22:48:37] kristenlans: What was the name of that spider guy you were telling me about? I didn't have time to check him out then. [22:52:02] kaldari: oh yeah, he is @dpsspiders on twitter. Unfortunately, it looks like his spider db has been dead for a while: http://ispiders.blogspot.com/2010/03/nearctic-spider-database-dead.html :-( [22:52:10] He’s a cool dude to talk spider with tho [23:01:18] kristenlans: Oh, yeah I totally know that site. It was based in Canada, wasn't it. I remember when it died :( [23:03:31] (03CR) 10JGonera: Improve fixed header in overlays on iOS (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) (owner: 10JGonera) [23:08:26] dbrant|brb: Thanks for sending the screenshots! The Santa Claus one looks like a single disambig button, how come it has both [23:08:58] vbamba: right, the Santa Claus page has two disambiguation notices, and I only care about the first one. [23:10:53] You might be interested in this little (prototype!) tool we were working on when I left EOL kaldari. Meant to show gaps in data across life, currently down to the family level, but v2 will show genus level: eg http://ggi.eol.org/taxon/E8D86BF9-2C93-62F7-7799-81A2A343AB51 [23:11:02] (03PS14) 10JGonera: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) [23:11:10] kaldari, ^ [23:11:29] (03PS4) 10JGonera: Let VE know if we are running on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148888 [23:11:47] Wikimedia Biologists, yay! [23:11:48] \o/ [23:12:13] spiders, imma let you finish, but ticks are the best arachnids of all time. [23:12:17] :D [23:12:35] Ticks, nooooooo!!! [23:12:39] kristenlans: That's awesome! [23:12:57] dbrant: I actually discussed this with Jared. Our idea was to ignore the second notice. Its a specific notice and doesn't always make sense. [23:13:06] kristenlans: Were you familiar with tolweb? (Tree of Life Web) [23:13:23] Totally. [23:13:52] vbamba: so then, the logic should be: hide all hatnotes except the first one? [23:14:02] (03PS1) 10Catrope: Logging opera-detection cleanup [extensions/ZeroBanner] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150426 [23:14:10] (03CR) 10jenkins-bot: [V: 04-1] Logging opera-detection cleanup [extensions/ZeroBanner] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150426 (owner: 10Catrope) [23:14:37] kristenlans: My friend Wayne Maddison worked on tolweb, but it's kind of derelict now. [23:14:42] dbrant: yes [23:14:51] vbamba: can do! [23:15:12] (03CR) 10Catrope: [C: 032 V: 032] Logging opera-detection cleanup [extensions/ZeroBanner] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150426 (owner: 10Catrope) [23:15:16] (03CR) 10jenkins-bot: [V: 04-1] Logging opera-detection cleanup [extensions/ZeroBanner] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150426 (owner: 10Catrope) [23:15:25] kristenlans: Another friend of mine in Oakland built iNaturalist which is a really nice observations database. [23:16:02] MaxSem, is the "file cache" in https://bugzilla.wikimedia.org/show_bug.cgi?id=68106 related to something in MW core? [23:16:11] kaldari: Is it ken-ichi? I forget the other iNat guys name… [23:16:14] yes [23:16:38] kristenlans: Yeah ken-ichi! [23:16:49] kaldari: YEAH! [23:16:55] kristenlans: Scott Loarie is the other guy [23:18:10] kaldari: right. Small world! I’ve been meaning to hit those guys up for some “where to live in the Bay Area” protips [23:18:43] kristenlans: I've lived in SF, Berkeley, and Oakland. Oakland wins hands down :) [23:20:13] kristenlans: Anyway, gotta get back to more code review :) We should discuss more over dinner! [23:20:45] kaldari: 10-4! :-) [23:23:46] (03CR) 10Kaldari: [C: 04-1] Redirect to mobile diff page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [23:24:21] (03CR) 10Kaldari: [C: 032] Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) (owner: 10JGonera) [23:24:54] (03Merged) 10jenkins-bot: Improve fixed header in overlays on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) (owner: 10JGonera) [23:27:15] (03CR) 10Kaldari: [C: 032] Let VE know if we are running on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148888 (owner: 10JGonera) [23:27:47] (03Merged) 10jenkins-bot: Let VE know if we are running on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148888 (owner: 10JGonera) [23:33:18] (03PS1) 10Yurik: Use correct RL module class for templates [extensions/ZeroBanner] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150430 [23:34:38] vbamba: and what about hatnotes with more than one link? Remove them too, or keep them as is? [23:37:19] dbrant: extract the main hatnote that points to the disambig page, ignore other links and hatnotes. [23:37:27] mhurd: Any new bites on the beta invites? [23:38:28] jdlrobson2, https://gerrit.wikimedia.org/r/#/c/150430/ - is it needed for wmf15? [23:39:16] (03PS1) 10BearND: Updated launcher icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150432 [23:39:35] vbamba: but what about this, for instance: https://en.wikipedia.org/wiki/James_(name) There are two links, and there's no way for me to know which one is the "correct" disambig page. [23:44:26] yurikR: probably. If you are getting exceptions there yes [23:44:47] it won't hurt Mantle is installed on every wiki to my knowledge [23:44:55] (03PS5) 10Kaldari: Show talk button only when JS enabled or talk page not empty [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145411 (https://bugzilla.wikimedia.org/67819) (owner: 10Florianschmidtwelzow) [23:46:34] (03CR) 10Kaldari: [C: 032] Show talk button only when JS enabled or talk page not empty [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145411 (https://bugzilla.wikimedia.org/67819) (owner: 10Florianschmidtwelzow) [23:47:06] 3MobileFrontend / 3General/Unknown: If Javascript is disabled and an article doesn't have a talk page, we shouldn't show the talk page icon - 10https://bugzilla.wikimedia.org/67819 (10Ryan Kaldari) 5PATC>3RESO/FIX [23:47:10] (03Merged) 10jenkins-bot: Show talk button only when JS enabled or talk page not empty [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145411 (https://bugzilla.wikimedia.org/67819) (owner: 10Florianschmidtwelzow) [23:58:39] 3Wikipedia App / 3iOS App: Arabic links broken in latest beta - 10https://bugzilla.wikimedia.org/68829 (10Monte Hurd) 3NEW p:3Unprio s:3normal a:3None Looks like we've had a regression since the binary was submitted to the app store. To reproduce set search lang to arabic and taps on some links.