[00:00:41] 3Wikipedia App / 3iOS App: W menu items still in English when device lang switched to Arabic - 10https://bugzilla.wikimedia.org/68830 (10Monte Hurd) 3NEW p:3Unprio s:3normal a:3None Switch device lang to Arabic then tap on W menu to reproduce. [00:02:54] 3Wikipedia App / 3iOS App: References parsing JS doesn't recognize cluster of ref links if they have space between links. - 10https://bugzilla.wikimedia.org/68831 (10Monte Hurd) 3NEW p:3Unprio s:3normal a:3None It works fine if the refs looks like this "[1][2][3]" But it doesn't if they look like th... [00:14:10] 3Wikipedia App / 3iOS App: References parsing JS doesn't recognize cluster of ref links if they have space between links. - 10https://bugzilla.wikimedia.org/68831#c1 (10Bernd Sitzmann) One way to fix this is by replacing nextSibling/previousSibling with nextElementSibling/previousElementSibling. The drawbac... [00:15:14] Heyo. Question about mobilefrontend. I'm demonstrating the improvements that have been achieved in Flow on mobile, but I can't figure out how to get from a page to the talkpage. Where's the equivalent of the "discussion" tab hiding? [00:15:22] (03PS4) 10Jdlrobson: Explicitly name template languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149361 [00:16:42] aha, experimental-mode. (Someone pointed it out, in another channel) :) [00:17:48] (03CR) 10Jdlrobson: [C: 04-1] "Not quite production ready..." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150044 (owner: 10Jdlrobson) [00:17:52] 3Wikipedia App / 3iOS App: Arabic links broken in latest beta - 10https://bugzilla.wikimedia.org/68829#c1 (10Dan Garry) Just to clarify so there's no ambiguity, THIS IS NOT AN ISSUE IN THE BUILD THAT WILL BE RELEASED ON THE 31ST! [00:18:51] 3Wikipedia App / 3iOS App: Arabic links broken in latest beta - 10https://bugzilla.wikimedia.org/68829#c2 (10Monte Hurd) Confirmed. Not an issue in release build. [00:19:53] (03CR) 10Kaldari: [C: 032] Explicitly name template languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149361 (owner: 10Jdlrobson) [00:20:24] (03Merged) 10jenkins-bot: Explicitly name template languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/149361 (owner: 10Jdlrobson) [00:21:09] kaldari, do you know where is the most up to date agora color palette? [00:21:19] violetto, ^ [00:23:30] mhurd: what’s the issue with the arabic links? [00:23:53] (03CR) 10Kaldari: Instrumentation to test benefits of lazy loading in editing workflow (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150044 (owner: 10Jdlrobson) [00:24:11] when tapping on them i’m getting garbled encoding error msg [00:24:16] brion: ^ [00:25:04] mhurd: in current master? i don’t see any problems just clicking some random links [00:25:12] brion: noticed when i switched device lang to arabic, then search lang to arabic, then tapped a few links on the arabic main page [00:25:17] brion: ya [00:25:24] brion: current master [00:25:30] brion: lemme try again... [00:28:56] mhurd: might want to double-check that the bridge js is in sync with the obj-c side [00:29:01] it seems ok to me [00:34:43] jgonera: https://trello.com/c/IRqbu8p4/15-color-swatches [00:35:10] thanks violetto [00:35:15] brion: huh… now i don’t see the errors any more - i do wonder if what you mentioned happened - cruft js and such… [00:35:30] brion: hmmm [00:35:46] yeah if you pulled up an old branch it might have got confused [00:37:05] (03PS1) 10BearND: Fix background for dark theme in edit summary: other [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150450 [00:37:29] lemme double-check on the refs branch [00:38:26] brion: it seems i now get the error on the refs branch. you? [00:40:12] aha [00:40:17] mhurd: confirmed [00:40:24] brion: yay@ [00:40:26] ! [00:40:31] ok i think i have to add a decoding step on the other end of the bridge [00:40:46] brion: ah! nice! [00:40:47] it didn’t show up in english :) [00:40:50] lemme look [00:41:39] i must have assumed it was already decoded properly by the url stuff, bad assumption :D [00:42:42] oh hehe we already did one level of decode, i think we’re failing to decode on the other links :D [00:43:50] dbrant: Hello [00:44:26] mhurd: so a bug in the bridge was hiding a bug in the link handler ;) [00:44:29] i think this should work [00:44:39] yesssss [00:45:57] (03PS7) 10Brion VIBBER: References click backend: detect link clicks and send data over bridge [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148247 [00:46:08] mhurd: ok try rebasing on that and see if it fixes it [00:46:20] vbamba: hello [00:49:56] (03PS3) 10Kaldari: Instrumentation to test benefits of lazy loading in editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150044 (owner: 10Jdlrobson) [00:51:53] jgonera: Could you take a look at https://gerrit.wikimedia.org/r/#/c/150044 ? It was written by both Jon and myself, so we can't merge it :) [00:52:25] MaxSem: There's also some PHP in there ^ [00:52:40] OH NOES [00:54:37] brion: will do! [00:55:36] (03CR) 10MaxSem: [C: 04-1] Instrumentation to test benefits of lazy loading in editing workflow (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150044 (owner: 10Jdlrobson) [00:57:25] brion: i think that did it! [00:57:29] :) [00:58:09] \o/ [00:58:14] yayy [01:01:17] tfinc: ^ brion fixed it :) [01:01:22] brion: big thanks [01:01:34] i was really glad to see that not affect our approved market build [01:03:10] yeah that woulda been scary :D [01:03:36] the version we submitted should be fine, with one bug masking the other ;) [01:03:43] hehe [01:03:46] and our update will now have both fixed :D [01:04:14] brion: yes! [01:04:38] Deskana: https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals [01:06:02] number 2 is us! \o/ [01:07:04] (03PS1) 10Dr0ptp4kt: Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 [01:09:26] mhurd: Did you have a question? [01:09:35] im on the font stuff :) [01:09:42] vbamba: ah just checking in :) oh it’s food time! [01:10:09] vbamba: I updated the acceptance criteria on trello [01:11:03] have fun guys! [01:11:16] dbrant: thank you! [01:13:12] mhurd: actually you have a second to come over? [01:17:34] kaldari, I'll have a look at it first thing tomorrow [04:04:25] (03PS1) 10BearND: Handle page internal links inside reference display [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150479 (https://bugzilla.wikimedia.org/68336) [05:28:13] (03CR) 10Florianschmidtwelzow: "Thanks for uploading the fixes ;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145411 (https://bugzilla.wikimedia.org/67819) (owner: 10Florianschmidtwelzow) [05:36:05] (03CR) 10Florianschmidtwelzow: Redirect to mobile diff page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [07:01:35] (03PS12) 10Florianschmidtwelzow: Insert section name in edit summary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) [08:14:24] 3MobileFrontend / 3beta: Safari on iPad crashes when viewing large articles? - 10https://bugzilla.wikimedia.org/68845 (10deanator71) 3UNCO p:3Unprio s:3normal a:3None When viewing an article as large as https://en.m.wikipedia.org/wiki/Fukushima_Daiichi_nuclear_disaster, when I click one of the table... [09:45:51] 3MobileFrontend / 3beta: Safari on iPad crashes when viewing large articles? - 10https://bugzilla.wikimedia.org/68845#c1 (10Andre Klapper) s:5normal>3critic Thanks for taking the time to report this! Which Safari version is this about and which iPad version? (For general information, see https://www.med... [10:37:22] 3MobileFrontend / 3beta: Safari on iPad crashes when viewing large articles? - 10https://bugzilla.wikimedia.org/68845#c2 (10deanator71) On iOS 7.1.2 with the iPad 4 [12:38:21] 3MobileFrontend / 3beta: Safari on iPad crashes when viewing large articles? - 10https://bugzilla.wikimedia.org/68845 (10Florian) [13:03:19] (03PS3) 10Dbrant: Add disambiguation button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150385 [13:11:06] (03CR) 10Dbrant: [C: 032] Updated launcher icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150432 (owner: 10BearND) [13:12:04] (03CR) 10Dbrant: [C: 032] Fix background for dark theme in edit summary: other [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150450 (owner: 10BearND) [13:24:17] (03PS8) 10Dbrant: [WIP] Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [13:27:43] (03PS8) 10Dbrant: [WIP] Add first-time editing onboarding. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148436 [13:33:58] (03CR) 10Dbrant: "see inline comment" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 (owner: 10Dbrant) [13:34:52] (03PS2) 10Dbrant: [WIP] Implement full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 [13:43:43] (03CR) 10Dbrant: [C: 032] Bring back some translated strings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150147 (owner: 10BearND) [13:55:48] (03CR) 10Manybubbles: "Happy to +2 if your sure it is the right thing to do. And you are willing to build the submodule update on core :P once it merges." [extensions/ZeroBanner] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150430 (owner: 10Yurik) [14:46:06] (03PS3) 10Dbrant: [WIP] Implement full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 [15:14:37] (03CR) 10Dbrant: "see inline" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150479 (https://bugzilla.wikimedia.org/68336) (owner: 10BearND) [15:30:09] (03CR) 10BearND: "CIL" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150479 (https://bugzilla.wikimedia.org/68336) (owner: 10BearND) [15:35:44] bearND: ^ oh I see! it actually resolves the 'redirection' of references. [15:35:51] in that case, it should be good to go! [15:36:18] dbrant: yes, thanks [15:42:48] (03PS4) 10Florianschmidtwelzow: Redirect to mobile diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) [15:45:03] (03CR) 10Florianschmidtwelzow: "I get still redirected if i change the the user agent for every diff page :/ Maybe it's cache related (and i'm to silly to clear redirect " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [15:45:28] (03PS5) 10Florianschmidtwelzow: Redirect to mobile diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) [16:29:30] (03PS1) 10Cmcmahon: QA: update VE editor test to use API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150572 [16:30:56] (03CR) 10Cmcmahon: "I've been meaning to do this for some time, the target page fills up with "ABCDEF" edits." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150572 (owner: 10Cmcmahon) [16:52:23] 3Wikipedia App / 3iOS App: i18n not working for saved pages and history "no pages yet" text. - 10https://bugzilla.wikimedia.org/68864 (10Monte Hurd) 3NEW p:3Unprio s:3normal a:3None If you don't have any saved pages or you've deleted all history items, the "No saved pages yet" text you see below the... [16:56:53] 3Wikipedia App / 3iOS App: History of changes to page isn't showing localized dates. - 10https://bugzilla.wikimedia.org/68865 (10Monte Hurd) 3NEW p:3Unprio s:3normal a:3None If you scroll to bottom of an article and tap the "Modified X hours ago by..." button the dates presented are not localized. I... [16:58:12] Deskana: none of the other journalists jumped through the testflight hoops... [16:58:54] mhurd: Pft. [16:58:55] dbrant|brb: Morning Sir! [16:59:06] vbamba: hey!! [16:59:28] I did more scrubbing and checked the manual of style. No new conclusions. [16:59:42] mhurd: is really happy that we are doing all this leg work on Android [16:59:47] so we can just copy on IOS then :) [16:59:57] vbamba: yes!!! :) [16:59:57] vbamba: excellent! [17:00:00] Hows it going on your end? [17:00:05] jgonera kaldari if y'all are OK with this it would be nice to merge it today https://gerrit.wikimedia.org/r/#/c/150572/ I've been meaning to do that for a long time now. [17:00:10] Anything I can help with ? [17:00:12] dbrant: vbamba thanks to both of you!! :) [17:00:37] vbamba: it was easy to implement it the way we discussed yesterday. I can have a test build for you later. [17:00:37] dbrant: Any manual of style questions? [17:01:13] vbamba: nope; but that page is very educational! [17:02:02] I wish more editors followed the manual of style for consistent content formatting. [17:02:17] yes!! :( [17:02:33] What it does for us - Allows us to focus on the recommended strcuture. [17:02:52] (03PS1) 10Bartosz Dziewoński: Migrate Minerva-specific style modules to $wgResourceModuleSkinStyles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150580 [17:02:54] (03PS1) 10Bartosz Dziewoński: Remove two old modules kept for HTML backwards-compatibility [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150581 [17:02:54] If content formatting is outside of it, then we can blame it on people falling out of step. [17:02:56] (03PS1) 10Bartosz Dziewoński: Remove reference to 'mobile.styles.page' module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150582 [17:03:22] dbrant: :) Gives us a way to deal with the madness [17:03:23] (03CR) 10Bartosz Dziewoński: "DID NOT TEST. Requires master MediaWiki." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150580 (owner: 10Bartosz Dziewoński) [17:03:37] vbamba: indeed [17:05:59] vbamba: are you going to share the manual of style document with more devs? [17:07:01] (03PS2) 10Bartosz Dziewoński: Remove reference to non-existing 'mobile.styles.page' module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150582 [17:08:56] bearND: yeah absolutely. Ill send out an email. Its existed for a long time, not a lot of people are aware of it (IMO) [17:09:43] vbamba: I wasn't until a few minutes ago [17:21:12] MaxSem it looks like bugello hasn't run in about 11 hrs for some reason [17:21:26] thanks for catching that - i'll look into it after sos [17:25:27] (03PS1) 10Ebe123: Replace IP userpage link by IP contribution page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150588 (https://bugzilla.wikimedia.org/68775) [17:26:00] brion, mhurd - hi [17:26:05] can you please take a look at https://gerrit.wikimedia.org/r/#/c/150162/ ? [17:26:08] hi aharoni ! [17:26:15] in mtg will look shortly [17:27:12] (03CR) 10Siebrand: [WIP] Implement full-text search. (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 (owner: 10Dbrant) [17:27:34] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Per comments on PS1." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 (owner: 10Dbrant) [17:29:06] 3Wikipedia App / 3iOS App: References parsing JS doesn't recognize cluster of ref links if they have space between links. - 10https://bugzilla.wikimedia.org/68831#c2 (10Brion Vibber) Got a sample page to test with? Probably easyish to fix per Bernd's note [17:29:24] aharoni: ah good, i’ll cross-check the list [17:29:35] brion: thanks [17:35:28] aharoni: looks good, +2’d [17:35:35] ok [17:35:40] and added a comment about why it’s hard to just remove them from the file [17:36:13] Thank you very much. [17:36:34] thank you! i’m trying to make life easier for translators but it’s a new system and we’re still shaking it out :D [17:36:51] 3MobileFrontend / 3beta: Safari on iPad crashes when viewing large articles? - 10https://bugzilla.wikimedia.org/68845#c3 (10Ryan Kaldari) No luck so far reproducing the crash, but following the TOC links is definitely slow on en.wiki on iPad. The links are just plain anchor links, although they do have an ev... [17:37:16] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/148436 (owner: 10Dbrant) [17:40:26] mhurd: quick question about the iOS app: do you use single or double quotes in strings like: no results found for "x" [17:41:31] brion: ^ [17:41:48] hmm good question [17:41:48] dbrant: i guess i prefer double? [17:43:41] I see that mediawiki uses double quotes, but I've noticed that the Android app has been using single. I was curious what iOS uses. [17:46:45] dbrant: looking around we mostly refer indirectly to ‘the search term’ :D [17:46:54] but i’d recommend double quotes probably as a general rule [17:47:16] yeah, that's what I'd prefer, as well [17:48:21] 3Wikipedia App / 3iOS App: i18n not working for saved pages and history "no pages yet" text. - 10https://bugzilla.wikimedia.org/68864 (10Andre Klapper) [17:49:15] jgonera: replication lag watchdog in beta labs would set the db to read-only when replag went over 5 seconds. this caused generic "edit failed" messages in MF and caused Flow to just hang. [17:49:21] 3Wikipedia App / 3iOS App: i18n not working for saved pages and history "no pages yet" text. - 10https://bugzilla.wikimedia.org/68864#c1 (10Brion Vibber) This is probably simply because the localizations are incomplete? We've only just gotten the UI storyboard strings into TranslateWiki the other day. [17:49:40] jgonera: now replag timeout is 300 seconds and things are much improved [17:50:05] chrismcmahon, that doesn't solve issues mentioned in https://bugzilla.wikimedia.org/show_bug.cgi?id=68084 and https://bugzilla.wikimedia.org/show_bug.cgi?id=68083 does it? [17:51:09] (03CR) 10Dbrant: "Ah, I see. So in that case, I would probably prefer to change to double-quotes throughout the app, to be consistent with MediaWiki." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 (owner: 10Dbrant) [17:51:53] jgonera: we have a support ticket in with Sauce for https://bugzilla.wikimedia.org/show_bug.cgi?id=68083 . They are updating their default version of Chrome/Chromedriver for everyone, which I hope will solve that. [17:52:53] (03PS1) 10Florianschmidtwelzow: Show IP's contributions on SpecialMobileContributions, too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150592 (https://bugzilla.wikimedia.org/68775) [17:53:24] chrismcmahon, I see, thanks [17:54:43] jgonera: this one I'm not sure https://bugzilla.wikimedia.org/show_bug.cgi?id=68084 . It may have been HHVM at the root cause there, but that one looks like beta just being non-responsive and/or exceptionally slow. [17:55:25] chrismcmahon, yeah, ok, let's see if things improve in the next couple of weeks and take further action if beta labs is still unreliable [17:56:51] 3MobileFrontend / 3beta: VisualEditor Mobile: fresh accounts being taken to VE by default on beta labs - 10https://bugzilla.wikimedia.org/68583#c3 (10Maryana Pinchuk) 5NEW>3RESO/WOR When I cleared cookies, the problem disappeared, so it must've been just lingering VE cookie crumbs on my machine from all... [17:56:56] kaldari: ^ [17:57:09] one less bug to deal with :) [17:57:25] yay [17:58:39] (03CR) 10Florianschmidtwelzow: "@Jgoettlich: Sorry, hit too fast enter :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150588 (https://bugzilla.wikimedia.org/68775) (owner: 10Ebe123) [18:00:11] (03CR) 10Siebrand: "Sounds good to me :)." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 (owner: 10Dbrant) [18:05:25] (03PS1) 10Dbrant: Improve behavior of "empty" screen in History and Saved Pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150595 [18:08:05] (03PS1) 10Dbrant: Use double quotes in strings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150599 [18:13:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150396 (owner: 10Kaldari) [18:15:36] 3Wikipedia App / 3iOS App: References parsing JS doesn't recognize cluster of ref links if they have space between links. - 10https://bugzilla.wikimedia.org/68831#c3 (10Bernd Sitzmann) I created one on test wiki, but not sure if they really happen in a real world wiki. https://test.wikipedia.org/wiki/Referen... [18:16:16] Deskana: let me know if you need any more help with the "Today" patch [18:19:39] dbrant: Will do. Will probably try this afternoon. [18:19:40] (03CR) 10Dr0ptp4kt: Support multichannel builds. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 (owner: 10Dr0ptp4kt) [18:20:01] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150599 (owner: 10Dbrant) [18:20:21] (03Merged) 10jenkins-bot: Use double quotes in strings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150599 (owner: 10Dbrant) [18:22:46] (03PS4) 10Dbrant: [WIP] Implement full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 [18:23:26] dbrant: no hurry whatsoever but just wondering when you will send the updated apk [18:24:13] vbamba: few minutes [18:24:30] woo, catsitter’s pretty much set. heading in to office in a few mins [18:27:51] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 (owner: 10Dbrant) [18:30:16] (03CR) 10Dbrant: [C: 032] Handle page internal links inside reference display [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150479 (https://bugzilla.wikimedia.org/68336) (owner: 10BearND) [18:44:45] vbamba: do you have a sec? [18:51:11] Deskana: since your "today" menu item patch is not ready it probably should go back to Doing [18:52:39] bearND: Sure. [18:54:16] Deskana: thanks. Code review list looks much cleaner now, for Android at least. [18:54:34] dbrant: https://gerrit.wikimedia.org/r/#/c/150385/ needs a manual rebase [19:11:10] (03PS4) 10Dbrant: Add disambiguation button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150385 [19:15:29] bearND: ^ done! [19:17:16] (03CR) 10EBernhardson: [C: 032] "trivial" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150394 (owner: 10Bsitu) [19:19:57] brion: https://test.wikipedia.org/wiki/Monte_refs_test [19:20:24] (03Merged) 10jenkins-bot: Only trigger 'mark as read' API if unread notification is not 0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150394 (owner: 10Bsitu) [19:34:07] (03PS1) 10Jdlrobson: Force mobile friendly mediawiki ui interfaces where possible. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150636 (https://bugzilla.wikimedia.org/63428) [19:39:43] (03PS1) 10Brion VIBBER: Fix RTL edit pencil for iOS [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/150639 (https://bugzilla.wikimedia.org/67611) [19:39:47] (03PS1) 10Brion VIBBER: Fix content direction on edit preview [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/150640 [19:42:33] dbrant: where did you see the error message that triggered https://gerrit.wikimedia.org/r/#/c/150248/1/less/enwiki.less? [19:44:06] bearND: look at the generated css that comes out of it. The syntax is broken near the bottom of the file. [19:45:27] dbrant: is there way to generate it inside the MobileApp extension? Or do you basically do it from our app only [19:46:28] bearND: yeah, just run the make-css script [19:47:16] dbrant: ok. Was just hoping there would be something directly in the MobileApp extension [19:47:49] don't believe so :( [20:02:35] moizsyed: are you joining mobile web sotry grooming? [20:02:44] STORY even [20:04:08] dbrant: fyi: your MobileApp extension patches https://gerrit.wikimedia.org/r/#/c/150248/ and https://gerrit.wikimedia.org/r/150380 are merged [20:04:20] bearND: thanks!! [20:08:44] dbrant: would you like to update the css again in the disambig patch or do a separate patch for the css syntax fix later? [20:09:15] this is for the app patches [20:09:23] mhurd: yes! want to talk now? I can come over. [20:09:34] bearND: ah yes, i'll do it in the disambig patch [20:09:48] dbrant: sounds great [20:16:06] vbamba: was eating. still around? [20:17:52] Yeah, Ill come over in 2 mts [20:23:12] (03PS5) 10Dbrant: Add disambiguation button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150385 [20:23:18] (03CR) 10Jdlrobson: [C: 04-1] "Not working for some reason. Go to Special:Userlogin?useformat=mobile before and after to test." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150580 (owner: 10Bartosz Dziewoński) [20:24:01] (03PS3) 10Jdlrobson: Remove reference to non-existing 'mobile.styles.page' module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150582 (owner: 10Bartosz Dziewoński) [20:24:21] (03PS4) 10Jdlrobson: Hygiene: Remove reference to non-existing 'mobile.styles.page' module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150582 (owner: 10Bartosz Dziewoński) [20:26:35] MaxSem: If you have any suggestions for me to improve my interviews let me know. I specifically left out security since Arthur is covering that in his interview. [20:27:03] CODINGCODINGCODING [20:27:35] Well, that's what the coding task is supposed to be for :P [20:27:57] but maybe I'll add some more code tasks to the interview as well [20:32:20] (03CR) 10BearND: [C: 032] Add disambiguation button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150385 (owner: 10Dbrant) [20:32:42] (03Merged) 10jenkins-bot: Add disambiguation button. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150385 (owner: 10Dbrant) [20:35:26] (03PS2) 10BearND: Improve behavior of "empty" screen in History and Saved Pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150595 (owner: 10Dbrant) [20:38:33] (03CR) 10BearND: [C: 032] Improve behavior of "empty" screen in History and Saved Pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150595 (owner: 10Dbrant) [20:38:51] (03Merged) 10jenkins-bot: Improve behavior of "empty" screen in History and Saved Pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150595 (owner: 10Dbrant) [20:42:42] (03PS8) 10Brion VIBBER: References click backend: detect link clicks and send data over bridge [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/148247 [20:55:15] (03PS1) 10Dr0ptp4kt: Make the zerodot landing page occupy the viewport width. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/150698 [20:56:06] yurik: would you please review and +2 https://gerrit.wikimedia.org/r/150698 ? i didn't change it to make it run with mdot, it's still only on zerodot. [20:56:15] dr0ptp4kt, looking [21:03:22] 3Wikipedia App / 3iOS App: Arabic links broken in latest beta - 10https://bugzilla.wikimedia.org/68829#c3 (10Brion Vibber) 5NEW>3RESO/FIX This is fixed on the refs branch where the bug originated. [21:04:53] 3Wikipedia App / 3iOS App: References parsing JS doesn't recognize cluster of ref links if they have space between links. - 10https://bugzilla.wikimedia.org/68831#c4 (10Brion Vibber) 5NEW>3RESO/FIX Done on the iOS refs branch in: https://gerrit.wikimedia.org/r/#/c/148247/ -- see the goLeft/goRight functi... [21:11:54] mhurd: I have a new font file with (I think) consistent weights [21:11:58] can we try plugging them in? [21:12:04] vbamba: ya! [21:12:12] ok emailing it to you [21:16:19] (03CR) 10BearND: Support multichannel builds. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 (owner: 10Dr0ptp4kt) [21:16:24] (03PS3) 10Dr0ptp4kt: Update app description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 [21:22:06] (03PS4) 10Dr0ptp4kt: Update app description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 [21:22:36] 3Wikipedia App / 3iOS App: History of changes to page isn't showing localized dates. - 10https://bugzilla.wikimedia.org/68865#c1 (10Brion Vibber) 5NEW>3RESO/WOR Turns out this was actually working -- you have to set "regional settings" for date formatting as well as the language or it'll keep on giving y... [21:24:02] Deskana: would you please review https://gerrit.wikimedia.org/r/150088 and give your +1? bearND, i left the fork verbiage as is for now. will poke yuvi about the git pull bot, and we can make a change later on that [21:26:53] dr0ptp4kt: didn't want to change also "article" to "page" in this patch based on Siebrand's comment? [21:27:04] bearND: shoot, yes. thanks. hang on [21:28:06] (03PS5) 10Dr0ptp4kt: Update app description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 [21:28:10] Deskana: ^ update [21:28:14] bearND ^^ [21:32:22] (03CR) 10Dr0ptp4kt: "@YuviPanda, see question about releases.wikimedia.org." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 (owner: 10Dr0ptp4kt) [21:37:36] tfinc: has our meeting been moved again? [21:37:48] bearND: nope, just got distracted [21:37:55] tfinc: ah, ok [21:41:42] jgonera: there's some new weirdness with scrolling on ipad.. :-/ [21:44:24] Maryana, coming [21:51:28] (03PS2) 10Dr0ptp4kt: Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 [21:51:57] brion and bearND ^ mind taking a look at that? [21:52:11] moment [22:06:44] dr0ptp4kt: I closed my IRC client by accident. What did you want review on? :) [22:07:35] Deskana: https://gerrit.wikimedia.org/r/150088 . i reverted the pull request stuff back to forking, because i have a question with yuvi on the bot for github. but there are some other verbiage changes in that patch [22:09:33] I'd like to tighten up the wording a bit I think. [22:10:08] Deskana: sweet. wanna git review -d 15088 and then resubmit with git review -R? :) [22:10:28] Deskana: with a git commit -a --amend in the middle [22:10:47] Sure, let me finish this. [22:10:50] Deskana: can't remember if you're a git-command pro [22:10:53] Deskana: thanks [22:11:05] I'm not a git command pro. I'm learning though. :) [22:11:10] So thanks for the tip. [22:12:39] 3MobileFrontend / 3stable: Search results + pageimages garbled on beta labs - 10https://bugzilla.wikimedia.org/68880 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Created attachment 16104 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16104&action=edit Pageimage thumbnails overlapping... [22:12:47] bugz bugz bugz [22:13:42] Deskana: you're supposed to be napping.. :-P [22:14:47] brion and bearND, i forgot to mention what locales i saw on this samsung nexus device in the list of all supported locales (not the same as lang picker in Settings app) - https://gist.github.com/anonymous/fda06908830ef2618d8f [22:15:05] Maryana: Pfff [22:15:23] Maryana: Just relaxing at home has helped a lot. [22:16:50] Maryana: will you be in wikimania? [22:17:00] i will :) [22:17:12] hope to see you there! [22:17:25] yes! will you be at the hackathon, too, or just the conference? [22:17:45] kind of hackathon [22:17:51] fdc duties [22:18:09] Deskana: save a sit for me in the roundtable [22:18:47] (03CR) 10MaxSem: [C: 032] Replace IP userpage link by IP contribution page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150588 (https://bugzilla.wikimedia.org/68775) (owner: 10Ebe123) [22:19:21] (03Merged) 10jenkins-bot: Replace IP userpage link by IP contribution page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150588 (https://bugzilla.wikimedia.org/68775) (owner: 10Ebe123) [22:34:52] mhurd: I was almost done fixing everything, then fontforge froze on me. [22:35:06] mhurd: I need 2 mts to meltdown and then ill start again. [22:35:11] mhurd: sorry for the delay [22:35:11] vbamba: oh noo! [22:42:37] Maryana, can you give me the bug number for what you discovered? [22:42:58] jgonera: https://bugzilla.wikimedia.org/show_bug.cgi?id=68878 [22:42:59] Maryana, it is indeed the smoother scrolling in reference dialog so I'll revert it [22:44:02] kaldari, jdlrobson I'm sorry for not having reviewed that dynamic loading benchmark patch, but given Maryana and James_F decided to proceed with pushing VE to stable tomorrow, I'm still focusing on some last issues [22:44:13] can that debate/patch wait a little bit longer? [22:44:33] jgonera: sure [22:44:39] thanks [22:47:23] no problem jgonera there is no deployment till after wikimania from what i understand anyway [22:47:46] jdlrobson, yeah, the last one is tomorrow [22:53:13] dr0ptp4kt: Realistically I cannot review your commit due to having to answer a constant steam of questions from comms about the app launch. Sorry. :( [22:53:38] Deskana: alright [23:14:39] (03PS1) 10JGonera: Delay calculating available area height when keyboard opens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150727 (https://bugzilla.wikimedia.org/68832) [23:15:12] jdlrobson, kaldari, when you have a moment, please merge ^ it's a very small change [23:15:29] it would be good for this to hit beta labs today so that Rummana can test [23:15:46] (I ruined my karma by submitting this BTW but I'll make up for it) [23:16:12] jgonera: if kaldari doesn't get there i'll take a look at next opportunity did you get my message earlier about no deployment till post wikimania? [23:16:22] (03CR) 10jenkins-bot: [V: 04-1] Delay calculating available area height when keyboard opens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150727 (https://bugzilla.wikimedia.org/68832) (owner: 10JGonera) [23:16:28] yes, jdlrobson, I even replied to it ;) [23:16:38] yeh i had a netsplit :( [23:16:45] jdlrobson, yeah, the last one is tomorrow [23:16:58] jgonera: but as i understand the deployment tomorrow is only the one to enwiki [23:17:01] or somethign like that [23:17:06] that's what StevenW said anyway [23:17:09] jdlrobson, not that I know of... [23:17:12] Maryana, ^ [23:17:13] so stuff will go to mediawiki.org [23:17:17] but not to en.wiki till a long time [23:17:20] oh yes [23:17:26] yeah, that [23:17:32] I thought you said it only goes to enwiki [23:17:38] no community wikis basically [23:17:47] yes, that's what we want, so that during wikimania we can test VE on a real wiki [23:17:54] (mediawiki.org) [23:18:27] I mean, I'd assume changes from last week still will go to enwiki tomorrow [23:18:29] (03CR) 10Kaldari: [C: 032] Delay calculating available area height when keyboard opens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150727 (https://bugzilla.wikimedia.org/68832) (owner: 10JGonera) [23:18:42] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150727 (https://bugzilla.wikimedia.org/68832) (owner: 10JGonera) [23:20:13] (03CR) 10jenkins-bot: [V: 04-1] Delay calculating available area height when keyboard opens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150727 (https://bugzilla.wikimedia.org/68832) (owner: 10JGonera) [23:20:26] (03Merged) 10jenkins-bot: Delay calculating available area height when keyboard opens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150727 (https://bugzilla.wikimedia.org/68832) (owner: 10JGonera) [23:26:06] (03CR) 10Dr0ptp4kt: "Also @Dbrant, your thoughts on the releases.wikimedia.org beta channel User-Agent differentiation?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/149483 (owner: 10Dr0ptp4kt) [23:36:00] yo MaxSem [23:36:09] yo? [23:36:12] MaxSem: did you have any thoughts on https://gerrit.wikimedia.org/r/#/c/148557/ [23:36:21] killing code good no? [23:36:25] aww [23:36:31] looking [23:38:16] (03CR) 10MaxSem: Use Special:EditWatchlist for A-Z View (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148557 (owner: 10Jdlrobson) [23:38:30] thanks MaxSem [23:38:50] MaxSem: what about page images? [23:39:23] previously we did them as part of the watchlist query [23:39:26] is there a more core friendly way we can do them [23:39:35] I feel like MobilePage.php is a bad way to go [23:39:44] since database query per page [23:39:52] could do with help working that one out.. [23:40:03] batch them [23:42:01] need help with that? [23:42:46] MaxSem: i would <3 help with that [23:42:57] deal [23:43:07] I'm not sure if we want to do it via a hook in PageImages or have some concept of MobilePageArray [23:43:15] i trust you will have good ideas around that though [23:43:24] fyi dr0ptp4kt https://gerrit.wikimedia.org/r/149360 [23:43:33] you might need to change things in Zero to reflect that [23:44:45] jdlrobson: how soon? [23:44:57] dr0ptp4kt: as soon as you can it's a minor change [23:45:00] i can walk you through it [23:45:08] and you can do it now to play it safe without any repercussions :) [23:45:17] jdlrobson: let's go over it tomorrow [23:45:23] ok [23:49:52] Maryana: you around? [23:50:02] yep, just in a quick huddle w/howie [23:50:04] what's up? [23:50:19] wanted to compare notes about the upload analytics [23:50:59] kaldari: famous last words but.. gimme 30 min? :) [23:53:50] kaldari: actually, i'll be there in a sec [23:56:50] (03CR) 10Jdlrobson: [C: 04-1] "Need to merge dependency first." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150636 (https://bugzilla.wikimedia.org/63428) (owner: 10Jdlrobson)