[00:05:48] (03PS4) 10Dr0ptp4kt: Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 [01:09:12] (03PS1) 10Mhurd: Updated iOS glyphs. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151003 [05:46:22] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c143 (10Florian) > I don't know if I can resolve this fixed or not I think we can keep it on patch to review since we have feedback from Commons users and/or the new statistic after this change. Th... [06:09:29] (03PS2) 10Mhurd: Updated iOS glyphs. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151003 [06:11:23] (03CR) 10Mhurd: [C: 032 V: 032] "I like it!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/150286 (https://bugzilla.wikimedia.org/68681) (owner: 10Brion VIBBER) [06:14:16] (03CR) 10Mhurd: [C: 032 V: 032] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/150639 (https://bugzilla.wikimedia.org/67611) (owner: 10Brion VIBBER) [06:15:09] (03CR) 10Mhurd: [C: 032 V: 032] "Awesome!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/150640 (owner: 10Brion VIBBER) [06:16:05] (03CR) 10Mhurd: [C: 032 V: 032] "Yes!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/150972 (owner: 10Brion VIBBER) [07:10:25] 3MobileFrontend / 3General/Unknown: the number in mobile talk icon is misplaced in rtl - 10https://bugzilla.wikimedia.org/68990 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Created attachment 16117 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16117&action=edit Hebrew screenshot The... [07:10:37] 3MobileFrontend / 3General/Unknown: the number in mobile talk icon is misplaced in rtl - 10https://bugzilla.wikimedia.org/68990#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9rAAIwg5 [07:11:21] 3MobileFrontend / 3General/Unknown: the number in mobile talk icon is misplaced in rtl - 10https://bugzilla.wikimedia.org/68990#c2 (10Amir E. Aharoni) Created attachment 16118 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16118&action=edit English screenshot [07:20:20] (03PS1) 10Mhurd: Only scroll refs up if ref link would have been covered by refs panel. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151031 [07:31:05] (03CR) 10Mhurd: [C: 032 V: 032] "Looks good!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/150987 (owner: 10Brion VIBBER) [07:32:11] (03CR) 10Mhurd: [C: 032 V: 032] "Good!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/150988 (owner: 10Brion VIBBER) [07:45:39] 3MobileFrontend / 3General/Unknown: the number in mobile talk icon is misplaced in rtl - 10https://bugzilla.wikimedia.org/68990 (10Andre Klapper) [12:13:40] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c144 (10Steinsplitter) 5PATC>3RESO/FIX *On Commons, mobile upload should be only possible for users with an editcount higher as 75* should fix this definitive. Closing this for now as *resoled*.... [14:44:42] (03PS1) 10Dbrant: Checkstyle: "whitespace" and "design" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151087 [14:48:28] refreshing crash repots…… [14:48:28] yesssssss we got some [14:48:34] brion: yay [14:48:38] * YuviPanda waves at dbrant [14:48:51] hello! [14:49:19] (03PS12) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) [14:49:34] dbrant: nice, after that patch we only have 11!!! [14:49:35] https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/1657/checkstyleResult/ [14:49:57] (03CR) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [14:50:01] (03PS13) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) [14:50:02] YuviPanda: zapping those now... [14:50:07] w00t [14:50:18] dbrant: seperate patchset? [14:50:27] YuviPanda: yep [14:51:23] cool [14:52:33] hello all :) [14:53:48] hello FlorianSW [14:54:05] (03PS1) 10Dbrant: Checkstyle: magic numbers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151089 [14:54:42] bah xcode isn’t adding the symbols to the crash reports [14:54:54] dbrant: w00t [14:54:56] so that’s odd; the system libraries list symbols but the app doesn’t :D [14:56:20] i wonder if it’s our error handler [14:58:31] no, doesn’t look like the error handler, looks like onFinishblah [15:02:21] dbrant: w00t for the first successful checkstyle build! (cc YuviPanda) [15:02:27] bearND: indeed :) [15:03:13] yes! [15:06:14] (03CR) 10Yuvipanda: [C: 032] Checkstyle: "whitespace" and "design" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151087 (owner: 10Dbrant) [15:06:37] (03Merged) 10jenkins-bot: Checkstyle: "whitespace" and "design" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151087 (owner: 10Dbrant) [15:07:39] dbrant: can you poke hashar (Antoine, maintains our Jenkins infrastructure) to make the check 'voting' now? it'll prevent merges that produce an error [15:07:59] dbrant: he isn't around now, though [15:08:05] YuviPanda: sure [15:08:55] (03CR) 10Yuvipanda: [C: 032] "AWWW YEAH!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151089 (owner: 10Dbrant) [15:09:01] dbrant: bearND awesome work! \o/ [15:09:13] thanks! :D [15:09:16] (03Merged) 10jenkins-bot: Checkstyle: magic numbers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151089 (owner: 10Dbrant) [15:35:07] brion: any luck on the font size? [15:35:14] YuviPanda: ? [15:35:23] brion: gah, brain mush [15:35:28] brion: I meant, any luck on the crash reports [15:35:32] ah :D [15:35:51] yeah i managed to rebuild the version of the app we submitted and xcode is willing to add the symbols to the logs now [15:36:13] brion: ah, nice :) does it have stats on how many crashes there were? [15:36:19] looks like we’re turning up one or more null values when downloading text sections but failing to catch the error case [15:36:41] ah, hmm [15:36:52] no, just … percentages of total crashes that are each subset? [15:36:54] apple is fucking weird [15:36:57] totals would be nice [15:37:06] heh [15:37:11] 'sorry, that will violate user privacy' [15:40:49] brion: also, you might like... quarry.wmflabs.org [15:45:02] nice [15:45:40] YuviPanda: if i put in ‘select * from revision’ is it going to explode? :D [15:46:11] let’s find out [15:55:02] brion: won't explode [15:55:04] brion: will get killed in a minute, I've a query killer :) [15:55:09] yay [15:55:12] YuviPanda: nice UI [15:55:20] bearND: :) [15:55:23] checking out the user table, glad to see it’s filterred :D [15:55:43] hah, erik is the user ID after me on enwiki (52 vs 51) [15:56:12] hehe [15:56:25] YuviPanda: I like that you can see other peoples queries and results [15:56:32] brion: you can share the link with others as well, and over the weekend I'll add a 'fork' buttona [15:56:37] nice! [15:56:50] bearND: brion yeah, I hope this can run in prod as well, so we can use this interface for EventLogging too [15:56:58] (restricted to people who've signed an NDA) [15:57:38] YuviPanda: hmm, http://quarry.wmflabs.org/query/runs/all seems to show the same query by me three times instead of my three separate queries [15:57:42] brion: bearND this is still 'unannounced', so I'll clean out all queries / data once before sending out an announcement to mailig lists [15:57:49] spiff [15:57:52] brion: yeah, query runs is super wonk6y [15:57:59] :) [15:58:04] brion: also wondering if it should just use mediawiki.org (or metawiki) login instead of wikitech [16:07:08] brion: hey! [16:07:58] morning mhurd ! [16:08:59] brion: i got most of your patches merged last night and submitted 2 more small patches :) [16:09:07] woot [16:09:47] mhurd: i got the crash reports from apple, the ones they list seem to be in DownloadSectionsOp with some null value being inserted into a dictionary [16:09:57] which probably is indicative of a failure to get proper data back from the api [16:10:06] brion: we can work with that :) [16:10:20] \o/ [16:11:31] brion: btw, I heard something somewhere about lastupdated being null or wrong for action=mobileview when page being requested is actually on commons [16:11:55] brion: so might be that [16:14:29] hmmmm i’ll doublecheck that [16:17:09] brion: hey! that scroll patch is freaking great!!! [16:19:07] :D [16:19:11] thanks [16:24:27] (03CR) 10Mhurd: [C: 032 V: 032] "This is freaking great!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/150740 (https://bugzilla.wikimedia.org/68683) (owner: 10Brion VIBBER) [16:24:32] :D [16:26:24] lemme test those other patches real quick [16:29:07] brion: yay! [16:32:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks good; stroke weight on the icons feels more consistent" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151003 (owner: 10Mhurd) [16:33:26] brion: hey i’m going to start putting together release notes for the testflight build & you can use them for the market build too [16:34:20] vbamba: WOOOOOOOOOOO banner in the reference section :D [16:34:45] mhurd: spiff, stick em in an etherpad or something and we’ll edit em [16:35:11] are reviews readable in the store yet? i still don’t see them in itunes connect :P [16:35:14] dang system’s so weird [16:35:31] brion: will do! [16:35:50] (03CR) 10Brion VIBBER: [C: 032 V: 032] "nice!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151031 (owner: 10Mhurd) [16:36:03] brion: woohoo! [16:36:32] mhurd: lemme bump the version to 4.0.1 also [16:37:32] (03PS1) 10Brion VIBBER: Bump ver to 4.0.1 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151105 [16:43:17] mhurd: should we try to sneak in a workaround for that mystery faiilure too? i’ve got some ideas for better error reporting where we might try packaging the api response etc, but that’ll be “work on that during wikimania” project [16:43:46] brion: ya! wanna try adding protection around that date field? [16:44:35] yeah at least a quick nil check should avoid the crash [16:48:20] testing... [16:48:36] brion: Are you tracking bugs on OTRS? [16:49:14] vbamba: haven’t checked since last night, there might be a buncha new ones :D will look shortly [16:49:23] but yeah i’ll go through em [16:49:52] anything concrete we’ll move into bugzilla [16:49:59] and that’ll make trello cards [16:50:52] 3Wikipedia App / 3Generic: The login form, registration form and registration captcha form are not scrollable - 10https://bugzilla.wikimedia.org/64406#c5 (10Dmitry Brant) 5NEW>3RESO/FIX Should be fixed in current production. [16:52:05] (03PS1) 10Brion VIBBER: Workaround crasher when lastmodified date is bogus [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151109 [16:52:36] mhurd: ok if those look good to you let’s merge em and start prepping builds :D [16:53:06] 3Wikipedia App / 3Generic: Network error is still not handled gracefully - 10https://bugzilla.wikimedia.org/64470#c3 (10Dmitry Brant) 5NEW>3RESO/FIX Should be fixed in current production. [16:54:09] brion: checking… i should have the release notes up on a etherpad in a couple minutes too [16:54:17] awesome [16:56:46] (03PS1) 10Yuvipanda: Add EL for font and theme change events [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151110 [17:05:10] dbrant: bearND hmm, I can't seem to ssh to stat1003 to verify ^ [17:05:22] * YuviPanda debugs [17:05:50] (03CR) 10Mhurd: [C: 032 V: 032] "Yes!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151105 (owner: 10Brion VIBBER) [17:05:54] YuviPanda: I'm able to log in [17:06:03] ls [17:06:21] hmm [17:09:45] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151109 (owner: 10Brion VIBBER) [17:10:54] (03CR) 10Brion VIBBER: Workaround crasher when lastmodified date is bogus (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151109 (owner: 10Brion VIBBER) [17:11:03] brion: i added a quick comment to that patch. oh, and how does this look for release notes: https://etherpad.wikimedia.org/p/ios_app_update_release_notes [17:11:13] looking [17:11:28] brion: read you comment. sounds reasonable [17:11:43] i think we can drop the ios link tap bug since that wasn’t in release version [17:11:51] (03CR) 10Mhurd: [C: 032 V: 032] "Boom!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151109 (owner: 10Brion VIBBER) [17:11:57] oh ! and we should update i18n [17:12:08] brion: cool! [17:12:10] bearND: can you run a translatewiki export for us when you have a chance? [17:12:49] mhurd: ok sounds pretty good, but let’s lead with “Workaround for crash on page load” :D [17:13:04] brion: k. editing… [17:13:43] brion: how does that sound? [17:14:12] we might want to split it into a super-short summary for the list, and link to a wiki page with the full details [17:14:18] nobody’s gonna scroll past the first line or two :D [17:14:51] brion: oh i disagree! i love detailed update text :) [17:15:22] hehe ok :D [17:15:27] ah standup time [17:28:15] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 (owner: 10Dr0ptp4kt) [17:28:28] our trello board really needs a cover photo... [17:28:52] but i'm afraid of what i'll get from google image search if i look for "brazil n the hood" [17:30:17] noooo my trello gold has expired – jdlrobson do you still have trello gold? [17:30:25] Maryana: no :( [17:30:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 (https://bugzilla.wikimedia.org/68438) (owner: 10Dbrant) [17:30:33] need to invite kristen Maryana! [17:30:42] oh yeah [17:30:54] no goold 'n the hood [17:31:21] aw, damn, she's already invited [17:32:36] kristenlans: can you get us trello gold? :) [17:32:54] jon and i had it for a brief period of time. it's what allows us to add crazy custom images to trello [17:33:04] i promise a 500% increase in productivity :) [17:33:10] hehe [17:33:38] maryana: I can get you Trello PLATINUM* [17:33:42] kristenlans: i think we can backlog the ‘save articles to pocket’, it’s a feature request. the ‘possible problems with saved pages migration’ we gotta keep open, as we’ve got a number of complaints about that and i want to track it down [17:33:45] whaaaat [17:33:45] *Phabricator [17:33:56] hehe [17:33:57] oh haha [17:34:02] hahaha [17:34:09] trello adamantium [17:34:18] *Bugzilla [17:34:31] Trello Wood* [17:34:31] euuurgh. no, that's like trello tin can [17:34:32] *Mingle [17:34:35] hehe [17:34:49] trello primitive rock [17:35:22] Trello Mountain Dew Edition* [17:35:24] *Microsoft Project [17:35:48] Filemaker Pro [17:36:05] Excel [17:36:15] CSV files edited in Notepad [17:36:42] brion: lol [17:37:27] brion: 10-4 on the pocket articles and saved pages migration [17:37:48] brion: wins [17:37:54] \o/ [17:38:27] pen and paper with a whiteboard? :) [17:38:45] don’t make me break out the cuneiform reeds and clay tablets [17:39:01] heh, just 'spoken words' [17:39:15] …speak? to other humans? [17:39:15] ape calls? [17:39:23] that’s what i have computers for so i can avoid that! [17:39:29] 'boo bhoo ghooo hooo', 'yes, that sounds like a 3 as well' [17:39:44] brion: heh [17:39:56] * YuviPanda awards brion a degree in human avoidance [17:40:05] * brion accepts it via e-mail [17:40:11] brion: hey trying a quick fix for refs dealloc issue we notice yesterday… [17:40:20] ah great [17:40:37] almost forgot that bug! it’d leak memory and eventually probably crash the app :) [17:40:48] (03CR) 10Yurik: [C: 032] Make the zerodot landing page occupy the viewport width. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/150698 (owner: 10Dr0ptp4kt) [17:41:00] brion: ya. i think i may have idea how to fix :0 [17:41:00] (03Merged) 10jenkins-bot: Make the zerodot landing page occupy the viewport width. [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/150698 (owner: 10Dr0ptp4kt) [17:41:02] :) [17:41:26] ok i’m gonna grab some food real quick then see if i can test the data migration again, see if it regressed before the release or if it’s got a “special” failure mode :) [17:42:05] (03PS1) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151119 [17:42:15] brion: ^ [17:42:29] skimming over the reviews we're all over the place [17:42:42] making me think we don't have a stable platform to move forward on [17:43:29] i'll ask again. what is giving us confidence that our bug fix branch wont introduce more issues rather then just focusing on bugs from the point where we branched the last release [17:44:01] mhurd: brion: do we have an etherpad tracking, trello, other for issues ? [17:45:50] dbrant: bearND fixed it, I can login to stat1003 now. seem to have fucked up my .ssh/config when playing with it for other things. [17:48:56] (03CR) 10Dr0ptp4kt: "I noticed that the Gist URL wasn't working for me for some reason. Here's one that works:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 (owner: 10Dr0ptp4kt) [17:49:26] bearND: you able to do a videoconference to go over the language variant stuff? [17:49:47] bearND: i can schedule something for next week if that's better, too [17:50:14] dr0ptp4kt: can you poke monte ? [17:50:19] tfinc: ? [17:50:30] mhurd: scroll up to my question [17:50:34] s [17:51:16] dr0ptp4kt: sure [17:52:20] tfinc: we’ve introduced a lot of misc bug fixes. but if you and dan prefer to do a point release off the initial release branch, that’s a more conservative choice that i’m fine with [17:52:29] dr0ptp4kt: let's do next week after we're done with the beta release [17:52:39] it means we won’t get the i18n updates yet but we can still push them the following week [17:52:41] bearND, cool, okay [17:52:42] unless it's something quick [17:52:56] brion: i want to make sure we have confidence in what we choose to push out [17:53:05] tfinc: either way we won’t have anything out to the stor euntil at least monday [17:53:07] yeah [17:53:19] and that it'll address the early crashed that we are seeing without introducing new issues [17:53:36] *nod* [17:53:44] brion: where are you guys keeping your triage list ? [17:54:01] tfinc: bugs going into bugzilla, cards going into trello [18:06:00] brion: i do see them all in trello. excellent [18:06:15] probably more to come once i do another pass through otrs :) [18:06:33] for some reason itunes connect doesn’t show me any reviews (?!) so i’m reading them out of the itunes store app on my phone :P [18:06:55] odd, i can see them, wonder why [18:07:11] what the... [18:07:17] ok it’ll show me “all versions” but not “current version" [18:07:24] but “all versions” includes the 4.0 reviews [18:07:26] sighhhh [18:07:31] that's because current version is likely the 4.0.1 [18:07:37] heh [18:07:39] silly itunes connect [18:07:40] which hasn't been uploaded let alone published [18:08:04] in which case it shouldn’t be listed as current, since it’s the *next* version [18:08:06] * YuviPanda hugs the play store dev console [18:08:11] apple crazy [18:08:34] YuviPanda: it really has a lot more data and usefulness [18:08:49] yeah [18:08:55] and is quite intuitive too [18:09:26] brion: as in your mail, the biggest issues are the crash reports and the report of some users not seeing saved pages [18:09:46] brion: do we have anyone on OTRS who could verify if saved pages are actually gone or if they simply don't know where to find them / [18:09:47] ? [18:10:30] will ask if it’s still looking uncertain [18:10:45] (03PS2) 10Brion VIBBER: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151119 (owner: 10BearND) [18:11:07] (03CR) 10Brion VIBBER: [C: 032 V: 032] "(tweaked to put back a couple new messages)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151119 (owner: 10BearND) [18:12:04] brion: yeah, mhurd was thinking it might be users who can't find them which could be the case. i'd like to verify if thats what's happening [18:16:52] brion: tfinc: increasingly frustrated about apple not having proper wide release beta channel support… [18:17:02] mhurd: yes [18:18:15] that’s because apple works on everything in secret until they think it’s perfect, and they expect everyone else to do the same [18:18:21] kind of a poor fit with “release early, release often” :D [18:18:26] brion: ya [18:21:55] Question about iOS account signups in #wikipedia - is something going on with the app? [18:22:31] Happening on hewiki, apparently, in pretty good volume [18:22:55] marktraceur: yeah, it asks when you first open the app to create an account [18:22:55] so [18:23:03] Aha. [18:23:24] YuviPanda: But we're not like featured or anything, this is just people discovering the new app in droves? :) [18:23:37] marktraceur: that might also be the case, I'm unsure. [18:24:54] marktraceur: I think the app got featured yesterday [18:25:26] marktraceur: still featured under "Best New Apps" [18:27:57] K, thanks. [18:28:05] lemme see if i can install an old build… [18:33:46] Wow. [18:33:48] I didn't expect the in-flight wifi to work with IRC. [18:34:10] happy flight Deskana [18:34:19] Deskana: wheeee [18:34:40] brion: mhurd just showed me the release notes and it looks like its mostly bug fixes and some new features [18:34:51] with the biggest risky new feature going out being references [18:34:56] Deskana: greetings [18:34:59] right [18:35:00] Hey [18:35:01] dr0ptp4kt: still there? [18:35:08] So I was just about to say [18:35:14] We should keep the first release to include only bug fixes [18:35:41] ok [18:35:44] * kristenlans waves to Deskana [18:35:55] Deskana: so we can either be very conservative and just land a couple high-prio fixes on top of the release branch... [18:36:02] … or we can do ‘everything but the references update’ [18:36:13] mhurd: was there anything else that was a bigish refactor in the meantime? [18:36:33] brion: no i think everything else was a good fix [18:36:42] ok [18:39:34] Bear in mind that if we make the build smaller, we'll have less things to test and therefore have confidence about whether it can be pushed earlier. [18:39:41] So by making it smaller, we can get it out quicker too. :) [18:39:53] I think that's most important, especially in light of people noticing the forward/back behaviour weirdness. [18:42:39] I'm really eager to get the features out there too, but I think we should play it safe here. [18:44:20] so how safe? :) [18:44:37] no naked pointer dereferencing! [18:44:41] should be all safe then [18:44:43] :) [18:45:13] :) [18:45:32] Deskana: so should we branch just before the references addition? [18:45:34] Deskana: please keep in mind the turnaround for apple approving patches has been ~2 days and given that apple doesn’t provide a wide beta channel we’re not going to really learn until we cut actual releases [18:45:39] unless we have a way to get a lot of people signed up on test flight - releasing is the only way of discovering bugs. [18:45:54] true enough, we thought this version was fine :) [18:46:19] hrm, so saved pages import works for me with a new build of the old app [18:46:32] Deskana: lets release often :) [18:46:39] will try rebuilding it with older sdk,s ee if any differences [18:46:53] brion: It's always worked for me every time that I test it too. [18:47:16] i sent a followup question to one of our otrs reporters to double-check whether their saved pages got imported or not [18:47:25] cause it might just be people not finding the menu [18:47:42] brion: Well, considering I've only ever reviewed a work-in-progress version of the references thing, I definitely am not comfortable releasing that. [18:47:46] and their first reponse was ambiguous about whether they were responding to my explanation of the saved pages or my explanation of the language setting :P :) [18:47:52] Deskana: ok [18:48:06] Deskana: Deskana cutting testflight shortly [18:48:14] Woohoo! [18:48:30] yeah nothing’s likely to hit apple release until monday at the earliest, maybe tuesday [18:49:34] Deskana: you can try to get more people to sign up on test flight during wikimania? [18:49:50] vbamba: Oh, I will. [18:49:54] its the only way to get more testing before a release [18:50:13] mhurd: You and I should look into that thing we saw in TestFlight. You know, the public link that you could give out rather than inviting specific people? [18:50:18] mhurd: It might be a good avenue to do this. [18:50:20] with 20-30 people, we can never test enough [18:50:29] nd we will his this same issue for every build [18:50:33] mhurd: We should probably also take the journalists off the list now. [18:50:59] kristenlans: Hey! Sorry, you waved at me just as I stood up. :) [18:51:30] Deskana: no worries 8) [18:51:52] I'm surprised at how well this wifi is working, honestly. [18:52:13] I'm glad I charged my laptop though because there's no plugs. [18:52:16] we've already found out plenty from the crash reports and it's simply about patching those and other bug fixes and having that as a complete release vs. introducing new features [18:52:40] bugs will always creep in there is not way to mitigate that but you want to introduce new features when you feel you are stable [18:52:43] tfinc: Yep, agreed. [18:53:08] Deskana: so, we’ll make a branch with all the fixes except the reference stuff ? [18:53:21] and have confidence that the teams energy can be focused where it is best used [18:53:27] brion: Yeah. [18:53:36] sounds good [18:53:45] mhurd: good with that? i’ll try and figure out the branching :D [18:53:55] brion: ya! [18:54:06] and then we’ll release it with references after this one goes out and we’ve had a little more testing [18:54:09] i know mhurd was tidying up some last bits about references so he may be distracted with that [18:54:54] Yeah, and I'd rather not have something I've not tested at all (references) in a release candidate! :-) [18:54:58] tfinc: when brion gets the branching figured out i’ll send that over testflight [18:55:04] thanks mhurd [18:55:14] mhurd: brion: you guys are doing great work. thank you [18:55:20] Deskana: also surprising is several requests for night mode on the iOS store. I don't recall putting night mode there [18:55:33] YuviPanda: i think it might have crept into a bugfix release by mistake :) [18:55:36] YuviPanda: Well, that's not as surprising as you might think. [18:55:43] brion: ah, I se :) [18:55:55] brion: that makes sense, ya [18:55:57] Deskana: its really interesting to see the feature requests be pretty much the same as what android users wanted [18:55:58] brion: since it was on master [18:56:00] YuviPanda: When we released the Android app to production, people were asking for night mode. [18:56:10] YuviPanda: And those were people that'd never had it, since it was only ever in the beta. [18:56:18] tfinc: Indeed, yes. [18:56:21] Deskana: true, but were they asking for it or complaining we took them away? [18:56:29] YuviPanda: Asking. [18:56:36] YuviPanda: soome said it was there before [18:56:37] YuviPanda: People are still asking for night mode, even now that it's in the app. :P [18:56:37] Deskana: the iOS ones are complaining we took them away [18:56:41] i think…. [18:56:43] ah right [18:56:53] Deskana: hehe [18:56:54] we gotto hold out horses with any more nightmode work [18:58:10] YuviPanda: hehe waving magic night mode wand… DONE! ;) [18:58:15] * tfinc imagines vbamba on a night mode horse [18:58:18] haha! [18:58:28] that could be our new mascot [18:58:32] right next to bronte [18:58:53] tfinc: yes, named bronte [18:59:23] a night mode horse named bronte, brilliant [18:59:24] Daryana, the Night Mode Horse. [19:00:20] * YuviPanda waves anti-silliness magic wand on channel [19:00:47] YuviPanda: You're silly for thinking that'll stop it. :p [19:00:52] … how the hell do i create a branch in gerrit? i see docs on how to push to one, but it’s not accepting it yet [19:01:05] YuviPanda: everyone (looking sharp, stop fooling around) [19:01:09] hehe [19:01:27] YuviPanda: you familiar with that particular hell? :D [19:01:34] brion: sadly, yes [19:01:38] brion: am finding the incantation [19:01:43] thankd :D [19:01:48] thanks even [19:02:09] brion: thankd sounds like a deamon now [19:02:15] lol [19:03:11] brion: 'git push gerrit gerrit/master:refs/heads/' [19:03:26] brion: and then, 'git push gerrit HEAD:refs/for/' [19:03:46] the worst part about these commands is that I know enough git internals to know what they mean :| [19:04:10] brion: and then you can just use the second command to keep submitting patches to the branch [19:04:15] brion: the first one is what 'creates' the branch [19:04:37] excellent [19:04:49] ok i think i have created, now lemme add stuff [19:06:00] ! [remote rejected] HEAD -> refs/for/v4.0.1 (no new changes) [19:06:01] wtf [19:06:02] YuviPanda: When's your flight? [19:06:07] Deskana: Monday [19:06:08] (03PS5) 10Dr0ptp4kt: Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 [19:06:10] Deskana: I arrive on Monday evening [19:06:24] bearND|food: ^^ there's the update on the variable name and with more comments [19:06:44] YuviPanda: Cool! I'll get to London at around 2pm on Tuesday, so if you're around the hotel then we should go for a pint. [19:06:56] YuviPanda: Or whisky! [19:06:59] Deskana: definitely! :) I probably will be around by then. [19:07:02] Deskana: indeed. [19:07:28] Deskana: when we meet, I think I'd have spent more time in the UK this year than you :P [19:09:43] $ git review -R v4.0.1 [19:09:44] No changes between HEAD and gerrit/v4.0.1. Submitting for review would [19:09:45] be pointless. [19:10:13] YuviPanda: Well I've only spent three weeks. [19:10:18] brion: pffft, git review is for chumps :P [19:10:24] YuviPanda: I left on 19th January. [19:10:29] Deskana: I've 4 :P [19:10:46] YuviPanda: Soon to be significantly more! [19:10:47] YuviPanda: same with git push gerrit HEAD:refs/for/v4.0.1 [19:10:49] just more verbose [19:11:04] brion: huh? it didn't end up pushing? [19:11:12] it claims “no new changes” which is …. false? [19:11:14] brion: well, do a 'git commit --amend', remove the Change-Id line, and try again? [19:11:25] hmmm [19:11:44] lemme make an empty commit [19:12:00] Deskana: indeed! at the current rate I'll have permanently beat you at 'spend time in the UK' for 2014! [19:12:15] (03PS1) 10Brion VIBBER: here, have a change gerrit [apps/ios/wikipedia] (v4.0.1) - 10https://gerrit.wikimedia.org/r/151146 [19:12:18] yay [19:12:21] YuviPanda: I'd say that's a given. After Wikimania I have no firm date to return. [19:12:35] Deskana: heh. [19:12:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] here, have a change gerrit [apps/ios/wikipedia] (v4.0.1) - 10https://gerrit.wikimedia.org/r/151146 (owner: 10Brion VIBBER) [19:12:44] YuviPanda: It's a bit strange, actually. The entire time I've been in the US I've had "Well I'm going back in August" in the back of my mind. [19:12:47] weird [19:12:54] ok lemme rebase some more fixes on [19:13:01] YuviPanda: After this, when I'm on the plane back, that's it! No more confirmed travel. I have no idea when I'd next be back. [19:13:23] Deskana: :D yeah, in a way that's true for me too in the exact same way. I'll probably go back at some point again, though [19:14:11] hrm can i cherry-pick a merge commit? [19:14:26] ah, gerrit and merge commits [19:14:31] * YuviPanda has never gone there, and hopefully never will [19:14:35] haha [19:14:41] i’ll be careful :D [19:15:01] brion: it's dangerous to go alone! [19:15:03] YuviPanda: I don't think I have a visa for that. [19:15:04] brion: here, take this! [19:15:06] * YuviPanda hands brion kitten [19:15:09] LD [19:15:20] YuviPanda: And I don't want one. The Embassy of Git isn't very kind to visitors. [19:15:36] Deskana: heh, I thought you didn't have a visa to go back to the UK and was confused [19:15:36] Maryana. Steven is a cheater. See: https://meta.wikimedia.org/wiki/File:Similarity.by_type.by_rank_bucket.svg [19:16:03] haha [19:16:22] Also, objective evidence that elastic search is useful for recommending articles to edit! Woo! [19:18:02] halfak: wait, so what are those graphs showing? [19:18:57] (03PS1) 10Brion VIBBER: Here hvae another update gerrit [apps/ios/wikipedia] (v4.0.1) - 10https://gerrit.wikimedia.org/r/151147 [19:19:00] They are showing how deep you can dig into elastic search's "More like this" results before they aren't really similar anymore. [19:19:20] ah [19:19:28] So, we generally agree that at rank 50, "More like this" results are still pretty similar (~75%). [19:19:44] (03CR) 10Brion VIBBER: [C: 032 V: 032] Here hvae another update gerrit [apps/ios/wikipedia] (v4.0.1) - 10https://gerrit.wikimedia.org/r/151147 (owner: 10Brion VIBBER) [19:19:44] (I hid the ranks from you when you were hand-coding so they wouldn't affect your judgement" [19:19:47] ) [19:19:48] i’m so confused :D [19:19:57] halfak: so why does steven's look so messed up? [19:20:20] did he answer 1 to all the similarity ranking questions? [19:20:42] (03CR) 10Deskana: "wow, such change" [apps/ios/wikipedia] (v4.0.1) - 10https://gerrit.wikimedia.org/r/151147 (owner: 10Brion VIBBER) [19:20:44] brion, we would like to recommend articles to edit to people. One strategy is to recommend similar topics. Elastic search has a "more like this" function. We manually checked to see how far into the search results you could go before it stopped working. [19:20:50] it doesn’t seem right [19:21:03] not sure what’s with this branching [19:21:27] dbrant: How is the day looking for you? [19:21:44] I think that either (1) Steven is incredibly worldly and he can understand the similarity between articles by just looking at their title or (2) steven looked at the text when he wasn't supposed to. [19:21:47] Shd we do copy fixes and color updates to page issues/ Dismabiguation on Monday? [19:22:06] title = just looked at title and guessed at similarity [19:22:12] halfak: yeaahh, i'm gonna go with #2 on that [19:22:17] text = read the text and judge similarity again. [19:22:22] me too [19:22:24] 3MobileFrontend / 3stable: Mobile section redirects only redirect to tops of articles - 10https://bugzilla.wikimedia.org/69020 (10Pine) 3NEW p:3Unprio s:3major a:3None Searching for "Wikipedia Signpost" directs correctly to "Wikipedia Community" but not to the section "Media" in that article. I tried... [19:22:41] vbamba: whenever you like! us Android folks are a lot less busy than the iOS guys right now [19:24:20] (03PS1) 10Brion VIBBER: Branch for v4.0? [apps/ios/wikipedia] (v4.0) - 10https://gerrit.wikimedia.org/r/151151 [19:24:34] (03CR) 10Brion VIBBER: [C: 032 V: 032] Branch for v4.0? [apps/ios/wikipedia] (v4.0) - 10https://gerrit.wikimedia.org/r/151151 (owner: 10Brion VIBBER) [19:25:36] 3MobileFrontend / 3stable: Mobile section redirects only redirect to tops of articles - 10https://bugzilla.wikimedia.org/69020#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/DuzTGlb7 [19:26:52] vbamba: do you want to do a hangout? [19:27:20] dbrant: Lets do it! I sent you an invite :) [19:28:02] brion: hangout in a few minutes? [19:28:31] vbamba: any chance it could be (much) earlier? That's well into dinner time for me ;) [19:31:01] (03PS1) 10Brion VIBBER: another branch test? [apps/ios/wikipedia] (v4.0.1-rc) - 10https://gerrit.wikimedia.org/r/151153 [19:31:15] (03CR) 10Brion VIBBER: [C: 032 V: 032] another branch test? [apps/ios/wikipedia] (v4.0.1-rc) - 10https://gerrit.wikimedia.org/r/151153 (owner: 10Brion VIBBER) [19:31:55] mhurd: ? [19:32:08] brion: just to save some typing :) [19:32:23] “Could not create a merge commit during the cherry pick” wtf [19:32:50] brion: how about i just comment out the hook to references? [19:33:04] brion: so it just jumps [19:33:20] will that keep the additional items from being in the window as well? [19:33:30] the patch i just finished does [19:34:28] brion: it only loads the references view controller lazily [19:34:38] brion: confirmed deallocs are happening now too [19:34:59] (03PS1) 10Brion VIBBER: Cherry-pick: More fixes related to the random crash fix. [apps/ios/wikipedia] (v4.0.1-rc) - 10https://gerrit.wikimedia.org/r/151183 [19:35:07] i can modify it to comment out the hook, then should be good [19:35:11] brion: ^ [19:35:29] brion: will make our lives easier :) [19:35:32] (03CR) 10Brion VIBBER: [C: 032 V: 032] Cherry-pick: More fixes related to the random crash fix. [apps/ios/wikipedia] (v4.0.1-rc) - 10https://gerrit.wikimedia.org/r/151183 (owner: 10Brion VIBBER) [19:35:52] fucking gerrit [19:35:58] mhurd: yeah let’s do that [19:36:04] brion: 5 minutes [19:36:22] brion: diabling the hook... [19:36:28] vbamba: any chance it could be (much) earlier? That's well into dinner time for me ;) [19:37:49] Deskana, tfinc: so branching in gerrit is being …… unpleasant …. but we can leave the new code in and just disable it, it should behave the same as before with little danger :) [19:37:52] dbrant: bearND|food just confirmed https://gerrit.wikimedia.org/r/#/c/151110/ to work as expected [19:38:07] since we’re keeping all the other bug fixes [19:38:10] YuviPanda: nice! [19:38:29] * tfinc shakes first at gerrit [19:38:33] fist* [19:38:51] yeah i managed to create a branch but i can only cherry-pick things manually, not through the web ui [19:38:57] something seems off :P [19:38:57] brion: If it's disabled then as there's no user-facing difference, I defer to you as an engineering decision. :) [19:39:01] ok :D [19:39:46] brion: just about done... [19:40:11] brion: Does this include the guard for the last-modified bug? [19:40:45] dbrant: yes absolutely sir. apologies - wouldnt want to keep you from dinner [19:41:18] Deskana: yes [19:41:24] that’s the most important one :D [19:42:03] brion: Good, just checking. :) [19:48:23] (03PS1) 10Mhurd: Made refs panel lazy loaded. Disabled refs js hook for now. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151198 [19:48:27] brion: ^ [19:49:06] woot [19:51:19] dbrant: bearND|food do CR / merge the EL patch when you've the time. sorry it got so delayed. [19:52:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok, this should be safe to deploy and then we'll reactivate it on next TestFlight build :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151198 (owner: 10Mhurd) [19:52:47] brion: i updated the ether pad to not have refs line [19:53:03] brion: cut testflight? [19:53:25] brion: *ok for me to cut now?* [19:53:35] mhurd: go for it [19:53:51] (03PS1) 10Brion VIBBER: Made refs panel lazy loaded. Disabled refs js hook for now. [apps/ios/wikipedia] (v4.0.1-rc) - 10https://gerrit.wikimedia.org/r/151200 [19:54:00] oh NOW that button works. [19:54:00] wtf? [19:54:09] lol [19:54:12] (03CR) 10Brion VIBBER: [C: 032 V: 032] Made refs panel lazy loaded. Disabled refs js hook for now. [apps/ios/wikipedia] (v4.0.1-rc) - 10https://gerrit.wikimedia.org/r/151200 (owner: 10Brion VIBBER) [19:55:03] eh i don’t trust it. i’ll make a new branch :D [19:55:11] hehe [19:55:42] brion: should i wait? [19:55:59] mhurd: no, go for it [19:56:03] brion: k [19:56:08] i’ll set up the apple biuld at the same time :D [19:57:42] (03PS1) 10Brion VIBBER: v4.0.1-rc branch point (hopefully not broken) [apps/ios/wikipedia] (v4.0.1-rc-nonbroken) - 10https://gerrit.wikimedia.org/r/151202 [19:58:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] "ok think this is ok. branch point commit switches from testing to production signing id." [apps/ios/wikipedia] (v4.0.1-rc-nonbroken) - 10https://gerrit.wikimedia.org/r/151202 (owner: 10Brion VIBBER) [20:04:51] oh man i hate it when the progress bar on “your application is being uploaded” just sorta sticks for a while [20:05:04] it’s 4.7 megabytes! how long can it take to uploaddddd [20:05:41] kaldari: i'm in r33 whenever your ready [20:05:57] ok hopefully received :D [20:06:06] ‘Status Upload Received’ is a good sign [20:07:11] brion: testflight build cut too :) [20:08:35] tfinc: Deskana ^ [20:08:38] \o/ [20:08:46] wooo [20:13:31] testing 4.0.1… [20:13:40] ‘The status for the following app has changed to Waiting For Review.’ [20:21:25] brion: is latest gerrit branch ok to work with? [20:21:30] *commit* [20:21:52] mhurd: yeah master branch should be exactly the same as my v4.0.1-rc-nonbroken except for the code signing switch [20:22:05] so you can add new stuff on that [20:22:15] and we’ll still hvae the branch to work with if we need to make another incremental update [20:23:36] brion: perfect! [20:26:48] (03CR) 10Dbrant: [C: 032] "works for me!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151110 (owner: 10Yuvipanda) [20:27:18] dbrant: wo00t [20:27:31] Deskana: tfinc all estimated cards in the current sprint are ready for signoff [20:29:21] (03PS1) 10Dr0ptp4kt: Make Hogan template explicit [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/151206 [20:29:44] dbrant: looked at the today icon [20:30:48] it needs to be optically bigger - It may be the same size as the history circle (but it looks smaller cos it has strokes on the outer edge) [20:31:06] should we chat really quick about how to do this? [20:31:20] vbamba: yep! [20:39:40] running some quick errands, be back in a bit [20:41:59] tfinc: oh can i hit you back w square for lunch? [20:49:14] vbamba: I can easily increase the size of the Today icon. I had a similar feeling that it appeared a bit small. [20:49:25] later all! off to planes and such [20:49:46] safe travels! [20:51:10] 3Wikipedia App / 3iOS App: Temporal range in taxobox messed up in iOS 7.1.2 - 10https://bugzilla.wikimedia.org/69025 (10Kristen Lans) 3NEW p:3Unprio s:3minor a:3None Created attachment 16122 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16122&action=edit taxobox weirdness on animal page Go... [20:55:56] (03PS1) 10BearND: Refactor prepare release script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151217 [20:56:09] dr0ptp4kt: ^ [20:57:50] bearND: gotta go to a meeting, but after that will take a look [20:58:13] bearND: disconnecting for irc momentarily [21:06:55] (03CR) 10Jdlrobson: [C: 031] "assume you've tested locally? Looks good to me..." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/151206 (owner: 10Dr0ptp4kt) [21:07:32] (03CR) 10Dr0ptp4kt: "Worked on my rig, hopefully @Yurik can also verify." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/151206 (owner: 10Dr0ptp4kt) [21:23:52] dbrant|bbl, bearND, YuviPanda: Let's say I was using the original production release and then I updated to the version with onboarding. When I launch the app, do I see onboarding? [21:23:53] I do, right? [21:24:03] Deskana: you do [21:24:05] Deskana: once [21:26:27] Deskana: yes, you should see it once. If you want to see it again you can delete app data in the system settings [21:29:13] Thanks. [21:31:25] brion: going to be about 5min late [21:31:30] ok [21:55:36] dbrant|bbl: Guessing you are off - Let me know about the today icon, maybe the left nav icons are set in a diff canvas size? [21:56:02] dbrant|bbl: Our meeting is for Monday morning now. we can sort all the pending stuff out. [21:59:49] Maryana|bbl, do we want to disable basic reference (reference with no citation dialog) in mobile VE? [22:41:49] (03CR) 10Dr0ptp4kt: "See comments." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151217 (owner: 10BearND) [22:41:58] bearND: ^ on the meeting yet, but see that [22:45:39] (03CR) 10MaxSem: [C: 031] Make LeftNavEditTutorial no longer an A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150396 (owner: 10Kaldari) [22:45:46] jgonera: so... Flow, MobileFrontend and Echo are using our Makefile. Could/should we potentially move a lot of the developer tools into Mantle so we can share the same scripts? [22:46:11] jdlrobson, not sure how this would work [22:46:26] maybe just a separate tool repo that each project would include as a submodule? [22:46:45] I was thinking we'd set up a global which would point to Mantle so something like @MANTLE_DIR/dev-scripts/qunit.sh 'MobileFrontend&debug=true' in Makefile [22:46:46] I'm a little scared of submodules after VE, but this seems like a simpler use case ;) [22:46:55] jgonera: yeh that would be a good idea [22:47:03] much better than mine :) [22:47:16] i think in this case since the tool is used for development purposes it wouldn't be such a nightmare [22:47:27] yeah, seems like it's gonna be easier [22:47:53] it also doesn't change nearly as often as VE core [22:48:58] jgonera: raised a bug so we can track [22:49:07] cool, CC me [22:49:21] jgonera have done :) [22:49:24] thanks [22:50:01] Maryana, do we want to disable basic reference (reference with no citation dialog) in mobile VE? [22:50:20] (03CR) 10BearND: Refactor prepare release script (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151217 (owner: 10BearND) [22:50:27] jgonera: Yes please [22:50:31] dr0ptp4kt: ^^ [22:50:34] ok, will try [22:50:37] It seems to cause a ton of problems [22:50:49] According to Rummana [22:51:59] jgonera: thanks :) I think Rummana filed a bug on it, but it probably hasn't been Bugelloed yet [22:52:10] Maryana, yes, she did [22:52:43] I just remember that at some point we wanted that dialog, but I guess we never properly addressed all the issues related to it [22:53:15] Yeah, it opens up into a crazy non mobile friendly thing that breaks [22:53:37] And that template is all over the place on WP [22:54:49] (03PS6) 10BearND: Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 (owner: 10Dr0ptp4kt) [22:55:09] just a rebase [23:14:37] (03PS7) 10BearND: Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 (owner: 10Dr0ptp4kt) [23:14:59] Maryana|bbl: hey! [23:17:28] (03CR) 10BearND: "just added more tests," [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 (owner: 10Dr0ptp4kt) [23:17:55] (03CR) 10MaxSem: [C: 04-1] Enable View of "new messages on talk page" without Echo (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [23:18:21] dr0ptp4kt: go through my changes and let me know if it all looks good, or if you'd like to change something, e.g. add more tests, too [23:18:57] bearND: on the git tag, do we need to call git tag -a -m manually between steps 1 and 2? i didn't see git_tag(target) being called, so i was wondering if the call need to be made from step 2's push_git_tag? ... also, we'd need to have the documentation updated at the top so that git describe is called at the right time [23:19:03] bearND: will take a look at that thing [23:19:11] that language variant thing, that is :) [23:19:54] dr0ptp4kt: I feel much better about the zh lang variant code after the walkthrough with you [23:20:15] (03CR) 10MaxSem: "Ugh, I hate globals..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150636 (https://bugzilla.wikimedia.org/63428) (owner: 10Jdlrobson) [23:20:16] dr0ptp4kt: step 1 should call it [23:20:18] bearND: good! it was fun! [23:20:45] bearND, okay, want me to just update the build script to reinstate that call at the end of step 1's make_release? [23:21:27] (03CR) 10MaxSem: "I would be much more confident about this change if it had tests..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [23:22:03] dr0ptp4kt: good catch. I didn't mean to remove that [23:22:14] dr0ptp4kt: i'll amend [23:22:18] (03CR) 10MaxSem: [C: 032] Remove two old modules kept for HTML backwards-compatibility [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150581 (owner: 10Bartosz Dziewoński) [23:22:19] bearND: cool [23:22:58] (03Merged) 10jenkins-bot: Remove two old modules kept for HTML backwards-compatibility [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150581 (owner: 10Bartosz Dziewoński) [23:23:08] (03PS2) 10BearND: Refactor prepare release script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151217 [23:23:51] dr0ptp4kt: ^ the tag creation call is back [23:27:57] (03CR) 10Dr0ptp4kt: [C: 032] Refactor prepare release script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151217 (owner: 10BearND) [23:28:08] dr0ptp4kt: thanks [23:28:16] dr0ptp4kt: back to the Chinese language variant. I tested it with your latest patch set and I got the correct variant to show up in the webView as far as I can see. :) [23:28:29] bearND: excellent. [23:29:06] just let me know when you've reviewed the minor changes I made to it and i'll +2 then [23:29:11] dr0ptp4kt: ^^ [23:29:17] bearND: i like that we have a new language variant called "test" ;) [23:29:36] bearND: no change needed there, to be clear. just having a good chuckle [23:29:54] dr0ptp4kt: it's the test wikipedia site [23:30:18] bearND: i know :) we should make that use esperanto. wait, there's an esperanto wikipedia, too! [23:30:57] bearND: just pulling out the 4.3 and 2.3 devices here to run the tests [23:31:04] (03PS1) 10Kaldari: Hygiene: Fixing formatting of Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151251 [23:39:23] brion: finally at the gate :) [23:39:41] mhurd: cheerio, have a good flight! [23:39:44] i’ll see ya monday :D [23:40:01] (03PS2) 10Kaldari: Hygiene: Fixing formatting of Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151251 [23:40:13] brion: sounds good! no bug reports from testflight? [23:40:13] or sunday [23:40:21] mhurd: not that i’ve seen yet [23:40:24] :) [23:40:54] brion: i’m gonna see if my itunesconnect credentials will let me download crash reports [23:41:30] whee crashes [23:41:47] mhurd: there’s also some ios 8 crashes, looks like some autolayout stuff [23:41:58] fun :D [23:42:03] brion: hehe ya :) [23:42:46] brion: at least those are less mysterious than core data - will play with the workerContext stuff a bit too... [23:42:52] yeah :D [23:43:06] so far all the crash reports on 7.1 are that dictionary one in the downloadsectionsop [23:43:09] might have more tomorrow [23:44:05] brion: grr i cant see the crash reports :( [23:45:32] how… convenient :P :) [23:45:47] mhurd: i’ll stick the 7.1 ones up on Drive and share it to ya [23:45:55] brion: yay! [23:45:57] thanks! [23:48:29] mhurd: ok shared [23:48:45] brion: awesome! thanks! [23:50:09] brion: before when i’d sign in to the apple dev site it would ask me which team i was wanting to look at. doesn’t seem to do so any more [23:50:24] jgonera: you around? [23:51:35] weird [23:51:53] brion: not sure what i did differently this time, but now it worked. only problem is i don’t have the itunes connect item when i pick wikimedia team [23:52:16] brion: that whole team agent business? [23:52:29] it’s bullshit, yo [23:52:43] brion: heh, it's been more than 11 years since your first mediawiki commit on svn! [23:52:43] * YuviPanda is just digging through things [23:52:47] it’s THE MAN keeping us down :D [23:52:52] agh time flies [23:53:05] that’s almost 1/3 of my life [23:53:28] whoa! :) [23:53:35] brion: ;d [23:53:44] brion: it was: [23:53:46] ' Fix typo' [23:53:47] :) [23:53:53] brion: THE (apple) MAN is really on my shit list this week [23:54:37] blllaaaarrrrghghhghghhh! [23:58:18] bearND: execution of the test against a 2.3 device threw an NPE when i let it run without debugging. but it was fine when i ran it in debug mode; i think the device was too slow or something. on the 4.3 device no NPE when i ran the test (non-debugging mode). good enough, i think. [23:58:59] dr0ptp4kt: would you send me the stack trace? [23:59:10] bearND: lemme see if i can reproduce [23:59:18] jdlrobson: https://gerrit.wikimedia.org/r/#/c/145185/ [23:59:23] dr0ptp4kt: you should have it in logcat [23:59:56] dr0ptp4kt: do you have Chinese on your 2.3 device? I only have English and Spanish