[00:01:07] <grrrit-wm>	 (03CR) 10Ebe123: [C: 031] "Tested, and it worked. Just wish Florian didn't tell me that only one line had to be modified." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150592 (https://bugzilla.wikimedia.org/68775) (owner: 10Florianschmidtwelzow)
[00:01:37] <dr0ptp4kt>	 bearND, yeah that 2.3 device has multiple chinese dialects
[00:01:40] <grrrit-wm>	 (03CR) 10Jdlrobson: Improve fixed header in overlays on iOS (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/145185 (https://bugzilla.wikimedia.org/67390) (owner: 10JGonera)
[00:01:59] <vbamba>	 Maryana:  Hey! Safe Travels! I have Stuff to show you when you are back!
[00:02:09] <dr0ptp4kt>	 bearND: stack trace from 2.3 when not stepping through it slowly with debugger
[00:02:11] <dr0ptp4kt>	 https://gist.github.com/anonymous/5e0484fd491b5b14e25c
[00:02:44] <mhurd>	 brion: hey how did you tease out that date key from the crash report?
[00:03:02] <bearND>	 dr0ptp4kt: oh, in the test only
[00:03:30] <bearND>	 dr0ptp4kt: I probably should bring your runinUiThread back
[00:03:49] <bearND>	 dr0ptp4kt: thought it wasn't necessary
[00:05:33] <dr0ptp4kt>	 bearND: want me to handle it?
[00:05:49] <dr0ptp4kt>	 bearND: or you on it already?
[00:05:55] <bearND>	 dr0ptp4kt: either way is fine with me
[00:06:03] <dr0ptp4kt>	 bearND, lemme give it a quick spin
[00:06:19] <bearND>	 dr0ptp4kt: ok
[00:06:47] <Maryana>	 vbamba: oh yeah? what kind of stuff?
[00:07:08] <bearND>	 dr0ptp4kt: have you tested running the app on your 2.3 device and playing around with changing languages?
[00:07:29] <dr0ptp4kt>	 bearND, a little
[00:07:39] <mhurd>	 brion: nvmd, found the sybolication steps
[00:07:51] <dr0ptp4kt>	 bearND, i'll try a few other variations
[00:07:52] <mhurd>	 *symbolication*
[00:09:18] <grrrit-wm>	 (03PS1) 10Kaldari: Removing iOS momentum scrolling w/ hack in overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151257 
[00:13:57] <Maryana>	 kaldari: oh, so it was the smooth scrolling stuff that was causing the weird search results on ios?
[00:14:56] <brion>	 heh
[00:15:02] <brion>	 yeah i had some troubles resymbolicating
[00:15:23] <brion>	 was able to guess that *something* was null but couldn’t tell which op it was in until i got the symbols
[00:15:26] <mhurd>	 brion: ya i think i need the exact binary you submitted for it to resymbolicate
[00:15:50] <brion>	 mhurd: i actually had to rebuild it to get it to work!
[00:16:03] <mhurd>	 brion: rly?
[00:16:21] <brion>	 mhurd: git checkout gerrit/v4.0 <- and archive that, it should start showing up in the symbols in xcode
[00:16:27] <brion>	 at least that’s how it worked for me :P
[00:16:36] <mhurd>	 brion: ah cool! will try
[00:16:37] <brion>	 having the ACTUAL BINARY I SUBMITTED in archives it still didn’t pick it up :P
[00:16:44] <mhurd>	 ? weird
[00:16:46] <brion>	 i think it actually searches derived data rather than archives :P
[00:16:50] <brion>	 and we clear derived data a lot :D
[00:18:24] <mhurd>	 brion: archiving now...
[00:20:59] <mhurd>	 brion: so i checked out gerrit/v4.0, then archived… then i imported the crash reports in organizer’s device logs…
[00:21:19] <mhurd>	 brion: did i miss a step?
[00:21:34] <brion>	 mhurd: tried pushing the ‘resymbolicate’ button ?
[00:21:38] <brion>	 if that don’t do it… i dunno :(
[00:21:48] <brion>	 but lemme upload the dist binary in that folder just in case it helps you
[00:22:25] <mhurd>	 brion: oh do i have to pick the same provisioning settings before archiving?
[00:22:47] <brion>	 hmm, i don’t think that matters
[00:23:28] <brion>	 mhurd: ok i dropped a .zip of the .xcarchive of the 4.0 submitted binary in the same folder
[00:23:31] <mhurd>	 brion: trying clearing derived data then archiving
[00:23:38] <mhurd>	 brion: ah cool will try that too
[00:24:02] <mhurd>	 brion: oh where would i drop that file?
[00:25:33] <dr0ptp4kt>	 bearND, huh. so it thinks app is null. i actually went back to ps6 just for giggles to see if i'd hit an NPE, and i did.
[00:25:47] <brion>	 mhurd: i think you can just drop it into xcode, or into the organizer window?
[00:25:56] <brion>	 or else… find the dir where it holds other archives :D
[00:26:07] <mhurd>	 brion: k
[00:28:09] <bearND>	 dr0ptp4kt: hmm, weird. The runTestOnUiThread call should have fixed it. I added it back and tried on my 2.3 device and it fixed it for me.
[00:28:27] <bearND>	 dr0ptp4kt: would you like me to upload?
[00:28:30] <dr0ptp4kt>	 bearND: you wanna submit that patch?
[00:28:32] <dr0ptp4kt>	 bearND, yeah
[00:28:55] <bearND>	 dr0ptp4kt: yes
[00:29:19] <grrrit-wm>	 (03PS8) 10BearND: Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 (owner: 10Dr0ptp4kt)
[00:30:06] <mhurd>	 brion: that did it! i just had to double click on that xcarchive and it added it to the list of builds in organizer
[00:30:17] <brion>	 \o/
[00:31:04] <bearND>	 dr0ptp4kt: oops, i take it back. now I'm getting the NPE as well
[00:33:48] <mhurd>	 brion: in “(DownloadSectionsOp.m:147)” is 147 the line number?
[00:36:01] <mhurd>	 brion: if so, line 147 is what all these crashes report… 
[00:37:01] <grrrit-wm>	 (03PS9) 10BearND: Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 (owner: 10Dr0ptp4kt)
[00:37:03] <bearND>	 dr0ptp4kt: ^ should do it: had to start the activity befor trying to get the app, doh
[00:41:41] <dr0ptp4kt>	 bearND, blargh, same npe on my 2.3. ou?
[00:45:41] <mhurd>	 brion: ok i think i have another fix for that section op
[00:49:00] <bearND>	 dr0ptp4kt: trying a few more things...
[00:49:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Refactor prepare release script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151217 (owner: 10BearND)
[00:49:22] <bearND>	 wow looks like jenkins just woke up
[00:49:45] <grrrit-wm>	 (03PS10) 10BearND: Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 (owner: 10Dr0ptp4kt)
[00:50:09] <bearND>	 dr0ptp4kt: ^ now I moved getting app into run()
[00:50:11] <dr0ptp4kt>	 bearND: i'll check that. just sent a screenshot to demonstrate the glyph difference on the 2.3 device. looking alright there.
[00:50:39] <grrrit-wm>	 (03PS1) 10Mhurd: Null protection for section op. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151259 
[00:50:50] <mhurd>	 brion: ^ quick patch
[00:50:51] <brion>	 mhurd: yeah it’s the opening of the @{
[00:50:54] <brion>	 whee
[00:51:27] <dr0ptp4kt>	 bearND: you gotta be kidding me
[00:51:35] <dr0ptp4kt>	 bearND: test passes on both 2.3 and 4.3
[00:51:37] <mhurd>	 brion: i think these were the only 2 cases which could still fall through to the @{ with nil vals
[00:51:47] <bearND>	 dr0ptp4kt: thanks for the screen shots. it looks mirrored, like RTL
[00:52:00] <brion>	 mhurd: better safe than sorry :)
[00:52:28] <mhurd>	 brion: ya. the isNull is ‘cause the json objects can return null instead of nil
[00:52:30] <mhurd>	 iirc
[00:52:50] <brion>	 mhurd: yeah but an NSNull is ok to store in the dictionary…. but it might cause explosions later so yeah, safer :D
[00:52:52] <bearND>	 dr0ptp4kt: did you know that IntelliJ has a screenshot feature in the Android tab on the left hand side, the first icon does screen shots, the one underneath does videos (for kitkat+)
[00:52:54] <mhurd>	 brion: we can make a better method for doing this later :)
[00:52:58] <brion>	 yep
[00:53:18] <mhurd>	 brion: wanna update the binary?
[00:53:22] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "Better safe than sorry. :)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151259 (owner: 10Mhurd)
[00:53:29] <brion>	 sure
[00:53:37] <dr0ptp4kt>	 bearND, i think i read that somewhere. maybe from you! that's pretty cool
[00:53:54] <mhurd>	 brion: yay!
[00:54:38] <dr0ptp4kt>	 bearND, i took that picture using a selfie app, that's why the flippy
[00:54:53] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Null protection for section op. [apps/ios/wikipedia] (v4.0.1-rc-nonbroken) - 10https://gerrit.wikimedia.org/r/151260 
[00:54:54] <dr0ptp4kt>	 bearND: that's actually sort of silly, not sure why they do that
[00:55:00] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Null protection for section op. [apps/ios/wikipedia] (v4.0.1-rc-nonbroken) - 10https://gerrit.wikimedia.org/r/151260 (owner: 10Brion VIBBER)
[00:55:05] <mhurd>	 brion: should i cut another testflight? nothing better to do :)
[00:55:11] <brion>	 mhurd: sure :D
[00:55:13] <mhurd>	 brion: k
[00:55:34] <dr0ptp4kt>	 bearND: i guess it's not that strange...they're trying to mirror you i guess
[00:55:56] <bearND>	 dr0ptp4kt: that's cool.
[00:56:04] <mhurd>	 brion: when you cut release build would you mind dropping that xcdata whatever file into the shared folder again?
[00:56:09] <brion>	 ya
[00:56:13] <mhurd>	 cool
[00:58:01] <dr0ptp4kt>	 bearND, sending you the 4.3 screenshots shortly. it seems like it's all working!
[00:58:39] <brion>	 Status  Upload Received
[00:59:16] <brion>	 mhurd: ….and uploaded into the shared folder
[00:59:34] <mhurd>	 brion: nice!! cutting testflight now
[00:59:39] <brion>	 woot
[00:59:46] <brion>	 this is so much smoother than that first upload a couple weeks ago ;)
[01:02:02] <bearND>	 dr0ptp4kt: perfect. do the tests with the last patch set work for you now as well? or are you still getting the NPE?
[01:02:30] <dr0ptp4kt>	 bearND: it passes on both 2.3 and and 4.3 for me
[01:02:59] <dr0ptp4kt>	 no more npe
[01:03:08] <bearND>	 dr0ptp4kt: yeah!!
[01:03:32] <grrrit-wm>	 (03PS11) 10BearND: Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 (owner: 10Dr0ptp4kt)
[01:03:58] <grrrit-wm>	 (03CR) 10BearND: [C: 032] Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 (owner: 10Dr0ptp4kt)
[01:04:09] <dr0ptp4kt>	 bearND: yeeeeeeeeeehaw
[01:04:12] <bearND>	 dr0ptp4kt: w00t!
[01:04:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Support language variants on Chinese Wikipedia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150459 (owner: 10Dr0ptp4kt)
[01:04:42] <dr0ptp4kt>	 bearND: thank you for all of the help!
[01:05:22] <bearND>	 dr0ptp4kt: no, thank you. I wanted to get this feature in as well
[01:05:40] <bearND>	 dr0ptp4kt: this will make a lot of users happy
[01:06:32] <dr0ptp4kt>	 bearND, thanks again, seriously. i'm going to wrap up unless you need anything else from me...
[01:06:43] <dr0ptp4kt>	 bearND: also, thanks for staying late on a friday
[01:08:08] <bearND>	 dr0ptp4kt: yes, that's a wrap :)
[01:08:24] <dr0ptp4kt>	 bearND: alright! goodnight and have a good weekend
[01:09:17] <bearND>	 dr0ptp4kt: good night to you, too. have a great weekend!
[01:18:44] <mhurd>	 brion: i’m knocking out these crashes :) may have another patch :)
[01:23:05] <brion>	 awesome :D
[01:25:22] <mhurd>	 brion: experimenting with using just that main core data context instead of the worker one
[01:28:22] <grrrit-wm>	 (03PS1) 10Mhurd: Quick experiment for iOS 6. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151261 
[01:28:25] <brion>	 ah nice
[01:28:36] <brion>	 catch ya later — see you in the uk!
[01:28:40] <mhurd>	 brion: mind testing this on ios 6^
[01:29:56] <grrrit-wm>	 (03CR) 10Mhurd: "Brion if you could test this on an iOS 6 device that would be great. I know the old devices seemed more randomly crashy - hoping this addr" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151261 (owner: 10Mhurd)
[01:47:27] <grrrit-wm>	 (03CR) 10Mhurd: "A good test would be browsing to a variety of pages then hitting back-forward buttons rapidly." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151261 (owner: 10Mhurd)
[08:44:22] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: "> Just wish Florian didn't tell me that only one line had to be modified." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150592 (https://bugzilla.wikimedia.org/68775) (owner: 10Florianschmidtwelzow)
[13:03:56] <grrrit-wm>	 (03PS1) 10Dbrant: Make the "Today" icon a bit larger. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151287 
[22:04:33] <grrrit-wm>	 (03PS14) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) 
[22:04:41] <grrrit-wm>	 (03PS15) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834)