[00:02:02] (03CR) 10JGonera: [C: 04-1] "A few comments inline." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [00:02:28] (03CR) 10JGonera: "Also, thank you for working on this ;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [00:14:18] (03PS1) 10BearND: Remove old Chinese default language variant [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153548 (https://bugzilla.wikimedia.org/69304) [00:14:22] (03PS1) 10BearND: Link default and HK Chinese language variant [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153549 (https://bugzilla.wikimedia.org/69304) [04:35:53] 3Wikipedia App / 3iOS App: There is no way to refresh saved pages in the iOS app - 10https://bugzilla.wikimedia.org/69403#c2 (10Brion Vibber) Note that individual pages can be refreshed on the article display once loaded via the pull-to-refresh idiom. The bulk refresh operation is still in the works. [04:39:23] 3Wikipedia App / 3Android App: allow somehow marking links in Wikipedia app for later reading - 10https://bugzilla.wikimedia.org/69400#c2 (10Brion Vibber) (Yeah, the iOS 'Add to Reading List' is from the system-provided long-press menu and puts it into an offline reading list in Safari. Replacing it with a c... [04:49:17] (03PS3) 10BearND: Put 'action' before 'format' on API parameters to fix app indexing [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/147134 (owner: 10Brion VIBBER) [04:50:07] (03CR) 10BearND: "Needed to use a LinkedHasMap to keep insertion order." [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/147134 (owner: 10Brion VIBBER) [04:50:38] (03CR) 10Brion VIBBER: "Aho! Test cases save the day again :D" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/147134 (owner: 10Brion VIBBER) [04:50:47] thanks bearND|bbl :D [04:51:07] :) [04:54:26] i’m so spoiled by php’s magic assoc arrays with their guaranteed order :D [04:55:50] brion: Java has that feature, too, but you need to ask for it specifically, hehe [04:56:08] java makes you ask for everything. often several times in a row :D [09:47:03] (03PS2) 10Nikerabbit: Fix typo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153269 (owner: 10Florianschmidtwelzow) [09:47:17] (03CR) 10Nikerabbit: [C: 032] Fix typo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153269 (owner: 10Florianschmidtwelzow) [09:47:49] (03Merged) 10jenkins-bot: Fix typo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153269 (owner: 10Florianschmidtwelzow) [11:04:55] (03PS21) 10Mhurd: Nearby entry in main menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153071 [11:12:24] (03CR) 10Mhurd: "Improved the location services error message reporting to be instructional. Now explains how to re-enable location services if you'd previ" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153071 (owner: 10Mhurd) [12:00:49] (03PS22) 10Mhurd: Nearby entry in main menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153071 [12:28:54] mhurd: Fast releases. :P [12:29:17] sjoerddebruin: hehe yeah. that last one had a bug :) [12:29:39] When can I translate the nearby stuff btw? [12:33:26] sjoerddebruin: oh that would be awesome! as soon as it’s merged it should be available in translate wiki. it may be a few days though as lots of people are traveling presently… [12:33:52] Looking every day. :) [12:36:07] sjoerddebruin: that’s great! thanks so much! [12:37:14] sjoerddebruin: i have to run. more updates soon! [12:37:23] Okay. :) [13:07:27] (03CR) 10Dbrant: [C: 032] "excellent!" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/147134 (owner: 10Brion VIBBER) [13:08:41] (03CR) 10Dbrant: [V: 032] Put 'action' before 'format' on API parameters to fix app indexing [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/147134 (owner: 10Brion VIBBER) [13:16:26] hey dbrant [13:16:35] hello! [13:16:47] dbrant: the packages weren't installed on a few machines, but that should be resolved now as well [13:17:03] very nice [13:23:02] dbrant: let me know what part of the Release Management stuff I can help with [13:26:03] yuvipanda: well, since you ask... ;) how hard would it be to create a simple web page for submitting a Gerrit url to be built? [13:26:37] dbrant: ah, not very hard, once we have the build script running in the job queue [13:27:01] dbrant: I can take that up, yeah. we'll have to whitelist, though, so only patches from people in the whitelist get built [13:27:07] since otherwise it's arbit code execution [13:27:16] yep, definitely [13:29:49] dbrant: do we have builds working now? [13:29:53] * yuvipanda should catch up [13:31:48] yuvipanda: I haven't checked whether the build works when submitted on the grid... I should try it now [13:31:55] wooo cool [13:56:26] yuvipanda: I'm still getting out-of-memory errors (when submitting to the grid)... I've tried several different _JAVA_OPTIONS... [13:56:42] dbrant: have you tried a -mem 4G option to jsub? [13:56:53] I hope building doesn't take more than 4G of RAM [13:57:09] yuvipanda: let's see, it's set to 2g now, I'll try with 4g... [14:04:03] yuvipanda: now I get the following: " No compiler is provided in this environment. Perhaps you are running on a JRE rather than a JDK?" [14:04:10] awww, damn [14:04:21] dbrant: no JDK in exec_environ! [14:04:22] dbrant: let me fix [14:04:26] lol [14:06:20] dbrant: https://gerrit.wikimedia.org/r/#/c/153600/ [14:06:28] dbrant: but let me manually install it on the nodes in the meantime [14:13:02] dbrant: try now [14:24:00] yuvipanda: doesn't show any more errors, but now it doesn't get past the "dex" step. It just exits without any more output. (probably memory related?) [14:25:04] dbrant: nothing in the .err files? [14:25:11] yuvipanda: nope [14:25:16] dbrant: try 'qstat' it should tell you what happened, Ithink [14:25:24] dbrant: what was the tool name again? [14:26:10] yuvipanda: tools.wikipedia-android-builds [14:26:32] dbrant: hmm, I see runbuild is still running [14:26:42] yuvipanda: I just tried it again [14:26:45] dbrant: ah ok [14:27:05] yuvipanda: ...and it just succeeded. [14:27:12] dbrant: \o/ [14:27:26] lol.... but can it do it again? [14:27:33] dbrant: I see 'Picked up _JAVA_OPTIONS: -Xms256m -Xmx512m' [14:27:39] dbrant: we should probably increase those to 4G as well [14:27:52] I think rule of thumb for Java on Toollabs is to always give it 4G [14:43:56] yuvipanda: I've tried all kinds of permutations of -Xms and -Xmx, but it still either doesn't get past dex, or gives "insufficient memory for the JRE to continue". [14:44:05] dbrant: oh, even now? [14:44:25] yuvipanda: yep. is there a way to verify that the job is actually getting 4G? [14:44:36] dbrant: no, but it usually does [14:44:57] dbrant: you can run 'qstat', and it'll tell you which machine it's running on. you can then 'ssh ' from tools-login to ssh to that, and run top, etc to see [14:46:22] yuvipanda: I'll try that... Ideally I don't want to have to specify -Xms or -Xmx, since it works without those when running directly on tools-dev. [14:46:37] dbrant: hmm, right. and the exec hosts are actually bigger than tools-dev [14:46:44] (64G RAM and 8cores) [15:07:41] yuvipanda: analytics dashboard meeting? [15:08:02] dbrant: ogh, auhghg, TZ fucked up. coming [15:08:13] dbrant: sorry, moment, finding my headphones [15:14:19] (03PS1) 10Jdlrobson: WIP: Use Desktop Echo overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153615 [15:14:49] dbrant: bearND https://github.com/wikimedia/analytics-limn-mobile-data [15:14:53] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use Desktop Echo overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153615 (owner: 10Jdlrobson) [15:30:09] dbrant: bearND http://meta.wikimedia.org/wiki/Schema:ServerSideAccountCreation [15:30:45] dbrant: bearND https://www.mediawiki.org/wiki/Manual:Database_layout [15:33:05] dbrant: bearND http://www.fabfile.org/ [16:23:46] Deskana|Away: congrats on the degree yo [16:37:47] (03CR) 10Dbrant: [C: 032] Remove old Chinese default language variant [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153548 (https://bugzilla.wikimedia.org/69304) (owner: 10BearND) [16:38:11] (03CR) 10Dbrant: [C: 032] Link default and HK Chinese language variant [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153549 (https://bugzilla.wikimedia.org/69304) (owner: 10BearND) [17:03:44] (03CR) 10Nikerabbit: "I think we should do this on twn side with codemap. Symlinks have caused troubles before." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153549 (https://bugzilla.wikimedia.org/69304) (owner: 10BearND) [17:15:28] yuvipanda: thoughts about ^? I think values-iw is also just a symlink in our repo. [17:15:40] bearND: +1 to codemaps [17:15:47] bearND: although I'm unsure how to do them [17:15:49] on twn [17:16:11] yuvipanda: what about values-iw? [17:16:27] bearND: so with codemaps, twn will export it as values-iw instead of values-he [17:16:30] and that should be fine for us [17:17:07] yuvipanda: we'd have both he and iw then? [17:17:21] bearND: no, we'd just have -iw [17:17:25] bearND: we don't need -he [17:18:09] yuvipanda: hmm, i thought we wanted both. same fo zh [17:18:12] for [17:18:23] bearND: android only reads -iw, so -he is useless [17:18:43] yuvipanda: interesting [17:18:54] bearND: same for zh variants. we should just have the ones android reads [17:20:18] bearND: yuvipanda: slight subject change -- regarding a build for QRD Brasil, any objection to building from last week's tag? [17:20:23] yuvipanda: well, for zh I think Android reads all of them we currently have, plus some more that we let default to just -zh [17:20:36] bearND: I don't think android reads anything we have now? [17:20:44] dbrant: the prod tag? [17:21:12] bearND: either way, doing it at the source (translatewiki) would be the best, IMO [17:21:43] yuvipanda: yep [17:21:50] dbrant: go for it! [17:22:37] is there a sizeable Chinese population in Brazil that would benefit from these twn changes? [17:23:40] dbrant: There were a few new -es and -pt strings during the last TWN pull [17:25:03] dbrant: but the -pt strings are only changes of mainly one word ("save page"), so i guess that is not that critical [17:25:41] dbrant: I wouldn't worry about -zh for Brazil [17:46:14] yuvipanda: fyi, here is the codemap change brion made for zh: https://gerrit.wikimedia.org/r/#/c/153031/1/groups/Wikimedia/WikimediaMobile-android.yaml [17:46:40] yuvipanda: we could do the same for -he and -iw [17:46:46] bearND: yup! [17:48:09] yuvipanda: what did you mean earlier that Android doesn't read anything we have right now? [17:48:40] bearND: it doesn't read -he, and for chinese it just did something defaultish for -zh [17:51:16] yuvipanda: I think that really depends on the devices' ROM. Now with the new values I get different symbols if I switch between hans and hant [17:51:29] bearND: hmm, right. perhaps for zh, I haven't tested that [17:51:34] bearND: but for he I am sure it doesn't read them [17:52:01] (03CR) 10Jdlrobson: [C: 04-1] Make use of mw-ui-text-truncated instead of truncated-text (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151790 (owner: 10Jdlrobson) [18:35:42] (03PS23) 10Mhurd: Nearby entry in main menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153071 [18:39:59] yuvipanda: how "important" was brion's patch for Google indexing? i.e. should we expedite a production release to incorporate this change? [18:40:17] dbrant: I think we should roll that into tomorrow's, yeah. [18:40:38] dbrant: we have one tomorrow, right? it's low impact, and lets Google turn indexing back on [18:41:09] yuvipanda: it's supposed to be next week. but I would be inclined to release tomorrow anyway [18:41:23] dbrant: ah, right. I forgot every other week, and not every. [18:42:26] yuvipanda: alright, then we'll plan on a release tomorrow. [18:42:33] dbrant: \o/ cool [18:43:55] dbrant: I'll have to go off in about 17mins (8pm GMT+1 deadline every day, since I'm staying with my girlfriend for the next 2 months). Anything you'd want from me before that? [18:44:34] yuvipanda: hmm, don't think so. I'll play around with the dashboards some more, as well as the builds. [18:45:06] dbrant: \o/ cool [18:45:33] (03CR) 10Dduvall: QA: Refactoring browser tests (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [18:50:56] jgonera dunno if you noticed yet but looks like VE is available on m.mediawiki.org now :) [18:53:31] awjr, hah, will check later if it misbehaves [18:53:49] im excited to see it live!! [19:49:20] (03CR) 10JGonera: QA: Refactoring browser tests (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [19:54:11] (03CR) 10JGonera: [C: 04-1] "Thanks Brion. One doubt inline." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153543 (https://bugzilla.wikimedia.org/69414) (owner: 10Brion VIBBER) [20:09:42] bearND|food: ah yes, totally agreed (re. beta) [20:10:07] oops, forgot to change my nick, hehe [20:11:56] dbrant: I guess tomorrow we'll do beta first, then cherry pick your change to disable the experimental stuff, then prod, and the rest [20:14:20] bearND: sounds right... version bump -> beta release -> cherry-pick -> prod -> amazon / qbp [20:14:35] dbrant: yup [20:23:32] bearND: did you have a patch that modifies the appearance of page-issues/disambiguation as simple links (instead of buttons)? [20:23:49] it sounds like that's the direction it's going: https://trello.com/c/lADtYeQl [20:24:39] dbrant: I have not pushed one yet. If you'd like I can push what I have so far but it's hackish. [20:25:23] dbrant: I directly update bundle.js, and there probably would be an extra pipe symbol if there is only page issues but not disambig [20:25:28] (03PS1) 10Mhurd: Further protection against corrupting css on build and sync. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153696 [20:25:45] dbrant: the css changes need to get added to MobileApp ext [20:28:00] dbrant: there are new comments from Deskana|Away about 20 min. ago [20:28:46] bearND: yeah, that's what I was referring to. It's sounding like we want to go with links, not buttons. [20:32:00] (03PS24) 10Mhurd: Nearby entry in main menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153071 [20:39:24] bearND: sure, go ahead and push it, and then you or I can rearrange/dissect it. I just want to preserve the dimensions and styling that you've got so far. [20:39:50] dbrant: ok [20:42:41] (03PS1) 10BearND: Update MW Java API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153704 [20:43:28] (03PS1) 10BearND: tmp: PageIssues and Disambig without borders [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153705 [20:43:37] dbrant: ^ [20:43:38] (03CR) 10jenkins-bot: [V: 04-1] Update MW Java API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153704 (owner: 10BearND) [20:44:35] dbrant: for ^ I'll need to upload the new artifact to the Maven team repo [20:44:59] bearND: gotcha.. [20:58:13] bearND: dbrant hey guys! [20:58:24] hey mhurd! [20:58:25] hi, mhurd [21:03:09] (03PS2) 10BearND: Update MW Java API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153704 [21:03:22] (03CR) 10jenkins-bot: [V: 04-1] Update MW Java API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153704 (owner: 10BearND) [21:03:33] bearND: dbrant hey are you guys using the same “generator” query that mobile front end uses in its “SearchApi.js” file to get both query results and page thumbnail urls in a single query? [21:04:31] bearND: dbrant hey are you guys using the same “generator” query that mobile front end uses in its “SearchApi.js” file to get both query results and page thumbnail urls in a single query? [21:04:46] mhurd: actually no! I was just looking at that... [21:04:54] bearND: dbrant (my connection is flaking out haha) [21:05:50] dbrant: cool! i think i may give it a go tomorrow on ios… fewer requests are good :) [21:06:12] mhurd: we're using opensearch, which just gives a list of titles. I would be *all* for switching to the generator query!! [21:06:42] +1 [21:06:53] dbrant: iirc max said the gen query they use does the same opensearch stuff under the hood… [21:07:11] could be wrong [21:07:19] mhurd: yes, but even looks like the generator query gives a better-ordered list of results! [21:07:27] ooog nice! [21:07:32] *oooh* [21:07:34] hehe [21:07:36] lol [21:07:44] caveman speak [21:08:02] gronk grok! [21:08:54] dbrant: bearND hey do you guys have ios devices? [21:09:45] mhurd: I have an iphone 4S that i used prior to my current phone. [21:10:08] but would I be able to use it with xcode? [21:10:38] i think so… i was also going to see if you had it signed up to recieve the testflight betas [21:11:03] mhurd: no, only simulator [21:11:20] mhurd: i haven't! how does that work? [21:11:25] and when i get back to sf i’ll prob need help getting an android device set up to do the same, tomasz and dan can maybe help me, but i may ping you as well [21:11:26] oh [21:11:41] i can just send you an invite [21:13:36] dbrant|brb: bearND just sent both of you invites [21:13:42] vbamba: heya! [21:19:51] (03CR) 10Mhurd: [C: 04-1] "-1'ing myself until I try a refactor of the search results controller and see if that helps with the ios6 lockups. I've identified a coupl" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/151261 (owner: 10Mhurd) [21:25:32] (03PS3) 10BearND: Update MW Java API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153704 [21:25:44] (03CR) 10jenkins-bot: [V: 04-1] Update MW Java API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153704 (owner: 10BearND) [21:26:40] bearND: dbrant|brb see you guys later! [21:27:08] mhurd: later :) [21:29:42] (03PS5) 10Dduvall: QA: Refactoring browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 [21:36:39] (03PS2) 10Dduvall: QA: Extension dependencies for VE and notification features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152993 [21:39:59] (03CR) 10JGonera: "Thanks Dan, I made some progress with this recently so this patch is kind of out of date. I'll try to push something new in the next few d" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126878 (owner: 10JGonera) [21:40:50] (03CR) 10Dduvall: "I've fix all remaining indentation issues, some of which I introduced. :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [23:02:08] 3Wikipedia App / 3Search: switching search target project of search window has to be changed by switching the language - 10https://bugzilla.wikimedia.org/34672#c8 (10Ryu, Cheol) 5NEW>3RESO/FIX I found you developed the 'Language Setting' and I am now enjoying. I downloaded it of 2.0-r-2014008-07 on Play... [23:12:01] (03PS1) 10JGonera: Make thumbnail caption color darker [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153726 (https://bugzilla.wikimedia.org/67005) [23:16:01] (03CR) 10JGonera: [C: 032] Make LeftNavEditTutorial no longer an A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150396 (owner: 10Kaldari) [23:16:32] (03Merged) 10jenkins-bot: Make LeftNavEditTutorial no longer an A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150396 (owner: 10Kaldari) [23:28:16] (03PS2) 10JGonera: Make sure that images are aligned correctly on wide screens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151819 (https://bugzilla.wikimedia.org/69141) (owner: 10Amire80) [23:28:32] (03CR) 10JGonera: [C: 032] Make sure that images are aligned correctly on wide screens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151819 (https://bugzilla.wikimedia.org/69141) (owner: 10Amire80) [23:29:03] (03Merged) 10jenkins-bot: Make sure that images are aligned correctly on wide screens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151819 (https://bugzilla.wikimedia.org/69141) (owner: 10Amire80) [23:29:26] dbrant|brb: hello [23:46:34] (03PS4) 10BearND: Update MW Java API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153704 [23:47:33] (03CR) 10jenkins-bot: [V: 04-1] Update MW Java API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153704 (owner: 10BearND) [23:51:14] (03PS1) 10BearND: Bump version to 1.1 [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/153730