[01:47:27] (03PS1) 10Florianschmidtwelzow: Remove last non-test related use of writeCokkie/readCookie [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153741 [05:14:25] 3Wikipedia App / 3Android App: Only show simplified Chinese - 10https://bugzilla.wikimedia.org/69457 (10ddyangliu@yeah.net) 3UNCO p:3Unprio s:3normal a:3None My Android phone language is traditional Chinese. I mean within the Chinese interface, my phone can only show Simpfield Chinese, not Tradition... [05:16:23] 3Wikipedia App / 3Android App: Only show simplified Chinese - 10https://bugzilla.wikimedia.org/69457 (10ddyangliu@yeah.net) [05:20:38] 3Wikipedia App / 3Android App: Only show simplified Chinese - 10https://bugzilla.wikimedia.org/69457 (10ddyangliu@yeah.net) [05:29:08] 3Wikipedia App / 3Android App: Only show simplified Chinese - 10https://bugzilla.wikimedia.org/69457#c1 (10Bernd Sitzmann) Does the article text show up in traditional Chinese? We're aware that the UI elements of the application itself (like menu items, dialog labels, etc.) are currently in simplified Chine... [05:40:09] 3Wikipedia App / 3Android App: Only show simplified Chinese interface - 10https://bugzilla.wikimedia.org/69457 (10LNDDYL) [05:49:38] 3Wikipedia App / 3Android App: Only show simplified Chinese interface - 10https://bugzilla.wikimedia.org/69457#c2 (10LNDDYL) (In reply to Bernd Sitzmann from comment #1) > Does the article text show up in traditional Chinese? > > We're aware that the UI elements of the application itself (like menu items, >... [09:41:41] yuvipanda: hey! [12:13:09] 3MobileFrontend / 3General/Unknown: images are aligned incorrectly in MobileFronted in RTL - 10https://bugzilla.wikimedia.org/69141 (10Amir E. Aharoni) 5PATC>3RESO/FIX [12:13:53] 3MobileFrontend / 3General/Unknown: images are aligned incorrectly in MobileFrontend in RTL - 10https://bugzilla.wikimedia.org/69141 (10Amir E. Aharoni) [12:14:25] 3MobileFrontend / 3stable: List of languages looks strange when mixes RTL and LTR languages - 10https://bugzilla.wikimedia.org/64617 (10Amir E. Aharoni) a:3Amir E. Aharoni [12:23:41] (03PS3) 10Florianschmidtwelzow: Improve Talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153341 (https://bugzilla.wikimedia.org/64105) [12:30:26] 3MobileFrontend / 3General/Unknown: editing area on MobileFrontend must be set to the language and the direction of the page's content - 10https://bugzilla.wikimedia.org/69465#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/mVBsrFvV [12:30:26] 3MobileFrontend / 3General/Unknown: editing area on MobileFrontend must be set to the language and the direction of the page's content - 10https://bugzilla.wikimedia.org/69465 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Editing area in MobileFronted inherits the lang and the dir of the HTML... [12:31:38] 3MobileFrontend / 3General/Unknown: editing area on MobileFrontend must be set to the language and the direction of the page's content - 10https://bugzilla.wikimedia.org/69465#c2 (10Amir E. Aharoni) Compare: English UI: https://meta.m.wikimedia.org/w/index.php?title=Language_committee&uselang=en&article_acti... [12:46:38] 3MobileFrontend / 3General/Unknown: editing area on MobileFrontend must be set to the language and the direction of the page's content - 10https://bugzilla.wikimedia.org/69465#c3 (10Amir E. Aharoni) ... Should be an easy thing to fix, but I know nothing about Hogan. With a bit of advice from experienced MF d... [14:46:53] 3Wikipedia App / 3Android App: Crash reports with null values? - 10https://bugzilla.wikimedia.org/68308#c1 (10Alex Monk) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7725384 [14:50:09] 3Wikipedia App / 3Android App: NPEs from android.support.v4.widget.DrawerLayout.isContentView ? - 10https://bugzilla.wikimedia.org/67808#c2 (10Alex Monk) Apparently this occurred for one user when they opened the left pullout while the page was still loading. It was transparent and two spinners were visible.... [14:57:11] 3MobileFrontend / 3stable: messages to logged-in user gone missing - 10https://bugzilla.wikimedia.org/69475 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Seen in beta labs: messages for user-already-logged-in and password-reset no longer appear. Please see the test failures in login.feature at... [15:00:23] 3Wikipedia App / 3Android App: NPEs from page.PageViewFragment.commonSectionFetchOnCatch - 10https://bugzilla.wikimedia.org/67807#c7 (10Alex Monk) What about https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7708614 ? java.lang.RuntimeException: java.lang.NullPointerException: Attem... [15:00:39] 3MobileFrontend / 3stable: messages to logged-in user gone missing - 10https://bugzilla.wikimedia.org/69475#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/BWhN8M1K [15:07:14] (03PS1) 10Florianschmidtwelzow: WIP: Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) [15:07:24] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow) [15:08:14] (03PS2) 10Florianschmidtwelzow: WIP: Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) [15:09:11] 3Wikipedia App / 3Android App: SecurityException: Permission denied (missing INTERNET permission?) - 10https://bugzilla.wikimedia.org/67948#c4 (10Alex Monk) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7689643 https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;Tic... [15:10:16] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Needs a rework of TalkOverlay, the API request in initialize prevent's OverlayManager to show the Overlay for slow connections (content is" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow) [15:37:56] hey bearND [15:39:14] bearND: so, the default for simplified Chinese will be simply "zh"? (i.e. are we sure that we don't need "zh-rCN"?) [15:45:13] 3MobileFrontend / 3stable: messages to logged-in user gone missing - 10https://bugzilla.wikimedia.org/69475#c2 (10Jon) Either wrongly or rightly the desktop behaviour has changed Going to http://127.0.0.1:8080/wiki/Special:Userlogin whilst logged in now redirects me to the main page. As for password reset... [16:03:03] dbrant: if it's looking for zh-rCN it would first it. If it doesn't find that it would fallback to zh. That way we have all simplified Chinese variants covered with this one set of string resources. [16:03:22] bearND_: I see! [16:06:04] (03PS1) 10Dbrant: Use generator:prefixsearch instead of opensearch. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153809 [16:11:41] (03Abandoned) 10BearND: Remove useless variable declaration [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/125973 (owner: 10Yuvipanda) [16:12:21] YuviPanda: would you take a peek at https://gerrit.wikimedia.org/r/#/c/153730/ ? [16:14:40] bearND_: want me to +2? [16:14:43] 3Wikipedia App / 3Android App: Android app doesn't support language variants in UI translations - 10https://bugzilla.wikimedia.org/69304#c14 (10Bernd Sitzmann) *** Bug 69457 has been marked as a duplicate of this bug. *** [16:14:43] 3Wikipedia App / 3Android App: Only show simplified Chinese interface - 10https://bugzilla.wikimedia.org/69457#c3 (10Bernd Sitzmann) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 69304 *** [16:15:19] dbrant: yes, please do [16:15:31] (03CR) 10Dbrant: [C: 032 V: 032] Bump version to 1.1 [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/153730 (owner: 10BearND) [16:17:51] dbrant: thanks [16:22:28] 3Wikipedia App / 3Generic: Keyboard doesn't hide when I navigate to left drawer - 10https://bugzilla.wikimedia.org/64339#c5 (10Dan Garry) 5REOP>3RESO/FIX It's fine now. [16:24:44] 3Wikipedia App / 3Android App: Android app: Keyboard sometimes doesn't collapse when you minimise the app - 10https://bugzilla.wikimedia.org/69479 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1) Open the left nav 2) Tap search (the left nav collapses and the keyboard comes up)... [16:27:53] (03PS5) 10BearND: Update MW Java API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153704 [16:43:53] (03PS1) 10Dbrant: Put disambiguation links into a popup dialog. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153814 [16:44:15] (03CR) 10Dbrant: [C: 032] Update MW Java API [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153704 (owner: 10BearND) [16:53:11] (03PS1) 10Dbrant: No longer using abusefilter js/css, so remove the files. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153816 [16:55:07] (03PS2) 10Dbrant: No longer using abusefilter js/css, so remove the files. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153816 [16:56:37] (03PS4) 10Dbrant: Temporarily disable Page Issues & Disambiguation buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/152191 [17:10:20] kristenlans: awjr sorry massive technology fail [17:10:43] maryana: lulz no problem. Re-entry from wikimania is rough ;-) [17:12:13] (03PS1) 10BearND: Need only one variant for simplified Chinese [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153822 [17:18:03] (03Abandoned) 10Yurik: Use correct RL module class for templates [extensions/ZeroBanner] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150430 (owner: 10Yurik) [17:19:41] 3MobileFrontend / 3General/Unknown: Special:Nearby doesn't work on it:voy - 10https://bugzilla.wikimedia.org/69480 (10Andre Klapper) p:5High>3Unprio [17:20:26] 3MobileFrontend / 3General/Unknown: Special:Nearby doesn't work on it:voy - 10https://bugzilla.wikimedia.org/69480#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/cdbrsLSf [17:27:41] 3Wikipedia App / 3Android App: Android app: Keyboard sometimes doesn't collapse when you minimise the app - 10https://bugzilla.wikimedia.org/69479 (10Kristen Lans) [17:32:08] maryana: time to chat now? [17:32:21] sure, lemme grab a room [17:32:37] m’kay, I will make a calendar invite/hangout [17:34:43] aight i'm in the call kristenlans :) [17:35:11] 3Commons App / 3Android: i18n: \u00A0 does not survive export to translatewiki - 10https://bugzilla.wikimedia.org/69395#c1 (10Bernd Sitzmann) We're currently not doing anything with the Commons app. I've checked that we don't use any escaped Unicode characters in the Wikipedia Android app. [17:35:31] (03CR) 10Dbrant: [C: 032] Need only one variant for simplified Chinese [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153822 (owner: 10BearND) [17:47:58] dbrant: bearND_ gah, seem to have fell asleep. sorry about that [17:51:09] hello YuviPanda :) [17:51:21] hi bearND_ [17:53:18] YuviPanda|groggy: I updated the Java MW API to 1.1 since the team Maven repo was stuck thinking 1.1-SNAPSHOT didn't exist. Now it's happy. [17:56:55] bearND_: bah, my bouncer disconnected. did I miss anything? [17:57:33] YuviPanda|groggy: not really [18:01:13] 3MobileFrontend / 3Feature requests: Addition of a "new section" button on talkpages - 10https://bugzilla.wikimedia.org/69484 (10fionareidc) 3UNCO p:3Unprio s:3normal a:3None So I've been doing a lot of my editing from my Kindle Fire lately, and one thing that's been tripping me up/making my editing... [18:02:12] (03PS1) 10BearND: Check if fragment is added before dealing with reference clicks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153837 (https://bugzilla.wikimedia.org/69415) [18:05:31] 3MobileFrontend / 3Feature requests: Addition of a "new section" button on talkpages - 10https://bugzilla.wikimedia.org/69484#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/3Jd6EdUq [18:07:16] jdlrobson: ping [18:11:20] FlorianSW: hey one second i'm troubleshooting some browser tests. ping me in about 20 mins? [18:11:35] jdlrobson: ok :) Good luck! [18:15:29] 3MobileFrontend / 3stable: Bad title error when following wikilinks with certain punctuation - 10https://bugzilla.wikimedia.org/69485 (10fionareidc) 3UNCO p:3Unprio s:3normal a:3None There seems to be a problem with following wikilinks with certain punctuation (such as the ? character) when on the mo... [18:20:26] 3MobileFrontend / 3stable: Bad title error when following wikilinks with certain punctuation - 10https://bugzilla.wikimedia.org/69485#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/fxZgRAAr [18:26:14] (03PS3) 10Florianschmidtwelzow: WIP: Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) [18:26:59] Where do I direct editors who want to give feedback and suggestions on MobileFrontend? probably [[mw:MobileFrontend/Feedback]] (but it seems too quiet) or [[mw:Talk:Wikimedia mobile engineering]] or other? [18:29:25] quiddity: You mean only feedback aka "Very good" or "not so good" or bugs and something else? [18:29:41] Or questions, e.g. "Where i find function XY?" [18:31:06] FlorianSW, bug reports, and suggestions for feature changes. (The last time they asked, they were directed to the mailing list, which isn't what they wanted to hear! It's a non-technical editor, who wants a wiki-location) [18:32:06] (03PS1) 10Yurik: Handle TextContent::isEmpty() and isCountable() for better statistics [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/153851 [18:32:08] oh, ok, a wiki location... normally bugzilla.wikimedia.org but my person reads the talk page of the extension on mediawiki.org, too: https://www.mediawiki.org/wiki/Extension_talk:MobileFrontend [18:32:23] so if there is a feature request or bug report i will/can create it on bugzilla. [18:32:33] A wiki location on *.wikipedia.org i don't know, sry :/ [18:32:41] bearND_: shall we include your reference-click bug fix in the release? [18:33:36] (03PS1) 10Yurik: cleaned up api lib [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/153852 [18:35:20] jdlrobson: ping :) [18:35:47] FlorianSW, that works. Thank you :) [18:35:56] quiddity: Great :D [18:39:26] dbrant: +1 for including, I'd say [18:40:16] (03CR) 10Dbrant: [C: 032] "Makes sense." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153837 (https://bugzilla.wikimedia.org/69415) (owner: 10BearND) [18:41:16] quiddity: can we get a Flow board setup for Extension talk:MobileFrontend [18:41:41] i ignore that talk page simply because it is liquid threads [18:41:41] mobile-l would be the official place to go if people want to talk about mobile stuff [18:41:50] jdlrobson, ask werdna to finish up his conversion script, and yes. :) [18:42:28] quiddity: sighh. as i've said numerous times the quicker we kill LiquidThreads the better [18:42:45] quiddity: can you poke danny to prioritise that :) it's a real use case where we can get some real value [18:43:34] jdlrobson: i'm working on using OverlayManager for talk pages on MobileFrontend (https://gerrit.wikimedia.org/r/#/c/153803/3), it's working like i want, but if i close the talk overlay and reopen it, a new overlay will be created over the "old" one without any content. (Hope it's clear what i say oO) [18:45:08] FlorianSW: mmm the OverlayManager has a habit of doing that sort of thing [18:45:14] let me take a quick look [18:45:42] bearND: at this point, do you think it might be simpler to just merge the patch to disable page-issues? (and we'll just have a WIP patch to un-disable them?) [18:47:36] jdlrobson: that sounds logical (like on editor, which i used as an orientation), but the old (closed) overlay seems to be still loaded and the new created doesn't loaded (execute) the content (_loadContent()) [18:49:56] 3MobileFrontend / 3Feature requests: Addition of a "new section" button on talkpages - 10https://bugzilla.wikimedia.org/69484#c2 (10Florian) Hello! Are you using beta or alpha mode (left sidebar -> Settings-> beta/experimental?)? The talk pages there are optimized and you have a button at the top of the lis... [18:51:07] bearND: at this point, do you think it might be simpler to just merge the patch to disable page-issues? (and we'll just have a WIP patch to un-disable them?) [18:51:13] 3MobileFrontend / 3stable: Special:MobileOptions 'checkboxes' are confusing - 10https://bugzilla.wikimedia.org/69487 (10Jon) 3NEW p:3Unprio s:3normal a:3None The checkboxes on this page look like slide controls that would instantly save yet you have to hit the save button to opt in. I suspect this a... [18:51:52] so FlorianSW [18:52:03] dbrant: Either way works for me [18:52:04] ohoh :) [18:52:08] am taking a look at your patch [18:54:24] dbrant: bearND I think in the future, we should use https://en.wikipedia.org/wiki/Feature_toggle [18:54:28] 3MobileFrontend / 3stable: "How did you improve the page?" doesn't really make sense on non-article namespace - 10https://bugzilla.wikimedia.org/69488 (10Jon) 3NEW p:3Unprio s:3normal a:3None If I go to edit a talk page I am prompted with "How did you improve the page?" This is very strange. The wor... [18:54:33] we do that in production Mediawiki (sortof) [18:55:15] FlorianSW: so i think i have an idea what's happening here [18:55:27] 3MobileFrontend / 3stable: Special:MobileOptions 'checkboxes' are confusing - 10https://bugzilla.wikimedia.org/69487#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/65fIifaP [18:55:27] 3MobileFrontend / 3stable: "How did you improve the page?" doesn't really make sense on non-article namespace - 10https://bugzilla.wikimedia.org/69488#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/V907uHNX [18:56:04] YuviPanda|groggy: that's a good point... [18:56:32] dbrant: once the thing gets into prod and we're sure it's ok enough we won't have a rollback, we can remove the flag for next release [18:57:02] jdlrobson: that sounds good :) [18:57:38] FlorianSW: so i think this is the bug i raised a while ago [18:57:44] that kaldari disagreed with my fix [18:57:50] oO [18:57:54] the page api request is being cached [18:58:19] ok, and the api don't return the cached version?! [18:58:25] https://gerrit.wikimedia.org/r/137734 [18:59:46] FlorianSW: well the api returns the cached version instantly [19:00:08] ah... yeah i think i remember the problem when you navigate through 3 pages with lazyload and click back in browser, the last modified and other js added content doesn't load [19:00:09] but because of the way things are set up the event is triggered instantly so anything binded later does not get acted upon [19:00:46] (03Restored) 10Jdlrobson: Emit events after delay to support chaining [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [19:01:34] FlorianSW: yeh i restored it. Maybe you can help Kaldari/Jgonera understand this issue and we can find some compromise :) ^ [19:01:49] (03PS5) 10Jdlrobson: Emit events after delay to support chaining [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) [19:02:11] jdlrobson: Get e-mail :P i will use this patch locally and try again :) one moment :) [19:03:57] jdlrobson: hmm, no, still the same problem :/ [19:06:09] jdlrobson: can you reproduce this? If you click on talk page it opens the talk page and loads the sections, ok. You can add and open discussions without problems. Now click the back key to leave the talk overlay. After this, reopen the talk page by click the talk button again. Now you have a new overlay with a spinner and no content (and no api request). If you click the back key you still have the header but no content o [19:06:16] (03CR) 10Yurik: [C: 032] cleaned up api lib [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/153852 (owner: 10Yurik) [19:06:27] .. have the "old" overlay with content and all and can navigate through discussions without a problem. [19:07:48] bearND: YuviPanda|groggy: ready for release? speak now or forever hold your peace... [19:08:15] (03CR) 10jenkins-bot: [V: 04-1] Emit events after delay to support chaining [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137734 (https://bugzilla.wikimedia.org/65633) (owner: 10Jdlrobson) [19:08:17] (03Merged) 10jenkins-bot: cleaned up api lib [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/153852 (owner: 10Yurik) [19:08:38] dbrant: I shall hold my peace, once I find it :) [19:09:44] dbrant: ready. would you like me to do the release? [19:12:09] bearND: how about we break it up a bit, just to exercise the script. You do the version bump and Beta release (and tag), and then I'll check out the tag, and do the production, Amazon, etc. builds? [19:12:39] dbrant: sounds good to me [19:14:31] dbrant: do you have a beta tag in your repo? [19:14:54] bearND: I don't believe so [19:28:55] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153873 [19:30:27] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153873 (owner: 10BearND) [19:30:47] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153873 (owner: 10BearND) [19:36:00] dbrant: I pushed the beta to releases.mw.org site [19:36:24] dbrant: YuviPanda|groggy: in case you want to test beta [19:36:36] releases.wm.org :D [19:36:40] and sweet :) [19:43:31] FlorianSW: sorryyy my ir dropped off [19:43:42] jdlrobson: np :) [19:43:43] FlorianSW: yeh i can replicate that issue [19:43:46] there are 2 issues here [19:43:52] 2? oO [19:44:00] 1 is that addContent never gets run [19:44:06] fixed by my patch [19:44:50] check it with a console.log statement [19:45:16] 2nd issue i'm not sure about yet but looking [19:45:18] dbrant: tomorrow 12 PST for full text search catchup [19:45:34] Ill have the icon ready as well [19:46:10] dbrant: YuviPanda|groggy: hmm, the script spit out an error message ("no new changes") while pushing the branch, but it did push the branch [19:46:18] jdlrobson: one moment please, have a skype call with another person/another topic, think 20 minutes :/ [19:46:22] so, I'll have to push the tag manually [19:46:29] FlorianSW: no worries [19:47:52] YuviPanda|groggy: would you check the git push syntax in the script after 'pushing branch'? [19:50:03] dbrant: pushed the tag manually: https://git.wikimedia.org/tags/apps%2Fandroid%2Fwikipedia.git [19:50:50] dbrant: YuviPanda|groggy: once you guys are ok with the apk I'll publish it [19:51:34] dbrant: quick question [19:53:16] bearND: I thought that there should also be a tag of the Bump commit? (from which I would do the prod/Amazon builds) [19:53:40] bearND: did you do a "--bump --push"? [19:54:10] dbrant: no, i did not do that. I followed what the script said and just did a git review [19:54:45] "Run git review with bumped version and +2 if appropriate" [19:55:36] dbrant: but that runs counter to the rest of the documentation [19:56:01] (03CR) 10Jdlrobson: [C: 04-1] "Okay so I think the problem you are having is you are using $ rather than this.$" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow) [19:56:02] bearND: lol right. The comments within the script itself talk about --bump --push [19:56:28] dbrant: but the output says something different [19:56:30] dbrant: ok, i'll push that tag as well [19:57:19] we'll get it right one day. [19:57:50] dbrant: do we really want a tag called "master/2.0-master-2014-08-13"? [19:58:26] dbrant: I thought we wanted something with bump in there [19:59:12] YuviPanda|groggy: dbrant: I'm also thinking that in most cases we don't need to push the branch [20:04:27] bearND: I wouldn't see a problem with a name like "master/2.0-master-2014-08-13"... it simply represents a milestone at which we chose to make a release. (isn't that right?) [20:04:49] dbrant: alright [20:05:21] maryana: we are hanging for story review [20:05:38] kristenlans: yep yep [20:05:39] setting up [20:05:45] sorry, weird tech things [20:06:16] dbrant: master (bump) tag is pushed [20:07:05] dbrant: are you ok with me publishing the apk? [20:07:26] bearND: the beta APK looks good to me! [20:08:27] dbrant: 10..9..8..7..654321..published [20:08:36] \o/ [20:08:57] dbrant: feel free to edit "what's new" [20:10:59] dbrant: want me to rebase and +2 https://gerrit.wikimedia.org/r/#/c/152191/? [20:12:47] w00t on publishing [20:12:50] bearND: well... no, let's keep cherry-picking it. plus it's too late now, since we already made the tag. [20:13:15] dbrant: ok [20:13:52] dbrant: you'll need to cherry-pick it three times though [20:14:04] once for each release [20:14:13] bearND: lol yes, such is life [20:15:56] * bearND hands over the release baton to dbrant [20:37:16] YuviPanda|groggy: is there a way to verify (from the server side) that our api parameters are in the right order? (i.e. is there a port that I can zsub that shows all api requests?) [20:40:34] jgonera: Do we have an iPad lying around somewhere for testing purposes? [20:42:38] bearND: how did you push the tag manually? (looks like I need to do the same) [20:42:53] git push gerrit [20:43:47] dbrant: ^ [20:43:58] RoanKattouw, there should be some in the Tablets drawer next to my desk [20:44:18] bearND: oh, ok! [20:45:59] jgonera: Thanks, I grabbed one from there [21:02:34] jdlrobson: a bit more then 20 minutes :) [21:03:53] FlorianSW: i already commented on the patch with you problem [21:04:39] i saw it :) But i carefully i want to say, that this can't be the problem, but will test first :) [21:04:56] 3MobileFrontend / 3General/Unknown: Special:Nearby doesn't work on it:voy - 10https://bugzilla.wikimedia.org/69480#c2 (10Andyrom75) Andre, a couple of questions: 1) Why the component is General/Unknown if the problem occurs on the special page Nearby? 2) Considering that the problem is also on desktop view,... [21:11:44] jdlrobson: hmm, seems to be the solution :) I will do some test's and upload then, big thanks for your help! [21:13:49] dbrant: For the full text search - icon size is 24 dp focus. Is that how you have it set up? [21:14:05] vbamba: yep [21:14:58] so full text search and find in page - conceptually mean the same thing to the user [21:15:12] But, we dont carry any icons for ''Find in page' [21:15:37] Since its in that Android overflow menu which has no icons (or emotions for that matter) [21:15:42] :) [21:15:49] vbamba: right! [21:16:44] ok. Am i correct about 24 dp focus area? [21:18:21] vbamba: yep! [21:20:35] bearND: yeah, the stuff I pushed to MobileApp is simply what I had "so far".... I'll amend that patch with the dimensions/styling from your patch. [21:20:53] dbrant: sounds good [21:21:25] Error: Could not start Service[jobrunner]: Execution of '/sbin/start jobrunner' returned 1: [21:21:35] eh, anyone got a clue on that ? [21:22:06] vbamba: I think we could use some real icons for the "find-in-page" fragment: The up/down arrows we have right now are just from text. We could use some nice icons for the arrows. [21:22:25] oh wrong chan [21:22:53] (03PS4) 10Florianschmidtwelzow: WIP: Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) [21:23:35] bearND: YuviPanda|groggy: production app released! [21:23:46] \0/ [21:23:50] dbrant: \o/ [21:24:44] \ 0 / [21:26:03] bearND: True. The up/ down feel a bit fragile. [21:26:37] vbamba: yeah, bony arrows [21:29:26] 3Wikipedia App / 3Android App: NPE when instantiating Dialog from ReferenceDialog - 10https://bugzilla.wikimedia.org/69415#c3 (10Bernd Sitzmann) 5PATC>3RESO/FIX should be fixed now [21:30:59] (03PS4) 10Mhurd: Dom transformations no longer "thrash". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/152848 [21:34:44] kristenlans: ok, i looked over the VE bugs that roan sent to me, and it doesn't look like any of them are all that major [21:34:55] a few look to be fixed already, even [21:35:41] Nice d:) [21:37:52] Maryana: one thing to note the boards got a little messed up, Arthur had already created a next sprint board, so add any bugs that you think shoudl go in to the next sprint to Mobile Web - Next Sprint 29 (C____) [21:38:10] I’ll move stuff off the other board and delete it [21:38:21] ah, ok [21:38:24] will do [21:39:04] oh, you already did [21:39:06] thanks :) [21:39:12] No probZ [21:45:13] 3MobileFrontend / 3stable: Special:Nearby doesn't work on it:voy - 10https://bugzilla.wikimedia.org/69480#c3 (10Jon) The Nearby page is part of the MobileFrontend extension. The fact it appears on desktop is just a confusing side effect :) So no need to create another bug. I've set to the correct component,... [21:53:32] (03PS6) 10JGonera: QA: Refactoring browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [21:58:49] (03PS7) 10JGonera: QA: Refactoring browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [22:00:07] (03PS3) 10Dduvall: QA: Extension dependencies for VE and notification features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152993 [22:00:57] (03PS4) 10Dduvall: QA: Extension dependencies for VE and notification features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152993 [22:09:39] (03PS1) 10Florianschmidtwelzow: Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 [22:10:48] (03PS2) 10Florianschmidtwelzow: Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 [22:12:14] (03PS16) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) [22:16:06] Is there anyone with Beta Labs superpowers willing to lend a hand with some account creation problems I’m having? :) [22:16:24] (03PS17) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) [22:17:06] (03CR) 10Florianschmidtwelzow: "?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) (owner: 10Florianschmidtwelzow) [22:26:26] 3MobileFrontend / 3stable: Bad title error when following wikilinks with certain punctuation - 10https://bugzilla.wikimedia.org/69485#c2 (10Florian) Hi! Can you say, what browser you use? I have tested the linking from this page [1] to "R U Mine?" on chrome for android in stable, beta ad alpha mode of Mobile... [22:27:13] kristenlans, hey [22:27:24] kristenlans, still need help? [22:28:15] Hi Krenair. I could use some help, yeah. [22:28:23] shall I PM you? [22:29:10] ok [22:30:41] 3MobileFrontend / 3General/Unknown: messages to logged-in user gone missing - 10https://bugzilla.wikimedia.org/69475#c4 (10Jon) Please let's keep it as a MobileFrontend bug as this is where the tests are passing. Personally I think the new behaviour is correct and we simply need to update the tests [22:30:56] 3MobileFrontend / 3General/Unknown: messages to logged-in user gone missing - 10https://bugzilla.wikimedia.org/69475#c5 (10Jon) failing rather... :) [22:36:52] (03PS1) 10Florianschmidtwelzow: Use summary message on non Main namespace pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153962 (https://bugzilla.wikimedia.org/69488) [22:37:32] (03PS2) 10Florianschmidtwelzow: Use summary message on non Main namespace pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153962 (https://bugzilla.wikimedia.org/69488) [22:39:13] (03PS2) 10Florianschmidtwelzow: Check userCanUpload when wgMFPhotoUploadEndpoint is set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) [22:46:34] (03PS8) 10Dduvall: QA: Refactoring browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 [22:48:12] 3MobileFrontend / 3General/Unknown: Thank notification on mobile doesn't ask for confirmation: accident-prone - 10https://bugzilla.wikimedia.org/61737 (10WhatamIdoing) 5UNCO>3NEW [22:59:18] (03PS9) 10JGonera: QA: Refactoring browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [23:00:02] (03CR) 10JGonera: [C: 032] QA: Refactoring browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [23:00:54] (03Merged) 10jenkins-bot: QA: Refactoring browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/147115 (owner: 10Dduvall) [23:03:02] (03PS5) 10JGonera: QA: Extension dependencies for VE and notification features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152993 (owner: 10Dduvall) [23:03:09] (03CR) 10JGonera: [C: 032] QA: Extension dependencies for VE and notification features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152993 (owner: 10Dduvall) [23:04:14] (03Merged) 10jenkins-bot: QA: Extension dependencies for VE and notification features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152993 (owner: 10Dduvall) [23:06:28] 3MobileFrontend / 3General/Unknown: Thank notification on mobile doesn't ask for confirmation: accident-prone - 10https://bugzilla.wikimedia.org/61737#c7 (10WhatamIdoing) If Bug 53879 results in one-click thanking on desktop, then Mobile might be able to use the same method. The main point is this: Peopl... [23:08:59] (03CR) 10Dbrant: [C: 032] Update lead-in documentation for prepare-release script [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/152819 (owner: 10Dr0ptp4kt) [23:11:17] (03PS5) 10Florianschmidtwelzow: Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) [23:17:42] (03PS1) 10Dbrant: Add important hint when script exits. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153968 [23:17:59] (03CR) 10jenkins-bot: [V: 04-1] Add important hint when script exits. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153968 (owner: 10Dbrant) [23:18:47] :( stupid tabs [23:19:34] jgonera: can you take a look on this? https://gerrit.wikimedia.org/r/#/c/152748/ :) [23:20:01] (03PS2) 10Dbrant: Add important hint when script exits. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153968 [23:20:32] bearND: dbrant hey guys! Re: Disambiguation and Page Issues. Can we merge the grey links into the beta build, when we have a chance. Everything is clarified on the trello card. [23:22:24] vbamba: yep! it'll make it into the next beta release. (or an earlier one-off build) [23:25:53] (03CR) 10BearND: Add important hint when script exits. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153968 (owner: 10Dbrant) [23:30:57] 3MobileFrontend / 3General/Unknown: Thank notification on mobile doesn't ask for confirmation: accident-prone - 10https://bugzilla.wikimedia.org/61737#c8 (10Jon) Dropping a phone will not lead to accidental button presses. Please read https://en.m.wikipedia.org/wiki/Capacitive_sensing and I don't think we s... [23:48:04] (03PS1) 10Dduvall: QA: Extension dependencies for geodata-related scenarios [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153988 [23:51:58] bearND: re. your comment on the script: if it's called with "--bump --push", then that whole block won't be reached... [23:53:47] dbrant: the args parsing logic needs to be fixed, too, then [23:55:23] bearND: how so? I'm not sure I'm following [23:56:22] dbrant: sounds like you were thinking about a different block that won't be reached than I was. Which one were you thinking? [23:56:38] bearND: the one where you made the comment [23:57:34] dbrant: but why would it not be reached on "--bump --push"? [23:58:00] dbrant: IMO it's because the args parsing code does an elif args.bump [23:58:57] dbrant: we need to have two if args.bump inside the other two cases, like Adam had before