[00:01:28] 3MobileFrontend / 3stable: Useprofile page left aligned rather than centered in tablet view - 10https://bugzilla.wikimedia.org/69587 (10Jon) 3NEW p:3Unprio s:3normal a:3None https://en.m.wikipedia.org/wiki/Special:UserProfile/Jdlrobson The class .profile has margin: 1em 0 0 0; defined. I'm not sure... [00:05:29] 3MobileFrontend / 3stable: Useprofile page left aligned rather than centered in tablet view - 10https://bugzilla.wikimedia.org/69587#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/K7WojRQH [00:05:42] jdlrobso_: ping :) [00:06:26] FlorianSW|away: hey hey [00:06:42] hey :) to your comment: https://gerrit.wikimedia.org/r/#/c/152748/2/includes/specials/SpecialUploads.php [00:06:52] i would say: no :) [00:13:12] 3MobileFrontend / 3beta: Safari on iPad crashes when viewing large articles? - 10https://bugzilla.wikimedia.org/68845#c7 (10Juliusz Gonera) My guess is that this is a iOS Safari bug. It seems to crash only now and then (actually I haven't been able to reproduce more than once) and scrolling through the page... [00:21:04] (03CR) 10Florianschmidtwelzow: Check userCanUpload when wgMFPhotoUploadEndpoint is set (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [00:23:50] (03CR) 10Jdlrobson: Check userCanUpload when wgMFPhotoUploadEndpoint is set (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [00:34:38] (03CR) 10Florianschmidtwelzow: Check userCanUpload when wgMFPhotoUploadEndpoint is set (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [00:51:14] (03CR) 10Florianschmidtwelzow: Check userCanUpload when wgMFPhotoUploadEndpoint is set (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [04:51:43] (03CR) 10Brion VIBBER: [C: 032 V: 032] "whee!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153342 (owner: 10Mhurd) [04:53:24] (03CR) 10Brion VIBBER: [C: 032 V: 032] Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153525 (owner: 10BearND) [04:56:06] (03CR) 10Brion VIBBER: Further protection against corrupting css on build and sync. (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153696 (owner: 10Mhurd) [05:08:11] (03CR) 10Brion VIBBER: Dom transformations no longer "thrash". (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/152848 (owner: 10Mhurd) [13:22:57] 3Commons App / 3iOS (iPhone or iPad): Uploads broken in version 1.0.10 on iOS7 - 10https://bugzilla.wikimedia.org/56967#c1 (10Andre Klapper) > I cannot get queued photos to upload via any method. swalling: Do you know if this is still an issue after those nine months? [13:24:11] 3MobileFrontend / 3stable: Site notices look crappy on mobile - 10https://bugzilla.wikimedia.org/65395#c12 (10Florian) Created attachment 16204 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16204&action=edit example of CentralNotice on de-wiki The same on dewiki (but they look not too bad, but does... [13:24:35] (03CR) 10Yuvipanda: "Do use table instead of TABLE, for some reason it's bugging me a fair bit :)" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/152848 (owner: 10Mhurd) [15:08:30] dbrant: YuviPanda: are you able to push from the tools account to git? [15:08:35] bearND: heya [15:08:38] bearND: so... you can't [15:08:55] bearND: however, you can just cd to /data/project/ as your own user account [15:08:58] bearND: and push from there [15:09:17] YuviPanda: ah, go it. thanks [15:09:19] bearND: user and tool are part of same group, so should be able to access [15:09:22] got [16:42:55] YuviPanda: are there any good examples of web services on tool labs? Or should we for https://trello.com/c/Q55dzos6/7-release-management-build-status-web-page-that-is-mobile-friendly-that-lets-people-download-current-apk-see-list-of-builds just make the public_html browseable? [16:51:56] dbrant_: are there any patches from you that are ready to be merged? [16:54:27] bearND: yep! in my standup notes I mentioned which ones are ready for review. [16:56:28] dbrant_: great! I see two of those. When you get a chance please take also a look at https://gerrit.wikimedia.org/r/#/c/154210/ (updating support libraries). I'd like to get that in for the next beta [16:59:32] bearND: will do. (will that be obsoleted by the gradle build?) [17:02:04] dbrant_: yes, once we switch fully to Gradle pom.xml file changes would be obsolete. But I'm not sure when we can fully switch to it. For some weird reason it doesn't like to run or even pick up the instrumentation test, which I consider somewhat of a blocker. [17:03:19] I see! [17:10:48] Maryana: checkboxes are in the style guide [17:10:50] in core [17:11:00] jgonera: ^^ [17:11:21] Maryana: their not mine :P [17:11:25] they are the ones from beta labs [17:11:30] *beta features [17:12:03] i know i know :) [17:12:29] bearND: hey [17:12:37] bearND: you can use php or python, and the toollabs docs has a bunch [17:12:51] bearND: https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/Help [17:13:11] dbrant_: bearND I'm looking at the search patch now :) [17:14:34] bearND: we should definitely do a better display than just have it be browsable [17:15:39] bearND: maybe integrate it with https://tools.wmflabs.org/snapshots/ ? [17:16:30] jgonera Maryana kristenlans looks like VE is working on mobile on enwiki :) [17:16:54] yep :) i was editing ukrainian wikipedia with it yesterday [17:17:22] although i am getting a JS error though when i open up VE: Discontiguous selection is not supported. [17:17:37] uh oh [17:17:43] file bug? [17:17:48] but editing seems to still work, no idea what that's about [17:17:52] sure thing [17:17:55] ty [17:18:08] not sure if it's mobile or ve tho [17:18:58] kristenlans: Cant seem to find anyone on the apps standup [17:19:08] vbamba try again? it's going on now [17:19:15] there are a bunch of us here :) [17:19:21] there she is! [17:19:25] \0/ [17:23:42] Maryana: https://bugzilla.wikimedia.org/show_bug.cgi?id=69616 [17:23:43] 3MobileFrontend / 3stable: JS error on loading mobile VE: Discontiguous selection is not supported. - 10https://bugzilla.wikimedia.org/69616 (10Arthur Richards) 3NEW p:3Unprio s:3normal a:3None When I open the VisualEditor on mobile in stable on enwiki using Chrome on desktop (OSX), I get the followi... [17:23:45] kristenlans ^ [17:23:49] danke [17:25:26] 3MobileFrontend / 3stable: JS error on loading mobile VE: Discontiguous selection is not supported. - 10https://bugzilla.wikimedia.org/69616#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/7MTSGUCb [17:30:28] 3MobileFrontend / 3stable: JS error on loading mobile VE: Discontiguous selection is not supported. - 10https://bugzilla.wikimedia.org/69616#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/nqeGVbpJ [17:32:49] awjr: Can you add me to the apps standup invite please? [17:33:20] vbamba ask kristenlans :) [17:35:59] vbamba: added :-) [17:38:37] legoktm: ping [17:38:41] hi [17:38:51] legoktm: bearND wants to setup a b arebones flask app on toollabs. Do you have a skeleton he could look at / docs? [17:39:36] I would just look at https://github.com/valhallasw/gerrit-patch-uploader/ [17:39:43] and copy his fcgi / flup thingy [17:41:28] legoktm: so, I copy/mod the FCGI Flask config from https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/Help#Example_configurations to my local ~/.lighttpd.conf? [17:45:14] kaldari: if you have additional notes/answers to the questions in this card – https://trello.com/c/HDhDIvZM/1-spike-investigate-magnus-s-wikidata-games – can you put 'em somewhere? :) [17:46:49] bearND: yeah [17:47:03] legoktm: ok, thank you [17:47:33] valhallasw in -labs is a good person to ask as well [17:47:44] I typically just copy his code :P [17:49:21] awjr! yessir! [17:49:42] bearND: Should I set up call for you, me and dmitry? [17:50:00] To discuss any blockers for Sprint 38? [17:50:25] vbamba1: probably on Monday [17:55:05] bearND: sounds good [17:55:26] dmitry and I have to clean up some search styling stuff today [18:03:16] Maryana: Have a quick question for you [18:03:24] what's up? [18:03:58] Early in May, we had a visitor from Chinese Wikipedia (I think he was an admin) [18:04:11] Do you know his name by any chance? [18:04:40] all office visits are logged on officewiki [18:04:43] err, no, i don't.. [18:06:31] no worries! [18:11:22] (03PS1) 10Kaldari: WIP: WikiGrok interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154299 [18:12:17] (03CR) 10jenkins-bot: [V: 04-1] WIP: WikiGrok interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154299 (owner: 10Kaldari) [18:27:15] vbamba: the reason I said Monday was not because of me but Dmitry since he is offline right now. Is there anything I could help with? [18:41:28] 3Wikipedia App / 3General/Unknown: Mobile site search results are illegible - 10https://bugzilla.wikimedia.org/69619 (10Chris_Chidester) 3UNCO p:3Unprio s:3major a:3None Up until yesterday I had no problems with the mobile site version of Wikipedia. Lately though when searching for something the pict... [18:42:56] damn it [18:43:07] Looks like that search images bug leaked to prod [18:43:17] jgonera: kaldari ^^ [18:44:13] Maryana: ah, I knew there was something we needed to lightning deploy! [18:44:20] :-/ [18:44:47] there's no LD on Friday though, right? [18:45:02] This is pretty bad. I don't want to wait to fix it till Monday [18:46:47] kristenlans: ^^ [18:46:50] Maryana: Maybe ask for LD in #wikimedia-operations [18:47:35] I'm just going to ping all the people and hope that solves it :) [18:48:08] :P [18:48:24] fingers crossed :) [18:50:11] 3MobileFrontend / 3stable: Search results + pageimages garbled on beta labs on iOS devices - 10https://bugzilla.wikimedia.org/68880#c7 (10Ryan Kaldari) *** Bug 69619 has been marked as a duplicate of this bug. *** [18:50:13] 3Wikipedia App / 3General/Unknown: Mobile site search results are illegible - 10https://bugzilla.wikimedia.org/69619#c1 (10Ryan Kaldari) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 68880 *** [18:50:29] Maryana: you could add a css hack to MediaWiki:Mobile.css [18:50:32] it's only real use case [18:50:49] but that's just on enwiki right? [18:50:54] This is appearing everywhere [18:51:08] yeah, I'll do that and prepare a deployment branch for later today.... [18:51:22] kaldari: Thank you!!! [18:52:00] I might drop by the office later this afternoon - I will bring you a bubble tea :) [18:52:13] Maryana: do it! [18:52:17] we can go for after work drinks! [18:59:35] Eek that is a rotten bug! Always on Fridays… [18:59:48] indeed [19:00:38] Sounds like Kaldari is on it, tho [19:04:13] * kristenlans cheers for Kaldari [20:19:22] (03CR) 10Mhurd: "Added notes. Will amend." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/152848 (owner: 10Mhurd) [20:23:07] (03CR) 10Yuvipanda: Dom transformations no longer "thrash". (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/152848 (owner: 10Mhurd) [20:24:43] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/152848 (owner: 10Mhurd) [20:25:12] yuvipanda: can there be more than one infobox on a page? [20:25:26] mhurd: theoretically no :) there are other infobox like boxes. [20:25:34] mhurd: legoktm or quiddity can give a more authoritative answer, I think [20:25:51] yuvipanda: so “table.infobox:nth-of-type(1)” should be ok? [20:25:56] yuvipanda: just to be safe? [20:26:05] mhurd: querySelector always returns only one element [20:26:12] mhurd: querySelectorAll returns a list of elements [20:26:15] yuvipanda: oh that’s right! [20:26:19] yuvipanda: duuur [20:26:23] :) [20:26:24] mhurd, https://en.wikipedia.org/wiki/Mini [20:26:25] mhurd: :) [20:26:43] many vehicle articles, have multiple infoboxes. (the result of mergism) [20:26:52] (cars, planes, tanks, etc) [20:26:53] quiddity: ah! thanks! [20:27:20] np :) [20:27:38] yuvipanda: so for infobox if i do querySelector( "table.infobox" ) it will just return the first one it finds? [20:28:00] yuvipanda: suppose i can try it :) [20:29:22] mhurd: Welcome back [20:29:28] vbamba: thanks! [20:31:35] (03PS5) 10Mhurd: Dom transformations no longer "thrash". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/152848 [20:31:41] yuvipanda: ^ [20:36:57] (03PS1) 10Kaldari: Remove forced hardware acceleration in overlays on iOS [extensions/MobileFrontend] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154324 (https://bugzilla.wikimedia.org/68880) [20:38:26] (03PS2) 10Mhurd: Further protection against corrupting css on build and sync. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153696 [20:38:55] (03CR) 10Kaldari: [C: 032] Remove forced hardware acceleration in overlays on iOS [extensions/MobileFrontend] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154324 (https://bugzilla.wikimedia.org/68880) (owner: 10Kaldari) [20:39:27] (03Merged) 10jenkins-bot: Remove forced hardware acceleration in overlays on iOS [extensions/MobileFrontend] (wmf/1.24wmf16) - 10https://gerrit.wikimedia.org/r/154324 (https://bugzilla.wikimedia.org/68880) (owner: 10Kaldari) [20:41:45] kaldari: \o/ [20:42:00] what flavor bubble tea you want? :) [20:42:48] Maryana: well, there's still the issue of how to deploy it. No SWAT deploys on Friday. I'll have to ask greg-g. [20:43:08] monday morning? [20:43:14] err [20:43:21] This is a pretty ugly bug [20:43:34] Garbled search results for anyone on iOS [20:43:36] greg-g: where are you at? [20:44:08] I'd really hate to leave this broken all weekend [20:44:14] agreed [20:44:18] ahh, no idea what it was :) [20:44:56] https://bugzilla.wikimedia.org/show_bug.cgi?id=68880 ? [20:45:09] Yep [20:45:29] yucky [20:45:39] Yeah :( [20:45:49] kaldari: can you do it now and babysit it a bit? [20:46:14] greg-g: sure [20:46:34] Thanks d00ds [20:47:58] greg-g: Since no one else is deploying today, I guess ASAP is best? [20:48:05] yeppers [20:58:42] (03PS2) 10Dduvall: QA: Workaround for cookie domain bug in chrome webdriver [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154217 [20:59:56] Maryana, greg-g: deployment complete [21:01:30] kaldari: did the world end? [21:01:54] greg-g: So far, so good :) It was only CSS changes (but important ones) [21:02:14] ^5 [21:02:25] ^5 [21:02:40] Looking good from where I am kaldari :D [21:02:48] yay [21:03:04] Maryana: You missed the excitment [21:03:10] What happened? [21:03:16] I'm almost to office [21:03:19] I deployed the fix and it worked :) [21:03:26] (03CR) 10JGonera: [C: 032] QA: Workaround for cookie domain bug in chrome webdriver [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154217 (owner: 10Dduvall) [21:03:27] Oh nice! [21:03:45] I'll be in shortly with your reward, kaldari [21:04:11] Maryana: Did you buy some bubble tea? [21:04:21] Maaaybe [21:04:37] (03Merged) 10jenkins-bot: QA: Workaround for cookie domain bug in chrome webdriver [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154217 (owner: 10Dduvall) [21:10:18] (03PS1) 10JGonera: QA: Ensure that we wait for editor close button to appear [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154337 [21:21:18] (03CR) 10Cmcmahon: [C: 032] "good practice" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154337 (owner: 10JGonera) [21:22:11] (03Merged) 10jenkins-bot: QA: Ensure that we wait for editor close button to appear [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154337 (owner: 10JGonera) [21:44:46] (03PS2) 10Kaldari: WIP: WikiGrok interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154299 [21:48:08] kaldari, jgonera, jdlrobson: I must annoy you :) There are two changes i would be very happy to get a review asap :-) https://gerrit.wikimedia.org/r/#/c/152748/ and https://gerrit.wikimedia.org/r/#/c/150592/ [21:48:18] (03CR) 10jenkins-bot: [V: 04-1] WIP: WikiGrok interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154299 (owner: 10Kaldari) [21:49:53] FlorianSW|away: so with respect to https://gerrit.wikimedia.org/r/#/c/152748/2/includes/specials/SpecialUploads.php still my confusion lays around what you are trying to do [21:50:16] What is the difference between UploadBase::isallowed( $user ) and $mobileContext->userCanUpload() for example [21:50:52] UploadBase::isAllowed checks for the core upload right. usercanUpload checks for min edits for upload [21:51:13] and why do we even need to check empty( $wgMFPhotoUploadEndpoint ) any more? [21:51:26] that means, that you can be allowed to upload (you have upload right, e.g. used for desktop) but have no 75 edits (actual setting on wikimedia) to use the mobile upload [21:51:50] empty( $wgMFPhotoUploadEndpoint ) basically means imagesUploadToLocalWiki = true [21:52:25] i think that how if statement needs gutting to just be $mobileContext->userCanUpload() && [21:52:28] correct. And with !empty( $wgMFPhotoUploadEndpoint ) we check, if the upload goes to commons (in wikimedia setting [21:52:33] and the logic should be moved over there [21:52:57] $isAllowed = $mobileContext->userCanUpload() [21:53:04] much more readable :) [21:53:37] you mean to move the complete logic to userCanUpload()? [21:54:15] i think so. It's got to the point that i don't even understand what the existing code is doing any more and this is making it even more confusing :) [21:55:13] hmm, that sounds totally logical :) I don't know, why we don't do it from the beginning oO [21:57:48] (03CR) 10Kaldari: [C: 04-1] Check userCanUpload when wgMFPhotoUploadEndpoint is set (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [21:59:21] kaldari: FlorianSW remember $wgMFPhotoUploadEndpoint. is a url of undefined [21:59:43] I think the issue it is trying to solve is this one: [21:59:57] if you are on English Wikipedia, we don't know whether you are allowed to upload to commons or banned from commons [22:00:11] so i think it was guessing that you were allowed to upload [22:00:43] So I think the UploadBase stuff should only apply when is not set $wgMFPhotoUploadEndpoint [22:00:51] jgonera, jdlrobson: Any idea why Jenkins keeps throwing a qunit failure for this: https://gerrit.wikimedia.org/r/#/c/154299/ . I completely emptied the js files and it still gives the same error. [22:01:01] yeah, the basic check is, if you are allowed to upload OR endpoint is set (so we can't check if you are allowed and think you are) [22:01:02] so $mobileContext->userCanUpload() should be something like if ( $uploadingToForeignWiki ) { // do this } else { // do that }} [22:01:20] yeah, my idea :) [22:01:31] kaldari: Message: Modules in error state [22:01:45] jdlrobson: Well, I know that much, but why? [22:01:55] kaldari: i suspect you have to be more explicit in your dependencies in 'mobile.wikigrok' [22:03:00] kaldari: shouldn't it be other way round? [22:03:25] e.g. 'mobile.alpha' depends on 'mobile.wikigrok' [22:03:41] jdlrobson: No [22:03:55] oh wait i see what you mean [22:04:15] wikigrok.js is just a loader for the mobile.wikigrok module [22:04:23] kaldari: have you opened up Special:JavaScriptTest/QUnit [22:04:47] jdlrobson: yeah, the MF stuff looks OK there [22:05:14] kaldari: try disabling all extensions except MobileFrontend [22:05:15] usually surfaces problems for me [22:05:24] as that's how jenkins runs [22:05:24] jdlrobson: good idea :) [22:05:49] kaldari: i suspect you need to declare the dependency to where the Drawer.js code is though [22:06:32] jdlrobson: oh, maybe so, I just assumed it was in the regular module chain [22:07:18] kaldari: i can replicate locally [22:09:50] kaldari: never good in dependencys to be vague [22:10:30] (03PS1) 10JGonera: QA: Fix browser tests for issues (cleanup templates) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154345 [22:10:55] jdlrobson: I don't get any qunit errors locally [22:11:09] kaldari: i worked it out [22:11:23] ready to face palm yourself? [22:11:29] jdlrobson: nevermind, now I see it [22:11:30] 'javascripts/modules/wikigrok.js' => 'javascripts/modules/wikigrok/wikigrok.js' [22:11:41] yep [22:11:43] :) [22:12:10] also, I was looking at the qunit tests on desktop :P [22:12:33] http://www.wrenroberts.com/wp-content/uploads/2013/11/Picard-Riker-Facepalm.jpg [22:12:54] jdlrobson: thanks :P [22:16:18] (03PS3) 10Kaldari: WIP: WikiGrok interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154299 [22:18:56] (03PS3) 10Florianschmidtwelzow: Check userCanUpload when wgMFPhotoUploadEndpoint is set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) [22:21:33] (03PS4) 10Florianschmidtwelzow: Check userCanUpload when wgMFPhotoUploadEndpoint is set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) [22:23:38] wikibombssss http://mobile.abc.net.au/news/2014-08-14/women-scientists-work-to-right-wrongs-with-wikibomb/5671332 [22:28:27] (03PS1) 10JGonera: QA: Fix login tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154349 [22:33:34] FlorianSW|away: you still around? [22:33:49] kaldari: ever :) [22:33:56] away means: not reading, so ping me :)= [22:34:35] (03CR) 10Cmcmahon: [C: 032] QA: Fix login tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154349 (owner: 10JGonera) [22:34:58] (03Abandoned) 10Cmcmahon: QA: Login behavior on main page is now simpler [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154085 (owner: 10Cmcmahon) [22:35:07] (03Merged) 10jenkins-bot: QA: Fix login tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154349 (owner: 10JGonera) [22:35:15] FlorianSW: https://gerrit.wikimedia.org/r/#/c/150592 seems to work, but I have no idea why. The change is on Special:MobileDiff, but the patch only touches SpecialMobileContributions and SpecialMobileHistory. Very mysterious. [22:36:03] kaldari: there was another patch... wait [22:36:13] ah ja, here: https://gerrit.wikimedia.org/r/#/c/150588/ [22:36:31] this change replaces the link, my patch enables the show :) [22:36:47] the problem: The change of the link is merged, but not the one to enable the display :/ [22:37:09] that means, that actual all links on MobileDiff to anon IP's runs into a "Not found" (mobile unformatted) page [22:37:21] that's why i'm happy if this get's reviewed asap :) [22:37:51] FlorianSW: Ah, that makes more sense :) [22:37:57] yap :) [22:38:47] if this get's merged i would suggest to backport this to wmf17, too, to fix this on wikipedias at 21 of August :) [22:48:52] (03CR) 10Kaldari: [C: 04-1] Show IP's contributions on SpecialMobileContributions, too (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150592 (https://bugzilla.wikimedia.org/68775) (owner: 10Florianschmidtwelzow) [22:50:25] (03CR) 10Jdlrobson: [C: 032] Show IP's contributions on SpecialMobileContributions, too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150592 (https://bugzilla.wikimedia.org/68775) (owner: 10Florianschmidtwelzow) [22:51:05] (03Merged) 10jenkins-bot: Show IP's contributions on SpecialMobileContributions, too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150592 (https://bugzilla.wikimedia.org/68775) (owner: 10Florianschmidtwelzow) [22:52:01] (03CR) 10Florianschmidtwelzow: Show IP's contributions on SpecialMobileContributions, too (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150592 (https://bugzilla.wikimedia.org/68775) (owner: 10Florianschmidtwelzow) [22:52:11] (03CR) 10Jdlrobson: Check userCanUpload when wgMFPhotoUploadEndpoint is set (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [22:52:14] (03PS1) 10Florianschmidtwelzow: Show IP's contributions on SpecialMobileContributions, too [extensions/MobileFrontend] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154353 (https://bugzilla.wikimedia.org/68775) [22:54:12] (03CR) 10Florianschmidtwelzow: Check userCanUpload when wgMFPhotoUploadEndpoint is set (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [22:54:24] thx jdlrobson :) [22:56:49] kaldari: I haven't understood the raw process of backporting i think :/ Now i have cherry picked the change i want to backport to an already created branch (and deployed to some wikimedia wikis). Now there needs a SWAT, right? [22:57:01] (03CR) 10Jdlrobson: Insert section name in edit summary (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [22:57:29] 3MobileFrontend / 3stable: VisualEditor Mobile: [iOS] abandoning edit takes me to unscrollable page - 10https://bugzilla.wikimedia.org/69630 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Observed on iPad. Steps to repro: 1. Go into VE edit mode on an article and enter the link inspector 2. Us... [22:58:46] (03CR) 10Jdlrobson: [C: 031] "Code looks okay but don't understand this part of mediawiki that well" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [23:00:27] 3MobileFrontend / 3stable: VisualEditor Mobile: [iOS] abandoning edit takes me to unscrollable page - 10https://bugzilla.wikimedia.org/69630#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ttlYWwkt [23:00:29] FlorianSW: The process is typically... Cherry pick the change to a deployment branch of the extension (for example wmf/1.24wmf16), get that cherry pick merged, update the extension submodule in the core deployment branch, commit that core update, but don't merge it, post that core update as a requested SWAT deployment on the deployment schedule on Wikitech wiki. [23:00:48] The weekend is starting on the East Coast! See you guys on Monday :-) [23:01:01] kristenlans: Cya! [23:01:20] weekend since 1 hour, yeah! Europe for the win! :D [23:03:22] jdlrobson: https://gerrit.wikimedia.org/r/#/c/150592/ [23:04:03] kaldari: Ok, i will look if i can do that :D [23:05:10] (03CR) 10Kaldari: [C: 04-1] Show IP's contributions on SpecialMobileContributions, too (031 comment) [extensions/MobileFrontend] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154353 (https://bugzilla.wikimedia.org/68775) (owner: 10Florianschmidtwelzow) [23:05:27] 3MobileFrontend / 3stable: VisualEditor Mobile: [iOS] abandoning edit takes me to unscrollable page - 10https://bugzilla.wikimedia.org/69630#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/kzlyuZku [23:06:03] hmm, bingle is dupe-ing bugs [23:06:28] * Maryana smacks bingle [23:10:21] (03CR) 10Kaldari: [C: 032] Check userCanUpload when wgMFPhotoUploadEndpoint is set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [23:10:54] (03Merged) 10jenkins-bot: Check userCanUpload when wgMFPhotoUploadEndpoint is set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/152748 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [23:12:15] (03PS1) 10Florianschmidtwelzow: Remove htmlspecialchars [extensions/MobileFrontend] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154358 [23:12:51] grrrrrr [23:13:56] (03PS2) 10Florianschmidtwelzow: Show IP's contributions on SpecialMobileContributions, too [extensions/MobileFrontend] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154353 (https://bugzilla.wikimedia.org/68775) [23:14:11] (03Abandoned) 10Florianschmidtwelzow: Remove htmlspecialchars [extensions/MobileFrontend] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154358 (owner: 10Florianschmidtwelzow) [23:15:06] (03PS1) 10Florianschmidtwelzow: Remove useless htmlspecialchars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154359 [23:17:17] (03CR) 10Jdlrobson: [C: 04-1] "lolz 1am coding" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154359 (owner: 10Florianschmidtwelzow) [23:17:25] (03CR) 10Florianschmidtwelzow: Insert section name in edit summary (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [23:17:27] FlorianSW: hehe [23:18:27] (03CR) 10Jdlrobson: [C: 04-1] "Looks great! Fix the indent and i'll throw down the +2 hammer :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [23:18:43] ^ FlorianSW if you are quick i can +2 both those patches [23:19:02] jdlrobson: this i don't understand: https://gerrit.wikimedia.org/r/#/c/154359/1/includes/specials/SpecialMobileContributions.php [23:19:02] :D [23:19:10] it looks correct for me :) [23:19:36] standard is to use $par (the username), and if $par isn't IP, then use "correct" userpaghe [23:20:07] FlorianSW: it looks like an unnecessary assignemnt [23:20:20] it's like $a = 4; $b = $a [23:20:37] not really :) [23:20:41] $userPage is used in renderHeaderBar [23:20:55] and we must decide what we give as parameter for this :) [23:21:11] if the user is anon we just give $par, if he isn't we give the title object of his userpage :) [23:21:20] (03CR) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [23:21:24] (03PS19) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) [23:21:46] also renderHeaderBar should take a Title [23:22:44] (03PS20) 10Florianschmidtwelzow: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) [23:23:09] (03CR) 10Jdlrobson: [C: 032] Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [23:23:42] (03Merged) 10jenkins-bot: Enable View of "new messages on talk page" without Echo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138229 (https://bugzilla.wikimedia.org/56834) (owner: 10Florianschmidtwelzow) [23:24:26] jdlrobson: it's like $a = 4; if ( 5 === $i ) { $a = $i } renderHeaderBar( $a ); [23:24:42] if ( !User::isIP( $par ) ) { $userPage = $this->user->getUserPage(); } else { $this->renderHeaderBar( Title::newFromText( $par ) ); } [23:24:58] 3MobileFrontend / 3Feature requests: Standard pre-echo "you have new messages" bar is not displayed - 10https://bugzilla.wikimedia.org/56834 (10Florian) 5PATC>3RESO/FIX [23:25:03] $par is a string and $userPage should be a Title [23:25:18] unless i'm misunderstanding something? [23:26:11] jdlrobson: userPage can be object of title or a string. But no matter what type, we want to give it as the first parameter of renderHeaderBar (this is the only place we use this) :) [23:26:32] FlorianSW: not according to the documentation ;-) [23:26:42] getHeaderBarLink calls $title->getLocalUrl() in SpecialMobileHistory [23:27:17] and in Contributions SpecialPage::getTitleFor( 'UserProfile', $title->getText() )->getLocalUrl(), [23:27:22] if $title is a string... [23:27:40] not with this change: https://gerrit.wikimedia.org/r/#/c/150592/3/includes/specials/SpecialMobileHistory.php [23:28:03] if $title is a string we don't call getHeaderBarLink [23:28:08] ah wait let me rebase [23:28:12] :P [23:28:31] (03PS2) 10Jdlrobson: Remove useless htmlspecialchars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154359 (owner: 10Florianschmidtwelzow) [23:30:56] FlorianSW: okay in that case that's less worrying [23:30:57] (03PS1) 10Florianschmidtwelzow: Check userCanUpload when wgMFPhotoUploadEndpoint is set [extensions/MobileFrontend] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154364 (https://bugzilla.wikimedia.org/62598) [23:31:09] jdlrobson: yeah :) [23:31:23] i still thing $userPage = $par; looks kinda weird, and i think $this->renderHeaderBar( $par ); in an else would be more readable but that's just a personal coding convention thingy [23:31:42] re-assigning variables just for readability always seems a little weird to me [23:32:08] maybe $par should be renamed to $username [23:32:30] hmm, i think it's personal :) But if you feel better i can write into else :P [23:32:40] $par -> $username possible, too :) [23:33:09] i'd just use an else [23:33:30] if ( User::isIP( $par ) ) { $this->renderHeaderBar( $par ); } else { $this->renderHeaderBar( $this->user->getUserPage() ); } [23:35:40] (03PS3) 10Florianschmidtwelzow: Remove useless htmlspecialchars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154359 [23:36:53] (03CR) 10Jdlrobson: [C: 04-1] "I added a discussion but it didn't show up in overlay :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153341 (https://bugzilla.wikimedia.org/64105) (owner: 10Florianschmidtwelzow) [23:37:36] (03CR) 10Jdlrobson: [C: 032] Remove useless htmlspecialchars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154359 (owner: 10Florianschmidtwelzow) [23:38:10] (03Merged) 10jenkins-bot: Remove useless htmlspecialchars [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154359 (owner: 10Florianschmidtwelzow) [23:39:46] (03PS3) 10Florianschmidtwelzow: Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 [23:42:58] jdlrobson: About your comment at https://gerrit.wikimedia.org/r/#/c/153341/3: This is in master, too, and get fixed in this change (which depends on the change you commented): https://gerrit.wikimedia.org/r/#/c/153957/3. What to do? Move the fix? [23:44:25] FlorianSW: it is? ergg [23:44:37] FlorianSW: i'm not sure i'll take a look monday [23:44:42] talk feature could really do with tests [23:44:43] ok :) [23:45:27] now weekend for you? :D [23:47:18] FlorianSW: getting there yehhh ;-) [23:47:45] Great! wish you a good one :)