[00:05:12] 3MobileFrontend / 3stable: Mediawiki.ui: Blue input indicators showing up on mobile & not formatted for it - 10https://bugzilla.wikimedia.org/69724#c1 (10Jon) I think the solution to this is to stop using a different login page for mobile. Currently mobile rewrites the login page. We shouldn't have to do thi... [00:05:28] 3MobileFrontend / 3stable: Mediawiki.ui: Blue input indicators showing up on mobile & not formatted for it - 10https://bugzilla.wikimedia.org/69724#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/nxvLBVNW [00:05:52] (03CR) 10BearND: "sorry, comments were in PS2" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153814 (owner: 10Dbrant) [00:11:14] (03PS7) 10Kaldari: Redirect to mobile diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [00:13:03] MaxSem: Can you take a look at https://gerrit.wikimedia.org/r/#/c/148613 ? Ity [00:13:18] it's all PHP and I rewrote it, so I can't +2 [00:17:11] jgonera: Any thoughts about my comments on https://gerrit.wikimedia.org/r/#/c/151251/ ? [00:17:58] (03CR) 10MaxSem: [C: 04-1] Redirect to mobile diff page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [00:18:08] kaldari, ^ [00:20:37] (03PS8) 10Kaldari: Redirect to mobile diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [00:20:46] MaxSem: Good catch. Fixed. [00:21:58] kaldari, I'm not sure if my comment was clear... I'll come to your desk in a moment [00:21:58] (03CR) 10MaxSem: [C: 032] Redirect to mobile diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [00:21:59] (03Merged) 10jenkins-bot: Redirect to mobile diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148613 (https://bugzilla.wikimedia.org/61489) (owner: 10Florianschmidtwelzow) [00:22:56] (03CR) 10Kaldari: [C: 032] QA: Fix browser tests for issues (cleanup templates) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154345 (owner: 10JGonera) [00:23:27] (03Merged) 10jenkins-bot: QA: Fix browser tests for issues (cleanup templates) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154345 (owner: 10JGonera) [00:23:44] (03CR) 10Kaldari: [C: 032] Make thumbnail caption color darker [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153726 (https://bugzilla.wikimedia.org/67005) (owner: 10JGonera) [00:24:16] (03Merged) 10jenkins-bot: Make thumbnail caption color darker [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153726 (https://bugzilla.wikimedia.org/67005) (owner: 10JGonera) [00:24:53] (03PS30) 10Mhurd: Nearby entry in main menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153071 [00:25:42] 3MobileFrontend / 3General/Unknown: Image caption text color is too light - 10https://bugzilla.wikimedia.org/67005 (10Florian) 5PATC>3RESO/FIX [00:26:12] 3MobileFrontend / 3Feature requests: normal diff links don't redirect to MobileDiff - 10https://bugzilla.wikimedia.org/61489 (10Florian) 5REOP>3RESO/FIX [00:29:21] (03PS4) 10Kaldari: Hygiene: Avoid loading absent module. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151793 (owner: 10Jdlrobson) [00:29:52] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Avoid loading absent module. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151793 (owner: 10Jdlrobson) [00:34:44] (03CR) 10Kaldari: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151793 (owner: 10Jdlrobson) [00:35:06] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Avoid loading absent module. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151793 (owner: 10Jdlrobson) [00:36:27] 3MobileFrontend / 3stable: IP link in diff shouldn't take you to IP's user page - 10https://bugzilla.wikimedia.org/68775 (10Jon) 5PATC>3RESO/FIX [00:39:18] (03PS1) 10Jdlrobson: Remove rounded corners on login form to get more login form consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154979 (https://bugzilla.wikimedia.org/69724) [00:39:41] (03CR) 10jenkins-bot: [V: 04-1] Remove rounded corners on login form to get more login form consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154979 (https://bugzilla.wikimedia.org/69724) (owner: 10Jdlrobson) [00:39:55] (03PS2) 10Jdlrobson: Remove rounded corners on login form to get more login form consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154979 (https://bugzilla.wikimedia.org/69724) [00:40:17] (03CR) 10jenkins-bot: [V: 04-1] Remove rounded corners on login form to get more login form consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154979 (https://bugzilla.wikimedia.org/69724) (owner: 10Jdlrobson) [00:42:22] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151793 (owner: 10Jdlrobson) [00:46:47] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151793 (owner: 10Jdlrobson) [00:47:09] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Avoid loading absent module. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151793 (owner: 10Jdlrobson) [00:55:05] nah, doesn't want to work:P [01:00:30] (03PS8) 10Mhurd: Much faster table of contents. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154369 [03:48:43] (03PS2) 10Mhurd: Fix for web view scroll delay. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154858 [03:55:28] (03PS9) 10Mhurd: Much faster table of contents. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154369 [03:56:12] (03PS3) 10Mhurd: Fix for web view scroll delay. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154858 [05:02:41] (03PS10) 10Mhurd: Much faster table of contents. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154369 [05:03:26] (03PS4) 10Mhurd: Fix for web view scroll delay. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154858 [12:35:39] (03CR) 10Dbrant: Put disambiguation links into a popup dialog. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153814 (owner: 10Dbrant) [12:36:08] (03PS4) 10Dbrant: Put disambiguation links into a popup dialog. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153814 [13:02:50] (03CR) 10Dbrant: Remember recently-used languages, and keep them at the top. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154874 (https://bugzilla.wikimedia.org/69175) (owner: 10Dbrant) [13:03:37] (03PS3) 10Dbrant: Remember recently-used languages, and keep them at the top. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154874 (https://bugzilla.wikimedia.org/69175) [14:20:17] MaxSem: are you here? [14:22:11] yup [14:23:24] can you merge this backport, so i can schedule a swat? https://gerrit.wikimedia.org/r/#/c/154364/ :) [14:47:22] (03PS5) 10Dbrant: Put disambiguation links into a popup dialog. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153814 [15:03:19] (03CR) 10MaxSem: [C: 032] Check userCanUpload when wgMFPhotoUploadEndpoint is set [extensions/MobileFrontend] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154364 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [15:04:08] (03Merged) 10jenkins-bot: Check userCanUpload when wgMFPhotoUploadEndpoint is set [extensions/MobileFrontend] (wmf/1.24wmf17) - 10https://gerrit.wikimedia.org/r/154364 (https://bugzilla.wikimedia.org/62598) (owner: 10Florianschmidtwelzow) [15:04:41] MaxSem: thx :) [15:29:24] hi Deskana [15:29:49] Hey aharoni! [15:29:52] Can you please try again to see if you still see this problem with the canned edit summaries in he.wiki ? [15:30:27] If I understood correctly, buttons looked weird when you looked at them with English UI. [15:30:35] MaxSem: Does a swat schedule need a wikimedia employee/contractor as a irc contact person/developer, or can it be a volunteer? [15:30:46] no [15:30:56] anyone can do so [15:31:37] ok :) [15:31:52] aharoni: I also changed to Hebrew UI and had a similar problem (the second screenshot). Let me take a look again, though. [15:33:11] Deskana: then I'm not sure what is the problem, because the second screenshot looks OK to me. Are you talking about the spill over to the next line? [15:33:40] aharoni: Oh, no, you're right. It's fine now. :) [15:33:52] aharoni: Thanks! [15:34:01] Deskana: ah, the frightening ease of fixing a gadget in production without any review :) [15:45:05] aharoni: This actually helped me find one or two issues with ULS. Should I show them to you too? [15:45:19] Yes, please. [15:45:28] Feel free to file bugs, of course. [15:46:10] I'll do that! [15:51:22] Deskana: thanks [15:51:52] aharoni: It's relatively trivial, but still. :) [16:13:55] bawolff: btw. java + safari... [16:14:02] was that reenabled ? [16:14:47] there is a complaint on commons that people can't get it working (neither can i), but i thought it was disabled in favor of file downloads over the last few months.... [16:15:18] (03CR) 10BearND: [C: 032] Remember recently-used languages, and keep them at the top. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154874 (https://bugzilla.wikimedia.org/69175) (owner: 10Dbrant) [16:16:32] (03CR) 10BearND: [V: 032] Remember recently-used languages, and keep them at the top. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154874 (https://bugzilla.wikimedia.org/69175) (owner: 10Dbrant) [16:16:34] (03Merged) 10jenkins-bot: Remember recently-used languages, and keep them at the top. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154874 (https://bugzilla.wikimedia.org/69175) (owner: 10Dbrant) [16:24:03] (03PS6) 10BearND: Put disambiguation links into a popup dialog. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153814 (owner: 10Dbrant) [17:12:00] (03CR) 10BearND: Put disambiguation links into a popup dialog. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153814 (owner: 10Dbrant) [17:12:30] (03CR) 10BearND: [C: 032] "Nice CSS trick to hide multiple amboxes." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153814 (owner: 10Dbrant) [17:12:49] (03Merged) 10jenkins-bot: Put disambiguation links into a popup dialog. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/153814 (owner: 10Dbrant) [17:25:48] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 (https://bugzilla.wikimedia.org/68438) (owner: 10Dbrant) [17:29:07] (03PS1) 10BearND: Correct order of arguments in assertEquals [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/155074 [17:29:16] moizsyed: design question if you have a sec [17:29:37] kaldari: oh sure, let me get out of this meeting [17:29:41] kaldari: i'll come by [17:37:51] (03PS5) 10Jdlrobson: Hygiene: Avoid loading absent module. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151793 [17:37:56] (03CR) 10Jdlrobson: [C: 032] Hygiene: Avoid loading absent module. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151793 (owner: 10Jdlrobson) [17:38:27] (03Merged) 10jenkins-bot: Hygiene: Avoid loading absent module. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151793 (owner: 10Jdlrobson) [17:40:13] 3Wikipedia App / 3Generic: App stops responding after being used for a while - 10https://bugzilla.wikimedia.org/64450#c8 (10Dan Garry) Is this still an issue? [17:44:57] 3Wikipedia App / 3iOS App: iOS: Special pages do nothing when clicked - 10https://bugzilla.wikimedia.org/63973#c2 (10Dan Garry) Should we just bump these to the browser? [17:46:13] 3Wikipedia App / 3iOS App: iOS app: Credits screen needs improvement - 10https://bugzilla.wikimedia.org/64391#c3 (10Dan Garry) We should just make the iOS screen look more like the Android one. [17:50:42] 3Wikipedia App / 3Android App: Text Looks garbled when using Bengali - 10https://bugzilla.wikimedia.org/66125#c6 (10Dan Garry) Is this still an issue? [17:54:27] 3Wikipedia App / 3Generic: Using "random" and go home when "loading random page" then return crashes the app - 10https://bugzilla.wikimedia.org/65609#c6 (10Dan Garry) I don't understand how to reproduce this bug. Can someone explain? [17:54:35] Deskana|Away: heya! [17:54:42] 3Wikipedia App / 3Generic: Using "random" and go home when "loading random page" then return crashes the app - 10https://bugzilla.wikimedia.org/65609 (10Dan Garry) 5PATC>3NEW [17:55:28] 3Wikipedia App / 3Generic: Using "random" and go home when "loading random page" then return crashes the app - 10https://bugzilla.wikimedia.org/65609#c7 (10Yuvi Panda) 5NEW>3RESO/FIX We used to have a dialog box that popped up when you hit 'random' saying 'Loading random page...'. We no longer do. [18:00:20] I am officially about to close Brazil (n the Hood). [18:00:28] 3Wikipedia App / 3iOS App: iOS app: Credits screen needs improvement - 10https://bugzilla.wikimedia.org/64391#c4 (10Vibha Bamba) Mostly agree, but this I assume this has to be prioritized against everything else we are trying to get done. [18:03:41] Maryana: you may want to take a spin through the Current Sprint and make sure things are in the right priority. I think Trello might have Trollo’ed me on the order when I moved stuff. [18:03:55] word. will do [18:10:48] (03PS3) 10Kaldari: Hygiene: Fixing formatting of Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151251 [18:10:53] kristenlans: ok, it's tidied up now :) [18:11:42] yey! thanks :-) [18:21:12] 3Wikipedia App / 3Android App: Text Looks garbled when using Bengali - 10https://bugzilla.wikimedia.org/66125#c7 (10Dmitry Brant) Can't reproduce on my devices... [18:50:00] Deskana|Away: sooo, unrelated, but I have hadoop access now, and by dint of it page view access [18:50:06] Deskana|Away: no idea how to use it, mind you. [18:50:07] still [18:50:08] access [19:20:52] bearND|brb: dbrant|brb btw, I'm getting preliminary page view stats for the apps :) [19:21:11] YuviPanda: nice!! [19:27:30] bearND: thanks for those merges! So, is the Gradle patch ready to merge? (does it coexist with the existing maven structure?) [19:28:16] dbrant: yes, the first gradle patch (without the [WIP]) is ready to be merged. [19:31:39] dbrant: about the page issues link. I merged it because I think it's a significant improvement. Still one minor thing I wanted to check with you, Deskana|Away, and Vibha: since both links open a dialog I think they should either both have the ellipsis at the end or none of them. [19:33:28] dbrant: There is also another patch in the java-mwapi: https://gerrit.wikimedia.org/r/#/c/155074/ [19:35:02] bearND: as it happens, the designers have reached a (new) consensus: https://trello.com/c/lADtYeQl (both with no ellipsis) [19:35:16] bearND: ...so I'll do one more (final) patch to take care of that! [19:37:17] (03CR) 10Dbrant: [C: 032 V: 032] Correct order of arguments in assertEquals [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/155074 (owner: 10BearND) [19:37:18] dbrant: cool [19:40:34] (03PS1) 10Dbrant: Final (for real) tweak of disambiguation styling/verbiage. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155104 [19:44:48] (03PS7) 10Dbrant: Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150973 (owner: 10BearND) [19:52:59] (03PS1) 10Yurik: Reduce image quality for srcset attribute [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/155108 [19:53:40] (03CR) 10Yurik: [C: 032] Reduce image quality for srcset attribute [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/155108 (owner: 10Yurik) [19:53:49] (03Merged) 10jenkins-bot: Reduce image quality for srcset attribute [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/155108 (owner: 10Yurik) [19:54:26] (03CR) 10BearND: [C: 032] Final (for real) tweak of disambiguation styling/verbiage. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155104 (owner: 10Dbrant) [19:58:10] (03CR) 10Dbrant: [C: 032] Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150973 (owner: 10BearND) [20:21:39] YuviPanda: did you open a bug on the bug i showed you @ wikimania? the flickring bug [20:21:56] matanya: I did not, matanya :( [20:22:03] can you open one? I'll add details [20:22:23] Maryana: same question for you for the talk page and cat icons on mobile web [20:22:31] doing YuviPanda [20:23:16] Still no stuff about Nearby on translatewiki :( [20:29:32] dbrant: thanks for the build! [20:29:41] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=69754 [20:29:45] 3Wikipedia App / 3Android App: screen flickers when scrolling down for the first time on page - 10https://bugzilla.wikimedia.org/69754 (10matanya) 3NEW p:3Unprio s:3normal a:3None This only happens on first scroll of the page. [20:31:45] (03Merged) 10jenkins-bot: Final (for real) tweak of disambiguation styling/verbiage. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155104 (owner: 10Dbrant) [20:31:47] (03Merged) 10jenkins-bot: Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150973 (owner: 10BearND) [20:34:46] sjoerddebruin: once the code gets merged I can to an export to translatewiki, but with brion being out and mhurd as the only iOS dev left that might take a while i guess [20:34:58] Just one iOS-dev? :O [20:35:19] sjoerddebruin: it’s been a busy year :) [20:35:50] sjoerddebruin: i’ll email brion [20:36:19] sjoerddebruin: he’s been coming online occasionally during his vacation [20:36:24] Ok [20:36:31] Btw, there was a review in the App Store: someone misses the dark mode. :/ [20:36:40] Other reviews were positive. :) [20:36:50] sjoerddebruin: ya we’re going to add that asap :) [20:37:11] Or are you waiting for iOS 8 first? [20:37:20] sjoerddebruin: no, had some crashy bugs to squash first [20:37:40] dbrant: Just reviewed all the changes with Jared. It looks great. [20:37:55] vbamba: nice! [20:37:56] Deskana|Away: Let us know when you take a look? [20:41:15] mhurd: hello! [20:41:19] vbamba: hey! [20:42:00] sjoerddebruin: email sent [20:42:04] mhurd: Wondering if I should cancel the version 4.0.1 review? [20:42:12] Since youve already submitted patches for the search fixes [20:43:17] (03PS1) 10BearND: Inherit Android platform version from parent project [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155124 [20:43:19] (03PS1) 10BearND: Add Http Request library to credits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155125 [20:43:21] (03PS1) 10BearND: Use new java-mwapi [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155126 [20:44:40] dbrant: I guess you can abandon https://gerrit.wikimedia.org/r/#/c/152191/ now ;) [20:45:44] 3Wikipedia App / 3Android App: Return to the section after a mobile section edit - 10https://bugzilla.wikimedia.org/69648 (10Bernd Sitzmann) [20:46:57] bearND: here's hoping! (still need Dan's signoff) [20:47:14] dbrant: ah, ok [20:47:49] (03CR) 10Dbrant: [C: 032] Inherit Android platform version from parent project [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155124 (owner: 10BearND) [20:52:23] vbamba: i think we’re pretty on-track addressing many of the review issues :) prob ok to cancel [20:54:36] (03CR) 10Dbrant: [C: 032] Add Http Request library to credits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155125 (owner: 10BearND) [20:56:49] (03CR) 10Dbrant: [C: 032] Use new java-mwapi [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155126 (owner: 10BearND) [20:58:04] dbrant: thanks for the merges. After Dan approves we should probably cut another beta, either today or tomorrow [20:59:01] bearND: definitely! [21:00:22] mhurd: ok sir! [21:05:07] bearND: That's the test build Dmitry sent out before, right? [21:05:32] Deskana: correct [21:06:03] bearND: I'll take a look now. In general I'm okay with us using very lenient criteria for pushing to beta. It's the beta, after all. :) [21:06:55] Deskana: yeah. Ideally we use the same code base for the next production release as well [21:08:15] bearND: Well, if the stuff in beta is ready to be pushed, sure. :) [21:08:29] bearND: But not every APK that goes to beta will go to production, necessarily. [21:08:40] Deskana: that's true [21:08:52] (03PS1) 10Yurik: Updated to match unified's global var name [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/155130 [21:09:01] Hmm, when did this become "Other meanings"? [21:09:26] (03PS2) 10Yurik: Test fix: Updated to match unified's global var name [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/155130 [21:09:33] (03CR) 10Yurik: [C: 032] Test fix: Updated to match unified's global var name [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/155130 (owner: 10Yurik) [21:09:44] Deskana: that was the design consensus: https://trello.com/c/lADtYeQl [21:09:45] (03Merged) 10jenkins-bot: Test fix: Updated to match unified's global var name [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/155130 (owner: 10Yurik) [21:09:45] Deskana: I think "Other meanings" came from UX (cc vbamba) [21:10:18] Hmm. I need to think about this a bit more before I'm ready to push this. [21:10:29] (to production, that is. It's fine to go to beta) [21:10:51] dbrant: Is this full-text search hooked up to Cirrus or is it using Lucene? [21:11:33] Deskana: I don't specify it explicitly. (I think the default is cirrus) [21:12:02] dbrant: Right, you're using the default. So that's Lucene on English Wikipedia. [21:12:13] dbrant: Deskana: is full-text search going to be ready soon? [21:13:20] Ah, dbrant (and bearND), I was going to ask what you guys wanted to do about the OTRS card, thanks for moving to next sprint. I’m working on closing out Sprint 37. [21:13:33] bearND, dbrant: I think it's looking good. We're going to need a bit more iterations for polishing, though. [21:13:44] Might need to steal Deskana for a moment (again) to see what we want to do with some of the stories in To Do. [21:14:25] bearND: you're welcome to try the patch and give feedback, as well [21:14:44] Deskana: ok, I'm going to rebase and then check it out [21:14:57] (03CR) 10JGonera: [C: 032] Hygiene: Fixing formatting of Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151251 (owner: 10Kaldari) [21:15:22] dbrant: can you do a manual rebase? (path conficlit during merge) [21:15:35] bearND: yep... [21:15:41] (03Merged) 10jenkins-bot: Hygiene: Fixing formatting of Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/151251 (owner: 10Kaldari) [21:16:15] (03PS12) 10Dbrant: [WIP] Implement full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 (https://bugzilla.wikimedia.org/68438) [21:16:24] dbrant: thanks [21:16:35] (03CR) 10JGonera: [C: 04-1] "Moiz says he wants rounded corners." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154979 (https://bugzilla.wikimedia.org/69724) (owner: 10Jdlrobson) [21:16:48] bearND, dbrant: This looks 100% good to go to beta, though. :) [21:17:00] Deskana: you mean full-text search? [21:17:11] dbrant: Yeah, sure. Why not? It's beta! [21:17:16] Deskana: excellent! [21:17:26] Do we have instrumentation in place to figure out how many people are using it? [21:17:57] Deskana: we do not... that will have to be a story. [21:18:45] Deskana: so then... how about syntax highlighting in Beta? [21:18:51] Okie doke. We need to be very careful with that too, since I don't want to be doing something like associating search queries with users. [21:19:19] Deskana: dbrant: didn't vbamba want another EL story? I think it was for disambig or page issues IIRC [21:19:33] bearND: yep, that's right. [21:19:34] in addition to full text search EL [21:19:51] (03CR) 10JGonera: "Why wouldn't you simply change && to ||?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [21:20:06] (03CR) 10JGonera: [C: 04-1] Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [21:20:44] bearND, dbrant: We can chat about that at the standup tomorrow. [21:21:58] My instinct says we can probably fit those in since we're still floating around in undefined territory about the onboarding stuff. [21:22:29] Deskana: yeah, I think we add those EL cards to this sprint [21:22:48] (03CR) 10JGonera: [C: 032] QA: Extension dependencies for geodata-related scenarios [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153988 (owner: 10Dduvall) [21:23:04] But still, we need to have a think about it. In particular, what questions do we want to answer and how are we going to measure that? [21:23:17] Absolute numbers of taps, which easy to implement, can be fairly useless. [21:23:19] (03Merged) 10jenkins-bot: QA: Extension dependencies for geodata-related scenarios [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153988 (owner: 10Dduvall) [21:25:50] (03CR) 10JGonera: [C: 04-1] Insert section name in edit summary (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [21:30:38] (03PS11) 10Mhurd: Much faster table of contents. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154369 [21:31:12] (03PS5) 10Mhurd: Fix for web view scroll delay. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154858 [21:35:41] Deskana: hey [21:36:41] Deskana: I've access to pageview data, and ran a query to see all pageviews for first week of august from the apps, and came up with 50k, which obviously can't be right. [21:36:45] (03CR) 10Florianschmidtwelzow: Insert section name in edit summary (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [21:37:19] (03PS16) 10Florianschmidtwelzow: Insert section name in edit summary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) [21:37:27] YuviPanda: Yay... [21:37:38] (03CR) 10JGonera: [C: 04-1] "Thanks for doing this. Please remove the readCookie and writeCookie methods and their tests too since this is dead code now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153741 (owner: 10Florianschmidtwelzow) [21:38:03] Deskana: Did you have a chance to review final copy? [21:38:52] Deskana: do you want access to it too? [21:39:00] YuviPanda: Absolutely. [21:39:03] Deskana: moment [21:39:31] vbamba: Yeah. I want to think about it a bit more and review it with Maryana and Howie. [21:41:01] (03PS2) 10Florianschmidtwelzow: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 [21:42:31] Deskana: submitted patchset, now we've to poke analytics to +2 it / find out the proces for it [21:45:29] (03PS2) 10Florianschmidtwelzow: Remove last non-test related use of writeCokkie/readCookie [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153741 [21:45:38] (03CR) 10jenkins-bot: [V: 04-1] Remove last non-test related use of writeCokkie/readCookie [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153741 (owner: 10Florianschmidtwelzow) [21:46:33] (03PS3) 10Florianschmidtwelzow: Remove last non-test related use of writeCokkie/readCookie [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153741 [21:50:49] jdlrobso_, what was the redis fix that Aaron came up with? [21:51:05] jgonera: haha i just hit vagrant issues again [21:51:12] so i guess whatever it was didn't solve my issue [21:51:21] jdlrobso_, but maybe it will solve mine ;) [21:51:25] aaron did say it was merged to vagrant master though [21:51:31] an imported page keeps loading for 2 minutes now [21:51:36] so if you are running latest vagrant it should be fine [21:51:45] I am... [21:51:51] he edited redis.conf [21:51:52] is he in the office? [21:51:54] and upped the memory [21:52:05] i haven't seen him today.. [21:52:06] try wikimedia-dev [21:52:27] jdlrobso_, what is the memory for redis on your instance? for me it's 256MB [21:52:38] what's his irc nick? [21:53:24] AaronShulz or something like that [21:59:44] 3Wikipedia App / 3Android App: Allow limiting of cache size - 10https://bugzilla.wikimedia.org/69761 (10Florian) 3NEW p:3Unprio s:3enhanc a:3None (Users with OTRS access: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7737787) The app uses space for caching. For devices w... [22:04:44] 3Wikipedia App / 3Android App: Allow creation of pages - 10https://bugzilla.wikimedia.org/69762 (10Florian) 3NEW p:3Unprio s:3enhanc a:3None Actually there is no way to create a new page (?) Is it planned to add this feature? (For OTRS members: https://ticket.wikimedia.org/otrs/index.pl?Action=Agent... [22:23:07] (03PS12) 10Mhurd: Much faster table of contents. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154369 [22:23:45] (03PS6) 10Mhurd: Fix for web view scroll delay. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154858 [22:45:06] (03CR) 10Jdlrobson: [C: 04-1] Enable anonymous editing in alpha mode (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [22:48:30] (03CR) 10Jdlrobson: "Writing some phpunit tests would really help you here from making mistakes :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [22:50:56] (03CR) 10Jdlrobson: [C: 04-1] "I would suggest writing a php unit test to go with this change." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [22:52:26] (03PS6) 10Jdlrobson: Improve Talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153341 (https://bugzilla.wikimedia.org/64105) (owner: 10Florianschmidtwelzow) [22:56:28] (03PS10) 10Jdlrobson: Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow) [22:56:46] (03CR) 10Jdlrobson: [C: 04-1] "Please add unit tests so this doesn't break again." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (owner: 10Florianschmidtwelzow) [22:57:04] (03CR) 10jenkins-bot: [V: 04-1] Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow) [23:00:17] (03CR) 10Jdlrobson: [C: 04-1] "Please add jquery.cookie dependency to mobile.stable.common RL module. Otherwise this is not explicit and might result in errors." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153741 (owner: 10Florianschmidtwelzow) [23:01:24] (03CR) 10Jdlrobson: [C: 04-1] "Appears to break it for me. Clicking talk opens a blank overlay." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow) [23:03:21] mhurd: Hey! [23:03:28] vbamba: hey! [23:03:33] got a sec to come hang at my monitor? [23:03:40] vbamba: ya be there in a minute [23:03:55] jared and I wanted to run some ideaz past you [23:04:57] (03PS7) 10Jdlrobson: Improve Talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153341 (https://bugzilla.wikimedia.org/64105) (owner: 10Florianschmidtwelzow) [23:04:59] (03PS1) 10Jdlrobson: Hide discussion button whilst it is broken [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155160 [23:05:32] 3MobileFrontend / 3beta: The add discussion button in talk overlay doesn't work - 10https://bugzilla.wikimedia.org/69763#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/mK89H5lq [23:07:33] (03PS20) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [23:07:35] (03CR) 10jenkins-bot: [V: 04-1] Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [23:08:17] (03CR) 10Jdlrobson: [C: 032] "I'm happy to merge this provided the patch I posted before this one that disables the add discussion button is merged first." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153341 (https://bugzilla.wikimedia.org/64105) (owner: 10Florianschmidtwelzow) [23:08:44] (03PS21) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) [23:09:17] (03CR) 10Florianschmidtwelzow: Enable anonymous editing in alpha mode (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [23:12:19] (03CR) 10Jdlrobson: [C: 032] Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [23:12:33] jdlrobson: jquery.cookie is loaded by mobile.startup? which is a dependency of mobile.stable.common, so really need to add the dependency again? https://gerrit.wikimedia.org/r/#/c/153741/ [23:12:46] FlorianSW: it's better to be explict [23:12:51] (03Merged) 10jenkins-bot: Enable anonymous editing in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/138802 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [23:12:51] you never know what will happen in the future [23:12:58] jdlrobson: ok :) [23:12:59] what if mobile startup gets killed? [23:13:08] right :P [23:14:00] jdlrobson: and this comment i don't understand :/ https://gerrit.wikimedia.org/r/#/c/153957/ what breaks again? There is no fix for a bug in this change? [23:15:37] (03PS4) 10Florianschmidtwelzow: Remove last non-test related use of writeCokkie/readCookie [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153741 [23:16:36] (03CR) 10Florianschmidtwelzow: "jquery.cookie: added" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153741 (owner: 10Florianschmidtwelzow) [23:25:10] jdlrobso_ have you seen my message (jdlrobson: and this comment i don't understand :/ https://gerrit.wikimedia.org/r/#/c/153957/ what breaks again? There is no fix for a bug in this change?) or were you logged of? [23:26:12] 3MobileFrontend / 3stable: IP link in diff shouldn't take you to IP's user page - 10https://bugzilla.wikimedia.org/68775#c9 (10Florian) Notice: Backported to wmf17 and working on wikivoyage :) [23:27:46] 3MobileFrontend / 3stable: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c160 (10Florian) 5PATC>3RESO/FIX The last patch is now backported to MW1.24wmf17 and works for me on commons and wikivoyage. Closing again as resolved. @Lupo (or/and others) can you reopen this,... [23:29:09] FlorianSW: ? [23:29:30] Add discussion is broken yes? [23:29:46] So I'm saying in a patch that fixes it we should write a unit test so that it doesn't break again :) [23:30:06] bug link: https://bugzilla.wikimedia.org/show_bug.cgi?id=69763 [23:30:42] uhm :D I don't know this bug :P [23:32:12] i will take a look, but qunit tests are really new for me :/ Another point (now you're here :P) can you just try to open the mobile page of wikisource? https://m.wikisource.org/wiki/Main_Page [23:32:23] jdlrobso_: ^ [23:34:07] FlorianSW: nope. wikisource is broken for me. [23:34:37] jdlrobso_ ah, ok, for me too. I will open a bug :) thanks for your try :P [23:34:42] FlorianSW: yeh unit tests are hard but they are worth the effort to get to understand. You'll end up writing better more resilient code and get reviews faster. [23:34:48] I'm happy to hand hold you in any way :) [23:35:21] :D thanks :P I will try to write the unit tests and just upload, like ever :P [23:42:40] FlorianSW: https://www.mediawiki.org/wiki/Extension:MobileFrontend/Writing_QUnit_tests [23:44:41] jdlrobso_ great :) I will take a look, but maybe tomorrow :/ Do you know, when this get merged? (https://gerrit.wikimedia.org/r/#/c/153341/7) [23:44:53] when someone merges https://gerrit.wikimedia.org/r/#/c/155160/1 :) [23:45:35] i'll merge it tomorrow without that fix if noone has. [23:45:39] i'd like the two to go out together though [23:46:03] (03PS5) 10Jdlrobson: Hygiene: Remove last non-test related use of writeCokkie/readCookie [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153741 (owner: 10Florianschmidtwelzow) [23:46:10] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove last non-test related use of writeCokkie/readCookie [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153741 (owner: 10Florianschmidtwelzow) [23:46:44] (03Merged) 10jenkins-bot: Hygiene: Remove last non-test related use of writeCokkie/readCookie [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153741 (owner: 10Florianschmidtwelzow) [23:46:45] maybe i said it false :D That i readed in your comment (if i understand it correctly), but you give a +2 to the patch, and i thought a +2 means, that gerrit merge it? So it's more a question: How did you add a merge dependency? :P [23:49:11] and i really doesn't see a problem with the add discussion button :/ jdlrobso_ [23:51:41] (03PS2) 10Florianschmidtwelzow: Hide discussion button whilst it is broken [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155160 (https://bugzilla.wikimedia.org/69763) (owner: 10Jdlrobson) [23:53:56] FlorianSW: Gerrit adds a dependency for all non-merged commits. You can do that by either checking out someone else's patch or have one or more local commits in the same branch that have not been merged; then create another commit based on that and push to gerrit [23:55:18] bearND: ah, ok, that i know :) I didn't know, that a merge wait's for all dependencies (thought, that all get merged :)), thanks :) [23:56:25] (03PS11) 10Florianschmidtwelzow: Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) [23:56:27] (03PS8) 10Florianschmidtwelzow: Improve Talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153341 (https://bugzilla.wikimedia.org/64105) [23:57:55] FlorianSW: it has to wait for the dependencies to get merged. You would not want Gerrit to merge dependencies automatically. That woud defeat the whole purpose of code review if something gets merged automatically just because another commit depends on it. [23:58:47] bearND: hm, right, the changes aren't visible as changes :)