[00:05:30] FlorianSW: i purposely added a dependency [00:05:38] (03CR) 10Jdlrobson: [C: 031] Improve Talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153341 (https://bugzilla.wikimedia.org/64105) (owner: 10Florianschmidtwelzow) [00:05:57] https://gerrit.wikimedia.org/r/155160 < I want this merged first [00:06:06] i thought the patch was confusing as it makes changes to a broken interface [00:06:36] äh...why i have removed it? :/ [00:06:46] i'm not sure but don't worry [00:07:22] no, i want to know, that means, that i have a review missing somewhere else :D [00:07:50] i mean there is no harm in merging either of them separately but the commit log is like a story and i think it's good to tell it in a logical way :) [00:08:48] argh, now i know: I have tested the change (to test the add discussion button) and thought: Why not rebase :D no, i think it's right so :) but no need to add it again, i think your comment say all :) [00:09:01] jdlrobson: can you shortly explain... he can not :D [00:10:00] jdlrobson: can you shortly explain what is broken in "add discussion" button? :/ [00:10:37] (03CR) 10Florianschmidtwelzow: [C: 04-1] "> Clicking talk opens a blank overlay." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow) [00:13:06] (03PS12) 10Florianschmidtwelzow: Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) [00:51:22] (03PS13) 10Mhurd: Much faster table of contents. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154369 [00:51:57] (03PS7) 10Mhurd: Fix for web view scroll delay. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154858 [01:07:08] (03CR) 10Florianschmidtwelzow: Fix wgMFShowRedLinks (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [01:10:43] 3MobileFrontend / 3beta: The add discussion button in talk overlay doesn't work - 10https://bugzilla.wikimedia.org/69763#c3 (10Florian) What isn't working with the button? Works for me on beta labs and local :/ [01:49:42] 3MobileFrontend / 3beta: The add discussion button in talk overlay doesn't work - 10https://bugzilla.wikimedia.org/69763#c4 (10Jon) 5PATC>3NEW Patch doesn't fix issue just hides it. so removing patch for review (shouldn't be on commit either) For me going tohttp://en.m.wikipedia.beta.wmflabs.org/wiki/0... [01:57:42] 3MobileFrontend / 3beta: The add discussion button in talk overlay doesn't work - 10https://bugzilla.wikimedia.org/69763#c5 (10Florian) Ah ok, i thought you mean, that the add doesn't work completly :) (The error in the console is "fixed" in this patch: https://gerrit.wikimedia.org/r/#/c/153341/ (but only by... [01:57:53] (03PS4) 10Florianschmidtwelzow: Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) [04:23:09] (03PS2) 10Yurik: Added ZeroConfig context search modes [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/154760 [04:32:02] (03PS1) 10Mhurd: Much better handling of TOC show/hide swipe. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/155193 [04:32:14] 3MobileFrontend / 3Hygiene: Separate Minerva skin from MobileFrontend, move to mediawiki/skins/Minerva - 10https://bugzilla.wikimedia.org/69366 (10Jon) a:3Jon [04:33:26] (03PS1) 10Mhurd: Delete all option for saved pages and recent. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/155194 [04:34:58] 3MobileFrontend / 3alpha: Add intermediate screen to warn logged-out editors similar to 'anoneditwarning' message - 10https://bugzilla.wikimedia.org/59937#c17 (10Jon) 5PATC>3NEW Florian I just realised your patch doesn't address this issue. Can you fix that in a follow up asap as otherwise I suspect we w... [07:15:46] 3MobileFrontend / 3stable: The mobile site does not display collapsible elements - 10https://bugzilla.wikimedia.org/69773 (10Strainu) 3NEW p:3Unprio s:3normal a:3None Latest Opera for Android on Android 4.4.x/Nexus 4. Collapsible elements such as the ones generated by {{collapse top}}/{{collapse bo... [07:20:27] 3MobileFrontend / 3stable: The mobile site does not display collapsible elements - 10https://bugzilla.wikimedia.org/69773#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/BghhAJXd [14:48:37] (03PS1) 10Dbrant: Add support for feature toggle of beta features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155268 [15:37:14] (03CR) 10Jdlrobson: "Well Moiz is in disagreement with the inputs as designed in all other places on MediaWiki and needs to work that out.. :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154979 (https://bugzilla.wikimedia.org/69724) (owner: 10Jdlrobson) [17:12:36] 3MobileFrontend / 3stable: The mobile site does not display collapsible elements - 10https://bugzilla.wikimedia.org/69773#c2 (10Ryan Kaldari) @Strainu: Is there a URL I can reproduce this bug at? [17:32:01] bearND: were you able to get limn running locally? [17:41:48] kaldari: poke [17:42:01] howdy [17:42:06] so I merged Florian's patch yesterday but i realised for some reason no IP anon editor warning is showing [17:42:24] so before it gets on deployment train we need to either fix that or disable anon editing in alpha [17:42:27] which patch? [17:42:52] kaldari: https://gerrit.wikimedia.org/r/138802 [17:43:01] i was hoping florian would be around to fix it [17:43:16] i can do a patch that removes the SkinMinervaAlpha enable code in case he doesn't show up [17:44:12] jdlrobson: Does that not have a config flag? [17:44:43] kaldari: https://gerrit.wikimedia.org/r/#/c/138802/21/includes/skins/SkinMinervaAlpha.php [17:44:57] i'm confused to what happened to the anon editor warning though [17:45:45] bearND: YuviPanda: I'm trying to follow the Readme in limn-mobile-data.... what is "coke"? [17:46:08] jdlrobson: So we always override the config flag in Alpha? That seems really bad for 3rd party users. [17:46:27] kaldari: yeh but it's documented with this caveat [17:46:36] in theory 3rd party users should be able to turn off beta and alpha [17:46:49] there should be a boolean for that [17:46:53] * jdlrobson raises bug [17:47:45] done [17:47:55] How do you turn off alpha? [17:48:07] 3MobileFrontend / 3beta: 3rd partys should be able to turn off beta and alpha mode - 10https://bugzilla.wikimedia.org/69793 (10Jon) 3NEW p:3Unprio s:3normal a:3None I can imagine some users will have little need for the beta/alpha mode. It does things such as enable anonymous editing which they might... [17:48:39] kaldari: you can't right now :) [17:48:47] kaldari anyway rewinding... [17:49:03] jdlrobson: In that case, for now, can we just either turn off anon editing in alpha or revert the patch? [17:49:31] kaldari: i'd say former is easiest right now [17:49:41] i wouldn't want to revert as florian did some good stuff in that patch [17:49:43] jdlrobson: Sorry I hadn't taken a look at that patch earlier [17:50:00] kaldari: okay i'll knock up a patch now [17:50:07] thanks! [17:50:35] 3MobileFrontend / 3beta: 3rd partys should be able to turn off beta and alpha mode - 10https://bugzilla.wikimedia.org/69793#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Ty5JaCqx [17:53:00] (03PS1) 10Jdlrobson: Revert enabling of anonymous editing in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155306 [17:53:35] 3MobileFrontend / 3alpha: Add intermediate screen to warn logged-out editors similar to 'anoneditwarning' message - 10https://bugzilla.wikimedia.org/59937#c18 (10Jon) https://gerrit.wikimedia.org/r/155306 temporarily reverts the patch. We can revert the revert when this bug is fixed. [17:53:55] (03CR) 10Kaldari: [C: 032] Revert enabling of anonymous editing in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155306 (owner: 10Jdlrobson) [17:54:25] (03Merged) 10jenkins-bot: Revert enabling of anonymous editing in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155306 (owner: 10Jdlrobson) [17:57:11] bearND: YuviPanda: I'm trying to follow the Readme in limn-mobile-data.... any idea what "coke" is? [17:57:25] dbrant: I gotcha [17:57:35] I'll spare poor Yuvi from any more limn pain [17:57:40] coke is "make for coco" [17:57:47] npm install -g coco and you'll have it [17:58:27] milimetric: ah, thanks!! [17:58:41] (probably worth mentioning in the readme!) [17:59:22] 3MobileFrontend / 3alpha: Add intermediate screen to warn logged-out editors similar to 'anoneditwarning' message - 10https://bugzilla.wikimedia.org/59937#c19 (10Florian) 5NEW>3ASSI a:3Florian I'll take a look on it. > We can revert the revert when this bug is fixed. Or just add the lines in the fix? :) [18:01:15] (my bad; it is in the readme (for limn itself)!) [18:01:22] right :) https://github.com/wikimedia/limn#install [18:01:25] I was just gonna link [18:01:31] though - to be fair - not easy to follow [18:01:47] main thing is - we're gonna phase out limn as soon as we can, so it's not worth cleaning up too much [18:02:15] milimetric: when is "as soon as we can"? [18:02:16] I see; what will be the new thing? [18:02:19] :) [18:02:47] just curious if this means "in the next month", "next quarter", or "6 months from now" [18:02:50] 3MobileFrontend / 3alpha: Add intermediate screen to warn logged-out editors similar to 'anoneditwarning' message - 10https://bugzilla.wikimedia.org/59937#c20 (10Jon) Which fix? Is there another patch that fixes this? [18:03:04] FlorianSW: hey, so yeh basically we need to fix that in some way - we can't deploy it in current form :) if you can add the anon editing warning even better :) [18:03:28] jdlrobson: That is what i want to say :D Currently working on it :P [18:03:50] 3MobileFrontend / 3alpha: Add intermediate screen to warn logged-out editors similar to 'anoneditwarning' message - 10https://bugzilla.wikimedia.org/59937#c21 (10Florian) I mean a future fix :) When we have some :P [18:06:06] Maryana: we've got the next six weeks or so to write a dashboard for EEVS that doesn't use limn. If that looks good, and other people like it, we'll generalize it and start switching people over I think. Though you should talk to Kevin about the real plan - this is just developer fantasy :) [18:06:16] jdlrobson: That is what i want to say :D Currently working on it :P [18:06:58] milimetric: gotcha. just wondering cos i've been meaning to clean up the mobile dashes, but if y'all are switching to something that's not limn, i don't want to waste effort on it [18:07:20] Maryana: I don't think effort will be wasted - ping me with what you're trying to change [18:08:59] ok :) need to talk to Deskana & dartar first about what we want to measure & report on [18:09:41] Maryana: There are a few cards in the current apps sprint to build things out for apps. [18:10:10] brb restarting my laptop because it's being lame [18:16:58] Krinkle|detached: This is my reminder to you to remind me about what I have to do. :P [18:17:11] Krinkle|detached: Oops, you're not Kristen. [18:17:12] kristenlans: You are though! [18:17:44] Thanks for the reminder reminder ;-) [18:19:10] milimetric: dbrant: btw, the port number for limn is 5000 instead of 8081 from the limn-mobile-data/README. [18:20:32] milimetric: dbrant: one thing I haven't found out is how to get any graphs to show up. When I go to http://localhost:5000/ I see the heading "Graphs" and the footer, but except that it's all empty. [18:29:29] (03PS1) 10Florianschmidtwelzow: Add intermediate screen for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) [18:29:41] (03CR) 10jenkins-bot: [V: 04-1] Add intermediate screen for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [18:30:45] (03PS2) 10Florianschmidtwelzow: Add intermediate screen for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) [18:37:35] 3Wikipedia App / 3Android App: Allow creation of pages - 10https://bugzilla.wikimedia.org/69762#c1 (10Dan Garry) (In reply to Florian from comment #0) > Actually there is no way to create a new page (?) Is it planned to add this > feature? It is planned, yes. But we want to make sure that we create a good u... [18:39:32] * tfinc looks about [18:40:35] * tfinc greets jdlrobson, jgonera, mhurd, bearND|brb, kaldari, kristenlans, awjr, MaxSem, YuviPanda and others [18:40:38] nice to be back [18:40:42] yo [18:40:45] hello! [18:40:47] * awjr waves [18:40:48] welcome back! [18:40:50] tfinc: yay! [18:40:51] welcome back tfinc [18:40:58] Hey Tomasz, glad to have you back :-) [18:40:59] tfinc: finally, not more of your pictures.... [18:41:21] teasing us all the time with beach pics etc... [18:41:27] grmbl [18:41:33] :) [18:42:00] thedj: hehe, i was lucky to spend a day there [18:42:06] much colder now that i'm back in SF [18:42:26] i should have worked from the beach like YuviPanda did back in the day [18:42:47] dbrant: greetings, how goes it ? [18:42:50] 3MobileFrontend / 3stable: The mobile site does not display collapsible elements - 10https://bugzilla.wikimedia.org/69773#c3 (10Strainu) Yeah, the one from the URL field :) Compare https://ro.m.wikipedia.org/wiki/Wikipedia:Sondaje/Leg%C4%83tur%C4%83_de_%C3%AEnc%C4%83rcare_pentru_LMI vs https://ro.wikipedi... [18:43:07] * tfinc looks at his tower of email [18:43:57] tfinc: things are shaping up nicely! [18:43:58] bearND: that sounds like the coke command didn't work as expected [18:44:19] basically, for limn to find your graphs / data, the coke command sets up symlinks to your limn-mobile-data repository [18:45:09] that coke command does that, but it's a lot better to have the path to the data repository be absolute, everyone gets super confused when it's relative since it has to be relative to /var/data or something (I even forget) [18:45:37] long story short, delete any symlinks in var/data/** and run this: [18:45:48] cd [18:46:14] coke --vardir ./var --data --to mobile link_data [18:46:25] (keep in mind the word "mobile" is magic and can't be changed) [18:46:33] (03PS4) 10Kaldari: WIP: WikiGrok interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154299 [18:46:56] milimetric: bearND|brb: I see graphs!! [18:47:05] 3Wikipedia App / 3Android App: Allow creation of pages - 10https://bugzilla.wikimedia.org/69762#c2 (10Florian) p:5Unprio>3Low > it's not bubbled up in our list of priorities right now. Ok, but it's great, that it isn't forgotten at all :) Let's use this bug to track news for it, ok? :) [18:47:07] 3MobileFrontend / 3Feature requests: The mobile site does not display navbox elements - 10https://bugzilla.wikimedia.org/69773#c4 (10Jon) It's a navbox. Navboxes are hidden on mobile as they are generally cluttered and not mobile friendly. [18:47:07] :) [18:47:40] limn - making foundation employees have stockholm syndrome, one at a time [18:50:37] milimetric: Thank you! I see graphs, too :) [18:50:52] 3MobileFrontend / 3Feature requests: The mobile site does not display navbox elements - 10https://bugzilla.wikimedia.org/69773#c5 (10Ryan Kaldari) 5NEW>3RESO/INV If you remove the navbox class from that element, it should display fine on mobile. As Jon mentioned, we purposefully don't display navboxes on... [18:51:05] after making the symlinks point to absolute paths [18:52:15] milimetric: i just think the README needs some updating [18:53:49] milimetric: what is generate.py for? In other words: When would I need to run it? [18:54:18] bearND: mobile team maintains limn-mobile-data, feel free to submit patches in gerrit and I'll help you merge them [18:54:43] the story of generate.py: so this repository is dual-purpose [18:54:55] 1. it sets up metadata for limn to render graphs [18:55:16] 2. it has configuration and sql code that generates the data for the limn graphs to plot [18:55:24] 1 you just saw in action [18:56:31] 2 works by running generate.py on stat1003, that in turn queries the event logging database, outputs data, then syncs it over to a public static file server. The graphs look there to consume data [18:56:48] so you wouldn't run generate.py unless you're trying to debug something [18:57:49] ah, great. Thanks, milimetric! [18:58:07] np [19:36:22] 3MobileFrontend / 3General/Unknown: Thank notification on mobile doesn't ask for confirmation: accident-prone - 10https://bugzilla.wikimedia.org/61737 (10WhatamIdoing) [19:37:38] http://i.imgur.com/Kb6jYRw.png [19:37:40] Eugh [19:38:08] :/ [19:38:29] Don't try to use the app in Piedmontese, I guess. [19:38:51] 3MobileFrontend / 3General/Unknown: Thank notification on mobile doesn't ask for confirmation: accident-prone - 10https://bugzilla.wikimedia.org/61737#c19 (10WhatamIdoing) I filed the request for information at bug 69804. Jon, if the confirmation step on desktop is working (stopping unwanted thanks withou... [19:41:14] Deskana: yikes! [20:12:59] (03CR) 10Jdlrobson: [C: 04-1] Add intermediate screen for anonymous editors (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [20:13:52] bearND: any objection to releasing Beta from the current master? [20:15:38] 3MobileFrontend / 3General/Unknown: Thank notification on mobile doesn't ask for confirmation: accident-prone - 10https://bugzilla.wikimedia.org/61737#c20 (10Jared Zimmerman (WMF)) Thanks for filing this bug WhatamIdoing, my gut feeling is that the opposite will happen, that we'll be able to developer an und... [20:21:31] dbrant: no objection. except one question: is full-text search ready, too? I still see WIP on the commit message [20:23:35] bearND: Full text search is not ready for production yet, but can go to beta for sure. [20:24:02] dbrant: ^ [20:24:29] We probably want some in-person user tests of this. [20:27:52] bearND: I'd like to build a feature-toggle switch that would enable/disable these kinds of features for beta vs. production. Perhaps we could leave full-text search out for now, and by next week we'll have it available via feature toggle? [20:30:53] dbrant: sounds great. Just a quick check if there's anything new on TWN... [20:31:18] FWIW I'm probably going to be pushing a bit more for in-person user tests of stuff. [20:31:35] Erik and Lila have made it clear that as an organisation we should be doing more user tests on things. [20:31:49] I think they're right about it [20:31:56] totally! [20:31:58] And we've learned a lot from user tests so far, e.g. ToC discovery [20:33:59] Deskana: speaking of ToC discovery, I had a random idea that might help a bit: what if pressing on a section title (inside the article) brings up the ToC? (cc bearND YuviPanda) [20:34:53] dbrant: I'm not sure how people would discover that. [20:35:15] (03PS5) 10Florianschmidtwelzow: Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) [20:35:29] (03CR) 10jenkins-bot: [V: 04-1] Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) (owner: 10Florianschmidtwelzow) [20:35:31] dbrant: Deskana: another one: we could slide in the ToC the very first time a page with multiple sections is loaded [20:35:57] dbrant: What I thought about was "If someone scrolls down quickly (for some definition of quickly) then we could show them a little bit of text under the ToC saying "Try using the Table of Contents!"" [20:36:26] (03PS6) 10Florianschmidtwelzow: Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) [20:36:34] (03CR) 10jenkins-bot: [V: 04-1] Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) (owner: 10Florianschmidtwelzow) [20:36:41] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155426 [20:36:46] Deskana: users of mobile frontend are used to clicking on sections to expand/collapse them, so they might be naturally inclined to click on the section title. [20:36:53] dbrant: got a few new translated strings ^ [20:37:50] dbrant: Ah, interesting. That helps with some of the users, but we can't assume that everyone that can't find the ToC has used mobile web. [20:38:12] dbrant: There's a lot of ideas about this flying around. All of us should have a quick 30 minutes together to chat about our ideas. [20:38:18] (03CR) 10Florianschmidtwelzow: Improvements to add discussion on talk page (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) (owner: 10Florianschmidtwelzow) [20:38:19] I want to make sure we're all in sync. :) [20:38:24] (03CR) 10Florianschmidtwelzow: [C: 04-1] Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) (owner: 10Florianschmidtwelzow) [20:38:40] dbrant: Deskana: I think it's an idea worth exploring [20:40:53] dbrant: Are you okay for meeting tomorrow at 3:30pm SF time? [20:41:38] Deskana: yep, fine for me [20:42:34] (03CR) 10Dbrant: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155426 (owner: 10BearND) [20:43:33] bearND: ok! I'll do a beta push now [20:43:47] dbrant: great! :) [20:44:15] bearND: btw, have you tried running the generate.py script? [20:44:49] (for local data?) [20:47:16] dbrant: yeah, but I get ImportError: No module named MySQLdb [20:48:17] dbrant: milimetric: pip install -r requirements.txt fails with pages of errors [20:48:34] in limn-mobile-data [20:49:19] I just hope I don't really need it [20:49:33] bearND: lol so I just installed the requirements manually... [20:49:42] pip install MySQL-python [20:49:51] dbrant: did that work? [20:49:51] pip install PyYAML [20:49:54] bearND: so what are you guys doing with this, btw? [20:50:10] milimetric: https://trello.com/c/6TpG6Y7H/12-5-as-a-mobile-team-member-i-d-like-our-editor-workflow-metrics-to-be-shown-on-an-analytics-dashboard [20:50:34] what data sources will you need to query? [20:50:50] sounds like event logging, right? [20:50:59] yep [20:51:21] and where will you be hosting the graphs, the http://mobile-reportcard.wmflabs.org instance? [20:51:36] yep [20:51:38] milimetric: yes, EL, for at least #2-5, not sure yet about #1 Page views. YuviPanda was figuring that one out [20:51:44] (03CR) 10Florianschmidtwelzow: Add intermediate screen for anonymous editors (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [20:52:19] (03PS3) 10Florianschmidtwelzow: Add intermediate screen for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) [20:52:28] bearND / dbrant ok, gotcha. So you won't need the python stuff [20:52:33] all you'll need is to look here: https://github.com/wikimedia/analytics-limn-mobile-data/blob/master/mobile/config.yaml [20:52:43] and add graphs to the graphs section [20:52:49] along with any required sql [20:53:11] notice how some of those graphs have "timeboxed: true" [20:54:13] that passes in start / end values to the SQL you provide, this is an example of a template: https://github.com/wikimedia/analytics-limn-mobile-data/blob/master/mobile/edits-monthly-5plus-editors.sql [20:54:21] milimetric: but wouldn't we need to experiment with the graphs locally before deploying them there? [20:54:35] notice, also, that the key in that graphs section in the config is the name of the SQL file the system is expecting [20:55:08] Deskana: milimetric: Should those go into the "Monthly reports" tab? [20:55:14] dbrant: the first step would be to get your SQL to work and get it pushed to the repository [20:56:26] dbrant: once that's working, you'll have new files generated here: http://datasets.wikimedia.org//limn-public-data/mobile/datafiles/ [20:56:44] and once you have that, you can make your graphs locally and test them [20:58:10] dbrant: there's a tool that will generate a basic graph for you, https://github.com/wikimedia/analytics-limn-mobile-data/blob/master/generate-graph.py [20:58:35] or you can just point to the remote datafile in the limn dashboard and the graph will be generated on the fly (but you won't be able to customize the title, etc.) [20:59:04] basically, dbrant / bearND, ping me again once you've got SQL that works and it's merged into the repository and generating the datafiles you need [20:59:48] (03CR) 10Florianschmidtwelzow: [C: 04-1] Add intermediate screen for anonymous editors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [21:00:09] milimetric: thanks [21:00:55] jdlrobson, what happened to the patch measuring the influence of dynamic page loading after editing? [21:01:37] jgonera: i got sidetracked by Flow things :-/. [21:01:38] 3MobileFrontend / 3stable: New page create confirmation does not allow to cancel - 10https://bugzilla.wikimedia.org/69813 (10Florian) 3NEW p:3Unprio s:3major a:3None If i try to create a new page in mobile, there will be a warning in last step, asking me, if i really want to save this page. If i clic... [21:01:57] are you moving lazy loading in alpha this iteration? [21:02:13] as that will simplify the A/B test if that's done first [21:02:38] * dbrant is thoroughly confused. [21:05:35] 3MobileFrontend / 3stable: New page create confirmation does not allow to cancel - 10https://bugzilla.wikimedia.org/69813#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/hYBZxubh [21:08:57] ugh [21:09:08] API is a nightmare [21:10:31] * YuviPanda pats MaxSem [21:20:10] (03PS4) 10Florianschmidtwelzow: Add intermediate screen for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) [21:21:57] (03CR) 10Florianschmidtwelzow: "There is still a problem. With the german Anoneditwarning message (https://de.wikipedia.org/w/index.php?title=MediaWiki:Anoneditwarning&ac" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [21:33:40] MaxSem, jdlrobson: can you take a look on https://gerrit.wikimedia.org/r/#/c/152331 [21:35:06] done [21:35:53] thx MaxSem! [21:39:37] 3MobileFrontend / 3stable: Mobile section redirects only redirect to tops of articles - 10https://bugzilla.wikimedia.org/69020 (10Florian) 5PATC>3RESO/FIX [21:43:08] (03PS5) 10Florianschmidtwelzow: Add intermediate screen for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) [21:58:08] jdlrobson: should https://gerrit.wikimedia.org/r/#/c/152331/ be reverted? [21:58:21] it's also causing tests to fail, so I'm not sure whether we should just fix it or revert [21:58:28] legoktm: it is? If so I'd suggest reverting it then :) [21:59:10] the whole point of the targets property was to carefully add stuff to mobile that didn't break things and use it as a tool for auditing [21:59:37] thanks legoktm for being on top of that :) [22:00:50] np, I just saw other core stuff failing :P [22:01:35] 3MobileFrontend / 3stable: Mobile section redirects only redirect to tops of articles - 10https://bugzilla.wikimedia.org/69020#c4 (10Florian) 5RESO/FIX>3REOP Reopened: https://gerrit.wikimedia.org/r/#/c/155451/ [22:01:49] hmm :( [22:20:50] vbamba: ok i think it’s working [22:23:08] 3MobileFrontend / 3alpha: wgIsMainPage is unreliable on lazy-loaded pages - 10https://bugzilla.wikimedia.org/69820 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Go to https://en.m.wikipedia.org/wiki/Main_Page, click a link to another page, and ask for mw.config.get( 'wgIsMainPage' ) in the consol... [22:24:37] (03PS1) 10Kaldari: Disabling lazy-loading in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155455 (https://bugzilla.wikimedia.org/69820) [22:31:38] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155458 [22:31:39] jdlrobson, jgonera: ^ [22:32:17] kaldari: i thought we agreed to remove the code altogether? [22:32:30] jdlrobson: Apparently apps might use it? [22:32:42] oh the firefox os app you mean? [22:32:45] what is the state of that? [22:32:46] yeah [22:32:49] no idea [22:33:01] seems silly having code that's not being used in repo [22:33:20] kaldari, do you need that to start working on wikigrok? [22:33:26] jdlrobson: Who's in charge of the Firefox app? Adam? [22:33:53] jgonera: I just need bug 69820 fixed and this is a cheap way to fix it [22:34:12] (03CR) 10Dbrant: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155458 (owner: 10Dbrant) [22:34:14] jgonera: Since Wikigrok should never load on the Main Page [22:34:20] kaldari, if you need it for today, let's merge it and get rid of the code later [22:34:33] jgonera: Sounds good to me [22:34:51] jdlrobson, is this acceptable? [22:35:05] jgonera, jdlrobson: I'll add a FIXME to say we should consider removing the code altogether [22:35:13] ok [22:37:14] (03PS2) 10Kaldari: Disabling lazy-loading in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155455 (https://bugzilla.wikimedia.org/69820) [22:38:26] (03CR) 10Jdlrobson: [C: 032] Disabling lazy-loading in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155455 (https://bugzilla.wikimedia.org/69820) (owner: 10Kaldari) [22:38:28] wfm kaldari [22:38:56] (03Merged) 10jenkins-bot: Disabling lazy-loading in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155455 (https://bugzilla.wikimedia.org/69820) (owner: 10Kaldari) [22:40:54] thanks! [22:41:50] 3MobileFrontend / 3alpha: wgIsMainPage is unreliable on lazy-loaded pages - 10https://bugzilla.wikimedia.org/69820 (10Ryan Kaldari) 5PATC>3RESO/FIX [22:42:52] 3MobileFrontend / 3alpha: alpha: edit CTA redirects to original article - 10https://bugzilla.wikimedia.org/54284 (10Ryan Kaldari) 5PATC>3RESO/FIX [22:51:05] 3MobileFrontend / 3alpha: Middle click in alpha loads page in the same tab - 10https://bugzilla.wikimedia.org/62517#c4 (10Jon) 5NEW>3RESO/INV https://gerrit.wikimedia.org/r/155455 renders this to be no longer relevant. [22:58:54] (03PS31) 10Mhurd: Nearby entry in main menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153071 [23:09:27] (03PS5) 10Kaldari: WIP: WikiGrok interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154299 [23:54:51] jdlrobso_, will you prepare that post-editing dynamic loading a/b test patch anytime soon then? [23:55:09] there is a bug related to that and I don't know if I should work on it or not