[00:08:24] (03PS1) 10JGonera: Don't trigger focus event on contenteditable in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155671 [00:21:57] (03PS1) 10Jdlrobson: Setup A/B test for editing / performance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155675 [00:41:25] mhurd: i'm planning on leaving in 10-15 [00:41:35] tfinc: sounds good! [11:06:59] 3Commons App / 3Android: i18n: \u00A0 does not survive export to translatewiki - 10https://bugzilla.wikimedia.org/69395#c2 (10Lokal_Profil) Does this mean that no updates are being pushed to the Android app? If so the project should be removed from Translatewiki since any translation would be considered "wa... [11:38:15] 3MobileFrontend / 3stable: Lack of attribution in mobile version of MultimediaViewer - 10https://bugzilla.wikimedia.org/69656#c20 (10Andre Klapper) (In reply to Robert Myers from comment #19) > When will this be addressed? See comment 15 for scheduling. [11:40:00] 3Wikipedia App / 3Android App: Text Looks garbled when using Bengali - 10https://bugzilla.wikimedia.org/66125 (10Andre Klapper) [13:29:12] * dbrant waves at YuviPanda [13:29:24] * YuviPanda waves at dbrant [13:29:46] dbrant: I've completed porting the bash scripts into python, and now working on them outputing their status in a way the webapp can read them :) [13:30:03] YuviPanda: terrific! [13:30:23] YuviPanda: so, I've no idea how to construct the query for this: https://trello.com/c/jUUWQJfq [13:30:52] the "ServerSideAccountCreation" schema doesn't have information on whether the new account came from the app... [13:31:34] dbrant: aaah, it does! [13:31:52] dbrant user_agent LIKE 'WikipediaApp/%' :) [13:32:08] dbrant: along with user_agent LIKE '%android%' on top to differentiate android [13:32:54] YuviPanda: oh, i see! but I don't see user_agent in the schema... [13:34:55] dbrant: those are automatically added by EL to every schema [13:35:10] dbrant: so all schemas have a UA, and that's what we have to use to differentiate iOS / Android [13:35:30] 3MobileFrontend / 3stable: Lack of attribution in mobile version of MultimediaViewer - 10https://bugzilla.wikimedia.org/69656#c21 (10Robert Myers) It states nothing other then "Needs analysis" and "Archived", it has nothing regarding scheduling (ie: fix scheduled/planned to be complete on 1 Sept). [13:35:31] YuviPanda: well that's what I was missing, then! [13:36:10] dbrant: :) [13:50:36] dbrant / bearND: apologies for the premature merge by nuria on https://gerrit.wikimedia.org/r/#/c/155637/1, it wasn't ready and I don't think it's working [13:50:58] I've left suggestions [13:53:35] milimetric: so, I'm just starting to test queries on the log db (in the console)... and I thought I'd start by trying one of the existing queries, to see if I can get the same numbers as I see in the graphs, but I'm not seeing the same numbers... [13:57:33] milimetric: for example, the first graph that appears in http://mobile-reportcard.wmflabs.org ... I'm pasting the corresponding query (from "edits-monthly-active-2014.sql") (plugging in a date range), but I don't get the same numbers as the graph shows. [13:58:13] if you could pastebin the query with the dateranges you're using I can take a look dbrant [13:59:16] milimetric: http://pastebin.com/1qNuj4Dk [13:59:32] gimme a few minutes, gotta run standup [13:59:40] np! [14:34:27] YuviPanda: what's the format of the "timestamp" field in the tables? [14:37:42] dbrant: it's the familiar YYYYMMDDHHmmss format [14:37:43] http://pastebin.com/e6XWr5AU [14:39:02] dbrant: ^ [14:40:51] milimetric: ok, that helps! but that still doesn't give the same numbers as the graph shows... [14:43:55] milimetric: sorry! it does. I've got it now! [14:44:39] yep, those queries are running directly on that same database so it'd be very strange if numbers didn't match :) [15:14:52] hey bearND [15:15:08] hey YuviPanda [15:15:11] bearND: I rejigged the build scripts :) I already merged a couple of patches, but wnat to merge the others? :) [15:15:31] bearND: I ported them to python! [15:17:22] YuviPanda: great. I'll take a look. You can just push things directly in that project if you like btw. [15:17:33] bearND: yeah, cool :) [15:19:13] bearND: I will also stop the cron emails momentarily [15:19:23] \o/ [15:19:30] :) [15:20:28] dbrant: I can only +1 in this project [15:22:45] * dbrant checks... [15:27:20] bearND: not sure why that would be; our 'group' should have +2 rights. [15:29:30] dbrant: never mind. I had accidentally logged in with a different account. [15:30:02] 3Wikipedia App / 3Android App: Edit doesn't work good, when content is transcluded - 10https://bugzilla.wikimedia.org/69907 (10Florian) 3NEW p:3Unprio s:3normal a:3None (For OTRS members: comes from https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7747714) If you look at th... [15:45:08] milimetric: YuviPanda: and, last piece of the puzzle, which table contains whether a user is blocked? [15:45:21] legoktm: ^ [15:45:29] ipblocks [15:45:33] yes, poorly named! [15:45:44] dbrant: https://www.mediawiki.org/wiki/Manual:Ipblocks_table [15:46:19] that table also contains whether a user has been suppressed [15:47:30] so, that's a different database from event-logging... [15:53:22] (03PS1) 10Yuvipanda: Make prepare-release executable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155743 [15:53:25] (03CR) 10jenkins-bot: [V: 04-1] Make prepare-release executable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155743 (owner: 10Yuvipanda) [15:54:32] (03PS2) 10Yuvipanda: Make prepare-release executable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155743 [15:54:41] bearND: can you merge ^ [15:55:02] YuviPanda: looking [15:55:32] (03CR) 10BearND: [C: 032] Make prepare-release executable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155743 (owner: 10Yuvipanda) [15:56:06] (03Merged) 10jenkins-bot: Make prepare-release executable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155743 (owner: 10Yuvipanda) [15:59:49] ok I definitely don't have the sql skills to do this on my own: [16:00:04] Here's the theoretical query I need to make: Get the number of users who have signed up using the mobile app, then made at least one edit, and are now blocked. (grouped by day) [16:00:37] I've gotten as far as the first part. [16:01:25] bearND: dbrant http://tools.wmflabs.org/wikipedia-android-builds/runs/latest/wikipedia.apk is now from the latest master, and is org.wikipedia.master :) [16:01:32] ^ milimetric legoktm YuviPanda any help would be appreciated [16:01:37] you could do a join on revision + change tags + ipblocks [16:01:46] I'm not sure how to integrate in the first part [16:02:17] YuviPanda: awesome!! [16:03:01] dbrant: I guess you'll have to join the user id in serversideaccountcreation with ipblocks on each wiki depending on the wiki... [16:04:13] can one query iterate through different databases? [16:04:17] dbrant: I'm not sure how to automate the 'wiki' part of it :| [16:04:21] dbrant: it could, yeah. [16:04:38] dbrant: there is 'show databases' but then you'll not be able to pass that on as input for a query I think [16:04:53] * dbrant has no idea [16:04:55] dbrant: I'm unsure how to do this as well :| [16:05:00] * YuviPanda pokes milimetric ^ [16:07:47] dbrant: bearND shouldn't be any more cron emails [16:08:18] YuviPanda: thank you [16:08:59] bearND: I should eventually make it email when the build fails tho [16:09:22] yes, that would come from the build script tho [16:09:29] bearND: we also now output http://tools.wmflabs.org/wikipedia-android-builds/runs/latest/meta.json which can be read from JS to produce the web page. [16:10:15] 3MobileFrontend / 3stable: Lack of attribution in mobile version of MultimediaViewer - 10https://bugzilla.wikimedia.org/69656#c22 (10Andre Klapper) Yes, nothing scheduled yet, and for non-high-priority issues like this one I don't expect scheduling to happen within four days. Hence patience is required. [16:12:27] YuviPanda: Nice! [16:14:59] 3MobileFrontend / 3stable: Lack of attribution in mobile version of MultimediaViewer - 10https://bugzilla.wikimedia.org/69656#c23 (10Ryan Kaldari) It will be implemented within the next week. Just waiting on some feedback from Moiz currently (the designer). [16:19:59] 3MobileFrontend / 3stable: Lack of attribution in mobile version of MultimediaViewer - 10https://bugzilla.wikimedia.org/69656#c24 (10Pete F) Can somebody on the team evaluate why this issue continues to arise repeatedly? I first reported the same basic issue in December 2012, and devoted a good deal of time... [16:22:01] 3MobileFrontend / 3stable: Mobile version of Wikipedia doesn't properly link history (required for attribution) when accessing article via redirect - 10https://bugzilla.wikimedia.org/42660 (10Pete F) [16:22:01] 3MobileFrontend / 3stable: Lack of attribution in mobile version of MultimediaViewer - 10https://bugzilla.wikimedia.org/69656 (10Pete F) [16:25:59] 3MobileFrontend / 3stable: Lack of attribution in mobile version of MultimediaViewer - 10https://bugzilla.wikimedia.org/69656#c25 (10Florian) @Pete F: But that are two totally different bugs, am i right? [16:27:17] dbrant: I couldn't discern from above - what's the question? [16:28:07] milimetric: Here's the theoretical query I need to make: Get the number of users who have signed up using the mobile app, then made at least one edit, and are now blocked. (grouped by day) [16:28:22] I can only get as far as the first part. [16:28:33] so where's the blocked information? [16:28:47] in a different database [16:29:00] is it a separate db per wiki or just one separate db? [16:29:07] per wiki [16:29:24] and you're trying to do this across all wikis or just one wiki? [16:29:44] across all, preferably [16:29:54] k, thinking [16:33:01] hm, dbrant, to query separate dbs dynamically, you'd have to either use python logic to wrap around your sql, or prepared statements: http://rpbouman.blogspot.com/2005/11/mysql-5-prepared-statement-syntax-and.html [16:33:37] or, alternatively, make a view that unions all the blocked users from all the dbs [16:34:53] the view's probably the easiest, we can ask someone with rights to create it [16:35:32] assuming you'd have such a view, dbrant, is everything else straightforward? [16:37:17] milimetric: couldn't one just add another table entry in mobile/config.yaml of limn-mobile-data to accomplish that? [16:37:33] that one has plenty of unions already [16:37:49] bearND: yeah, that would work too - but it would be a very long union [16:38:10] milimetric: that's true [16:39:16] oh, cool, we have rights to create whatever we want on analytics-store, in the "staging" database [16:40:03] milimetric: what would it take to publish the dataset of my sql query that got merged yesterday to datasets.wm.o? [16:40:28] bearND: did you see my comments after the merge? [16:40:37] milimetric: checking [16:40:40] that shouldn't have been merged, I apologize [16:40:53] nuria merged it but I think she wasn't familiar enough with how that code works [16:41:26] milimetric: ah, just noticed your comments [16:44:13] milimetric: the SQL file was modeled after an existing one for mobile web: successful-edits-main.sql [16:44:25] yep, I saw the comment [16:44:37] the config and sql are not in sync [16:45:01] notice the config for successful-edits-main doesn't have timeboxing [16:45:23] milimetric: ah, i see. I'll also need to change it to be really three datasets: Android, iOS, total, similar to what some of the monthly reports have [16:45:31] but still have it daily [16:46:34] milimetric: do i need to use a py files instead of the sql file for that? [16:48:29] no bearND, you can do them all in the same query. Just select three separate sums that get you each of the columns above, and make sure you label the columns well. Lemme see if there's an example [16:48:59] milimetric: edits-monthly-active-2014.sql looks pretty simple [16:49:00] bearND: https://github.com/wikimedia/analytics-limn-mobile-data/blob/master/mobile/cancelled-uploads.sql [16:49:22] milimetric: even better [16:49:42] well, the edits-monthly-active-2013 is better 'cause it has timeboxing too [16:49:43] but yea [17:05:02] milimetric: well, supposing that we could create a view that gives us all blocked userID's from all wikis, then I guess everything else would be straightforward... [17:09:54] dbrant: the same research user you're using has access to create tables / views in the staging database (same analytics-store host) [17:16:26] bearND we are staning [17:16:30] standing [17:32:26] (03PS6) 10Kaldari: WIP: WikiGrok interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154299 [17:33:07] (03CR) 10Kaldari: WIP: WikiGrok interface (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154299 (owner: 10Kaldari) [17:38:21] milimetric: if I do a daily graph I probably don't need to timebox it since the daily graphs only look back 30 days, and we could start the data at the end on June when we first released the new Android app. [17:39:05] bearND: sure, however you like it. The config should match the intention though [17:39:15] milimetric: understood [17:40:14] milimetric: is there a way to share the same sql query for both monthly and daily graphs? [17:40:36] not with the current setup, no [17:41:01] it just uses the key in the config to find a file and create an output file [17:41:09] *find a sql file [17:41:16] but you're welcome to extend it to do whatever you like [17:41:31] like give it a "sql-file" setting that overrides that behavior [17:41:39] milimetric: I thought so, but just wanted to check [17:41:50] (the override thing would be easy to write if you need) [17:42:11] (03PS13) 10Dbrant: Implement full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150014 (https://bugzilla.wikimedia.org/68438) [17:45:31] milimetric: https://gerrit.wikimedia.org/r/155763 [17:45:49] I hope this one works better [17:46:24] i'll review right now [17:46:39] thank you [17:50:36] bearND: made one comment, I'll merge once you consider [17:54:08] milimetric: actually, I don't mind a longer time frame than 30 days. I was just assuming that the daily graphs would be 30 days since that's what I saw on the first graphs. I think there is benefit of having them show more data [17:54:39] bearND: the performance of these queries is a concern [17:54:57] essentially, every hour you'd be grouping by the date of every record in that table [17:55:09] so in that case, I'd recommend timeboxing [17:55:32] what that does is generate only the days you don't have, since the specified start date [17:55:40] milimetric: The first records are on 6/25/2014 [17:56:10] milimetric: so, if I add that as the start date it's ok? [17:56:28] yeah, that works ok (and remember to change your query) [17:56:42] milimetric: will do. thank you [17:57:30] 3MobileFrontend / 3stable: Lack of attribution in mobile version of MultimediaViewer - 10https://bugzilla.wikimedia.org/69656#c26 (10Pete F) (In reply to Florian from comment #25) > @Pete F: But that are two totally different bugs, am i right? Yes, you are right. Sorry if I wasn't clear. My point is that th... [17:58:37] milimetric: I've amended the patch [17:58:44] 3MobileFrontend / 3stable: Lack of attribution in mobile image viewer - 10https://bugzilla.wikimedia.org/69656#c27 (10Mark Holmquist) (sorry for the title change, I'm tired of getting pinged on this bug :)) [17:59:11] bearND: btw, I get pinged in #wikimedia-analytics whenever someone touches an analytics/* repo so no need to ping me [17:59:18] unless I'm being lazy and letting you wait forever [18:00:30] 3MobileFrontend / 3stable: Lack of attribution in mobile image viewer - 10https://bugzilla.wikimedia.org/69656#c28 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/QohbVoc2 [18:01:30] 3MobileFrontend / 3stable: Lack of attribution in mobile image viewer - 10https://bugzilla.wikimedia.org/69656#c29 (10Florian) Sorry Pete F, i still don't understand :/ > to avoid similar mistakes This issue, if i read and remember correctly, isn't a real legal issue, it relies on how to interpret the CC co... [18:03:40] milimetric: great. I'm usually wondering about that when I don't see it in the channels I've joined but I just joined that one as well [18:11:29] (03PS1) 10Dduvall: QA: Corrected page elements for create_account_failure_messages.feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155766 [18:13:01] 3MobileFrontend / 3stable: Lack of attribution in mobile image viewer - 10https://bugzilla.wikimedia.org/69656#c30 (10Pete F) (In reply to Florian from comment #29) > This issue, if i read and remember correctly, isn't a real legal issue, it > relies on how to interpret the CC correct. I don't understand wh... [18:17:30] 3MobileFrontend / 3stable: Lack of attribution in mobile image viewer - 10https://bugzilla.wikimedia.org/69656#c31 (10Florian) > I don't understand what you're saying -- if the way to interpret a legally > binding contract correctly isn't a "real legal issue," then what is? maybe you read comment 4 and com... [18:33:21] bearND: fyi, puppet will deploy that change automatically and cron should run it within the next hour or so [18:33:45] if there are no problems, the datafile would be generated here: http://datasets.wikimedia.org//limn-public-data/mobile/datafiles/ [18:33:58] all this is automatic, so now we just wait [18:33:59] milimetric: awesome! Thanks for merging [18:39:11] dbrant: bearND http://tools.wmflabs.org/wikipedia-android-builds/ [18:39:21] dbrant: bearND looks far nicer on a phone than on desktop, I promise :) [18:39:35] YuviPanda: nice :) [18:39:50] bearND: I need to make the date better [18:40:18] yeah, nanoseconds [18:40:43] bearND: :) [18:52:33] (03PS9) 10Dbrant: Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [18:53:57] (03CR) 10jenkins-bot: [V: 04-1] Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 (owner: 10Dbrant) [18:55:06] dbrant: i hope i didn’t come off as dismissive about syntax highlighting :( apologies if so. [18:55:56] foods! [18:56:16] mhurd: not at all! I realize it's not the optimal solution... I just think it's better than a uniform wall of text/symbols! [19:04:29] dbrant: If you left out the making the section headings bigger then I think mhurd's main concerns should be addressed [19:06:11] (03PS1) 10Dduvall: QA: Fixed "Upload image file" scenario [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155781 [19:07:15] 3Wikipedia App / 3Android App: Android app flashes on page load - 10https://bugzilla.wikimedia.org/69863#c1 (10Bernd Sitzmann) That's with the faster page load (in new beta release) [19:07:54] bearND: perhaps; but what would be a better way to 'highlight' section titles, then? [19:08:49] dbrant: I would try how it looks with giving it a different color or a background color [19:09:23] bearND: ah, background color might be interesting... [19:09:50] dbrant: yeah, a different background color would section it off nicely I think without being similar to the end result [19:10:11] I'll try it [19:10:19] 3MobileFrontend / 3stable: Lack of attribution in mobile image viewer - 10https://bugzilla.wikimedia.org/69656#c32 (10Pete F) (In reply to Tisza Gergő from comment #4) > (In reply to Robert Myers from comment #3) > > It is a CC violation, it fails to attribute the author with the licence. > > You need to cl... [19:21:12] (03PS1) 10Dduvall: QA: Tagged additional features know to work under MWV [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155786 [19:23:14] (03PS2) 10Dduvall: QA: Tagged additional features known to work under MWV [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155786 [19:41:06] (03PS1) 10Kaldari: Adding attribution information to mobile media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155792 (https://bugzilla.wikimedia.org/69656) [19:41:42] (03PS10) 10Dbrant: Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [19:45:12] has anyone noticed problems with beta labs today? [19:52:08] dbrant: bearND hmm, should we label the 'master' build 'alpha' or 'CI' or what? [19:52:19] ci? [19:52:49] YuviPanda: why not master? [19:52:59] 'Wikipedia Master' sounds confusing [19:53:00] tfinc: ^ [19:53:14] dbrant: bearND also we already have a design asset saying 'alpha' :D [19:53:49] YuviPanda: oh, you're talking about the app_name label? [19:53:54] YuviPanda: i don't care what you name it as long as i can tell the difference [19:53:56] bearND: yeah [19:54:19] bearND: dbrant I prefer the alpha one solely because the icon already exists :) Am ok with whatever you guys wnana pick [19:55:42] tfinc: :) yeah, I already have the code changes done, just need to reach some form of consensus on what to call it [19:55:54] YuviPanda: what are you choosing between ? [19:56:07] tfinc: 'alpha', 'master', 'CI' [19:56:39] YuviPanda: we can still use the alpha icon and call it something else than alpha. It's just an icon. I could also got for Wikipedia [master] [19:56:42] we could also get creative and call it 'robot' or something [19:57:16] bearND: dbrant :) I'm going to just put onus on dbrant and go with whatever he picks. [19:58:14] YuviPanda: since we're doing away with the "alpha" from the Play Store, then I guess it's ok to call it "Alpha" in this context. [19:58:23] alright [20:00:02] 3MobileFrontend / 3stable: Lack of attribution in mobile image viewer - 10https://bugzilla.wikimedia.org/69656#c34 (10Ryan Kaldari) Pete: I'd be happy to discuss process issues, but not inside this bug. FWIW, I don't think there was any overlap between the people involved in bug 42660 (Kenan, Jon, MaxSem) an... [20:00:41] (03PS1) 10Yuvipanda: Add alpha build variant to prepare-release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155795 [20:00:44] (03CR) 10jenkins-bot: [V: 04-1] Add alpha build variant to prepare-release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155795 (owner: 10Yuvipanda) [20:01:26] (03PS2) 10Yuvipanda: Add alpha build variant to prepare-release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155795 [20:04:37] (03CR) 10Florianschmidtwelzow: Adding attribution information to mobile media viewer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155792 (https://bugzilla.wikimedia.org/69656) (owner: 10Kaldari) [20:06:02] (03PS3) 10Yuvipanda: Add alpha build variant to prepare-release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155795 [20:06:09] (03CR) 10jenkins-bot: [V: 04-1] Add alpha build variant to prepare-release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155795 (owner: 10Yuvipanda) [20:06:27] milimetric: it's been more than 90 minutes, and I still don't see the app-edits-starts.csv file in http://datasets.wikimedia.org//limn-public-data/mobile/datafiles/. Is there a log file you could access? [20:06:51] bearND: :( that sux, it must be failing somehow [20:06:59] I am awful at finding logfiles [20:07:06] but it would be on stat1003 [20:07:55] bearND: yay - it's just /var/log/limn-mobile-data.log [20:08:00] 3Wikipedia App / 3Android App: TOC does not update highlighted position until after it is opened - 10https://bugzilla.wikimedia.org/66612 (10Dan Garry) [20:08:31] milimetric: bummer. I don't have permission to read it [20:08:54] (03CR) 10Kaldari: Adding attribution information to mobile media viewer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155792 (https://bugzilla.wikimedia.org/69656) (owner: 10Kaldari) [20:09:00] (03PS4) 10Yuvipanda: Add alpha build variant to prepare-release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155795 [20:09:05] bearND: dbrant ^ can one of you merge that? [20:09:08] https://www.irccloud.com/pastebin/1K7Qa7cS [20:09:37] bearND: doesn't like your sql - weird [20:09:45] (03CR) 10Kaldari: Adding attribution information to mobile media viewer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155792 (https://bugzilla.wikimedia.org/69656) (owner: 10Kaldari) [20:10:43] milimetric: thanks for pasting. Weird, I added the "as Edits" since I needed it later for the Edits.timestamp (for the timeboxing) [20:11:24] (03PS2) 10Kaldari: Adding attribution information to mobile media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155792 (https://bugzilla.wikimedia.org/69656) [20:11:55] i'm trying to figure out what the problem is [20:12:26] (03PS3) 10Kaldari: Adding attribution information to mobile media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155792 (https://bugzilla.wikimedia.org/69656) [20:12:46] (03CR) 10Florianschmidtwelzow: "Damn, my beautiful comment, and then you understand what i mean :D" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155792 (https://bugzilla.wikimedia.org/69656) (owner: 10Kaldari) [20:13:07] (03CR) 10Deskana: "Any news on this patch? Would be good to either close it out or abandon it." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151779 (https://bugzilla.wikimedia.org/66732) (owner: 10Dbrant) [20:13:36] (03CR) 10Florianschmidtwelzow: [C: 031] Adding attribution information to mobile media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155792 (https://bugzilla.wikimedia.org/69656) (owner: 10Kaldari) [20:13:42] (03PS1) 10Yuvipanda: Don't fail if branch or tag for release already exists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155799 [20:13:43] dbrant: bearND ^ as well. [20:14:53] (PS1) Yuvipanda: Use .alpha and not .master [labs/tools/wikipedia-android-builds] - https://gerrit.wikimedia.org/r/155801 [20:14:55] dbrant: bearND ^ as well [20:15:45] 3Wikipedia App / 3Android App: Read in other languages activity not properly flipped in RTL view - 10https://bugzilla.wikimedia.org/66795#c2 (10Dan Garry) 5NEW>3RESO/INV Insufficient context to this bug for me to figure out what it means, and therefore how to prioritise it. Please reopen if you have cont... [20:16:05] (03CR) 10Kaldari: [C: 032] Fix "confirm on new page creation" can not be cancelled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155530 (https://bugzilla.wikimedia.org/69813) (owner: 10Florianschmidtwelzow) [20:16:22] YuviPanda: dbrant: looking at your patches... [20:16:31] bearND: found your sql problem, I'll submit a patch. It's in the config.yaml and how you set that up [20:16:39] (03Merged) 10jenkins-bot: Fix "confirm on new page creation" can not be cancelled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155530 (https://bugzilla.wikimedia.org/69813) (owner: 10Florianschmidtwelzow) [20:16:50] milimetric: thank you [20:17:12] (03CR) 10Jdlrobson: [C: 04-1] "Let's add a test to test_EditorOverlay.js that ensures the anon editor warning shows when the user is anon. Ping me on irc if you need hel" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [20:17:18] 3MobileFrontend / 3stable: New page create confirmation does not allow to cancel - 10https://bugzilla.wikimedia.org/69813 (10Florian) 5PATC>3RESO/FIX [20:17:30] 3Wikipedia App / 3Android App: the languages list shows the languages in a suboptimal way - 10https://bugzilla.wikimedia.org/66917 (10Dan Garry) [20:18:21] (03CR) 10BearND: [C: 032] Add alpha build variant to prepare-release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155795 (owner: 10Yuvipanda) [20:18:43] (03Merged) 10jenkins-bot: Add alpha build variant to prepare-release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155795 (owner: 10Yuvipanda) [20:20:01] (03PS2) 10BearND: Don't fail if branch or tag for release already exists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155799 (owner: 10Yuvipanda) [20:23:23] bearND: https://gerrit.wikimedia.org/r/#/c/155803/ [20:23:28] i'm gonna self merge so we can see if it worked [20:24:48] milimetric: sounds great. I like your changes [20:25:00] (03CR) 10Jdlrobson: [C: 04-1] "Also use FIXME rather than @todo" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155663 (owner: 10Bsitu) [20:25:51] (03CR) 10BearND: Don't fail if branch or tag for release already exists (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155799 (owner: 10Yuvipanda) [20:28:04] (03CR) 10Jdlrobson: [C: 032] "There's still issues with re-rendering the talk overlay but I guess this is a step in right direction." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153341 (https://bugzilla.wikimedia.org/64105) (owner: 10Florianschmidtwelzow) [20:28:37] (03Merged) 10jenkins-bot: Improve Talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153341 (https://bugzilla.wikimedia.org/64105) (owner: 10Florianschmidtwelzow) [20:37:15] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) (owner: 10Florianschmidtwelzow) [20:37:50] (03Abandoned) 10Jdlrobson: Hide discussion button whilst it is broken [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155160 (https://bugzilla.wikimedia.org/69763) (owner: 10Jdlrobson) [20:38:19] (03PS2) 10Bsitu: Remove direct echo db access from mobilefrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155663 [20:39:29] (03CR) 10Jdlrobson: [C: 04-1] "This doesn't work." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow) [20:40:15] * YuviPanda pokes https://gerrit.wikimedia.org/r/#/c/155799/ with bearND again [20:40:16] err [20:40:19] the other way around [20:40:30] :) [20:41:12] YuviPanda: did you see my comment for PS 1? [20:41:43] jdlrobson: coming by R33 or do you need to cancel ? [20:41:53] bearND: bah, missed that [20:41:59] bearND: hmm, so we'll need a 'do not tag' flag [20:42:52] moizsyed: wanna see the attribution display now? It's implemented on my local machine. [20:43:15] bearND: we could also make the tag accurate to seconds :) thoughts on that? [20:43:42] dbrant: ^ [20:44:41] kaldari: can i look, too? [20:44:48] sure [20:45:03] YuviPanda: I don't think alpha/ci builds need a tag. [20:45:12] me neither [20:45:18] hmm, or branch [20:45:22] alright, let me add those options then [20:45:52] good [20:46:48] (03PS1) 10MaxSem: Allow third parties to disable beta and alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) [20:46:53] (03CR) 10jenkins-bot: [V: 04-1] Allow third parties to disable beta and alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) (owner: 10MaxSem) [20:47:10] YuviPanda: no command line flag needed though. just set it inside the options parsing def [20:47:42] (03CR) 10Dbrant: "The problem is that this has proved extremely elusive to reproduce (on 2.3), and yet we still get OTRS reports about it on a daily basis. " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151779 (https://bugzilla.wikimedia.org/66732) (owner: 10Dbrant) [20:48:31] 3Wikipedia App / 3Android App: Following a link during page save operation marks second page as saved in menu - 10https://bugzilla.wikimedia.org/68192#c1 (10Dan Garry) 5NEW>3RESO/FIX Seems to be fixed to me. [20:49:10] (03PS2) 10MaxSem: Allow third parties to disable beta and alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) [20:49:29] (03PS3) 10Yuvipanda: Don't create tags or branches for alpha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155799 [20:49:31] bearND: dbrant ^ [20:51:35] (03CR) 10BearND: [C: 04-1] "minor thing in the comments section" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155799 (owner: 10Yuvipanda) [20:52:10] (03PS4) 10Yuvipanda: Don't create tags or branches for alpha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155799 [20:52:16] bearND: ^ [20:52:27] (03CR) 10TheDJ: [C: 04-1] Adding attribution information to mobile media viewer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155792 (https://bugzilla.wikimedia.org/69656) (owner: 10Kaldari) [20:52:37] https://github.com/wikimedia/bingle/issues/43 [20:52:43] awjr ^ [20:52:44] :D [20:52:54] hahaha [20:52:55] \0/ [20:53:44] (03CR) 10BearND: [C: 032] Don't create tags or branches for alpha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155799 (owner: 10Yuvipanda) [20:53:46] Maryana: are you concerned at all about hug spam? [20:53:55] haha [20:53:56] the hugpocalypse? [20:53:57] hugpocalypse [20:53:59] jinx [20:53:59] hugocalypse [20:54:00] haha [20:54:00] hahaha [20:54:03] (03Merged) 10jenkins-bot: Don't create tags or branches for alpha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155799 (owner: 10Yuvipanda) [20:54:16] that would be a great problem to have [20:54:25] "there's too many hugs in this sprint!" [20:56:12] (03PS2) 10Dbrant: Add support for feature toggle of beta features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/155268 [21:00:24] Wait I’m concerned about the hugapocalypse! Am I prepared? [21:01:20] Deskana|Away: are you still wfh? [21:01:40] kristenlans: just wear lots of layers of thick sweaters and you'll be fine [21:01:55] LOLOL [21:01:55] you won't even know you're being hugpocalypsized [21:02:50] (03CR) 10Jdlrobson: [C: 04-1] Allow third parties to disable beta and alpha (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) (owner: 10MaxSem) [21:03:53] (03CR) 10Jdlrobson: [C: 032] Use summary message on non Main namespace pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153962 (https://bugzilla.wikimedia.org/69488) (owner: 10Florianschmidtwelzow) [21:04:20] (03CR) 10MaxSem: Allow third parties to disable beta and alpha (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) (owner: 10MaxSem) [21:04:26] (03Merged) 10jenkins-bot: Use summary message on non Main namespace pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153962 (https://bugzilla.wikimedia.org/69488) (owner: 10Florianschmidtwelzow) [21:05:45] (03CR) 10Jdlrobson: [C: 032] Remove direct echo db access from mobilefrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155663 (owner: 10Bsitu) [21:06:17] (03Merged) 10jenkins-bot: Remove direct echo db access from mobilefrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155663 (owner: 10Bsitu) [21:17:31] 3MobileFrontend / 3stable: "How did you improve the page?" doesn't really make sense on non-article namespace - 10https://bugzilla.wikimedia.org/69488 (10Jon) 5PATC>3RESO/FIX [21:21:42] (03PS6) 10Florianschmidtwelzow: Add intermediate screen for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) [21:23:04] (03PS4) 10Kaldari: Adding attribution information to mobile media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155792 (https://bugzilla.wikimedia.org/69656) [21:24:01] (03CR) 10Jdlrobson: Add intermediate screen for anonymous editors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [21:27:50] (03CR) 10Florianschmidtwelzow: Add intermediate screen for anonymous editors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [21:28:45] (03PS7) 10Florianschmidtwelzow: Add intermediate screen for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) [21:28:47] (03CR) 10Jdlrobson: Add intermediate screen for anonymous editors (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [21:29:11] (03PS8) 10Florianschmidtwelzow: Add intermediate screen for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) [21:31:34] jdlrobson: around? [21:32:05] hey FlorianSW editorOverlay.$anonWarning.length > 0 is sufficient :D [21:32:08] no need to do editorOverlay.$anonWarning.text().length > 0 [21:32:59] ehhh :D [21:33:40] i rewrite this :) Can you look at your comment here: https://gerrit.wikimedia.org/r/#/c/153341/ Do you mean the problem, that it will not reload content after the overlay was closed? [21:33:47] jdlrobson: ^ [21:34:23] FlorianSW: after adding a topic [21:34:32] it doesn't refresh the content yeh [21:35:13] bearND: http://datasets.wikimedia.org//limn-public-data/mobile/datafiles/app-edits-starts.csv nice! [21:35:17] ah, ok :) This i have "solved" with this one: https://gerrit.wikimedia.org/r/153957 I thought it is better to use two changes :) Two little pieces better as one big :D [21:35:18] milimetric: yeah. I see the new csv file on the server! [21:35:29] thank you, milimetric! [21:35:39] np [21:35:43] so now you have to make a graph [21:35:55] (03PS9) 10Florianschmidtwelzow: Add intermediate screen for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) [21:36:25] easiest way is to add "http://datasets.wikimedia.org//limn-public-data/mobile/datafiles/app-edits-starts.csv" as a "graph_id" here: https://github.com/wikimedia/analytics-limn-mobile-data/blob/master/dashboards/reportcard.json#L48 [21:36:44] milimetric: do i need to download the csv file to try out the graph locally? I've added a corresponding graph file and also added to the reportcard but I only see a white area where the graph should appear [21:36:46] literally a URL is just as valid in that json as "diff-activity" for example [21:37:00] you want me to submit a patch so you can play with it? [21:37:15] if you do it that way, you won't be able to customize the graph, but you'll have something to start with [21:37:23] (03PS13) 10Florianschmidtwelzow: Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) [21:37:47] milimetric: i was using cancelled-uploads.json and just changed the names [21:38:13] bearND: it's not that easy, the graph file you made is half the story [21:38:18] you also need to define a datasource [21:38:22] but before you do that, try this: [21:40:47] milimetric: cool. using the full URI to the csv file helped [21:41:11] bearND: you gots graphs? [21:41:18] milimetric: yes [21:41:56] milimetric: i put the full URL to the csv file into reportcards.json as you indicated [21:42:02] ah, good [21:42:20] milimetric: i had already pushed the graph file earlier [21:42:24] so now if you want to have the graph show just like that you can leave it or put it into another tab [21:42:30] (03CR) 10Jdlrobson: [C: 032] "In a follow up we should give the warning some design love. At very least we should make it more obvious it is a warning :) but yey anon e" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [21:42:49] if you want to customize it, you can keep working on your graph file and make a corresponding datasource file (in the datasources directory) [21:43:03] (03Merged) 10jenkins-bot: Add intermediate screen for anonymous editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155312 (https://bugzilla.wikimedia.org/59937) (owner: 10Florianschmidtwelzow) [21:43:12] milimetric: I'll probably add an Apps tab. [21:43:35] k, nothing special needed for that, just that dashboard file [21:44:29] milimetric: you mean reportcard.json? [21:44:36] yep [21:44:51] cool, thanks easy [21:44:54] that's [21:45:40] kaldari: jdlrobson bubble tea/coffee time? [21:45:48] bearND dbrant mhurd moizsyed vbamba Maryana tfinc awjr jgonera kaldari MaxSem Deskana: Would anyone be bothered if I left a bit early? I got invited to go on a boat to Martha’s Vineyard to watch fireworks :D [21:45:55] bearND: you're lucky you're not in the office [21:45:59] kristenlans: boat! [21:46:06] boat it up :) [21:46:07] fireworks! [21:46:12] I think if someone says "that's easy" and they're talking about limn, someone jumps out and shoots them with a watergun [21:46:12] kristenlans: whoa whoa whoa, hold up sista [21:46:18] haha [21:46:21] don't listen to moiz [21:46:22] ever [21:46:24] I knew it [21:46:26] milimetric: lol [21:46:30] good advice. [21:46:39] kristenlans: you just can not just boat it up, we're working for a non profit here... this isnt a joke [21:46:50] blocked by moizsyed [21:46:51] * Maryana smacks moiz [21:46:52] kristenlans, not a problem for me [21:46:53] https://en.wikipedia.org/wiki/Martha's_Vineyard [21:47:02] kristenlans: ok im joking, of course [21:47:29] have fun, kristenlans :) [21:47:30] bearND: I'm out for the weekend - good luck [21:47:36] kristenlans: its a friday! have fun :) [21:47:56] moizsyed: I knew you were joking ;-) We shoudl have a Cape Cod offsite and we can ALL GO ON THE BOAT!!! [21:47:57] milimetric: thank you for your help. I appreciate it very much. Couldn't have done it without you. [21:48:05] milimetric: Have a great weekend [21:48:20] kristenlans: is this shot at Martha's Vineyard: https://www.youtube.com/watch?v=9wHl9qRsMzw [21:48:25] Yeah thanks millimetric [21:49:01] kristenlans: we're gonna take the ferry to oakland later.. [21:49:11] that's, uh, kind of like martha's vineyard? [21:49:15] except not at all. in any way. [21:50:07] Maryana: FERRRY [21:50:15] but first, coffeeeee [21:50:17] YES [21:50:47] ferry friday [21:52:06] moizsyed Lulz, looks like that video was shot in Jersey! [21:52:07] (03PS14) 10Florianschmidtwelzow: Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) [21:52:09] (03PS9) 10Florianschmidtwelzow: Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) [21:52:11] https://en.wikipedia.org/wiki/Cape_Cod_Kwassa_Kwassa [21:57:59] bearND: hey! let me know if you need anything from me for the ios dev interview monday [21:58:55] mhurd: ok [22:00:03] 3MobileFrontend / 3alpha: Add intermediate screen to warn logged-out editors similar to 'anoneditwarning' message - 10https://bugzilla.wikimedia.org/59937#c24 (10Florian) 5PATC>3RESO/FIX Screen added, in alpha activated :) [22:09:43] (03CR) 10Florianschmidtwelzow: "> Actual: loads talk overlay then closes it" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow) [22:09:53] (03CR) 10Florianschmidtwelzow: [C: 04-1] Use OverlayManager for talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow) [23:27:04] (03PS1) 10Mhurd: onClick and touchEnd handlers were fighting. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/155845 [23:43:20] kaldari, if you have a moment merge https://gerrit.wikimedia.org/r/#/c/155671/ [23:43:28] corresponding VE patch has been merged today [23:58:53] I guess Dan (or someone who was involved in the Windows 8 app) should look at https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7740536 if they don't already know about it [23:58:57] (03PS3) 10Mhurd: Much better handling of TOC show/hide swipe. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/155193