[00:36:02] (03PS7) 10Mhurd: Single generator search query returns both results and thumb urls. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154445 [01:14:33] (03PS1) 10Deskana: Scroll to section after you're done editing it. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156012 [01:20:00] 3Wikipedia App / 3Android App: Return to the section after a mobile section edit - 10https://bugzilla.wikimedia.org/69648#c1 (10Dan Garry) 5NEW>3PATC Patch: https://gerrit.wikimedia.org/r/#/c/156012 [01:21:03] YuviPanda: You about? I just wrote a patch that feels like a really stupid hack and I'd love your input. [01:21:05] YuviPanda: It's linked above. [01:21:16] YuviPanda: Also, typing your name into Spotlight to try to contact you is a poor substitute for actually launching my IRC client. :P [01:21:22] Deskana: :D [01:21:27] * YuviPanda moves to Deskana's filesystem [01:24:10] But yeah, what I wrote feels kind of stupid. [01:24:14] Not sure if it actually is or not. [01:25:08] Going for dinner! I'll check back afterwards. [01:27:20] (03CR) 10Yuvipanda: [C: 04-1] "Minor nit, otherwise looks ok :)" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156012 (owner: 10Deskana) [01:27:45] Deskana: it isn't stupid! Although, does it work? :) I left a nit [01:36:09] YuviPanda: Yeah, it does. Surprisingly. [01:36:18] YuviPanda: I tried a lot of different things and this was the one that worked. :P [01:36:25] Deskana: \o/ [01:36:36] Deskana: I just wasn't sure because I wasn't sure if the scroll to JS command would work [01:36:38] looks like it does [01:36:47] Deskana: is mergeable once the change I suggested is implemented [01:37:01] Basically I delayed the execution of the scroll as late as possible [01:37:06] indeed [01:37:17] I had it after I extracted the section from the intent at first [01:37:25] But it didn't work unless I also stopped the page refreshing :P [01:37:58] Deskana: :D [01:38:30] Deskana: also, getting the fragment passed in by lift - you can do that by checking for the .getFragment() from the title object, and somehow matching that to a section ID :) [01:39:25] Deskana: actually, no, I think that one is possibly simpler, let me look [01:41:18] Deskana: boom, the only thing needed to fix the 'extranl link fragment' problem is sfixing the Site object's titleForInternalLink function to handle fragments [01:41:55] Hm. I was away for the week and the mobile queue is up to 522 :/ [01:42:36] YuviPanda: I'm not sure what you mean. [01:43:38] (03CR) 10Yuvipanda: Scroll to section after you're done editing it. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156012 (owner: 10Deskana) [01:43:41] Deskana: ^ [01:43:46] Krenair: :( [01:43:59] Deskana: we should poke dbrant and bearND to take a look again (at the OTRS queue) [01:44:06] * YuviPanda has stopped doing much of that, part of the 'transition' and all [01:45:55] YuviPanda: So in order to build the scroll payload it looks like you need quite a bit of the object [01:46:09] YuviPanda: That's why I passed the whole object. [01:46:44] Deskana: you can pass the index, and do page.getSections().get(index) to get the section [01:46:54] Ah, that works. [01:47:25] Deskana: objects that are copies of other objects can be dangerous, since you might think you're doing something on an object, while you're actually just doing that thing on a *copy* of the object that's free floating, unattached [01:47:29] 3Wikipedia App / 3Android App: Crash reports with null values? - 10https://bugzilla.wikimedia.org/68308#c2 (10Alex Monk) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7745346 [01:47:48] YuviPanda: Yeah, passing by value as opposed to by reference. [01:47:52] Makes sense. [01:47:58] Deskana: indeed :) [01:50:16] 3Wikipedia App / 3Android App: NPEs from page.PageViewFragment.commonSectionFetchOnCatch - 10https://bugzilla.wikimedia.org/67807#c8 (10Alex Monk) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7747331 [01:52:06] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7748544 - caused by hitting an abuse filter? [01:54:03] Krenair: ugh, looks like [01:54:54] (03PS2) 10Deskana: Scroll to section after you're done editing it. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156012 [01:55:14] (03CR) 10jenkins-bot: [V: 04-1] Scroll to section after you're done editing it. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156012 (owner: 10Deskana) [01:55:31] JENKIIIIIIIINS [01:56:35] YuviPanda: Okay, so I don't understand what Jenkins is saying to me. [01:57:14] Deskana: Java styleguideline errors. [01:57:18] Deskana: go to 'https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/1800/checkstyleResult/' [01:57:22] click 'Details' tab [01:57:40] Deskana: I got there by clicking the link in jenkins error message, and the 'Checkstyle report' or something like that in the left sidebar [01:58:09] Ahh [01:59:26] (03PS3) 10Deskana: Scroll to section after you're done editing it. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156012 [02:01:22] Deskana: there you go :) [02:01:40] Deskana: want me to test+merge or should I leave it to dbrant / bearND? [02:01:47] oh what the hell, let me do it [02:02:31] YuviPanda: You can test. Whether you merge or not is up to you, but I think you still have the right to merge stuff if that's what you're asking. [02:02:44] Deskana: oh, that's a granted :) [02:02:46] :D [02:04:39] Deskana: mostly a question of the fact that I've about 1.5L of beer in me and it's 3AM :) [02:04:46] Haha [02:04:56] Deskana: I'll test + merge when I wake up with less beer [02:05:13] code drunk, but merge sober [02:06:19] That took me a lot longer to figure out than I'd care to admit. [02:06:27] Learned a massive amount though. [02:13:05] Krenair: Thanks for helping with our OTRS queue. We really appreciate it. :) [02:14:32] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7732972 - wut [02:15:14] It looks like that exists to me [02:18:25] How is that a runtime error anyway? Isn't the compiler supposed to pick up such issues? [02:24:15] Krenair: I was betting it was a Samsung device, even before actually reading the device name [02:24:16] it was [02:24:21] Krenair: Samsung does some weird shit sometimes. [02:25:46] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7706846 - also wut [02:28:05] Krenair: my bet is that the user accidentally deleted the rest of them [02:29:26] Also there's a load of java.lang.SecurityException: Permission denied (missing INTERNET permission?) [02:32:37] A lot of stuff from SaneAsyncTask.onCatch [02:34:18] Krenair: yeah, INTERNET permission is I presume custom rooted roms that deny network access by default, nothing much we can do, I think? [02:34:43] Krenair: except perhaps throw up a dialog saying 'sorry, could not access internet', but if they restrict permissions how do they expect the app to work... [02:36:13] Yeah [02:36:18] 3Wikipedia App / 3Android App: NPEs from concurrency.SaneAsyncTask.onCatch - 10https://bugzilla.wikimedia.org/69952 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None java.lang.NullPointerException at org.wikipedia.concurrency.SaneAsyncTask.onCatch(SaneAsyncTask.java:72) https://ticket.wikimedia.org/otr... [02:36:18] It still shouldn't crash [02:41:02] Krenair: probably, yeah [02:48:05] YuviPanda, actually https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7662323# [02:48:49] Krenair: ugh, doubly weird. Also Samsung. [02:49:01] Krenair: I think the solution here is to catch it and display a 'no network connection' error [02:50:18] 3Wikipedia App / 3Android App: Allow change of interface language - 10https://bugzilla.wikimedia.org/68299 (10Sundar) [02:53:41] heh, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7659237# [02:55:16] 3Wikipedia App / 3Android App: Allow change of interface language - 10https://bugzilla.wikimedia.org/68299#c1 (10Yuvi Panda) This is fairly technically hard to do, since we just use Android's default i18n system, which, afaik, does not allow you to programmatically set the language (I'll be happy to be prove... [02:55:25] Krenair: dedicated :) [02:55:28] * YuviPanda should go to sleep [06:36:01] (03PS8) 10Mhurd: Single generator search query returns both results and thumb urls. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154445 [06:53:59] (03PS9) 10Mhurd: Single generator search query returns both results and thumb urls. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154445 [07:53:16] (03PS1) 10Mhurd: Fix for jumpy text when top chrome shows. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/156023 [16:16:03] 3MobileFrontend / 3stable: Image taken in portrait mode is uploaded as landscape - 10https://bugzilla.wikimedia.org/69962 (10Axel Boldt) 3NEW p:3Unprio s:3normal a:3None On Android 4.2.2 with the stock browser I use the mobile interface to upload an image from my photo gallery. It was taken in portra... [16:20:30] 3MobileFrontend / 3stable: Image taken in portrait mode is uploaded as landscape - 10https://bugzilla.wikimedia.org/69962#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/VOhbH1B6 [17:12:45] 3Wikipedia App / 3Android App: Add option to reload an article - 10https://bugzilla.wikimedia.org/68627#c2 (10Florian) New ticket (reload main page): https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7750619 [17:50:17] * Steinsplitter überreicht Florian ein keks. [17:50:29] schön das es mit dem movile upload filter so gut geklapt hat. [18:07:16] 3Wikipedia App / 3Settings: If ToC is open, it should not be possible to swipe open the settings bar - 10https://bugzilla.wikimedia.org/65043#c1 (10Dan Garry) Note that this issue is only present on my tablet but not on my phone, probably because both of them can fit on my tablet's screen at the same time. [18:21:32] 3Wikipedia App / 3Settings: If ToC is open, it should not be possible to swipe open the settings bar - 10https://bugzilla.wikimedia.org/65043#c2 (10Dan Garry) 5NEW>3RESO/FIX This seems to have been fixed at some point, because I can no longer replicate this if I pull from master. The change is probably j... [18:23:45] 3Wikipedia App / 3Android App: It should take me to the browser if I open a special page directly - 10https://bugzilla.wikimedia.org/66157#c4 (10Dan Garry) 5PATC>3RESO/FIX Seems to have been fixed at some point. [18:25:34] 3Wikipedia App / 3General/Unknown: Apps: Long-pressing a wikilink should give you an option to save the target page for offline reading - 10https://bugzilla.wikimedia.org/69930#c3 (10Dan Garry) *** Bug 69400 has been marked as a duplicate of this bug. *** [18:25:34] 3Wikipedia App / 3Android App: allow somehow marking links in Wikipedia app for later reading - 10https://bugzilla.wikimedia.org/69400#c3 (10Dan Garry) 5NEW>3RESO/DUP Although this one was filed earlier, I'm marking this one as a duplicate of bug 69930 since that bug has a clearer description of the way... [18:35:50] 3Wikipedia App / 3Localization/Translation/Language: App should remember your recently accessed languages - 10https://bugzilla.wikimedia.org/62775 (10Dan Garry) 5NEW>3RESO/FIX [18:49:27] Deskana: mark all the things as fixed! :) [20:16:14] (03PS2) 10Mhurd: Fix for jumpy text when top chrome shows. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/156023