[00:00:53] jgonera: yep, what's up? [00:01:02] Maryana, at your desk? [00:37:57] (03CR) 10Kaldari: [C: 04-1] Remove delay when recalculating viewport height on iOS (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/156490 (owner: 10JGonera) [02:37:13] 3Wikipedia App / 3Android App: Return to the section after a mobile section edit - 10https://bugzilla.wikimedia.org/69648#c2 (10Dan Garry) 5PATC>3RESO/FIX Merged! [13:36:13] (03CR) 10Hashar: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [13:41:53] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [14:21:40] (03PS1) 10Cmcmahon: QA: update for API auth token change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/156786 [14:22:25] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/156786 (owner: 10Cmcmahon) [14:22:55] (03Merged) 10jenkins-bot: QA: update for API auth token change [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/156786 (owner: 10Cmcmahon) [14:52:28] 3Wikipedia App / 3Android App: Add support for Portuguese "pt" and "pt_BR" - 10https://bugzilla.wikimedia.org/70107 (10Andre Klapper) [15:47:23] aharoni: The icons in WikiEditor need to be switched over to OOUI, yeah. Right now they're both ugly and can't use OOUI's i18n system for icons. [15:47:52] James_F: \o/ [15:48:00] good to hear that we agree about this. [15:48:35] we are considering making a VERY SIMPLE formatting toolbar for ContentTranslation, and I don't want to localize the Bold and Italic buttons all over again. [15:48:56] aharoni: Use VE's. :-) [15:49:04] Yes, that's what I want. [15:49:53] At the time I opened the Bugzilla requests for localizing them in WikiEditor and VisualEditor, [15:50:10] They are localised in VE… [15:50:16] and I don't want a third bug like this, especially now that I'm in the team that develops it. [15:50:19] Exactly. [15:51:44] (In Hebrew there's an expression that mooeypoo certainly knows: "Third time ice cream." It's nonsensical and nobody quite knows where does it come from. Possibly, but not necessarily from the English "I scream". Anyway, it means "don't do a silly a thing for the third time".) [15:52:29] So, like "the definition of insanity is doing the same wrong thing a third time and expecting a different result", but briefer? :-) [15:52:38] Something like that. [15:52:50] It literally means "you're going to buy me ice cream next time you do this" too. I got a couple of free cones like that, it's a very useful expression. [15:53:07] Ha. [16:44:44] now where the hell is my iphone… [16:44:59] i’ve located every *other* device :D [16:49:34] ok, i’ll just use the ipod for testing today :P [16:50:22] i wonder if i turned on ‘find my iphone’…. probably forgot [16:50:37] brion: how about you try to call it? [16:50:45] oh yeah [16:50:49] i forgot it works as a phone too [16:51:02] :) [16:52:25] magic! found it just before my other phone booted up enough to call it [16:56:27] nice [17:03:48] (03CR) 10Jdlrobson: Fix wgMFShowRedLinks (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [17:04:13] * MaxSem pokes awjr_away [17:06:56] * awjr waves to MaxSem [17:06:57] you poked? [17:07:19] awjr, you promised to review something:) [17:07:33] i did :) [17:07:36] today. [17:10:29] vbamba: you about? [17:13:25] ok old 3gs still has to charge a bit so let’s start with ios 7 \o/ new toc code, time to test you! [17:15:41] (03CR) 10Brion VIBBER: "Custom scroll indicator looks good at the top of the page, but toward the bottom the indicator actually slips down past the bottom edge. L" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154369 (owner: 10Mhurd) [17:16:39] (03CR) 10Mhurd: "Ok to tweak this later?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154369 (owner: 10Mhurd) [17:16:55] brion: ^ either way [17:17:10] (03CR) 10Florianschmidtwelzow: "> I would suggest writing a php unit test to go with this change." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [17:17:16] (03CR) 10Brion VIBBER: "Yeah as long as we don't lose it :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154369 (owner: 10Mhurd) [17:17:23] brion: cool got it [17:18:00] aha 3gs booted, let’s try on 6.1 :D [17:19:24] brion: the worker context patch seems to clear up all the ios 6 lockups. will submit that after these if that’s ok [17:19:43] yeah that’d be perfect :D [17:19:43] yay! [17:21:58] 3Wikipedia App / 3iOS App: edit summary is in one line in iOS app - 10https://bugzilla.wikimedia.org/69275 (10Dan Garry) [17:22:48] (03PS4) 10Dbrant: Improve the way that sections are loaded into the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156304 (https://bugzilla.wikimedia.org/69700) [17:23:03] yeah the toc comes up a lot faster on the slow phone now :D [17:23:36] woohoo! [17:24:21] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Woohoo mucho faster on old 3Gs! Can tweak the scroll indicator position in a followup." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154369 (owner: 10Mhurd) [17:24:40] yay! [17:27:34] (03PS13) 10Brion VIBBER: Single generator search query returns both results and thumb urls. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154445 (owner: 10Mhurd) [17:28:35] manual rebase ….. [17:29:17] (03Abandoned) 10Jdlrobson: Instrumentation to test benefits of lazy loading in editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150044 (owner: 10Jdlrobson) [17:30:47] brion: so for both the search and the nearby, for faster thumbnail access, i’m using the temp dir as a storage bucket. the os can clear items out of it if it needs to, but the code should handle that gracefully [17:31:32] nice [17:32:16] brion: really shines in nearby where we have a long list of results. the result images, in both cases, are only retrieved when their respective cell is onscreen, so lazily. also, thumb retrieval ops are cancelled if respective interface is hidden [17:32:55] (03CR) 10Brion VIBBER: "Interestingly, this changes the order of search results: they come up alphabetically now instead of in .... whatever order the search retu" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154445 (owner: 10Mhurd) [17:33:04] mhurd: sweet! [17:33:41] mhurd: niiiice i can actually typer a search term like ‘los angeles’ at normal speed and it doesnt explode on ios 6 :DD [17:34:04] (03CR) 10Mhurd: "Yes, the generator query returns a slightly different order, but I massage the results to move more exact matches to the top. Max is worki" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154445 (owner: 10Mhurd) [17:34:36] (03CR) 10Brion VIBBER: "Muuuuuuuch improved search-during-typing performance on iOS 6.1/iPhone 3Gs! \o/" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154445 (owner: 10Mhurd) [17:34:36] brion: yay fewer explosions! [17:34:43] lol [17:34:45] hehe [17:35:09] if ([device iOSVersionLessThan:@“7.0.0”) { [device explode] } [17:35:15] hahaha [17:36:07] mhurd: i don’t know if you remember BeOS, it was a niche OS from some ex-apple guys back in the late 90s early 2000s [17:36:18] but it had some handy functions [17:36:21] is_computer_on() [17:36:26] brion: i sure do! :) [17:36:30] lol [17:36:41] always returned true i hope [17:36:42] is_computer_on_fire() [17:36:50] “Returns the temperature of the motherboard if the computer is currently on fire. If the computer isn't on fire, the function returns some other value.“ [17:36:58] bahaha [17:38:16] interesting, enumateObjectsUsingBlock passes a boolean outvar to let you stop the enumeration [17:38:20] that’s a …. wacky interface [17:38:55] yeah it’s a pointer to a bool right? [17:39:02] yeah [17:39:12] makes sense, since you can’t use the lexical break/continue there [17:39:15] just feels weird :D [17:39:32] objc is such a mix of old and new patterns these days [17:39:32] MaxSem: is it true that this change disables uploads from MF completely? https://gerrit.wikimedia.org/r/#/c/156523 [17:39:37] yeah blocks are strange [17:39:52] chrismcmahon, yep [17:41:00] MaxSem: do you know if that change is expected to be permanent? or would we expect to allow uploads again at some later time? [17:41:23] so far the plan was to attemt a revisit it at some point [17:41:42] mhurd: i like the new placeholder icon too [17:42:02] MaxSem: thanks, that's what I wanted to know [17:42:21] brion: looks better when rounded for sure. design folks said it’s cool for now but they’ll prob have tweaks later [17:42:31] ok [17:43:20] (03CR) 10Brion VIBBER: [C: 032 V: 032] Single generator search query returns both results and thumb urls. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/154445 (owner: 10Mhurd) [17:44:50] (03CR) 10Brion VIBBER: [C: 032 V: 032] Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/156472 (owner: 10BearND) [17:49:53] (03PS1) 10Dbrant: Correctly jump to a specific section from an incoming link. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156823 (https://bugzilla.wikimedia.org/69948) [17:50:39] rebasing nearby... [17:50:40] (03PS38) 10Brion VIBBER: Nearby entry in main menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153071 (owner: 10Mhurd) [17:50:54] (03CR) 10Jdlrobson: "Make $wgMFEnableBeta = true; -> $wgMFEnableBeta = false; and then feel free to self merge" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) (owner: 10MaxSem) [17:54:27] (03CR) 10Dbrant: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156471 (owner: 10BearND) [17:55:15] brion: were those rebases pretty clean? [17:56:04] mhurd: yeah just minor clashes with adjacent lines added in #imports or project file [17:56:17] brion: cool [17:58:01] man, a lot of bus stops in my neighborhood have wikipedia articles :D [17:58:06] haha [17:58:41] oh neat, there’s a little park just a quarter mile from here. might make for a pleasant walk some time *bookmark* [18:01:23] brion: w/nearby i found a hotel near my apt that has each room painted by an artist. hotel de arts iirc. sounded really cool [18:01:33] cool! [18:01:48] brion: it’s like 80 feet from where i live and i had no clue [18:02:17] (03PS1) 10Cmcmahon: QA: uploads removed from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/156826 [18:04:25] mhurd: my main quibbles right now are i’m not sure if the long-press is discoverable; and if you click through to an article it’s hard to get back if you were down on the list somewhere [18:04:28] but we can work those out later [18:04:33] lemme finish going through the code :D [18:04:49] [[[NSLocale currentLocale] objectForKey:NSLocaleUsesMetricSystem] hell yes for making our job easier [18:04:55] brion: agreed. we’ll def need to tweak that [18:04:58] haha yes! [18:05:00] lemme try switching my phone to metric :D [18:06:08] nice, i switched regional settings to Canada and it just flipped to km automatically [18:07:11] the nearby view is pretty slow to update on the 3gs, i bet we could improve the responsiveness of that… maybe it’s in the graphics [18:07:17] runs *smooth as heck* on the 5s though :D [18:07:27] :) [18:08:24] hmmm [18:09:41] something seems wrong with the distances [18:10:01] nearest bus stop shows as ~109 feet or 0.11km [18:10:26] that should be like 33 meters [18:10:40] if the feet was right [18:11:17] mhurd: is distance always in meters and converted on display? or does it swtich around as well [18:12:36] brion: hmmm i don’t recall. iirc it’s always reported in meters… it may be that i’m not converting these to feet? [18:12:54] when non metric is reported [18:13:39] lessee…. in NearbyResultCell.m [18:14:06] if (distance.floatValue > (5279.0f / 10.0f)) { [18:14:06] NSNumber *displayDistance = @(distance.floatValue / 5280.0f); [18:14:24] yeah that looks like it’s assuming distance was in feet [18:14:37] whereas on the metric side it assumes meters [18:15:03] brion: should be easy tweak. mind if i do this as a quick follow-up post merge later today? [18:15:12] sure [18:15:16] i’ll add anote [18:15:23] good catch for sure! [18:19:01] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Non-metric (feet/miles) display is incorrect, needs to convert meters to feet before it goes calculating and displaying. :) Display is a b" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/153071 (owner: 10Mhurd) [18:19:23] mhurd: ok i think that’s evertyhing that was waiting :D [18:19:40] i’m gonna grab some food and check back in on the state of the trello cards :D [18:19:51] woohoo i’ll get the workerContext to you in a few! thanks!!! [18:20:06] brion: ^ [18:20:45] my phone’s beeping about an iteration review. i thought that was tomorrow? [18:21:10] ya tomorrow i think [18:21:20] whew :) [18:21:24] :) [18:21:25] rogue calendars! [18:49:31] Deskana: kristenlans I responded about the iteration review, unsure if you guys got the email [18:50:21] YuviPanda|zzz: Yep. Sucks, but unavoidable unfortunately. [18:50:29] Deskana: yeah, 'tis ok [18:56:05] Deskana: anything in the next sprint that we critically need Yuvi’s input on? https://trello.com/b/ylAF2Yey/mobile-app-sprint-39-navigation-9-1 [18:56:38] kristenlans: Nope. :) [19:07:12] (03PS1) 10Mhurd: No more flaky worker context. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/156875 [19:13:13] kristenlans: :) I'm moving to the Ops team in a month and so, and so have been slowly moving to the background anyway :) [19:13:38] kristenlans: Deskana|Away if you look at my goals for this quarter at https://office.wikimedia.org/wiki/Goals/2014-2015/Engineering_and_Product_Development/Yuvaraj_Pandian the primary one is 'make myself redundant in the apps team' and that seems to be going well [19:17:37] mhurd: woohoo! taking a peek [19:17:44] (03PS1) 10Dbrant: Fix jerking effect when scrolling with RTL language. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156876 (https://bugzilla.wikimedia.org/69754) [19:17:53] * kristenlans gives YuviPanda a bittersweet high-five [19:18:14] kristenlans: :) I'll still be around after that as well - and even more perhaps, since I'll move to SF :) [19:18:20] * YuviPanda gives kristenlans a hi5 too [19:19:00] an sf_yuvi woohoo! [19:19:20] brion: :) [19:19:30] brion: the US govt. is supposed to give me a response in about 3 weeks [19:19:38] (03PS4) 10MaxSem: Add a configuration setting to disable beta and alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) [19:19:48] brion: although, with possibility of Ebola in India, I might not be back in India by the time it arrives [19:19:54] heh [19:19:58] and if there's an actual confirmed case, I might not go back for a while :| [19:20:07] (03CR) 10MaxSem: [C: 032] "Because Jon told me to" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) (owner: 10MaxSem) [19:20:09] :( [19:20:12] (03CR) 10jenkins-bot: [V: 04-1] Add a configuration setting to disable beta and alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) (owner: 10MaxSem) [19:20:28] fuck you jerkins [19:22:53] MaxSem: “jerkins” LOL [19:24:30] (03PS5) 10MaxSem: Add a configuration setting to disable beta and alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) [19:25:29] i just added the missing DNS entry for the Polish chapter [19:25:34] pl.m.wikimedia.org is an alias for m.wikimedia.org. [19:25:34] m.wikimedia.org is an alias for mobile-lb.eqiad.wikimedia.org. [19:25:46] and told wikimedia-pl [19:25:59] they had reported they already have MobileFrontend on [19:26:06] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Been banging away at the touchscreen for a few minutes and nothing's exploded! \o/ Definitely seems to simplify things." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/156875 (owner: 10Mhurd) [19:26:48] flyingclimber: ^ in case they ask in Polish maybe :) [19:28:15] (03CR) 10MaxSem: [C: 032] Add a configuration setting to disable beta and alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) (owner: 10MaxSem) [19:28:48] (03Merged) 10jenkins-bot: Add a configuration setting to disable beta and alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155814 (https://bugzilla.wikimedia.org/69793) (owner: 10MaxSem) [19:30:35] MaxSem: wanna +2 https://gerrit.wikimedia.org/r/#/c/156878/? :) [19:30:42] mutante, now need to enable redirection for them [19:31:27] http://pl.m.wikimedia.org/wiki/Strona_g%C5%82%C3%B3wna [19:31:32] that looks like it works to me [19:31:45] MaxSem: in addition to that? ok [19:32:00] ah, of course, gotcha [19:32:14] mutante, yep - but mobile devices aren't getting redirected to it yet:) [19:32:21] 1 sec... [19:32:40] heee heee [19:32:44] btw mutante, did any other wiki request it for them? [19:32:53] that makes a lot of sense [19:33:15] no, i didnt see other requests myself, BUT lazowik just pointed out one other one [19:33:47] 12:31 < lazowik> mutante: I checked yesterday, at least ar has also mobilefrontend enabled [19:33:51] ar [19:34:13] 3MobileFrontend / 3beta: 3rd partys should be able to turn off beta and alpha mode - 10https://bugzilla.wikimedia.org/69793 (10Florian) 5PATC>3RESO/FIX [19:37:50] mutante, all wikis but wikidata have MF. the question is whether they have an adequate mobile main page [19:38:30] just committed a redirect update [19:38:42] MaxSem: are you in the office? [19:38:54] awjr, nope - next week [19:39:00] ah right - russia! [19:39:27] MaxSem: i'm trying to get vagrant set up on my new laptop then i'll test your changes [19:39:45] yay new shinies! [19:39:53] \0/ [19:40:12] too bad vagrant installation is not going so smoothly though :( [19:41:28] (03PS5) 10Dbrant: Improve the way that sections are loaded into the WebView. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156304 (https://bugzilla.wikimedia.org/69700) [19:44:17] (03PS2) 10Dbrant: Correctly jump to a specific section from an incoming link. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156823 (https://bugzilla.wikimedia.org/69948) [19:46:50] MaxSem: you should +2!! [19:50:27] (03PS1) 10Dbrant: Hide keyboard when Search fragment disappears. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156888 (https://bugzilla.wikimedia.org/69479) [19:59:38] YuviPanda: Your job is to make sure you have no job! [19:59:40] (in apps) [19:59:42] ;) [19:59:55] Deskana: indeed! And I'll do well if I do nothing! :P [20:05:25] kristenlans: Ping! Backlogging? :) [20:05:51] Yo, I’m in the hangout! [20:06:04] Uh, well actually, I need to press Join. Doh! [20:06:53] (03PS1) 10Dbrant: Make "retry" button expand vertically to fit text. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/156895 (https://bugzilla.wikimedia.org/70105) [20:09:56] YuviPanda: I hope I've been making this 'job' of yours easier! [20:10:43] dbrant: very much so, indeed :) [20:10:59] 3Wikipedia App / 3Generic: iPhone URL protocol handler to open Wikipedia App from Safari - 10https://bugzilla.wikimedia.org/52472#c4 (10Dan Garry) 5UNCO>3RESO/INV This feature request has insufficient context for me to understand what it means. If you can add more explanation, please reopen the bug and... [20:11:59] 3Wikipedia App / 3Generic: Search bar is sometimes missing when TOC drawer closing action is interrupted by tapping back - 10https://bugzilla.wikimedia.org/64666#c2 (10Dan Garry) 5NEW>3RESO/FIX Can't reproduce, so I'm assuming this was fixed. [20:12:59] 3Wikipedia App / 3Generic: Tapping "play" on