[00:11:16] dbrant|bbl: I'm playing around with the page issues code. [00:11:36] dbrant|bbl: I've got it enabled on my build by setting releaseType to RELEASE_BETA but I can't change the colour of the text very easily. [00:12:00] dbrant|bbl: I thought it was in that isEnabled() method because there was a comment in there that made reference to making it look clickable, but when I change that method to return true instead of false, nothing change. [00:12:26] Deskana: checking... [00:12:57] ARGH, ADAPTERS [00:13:00] I HATE YOU ADAPTERS [00:13:46] All I wanted to do was make it blue without having to bother you, and I ended up having to bother you anyway. :P [00:13:56] Deskana: no worries! [00:14:19] Deskana: so, to change the text color, you'll need to change the CSS (assets/styles.css) [00:14:32] So what does isEnabled() do? [00:14:44] Methods that you can change from false to true that do nothing are... questionable. :P [00:14:54] Deskana: where exactly is this? [00:15:17] Line 59 in IssuesHandler.java [00:15:48] Oh, does that control the clickability of the buttons? [00:16:06] In the dialogue. [00:16:10] Deskana: ah, that's just so that the list item isn't "clickable". We don't want to give the user the impression that there's an "action" to be taken by clicking it. [00:16:20] Ahh, right! [00:16:49] Deskana: in the CSS, you want "a.issues_button" and "a.disambig_button" [00:17:14] What's the colour for a link? [00:17:51] we have it as #347BFF [00:18:19] Okay, cool. [00:18:20] Thanks. :) [00:18:35] anytime [00:19:20] I like the way we've got the alpha/beta/prod set up in WikipediaApp.java. [00:19:46] :D [01:01:57] dbrant: Hmm, it doesn't look like #347bff is the right colour. [01:02:25] dbrant: http://i.imgur.com/bFRpkcF.png [01:02:59] dbrant: Although it's up for debate whether it should be the exact same colour I guess. [01:16:03] (03PS1) 10Deskana: Make article issues and disambiguation links appear clickable. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159236 [01:19:52] Deskana: isn't it "pages" instead of "articles"? [01:20:12] Ah, that crap again. [01:20:21] Whatever. [01:20:31] :) [01:21:25] (03PS2) 10Deskana: Make article issues and disambiguation links appear clickable. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159236 [01:21:28] dbrant: Thanks. :) [01:30:35] (03PS2) 10NightlyNexus: use default browser instead of chooser when appropriate [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159198 [01:31:32] (03CR) 10NightlyNexus: "I understand. Thanks!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159198 (owner: 10NightlyNexus) [02:09:07] (03PS1) 10Esanders: Update OOJSui class names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159243 [02:10:19] (03PS2) 10Jforrester: Update OOjs UI class names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159243 (owner: 10Esanders) [02:10:24] (03CR) 10Jforrester: [C: 032] Update OOjs UI class names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159243 (owner: 10Esanders) [02:10:55] (03Merged) 10jenkins-bot: Update OOjs UI class names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159243 (owner: 10Esanders) [02:11:13] (03PS1) 10Jforrester: Update OOjs UI class names [extensions/MobileFrontend] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159244 [13:37:14] (03PS1) 10Dbrant: [WIP] Nearby -- with magnets! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159296 [14:21:44] (03PS2) 10Dbrant: [WIP] Nearby -- with magnets! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159296 [15:06:27] Deskana: a couple notes regarding your patch: [15:07:00] dbrant: Hit me! [15:08:10] Deskana: the CSS should actually be changed via the MobileApp extension. It contains the .less files from which the resulting CSS is built. Once the MobileApp patch is merged, it's then deployed to labs, and then we pull the resulting CSS into the app code. [15:08:49] Mmm, I did wonder about that. [15:09:23] Deskana: In MobileApp, you'll want to modify /less/issues.less and /less/disambig.less [15:09:38] (and /less/night.less for night mode!) [15:10:09] Night mode! [15:10:09] (03CR) 10MarkTraceur: [C: 032] Update OOjs UI class names [extensions/MobileFrontend] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159244 (owner: 10Jforrester) [15:10:11] Okay, cool. [15:10:26] I'll abandon that and submit the string change as a separate patch. [15:10:27] Thanks! [15:10:45] (03Merged) 10jenkins-bot: Update OOjs UI class names [extensions/MobileFrontend] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/159244 (owner: 10Jforrester) [15:10:56] Deskana: yw! (the link color for night mode is #2B6FB2) [15:11:18] By the way, it seems like #347bff isn't the link colour used in normal mode. [15:11:27] http://i.imgur.com/bFRpkcF.png [15:11:31] They seem a bit different. [15:11:58] * Deskana shrugs [15:12:07] Deskana: indeed... it seems to be the link color used throughout the app, except inside the webview. [15:12:18] a question for Vibha... [15:12:20] Hah. [15:12:29] Deskana: pardon me, "colour". [15:12:38] :D [15:14:07] (03Abandoned) 10Deskana: Make article issues and disambiguation links appear clickable. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159236 (owner: 10Deskana) [15:36:17] Android devs here? :) [15:36:40] roger! [15:37:29] dbrant: This change was merged (https://gerrit.wikimedia.org/r/#/c/150014/), i'm not familar with the "deploy" process :) Can you say, when this feature will go into Beta/Stable app? [15:37:39] So bug (https://bugzilla.wikimedia.org/show_bug.cgi?id=68438) can be closed? [15:40:09] FlorianSW|hotel: yep, it will go into the Beta app as soon as we release the next build to the Play Store. [15:40:26] dbrant: is there a plan for this? :) [15:41:00] Random question: if I'm understanding correctly, "WikipediaApp/2.0-r" is more recent than /4, which is version 4 of the old-style? [15:41:14] 3Wikipedia App / 3Android App: Add full text search functionallity - 10https://bugzilla.wikimedia.org/68438#c4 (10Florian) 5PATC>3RESO/FIX Patch merged, set to resolved :) Thanks! [15:41:59] FlorianSW|hotel: for the Beta app, we have a "soft" release cadence of every Wednesday. Although we haven't made releases for a couple Wednesdays, since there haven't been that many ground-breaking things :) [15:42:42] dbrant: Ah, ok :) But that it will be in the next beta release is enough for me :) Thanks! [15:44:11] Ironholds: iirc, version 4 is the iOS app... [15:44:27] Ironholds: the old-style Android app was version 1.4 [15:44:28] huh. weird. [15:44:39] Ironholds: "WikipediaApp/2.0-r" are the production versions of the native Android app. The native iOS app is version 4 [15:44:39] okay. and how recent is version 4/iOS? [15:44:45] gotcha [15:45:05] 4.0.1, how recent? [15:45:10] only I'm getting hits without UUIDs [15:45:15] not critical, just thought you guys should know. [15:45:30] Ironholds: Aug-04: https://itunes.apple.com/us/app/wikipedia-mobile/id324715238?mt=8 [15:45:44] ta. [15:49:34] bearND, please look at https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7778723#9229578 [15:49:40] (03PS1) 10Dbrant: Fix fetching/saving of page thumbnails (for showing in History/Saved) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159328 [15:50:53] Krenair: dbrant: that's because of Googles deep linking of apps. Not sure how to fix it [15:51:19] So, say 'Ask Google?' [15:51:58] Krenair: the issue is indeed on Google's end; there's not much we can do about it. [15:52:38] hmm, terrible this deep linking :( [15:52:48] I think there were some earlier OTRS reports about it, too. I thought Deskana responded to one. [15:53:05] https://bugzilla.wikimedia.org/show_bug.cgi?id=68275 [15:53:10] (although I can't reproduce it on my devices) [15:53:17] all tickets linked to the one in com0 [15:53:38] i can reproduce on HTC One and nexus 7 [15:57:31] I can't believe you guys still haven't dealt with these - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketQueue;QueueID=323;View=Preview [15:58:39] Krenair: the Sprint communique was forwarded to the Partners team. I would think that they followed up outside of OTRS... [15:59:26] I don't see any forward... [16:11:25] Krenair: So the Sprint one is not up to us, that's up the Partners team. And the other one about Android wear, I have a hangout with that guy at 11am today. :) [16:36:47] 3MobileFrontend / 3beta: Can't easily add new section to user talk page - 10https://bugzilla.wikimedia.org/70614 (10pamdavies7) 3UNCO p:3Unprio s:3normal a:3None If I go to an article talk page, whether it exists or not, I'm offered a blue "Add discussion" button. If I go to a user talk page, I just... [16:38:45] 3MobileFrontend / 3beta: Can't easily add new section to user talk page - 10https://bugzilla.wikimedia.org/70614#c1 (10pamdavies7) Sorry, should have included "In Mobile Beta on Android phone" in subject line and/or text. [16:40:29] 3MobileFrontend / 3beta: Can't easily add new section to user talk page - 10https://bugzilla.wikimedia.org/70614#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/5QU04zgo [16:51:14] (03PS2) 10BearND: Don't pass whole Section object over intent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159172 (owner: 10Dbrant) [16:51:31] dbrant: Is this ^ ready to be merged? [16:52:12] bearND: yep! [16:52:39] dbrant: I assume the dependend patch is, too [16:52:49] bearND: yep! [16:52:57] dbrant: cool [16:56:29] Ah, so at least I know I wasn't the only one that tried to pass an entire Section over an intent. :) [16:57:51] it's not the worst thing... but it can certainly cause slowdowns. [16:58:32] (03CR) 10BearND: [C: 032] Don't pass whole Section object over intent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159172 (owner: 10Dbrant) [16:58:51] (03Merged) 10jenkins-bot: Don't pass whole Section object over intent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159172 (owner: 10Dbrant) [16:58:57] (03PS2) 10BearND: Fix fetching/saving of page thumbnails (for showing in History/Saved) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159328 (owner: 10Dbrant) [17:02:16] (03CR) 10BearND: [C: 032] Fix fetching/saving of page thumbnails (for showing in History/Saved) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159328 (owner: 10Dbrant) [17:02:33] (03Merged) 10jenkins-bot: Fix fetching/saving of page thumbnails (for showing in History/Saved) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159328 (owner: 10Dbrant) [17:03:11] dbrant: did you want to merge https://gerrit.wikimedia.org/r/#/c/159198/2? [17:05:08] bearND: I was going to ask Deskana and/or vbamba about that... I think we should always have a chooser when going to an external link (as a visual cue that the user is about to leave the app). What do you think? [17:23:25] dbrant: agreed [17:35:58] dbrant: Deskana|Away: if you don't mind I'm going to cut a beta release [17:36:41] dbrant: sure! [17:36:50] bearND: ^ [17:36:51] bearND, that pinged me for some reason phaha [17:41:50] 17 september guys, iOS 8. [17:48:44] 3Wikipedia App / 3Android App: NPEs from page.PageViewFragment.commonSectionFetchOnCatch - 10https://bugzilla.wikimedia.org/67807#c9 (10Alex Monk) 5RESO/FIX>3REOP https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7784958 [17:57:51] bearND: Go for it! [18:07:55] PHP Fatal error: Cannot use object of type stdClass as array in /usr/local/apache/common-local/php-1.24wmf20/extensions/MobileFrontend/includes/MobileFrontend.hooks.php on line 329 [18:07:58] There's quite a few of them [18:08:43] PHP Warning: Error 0 executing convert -trim -border 3 -bordercolor '##FFCC33' -background '##FFCC33' -fill '#000000' -font '/usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.ttf' -pointsize '10' 'label:Your FREE Wikipedia Access is brought to you by SUN' gif:-: convert: geometry does not contain image `Your FREE Wikipedia Access is brought to you by SUN' @ warning/attribute.c/GetImageBoundingBox/239.#012GIF89a#015#001#024 in [18:08:43] /usr/local/apache/common-local/php-1.24wmf19/includes/debug/MWDebug.php on line 302 [18:08:48] yurikR: ^ [18:10:43] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159355 [18:11:11] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159355 (owner: 10BearND) [18:11:29] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159355 (owner: 10BearND) [18:11:42] "You'll be able to download iOS 8 on September 17th." [18:16:47] 3MobileFrontend / 3General/Unknown: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 329 - 10https://bugzilla.wikimedia.org/70618 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None PHP Fatal error: Cannot use object of type stdClass as array in /us... [18:18:14] 3MobileFrontend / 3stable: mobile redirect only works on canonical URLs - 10https://bugzilla.wikimedia.org/70312#c9 (10Ryan Kaldari) MaxSem: So you're suggesting that we should only redirect page views and not things like diffs or action=edit, etc.? In that case we should close bug 61489 as WONTFIX and rever... [18:20:29] 3MobileFrontend / 3General/Unknown: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 329 - 10https://bugzilla.wikimedia.org/70618#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/RYg27a2l [18:23:31] 3MobileFrontend / 3General/Unknown: PHP Fatal error: Cannot use object of type stdClass as array in MobileFrontend.hooks.php on line 329 - 10https://bugzilla.wikimedia.org/70618#c2 (10Max Semenik) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 67596 *** [18:46:03] Reedy, thx, i'll take a look [18:46:17] I logged a bug for it too [18:50:23] MaxSem: are you on top of bug 67596 or should I work on it? [18:51:21] kaldari, the bug's not ours, right? [18:51:59] I looked a lot at the core code, couldn't figure out why is it barfing objects instead of arays... [18:53:36] MaxSem: I added a comment to the bug about why it's casting to object, but it looks like it's been doing that since 2011. I don't really see how our hook handler was ever working correctly. [18:54:08] well, it seems to receive the right arams most of the time [18:54:24] otherwise the error would've been far more frequent [18:56:17] MaxSem: I guess there are certain cases where SpecialPageFactory::getList() is getting called twice maybe? [18:57:04] but it has if ( !is_object( self::$list ) ) [18:57:12] Yeah, just noticed that :P [18:58:50] This is a real head-scratcher. I don't see how it was ever working correctly. [19:00:00] I don't se how it can ever work incorrectly! [19:01:41] * Ironholds looks into channel, reads, nods, deletes mobile app and starts drinking [19:14:07] (03PS11) 10Jdlrobson: Show anoneditwarning when $wgMFAnonymousEditing = true [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155863 (owner: 10Florianschmidtwelzow) [19:14:50] (03CR) 10Jdlrobson: [C: 032] Show anoneditwarning when $wgMFAnonymousEditing = true [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155863 (owner: 10Florianschmidtwelzow) [19:15:23] (03Merged) 10jenkins-bot: Show anoneditwarning when $wgMFAnonymousEditing = true [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/155863 (owner: 10Florianschmidtwelzow) [19:17:14] 3Wikipedia App / 3Android App: NPEs from android.support.v4.widget.DrawerLayout.isContentView ? - 10https://bugzilla.wikimedia.org/67808#c3 (10Alex Monk) According to https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7785062 it's this specifically: java.lang.NullPointerException: At... [19:20:59] MaxSem: Don't we need to change $list['Watchlist'] = 'SpecialMobileWatchlist'; to $list->Watchlist = 'SpecialMobileWatchlist'; in order for it to work? [19:21:13] we got 135,765,392 app PVs in August. Trivia of the day. [19:22:13] You can't just treat object keys as array keys in PHP, right? [19:23:51] Maryana: why is the office so quiet. Is something happening that i'm not aware of? [19:24:08] app testing upstairs :) [19:24:14] there's free food -- come on up! [19:24:31] grr [19:24:34] * Ironholds should eat [19:24:50] Maryana, I'll have all that data for you by Wednesday morning by the way, and a Super Awesome Surprise Present on Friday. [19:24:58] oooh [19:25:01] can i have it now? [19:25:02] :D [19:25:06] sure! [19:25:19] I'll just need your entire department budget and a mechanical turk account :D [19:25:44] doin' it old skool. [19:25:45] i have one of those things [19:25:51] but not the one that matters [19:26:11] there was a guy mailing security@ , he was all "omg, wikipedia mobile app can be debugged" [19:27:05] hahah [19:27:17] Maryana: Did Max go to lunch? [19:27:23] he's right here [19:27:30] eatin' free app food :) [19:27:42] except he just went to the kitchen.. need him for something? [19:28:15] I just wanted him to explain his comment above related to Bug 67596 [19:28:24] since it didn't make sense to me [19:29:37] jdlrobson: can you have a quick look to change https://gerrit.wikimedia.org/r/#/c/135311/ (my last comment)? [19:31:31] kaldari: You can't just treat object keys as array keys in PHP, right? -> i think you're right :) But you can create an ArrayObject to do so: http://php.net/manual/de/class.arrayobject.php [19:32:05] ughughugh [19:33:02] FlorianSW|hotel: true, that would be another way to fix it [19:33:32] MaxSem: I guess you guys are chowing down. I'm going to get some lunch myself now... [19:34:47] kaldari, maxsem: But i never used ArrayObject with an object, so it would be clever to check, if the var is an array before to create the new arrayobject :) [19:34:57] max is too busy trying to break the app :) [19:35:11] kaldari, maxsem: ah no, can be an object or an array: http://php.net/manual/de/arrayobject.construct.php [19:35:12] but core does setobject() right after callig our hook... [19:35:49] MaxSem: http://etherpad.wikimedia.org/p/WikipediaiOSTesting [19:37:15] MaxSem: true, but how does that hook ever get called unless the list is already an object? [19:37:40] that's the question [19:39:17] MaxSem: and actually it's even more complicated because the object is put inside an array when the hook is called. [19:40:18] MaxSem: oops, nevermind, that's just the hook parameter array :) [19:41:25] MaxSem: Does PHP return true for is_object() on arrays maybe? [19:42:26] easy to check [19:43:49] bool(false) [19:47:24] MaxSem: Oh nevermind, I didn't notice the !. It only calls hte hook if the list is NOT an object. So you're right, it should always work :) [19:47:57] what I was trying to explain for the last hour;) [19:48:24] THE CORE HAS AN IMPOSSIBLE BUG REEDY FIX IT [19:50:33] MaxSem: you're totally right :) [19:53:33] MaxSem: remind me never to trubleshoot bugs before lunch [19:54:11] try drinking coffee during breakfast?:P [19:59:42] dbrant: Deskana|Away: published Android beta app [20:00:00] bearND: \o/ [20:00:12] bearND: now, this is the first beta that includes full-text search, correct? [20:00:45] bearND: ...and we've got the session logging in there... excellent! [20:00:52] dbrant: that's correct [20:18:17] @android-devs: Do you know any problem of the Wikipedia App, that you can only edit under your username, when you logged in in the web browser? [20:18:25] dbrant: ^ [20:18:54] FlorianSW|hotel: doesn't sound familiar... [20:19:43] FlorianSW|hotel: you should be able to log in via the app, independendly of where else you're logged in. [20:19:46] MaxSem: analytics/limn-mobile-data and wikimedia/limn [20:20:33] dbrant: that is, what i think too :) Thx! [20:20:34] FlorianSW|hotel: looking [20:21:11] FlorianSW|hotel: The comment should say this is purely cosmetic then [20:21:24] as in current form it looks like you are escaping for security reasons :) [20:22:11] jdlrobson: ah, ok :) That sounds plausible :P I will change it. [20:22:23] (03CR) 10Jdlrobson: Insert section name in edit summary (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) (owner: 10Florianschmidtwelzow) [20:22:28] FlorianSW|hotel: there you go for future reference ^ [20:22:29] * FlorianSW|hotel looking if the hotel's wlan allows SSH connections [20:22:47] also FlorianSW|hotel i'm switching back to working on mobile codebase next week so will hopefully have lots of time to overhaul the talk pages with you [20:23:33] jdlrobson: great. thx :) Next week i hope i'm "normalized" too, first vacation, now a trip to berlin :) [20:24:07] FlorianSW|hotel: my work on Flow is making me want to revisit talk ;-) [20:24:07] FlorianSW|hotel: yeyyyy vacation :D [20:24:07] that's great [20:24:26] jdlrobson: finished work on flow? :D [20:25:25] jdlrobson: what do you think: Can we move the MF talk page from LQT to flow? I think there is all said in the discussion (on mw.org)? [20:25:45] FlorianSW|hotel: well Flow is not finished ;-) [20:25:57] FlorianSW|hotel: I would like to but sadly it's not that easy yet :/ [20:26:01] jdlrobson: No product is ever finished :D [20:26:17] jdlrobson: "Just" a config change, or not? [20:26:20] we either need to archive LQT or migrate it to Flow see https://gerrit.wikimedia.org/r/119243 [20:26:46] * FlorianSW still at the hotel, but name is shorter now :P [20:27:06] argh, the old threads, yeah :/ [20:35:01] (03PS17) 10Florianschmidtwelzow: Insert section name in edit summary [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/135311 (https://bugzilla.wikimedia.org/60134) [20:38:31] kaldari: Argh, what happened to ee-dashboard? [20:39:13] it's broken. I told the core features team it was broken last week, so hopefully they'll fix it [20:39:34] It was working mid-last week for me. [20:39:55] It's got the only public-facing VE metrics, so it'd be nice to get it fixed. [20:40:03] Should I talk to Erik B.? [20:40:56] James_F: Yes [20:43:04] James_F: All the documentation about how they are set up is at https://wikitech.wikimedia.org/wiki/Ee_dashboard (which I sent to Erik B). I would look at it myself, but we're too swamped right now with only 2 devs. [20:49:08] kaldari: Yeah, no worries at all. [20:51:59] MaxSem: api question: given a "File:" page title, is there a way to retrieve a list of URLs for the various resolutions in which it's available? [20:57:48] kaldari: i want to make some tweaks to the copy on inline wikigrok version a – will that totally destroy your world? :) [20:57:49] dbrant, https://www.mediawiki.org/wiki/Special:ApiSandbox#action=query&prop=imageinfo&format=json&iiprop=url&iilimit=1&iiurlwidth=123&titles=File%3AWiki.png [20:58:10] Maryana: No, I'm in that code right now [20:58:17] apparently, you'll have to make one request per resolution though [20:58:38] Maryana: So this is the ideal time to change it :) [20:58:50] kaldari: on the confirmation screen, can we change the message based on whether they've answered yes/no or not sure? [20:58:50] MaxSem: that should work; thanks! [20:59:22] Maryana: Yes [21:00:23] Deskana: shall I do the honors of pulling the Commons app? [21:00:37] in the not sure case, it would be good to still show a confirmation message + play again button, but it should say something like "That's okay, thanks for your time" [21:00:48] dbrant: Not yet. :) [21:01:06] * YuviPanda|bzzzz is vaguely here [21:01:15] Deskana: btw, +1 on killing the commons app [21:01:29] dbrant: We may want to sneak a last update in before we pull it, or do this degradation a little more gracefully. [21:01:37] dbrant: I'll float that on the mailing list too. [21:01:49] very well! [21:03:39] tfinc: hey there [21:03:44] vbamba: hey [21:03:44] had a quick question for you [21:03:57] in a meeting so my response will be delayed [21:03:59] Maryana: In most cases, thy would get the same question again, as the majority of articles only have 1 potential occupation [21:04:02] ok! Ill email [21:05:17] kaldari: hmm, ok, no play again button, but rather a "show me this on other articles" button? [21:07:02] hmm, that might be confusing (since we don't actually do anything if they click the button). Maybe just an "Okay" button? [21:10:24] kaldari, bleh - the error happens on urls like http://www.mediawiki.org/w/index.php?title=Special:UserLogin&returnto=MediaWiki&error=&type=signup&fromhttp=1&mobileaction=toggle_view_mobile [21:11:51] (03PS5) 10BearND: [WIP] Nearby [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159171 [21:13:51] MaxSem: hmm, I still don't see how that would cause the error [21:14:36] MaxSem: it would be worth adding to the bug report though [21:15:32] (03PS3) 10Dbrant: [WIP] Nearby -- with magnets! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159296 [21:27:13] Fucking magnets. [21:27:13] How do they work> [21:27:52] science! [21:34:44] try juggalos-l [21:37:39] kaldari: design by IRC is hard :) [21:37:48] how you feeling? will you be in tomorrow? [21:38:06] Maryana: possibly [21:38:50] a hangout could work, too. i just think it'll be 100 times faster/easier to hash this out with me, you, & moiz in person (or as close to it as possible) [21:42:12] kaldari: drink lots of fluids and follow the juju sick diet: garlic [21:42:16] :) [21:43:50] kaldari: get better dude! [21:44:02] I hope so :)\ [21:56:13] tfinc: https://www.tindie.com/products/hugs/tapster/ [21:56:18] We should get one [22:00:33] Maryana, Moiz: Any ideas on the copy for the 'more info' overlay? I'm finishing that up now. Should we still call it the 'Wikidata Game'? [22:00:40] moizsyed: ^ [22:00:43] cute [22:01:16] kaldari: i have some copy in the mock [22:01:23] kaldari: let's stick with that for now. i'm not so much worried about that page [22:01:25] kaldari: but Maryana should ok it [22:01:35] moizsyed: show me plz :) [22:01:39] kaldari: yeah i agree with Maryana [22:01:53] Maryana: its on trello.. let me find [22:02:02] i just want to make sure we work out the confirmation message copy, cos that will affect how people use it during testing [22:02:05] Maryana: https://trello.com/c/7P9KBEwg/1-5-wikigrok-inline-styling [22:02:13] the wall of text will just be a wall of text for 99% of people :) [22:02:17] Maryana: https://trello.com/c/7P9KBEwg/1-5-wikigrok-inline-styling [22:02:43] yeah, that's fine kaldari [22:03:00] kaldari: as long as it doesnt say WikiPoop, i think we're fine [22:03:40] ok [22:05:23] Maryana: Why don't you and moizsyed discuss the confirmation message and corresponding dismissal buttons and let me know what you come up with. I'm not sure I'll be in tomorrow, so no sense in waiting. [22:05:49] ok. unfortunately, i'm in meetings till 5 and then have to jet [22:06:03] no worries [22:06:13] moizsyed: can we meet real quick tomorrow morning first thing? [22:06:13] we can always change it later :) [22:06:36] yeah, but we're gonna start doing regular user testing.. [22:06:48] and i want to make sure we have a sane experience to test with :) [22:07:07] ideally by next week [22:07:14] * Maryana cracks whip [22:07:29] oh sorry, was that too abrasive? [22:07:31] ;) [22:08:35] Change ist verboten. [22:13:27] Maryana: yeah for sure, we can meet tomorrow morning [22:14:06] invite sent [22:14:19] Maryana: invite accepted [22:14:33] moizsyed: achievement unlocked [22:25:34] (03PS2) 10Kaldari: Improvements to Wikigrok A interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 [22:26:12] (03CR) 10jenkins-bot: [V: 04-1] Improvements to Wikigrok A interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 (owner: 10Kaldari) [22:30:17] MaxSem: https://test.wikipedia.org/wiki/Special:ApiSandbox#action=query&prop=coordinates&format=json&colimit=10&generator=geosearch&ggscoord=37.786688999999996%7C-122.3994771999999&ggsradius=25&ggslimit=10 returns [], and not an object. Is this a bug? [22:30:37] this is a known API silliness:( [22:30:42] MaxSem: Or is there a way to avoid the []? [22:30:45] (03PS3) 10Kaldari: Improvements to Wikigrok A interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 [22:31:04] wait for Anomie to fix this...:P [22:31:39] MaxSem: oh well, I guess i'll just keep catching the ApiException in the meantime [22:31:46] thanks [22:33:58] MaxSem: https://gerrit.wikimedia.org/r/#/c/158821 is done (new iteration of WikiGrok) [22:37:35] tfinc: so has Bahodir officially started? or has his start date been postponed? I haven't heard anything recently [22:38:18] kaldari: yup, he's waiting on his exit visa. next update on that is 9/10 [22:38:37] ughhhh, exit visa [22:38:46] fucking dictatorships [22:38:53] :( [22:39:16] kaldari: "Uzbekistan is the last remaining former USSR country that still requires an exit visa, which is valid for a two-year period.[203] There has been explicit UN complaint of this practice.[" [22:39:19] from https://en.wikipedia.org/wiki/Visa_(document)#Exit_visas [22:44:39] hi bearND [22:44:48] hi vbamba [22:45:12] Im not sure that 24X24 will work for the recent view [22:45:21] thats usually the size of icons for action bar [22:45:44] i can resize the svg to make it consistent with other sizes in the recent view. However, I do need the dimensions from you [22:46:25] it looks like icons in the recent view are a 16X16 focus area [22:46:34] could you quickly check and let me know? [22:46:39] please :) [22:46:52] vbamba: I'll try it out. I can control the size of the png that the svg gets converted to [22:47:42] vbamba: I think we might also want an icon for when there is nothing found nearby, similar to what we have for saved pages and history [22:47:50] alrightey and Ill add the empty screen content to the design board and ping you [22:48:00] vbamba: thank you [22:48:39] (03CR) 10MaxSem: Improvements to Wikigrok A interface (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 (owner: 10Kaldari) [22:50:28] greg-g: good when you are [22:53:27] tfinc: let's do it [22:53:28] vbamba: For the nav drawer the icon should be white not black [22:54:05] I should say it should be light gray [23:01:00] bearND: You are absolutely right. I thought you just wanted this for the recent icon list. but we need this for Left Nav Nearby and the empty screen as well. [23:01:37] vbamba: I manually changed the color to white, and that seems to work for the nav drawer [23:01:54] dbrant, vbamba: Running a little late. I'll try and be there in 5 or 10 minutes. [23:02:06] vbamba: I'm going to use #AAAAAA for history [23:28:47] 3Wikipedia App / 3Android App: "Could not create account" error is unhelpful - 10https://bugzilla.wikimedia.org/70635 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None A few users reported seeing this: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7779487 And probably these... [23:42:30] 3Wikipedia App / 3Android App: "Could not create account" error is unhelpful - 10https://bugzilla.wikimedia.org/70635#c1 (10Dan Garry) a:3Dan Garry I agree that that is a suboptimal set of errors to explicitly handle. We could do better. The questions here are primarily product ones, namely: 1) What error... [23:44:08] (03PS1) 10Deskana: Change "Other meanings" to "Similar articles". [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159430 [23:49:31] bearND: https://trello.com/c/Li5fXUxj/53-icon-for-nearby [23:49:35] both icons here [23:52:28] Today in confusing commands... [23:52:35] dan-garry:MobileApp dgarry$ cd less [23:52:38] dan-garry:MobileApp dgarry$ ls less [23:52:43] dan-garry:MobileApp dgarry$ less issues.less [23:52:59] LESS [23:53:02] Deskana, you should do it in a persistent session [23:53:17] so you can have screen -S less_screen; less issues.less [23:53:18] Deskana: less is sometimes more [23:53:55] dan-garry:less dgarry$ which less [23:53:55] /usr/bin/less [23:53:56] dan-garry:less dgarry$ which more [23:53:58] /usr/bin/more [23:54:03] bearND: which disagrees. ;-) [23:54:43] sometimes: less is better than more [23:54:52] Yes! [23:55:17] at least for the command that's mostly true [23:55:36] or was it "at less" ;) [23:56:12] Wow [23:56:20] man more [23:56:23] NAME [23:56:24] less - opposite of more [23:56:38] Yes...