[00:10:18] (03PS2) 10Jdlrobson: Beta: Apply this page has issues to talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158006 [00:53:39] (03PS1) 10MaxSem: Allow overriding Nearby coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159436 (https://bugzilla.wikimedia.org/49413) [00:54:12] (03CR) 10jenkins-bot: [V: 04-1] Allow overriding Nearby coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159436 (https://bugzilla.wikimedia.org/49413) (owner: 10MaxSem) [01:26:38] (03PS6) 10BearND: [WIP] Nearby [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159171 [04:44:23] (03PS7) 10BearND: [WIP] Nearby [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159171 [05:19:03] 3MobileFrontend / 3Feature requests: replace ≡ (hamburger menu) with wikifont W symbol for site drawer. - 10https://bugzilla.wikimedia.org/63978 (10Nemo) [05:19:05] 3Wikipedia App / 3Generic: Replace floppy disk and trash icons on editing, history screens. - 10https://bugzilla.wikimedia.org/64320 (10Nemo) [05:53:29] 3MobileFrontend / 3Feature requests: replace ≡ (hamburger menu) with W symbol for site drawer. - 10https://bugzilla.wikimedia.org/63978#c12 (10Jared Zimmerman (WMF)) this should still happen even without wikifont, title updated. [13:00:51] (03PS4) 10Dbrant: [WIP] Nearby -- with magnets! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159296 [13:11:41] (03CR) 10Dbrant: [C: 032] Change "Other meanings" to "Similar articles". [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159430 (owner: 10Deskana) [13:45:28] 3Commons App: Replication engine moans because of duplicate entry - 10https://bugzilla.wikimedia.org/63997#c1 (10nosy) 5NEW>3RESO/WON No fucking one cares, heh [14:23:30] 3Commons App: Replication engine moans because of duplicate entry - 10https://bugzilla.wikimedia.org/63997#c2 (10Andre Klapper) nosy: I have no idea why this ticket was filed against the Commons Mobile application which is pretty unmaintained, so that's why not many people cared. [16:15:40] (03PS2) 10BearND: [WIP] Show ToC the first time it is available; plus hints [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/158268 [16:16:10] (03CR) 10BearND: "manual rebase" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/158268 (owner: 10BearND) [16:42:30] (03PS2) 10MaxSem: Allow overriding Nearby coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159436 (https://bugzilla.wikimedia.org/49413) [16:46:40] (03PS4) 10Kaldari: Improvements to Wikigrok A interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 [17:13:56] woo time to upgrade machines to gm build of 8 and double-test some more [17:16:57] You in office brion? We are waiting for bronte and Deskana in standup [17:17:16] not in office [17:24:27] "541 Fatal error: Cannot use object of type stdClass as array" [17:24:37] Why's there so many of those? :/ [17:36:10] “TestFlight Beta Testing for external testers will be coming soon. “ [17:36:11] soooooooon [17:38:00] ooh we can now add video previews to our app store entry :D [17:38:07] not that ours is the most exciting app to watch [17:39:11] Reedy: yesterday there was a discussion between kaldari and MaxSem about that. IIIRC, they came to the conclusion that the hook shouldn't be called, if $list is already an object (https://github.com/wikimedia/mediawiki-core/blob/wmf/1.24wmf11/includes/specialpage/SpecialPageFactory.php#L187) [17:39:23] I know [17:39:25] that means: How can the hook parameter be an object? [17:39:27] So why is it still? :) [17:39:27] ah, ok :) [17:39:51] kristenlans: since kaldari's sick and he's a) tech lead and b) half the eng team currently :) can we move today's story estimation? [17:39:52] yeah, good question. Maybe (i never used clone) bc of this: https://github.com/wikimedia/mediawiki-core/blob/wmf/1.24wmf11/includes/specialpage/SpecialPageFactory.php#L243 [17:40:05] Reedy: Yeah, that one is a mystery :P [17:40:15] oh, and c) he's the one who'll be working on wikigrok, and that's what we want to estimate [17:40:50] brion: Deskana|Away btw, lots of messages on OTRS for iOS complaining about lack of article styling [17:40:58] looks like the CSS isn't being laoded [17:41:05] Maryana: I could do the estimation remotely [17:41:14] I don't want us to fall behind scheulde [17:41:24] probably a failure on those update fetches [17:41:25] no, you're sick! what are you doing on IRC? :-P [17:41:54] Maryana: well, at least I'm still in bed in my pajamas [17:42:40] * Ironholds giggles [17:42:50] Maryana: but we can also reschedule if you think it makes more sense [17:42:54] sorry, my mental image of your PJs is just...your big scary goth coat, but in plaid. [17:43:01] :) [17:43:03] Maryana kaldari: fine with me. Should we move it to tomorrow? Cool with you MaxSem? [17:43:03] I want that to exist. It sounds awesome. [17:43:21] interviewing [17:43:30] :) [17:43:52] brion: true but if fetch fails it should fall back to old styles and not overwrite them [17:44:04] YuviPanda: yes, so presumbaly that is failing? [17:44:09] looks like [17:45:32] Maryana, kristenlans: also, I forgot to find someone to cover me at scrum of scrums :( Although it sounds like no one was available anyway since Max had a interview. [17:45:54] (03PS1) 10Yuvipanda: Check for new releases and pop up a notification if there is one [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159506 [17:45:57] dbrant: bearND ^ [17:46:41] kristenlans: I'm free all tomorrow except 11-11:30 [17:47:01] dbrant: bearND an android patch from me since forever [17:47:02] :) [17:47:46] kristenlans: my calendar's kind of a mess tomorrow, and actually it looks like howie totally booked over our quarterly planning checkin :-/ [17:47:48] Reedy: how common is that impossible error? [17:48:13] kaldari: atm, 921/1000 apache syslog lines are it [17:48:16] (03CR) 10jenkins-bot: [V: 04-1] Check for new releases and pop up a notification if there is one [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159506 (owner: 10Yuvipanda) [17:48:17] so VERY [17:48:28] Maryana: Howie!!!!! Do I need to arm wrestle him? [17:48:28] Reedy: ack [17:48:43] kristenlans: yes. bad boss, no cookie! [17:49:00] it's lunch with lila, tho, so i don't think it's very moveable [17:49:05] Maryana, kristenlans: let's do it today then [17:49:16] YuviPanda: :) [17:49:26] kaldari: you sure? we could do it at 10 tomorrow, too, looks like [17:49:46] Maryana, kristenlans: I just have a cold, it's not terrible [17:50:04] (03PS2) 10Yuvipanda: Check for new releases and pop up a notification if there is one [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159506 [17:50:21] kaldari: only if you promise to take the rest of the day to actually rest [17:50:27] kaldari: we’ll keep it super low-stress [17:50:28] Agreed [17:50:41] you're 50% of our eng team! we need you at fighting weight :D [17:50:48] :) [17:50:52] Compared to our usual ANGRY HIGH STRESS MEETINGS [17:50:57] haha [17:51:06] you joke, but you weren't around for the early days of mobile web [17:51:14] hehehehe [17:51:58] ok, so we're keeping it as is then? i'll let moiz know [17:52:14] As is. Now about that quarterly planning planning meeting…. [17:52:17] (03PS3) 10Yuvipanda: Check for new releases and pop up a notification if there is one [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159506 [17:52:20] yeah.. [17:52:31] Maryana: alright, i'll be there for the meeting [17:52:40] speak of the devil [17:53:10] kristenlans: i'm free from 10-11:30 tomorrow [17:53:28] looks like dan has a thing at 11 [17:53:37] could we do 10-11? [17:53:48] dan's also in the lunch w/lila (double bad boss howie) [17:54:41] Yeah looks like Deskana could do 10-11. I’ll move it to then and see if he complains ;-) [17:55:15] Maryana, moizsyed: are you guys still going to meet about Wikigrok 'thanks for playing' wording? In the meantime, I just made it say 'Thanks anyway' if you choose 'Not sure', and it has an 'Whatever!' button to dismiss it. [17:55:25] haha [17:55:30] kaldari: yeah, we just talked about it [17:55:34] kaldari: We just did [17:55:44] 3MobileFrontend / 3stable: Mobile MediaViewer: Inapprehensible licensing information - 10https://bugzilla.wikimedia.org/70151#c4 (10Florian) Is this bug resolved now? [17:55:56] kaldari: see my last comment here: https://trello.com/c/7P9KBEwg/1-5-wikigrok-inline-styling [17:56:12] Maryana: kristenlans invite me to the quarterly planning planning meeting, i'll sit in the back quiet [17:56:41] ok - are you actually busy at 10 tomorrow? your calendar says so [17:57:12] Maryana I am busy…with quarterly plannign planning!!! [17:57:16] Maryana: im not busy, its a VE meeting [17:57:32] heh, ok [17:57:47] Oh, that was to moiz ;-) [17:57:57] kaldari: lemme know if that makes sense. sorry it's so confusing/split btw 2 cards [17:58:08] kristenlans: yeah :) [17:58:32] the perils of IRC communication [17:58:45] IRC = Its Really Confusing [17:58:48] So perilous! [17:59:10] Maryana, moizsyed: Do we really want to show them another screen after they click 'No Thanks'? That sounds like it would be annoying. [17:59:26] moizsyed: good one! [17:59:43] kaldari: we only show that screen the first time [18:00:03] kaldari: if they choose "never show this", we never show the game to the them ever [18:00:20] ok [18:00:25] kaldari: and if they show "ask another time", then we show them the game [18:01:03] kaldari: also if its annoying, we will find it in user testing real quick [18:01:20] kaldari: for a lot of people, the whole premise of this game will be annoying [18:02:17] Maryana: I guess that means I need to move the card back into development then as this will require a bit of retooling [18:02:30] hmm.. [18:02:36] what's the experience now? [18:02:57] my #1 priority is getting something merged today that makes sense, even if it's not 100% perfect :) [18:03:42] kaldari: can you just change "whatever" to done on the not sure screen? [18:03:58] Right now, 'No Thanks' dismisses forever, and clicking 'Not Sure' sends you to the thanks screen with alternate messaging, but the thanks screen only has one button that just dismisses. [18:04:03] we don't have to worry about all the "don't show again one time/don't show again ever" conditions yet [18:04:21] ok, that's fine [18:04:29] Maryana: maybe we should create a separate card for the new changes [18:04:48] yeah, the more elaborate stuff will go into next sprint [18:05:06] we can talk about that at the story estimation today [18:05:25] cool [18:05:33] i really wish vagrant wasn't so fubar so i could just test your patches :-/ [18:06:21] Maryana: I can help you set up MobileFrontend without vagrant if you like [18:06:32] ooh [18:06:37] i like! [18:07:08] but prolly easier to do in person, right? [18:09:22] (03PS5) 10Kaldari: Improvements to Wikigrok A interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 [18:09:34] Maryana: yes [18:10:15] (03PS1) 10Yurik: +repage for imagemagick and minor js optimization [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/159509 [18:10:54] (03CR) 10Yurik: [C: 032] +repage for imagemagick and minor js optimization [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/159509 (owner: 10Yurik) [18:11:05] (03Merged) 10jenkins-bot: +repage for imagemagick and minor js optimization [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/159509 (owner: 10Yurik) [18:13:56] oh hey, my wikimania talk is online now! [18:14:04] :D [18:14:22] Yey! you haz link? [18:14:31] https://www.youtube.com/watch?v=f67VFRBCQVw&list=UURXe4cgJPTVHcDH6ZGwOT3A [18:14:37] starts at 1:12 [18:14:44] iz funny [18:14:59] brion: will you be in the office today? [18:16:22] looking at logs for other reasons, but just noticed this spamming through fatal.log at a rate of ~20/s: [2014-09-10 18:14:53] Fatal error: Cannot use object of type stdClass as array at /usr/local/apache/common-local/php-1.24wmf20/extensions/MobileFrontend/includes/MobileFrontend.hooks.php on line 329 [18:17:41] oh, wrong mobile :P [18:19:25] tfinc: i’m trying to catch up on arch meetings this afternoon, simplest for me if i can just work through the day from home office [18:19:34] brion: ok [18:21:15] ugh i’m having some kind of simulator trouble, lemme reboot and see if that clears it up [18:25:40] (03PS1) 10Jdlrobson: WIP: Preference search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159514 [18:26:39] ok, looks like a couple small oddities on iphone 6 plus but we can work on those later [18:27:08] bsitu: ebernhardson what commit of MobileFrontend is running? [18:28:23] Reedy: I took another look, but no progress. wfRunHooks( 'SpecialPage_initList' ) is only called from one place, and the paramater absolutely has to be an array at that point. The other extensions that are using that hook use it in the exact same way as we are. Are there any extra clues that might help solve this? [18:29:31] APC [18:29:52] Reedy: What's APC? [18:30:25] php opcode cache [18:32:33] Reedy: What do you think about just getting rid of the object casting there entirely since it isn't actually needed anymore? [18:32:57] Seems sane to me, tbh [18:33:50] Reedy: Is that something the platform team could do or should mobile take care of it? [18:34:16] Either, or [18:34:22] It's a quick enough thing to do [18:34:27] I can jfdi and put for review [18:35:03] Reedy: That would be awesome and hopefully git rid of this phantom error [18:36:17] although that APC voodoo still worries me ;) [18:37:10] I guess hhvm will fix that ;) [18:37:22] I note we have some stuff like: $rec = self::getList()->$realName; [18:38:08] / Cast to object: func()[$key] doesn't work, but func()->$key does [18:38:17] That doesn't work in 5.3 does it? [18:38:53] Hmm, that's PHP 5.4 syntax [18:39:05] It looks like it's only the special page that uses it like that [18:39:15] So I could fix those up, and add a couple of temporary variables [18:41:17] Reedy: I'm not sure if that was introduced in PHP 5.3 or 5.4 [18:42:13] PhpStorm says 5.4 for array dereferencing [18:42:24] ah :( [18:42:46] Everywhere (all our extensions in gerrit) outside that file iterate over the result [18:42:52] So I'll just fix up that page [18:42:57] s/page/file/ [18:43:03] sounds good [18:43:23] I mean, the docs even say @return array [18:44:30] aha apparently i have to update the luanch images for the new resolutions or it scales funny [18:44:31] sigh [18:46:20] hmm, the $foo->bar()->$baz = '...'; syntax should be fine: http://3v4l.org/25YSn [18:47:17] Yeah [18:47:25] But we're switching it to an array, sort of [18:48:37] * Reedy is waiting for git fetch --all [18:49:14] hrmm, kristenlans so are going to have a mtg at 1 or not? [18:52:17] MaxSem no meeting chnages [18:52:28] okie [18:55:16] dbrant: Hi Dmitry [18:55:51] Quick question for you (Cos Bernd doesnt seem to be online) [18:56:01] Do you know what the threshold for nearby articles is? [18:56:05] What radius do we look at? [18:56:38] vbamba: you mean the "maximum" radius? [18:58:06] vbamba: I don't think there is one... we just show whatever the API returns, given the number of articles requested. [18:58:32] (03PS1) 10Brion VIBBER: Stub launch images for iPhone 6, 6 Plus [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/159524 [18:58:34] max radius is 10 km [18:59:04] MaxSem: is that right? [18:59:15] vbamba: ^ and that is indeed what we pass to the API [18:59:36] dbrant: So if there is nothing in that radius we have no nearby articles? [19:00:01] yup [19:00:07] vbamba: I would assume so [19:05:58] * MaxSem rushes to the office [19:32:33] Maryana your talk is so ful of LOLs! [19:42:18] :) [19:43:24] kristenlans: did they get the Q&A session after? there were some… uh… interesting questions [19:43:34] just starting…. [19:43:48] (the Q and A session) [19:45:51] wow [19:47:14] 3Wikipedia App / 3iOS App: iOS app table of contents icon is wrong in RTL interfaces - 10https://bugzilla.wikimedia.org/70491#c2 (10Brion Vibber) Sounds like we might have flipped these by swapping when we need to transform... [19:55:00] kristenlans: i know, right?? [20:01:00] moizsyed: kaity - we're in r37 for the estimation meeting. somebody stole our usual room :( [20:03:08] kristenlans: kaldari_lunch i can't hear you guys [20:03:14] i think this room comp needs a reboot [20:03:16] stay tuned [20:03:34] Maryana: the audio from the office is a crazy techno track [20:03:40] haha [20:03:46] i was wondering why y'all were laughing [20:03:48] that was fully insane [20:03:55] my confused face can't be that entertaining [20:04:20] hopefully rebooting will help..? [20:04:50] This is my impression of it: “PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES PLACES ” in a robot voice. [20:05:12] yeah, that's about right [20:05:51] https://plus.google.com/hangouts/_/calendar/d2lraW1lZGlhLm9yZ19yMWNvaHVib3JmYjlqcWMydHA0bmwxcXMxZ0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t.533jdjq46pqgopsnbm60rrstd0?authuser=0 [20:25:01] 3MobileFrontend / 3stable: galleries appear misaligned on mobile tablet or mobile desktop - 10https://bugzilla.wikimedia.org/70684 (10Kaity Hammerstein) 3NEW p:3Unprio s:3normal a:3None Created attachment 16433 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16433&action=edit Romanesque Archit... [20:25:29] 3MobileFrontend / 3stable: galleries appear misaligned on mobile tablet or mobile desktop - 10https://bugzilla.wikimedia.org/70684#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/2yCPHlQN [20:25:29] 3MobileFrontend / 3stable: galleries appear misaligned on mobile tablet or mobile desktop - 10https://bugzilla.wikimedia.org/70684#c1 (10Kaity Hammerstein) Created attachment 16434 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16434&action=edit Edgar Degas article [20:29:11] (03CR) 10Jdlrobson: [C: 032] Fix media viewer styling to accommodate for zooming [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/156482 (https://bugzilla.wikimedia.org/69414) (owner: 10JGonera) [20:30:00] (03PS5) 10Jdlrobson: Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (https://bugzilla.wikimedia.org/67107) [20:30:09] (03PS6) 10Jdlrobson: Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (https://bugzilla.wikimedia.org/67107) [20:30:43] (03CR) 10jenkins-bot: [V: 04-1] Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (https://bugzilla.wikimedia.org/67107) (owner: 10Jdlrobson) [20:45:57] (03PS7) 10Jdlrobson: Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (https://bugzilla.wikimedia.org/67107) [20:46:30] (03CR) 10jenkins-bot: [V: 04-1] Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (https://bugzilla.wikimedia.org/67107) (owner: 10Jdlrobson) [20:48:10] http://1.bp.blogspot.com/-HnelsFznzrk/TbDbC7TXyMI/AAAAAAAAAq0/DHeLc-gm5Yw/s320/grimace2.jpg [21:07:06] (03PS3) 10BearND: Show ToC automatically; plus hints [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/158268 [21:33:05] (03PS8) 10Jdlrobson: Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (https://bugzilla.wikimedia.org/67107) [21:33:40] (03CR) 10jenkins-bot: [V: 04-1] Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (https://bugzilla.wikimedia.org/67107) (owner: 10Jdlrobson) [21:34:19] (03PS1) 10Jdlrobson: Kill super [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159555 [21:34:53] (03CR) 10jenkins-bot: [V: 04-1] Kill super [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159555 (owner: 10Jdlrobson) [22:16:31] 3Wikipedia App / 3Android App: new ToC icon is too dark in dark mode - 10https://bugzilla.wikimedia.org/70689 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None This happens when the ToC drawer is opened. Also the three lines of the ToC icon don't seem aligned to the three dots of the overflow menu... [22:39:01] yuvipanda MaxSem whatever happened to jerkins? :D [22:39:30] what's wrong with it? [22:40:48] https://gerrit.wikimedia.org/r/#/c/156878/ [22:41:53] doesn't work :P [22:43:17] We’ll get it in to our next sprint ;-) [23:52:43] (03CR) 10MaxSem: Improvements to Wikigrok A interface (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 (owner: 10Kaldari) [23:57:43] (03PS6) 10Kaldari: Improvements to Wikigrok A interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821