[00:51:02] 3Wikipedia App / 3Android App: Crash caused by pressing Retry button on connection issue error - 10https://bugzilla.wikimedia.org/70834 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None I managed to get the app to crash by trying to load the app without a connection, turning it on and then spamming the... [01:21:59] (03PS1) 10Deskana: Add explicit super keyword to log method of all classes extending Funnel. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160370 [02:54:44] 3Wikipedia App / 3General/Unknown: Canned edit summaries in the mobile apps are inserted in the app language - 10https://bugzilla.wikimedia.org/69848 (10Dan Garry) 5PATC>3RESO/FIX [02:55:44] 3Wikipedia App / 3Android App: Add support for Portuguese "pt" and "pt_BR" - 10https://bugzilla.wikimedia.org/70107#c1 (10Dan Garry) 5NEW>3RESO/FIX Pretty sure we've done this. [03:41:17] (03PS1) 10Deskana: Show message to user when filtering interwiki links returns no results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160386 [03:41:52] (03PS2) 10Deskana: Show message to user when filtering interwiki links returns no results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160386 (https://bugzilla.wikimedia.org/70106) [06:05:48] (03CR) 10BearND: [C: 04-1] "Would you mind adding some more comments?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159997 (owner: 10Dbrant) [09:46:47] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160386 (https://bugzilla.wikimedia.org/70106) (owner: 10Deskana) [11:24:45] 3Wikipedia App / 3Android App: Allow automatic save of visited pages - 10https://bugzilla.wikimedia.org/70842 (10Florian) p:5Unprio>3Lowest [11:24:46] 3Wikipedia App / 3Android App: Allow automatic save of visited pages - 10https://bugzilla.wikimedia.org/70842 (10Florian) 3NEW p:3Unprio s:3enhanc a:3None Actually the user has to tap "save", if he want to save a page to the local storage. Request: Implement a setting to turn automatic save of pages... [13:03:30] (03Abandoned) 10Bartosz Dziewoński: Migrate Minerva-specific style modules to $wgResourceModuleSkinStyles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/150580 (owner: 10Bartosz Dziewoński) [14:39:47] (03PS4) 10Dbrant: Nearby - add realtime compass views. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159997 [14:49:54] (03CR) 10Dbrant: [C: 032] Improve layout and searching of History and Saved Pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160217 (https://bugzilla.wikimedia.org/70102) (owner: 10Deskana) [14:56:02] (03CR) 10BearND: [C: 032] Nearby - add realtime compass views. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159997 (owner: 10Dbrant) [14:56:17] bearND: \o/ [14:56:21] (03Merged) 10jenkins-bot: Nearby - add realtime compass views. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159997 (owner: 10Dbrant) [14:56:32] dbrant: nice job. And thanks for the comments! [14:56:34] :D [15:16:04] (03CR) 10Dbrant: [C: 032] Add explicit super keyword to log method of all classes extending Funnel. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160370 (owner: 10Deskana) [15:32:31] (03CR) 10Dbrant: [C: 04-1] "extremely pedantic nits..." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160386 (https://bugzilla.wikimedia.org/70106) (owner: 10Deskana) [15:40:08] (03PS4) 10Dbrant: pick up tests in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159796 (owner: 10BearND) [15:48:15] (03CR) 10BearND: Show message to user when filtering interwiki links returns no results. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160386 (https://bugzilla.wikimedia.org/70106) (owner: 10Deskana) [16:09:57] (03PS3) 10Deskana: Show message to user when filtering interwiki links returns no results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160386 [16:13:05] bearND\brb: just to be sure - will your newest Gradle patch still leave things backwards-compatible with Maven? [16:14:04] (03PS1) 10Deskana: Add a space between any right bracket and left curly brace, for style. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160470 [16:16:10] dbrant: it wouldn't add anything that's not backwards compatible with Maven. The main changes are in the build.gradle files and only affect gradle. Would be good to run the tests through Maven, just to be sure. [16:18:14] (03CR) 10jenkins-bot: [V: 04-1] Add a space between any right bracket and left curly brace, for style. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160470 (owner: 10Deskana) [16:18:16] (03CR) 10jenkins-bot: [V: 04-1] Show message to user when filtering interwiki links returns no results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160386 (owner: 10Deskana) [16:18:25] (03PS1) 10BearND: Nearby: handle missing location provider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160471 [16:55:55] (03PS1) 10Jdlrobson: Jon fixup to Kaldari patch [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160472 [16:59:04] (03PS2) 10Jdlrobson: Jon fixup to Kaldari patch [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160472 [17:10:51] (03CR) 10Jdlrobson: [C: 04-1] "Take a look at my follow up. If you're happy with it, merge it into this patch and feel free to self merge." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160172 (owner: 10Kaldari) [17:17:03] dbrant|food we are standing [17:33:23] dbrant|food, bearND: Hey, so, firstly. [17:33:27] I'm not sure what problem Jenkins had with these: [17:33:28] https://gerrit.wikimedia.org/r/#/c/160386/ [17:33:32] https://gerrit.wikimedia.org/r/#/c/160470/ [17:34:12] Deskana: I can help! [17:34:18] YuviPanda: Please do. :) [17:34:23] (03CR) 10Yuvipanda: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160386 (owner: 10Deskana) [17:34:26] Deskana: it aborted because it took too long [17:34:33] Deskana: ^ commenting that makes jenkins try again [17:34:42] So it was just a hiccup? [17:34:48] I didn't do anything wrong? :) [17:34:49] (03CR) 10Yuvipanda: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160470 (owner: 10Deskana) [17:34:57] Deskana: you might have :) we don't know yet [17:35:03] Hah! [17:35:07] (03CR) 10Brion VIBBER: [C: 032 V: 032] Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/160166 (owner: 10BearND) [17:35:20] (03PS4) 10Yuvipanda: Show message to user when filtering interwiki links returns no results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160386 (owner: 10Deskana) [17:35:24] (03PS2) 10Yuvipanda: Add a space between any right bracket and left curly brace, for style. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160470 (owner: 10Deskana) [17:35:30] hitting rebase also re-triggers jenkins [17:36:08] dbrant: And yeah, I did mean to turn it off. I'm really sorry that I basically asked you to implement something and am now turning it off. :( [17:36:15] it = session event logging [17:36:42] * YuviPanda pats Deskana [17:37:09] Yay, Jenkins gave them +2s. [17:37:17] :) [17:37:50] Deskana: no worries... it's all a learning experience. (e.g. I hadn't set up an EL schema before then) [17:38:03] Deskana: for any 'aborted' or 'this job has been lost' messages from jenkins, a rebase or a 'recheck' comment usually fixes [17:38:36] Right. I figured it was some Jenkins internal hiccup because it shouldn't take 8 minutes to check code style. :) [17:39:22] Deskana: it could've also been 'you fucked up so badly that the system RAM filled up with all the error messages' :P [17:39:47] YuviPanda: Considering one of the patches literally just added spaces between a ) and a {, I doubt it. :P [17:39:58] But yes, fair enough. :P [17:39:59] Deskana: :D I don't think that has happened before [17:40:15] Oh, I know how to push the envelope. Don't count me out yet. :P [17:40:26] Alright, cool, so that's resolved. [17:40:35] I had a lot of fun doing this hacking this weekend. [17:41:06] Deskana: saw your devlog :) [17:41:51] I feel like I'm tackling simpler problems, but I think the reality is that the problems are as hard (or, more accurately, easy) as the other ones, I'm just better at it. [17:41:58] * Deskana shrugs. [17:42:22] Deskana: :) [17:43:18] Deskana: what do we want to do with https://trello.com/c/zF8rGtVT/39-continue-ios-8-testing-to-identify-further-issues [17:43:34] kristenlans: I declare it officially done. [17:43:44] (03CR) 10Dbrant: [C: 032] Show message to user when filtering interwiki links returns no results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160386 (owner: 10Deskana) [17:43:56] Deskana: I saw it happen in Trello right before my eyes! [17:43:57] kristenlans: Obviously we'll continue testing, but the scope of that card was within that sprint. [17:45:50] Best user story ever: “As a mobile device, I'd like the interface on my screen to be scaled appropriately to my size so that users like using the app on me.” [17:46:58] Deskana: manual rebase, plz -- https://gerrit.wikimedia.org/r/#/c/160309/ [17:47:09] It shall be done. [17:50:12] Maryana, red links are also present in previews :P [17:50:21] yeah, that's bad, too [17:50:27] but let's not worry about that for now [17:51:36] bwah [17:51:37] no [17:51:43] IM GONNA FIX [17:52:34] * YuviPanda pats MaxSem [17:56:13] (03PS2) 10Deskana: Allow session sampling rate to be 0, and change session sample rate to 0. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160309 [17:56:24] Rebased. [17:56:49] Deskana: you should probably add rationale for chaing it to 0 there [17:57:00] I presumed you just set a default and it would be overriden by Extension:MobileApp [17:57:01] brion: ever had simulators disappear? [17:57:12] o_O [17:57:29] maybe we hit the recursion limit? [17:57:31] YuviPanda: Yeah, I also changed the remote config in MobileApp to 0. [18:00:24] brion: so 3 of them are back... [18:04:04] dbrant, bearND, kristenlans: Are your flights/hotel rooms all sorted for the quarterly planning? [18:04:21] Deskana: they sure are! [18:04:22] * YuviPanda has mixed feelings about not being there [18:04:24] Deskana: Yes for me. [18:04:47] YuviPanda: Yeah, it's sad. But hey, you're the one that chose to leave, so. :-P [18:04:53] :) [18:06:01] (03CR) 10Dbrant: [C: 04-1] pick up tests in Gradle build (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159796 (owner: 10BearND) [18:06:29] (03CR) 10Dbrant: [C: 032] Add a space between any right bracket and left curly brace, for style. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160470 (owner: 10Deskana) [18:06:54] I like how my client shows that as "Dbrant: [C 032]" [18:06:57] CODE REVIEW +32! [18:07:05] you need colorssss [18:07:05] Deskana: yes, got flight and hostel [18:07:08] and other things [18:07:09] it's just that good. [18:07:37] dbrant, bearND, kristenlans: Woohoo! Thanks. :) [18:08:16] I’m excited to be back in the office and to see everybody :D [18:08:42] brion, mhurd: Can you guys cut a testflight build when you're ready? [18:08:59] Deskana: ya! [18:09:05] Cheers! [18:09:14] brion: Deskana i’ll do that now [18:09:14] brion: mhurd: want a new TWN sync? [18:09:25] bearND: oooh yeah! [18:09:39] i did one on Friday but that hasn't been merged yet. [18:11:22] never mind. just realized it got merged 30 min ago [18:11:52] bearND: oh, that’s right :) [18:12:56] mhurd: since then only very minor changes. So, probably not worth it [18:13:32] bearND: gotcha. thanks for asking though [18:15:42] (03PS1) 10MaxSem: Fix redlinks on preview and save [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160492 (https://bugzilla.wikimedia.org/69559) [18:16:04] brion: http://appreviewtimes.com/ [18:16:08] Deskana: ^ [18:16:17] 10 days... [18:16:24] :P [18:16:30] Well, I'm not entirely sure to trust that website now. [18:16:39] It said it was 7 days when they were reviewing our builds in 1 day. [18:16:55] Although I guess it is a rolling average, so. [18:19:44] mhurd, brion: Let us be calm. They've still got two days to review it before the iOS 8 release. :) [18:20:17] * YuviPanda tch tchs about iOS review, etc, etc [18:20:25] gah! [18:20:35] brion: have a second for testflight fun? [18:22:24] mhurd: I did a factory reset of my phone this weekend, btw. It seems a bit better. [18:22:38] Deskana: haha it was pretty bad... [18:22:46] mhurd: It's still bad, it's just better now. :-p [18:22:57] Better than it was... [18:33:13] (03PS5) 10BearND: pick up tests in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159796 [18:34:30] Deskana: testflight build cut [18:36:26] (03PS1) 10Brion VIBBER: Initial SavedPages eventlogging for iOS [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/160496 [18:37:00] (03CR) 10Dbrant: [C: 032] Nearby: handle missing location provider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160471 (owner: 10BearND) [18:37:44] (03CR) 10Dbrant: [C: 032] Allow session sampling rate to be 0, and change session sample rate to 0. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160309 (owner: 10Deskana) [18:59:02] Oh, jdlrobson, if you take a look at the ‘Must have’ column you can see the work that is slated for this upcoming sprint: https://trello.com/b/TInnSh9E/mobile-web-q1-backlog-2014-2015 [19:14:26] dbrant: Are you okay for a meeting at 3pm SF time on Thursday? [19:14:58] Deskana: should be okay, yes. [19:17:49] dbrant: Cool, thanks. [19:19:03] YuviPanda: Can you update the stuff on the Wikipedia app page to include info about the automated builds? [19:20:08] (03PS1) 10Dbrant: Detect whether location is disabled on the device... [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160502 [19:27:22] (03PS4) 10Brion VIBBER: Pull to refresh UI on Saved Pages (frontend only) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144846 [19:58:41] Deskana|Away: got lost in a bunch of Ops stuff (I started attending their meetings today), will make sure to finish up tomorrow [19:58:44] sorry [20:01:44] YuviPanda: Cheers. :) [20:01:56] * YuviPanda has two teams' meeings now [20:02:39] Deskana: https://www.mediawiki.org/wiki/Mobile/Release_history#Apps [20:03:38] tfinc: iOS has never been updated on that. [20:03:41] https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [20:03:43] tfinc: Android appears to be up-to-date though. [20:04:02] yup, lets update it please. its how we know what changed and when [20:04:24] tfinc: Indeed! [20:06:01] https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AqEdtQuSLdAxdGF0Unlob2MtRmZTeU4tODJXbk9rQ1E&usp=drive_web#gid=1 [20:07:09] (03PS1) 10Dbrant: Make sure that a new location is "better" than the previous one. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160509 [20:27:08] awjr you may need to mute [20:27:32] kristenlans: i am [20:27:37] hardware muted, at least [20:27:44] (03PS6) 10BearND: pick up tests in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159796 [20:27:45] hmmm [20:27:48] i just hangout muted too [20:27:50] there we go [20:27:58] (03PS7) 10BearND: pick up tests in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159796 [20:28:13] im still getting the weird rustling sound; i think it's coming from the office [20:30:02] it is possible the audio settings are wrong in the office (eg not using the chat150s for audio in) [20:31:09] (03CR) 10BearND: pick up tests in Gradle build (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159796 (owner: 10BearND) [20:32:13] dbrant: ^ [20:46:31] (03CR) 10Dbrant: [C: 032] pick up tests in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159796 (owner: 10BearND) [20:54:06] Hello yurik [20:54:23] jhobs, welcome! :) [20:54:42] everyone, Jeff has joined! :D [20:54:54] hi all :) [20:55:39] jhobs will be working on the zero project [20:56:00] are there any specific channels I should be keeping an eye on? So far I have this one and #wikimedia-dev open [20:56:05] jhobs, autocomplete should work (tab) [20:56:09] jhobs: Welcome! [20:56:58] jhobs: I'm Dan, the product manager working on the mobile apps. Nice to meet you. :-) [20:57:12] Nice to meet you too! [20:57:16] jhobs, #wikimedia-dev #wikimedia-operations #wikimedia-office (that one is tricky, need perm)... should be enough for now ) [20:59:59] jhobs: welcome! I work on the Android app :) [21:00:26] jhobs: welcome! I also work on the Android app [21:00:57] hello! Nice to meet you both [21:03:43] jhobs, any luck getting vagrant up and running? [21:09:19] jhobs: Welcome aboard Jeff! [21:17:54] https://etherpad.wikimedia.org/p/e [21:23:23] yurik, I'm fairly certain I've got it up and running properly! I can see a dev wiki so hopefully everything is fine [21:24:13] (03CR) 10BearND: [C: 04-1] "I like the general approach. Just some nits." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160502 (owner: 10Dbrant) [21:26:25] mhurd: you free? [21:27:12] violetto: i can be. what’s up? [21:27:27] iconz [21:27:29] mhurd: [21:28:03] violetto: your desk? meeting? [21:28:28] my desk sounds comfortable mhurd [21:28:42] violetto: cool in 5 min ok? [21:29:03] mhurd: ok [21:33:45] 3MobileFrontend / 3Feature requests: Use touchend instead of click event where possible - 10https://bugzilla.wikimedia.org/46012 (10Andre Klapper) 5ASSI>3NEW a:5Juliusz Gonera>3None [21:39:28] (03CR) 10BearND: [C: 031] "I like it. Just waiting for the dependent patch to get merged." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160509 (owner: 10Dbrant) [21:41:12] (03PS3) 10BearND: remove configChange hack from AboutActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159752 (owner: 10NightlyNexus) [22:16:48] (03CR) 10MaxSem: [C: 032] Remove direct echo db access from mobilefrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160159 (owner: 10Bsitu) [22:17:23] (03Merged) 10jenkins-bot: Remove direct echo db access from mobilefrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160159 (owner: 10Bsitu) [22:31:33] (03PS1) 10Cmcmahon: QA: update Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160540 [23:20:00] 3Wikipedia App / 3Android App: NPEs from concurrency.SaneAsyncTask.onCatch - 10https://bugzilla.wikimedia.org/69952#c1 (10Bernd Sitzmann) The inner exception is usually more interesting. version 2.0-r-2014-08-07 Caused by: java.lang.NullPointerException at org.wikipedia.savedpages.SavedPage.writeToFileSyst... [23:39:53] mhurd: free again? [23:40:07] violetto: ya! just got done [23:40:29] mhurd: oki [23:55:00] (03PS1) 10BearND: Guard against page being null in savePage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160562 [23:56:38] (03PS1) 10Jdlrobson: Register TalkOverlay to #/talk [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160565 [23:57:30] (03CR) 10Jdlrobson: [C: 04-1] "https://gerrit.wikimedia.org/r/160565" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow)