[00:03:27] (03CR) 10Jdlrobson: "There's lots of untranslated strings and no reference in the commit message or the class that this is expected." (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 (owner: 10Kaldari) [00:03:38] (03PS1) 10MaxSem: Disable file caching for mobile pageviews [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160568 (https://bugzilla.wikimedia.org/68106) [00:06:08] (03CR) 10Jdlrobson: [C: 04-1] Improvements to Wikigrok A interface (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 (owner: 10Kaldari) [00:06:44] (03PS10) 10Jdlrobson: Use Mantle version of Class, eventemitter and View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (https://bugzilla.wikimedia.org/67107) [00:08:52] (03PS3) 10Jdlrobson: Make sure we're in 'view' mode before loading WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159912 (owner: 10Kaldari) [00:08:58] (03CR) 10Jdlrobson: [C: 032] "no harm" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159912 (owner: 10Kaldari) [00:09:30] (03Merged) 10jenkins-bot: Make sure we're in 'view' mode before loading WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159912 (owner: 10Kaldari) [00:42:45] (03CR) 10Jdlrobson: [C: 04-1] Use summary message on non Main namespace pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159769 (https://bugzilla.wikimedia.org/69488) (owner: 10Florianschmidtwelzow) [00:47:59] 3MobileFrontend / 3stable: Redlinks show in stable after VE or wikitext edit - 10https://bugzilla.wikimedia.org/69559#c7 (10Jon) FYI in preview this was by design so that editors could work out if they created a real link or not. [00:50:17] (03CR) 10Jdlrobson: [C: 04-1] Fix redlinks on preview and save (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160492 (https://bugzilla.wikimedia.org/69559) (owner: 10MaxSem) [00:50:49] (03CR) 10Jdlrobson: [C: 031] "Feel free to +2 if hook gets merged into core." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160568 (https://bugzilla.wikimedia.org/68106) (owner: 10MaxSem) [01:03:12] (03CR) 10Jdlrobson: [C: 032] QA: update Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160540 (owner: 10Cmcmahon) [01:03:45] (03Merged) 10jenkins-bot: QA: update Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160540 (owner: 10Cmcmahon) [03:19:59] 3Wikipedia App / 3Android App: Crash caused by pressing Retry button on connection issue error - 10https://bugzilla.wikimedia.org/70834#c1 (10Bernd Sitzmann) I was able to repro this pretty much every time. I believe this is the same as Alex was able to. Airplane mode on -> follow link to another page -> Air... [03:20:26] (03PS1) 10BearND: Slow down retry button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160604 [03:22:14] 3MobileFrontend / 3Feature requests: Add font size adjustment feature to the mobile front end - 10https://bugzilla.wikimedia.org/48946 (10Matthew Flaschen) [04:55:54] (03PS1) 10BearND: Use serif fonts for Wikipedia logo [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160607 [05:02:56] (03PS1) 10BearND: Default resource file name for colors.xml [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160609 [07:16:46] (03CR) 10Florianschmidtwelzow: "Hmm:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160565 (owner: 10Jdlrobson) [07:17:50] (03CR) 10Florianschmidtwelzow: "This patch works, but i'm unsure, if this solves the problem :/ Can we talk on irc today? I think it's much easier to discuss this :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153803 (https://bugzilla.wikimedia.org/52165) (owner: 10Florianschmidtwelzow) [07:47:12] (03CR) 10Hashar: "Jon, I use that kind of change to play with Jenkins. They can indeed be abandoned :-] I can always reopen it if needed." [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/156529 (owner: 10Hashar) [08:34:30] 3Commons App / 3Android: Incorrect date displayed - 10https://bugzilla.wikimedia.org/68604#c1 (10iuval.moog) See also: https://commons.wikimedia.org/wiki/File:Festejando_la_victoria_de_Argentina_ante_Holanda._patio_olmos_-_C%C3%B3rdoba,_Argentina_.jpg Another Android mobile upload which has 1969-12-31 (esse... [10:07:47] (03PS2) 10Florianschmidtwelzow: Use summary message on non Main namespace pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159769 (https://bugzilla.wikimedia.org/69488) [10:07:50] (03CR) 10Florianschmidtwelzow: Use summary message on non Main namespace pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159769 (https://bugzilla.wikimedia.org/69488) (owner: 10Florianschmidtwelzow) [10:34:38] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [10:35:58] (03CR) 10Hashar: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [11:19:49] (03CR) 10Hashar: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [11:21:52] (03PS4) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 [11:21:56] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [11:23:26] (03PS5) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 [11:24:42] (03Restored) 10Hashar: Jenkins job validation REL1_23 (DO NOT SUBMIT) [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/156529 (owner: 10Hashar) [11:24:46] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/156529 [11:25:06] (03CR) 10Hashar: "check experimental" [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/156529 (owner: 10Hashar) [11:25:11] (03CR) 10Hashar: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [11:25:21] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/156529 (owner: 10Hashar) [12:03:36] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159769 (https://bugzilla.wikimedia.org/69488) (owner: 10Florianschmidtwelzow) [12:29:33] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144846 (owner: 10Brion VIBBER) [12:35:31] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160502 (owner: 10Dbrant) [13:38:48] (03PS6) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 [13:39:59] (03CR) 10Hashar: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [13:40:03] (03CR) 10Hashar: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [13:54:36] (03CR) 10Dbrant: [C: 032] Guard against page being null in savePage [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160562 (owner: 10BearND) [14:01:42] (03CR) 10Dbrant: [C: 032] Slow down retry button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160604 (owner: 10BearND) [14:04:10] (03CR) 10Dbrant: [C: 032] Default resource file name for colors.xml [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160609 (owner: 10BearND) [14:08:22] (03CR) 10Dbrant: [C: 032] Use serif fonts for Wikipedia logo [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160607 (owner: 10BearND) [14:16:34] (03PS2) 10Dbrant: Detect whether location is disabled on the device... [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160502 [14:17:28] (03PS3) 10Dbrant: Detect whether location is disabled on the device... [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160502 [14:18:12] (03PS2) 10Dbrant: Make sure that a new location is "better" than the previous one. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160509 [15:06:28] dbrant, I've been seeing a bunch of network-related exceptions again [15:07:29] Krenair: which one is that again? [15:11:43] dbrant, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7807367 or https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7768238 [15:12:08] maybe I just remember more than there actually are [15:12:35] That first one is from a really old version of the app... [15:13:00] but we do indeed have a few patches to fix more crashes, ready for the next production build. [15:14:06] Krenair: and we're still at a roadblock with the "handleStopActivity" bug on android 2.3 :( [15:14:19] :( [15:14:42] https://bugzilla.wikimedia.org/show_bug.cgi?id=68895 and https://bugzilla.wikimedia.org/show_bug.cgi?id=68896 keep coming up [15:15:01] (NPE when pageimages.PageImageSaveTask.onFinish calls data.ContentPersister.upsert, android.view.InflateException: Binary XML file line #x: Error inflating class) [15:15:42] yep, unable to reproduce those, either... [15:33:30] 3Wikipedia App / 3Android App: NPEs from concurrency.SaneAsyncTask.onCatch - 10https://bugzilla.wikimedia.org/69952#c4 (10Alex Monk) 5PATC>3RESO/FIX Assuming this is fixed. [15:45:30] 3Wikipedia App / 3Android App: Crash caused by pressing Retry button on connection issue error - 10https://bugzilla.wikimedia.org/70834#c4 (10Alex Monk) 5PATC>3RESO/FIX Assuming this is fixed. [16:14:39] Needs a German speaker - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7811236 [16:17:13] * FlorianSW reading it [16:18:13] Krenair: oha... [16:20:42] Krenair: added a rough paraphrasing in English [16:22:04] Didn't someone complain in English about WP app links appearing on google searches in the browser? I wonder if it's related [16:23:43] Krenair: it's unclear if he's talking about app links. I think he's talking more about advertisement [16:24:42] Maybe someone can try replying and getting some clarification. Let's not put too much detail here. [16:24:47] Krenair, bearND: Maybe he talking about the site notice (wiki loves monoument), i will ask him :) [16:36:54] FlorianSW: great response! :) [16:37:08] bearND: thanks :) [16:37:15] hope it helps :) [16:57:08] bearND, https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7801873 - shouldn't that already work? [16:58:32] Krenair: yes, we've had saved pages for a very long time [16:58:42] And they should work while offline. [16:59:33] maybe he mean, that he don't know, how to recall a saved page (through main menu -> saved pages) [16:59:54] I just tried to open a saved page, but got 'Could not reach the network :(' [17:00:10] (2.0-beta-2014-09-09) [17:00:56] oh-oh, just rebooting my device. will check shortly [17:02:18] 3MobileFrontend / 3General/Unknown: Search results blanked on ios7 iPhone4s - 10https://bugzilla.wikimedia.org/70890 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None From an enwiki user: "Problem: after a search, attempts at refinement (or more likely a typo) of the search term(s) blanks the sea... [17:02:59] Krenair: I can confirm that it's broken ;( Would you file a bug? [17:04:03] dbrant: ^ Seems like the refreshing code of saved pages overlays the error message instead of showing the page [17:05:05] dbrant: I'm going to take a look at that so you can focus on the refactoring [17:05:12] after meeting [17:05:27] Krenair: ok, ty [17:05:29] 3MobileFrontend / 3General/Unknown: Search results blanked on ios7 iPhone4s - 10https://bugzilla.wikimedia.org/70890#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/L8wi79oT [17:06:18] bearND: well that doesn't sound good :( thanks for looking [17:07:43] Krenair: dbrant: it workd correctly in the last production release. So, it broke sometime between 8/13 and 9/9 [17:09:00] short question: Android 2.2 isn't supported anymore (Wikipedia 2.0), right? [17:12:01] FlorianSW: that's correct. Only 2.3 (API 10) and above [17:12:43] dbrant: 2.2 users get's the "old" version via Google play or just a "not compatible" message? IIRC the old version has the dark theme, too? [17:12:58] FlorianSW: not compatible. [17:13:53] dbrant: ah, ok, thx :) [17:25:31] tfinc: not even a full 24 hrs and testflight signups over 300 (up from 110)… [17:26:13] mhurd: exciting, when will they receive their first testflight build ? [17:26:34] tfinc: i can re-send the one from yesterday morning [17:29:15] tfinc: just resent [17:29:43] mhurd: k [17:33:21] tfinc: and in just the minutes since i resent that testflight notice a dozen people have installed :) [17:37:26] (03PS4) 10BearND: Detect whether location is disabled on the device... [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160502 (owner: 10Dbrant) [17:40:26] (03CR) 10BearND: "PS2 was broken. See the first two inline comments." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160502 (owner: 10Dbrant) [17:41:28] bearND: lol fixing... [17:41:47] dbrant: no. I already fixed it in PS4 [17:42:01] dbrant: see also my other changes [17:42:05] bearND: oh! i gotcha [17:42:14] dbrant: once you agree feel free to merge [17:43:04] bearND: very good; I didn't sleep too well :) [17:47:32] (03CR) 10Dbrant: [C: 032] "much better" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160502 (owner: 10Dbrant) [17:54:00] (03PS3) 10BearND: Make sure that a new location is "better" than the previous one. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160509 (owner: 10Dbrant) [17:58:27] bearND, Krenair: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7811236 google deep link ;) [18:00:20] FlorianSW: good call [18:00:49] bearND: i'm happy, that it is the deep linking and not an other crazy shit :D [18:09:40] (03CR) 10Jdlrobson: [C: 032] Use summary message on non Main namespace pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159769 (https://bugzilla.wikimedia.org/69488) (owner: 10Florianschmidtwelzow) [18:10:21] (03Merged) 10jenkins-bot: Use summary message on non Main namespace pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159769 (https://bugzilla.wikimedia.org/69488) (owner: 10Florianschmidtwelzow) [18:11:17] 3MobileFrontend / 3stable: "How did you improve the page?" doesn't really make sense on non-article namespace - 10https://bugzilla.wikimedia.org/69488 (10Florian) 5PATC>3RESO/FIX [18:12:37] jdlrobson: Hi :) If you have 10 free minutes, can you ping me? Topic: Talkoverlay :P [18:12:46] FlorianSW: sure [18:12:57] thanks : [18:12:58] FlorianSW: did you take a look at my attempt on adding talk to the router? [18:12:59] (03PS1) 10MaxSem: Pre-fill search bar in SearchOverlay with previous contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160784 (https://bugzilla.wikimedia.org/70890) [18:13:10] jdlrobson: yes :) [18:13:33] (03CR) 10jenkins-bot: [V: 04-1] Pre-fill search bar in SearchOverlay with previous contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160784 (https://bugzilla.wikimedia.org/70890) (owner: 10MaxSem) [18:13:38] unhappily i'm not sure, if this solves the problem :/ [18:14:15] FlorianSW: which problem does it not solve? [18:14:29] The problem seems to be in adding the TalkOverlay when TalkSectionOverlay is closed [18:15:05] jdlrobson: When TalkSectionOverlay is closed, Overlay.hide will delay 1 second before remove the Overlay from DOM, in this time, TalkOverlay is created [18:15:26] self.$el contains (at this time) both overlays, so both will be removed [18:15:48] that's correct [18:15:49] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/common/Overlay.js#L169 [18:16:16] FlorianSW: but in my patch TalkSectionOverlay overrides hide [18:16:26] yes, with this.remove() [18:16:31] so the open talk section will not be effected by the router [18:16:41] this won't change the hash, am i right? [18:16:46] correct [18:17:02] and in TalkOverlay it binds an event so when it closes TalkSectionOverlay also closes [18:17:05] ok, then i have unerstand it right :) [18:17:34] FlorianSW: i added some fixmes [18:17:47] ideally what should happen is we should bind #/talk/1 to TalkSectionOverlay [18:17:49] where 1 is id [18:17:55] but that would have complicated the patch even further. [18:18:12] i'm keen to get the talk code in a nice state with browser tests and unit tests before doing that [18:18:24] i just wanted to unblock the work you were doing because most of the problems seemed to be with the Router [18:18:32] (03PS2) 10MaxSem: Pre-fill search bar in SearchOverlay with previous contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160784 (https://bugzilla.wikimedia.org/70890) [18:18:41] jdlrobson: ah, ok, no i see what you mean :) [18:18:47] *now [18:20:18] FlorianSW: cool. So if you want to try basing your second patch off that one [18:20:28] hopefully it will just work [citation needed ] :) [18:20:36] jdlrobson: yeah, can you check my comment before? [18:20:45] js error :) [18:21:15] js errorr?!? oh nos [18:21:36] jdlrobson: unhappily yes: TypeError: Cannot read property 'appendTo' of undefined [18:21:52] FlorianSW: which browser? [18:22:08] Chrome 37 [18:22:16] and FF 28 [18:22:39] nice catch FlorianSW :) [18:23:12] jdlrobson: thx :) No problem in (Safari*)? * You're using Safari? [18:24:45] (03CR) 10Florianschmidtwelzow: Register TalkOverlay to #/talk (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160565 (owner: 10Jdlrobson) [18:47:48] FlorianSW: have no idea what is causing that issue [18:47:50] am seeing it in Chrome [18:48:19] jdlrobson: hmm, iirc i had this, too first. But idk when or how i fixed it :/ [18:52:39] FlorianSW: think i have worked it out [18:52:44] show is getting called before postRender [18:52:51] jdlrobson:? [18:54:14] jdlrobson: but why only in TalkOverlay? [18:54:27] FlorianSW: still trying to work out [18:55:03] because initialize is async [18:55:29] yeah, wanted to write this just now :D [18:55:39] and _super is called out of the api callback [18:57:35] ah, yeah, that was one reason why i moved the ajax request to _loadContent [19:00:42] jdlrobson: another question (one short look back to overlaymanager for talksectionoverlay): Is there a best practice or an already implemented way, to handle a route with 2+ overlay's? (Closing one, opens another)? [19:01:14] FlorianSW: i think i've worked out an easy fix [19:01:27] FlorianSW: it's never been done before :D [19:01:36] jdlrobson: great :D [19:01:59] jdlrobson: i thought about to reimplement hide(), this should be the easiest solution? But not tried yet :P [19:02:37] FlorianSW: that sounds dangerous lol [19:02:47] FlorianSW: it shouldn't be too hard [19:03:08] we just have to change the talk overlay headings to be links [19:03:24] actually now i think about it we do have examples of overlays on top of overlay [19:03:39] lead photo upload opens the tutorial or at least used to [19:03:44] and linking to #talk and #talk/1, #talk/2 and so on? [19:04:10] yup [19:04:24] jdlrobson: linking i have tried, too :P But the old overlay will be closed from OverlayManager, with hide() :) [19:06:34] which will cause the same problem :/ [19:13:22] jdlrobson: upload-tutorial has the same problem :) If you click "what does this mean" and instantly click the back key of the browser, after a second, the upload-preview overlay will close, too. The only different: upload-tutorial hasn't a back key, and no one clicks through the steps in less than 1 second :) [19:14:53] jdlrobson: anyway: why is there a delay, for what animations we wait? :? [19:20:30] (03CR) 10Jdlrobson: [C: 04-1] "Florian points out this causes a JS exception." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160565 (owner: 10Jdlrobson) [19:23:54] It’s going to be interesting to see what bugello does with our two Sprint 40s. [19:32:31] kristenlans: can you add a google hangout to the wikigrok update invite? [19:32:43] hmm I did few mins ago [19:32:55] didn’t save it tho HO!hohO!H [19:32:58] hehe [19:33:21] there's a very hidden preference that makes it so every new invite has a hangout link [19:33:25] it changed my life, man [19:33:39] Oh, nice. I will have to get familiar with that ;-) [19:38:46] (03PS1) 10Brion VIBBER: Bump version to 4.0.3 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/160803 [19:39:00] (03CR) 10Brion VIBBER: [C: 032 V: 032] Bump version to 4.0.3 [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/160803 (owner: 10Brion VIBBER) [19:40:10] (03PS9) 10Kaldari: Improvements to Wikigrok A interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 [19:42:23] oh lemme make sure all the localizations are attached properly [19:44:23] grrr xcode’s being wonky [19:57:44] (03PS1) 10Brion VIBBER: update language project files [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/160806 [19:58:23] (03PS2) 10Brion VIBBER: update language project files [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/160806 [19:58:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] update language project files [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/160806 (owner: 10Brion VIBBER) [20:03:31] http://hatjitsu.wmflabs.org/22389 [20:05:34] ok lemme set the code signing magic and make a build [20:05:36] FINGERS CROSSED [20:08:59] sweet xcode crashed [20:10:36] and …. it crashed again [20:10:37] well this is fun [20:16:32] i can export an .ipa but it won’t let me upload from xcode 6 without crashing :D. sighhhhh [20:17:11] maybe i can upload it from xcode 5 [20:18:29] * YuviPanda pats brion [20:18:30] ok i got it in \o/ letting it process for a bit [20:19:20] YuviPanda: so we’ve had a few dozen beta signups since we added the link to the update notes :D [20:19:26] still a fraction of what you guys get of course sigh [20:23:16] trying to find out how to depublish Commons app for iOS :) [20:25:10] brion: nice [20:25:25] (03CR) 10Kaldari: "Jdlrobson: I don't want to rebase this off the refactoring, as the refactoring touches other features. So if we have to revert or redo the" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 (owner: 10Kaldari) [20:36:29] (03CR) 10Kaldari: Jon fixup to Kaldari patch (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160472 (owner: 10Jdlrobson) [20:39:18] brion: hey! i’m poking that network op refactor. found my old partial refactor branch… the key realization i had was that the “dependencies” array property of NSOperation retains it's pointers even if the ops in the array pointers refer to have finished - this means data can be relayed simply via these pointers. much more clean [20:40:10] mhurd: nice! [20:40:19] ok i got 4.0.3 in the queue with the iphone 6 fixes [20:40:23] we’ll see how long it takes [20:40:32] brion: yes!!!! awesome! [20:40:43] (03PS2) 10Jdlrobson: Register TalkOverlay to #/talk [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160565 [20:40:47] i had to upload it from xcode 5 because xcode 6 crashes when i submit to the store ;) [20:40:53] ^ FlorianSW that does it [20:40:56] but it was built with 6 [20:41:00] so …. hopefully no explody [20:41:09] brion: weird! [20:41:52] (03PS5) 10Jdlrobson: WIP: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [20:42:25] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix wgMFShowRedLinks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [20:43:08] mhurd: awesome, lemme know when that’s ready and i’ll poke at fixing up the frontend refresh patch, i messed something up in the storyboard but it’s close :D [20:43:12] and … i should probbably grab lunch [20:43:25] food! [20:43:51] iOS review queue is pretty fast these days, I think [20:44:16] jdlrobson: checking, but looks good :) [20:44:27] sjoerddebruin: last update took over a week :( [20:44:36] When was that? [20:45:05] The topic of this channel mentions that there is a iOS-update every day. ^ [20:45:08] went live yesterday, was submitted on the 5th iirc [20:45:24] jdlrobson: can you take a look at my comment on ps1? [20:48:29] FlorianSW: i'm a little confused [20:48:41] what do you mean by trailing slash? [20:48:50] do you mean leading slash [20:48:59] (03CR) 10BearND: [C: 032] Make sure that a new location is "better" than the previous one. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160509 (owner: 10Dbrant) [20:49:07] jdlrobson: ähm, yes :D [20:49:14] yeh editor needs to be fixed [20:49:16] jdlrobson: sorry for confusen :) [20:49:19] let me see if i raised a bug for that [20:49:43] jdlrobson: ah, ok :) [20:50:16] https://www.mediawiki.org/wiki/Mobile_web/Coding_conventions#URL_Routing_.28Use_of_the_URL_hash.29 [20:50:28] ok gonna grab a quick lunch [20:50:48] (03Merged) 10jenkins-bot: Make sure that a new location is "better" than the previous one. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160509 (owner: 10Dbrant) [20:51:09] jdlrobson: ah, yeah :) [20:51:13] FlorianSW bug raised. https://bugzilla.wikimedia.org/show_bug.cgi?id=70904 [20:51:47] 3MobileFrontend / 3Hygiene: Hygiene: Change editor URL to use leading / - 10https://bugzilla.wikimedia.org/70904 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon See https://www.mediawiki.org/wiki/Mobile_web/Coding_conventions#URL_Routing_.28Use_of_the_URL_hash.29 #editor/0 should be changed to #/editor/0 T... [20:51:59] (03CR) 10Florianschmidtwelzow: [C: 031] Register TalkOverlay to #/talk [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160565 (owner: 10Jdlrobson) [21:28:38] (03PS1) 10Deskana: Add information about the app being not supported to the readme. [apps/android/commons] - 10https://gerrit.wikimedia.org/r/160830 [21:35:17] 3Commons App / 3Android: i18n: \u00A0 does not survive export to translatewiki - 10https://bugzilla.wikimedia.org/69395#c4 (10Nemo) 5NEW>3UNCO https://gerrit.wikimedia.org/r/#/c/160831/ for disabling. However, that doesn't affect this bug, which needs: 1) verify if the source l10n file was valid, 2) if... [21:35:58] (03PS1) 10Deskana: Add information about the app being not supported to the readme. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/160833 [21:46:23] (03PS3) 10Kaldari: Jon fixup to Kaldari patch [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160472 (owner: 10Jdlrobson) [21:46:27] Can someone give these patches a quick +2? [21:46:28] https://gerrit.wikimedia.org/r/#/c/160833/ [21:46:31] https://gerrit.wikimedia.org/r/#/c/160830/ [21:47:07] (03CR) 10jenkins-bot: [V: 04-1] Jon fixup to Kaldari patch [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160472 (owner: 10Jdlrobson) [21:47:53] (03CR) 10MaxSem: [C: 032 V: 032] Add information about the app being not supported to the readme. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/160833 (owner: 10Deskana) [21:47:56] Deskana: I forgot where you wanted me to put the testing docs, so they're at https://www.mediawiki.org/wiki/User:Yuvipanda/Testing_android_app?venotify=created now [21:48:00] do you remember the link? [21:48:05] search on mw.o didn't find it [21:48:16] (03CR) 10MaxSem: [C: 032 V: 032] Add information about the app being not supported to the readme. [apps/android/commons] - 10https://gerrit.wikimedia.org/r/160830 (owner: 10Deskana) [21:48:22] YuviPanda: https://www.mediawiki.org/wiki/Wikipedia_app#Android_app [21:48:26] MaxSem: Cheers Max. :) [21:48:42] Deskana, you shoud be able to do that yourself [21:49:14] Deskana: done [21:49:20] YuviPanda: Thanks! [21:49:21] MaxSem: tch tch don't teach him bad habits [21:49:32] YuviPanda: Exactly. ;) [21:53:58] Deskana: btw, if you want to mess with the android script parts of the Android app, check out https://trello.com/c/DpHf0vu0/4-1-add-xxxhdpi-launcher-icon [21:55:14] YuviPanda: Hmm, we shouldn't leave work lying around just so I can do it. :) [21:55:22] Deskana: hehe, I know :) [21:55:41] Deskana: it's a hourish work for me, but I can leave it till the weekend if you want to claim it :) [21:56:32] YuviPanda: Nah, we should leap right on this so we're good to go for getting featured. [21:56:46] I'll find something else to do. ;) [21:57:19] Deskana: :) ok [22:00:58] (03PS3) 10Kaldari: Refactoring InlineDialog and Drawer using new abstract Panel class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160172 [22:01:52] (03Abandoned) 10Kaldari: Jon fixup to Kaldari patch [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160472 (owner: 10Jdlrobson) [22:05:00] (03CR) 10Kaldari: [C: 032] "Self-merging per Jon" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 (owner: 10Kaldari) [22:05:34] (03Merged) 10jenkins-bot: Improvements to Wikigrok A interface [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/158821 (owner: 10Kaldari) [22:06:04] (03PS3) 10Kaldari: Adding user_id to data recorded by WikiGrok per analytics request [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159933 [22:06:25] (03CR) 10Kaldari: [C: 032] Adding user_id to data recorded by WikiGrok per analytics request [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159933 (owner: 10Kaldari) [22:06:56] (03Merged) 10jenkins-bot: Adding user_id to data recorded by WikiGrok per analytics request [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159933 (owner: 10Kaldari) [22:14:57] (03CR) 10BearND: [C: 032] "translation import" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160821 (owner: 10BearND) [22:16:07] (03Merged) 10jenkins-bot: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/160821 (owner: 10BearND) [22:21:54] (03PS4) 10Kaldari: Refactoring InlineDialog and Drawer using new abstract Panel class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160172 [22:22:26] (03CR) 10jenkins-bot: [V: 04-1] Refactoring InlineDialog and Drawer using new abstract Panel class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160172 (owner: 10Kaldari) [22:23:10] (03PS5) 10Kaldari: Refactoring InlineDialog and Drawer using new abstract Panel class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160172 [22:23:41] (03CR) 10jenkins-bot: [V: 04-1] Refactoring InlineDialog and Drawer using new abstract Panel class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160172 (owner: 10Kaldari) [22:31:36] (03PS6) 10Kaldari: Refactoring InlineDialog and Drawer using new abstract Panel class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160172 [22:33:30] 3MobileFrontend / 3General/Unknown: Search results blanked on ios7 iPhone4s - 10https://bugzilla.wikimedia.org/70890#c3 (10Jon) 5PATC>3RESO/DUP *** This bug has been marked as a duplicate of bug 69163 *** [22:33:30] 3MobileFrontend / 3stable: Search box cleared when selected from results page - 10https://bugzilla.wikimedia.org/69163#c4 (10Jon) *** Bug 70890 has been marked as a duplicate of this bug. *** [22:37:28] (03PS7) 10Kaldari: Refactoring InlineDialog and Drawer using new abstract Panel class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160172 [22:38:20] (03CR) 10Jdlrobson: [C: 04-1] Pre-fill search bar in SearchOverlay with previous contents (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160784 (https://bugzilla.wikimedia.org/70890) (owner: 10MaxSem) [22:38:28] (03CR) 10Kaldari: [C: 032] "self-merging per Jon" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160172 (owner: 10Kaldari) [22:39:02] (03Merged) 10jenkins-bot: Refactoring InlineDialog and Drawer using new abstract Panel class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160172 (owner: 10Kaldari) [23:00:06] (03PS1) 10Jdlrobson: Restrict iOS fixed header code to overlays with fixed headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160855 (https://bugzilla.wikimedia.org/69414) [23:01:09] (03Abandoned) 10Jdlrobson: Reenable zooming in overlays on iOS (except for VE) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/156481 (https://bugzilla.wikimedia.org/69414) (owner: 10JGonera) [23:04:11] (03Abandoned) 10Jdlrobson: Fix media viewer styling to accommodate for zooming [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/156482 (https://bugzilla.wikimedia.org/69414) (owner: 10JGonera) [23:06:50] (03PS1) 10Kaldari: Using #/ for MoreInfo overlay per mobile coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160861 [23:08:23] jdlrobson: Quick fix: https://gerrit.wikimedia.org/r/#/c/160861/ [23:12:08] (03CR) 10Jdlrobson: [C: 032] "Thanks for this!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160824 (https://bugzilla.wikimedia.org/70904) (owner: 10Florianschmidtwelzow) [23:13:15] (03Merged) 10jenkins-bot: Hygiene: Change editor URL to use leading / [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160824 (https://bugzilla.wikimedia.org/70904) (owner: 10Florianschmidtwelzow) [23:17:37] (03CR) 10Kaldari: [C: 04-1] "Hashar: What are these for? They're interfering with our pre-review hooks." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [23:22:44] (03CR) 10Kaldari: [C: 032] Register TalkOverlay to #/talk [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160565 (owner: 10Jdlrobson) [23:27:39] (03Merged) 10jenkins-bot: Register TalkOverlay to #/talk [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160565 (owner: 10Jdlrobson) [23:27:44] (03PS2) 10Jdlrobson: Hygiene: Using #/ for MoreInfo overlay per mobile coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160861 (owner: 10Kaldari) [23:27:51] (03CR) 10Jdlrobson: [C: 032] "We should probably rename this to /wikigrok/moreinfo as moreinfo is ambiguous and could mean more info about photo uploads." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160861 (owner: 10Kaldari) [23:28:51] (03Merged) 10jenkins-bot: Hygiene: Using #/ for MoreInfo overlay per mobile coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160861 (owner: 10Kaldari) [23:31:59] 3MobileFrontend / 3General/Unknown: Accessibility of headers broken due to accessibility enhancements - 10https://bugzilla.wikimedia.org/68371#c3 (10Jon) Hoo man and TheDJ how can we get this patch wrapped up (I see theDJ -1ed it)? [23:33:16] MaxSem: are you working on report card? [23:33:23] i see your face on the card but it's under ready for dev [23:33:34] nope, not right now [23:44:45] kaldari: eep. wikigrok looks a little… jankified on a tablet [23:44:56] can we just not show it to tablet users? is that easy to do? [23:56:16] (03PS3) 10MaxSem: Pre-fill search bar in SearchOverlay with previous contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160784 (https://bugzilla.wikimedia.org/69163) [23:57:25] jdlrobson, ^