[00:14:59] (03PS1) 10Kaldari: Adding clicktracking to WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161143 [00:27:05] brion: heading out for a bit - will continue the download refactor a bit later this evening [00:29:10] (03PS2) 10Kaldari: Adding clicktracking to WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161143 [00:32:18] (03CR) 10Ori.livneh: [C: 032] Adding clicktracking to WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161143 (owner: 10Kaldari) [00:32:48] (03Merged) 10jenkins-bot: Adding clicktracking to WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161143 (owner: 10Kaldari) [00:59:54] * Maryana looks for thank button in gerrit, does not find… thanks, ori :) [02:40:37] (03PS1) 10BearND: Don't filter out devices that just have fake touch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161154 [05:38:17] (03PS3) 10Florianschmidtwelzow: Move load content out of initialize [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160920 [05:38:24] (03CR) 10Florianschmidtwelzow: "> I'd expect to see an infinite spinner but what I actually see is the lead discussion row and the add discussion button." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160920 (owner: 10Florianschmidtwelzow) [06:44:28] (03PS13) 10Florianschmidtwelzow: Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) [06:54:41] (03PS14) 10Florianschmidtwelzow: Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) [07:47:24] 3MobileFrontend / 3beta: Scrolling in TalkSectionOverlay shows discussion list of TalkOverlay - 10https://bugzilla.wikimedia.org/70989 (10Florian) 3NEW p:3Unprio s:3normal a:3None Created attachment 16511 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16511&action=edit example If te discussi... [08:58:45] (03CR) 10Florianschmidtwelzow: Remove Language selector as image in beta (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) (owner: 10Florianschmidtwelzow) [10:01:04] (03CR) 10Florianschmidtwelzow: Improvements to add discussion on talk page (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) (owner: 10Florianschmidtwelzow) [11:08:56] (03PS2) 10Florianschmidtwelzow: Remove Language and Nearby Beta features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) [11:09:34] (03CR) 10jenkins-bot: [V: 04-1] Remove Language and Nearby Beta features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) (owner: 10Florianschmidtwelzow) [11:11:34] (03PS3) 10Florianschmidtwelzow: Remove Language and Nearby Beta features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) [11:14:01] (03CR) 10Florianschmidtwelzow: "I hope i haven't misunderstood you, Jon, but if i understand you right, you mean the remove of the Nearby beta features, right?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) (owner: 10Florianschmidtwelzow) [12:32:32] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [13:28:51] 3Commons App / 3iOS (iPhone or iPad): Upload fails and app crash - 10https://bugzilla.wikimedia.org/58857 (10Andre Klapper) [14:53:44] Yeah, I'll ping you on your talk page later. [14:55:46] Wrong channel^ [15:08:06] 3Wikipedia App / 3Android App: "Other languages" screen doesn't show "no results" when no language found - 10https://bugzilla.wikimedia.org/70106 (10Nemo) [15:18:55] * bearND waves at YuviPanda and dbrant [15:19:17] hey bearND! [15:19:43] dbrant: I didn't release the beta yesterday since it required more manifest changes, see https://gerrit.wikimedia.org/r/#/c/161136/ [15:21:02] when i uploaded the apk it told me that a few hundred more device type would be incompatible and filtered out [15:22:12] bearND: ah, very nice. So then, the app will launch on those devices, but the Nearby feature won't work? [15:23:52] I wonder if we could automatically remove the Nearby item from the list, if the device doesn't support it at all. [15:25:25] dbrant: without the patch, those devices couldn't even install it, whether the users want to use the nearby feature or not. With the patch the same number of devices can install the app, and I think they all should be able to use the nearby feature since we require network access anyways. [15:25:44] bearND: ok, makes sense [15:26:16] Just location based on network alone may not be as accurate sometimes (depends of if you're inside a building or outside and many other things) [15:26:46] but it think nearby should still be usable [15:26:56] bearND: have you verified that, with those manifest changes, the Play Store no longer filters out those devices? [15:27:20] dbrant: yes, i've uploaded an apk with the changes and we're back to 6770 device types [15:27:43] dbrant: with the 2nd patch we get 52 more device types than before [15:27:55] bearND: alright!! [15:28:03] (03CR) 10Dbrant: [C: 032] Mark Android features used by Nearby as optional [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161136 (owner: 10BearND) [15:28:59] (03CR) 10Dbrant: [C: 032] Don't filter out devices that just have fake touch [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161154 (owner: 10BearND) [15:30:13] dbrant: ty [15:30:49] yay for more compatibility! [15:31:38] dbrant: Deskana|Away: Should we add some code just for the beta to try to repair the saved pages (move them to the correct location on the fs). It would be only for pages saved with the 2.0-beta-2014-09-09 bits. [15:31:42] YuviPanda: ^ [15:34:06] bearND: my vote would be No... beta users should expect a hiccup or two along the way. [15:35:39] dbrant: ok, probably would have been a bit complicated anyways. If you don't have any other things that you want to get into the beta I'll prepare another release [15:36:11] bearND: excellent; good to go [15:49:04] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161249 [15:49:28] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161249 (owner: 10BearND) [15:49:53] 3Wikipedia App / 3iOS App: App should allow pinch and zoom of article content (REDUX) - 10https://bugzilla.wikimedia.org/71004 (10Joe Decker) 3NEW p:3Unprio s:3normal a:3None iOS pinch/Zoom does not function at article contents or image contents. This has accessibility implications, and the latter i... [15:52:21] (03PS2) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161249 [15:54:30] (03Abandoned) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161249 (owner: 10BearND) [15:57:35] (03Restored) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161249 (owner: 10BearND) [15:59:01] (03Abandoned) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161249 (owner: 10BearND) [16:14:39] (03PS1) 10Yurik: pt translation for zero-charge-auth [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/161255 [16:15:25] (03CR) 10Yurik: [C: 032] pt translation for zero-charge-auth [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/161255 (owner: 10Yurik) [16:17:47] (03Merged) 10jenkins-bot: pt translation for zero-charge-auth [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/161255 (owner: 10Yurik) [16:25:35] dbrant|food: Deskana|Away YuviPanda: beta is published [16:32:00] My top complaint right now with the app is that the TOC doesn't give any indication of which sections haven't loaded yet. [16:32:12] (Android app, that is) [16:32:31] I often open links from email to see what the new message on my talk page is. [16:32:56] Of course, it's the last section. So I open the TOC to get to it, but usually the first time I tap, it hasn't loaded yet. [16:35:42] it'd be nice if there was like a spinner, or unloaded sections would be greyed out. [16:48:12] ragesoss: interesting idea ^. Should mention that to Deskana|Away [16:59:04] (03CR) 10MaxSem: Remove Language and Nearby Beta features (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) (owner: 10Florianschmidtwelzow) [17:00:21] 3MobileFrontend / 3General/Unknown: Desktop interface reverts to mobile after opt out - 10https://bugzilla.wikimedia.org/69967#c4 (10Todd Allen) No luck, I'm afraid. Was back on mobile this morning. [17:25:12] (03PS4) 10Jdlrobson: Remove Language and Nearby Beta features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) (owner: 10Florianschmidtwelzow) [17:27:32] (03CR) 10Jdlrobson: [C: 04-1] "You also need to delete images/BetaFeatures/nearby-ltr.svg and its friend" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) (owner: 10Florianschmidtwelzow) [17:32:28] (03CR) 10Jdlrobson: [C: 032] "perfect :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160920 (owner: 10Florianschmidtwelzow) [17:37:06] 3MobileFrontend / 3General/Unknown: Desktop interface reverts to mobile after opt out - 10https://bugzilla.wikimedia.org/69967#c5 (10Max Semenik) Is your browser in privacy mode? [17:37:17] (03Merged) 10jenkins-bot: Move load content out of initialize [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160920 (owner: 10Florianschmidtwelzow) [17:41:52] jhobs, how goes it? [17:46:22] 3MobileFrontend / 3General/Unknown: Desktop interface reverts to mobile after opt out - 10https://bugzilla.wikimedia.org/69967#c6 (10Todd Allen) No, it isn't, just checked to be sure. I also don't have any trouble with persistent cookies or settings on other sites. [17:49:13] (03CR) 10Jdlrobson: [C: 032] "I've made some notes about things that can be dealt with in a follow up." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) (owner: 10Florianschmidtwelzow) [17:57:42] (03PS1) 10BearND: More instructions for Android Studio [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161278 [18:01:37] bearND [18:01:43] kristenlans: coming [18:02:04] oh hey yurik, sorry I missed that message earlier. I still have about 40 tabs of onboarding videos & pages to go over, but other than that, great :) [18:02:13] (03Merged) 10jenkins-bot: Improvements to add discussion on talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153957 (https://bugzilla.wikimedia.org/69763) (owner: 10Florianschmidtwelzow) [18:02:39] https://etherpad.wikimedia.org/p/MobileAppRetrospective [18:02:47] jhobs, most of them are either dups, outdated, or useless ;) [18:06:51] 3MobileFrontend / 3beta: The add discussion button in talk overlay doesn't work - 10https://bugzilla.wikimedia.org/69763 (10Jon) 5PATC>3RESO/FIX [18:08:28] bearND: \o/ (re: beta) [18:29:47] cna you hear us bearND [19:00:35] Maryana we’e just wrapping up apps retroepctive, we’ll be there in a second. [19:00:41] np [19:04:19] (03PS1) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 [19:05:24] https://docs.google.com/a/wikimedia.org/document/d/12t4EEg0thL_a4oLINcpo1FmqcY82s3zGJ-R1kX7_ycE/edit#heading=h.jnbf08sr20ov [19:08:03] 16 Fatal error: Cannot use object of type stdClass as array in /srv/mediawiki/php-1.24wmf22/extensions/MobileFrontend/includes/MobileFrontend.hooks.php on line 330 [19:08:04] WUT [19:09:24] $list['Watchlist'] = 'SpecialMobileWatchlist'; [19:09:38] go home php, you are drunk, etc, etc [19:09:57] YuviPanda: It's more that I fixed this [19:10:19] MaxSem merged it [19:10:37] https://gerrit.wikimedia.org/r/#/c/159526/3 [19:14:18] https://github.com/wikimedia/mediawiki-core/commit/4f0b2f42419c283e8c94a5be6147d54ae7731a6b [19:14:19] DAMN IT [19:40:14] Nearby on Android app rocks! [19:41:32] (also rocks on iOS, but we knew that ;-)\) [20:15:56] (03PS1) 10Deskana: Add text file containing the MIT Licence. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/161345 [20:17:00] kristenlans: I was thinking about the "beta only features" thing raised in the retrospective. [20:17:15] kristenlans: I wonder whether it's worth having a page that documents all features that are currently only in the beta app. [20:17:21] kristenlans: That way it's harder to lose track of them. [20:17:26] kristenlans: Do you think that helps? [20:17:33] kristenlans: Or is it just extra unnecessary overhead? [20:18:06] Deskana: I think it helps, I just wonder if there’s a way to make it more of an atuomated thing… [20:18:53] mhurd: Why do we have phplint running on the iOS app? I thought there was no PHP in it. [20:19:33] Deskana: running on it? where? [20:19:47] mhurd: Jenkins on my most recent patch: https://gerrit.wikimedia.org/r/#/c/161345/ [20:19:55] mhurd: apps-ios-wikipedia-phplint SUCCESS in 0s [20:20:05] Although the 0s suggests it's not really trying very hard. :P [20:20:36] Maybe it's just Jenkins being weird because I only touched a txt file. [20:20:47] Jerkins. [20:20:48] Deskana: ah! oh yeah a recently added build script uses some php scripting to process some lang files iirc. brion? ^ [20:21:14] Deskana: oops brion’s not online… [20:21:18] mhurd: Not a pressing issue, was just curious. [20:21:22] mhurd: Never mind. [20:21:45] Deskana: ya shouldn’t hurt anything i guess :) [20:22:11] Deskana: Looks liek mobile web does this, doesn’t quite look up to date though https://www.mediawiki.org/wiki/Mobile/Release_history#Mobile_Web [20:29:02] There's something somewhat fascinating about sitting here watching violetto work. [20:29:14] Actually sat drawing in a sketchbook. That's so alien to me! [20:29:42] creepy Deskana [20:29:44] Okay, clarify. [20:29:47] I'm doing my own work too. [20:29:50] :P [20:30:41] * YuviPanda pats Deskana and violetto [20:33:32] YuviPanda: Well, soon you'll be here too and I'll be watching you work. [20:33:42] YuviPanda: Except with you it *will* be in a creepy way. :) [20:33:43] Deskana: it's ok, I've a loud keyboard [20:33:56] Deskana: haha :D [20:34:04] * YuviPanda wears google glass, looks at Deskana [20:34:42] * Deskana issues a DRONE_HIDE command to the spy bot he has deployed on YuviPanda. [20:35:05] Deskana: tschh, I've a Seven of Nine with borg enhanced optical sensors... [20:35:36] * Deskana just realised he is only vaguely sure which continent YuviPanda is on right now, so perhaps the spy bot needs its data reporting enhanced. [20:35:49] Deskana: haha, still in the UK :) [20:37:19] Deskana: the trams in manchester were pretty cool [20:37:29] YuviPanda: Where did you go to/from? [20:37:38] 3MobileFrontend / 3stable: References on main page do not work - 10https://bugzilla.wikimedia.org/71023 (10Jon) 3NEW p:3Unprio s:3normal a:3None * Visit main page in edit mode (append action=edit at the end) * Enter text boo * Save With the Cite extension enabled this renders a standalone... [20:37:45] Deskana: oh, we only spent an hour or so in Manchester, took a tram to Oldham for a day, and then spent 2 days in Edale [20:37:51] Edale is *verrrrryyyyy* pretty [20:38:02] YuviPanda: Funny, I've only ever gotten the tram once, and it was to go to Oldham. :) [20:38:06] haha [20:38:20] YuviPanda: I went from the Shudehill Interchange to Oldham. [20:38:31] I used to live 5 minutes walk away from the Shudehill Interchange. [20:38:34] Deskana: re: docuemnting the state of features, it woudl be neat if we could generate something out of commit messgaes, a few possibilites here: http://stackoverflow.com/questions/14960674/changelog-generation-from-github-issues [20:38:35] Deskana: also learnt that Oldham is supposed to be called Oldam [20:38:41] Deskana: heh, I went from picadally [20:39:06] YuviPanda: There's something rather strange about hearing about someone touring my hometown when I'm so far away from it... [20:39:12] Deskana: hehe :) [20:39:23] (03Abandoned) 10MaxSem: Simplify references selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161018 (owner: 10MaxSem) [20:39:42] Deskana: at least you didn't live in London or Glasgow [20:40:01] YuviPanda: Agreed about London, I don't like London. But I do like Glasgow... [20:40:12] YuviPanda: What's wrong with Glasgow? [20:40:12] Deskana: Glasgow is cold! London is less colder... [20:40:16] Haha :D [20:40:18] That's why I like it! [20:40:21] haha [20:40:22] Cold and rain, just like Manchester. [20:40:25] lol [20:40:36] although it was nice and sunny when I was there (glasgow and manchester0 [20:40:37] ) [20:40:46] of course, I learnt that 'sunny' doesn't have any correlation with temperatur [20:40:47] e [20:40:52] It might sound stupid, but Northern Englishmen have way more in common with Scots than they do with Southern Englishmen. [20:40:58] still find it weird to be in a place that's very sunny, but cold [20:41:01] A hated for the Tories, for example... [20:41:04] haha [20:41:05] *hatred [20:41:13] I'm jealous that Scotland might manage to free themselves from them. [20:41:16] No, seriously. [20:41:19] indeed, I've learnt a fair bit about that in the last month [20:41:23] I have the same fucking issue with the Tories that the Scots do. [20:41:27] The Tories don't represent my interests. [20:41:36] * YuviPanda notes that Alice is in a very political meeting right now [20:41:39] (03PS3) 10MaxSem: Allow overriding Nearby coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159436 (https://bugzilla.wikimedia.org/49413) [20:41:45] and I might get to stay up to watch the results [20:41:50] Deskana: yeah. [20:42:04] Scotland is on my list of places to live. [20:42:11] Along with Ireland and the Netherlands. [20:42:14] (03CR) 10jenkins-bot: [V: 04-1] Allow overriding Nearby coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159436 (https://bugzilla.wikimedia.org/49413) (owner: 10MaxSem) [20:42:16] Deskana: not india? [20:42:17] :) [20:42:20] * Deskana still hasn't been to Northern Ireland. [20:42:29] YuviPanda: India is on my list of places to visit. [20:43:01] Deskana: ah! yes, indeed. I suggest 1 month min :) [20:43:39] (03PS2) 10BearND: More instructions for Android Studio [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161278 [20:46:02] (03PS1) 10BearND: [do not merge] dummy commit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161351 [20:46:21] (03Restored) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161249 (owner: 10BearND) [20:48:11] YuviPanda: oh-oh. our repo is some serious doodoo. https://gerrit.wikimedia.org/r/#/c/161249/ [20:49:05] * YuviPanda looks [20:49:19] oh [20:49:20] two bumps? [20:49:39] YuviPanda: well, it was actually the same commit (note that the change id is the same) [20:49:49] @_@ [20:50:01] bearND|away: oh wait:! [20:50:08] how did that even merge?! [20:50:42] (03PS3) 10Yuvipanda: More instructions for Android Studio [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161278 (owner: 10BearND) [20:50:57] bearND: anyway, rebase seems to work... [20:52:17] i think it started this morning when I submitted the bump commit. Suddenly it was duplicated and dependend on itself. then i did a serious of abandoning and restoring. Hmm, can you try to submit a dummy patch, too? [20:53:31] (03PS1) 10Yuvipanda: dummy commit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161352 [20:54:23] bearND: seems ok [20:55:15] YuviPanda: ahh, good [20:55:47] (03Abandoned) 10BearND: [do not merge] dummy commit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161351 (owner: 10BearND) [20:56:27] (03Abandoned) 10BearND: dummy commit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161352 (owner: 10Yuvipanda) [21:03:15] mhurd: Do you have a few moments to look at TestFlight config with me to see if we can hook it up to OTRS? [21:03:30] Deskana: 5 minutes? [21:03:34] in 5? [21:03:36] mhurd: Sure, see you in 5. [21:03:40] dbrant|food: Please do ping me when you are back [21:03:58] vbamba: back! [21:04:03] oh yay! [21:04:18] Shd I come up with a general list style for saved/ recent/ nearby/ search? [21:04:39] vbamba: I think that would be quite helpful [21:05:08] Do you want to hold off on styling nearby? [21:05:20] I can work on a general list style and have it out to you by eod [21:05:55] vbamba: absolutely! that would be good [21:07:20] jdlrobson, http://colinm.org/language_checklist.html [21:09:10] (03CR) 10Jdlrobson: [C: 04-1] Allow overriding Nearby coordinates (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159436 (https://bugzilla.wikimedia.org/49413) (owner: 10MaxSem) [21:12:05] bearND: did you, by any chance, have your heart set on doing this: https://trello.com/c/l2ouTvnf/2-5-make-every-other-activity-launched-from-nav-bar-into-fragments [21:13:10] bearND: I feel like it's too tightly-coupled with the one I'm working on now... so it might be more efficient for the same person to tackle both. [21:14:03] dbrant: either way is fine with me [21:14:16] dbrant: how's it going so far? [21:15:00] bearND: not bad! I'm going down the route of reusing the webview, and it's looking good. [21:15:08] I might have a patch by the end of today [21:15:32] dbrant: Great! I imagine you have a MainActivity of sorts [21:16:56] bearND: I haven't renamed PageActivity, but it's now just a container of fragments, and dispatcher of events. [21:17:18] dbrant: sounds great [21:20:42] mhurd: https://trello.com/c/JUWS2tPb/31-clicking-on-a-search-result-still-shows-previous-content-for-a-second-or-two [21:20:52] Can i chat with you quickly about this? [21:21:43] dbrant: if you don't mind i'll focus more on the nearby feature for a bit. Saw the first OTRS crash reports for Nearby coming in. [21:21:54] Wamted to understand how much work would be involved in just blanking out the previous result? [21:21:58] bearND: yeah, I noticed that; by all means! [21:22:40] dbrant: also feel free to merge https://gerrit.wikimedia.org/r/#/c/161278/3 in the meantime [21:25:55] Bookmark “the batcave” everybody! https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [21:26:08] vbamba: ya! i’ve got a quick chat with dan about testflight, but right after that? [21:26:47] (03CR) 10Florianschmidtwelzow: [C: 031] Remove Language and Nearby Beta features (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) (owner: 10Florianschmidtwelzow) [21:27:26] kristenlans: is this the analytics' team's batcave? :) [21:27:57] YuviPanda: it’s OURS™!!!!!!!!!!!!! Attribution: I stole the Batcave idea (persistent google hangout) from millimetric. [21:28:03] heh :) [21:28:08] (03CR) 10Florianschmidtwelzow: Remove Language and Nearby Beta features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) (owner: 10Florianschmidtwelzow) [21:28:14] kristenlans: robincave? [21:28:29] yuvipanda: Jokercave :-| [21:28:38] jdlrobson: have you one second? [21:28:39] surely you mean jokercircus [21:28:47] FlorianSW: sure [21:29:02] eagles' nest. [21:29:26] “To the eagle’s nest!” Has a good ring to it. [21:29:26] Ready Room? [21:29:29] .page-secondary-actions remove from https://gerrit.wikimedia.org/r/#/c/161025/4/includes/skins/MinervaTemplate.php too? It's inconsistent with page.hogan now (or add the div to template? I don't know the plans with it :)) [21:29:35] (for all the ST:TNG fans) [21:31:12] ? [21:31:17] i'm confused [21:31:33] it should be consistent with page.hogan [21:31:49] mhurd: Are you working on this today? https://trello.com/c/JUWS2tPb/31-clicking-on-a-search-result-still-shows-previous-content-for-a-second-or-two [21:32:06] it looks consistent though FlorianSW? [21:33:04] vbamba: Are you coming to this meeting about the trademarks? [21:33:11] vbamba: We're in Browne. :) [21:33:27] 1 minute [21:33:31] talking to mhurd [21:33:32] Deskana; oops forgot about that. I’m gonna lurk, brt [21:33:54] jdlrobson: look at the first commands of protected function renderMetaSections() { [21:33:59] (+10 lines) [21:34:01] :) [21:34:16] jdlrobson: "echo Html::openElement( 'div', array( 'id' => 'page-secondary-actions' ) );" it will add the div [21:36:14] Florian make the page.hogan file include the div [21:36:18] it should be identical to the PHP [21:37:11] jdlrobson: ok :) [21:42:59] (03PS5) 10Florianschmidtwelzow: Remove Language and Nearby Beta features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) [21:45:08] (03PS6) 10Florianschmidtwelzow: Remove Language and Nearby Beta features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) [21:48:34] (03CR) 10Dbrant: [C: 032] More instructions for Android Studio [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161278 (owner: 10BearND) [22:05:04] jdlrobson: was there any special reason why you reimplemented hide in TalkOverlay: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/modules/talk/TalkSectionOverlay.js#L18 ? Because i want to remove it to resolve bug 70989 :) [22:05:08] 3Wikipedia App / 3Android App: Nearby feature crash with NPE - 10https://bugzilla.wikimedia.org/71025 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None Two similar NPEs occurring in Nearby feature during the sort by distance step: java.lang.NullPointerException at android.location.Location.distanc... [22:05:35] mhurd: quick question [22:05:47] vbamba: ya [22:06:10] is the action sheet modif-able so it contains content and not list of action? [22:06:31] It kind of defeats the purpose, but I was just curious [22:06:50] vbamba: hmmm not sure… i can check later [22:07:09] its not urgent at all [22:23:56] (03PS1) 10Jdlrobson: Optimise galleries on mobile and tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161364 (https://bugzilla.wikimedia.org/70684) [22:24:09] (03PS2) 10Jdlrobson: Optimise galleries on mobile and tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161364 (https://bugzilla.wikimedia.org/70684) [22:31:58] (03CR) 10Jdlrobson: [C: 04-1] "I need to align image to left and shrink caption size still" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161364 (https://bugzilla.wikimedia.org/70684) (owner: 10Jdlrobson) [22:43:13] FlorianSW: hey [22:43:21] you can also remove the mobile.nearby.beta i believe [22:43:26] jdlrobson: hey :) [22:43:40] but you can do that in a follow up [22:43:55] i'm not even sure if the NearbyOverlay get's used anymore [22:44:04] i'm just gonna test yours and merge [22:44:57] jdlrobson: ok, if you give me 2 minutes i can check if it's "easy" to figure out, if someone uses this code :) [22:46:08] ok awesome FlorianSW [22:46:23] jdlrobson: you mean mobile.special.nearby.beta to be clear, right? :) [22:46:42] yes. basically anything which uses page preview or NearbyOverlay [22:47:06] accoridng to https://trello.com/c/NdTdZdxI/8-3-remove-nearby-beta-features-from-beta [22:50:35] jdlrobson: You're right, can be removed, too :) [22:52:15] (03PS1) 10Florianschmidtwelzow: WIP: Fixes for Talk feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161368 (https://bugzilla.wikimedia.org/70989) [22:57:25] (03PS3) 10Jdlrobson: Optimise galleries on mobile and tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161364 (https://bugzilla.wikimedia.org/70684) [22:57:41] FlorianSW: cool let me know when it's p and i'll review [22:58:04] jdlrobson: actually working on it, ping you if i finished :) [23:03:47] (03PS7) 10Florianschmidtwelzow: Remove Language and Nearby Beta features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161025 (https://bugzilla.wikimedia.org/65907) [23:03:58] jdlrobson: ping ^^ :) [23:05:22] Deskana: mhurd can you ping me when you guys are done with anaytics meeting? [23:06:11] vbamba: done! [23:09:37] 3MobileFrontend / 3General/Unknown: Gallery modes "packed-overlay" and "packed-hover" break the page - 10https://bugzilla.wikimedia.org/68228#c5 (10Jon) I too cannot reproduce it using packed galleries on mobile. Looking at the source code of the page the footer is there but the gallery tag is not closed fo... [23:12:18] Ironholds: when next week is over, i'm going to owe you one hell of a care package [23:12:58] Maryana: haha [23:13:06] hey, it's only...okay, 19:13pm [23:13:43] vbamba: https://github.com/wikimedia/apps-ios-wikipedia/blob/master/wikipedia/en.lproj/Localizable.strings [23:14:02] if you're serious, though, I currently accept payment in whisky, picture frames or stuff off http://amzn.com/w/35FQK4U0BYWW4 [23:14:08] * YuviPanda pats Ironholds [23:14:17] i'll just get you a yankees hat [23:14:24] * Ironholds winces [23:14:29] >:) [23:14:32] sure [23:14:40] and then maybe I can stand on the street corner with a sandwich board [23:14:54] on the front it'll say "THE BOSSTONES ARE OVERRATED" and on the back it'll say "I DON'T GET WHAT THE DEAL IS WITH DUNKS" [23:15:08] I mean, you know, if we really want to make this beatdown a shoe-in ;p [23:15:08] … and that was the last we ever saw of oliver, strangely [23:15:19] yup [23:15:38] ooh [23:15:39] actually it'll have to be square, on account of there are too many good boston trolls [23:15:41] another random rec [23:15:44] bukowskis [23:15:44] BU '16 on one side [23:15:45] https://docs.google.com/a/wikimedia.org/spreadsheets/d/1WLFLUwynMxnjccrMuOWjd6C7MVTgTJNLmaWyogu_-ig/edit?usp=sharing [23:15:48] go to bukowskis [23:15:50] mhurd: Deskana [23:15:56] jdlrobson: (refer to your comment https://gerrit.wikimedia.org/r/#/c/153957/14/i18n/en.json) I think a generic edit error eventlogging would be useful (to use one schema for all edits, talkOverlay and editor). Maybe open a bug for it to discuss this more deeply? [23:15:59] I CROSS ON YELLOW on the other [23:16:06] *scribbles down*. Thanks! [23:16:26] you realise I will try and work "but god, who'd want to be such an asshole" into my review, right? Indie rock nerdery demands it. [23:17:07] * the one in back bay. eff that cambridge b.s. [23:17:45] makes sense! [23:17:53] it turns out i have more fond memories of the greater boston area than i thought [23:17:59] you need to come back to Allston and re-familiarise yourself with the local crazies [23:18:02] relive them for me, pls kthx [23:18:13] oh man, you missed out on the best crazy! [23:18:15] mr. butch [23:18:23] I've tried to decide if my favourite is "the native american dude living behind my apartment building" or "fat lady with dreads dancing down the street to music nobody else can hear" [23:18:44] he just..lives there. I think he might be mute. He comes over and waves sometimes, and just mimes, really happily. [23:18:49] But never any talking. [23:19:12] https://en.wikipedia.org/wiki/Mr._Butch [23:19:13] Mr. Butch? [23:19:15] huh [23:19:15] ^ this guy [23:19:28] i gave him 5 dollars once and he was my best friend forever after that [23:19:50] huh. cool! [23:19:52] RIP [23:19:59] You need to come back and visit or something [23:20:05] Allston is no longer home of crazies [23:20:12] it's now home of awesome korean food. And Wan's! [23:20:44] maybe i will... [23:20:48] oh, that reminds me; better way of describing whereabouts I am: you know the Brighton Music Hall? [23:20:53] Yeah, that's on one side of my block. [23:20:57] Gigs are hella-convenient. [23:22:46] doo eeet [23:22:56] ahh, yes [23:23:01] we have a cabal of computer scientists and designers [23:23:06] and they're wonderfully, wonderfully left wing [23:23:08] i lived closer to comm ave – glenville [23:23:44] Like, "took a month off to campaign for Elizabeth Warren" left wing. Which seems pretty left wing by overall national standards. [23:23:45] cool! [23:24:13] you're real close to the white horse [23:24:22] yerp-wait [23:24:29] Glenville/Comm Ave? [23:24:34] that is, Glenville Ave? [23:24:38] yep [23:24:43] my road leads off Glenville Ave. [23:24:46] small world, etc [23:25:00] indeed! [23:28:38] 3MobileFrontend / 3beta: Talk: Add new discussion to non existing talk page causes JS error - 10https://bugzilla.wikimedia.org/71028 (10Florian) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: - You have to be logged in - Open a page with a non existing talk page (in beta/alpha) - Click "Talk ic... [23:29:05] (03PS2) 10Florianschmidtwelzow: WIP: Fixes for Talk feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161368 (https://bugzilla.wikimedia.org/70989) [23:32:31] (03PS3) 10Florianschmidtwelzow: Fixes for Talk feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161368 (https://bugzilla.wikimedia.org/70989)