[00:00:07] https://gerrit.wikimedia.org/r/#/ I see two lines under 'outgoing reviews' [00:00:59] bmansurov: oh sorry, I thought you had already abandoned the later one [00:01:21] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162172 [00:01:35] bmansurov: this is definitely something that is easier to go over in person :) [00:01:44] kaldari, ok [00:02:09] (03CR) 10BearND: [C: 032] "simple version bump for next beta" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162172 (owner: 10BearND) [00:02:27] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162172 (owner: 10BearND) [00:03:01] bmansurov: you can abandon both of them now though [00:03:09] since they were just for testing [00:04:45] ok, I abandoned them. So in this case I just edited a random file, but usually I'd like to be able to see my changes in the browser. How do I do it? Is it project spefici? [00:04:54] specific* [00:05:08] bmansurov: normally, a change will get reviewed by 1 or 2 other developers, it will be amended a few times to address concerns or bugs and then one of the other devs on the team will approve it by marking it as '+2' [00:05:37] (03PS1) 10Jdlrobson: Switch to using $.inArray instead of indexOf for arrays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162176 (https://bugzilla.wikimedia.org/70963) [00:05:39] sorry if I missed, it but is there a +1 too? [00:05:57] bmansurov: yes, +1 means 'I think this is good, but I'd like to have a second opinion' [00:06:04] kaldari, ok [00:06:11] (03CR) 10jenkins-bot: [V: 04-1] Switch to using $.inArray instead of indexOf for arrays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162176 (https://bugzilla.wikimedia.org/70963) (owner: 10Jdlrobson) [00:07:50] bmansurov: normally, you'll want to test your changes locally before committing them. You should either point your localhost to your mediawiki installation or set up a local virtual host. I'm not sure if vagrant does any of that for you (I'm not using vagrant personally). [00:08:19] kaldari, there is an alternative to vagrant? [00:08:37] bmansurov: the alternative is setting up and configuring everything manually [00:08:47] kaldari, ok [00:10:04] bmansurov: also if you want to set up a localhost tunnel, so you can pull up your local instance of MediaWiki on a phone for example, you can use https://ngrok.com/ [00:10:27] bmansurov: or just set up your local webhost with a public IP address or domain name [00:10:41] kaldari, ok [00:11:23] bmansurov: if you need any help with that, Max would be the best person to ask probably [00:12:27] ngrok is extremely easy to set up though [00:13:09] ok thanks [00:14:03] (03PS1) 10Jdlrobson: Support internal redirects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162178 (https://bugzilla.wikimedia.org/69020) [00:14:53] bmansurov: Once a changeset is +2ed, jenkins will try to merge it with the current master branch. If the merge is successful your change will become live on beta labs within 10 minutes or so: http://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page [00:15:03] that's the mobile version of beta labs [00:15:06] (03PS2) 10Jdlrobson: Support internal redirects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162178 (https://bugzilla.wikimedia.org/69020) [00:15:12] (with a '.m') [00:15:33] and you can also test it there [00:15:52] ok, is there a link to the 'examples' in the betalabs? [00:16:54] bearND: hey, I'm here [00:17:51] bmansurov: I don't think that extension is turned on at beta labs actually [00:20:50] bmansurov: so your next priority should be getting your local web server pointed at your mediawiki installation if you haven't already. otherwise, it will be impossible to do much. [00:22:01] bmansurov: what OS are you running? [00:22:24] kaldari, I see the main page when I go to http://localhost:8080/wiki/Main_Page [00:22:29] kaldari, arch linux [00:22:34] cool [00:23:27] have you gotten the MobileFrontend extension working? i.e. can you click on the 'Mobile view' link at the bottom of the Main Page and see the mobile version of the website? [00:24:12] kaldari, yes [00:24:17] excellent [00:24:56] bmansurov: in that case, tomorrow we can start looking at the MobileFrontend code if you're ready to do that [00:25:21] kaldari, ok sounds good [00:25:35] kaldari, thanks for your help today [00:25:40] kaldari, i've learned a lot [00:26:14] bmansurov: No problem. I'm glad we made so much progress in one day :) [00:26:40] kaldari, me too [00:26:42] bmansurov: what hours are you working this week? [00:26:59] kaldari, I'll be available 9-5 SF hours [00:27:04] cool [00:27:15] kaldari, you mean I can pick my hours? [00:27:16] ;) [00:27:29] kaldari, I'm trying to be in the same time zone as you [00:27:32] bmansurov: actually, all the devs here at the office work 10-6 PST [00:27:43] ok, 10 - 6 then [00:27:59] bmansurov: but it's flexible [00:28:27] bmansurov: sorry if that runs into your dinner time :P [00:28:44] at least you get to sleep in :) [00:28:47] kaldari, np, i'm flexible too. what time will you be available tomorrow? [00:28:56] kaldari, sleep > food [00:29:51] bmansurov: I should be mostly free tomorrow except noon-2pm [00:30:00] SF time [00:30:11] kaldari, OK [00:30:33] bmansurov: anyway, that's plenty for today. I have to finish writing up my interview notes anyway [00:31:05] kaldari, thanks again and I'll talk to you tomorrow [00:31:10] kaldari, have a good one [00:31:26] bye all [00:36:13] (03PS1) 10Jdlrobson: Hygiene: WikiDataApi::getClaims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162185 [00:42:02] (03PS3) 10Jdlrobson: Hygiene: Move DOM handling out of postRender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162134 [00:42:04] (03PS1) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [00:43:30] 3MobileFrontend / 3beta: Wikigrok styling impacts search - 10https://bugzilla.wikimedia.org/71158 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16546 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16546&action=edit CSS regression See attachment. [00:45:00] (03PS3) 10Jdlrobson: Hygiene: Make more info dialog reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162129 [00:45:38] 3MobileFrontend / 3beta: Wikigrok styling impacts search - 10https://bugzilla.wikimedia.org/71158#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/qHjX6qrI [05:01:02] (03PS1) 10BearND: Right swipe in ToC hint for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162199 [05:07:32] (03PS1) 10BearND: Use beta package in Gradle build for beta flavor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162200 [05:38:13] (03CR) 10Florianschmidtwelzow: Better message to explain Images on Special:MobileOptions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161696 (owner: 10Florianschmidtwelzow) [05:38:48] (03PS3) 10Florianschmidtwelzow: Better message to explain Images on Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161696 [08:01:34] (03PS5) 10Florianschmidtwelzow: WIP: Addition to "Make advanced wikitext that is not content gray" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/157307 [08:01:36] (03PS2) 10Florianschmidtwelzow: Make advanced wikitext that is not content gray [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/157106 (owner: 10Jdlrobson) [08:02:13] (03CR) 10jenkins-bot: [V: 04-1] Make advanced wikitext that is not content gray [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/157106 (owner: 10Jdlrobson) [08:02:16] (03CR) 10jenkins-bot: [V: 04-1] WIP: Addition to "Make advanced wikitext that is not content gray" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/157307 (owner: 10Florianschmidtwelzow) [14:31:40] (03CR) 10Dbrant: [C: 032] Update tests of strings with one parameters [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161993 (owner: 10BearND) [14:36:12] (03CR) 10Dbrant: [C: 032] Right swipe in ToC hint for RTL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162199 (owner: 10BearND) [15:03:51] (03CR) 10Dbrant: [C: 032] Save nearby results between activity restores [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162170 (owner: 10BearND) [16:18:52] (03PS1) 10BearND: Right swipe in ToC hint for RTL, part 2 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162283 [16:39:09] (03CR) 10Jdlrobson: [C: 032] Better message to explain Images on Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161696 (owner: 10Florianschmidtwelzow) [16:39:46] (03Merged) 10jenkins-bot: Better message to explain Images on Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161696 (owner: 10Florianschmidtwelzow) [16:46:25] 3MobileFrontend / 3Hygiene: MobileFrontend should use mw-ui-icon - 10https://bugzilla.wikimedia.org/71181 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon Now mw-u-icon is available [1] MobileFrontend should deprecate it's use of the icon class and friends. [1] http://tools.wmflabs.org/styleguide/desktop/sec... [16:46:35] jdlrobson: I don't see any icons on http://tools.wmflabs.org/styleguide/desktop/section-4.html [16:46:39] 3MobileFrontend / 3Hygiene: MobileFrontend should use mw-ui-icon - 10https://bugzilla.wikimedia.org/71181 (10Jon) [16:47:01] prtksxna: what browser? maybe you found a bug ;-) [16:47:09] 3MobileFrontend / 3beta: Talk: Clicking back from add topic overlay doesn't destroy it - 10https://bugzilla.wikimedia.org/71076 (10Florian) [16:47:09] 3MobileFrontend / 3beta: Talk: Back button doesn't destroy open topic - 10https://bugzilla.wikimedia.org/71075 (10Florian) [16:47:18] (03PS7) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71180) [16:47:21] jdlrobson: Chrome 37 [16:48:10] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71180) (owner: 10Jdlrobson) [16:48:24] prtksxna: weird.. i was seeing them a minute ago but now i hard refreshed and they are gone [16:48:36] works fine locally [16:48:55] jdlrobson: Maybe its not getting the files? [16:49:05] jdlrobson: Are they base64 in the css? [16:49:16] oohh wait i know what's going on [16:49:21] it's using beta labs css [16:49:23] which hasn't updated yet [16:49:27] Ah [17:02:59] (03CR) 10Brion VIBBER: [C: 032 V: 032] "yeahhhhhh license info" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/161345 (owner: 10Deskana) [17:03:53] can anyone give me a link to upload a file to mediawiki? [17:04:07] (03CR) 10Brion VIBBER: [C: 04-2] "On further experimentation yesterday we found we don't seem to need this, and I'd rather not enable it unless we actually have a startup s" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/161630 (owner: 10Mhurd) [17:04:24] brion: sounds good [17:04:44] brion: hopefully update will go live today :) [17:04:52] * brion checks itunes [17:05:05] still in review. holy crap [17:05:11] brion: gah! [17:05:35] when it says “in review” i expect someone to be *actually looking at my app right then and there*, i don’t think they’ve had someone actually poking at it without sleep for the last few days [17:05:46] hehe [17:05:56] i think “in review” really means “we’re ignoring you right now, but you’re assigned to someone’s queue” :P [17:06:09] mhurd: gotta run finish up this lease stuff, be in the office in a bit after [17:06:12] kaldari: Maryana fyi i'll be in office for lunchtime [17:06:22] okey doke [17:06:37] brion: see ya then! [17:07:58] brion: i keep forgetting to turn the network link conditioner off... [17:14:05] (03CR) 10Kaldari: [C: 04-1] "Why not just create a cancel-icon class and avoid all the template madness?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161586 (owner: 10Jdlrobson) [17:14:27] kaldari|2: i don't understand [17:14:51] it's not madness it's componentising reusable components. [17:15:03] it makes it easier to change all our cancel buttons in one place rather than across multiple files [17:15:18] jdlrobson: sure, but why does it need to be a separate template, instead of just a CSS class? [17:15:23] this is exactly what templates were built for! [17:15:34] kaldari|2: because that's now how mediawiki ui works :) [17:15:41] we don't have god classes - you have modifiers [17:15:48] it makes sense when you look at the follow up [17:16:07] imagine making the change here -> https://gerrit.wikimedia.org/r/#/c/161321/7/templates/cancelButton.hogan in 10 templates [17:16:15] jdlrobson: OK, maybe I need to look at the follow-up. Otherwise, it looks like just complicating the code for no benefit [17:16:26] it's simplifying the code :) [17:16:30] all overlays have cancel buttons [17:16:53] it might be oversimplification (e.g. maybe there is something higher up) but that can be rectified later [17:17:05] but this is basically how OOJS works so we're gonna have to get used to it :) [17:17:11] OOUI rather [17:17:27] jdlrobson: to me ahving to look at 30 different file to figure out how a page's output is generate is complicated :) [17:18:02] why would you need to look at 30 files? [17:18:08] you'd just look at the partial [17:18:12] ? [17:18:29] we do this in the overlay already for header and content templates [17:19:20] i mean look at Overlay.hogan already - it uses this method for footer and content [17:21:11] (03PS1) 10Florianschmidtwelzow: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) [17:21:20] mhurd: heh [17:21:36] I totally understand using partials, I just don't think we need to create them for every button and ui component, but maybe this one makes sense. I'll look at the follow-up [17:21:55] mhurd: ok they *might* knock a couple hundred bucks off the rent increase. or they might not. they’ll get back to us. :PPPPP ah well we’ll see [17:21:57] (03CR) 10jenkins-bot: [V: 04-1] Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [17:22:00] whatever the market will bear :PPPPP [17:22:04] heading downtown, see ya [17:22:54] kaldari|2: a partial is just a template that can be slotted into another template [17:23:15] basically the benefit this brings if you want to change something about the cancel button, rather than change 50 files you can change one [17:23:24] we don't have 50 files yet but we have 8 which is a sign it should be a partial [17:26:18] jdlrobson, kaldari|2: one minute plz? [17:27:14] hey FlorianSW [17:27:16] (03PS2) 10Florianschmidtwelzow: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) [17:27:17] jdlrobson: all abstraction has a cost - the cost is you have to dig through more and more files to digest how a single page is constructed. The other cost is it requires more work to make unique changes to specific pages. These costs have to be weighted against the benefit gained from centralizing duplicated code. It's not a simple black and white decision. [17:27:33] Hey Jon :) How are you? [17:27:41] kaldari|2: well i'm telling you in this case it gives me great benefit. I was shocked at how many cancel buttons we had in our templates [17:28:09] i'm not suggesting we abstract everything but where we have more than 3 cases of duplicate html in a template that to me says abstract [17:28:23] kaldari|2, jdlrobson: never mind :) I have answered my question myself :P [17:28:44] jdlrobson: OK, you've convinced me. I'll take another look :) [17:29:19] bearND: this is ready, at you leisure :) https://gerrit.wikimedia.org/r/#/c/161483 [17:29:28] *your [17:30:25] (03PS6) 10Florianschmidtwelzow: WIP: Addition to "Make advanced wikitext that is not content gray" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/157307 [17:30:27] (03PS3) 10Florianschmidtwelzow: Make advanced wikitext that is not content gray [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/157106 (owner: 10Jdlrobson) [17:30:57] (03CR) 10jenkins-bot: [V: 04-1] WIP: Addition to "Make advanced wikitext that is not content gray" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/157307 (owner: 10Florianschmidtwelzow) [17:31:01] (03CR) 10jenkins-bot: [V: 04-1] Make advanced wikitext that is not content gray [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/157106 (owner: 10Jdlrobson) [17:31:46] jdlrobson: OK, I see the follow-up and now I completely understand why you did this :) Sorry. [17:33:51] okay cool :) [17:41:59] dbrant: probably should merge this around the same time as the other patch [17:43:08] (03CR) 10Jdlrobson: [C: 04-1] "Could you add tests? Something about this code doesn't quite look right." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [17:43:33] bearND: actually this first patch doesn't change much in terms of UI. It's the second patch that will need to be merged together with the patch that implements the real ActionBar. [17:44:13] hey bmansurov, how's life? [17:45:30] (03CR) 10Jdlrobson: Make sure, issues only added once (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [17:46:03] jdlrobson: Your patch gets rid of the disabled state in the edit save interface. Is that intentional? We should probably just git rid of the close button there. [17:46:25] kaldari|2: yep.. it made no sense [17:46:30] why would a cancel button be disabled? [17:46:35] unless i'm missing something [17:47:51] dbrant: ok, good to know [17:47:52] jdlrobson: I'll suggest removing it in a follow-up then [17:49:22] (03CR) 10Kaldari: [C: 032] "This removes the disabled state of the cancel button in the edit save interface (which didn't really make sense anyway). I would suggest r" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161586 (owner: 10Jdlrobson) [17:49:54] (03Merged) 10jenkins-bot: Hygiene: Use partial for cancel button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161586 (owner: 10Jdlrobson) [17:50:01] thanks kaldari|2 [17:51:21] jdlrobson: I still wish we could just have a cancel-icon class though. It would be so much simpler, but I guess it makes more sense to use mw-ui if we can. [17:55:30] yurikR: hey there, is there someone who can get my IP address on the list for Zero testing? [17:55:42] (03CR) 10MaxSem: [C: 04-1] Switch to using $.inArray instead of indexOf for arrays (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162176 (https://bugzilla.wikimedia.org/70963) (owner: 10Jdlrobson) [17:56:59] hi dbrant [17:57:06] are you good to meet at 11 [17:57:13] vbamba: yep! [17:57:14] I didnt get an accept on my invite [17:57:21] vbamba: (sorry) [17:57:27] ok awesome! im moving meeting rooms, might be 2 mts late. [17:57:29] no worries [17:58:27] (03CR) 10Jdlrobson: [C: 04-1] "QUnit is failing awrrghh" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162176 (https://bugzilla.wikimedia.org/70963) (owner: 10Jdlrobson) [18:01:49] dbrant: bearND mhurd brion just a headsup, our cluster is experiencing load issues with the API, so if you're testing something and things seem to return wrong things, it's probably the servers and not the app [18:02:21] YuviPanda: got it! [18:03:21] (03CR) 10Kaldari: Optimise galleries on mobile and tablets (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161364 (https://bugzilla.wikimedia.org/70684) (owner: 10Jdlrobson) [18:03:53] I seem to have two versions of the app installed on this iPod simultaneously. [18:04:01] I wasn't even aware that was possible. [18:05:25] dbrant, sure, but you don't really need your ip in the list [18:05:37] dbrant, what would you like to test? [18:06:56] yurikR: I need the Android app to believe that it's in a Zero 'environment' [18:07:10] dbrant: bearND mhurd brion the servers seem to have recovered for now, but might still be ocassionally iffy over the next few hours [18:07:30] whee [18:07:44] oh. dbrant yeah, that we can't simulate, need to add your ip. I can add your ip to the TESTON carrier if that's ok [18:09:31] yurikR: sure! shall I PM my IP? [18:09:46] yep [18:10:01] dbrant, is that your private ip, or shared in the office? [18:12:36] (03PS3) 10Kaldari: Hygiene: Move logic for rendering WikiGrokPanel out of Panel itself [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162130 (owner: 10Jdlrobson) [18:15:20] YuviPanda: cool thanks for the heads-up! [18:16:35] (03PS8) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71180) [18:16:36] yurikR, can you review https://gerrit.wikimedia.org/r/161517 please? [18:17:06] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71180) (owner: 10Jdlrobson) [18:18:46] MaxSem, sorry, missed it. Is this for watchlist only? Because we are moving away from using config when generating a page because html should always be the same in all cases [18:19:20] yes, watchlist only. no, it's not a problem because special pages aren't cached anyway [18:25:10] (03PS1) 10Jdlrobson: Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 [18:25:36] YuviPanda|dinner: when you said API did you mean just the geosearch generator or any API call? I did notice a stack trace earlier with a JSONException Value dbrant, bearND, YuviPanda|dinner: Sorry for missing the standup yesterday. How are things going in Android-land? Anything I can help with? [18:26:52] Deskana: np; we're humming along [18:28:27] (03PS9) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71180) [18:28:46] Deskana: i’m thinking the problem might be because we changed out our certificates trying to fix stuff [18:28:56] so the 4.0.2.1 release is on an old cert that no longer installs [18:29:00] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71180) (owner: 10Jdlrobson) [18:29:04] but the 4.0.3 (beta) release is on the new cert and works [18:29:14] i wish i could see more system logs :P [18:30:22] MaxSem, it's great. I've been creating pages about myself. What shall we do now? [18:30:39] (03PS2) 10Jdlrobson: Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 [18:30:42] mmm, break something?:) [18:30:44] brion: So if these users update then it'll fix itself? [18:30:55] Deskana: yeah. lemme blast out an update mail [18:31:08] MaxSem, sure ;) [18:32:00] (03CR) 10Kaldari: [C: 04-1] Hygiene: Make more info dialog reusable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162129 (owner: 10Jdlrobson) [18:32:30] wow much features in the new beta :O [18:34:13] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Add back button partial (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 (owner: 10Jdlrobson) [18:35:28] bmansurov, do you already have a Trello account? [18:35:40] MaxSem, no I don't [18:35:48] go to https://trello.com/b/lE01t781/mobile-web-current-sprint-31-eat-pray-love [18:36:11] on login, use your wmf google account [18:36:46] then poke kristenlans to add you to the team [18:37:01] bmansurov: Once you're set up in Trello, I can dig up some tasks for you to get started on [18:37:43] bmansurov: Also you have to pick out a good trello avatar [18:37:53] Deskana: ok while i’m at it i’m upgrading your ipod touch to final release of ios 8.0 [18:37:55] MaxSem, how do I poke someone? [18:38:01] kaldari|2, ok great [18:38:10] here;) [18:38:55] kristenlans, can you please add me to the Trello team? [18:40:06] brion: Great, thanks. [18:40:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Good catch thanks!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/161410 (owner: 10Saltymule) [18:42:05] lunch [18:42:17] kaldari|2, before you leave, I'm done creating my account, just waiting for kristenlans to add me to the team? Can I do some tasks? [18:42:37] (03CR) 10Brion VIBBER: [C: 032 V: 032] Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/161988 (owner: 10BearND) [18:47:03] bmansurov: added! [18:47:16] kristenlans, thanks [18:48:34] kaldari|2: WHAT HAVE YOU DONE WITH KALDARI|1!!!! [18:51:48] (03PS2) 10Brion VIBBER: Initial SavedPages eventlogging for iOS [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/160496 [18:51:50] (03CR) 10jenkins-bot: [V: 04-1] Initial SavedPages eventlogging for iOS [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/160496 (owner: 10Brion VIBBER) [18:55:02] (03PS3) 10Brion VIBBER: Initial SavedPages eventlogging for iOS [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/160496 [18:55:12] MaxSem, anything we can do now? [18:55:45] kristenlans! [18:56:03] DESKANA!!!! Feeling better? [18:56:41] kristenlans: A bit. Still coughy, but I can breathe for the most part. [18:57:24] (03CR) 10Yurik: Remove images from watchlist when needed (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/161517 (owner: 10MaxSem) [18:57:29] MaxSem, ^ [18:57:31] https://twitter.com/sempf/status/514473420277694465 [18:58:56] heehee [19:00:14] Sorry for the "looks"...I made a nice list in Outlook, witth bullets, bolding, spaces etc... but https://lists.wikimedia.org/pipermail/mobile-l/2014-September/008075.html [19:02:10] 3Wikipedia App / 3iOS App: 'Share' button crashes app on iPad Mini running iOS 8 - 10https://bugzilla.wikimedia.org/71189 (10Brion Vibber) 3NEW p:3Unprio s:3normal a:3None With latest 4.0.3 TestFlight build, pressing the 'share' button immediately crashes the app on iPad Mini with iOS 8. This appear... [19:11:52] 3Wikipedia App / 3iOS App: 'Share' button crashes app on iPad Mini running iOS 8 - 10https://bugzilla.wikimedia.org/71189#c1 (10Jonatan Svensson Glad (Josve05a)) Created attachment 16562 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16562&action=edit Screenshot of the share-menu with 4.0.2 [19:22:44] (03CR) 10MaxSem: Remove images from watchlist when needed (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/161517 (owner: 10MaxSem) [19:22:51] yurikR, ^ [19:23:39] MaxSem, i meant that in the handler function you don't have to pass all the values - only those that you need [19:23:51] the forwarding function could take care of that [19:23:58] ok [19:24:13] wasn't sure about your policy on that:) [19:25:24] bmansurov: Looks like you [19:25:37] you're set up in Trello. Wanna try fixing some bugs? [19:25:43] kaldari|2, sure [19:26:03] brion: iOS beta just crashed while I was usign the search [19:26:08] using* [19:26:16] (03PS2) 10MaxSem: Remove images from watchlist when needed [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/161517 [19:26:26] bmansurov: we'll start with something simple just to get you used to the workflow. I added you to the following card on the current trello board: https://trello.com/c/K7WojRQH/37-bug-69587-useprofile-page-left-aligned-rather-than-centered-in-tablet-view [19:28:13] kaldari|2, I've read the card. [19:28:14] bmansurov: usually, I'll create a new local dev branch for each new card I work on unless there is an obvious dependency between them. That way I can always work on other cards if one is held up in review. [19:28:15] MaxSem, lol, policy? :) [19:28:21] Josve05a: if you can find a reliable way to trigger that do file a bug :D [19:28:29] otherwise we’ll see if we can get crash reports going on the betas soon [19:28:47] Isn't that part of whyy you are using test flight? [19:28:53] kaldari|2, i see [19:28:53] TestFLight* [19:28:56] bah [19:29:54] Josve05a: we’ve been mainly using it for internal distribution so far, we haven’t integrated all the fancy features yet :D [19:30:40] wel...integrate the crash dump -thingy....:P [19:31:02] (03CR) 10Yurik: [C: 032] Remove images from watchlist when needed [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/161517 (owner: 10MaxSem) [19:31:11] brion: there’s a section here (http://www.imore.com/testflight-ios-8-explained) talking about integrated crash reports in testflight coming “later next year”… [19:31:12] bmansurov: also, don't forget to mention the bug in the commit summary: 'Bug: 69587' (on a separate line). That way it will automatically update the bug report in Bugzilla. [19:31:37] kaldari|2, what url should I clone? [19:32:28] bmansurov, you already have it in vagrant/mediawiki/extensions/MobileFrontend [19:32:29] kaldari|2, is everything a 'bug' or can the word 'Bug' be something else too? [19:32:42] we installed it yesterday, rememer? [19:32:54] MaxSem, oh yes [19:33:17] 'Bug' only refers to Bugzilla bugs [19:34:01] meanwhile, you need to grab that card in trello. drag'n'drop it from ready for dev to in dev [19:34:36] yurikR, thanks!:) [19:34:52] (03Merged) 10jenkins-bot: Remove images from watchlist when needed [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/161517 (owner: 10MaxSem) [19:35:05] MaxSem, ooh, oops, problem - that thing is not really if images should be there or not :( Need to fix. [19:35:14] will fix shortly [19:35:21] :P [19:37:11] MaxSem, do I need to create this page (http://127.0.0.1:8080/wiki/Special:UserProfile/Jdlrobson)? [19:37:21] no [19:38:01] everything in the Special: namespace are PHP-generated instead of wikitext basedd [19:38:07] MaxSem, how do I get to this page (https://en.m.wikipedia.org/wiki/Special:UserProfile/Jdlrobson) in my dev? [19:38:35] replace jdlrobson with whatever your account is [19:39:15] so this URL is parsed like that :/ [19:40:24] subpage meaning depends on a particular name. in this particular case, it's the name of account whose profile you're watching [19:41:25] MaxSem, I replaced the name, but the page doesn't exist, should I create one? [19:42:07] ah, it's still in beta [19:42:23] go to mobile options, enable beta mode, then alpha [19:42:33] (03CR) 10Kaldari: [C: 032] "nice" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148557 (owner: 10Jdlrobson) [19:42:41] it's accessible from hamburger menu [19:43:27] MaxSem, I did, but still getting the same error message: "No user with this name exists. Usernames are case sensitive so please check if it has been typed correctly." [19:43:40] brion: sorry for spamming the pipemail... [19:43:56] grr, I said you should replace it with your username [19:43:57] (03CR) 10Kaldari: [C: 04-1] "Just for minor comment" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161364 (https://bugzilla.wikimedia.org/70684) (owner: 10Jdlrobson) [19:44:55] MaxSem, I tried http://127.0.0.1:8080/wiki/Special:UserProfile/bmansurov and http://127.0.0.1:8080/wiki/Special:UserProfile/Bmansurov_%28WMF%29, neither work [19:45:14] and have you registered on that wiki? ;) [19:45:29] not in my dev environment [19:45:44] I can see my profile here: https://en.m.wikipedia.org/wiki/Special:UserProfile/Bmansurov_%28WMF%29 [19:45:51] Josve05a: no worries :D [19:47:01] MaxSem, it's working now, I had to sign up [19:47:11] (03Merged) 10jenkins-bot: Use Special:EditWatchlist for A-Z View [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148557 (owner: 10Jdlrobson) [19:49:08] (03PS5) 10Brion VIBBER: Pull to refresh UI on Saved Pages (frontend only) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144846 [19:49:16] okay. do you see the bug? [19:50:19] yurikR: still not seeing W0 headers :( should it be taking this long? [19:50:43] MaxSem, no because I don' have any recent activity? I want to edit a page, but when I hit 'Random' in the menu, I'm taken to the main page [19:51:04] dbrant, no, should have worked right away - check if you browse to http://en.m.wikipedia.org - do you see banners? [19:51:20] (also try to navigate from privacy mode just in case) [19:51:48] yurikR: nope, don't see it [19:51:50] yup - because it's the only page [19:52:15] MaxSem, actually I can just use that page, I see the bug now. [19:52:32] dbrant, check your pub ip just in case, and try it from privacy mode (non -https just to be sure) [19:52:52] compare with how content pages are centered [19:53:26] yurikR: ah, non-https is showing correctly! [19:53:41] dbrant, ok, need to adjust settings than, sec [19:55:01] MaxSem, i guess the logic should be: if its m., always show images, if its zero., show images if user has show images [19:55:09] not user, config [19:55:13] MaxSem, I've fixed it. Should I push it for a review? [19:56:02] (03PS1) 10Yurik: Only hide images in zero-subdomain [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/162380 [19:56:09] MaxSem, ^ [19:56:11] yurikR, it shoud be like: if we would show an image warning to this user don't show the images? [19:56:21] bmansurov, yes please [19:57:06] 3Commons App / 3Android: My Uploads feature of Android App fetches its information from log - 10https://bugzilla.wikimedia.org/46839#c4 (10Rainer Rillke @commons.wikimedia) Instead of blindly? WONTFIXing everything, you could consider this feedback for the development of the native Wikipedia App. [20:00:14] MaxSem, if they are on m., they will see images regardless. If their "showImages" is set to true, even if they are on zero., that means they are also whitelisting m., which means we might as well show images - they are free [20:00:38] (03PS1) 10Bmansurov: Profile page content alignment fix Bug 69587 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162409 [20:00:45] so go ahead and +2 it ^^ [20:00:45] (03CR) 10MaxSem: [C: 032] Only hide images in zero-subdomain [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/162380 (owner: 10Yurik) [20:00:49] ah, ok [20:00:59] (03Merged) 10jenkins-bot: Only hide images in zero-subdomain [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/162380 (owner: 10Yurik) [20:01:16] dbrant, fixed https, should work shortly [20:01:40] kaldari|2, I've added you as a reviewer [20:03:00] (03CR) 10Brion VIBBER: "Yeah, this is an update of an older patch so it's no longer consistent. Will fix." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144846 (owner: 10Brion VIBBER) [20:03:35] yurikR: working! thanks [20:03:45] dbrant, np, sorry for the delay [20:03:50] legoktm, https://gerrit.wikimedia.org/r/#/c/160541/ :) [20:05:03] bmansurov you got gerrit working! :D [20:05:36] jdlrobson, ;) [20:06:21] this is good it lets me give you a few pointers and explain some of the mobile codebase :) [20:06:48] So firstly there is a neat trick with bugs [20:06:59] bmansurov: if you look @ https://bugzilla.wikimedia.org/show_bug.cgi?id=69587 you'll notice your patch isn't reported on it [20:07:42] (03CR) 10Kaldari: Hygiene: Add back button partial (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 (owner: 10Jdlrobson) [20:08:51] bmansurov: https://www.mediawiki.org/wiki/Mobile_web/Coding_conventions#Commit_Messages [20:10:10] jdlrobson, please go on [20:10:22] bmansurov: ok cool wasn't sure if you were still there :) [20:10:33] jdlrobson, yes I'm following you [20:10:38] so in the gerrit interface you can edit commit messages - no need to resubmit them [20:10:55] (edit icon is in top right corner next to permalink) [20:11:10] (03PS2) 10Bmansurov: Profile page content alignment fix Bug: 69587 Change-Id: I7f85e7c2a18e5d375ec328df5652378f0e92c6fa [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162409 (https://bugzilla.wikimedia.org/69587) [20:11:19] Sweet :) [20:11:31] you'll also need to add a line between Profile and Bug: [20:11:46] (03PS3) 10Bmansurov: Profile page content alignment fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162409 (https://bugzilla.wikimedia.org/69587) [20:11:52] although not documented we always add a line between subject and the description [20:12:02] ok [20:12:03] ok awesome :D [20:12:16] notice how abovve how @grrrit-wm is linking to the bug and the patch [20:12:20] that means you worked it out :) [20:12:56] jdlrobson, i see [20:13:02] ok so secondly never comment out lines of code in commits. just remove them! I guess that was a mistake? :-) [20:13:21] ok, let me resubmit [20:13:24] wait wait [20:13:30] ok [20:13:32] i wanted to talk about something else first :) [20:13:42] sure [20:13:57] okay so the mobile skin (called Minerva) is all mobile first [20:14:22] so what we tend to do is style first for mobile and then tweak it for tablets (which also gives a nicer experience for desktop users) [20:14:32] so the margin in the profile page is likely to be there for a reason [20:14:54] i thought this would be a good way to introduce you to @wgMFDeviceWidthTablet :) [20:15:12] so this is a configurable variable which basically means - your device has the minimum width to be considered a tablet [20:15:29] if you look at the bottom of the stylesheet you'll notice we have a bunch of css in a media query [20:15:44] yes [20:16:22] so the fix is correct in a way, but we should probably preserve the margin on mobile and just remove it on tablet/desktop [20:17:07] If you however think the margin is wrong and worth discussing you can also feel free to grab a designer and argue with them but for something so small it's probably not worth taking up their time [20:17:21] ok [20:18:15] i'm going to copy this on to the patch and -1 it. Although the -1 always looks nasty we use it quite heavily. You can read it as meaning "hey! i left you some comments" as gerrit doesn't have the best way of notifying you about changes :) [20:18:27] (03CR) 10Jdlrobson: [C: 04-1] Profile page content alignment fix (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162409 (https://bugzilla.wikimedia.org/69587) (owner: 10Bmansurov) [20:18:52] bmansurov: also pro-tip - if you run `make gerrit` on your command line in MobileFrontend it will give you a list of all the open patchsets [20:19:06] it will also allow you to checkout patches from gerrit [20:19:10] i personally prefer the interface to gerrit so use it heavily :) [20:19:29] (this will allow you to checkout your patch with the altered commit message to amend it) [20:19:56] if you submit the new patch i'll happily merge it and we can say you fixed your first bug :) [20:20:14] jdlrobson, make gerrit seems to use python2 but by default I have python3, how do I change make gerrit to use python2? [20:21:55] otherwise, I'm getting an error that reads: SyntaxError: invalid syntax [20:21:55] Makefile:22: recipe for target 'gerrit' failed [20:23:07] bmansurov, forget about this stuff [20:23:19] you can waste your time on it later:P [20:23:28] MaxSem, I made a change in the gerrit interface and would like to pull it [20:23:34] * MaxSem bites jdlrobson [20:23:56] yup, there's a UI way for this [20:24:15] can you tell me how? [20:24:24] bmansurov: okay the old fashioned way is to go to the page and next do download click the checkout tab [20:24:46] it says git fetch...&& git checkout [20:25:11] the `make gerrit` command was meant to prevent you from having to deal with that but we can work that out later :) [20:25:29] ok, so copy and run that command? [20:26:09] yup [20:26:41] also, who the hell uses python 3? :P [20:27:28] It's not my choice, it's default in arch [20:27:57] 2014090810022679 is about reading on a nokia e51. unclear if that's mobile site or desktop site. what's the state of support for symbian? [20:28:12] (they say their experience has regressed since a year ago) [20:28:25] (03PS4) 10Bmansurov: Profile page content alignment fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162409 (https://bugzilla.wikimedia.org/69587) [20:29:02] > I've read on line that this problem first started after changes made to the layout of wikipedia pages but was pleased to also read that this should be rectified shortly and you were aware of the problem. [20:29:37] jdlrobson, should I have kept the top margin for the tablet version? [20:29:59] jdlrobson, in case i have a question about the design, who should I contact? [20:30:09] jdlrobson, I mean which designer? [20:30:31] bmansurov: in this case i would advise it is not necessary [20:30:34] just remove it in the tablet mode [20:30:40] it appears to be an oversight [20:31:01] jeremyb, we can even crash some older symbians:P [20:31:02] jdlrobson, removed it and pushed [20:31:16] bmansurov: ok great. Next thing - you need to setup your text editor to notice whitespace [20:31:22] MaxSem: errr, ok. is this older? [20:31:32] the indentation is wrong. In mobile we use tab indents [20:31:33] no [20:31:48] jdlrobson, in less files only [20:31:49] but yeah, if it's symbian it should be properly detected as mobile and redirected to the mobile site [20:31:49] ? [20:32:04] everywhere [20:32:09] MaxSem: presumably it would be on the JS blacklist with IE6, etc. (or maybe it doesn't even have a JS engine?) [20:32:23] does mobile use the same JS blacklist as desktop? [20:32:23] OK [20:32:31] bmansurov: yup we use tabs everywhere https://www.mediawiki.org/wiki/Mobile_web/Coding_conventions#Indenting [20:32:37] jeremyb, I don't have OTRS access [20:33:37] mmm, year ago? [20:33:55] when we stopped serving WAP to many phones? :P:P:P [20:34:10] ohhh, maybe that's it [20:34:21] MaxSem: i could bounce it to you [20:35:16] bmansurov: taking a closer look that margin is necessary. [20:35:21] (in mobile) [20:36:08] MaxSem: and now i have [20:36:46] jdlrobson: because i read it know :) (https://www.mediawiki.org/wiki/Mobile_web/Coding_conventions#Indenting) is there a special reason why en.json uses spaces? :/ [20:37:00] FlorianSW: it's a good question. I believe there was a mail about this a while ago [20:38:02] jdlrobson: ah, ok, i will look for it sometime :) Because my favourite editor doesn't show any difference for this amount of spaces and tabs, so i always forget, that there are spaces :D [20:38:45] (03PS5) 10Bmansurov: Profile page content alignment fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162409 (https://bugzilla.wikimedia.org/69587) [20:38:50] FlorianSW: it's worth bringing up again on the mailing list [20:39:12] (03CR) 10Jdlrobson: [C: 032] Profile page content alignment fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162409 (https://bugzilla.wikimedia.org/69587) (owner: 10Bmansurov) [20:39:18] jhobs, around? [20:39:23] bmansurov: perfect :) [20:39:42] jdlrobson: yeah, will do it :) Would be great to be constistent there, too, if there is no special reason for it :) [20:39:44] (03Merged) 10jenkins-bot: Profile page content alignment fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162409 (https://bugzilla.wikimedia.org/69587) (owner: 10Bmansurov) [20:40:09] bmansurov: so now you can move the trello card to ready for signoff so maryana can check it [20:40:19] and well done on your first bug fix :) [20:40:27] jdlrobson, thanks to you guys [20:41:13] jdlrobson, i've updated the caard [20:41:18] bmansurov: so you've done a css fix maybe we should find you a js fix to look into? [20:41:30] (03CR) 10Florianschmidtwelzow: [C: 04-1] Make sure, issues only added once (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [20:41:52] jdlrobson, sure [20:42:03] bmansurov: looking for something that looks easy enough :) [20:42:10] jdlrobson, where other than my dev env can I see my change? [20:42:32] jdlrobson, is there a public url? [20:42:34] bmansurov: so i can't remember how often it happens but changes eventually get synced on to en.m.wikipedia.beta.wmflabs.org [20:42:40] ok [20:42:46] it might be a 10 minute lag from getting merged though [20:43:02] jdlrobson: have you seen this qunit: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/5067/console ??? It was triggered by a rebase, but the result looks unrelated for me :/ [20:43:09] jdlrobson, I need to create an account there too? [20:45:37] bmansurov: yap, new account for beta labs :) [20:46:14] FlorianSW, thanks [20:46:26] np :) [20:48:52] 3MobileFrontend / 3Feature requests: Special:History should work on desktop - 10https://bugzilla.wikimedia.org/64939#c5 (10Jon) Not to my knowledge. A while back action=history was ported to redirect to Special:History and that change got reverted so I'm also a bit concerned about interfering with any effort... [20:48:55] bmansurov: yeh you'll have to create an account [20:49:00] FlorianSW: will take a look in a minute [20:49:17] bmansurov: i'd suggest looking at bug https://bugzilla.wikimedia.org/show_bug.cgi?id=70078 [20:49:27] jdlrobson: no rush :) Just as a hint :) [20:49:32] i'm not sure if it's tricky or not but should be meaty enough that you can look into the JS code [20:49:51] ok [20:50:17] i'd also suggest starting with a qunit test [20:50:22] have you written qunit tests before? [20:50:45] (note this could be tricky so i'm expecting you'll need lots of my help so don't be afraid to ask if you need it :)) [20:51:22] bmansurov: i'm just running out for coffee but i'll be back in a bit :) [20:51:28] jdlrobson, yes I have [20:51:32] jdlrobson, sure [20:52:14] dbrant, does 2.0-beta-2014-09-18 include the fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=70834 ? [20:53:31] MaxSem, how do I add a nonexisting article to my watchlist? [20:54:03] dbrant, I ask because of https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7792494 [20:54:25] go to that page and click on the star icon [20:54:50] what page? [20:55:13] Krenair: yep, it should. bearND, can you confirm that? ^ [20:55:45] MaxSem, my local environment doesn't have any pages. How do I add one? [20:57:19] all right, it's the time you learn some MW basics:) [20:57:19] bmansurov: if you allow, that i scratch into: Just open a non existing page in MF :) E.g. localhost/index.php/TestWatchstar?mobileaction=toggle_view_mobile [20:57:36] sry MaxSem :/ [20:58:05] bmansurov, try at least skimming through https://www.mediawiki.org/wiki/Help:Contents [20:58:22] FlorianSW, that wasn't for you [20:58:39] FlorianSW, thanks [20:58:46] MaxSem: no :P i mean sorry, that i interruppt your conversation :) [21:00:39] dbrant, by the way, the link to a testing APK we were giving out to try to fix the handleStopActivity NPE stuff, is that still relevant? [21:01:45] Krenair: technically yes, but based on the dearth of responses that we've gotten, I've all but given up... [21:06:50] MaxSem, I'm not able to reproduce the bug. I can't add a nonexisting page to my watchlist. The backend responds by saying pageid = 0; missing ="". This is the URL I tried: http://127.0.0.1:8080/wiki/Ddda [21:07:28] (03PS1) 10Kaldari: Make sure WikiGrok more info overlay doesn't interfere with search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162466 (https://bugzilla.wikimedia.org/71158) [21:07:28] FlorianSW, is the URL you gave for mediawiki? The backend returns an error when I open that url [21:08:00] Deskana|Away: i'm enjoying the TOC popup while scrolling like a mad man in the beta [21:09:08] bamnsurov: are you in mobile view? I can reproduce it only there, after this i have a "No exist" entry in my watchlist :) [21:09:30] FlorianSW, Yes I am [21:09:33] tfinc: it seems like opinions are polarized about that one. (I like it myself) [21:09:34] bmansurov: This should be "enough" to test this :) Alternatively you can create a new page, add it to your watchlist and delete it then :) [21:09:41] bmansurov, t's brokn indeed. do that from desktop :] [21:09:50] MaxSem, ok [21:09:55] FlorianSW, thanks for the workaround [21:10:03] bmansurov: np :D [21:11:51] (03CR) 10Kaldari: [C: 032] Hygiene: Remove unused icon files and rules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161990 (owner: 10Jdlrobson) [21:12:54] kristenlans: Are you free at 4pm my time? [21:13:39] kristenlans: I'm chatting to Monte about something which I need your input on. [21:13:49] kristenlans: I'm thinking we should hop in the batcave! [21:15:05] kristenlans: Or we can find some time tomorrow. [21:15:09] (03Merged) 10jenkins-bot: Hygiene: Remove unused icon files and rules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161990 (owner: 10Jdlrobson) [21:15:09] 3MobileFrontend / 3stable: Can't watchlist nonexistent pages - 10https://bugzilla.wikimedia.org/71199 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3None Upon clicking on star icon on such pages, UI claims that watchlisting succeeded but it didn't. [21:15:34] Batcave! [21:15:37] 3MobileFrontend / 3stable: Can't watchlist nonexistent pages - 10https://bugzilla.wikimedia.org/71199#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/LnH6oo7v [21:16:06] Deskan: I’m inthe batcave [21:16:15] ^ Deskana [21:20:34] (03PS2) 10Kaldari: Hygiene: Use core mediawiki ui colors where possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161991 (owner: 10Jdlrobson) [21:21:12] (03CR) 10Florianschmidtwelzow: Make sure, issues only added once (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [21:21:22] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use core mediawiki ui colors where possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161991 (owner: 10Jdlrobson) [21:21:36] (03PS3) 10Florianschmidtwelzow: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) [21:21:58] (03CR) 10Florianschmidtwelzow: [C: 04-1] "needs tests" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [21:22:28] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161991 (owner: 10Jdlrobson) [21:22:41] (03CR) 10jenkins-bot: [V: 04-1] Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [21:23:14] (03CR) 10Kaldari: [C: 032] Hygiene: Use core mediawiki ui colors where possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161991 (owner: 10Jdlrobson) [21:23:43] tfinc: Heh, yes. We need to take that out. :-p [21:23:54] bmansurov: did you manage to replicate the issue? [21:23:55] Deskana: how come ? [21:24:04] jdlrobson, yes [21:24:22] awesome. [21:24:23] jdlrobson, where is the Page.js located at? [21:24:23] tfinc: Most of the people I showed it to said "You need to fix that bug". [21:24:30] kaldari|2 is there a way to trigger a recheck for a gerrit change?! [21:24:33] tfinc: It hasn't really worked, people think it's just broken. [21:24:38] bmansurov: okay so let me talk about the JS directory structure [21:24:47] so we have a modules, specials and common folder under javascript [21:24:51] FlorianSW: Yes, just leave a review comment that says 'recheck' [21:25:12] All the things in common are reusable UI components we use across the site. [21:25:12] kaldari|2: so easy, yes? Thanks :D [21:25:19] and utility libraries [21:25:23] (03CR) 10Florianschmidtwelzow: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [21:25:41] Page.js is an example of a common component as it is not tied to a specific feature [21:25:47] thus it lives in the common folder [21:26:13] jdlrobson, i see [21:26:53] bmansurov: another way to look at it is most of the common components are loaded on startup [21:27:09] ok [21:27:12] if something isn't needed straight away, for example the editing interface which is only needed when you click edit it's a module [21:27:23] (the specials folder is for Special pages but we will come to that later) [21:27:39] (03Merged) 10jenkins-bot: Hygiene: Use core mediawiki ui colors where possible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161991 (owner: 10Jdlrobson) [21:27:59] jdlrobson, thanks [21:28:23] (03PS1) 10Florianschmidtwelzow: Use tabs instead of spaces in en.json [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162472 [21:28:48] jdlrobson, I was able to figure out why this happening, but I'm not sure how to fix it. [21:28:51] disclaimer: the watchstar is a bit of a weird one - it started off as a module as the watchstar but might be better as a common component now as it is used in multiple places. [21:29:10] bmansurov: how is it happening? Can you explain? [21:29:20] * jdlrobson hasn't looked into the bug so has no idea [21:29:23] 3MobileFrontend / 3stable: Useprofile page left aligned rather than centered in tablet view - 10https://bugzilla.wikimedia.org/69587 (10Jon) 5PATC>3RESO/FIX [21:29:28] jdlrobson, so missing pages are returned with an ID of 0, and there is no property of 'watched', thus the check for 'watched' always returns false [21:29:36] ahh i see [21:29:45] so this is something returned by the API ? [21:29:46] it's in the WatchstarApi.js line 17 [21:29:58] * jdlrobson looks [21:30:01] jdlrobson, yes the API doesn't say that the missing page is watched [21:30:03] (03CR) 10Florianschmidtwelzow: "Info: https://lists.wikimedia.org/pipermail/mobile-l/2014-September/008080.html" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162472 (owner: 10Florianschmidtwelzow) [21:30:54] bmansurov: interesting [21:31:20] bmansurov: so i'd recommend you write a test for WatchstarApi [21:31:26] vbamba: I've got some layout changes in nearby I'd like to show you. Do you want to hangout? [21:31:31] that returns a json with id 0 and no watched property [21:31:33] Deskana: so when you say it doesn't work do you mean that users who don't know about the TOC doesn't find it when it pops out while the article is scrolling quickly ? [21:31:55] jdlrobson, ok [21:32:13] bmansurov: usually when something involves the api I pull in MaxSem [21:32:24] BEWARE [21:32:29] jdlrobson, he's been helping me with everything [21:32:40] it might be that we need to change how we query the API or we will have to raise a bug and work around it [21:32:41] jdlrobson: If https://gerrit.wikimedia.org/r/162145/ is fine now I'll fix up the others too [21:32:53] prtksxna: will take a look before end of the day :) [21:33:09] jdlrobson: (y) [21:33:15] ok [21:33:52] bmansurov: so I'm guessing the correct behaviour here should be to assume it is watched if the id is 0 [21:33:55] jdlrobson: btw, that was a thumbs up emoticon, I don't know how, but I know it is :P [21:34:07] noooo [21:34:20] the id is 0 when the page doesn't exist [21:34:32] MaxSem: how would we deal with pages without an id? [21:34:39] it doesn't speak anything about watched status [21:34:59] awjr are you hangin with us for debrief? [21:35:06] jdlrobson, i'm not sure because the list may contain not watched pages [21:35:11] jdlrobson, maybe not [21:35:14] tfinc: They find it, but it looks like a bug to them that part of the interface is popping out. [21:35:20] MaxSem: but based on how we are using the api it might be enough to assume [21:35:32] we only ever call it when we have pages on the watchlist but yes it is a hack :) [21:35:32] tfinc: It doesn't achieve its goal of "Expose users to the ToC" because they think it's a bug and don't understand what's happening. [21:35:46] actually wait.. your right [21:36:08] 3Wikipedia App / 3iOS App: App should allow pinch and zoom of article content (REDUX) - 10https://bugzilla.wikimedia.org/71004#c1 (10Brion Vibber) Per our internal discussion this is probably something we can reenable, but need to test to make sure things don't explode with the other gestures in use. [21:36:14] i'm guessing there is another issue here which is that you can't unwatch the page [21:36:32] makes sense [21:36:34] as we exclusively use id rather than title :-S [21:36:40] 3Wikipedia App / 3iOS App: iOS app table of contents icon is wrong in RTL interfaces - 10https://bugzilla.wikimedia.org/70491#c5 (10Brion Vibber) 5PATC>3RESO/FIX This should be fixed in the next store release if it's not in the current one (I forget which made it into what) [21:36:41] you can't watch them either [21:37:00] MaxSem: can you use pageids as well as titles? [21:37:08] for? [21:37:21] well the reason we use ids is to minimise the http request url length [21:37:21] jdlrobson, MaxSem so we need to hide the watch button on non-existing pages? [21:37:34] bmansurov: not quite sure what the best thing to do here is yet [21:37:41] bmansurov: the api allows you to pass title's instead of ids [21:37:50] we might have to rethink how we do that [21:37:51] also, didn't I write ApiSandbox so that you could answer these questions yourself? ;) [21:37:55] 3Wikipedia App / 3iOS App: iOS 8: ToC zoom-out effect buggy on iOS 8 beta 5 - 10https://bugzilla.wikimedia.org/68536#c2 (10Brion Vibber) 5NEW>3RESO/FIX Monte got this worked out. [21:38:02] bmansurov: it's possible this is more complicated than i originally thought [21:38:10] bmansurov, no, we need to fix it [21:38:11] jdlrobson, looks like so [21:38:13] MaxSem: i'm still waiting for API2 ;-) "Cannot use 'pageids' at the same time as 'titles'" [21:38:24] bmansurov: you should update the bug report to explain your findings though [21:38:28] MaxSem, where is ApiSandbox? [21:38:30] it helps us keep a record of these things [21:38:35] use only titles [21:38:35] jdlrobson, ok [21:38:40] Deskana: got it [21:38:54] bmansurov, SPecial:ApiSandbox [21:39:02] MaxSem, ok thanks [21:39:11] tfinc: Rapid iteration and experimentation success, as far as I'm concerned. Tried it, didn't work, that's okay! [21:39:24] Deskana: k, move on and try again [21:41:48] bmansurov: i would advise dropping working on this bug for the time being - it's a bit of an unexpected rabbit hole, but knowing what the problem is is very helpful :) [21:42:07] jdlrobson, sure, I'll just update the card [21:42:10] (03CR) 10Kaldari: [C: 04-1] Hygiene: Move logic for rendering WikiGrokPanel out of Panel itself (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162130 (owner: 10Jdlrobson) [21:42:19] thanks bmansurov :) you can come back to that one later ;-) [21:43:01] (03PS1) 10BearND: Nearby styling updates [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162475 [21:43:48] jdlrobson, I've left a comment, what would you suggest I work on next? [21:44:18] bmansurov: i'm taking a look at the backlog as we speak :) [21:44:26] ok thanks [21:45:01] bmansurov: i would suggest this one - https://trello.com/c/n9jdWFzS [21:45:10] ok [21:45:44] it should be just adding a class but it will at least give you an idea of how our overlay code works [21:47:09] 3Commons App / 3Android: My Uploads feature of Android App fetches its information from log - 10https://bugzilla.wikimedia.org/46839#c5 (10Andre Klapper) Except that this ticket was a request for the Commons App and hence the situation is correctly reflected. :) Plus WONTFIXing this ticket does not stop any... [21:48:21] bmansurov: have you got a bugzilla account yet? [21:48:38] jdlrobson, no, not yet [21:48:48] I'll create one soon [21:49:46] bmansurov: i updated the bug report with your comment -> https://bugzilla.wikimedia.org/show_bug.cgi?id=70078 [21:49:52] 3MobileFrontend / 3stable: mobile watchlist shows deleted articles in the full list with a white star - 10https://bugzilla.wikimedia.org/70078#c3 (10Jon) Bahodir did some investigation into this. Here's what he discovered: "My findings so far: 1. You can only watch a non-existent page in the destop version... [21:50:17] jdlrobson, so if I leave a comment in the card, should I update the bug report too? [21:50:18] the bugs are more visible to volunteers such as florian so we tend to do discussion on bugs in bugzilla and just use trello for discussing stories [21:50:29] oh my, things are moving to ready for signoff soooo quickly now [21:50:33] \o/ [21:51:16] jdlrobson, ok [21:51:17] (03PS2) 10Jdlrobson: Hygiene: Use tabs instead of spaces in en.json [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162472 (owner: 10Florianschmidtwelzow) [21:51:36] (03PS3) 10Jdlrobson: Hygiene: Use tabs instead of spaces in en.json [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162472 (owner: 10Florianschmidtwelzow) [21:52:06] (03CR) 10Jdlrobson: [C: 032] "Awesome! Merging before we hit a rebase issue :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162472 (owner: 10Florianschmidtwelzow) [21:52:36] (03Merged) 10jenkins-bot: Hygiene: Use tabs instead of spaces in en.json [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162472 (owner: 10Florianschmidtwelzow) [21:53:34] jdlrobson, there is another card for this: https://trello.com/c/GPO0AywX/27-bug-69111-too-long-image-descriptions-ruin-the-mobile-media-viewer [21:53:45] jdlrobson, nm it's archived [21:54:58] jdlrobson, how can I see the url in question in my dev environment? [21:55:20] upload a file, add it to a page with a long description [21:55:25] bmansurov, ^ [21:55:36] (03PS5) 10Jdlrobson: Optimise galleries on mobile and tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161364 (https://bugzilla.wikimedia.org/70684) [21:55:42] MaxSem, ok thanks [22:03:07] MaxSem, I'm unable to upload a file. Here is the error: http://pastebin.com/PwqCsW59 [22:04:05] try setting mediawiki/images and its subs to 777 [22:06:03] MaxSem, it didn't help [22:08:21] bmansurov: there is a cheat you can do here [22:08:43] $wgUseInstantCommons = true; [22:08:47] put that in your LocalSettings.php [22:08:56] it will allow you to use images from commons on your local wiki [22:09:17] jdlrobson, ok thanks [22:09:32] bmansurov: to follow MaxSem's advice ensure you do it in vagrant e.g. vagrant ssh [22:09:38] (03PS1) 10Brion VIBBER: Fix for share button on iPad [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/162480 (https://bugzilla.wikimedia.org/71189) [22:09:53] jdlrobson, ohh i see [22:10:07] jdlrobson, InstantCommons also uses mw/images ;) [22:10:36] (03PS4) 10Jdlrobson: Hygiene: Make more info dialog reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162129 [22:11:08] MaxSem, can you give me the full path to mediawiki/images? [22:11:36] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make more info dialog reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162129 (owner: 10Jdlrobson) [22:11:37] MaxSem, I did vagrant ssh [22:11:38] (03PS4) 10Jdlrobson: Hygiene: Move logic for rendering WikiGrokPanel out of Panel itself [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162130 [22:11:48] do it from vagrant (vagrant ssh). there, /vagrant/mediawiki/images [22:11:50] (03PS5) 10Jdlrobson: Hygiene: Make more info dialog reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162129 [22:12:01] (03PS5) 10Jdlrobson: Hygiene: Move logic for rendering WikiGrokPanel out of Panel itself [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162130 [22:12:09] (03PS3) 10Jdlrobson: Hygiene: Create WikiDataApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162131 [22:12:18] (03PS3) 10Jdlrobson: Hygiene: Introduce WikiGrokApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162132 [22:12:24] (03PS3) 10Jdlrobson: Hygiene: Add recordOccupation method to WikiGrokApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162133 [22:12:26] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make more info dialog reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162129 (owner: 10Jdlrobson) [22:12:33] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Move logic for rendering WikiGrokPanel out of Panel itself [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162130 (owner: 10Jdlrobson) [22:12:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Create WikiDataApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162131 (owner: 10Jdlrobson) [22:12:56] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce WikiGrokApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162132 (owner: 10Jdlrobson) [22:13:08] 3Wikipedia App / 3iOS App: iOS App: If a page is saved, I can save it again and again - 10https://bugzilla.wikimedia.org/65107#c2 (10Brion Vibber) 5NEW>3RESO/FIX We've moved the save button out of the share action to its own state-based button, so clicking again toggles the save state (and the appearance... [22:13:36] (03PS6) 10Jdlrobson: Hygiene: Make more info dialog reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162129 [22:14:10] (03PS2) 10Jdlrobson: Switch to using $.inArray instead of indexOf for arrays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162176 (https://bugzilla.wikimedia.org/70963) [22:14:40] (03CR) 10jenkins-bot: [V: 04-1] Switch to using $.inArray instead of indexOf for arrays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162176 (https://bugzilla.wikimedia.org/70963) (owner: 10Jdlrobson) [22:15:34] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Add recordOccupation method to WikiGrokApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162133 (owner: 10Jdlrobson) [22:24:30] jdlrobson: would like to get this merged for a deployment branch to push out before the demo: https://gerrit.wikimedia.org/r/#/c/162466/ [22:26:25] 3MobileFrontend / 3stable: Inconsistency: Editor uses back icon for closing overlay, talk uses X - 10https://bugzilla.wikimedia.org/71203 (10Jon) 3NEW p:3Unprio s:3normal a:3None The editor uses a back button (<-) to close the overlay. This is inconsistent from the talk overlay and the search overlay... [22:27:16] (03PS3) 10Jdlrobson: Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 [22:27:59] (03CR) 10Jdlrobson: [C: 032] Make sure WikiGrok more info overlay doesn't interfere with search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162466 (https://bugzilla.wikimedia.org/71158) (owner: 10Kaldari) [22:28:32] (03Merged) 10jenkins-bot: Make sure WikiGrok more info overlay doesn't interfere with search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162466 (https://bugzilla.wikimedia.org/71158) (owner: 10Kaldari) [22:28:49] bmansurov: how are things going? [22:29:03] did you get images working on your local wiki? [22:29:40] jdlrobson, yes I did, i'm learning about the overlay [22:30:06] perfect. Don't be too scared about it - it's probably our most complicated piece of code lol [22:30:27] but essentially we have this thing called an OverlayManager that we use to bind hash fragments in the URL to a type of overlay [22:30:31] the manager controls showing and hiding it [22:30:33] jdlrobson, I can't seem to figure out in which file the description is being used [22:30:50] ok [22:31:08] 3MobileFrontend / 3stable: Inconsistency: Editor uses back icon for closing overlay, talk uses X - 10https://bugzilla.wikimedia.org/71203#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/VdKb5Ris [22:31:15] bmansurov: so when you click on the image you'll notice the URL changes to #/image/File:.jpg [22:31:30] <MaxSem> bmansurov, [[File:<name>|longlonglong description here]] [22:31:32] <bmansurov> yes [22:32:11] <jdlrobson> bmansurov: if you grep for \/image\/ (part of the regex that is likely to match that) you will find the entry point into the code [22:32:15] <grrrit-wm> (03PS7) 10Kaldari: Hygiene: Make more info dialog reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162129 (owner: 10Jdlrobson) [22:32:39] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Hygiene: Make more info dialog reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162129 (owner: 10Jdlrobson) [22:32:52] <bmansurov> ok [22:33:13] <grrrit-wm> (03Merged) 10jenkins-bot: Hygiene: Make more info dialog reusable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162129 (owner: 10Jdlrobson) [22:34:41] <grrrit-wm> (03PS6) 10Kaldari: Hygiene: Move logic for rendering WikiGrokPanel out of Panel itself [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162130 (owner: 10Jdlrobson) [22:37:36] <jdlrobso_> bmansurov: maybe thursday after you've had a chance to tackle a few bugs and work your way through the codebase we should sit down and i can go through the code in detail and you can ask me any questions [22:37:39] <jdlrobso_> would that be useful? [22:38:17] <bmansurov> jdlrobso_, yes! [22:38:22] <bmansurov> that's a great idea [22:38:38] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Hygiene: Move logic for rendering WikiGrokPanel out of Panel itself [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162130 (owner: 10Jdlrobson) [22:38:39] <jdlrobso_> bmansurov: i'll setup a meeting [22:38:51] <jdlrobso_> i think it's useful for you to prod around the code first though :-) [22:38:52] <bmansurov> ok thanks [22:39:01] <MaxSem> can someone review https://gerrit.wikimedia.org/r/#/c/161498/ please? [22:39:43] <jdlrobso_> bmansurov: we have the quarterly review thursday so would you be okay with straight after it? [22:40:00] <grrrit-wm> (03Merged) 10jenkins-bot: Hygiene: Move logic for rendering WikiGrokPanel out of Panel itself [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162130 (owner: 10Jdlrobson) [22:40:05] <bmansurov> jdlrobso_, sure [22:41:18] <grrrit-wm> (03CR) 10Kaldari: [C: 04-1] Optimise galleries on mobile and tablets (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161364 (https://bugzilla.wikimedia.org/70684) (owner: 10Jdlrobson) [22:44:18] <jdlrobso_> bmansurov: setup. hope time is okay :-S [22:44:32] <grrrit-wm> (03PS3) 10Jdlrobson: Switch to using $.inArray instead of indexOf for arrays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162176 (https://bugzilla.wikimedia.org/70963) [22:44:43] <bmansurov> jdlrobso_, perfect [22:45:54] <grrrit-wm> (03PS6) 10Jdlrobson: Optimise galleries on mobile and tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161364 (https://bugzilla.wikimedia.org/70684) [22:45:55] <jdlrobso_> ^ kaldari|2 [22:45:58] <jdlrobso_> MaxSem: looking [22:46:37] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Optimise galleries on mobile and tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161364 (https://bugzilla.wikimedia.org/70684) (owner: 10Jdlrobson) [22:48:17] <bmansurov> jdlrobso_, I made a fix and am trying to push for a review, but git is asking if I want to submit my previous commit too. How can I only push the latest commit for a review? [22:48:48] <grrrit-wm> (03Merged) 10jenkins-bot: Optimise galleries on mobile and tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161364 (https://bugzilla.wikimedia.org/70684) (owner: 10Jdlrobson) [22:52:39] <grrrit-wm> (03PS1) 10Kaldari: Wikigrok: Make query string override reset the opt out [extensions/MobileFrontend] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162493 [22:52:41] <grrrit-wm> (03PS1) 10Kaldari: Make sure WikiGrok more info overlay doesn't interfere with search [extensions/MobileFrontend] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162494 (https://bugzilla.wikimedia.org/71158) [22:53:04] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Wikigrok: Make query string override reset the opt out [extensions/MobileFrontend] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162493 (owner: 10Kaldari) [22:53:16] <grrrit-wm> (03CR) 10Kaldari: [C: 032] Make sure WikiGrok more info overlay doesn't interfere with search [extensions/MobileFrontend] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162494 (https://bugzilla.wikimedia.org/71158) (owner: 10Kaldari) [22:57:28] <grrrit-wm> (03Merged) 10jenkins-bot: Wikigrok: Make query string override reset the opt out [extensions/MobileFrontend] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162493 (owner: 10Kaldari) [22:57:30] <grrrit-wm> (03Merged) 10jenkins-bot: Make sure WikiGrok more info overlay doesn't interfere with search [extensions/MobileFrontend] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/162494 (https://bugzilla.wikimedia.org/71158) (owner: 10Kaldari) [22:58:37] <wikibugs> 3MobileFrontend / 3beta: Wikigrok styling impacts search - 10https://bugzilla.wikimedia.org/71158 (10Jon) 5PATC>3RESO/FIX [23:01:22] <wikibugs> 3MobileFrontend / 3stable: Talk button has horrible hover effect on Special:UserProfile - 10https://bugzilla.wikimedia.org/70947#c2 (10Jon) 5NEW>3RESO/WOR This doesn't appear to be happening anymore. [23:01:46] <kaldari|2> bmansurov: had to go to some meetings and get a deployment branch ready. Have Jon and Max kept you busy with stuff to work on? [23:02:44] <bmansurov> kaldari|2, yes, we've been working on some bugs [23:03:12] <kaldari|2> bmansurov: That's a bug with git review, you can either do 'git fetch --all' first, or just ignore it and say 'Yes'. It will only actually submit the latest change. [23:03:27] <bmansurov> kaldari|2, cool [23:03:31] <grrrit-wm> (03PS1) 10Bmansurov: Add 'truncated-text' class to image description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162498 (https://bugzilla.wikimedia.org/69111) [23:08:39] <wikibugs> 3MobileFrontend / 3stable: Watchlist doesn't redirect to login on mobile - 10https://bugzilla.wikimedia.org/71206 (10Jon) 3NEW p:3Unprio s:3normal a:3None Visit http://en.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist (desktop) and you are redirected to the login form. Do the same on mobile and no... [23:10:23] <wikibugs> 3MobileFrontend / 3stable: Watchlist doesn't redirect to login on mobile - 10https://bugzilla.wikimedia.org/71206#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/xJw5Qr3s [23:15:41] <mhurd> brion: checkout the “uikit extensions” at bottom: https://github.com/AFNetworking/AFNetworking/wiki/AFNetworking-2.0-Migration-Guide [23:16:35] <brion> niiiiiice [23:19:05] <grrrit-wm> (03PS1) 10Dbrant: Added callback listener for checking response headers. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/162503 [23:19:29] <grrrit-wm> (03PS1) 10Dbrant: Factor out Wikipedia Zero code into its own module. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162504 [23:21:23] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Factor out Wikipedia Zero code into its own module. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162504 (owner: 10Dbrant) [23:21:25] <grrrit-wm> (03PS2) 10Dbrant: Added callback listener for checking response headers. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/162503 [23:24:57] <grrrit-wm> (03PS2) 10Dbrant: Factor out Wikipedia Zero code into its own module. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162504 [23:25:35] <jdlrobso_> prtksxna: around? [23:28:37] <mhurd> brion: was this page: https://github.com/AFNetworking/AFNetworking/wiki/Getting-Started-with-AFNetworking [23:31:56] <grrrit-wm> (03PS8) 10BearND: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [23:32:07] <wikibugs> 3MobileFrontend / 3stable: galleries appear misaligned on mobile tablet or mobile desktop - 10https://bugzilla.wikimedia.org/70684 (10Jon) 5PATC>3RESO/FIX [23:35:27] <jdlrobso_> bmansurov: did you need another bug? :) [23:35:27] <bmansurov> jdlrobso_, sure [23:35:55] <MaxSem> haaaahaaaaa https://gerrit.wikimedia.org/r/#/c/162505/1/docroot/bits/DolphinBrowser/wikis.json [23:36:31] <prtksxna> jdlrobso_: https://gerrit.wikimedia.org/r/#/c/162509/1 [23:36:42] <grrrit-wm> (03CR) 10Jdlrobson: [C: 04-1] Add 'truncated-text' class to image description (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162498 (https://bugzilla.wikimedia.org/69111) (owner: 10Bmansurov) [23:37:56] <jdlrobso_> bmansurov: problem with your patchset ^ [23:37:58] <prtksxna> jdlrobso_: https://gerrit.wikimedia.org/r/#/c/162145/4/includes/specials/SpecialBooksources.php [23:39:20] <bmansurov> jdlrobso_, great [23:40:13] <prtksxna> jdlrobso_: https://gerrit.wikimedia.org/r/#/c/162509/ [23:40:47] <grrrit-wm> (03CR) 10BearND: Make page browsing into a Fragment. (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [23:41:32] <kaldari|2> MaxSem: If you could SWAT deploy this, it would be awesome: https://gerrit.wikimedia.org/r/#/c/162510/ [23:42:10] <bearND> Hi vbamba. I sent you a screenshot with the Nearby layout changes. [23:42:21] <jdlrobso_> bmansurov: you could take a look at https://trello.com/c/4meh4lhV/45-2-detect-retina-display-support-for-mobile-picture-shower next [23:42:32] <bmansurov> jdlrobso_, ok [23:43:52] <grrrit-wm> (03PS2) 10Bmansurov: Add 'truncated-text' class to image description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162498 (https://bugzilla.wikimedia.org/69111) [23:45:24] <wikibugs> 3MobileFrontend / 3Feature requests: Option labels on the mobile preferences page can be too long - 10https://bugzilla.wikimedia.org/61114#c11 (10Jon) 5NEW>3RESO/WOR This doesn't appear to be a problem anymore now we use mw-ui-checkbox [23:45:40] <wikibugs> 3MobileFrontend / 3Feature requests: Option labels on the mobile preferences page can be too long - 10https://bugzilla.wikimedia.org/61114#c12 (10Jon) Created attachment 16570 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16570&action=edit Problem not present with mw-ui-checkbox [23:47:52] <grrrit-wm> (03CR) 10Jdlrobson: [C: 032] Add 'truncated-text' class to image description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162498 (https://bugzilla.wikimedia.org/69111) (owner: 10Bmansurov) [23:48:26] <grrrit-wm> (03Merged) 10jenkins-bot: Add 'truncated-text' class to image description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162498 (https://bugzilla.wikimedia.org/69111) (owner: 10Bmansurov) [23:52:36] <bmansurov> jdlrobso_, what's the Picture Shower? [23:54:21] <prtksxna> jdlrobso_: https://gerrit.wikimedia.org/r/#/c/162512/ [23:56:57] <Krenair> bearND, is location access used for anything other than the 'Nearby' feature? [23:59:19] <Deskana> bearND: No. :) [23:59:24] <Deskana> Krenair: ^