[00:00:32] Krenair: what Deskana said [00:00:46] (03PS1) 10Jdlrobson: Use inline-block rather than floating [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162513 [00:01:10] bmansurov: picture shower is the mediaviewer [00:01:17] ImageOverlay [00:01:29] I don't know why its referred to in that card as picture shower lol :) [00:01:45] ok, replied to that query. nice work on that feature by the way [00:14:07] (03PS10) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) [00:14:12] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [00:14:32] bmansurov: i'm heading off soon anything you need from me before i go? [00:14:48] jdlrobso_, no I'm good. I'm going to push a fix soon [00:14:52] 3MobileFrontend / 3stable: Too long image descriptions ruin the mobile media viewer - 10https://bugzilla.wikimedia.org/69111 (10Jon) 5PATC>3RESO/FIX [00:15:16] bmansurov: if you run out of stuff to do and need more feel free to check out the must have column at https://trello.com/b/TInnSh9E/mobile-web-q1-backlog-2014-2015 [00:15:25] jdlrobso_, ok [00:19:40] bmansurov: good luck and see you tomorrow :D [00:26:22] (03PS1) 10Bmansurov: Detect retina displays and load the image in the correct size. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162517 [00:30:06] (03CR) 10MaxSem: Detect retina displays and load the image in the correct size. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162517 (owner: 10Bmansurov) [00:31:06] (03PS2) 10Kaldari: Use inline-block rather than floating [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162513 (owner: 10Jdlrobson) [00:31:28] (03PS2) 10Bmansurov: Detect retina displays and load the image in the correct size. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162517 [00:31:40] (03CR) 10Kaldari: [C: 032] Use inline-block rather than floating [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162513 (owner: 10Jdlrobson) [00:33:06] (03Merged) 10jenkins-bot: Use inline-block rather than floating [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162513 (owner: 10Jdlrobson) [00:52:22] 3MobileFrontend / 3stable: Can't watchlist nonexistent pages - 10https://bugzilla.wikimedia.org/71199#c2 (10Jon) 5NEW>3RESO/DUP it's the same bug. fixing one will fix the other *** This bug has been marked as a duplicate of bug 70078 *** [00:52:22] 3MobileFrontend / 3stable: mobile watchlist shows deleted articles in the full list with a white star - 10https://bugzilla.wikimedia.org/70078#c4 (10Jon) *** Bug 71199 has been marked as a duplicate of this bug. *** [00:53:38] Hmm. [00:53:50] We apparently have a Android beta push taking place on Sunday at 1am. [00:53:53] Somehow I doubt this is happening. [00:54:00] (03CR) 10Jdlrobson: "looks good but I wonder if it should default to 2? will test later." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162517 (owner: 10Bmansurov) [00:54:56] (03CR) 10Jdlrobson: [C: 031] "oh wait.. I reread the card ;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162517 (owner: 10Bmansurov) [07:23:52] (03PS3) 10Florianschmidtwelzow: Hygiene: Manage z-index with less variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) [07:24:32] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Manage z-index with less variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) (owner: 10Florianschmidtwelzow) [07:25:54] (03PS4) 10Florianschmidtwelzow: Hygiene: Manage z-index with less variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) [09:38:25] 3Wikipedia App / 3iOS App: in the iOS app, the main-menu-account-logout message should display the username differently - 10https://bugzilla.wikimedia.org/71225 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Currently, the main-menu-account-logout message only has the words "Log out" and not th... [10:59:33] (03CR) 10Alex Monk: "This commit broke the checkbox showing at all on my device. Given that it's used to indicate whether or not usage reports are sent and war" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159735 (https://bugzilla.wikimedia.org/70719) (owner: 10Dbrant) [11:03:39] 3Wikipedia App / 3Android App: Checkboxes for important options (usage report, leaving-Zero warnings) are missing - 10https://bugzilla.wikimedia.org/71228 (10Alex Monk) 3NEW p:3Unprio s:3major a:3None Seems to be caused by Gerrit change 159735 (bug 70719) [11:04:39] 3Wikipedia App / 3Android App: Checkboxes for important options (usage report, leaving-Zero warnings) are missing - 10https://bugzilla.wikimedia.org/71228 (10Alex Monk) [11:04:39] 3Wikipedia App / 3Android App: Items in the "More" menu appear cut-off on low-res screens. - 10https://bugzilla.wikimedia.org/70719#c3 (10Alex Monk) 5PATC>3RESO/FIX Assuming this is resolved, opened bug 71228 though. [11:04:50] (03CR) 10Alex Monk: "(Opened bug 71228)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159735 (https://bugzilla.wikimedia.org/70719) (owner: 10Dbrant) [11:21:09] 3Wikipedia App / 3Android App: Icons appear incorrectly for empty state of Saved/ Recent/ Nearby - 10https://bugzilla.wikimedia.org/70745#c3 (10Alex Monk) 5PATC>3RESO/FIX Seems to have been fixed... [11:33:52] 3Wikipedia App / 3Android App: Some links clicked from Disambiguation dialog don't work. - 10https://bugzilla.wikimedia.org/70769#c3 (10Alex Monk) 5PATC>3RESO/FIX Seems fixed. [11:39:53] 3Wikipedia App / 3Android App: new ToC icon is too dark in dark mode - 10https://bugzilla.wikimedia.org/70689#c3 (10Alex Monk) 5PATC>3RESO/FIX Assuming this is fixed, marking as such. [11:41:37] 3Wikipedia App / 3Android App: "Maximum call stack size exceeded" in javascript bridge - 10https://bugzilla.wikimedia.org/69700#c3 (10Alex Monk) Is this fixed now? [11:44:37] 3Wikipedia App / 3Android App: Tapping on backlinks (^) in reference list shows a popup with only a [#] link in it - 10https://bugzilla.wikimedia.org/69965#c3 (10Alex Monk) 5PATC>3RESO/FIX Sounds like this was fixed then. [11:52:06] 3Wikipedia App / 3Android App: screen flickers when scrolling down for the first time on page - 10https://bugzilla.wikimedia.org/69754#c7 (10Alex Monk) Is this fixed now? [11:57:06] 3Wikipedia App / 3Android App: Android app flashes on page load - 10https://bugzilla.wikimedia.org/69863#c4 (10Alex Monk) Was this fixed? [12:22:53] 3Wikipedia App / 3Android App: Crash caused by pressing Retry button on connection issue error - 10https://bugzilla.wikimedia.org/70834#c5 (10Alex Monk) But is it really? https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7792494 reports what appears to be the same stack trace again... [13:21:31] (03PS1) 10Yuvipanda: [WIP] Add xxxhdpi resolution [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162577 [13:52:48] (03PS1) 10Dbrant: Fixed checkbox not showing in preferences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162586 (https://bugzilla.wikimedia.org/71228) [14:16:30] (03CR) 10Dbrant: [C: 032] Right swipe in ToC hint for RTL, part 2 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162283 (owner: 10BearND) [14:17:16] (03CR) 10Dbrant: [C: 032] Use beta package in Gradle build for beta flavor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162200 (owner: 10BearND) [14:22:28] dbrant: hey [14:23:11] dbrant: can you checkout this patch (https://gerrit.wikimedia.org/r/#/c/162577/) and run the convert-icons script when you've time? it keeps failing on my machine and I've been unable to figure out why [14:23:33] YuviPanda: will do [14:30:55] YuviPanda: seems to have worked for me! [14:34:15] dbrant: bah, I think rsvg on my computer is broken again [14:34:17] * YuviPanda facepalms [14:34:32] dbrant: can you commit the launcher icons in the xxxhdpi folders and update the patch? [14:35:49] YuviPanda: yep, after my Mac updates itself :( [14:35:57] heh ok [14:44:13] (03PS2) 10Dbrant: [WIP] Add xxxhdpi resolution [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162577 (owner: 10Yuvipanda) [15:00:40] 3Wikipedia App / 3Android App: Add Wikipedia app to share menu - 10https://bugzilla.wikimedia.org/71234 (10Florian) 3NEW p:3Unprio s:3enhanc a:3None For OTRS members: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7832996; To search directly in the wikipedia for a string... [15:01:51] :D [15:02:02] +1 that ^ [15:02:24] Oh wait, it's about Android. :/ [15:02:31] yeah, all about android :D [15:02:43] No iOS? :( [15:02:55] It's possible now... [15:02:56] i have no iOS :) [15:03:25] but you can open a ticket, too :) [15:05:48] (03CR) 10BearND: [C: 04-1] "Just making sure that you know that we only want the launcher icons to be xxxhdi, but none of the others." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162577 (owner: 10Yuvipanda) [15:07:14] (03PS3) 10Yuvipanda: Add xxxhdpi resolution launcher icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162577 [15:07:54] (03CR) 10Yuvipanda: "Yeah, convert-icons wouldn't run on my machine (I think rsvg is broken), so dbrant ran it on his, pushed a patch with all icons. I've now " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162577 (owner: 10Yuvipanda) [15:13:29] (03PS2) 10BearND: Fixed checkbox not showing in preferences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162586 (https://bugzilla.wikimedia.org/71228) (owner: 10Dbrant) [15:16:30] (03CR) 10BearND: [C: 032] Fixed checkbox not showing in preferences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162586 (https://bugzilla.wikimedia.org/71228) (owner: 10Dbrant) [15:17:03] (03Merged) 10jenkins-bot: Fixed checkbox not showing in preferences. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162586 (https://bugzilla.wikimedia.org/71228) (owner: 10Dbrant) [15:18:01] (03PS3) 10BearND: Factor out Wikipedia Zero code into its own module. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162504 (owner: 10Dbrant) [15:28:20] (03CR) 10BearND: [C: 04-1] "typo in method name" (031 comment) [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/162503 (owner: 10Dbrant) [15:28:50] bearND: lol damn it [15:28:56] :) [15:34:22] 3Wikipedia App / 3Android App: Checkboxes for important options (usage report, leaving-Zero warnings) are missing - 10https://bugzilla.wikimedia.org/71228 (10Alex Monk) 5PATC>3RESO/FIX [15:34:50] (03PS3) 10Dbrant: Added callback listener for checking response headers. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/162503 [15:35:26] (03PS4) 10Dbrant: Factor out Wikipedia Zero code into its own module. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162504 [15:36:57] (03CR) 10BearND: [C: 032] Added callback listener for checking response headers. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/162503 (owner: 10Dbrant) [15:37:26] dbrant: going to upload the new java api to the team repo [15:37:55] needs to be doen before we can merge the app change [15:37:55] bearND: great [15:40:54] (03CR) 10BearND: [V: 032] Added callback listener for checking response headers. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/162503 (owner: 10Dbrant) [15:42:11] dbrant: hmm, why is it not merging? [15:42:40] something might be stuck... [15:43:19] zuul is not showing much at all, and not the java-mwapi change [15:44:39] dbrant: looked at some older patches, and they also needed a manual submit [15:45:46] bearND: looks like it's merged now [15:45:54] dbrant: ok, I manually submitted that one and now it's merged [15:46:44] maybe YuviPanda knows something about this behavior of the java-mwapi repo? [15:49:58] bearND: Did we have jenkins set up for that repo at all? [15:50:00] * YuviPanda is unsure [15:50:41] YuviPanda: no idea. Looks like Jenkins is not involved at all. [15:50:56] bearND: yeah, probably we never setup a job there, and have always used manual submit [15:51:57] YuviPanda: that explains. Thanks (cc dbrant) [16:01:14] bearND: wanna merge https://gerrit.wikimedia.org/r/#/c/162577/ [16:01:14] ? [16:04:47] YuviPanda: what happened to the script? I thought we also want to have the script updated, so when we get an updated icon we can just run the script. [16:05:02] bearND: the script works fine, my local rsvg installation is fucked up [16:05:08] bearND: it ran fine on dbrant's machine [16:05:19] we can still run the script, just not on my machine [16:05:39] YuviPanda: no, I mean the script changes are not included in the patch anymore [16:05:55] bearND: oh, hmm. xxxhdpi, yeah. [16:06:00] * YuviPanda wonders how to deal with that [16:08:19] YuviPanda: I think the card should have been named: change the convert-icons script to generate the launcher icons also in xxxhdpi [16:08:46] bearND: there we go [16:08:48] (03PS4) 10Yuvipanda: Add xxxhdpi resolution launcher icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162577 [16:09:53] YuviPanda: looks promising. I'll check it out shortly [16:09:58] bearND: \o/ cool [16:10:07] I'm stepping away for a bit now, will brb [16:24:52] (03PS1) 10BearND: Use same lib versions for Gradle and Maven [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162624 [16:25:27] dbrant: ^ [16:26:19] dbrant: I'd like to rebase your patch after ^ [16:26:33] so it also works on Gradle [16:30:14] (03CR) 10Dbrant: [C: 032] Use same lib versions for Gradle and Maven [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162624 (owner: 10BearND) [16:30:35] dbrant: ty [16:32:57] (03PS5) 10BearND: Add xxxhdpi resolution launcher icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162577 (owner: 10Yuvipanda) [16:34:21] (03PS6) 10BearND: Add xxxhdpi resolution launcher icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162577 (owner: 10Yuvipanda) [16:34:39] (03CR) 10BearND: [C: 032] Add xxxhdpi resolution launcher icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162577 (owner: 10Yuvipanda) [16:34:56] (03Merged) 10jenkins-bot: Add xxxhdpi resolution launcher icons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162577 (owner: 10Yuvipanda) [16:35:45] (03PS5) 10BearND: Factor out Wikipedia Zero code into its own module. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162504 (owner: 10Dbrant) [16:37:46] When updating an article on iOS 8; iPad mini (WIkipedia beta...4.0.3?), the result becomes 1/4 times this: http://s9.postimg.org/au0buckcf/image1.png awhole lot of blank space. Once it even crashed the app. I have only tried on the article. [16:37:47] (03PS11) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) [16:37:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [16:41:04] (03CR) 10BearND: [C: 032] Factor out Wikipedia Zero code into its own module. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162504 (owner: 10Dbrant) [16:41:23] (03Merged) 10jenkins-bot: Factor out Wikipedia Zero code into its own module. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162504 (owner: 10Dbrant) [16:42:54] bearND: ty! sorry for the distraction... but that has stood out to me for a while now :) [16:42:54] (03PS9) 10BearND: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [17:01:09] bmansurov: we are looking at https://trello.com/b/lE01t781/mobile-web-current-sprint-31-eat-pray-love [17:01:29] kristenlans, ok [17:17:40] jdlrobson: We have icons \o/ [17:17:53] jdlrobson: Is the baseline incorrect for you too? [17:18:15] prtksxna: on the okay button? [17:18:32] jdlrobson: Yup, the one without the text though [17:18:59] .content .example blockquote div margin-bottom: 5px [17:19:11] the kss styling is interfering with mediawiki ui [17:19:21] maybe change to > div ? [17:19:22] jdlrobson: Oh, I'll take care of that then [17:19:24] Yeah [17:19:54] oh wait that's not the reason [17:20:05] (03PS1) 10Florianschmidtwelzow: Remove unused talk-Template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162643 [17:20:06] * prtksxna raises a bug anyway [17:20:16] (03PS1) 10Florianschmidtwelzow: Use back button to leave Overlay on all Overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162644 (https://bugzilla.wikimedia.org/71203) [17:20:43] FlorianSW: https://gerrit.wikimedia.org/r/162306 :) [17:21:15] jdlrobson: :O [17:21:22] jdlrobson: damn :) [17:22:04] jdlrobson: https://bugzilla.wikimedia.org/71243 [17:22:35] kristenlans: can you make sure baha goes to story prioritisation today? [17:22:48] although he's optional i think it would be useful for bmansurov to see how it works :) [17:23:03] oh wait that is the mandatory one ;-) [17:23:12] and he's on the invite so ignore [17:23:18] jdlrobson, ;) [17:23:37] jdlrobson, is this a good card to work on for me? https://trello.com/c/9rAAIwg5/108-bug-68990-the-number-in-mobile-talk-icon-is-misplaced-in-rtl [17:23:42] jdlrobson: this makes no sense: https://gerrit.wikimedia.org/r/#/c/162306/3/templates/modules/talk/talkHeader.hogan :P But that's my fault :) [17:24:10] (03Abandoned) 10Brion VIBBER: Pull to refresh UI on Saved Pages (frontend only) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/144846 (owner: 10Brion VIBBER) [17:24:28] FlorianSW: why doesn't it make sense? [17:24:41] TalkOverlay uses OverlayHeader.hogan [17:24:47] not talkHeader anymore [17:25:02] jdlrobson: -> https://gerrit.wikimedia.org/r/#/c/162643/ [17:25:31] (03Abandoned) 10Florianschmidtwelzow: Use back button to leave Overlay on all Overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162644 (https://bugzilla.wikimedia.org/71203) (owner: 10Florianschmidtwelzow) [17:26:06] 3MobileFrontend / 3stable: Inconsistency: Editor uses back icon for closing overlay, talk uses X - 10https://bugzilla.wikimedia.org/71203 (10Florian) 5PATC>3NEW [17:26:07] FlorianSW: ah? so that template can be removed? [17:26:33] yap, see https://gerrit.wikimedia.org/r/#/c/162643/ [17:26:37] :P [17:27:06] 3MobileFrontend / 3stable: Inconsistency: Editor uses back icon for closing overlay, talk uses X - 10https://bugzilla.wikimedia.org/71203#c4 (10Jon) We need a designer to chip in before we consolidate this. It's not clear which is the right icon to use for close. It may be back but let's resolve this later. [17:27:41] (03CR) 10Jdlrobson: [C: 032] Remove unused talk-Template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162643 (owner: 10Florianschmidtwelzow) [17:27:48] (03PS2) 10Jdlrobson: Hygiene: Remove unused talk-Template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162643 (owner: 10Florianschmidtwelzow) [17:34:36] dbrant: want to work on the nearby blog post this afternoon? [17:34:50] bearND: ^ [17:35:01] mhurd: sure! [17:37:35] YuviPanda: hey there [17:38:41] tfinc: hey [17:38:53] tfinc: my system crashed and wouldn't boot up [17:38:56] Am on phone [17:39:10] tfinc: want to do it over IRC? [17:39:15] Or reschedule? [17:39:22] YuviPanda: should i move our 1:1 i see you marked it as not attending [17:39:26] reschedule it [17:39:40] i prefer video [17:39:42] tfinc: yeah can you give me perms to move? [17:39:46] it's editable by you [17:40:02] tfinc: no I tried and it said it will only reflect on mine [17:40:10] then reload it [17:40:24] MaxSem, how do I create a page where the text is displayed RTL? [17:40:50] tfinc: alright let me do that. I'll find a slot in your calendar [17:41:01] thanks [17:42:37] bmansurov, switch the wiki to a RTL language, e.g. $wgLanguageCode = 'ar'; [17:42:50] MaxSem, thanks [17:44:32] jdlrobson: yep, good idea [17:44:38] mhurd, kristenlans: I've got all the cards in the current sprint for the refactoring. [17:44:47] Deskana: great! thanks! [17:45:02] mhurd, kristenlans: I've labelled them. Red label = storage refactor. Purple label = networking refactor. [17:45:10] lulz: https://trello.com/c/I5O0x0w5/49-try-to-break-it [17:49:01] Deskana monte brion: nice! What’s the plan for now? Do we want to spend some time at the iteration review tomorrow discussing/estimating? Are you going to take cards from the top of the stack this sprint? [17:49:14] jdlrobson: is there a way to load a html file's content into a variable in a qunit test? [17:49:23] kristenlans: Good point, I need to jiggle the priorities, because we did discuss that yesterday... [17:49:41] kaldari|2: ^^ [17:49:42] MaxSem, what do I need to do to see the talk icon in my dev env? As in this screenshot: https://bug-attachment.wikimedia.org/attachment.cgi?id=16117 [17:50:07] create a few discussion on talk page [17:50:08] kristenlans: Jiggled. [17:50:09] bamnsurov: alpha mode, e.g. ?mobileaction=alpha [17:50:14] kaldari|2: in meeting [17:50:23] FlorianSW: in meeting [17:50:23] bmansurov and what MaxSem said :) [17:50:38] FlorianSW, oh thanks [17:50:49] kaldari|2: ok [17:50:51] mhurd: Next sprint is unstructured anyway, so I'm not sure of the value of estimating. [17:51:53] mhurd, kristenlans: We met to discuss the work since it's a big chunk and I wanted to break it up into more discrete tasks, and then those translated into cards. I'm indifferent about estimating said cards. Thoughts? [17:53:55] kristenlans, I'm working on this card (https://trello.com/c/9rAAIwg5/108-bug-68990-the-number-in-mobile-talk-icon-is-misplaced-in-rtl) and I'd like to mark it in development. I don't see that option in the dropdown. How do I do it? [17:55:29] bmansurov: you can also opt into alpha via the Settings link in the left menu [17:55:42] Ah, bmasurov, you have to move it in to the curretn sprint. Click the ‘Move’ button and chose Board: MobileWeb-Current SPrint and List: In Development [17:55:48] bmansurov: You can move it into the current sprint and put it in "In development" [17:55:53] ^ bmansurov [17:56:09] Deskana, kristenlans, jdlrobson thanks [17:56:15] :D [18:00:28] Deskana: hows about we converge on the idea of estimating the refactoring tasks at the iteration review tomorrow? I’m interested to hear Bronte’s thoughts ont he matter ‘-) [18:00:37] Sure! [18:02:16] (03CR) 10Dbrant: Make page browsing into a Fragment. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [18:02:21] (03PS10) 10Dbrant: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 [18:02:31] * kristenlans is watching the Phabricator tech talk [18:02:46] Deskana: kristenlans: unsure about estimating also… hmmm... [18:03:52] (03CR) 10jenkins-bot: [V: 04-1] Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [18:05:38] Email sent. [18:05:59] mhurd, kristenlans: And I've updated the order of the cards, so the board does now represent my view on priorities. [18:06:09] (03PS11) 10Dbrant: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 [18:07:33] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Manage z-index with less variables (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) (owner: 10Florianschmidtwelzow) [18:08:01] (03CR) 10Jdlrobson: Hygiene: Remove unused talk-Template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162643 (owner: 10Florianschmidtwelzow) [18:08:06] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove unused talk-Template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162643 (owner: 10Florianschmidtwelzow) [18:08:10] Deskana: awesome! [18:08:41] (03Merged) 10jenkins-bot: Hygiene: Remove unused talk-Template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162643 (owner: 10Florianschmidtwelzow) [18:08:52] Deskana: kristenlans: heading out to run quick errand… back in ~40 min [18:09:15] mhurd: 10-4 [18:15:08] (03CR) 10Jdlrobson: [C: 04-1] "Once typo fixed this is good to merge." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162517 (owner: 10Bmansurov) [18:16:27] (03PS4) 10Jdlrobson: Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 [18:16:57] (03PS4) 10Jdlrobson: Hygiene: Create WikiDataApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162131 [18:17:03] (03CR) 10Jdlrobson: [C: 032] "rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162131 (owner: 10Jdlrobson) [18:17:09] (03PS4) 10Jdlrobson: Hygiene: Introduce WikiGrokApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162132 [18:17:20] (03PS4) 10Jdlrobson: Hygiene: Add recordOccupation method to WikiGrokApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162133 [18:17:46] (03Merged) 10jenkins-bot: Hygiene: Create WikiDataApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162131 (owner: 10Jdlrobson) [18:19:23] dbrant, bearND: What's with the push to beta at 1pm on Sunday? :-p [18:19:35] dbrant, bearND: I'm assuming that's a weird scheduling mixup... [18:19:59] Deskana: no idea where that one came from. I assume the calendar invite got accidentally moved somehow [18:20:14] who can review https://gerrit.wikimedia.org/r/#/c/162638/ (adding apple touch icon for wikidata) ? [18:20:29] Deskana: hmm... no idea! Google calendar must have screwed up somehow [18:20:33] bmansurov: so are you familiar with the concept of our stable/beta/alpha modes of the site and what they mean? [18:20:34] not sure if there are particular style guidelines for this [18:21:11] jdlrobson, I'm not, can you give me some information about them? [18:22:43] (03PS6) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 [18:24:52] 3Wikipedia App / 3Android App: Crash caused by pressing Retry button on connection issue error - 10https://bugzilla.wikimedia.org/70834#c6 (10Dan Garry) 5RESO/FIX>3REOP (In reply to Alex Monk from comment #5) > But is it really? > https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom; > Ticke... [18:25:12] jdlrobson, if I want to add a style specifically for an RTL page, do I just append html[dir="rtl"] to the CSS selector? [18:25:22] 3Wikipedia App / 3Android App: Android app flashes on page load - 10https://bugzilla.wikimedia.org/69863#c5 (10Dan Garry) 5PATC>3RESO/FIX (In reply to Alex Monk from comment #4) > Was this fixed? It should've been. I certainly haven't noticed it since that fix was merged. Resolving fixed accordingly. [18:27:08] 3Wikipedia App / 3Android App: screen flickers when scrolling down for the first time on page - 10https://bugzilla.wikimedia.org/69754 (10Dmitry Brant) 5PATC>3RESO/FIX [18:27:23] 3Wikipedia App / 3Android App: "Maximum call stack size exceeded" in javascript bridge - 10https://bugzilla.wikimedia.org/69700 (10Dmitry Brant) 5PATC>3RESO/FIX [18:27:27] The product manager giveth bugs, the product manager taketh away bugs. [18:27:36] :) [18:33:56] (03PS1) 10Bmansurov: Add padding to mobile talk icon text in RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162665 (https://bugzilla.wikimedia.org/68990) [18:34:24] bmansurov: RTL is a curious beast in mediawiki world [18:34:35] just answering your earlier question 1s [18:36:06] mmm i can't dig out any documentation on this (maybe kristenlans has some ideas) [18:36:55] but basically Beta is where stuff the product manager wants goes, Alpha is where stuff developers put things they think we should be thinking about. The idea is to use alpha to show good ideas that can feed into the product direction [18:37:10] i don't know if kaldari|2 wants to add anything to that [18:37:43] jdlrobson, i see [18:38:07] bmansurov: Alpha is also for technical proof-of-concepts [18:38:16] ok [18:38:21] that we don't necessarily want a lot of users using yet [18:39:43] so bmansurov if you suddenly think "wouldn't it be great if Wikipedia did this" you should feel free to build it into the alpha of the site. [18:39:49] (as part of your experimentation time) [18:40:15] jdlrobson bmansurov: the closest thign I can find explaining alpha beta etc is here: https://www.mediawiki.org/wiki/Mobile/Release_history#Mobile_Web [18:40:24] I fear it may be out of date :-/ [18:40:34] it's likely [18:40:54] ok thanks [18:40:59] We coudl really use some documntation that beter explains and where to go to access beta, alpha… [18:41:01] bmansurov: Also, most experimental features have a "feature flag" - a global boolean config var defined in MobileFrontend.php - that can be used to turn the feature on and off [18:41:51] kaldari|2, so if I turn the feature flag on, then I'll be able to see alpha changes from others? [18:42:43] kaldari|2, how do I make my commit a 'feature commit'? Or is just a regular commit that won't get approved by the reviewer, thus stays in the review? [18:43:12] bmansurov: so rtl is pretty magical in mediawiki [18:43:33] stylesheets are magically converted to rtl [18:43:41] bmansurov: most experimental features have their own feature flag, so for example, if you look in MobileFrontend.php you'll see '$wgMFEnableWikiGrok = false;' [18:43:46] a rule padding-left: 5px will become padding-right: 5px in RTL mode [18:44:28] so if you override that with $wgMFEnableWikiGrok = true in your LocalSettings.php, you can turn on the WikiGrok experimental feature on your local MediaWiki instance [18:44:34] so you'll notice the rule in the file you posted is actually being turned into a padding-left [18:44:39] kaldari|2, ok [18:44:46] jdlrobson, yes [18:45:54] (03PS3) 10Bmansurov: Detect retina displays and load the image in the correct size. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162517 [18:46:35] bmansurov: commiting alpha and beta features is just like doing any other code commit, nothing special. [18:47:13] makes sense [18:47:26] (03CR) 10Jdlrobson: [C: 04-1] Add padding to mobile talk icon text in RTL (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162665 (https://bugzilla.wikimedia.org/68990) (owner: 10Bmansurov) [18:47:36] ^ bmansurov made some comments here about the RTL stuff [18:51:46] jdlrobson, left a comment on your comment. [18:52:45] (03CR) 10Jdlrobson: [C: 032] Detect retina displays and load the image in the correct size. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162517 (owner: 10Bmansurov) [18:56:12] (03Merged) 10jenkins-bot: Detect retina displays and load the image in the correct size. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162517 (owner: 10Bmansurov) [18:58:05] jdlrobson, once 'must have' cards are done, should I move on to 'should have', and then to 'could have'? [19:01:13] (03CR) 10Florianschmidtwelzow: Hygiene: Manage z-index with less variables (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) (owner: 10Florianschmidtwelzow) [19:02:04] (03PS5) 10Florianschmidtwelzow: Hygiene: Manage z-index with less variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) [19:03:35] DarTar: I forget, how do I connect to the log database from stat1003? [19:03:58] kaldari|2: in an interview - brb [19:04:02] NP [19:04:15] jdlrobson: do you know? ^ [19:05:32] I need to actually take a look at the data to see why a graph stopped working [19:06:21] kaldari|2: I can help in 5 [19:18:10] bmansurov: hey sorry [19:18:25] np [19:18:37] bmansurov: yeh so usually we just work off the current sprint [19:18:51] but this one is unusual since you've joined half way and we are flying through cards ;-) [19:19:12] let me find something suitable [19:19:23] ok thanks [19:19:37] bmansurov: how is your PHP? [19:19:42] i forget :) [19:19:53] jdlrobson, not good [19:20:02] ok not a problem :) [19:20:03] jdlrobson, should I be improving it? [19:20:21] bmansurov: you are likely to improve it whilst you work on this code base but don't worry about it too much just yet [19:20:24] yurik, around? [19:21:04] bmansurov: https://bugzilla.wikimedia.org/show_bug.cgi?id=69721 is probably a good one to look at [19:21:10] i will introduce you to the notification overlay [19:21:12] jdlrobson, OK. Also, is there a documentation about the codebase? Or should I just read the code and try to understand how things work? [19:21:20] jhobs, yep [19:21:31] bmansurov: so if you navigate to the MobileFrontend directory and run `make docs` [19:21:38] it should generate a bunch of local documentation [19:21:46] yurik, still able to go over setting up the local environment? We can push it back if you need to [19:22:02] jdlrobson, ok great [19:22:05] jhobs, lets postpone 40 min, sorry about it - mid of deployment [19:22:13] actually it turns out some of the documentation is not up to date (i get loads of warnings) - so feel free to fix that in the process :) [19:22:20] yruik: not a problem, just give me a call when you're ready [19:22:30] (03PS3) 10Yurik: Added ZeroConfig context search modes [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/154760 [19:23:20] jdlrobson, how do I fix this? make: *** [kss] Error 7 [19:23:26] 3MobileFrontend / 3Hygiene: Documentation: JS Documentation out of date since OOJS move - 10https://bugzilla.wikimedia.org/71250 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon When running `make docs` jsduck javascripts/ --output docs/js/ --external=jQuery.Object,Hogan.Template,jQuery.Deferred,mw.user --ex... [19:23:33] yikes [19:23:50] bmansurov: what happens when you run `make jshint` [19:24:07] and what happens when you run `make nodecheck` [19:24:09] npm WARN package.json MobileFrontend-dependencies@0.0.1 No repository field. [19:24:31] same text for both command [19:24:32] s [19:25:30] DarTar: Also, I need to get the updated definition for 'mobile new active editors' [19:25:59] ***Security notice*** for IRC: vulnerability prior to September 15, change passwords https://lists.wikimedia.org/pipermail/wikimedia-l/2014-September/074727.html [19:26:11] (03CR) 10Yurik: [C: 032] Added ZeroConfig context search modes [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/154760 (owner: 10Yurik) [19:26:12] DarTar: currently it looks like we're using 'at least 5 edits within 30 days of registration' [19:27:05] mmm [19:27:30] what about `make gems` [19:27:30] ? [19:27:49] bundle install [19:27:49] make: bundle: Command not found [19:27:49] Makefile:5: recipe for target 'gems' failed [19:27:49] make: *** [gems] Error 127 [19:28:11] bmansurov: ok so you'll need to install a few things [19:28:32] ok [19:28:39] so first you need to install ruby [19:28:40] (sorry) [19:29:02] ruby 2.1.3-2 is already installed [19:29:05] ok cool [19:29:09] next step `gem update --system` [19:29:10] jdlrobson, MaxSem: we should get some food before the story review meeting [19:29:13] `gem install bundler` [19:29:17] `bundle install` [19:29:31] that should get jsduck working and also get you in a state where you'll be able to run the browser tests [19:30:07] bmansurov: we're just grabbing lunch. When you are done with that `make jsduck` should run and generate the JavaScript documentation for you [19:30:16] that should be enough for you to understand the JS code [19:30:24] ok thakns [19:34:39] dbrant|food: Hey there, ping me when you have a chance? [19:36:03] (03Merged) 10jenkins-bot: Added ZeroConfig context search modes [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/154760 (owner: 10Yurik) [19:42:23] vbamba: back! [19:45:09] bearND: the second (other-fragments) patch is ready! [19:45:43] dbrant: cewl. But we'll wait with merging until the search bar stuff is done, right? [19:45:51] bearND: correct [19:59:51] (03PS1) 10Chad: Don't rely on global title state for url generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162699 [20:02:15] bmansurov: are you able to make it to story prioritization meetign? [20:02:27] kristenlans, yes [20:02:44] (03PS2) 10Chad: Don't rely on global title state for url generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162699 [20:03:09] (03PS2) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [20:03:11] (03PS4) 10Jdlrobson: Hygiene: Move DOM handling out of postRender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162134 [20:03:13] (03PS2) 10Jdlrobson: Hygiene: WikiDataApi::getClaims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162185 [20:03:35] bmansurov: I think this link shoudl work https://plus.google.com/hangouts/_/calendar/d2lraW1lZGlhLm9yZ19yMWNvaHVib3JmYjlqcWMydHA0bmwxcXMxZ0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t.533jdjq46pqgopsnbm60rrstd0?authuser=0 [20:03:49] kristenlans, joining in a sec [20:05:23] kaldari|2: I’m around now but I can’t join the mobile review meeting, ping me if you still need help [20:13:54] 3MobileFrontend / 3Feature requests: Mobile media viewer: If the author data from the API includes a link, and the link is to a User page, preserve the link in the viewer - 10https://bugzilla.wikimedia.org/70552 (10Jon) [20:16:38] http://hatjitsu.wmflabs.org/27623 [20:21:00] (03CR) 10BearND: [C: 04-1] "Now when you go back it'll take a while for the WebView to be scrolled to the correct position. Before it was immediate. Is there anything" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [20:21:26] https://trello.com/b/TInnSh9E/mobile-web-q1-backlog-2014-2015 [20:30:12] dbrant: sorry, I just noticed that we also have a ParcelableLruCache class in our code. That should probably be used for the page caching mechanism. [20:30:43] that can come in a later patch [20:33:08] bearND: well the thing is, I still don't think that we should put the whole Page object in savedInstanceState. If anything, we could save the cached pages to internal storage, kind of like SavedPages... [20:34:16] (03CR) 10Legoktm: [C: 032] Don't rely on global title state for url generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162699 (owner: 10Chad) [20:34:53] http://hatjitsu.wmflabs.org/27623 [20:36:52] dbrant: if saving the page wasn't so slow and required us to redownload the images. We would need to see if we could get the images from the webview directly. [20:37:10] (03Merged) 10jenkins-bot: Don't rely on global title state for url generation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162699 (owner: 10Chad) [20:37:25] vbamba: at the office today? [20:39:36] https://trello.com/b/BdoyCeLj/mobile-web-bug-backlog [20:40:50] dbrant: any ideas about fixing the scrolling behavior in https://gerrit.wikimedia.org/r/161483? [20:41:09] 3MobileFrontend / 3Feature requests: Hash behaviour on mobile with sections - 10https://bugzilla.wikimedia.org/53308#c8 (10Jon) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 69351 *** [20:41:09] 3MobileFrontend / 3stable: Going back to previous page doesn't remember expanded sections - 10https://bugzilla.wikimedia.org/69351#c2 (10Jon) *** Bug 53308 has been marked as a duplicate of this bug. *** [20:42:24] 3MobileFrontend / 3Hygiene: MobileOptions checkbox toggles should be refactored and put in mediawiki.ui - 10https://bugzilla.wikimedia.org/64313#c3 (10Jon) 5NEW>3RESO/INV We moved to using mw-ui-checkbox so this bug is no longer relevant. [20:42:52] kaldari|2 jdlrobson: are there any metrics about the usage of anonymous editing in mobile alpha? [20:43:06] FlorianSW: i can take a look for you in bit [20:43:16] jdlrobson: great :) [20:45:06] bmansurov, https://en.wikipedia.org/w/index.php?title=Template:Str_len/core&action=edit [20:45:23] MaxSem, thanks [20:45:42] 3MobileFrontend / 3stable: Going back to previous page doesn't remember expanded sections - 10https://bugzilla.wikimedia.org/69351#c3 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/6kTIIUyU [20:47:07] DON'T THANK ME HAHAHA [20:47:55] 3MobileFrontend / 3beta: Page preview: Clicking on links sends you to the reference list of the current article - 10https://bugzilla.wikimedia.org/57412#c5 (10Jon) 5ASSI>3RESO/INV Feature got removed. [20:49:52] 3MobileFrontend / 3Feature requests: Use touchend instead of click event where possible - 10https://bugzilla.wikimedia.org/46012#c8 (10Jon) 5NEW>3ASSI Will be handled in next sprint [20:52:22] 3MobileFrontend / 3Hygiene: Copyvio tests do not work on Chrome - 10https://bugzilla.wikimedia.org/64397#c3 (10Jon) 5REOP>3RESO/WOR No tests are failing right now. [20:52:52] 3MobileFrontend / 3Uploads: Rethink the upload summaries for photo uploads from mobile - 10https://bugzilla.wikimedia.org/58983 (10Jon) [20:53:07] 3MobileFrontend / 3Uploads: Cannot easily retry upload - 10https://bugzilla.wikimedia.org/45377 (10Jon) [20:53:33] MaxSem, why not? [20:53:52] 3MobileFrontend / 3Feature requests: MobileFrontend: All icon buttons should have title tooltips - 10https://bugzilla.wikimedia.org/50705#c5 (10Jon) 5REOP>3ASSI Should be fixed as part of icon standardisation project. [20:54:10] 3MobileFrontend / 3Uploads: AbuseFilterPanel on lead photo upload is too easy too ignore. - 10https://bugzilla.wikimedia.org/61976 (10Jon) [20:56:44] FlorianSW: when did it go live? [20:57:16] jdlrobson: öhm :P If i'm right at the end of august, let me check [20:58:20] FlorianSW: so is event logging definitely working for anonymous edits? [20:58:30] MaxSem, et al, any concerns with the WP icon change in https://gerrit.wikimedia.org/r/#/c/162538/ [20:58:58] (03CR) 10Dbrant: "This was one of the caveats I mentioned (no longer having the snappy "back" functionality). I'm not sure what the immediate solution would" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [20:59:07] bearND: ^ [20:59:07] jdlrobson: ah, wait, it's online since 18 Sep :/ [20:59:29] looks broken to me FlorianSW [20:59:32] https://m.mediawiki.org/wiki/Project:Sandbox?mobileaction=alpha#/editor/0 [20:59:35] Maryana: / Deskana: don't forget to circulate the asks for the quarterly review [20:59:40] oh wait [20:59:42] MaxSem, it looks almost identical, and we would be saving over 80% of the original size [20:59:57] FlorianSW: yeh it's broken :( [20:59:58] Validation error against schema MobileWebEditing: Wrong type for property: userEditCount null [21:00:23] jdlrobson: argh, damn :) Let me open a bug [21:00:46] FlorianSW: already did [21:00:51] FlorianSW: i think it's possible to get data for dropped data of this kind [21:00:54] but i'm not sure of the process [21:00:55] 3MobileFrontend / 3alpha: EventLogging on alpha anonymous editing being thrown away - 10https://bugzilla.wikimedia.org/71252 (10Jon) 3NEW p:3Unprio s:3normal a:3None Validation error against schema MobileWebEditing: Wrong type for property: userEditCount null [21:01:02] FlorianSW: https://bugzilla.wikimedia.org/show_bug.cgi?id=71252 ^ [21:01:39] jdlrobson: thanks :) maybe i have to read more about eventlogging :/ [21:04:15] jdlrobson: should be "enough" to extend https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/javascripts/loggingSchemas/mobileWebEditing.js to check if the user is logged in and only log data we know?! Is it possible to add and remove data there? [21:04:50] easiest thing would be to give it a number [21:04:57] otherwise you'll need to update the schema [21:05:23] 3MobileFrontend / 3alpha: EventLogging on alpha anonymous editing being thrown away - 10https://bugzilla.wikimedia.org/71252#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/KGRuurfD [21:05:24] number could be 0 or -1 (-1 would at least make it obvious it is special) [21:05:29] DarTar: you free now? [21:05:30] jdlrobson, is there an easy way to generate 100 notifications as in this screenshot? https://bug-attachment.wikimedia.org/attachment.cgi?id=16230 [21:05:47] FlorianSW: in mean time... https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&hideliu=1&tagfilter=mobile+web+edit [21:05:54] kaldari|2: in a 1:1 for another 20 mins :-/ [21:05:59] bmansurov: yes :) [21:06:07] 1s [21:06:37] bmansurov: firstly did you get Echo installed on your vagrant instance? [21:06:51] I believe no [21:06:51] also btw did you get the js documentation generated? [21:06:54] yes [21:06:59] sweet [21:06:59] thanks for that [21:07:05] `vagrant enable-role echo` [21:07:08] bearND: on another note, I explored re-using the WebView for loading multiple pages, and it was going well, but then I made the mistake of testing it on 2.3... and it was a big disappointment! Something about all of our bridge transactions eventually destabilizes the webview. So, I shelved those changes for now. [21:07:09] `vagrant provision` [21:07:11] you'll need that [21:07:17] jdlrobson: yeah, that's a possible way, too :P [21:07:46] so in terms of 100 notifications, we could either write you an api snippet OR you could run various browser tests which generate them [21:08:03] ok [21:08:10] can you show me both? [21:08:13] kristenlans: Have you given bmansurov an overview of how the workflow on a Trello board works? If not, that would probably be helpful. [21:08:14] FlorianSW: https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&hideliu=1&tagfilter=mobile+web+edit [21:08:23] there have been a few :) [21:08:37] jdlrobson: yeah, i saw :) [21:09:11] jdlrobson, vagrant is done [21:09:20] kaldari [21:09:22] oops [21:09:33] dbrant: Can you quickly update that thread you sent about about the WebView for posterity? After all, if it didn't happen in email, it didn't happen. :-) [21:09:39] kaldari|2: not yet, good idea. I will add it to my Baha list :-) [21:09:48] kristenlans, thanks [21:09:54] thanks! [21:09:56] Deskana: sure! [21:11:25] have a nice day all, bb and good night :P [21:11:35] dbrant: Isn't https://gerrit.wikimedia.org/r/161483 about reusing the webview? [21:11:49] testing on 2.3... [21:12:04] FlorianSW: night! [21:12:11] bearND: nope, it still uses a separate fragment (with its own webview) per page. [21:13:02] dbrant: i see [21:13:18] (03CR) 10BearND: "Just an idea but it's not a full solution: Currently we wait before we scroll until the page is fully loaded. If we scrolled right after t" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [21:14:22] bearND: ^ not a bad idea; I can look into it. [21:14:28] bmansurov: I'm not sure if I've introduced myself to you. If I have, sorry for the repetition! I'm Dan, Maryana's counterpart in the Mobile Apps Team. :-) [21:14:59] Deskana, Hi Dan. Pleasure to meet you! [21:15:12] bmansurov: sorry about that [21:15:17] np [21:15:31] i'm still trying to work out best way to generate those notifications [21:15:38] so i think it would be useful for you to run some browser tests [21:16:20] ok [21:16:46] bmansurov: the only problem is as soon as you get 100 notifications and read them they are gone [21:17:07] jdlrobson, so I should not click the notification button? [21:17:15] when does reading happen? [21:17:16] bmansurov: so i think the best thing is going to be to fake it [21:18:03] so notifications is kind of weird [21:18:08] some of it lives in the Echo extension [21:18:11] some in MobileFrontend [21:18:48] (for the record the goal is to get it all into Echo) [21:19:05] we will talk about that later :) [21:19:12] ok [21:19:17] anyway [21:19:28] to generate 1 notification, you'll need 2 accounts on your vagrant instance [21:19:42] I already have 2. [21:19:54] tfinc: i responded to your email about the impact of the refactor on the ios position requirements [21:20:03] then in one of them go to the other users talk page (User talk:Baha for example) [21:20:09] ok perfect :) [21:20:13] you are one step ahead of me ;-) [21:20:21] so in NotificationsOverlay grep for result.query.notifications.list [21:20:36] i would suggest programmatically altering that so it ends up reporting 100 notifications [21:21:07] (alter result) [21:21:22] unfortunately it will also require you consulting the Echo code and how that works [21:21:35] they don't have this problem on desktop so in their javascript folder you'll have to find out how they do it [21:21:50] jdlrobson, 1 sec. After vagrant provision, my dev env stopped working [21:22:09] updateBadgeCount seems to be the best place to start (in ext.echo.overlay.js) [21:22:25] i think with those puzzle pieces you'll be able to work it out [21:22:28] * jdlrobson hopes :) [21:22:50] ok, thanks. how do I get my dev env working again? vagrant reload didn't help [21:28:56] MaxSem, vagrant stopped working after 'vagrant provision'. How can I fix it? [21:29:19] define stopped [21:29:36] page reload says server unavailable [21:29:43] vagrant ssh also quit [21:29:50] mmm [21:29:53] not server, service [21:30:02] enale-role zend [21:30:08] *enable-role zend [21:31:51] MaxSem, thanks! that fixed it [21:32:00] :P:P:P [21:32:04] evul hhvm [21:32:41] what's that? [21:33:06] https://www.mediawiki.org/wiki/HHVM [21:33:17] I switched you to a different interpreter [21:34:40] (03CR) 10BearND: [C: 04-1] "need also more comments" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [21:34:51] ok thanks [21:39:47] dbrant: hello! [21:39:55] vbamba: hey! [21:40:39] Hey so I just wanted to follow up. Should I set up a meeting next week so we can jam on the list styling? [21:41:06] How are you thinking we could move into some lightweight prototype implementation? [21:41:09] vbamba: any time later today to chat about potential mocks for tomorrow? [21:43:51] vbamba: sure, sometime next week will be good (since I'll be there!) [21:47:20] jdlrobson: https://office.wikimedia.org/wiki/Goals/2014-2015/Engineering_and_Product_Development/Jon_Robson [22:00:12] Deskana: are you in the office today? [22:00:29] we're gonna get started on mobile editing convo – lmk if you need a hangout [22:03:18] bmansurov: how are you getting on? [22:03:56] jdlrobson, couldn't generate 100 notifications, but I think the fix should be in the SkinMinerva.php file [22:04:21] jdlrobson, line 244 [22:04:38] mhurd: I can chat at 3:30. works? [22:04:54] vbamba: ya! [22:06:11] (03CR) 10Kaldari: [C: 04-1] "This works in mobile, but not on tablet, since reveal() assumes that all sections are closed by default and only scrolls to the section if" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162178 (https://bugzilla.wikimedia.org/69020) (owner: 10Jdlrobson) [22:06:39] jdlrobson, how can I output some debug info from that php file? [22:06:54] MaxSem: can you help bmansurov with that? ^ [22:07:40] I usually just whack var_dump() everywhere [22:07:54] jdlrobson, I'm not supposed to edit php files (yet), am I? [22:07:58] MaxSem, thanks [22:07:59] bmansurov: feel free ;-) [22:08:03] bmansurov: it's inevitable [22:08:10] jdlrobson, am I on the right track? [22:08:23] bmansurov, how's your general PHP knowledge? do you need a crash course in it or our PHP code base? [22:08:25] bmansurov: possibly. I'm not sure. I don't not what's causing the bug [22:08:43] vbamba Deskana dbrant mhurd et al: do we have stuff to talk about at Design review meeting today? Just wondering given that next sprint is ‘unstructured’ and it sounds like design for the upcoming quarter is still emerging. [22:08:46] the notification count does seem to be done on the server side though so you are probably right! [22:08:57] MaxSem, not good, I'll need both [22:09:11] jdlrobson, ok thanks [22:10:10] kristenlans: there's not much from the Android side, no... [22:11:40] kristenlans: good point… vbamba? [22:11:55] bmansurov, jdlrobson: The Echo API should return a preformatted notification count, i.e. Like I told Jon, I have no idea how it's even possible for us to get the number 100. [22:12:02] MaxSem, how can I clear a cached template? [22:12:19] ?? [22:12:36] jdlrobson: Are we just not using the count returned by the API? [22:13:00] MaxSem, I edited a template and refreshed the page and saw my change. But when I change it to something else, I still see my old change after refresh [22:13:18] kaldari|2, I think we are, it's in the SkinMinerva.php file [22:13:26] $count = MWEchoNotifUser::newFromUser( $user )->getNotificationCount(); [22:13:48] when you change a template, the changes propagate to pages using it via job queue, so it can take a bit of time [22:14:16] bmansurov: Ah, then all you have to do is pipe that through EchoNotificationController::formatNotificationCount() [22:14:20] MaxSem, any way I can manually accelerate the process? [22:14:29] just null edit it [22:14:47] kaldari|2, thanks [22:14:56] MaxSem, can you explain moe? [22:14:58] more? [22:15:08] $count = EchoNotificationController::formatNotificationCount( $count ); [22:15:13] hangouts/skype? [22:15:15] after that line you posted [22:15:34] kaldari|2, cool [22:15:37] MaxSem, sure 1 sec [22:16:21] MaxSem, can you add me to skype? m6ahodir [22:17:19] bmansurov, jdlrobson: in this case, it looks like we are bypassing the Echo API, which is why it's formatted wrong. Easy enough to fix though. [22:18:55] i see... [22:19:45] DarTar: You free yet? [22:19:59] kaldari|2: I am, coming [22:20:03] yay! [22:22:19] kaldari|2: analytics-store.eqiad.wmnet [22:22:45] (03PS1) 10Bmansurov: Add notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) [22:23:28] kristenlans: Hi there! [22:23:33] is there a board for sprint 41? [22:23:45] I can't see it [22:24:28] Hmmm, I don’t see it yet either vbamba. [22:24:46] Deskana can you add us to the board when you have a moment? [22:24:56] (03PS3) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [22:31:29] We have a design review at 4 and I would like to discuss search but I actually have no idea whats on sprint 41 board. [22:31:55] perhaps thats the planning that maryana was talking about [22:32:10] mhurd: sent you an invite for video call [22:32:32] vbamba: I knwo that Sprint 41 is going to be unstructured because of all the planning meetings next week. [22:33:01] umm ok thats fine. ill use the design review to discuss search [22:33:11] so it wont be so much about sprint 41 [22:33:16] tahnks kristenlans [22:34:09] vbamba: no problem [22:36:00] (03CR) 10Kaldari: [C: 032] Add notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [22:37:08] (03PS1) 10Jdlrobson: Hygiene: Add JSONP support to API classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162778 [22:37:11] bmansurov: You'll notice that I +2ed the notification fix, but it can't be merged because it has a dependency on an unrelated change (padding for talk icon)... [22:37:15] https://gerrit.wikimedia.org/r/#/c/162775/ [22:37:53] bmansurov: To avoid that situation, we usually create new git branches locally for each self-contained task we work on [22:38:31] bmansurov: And only reuse those branches if there should be real dependancies on previous pieces of work [22:39:06] (03CR) 10Jdlrobson: [C: 04-1] "I'm still seeing it clipped. Screenshot to follow." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [22:39:34] bmansurov: The down-side of this is that you'll quickly end up with dozens of local git branches, so you'll need to clean them up periodically with 'git branch -D myCoolBranchName' [22:40:54] mhurd: That device has been ringing for some time now :P [22:40:57] (03CR) 10Kaldari: [C: 031] "Per Jon" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [22:41:00] (03CR) 10Jdlrobson: "Force the count to be over 100 with the following patch:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [22:41:26] ^ bmansurov will need a css tweak too [22:41:28] prtksxna: hahaha [22:43:36] (03CR) 10Kaldari: [C: 04-1] "Probabaly need to change the hard-coded width to a min-width." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [22:48:15] kristenlans: I haven't set the board for next sprint up yet because I don't have anything to put in it. :) [22:48:31] kristenlans: So AFAIK there is nothing to review at the design review. [22:48:43] Deskana: I suspected that might be the case. [22:49:19] Deskana: sounds like vbamba wants to discuss search [22:50:00] kristenlans: That works! [22:50:11] In the mean time, I'll set up boards. [22:50:31] Thanks Deskana! [22:52:10] jdlrobson: Just added you as a reviewer on some limn graph fixes. Would be good to get these merged and deployed before the quarterly planning meeting tomorrow. [22:52:17] roger [22:52:48] also added MaxSem [22:53:07] thanks for limn wrestling kaldari|2 :-) [23:01:15] kaldari|2: bearND has done some Limn work recently. Perhaps he could review your work too, if you need that. :) [23:01:55] Deskana: thanks for the tip [23:08:24] kaldari|2, sorry, I was in a meeting. Thanks for the info, I'll note that. [23:29:17] DarTar: where did you say I could get the user's registration type from, i.e. either mobile or desktop? [23:29:30] ServerSideAccountCreation [23:29:43] for mobile site vs desktop site [23:30:03] kaldari|2: sending you some sample SQL [23:30:15] DarTar: thanks [23:35:17] DarTar: Did we resolve that inconsistency that was in the event_isMobile field? [23:35:50] kaldari|2: tl;dr is "Don't trust event_isMobile to tell you whether the user is on mobile or not" :-p [23:36:53] Deskana: remind me, do you mean for app registrations? [23:37:33] Deskana, Deskana: We're still using event_isMobile for the current mobile active editors graph, but this will change soon. [23:37:39] DarTar: ^ [23:37:50] DarTar: Yeah. [23:38:13] kaldari|2, I amended the commit, and when I do git-review it still wants to push the previous commit. How do I push the latest commit only? [23:38:24] kaldari|2: you’ll see in the sample SQL how to detect app registrations [23:38:38] it’s a hack, I agree we need to fix the log [23:40:09] Deskana: if you guys are planning on making instrumentation changes for account creation, make sure you loop me (and kevinator) in, as there are many people consuming data from Schema:SSAC [23:40:30] bmansurov: Sounds like that git review bug I described yesterday. It won't actually repush the previous commits, even if it says it is. You can just say 'Yes'. Or if you want to get rid of the bogus warning, you can run 'git fetch --all' before 'git review' and I think that fixes it. [23:40:33] DarTar: Nothing planned on our end. Noted, though! [23:40:42] jdlrobson: https://github.com/wikimedia/apps-ios-wikipedia/tree/master/wikipedia/Fonts [23:41:03] bmansurov: although it only fixes it temporarily :( [23:41:08] DarTar: thanks for the help on mobile reportcard <3 [23:41:29] kaldari|2, yes I remember you explaining it to me yesterday. It's weird that my previous commit was pushed earlier. [23:41:44] (03PS2) 10Bmansurov: Add notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) [23:41:56] np (I’ll have more time this Friday to QA the data if needed) [23:42:16] kaldari|2, oh that's a dependency. How do I remove it? [23:43:12] (03PS3) 10Bmansurov: Add notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) [23:43:21] kaldari|2: can we still backfill the graphs with historical data? [23:44:07] Maryana: sure [23:44:13] radical [23:45:40] Maryana: we just can make it universal since there isn't a composite table for the new definition, like there was for the old one. [23:45:46] can=can't [23:46:15] gotcha. i was hoping we could hijack one big box for that, but it's ok if not [23:46:57] one big box being the thing that has alllll the dbs [23:55:27] (03PS6) 10Jdlrobson: Hygiene: Manage z-index with less variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) (owner: 10Florianschmidtwelzow) [23:55:47] (03CR) 10Jdlrobson: [C: 032] Hygiene: Manage z-index with less variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) (owner: 10Florianschmidtwelzow) [23:56:21] (03Merged) 10jenkins-bot: Hygiene: Manage z-index with less variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/139568 (https://bugzilla.wikimedia.org/64707) (owner: 10Florianschmidtwelzow)