[00:09:17] (03CR) 10Kaldari: [C: 04-1] Add notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [00:26:32] (03CR) 10Kaldari: [C: 032] Add notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [00:27:02] (03PS1) 10Jdlrobson: Hygiene: Abstract more of the nastiness of the wikidata api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162797 [00:47:17] (03PS4) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [00:54:28] (03PS1) 10Kaldari: Gitting rid of skins.minerva.chrome.styles.beta and uiNew.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162799 [00:55:16] (03PS2) 10Kaldari: Hygiene: Gitting rid of skins.minerva.chrome.styles.beta and uiNew.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162799 [01:44:39] 3Wikipedia App / 3Android App: NPE when pageimages.PageImageSaveTask.onFinish calls data.ContentPersister.upsert - 10https://bugzilla.wikimedia.org/68895#c2 (10Dan Garry) 5NEW>3RESO/INV The PageImageSaveTask class was removed from the repo on 18th August (https://gerrit.wikimedia.org/r/#/c/153809/), so t... [05:57:21] 3MobileFrontend / 3stable: I got 99+ notifications but the label ain't one (it says 100 instead) - 10https://bugzilla.wikimedia.org/69721 (10Florian) 5PATC>3RESO/FIX [06:01:55] 3MobileFrontend / 3Hygiene: Manage z-index with LESS variables - 10https://bugzilla.wikimedia.org/64707 (10Florian) 5PATC>3RESO/FIX [06:04:20] (03CR) 10Florianschmidtwelzow: Hygiene: Gitting rid of skins.minerva.chrome.styles.beta and uiNew.less (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162799 (owner: 10Kaldari) [10:02:10] (03PS1) 10Yurik: Added private-wiki-only lua extensions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 [10:10:23] 3MobileFrontend / 3stable: I got 99+ notifications but the label ain't one (it says 100 instead) - 10https://bugzilla.wikimedia.org/69721#c3 (10Andre Klapper) Jon: Re Bug Summary: "Hit me!" Florian: Why is this fixed? The patch isn't merged yet. [10:13:31] (03CR) 10Daniel Kinzler: "Yay for read-access to the API from Lua." (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [10:23:34] (03CR) 10Yurik: Added private-wiki-only lua extensions (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [10:40:13] (03PS2) 10Yurik: Added private-wiki-only lua extensions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 [11:19:03] (03PS3) 10Yurik: Added private-wiki-only lua extensions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 [12:32:37] 3MobileFrontend / 3stable: I got 99+ notifications but the label ain't one (it says 100 instead) - 10https://bugzilla.wikimedia.org/69721#c4 (10Florian) 5RESO/FIX>3PATC (In reply to Andre Klapper from comment #3) > Florian: Why is this fixed? The patch isn't merged yet. Argh, sorry, my fault, i only saw... [12:45:34] love that bugname [13:03:34] (03PS1) 10Florianschmidtwelzow: Adjust mobileWebEditing to fit anon editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162877 (https://bugzilla.wikimedia.org/71252) [13:14:52] 3Wikipedia App / 3Android App: NPE when pageimages.PageImageSaveTask.onFinish calls data.ContentPersister.upsert - 10https://bugzilla.wikimedia.org/68895#c3 (10Alex Monk) Was there any loss in functionality for users? If not, 'resolved fixed' should work as well. [13:29:40] 3Wikipedia App / 3Android App: android.view.WindowManager$BadTokenException: Unable to add window -- token is not valid; is your activity running? - 10https://bugzilla.wikimedia.org/71299 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;... [13:58:05] hm - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7835042 [14:07:14] 3Wikipedia App / 3Android App: Issues with Google Plus interaction - java.lang.SecurityException: Permission Denial: starting Intent { act=android.intent.action.VIEW - 10https://bugzilla.wikimedia.org/71301 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None https://ticket.wikimedia.org/otrs/index.pl?Acti... [14:08:39] 3Wikipedia App / 3Android App: SecurityException: Permission denied (missing INTERNET permission?) - 10https://bugzilla.wikimedia.org/67948 (10Alex Monk) [14:08:39] 3Wikipedia App / 3Android App: Issues with Google Plus interaction - java.lang.SecurityException: Permission Denial: starting Intent { act=android.intent.action.VIEW - 10https://bugzilla.wikimedia.org/71301 (10Alex Monk) [14:12:52] 3Wikipedia App / 3Android App: IllegalArgumentException: View not attached to window manager causing crashes - 10https://bugzilla.wikimedia.org/67947 (10Alex Monk) 5RESO/FIX>3REOP [14:13:07] 3Wikipedia App / 3Android App: IllegalArgumentException: View not attached to window manager causing crashes - 10https://bugzilla.wikimedia.org/67947#c5 (10Alex Monk) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7758193 [14:20:08] 3Wikipedia App / 3Android App: Saved pages are not ordered in a useful way - 10https://bugzilla.wikimedia.org/67028 (10Alex Monk) [14:20:10] 3Wikipedia App / 3Android App: Change order of saved pages - 10https://bugzilla.wikimedia.org/70186 (10Alex Monk) [14:28:11] (03CR) 10Jackmcbarn: "This whole thing scares me a lot." (033 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [14:38:25] (03PS4) 10Nemo bis: Added private-wiki-only lua extensions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [15:06:05] (03CR) 10Anomie: [C: 04-2] "Why would a Scribunto module need to be *writing* pages? Why would it need access to the GET/POST parameters, much less the user's cookies" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [15:18:16] (03CR) 10Jackmcbarn: "Also, what's the on-wiki Lua module going to do that couldn't just be done from PHP?" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [15:20:38] 3MobileFrontend / 3stable: False "already logged in" message on user create form - 10https://bugzilla.wikimedia.org/71307#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/3PKURtsw [15:20:42] 3MobileFrontend / 3stable: False "already logged in" message on user create form - 10https://bugzilla.wikimedia.org/71307 (10Florian) 3NEW p:3Unprio s:3trivia a:3None If you go to the account creation form (http://localhost/index.php/Special:UserLogin?type=signup&mobileaction=toggle_view_mobile) and... [15:27:24] bearND|away: ^ added more comments, and improved scrolling based on your comment (it's quite a bit better). Rebasing the other one now... [15:28:37] (03CR) 10jenkins-bot: [V: 04-1] Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [15:28:56] * dbrant slaps jenkins [15:30:44] (03PS13) 10Dbrant: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 [15:37:17] (03PS7) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 [15:39:30] dbrant: sounds great! :) [15:41:30] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7838331 [15:44:34] looks like spam... [15:49:37] +1 dbrant [16:08:38] 3MobileFrontend / 3Hygiene: Views used to like Models - 10https://bugzilla.wikimedia.org/64933#c1 (10Jon) 5NEW>3RESO/WOR I don't think this bug is actionable and am hoping it will come out of UI standardisation [1] so closing. [1] https://www.mediawiki.org/wiki/User:Jdlrobson/Quest/Frontend_UI_standardis... [16:10:37] 3MobileFrontend / 3Hygiene: VisualEditor uses different class names to mobile - leads to duplicate CSS - 10https://bugzilla.wikimedia.org/64973#c1 (10Jon) 5NEW>3ASSI I am hoping this will be fixed as part of UI standardisation [1] [1] https://www.mediawiki.org/wiki/User:Jdlrobson/Quest/Frontend_UI_stand... [16:13:11] (03PS5) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [16:15:07] 3MobileFrontend / 3Hygiene: Code Hygiene: Standardise between forEach and $.each usage - 10https://bugzilla.wikimedia.org/63454#c2 (10Jon) forEach is used in api.js, PageApi.js, application.js and View.js Polyfills were dropped in I55629aca3646367694c23b2e3fca6f2db31a96f7 but we probably want to support IE8? [16:18:08] 3MobileFrontend / 3Hygiene: Make mobileFrontend an object created with "new" - 10https://bugzilla.wikimedia.org/44264 (10Jon) s:5enhanc>3normal [16:24:02] dbrant: it's improved with the last PS but overall this patch still feels like a step back from a UX perspective. Can we keep a few fragments with their webviews in memory? [16:24:38] dbrant: on a slow device and long article it still takes a long time for the scroll to happen [16:24:58] Maybe YuviPanda has some ideas? [16:25:22] ah, hmm [16:25:33] bearND: I don't know of a way to keep only a certain number of fragments in memory... [16:26:23] I guess that'll need custom code... [16:27:17] another suggestion would be to maybe show a progress bar before the section we want to scroll to is loaded. At least it's not that big of a surprise when we suddenly scroll [16:29:36] bearND: hmm, a progress bar while the page continues to load is a good idea in general. But where would we show it? [16:31:21] same as chrome, I guess? super thin, at top of chrome if there's no search bar, and under it if htere is? [16:31:39] dbrant: In the past we've been just showing the progress wheel in the center of the screen, but I would prefer a straight line progress bar at the top of the fragment, just under the action bar [16:32:16] yeah, what YuviPanda said [16:36:06] 3MobileFrontend / 3Hygiene: Standardize page-loaded event across stable/beta/alpha - 10https://bugzilla.wikimedia.org/45299#c2 (10Jon) 5NEW>3ASSI I guess this will go with the death of the ajax loading feature. [16:37:37] 3MobileFrontend / 3Hygiene: Use real (logic-less) templates to generate HTML - 10https://bugzilla.wikimedia.org/44130#c4 (10Jon) 5NEW>3ASSI We will be exploring this as part of the UI standardisation project (templating in core) [16:38:53] (03PS1) 10Cmcmahon: QA: workaround for ChromeDriver bug with confirm dialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162915 [16:39:02] (03CR) 10Yurik: "Anomie, thx for the review, and thx for xkcd ref - haven't seen it yet, but very appropriate :)" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [16:42:04] (03PS2) 10Cmcmahon: QA: workaround for ChromeDriver bug with confirm dialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162915 [16:42:33] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162915 (owner: 10Cmcmahon) [16:43:07] (03Merged) 10jenkins-bot: QA: workaround for ChromeDriver bug with confirm dialog [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162915 (owner: 10Cmcmahon) [16:47:54] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676 (10Jon) 5PATC>3NEW [16:48:52] 3MobileFrontend / 3stable: Zoom and scroll gestures unusable on mobile browsers - 10https://bugzilla.wikimedia.org/69414#c19 (10Jon) 5PATC>3RESO/FIX Should be fixed by https://gerrit.wikimedia.org/r/160855 [16:50:23] 3MobileFrontend / 3stable: Search results + pageimages garbled on beta labs on iOS devices - 10https://bugzilla.wikimedia.org/68880 (10Jon) 5PATC>3RESO/FIX [16:51:08] 3MobileFrontend / 3General/Unknown: API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output - 10https://bugzilla.wikimedia.org/67054 (10Jon) 5PATC>3NEW [16:52:07] 3MobileFrontend / 3General/Unknown: Many Difficulties in Mobile Display of Hebrew WIkisource - 10https://bugzilla.wikimedia.org/66958 (10Jon) 5PATC>3RESO/FIX [16:54:48] (03CR) 10Anomie: "Re security, "We can have security holes here because it's a locked-down wiki" doesn't justify security holes, IMO. But if you can convinc" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [16:57:00] (03CR) 10BearND: Make page browsing into a Fragment. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [17:03:48] (03PS5) 10Yurik: Added private-wiki-only lua extensions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 [17:04:04] bmansurov, seen https://bugzilla.wikimedia.org/show_bug.cgi?id=69721#c4 ? [17:04:44] that's why you should try to make your commits not depend on each other if possible [17:05:31] bearND: it looks like we'll be able to make a horizontal progressbar as part of the ActionBar: http://stackoverflow.com/questions/9157504/put-a-progressbar-on-actionbar [17:05:35] otherwise, take a look at jdlrobson's commits: he chains them a lot and as a result has a ton of unmerged ones:P [17:08:07] dbrant: cool find [17:11:55] (03Abandoned) 10Mhurd: Fix for iPhone 6 using blurry scaled layout. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/161630 (owner: 10Mhurd) [17:16:21] kaldari: https://office.wikimedia.org/wiki/Goals/2014-2015/Engineering_and_Product_Development/Ryan_Kaldari [17:25:27] (03PS2) 10Mhurd: Fix for share button on iPad [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/162480 (https://bugzilla.wikimedia.org/71189) (owner: 10Brion VIBBER) [17:27:07] brion: hey i rebased and amended that ipad popover patch ^ - had a bug w ipad 2 on ios7 [17:27:18] woop [17:27:19] thanks! [17:27:52] agh i gotta run to a meeting, i’ll be on hangouts all day i think :) [17:28:00] brion: haha ok :) [17:28:27] brion: oh i got the AFNetworking stuff to do section retrieval :) [17:28:53] brion: jumping back on the scaling stuff today though [17:29:22] sweet! [17:30:02] brion: it seems to work pretty nicely! have to do same for preview stuff, but i’m feeling pretty good about it [17:31:14] brion: adding cocoapods and the AF libraries and doing HPPLE via cocoapods means lots of new files in the repo though. thankfully updating is as simple as running single cocoapods command [17:31:23] sweet [17:32:45] brion: here’s the work-in-progress branch: https://github.com/montehurd/apps-ios-wikipedia/commits/articleRetrievalRefactor3 [17:50:53] jdlrobson, kaldari: is there a way to load a test html file via qunit? I have a long html for test purposes, but it looks ugly to write it into the qunit js file :/ [17:59:40] yeh FlorianSW checkout templates tests in Extension:Mantle [18:00:12] (e.g. use a template) [18:01:41] * jdlrobson waves at bmansurov [18:03:01] MaxSem, sorry was in a meeting. So that commit has a dependency, which I don't know how to remove. Can you help? [18:03:08] jdlrobson, how'd you wave at me? [18:03:16] jdlrobson: ok, yeah :) [18:03:43] bmansurov: with "/me waves at bmansurov" :) [18:03:56] * bmansurov waves at FlorianSW [18:04:05] exactly :) [18:04:18] you can use every text ;) [18:04:49] FlorianSW, any other cool tricks? [18:05:36] FlorianSW: öhm, not for now :) [18:06:31] bmansurov: to your dependency: I don't know any easy way to remove the false dependency :) To understand, what this means: Gerrit recognized, that you submitted a patch, which is based on a commit, which is ahead of master [18:06:52] this means, there is master->patch1->patch2 (where patch two is your one) [18:07:29] so to merge patch2 into master, patch1 has to be merged first, otherwise there is missing code/missing changes [18:08:03] FlorianSW, OK, is abandoning the patch set and redoing it a solution? [18:08:21] bmansurov: the only solution i know :) [18:08:35] FlorianSW, OK thanks [18:11:15] bmansurov: np ;) [18:22:58] Fatal error: Call to a member function getFullURL() on a non-object in /srv/mediawiki/php-1.25wmf1/extensions/MobileFrontend/includes/MobileContext.php on line 912 [18:23:48] bmansurov: you can cherry pick to master [18:23:52] (03Abandoned) 10Bmansurov: Add notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [18:23:57] bmansurov, before working on a new card, switch to master [18:24:12] (03PS1) 10Bmansurov: Add and format notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162940 (https://bugzilla.wikimedia.org/69721) [18:24:15] eh, you don't need to abandon [18:24:30] Reedy, looking [18:24:31] MaxSem, I just did [18:24:35] (03Restored) 10Jdlrobson: Add notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [18:24:46] jdlrobson, can you explain more? [18:24:47] ^ bmansurov i restored [18:24:59] right at the bottom of gerrit is a `cherry pick to` button [18:25:04] jdlrobson, I also submitted a new review [18:25:04] click that and type master [18:25:11] `refs/head/master` [18:25:42] (03PS4) 10Bmansurov: Add notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) [18:25:49] jdlrobson, done [18:26:47] jdlrobson: thanks for this nice info :) [18:27:17] Deskana: Are we having iteration review? [18:27:41] vbamba: As far as I know, yes. [18:27:48] We can always end quickly if there's nothing to discuss. [18:30:02] (03CR) 10Yurik: "Your concern with code review is very valid, and I think the best way to address it is to auto-export all lua modules to a git repository " [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [18:32:38] bearND come join us [18:35:36] Reedy, aha - that's some core change that broke MW:P [18:36:58] Does anyone know what the ask "Roadmap for FE Standards" means? [18:37:02] It's an ask in the quarterly review. [18:37:07] But it means nothing to me. [18:39:37] Deskana: FrontendEngineering standards, I think [18:39:44] Deskana: I don't think Mobile Apps will have anything there [18:39:50] http://hatjitsu.wmflabs.org/69584 [18:39:56] That explains why I don't understand that. [18:39:59] heh [18:40:05] Deskana: oh i’m in that i think but not the rest of y’all :) [18:41:07] (03CR) 10Jdlrobson: [C: 032] Add notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [18:41:33] (03Abandoned) 10Jdlrobson: Add and format notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162940 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [18:41:40] (03Merged) 10jenkins-bot: Add notification cap [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162775 (https://bugzilla.wikimedia.org/69721) (owner: 10Bmansurov) [18:42:21] bmansurov: could you help out with code review? Maybe +1 the ones you've tested and work that don't have any badly written JS. Feel free to +2 if you feel confident enough :) [18:42:47] jdlrobson, sure [18:42:54] bmansurov: this might be a good time to get you up to date with how `make gerrit` works [18:43:07] ok [18:43:27] milimetric: you around? [18:43:34] yep, hi [18:43:46] can we update hte limn graphs? [18:43:52] one sec [18:43:54] it's been a while since i've run the deploy script so i can't remember how to do it [18:44:02] bmansurov: so what happens when you run `make gerrit` ? [18:44:19] python error [18:44:25] fab mobile_reportcard deploy.only_data [18:44:32] done jdlrobson [18:44:42] jdlrobson, print '#%s: %s'%(index, project) <<<< invalid syntax [18:45:02] (03CR) 10Jdlrobson: [C: 032] Adjust mobileWebEditing to fit anon editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162877 (https://bugzilla.wikimedia.org/71252) (owner: 10Florianschmidtwelzow) [18:45:16] bmansurov: try "print '#{}: {}'.format(index, project) [18:45:18] * jdlrobson hugs milimetric [18:45:34] (03Merged) 10jenkins-bot: Adjust mobileWebEditing to fit anon editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162877 (https://bugzilla.wikimedia.org/71252) (owner: 10Florianschmidtwelzow) [18:45:41] bmansurov: so yeh that's a python version problem [18:45:43] milimetric, change the file? [18:45:52] milimetric, File "dev-scripts/remotes/gerrit.py", line 162 [18:46:26] milimetric, i think print is the problem here [18:46:27] :) ignore me, i've no idea what you're doing - but that syntax is preferrable when formatting strings in python (less headaches) [18:46:47] milimetric, python 3 needs () after print [18:47:04] oh you're in 3, right, yep [18:47:09] milimetric: did it break :-S http://mobile-reportcard.wmflabs.org/ [18:47:33] looks like it jdlrobson [18:47:38] uhohhhh [18:47:39] i'll debug [18:47:48] thanks milimetric [18:49:00] jdlrobson, should I review cards that have already been reviewed by someone else like this one: https://gerrit.wikimedia.org/r/#/c/162178/ [18:49:10] 3MobileFrontend / 3stable: I got 99+ notifications but the label ain't one (it says 100 instead) - 10https://bugzilla.wikimedia.org/69721 (10Jon) 5PATC>3RESO/FIX [18:49:41] bmansurov: so it's not really worth reviewing things that are -1ed [18:49:48] ok [18:49:49] so bmansurov quick fix for your problem with `make gerrit` [18:49:56] open dev-scripts/remotes/gerrit.py [18:50:02] and change the top to point to the right python version [18:50:42] jdlrobson, ok that worked and I see this: Enter number of patchset to checkout (Press enter to exit): [18:50:52] so bmansurov this is like choose your own adventure [18:51:00] the patches at the top are the ones that need review the most [18:51:05] unless they are +2ed :) [18:51:17] patches at the bottom have already been reviewed and need more work [18:52:14] bmansurov: if you type the number in it will check out the patch for you [18:52:23] which saves you having to deal with the gerrit interface which is why i like it [18:52:28] jdlrobson: I self-merged the fix and deployed. Simple json syntax: https://gerrit.wikimedia.org/r/#/c/162945/ [18:52:39] milimetric: haha [18:52:41] jdlrobson, i'm trying to find an easier to review patch [18:52:42] good catch [18:53:01] thanks a bunch milimetric [18:53:08] * jdlrobson gives millimetric huge hug [18:53:09] np [18:53:30] thanks milimetric [18:53:36] jdlrobson, I picked a patch and downloaded it [18:53:38] milimetric: i think we need to regenerate the thanks graph though :/ [18:53:40] milimetric: you must be owe'd a lot of drinks thanks to Limn :D [18:53:44] bmansurov: which patch did you download? [18:53:50] jdlrobson: you mean the data? [18:53:58] milimetric: yup [18:54:02] limn: the drink maker [18:54:06] http://mobile-reportcard.wmflabs.org/graphs/thanks-daily has been broken since march [18:54:07] lolz [18:54:08] jdlrobson, 15: Hygiene: Add back button partial (by Jdlrobson, 1 days old) [0] [18:54:17] jdlrobson: that'll happen automatically whenever the cron picks it up on stat1003 [18:54:18] bmansurov: awesome. [18:54:28] bmansurov: so yeh take a look through the diff, check nothing looks broken [18:54:28] oh - i see [18:54:32] and then +1/+2 as necessary [18:54:50] jdlrobson, can I do +1/+2 in the terminal too? [18:54:54] milimetric: i think the thanks daily graph gets cached [18:54:59] bmansurov: sadly not i didn't get round to doing that :/ [18:55:05] you have to go to the url it prints [18:55:06] jdlrobson, ok [18:55:52] 3MobileFrontend / 3alpha: EventLogging on alpha anonymous editing being thrown away - 10https://bugzilla.wikimedia.org/71252 (10Jon) 5PATC>3RESO/FIX [18:56:15] bmansurov: also note https://gerrit.wikimedia.org/r/#/c/162665/ is -1ed [18:56:17] needs some work [18:56:36] jdlrobson, ok, can you tell me how to use git diff in this case? [18:57:13] git diff HEAD^ [18:57:17] that will diff your latest commit [18:57:26] you can also use the web interface for that [18:57:49] jdlrobson, about the -1ed above, I also left a comment on your comment, but for some reason it says 'draft' [18:58:17] FYI bmansurov today is deployment day. Branches were cut yesterday night so Thursday is great day to merge big changes :) [18:58:21] bmansurov: ahhh [18:58:31] bmansurov: Click Review (or add comment) and save :) [18:58:34] bmansurov: ok so gerrit interface is crappy here. you have to click the review button [18:58:39] and then it will publish it lolz [18:58:43] it's no github [18:58:49] but we have fabricator coming very soon [18:59:38] phabricator :D [18:59:53] jdlrobson, where is the review button, I only see save, cancel, discard [19:00:00] try save [19:00:06] it might be that you've not got permission to review yet [19:00:09] jdlrobson, what do you mean by 'branches were cut yesterday night'? [19:00:21] oh wait bmansurov [19:00:26] jdlrobson, after save it says 'edit' [19:00:35] and still in draft [19:00:44] bmansurov: review button is on https://gerrit.wikimedia.org/r/#/c/162665/ [19:00:50] not the diff [19:00:54] not very obvious [19:01:07] bmansurov: i'll answer your other question once that's dealt with [19:01:34] jdlrobson, can I not add an inline review? [19:02:06] bmansurov: so clicking review will publish all the notes on the draft [19:02:11] on the diff [19:02:24] it's limited interface but you'll have to cope with it for a bit :) [19:03:21] jdlrobson: that graph is fine, the sql is querying a table that stopped getting data [19:03:22] https://github.com/wikimedia/analytics-limn-mobile-data/blob/master/mobile/thanks-daily.sql#L8 [19:03:23] (03CR) 10Bmansurov: "added an inline comment" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162665 (https://bugzilla.wikimedia.org/68990) (owner: 10Bmansurov) [19:03:26] that table has no data since march [19:03:45] jdlrobson, ok the comment has been published [19:03:58] milimetric: it doesn't? o_O [19:04:22] nope. did the schema change maybe and that needs to be a union? [19:04:37] * jdlrobson wonders that too [19:05:18] ^ kaldari [19:06:06] bmansurov: ok so with respect to "deployment branch has been cut". So every thursday Reedy cuts a branch e.g. git checkout -b NewDeploymentBranch and that gets pushed to mediawiki.org [19:06:15] a week later those changes propogate to English Wikipedia [19:06:30] it's a bit more complicated than that but that's essentially how stuff gets deployed - once a week [19:06:34] kaldari / jdlrobson: I see Echo_7572295 and Echo_7731316 and the latter has data as of yesterday [19:06:37] so that makes sense [19:07:09] jdlrobson, I see. By "merge big changes" do you mean push my code for review, or just get open bugs +2ed? [19:07:12] if you change that sql / merge the change, everything else would happen automatically. Then let me know and I'll tell it to re-do the results it doesn't have [19:07:19] shouldnt' the graph show the recent date milimetric ? [19:07:43] bmansurov: so every time you +2 you are contributing to the branch that goes live next thursday [19:07:50] jdlrobson: the cron job thinks there are no results because they're always coming back as 0 [19:07:51] so obviously don't make any huge changes wednesday lunchtime [19:07:58] jdlrobson, makes sense [19:09:07] jdlrobson: if you look at the actual CSV, each day there are just 0s [19:11:35] jdlrobson, so the patch I picked doesn't have a bug associated with it, and I'm not sure how to test it in the browser. [19:16:35] kristenlans: Deskana: sorry, totally spaced out the meeting earlier. [19:16:56] bearND: No worries, as it's unstructured we didn't discuss anything Android related. [19:17:07] Deskana: ah, good [19:19:15] bmansurov: so that patch is marked hygiene right? [19:19:25] jdlrobson, yes [19:19:42] The hygiene patches should not change any functionality according to https://www.mediawiki.org/wiki/Mobile_web/Coding_conventions#Commit_Messages [19:19:52] so in these cases it's good to look at what code they touch [19:20:03] and check the functionality works still for them. [19:20:04] jdlrobson, ok [19:20:17] jdlrobson, how do I check the functionality? [19:20:18] So this one changes the back button, so best thing to test would be the back button of all the overlays it touches [19:20:29] jdlrobson, i see [19:20:31] just load your browser and compare the master version with this branch [19:20:39] ok [19:22:37] (03PS4) 10Florianschmidtwelzow: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) [19:24:49] (03PS5) 10Florianschmidtwelzow: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) [19:24:52] (03CR) 10Jdlrobson: Add padding to mobile talk icon text in RTL (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162665 (https://bugzilla.wikimedia.org/68990) (owner: 10Bmansurov) [19:25:49] milimetric: it is possible for you to edit the csv file and remove the last few lines? [19:25:54] i suspect it is caching [19:26:44] jdlrobson: my point is, cached or not, the query is wrong. There are no records in the table it's querying [19:26:52] so if I remove those lines, it would just fill them with 0s again [19:26:55] Maryana: where you at anyway? [19:26:56] until the query is fixed [19:27:00] milimetric: wait yeh i see what you mean [19:27:04] kaldari lied to me :P [19:27:09] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Really, that's not, what i want to submit to review :/ But i'm finished for today, i'm open for help and any idea what/how this can be imp" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [19:27:10] that liar! [19:27:33] you see those two tables I pasted? Those are more recent versions of that schema [19:27:45] Echo_7572295 and Echo_7731316 [19:29:53] milimetric: fixing it now.. [19:35:30] milimetric: so apparently https://gerrit.wikimedia.org/r/#/c/162779/ is where we went wrong [19:35:49] milimetric: can we have a redeploy (sorrrrry) [19:35:53] milimetric: Looks like the patch to update that one never got merged: https://gerrit.wikimedia.org/r/#/c/162779/1/mobile/thanks-daily.sql [19:36:03] milimetric: But it's not that important for now [19:36:17] k [19:36:37] there's nothing to re-deploy, it'll just start working [19:36:52] but the old data will need to be refreshed [19:37:10] I'm reading through the code now to figure out how it's doing that... I thought there was a history file but that hasn't been updated since july [19:37:10] FlorianSW: i'll take a look at the issues patch today if i get time [19:37:14] did you guys change it? [19:38:10] jdlrobson: great :) i stopped at the tests unhappily :/ [19:38:19] jdlrobson, how can I see both the local master branch and the patch in two browser tabs? [19:38:53] bmansurov: you cant.. you'll have to try one and then try the other [19:39:04] when you get to know how the site works you'll just know without having to resort to master [19:39:11] if you want you can compare beta labs i guess [19:39:16] with your local version [19:39:29] jdlrobson, ok thanks [19:40:27] milimetric: i think it uses the csv file itself [19:40:47] as it's a daily graph - so it will load the csv file and look at when it needs to start measuring from [19:41:08] 3Wikipedia App / 3Android App: Add Wikipedia app to share menu - 10https://bugzilla.wikimedia.org/71234#c1 (10Dmitry Brant) I'm not sure that putting Wikipedia in the "share" menu is the best option, because it wouldn't be at all obvious that "share" really means "search" in this case. If there is a way to... [19:42:05] jdlrobson: you're right, but man that logic is way complicated :) [19:42:11] milimetric: :P [19:43:15] k, I'll ask someone with root to delete the 0s from that file and then it should regenerate by itself [19:48:09] jdlrobson, does /templates/modules/talk/talkSectionHeader.hogan show up when a user hits the talk icon? [19:48:22] i suspect so [19:48:29] (in betaa) [19:48:39] jdlrobson, how I can find out about it easily? [19:48:52] start looking at TalkOverlay.js [19:49:02] and the template / templatePartials it uses [19:49:08] jdlrobson, ok [19:55:24] bmansurov: sitenote: but for talkSectionHeader.hogan i suggest TalkSectionOverlay.js :) [19:55:51] FlorianSW, ok thanks [19:59:32] (03PS3) 10Jdlrobson: Support internal redirects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162178 (https://bugzilla.wikimedia.org/69020) [20:01:02] (03PS4) 10Jdlrobson: Support internal redirects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162178 (https://bugzilla.wikimedia.org/69020) [20:09:10] 3MobileFrontend / 3General/Unknown: MobileFrontend fatal in SpecialPage_initList hook - 10https://bugzilla.wikimedia.org/71329 (10Brad Jorsch) 3NEW p:3Unprio s:3critic a:3None Part of the problem in bug 70686 was that we were blindly redirecting special pages without knowing that the redirect target... [20:10:23] 3MobileFrontend / 3General/Unknown: MobileFrontend fatal in SpecialPage_initList hook - 10https://bugzilla.wikimedia.org/71329#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/OxXcHddW [20:26:21] YuviPanda: yes, we have the chat up [20:26:30] tfinc: good to know :) [20:26:42] jdlrobson: I am not sure why the linter is failing. It shows tabs in both gerrit and my editor. I can't seem to be able to fix this. [20:28:06] jdlrobson: found it [20:29:25] 3Wikipedia App / 3Android App: JSONException: Value 3Wikipedia App / 3Android App: JSONException: Value 3Wikipedia App / 3Android App: UnknownHostException: Unable to resolve host "lang.m.wikipedia.org": No address associated with hostname - 10https://bugzilla.wikimedia.org/71332 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None Network errors like this should be shown to the user, not cause the app to cr... [20:59:16] (03PS6) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [21:15:36] (03PS1) 10Jdlrobson: Ensure mw.user is available to WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163022 [21:24:20] hehe. we judst dodged a javascript error bullet [21:24:54] When I clicked next i got Uncaught TypeError: undefined is not a function [21:25:06] i was sweating as kaldar1 clicked next [21:25:51] ;) [21:26:38] 3MobileFrontend / 3beta: Wikigrok - clicking next doesn't always work - 10https://bugzilla.wikimedia.org/71335 (10Jon) 3NEW p:3Unprio s:3normal a:3None There is a JavaScript error in the console :-( [21:26:40] (03PS2) 10Jdlrobson: Ensure mw.user is available to WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163022 (https://bugzilla.wikimedia.org/71335) [21:29:37] 3MobileFrontend / 3beta: Wikigrok - clicking next doesn't always work - 10https://bugzilla.wikimedia.org/71335#c2 (10Jon) 5PATC>3NEW Seems Wikigrok sends boolean value under some circumstances. jQuery1111049327613739296794_1411680543103({"status":"OK","occupations":false}); [21:29:42] (03PS3) 10Jdlrobson: Ensure mw.user is available to WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163022 [21:30:38] 3MobileFrontend / 3beta: Wikigrok - clicking next doesn't always work - 10https://bugzilla.wikimedia.org/71335#c3 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/TSLOKU3G [21:40:56] brion: Can you tell Yuvi that I am reading what he's saying. :) [21:41:03] brion: I just can't respond since I'm not in the hangout. [21:41:25] brion: Thanks. :) [21:41:30] :D [21:41:36] Deskana: i know :) [21:41:48] SadPanda: Oh, there you are. [21:41:50] Deskana: I'm just slightly frustrated that they don't seem to be taken too seriously [21:42:00] Deskana: I am also typing them there so peopel can read htem [21:42:23] SadPanda: The more I think about it, the more I think we can't start to tackle these problems yet. [21:42:55] SadPanda: I'm in 100% agreement with you. Every time I'm asked "What is the holistic view of contributing on apps?", I describe what I literally call "the cliff users hurl themselves off that is getting blocked" [21:43:09] There is no flow. There is only death. [21:43:44] Deskana: we aren't even trying :( The fact that we are building an app for what, at its core, is perhaps the most wonderful *community* (that happens to be on a website), and have *absolutely* no way for new people to join that community, feels (personally), *very* wrong [21:43:44] This is the downside of pushing out an MVP. [21:43:56] It's the downside of dealing with legacy technology. [21:44:03] we aren't trying, is all I can say. [21:44:19] SadPanda: Well, bear in mind that 99% of people that use the app aren't even tapping edit even once. [21:44:22] 3MobileFrontend / 3beta: Wikigrok - clicking next doesn't always work - 10https://bugzilla.wikimedia.org/71335#c4 (10Jon) The patch relates to another problem so restored NEW status. Basically some articles will not have any suggested occupations. There is no second screen.. [21:44:40] Deskana: sure, and more people are getting blocked than are becoming active editors. [21:44:53] It's the age old question of "is something that's a little bad for 99% of people more important than something that's fucking awful for 1%?" [21:45:02] No matter what way you look at it, you get an unsatisfactory answer [21:45:20] Especially since we only have two engineers per platform [21:45:44] I'm reiterating that to people more and more, too [21:45:58] You can say "apps has four engineers" but really we've only got two, since we have to do everything twice [21:46:08] Deskana: sure, I'll be happy if we say 'right, we are going to build a top notch reading platform, and then we go make it contributor friendly, make it possible for people to join the community', but I don't think that is what's being said [21:46:35] SadPanda: This isn't binding forevermore. :) [21:46:42] SadPanda: It's our focus for the next quarter or two. [21:46:57] We need Flow to tackle the discussions issue. [21:47:22] Deskana: I thought we had a meeting with the Flow PM where we decided to not do that :) [21:47:43] SadPanda: Yes, and honestly their progress has been incredibly disappointing. [21:48:01] They're no where near being close to us being able to make all mobile user talk pages Flow. [21:48:08] jdlrobson: ping [21:48:29] Deskana: :D we can't use flow until it's enabled *everywhere* (as in, desktop/mobile) as well, and personally I think that's about 2y away. [21:50:24] :( [21:51:02] :( [21:51:04] if we are aware of that (not just 2Y, but xY for any value of x), and are ok with letting people not be able to *join the community* until then, if that is an informed decision, then I guess that's ok [21:51:46] SadPanda: Well, it's about defining what "mobile Wikipedian" means, and it's not the same as desktop for now. [21:52:06] It's the harsh reality of the resources we have available to us. [21:52:20] Two engineers per platform! [21:53:08] I think that we get the biggest reward per unit cost with trying something new. [21:53:37] 3MobileFrontend / 3beta: SkinAfterBottomScripts doesn't run on mobile (Conflict with Google Analytics Integration extension) - 10https://bugzilla.wikimedia.org/61462#c7 (10Jon) 5PATC>3RESO/FIX This is fixed on master so status shouldn't have changed. [21:53:38] Frankly, I'd rather try something crazy and see it fail rather than *not* do it and wonder what would've happened. [21:54:05] :( ok [21:54:20] jdlrobson, meet in 10 mins? [22:01:10] (03CR) 10Kaldari: [C: 032] Ensure mw.user is available to WikiGrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163022 (owner: 10Jdlrobson) [22:02:53] bmansurov: hey [22:02:57] sorry we are running late [22:03:35] jdlrobson, should we start? [22:03:40]