[00:00:57] kaldari, OK, I will [00:12:50] jdlrobson: I've updated https://gerrit.wikimedia.org/r/#/c/162147/ the other one is a bit tricky [00:17:45] (03CR) 10Jdlrobson: [C: 04-1] "apart from that good to go." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162799 (owner: 10Kaldari) [00:18:25] kaldari: do you mean remove the comment in https://gerrit.wikimedia.org/r/#/c/162133/4/javascripts/modules/wikigrok/WikiGrokDialog.js [00:22:45] jdlrobson: Sorry, that's meant for the line underneath [00:23:02] jdlrobson: this.apiWikiGrok.getPossibleOccupations( options.itemId ) [00:23:13] the param is no longer defined in the method [00:25:07] 3MobileFrontend / 3beta: Breaking VisualEditor breaks wikitext editor - 10https://bugzilla.wikimedia.org/66678 (10Jon) 5PATC>3RESO/FIX [00:26:08] 3MobileFrontend / 3General/Unknown: Mobile Thanks graph is broken - 10https://bugzilla.wikimedia.org/68400#c4 (10Jon) 5ASSI>3RESO/FIX This is now logging again. [00:28:54] (03PS5) 10Jdlrobson: Hygiene: Add recordOccupation method to WikiGrokApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162133 [00:29:04] (03PS3) 10Jdlrobson: Hygiene: WikiDataApi::getClaims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162185 [00:29:08] (03PS5) 10Jdlrobson: Hygiene: Move DOM handling out of postRender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162134 [00:29:12] (03PS2) 10Jdlrobson: Hygiene: Add JSONP support to API classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162778 [00:29:16] (03PS2) 10Jdlrobson: Hygiene: Abstract more of the nastiness of the wikidata api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162797 [00:29:43] (03PS7) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [00:39:32] (03PS1) 10Kaldari: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) [00:39:56] (03PS2) 10Bmansurov: Add padding to mobile talk icon text in RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162665 (https://bugzilla.wikimedia.org/68990) [00:41:03] (03CR) 10Bmansurov: "I had to use the .rtl class because the background image is not symmetrical and @noflip wasn't of use." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162665 (https://bugzilla.wikimedia.org/68990) (owner: 10Bmansurov) [00:42:22] jdlrobson: Here's the bug fix for WikiGrok: https://gerrit.wikimedia.org/r/#/c/163070/ [00:44:09] (03PS3) 10Kaldari: Hygiene: Gitting rid of skins.minerva.chrome.styles.beta and uiNew.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162799 [00:44:13] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Gitting rid of skins.minerva.chrome.styles.beta and uiNew.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162799 (owner: 10Kaldari) [00:45:51] (03PS4) 10Kaldari: Hygiene: Gitting rid of skins.minerva.chrome.styles.beta and uiNew.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162799 [00:50:27] (03CR) 10Kaldari: [C: 032] Hygiene: Add recordOccupation method to WikiGrokApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162133 (owner: 10Jdlrobson) [00:50:58] (03Merged) 10jenkins-bot: Hygiene: Add recordOccupation method to WikiGrokApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162133 (owner: 10Jdlrobson) [00:53:49] (03PS2) 10Kaldari: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) [00:55:16] (03PS1) 10MaxSem: Fix fatals due to core changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163073 (https://bugzilla.wikimedia.org/71329) [00:57:04] (03PS8) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [01:17:32] (03PS3) 10Kaldari: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) [01:22:07] (03PS1) 10Kaldari: Adding mobile.startup to wikigrok dependencies for debug=true [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163079 [01:25:28] (03CR) 10MaxSem: [C: 032] Adding mobile.startup to wikigrok dependencies for debug=true [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163079 (owner: 10Kaldari) [01:25:58] (03Merged) 10jenkins-bot: Adding mobile.startup to wikigrok dependencies for debug=true [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163079 (owner: 10Kaldari) [04:38:40] (03CR) 10Yurik: "There are three overlapping issues here: security, approach, functionality. Security is straightforward -- either it can cause unauthorize" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [05:06:21] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Gitting rid of skins.minerva.chrome.styles.beta and uiNew.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162799 (owner: 10Kaldari) [06:29:19] (03CR) 10Tim Starling: "For the record, Yurik did not discuss with me the idea of exposing the whole action API to Lua. Yurik showed me this code:" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [06:33:36] (03PS6) 10Florianschmidtwelzow: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) [06:34:11] (03CR) 10Tim Starling: "I think it's fair to say that inventing a whole new platform for rapid prototyping is not the usual method for doing a single rapid protot" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [06:35:54] (03PS7) 10Florianschmidtwelzow: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) [07:08:32] (03CR) 10Yurik: "API is a preferred way because the portal will need to query certain things from wiki, e.g. list all zero configurations (json blobs in Ze" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [13:32:45] hello bmansurov :) [13:33:13] FlorianSW, hi! [13:35:11] (03CR) 10Anomie: "> Also, WikiData's DanielK was very supportive of read API access and thinks it would be good on the regular wikis." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [14:18:19] * bmansurov is back (gone 00:01:34) [14:18:32] * bmansurov is away: I'm busy [15:29:35] bearND: good call on the factory pattern for fragments! completing now... (there will still be a little special processing related to the "internal" object, as well as changing themes, but it's looking cleaner.) [15:30:06] dbrant: great! [16:14:39] (03PS14) 10Dbrant: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 [16:44:29] (03PS15) 10Dbrant: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 [16:51:52] (03PS1) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163191 [16:54:13] (03Abandoned) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163191 (owner: 10Dbrant) [16:54:47] (03PS8) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 [16:58:25] (03PS9) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 [16:59:04] maryana kaldari mexsem jonrobson are you at/watching Lila’s talk? [17:20:27] (03CR) 10Yurik: "I agree that some API functions could be slow, but so is executing some complex Lua code - that's exactly why we have "expensive call" con" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [17:21:39] bearND: the complexities and slight weirdness of the search stuff is why I rolled my own in the start [17:24:45] (03CR) 10MaxSem: [C: 04-1] "It scrolls to the needed section but doesn't update the hash." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162178 (https://bugzilla.wikimedia.org/69020) (owner: 10Jdlrobson) [17:26:26] 3MobileFrontend / 3Feature requests: Links to talk pages in mobile view - 10https://bugzilla.wikimedia.org/52165 (10Florian) [17:26:26] 3MobileFrontend / 3beta: Talk page overlay lead section - 10https://bugzilla.wikimedia.org/50396 (10Florian) [17:28:50] (03CR) 10MaxSem: [C: 032] Hygiene: Gitting rid of skins.minerva.chrome.styles.beta and uiNew.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162799 (owner: 10Kaldari) [17:29:36] (03Merged) 10jenkins-bot: Hygiene: Gitting rid of skins.minerva.chrome.styles.beta and uiNew.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162799 (owner: 10Kaldari) [17:35:59] (03CR) 10MaxSem: "Do it in core instead?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162778 (owner: 10Jdlrobson) [18:00:38] awjr: joining us for the hiring meeting ? [18:00:48] tfinc yes [18:01:20] awjr: not seeing you on the hangout, do you see us ? [18:02:07] tfinc: joining now [18:05:52] (03PS2) 10BearND: Nearby styling updates [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162475 [18:10:20] (03PS3) 10BearND: Nearby styling updates [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/162475 [18:31:52] 3Wikipedia App / 3General/Unknown: iOS & Android: MobileFrontend styles unconditionally adding borders to tables - 10https://bugzilla.wikimedia.org/68579#c1 (10Ryan Kaldari) Maybe tables within infoboxes shouldn't get automatic borders. [18:36:17] Maryana, jdlrobson: you guys are around? [18:36:36] I forgot to book a room [18:40:25] 3MobileFrontend / 3stable: Audio tags shouldn't have height. Look cramped in mobile. - 10https://bugzilla.wikimedia.org/71365 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16606 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16606&action=edit this problem features on many song a... [18:40:37] 3MobileFrontend / 3stable: Audio tags shouldn't have height. Look cramped in mobile. - 10https://bugzilla.wikimedia.org/71365#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/VZh3nH2X [18:46:22] 3MobileFrontend / 3Feature requests: Disable video and audio tags when not supported - 10https://bugzilla.wikimedia.org/58948#c6 (10Jon) 5UNCO>3RESO/FIX I'm pretty sure this is fixed. As you can see in the screenshot that I will post to followthis up the browser complains it cannot play the file. Provide... [18:46:52] 3MobileFrontend / 3Feature requests: Disable video and audio tags when not supported - 10https://bugzilla.wikimedia.org/58948#c7 (10Jon) Created attachment 16607 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16607&action=edit Cannot play ogg file (on iPhone) [18:47:08] hey DarTar did you find Maryana i'm feeling a bit under the weather today [18:47:55] ah just saw your update mail :) [18:49:35] jdlrobson: yeah, my bad I thought I had invited you to this thing [18:55:10] 3MobileFrontend / 3General/Unknown: Can't scroll to top in editing window - 10https://bugzilla.wikimedia.org/69092#c2 (10Ryan Kaldari) Hmm, works for me in Firefox on Mac. Are you still seeing this? [18:55:10] 3MobileFrontend / 3General/Unknown: Can't scroll to top in editing window - 10https://bugzilla.wikimedia.org/69092 (10Ryan Kaldari) 5NEW>3UNCO [18:55:10] kaldari|2, you there? [18:55:24] bmansurov: in meeting [18:55:32] kaldari|2, OK [18:55:46] MaxSem, you there? [18:55:52] yup [18:56:07] MaxSem, I'm look at this bug but I cannot reproduce it. Can you help? https://bugzilla.wikimedia.org/show_bug.cgi?id=69020 [18:56:22] 3MobileFrontend / 3General/Unknown: Can't scroll to top in editing window - 10https://bugzilla.wikimedia.org/69092#c3 (10Jon) Nemo, what device are you seeing this on? Sounds device specific... [18:56:47] MaxSem, when I search for "Wikipedia Signpost", I just see the search results page, no redirect. [18:57:06] it has changed recently [18:57:29] create a long article with several sections, create a redirect to one of its sections, visit the redirect page [18:57:56] MaxSem, how do I create a redirect to one of its sections? [18:58:18] #REDIRECT [[Page#Section]] [18:58:32] MaxSem, thanks [19:00:28] 3MobileFrontend / 3General/Unknown: Can't scroll to top in editing window - 10https://bugzilla.wikimedia.org/69092#c4 (10Nemo) (In reply to Ryan Kaldari from comment #2) > Hmm, works for me in Firefox on Mac. Are you still seeing this? Thanks for looking. I do, but comment 0 is (now?) incorrect. Point 1 sho... [19:04:27] (03CR) 10Jdlrobson: [C: 04-1] Make sure, issues only added once (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [19:07:34] (03CR) 10Jdlrobson: [C: 04-1] Using same API data for wikigrokeval and askWikidataQuestion (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) (owner: 10Kaldari) [19:13:27] (03PS5) 10Jdlrobson: Support internal redirects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162178 (https://bugzilla.wikimedia.org/69020) [19:17:24] jdlrobson: ajax refresh in mobile web is going away, right? [19:17:43] (03CR) 10Jdlrobson: [C: 032] Add padding to mobile talk icon text in RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162665 (https://bugzilla.wikimedia.org/68990) (owner: 10Bmansurov) [19:18:23] (03Merged) 10jenkins-bot: Add padding to mobile talk icon text in RTL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162665 (https://bugzilla.wikimedia.org/68990) (owner: 10Bmansurov) [19:21:11] 3MobileFrontend / 3General/Unknown: Can't scroll to top in editing window - 10https://bugzilla.wikimedia.org/69092#c5 (10Jon) 5UNCO>3NEW Yeh I can replicate this.. by using down and up cursors. Most strange.. Thanks for the report Nemo! [19:21:52] 3MobileFrontend / 3alpha: the number in mobile talk icon is misplaced in rtl - 10https://bugzilla.wikimedia.org/68990 (10Jon) 5PATC>3RESO/FIX [19:25:31] YuviPanda: yeh looks like it (see mobile-l thread) [19:25:48] doesn't seem to effect editing in anyway [19:26:42] jdlrobson: ah, ok. [19:26:59] jdlrobson: just wanted to ask because analytics. can you remember to give me a ping when it does get killed? [19:27:55] YuviPanda: i have a meeting with analytics monday [19:30:02] kaldari|2: can you merge rest of my wikigrok patches. with you and me both working on this codebase, rebases could get out of control [19:31:01] jdlrobson: totally. I merged a bit yesterday. I'll try to merge the rest of it before I do any more work on wikigrok [19:32:21] kaldari|2: thanks. i'd love to get all the hygiene patches merge so we are working off the same place [19:32:28] i wanted to wrap up my story today [19:32:35] but with all moving parts i don't want to do any more coding on it [19:34:39] (03CR) 10Kaldari: Using same API data for wikigrokeval and askWikidataQuestion (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) (owner: 10Kaldari) [19:35:24] jdlrobson: ah, cool. just wanted a small clarification anyway :) [19:37:13] (03PS4) 10Kaldari: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) [19:37:53] jdlrobson: Also https://gerrit.wikimedia.org/r/#/c/163070 (the wikigrok bug fix) is updated now. [19:39:08] (03PS1) 10Jdlrobson: Stop user profile talk button from being special [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163236 (https://bugzilla.wikimedia.org/71071) [19:39:38] kaldari|2: looks like your patch will cause a rebase conflict on mine.. ergg let me take a look [19:41:39] 3MobileFrontend / 3Feature requests: Icons missing/broken on old Nokia phones (X3, C3) - 10https://bugzilla.wikimedia.org/50326 (10Jon) a:3Jon [19:41:39] 3MobileFrontend / 3Feature requests: Icons missing/broken on old Nokia phones (X3, C3) - 10https://bugzilla.wikimedia.org/50326#c4 (10Jon) 5NEW>3ASSI The Nokia Asha 501 issues are due to lack of background-size support. When we move to MediaWiki UI icons these devices since they do not support pseudo ele... [19:42:10] (03PS5) 10Jdlrobson: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) (owner: 10Kaldari) [19:45:20] (03CR) 10Jdlrobson: [C: 04-1] Using same API data for wikigrokeval and askWikidataQuestion (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) (owner: 10Kaldari) [19:45:35] kaldari|2: i found another issue ;/ [19:46:11] kaldari|2: i think this is going to be easier if you merge mine first.. [19:46:11] (03CR) 10Kaldari: [C: 04-1] Hygiene: WikiDataApi::getClaims (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162185 (owner: 10Jdlrobson) [19:46:21] sure [19:46:55] jdlrobson: Just a small request for that patch [19:47:04] doing it now [19:47:21] thanxz [19:47:58] (03PS4) 10Jdlrobson: Hygiene: WikiDataApi::getClaims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162185 [19:48:17] MaxSem, pre-commit hooks are returning an error: Unable to access network: fail. How can I fix it? [19:48:38] MaxSem, the next line reads: Makefile:69: recipe for target 'qunit' failed [19:49:04] geh, I personally don't use them;) [19:49:07] kaldari: you still able to meet today after 1pm or push it to next week? [19:49:16] MaxSem, can I turn them off? how? [19:49:25] (03PS5) 10Jdlrobson: Hygiene: WikiDataApi::getClaims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162185 [19:49:34] .git/hooks [19:49:40] bmansurov: setup qunit [19:49:47] it's complaining that the qunit tests are not working for you [19:49:56] don't turn them off please.. :) [19:50:08] you'll need to get `make qunit` working [19:50:13] jdlrobson, setup not found [19:50:29] bmansurov: is your vagrant up? [19:50:30] ohhh [19:50:36] jdlrobson, yes [19:50:50] make qunit also gives the same error above [19:50:50] have you setup your environment (export MEDIAWIKI_URL=http://127.0.0.1:80/w/index.php/) [19:51:06] did you install phantomjs? [19:51:25] jdlrobson, I have set it up, phantomjs - yes [19:51:27] ./dev-scripts/qunit.sh < what happens when you run that? [19:51:27] just disssable these evil hoooksssss! [19:51:41] Unable to access network [19:51:50] MaxSem: anyone working on client side code should be using them. saves a bunch of time in code review [19:52:31] echo ${MEDIAWIKI_URL}Special:JavaScriptTest/qunit?useformat=mobile [19:52:35] what does that give you bmansurov [19:52:46] http://127.0.0.1:80/w/index.php/Special:JavaScriptTest/qunit?useformat=mobile [19:52:53] what happens when you go to that url? [19:53:02] do you see qunit tests? [19:53:13] jdlrobson, unable to connect. so I guess I need to change 80 to 8080? [19:53:17] correct [19:53:29] update your MEDIAWIKI_URL it should point to /your/ instance [19:53:38] jdlrobson, ok it's working now, thanks [19:53:47] make qunit is? [19:54:08] yes [19:54:15] (03CR) 10Kaldari: Using same API data for wikigrokeval and askWikidataQuestion (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) (owner: 10Kaldari) [19:54:20] jdlrobson, i suppose it takes some time to run all qunit tests? [19:54:29] bmansurov: not too long [19:54:41] jdlrobson, like 2mins? [19:54:49] 10seconds for me [19:54:57] as long as you run mobile qunit tests [19:55:00] e.g. not desktop [19:55:00] (03PS6) 10Bmansurov: Support internal redirects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162178 (https://bugzilla.wikimedia.org/69020) (owner: 10Jdlrobson) [19:55:20] jdlrobson, it's part of prehooks, so I'm not sure which one is being run [19:55:27] ^ bmansurov O_o what happened there? [19:55:37] jdlrobson, Max left a comment [19:55:44] jdlrobson, I tried fixing it [19:55:50] i fixed it already.. :) [19:56:11] jdlrobson, did you add hash too? [19:56:14] (03PS6) 10Kaldari: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) [19:56:27] bmansurov: yeh... usually we don't work on each other's patches as it just leads to duplicate work like this [19:56:44] jdlrobson, OK, sorry [19:56:51] bmansurov, I was actually reviewing it [19:56:56] (03PS7) 10Jdlrobson: Support internal redirects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162178 (https://bugzilla.wikimedia.org/69020) [19:56:59] since you're sick today wanted to get that in [19:57:44] yeh don't worry i can understand how that can be confusing. my patch was a little different - i cached the variable to make it more readable [19:57:53] i probably should be asleep but i got bored ;-) [19:58:21] jdlrobson, OK [19:58:54] jdlrobson, how can I remove my patchet now? [19:58:55] s [19:59:14] bmansurov: I fixed it already dont worry [19:59:36] jdlrobson, OK thanks. Should I still review it? [19:59:52] (03PS6) 10Jdlrobson: Hygiene: Move DOM handling out of postRender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162134 [20:01:37] (03CR) 10Kaldari: [C: 032] Hygiene: WikiDataApi::getClaims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162185 (owner: 10Jdlrobson) [20:02:29] (03Merged) 10jenkins-bot: Hygiene: WikiDataApi::getClaims [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162185 (owner: 10Jdlrobson) [20:02:31] (03Merged) 10jenkins-bot: Hygiene: Move DOM handling out of postRender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162134 (owner: 10Jdlrobson) [20:02:39] jdlrobson: merged https://gerrit.wikimedia.org/r/#/c/162185/. I need to do onboarding with jhobs now though. [20:02:53] kaldari|2: roger. Thanks! [20:02:55] i'll rebase your patchset [20:03:05] jdlrobson: thanks [20:03:07] kaldari: got a room set up or anything or do you just want to call me [20:03:16] ? [20:04:14] (03CR) 10Bmansurov: [C: 031] Support internal redirects [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162178 (https://bugzilla.wikimedia.org/69020) (owner: 10Jdlrobson) [20:05:40] jhobs: I'll give you a call in a sec... [20:07:48] jhobs: Just set up a calendar event with a Google Hangout. Give me a couple minutes though, running a bit behind... [20:08:07] kaldari: no problem, I've got food on the way anyways [20:09:20] (03CR) 10Jdlrobson: [C: 04-1] "I couldn't work out how to rebase :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) (owner: 10Kaldari) [20:09:48] (03PS3) 10Jdlrobson: Hygiene: Add JSONP support to API classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162778 [20:09:52] (03PS3) 10Jdlrobson: Hygiene: Abstract more of the nastiness of the wikidata api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162797 [20:09:58] (03PS9) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [20:10:12] (03PS10) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [20:11:05] (03PS5) 10Jdlrobson: Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 [20:15:49] jhobs: oops, looks like there are actually 2 calendar events now :P [20:15:55] let's go with yours [20:16:40] ok [20:26:13] (03PS2) 10Jdlrobson: Stop user profile talk button from being special [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163236 (https://bugzilla.wikimedia.org/71071) [20:26:15] (03PS12) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) [20:26:51] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [20:34:59] MaxSem, how does wfMessage work? What does this code do? wfMessage( 'userlogin-loggedin' ) [20:35:23] https://www.mediawiki.org/wiki/Localisation [20:35:43] MaxSem, thanks [20:39:44] MaxSem, I'm trying to fix this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=71307 and the file I need to change is outside the MobileFrontend extension folder. [20:39:55] MaxSem, how do I handle such cases? [20:40:38] you're hired as a Wikimedia developer, not MobileFrontend developer. just do it ;) [20:42:19] bmansurov: https://en.wikipedia.org/wiki/Wikipedia:Be_bold [20:42:21] :) [20:43:08] bmansurov: We find quite a few random issues in core on the Mobile team. Better to try to address them directly by patching core itself. [20:44:07] MaxSem, Maryana thanks [20:44:22] Deskana, so I will have to get my patch accepted by them first [20:44:23] ? [20:44:36] bmansurov: The process is the same as anything else. Submit patch, get review, ???, profit. :-) [20:44:41] who are "them"? :P [20:44:46] it's only us! [20:45:00] bmansurov: What MaxSem said. Shared ownership! [20:45:08] no matter what team people are, they're still "us" [20:45:30] MaxSem, Deskana ok I see, I just thought there are different teams that deal with different parts of the project [20:46:29] bmansurov: It's not that black and white. There are people that typically work in certain areas, are more experienced with that code base and therefore more likely to review your patch, but ultimately everything is owned by everyone. :-) [20:46:40] bmansurov: So, you're not entirely wrong. [20:47:28] Deskana, I see, thanks for clarifying. [20:47:47] bmansurov: You're welcome. :-) [20:53:06] bmansurov: Oh, also, be sure to change the bug to the correct product/component, if the issue is outside MobileFrontend like you say. [20:54:11] Deskana, well the issue is partially outside of MobileFrontend, but part of the fix is not. [20:54:49] bmansurov: Ah, grey areas. Pick whatever you think best describes the situation then, but don't spend too long worrying about it. :-) [20:55:19] Deskana, OK thanks [20:58:58] (03PS1) 10BearND: Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 [20:59:37] (03CR) 10BearND: [C: 04-2] "not ready yet" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 (owner: 10BearND) [21:02:26] MaxSem, so I made a fix in the core, now I'd like to fix the remaining parts of the bug in MobileFrontend. Is it one of those cases where dependencies come into play? [21:02:57] just mention the core commit id in MF commit message [21:03:35] MaxSem, in any specific format? Like how we add 'Bug: X' at the end? [21:03:50] Dependency: ... [21:03:59] MaxSem, great, thanks. [21:05:16] (03PS1) 10Jdlrobson: Add tooltips to all standalone icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163277 (https://bugzilla.wikimedia.org/50705) [21:23:25] YuviPanda|afk: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Intermittent_403_on_server_resources [21:24:42] YuviPanda|afk: You signed yourself up to be the person I dump random ops-y things on. :-p [21:34:29] MaxSem: https://www.mediawiki.org/wiki/Wikimedia_Engineering/Maps_%26_Geo_Team lets slot it under this [21:35:59] (03PS1) 10Bmansurov: Fix false 'already logged in' message. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163281 (https://bugzilla.wikimedia.org/71307) [21:41:21] MaxSem, in trello I was subscribed to a card while it was in development. Once it's in code review, do I just remove myself from the card? [21:45:38] bmansurov: are you here? [21:45:46] FlorianSW|hotel, yes [21:46:01] dbrant|food: So I got this email about app indexing in Google. [21:46:08] bmansurov: Have you talked to someone to made this (https://gerrit.wikimedia.org/r/#/c/163275) as an extra changeset? [21:46:10] dbrant|food: The email does a poor job of explaining exactly what this is. [21:46:12] dbrant|food: Do you know? [21:46:48] FlorianSW|hotel, no, I just was bold and made the change [21:47:13] bmansurov: ah, cool :) For future changes: You can change the language files in the same changeset :) [21:47:35] bmansurov: Otherwise this were a good point to use the "built-in" dependency of gerrit/git :P [21:48:16] FlorianSW|hotel, can you explain more? Isn't hat change located in another repo (not MF) [21:49:43] bmansurov: argh :D Right, sorry for the confusion :) I thought it is in MF, too [21:50:05] FlorianSW|hotel, ;) [21:52:58] * Deskana appreciates the simplicity of the apps having their own i18n system... [21:53:05] bmansurov: this failures looks very unrelated to your change: https://integration.wikimedia.org/ci/job/mediawiki-vendor-integration/2205/console (https://gerrit.wikimedia.org/r/#/c/163275/1)?! [21:53:26] FlorianSW|hotel, that's what I thought [21:53:43] bmansurov: retrigger tests with a comment "recheck" :) [21:53:53] normally in a second run, all shoud be ok :) [21:53:59] (or related failures :P) [21:54:12] FlorianSW|hotel, ok thanks for the tip [21:57:00] Deskana: maybe https://developers.google.com/app-indexing/ helps. App indexing for Google Search is basically a way to launch the app from a Google Search that happens on an Android device. [21:57:08] (03CR) 10Bmansurov: [C: 031] Stop user profile talk button from being special [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163236 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [22:00:03] (03PS2) 10Florianschmidtwelzow: Fix false 'already logged in' message. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163281 (https://bugzilla.wikimedia.org/71307) (owner: 10Bmansurov) [22:00:08] FlorianSW|hotel, how do you usually test IE? Do you have virtualboxes setup with different versions of IE? [22:01:23] bmansurov: i'm a windows user :P So, IE11 i test on my PC, other versions i usually don't test (unhappily), unless there is a known problem i want to fix. For this i have an Win XP image here (for IE6-8) and an Win7 (for IE8-10). All runs in a virtualbox, yes :) [22:01:49] FlorianSW|hotel, OK, good to know [22:01:52] bmansurov: Other browsers i test on my pc (chrome and firefox) and i have installed safari, too, but never used it (:() [22:02:17] FlorianSW|hotel, safari didn't show enough love for windows users? [22:03:15] bmansurov: it's because i forget it :D [22:05:05] bmansurov: https://gerrit.wikimedia.org/r/#/c/163275/1 looks much better :) [22:05:43] FlorianSW|hotel, as you said ;) [22:05:51] bmansurov :P [22:07:28] bmansurov, so where are the messages from https://gerrit.wikimedia.org/r/#/c/163275/1 used? [22:08:16] MaxSem, https://gerrit.wikimedia.org/r/#/c/163281/ [22:08:38] (03PS11) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [22:09:12] (03CR) 10jenkins-bot: [V: 04-1] WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 (owner: 10Jdlrobson) [22:09:25] bmansurov, ehh - if this message is used in MF only, it should be in MF [22:09:55] (03CR) 10Florianschmidtwelzow: Make sure, issues only added once (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [22:09:56] also, when you add messages to core, you need to update tests/language/messages.inc [22:09:59] MaxSem, for now it's used in MF, but it's used in code and according to the link you gave, it should be in the /languages folder [22:10:36] bmansurov, MaxSem: if it's only used in MF, we should think about to add it to our "own" message file first. [22:10:51] if there is someone else, who want to use it, we can move later, too :) [22:10:59] I see [22:11:04] I can redict what Siebrand will say about that :P [22:11:08] * MaxSem hides [22:11:42] MaxSem, i might have misread the localization page [22:12:13] MaxSem :D [22:12:21] MaxSem, the original message was already in /languages, so a similar message should be in the same place, no? [22:12:42] no [22:13:05] not used in core === shouldn't be in core [22:13:40] MaxSem, alright, let me move the messages over [22:20:28] (03PS3) 10Bmansurov: Fix false 'already logged in' message. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163281 (https://bugzilla.wikimedia.org/71307) [22:32:21] (03PS12) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [22:32:23] (03PS1) 10Jdlrobson: Hygiene: Rename getOccupations to something more appropriate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163294 [22:32:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 (owner: 10Jdlrobson) [22:34:04] (03PS8) 10Florianschmidtwelzow: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) [22:34:24] (03PS4) 10Bmansurov: Fix false 'already logged in' message. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163281 (https://bugzilla.wikimedia.org/71307) [22:36:25] (03PS9) 10Florianschmidtwelzow: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) [22:36:57] (03CR) 10Florianschmidtwelzow: Make sure, issues only added once (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [22:38:20] (03PS2) 10Jdlrobson: Hygiene: Rename getOccupations to something more appropriate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163294 [22:39:13] (03CR) 10Florianschmidtwelzow: [C: 031] "Looks much better!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163236 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [22:39:17] (03PS4) 10Jdlrobson: Hygiene: Add JSONP support to API classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162778 [22:39:29] (03PS4) 10Jdlrobson: Hygiene: Abstract more of the nastiness of the wikidata api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162797 [22:39:39] (03PS3) 10Jdlrobson: Hygiene: Rename getOccupations to something more appropriate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163294 [22:44:37] (03PS5) 10Jdlrobson: Hygiene: Abstract more of the nastiness of the wikidata api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162797 [22:44:39] (03PS4) 10Jdlrobson: Hygiene: Rename getOccupations to something more appropriate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163294 [22:44:41] (03PS1) 10Jdlrobson: Hygiene: Hide API yukiness [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163295 [22:53:05] (03PS2) 10Jdlrobson: Hygiene: Hide API yukiness [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163295 [22:53:07] (03PS7) 10Jdlrobson: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) (owner: 10Kaldari) [22:53:37] (03CR) 10Jdlrobson: [C: 04-1] "Rebased but not working.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) (owner: 10Kaldari) [22:53:53] jdlrobson, so why https://gerrit.wikimedia.org/r/#/c/162778/4 is not to core? :P [22:54:18] MaxSem: i'm not sure we want to encourage jsonp use.. [22:55:01] if we want the API to potentially be used cross-wiki.... [22:59:25] jdlrobson: I'm not totally happy with https://gerrit.wikimedia.org/r/#/c/162134/. All the other versions of Panel handle their own DOM insertion. It's confusing having this handled in 2 different ways. We should choose one and be consistant. [22:59:54] postRender can get called multiple times [23:00:00] we should never handle DOM insertion in post render [23:00:28] this is also important for testing purposes [23:00:38] if any Panels are doing their own DOM insertion that should be fixed [23:00:47] i suspect that's a legacy thing from old code [23:01:24] ( just like $( '
' ) doesn't add a DIV to the DOM neither should new Widget() ) [23:01:26] jdlrobson: Yes, right now all Drawers do their own DOM insertion and always have (as far as I can tell) [23:01:45] kaldari|2: open a bug for that, whatever is making the drawer should be doing that [23:02:03] jdlrobson: you feeling better ? [23:02:17] tfinc: yeh the extra sleep helped. i think i've been overdoing it [23:02:32] hopefully another early night will sort me out [23:02:33] jdlrobson: great, glad your doing better [23:04:01] kaldari|2: WikiGrok is unlikely to be done by monday.. this is turning into a 13 point story [23:04:31] brb [23:04:37] jdlrobson: This change makes the code quite confusing though, as it looks like all Panels are supposed to do their own insertion. So WikiGrokDialog's behavior appears to be magical (as it is controlled from elsewhere). [23:05:50] jdlrobson: brb [23:25:21] (03PS8) 10Kaldari: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) [23:27:58] (03PS9) 10Kaldari: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) [23:28:15] (03PS10) 10Jdlrobson: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163070 (https://bugzilla.wikimedia.org/71335) (owner: 10Kaldari) [23:30:42] (03PS13) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [23:30:43] jdlrobson: your rebase looks a lot different than my rebase :P [23:31:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 (owner: 10Jdlrobson) [23:33:05] jdlrobson: You also totally changed the dependancy chain [23:33:14] kaldari|2: yes. [23:33:22] cos i need to get WikiGrokDialogB done [23:33:27] and it was becoming a cluster fuck [23:33:51] jdlrobson: No, we need to fix WikiGrok A first [23:34:04] kaldari|2: just merge the dependencies then [23:34:12] i can fix them up with a minutes work if there is anything you don't like [23:34:18] there is no deployment till thursday any how [23:34:43] jdlrobson: I told Maryana I would SWAT deploy the Wikigrok A fix on Monday :( [23:34:50] why? [23:34:53] it's not urgent surely [23:34:57] it effects a subset of pages [23:35:22] jdlrobson: I can't merge anything right now, I have to leave early :( [23:35:24] we need to deploy the fix so we don't get a bunch of junk data [23:35:36] (cough.. if it's not on the mailing list it didn't happen.. i had no idea) [23:35:43] :P [23:35:44] what junk data would you get? [23:35:46] that's not how that works, jon [23:35:54] that's for rule of three conversations [23:35:59] Maryana: yeh it is! we always send a mail to the mailing list if we need a swat deploy! [23:36:35] err, ok [23:36:51] but what you're asking is why is this urgent? [23:37:03] it's urgent because we need to start looking at the data from wikigrok v. a [23:37:09] to see the quality & engagement [23:37:30] and none of this should be a dependency on wikigrok v. b [23:38:39] ok so my main issue here is wikigrok b is apparently the top card in this iteration. I'm working to get it done. Kaldari is moaning at me for changing a few things to support that because he needs a swat deploy and i had no idea we needed a swat deploy as i am not a mind reader [23:38:53] the question about why is it urgent is a separate discussion and was just a curiosity [23:39:10] jdlrobson: You're right, I should have communicated that by email or IRC at least [23:39:41] let's talk about this on monday [23:39:42] Either way any lightning deploy is going to be a pain in the arse for that because of WikiGrok B [23:39:53] jdlrobson: I just didn't expect a huge chain of refactoring to become a dependancy [23:40:07] yeah, i'm worried that we're drifting away from agile with this stuff [23:40:09] kaldari|2: well already a bunch of stuff got merged right? you'd have a bunch of dependencies to deploy anyway [23:40:11] but we should talk in person [23:40:34] kaldari it probably makes sense to write a one off commit against the current branch? [23:40:40] (on enwiki) [23:41:34] jdlrobson: I've already done a bunch of rebasing/merging. No reason to throw that away. [23:42:03] kaldari|2: well i needed your code for wikigrok b anyhow.. :-/ [23:42:15] but yeh if we need a lightning deploy we can work out what to do monday. [23:42:29] we can work all this out after standup [23:42:35] so i'm guessing the issue is we log 'attempt' but a load of people hit the bug so we can't remove them [23:42:37] without the pain of textual communication [23:42:41] (from the people that go on to finish it) [23:42:44] yep [23:43:50] jdlrobson: I'll try to sort the code out some more tonite, but I'm afraid I can't plow through it all right at this moment as we're supposed to be celebrating Steven's going away right now :P [23:44:12] and I was busy with Jeff's onboarding eariler [23:44:53] jdlrobson: is that OK if it sits for a bit in the meantime? [23:45:33] kaldari|2: sure we can sort it monday. Maybe we can just have a one-off commit to fix the issue.. i mean we could log something when this bug is hit to allow the data to be collected better [23:45:49] sure, that might work [23:45:55] i dunno i can't think straight yet but let's just talk first thing monday and work out best thing to do [23:46:06] ok, sounds good :) [23:46:31] jdlrobson: Sorry to slow you down. I know you were hoping to plow through it all. [23:47:01] we just have to git this fix out soon [23:47:14] i'm gonna continue plowing as i'm almost at the finishing line if you need to rebase the other commit can you upload it with a different commit id? [23:47:25] ok, everybody stop thinking & go enjoy your friday night :) [23:47:42] I guess I'll have to [23:48:25] ttyl [23:59:52] (03PS14) 10Jdlrobson: WIP: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [23:59:54] (03PS1) 10Jdlrobson: Hygiene: Add chooseRandomItemFromArray method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163314