[00:00:55] (03PS1) 10Jdlrobson: Prevent explosions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163776 [00:01:10] Took 2825ms to run 350 tests. 350 passed, 0 failed. < bmansurov yeh they've got slow [00:01:18] it's as fast as your localhost [00:01:48] (03PS2) 10Jdlrobson: Prevent explosions due to jquery.json removal [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163776 [00:01:56] kaldari: https://gerrit.wikimedia.org/r/#/c/163776/ [00:02:02] i can't merge code until that's merged [00:02:50] https://docs.google.com/a/wikimedia.org/document/d/1grMZUS5dctRxLWounbqRE_ge3HK5V-K0NCiabgPfaqw/edit# [00:02:54] bah parallels is not starting. reboot time [00:03:32] jdlrobson, how can I make my localhost faster? [00:04:02] MaxSem: https://gerrit.wikimedia.org/r/#/c/163776/ [00:04:06] bmansurov: i'd love to know :) [00:04:51] (03CR) 10MaxSem: [C: 032] Prevent explosions due to jquery.json removal [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163776 (owner: 10Jdlrobson) [00:05:45] (03Merged) 10jenkins-bot: Prevent explosions due to jquery.json removal [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163776 (owner: 10Jdlrobson) [00:05:52] thanks MaxSem :) [00:06:06] (03PS4) 10Jdlrobson: Stop user profile talk button from being special [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163236 (https://bugzilla.wikimedia.org/71071) [00:06:22] (03PS7) 10Jdlrobson: Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 [00:06:32] (03PS24) 10Jdlrobson: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [00:13:52] (03PS4) 10Jdlrobson: Add tooltips to all standalone icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163277 (https://bugzilla.wikimedia.org/50705) [00:20:48] (03PS13) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) [00:20:50] (03PS8) 10Jdlrobson: Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 [00:21:23] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [00:27:26] (03PS9) 10Jdlrobson: Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 [00:31:04] Deskana, hey. around? [00:31:57] Krenair: Kinda busy, but around. What's up? [00:32:16] nothing important [00:33:20] someone suggests the search field isn't obvious enough, perhaps put a magnifying glass icon there? [00:33:57] Krenair: We're going to be diving into that code soon, next sprint basically. [00:34:02] Krenair: That sounds sensible to me. [00:35:40] Some people actually couldn't find it - to the point where they sent email feedback. :/ [00:36:31] Krenair: Yeah, there's a few things causing that that we're aware of. Particularly with the way that Android handles it compared to iOS. [00:41:32] (03CR) 10Krinkle: "qunit was failing because one of the jenkins slaves had a full temp disk." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 (owner: 10Jdlrobson) [00:41:40] (03PS14) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) [00:42:11] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [00:43:31] (03PS15) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) [00:43:43] Krenair: Thanks for letting me know. :) [00:43:59] you're welcome [00:44:03] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [01:56:16] yurikR: https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html#dialogs-apex-ltr [07:40:22] (03PS1) 10Yurik: Added 'name' value to jsConfigBlock, init cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163804 [12:01:49] (03PS1) 10Zhaofeng Li: Fixed SSL fallback logic for users in China [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163830 [16:53:16] 3MobileFrontend / 3General/Unknown: MobileFrontend fatal in SpecialPage_initList hook - 10https://bugzilla.wikimedia.org/71329#c7 (10Florian) 5PATC>3RESO/FIX deployed in I0829e865ba01436e984bf43fb23e606575d6d35c [17:06:11] jdlrobso_, hey, what's the primary use of sessionId on the front end? [17:06:37] hey bmansurov EventLogging [17:06:55] jdlrobso_, do you think it's a good idea to use it for tracking open sections too? [17:07:59] I'm not sure what you mean. what would be the advantage of using it over just plain local storage? [17:09:23] jdlrobso_, I'd use localStorage or cookies, but I want to make sure that I store the relevant info for just the current session. I don't want to collapse sections when someone restarts the browser. Does that make sense? [17:11:04] bmansurov: mm yeh i guess that makes sense [17:11:14] would have to be tied to title too [17:11:31] jdlrobso_, and to the referer too? [17:11:48] jdlrobso_, so that only collapse sections when the back button is hit? [17:20:52] (03PS1) 10Florianschmidtwelzow: Check for Nearby-Requirements first [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163879 (https://bugzilla.wikimedia.org/70797) [17:32:05] bmansurov: sorry in an interview right now but yeh maybe some combo of session and title [17:32:09] it might be overengineering though [17:32:27] jdlrobso_, ok thanks [17:34:35] sigh. beta labs down. can't sign off on anything :( [17:34:49] (03CR) 10Kaldari: [C: 032] Check for Nearby-Requirements first [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163879 (https://bugzilla.wikimedia.org/70797) (owner: 10Florianschmidtwelzow) [17:35:23] (03Merged) 10jenkins-bot: Check for Nearby-Requirements first [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163879 (https://bugzilla.wikimedia.org/70797) (owner: 10Florianschmidtwelzow) [18:07:32] 3MobileFrontend / 3stable: 3rd party: Nearby shows up in mobile interface with Geodata not installed - 10https://bugzilla.wikimedia.org/70797 (10Florian) 5PATC>3RESO/FIX [18:17:22] (03PS1) 10Jdlrobson: Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 [18:17:57] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 (owner: 10Jdlrobson) [18:19:37] mhurd: which case is worth it for the iPhone 6 and 6 plus ? i'm putting in an order for test devices ? [18:20:55] (03PS1) 10Jhobs: Update zero info page to match mobile-frontend [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163891 [18:22:56] (03CR) 10Jhobs: "Actually I just noticed a couple things so don't bother reviewing this yet." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163891 (owner: 10Jhobs) [18:33:16] (03PS2) 10Jhobs: Update zero info page to match mobile-frontend [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163891 [18:37:30] James_F: will you guys be using R32 on Thur for VisualEditor KIT ? i need to move our FE group meeting earlier due to metrics [18:38:08] tfinc: I will, but I can switch to a different room if you have one that's good for stand-ups. [18:39:30] there are two rooms available on six R64 and R67 [18:40:25] Eurgh, 6th Floor. :-) [18:42:01] tfinc: Neither of those are suitable for a Hangout, sadly. [18:42:33] i was in R64 yesterday. fits two easily three if you squish in. they have mic's and a phone to dial out on [18:42:45] the only bit that i know their missing is a large screen [18:42:45] tfinc: Sure, but this is a 5 local, 7 remote meeting. [18:42:56] thats too big than [18:43:06] thanks for checking [18:43:07] Yeah. :-( [18:43:08] Sorry. [18:59:35] (03PS1) 10Yurik: Enabled parameter now allows enabled range [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163897 [19:00:13] (03CR) 10Dr0ptp4kt: [C: 032] "LGTM. Yuri said it's working on his system." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163804 (owner: 10Yurik) [19:00:26] (03Merged) 10jenkins-bot: Added 'name' value to jsConfigBlock, init cleanup [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163804 (owner: 10Yurik) [19:29:35] yurikR2: when you have a moment, would you please demo https://gerrit.wikimedia.org/r/#/c/163897 for me? it looks pretty good, just want to see it in action. no time to be setting up VMs for me today. able to add some unit tests or want to defer that post-merge? [19:31:22] TrevorParscal: jdlrobson: can i get the two of you to jump in on the agenda for the next meeting http://etherpad.wikimedia.org/p/FrontEndStandardsGroup ? [19:31:36] (03CR) 10Jdlrobson: Stop user profile talk button from being special [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163236 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [19:31:42] (03CR) 10Jdlrobson: [C: 032] "try again" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163236 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [19:32:15] (03Merged) 10jenkins-bot: Stop user profile talk button from being special [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163236 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [19:39:22] kristenlans: is there a link for these slides to personas? [19:39:39] Will get it from MAryana [19:44:16] jdlrobson: https://docs.google.com/a/wikimedia.org/presentation/d/1sMrYYtkb_xy8HxK8WdpPQyjsNCLiwyw7WVM9wFJVKZQ/edit [20:04:43] (03CR) 10Jdlrobson: [C: 04-1] Make sure, issues only added once (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [20:16:30] 3MobileFrontend / 3Feature requests: Make images clickable on image description pages - 10https://bugzilla.wikimedia.org/48996#c11 (10Jon) Maybe we can remove this link removal now the media viewer is here? This will only effect people visiting the File page. I think this should still be removed in core (le... [20:24:45] hey kristenlans: i'm gonna slink off after the end of this session (it's 9:30 pm here and i'm up early tomo) [20:24:51] are we recording these sessions? [20:25:38] phuedx: Thank for attending! we are not recording the sessions [20:31:55] jdlrobson, does this look right formatting-wise? Or should there be no spaces before closing parens? toggle( $( $headline.parents ( '.section_heading' ).eq ( 0 ) ) ); [20:36:46] bmansurov: just looking at the sapces: this looks right :) [20:39:32] FlorianSW, thanks [20:40:22] (03CR) 10BearND: [C: 04-1] "minor stuff" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163741 (owner: 10Dbrant) [20:41:16] np :P [20:58:00] bmansurov: .parents ( => .parents( [20:58:10] the only reason we use a space is to distinguish from functions [20:58:20] e.g. for( if( are not functions so for ( and if ( [20:58:38] bmansurov: also fyi https://gerrit.wikimedia.org/r/163889 [20:58:54] am trying to change markup so potential merge conflict on the horizon :) [21:01:53] jdlrobson, what's the reason for using spaces inside parenthesis? [21:02:44] readability i guess [21:02:49] https://www.mediawiki.org/wiki/Manual:Coding_conventions might have some more details [21:03:13] jdlrobson, this just looks not so readable: ... eq ( 0 ) ) ); [21:03:56] so your line is toggle( $( $headline.parents( '.section_heading' ).eq( 0 ) ) ); ? [21:04:00] why are you wrapping with $ ? [21:04:08] it's already a jquery object.. [21:04:19] yes, i got it confused with get [21:04:22] toggle( $headline.parents( '.section_heading' ).eq( 0 ) ); [21:04:31] sure [21:04:32] and i'd suggest caching the variable for readability [21:04:50] jdlrobson, i'm using it only once [21:05:01] but you're right [21:05:27] jdlrobson, another question, when does the sessionId change? [21:08:28] (03PS1) 10Kaldari: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163956 (https://bugzilla.wikimedia.org/71335) [21:25:35] (03Abandoned) 10Kaldari: Using same API data for wikigrokeval and askWikidataQuestion [extensions/MobileFrontend] (wmf/1.24wmf22) - 10https://gerrit.wikimedia.org/r/163956 (https://bugzilla.wikimedia.org/71335) (owner: 10Kaldari) [21:26:45] 3MobileFrontend / 3beta: Wikigrok - clicking next doesn't always work - 10https://bugzilla.wikimedia.org/71335#c12 (10Ryan Kaldari) 5PATC>3RESO/FIX Fixed on test.wiki. [21:36:21] (03PS1) 10BearND: More Nearby styling changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163960 [21:37:03] remobile [21:37:05] groble [21:37:09] regroble [21:37:15] regroble [21:41:59] https://docs.google.com/a/wikimedia.org/document/d/1grMZUS5dctRxLWounbqRE_ge3HK5V-K0NCiabgPfaqw/edit#heading=h.q7klgudrnvks [21:44:05] (03CR) 10Florianschmidtwelzow: Make sure, issues only added once (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [21:44:31] (03PS3) 10Dbrant: Add option to switch between metric/imperial in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163741 [21:44:42] (03PS10) 10Florianschmidtwelzow: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) [21:51:39] (03PS1) 10Florianschmidtwelzow: Remove link removal on filepages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163963 (https://bugzilla.wikimedia.org/48996) [21:55:16] http://etherpad.wikimedia.org/p/mobile_web_breakout [21:56:11] bmansurov: https://plus.google.com/hangouts/_/wikimedia.org/klans?authuser=0 [21:56:25] kristenlans, thanks [21:56:51] (03CR) 10Brion VIBBER: "I haven't seen the specific Lua module code that's meant to be used with this here; Yuri can you provide an example that's written out so " [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [21:57:18] 3MobileFrontend / 3Feature requests: Make images clickable on image description pages - 10https://bugzilla.wikimedia.org/48996 (10Florian) [22:15:24] http://etherpad.wikimedia.org/p/mobile_web_breakout [22:47:07] bmansurov need the link? [22:47:20] kristenlans, no, I'm joining now [22:47:34] cool :-) [23:14:02] example of a non-existant page on enwiki that is on wikidata https://www.wikidata.org/wiki/Q5871567 [23:23:03] etherpad, in case anyone needs the link http://etherpad.wikimedia.org/p/mobile_web_breakout [23:32:37] (03PS16) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) [23:32:39] (03PS2) 10Jdlrobson: Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 [23:32:42] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [23:32:55] awjr: be right there [23:33:16] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 (owner: 10Jdlrobson) [23:34:12] np kristenlans still waiting on leila [23:35:39] (03CR) 10Jdlrobson: [C: 032] Remove link removal on filepages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163963 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [23:36:17] (03Merged) 10jenkins-bot: Remove link removal on filepages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163963 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [23:51:31] 3MobileFrontend / 3Feature requests: Make images clickable on image description pages - 10https://bugzilla.wikimedia.org/48996 (10Jon) 5PATC>3RESO/FIX