[00:00:11] (03CR) 10Jdlrobson: [C: 04-1] "Max will need to take a look at this." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [00:00:31] jdlrobso_, what did you do to get past failed qunit tests yesterday? [00:02:45] (03PS1) 10Bmansurov: WIP: Remember expanded sections on page reload or when going back to the previous page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [00:03:18] (03CR) 10jenkins-bot: [V: 04-1] WIP: Remember expanded sections on page reload or when going back to the previous page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [04:27:19] (03CR) 10Florianschmidtwelzow: [C: 04-1] Make sure, issues only added once (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [13:54:25] (03CR) 10Anomie: "> Offhand I have no objection to the general notion of using a customizable Lua module instead of a wikitext template, or a MediaWiki: mes" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [15:39:05] Bah. I hate it when I get bounces for using the wrong send address. [15:50:03] ragesoss, where'd you send to? [15:50:20] mobile-l [15:52:27] It was just a nudge to get section redirects working on mobile, since that's a sort of hand-curated (small) search index. [15:53:14] And just because it's bug that bugs me. [16:30:56] (03PS2) 10Yurik: Enabled parameter now allows enabled range [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163897 [16:43:07] (03PS11) 10Florianschmidtwelzow: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) [17:01:22] MaxSem, are we doing the standup or apps planning meeting? [17:01:43] apps planning [17:01:49] ok thanks [17:07:41] (03CR) 10Jdlrobson: [C: 031] "I need Max or Kaldari to check PHP changes." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [17:10:17] (03CR) 10Florianschmidtwelzow: "> Also I can't verify as import is broken on my wiki so I can't import the page :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [17:13:59] jdlrobson: What is the 'before' class for in mw-ui? [17:14:12] kaldari: mm? [17:50:09] dr0ptp4kt, around? pls +2 [17:52:14] yurikR: in car, to be dropped off in about 6 minutes. which patch? [17:56:55] same as yesterday, thx [18:00:34] yurikR: oh right, it's oracle openworld today, so downtown is bananas [18:02:05] yurikR: does this resolve the issue you identified yesterday? [18:02:15] yurikR: coming up in 2 mins [18:04:11] TrevorParscal: jdlrobson: can i get the two of you to jump in on the agenda for the next meeting http://etherpad.wikimedia.org/p/FrontEndStandardsGroup ? [18:04:24] (03PS12) 10Kaldari: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [18:04:37] lookin [18:06:49] (03CR) 10Kaldari: [C: 032] Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [18:07:22] (03Merged) 10jenkins-bot: Make sure, issues only added once [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162295 (https://bugzilla.wikimedia.org/71046) (owner: 10Florianschmidtwelzow) [18:11:01] (03PS1) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [18:11:03] (03PS1) 10Jdlrobson: WIP: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [18:11:34] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [18:11:38] (03CR) 10jenkins-bot: [V: 04-1] WIP: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [18:11:48] (03PS3) 10Jhobs: Update zero info page to match mobile-frontend [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163891 [18:12:00] 3MobileFrontend / 3beta: Talk page 'about this article' repeats itself - 10https://bugzilla.wikimedia.org/71046 (10Jon) 5PATC>3RESO/FIX [18:13:00] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=71438 [18:13:48] 3MobileFrontend / 3Hygiene: Hygiene: Rearrange templates folder so that is is consistent with javascripts and less - 10https://bugzilla.wikimedia.org/71523 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon The templates folder should be arranged logically in a consistent way with the javascripts and less folde... [18:18:15] jdlrobson, what's the best way to expose private functions for QUnit testing only? [18:18:43] jhobs: https://www.mediawiki.org/wiki/OOjs_UI#Showing_a_dialog [18:18:54] jhobs: ooui is still a bit experimental though [18:19:34] kaldari: yeah I looked at that and it was inconsistent with the documentation (for example, Dialog has no "show" method) [18:21:51] (03CR) 10Dr0ptp4kt: [C: 032] "Saw it work on Yuri's machine, too." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163897 (owner: 10Yurik) [18:22:07] (03Merged) 10jenkins-bot: Enabled parameter now allows enabled range [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163897 (owner: 10Yurik) [18:22:50] prtksxna: https://bugzilla.wikimedia.org/show_bug.cgi?id=71370 [18:22:52] (03PS4) 10Yurik: Update zero info page to match mobile-frontend [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163891 (owner: 10Jhobs) [18:24:09] brion: is there a fan on in there? [18:24:18] window’s open and a fan [18:24:49] brion: i think the air from the fan is hitting the chat150s making that horrible rumble sound which makes it hard to hear - would you mind trying to reposition it, or if it's comfortable enough, turn it off? [18:25:57] sjoerddebruin: ping [18:26:03] aude: what's up? [18:26:30] looks like you accidentially banned people (me at least) in #wikidata with mode b [18:26:34] i have no idea how to undo that [18:26:43] when kicking the troll [18:26:44] gonna take a look [18:26:54] thanks [18:27:12] sorry to interrupt folks :) [18:27:25] In only banned "*!*@gateway/web/cgi-irc/kiwiirc.com/ip.177.67.81.103" [18:27:32] hmmm [18:27:32] jdlrobson, what's the best way to expose private functions for QUnit testing only? -> _functionName() (underline as prefix) [18:27:43] i can't talk in #wikimedia-tech or #wikimedia-nl [18:27:52] Maybe a global ban then. [18:27:54] FlorianSW, thanks [18:28:12] ugh [18:28:16] how's that? [18:28:45] (03PS1) 10Jdlrobson: Remove ajax refresh from editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164131 (https://bugzilla.wikimedia.org/69559) [18:28:46] People who get a ban in #wikimedia-bans get blocked in some channels. [18:29:11] oooh [18:29:16] brion: whatever you just did was magic. [18:29:19] awjr: moved the fan, any better? :D [18:29:32] brion: a million times! [18:29:34] thank you [18:29:35] \o/ [18:33:09] (03CR) 10Florianschmidtwelzow: [C: 031] "great! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [18:33:55] Maryana: would you mind leaning closer to the mic? i'm haivng a hard time hearing you [18:39:16] heh, sorry awjr [18:57:49] (03PS1) 10Jdlrobson: WIP: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 [18:58:22] (03CR) 10jenkins-bot: [V: 04-1] WIP: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (owner: 10Jdlrobson) [18:59:17] 3MobileFrontend / 3Hygiene: Remove commons folder - 10https://bugzilla.wikimedia.org/71524#c1 (10Florian) a:5Jon>3Florian @Jon: You're the default assignee, hope it's ok, when i take it? :) [18:59:17] 3MobileFrontend / 3Hygiene: Remove commons folder - 10https://bugzilla.wikimedia.org/71524 (10Florian) 5NEW>3ASSI [19:01:02] (03PS2) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [19:02:45] (03PS1) 10Florianschmidtwelzow: Move JavaScripts from javascripts/common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164142 (https://bugzilla.wikimedia.org/71524) [19:02:57] (03PS1) 10Florianschmidtwelzow: Move less/common/ to less/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164143 (https://bugzilla.wikimedia.org/71524) [19:03:21] FlorianSW, when I run 'make qunit' does anything get cached? Tests that were working before are failing now. Any ideas? [19:03:57] bmansurov: not that i know. Have you changed anything? Does the tests fail on origin/master? [19:04:28] FlorianSW, no it's my working branch. I changed some stuff but those tests don't rely on the stuff I changed. [19:05:24] bmansurov: maybe they have a relationship, otherwise it's strange. What test fails? [19:06:10] FlorianSW, it's test_toggle.js. Do you mind taking a look in your environment? I'll push my changes. [19:06:40] bmansurov: go ahead :) [19:09:07] (03PS2) 10Bmansurov: WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [19:09:15] FlorianSW, ^ [19:09:25] * FlorianSW is testing now [19:09:38] (03CR) 10jenkins-bot: [V: 04-1] WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [19:12:03] (03PS1) 10Yurik: Fix private access from closure 5.3 vs 5.4 bug [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164145 [19:12:05] (03CR) 10jenkins-bot: [V: 04-1] Fix private access from closure 5.3 vs 5.4 bug [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164145 (owner: 10Yurik) [19:13:39] (03PS2) 10Yurik: Fix private access from closure 5.3 vs 5.4 bug [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164145 [19:15:29] (03CR) 10Dr0ptp4kt: [C: 032] "Yuri said it seems not broken on his machine." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164145 (owner: 10Yurik) [19:18:52] bmansurov: one minute please :) [19:19:01] FlorianSW, sure, thanks [19:21:50] (03Merged) 10jenkins-bot: Fix private access from closure 5.3 vs 5.4 bug [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164145 (owner: 10Yurik) [19:32:21] bmansurov: it's related to your changes, but i can't figure out, where and why :/ if you don't call expandStoredSections, the tests will run normally. Let me look at your code and comment some thing, maybe we can figure it out :) [19:33:17] FlorianSW, thanks for the info. The weird thing is that the first test that fails is something that was written before. [19:33:56] yes, because for some strange reason, the section isn't toggeled (like it should). Now the question is: why :) [19:36:18] FlorianSW, if it's related to expandStoredSections, then let me look into it myself. Thanks for helping out. [19:36:55] bmansurov: i will leave some comments if i found something, otherwise: good luck :P [19:37:07] FlorianSW, that'd be great. Thanks [19:42:31] bmansurov: it seems, that the if condition in line 39 always returns true (or a value interpreted as true) in toggle.js [19:43:10] bmansurov: (or the localStorage get's not cleared correctly after test) [19:43:38] FlorianSW, I see. [19:47:13] FlorianSW, you're right, localStorage wasn't being cleared. Thanks for your help. I can I can fix it now. [19:47:19] can-> think [19:47:51] bmansurov: great :) wait one second, i have some suggestions to your code (code conventions ;)) [19:48:03] FlorianSW, awesome [19:53:19] yurikR: banner grab script came back okay [19:53:33] (03CR) 10Florianschmidtwelzow: [C: 04-1] WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [19:53:40] bmansurov ^ [19:53:49] FlorianSW, cool, thanks [19:53:58] bamnsurov np ;) [19:57:27] FlorianSW: mobileBridge.less can be deleted no? [19:57:40] doesn't seem to be used but is in repository [19:58:20] jdlrobson: i remember, that something was with mobileBridge, let me check :) [19:59:48] jdlrobso_: no, you're right :) never used anymore [20:01:08] kristenlans: there's no hangout for session 4 [20:01:08] jdlrobso_: Ah, now i remember: Was used for beta feature nearby :) https://gerrit.wikimedia.org/r/#/c/161025/9/includes/Resources.php [20:01:41] (03CR) 10Jdlrobson: [C: 032] Move less/common/ to less/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164143 (https://bugzilla.wikimedia.org/71524) (owner: 10Florianschmidtwelzow) [20:01:44] awjr just added it [20:01:49] save/refresh [20:01:52] ty :) [20:02:15] (03Merged) 10jenkins-bot: Move less/common/ to less/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164143 (https://bugzilla.wikimedia.org/71524) (owner: 10Florianschmidtwelzow) [20:02:36] bmansurov: you joining us? [20:02:51] jdlrobso_, I'm already here: https://plus.google.com/hangouts/_/calendar/d2lraW1lZGlhLm9yZ19yMWNvaHVib3JmYjlqcWMydHA0bmwxcXMxZ0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t.8olmqis0vt9mjpt8nabrh74nrc?authuser=0 [20:03:18] jdlrobso_, should I join [HOLD] Session 4: TBD? [20:03:25] bmansurov: https://plus.google.com/hangouts/_/wikimedia.org/hold-session-4?authuser=0&hceid=a2xhbnNAd2lraW1lZGlhLm9yZw.mese3l24mo6sesg4h8sl7llam4 [20:03:28] yu [20:03:32] *yup [20:03:55] (03PS2) 10Jdlrobson: Move JavaScripts from javascripts/common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164142 (https://bugzilla.wikimedia.org/71524) (owner: 10Florianschmidtwelzow) [20:06:20] (03PS1) 10Florianschmidtwelzow: Remove obsolete files from less/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164186 [20:06:34] (03CR) 10Jdlrobson: [C: 032] Move JavaScripts from javascripts/common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164142 (https://bugzilla.wikimedia.org/71524) (owner: 10Florianschmidtwelzow) [20:06:56] (03CR) 10Jdlrobson: [C: 04-1] "whoops" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164142 (https://bugzilla.wikimedia.org/71524) (owner: 10Florianschmidtwelzow) [20:07:42] (03CR) 10Jdlrobson: "Please update tests. 100 tests no longer run." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164142 (https://bugzilla.wikimedia.org/71524) (owner: 10Florianschmidtwelzow) [20:10:25] (03CR) 10Florianschmidtwelzow: "> Please update tests. 100 tests no longer run." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164142 (https://bugzilla.wikimedia.org/71524) (owner: 10Florianschmidtwelzow) [20:11:19] (03CR) 10Florianschmidtwelzow: "Aha, sorry, my fault, they don't run, not they fail :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164142 (https://bugzilla.wikimedia.org/71524) (owner: 10Florianschmidtwelzow) [20:12:26] (03PS3) 10Florianschmidtwelzow: Move JavaScripts from javascripts/common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164142 (https://bugzilla.wikimedia.org/71524) [20:17:34] (03CR) 10Dr0ptp4kt: "@Jdlrobson, it's okay from a W0 perspective to remove those Ajax things. The fine people at Mozilla provided another idea that may be work" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (owner: 10Jdlrobson) [20:41:22] MaxSem: https://www.wikidata.org/w/api.php?action=wbgetentities&ids=Q76%7CQ213%7CQ3512&props=descriptions&languages=en%7Cde&format=json [20:47:38] (03CR) 10Jdlrobson: [C: 032] Move JavaScripts from javascripts/common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164142 (https://bugzilla.wikimedia.org/71524) (owner: 10Florianschmidtwelzow) [20:48:13] (03Merged) 10jenkins-bot: Move JavaScripts from javascripts/common [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164142 (https://bugzilla.wikimedia.org/71524) (owner: 10Florianschmidtwelzow) [20:49:16] 3MobileFrontend / 3Hygiene: Remove commons folder - 10https://bugzilla.wikimedia.org/71524 (10Florian) 5PATC>3RESO/FIX [20:52:15] (03PS3) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [20:52:35] (03PS25) 10Jdlrobson: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [20:53:14] (03PS5) 10Jdlrobson: Add tooltips to all standalone icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163277 (https://bugzilla.wikimedia.org/50705) [20:55:12] (03PS10) 10Jdlrobson: Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 [20:55:32] (03PS3) 10Jdlrobson: Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 [20:56:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 (owner: 10Jdlrobson) [20:56:14] (03CR) 10Jdlrobson: [C: 032] Remove obsolete files from less/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164186 (owner: 10Florianschmidtwelzow) [20:56:19] (03PS2) 10Jdlrobson: Hygiene: Remove obsolete files from less/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164186 (owner: 10Florianschmidtwelzow) [21:02:20] (03PS17) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) [21:02:22] (03PS4) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [21:02:24] (03PS2) 10Jdlrobson: WIP: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [21:05:41] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [21:05:59] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [21:06:20] (03CR) 10jenkins-bot: [V: 04-1] WIP: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [21:10:41] (03CR) 10Kaldari: [C: 04-1] Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 (owner: 10Jdlrobson) [21:10:54] (03CR) 10Kaldari: Wikigrok B (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 (owner: 10Jdlrobson) [21:11:45] jdlrobso_: https://gerrit.wikimedia.org/r/#/c/162188/24/javascripts/modules/wikigrok/WikiGrokDialogB.js [21:26:29] (03PS18) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) [21:27:50] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [21:36:03] (03PS19) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) [21:36:54] kaldari|2: correct [21:36:56] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [21:37:00] ("It looks like this will only record the first claim that is checked." ) [21:37:12] there's only one claim you can check so far ;-) [21:37:16] i'll add a FIXME [21:38:42] (03PS26) 10Jdlrobson: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 [21:40:18] prtksxna: did you check all your bugs you raised and closed the invalid ones? [21:44:07] (03PS3) 10Bmansurov: WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [21:44:12] (03CR) 10jenkins-bot: [V: 04-1] WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [21:49:10] jdlrobso_, can you review ^? It's basically done except for one test. [21:49:42] sure taking a look [21:50:07] thanks [21:56:06] http://etherpad.wikimedia.org/p/q_planning_retro [21:56:22] http://etherpad.wikimedia.org/p/q_planning_retro [21:56:54] jdlrobso_: so we're not surfacing all possible occupations for the person? [21:57:03] jdlrobso_: Not yet, will today [21:57:22] http://etherpad.wikimedia.org/p/q_planning_retro [22:01:06] (03CR) 10Jdlrobson: [C: 04-1] "a few early thoughts" (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [22:28:57] (03CR) 10Kaldari: [C: 04-1] Wikigrok B (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 (owner: 10Jdlrobson)