[00:06:46] (03PS4) 10Bmansurov: WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [00:06:50] (03CR) 10jenkins-bot: [V: 04-1] WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [05:21:49] (03CR) 10Kaldari: [C: 032] "Merging for train ride, but please fix CSS issue in follow-up commit." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 (owner: 10Jdlrobson) [05:22:29] (03Merged) 10jenkins-bot: Wikigrok B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162188 (owner: 10Jdlrobson) [05:45:45] (03CR) 10Florianschmidtwelzow: [C: 04-1] "And: needs rebase" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [07:14:40] (03CR) 10Jdlrobson: Hygiene: Remove obsolete files from less/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164186 (owner: 10Florianschmidtwelzow) [07:14:46] (03CR) 10Jdlrobson: [C: 032] "boom" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164186 (owner: 10Florianschmidtwelzow) [07:15:19] (03Merged) 10jenkins-bot: Hygiene: Remove obsolete files from less/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164186 (owner: 10Florianschmidtwelzow) [12:00:34] 3Wikipedia App / 3Android App: NPEs from page.PageViewFragment.commonSectionFetchOnCatch - 10https://bugzilla.wikimedia.org/67807#c10 (10Alex Monk) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7852747 [15:57:24] (03Abandoned) 10Jdlrobson: Remove clickable link around image on file page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137692 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [16:21:41] (03CR) 10Florianschmidtwelzow: "> hope that's okay!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/137692 (https://bugzilla.wikimedia.org/48996) (owner: 10Florianschmidtwelzow) [17:13:55] jdlrobson: Are you in the office? [17:17:05] (03PS1) 10Florianschmidtwelzow: Remove lead section in talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164371 (https://bugzilla.wikimedia.org/50396) [17:20:00] bearND: ? that sounds weird [17:20:20] mhurd: save pages of search results [17:20:44] prtksxna: yes [17:20:45] bearND: but if you’re offline tapping on a result won’t load… [17:24:44] kristenlans yurikR head's up that i just received some cron failure emails for bugello - for web, apps, and zero [17:24:58] not sure what it's all about but i will look into it as soon as i can [17:25:00] jdlrobson: Do you have time to go over this - https://gerrit.wikimedia.org/r/#/c/164376/ - now? [17:26:19] prtksxna: it's better to use the revert button on the patches themselves if you can https://gerrit.wikimedia.org/r/#/c/162514/ [17:26:25] prtksxna: you still need someone to lightning deploy it [17:26:29] awjr, can you forward them pls [17:26:37] Thansk awjr [17:27:03] jdlrobson: There were two patches that were dependent on each other. Doing one patch seemed simpler than 2 separate ones. [17:27:43] awjr: i think bugello is broken btw [17:27:48] got some cronjob complaint today [17:28:13] yurikR: just forwarded [17:28:15] jdlrobson: Do they look alright? [17:28:19] jdlrobson: yeah i just got a bunch of cron failure emails [17:28:30] i suspect it's not bugello that's broken but rather jsub or something related [17:28:35] awjr, hm, thx, no idea what that is actually :) [17:28:37] looks like jsub segfaulted... [17:28:50] yurikR: it's ok, i'm on it :) [17:28:57] awjr: do hygiene bugs appear in trello as a bunch of bugs haven't appeared in trello [17:29:04] * awjr shrugs [17:29:08] i don't know what hygiene bugs are [17:29:17] the ones you have to wash regularly [17:29:25] heh [17:29:29] i just asked dr0ptp4kt, he has no idea what that thing is either [17:30:24] yurikR: bugello is a tool that sits between bugzilla and trello, piping bugs from bz matching some defined criteria into a specified trello board - dan asked me to set it up for zero a long time ago [17:30:42] prtksxna: with two reverts via the gerrit revert button it's easier to follow the change timeline :) [17:33:05] awjr, yurikR showed me the email. awjr, i'll email dfoy and copy you for providing the board he wants used for bugello. [17:33:33] jdlrobson: Would you prefer that too? [17:33:53] dr0ptp4kt: yurikR the tool failed for some reason for everyone using it, i'm digging into it now - but i think it's related to the job runner on labs rather than the tool itself [17:34:33] awjr, thx for the heads up ) [17:34:34] awjr, ok. alright, maybe a good time to make sure everything's in sync anyway, so we'll see what dfoy says there [17:34:36] awjr: if it failed *right now* that might be a minor labs outage, is back up, I believe. [17:34:43] dr0ptp4kt: aye [17:34:45] YuviPanda: ah ok [17:34:55] YuviPanda: that makes sense [17:34:56] awjr: should still check it up, tho :) [17:35:01] awjr, when are you creating phello? [17:35:02] awjr: NFS failed, I think. [17:35:05] YuviPanda: aye im watching it now [17:35:11] awjr: cool :) [17:35:20] dr0ptp4kt: theoretically phabricator will eliminate the need for -ello [17:35:31] awjr, trellicator [17:35:41] unless you mean phabricator -> the new social networking site, ello [17:35:42] awjr, okay, i'll stop :) [17:35:43] trellicator! [17:35:56] terminator! [17:36:12] written in prolog [17:36:49] dr0ptp4kt: just like Gerrit! [17:36:58] (which has an embedded prolog component, I think?) [17:37:23] :) [17:38:41] YuviPanda: yeah last error i saw said 'out of memory!' from a jsub run, about 25 mins ago [17:38:45] 3MobileFrontend / 3stable: Back/Forward button doesn't show up when operating in standalone app mode - 10https://bugzilla.wikimedia.org/60917#c4 (10Jon) Actions then: Seems like we just need to remove but things appear to be working normally now [17:39:00] afaict [17:39:05] awjr: ah, I see. do you pass -mem parameter to jsub in cron? [17:39:14] YuviPanda: no [17:39:28] YuviPanda: the commands used look like: /usr/bin/jsub -once -N bugello_flow /data/project/bugello/bin/bugello_flow > /dev/null [17:39:37] awjr: ah, add -mem 2G [17:39:39] to jsub [17:39:42] @_@ [17:39:45] for serious? [17:40:06] awjr: the defaults are OKish, but I guess it goes over the default limit if it processes a lot of them? [17:40:07] on all jsub jobs? [17:40:07] mhurd: it was meant to save the pages while you're online for later offline reading [17:40:24] YuviPanda: ah ok - should i do this on all jsub jobs? [17:40:41] awjr: yeah. 2G should give python scripts a lot of breathing room [17:40:51] ok YuviPanda - does order matter at all for the params? [17:41:06] awjr: nope [17:41:12] except the command has to be last, of course [17:41:16] aye [17:41:19] ok thanks YuviPanda [17:41:21] awjr: yw! [17:42:43] YuviPanda: look ok? /usr/bin/jsub -once -mem 2G -N bugello_web /data/project/bugello/bin/bugello_web -mem 2G > /dev/null [17:42:48] yup [17:42:51] awjr: wait [17:42:51] (03CR) 10MaxSem: [C: 04-1] "Fallback for cached old HTML?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 (owner: 10Jdlrobson) [17:42:55] awjr: you have -mem twice? [17:43:01] oops [17:43:03] good catch thanks [17:43:05] :) [17:43:33] thanks! [17:44:10] YuviPanda: sorry - another error i saw was: [17:44:10] Can't load '/usr/lib/perl/5.14/auto/IO/IO.so' for module IO: /usr/lib/perl/5.14/auto/IO/IO.so: failed to map segment from shared object: Cannot allocate memory at /usr/share/perl/5.14/XSLoader.pm line 71. [17:44:10]  at /usr/lib/perl/5.14/IO.pm line 11 [17:44:11] Compilation failed in require at /usr/lib/perl/5.14/IO/Handle.pm line 9. [17:44:11] BEGIN failed--compilation aborted at /usr/lib/perl/5.14/IO/Handle.pm line 9. [17:44:11] Compilation failed in require at /usr/share/perl5/IPC/Run.pm line 1056. [17:44:12] BEGIN failed--compilation aborted at /usr/share/perl5/IPC/Run.pm line 1056. [17:44:13] Compilation failed in require at /usr/bin/jsub line 21. [17:44:14] BEGIN failed--compilation aborted at /usr/bin/jsub line 21. [17:44:19] (03PS20) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) [17:44:21] (03PS3) 10Jdlrobson: WIP: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [17:44:23] (03PS1) 10Jdlrobson: Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 [17:44:44] awjr: yeah, that's just OOM as well. [17:44:46] aye [17:44:46] ok [17:44:57] man im getting the cron emails like 30 mins after the failure [17:44:58] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/71071) (owner: 10Jdlrobson) [17:45:00] (03CR) 10jenkins-bot: [V: 04-1] WIP: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [17:45:04] (03CR) 10jenkins-bot: [V: 04-1] Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 (owner: 10Jdlrobson) [17:45:16] 3MobileFrontend / 3Hygiene: Minimize number of thumb sizes used in MobileFrontend extension - 10https://bugzilla.wikimedia.org/58285#c5 (10Bahodir Mansurov) (In reply to Max Semenik from comment #3) > These sizes should be already present from other sources eg 120, 150, 180, > 200, 250 and 300 from standard... [17:46:01] jdlrobson, hi, where is Max? [17:46:12] bmansurov: MaxSem [17:46:44] awjr, oh thanks, I thought he was offline [17:46:59] bmansurov: he can be sneaky like that ;) [17:47:10] lol [17:47:57] awjr: heh, I've cron emails from a *lot* more tools, and also the underlying infrastructure :) [17:47:59] RIP Inbox [17:48:08] lol [17:48:15] bmansurov: sometimes he's OuKB as well, when he doesn't want people knowhing where he is :) [17:48:22] YuviPanda: here's a different one: [17:48:23] Use of uninitialized value $prog in scalar chomp at /usr/bin/jsub line 112. [17:48:23] Use of uninitialized value $prog in -l at /usr/bin/jsub line 113. [17:48:23] Use of uninitialized value $prog in pattern match (m//) at /usr/bin/jsub line 127. [17:48:23] /data/project/bugello//data/project/bugello/bin/bugello_flow: No such file or directory [17:48:34] oh i should have read that before i sent it [17:48:40] bmansurov, have you applied for cloak? [17:48:50] awjr: path seems wrong [17:49:01] YuviPanda: yeah it does - but it hasn't changed [17:49:05] YuviPanda, what's OuKB? [17:49:11] MaxSem, yes, how do I use it now? [17:49:19] bmansurov: no idea, just MaxSem's alt nick. Some heavy metal band, perhaps [17:49:20] YuviPanda: and the path loooks right in the cronjob - unless jsub is now expecting relative paths? [17:49:42] well, you have no cloak so I assume you still don't have it [17:49:44] bmansurov: it should be fine with relative paths, can you try running the cron command by hand, see if it still fails? [17:50:05] YuviPanda: no failure [17:50:31] awjr: hmm, transient failures, I guess. let's wait an hour to see if they clear up? [17:50:51] YuviPanda: aight [17:51:34] (03CR) 10Jdlrobson: [C: 04-1] "a few tweaks needed" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164371 (https://bugzilla.wikimedia.org/50396) (owner: 10Florianschmidtwelzow) [17:52:11] bmansurov, can you give +2 in gerrit now? [17:52:25] MaxSem, I think I applied for it but haven't heard about it yet. [17:52:28] MaxSem, no [17:55:11] MaxSem, these are the 2 requirements for obtaining a cloak that I don't fulfil: 1) User must have at least 250 edits on Wikimedia projects; 2) User must have a Wikimedia project account registered for at least three months [17:57:24] * FlorianSW is looking for a new battery for his mouse [18:01:02] (03PS4) 10Jdlrobson: Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 [18:01:50] 3MobileFrontend / 3Hygiene: Minimize number of thumb sizes used in MobileFrontend extension - 10https://bugzilla.wikimedia.org/58285#c6 (10Max Semenik) No. [18:02:35] (03CR) 10Florianschmidtwelzow: Remove lead section in talk Overlay (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164371 (https://bugzilla.wikimedia.org/50396) (owner: 10Florianschmidtwelzow) [18:03:11] (03PS2) 10Florianschmidtwelzow: Remove lead section in talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164371 (https://bugzilla.wikimedia.org/50396) [18:03:22] awjr: just a fyi, the jsub errors are just other people apparently 'testing in production' :) should be gone now [18:04:33] YuviPanda: ahha! thanks [18:06:05] (03PS5) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [18:06:09] (03PS2) 10Jdlrobson: Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 [18:06:14] (03PS4) 10Jdlrobson: WIP: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [18:15:15] 3Wikipedia App / 3General/Unknown: iOS & Android: MobileFrontend styles unconditionally adding borders to tables - 10https://bugzilla.wikimedia.org/68579#c2 (10Bahodir Mansurov) Created attachment 16647 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16647&action=edit Are we talking about the table at... [18:17:46] MaxSem, how can I lock the database? I'm trying to reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=67514 [18:18:20] bmansurov, MaxSem: https://www.mediawiki.org/wiki/Manual:$wgReadOnly [18:18:29] FlorianSW, thanks [18:18:38] should be enough to reproduce :) [18:20:27] (03PS1) 10Mhurd: Work in progress. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164400 [18:21:29] (03PS2) 10Mhurd: Auto scaling for all interfaces for tablets. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164400 [18:22:32] brion: ^ here it is :) i had to tweak the “More…” patch on top of the scaling stuff, but it’s working nicely now [18:22:49] :D awesome [18:23:15] brion: i’ll try to get that non-lead-section-injection patch to you in a bit :) [18:23:16] 3MobileFrontend / 3stable: When wiki is read-only (wgReadOnly), mobile editor doesn't know what to do - 10https://bugzilla.wikimedia.org/67514 (10Florian) [18:23:51] sweet! [18:29:29] (03PS5) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [18:34:52] brion: oops i forgot a qqq entry.. [18:34:58] brion: adding now [18:35:02] heh ok [18:36:15] (03PS3) 10Mhurd: Auto scaling for all interfaces for tablets. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164400 [18:39:47] brion: “wikipedia/qqq.lproj/Main_iPhone.strings” has a “MISSING DESCRIPTION; DO NOT COMMIT FILE YET" message and i cant figure out why… any ideas? [18:40:25] hmm lemme check it [18:41:18] mhurd: looks like a label got added which has the default text “Label” [18:41:28] brion: lol [18:41:45] brion: do i just blank it out? [18:41:49] if we’re setting it programatically then clearing the text in the storyboard should fix it yeah [18:41:59] brion: k one sec... [18:42:16] mhurd: ok it looks like the more lable changed from a generic view to a label in the storyboard [18:42:40] brion: oh i needed a container view and the label as well... [18:42:47] and that’s why the text got added [18:42:49] ok that makes sense :D [18:42:56] brion: ah [18:45:46] 3MobileFrontend / 3beta: Talk overlay conflicting with tap event? - 10https://bugzilla.wikimedia.org/64105 (10Jon) 5PATC>3RESO/FIX [18:46:33] (03PS1) 10Jdlrobson: Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) [18:46:59] 3MobileFrontend / 3Hygiene: Hygiene: Change editor URL to use leading / - 10https://bugzilla.wikimedia.org/70904 (10Jon) 5PATC>3RESO/FIX [18:47:06] (03PS2) 10Jdlrobson: WIP: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) [18:47:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [18:47:47] 3MobileFrontend / 3stable: iPad tablet to mobile redirect not working (cookie or cache-related?) - 10https://bugzilla.wikimedia.org/66888 (10Jon) 5PATC>3RESO/FIX [18:48:06] (03PS4) 10Mhurd: Auto scaling for all interfaces for tablets. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164400 [18:48:18] 3MobileFrontend / 3General/Unknown: Accessibility of headers broken due to accessibility enhancements - 10https://bugzilla.wikimedia.org/68371#c4 (10Jon) 5PATC>3NEW Releasing into wild. [18:48:36] brion: ^fixed :) [18:48:42] \o/ [18:48:53] (03Abandoned) 10Jdlrobson: Make sure headings with role button also have the heading role [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [18:49:45] 3MobileFrontend / 3stable: Mobile MediaViewer: Inapprehensible licensing information - 10https://bugzilla.wikimedia.org/70151 (10Jon) 5PATC>3RESO/FIX [18:51:16] brion: do you want me to -1 the more patch since i merged it into the scaling patch, or do you just want to abandon it? [18:51:26] mhurd: i’ll abandon it [18:51:30] (03PS21) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) [18:52:00] (03Abandoned) 10Brion VIBBER: Turn ... button into a "More..." button [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/163670 (owner: 10Brion VIBBER) [18:52:03] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [18:53:58] brion: battery about gone… back online after lunch :) [18:54:09] ok :D [18:54:15] 3MobileFrontend / 3Hygiene: Standardise on our grey colours - 10https://bugzilla.wikimedia.org/65381#c1 (10Jon) Whoever works on this: You will need to audit all our existing grays, replace them with variables and then replace the non-standard ones with the ones defined in core resources/src/mediawiki.less/m... [18:57:39] (03CR) 10Jdlrobson: [C: 032] Remove lead section in talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164371 (https://bugzilla.wikimedia.org/50396) (owner: 10Florianschmidtwelzow) [18:58:44] FlorianSW: if you ever run out of stuff to do https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&namedcmd=MediaWikiUI helps mobile too :) [18:58:53] you're on fire :) [18:59:11] "The search named MediaWikiUI does not exist." [18:59:13] :P [18:59:19] but i know what you mean, i think :D [18:59:24] jdlrobson ^ [18:59:28] (03Merged) 10jenkins-bot: Remove lead section in talk Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164371 (https://bugzilla.wikimedia.org/50396) (owner: 10Florianschmidtwelzow) [18:59:59] FlorianSW: try https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=MediaWikiUI&sharer_id=14942 [19:00:18] 3MobileFrontend / 3beta: Talk page overlay lead section - 10https://bugzilla.wikimedia.org/50396 (10Jon) 5PATC>3RESO/FIX [19:01:34] jdlrobson: maybe i take a look on it from time to time :) Just to say this way: i love MW UI, it's a great design and easy to use :) [19:03:18] FlorianSW: :) [19:03:47] 3Wikipedia App / 3General/Unknown: pressing back from article accessed via nearby does not display nearby list - 10https://bugzilla.wikimedia.org/71567 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Article A → Nearby → Article B → Back → Article A pressing back should probably relaunch... [19:04:48] (03PS22) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) [19:05:19] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [19:09:59] (03CR) 10Brion VIBBER: "couple quick notes from looking at code, now testing :D" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164400 (owner: 10Mhurd) [19:23:43] (03PS1) 10Bmansurov: Show the correct error message when saving in EditorOverlay when the database is in readonly mode. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) [19:25:20] (03CR) 10Brion VIBBER: "Ok looks pretty good... Touch targets and some fonts seem a bit large on a full-size iPad, but things still *feel* more proportionate sinc" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164400 (owner: 10Mhurd) [19:33:58] (03CR) 10Bmansurov: [C: 031] Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [19:36:17] 3MobileFrontend / 3General/Unknown: Clicking on a link with ... suffix goes to a wrong page - 10https://bugzilla.wikimedia.org/71569 (10Stryn) 3NEW p:3Unprio s:3normal a:3None I'm using fi.m.wikipedia.org and if I click the page title link (Wikipedia:Tiesitkö että...) at https://fi.m.wikipedia.org/wi... [19:38:05] Hey, anyone around? [19:38:18] Mobile seems to be causing a fuckload of I guess 404s [19:38:27] File does not exist: /srv/mediawiki/docroot/wikipedia.org/upload.wikimedia.org, referer: http://zh.m.wikipedia.org/wiki/%E9%A6%99%E6%B8%AF [19:38:28] etc [19:40:32] 3MobileFrontend / 3General/Unknown: Clicking on a link with ... suffix goes to a wrong page - 10https://bugzilla.wikimedia.org/71569#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/oq1aDY12 [19:42:52] kristenlans: hey! I responded 'no' to the app team health check. I figured now that I'm close to transitioning out, you guys could use the extra time of me not talking much :) [19:51:21] (03CR) 10Florianschmidtwelzow: [C: 04-1] "You need to add the message key to inclueds/Resources.php to use it in JavaScript :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) (owner: 10Bmansurov) [19:55:56] (03PS2) 10Bmansurov: Show the correct error message when saving in EditorOverlay when the database is in readonly mode. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) [19:57:08] (03PS23) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) [19:57:10] (03PS1) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [19:57:51] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [19:57:56] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [19:58:12] bmansurov: i see, that sometimes you have really long commit message titles :D Better is to summarize the change with some words and explain the change more detailed as the body. If you ok with this, i can change the commit message of your error message in editoroverlay change to show, what i mean (as an example) :) [20:00:41] FlorianSW, yes, please do [20:01:02] (03PS3) 10Florianschmidtwelzow: Indicate read-only error in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) (owner: 10Bmansurov) [20:01:28] bmansurov ^^ [20:01:29] FlorianSW, looks good, thanks [20:01:40] bmansurov: there is a convention for this somewhere, wait [20:02:09] * FlorianSW digging through mediawiki.org contents [20:02:34] MediaWiki itself: https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines [20:02:36] Mobile web: https://www.mediawiki.org/wiki/Mobile_web/Coding_conventions#Commit_Messages [20:02:40] bmansurov: ^^ [20:03:31] Deskana|Away: ready when you are [20:03:55] FlorianSW, thanks for the link. I'll keep the convention in mind. [20:04:23] great bmansurov :) (the most important thing is the length :P in my opinion) [20:05:29] FlorianSW, my messages will be short, so short that you won't know they are about, jk [20:05:38] what* [20:05:41] lol :D [20:05:55] not so short :P [20:06:48] FlorianSW, I found this (https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2013-11-21) from the link you gave. I think it'll serve as a good example. [20:07:25] bmansurov: jap :) [20:09:22] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Compare: https://en.m.wikipedia.org/w/index.php?title=Wikipedia:WikiProject_Breakfast&mobileaction=alpha ...and... https:/... [20:10:33] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/q3UhD8Ur [20:10:35] 3MobileFrontend / 3General/Unknown: Mobile sites are causing a lot of 404s in production - 10https://bugzilla.wikimedia.org/71571 (10Sam Reed (reedy)) 3NEW p:3Unprio s:3normal a:3None Things like: File does not exist: /srv/mediawiki/docroot/wikipedia.org/upload.wikimedia.org, referer: http://zh.m.wi... [20:12:37] Reedy, where are the logs for ^^^ ? [20:12:47] 3MobileFrontend / 3General/Unknown: WikiGrok buttons misaligned again on beta labs/iOS - 10https://bugzilla.wikimedia.org/71572 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Navigate to Beta Labs on an iPhone (I'm on a 5c), log in, opt into beta and visit Anne Dallas Dudley with the wikidata I... [20:13:57] MaxSem: fluorine:/a/mw-log/apache2.log [20:14:01] Or in logstash [20:14:04] They're hard to miss [20:14:11] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Sorry, my fault :/ You don't need an extra message for this. There is no case, where we don't get an error message. API always set's the s" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) (owner: 10Bmansurov) [20:15:32] 3MobileFrontend / 3General/Unknown: WikiGrok buttons misaligned again on beta labs/iOS - 10https://bugzilla.wikimedia.org/71572#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/m0G1sxic [20:15:32] 3MobileFrontend / 3General/Unknown: Mobile sites are causing a lot of 404s in production - 10https://bugzilla.wikimedia.org/71571#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ohHHx35y [20:15:45] (03CR) 10Mhurd: "Added comments :)" (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164400 (owner: 10Mhurd) [20:15:54] brion: ^ [20:17:53] (03PS1) 10Florianschmidtwelzow: Fix toast error message image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164411 [20:17:56] (03CR) 10Brion VIBBER: Auto scaling for all interfaces for tablets. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164400 (owner: 10Mhurd) [20:18:10] jdlrobson: one second? :) https://gerrit.wikimedia.org/r/164411 [20:18:12] mhurd: i’m gonna go ahead and merge, \o/ [20:18:18] (03CR) 10Bmansurov: "Do you mean I should remove the else part and then remove the message from the Resources.php?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) (owner: 10Bmansurov) [20:18:20] (03CR) 10Brion VIBBER: [C: 032 V: 032] Auto scaling for all interfaces for tablets. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164400 (owner: 10Mhurd) [20:18:23] brion: woohoo! [20:18:27] brion: thx! [20:18:35] thank you, good work :D [20:18:44] brion: thanks :) [20:20:19] (03PS24) 10Jdlrobson: WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) [20:20:21] (03PS2) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [20:20:23] (03PS1) 10Jdlrobson: Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 [20:20:39] Deskana: scaling and “more…” button merged :) [20:20:53] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [20:20:56] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [20:21:06] “but wait, there’s More…” [20:21:10] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [20:21:16] hehe [20:22:45] TrevorP|Away: jdlrobson: two bits for tomorrows meeting. i see that the OOUI template star widget has fallen off the agenda. was that intentional? and the second is that this will be the third time that we've met and i'd like to do a short 10min retrospective about what's working well/poorly/confusing us [20:23:08] tfinc: k [20:24:32] tfinc: you want to do this in person? [20:24:51] jdlrobson: at tomorrows FE standards meeting [20:25:58] k [20:26:18] 3MobileFrontend / 3stable: #undefined hash appended on page views - 10https://bugzilla.wikimedia.org/71573 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3None Go to https://zh.m.wikipedia.org/wiki/宋任窮 and you will have #undefined appended to URL once page loads. Reproduced in desktop Chrome and FF. Prob... [20:26:30] jdlrobson: Also, another CSS problem from WikigrokB: https://bugzilla.wikimedia.org/show_bug.cgi?id=71572. Can you go ahead and fix those and I'll swat deploy them. [20:27:14] jdlrobson: I think that one's related to the margin and padding for the panel [20:27:32] kaldari: taking a look.. [20:29:48] fix on way [20:29:50] (03PS25) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) [20:30:29] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [20:30:30] 3MobileFrontend / 3stable: #undefined hash appended on page views - 10https://bugzilla.wikimedia.org/71573#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/7kDNfITT [20:33:34] (03PS1) 10Jdlrobson: Prevent button stacking in wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164418 (https://bugzilla.wikimedia.org/71572) [20:33:35] ^ kaldari [20:34:14] jdlrobson: I'm also reviewing some of your other patches now [20:38:23] (03CR) 10Kaldari: [C: 032] Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 (owner: 10Jdlrobson) [20:39:19] FlorianSW, is there a way to randomly create say 50 pages for testing? [20:40:25] jdlrobso_: Also, did my comment about the footer height in WikigrokB make sense? Would be good to fix that as well so I can cherry pick both. [20:40:32] bmansurov: no easy way i know :/ [20:40:44] i haven't managed to check out that comment yet kaldari :/ [20:40:51] FlorianSW, ok thanks [20:41:03] got the link handy? [20:41:24] bmansurov: you can create it manually, or you just export some pages from wikipedia (Special:Export) and import them into your local wiki (Special:Import) [20:41:35] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Cleanup PHP generation of icons for skins (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [20:41:59] FlorianSW, that's a great idea. thanks [20:42:58] if the namespace is irrelevant you can just export a complex template, normally there are ranscluded some other templates, so, if you have luck, you only need to type 4-5 pagenames and click "export templates, too" :D [20:43:04] bmansurov ^^ [20:43:38] FlorianSW, ok. I'm getting a permission error while importing, how can I get past it? [20:44:20] bmansurov: are you logged in with your admin account? if not, give yourself the import right [20:44:37] (adminsistrators normally have this right already) [20:44:55] FlorianSW, I think my account is a regular one. How can I make it an admin account? [20:45:27] kaldari: do you remember what page on wikidata had that nice handly list of the 5 or so item types? [20:45:32] people, events, etc.? [20:45:35] use the account you created in installation process :) [20:45:39] i'm driving myself insane trying to find it [20:45:47] Maryana: item types? [20:46:04] e.g. people, events, places... [20:46:10] FlorianSW, ok thanks [20:46:17] bmansurov: if you don't know this account (login details) anymore, you have to give yourself admin rights. [20:46:20] kaldari: there was one page that had a nice high-level list [20:46:23] and i can't find it anymore [20:46:34] (03CR) 10Jdlrobson: [C: 031] "Seems fine but not sure how to test. MaxSem?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) (owner: 10Bmansurov) [20:47:00] jdlrobso_, $wgReadOnly [20:47:17] bmansurov: found your admin account? [20:47:36] FlorianSW, no I haven't. How can I give myself admin rights? [20:47:55] Maryana: I don't think I've ever seen such a page, but it sounds useful :) [20:48:04] it might not exist anymore.. [20:48:05] (03CR) 10Florianschmidtwelzow: "@Jon: Set $wgReadOnly in your LocalSettings to true or any other string to test and then edit a page :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) (owner: 10Bmansurov) [20:48:28] kaity: do you remember that wikidata page that describes the high-level wikidata item types? [20:48:33] bmansurov: set userrights to true for the group users: $wgGroupPermissions['users']['userrights'] = true; [20:48:34] i can't find it anymore :( [20:48:51] bmansurov: go to Special:UserRights/bmansurov (bmansurov -> your username) [20:48:59] FlorianSW, thanks [20:49:02] bmansurov: check the adminstrator checkbox and click save [20:49:07] ok [20:49:22] bmansurov: after this, remove the userrights right from users :) [20:49:29] ok [20:50:28] jdlrobso_: one question about mw-ui? :) [20:50:36] (03PS3) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [20:50:46] Maryana: I'm looking [20:51:00] i thought it was glossary, but that looks different now :-/ [20:51:00] jdlrobso_: HTMLForm has no way to use mw-ui checkboxes instead of "normal" styled? [20:51:07] (03PS2) 10Jdlrobson: Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 [20:51:21] (03PS26) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) [20:51:46] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [20:51:52] i love wikidata, but it seriously reminds me of borges: https://en.wikipedia.org/wiki/Celestial_Emporium_of_Benevolent_Knowledge [20:51:56] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [20:52:00] Maryana: yea everything moved around! [20:52:04] (03CR) 10Kaldari: [C: 04-1] Add tooltips to all standalone icons (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163277 (https://bugzilla.wikimedia.org/50705) (owner: 10Jdlrobson) [20:52:36] Maryana: haha that page is awesome [20:54:54] Maryana: I think this is the page [20:54:55] https://www.wikidata.org/wiki/Wikidata:List_of_properties [20:55:33] kaity: awesome <3 <3 <3 [20:55:50] (03CR) 10Kaldari: [C: 04-1] Prevent button stacking in wikigrok (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164418 (https://bugzilla.wikimedia.org/71572) (owner: 10Jdlrobson) [21:00:55] MaxSem: https://github.com/kaldari/WikiGrokAPI [21:03:45] 3MobileFrontend / 3Feature requests: Add 'more' button at end of watch list, to look further in history - 10https://bugzilla.wikimedia.org/68368#c2 (10Bahodir Mansurov) How can I reproduce it? I have 57 items on my watchlist, and all of them show up. How many items should I add before some of them don't show... [21:04:06] (03CR) 10Florianschmidtwelzow: Hygiene: Cleanup PHP generation of icons for skins (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [21:20:03] MaxSem: https://bitbucket.org/magnusmanske/wikidata-game/src/f90f509f3d09e0236a752c487e48c98d707bce56/tools/?at=master [21:27:23] (03PS1) 10Yurik: Per Timo: minor javascript optimizations [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164454 [21:27:35] tfinc, do you have a link to hangout? [21:27:46] jhobs, ^^ [21:31:33] bmansurov: hangout added [21:41:45] 3MobileFrontend / 3Feature requests: Add 'more' button at end of watch list, to look further in history - 10https://bugzilla.wikimedia.org/68368#c3 (10Jon) MMM.. According to code 50 should be enough. const LIMIT = 50; // Performance-safe value with PageImages Try dropping that to 1 or 2 and see what happ... [21:45:51] 3MobileFrontend / 3stable: opening sidebar menu doesn't work correctly on iPhone6+ - 10https://bugzilla.wikimedia.org/71575 (10Ryan Kaldari) 3NEW p:3Unprio s:3critic a:3None The first time you click on the sidebar menu it just displays the mobile safari toolbar. You then have to scroll up and click i... [21:48:04] 3MobileFrontend / 3General/Unknown: Need to re-evaluate tablet/phone thresholds with iPhone 6 and 6+ - 10https://bugzilla.wikimedia.org/71576 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None We need to see what modes these phones trigger and whether those modes make sense. Needs PM input. [21:50:33] 3MobileFrontend / 3General/Unknown: Need to re-evaluate tablet/phone thresholds with iPhone 6 and 6+ - 10https://bugzilla.wikimedia.org/71576#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/0cOfs9Dk [21:50:34] 3MobileFrontend / 3stable: opening sidebar menu doesn't work correctly on iPhone6+ - 10https://bugzilla.wikimedia.org/71575#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9eneyAVV [22:11:45] 3MobileFrontend / 3Feature requests: Add 'more' button at end of watch list, to look further in history - 10https://bugzilla.wikimedia.org/68368#c4 (10Florian) Remember, that, if you click the "Watchlist" link in left navigation, you normally ends up in Special:EditWatchlist, which uses SpecialEditWatchlist'... [22:11:54] bmansurov ^^ [22:12:33] FlorianSW, great, that's it. [22:12:34] thanks [22:12:45] bmansurov: np ;) [22:14:56] (03CR) 10Jhobs: [C: 031] "I don't see any problems." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164454 (owner: 10Yurik) [22:17:47] 3MobileFrontend / 3alpha: problems with footer formatting in WikiGrok dialog B - 10https://bugzilla.wikimedia.org/71577 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Created attachment 16651 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16651&action=edit screenshot of unwrapped footer T... [22:18:15] 3MobileFrontend / 3alpha: problems with footer formatting in WikiGrok dialog B - 10https://bugzilla.wikimedia.org/71577#c1 (10Ryan Kaldari) Created attachment 16652 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16652&action=edit screenshot of wrapped footer [22:20:30] 3MobileFrontend / 3alpha: problems with footer formatting in WikiGrok dialog B - 10https://bugzilla.wikimedia.org/71577#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/mzgbFQK2 [22:25:17] (03PS27) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) [22:26:12] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [22:42:17] (03PS2) 10Kaldari: Prevent button stacking in wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164418 (https://bugzilla.wikimedia.org/71572) (owner: 10Jdlrobson) [22:42:52] (03CR) 10Kaldari: [C: 032] Prevent button stacking in wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164418 (https://bugzilla.wikimedia.org/71572) (owner: 10Jdlrobson) [22:43:23] (03Merged) 10jenkins-bot: Prevent button stacking in wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164418 (https://bugzilla.wikimedia.org/71572) (owner: 10Jdlrobson) [22:43:30] 3MobileFrontend / 3General/Unknown: WikiGrok buttons misaligned again on beta labs/iOS - 10https://bugzilla.wikimedia.org/71572 (10Ryan Kaldari) 5PATC>3RESO/FIX [22:46:05] brion: vibha found a small margin issue on ios8 with the “more…” button. preparing tiny patch [22:46:26] (03PS2) 10BearND: More Nearby styling changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163960 [22:47:19] (03PS1) 10Mhurd: Fix for more button left margin on ios 8. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164484 [22:47:36] brion: ^ fixed :) [22:48:40] jdlrobson, you there? [22:52:38] (03PS1) 10Kaldari: Prevent button stacking in wikigrok [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164485 (https://bugzilla.wikimedia.org/71572) [22:53:42] (03CR) 10Kaldari: [C: 032] Prevent button stacking in wikigrok [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164485 (https://bugzilla.wikimedia.org/71572) (owner: 10Kaldari) [22:54:14] (03Merged) 10jenkins-bot: Prevent button stacking in wikigrok [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164485 (https://bugzilla.wikimedia.org/71572) (owner: 10Kaldari) [22:57:28] (03PS1) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164486 [23:02:00] 3MobileFrontend / 3Hygiene: Standardise on our grey colours - 10https://bugzilla.wikimedia.org/65381#c2 (10Bahodir Mansurov) Are you saying that if '#cacaca' is not defined in either variables.less file, then replace it with the closest color, which might be '#ccc'? [23:13:30] (03CR) 10Kaldari: [C: 04-1] "Florian is right. It looks like we don't need a separate message for this since the API always returns a response.error.info message when " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) (owner: 10Bmansurov) [23:19:24] kaldari: i can haz wikigrok on enwiki? [23:20:03] Maryana: yes, it's live, but waiting for cache to clear [23:20:14] oh! ok :) [23:20:18] i am excite [23:20:20] Maryana: https://en.m.wikipedia.org/wiki/Anne_Dallas_Dudley?debug=true works though [23:20:40] (03CR) 10Florianschmidtwelzow: "But, what comes into my head just now, the message isn't translated, it is hard coded into API code, so all users will get the english err" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) (owner: 10Bmansurov) [23:22:00] Maryana: Seems to be working now [23:22:02] kaldari: how are we looking for our next set of onboarding next week ? [23:22:32] tfinc: that's my next priority [23:22:43] tfinc: still have some work to do before Monday [23:22:52] yay, i see it! [23:22:53] tfinc: for the onboarding [23:22:57] :D [23:23:14] kaldari: great, let me know if you need anything from me or the rest of the team to get going on it [23:23:21] Maryana: confirmed that it is collected data [23:23:28] tfinc: thanks [23:23:49] kaldari: yep, i see me in the logs. yayayaya [23:25:08] (03PS1) 10Bmansurov: WIP: Standardize grey colors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164488 (https://bugzilla.wikimedia.org/65381) [23:29:28] (03PS3) 10Jdlrobson: Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 [23:29:30] (03PS28) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) [23:29:32] (03PS4) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [23:30:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [23:30:10] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [23:34:35] awjr: i'm in the same quarterly review as you :) [23:36:26] (03PS29) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) [23:36:32] (03PS2) 10BearND: [WIP] Gradle package (applicationId) rename [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 [23:36:55] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Gradle package (applicationId) rename [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 (owner: 10BearND) [23:37:01] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [23:39:14] awjr: delayed 5-10min [23:39:44] tfinc: eh? [23:40:12] awjr: we have a 1:1, i'm delayed to it [23:40:18] MaxSem, what's the default vagrant password? [23:40:35] is there such a thing? [23:40:51] MaxSem, I'm trying to scp something to it and it's asking for a password [23:41:15] no need for scp causee you have a mapped directory [23:41:30] tfinc_: we do? not on my calendar [23:41:39] MaxSem, I'm not able to git review because my key is not in the vagrant machine [23:41:54] that's good [23:41:59] commit from host [23:42:22] MaxSem, it says Makefile:60: recipe for target 'phpcheck' failed [23:42:34] MaxSem, I wouldn't like to setup php on the host [23:43:05] that's why you shouldn't use silly git hooks [23:43:13] awjr: yup, your on the invite [23:43:22] wtf [23:43:29] MaxSem, can I at least turn off php hooks? how? [23:43:33] im in another mtg now with rob - i dont see ours :( [23:44:00] see what dev-scripts/install-hooks.sh does and do the opposite [23:44:10] MaxSem, ok thanks [23:44:30] 3MobileFrontend / 3Hygiene: Standardise on our grey colours - 10https://bugzilla.wikimedia.org/65381#c4 (10Jon) Not quite.. I'm suggesting that if we use #cacaca somewhere we should capture it in a meaningful variable name based on how it is being used and put it in our variables file e.g. iconOverlayText:... [23:45:36] (03PS1) 10Mhurd: Prevent jitter when loading lead section on slow connection. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164490 [23:47:16] (03PS4) 10Bmansurov: Indicate read-only error in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) [23:48:01] awjr: k [23:53:31] (03PS6) 10Jdlrobson: Add tooltips to all standalone icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163277 (https://bugzilla.wikimedia.org/50705) [23:54:20] (03PS11) 10Jdlrobson: Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 [23:54:30] (03CR) 10Jdlrobson: [C: 032] "cherrypicked" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 (owner: 10Jdlrobson) [23:55:02] (03Merged) 10jenkins-bot: Hygiene: Add back button partial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/162306 (owner: 10Jdlrobson) [23:55:04] (03CR) 10Jdlrobson: [C: 032] Fix toast error message image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164411 (owner: 10Florianschmidtwelzow) [23:55:34] (03Merged) 10jenkins-bot: Fix toast error message image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164411 (owner: 10Florianschmidtwelzow) [23:59:46] (03CR) 10Jdlrobson: [C: 032] Indicate read-only error in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) (owner: 10Bmansurov)