[00:00:02] (03CR) 10Jdlrobson: "Thanks Florian :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) (owner: 10Bmansurov) [00:00:19] (03Merged) 10jenkins-bot: Indicate read-only error in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164407 (https://bugzilla.wikimedia.org/67514) (owner: 10Bmansurov) [00:01:19] tfinc im so confused about that 1:1 invite. it's not on my calendar, but when i look at the invite on your calendar i am definitely there :-/ [00:03:05] (03PS1) 10Mhurd: Long press back or forward buttons brings up history. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164495 [00:10:30] (03CR) 10Jdlrobson: [C: 04-1] "Instead of Object {Anne Dallas DudleyFoo_2: 1412294934190}" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [00:13:01] 3MobileFrontend / 3Feature requests: Add 'more' button at end of watch list, to look further in history - 10https://bugzilla.wikimedia.org/68368#c5 (10Jon) Baha said: @jonrobson1 How should the "more" button look? Which of the .ui-mw- class should I use? May.... According to http://tools.wmflabs.org/stylegu... [00:13:31] (03PS2) 10Jdlrobson: Remove ajax refresh from editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164131 (https://bugzilla.wikimedia.org/69559) [00:14:30] 3MobileFrontend / 3Feature requests: Add 'more' button at end of watch list, to look further in history - 10https://bugzilla.wikimedia.org/68368#c6 (10Bahodir Mansurov) I think progressive. [00:14:38] brion: i sent a couple patches your way and bernd ran the twn import too :) [00:15:24] brion: gonna head out and start plowing through the AFNetworking udpates tomorrow [00:18:25] prtksxna: hey you there [00:30:15] 3MobileFrontend / 3stable: When wiki is read-only (wgReadOnly), mobile editor doesn't know what to do - 10https://bugzilla.wikimedia.org/67514 (10Florian) 5PATC>3RESO/FIX [00:43:06] (03PS1) 10Jdlrobson: Wikigrok B improvements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 [00:44:44] 3MobileFrontend / 3stable: Watchlist doesn't redirect to login on mobile - 10https://bugzilla.wikimedia.org/71206#c2 (10Jon) http://en.wikipedia.beta.wmflabs.org/wiki/Special:Uploads has the same problem and should also be fixed. [01:18:00] James_F|Away: Hey [01:18:18] Oops! Please ignore that James_F|Away [03:13:23] (03PS2) 10Krinkle: Minor javascript optimizations [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164454 (owner: 10Yurik) [03:13:29] (03CR) 10Krinkle: [C: 031] Minor javascript optimizations [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164454 (owner: 10Yurik) [05:17:27] (03CR) 10Yurik: [C: 032] Minor javascript optimizations [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164454 (owner: 10Yurik) [05:17:43] (03Merged) 10jenkins-bot: Minor javascript optimizations [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164454 (owner: 10Yurik) [07:17:34] (03PS1) 10Yurik: Removed isZeroSite()'s caching [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164519 [07:25:00] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c20 (10Andyrom75) Could the resolution of bug 65047 be applied on https://it.wikivoyage.org to solve the wrong switch from mobile version into desktop version? FYI The problem on wikivoy... [07:25:45] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c21 (10Andyrom75) Ops, I meant bug 66888 [12:04:48] 3MobileFrontend / 3stable: VisualEditor switcher isn't visible - 10https://bugzilla.wikimedia.org/71608 (10Florian) 3NEW p:3Unprio s:3major a:3None Created attachment 16659 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16659&action=edit Switcher icon not visible In EditorOverlay the icon fo... [12:05:32] 3MobileFrontend / 3stable: VisualEditor switcher isn't visible - 10https://bugzilla.wikimedia.org/71608#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/799d4SR5 [12:26:18] (03PS1) 10Florianschmidtwelzow: Use less function to embed editor images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164543 (https://bugzilla.wikimedia.org/71608) [17:07:38] first post [17:07:56] or netsplits [17:08:03] ? [17:08:21] dr0ptp4kt: welcome back :) [17:08:35] bearND: good to be back [17:10:23] \o/ [17:11:05] dr0ptp4kt: welcome back! [17:14:00] YuviPanda: holla [17:14:05] :D [17:14:07] and hola [17:16:44] jdlrobson: https://gerrit.wikimedia.org/r/#/c/164533/ this means, that Xml::checkLabel is already ok so? [17:23:47] 3MobileFrontend / 3stable: Browser test: cancel button changes - 10https://bugzilla.wikimedia.org/71613 (10Jon) 3NEW p:3Unprio s:3normal a:3None Wikitext Editor.Closing editor (overlay button) is failing Need to change the selector Probably broken by Ie69635f8b2638354baefb4dda0421c1b9e823050 [17:25:12] (03PS2) 10Jdlrobson: Wikigrok B improvements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 (https://bugzilla.wikimedia.org/71577) [17:25:54] 3MobileFrontend / 3stable: Browser test: cancel button changes - 10https://bugzilla.wikimedia.org/71613#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ix3s3LbD [17:26:41] FlorianSW: correct checkLabel should be fine [17:27:07] jdlrobso_ Ok, then there aren't really changes for this Specialpage :) [17:28:22] mmm [17:28:26] FlorianSW: this bug seems weird [17:28:31] prtksxna: did you bug triage? [17:28:35] i think you are causing confusion. [17:28:48] jdlrobso_: :P [17:29:50] FlorianSW: yeh it looks like this page works. I guess maybe Context title, for {{FULLPAGENAME}}, etc.: should be mw-ui-input-inline though [17:29:57] jdlrobso_: not "no" problem :) The mw-ui-inline is correct :P [17:30:01] yeah :D [17:30:05] that i mean :P [17:30:13] okay cool. shall i reopen it? [17:30:31] jdlrobso_: i don't think so, let me remove the mw-ui-input from my change and then simply merge? [17:30:38] FlorianSW: sounds good. [17:31:00] jdlrobso_: No I haven't yet. Was sleeping the whole day yesterday :( [17:31:03] FlorianSW: seems you can use Xml::submitButton [17:31:11] but no harm in switching :) [17:31:23] jdlrobso_: Jap, if you have no special reason [17:31:30] that would be my next question :P [17:31:36] both check for use mwuieverywhere [17:31:41] You can close them as you find them. I'll try and do the same today [17:35:22] FlorianSW: thanks for the Ve catch! [17:35:22] (03PS5) 10Bmansurov: WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [17:35:26] (03CR) 10jenkins-bot: [V: 04-1] WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [17:35:30] (03CR) 10Bmansurov: "I've fixed the formatting issues." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [17:35:57] jdlrobso_ i'm wondering, why this works before and not now anymore :P [17:36:05] (03CR) 10Jdlrobson: [C: 032] Use less function to embed editor images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164543 (https://bugzilla.wikimedia.org/71608) (owner: 10Florianschmidtwelzow) [17:36:21] (03PS1) 10Florianschmidtwelzow: Use less function to embed editor images [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164584 (https://bugzilla.wikimedia.org/71608) [17:36:33] jdlrobso_ ^^ [17:37:10] FlorianSW: you're a star. Need to just get someone to LD it [17:37:12] jrlsobso_ backport to wmf1, too? The next release to wikipedias is next wednesday, and next swat is monday [17:37:16] MaxSem or kaldari ^ [17:37:24] friday is no swat, right? [17:37:35] FlorianSW: correct we'll have to deal with it monday i'll send a mail [17:37:36] kaldari's decision [17:37:51] maybe we find someone today :D [17:38:15] (03PS1) 10Florianschmidtwelzow: Use less function to embed editor images [extensions/MobileFrontend] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164587 (https://bugzilla.wikimedia.org/71608) [17:39:07] FlorianSW: mail sent [17:39:20] jdlrobso_ great! :) [17:39:59] i could update the submodule, too, so just someone needs to deploy :) [17:41:24] (03Merged) 10jenkins-bot: Use less function to embed editor images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164543 (https://bugzilla.wikimedia.org/71608) (owner: 10Florianschmidtwelzow) [17:43:21] (03PS3) 10Jdlrobson: Remove ajax refresh from editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164131 (https://bugzilla.wikimedia.org/69559) [17:43:26] (03Abandoned) 10Jdlrobson: Fix redlinks on preview and save [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/160492 (https://bugzilla.wikimedia.org/69559) (owner: 10MaxSem) [17:44:26] bmansurov: https://gerrit.wikimedia.org/r/#/c/164000/ can you make jenkins happy and rebase this patch? :) [17:44:52] FlorianSW, hi, OK [17:45:35] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570#c2 (10Jon) Weird. It will be something to do with how wfRunHooks( 'SkinMinervaDefaultModules', array( $this, &$modules ) ); is run (which Flow uses). Not sure what is happening he... [17:47:09] FlorianSW: erik just replied saying it's a serious bug so may even warrant a friday lightning deploy :) [17:47:40] jdlrobso_: Great! :) [17:48:10] greg-g ^^ [17:50:45] 3MobileFrontend / 3stable: "Read in another language" gives desktop site's links - 10https://bugzilla.wikimedia.org/65047#c22 (10Jon) Not really. The problem here in my opinion is that there should be no redirects involved. If you are viewing mobile site on a desktop computer, go to a language version, you s... [17:51:16] (03PS6) 10Bmansurov: WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [17:53:00] (03CR) 10Bmansurov: "> When testing it doesn't seem to work for me. I click on a > link, click back, but the sections are still closed :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [17:53:53] brion: hey could you peek at those small patches? thinking about cutting testflight build :) [17:53:59] (03Abandoned) 10Jdlrobson: [WIP] QA: Experiments with taking and comparing screenshots [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126878 (owner: 10JGonera) [17:54:12] yeah will momentarily [17:54:19] was fighting with updates on one of my tablets ;) [17:54:29] (03CR) 10Jdlrobson: "Status of this?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142639 (owner: 10MaxSem) [17:55:12] (03CR) 10MaxSem: "Jgonera misunderstood me, can be merged:)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142639 (owner: 10MaxSem) [17:56:04] jdlrobso_: FlorianSW lemme know what you need [17:56:40] greg-g: There is a bug with mobile VE switcher: https://bugzilla.wikimedia.org/show_bug.cgi?id=71608 [17:57:14] greg-g and a patch for it, now it would be great to light deploy this today, and don't wait for monday :) [17:57:53] greg-g & FlorianSW: maxsem can do the lightning deploy [17:57:55] FlorianSW: if Erik says it should go out today, I'll trust that [17:58:00] :) [17:58:01] cool [17:58:03] yeah, he does [17:58:07] danke [17:58:12] MaxSem: no one is doing anything (it's friday) so fire when ready [17:58:20] ok [17:58:39] MaxSem: If you want, i can update the submodule after the patches are merged? [18:01:34] (03CR) 10MaxSem: [C: 032] Use less function to embed editor images [extensions/MobileFrontend] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164587 (https://bugzilla.wikimedia.org/71608) (owner: 10Florianschmidtwelzow) [18:01:49] (03CR) 10MaxSem: [C: 032] Use less function to embed editor images [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164584 (https://bugzilla.wikimedia.org/71608) (owner: 10Florianschmidtwelzow) [18:03:31] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570#c3 (10Florian) This seems to be because of how Alpha and stable recognize, if a talk button is useful or not. If the user has no JS enabled, the talk button should be hidden, if th... [18:05:49] (03Merged) 10jenkins-bot: Use less function to embed editor images [extensions/MobileFrontend] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/164587 (https://bugzilla.wikimedia.org/71608) (owner: 10Florianschmidtwelzow) [18:05:51] (03Merged) 10jenkins-bot: Use less function to embed editor images [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164584 (https://bugzilla.wikimedia.org/71608) (owner: 10Florianschmidtwelzow) [18:12:22] (03PS1) 10Yurik: renamed var, unset it during initialization [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164603 [18:12:45] kristenlans: sorry, meeting skipped my mind. joined now [18:13:01] no worries yuvipanda [18:13:41] (03CR) 10Yurik: [C: 032] renamed var, unset it during initialization [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164603 (owner: 10Yurik) [18:14:09] kristenlans: I'm still going to abstain from all voting, though :) [18:16:03] FlorianSW, Maryana - deployed [18:16:12] thanks MaxSem! [18:16:17] YuviPanda, any way to automate vagrant-labs testing? e.g. try to do "git pull && vagrant-labs provision", followed by a VM disk image rollback? [18:16:21] and FlorianSW for the catch/patch [18:16:21] thanks MaxSem :) [18:16:26] you rock \o/ [18:16:34] yurikR1: ah, not that I know of... [18:16:34] FlorianSW, no - thank you! :) [18:16:35] np Maryana :-) [18:16:38] brion: https://en.wikipedia.org/w/index.php?search=le+cobusier&title=Special%3ASearch&go=Go [18:16:41] don't think we've VM image rollback anywhere, yurikR1 [18:20:24] YuviPanda, i feel like we should start doing it if we ever want to make vagrant into a stable platform. From the looks of it, VM supports snapshots, which is the tech to rollback stuff [18:20:38] yurikR1: vagrant or labs-vagrant? [18:20:42] both [18:20:59] yurikR1: hmm, so with *vagrant*, you can use VirtualBox's snapshots [18:21:10] because we just had labs down for almost two weeks due to some changes in vagrant [18:21:12] yurikR1: https://github.com/dergachev/vagrant-vbox-snapshot [18:21:39] and it could have been eliminated if jenkins would have marked the patch as broken [18:21:40] yurikR1: so we could integrate that into MWV [18:23:01] yurikR1: but I don't know if we'll ever support snapshots on labs [18:23:05] yurikR1: let's talk about that on -labs [18:23:21] oki [18:23:28] sorry, wrong chanel :) [18:24:13] yurikR1: heh :) [18:27:26] (03Merged) 10jenkins-bot: renamed var, unset it during initialization [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164603 (owner: 10Yurik) [18:28:59] yo yo SF peeps if anybody want to come to the Mesosphere BBQ tonight all are welcome http://www.evite.com/l/9tmxnER5Py [18:32:15] 3MobileFrontend / 3stable: VisualEditor switcher isn't visible - 10https://bugzilla.wikimedia.org/71608#c8 (10Florian) 5PATC>3RESO/FIX Working now :) [18:34:58] FlorianSW, jdlrobson: So this change does create a minor regression. RTL flipping doesn't work with SVG + mix-in. [18:35:10] MaxSem: ^ [18:35:35] Why does background-image: embed() not work? [18:35:54] enwiki still works, right? [18:36:44] kaldari: ehm, this is the question, i see, that background-image: now has url(), and the definition of .background-image mixin in less says, that this is used, when embed isn't supported. [18:37:06] but i can't figure out, why :( [18:37:34] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for more button left margin on ios 8. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164484 (owner: 10Mhurd) [18:37:41] kaldaari and at the less file, which handles this in MF (editor.less) and the images aren't any commits [18:37:46] brion: yay! [18:37:48] kaldari ^ [18:38:20] Maybe I should send an email to wikimedia-tech about this [18:38:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164486 (owner: 10BearND) [18:39:33] FlorianSW: So for bug 71608 was that only on certain devices or was that bug happening for everyone? [18:40:20] kaldari: i have tested on Android nexus 7, chrome and ff on windows pc [18:40:37] FlorianSW: And the bug occured on all of them? [18:40:46] kaldari: correct [18:41:05] kaldari (nexus 7 with chrome, too) [18:41:50] DarTar, around? [18:42:43] (03PS3) 10BearND: Gradle package (applicationId) rename [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 [18:44:28] (03CR) 10jenkins-bot: [V: 04-1] Gradle package (applicationId) rename [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 (owner: 10BearND) [18:47:46] FlorianSW, MaxSem: Actually it looks like the flipping might be fixed now: https://bugzilla.wikimedia.org/show_bug.cgi?id=66091 [18:47:49] need to test [18:48:17] MaxSem: I am now, what’s up [18:48:18] * FlorianSW testing [18:51:49] kaldari: i see no flipping :( [18:52:43] (03PS1) 10Bmansurov: Use standard image sizes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) [18:54:14] DarTar, do we have UA information for 404s from https://bugzilla.wikimedia.org/71571 ? [18:54:47] my theory is that some antiquated phone browsers don't handle protocol-relative URLs [18:56:27] MaxSem: let me cc Oliver and ErikZ [18:56:39] hehe [18:57:10] Does anyone happen to have the mw page that has the mobile device list? [18:57:13] we don’t have parsed device/browser data in hadoop but if needed we can pull some data manually [18:57:14] ^handy [18:57:24] (03CR) 10Kaldari: [C: 032] Add tooltips to all standalone icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163277 (https://bugzilla.wikimedia.org/50705) (owner: 10Jdlrobson) [18:57:58] (03Merged) 10jenkins-bot: Add tooltips to all standalone icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163277 (https://bugzilla.wikimedia.org/50705) (owner: 10Jdlrobson) [18:58:10] DarTar, raw data would be good [20:09:31] 3Wikipedia App / 3General/Unknown: pressing back from article accessed via nearby does not display nearby list - 10https://bugzilla.wikimedia.org/71567#c1 (10Dan Garry) (In reply to Jared Zimmerman (WMF) from comment #0) > Article A → Nearby → Article B → Back → Article A > > pressing back should probably r... [20:10:00] 3Wikipedia App / 3General/Unknown: pressing back from article accessed via nearby does not display nearby list - 10https://bugzilla.wikimedia.org/71567#c2 (10Jared Zimmerman (WMF)) tested on iOS [20:14:36] FlorianSW: another good catch :) [20:16:16] jdlrobson: Yeah, it's friday :D [20:16:19] FlorianSW: haha [20:16:24] that didn't go live did it ?! :-S [20:16:33] no phew [20:16:51] i did a follow up FlorianSW hopefuly we can get that fix merged [20:17:16] jdlrobson: no, it's not live, but i think it's in wmf2 [20:17:40] 3MobileFrontend / 3Feature requests: MobileFrontend: All icon buttons should have title tooltips - 10https://bugzilla.wikimedia.org/50705 (10Jon) 5PATC>3RESO/FIX [20:18:13] prtksxna: lolz http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:UserLogin [20:18:26] eeeeeeek [20:19:00] jdlrobson: Link to that patch? [20:19:17] FlorianSW: is fixing it prtksxna (see https://gerrit.wikimedia.org/r/#/c/164630/) [20:19:25] FlorianSW: does my comment make sense? [20:19:35] jdlrobson: i think so :) [20:20:20] (03PS2) 10Jdlrobson: Improve tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142639 (owner: 10MaxSem) [20:20:30] (03CR) 10Jdlrobson: [C: 032] "as long as tests pass i'm fine!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142639 (owner: 10MaxSem) [20:21:07] jdlrobson: We should probably look at https://en.wikipedia.org/wiki/Special:PasswordReset as well FlorianSW [20:22:06] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=71623 :-S [20:22:07] 3MobileFrontend / 3stable: WebRequest::appendQuery deprecated - 10https://bugzilla.wikimedia.org/71623 (10Jon) 3NEW p:3Unprio s:3normal a:3None Deprecated: Use of WebRequest::appendQuery was deprecated in MediaWiki 1.25. [Called from SkinMinerva::prepareMobileFooterLinks in /vagrant/mediawiki/extensi... [20:22:42] I thought I grepped for it yesterday [20:22:45] ... [20:24:08] jdlrobson, prtksxna: https://gerrit.wikimedia.org/r/164630 [20:24:14] FlorianSW: looking :) [20:24:35] FlorianSW: looks good. testing. ps. we need to do this for Special:ResetPassword too FlorianSW [20:25:32] 3MobileFrontend / 3stable: WebRequest::appendQuery deprecated - 10https://bugzilla.wikimedia.org/71623#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/WfD9pOOj [20:25:52] LGTM FlorianSW :) [20:26:41] jdlrobson: for SpecialPasswordReset: i don't think so?! at least not on local master and on betalabs: http://en.wikipedia.beta.wmflabs.org/wiki/Special:PasswordReset [20:26:52] prtksxna ^ [20:27:09] FlorianSW: mmm, i guess it's using the old way :) [20:27:20] FlorianSW: well that's good. we can do that more carefully :) [20:27:33] jdlrobson: let me look at the code, if it's ok so :D [20:27:42] FlorianSW: The input fields look different on https://en.wikipedia.org/wiki/Special:PasswordReset [20:27:46] affirmative :) [20:27:53] But that is not in the scope of what we are doing :) [20:28:02] prtksxna: wow at https://en.wikipedia.org/wiki/Special:PasswordReset [20:28:03] that's nasty [20:28:08] has it always been that way?! [20:28:20] so much nicer here https://www.mediawiki.org/wiki/Special:PasswordReset [20:28:23] let's just leave it [20:28:30] prtksxna, jdlrobson: some change in wmf2 i think, mw.org looks good:https://www.mediawiki.org/wiki/Special:PasswordReset [20:28:37] damn, Jon was faster :D [20:28:39] *again* [20:28:50] Oh good! [20:29:20] ohai prtksxna [20:29:24] fancy seeing you here :) [20:31:03] YuviPanda: o/ [20:31:28] * FlorianSW is wondering his amount of mediawiki related E-Mails :D [20:31:28] jdlrobson: Most of the issues raised in the bugs are still relevant [20:31:39] * FlorianSW ... he recieved [20:31:50] jdlrobson, now find me that function in http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/60b6098a142c099ce8629311cdbcf26a08ae433d/includes%2Fskins%2FSkinMinerva.php ;) [20:31:55] jdlrobson: It has details on the text of the button and what type they should be [20:31:57] jdlrobson: And most inputs still aren't inline [20:34:16] MaxSem: mmm [20:34:34] MaxSem: something in a hook maybe?\ [20:35:05] jdlrobson: then it should show the hook function as the caller :) [20:35:29] jdlrobson: no need to backport the "login mw-ui fix", it's not in wmf2 [20:36:32] FlorianSW: phewww [20:36:54] jdlrobson: :D [20:42:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] "seems good !" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164490 (owner: 10Mhurd) [20:44:47] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Nice!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164495 (owner: 10Mhurd) [20:46:54] (03PS1) 10Brion VIBBER: bump version to 4.0.4 for next testflight (and if all goes well store) release [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164659 [20:47:16] (03CR) 10Brion VIBBER: [C: 032 V: 032] "selfmerge version number ;)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164659 (owner: 10Brion VIBBER) [20:48:56] (03PS2) 10Bmansurov: Standardize grey colors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164488 (https://bugzilla.wikimedia.org/65381) [20:54:31] FlorianSW: sorry there was excitement in SF [20:54:32] jdlrobson: https://gerrit.wikimedia.org/r/#/c/164665/ :) [20:54:50] FlorianSW: http://instagram.com/p/ttFUkNM2Fh/ [20:54:50] :D [20:55:04] lol, wow [20:55:12] FlorianSW: do we need to deploy it somewhere? [20:55:40] jdlrobson: not to fix this problem (because there is no problem (check e.g. locally, code or mw.org)). So it would be only a "gimmick" [20:55:51] ah i see ;- [20:56:04] jdlrobson: and in my opinion we shouldn't block a backport slot for this :) [20:57:15] 3MobileFrontend / 3General/Unknown: Clicking on a link with ... suffix goes to a wrong page - 10https://bugzilla.wikimedia.org/71569#c2 (10Bahodir Mansurov) Clicking on the title link took me to https://fi.m.wikipedia.org/wiki/Wikipedia:Tiesitk%C3%B6,_ett%C3%A4... which I assume is the correct behavior. Mayb... [20:57:54] jdlrobson: is there a special right to give -1 to other branches as master? Or is it disabled generally? [21:01:44] tfinc: where do you want to meet for the 1:1? [21:01:45] 3MobileFrontend / 3stable: opening sidebar menu doesn't work correctly on iPhone6+ - 10https://bugzilla.wikimedia.org/71575#c2 (10Jon) 5NEW>3UNCO Cannot replicate on simulator or on Monte's iPhone 6. James are you able to replicate this on: http://en.m.wikipedia.org http://m.mediawiki.org http://en.m.wik... [21:04:30] 3MobileFrontend / 3stable: opening sidebar menu doesn't work correctly on iPhone6+ - 10https://bugzilla.wikimedia.org/71575#c3 (10James Forrester) This was demonstrated in-person with my 6+, hence why it was opened. Tested on enwiki prod and Beta Labs. [21:05:20] jhobs: https://office.wikimedia.org/wiki/Goals/2014-2015/Engineering_and_Product_Development/Jeff_Hobson [21:08:14] jhobs: https://en.wikipedia.org/wiki/SMART_criteria [21:13:59] jhobs: https://www.mediawiki.org/wiki/Wikimedia_Engineering/Report/2014/August [21:14:04] (03CR) 10Jdlrobson: [C: 032] Standardize grey colors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164488 (https://bugzilla.wikimedia.org/65381) (owner: 10Bmansurov) [21:14:38] (03Merged) 10jenkins-bot: Standardize grey colors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164488 (https://bugzilla.wikimedia.org/65381) (owner: 10Bmansurov) [21:17:39] (03PS1) 10BearND: Manual import of translations from TWN [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164670 [21:21:48] (03PS1) 10Bmansurov: Redirect to login [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) [21:22:17] 3MobileFrontend / 3Hygiene: Get down to 15 shades of gray - 10https://bugzilla.wikimedia.org/71627 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon MediaWiki UI defines 15 shades of gray: @colorGray1: #111; // darkest @colorGray2: #222; @colorGray3: #333; @colorGray4: #444; @colorGray5: #555; @colorGray6: #66... [21:25:06] (03PS3) 10Jdlrobson: Improve tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142639 (owner: 10MaxSem) [21:25:10] (03CR) 10Jdlrobson: Improve tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142639 (owner: 10MaxSem) [21:25:15] (03CR) 10Jdlrobson: [C: 032] Improve tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142639 (owner: 10MaxSem) [21:25:49] (03Merged) 10jenkins-bot: Improve tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/142639 (owner: 10MaxSem) [21:25:59] thanks jdlrobson :) [21:27:42] (03CR) 10Jdlrobson: [C: 04-1] "A few comments." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [21:28:52] (03PS5) 10Jdlrobson: Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 [21:28:57] (03PS6) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [21:29:08] (03PS4) 10Jdlrobson: Remove ajax refresh from editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164131 (https://bugzilla.wikimedia.org/69559) [21:29:18] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [21:29:33] (03PS3) 10Jdlrobson: Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 [21:29:39] (03PS6) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [21:29:44] (03PS5) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [21:29:49] (03PS4) 10Jdlrobson: Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 [21:30:03] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [21:30:25] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [21:30:44] (03CR) 10BearND: [C: 032] Add option to switch between metric/imperial in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163741 (owner: 10Dbrant) [21:30:55] (03CR) 10Florianschmidtwelzow: [C: 04-1] Redirect to login (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [21:31:06] (03CR) 10Bmansurov: WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [21:32:20] (03Merged) 10jenkins-bot: Add option to switch between metric/imperial in Nearby. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163741 (owner: 10Dbrant) [21:33:16] https://docs.google.com/a/wikimedia.org/spreadsheets/d/1diG8Yc80aGibhIp9Lce3w8Pk4xMHM9N6Bq31KojYZSk/edit#gid=0 [21:34:32] (03PS7) 10Bmansurov: WIP: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [21:34:40] kaldari, come to the party in R31!!!!!! [21:35:01] (03CR) 10Jdlrobson: Redirect to login (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [21:35:21] kaity [21:35:33] (03CR) 10Bmansurov: Redirect to login (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [21:35:38] ^will you join our mobile web health check survey? [21:36:29] 3MobileFrontend / 3stable: opening sidebar menu doesn't work correctly on iPhone6+ - 10https://bugzilla.wikimedia.org/71575#c4 (10Jon) And you can confirm it's still happening to you now post Thur deployment? What browser are you using and what version of iOS 6? [21:36:44] 3MobileFrontend / 3stable: opening sidebar menu doesn't work correctly on iPhone6+ - 10https://bugzilla.wikimedia.org/71575#c5 (10Jon) Also beta/alpha? [21:38:44] 3MobileFrontend / 3stable: opening sidebar menu doesn't work correctly on iPhone6+ - 10https://bugzilla.wikimedia.org/71575#c6 (10Ryan Kaldari) James_F: Can you also verify if this was in Mobile Safari. I thought it was, but don't remember specifically. [21:39:48] (03PS4) 10BearND: Gradle package (applicationId) rename [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 [21:40:00] 3MobileFrontend / 3stable: opening sidebar menu doesn't work correctly on iPhone6+ - 10https://bugzilla.wikimedia.org/71575#c7 (10Ryan Kaldari) Jon: I believe this was in iOS 8 not iOS 6. Exact version would be useful. [21:42:40] (03CR) 10Florianschmidtwelzow: Redirect to login (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [21:48:29] (03CR) 10Dbrant: [C: 032] More Nearby styling changes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163960 (owner: 10BearND) [21:56:11] (03PS5) 10BearND: Gradle package (applicationId) rename [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 [22:07:37] (03PS1) 10Dr0ptp4kt: Establish Cucumber tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164684 [22:23:46] 3MobileFrontend / 3General/Unknown: Clicking on a link with ... suffix goes to a wrong page - 10https://bugzilla.wikimedia.org/71569#c3 (10Stryn) (In reply to Bahodir Mansurov from comment #2) > Clicking on the title link took me to > https://fi.m.wikipedia.org/wiki/Wikipedia:Tiesitk%C3%B6,_ett%C3%A4... whic... [22:29:30] brion: so i can’t get the testflight stuff working… :( [22:29:49] bah [22:29:52] mhurd: what’s it doing? [22:30:02] brion: certificate stuff [22:30:06] ughhhh [22:30:14] brion: ya. pretty frustrating [22:30:17] ok let’s do a hangout and share screen, see if we can figure it out [22:30:26] brion: k. lemme find a room… [22:30:32] k [22:46:00] 3MobileFrontend / 3General/Unknown: Clicking on a link with ... suffix goes to a wrong page - 10https://bugzilla.wikimedia.org/71569#c4 (10Bahodir Mansurov) (In reply to Stryn from comment #3) > (In reply to Bahodir Mansurov from comment #2) > > Clicking on the title link took me to > > https://fi.m.wikipedi... [22:57:27] \o/ [22:58:00] (03PS2) 10Bmansurov: Redirect to login [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) [22:59:19] mhurd: oh i was thinking we should see if we can rig up a script that sets the proper settings for beta or for release builds (adjust the project to have the .beta or not, pick the right provisioning, and update the icon state) [22:59:22] might try that next week :D [23:33:04] brion: that sounds great! [23:45:11] (03PS8) 10Yurik: Added private-wiki-only lua extensions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 [23:50:46] (03CR) 10Yurik: "Rebased and followed a few Brion's et al suggestions:" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik)