[01:44:18] (03PS1) 10Saltymule: Set the timezone for the NSDateFormatter to UTC [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164892 (https://bugzilla.wikimedia.org/66884) [03:28:54] (03PS9) 10Yurik: Added private-wiki-only lua extensions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 [03:29:00] (03CR) 10Yurik: Added private-wiki-only lua extensions (032 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [07:21:11] (03CR) 10Florianschmidtwelzow: Redirect to login (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [07:47:57] (03CR) 10Florianschmidtwelzow: Redirect to login (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [10:09:51] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/Pa54Bw [10:09:51] 13WikipediaMobile/06master 141300ece 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [10:57:28] (03CR) 10Siebrand: [C: 032] Update for simplified Chinese [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164935 (owner: 10L10n-bot) [10:57:47] (03Merged) 10jenkins-bot: Update for simplified Chinese [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164935 (owner: 10L10n-bot) [10:58:32] (03PS1) 10Siebrand: Revert "Update for simplified Chinese" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164936 [10:58:38] (03CR) 10Siebrand: [C: 032] Revert "Update for simplified Chinese" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164936 (owner: 10Siebrand) [10:59:05] (03Merged) 10jenkins-bot: Revert "Update for simplified Chinese" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164936 (owner: 10Siebrand) [11:02:13] (03CR) 10Siebrand: [C: 032] Update for simplified Chinese [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164937 (owner: 10L10n-bot) [11:02:32] (03Merged) 10jenkins-bot: Update for simplified Chinese [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164937 (owner: 10L10n-bot) [14:09:52] (03CR) 10Dbrant: [C: 032] Add flag `FEATURE_ACTION_MODE_OVERLAY` for an overlaying actionmode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163473 (owner: 10RashiqAhmad) [14:11:43] (03CR) 10Dbrant: [C: 032] Guard against ApiException in EditSectionActivity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163450 (https://bugzilla.wikimedia.org/71332) (owner: 10Deskana) [14:55:52] (03PS1) 10Dbrant: Update Crouton version. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164983 [15:05:32] phuedx: heya :) [15:05:37] welcome to the teaaaaaaaammmm [15:05:41] hullo GroggyPanda [15:05:54] thaaaaaaaannnnks! [15:06:07] :) [15:07:30] * phuedx has espresso [15:07:54] * GroggyPanda is no longer in London [15:09:26] * phuedx will forever be in london [15:22:31] phuedx: hah! :) [15:27:42] phuedx: I'm moving to the ops team in 3 weeks, though, so our time in similar teams will be limited [15:27:43] oh well [15:27:54] GroggyPanda: let's make it count! [15:27:58] heh :) [15:28:04] HIGH FIVE!!!1 [15:28:08] enthusiasm! [15:28:09] HIGHHHHH FIIIIVEEEEE!!!! [15:29:29] Hey phuedx, welcome. I hope your first day hasn’t been to shocking <- see what I did there [15:29:40] boom [15:30:06] also, hey :) [15:31:51] phuedx: bearND and dbrant (from the app team) and I are usually on IRC a couple hours before the SF crew [15:32:11] phuedx: hellooooo! [15:32:20] Then there’s GroggyPanda, international man of ALL THE TIME ZONES [15:32:37] is this why he's GroggyPanda? [15:32:43] kristenlans: heh :) [15:32:44] dbrant: hellooooo! [15:32:48] phuedx: indeed, jetlag [15:32:55] kristenlans: am in IST now [15:33:38] hello everybody [15:33:44] hey dbrant and bearND [15:35:53] hey bearND [15:37:15] pheudx is new? Welcome! :) [15:37:30] hello phuedx [15:37:43] i'm bright and shiny and new :) [15:37:57] o/ [15:38:35] phuedx: are you working on apps or web? [15:38:40] web [15:38:48] phuedx: great :P Android app dev or iOS? [15:39:05] damn bearND was faster :P [15:47:50] (03CR) 10Dbrant: [C: 04-1] "It's not quite as synchronous as it seems. Right now, even if the "refreshing..." dialog is dismissed, the tasks continue to run to compl" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163453 (https://bugzilla.wikimedia.org/67057) (owner: 10Deskana) [16:06:27] How are we supposed to be processing non-English/German mail by the way? [16:09:00] Does the feedback form not mention allowed languages? [16:13:13] phuedx: I have added you and Rob to all mobile web team meetings. I’ll schedule some time to check-in with you later in the week to discuss the development cycle, but please feel free to raise questions to me or any member of the team in the meantime. [16:17:15] MEETINGS!!! [16:17:26] i always used to feel bad that my calendar was empty [16:17:30] not so much now [16:23:26] (03CR) 10Dbrant: [C: 04-1] "See inline comments. Dr0ptp4kt, please check and add any comments from your end." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163830 (owner: 10Zhaofeng Li) [16:27:06] Hey it’s our other new team member! Welcome rmoen. [16:27:34] hello and thank you kristenlans [16:29:33] i'm getting vagrant provisioned with mobilefrontend and taking on my first bug. All is well. [16:29:55] Yeehaw! [16:30:14] rmoen: Welcome :) [16:55:46] bearND and dbrant: migrating Sprint 40 -> Sprint 41 [16:55:58] (if you see cards disappearing, you’re not goign crazy ;-)) [16:56:34] kristenlans: or magic [16:56:37] kristenlans: affirmative! [16:57:34] (03CR) 10Jdlrobson: [C: 04-1] "super super minor moan... :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164772 (https://bugzilla.wikimedia.org/71573) (owner: 10Florianschmidtwelzow) [16:57:37] kristenlans: can you add me to the trello board so that I may leave comments and things [16:57:59] user->robm17 [16:58:47] kristenlans: oh wait, it looks like i have two accounts -> robmoen is on it [16:59:05] Yeah, that’s the only one I found [16:59:15] Do you prefer robm17? [17:00:25] Ready for your first standup rmoen and phuedx? [17:00:25] kristenlans: that is the one i used for growth, but i'm ok with my older accoun [17:00:30] aye [17:00:38] Hangout link in calendar [17:00:44] https://plus.google.com/hangouts/_/calendar/d2lraW1lZGlhLm9yZ19yMWNvaHVib3JmYjlqcWMydHA0bmwxcXMxZ0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t.abvfhue9msa07tgt4d9v4s0u1g?authuser=0 [17:01:31] https://trello.com/b/MHam9Gx4/mobile-web-current-sprint-32-fear-and-loathing-in-las-vegas [17:05:12] (03CR) 10Florianschmidtwelzow: Don't add #undefined as redirectHash (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164772 (https://bugzilla.wikimedia.org/71573) (owner: 10Florianschmidtwelzow) [17:06:25] (03PS3) 10Florianschmidtwelzow: Don't add #undefined as redirectHash [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164772 (https://bugzilla.wikimedia.org/71573) [17:09:49] (03PS1) 10Dbrant: Remove ToC nudge when scrolling like a madman. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165013 [17:11:19] (03CR) 10jenkins-bot: [V: 04-1] Remove ToC nudge when scrolling like a madman. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165013 (owner: 10Dbrant) [17:13:51] (03PS2) 10Dbrant: Remove ToC nudge when scrolling like a madman. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165013 [17:16:49] i'll send an email about my intended working hours to the list [17:18:31] jdlrobson: i'll be afk for 30 minutes while i give george a bath and get him to bed, then i'll be available until whenever [17:18:58] generally speaking i'm around until 12 sf time, but today's an exception because of the poop start [17:19:00] 3MobileFrontend / 3General/Unknown: WikiGrok buttons misaligned again on beta labs/iOS - 10https://bugzilla.wikimedia.org/71572#c7 (10Jon) 5PATC>3RESO/FIX Yup although there are other issues captured in bug 71577 [17:22:22] kristenlans: is mobile-tech the appropriate place to update the team with personal matters ? I have requested to join mobile-l also but I'm not sure i'm in that one yet. [17:22:55] rmoen: mobile-tech is good :-) [17:22:59] ty [17:26:18] (03CR) 10Daniel Kinzler: "@yurik: let's have a session about this at the summit :)" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [17:26:28] rmoen: You should also subscribe to mobile-l if you haven't already [17:26:37] kaldari: I have requested it [17:27:25] Not sure if i'm in it yet [17:29:05] phuedx: have you subscribed to mobile-tech and mobile-l? [17:30:22] phuedx: no worries just grab me when time works for you [17:30:46] kristenlans: Your webcam wasn't showing, btw. [17:30:51] kristenlans: Not sure if that was intentional or not. [17:33:05] hangout fail [17:35:41] (03PS3) 10Jdlrobson: Wikigrok B improvements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 (https://bugzilla.wikimedia.org/71577) [17:40:34] kaldari: i'm on mobile-l now, i failed to confirm friday [17:42:29] jhobs___: https://www.mediawiki.org/wiki/Help:Magic_words#URL_data [17:44:33] (03CR) 10Kaldari: [C: 04-1] Remove ajax refresh from editing workflow (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164131 (https://bugzilla.wikimedia.org/69559) (owner: 10Jdlrobson) [17:46:17] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570#c4 (10Jon) I guess we need to rethink this code. The fix should be in MobileFrontend I'm just not sure how best to do that. [17:51:52] (03CR) 10Kaldari: [C: 04-1] Wikigrok B improvements (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 (https://bugzilla.wikimedia.org/71577) (owner: 10Jdlrobson) [17:52:12] (03PS2) 10Mhurd: Set the timezone for the NSDateFormatter to UTC [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164892 (https://bugzilla.wikimedia.org/66884) (owner: 10Saltymule) [17:52:37] (03CR) 10Mhurd: [C: 032 V: 032] "Seems to work :)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164892 (https://bugzilla.wikimedia.org/66884) (owner: 10Saltymule) [17:53:03] ... i crashed vagrant from searching too much ;/ [18:00:34] jdlrobson: to your comment to use HTMLForm here (https://gerrit.wikimedia.org/r/#/c/164733/1/includes/specials/SpecialNewpages.php): My problem is, that there are at least two pre rendered elements :) [18:04:03] kristenlans: have rob and sam been added to all our calendar events? [18:04:16] kaldari: yes sir [18:04:23] awesome [18:04:29] kaldari: adding them to our team page next :-) [18:04:46] (03PS1) 10Robmoen: Longer timeout for history update on search click [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) [18:06:06] (03CR) 10Kaldari: [C: 04-1] Use standard image sizes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [18:07:18] (03PS2) 10Mhurd: Clear the webview immediately when loading a new page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164731 (https://bugzilla.wikimedia.org/70422) (owner: 10Saltymule) [18:10:00] 3MobileFrontend / 3Hygiene: Minimize number of thumb sizes used in MobileFrontend extension - 10https://bugzilla.wikimedia.org/58285#c8 (10Ryan Kaldari) I like standardizing the sizes, but I'm a bit concerned about increasing the search thumb size from 80 to 120 due to the increase in bandwidth this would cr... [18:10:13] (03CR) 10Jdlrobson: Longer timeout for history update on search click (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) (owner: 10Robmoen) [18:10:32] (03CR) 10Kaldari: Use standard image sizes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [18:13:59] (03CR) 10Jdlrobson: [C: 032] Don't add #undefined as redirectHash [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164772 (https://bugzilla.wikimedia.org/71573) (owner: 10Florianschmidtwelzow) [18:14:30] (03Merged) 10jenkins-bot: Don't add #undefined as redirectHash [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164772 (https://bugzilla.wikimedia.org/71573) (owner: 10Florianschmidtwelzow) [18:14:42] (03CR) 10Mhurd: [C: 04-1] "It may be better to clear the innerHTML of the content div instead of the body... https://git.wikimedia.org/blob/apps%2Fios%2Fwikipedia/96" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164731 (https://bugzilla.wikimedia.org/70422) (owner: 10Saltymule) [18:15:50] ^ rmoen [18:15:57] rmoen, phuedx: have you guys used Trello before? [18:15:57] (Longer timeout for history update on search click) [18:16:30] 3MobileFrontend / 3stable: #undefined hash appended on page views - 10https://bugzilla.wikimedia.org/71573 (10Florian) 5PATC>3RESO/FIX [18:18:47] kaldari: we used it on growth [18:21:00] 3Wikipedia App / 3iOS App: "last modified" timestamp offsets by timezone instead of showing actual time since edit - 10https://bugzilla.wikimedia.org/66884#c5 (10Dan Garry) 5PATC>3RESO/FIX Should be fixed now! [18:21:00] rmoen: ah good. If you have any questions about how we're using it specifically, just ping kristenlans. Usually we have estimations that are shown on the cards via http://scrumfortrello.com/, so you'll want to install that. [18:21:22] Scrum Fort Rello [18:21:27] rmoen: although most of the cards right now are just bugs, which don't have estimations [18:21:27] jdlrobson: ty for review, happy to make a more reliable solution. Current patch is kind of a bandaid. I will take a stab at your recommendation in a bit [18:21:43] (03CR) 10Jdlrobson: Wikigrok B improvements (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 (https://bugzilla.wikimedia.org/71577) (owner: 10Jdlrobson) [18:21:57] kaldari: ahh ok i'll checkout scrumfortrello [18:23:15] kaldari: At first glance it looks like we were pretty much doing the same thing in trello, sans the estimations [18:23:20] dbrant: Interesting.. [18:23:26] dbrant: Regarding your -1 here: https://gerrit.wikimedia.org/r/#/c/163453/ [18:23:35] rmoen: yay [18:23:44] dbrant: Are you sure? I had my device hooked up and was watching logcat, and if you press back then the refresh messages stopped appearing in logcat. [18:23:55] dbrant: So it seemed like the process stopped. [18:24:19] kaldari: i never heard of scrum for trello kristenlans is that documented anywhere? [18:24:55] (03CR) 10Jdlrobson: [C: 04-1] "see my comment. feel free to disagree." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) (owner: 10Robmoen) [18:24:59] kaldari, kristenlans: re:trello we even the same boards. One thing different that I like so far is the bug analysis [18:25:49] (03PS6) 10Jdlrobson: Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 [18:25:53] (03PS7) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [18:25:58] (03PS4) 10Jdlrobson: Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 [18:26:03] (03PS7) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [18:26:08] (03PS6) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [18:26:14] (03PS5) 10Jdlrobson: Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 [18:26:15] dbrant: I could be wrong because I did think the process was asynchronous, but I figured if it was then I'd keep seeing the messages in logcat. [18:26:46] (03CR) 10Robmoen: "I agree. It would be best to know when the async is actually finished vs the current timeout and pray." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) (owner: 10Robmoen) [18:26:47] jdlrobson: not documented, afaik, but this page seems like a good place to add something. I will do. https://www.mediawiki.org/wiki/Mobile_web/Trello [18:28:14] (03CR) 10Jdlrobson: [C: 032] "Awesome." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164875 (owner: 10Florianschmidtwelzow) [18:28:40] Is phuedx gone for tonite? [18:28:47] nosire [18:28:52] (03Merged) 10jenkins-bot: Use mw-ui for "All notifications" link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164875 (owner: 10Florianschmidtwelzow) [18:28:53] just got back from giving george a bath [18:29:01] also, hey kaldari o/ [18:29:11] we used trello for growth [18:29:38] * phuedx installs scrumfortrello [18:29:47] phuedx: ah cool, just wanted to let you know to install http://scrumfortrello.com/ as well :) [18:30:02] Deskana: I do still see messages on my device. If you look at the code, all the tasks are started simultaneously, and the next time the "isCancelled" variable is checked is when the task is already complete. [18:30:27] dbrant: Oh, weird. Thanks! [18:30:31] (03PS2) 10Jdlrobson: Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) [18:31:50] bmansurov: You should install scrumfortrello as well if you haven't already. [18:32:09] kaldari, ok thanks [18:34:02] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [18:34:17] phuedx: hey :) [18:34:28] hey jdlrobson [18:35:08] Ah sweet scrum for trello works with more browsers since the last time I looked. [18:35:13] phuedx: so icons in mobile... essentially I'm trying to leverage the fact we have a beta on mobile. My goal is to enable the new markup in beta only so we can catch any issues with existing icons before pushing this stuff to stable. [18:35:19] I'm working towards this patch: https://gerrit.wikimedia.org/r/#/c/161321/ [18:35:28] it's leading to lots of refactoring to make changes like this easier [18:36:12] so far I've found a need for mw-ui-icon-after (although it's only 1 case and i'm still not sure whether it should be in there) [18:36:33] yurik: have you already enabled the emails for on-wiki changes for zero? [18:36:54] main blocker is having a shared icon library - basically a folder of svgs that we use for the icons that is shared across projects. matmarex is looking into this with help from TrevorParscal [18:37:04] but any help with the patches that lead up to the change would be useful [18:37:27] one of side effects of change is some icons in mobile will change size ever so slightly. [18:38:09] orly? [18:38:18] yeh in mobile we have non-standard icon sizes [18:38:22] which has been a pain [18:38:25] and many of them are png only [18:38:32] so they will change to lovely svgs [18:38:54] main browser we have to care about with this icon work in Android 2 which has no svg support [18:38:58] where are we with producing SVGs from the old font? [18:39:04] ^ mhurd [18:39:52] jdlrobson: TrevorParscal i’ll take a hack at adding the finishing touches to the script this afternoon [18:39:53] ah -- well i'm for standard icon sizes [18:40:01] \o/ [18:40:24] phuedx: did the Growth projects move to using the standard markup? [18:40:35] i think GettingStarted was one of them [18:40:48] jdlrobson: annoyingly, no, it was in the backlog [18:40:54] i'd still like to get guidedtours using 'em [18:41:11] All we need are SVG's worth committing [18:41:13] because forwards and backwards arrows should be standard [18:41:20] we don't need to round trip them or anything [18:41:51] we need to stop with the "standard" markup, and focus on using functions to generate the markup [18:41:56] HTML is not an API man [18:44:17] 3MobileFrontend / 3stable: Page list item tooltip interferes with watch icon tooltip - 10https://bugzilla.wikimedia.org/71711 (10Jon) 3NEW p:3Unprio s:3normal a:3None In the watchlist, hover over the title of the page. You see a tooltip of the title name. However hover over the watch star and this to... [18:45:30] 3MobileFrontend / 3stable: Page list item tooltip interferes with watch icon tooltip - 10https://bugzilla.wikimedia.org/71711#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/f2TwBrh9 [18:51:02] (03PS9) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [18:51:03] 3MobileFrontend / 3stable: WebRequest::appendQuery deprecated - 10https://bugzilla.wikimedia.org/71623#c2 (10Jon) 5NEW>3RESO/INV I'm not seeing this anymore. Guessing I somehow got to an older branch. [18:52:55] (03PS2) 10Bmansurov: Use standard image sizes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) [18:54:51] (03CR) 10CSteipp: [C: 04-1] "Overall, I don't think the functionality that this is opening up has had enough security thought put into it. Can you link somewhere to th" (032 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [18:56:58] (03PS6) 10BearND: Gradle package (applicationId) rename [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 [18:59:56] (03PS1) 10Jdlrobson: i18n the nearby refresh icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165035 (https://bugzilla.wikimedia.org/50705) [19:02:04] (03PS7) 10BearND: Move to Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 [19:02:15] dbrant: ^ [19:02:24] (03CR) 10jenkins-bot: [V: 04-1] Move to Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 (owner: 10BearND) [19:04:32] 3MobileFrontend / 3Hygiene: JSHint: Clean up .jshintignore - 10https://bugzilla.wikimedia.org/71714 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon In JSHint we allow "strictEqual": true, "deepEqual": true, "ok": true, We should remove these and fix the tests that make use of them. W... [19:05:52] (03PS8) 10BearND: Move to Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 [19:17:27] (03CR) 10Jdlrobson: [C: 04-1] "On tablets with this patch my headings are collapsed by default (with a clear local storage). This is a regression.. on tablets they shoul" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [19:21:45] TrevorP|Away: phuedx HTML is not an API no, but until we have OOUI php we should be encapsulating these contents. In mobile this means 1 function in PHP and 1 function in JavaScript that generate this markup. It will make any transition to an API easier. Also out of interest have you thought about how template editors will be able to use OOUI in markup? There are various people who want to use the styles.. would this be a shared t [19:21:45] emplate with the markup inside? [19:23:04] (03PS3) 10Jdlrobson: Use 300px standard image size for uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [19:24:52] (03CR) 10Jdlrobson: [C: 04-1] Use 300px standard image size for uploads (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [19:26:54] (03PS5) 10Jdlrobson: Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 (https://bugzilla.wikimedia.org/71715) [19:27:04] 3MobileFrontend / 3Uploads: Upload overlay doesn't load. - 10https://bugzilla.wikimedia.org/71715 (10Jon) 3NEW p:3Unprio s:3normal a:3None Click the upload icon and it crashes. Broken by OOJS move. [19:31:01] 3MobileFrontend / 3stable: IE8 background sizes - 10https://bugzilla.wikimedia.org/70961#c2 (10Jon) 5NEW>3ASSI I'm working on this [19:31:44] 3MobileFrontend / 3General/Unknown: Need to re-evaluate tablet/phone thresholds with iPhone 6 and 6+ - 10https://bugzilla.wikimedia.org/71576#c2 (10Jon) 5NEW>3RESO/INV This should be a spike. It's not actionable to anyone outside the mobile team. [19:32:45] 3MobileFrontend / 3stable: List of languages looks strange when mixes RTL and LTR languages - 10https://bugzilla.wikimedia.org/64617#c8 (10Jon) Let's just add a direction attribute to each individual language in the overlay? It would also allow us to categorise languages in the overlay by RTL/LTR which would... [19:35:46] 3MobileFrontend / 3General/Unknown: MobileFrontend: Blue "issues" icon should have HiDPI version (or SVG) - 10https://bugzilla.wikimedia.org/67423#c2 (10Jon) 5NEW>3ASSI I'm on this.. [19:45:34] bearND: are you able to compile the project, after the merge of the l10n patches? [19:52:11] dbrant: no, i get an error. Going to look into this [19:53:05] kaldari: ping [19:53:20] I'm a bit concerned that those were merged without any review... [19:53:21] howdy :) [19:53:27] do you know if there is particular reason http://tools.wmflabs.org/wikidata-game/# has webservice disabled? [19:53:41] you are listed as co-maintainer [19:54:33] (03PS1) 10BearND: Revert "Update for simplified Chinese" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165082 [19:54:47] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [19:57:06] (03CR) 10Kaldari: [C: 04-1] "There is no longer any indication that "Sign up" and "Edit without logging in" are links (While "Help improve this page" isn't). Especiall" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [19:57:45] aude: no idea, it was running last week :P [19:58:15] aude: I'll poke around... [20:00:29] kaldari: thanks [20:00:39] dbrant: reverted the L10N patch and no it's happy again [20:00:48] i don't know if magnus is around (i think holiday?) and he doesn't do irc [20:00:50] dbrant: can you CR https://gerrit.wikimedia.org/r/165082? [20:03:53] bearND: needs manual rebase (?) [20:04:24] bearND: technically it looks like we only need to delete "wikipedia/res/values-zh/values-zh-rCN" [20:04:43] dbrant: hmm, that's weird. I only clicked on the revert button in Gerrit [20:04:52] dbrant: that sounds right [20:06:34] aude: I got it up and running again [20:07:31] dbrant: actually, it looks like someone added sub folders under values-zh and values-zh-rCN [20:07:56] (03PS2) 10Robmoen: Wait for back history before going to search page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) [20:09:06] kaldari: yay! :) [20:11:05] jdlrobson: updated https://gerrit.wikimedia.org/r/#/c/165029 [20:11:23] rmoen: sweet [20:14:30] (03Abandoned) 10BearND: Revert "Update for simplified Chinese" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165082 (owner: 10BearND) [20:14:51] (03PS1) 10BearND: Fix zh string resource folders [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165087 [20:14:55] dbrant: ^ [20:15:21] dbrant: that should fix it [20:16:28] (03CR) 10Dbrant: [C: 032] "thanks!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165087 (owner: 10BearND) [20:18:44] bearND: mind merging this one? https://gerrit.wikimedia.org/r/164983 [20:19:06] (03PS2) 10BearND: Update Crouton version. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164983 (owner: 10Dbrant) [20:20:50] (03CR) 10Jdlrobson: [C: 04-1] Wait for back history before going to search page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) (owner: 10Robmoen) [20:21:22] kaldari: sam isn't on mobile-tech. adding him now [20:21:36] (03CR) 10BearND: [C: 032] Update Crouton version. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164983 (owner: 10Dbrant) [20:21:41] tfinc: thanks [20:21:50] bearND: ty [20:21:54] (03Merged) 10jenkins-bot: Update Crouton version. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164983 (owner: 10Dbrant) [20:22:17] (03PS9) 10BearND: Move to Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 [20:22:32] dbrant: would you mind merging https://gerrit.wikimedia.org/r/#/c/154136/? [20:22:46] bearND: yep, looking now... [20:23:00] dbrant: I've updated the script on the CI tools server [20:23:09] (03PS2) 10Dr0ptp4kt: Establish Cucumber tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164684 [20:27:27] (03PS7) 10Jdlrobson: Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 [20:28:09] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165089 [20:32:26] (03PS10) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [20:41:55] (03CR) 10Jdlrobson: [C: 04-1] "minor cleanup needed" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [20:43:31] (03CR) 10Jdlrobson: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [20:46:30] (03PS1) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [20:46:38] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [20:46:59] (03Abandoned) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161321 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [20:50:56] (03PS8) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [20:52:43] (03PS5) 10Jdlrobson: Remove ajax refresh from editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164131 (https://bugzilla.wikimedia.org/69559) [20:53:32] (03CR) 10Dbrant: [C: 04-1] "Looks like the contents of "alpha" and "beta" are mixed up. One more thing inline." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 (owner: 10BearND) [20:55:00] (03CR) 10Kaldari: [C: 032] i18n the nearby refresh icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165035 (https://bugzilla.wikimedia.org/50705) (owner: 10Jdlrobson) [20:55:31] (03Merged) 10jenkins-bot: i18n the nearby refresh icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165035 (https://bugzilla.wikimedia.org/50705) (owner: 10Jdlrobson) [20:57:25] (03PS3) 10Jdlrobson: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) [20:57:56] (03CR) 10jenkins-bot: [V: 04-1] Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [21:01:49] (03CR) 10Kaldari: "jdlrobson: What do you think about using anchor styling instead (as suggested by Jared and S on the design list)?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [21:02:42] fine with me kaldari [21:03:01] (03CR) 10Jdlrobson: [C: 04-1] "oh no qunit explosions" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [21:03:09] (03CR) 10Kaldari: [C: 032] Remove ajax refresh from editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164131 (https://bugzilla.wikimedia.org/69559) (owner: 10Jdlrobson) [21:03:40] (03Merged) 10jenkins-bot: Remove ajax refresh from editing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164131 (https://bugzilla.wikimedia.org/69559) (owner: 10Jdlrobson) [21:04:18] mhurd: how do you want to 'meet' regarding the blog post? [21:04:31] dbrant: good catch. [21:04:49] (03PS10) 10BearND: Move to Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 [21:05:21] dbrant: hangout? [21:06:28] 3Wikipedia App / 3General/Unknown: iOS & Android: MobileFrontend styles unconditionally adding borders to tables - 10https://bugzilla.wikimedia.org/68579#c3 (10Ryan Kaldari) Bahodir: Yes, I believe so. [21:07:42] Bmansurov [21:07:45] oops [21:08:15] (03PS11) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [21:08:47] (03CR) 10jenkins-bot: [V: 04-1] Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [21:09:04] dbrant: gonna reboot [21:09:10] mhurd: np [21:09:14] dbrant: seemed to work last time this happened [21:09:59] (03PS8) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [21:10:28] 3MobileFrontend / 3Feature requests: MobileFrontend: All icon buttons should have title tooltips - 10https://bugzilla.wikimedia.org/50705 (10Jon) 5PATC>3RESO/FIX [21:10:28] (03CR) 10Florianschmidtwelzow: "@Jon @Kaldari: This seems related to this patch, too: I6f20b6d9f7ecb8e2b3fbf282826d0c6046c8680f" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [21:11:10] (03PS2) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [21:11:14] 3MobileFrontend / 3stable: User profile 'Talk to username' button doesn't follow any mediawiki ui pattern - 10https://bugzilla.wikimedia.org/71071#c7 (10Jon) 5PATC>3RESO/FIX https://gerrit.wikimedia.org/r/163236 got merged. [21:11:15] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [21:12:01] (03CR) 10Jdlrobson: [C: 04-1] "jshint failures.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [21:13:03] (03PS4) 10Jdlrobson: Wikigrok B improvements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 (https://bugzilla.wikimedia.org/71577) [21:13:17] (03PS7) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [21:13:23] (03PS6) 10Jdlrobson: Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 [21:13:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use SkinMinerva::iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [21:14:45] (03PS12) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [21:17:59] (03PS7) 10Jdlrobson: Hygiene: Use iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 [21:18:01] (03PS8) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [21:18:44] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [21:22:30] (03PS8) 10Jdlrobson: Hygiene: Use iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 [21:23:01] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [21:24:07] (03CR) 10Robmoen: Wait for back history before going to search page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) (owner: 10Robmoen) [21:24:54] (03PS16) 10BearND: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [21:25:28] (03CR) 10Jdlrobson: [C: 04-1] "arghh this fails if skin != Minerva" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [21:43:43] 3MobileFrontend / 3stable: opening sidebar menu doesn't work correctly on iPhone6+ - 10https://bugzilla.wikimedia.org/71575#c8 (10Ryan Kaldari) The bug is in Mobile Safari when you have multiple tabs open. Open a page, scroll down, and scroll back up enough to reveal the hamburger menu but not enough to reve... [21:48:49] Is it just normal that mysql in vagrant frequently crashes ? Not sure if i'm running too many roles here or something [21:52:02] rmoen: are you having to reload frequently too? [21:52:06] i had this a while back [21:52:14] phuedx: constantly [21:52:18] (03CR) 10Jdlrobson: "Maybe add a test for the two callback states to make it easier for me to review?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) (owner: 10Robmoen) [21:52:28] 3MobileFrontend / 3General/Unknown: image embedding seems to be broken on beta labs - 10https://bugzilla.wikimedia.org/71210 (10Greg Grossmeier) [21:52:34] i've disabled most of the roles [21:52:51] phuedx: i feel cirrussearch is to blame, idk why [21:53:07] (03CR) 10Jdlrobson: [C: 031] "@kaldari want to take a look?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [21:53:11] had memory problems wit it in the past [21:54:43] 3MobileFrontend / 3stable: If you switch to mobile view while editing and save your edit, it takes you back to the desktop editing interface - 10https://bugzilla.wikimedia.org/65041#c5 (10Ryan Kaldari) 5REOP>3RESO/FIX Fixed by https://gerrit.wikimedia.org/r/#/c/164131/ [21:55:23] (03PS3) 10Robmoen: Wait for back history before going to search page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) [21:55:50] jdlrobson: I've resolved the lost deferred object issue with your suggestion. I will add a test if that helps [21:58:50] bmansurov, /join #wikimedia-staff [21:58:58] 3MobileFrontend / 3beta: Mobile: After saving a redlink page, the user is redirected to the previous page (typically the page the redlink was on) rather then the newly created page - 10https://bugzilla.wikimedia.org/67639#c8 (10Ryan Kaldari) 5NEW>3RESO/FIX Bug is no longer reproducible due to https://ger... [21:59:28] 3MobileFrontend / 3stable: Redlinks show in stable after VE or wikitext edit - 10https://bugzilla.wikimedia.org/69559 (10Ryan Kaldari) 5PATC>3RESO/FIX [22:00:39] MaxSem, I just did. [22:09:43] (03PS4) 10Robmoen: Wait for back history before going to search page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) [22:12:40] (03PS1) 10Bmansurov: Remove borders from tables within infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165120 (https://bugzilla.wikimedia.org/68579) [22:16:31] (03PS10) 10Yurik: Added private-wiki-only lua extensions [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 [22:21:17] (03CR) 10Yurik: "Changed. We don't have a document outlining the general approach. Basically we are building a private portal for zero partners, and Lua is" (032 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [22:23:04] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/164519 pls :) [22:27:55] (03PS1) 10Phuedx: Register EventLogging schemas the cool new way [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) [22:28:13] ^ i can't sleep [22:28:27] (03CR) 10jenkins-bot: [V: 04-1] Register EventLogging schemas the cool new way [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) (owner: 10Phuedx) [22:29:14] (03CR) 10Yurik: Establish Cucumber tests (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164684 (owner: 10Dr0ptp4kt) [22:29:31] jhobs___, dr0ptp4kt ^ [22:30:34] (03CR) 10Dr0ptp4kt: "That will come later, yeah." (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164684 (owner: 10Dr0ptp4kt) [22:30:36] (03PS2) 10Phuedx: Register EventLogging schemas the cool new way [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) [22:31:01] yurikR: is $isZero guaranteed to be null? [22:31:24] looking [22:31:29] (03PS4) 10Bmansurov: Use 300px standard image size for uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) [22:31:32] dr0 [22:32:29] dr0ptp4kt, there is no more $isZero [22:32:52] (03CR) 10Jhobs: Establish Cucumber tests (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164684 (owner: 10Dr0ptp4kt) [22:33:13] dr0ptp4kt, are you looking at https://gerrit.wikimedia.org/r/#/c/164519/1/includes/PageRendering.php [22:33:14] 3MobileFrontend / 3Hygiene: Setup EventLogging schemas the new cool way. - 10https://bugzilla.wikimedia.org/66055 (10Sam Smith) a:5Jon>3Sam Smith [22:33:34] yurikR: yes [22:33:51] dr0ptp4kt, so what's the question? [22:34:39] yurikR: the one i asked. i gather this is just cleanup. [22:35:31] dr0ptp4kt, i'm not following :) $isZero is gone - how can it be guaranteed to be null [22:36:08] (03CR) 10Yurik: [C: 032] "haven't ran the tests, but as long as they run for adam & jeff, this is fine" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164684 (owner: 10Dr0ptp4kt) [22:36:09] yurikR: ha. or how can it not be guaranteed to be null :) [22:36:23] (03Merged) 10jenkins-bot: Establish Cucumber tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164684 (owner: 10Dr0ptp4kt) [22:36:36] dr0ptp4kt, i am soooo confused. Could you elaborate? [22:37:03] yurikR: nm. was that patch just to reduce cruft? [22:37:13] (03CR) 10Dduvall: Establish Cucumber tests (034 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164684 (owner: 10Dr0ptp4kt) [22:38:22] yurikR: is there a vagrant role you enabled for testing the cucumber patch, or did you just d/l ruby, etc. manually? [22:38:49] dr0ptp4kt, correct [22:38:59] 3MobileFrontend / 3Hygiene: Setup EventLogging schemas the new cool way. - 10https://bugzilla.wikimedia.org/66055#c2 (10Sam Smith) I'll admit that writing out the map of schema to revision was nice. 165124 is complicated by supporting the admin not having the EventLogging extension installed as well as hand... [22:39:02] yurikR: because the QA page on mediawiki says there's a vagrant role but I think it may be outdated on that [22:39:07] am gonna try and sleep [22:39:17] my son doesn't care if i'm tired or not [22:39:26] jhobs___, check with adam how to enable it, not sure myself [22:39:35] dr0ptp4kt, ^ [22:40:08] jhobs___: you'll want to modify the zero role so that it provisions the browser-test dependencies [22:41:39] jhobs___: e.g. https://gerrit.wikimedia.org/r/#/c/160786/ [22:42:28] jhobs___, btw, you might want to group things first by "dev status", followed by the action. This way you can have templates = { dev = { header = '...', footer = '...', ...}, prod = {header='...', footer='...',...}. And later, you can do a merge: if prod, use prod, if dev, use dev + prod, thus dev can be incomplete override [22:43:15] marxarelli, jhobs___, lets have a separate zeroportal role [22:44:14] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7861256 - what did we say about the "chrome still opening links in app after uninstall" thing? [22:44:21] (03CR) 10Bmansurov: Redirect to login (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [22:44:32] (03PS3) 10Bmansurov: Redirect to login [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) [22:47:06] yurik: good idea, I was originally structuring it that way but not sure what made me change my mind. Definitely didn't think about overriding defaults though or I would've stuck with it [22:48:31] marxarelli, yurikR: adam and I were talking a bit about that too, eventually having some way to be able to easily develop locally for zero would be nice (especially when I'm doing lots of style changes within LESS). As of right now you'd have to manually copy the Lua Portal module and any templates used [22:48:56] marxarelli, yurikR: when we have a complete MVP it might make for a good base point for a vagrant role [22:49:21] jhobs___, vagrant role is very easy to setup, i might do it now [22:50:21] yurikR: your call, although we'd want to copy the current on-wiki state of zero for it to have much of any use (or a limited copy of the wiki) [22:51:58] we usually don't have any content in the vagrant roles [22:52:22] it will mostly be an empty shell, with scribunto, zero, and other settings set up [22:54:27] jhobs___, ^ [22:55:50] yurikR: yeah, I understand that, but since this scenario is kind of unique in that the development happens on-wiki and is pretty dependent on a specific lua script, wouldn't it be better to include a limited (or full) version of the current wiki? [22:56:28] yurikR: otherwise anyone who enables the zeroportal role would still have a lot of setup to go through to actually test most things [22:56:46] jhobs___, you can use import/export to copy stuff [22:57:13] will be the easiest way to get it into your dev [22:57:38] (03CR) 10Dr0ptp4kt: [C: 032] Removed isZeroSite()'s caching [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164519 (owner: 10Yurik) [22:57:39] yurikR: ok [22:57:57] (03Merged) 10jenkins-bot: Removed isZeroSite()'s caching [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/164519 (owner: 10Yurik) [22:58:11] yurikR: ^^^ looks fine, despite non-patch related issue i sent you [22:59:18] dr0ptp4kt, which non-patch related issue? [22:59:46] forging User-Agent, X-CS, and X-Subdomain, and using your patchset after having copied and pasted the 250-99 on a fresh vagrant instance after having added the 'zero' role, i'm seeing the following error: https://gist.github.com/anonymous/3bb9bbc4108601a4a92d . that also happens to show up in a less verbose fashion on (m.)mediawiki.org it seems. any ideas on how to resolve? [22:59:51] yurikR: ^ [23:00:02] btw, i did a submodule update [23:00:10] before trying to visit http://localhost:8080/wiki/Main_Page with the forged headers [23:00:15] yurikR: ^ ++ [23:01:08] (03CR) 10Kaldari: [C: 04-1] Wikigrok B improvements (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 (https://bugzilla.wikimedia.org/71577) (owner: 10Jdlrobson) [23:01:37] looking [23:02:12] yurikR: i also had run php update.php in case you were wondering [23:02:45] dr0ptp4kt, are you passing two values in?? [23:02:57] 250-99, 646-02 at the same time? [23:03:20] yurikR: lol. i had even scrolled down twice to check that [23:03:26] . and on the third time, now i see it [23:03:31] [23:03:35] hehe :) [23:03:40] my fav kinds of bugs [23:04:08] yurikR: yeah, me too. okay, it runs [23:06:18] (03PS1) 10Jdlrobson: Regression: Remove '>' from VE editor header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165128 [23:06:20] ^ kaldari eep. [23:06:53] jdlrobson: oops :P [23:07:19] (03CR) 10Kaldari: [C: 032] Regression: Remove '>' from VE editor header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165128 (owner: 10Jdlrobson) [23:07:49] (03Merged) 10jenkins-bot: Regression: Remove '>' from VE editor header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165128 (owner: 10Jdlrobson) [23:09:22] (03CR) 10Kaldari: Wikigrok B improvements (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 (https://bugzilla.wikimedia.org/71577) (owner: 10Jdlrobson) [23:17:29] (03PS1) 10Dr0ptp4kt: Make test Rspec style [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165130 [23:23:31] yurikR: is there a specific test user you want to use for cucumber tests (TEST, TEST1, TESTON), or should we create a new one specifically for it? [23:24:11] lets create a new user for that - Cucumber or CucumberTest or something like that :) [23:26:07] yurikR: sounds good [23:28:03] jhobs____, thing is, you will have to reset the state of the cucumberTest user, followed by their step-by-step workflow testing. Or we might want to define several users, each in their own "state", and test that they get to see the right thing [23:28:14] yurikR: we'll probably need two eventually (Cucumber and CucumberAdmin), but the latter can come later [23:28:27] jhobs____, also, i think it would be better to start all test users with the word Test - easier to sort [23:28:36] yurikR: true, but for now nothing will actually change the state [23:28:45] ok [23:29:01] yurikR: uhh i already created it so I'll get rid of it and rename it TestCucumber [23:29:34] Deskana: chat for a few about blog post stuff when you’re done? [23:30:05] jhobs____, you can't delete users :( [23:30:17] its ok [23:30:29] yurikR: yeah but I can just block it so we can tell [23:30:40] ok [23:31:18] jhobs____, btw, are there any blockers for the info screen? I was hoping to depl it on wed :) [23:31:47] lets get that thing out of our way first - it should be much smaller/easier than the whole portal [23:31:50] yurikR: yeah OOUI integration is not working well at all. I can try to book some time with Trevor tomorrow to work through it [23:32:04] thx :) [23:32:07] yurikR: but there's a decent chance it's conflicting with mobile frontend [23:32:29] talk to kaldari or MaxSem, they are the ultimate mobile gurus :) [23:32:55] yurikR: yeah I'll get it sorted out tomorrow [23:35:30] dr0ptp4kt, the cucumber test patches - i think it will be fine to self-merge them at this point [23:43:04] yurikR, alright. [23:43:24] (03CR) 10Dr0ptp4kt: [C: 032] Make test Rspec style [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165130 (owner: 10Dr0ptp4kt) [23:43:37] (03Merged) 10jenkins-bot: Make test Rspec style [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165130 (owner: 10Dr0ptp4kt) [23:43:41] (03CR) 10Kaldari: [C: 04-1] Use 300px standard image size for uploads (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [23:49:06] (03CR) 10Dduvall: "Quick merges. :) See my comment on the deprecated use of `should`." (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165130 (owner: 10Dr0ptp4kt) [23:56:19] (03CR) 10Dr0ptp4kt: "Thanks!" (032 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/164684 (owner: 10Dr0ptp4kt) [23:57:54] (03PS1) 10Robmoen: Standardize on jQuery.each vs forEach [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165135 (https://bugzilla.wikimedia.org/63454) [23:58:27] (03PS1) 10Dr0ptp4kt: Update to modern RSpec and simplify with block [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165136 [23:58:41] (03CR) 10Dr0ptp4kt: [C: 032] Update to modern RSpec and simplify with block [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165136 (owner: 10Dr0ptp4kt) [23:59:48] (03CR) 10Dr0ptp4kt: "Thanks again" (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165130 (owner: 10Dr0ptp4kt)