[00:06:18] (03Merged) 10jenkins-bot: Update to modern RSpec and simplify with block [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165136 (owner: 10Dr0ptp4kt) [00:10:30] (03CR) 10Kaldari: [C: 04-1] "Flo" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [00:11:18] (03CR) 10Kaldari: "@Florianschmidtwelzow: I would suggest changing that one to mw-ui-anchor as well." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [00:19:05] (03PS1) 10Kaldari: Making notification archive link use anchor styles rather than button styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165142 [00:20:57] (03PS9) 10Jdlrobson: Hygiene: Use iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 [00:20:59] (03PS9) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [00:21:01] (03PS3) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [00:21:03] (03PS1) 10Jdlrobson: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 [00:21:05] (03PS1) 10Jdlrobson: Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 [00:21:58] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [00:22:00] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [00:25:21] (03CR) 10Jdlrobson: [C: 032] Standardize on jQuery.each vs forEach [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165135 (https://bugzilla.wikimedia.org/63454) (owner: 10Robmoen) [00:26:38] (03CR) 10Jdlrobson: [C: 032] Wait for back history before going to search page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) (owner: 10Robmoen) [00:27:02] Hello [00:27:47] Daniels-Air-2:wikipedia saltymule$ git review --no-rebase [00:27:47] You are about to submit multiple commits. This is expected if you are [00:27:47] submitting a commit that is dependent on one or more in-review [00:27:47] commits. Otherwise you should consider squashing your changes into one [00:27:47] commit before submitting. [00:27:47] The outstanding commits are: [00:27:48] fce93fc (HEAD, review/saltymule/bug/70422) Clear the webview immediately when loading a new page. [00:27:48] 96c1a6d (origin/master, origin/HEAD, master) Set the timezone for the NSDateFormatter to UTC [00:27:49] 940da43 Localisation updates from https://translatewiki.net. [00:27:49] Do you really want to submit the above commits? [00:27:50] Type 'yes' to confirm, other to cancel: [00:27:56] That was too big, sorry [00:28:12] Daniels-Air-2:wikipedia saltymule$ git review --no-rebase [00:28:12] You are about to submit multiple commits. This is expected if you are [00:28:12] submitting a commit that is dependent on one or more in-review [00:28:12] commits. Otherwise you should consider squashing your changes into one [00:28:12] commit before submitting. [00:28:12] The outstanding commits are: [00:28:13] fce93fc (HEAD, review/saltymule/bug/70422) Clear the webview immediately when loading a new page. [00:28:13] 96c1a6d (origin/master, origin/HEAD, master) Set the timezone for the NSDateFormatter to UTC [00:28:14] 940da43 Localisation updates from https://translatewiki.net. [00:28:14] Do you really want to submit the above commits? [00:28:15] Type 'yes' to confirm, other to cancel: [00:28:31] Ugh, you can't just paste a blob of text in this thing? [00:29:17] Saltymule: you could just amend the previous commit then you won’t get that message [00:29:43] (03PS3) 10Saltymule: Clear the webview immediately when loading a new page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164731 (https://bugzilla.wikimedia.org/70422) [00:29:56] I did [00:30:17] Saltymule: yay! thanks for the patches! i’ll test that latest one now... [00:30:25] ok [00:33:52] (03Merged) 10jenkins-bot: Standardize on jQuery.each vs forEach [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165135 (https://bugzilla.wikimedia.org/63454) (owner: 10Robmoen) [00:33:55] (03Merged) 10jenkins-bot: Wait for back history before going to search page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165029 (https://bugzilla.wikimedia.org/65676) (owner: 10Robmoen) [00:34:27] (03CR) 10Jdlrobson: [C: 04-1] "mostly looks good.. a few clarifications/issues" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) (owner: 10Phuedx) [00:39:13] 3MobileFrontend / 3Hygiene: Code Hygiene: Standardise between forEach and $.each usage - 10https://bugzilla.wikimedia.org/63454 (10Jon) 5PATC>3RESO/FIX [00:39:58] (03CR) 10Mhurd: [C: 032 V: 032] "It works :)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164731 (https://bugzilla.wikimedia.org/70422) (owner: 10Saltymule) [00:42:42] Monte, my name is Daniel by the way [00:42:46] bmansurov: leeme know whenever you get back to that thumbnailing patch. I need to explain the mobile mode vs Minerva skin stuff as it's too confusing to explain in gerrit comments. [00:42:56] (03PS5) 10Jdlrobson: Wikigrok B improvements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 (https://bugzilla.wikimedia.org/71577) [00:43:02] I didn't mean to set my name to Saltymule, but there's no way to edit it now! [00:43:04] (03PS1) 10Mhurd: Protection against nil title or domain crashes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/165150 [00:43:17] Saltymule: nice to meet you :) [00:45:06] Saltymule, this is a known issue [00:45:20] Saltymule, run "git fetch gerrit" [00:45:32] the git-review people fixed this at some point, then it got broken again, IIRC. there's a bug somewhere... [00:45:51] (03CR) 10Jdlrobson: [C: 04-1] "This only does it for tablets...please apply to mobile in less/content/hacks.less (change in tablet should not be necessary)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165120 (https://bugzilla.wikimedia.org/68579) (owner: 10Bmansurov) [00:46:09] saper might know. You'll find them in -tech, -dev, -labs, #mediawiki, etc. not here though [00:46:28] Thanks, good to know [00:46:51] (03PS1) 10Bmansurov: Standardize grey colors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165151 (https://bugzilla.wikimedia.org/65381) [00:50:09] (03PS2) 10Bmansurov: Get down to 15 shades of gray [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165151 (https://bugzilla.wikimedia.org/71627) [00:50:38] (03Abandoned) 10Bmansurov: Get down to 15 shades of gray [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165151 (https://bugzilla.wikimedia.org/71627) (owner: 10Bmansurov) [00:53:33] (03PS2) 10Bmansurov: Remove borders from tables within infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165120 (https://bugzilla.wikimedia.org/68579) [00:57:31] 3MobileFrontend / 3General/Unknown: In beta labs, tapping into wikitext editor creates empty screen - 10https://bugzilla.wikimedia.org/71725 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Steps to repro: 1. On beta labs on an iPhone, log in and tap the edit button on an article. The wikitext e... [00:59:06] (03PS6) 10Kaldari: Wikigrok B improvements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 (https://bugzilla.wikimedia.org/71577) (owner: 10Jdlrobson) [00:59:38] (03CR) 10Kaldari: [C: 032] Wikigrok B improvements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 (https://bugzilla.wikimedia.org/71577) (owner: 10Jdlrobson) [00:59:41] (03PS5) 10Bmansurov: Use 300px standard image size for uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) [01:00:10] (03Merged) 10jenkins-bot: Wikigrok B improvements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164500 (https://bugzilla.wikimedia.org/71577) (owner: 10Jdlrobson) [01:00:35] 3MobileFrontend / 3General/Unknown: In beta labs, tapping into wikitext editor creates empty screen - 10https://bugzilla.wikimedia.org/71725#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/tSnJPwPu [01:06:14] (03PS1) 10Kaldari: Prevent var undefined error in WikiGrok version B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165156 [01:07:28] 3MobileFrontend / 3alpha: problems with footer formatting in WikiGrok dialog B - 10https://bugzilla.wikimedia.org/71577 (10Jon) 5PATC>3RESO/FIX [01:47:13] 3MobileFrontend / 3stable: opening sidebar menu doesn't work correctly on iOS 8+ Safari because of Safari's controls can cover the menu click area - 10https://bugzilla.wikimedia.org/71575#c9 (10James Forrester) s:5critic>3normal Re-writing title for clarity. [02:04:02] 3MobileFrontend / 3stable: Template:TOC limit does not work in mobile view - 10https://bugzilla.wikimedia.org/71726 (10stillwaterising) 3UNCO p:3Unprio s:3normal a:3None Template:TOC limit does not work in mobile browsers that show the TOC by default. Example URL: http://en.m.wikipedia.org/w/index.... [02:04:59] 3MobileFrontend / 3stable: Template:TOC limit does not work in mobile view - 10https://bugzilla.wikimedia.org/71726 (10stillwaterising) [02:05:28] 3MobileFrontend / 3stable: Template:TOC limit does not work in mobile view - 10https://bugzilla.wikimedia.org/71726#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/5iungbbW [02:06:58] 3MobileFrontend / 3Hygiene: Standardise on our grey colours - 10https://bugzilla.wikimedia.org/65381#c7 (10May) (In reply to Bahodir Mansurov from comment #2) > Are you saying that if '#cacaca' is not defined in either variables.less > file, then replace it with the closest color, which might be '#ccc'? Hey... [02:38:46] (03PS1) 10Jhobs: Redesign Zero info screen [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 [02:40:14] (03CR) 10Jhobs: [C: 04-1] "Hold up, left some log commands in there." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [02:53:44] (03PS2) 10Jhobs: Redesign Zero info screen [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 [04:03:37] (03PS10) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 [04:08:11] (03CR) 10Yurik: [C: 04-1] "a "few" comments :)" (0313 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [04:14:55] (03PS11) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 [04:15:32] dbrant|brb: thanks [05:28:13] 3MobileFrontend / 3Feature requests: MobileFrontend: Inline code tags styled very large in articles - 10https://bugzilla.wikimedia.org/49033 (10Krinkle) [05:28:42] 3MobileFrontend / 3Feature requests: Inline code tags styled strangely in articles - 10https://bugzilla.wikimedia.org/49033#c9 (10Krinkle) 5RESO/FIX>3REOP p:5Low>3Normal s:5enhanc>3normal Yeah, same here. https://meta.m.wikimedia.org/wiki/Tech/News/2014/41/en features a ridiculously large "phab"... [05:42:18] (03CR) 10Florianschmidtwelzow: [C: 04-1] Redirect to login (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [05:42:25] (03CR) 10Florianschmidtwelzow: Redirect to login (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [05:49:26] (03CR) 10Zhaofeng Li: "Replied to comments." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163830 (owner: 10Zhaofeng Li) [05:52:01] (03CR) 10Florianschmidtwelzow: [C: 04-1] "You should add 'mediawiki.ui.anchor' as a dependency for mobile.notifications :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165142 (owner: 10Kaldari) [05:53:54] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Same as te comments from Kaldari." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [05:54:43] 3MobileFrontend / 3stable: Need to click twice in search overlay - 10https://bugzilla.wikimedia.org/65676 (10Florian) 5PATC>3RESO/FIX [07:45:20] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [08:00:22] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163891 (owner: 10Jhobs) [09:28:14] 3MobileFrontend / 3stable: Template:TOC limit does not work in mobile view - 10https://bugzilla.wikimedia.org/71726#c2 (10Redrose64) I'm pretty sure that it's because the appropriate rule is in [[:en:MediaWiki/Common.css]] but not in [[:en:MediaWiki/Mobile.css]] [09:29:58] 3MobileFrontend / 3stable: Template:TOC limit does not work in mobile view - 10https://bugzilla.wikimedia.org/71726#c3 (10Redrose64) Whoops. I meant [[:en:MediaWiki:Common.css]] and [[:en:MediaWiki:Mobile.css]]. Will Phabricator offer (a) a "preview" feature and (b) the ability to amend your own posts? [10:40:23] (03PS3) 10Phuedx: Register EventLogging schemas the cool new way [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) [10:40:30] (03CR) 10Phuedx: Register EventLogging schemas the cool new way (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) (owner: 10Phuedx) [10:59:01] (03CR) 10Florianschmidtwelzow: Register EventLogging schemas the cool new way (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) (owner: 10Phuedx) [12:10:55] (03PS4) 10Phuedx: Register EventLogging schemas the cool new way [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) [12:11:46] (03CR) 10Phuedx: Register EventLogging schemas the cool new way (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) (owner: 10Phuedx) [12:53:08] (03CR) 10Phuedx: [C: 031] "This LGTM. Could you expand the commit message to include the cause of the error, e.g. "… when the entity has one or more claims about som" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165156 (owner: 10Kaldari) [13:48:12] (03CR) 10Florianschmidtwelzow: Register EventLogging schemas the cool new way (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) (owner: 10Phuedx) [14:09:45] (03CR) 10Dbrant: [C: 032] "lgtm!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/154136 (owner: 10BearND) [14:10:28] (03PS2) 10Dbrant: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165089 (owner: 10BearND) [14:20:59] (03CR) 10Dbrant: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165089 (owner: 10BearND) [14:22:51] (03PS2) 10Dbrant: Drag some Wikipedia domain stuff into the Site class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 (owner: 10Alex Monk) [14:23:31] (03PS3) 10Dbrant: Remove ToC nudge when scrolling like a madman. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165013 [14:27:49] (03PS17) 10Dbrant: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 [14:29:11] (03PS12) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 [14:42:17] bearND: Gradle is a go! [14:43:55] dbrant: bearND so, build from email looks fairly complicated, becase we'd need to serialize access (no more than one build at a time) [14:44:14] I suggest not doing that unless there's a good amount of demand [14:45:12] hmm, right... [14:49:51] dbrant: so basically, it'll require: 1. mail listener (easy), 2. queueing system that mail listener forwards to (a bit of work), 3. thing that pulls from queuing system, makes sure only one of it is running, and runs build (a bit *more* work), 4. sends out email with failure / result (bit of work) [14:52:41] YuviPanda: indeed, probably not quite worth it, considering the use cases we'd have for it. [14:52:51] yeah [15:18:00] (03Abandoned) 10Dbrant: [WIP] Don't store whole Page contents in savedInstanceState. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151779 (https://bugzilla.wikimedia.org/66732) (owner: 10Dbrant) [15:22:13] 3Wikipedia App / 3Android App: Crash caused by pressing Retry button on connection issue error - 10https://bugzilla.wikimedia.org/70834#c7 (10Alex Monk) https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7861931 as well [15:25:57] bearND: would you agree about merging this? https://gerrit.wikimedia.org/r/159752 [15:30:26] dbrant: yes, i think that could be merged [15:30:36] (03CR) 10Phuedx: "Recheck." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [15:30:51] (03PS4) 10Dbrant: remove configChange hack from AboutActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159752 (owner: 10NightlyNexus) [15:33:51] (03CR) 10BearND: [C: 04-1] Remove ToC nudge when scrolling like a madman. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165013 (owner: 10Dbrant) [15:34:45] (03CR) 10Phuedx: [C: 031] "This LGTM. If you rebase this onto master, then this could be merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [15:43:01] (03Abandoned) 10Dbrant: cleanup manifest and build.gradle [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/158947 (owner: 10NightlyNexus) [15:43:59] (03CR) 10Dbrant: [C: 032] "Yes, we should eventually do this for other Activities, as well." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/159752 (owner: 10NightlyNexus) [15:51:30] 3Wikipedia App / 3Android App: page internal links don't work - 10https://bugzilla.wikimedia.org/71745 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None Example on [[EN:Ion]], clicking on the links "cation" and "anion" doesn't seem to do anything. When clicking on the links the app should scroll to... [15:51:41] (03PS4) 10Dbrant: Remove ToC nudge when scrolling like a madman. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165013 [15:52:00] (03CR) 10jenkins-bot: [V: 04-1] Remove ToC nudge when scrolling like a madman. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165013 (owner: 10Dbrant) [15:52:41] (03PS5) 10Dbrant: Remove ToC nudge when scrolling like a madman. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165013 [16:21:32] ALright phuedx and rmoen, it’s official: https://www.mediawiki.org/wiki/Mobile_web/Team [16:21:56] i particularly like my photo [16:22:09] :) [16:22:15] i should really upload a photo [16:22:25] kristenlans: Wohooo! [16:40:39] (03PS1) 10BearND: Fix warning in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165242 [16:41:10] dbrant: would you mind merging ^? It caused the alpha build to fail [16:43:35] (03CR) 10Dbrant: [C: 032] Fix warning in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165242 (owner: 10BearND) [16:43:49] dbrant: thanks [16:43:55] :) [16:45:38] (03PS6) 10BearND: Remove ToC nudge when scrolling like a madman. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165013 (owner: 10Dbrant) [16:45:48] (03CR) 10BearND: [C: 032] Remove ToC nudge when scrolling like a madman. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165013 (owner: 10Dbrant) [16:46:15] (03Merged) 10jenkins-bot: Remove ToC nudge when scrolling like a madman. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165013 (owner: 10Dbrant) [16:57:44] (03PS4) 10Bmansurov: Redirect to login [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) [17:05:41] bmansurov: i hope you understand my comment here: https://gerrit.wikimedia.org/r/#/c/164673 :) If not, ask :P [17:06:24] FlorianSW, hi. I've read your comments and made changes as you suggested. Did I miss anything? [17:06:55] bmansurov: PS2, SpecialUploads.php, last comment :) [17:06:56] (03PS1) 10Dbrant: Guard against index-out-of-bounds when loading sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165244 (https://bugzilla.wikimedia.org/70834) [17:07:16] bmansurov: This would be the gimmick to made this change great :D [17:07:27] FlorianSW, oh I see it. thanks [17:09:58] 3Wikipedia App / 3Android App: Android app doesn't support language variants in UI translations - 10https://bugzilla.wikimedia.org/69304 (10Dmitry Brant) 5PATC>3RESO/FIX [17:18:47] (03PS5) 10Bmansurov: Redirect to login [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) [17:24:00] 3MobileFrontend / 3stable: Checkboxes do not work in Firefox OS (Special:MobileOptions) - 10https://bugzilla.wikimedia.org/71750 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16692 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16692&action=edit Overlap Visiting Special:MobileO... [17:25:28] 3MobileFrontend / 3stable: Checkboxes do not work in Firefox OS (Special:MobileOptions) - 10https://bugzilla.wikimedia.org/71750#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/K1RV5y2Z [17:33:56] (03PS1) 10Dbrant: Catch SecurityException and rethrow as ApiException. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/165246 (https://bugzilla.wikimedia.org/67948) [17:34:41] (03CR) 10Florianschmidtwelzow: [C: 04-1] "One little thing from my side :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [17:35:45] (03CR) 10Robmoen: [C: 031] Prevent var undefined error in WikiGrok version B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165156 (owner: 10Kaldari) [17:36:06] bearND: if you get a chance -- https://gerrit.wikimedia.org/r/165246 [17:37:26] dbrant: looking... good find [17:37:29] (03CR) 10Jdlrobson: [C: 032] Prevent var undefined error in WikiGrok version B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165156 (owner: 10Kaldari) [17:37:40] (03PS1) 10Florianschmidtwelzow: Hygiene: Link to Loginpage to view Watchlist should contain error message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165248 [17:39:21] (03Merged) 10jenkins-bot: Prevent var undefined error in WikiGrok version B [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165156 (owner: 10Kaldari) [17:40:05] that patch got super-revied [17:40:27] phuedx: so we can't use $wgEventLoggingSchemas global ? :/ [17:41:51] jdlrobson: yes, we could, but not in the ResourceLoaderRegisterModules hook [17:42:27] but we need the hook because of the dependencies? [17:42:40] not necessarily [17:42:48] *grr* Validation error against schema MobileWebEditing: Wrong type for property: username null [17:43:06] alternatively we could stick a single block in MobileFrontent.php (or a file that it includes) [17:43:42] the EventLoggingRegisterSchemas hook is run inside of the EventLogging extension's ResourceLoaderRegisterModules listener [17:43:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks good" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164711 (owner: 10Mhurd) [17:43:47] (say that three times fast) [17:44:00] 3MobileFrontend / 3alpha: EventLogging on alpha anonymous editing being thrown away - 10https://bugzilla.wikimedia.org/71252#c4 (10Florian) 5RESO/FIX>3REOP a:3Florian > Validation error against schema MobileWebEditing: Wrong type for property: username null [17:44:13] (03CR) 10Brion VIBBER: [C: 032 V: 032] Protection against nil title or domain crashes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/165150 (owner: 10Mhurd) [17:44:55] jdlrobson: what i mean to say is, we could just register the module /before/ those hooks are run [17:45:01] which we did in growth all the time [17:45:04] phuedx: i think your code is a lot more clearer but it would be cool to get this as simple as possible. [17:45:10] it's been a while since i looked at EventLogging code :) [17:45:14] jdlrobson: massive +1 [17:45:20] if it seems unclear, i dunnit wrong [17:45:46] I'm curious if there is a way 'mobile.loggingSchemas' doesn't need to specify dependencies [17:46:16] phuedx: anyway i'm gonna test yours and if it works merge :) [17:46:30] jdlrobson: i'll think about that while i'm reading george his story :) [17:46:40] sweet :-) [17:46:46] if you come up with something, then feel free to trample over the patch [17:47:28] ... and then George... marcel the monkey suddenly had a brainwave! He could use EventLogging in a different way. So marcel the monkey swang through the trees back to his monkey office and he did something that a monkey had never done before...` [17:47:47] (when eventlogging and story time collide!) [17:48:58] (03PS1) 10Florianschmidtwelzow: Fix username for anonymous editing in MobileWebEditing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165251 (https://bugzilla.wikimedia.org/71252) [17:49:11] (03CR) 10Brion VIBBER: "Looks mostly right, will test shortly. Note there seems to be a mistyped variable, note inline." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164756 (https://bugzilla.wikimedia.org/63971) (owner: 10Saltymule) [17:49:17] (03CR) 10Jdlrobson: [C: 032] "Looks good to me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) (owner: 10Phuedx) [17:49:57] (03CR) 10Jdlrobson: [C: 04-1] "`anon` could be the users name!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165251 (https://bugzilla.wikimedia.org/71252) (owner: 10Florianschmidtwelzow) [17:50:10] FlorianSW: https://meta.wikimedia.org/wiki/Schema:MobileWebEditing do you have edit rights? [17:50:42] jdlrobson: it seems, that i have :) [17:50:48] FlorianSW: actually [17:50:51] you can just use or just use '' no? [17:51:09] (03CR) 10Jdlrobson: "Actually it seems you could use an empty string rather than null" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165251 (https://bugzilla.wikimedia.org/71252) (owner: 10Florianschmidtwelzow) [17:51:22] jdlrobson: ähm, yes, i think so *facepalm* [17:51:51] (03PS2) 10Florianschmidtwelzow: Fix username for anonymous editing in MobileWebEditing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165251 (https://bugzilla.wikimedia.org/71252) [17:52:10] dr0ptp4kt: mind taking a look at this -- https://gerrit.wikimedia.org/r/163830 [17:52:52] (03Merged) 10jenkins-bot: Register EventLogging schemas the cool new way [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165124 (https://bugzilla.wikimedia.org/66055) (owner: 10Phuedx) [17:53:14] 3MobileFrontend / 3Hygiene: Setup EventLogging schemas the new cool way. - 10https://bugzilla.wikimedia.org/66055 (10Jon) 5PATC>3RESO/FIX [17:53:26] vbamba: can i pester you for 5 min? [17:55:31] (03CR) 10Jdlrobson: [C: 04-1] Redirect to login (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [17:57:01] (03PS2) 10Jdlrobson: Hygiene: Link to Loginpage to view Watchlist should contain error message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165248 (owner: 10Florianschmidtwelzow) [17:57:12] (03CR) 10Jdlrobson: [C: 032] Use 300px standard image size for uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [17:58:36] (03CR) 10Kaldari: [C: 04-1] Use 300px standard image size for uploads (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [18:00:13] (03Merged) 10jenkins-bot: Use 300px standard image size for uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164622 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [18:02:28] 3MobileFrontend / 3Hygiene: Minimize number of thumb sizes used in MobileFrontend extension - 10https://bugzilla.wikimedia.org/58285#c10 (10Jon) 5PATC>3NEW Update... We currently define small, medium and tiny image sizes const MEDIUM_IMAGE_WIDTH = 300; const SMALL_IMAGE_WIDTH = 150; const TIN... [18:06:19] (03CR) 10Jdlrobson: [C: 04-2] "We already show" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165248 (owner: 10Florianschmidtwelzow) [18:06:39] (03CR) 10Jdlrobson: [C: 032] Fix username for anonymous editing in MobileWebEditing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165251 (https://bugzilla.wikimedia.org/71252) (owner: 10Florianschmidtwelzow) [18:07:11] (03Merged) 10jenkins-bot: Fix username for anonymous editing in MobileWebEditing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165251 (https://bugzilla.wikimedia.org/71252) (owner: 10Florianschmidtwelzow) [18:07:17] (03PS9) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [18:12:10] (03PS10) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [18:12:28] 3MobileFrontend / 3alpha: EventLogging on alpha anonymous editing being thrown away - 10https://bugzilla.wikimedia.org/71252 (10Jon) 5PATC>3RESO/FIX [18:13:04] (03CR) 10Jdlrobson: [C: 032] Remove borders from tables within infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165120 (https://bugzilla.wikimedia.org/68579) (owner: 10Bmansurov) [18:13:40] (03CR) 10jenkins-bot: [V: 04-1] Remove borders from tables within infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165120 (https://bugzilla.wikimedia.org/68579) (owner: 10Bmansurov) [18:13:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [18:15:09] (03CR) 10Jdlrobson: [C: 04-1] "Actually re-reading the bug we only want this to apply to tables within the infobox" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165120 (https://bugzilla.wikimedia.org/68579) (owner: 10Bmansurov) [18:16:13] If you guys haven’t seen this, it’s fun: https://www.facebook.com/CoolFreaksWC [18:16:55] HIghighting such fascinating articles as http://en.wikipedia.org/wiki/Anti-Flirt_Club [18:18:18] (03CR) 10Jhobs: "Thanks for the comments; fixed the issues in the incoming patch." (037 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [18:20:43] (03PS3) 10Jhobs: Redesign Zero info screen [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 [18:21:16] (03CR) 10jenkins-bot: [V: 04-1] Redesign Zero info screen [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [18:22:30] yurikR1: uhhhh somehow a test failed on the new patch due to database/disk being full... [18:23:23] jhobs______, jenkins is having issues... as always :) [18:23:33] btw, how many ___ can you have [18:23:50] yurikR1: a lot, apparently [18:24:08] (03PS1) 10Bmansurov: WIP: Add missing JavaScript documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165257 [18:24:37] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [18:24:46] yurikR1: also, somehow this whole patch got split from the one I originally put out [18:24:56] yurikR1: 163891 [18:24:57] jhobs______, i think i have set it up in phpstorm to 110 (that's the max that gerrit shows as one line) [18:25:14] (03PS3) 10Jdlrobson: Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) [18:25:15] that's because you probably edited the last line in the commit message [18:25:22] yurikR1: ah, just 10 off [18:25:31] (03PS8) 10Jdlrobson: Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 [18:25:37] (03PS11) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [18:25:46] yurikR1: hmm... not sure how that would've happened, but maybe during rebase or something. I'll mark the old one as abandoned and leave a comment [18:25:56] ok [18:26:00] yurikR1: unless there's a different proper practice in this scenario? [18:26:28] (03CR) 10jenkins-bot: [V: 04-1] Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) (owner: 10Jdlrobson) [18:26:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 (owner: 10Jdlrobson) [18:26:42] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [18:26:51] nah, thats fine [18:28:06] (03Abandoned) 10Jhobs: Update zero info page to match mobile-frontend [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/163891 (owner: 10Jhobs) [18:28:46] yurikR1: how can I make jenkins run the tests again? Just add as reviewer again? [18:29:23] jhobs______, "recheck" as a comment should trigger it [18:29:41] (03CR) 10Jhobs: "recheck" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [18:37:59] (03CR) 10Yurik: [C: 04-1] "a few more things..." (036 comments) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [18:38:05] jhobs______, ^ [18:38:47] btw, jhobs______, make sure you monitor 'jhobs' (irc clients have /notify or something like that) - this way you will get pinged on irc [18:38:57] yurikR1: i do [18:39:09] yurikR1: i monitor jhobs, hobs, jhobson, etc. [18:39:14] lol :) [18:39:34] jhobs______: are you gaining _s over time? [18:39:35] :) [18:40:11] YuviPanda: apparently :D not sure whether to clear them or not now for hilarity's sake [18:40:47] :D [18:41:04] at some point you'll hit nick length limits... [18:41:24] you could cycle [18:46:45] and the _s are gone :D [18:47:32] yurikR1: I agree on renaming the i18n string. Does the qqq message seem fine to you [18:47:34] ? [18:51:56] jhobs, zero-info-proxy? yes, looks good to me [18:52:21] yurikR1: is the "ok" msg being used anywhere else? Because I removed that from the info screen too [18:52:37] yurikR1: so if it's not, then I'll get rid of it from i18n [18:53:03] jhobs, "ok" message is not in i18n [18:53:53] yurikR1: you're right... not sure what it's doing in ZeroBanner.php then. I'll get rid of it [18:54:24] jhobs, its a core message, which we can reuse in the ext [18:54:34] core has lots of fun messages like that [18:54:50] yurikR1: ah. Well I still don't think we're using it, so I'll remove it [18:57:31] jhobs, didn't we want to have some "ok/close/accept/...?" button at the bottom? [18:57:43] (03PS4) 10Jhobs: Redesign Zero info screen [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 [18:57:48] yurikR1: unnecessary with OOUI dialog since it has a close button [18:57:55] yurikR1: and they can still hit back [18:57:56] cool, thx [18:59:23] yurikR1: ^^^ [19:01:18] vbamba: is there a hangout for the meeting? [19:06:58] (03PS1) 10Robmoen: Remove apple web app capable mode from skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165315 (https://bugzilla.wikimedia.org/60917) [19:14:32] (03CR) 10BearND: [C: 032] Catch SecurityException and rethrow as ApiException. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/165246 (https://bugzilla.wikimedia.org/67948) (owner: 10Dbrant) [19:21:10] (03PS2) 10Kaldari: Making notification archive link use anchor styles rather than button styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165142 [19:24:43] (03CR) 10Florianschmidtwelzow: [C: 031] Making notification archive link use anchor styles rather than button styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165142 (owner: 10Kaldari) [19:29:22] (03PS3) 10Bmansurov: Remove borders from tables within infoboxes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165120 (https://bugzilla.wikimedia.org/68579) [19:32:04] Maryana, phuedx, rmoen, et al, we're working on a TOC for Flow (instead of the current collapsed view). [19:32:19] We were wondering if you wanted to sync up about mobile design/implementation. [19:34:14] superm401: It'd be nice if I could be involved since it's the mobile apps that have the ToC, and that's my area. :) [19:35:15] Deskana, sure, it probably makes sense for you to be involved as well. [19:35:24] Just realized I have no idea what the mobile app experience is with Flow. [19:35:36] superm401: It doesn't exist at all. :) [19:37:46] (03PS1) 10Kaldari: Hygiene: Cleaning up getSkinConfigVariables and improving documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165320 [19:38:13] jhobs, i was playing with the patch, looks very good, but i think we should change tech info a bit, posibly even making it into a one liner code strign, e.g. 250-99,DIRECT,HTTPS,EN,M,WP [19:39:00] superm401: This is Flow on the iOS app: http://i.imgur.com/hFUPwkg.jpg [19:39:08] yurikR1: I thought about that too and agree, but I figured that's something we should discuss when we talk with dan/carolynn about the wording [19:40:06] Deskana, yeah, it's pretty heavily broken on Android too. Let me get a screenshot. [19:40:08] yurikR1: I was going to bring up wording/phrasing during our meeting later too [19:40:08] jhobs, true, but i would rather not bug translators if possible :) I'm sure they will be ok with a small, gray text at the bottom [19:40:35] btw, for direct connection, seems like you are not showing tech details [19:40:59] yurikR1: i'm showing when conf.proxy is set to DIRECT [19:41:40] yurikR1: all of the technical details only show up if they're set (https, proxy, ipset) [19:42:33] (03CR) 10Yurik: [C: 04-1] Redesign Zero info screen (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [19:42:43] superm401: It's not surprising to me. We have zero code in the app to handle Flow pages. [19:42:49] jhobs, just a minor fix, otherwise looks good [19:42:52] http://imgur.com/6FVuvJa [19:43:14] Deskana, yeah, I never thought about it before. We'll need to address it somehow, but that might just be by sending them back to web or something. [19:43:18] For now at least. [19:43:24] yurikR1: aaargh idk why every time i fix the indents it seems to mess with another one [19:43:37] :) [19:43:57] i need to spend some time with phpStorm's preferences at some point [19:44:03] get everything customized to the right standards [19:44:14] superm401: Hah, I can't stop giggling to myself. [19:44:21] superm401: "What page are you editing?" "false" [19:44:32] "I'm editing false". [19:45:04] yurikR1: so do you want me to change the tech details then while I'm fixing this indent, or just save it for a different patch? [19:45:19] Deskana, does the mobile app only work on Wikipedias, or is there a way to trick it to work on e.g. MediaWiki.org? [19:45:32] superm401: Only Wikipedias, yeah. [19:46:12] jhobs, well, ideally, would be good to just make it into a one liner that is gray and smaller font at the bottom: Technical details: $1, and that $1 may be generated by js, or we could even produce it in php [19:46:44] and make it always theer [19:47:10] yurikR1: i agree, but at that point it seems like a different enough change to warrant its own patch, don't you think? [19:47:36] yurikR1: because if we want all of the details then we'll definitely have to modify the php some, which is more up your alley than mine [19:47:57] for now you can create that string in js, its fine [19:48:25] Deskana, FYI, there is a sandbox at Wikipedia_talk:Flow/Developer_test_page you can test with if you want. [19:48:30] yurikR1: right, but I'm not getting all the info, only what's set in the headers and passed along by php [19:48:30] jhobs, its more of not making translation volonteers do any unneeded work [19:48:38] I'm about to file a bug, just want to see if any interaction features work. [19:48:39] that should be enough [19:48:43] 3MobileFrontend / 3Hygiene: Minimize number of thumb sizes used in MobileFrontend extension - 10https://bugzilla.wikimedia.org/58285#c11 (10Bahodir Mansurov) Would it be a good idea to use some value closer to 56px (as Ryan mentioned), and not use 80px for search? Also, TINY image width is also used in less... [19:49:03] yurikR1: yeah I understand. Ok I'll change it. I assume that means you want me to remove the zero-info-via then, right? [19:49:23] yurikR1: and I can just prefix the tech string with zero-info-geek [19:49:35] yep :) [19:50:09] jhobs, actually, lets show it to dan first [19:50:42] you can show it on your laptop [19:51:22] yurikR1: ok yeah because I still need to ask him again whether he wants a "limited wikipedia" message or not and it would make more sense to do that in the same change [19:52:00] ok, and there now should be a link to the Special:ZRMA page [19:52:00] (03CR) 10Florianschmidtwelzow: "Argh, damn, this message i have ignored :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165248 (owner: 10Florianschmidtwelzow) [19:52:34] because we want to show the same page server-side in case of