[00:00:24] James_F|Away: --^ [00:00:37] tfinc: i don’t see him at his desk [00:04:59] 3MobileFrontend / 3General/Unknown: In Firefox Nightly for Android all sections are expanded and TOC is shown - 10https://bugzilla.wikimedia.org/70277#c2 (10Jon) 5NEW>3ASSI This appears to be an issue with Firefox OS https://bugzilla.mozilla.org/show_bug.cgi?id=1071620 I reached out to them. [00:05:29] 3MobileFrontend / 3General/Unknown: In Firefox Nightly for Android all sections are expanded and TOC is shown - 10https://bugzilla.wikimedia.org/70277#c3 (10Jon) * This appears to be a bug with Firefox nightly :) [00:06:36] (03PS2) 10Saltymule: Support DISPLAYTITLE in article view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164756 (https://bugzilla.wikimedia.org/63971) [00:06:39] Deskana: brion pointed out that this release will have the saved pages instrumentation for ios: https://github.com/montehurd/apps-ios-wikipedia/commit/1f03eecf90e8e881eecdc9b1e38bab9696b80f2a [00:07:33] Deskana: oops that’s the github mirror of my fork… same patch thing though [00:08:10] DarTar: I can never find that page with the SQL definitions, what's it called again? [00:08:25] the one on meta? [00:08:41] kaldari: https://meta.wikimedia.org/wiki/Research:Metrics_standardization [00:08:56] DarTar: Yes, thanks! [00:09:01] np [00:11:55] (03CR) 10Jdlrobson: [C: 032] Redirect to login [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [00:14:44] (03CR) 10Robmoen: QA: Make browser tests pass again (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165394 (https://bugzilla.wikimedia.org/71613) (owner: 10Jdlrobson) [00:15:27] (03CR) 10Deskana: [C: 04-2] "We should not be special-casing entire countries like this. I'll work with the engineers to see that we come up with a better solution, bu" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163830 (owner: 10Zhaofeng Li) [00:15:32] rmoen: you should be more confident and +2 :) [00:15:42] but in answer to your question [00:15:52] css allows adding/removing class names [00:16:02] jdlrobso_: i didn't give a score ;) [00:16:09] DarTar: also I forgot the name of the logging table that has the registration source. Is it SignupExpAccountCreationComplete_8539421? [00:16:10] so if an element has class "foo bar" :class needs to be exactly that [00:16:13] not "bar foo" [00:16:18] jdlrobso_: gotcha [00:16:19] and it won't match "foo bar newclass" [00:16:26] so css makes life a lot easier [00:16:28] it's a bit more recent [00:16:34] i think originally not available in the page api [00:16:40] jdlrobso_: yeah i was trying to read up about it [00:17:19] (03Merged) 10jenkins-bot: Redirect to login [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [00:17:31] jdlrobso_, rmoen: Are you guys talking about the rspec selectors? [00:17:38] kaldari: log.ServerSideAccountCreation_5487345, I attached sample queries here: https://trello.com/c/lBTK331k/402-mobile-activity-dashboards [00:18:28] kaldari: browser tests [00:18:57] (03CR) 10Robmoen: [C: 032] QA: Make browser tests pass again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165394 (https://bugzilla.wikimedia.org/71613) (owner: 10Jdlrobson) [00:20:12] (03PS1) 10Bmansurov: Use 300px standard image size for uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165408 (https://bugzilla.wikimedia.org/58285) [00:20:19] (03Merged) 10jenkins-bot: QA: Make browser tests pass again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165394 (https://bugzilla.wikimedia.org/71613) (owner: 10Jdlrobson) [00:20:24] jdlrobso_, rmoen: jhobs_ was having some trouble with those as well. Apparently, you can only do relatively simple css selections, but it's a million times better than the old class selector method [00:20:47] ^ yes, that. [00:21:18] or text selectors [00:23:57] (03PS2) 10Jdlrobson: Use 300px standard image size for uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165408 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [00:25:29] 3Wikipedia App / 3Android App: UnknownHostException: Unable to resolve host "lang.m.wikipedia.org": No address associated with hostname - 10https://bugzilla.wikimedia.org/71332#c4 (10Alex Monk) 5PATC>3RESO/FIX Looks like that'll fix it. [00:25:29] 3MobileFrontend / 3stable: Login form duplicate messages - 10https://bugzilla.wikimedia.org/71771#c3 (10Jon) Created attachment 16700 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16700&action=edit Similarly, if you hit an error you see two alert boxes. We should probably only show one. [00:25:29] 3MobileFrontend / 3stable: Login form duplicate messages - 10https://bugzilla.wikimedia.org/71771#c2 (10Jon) I'd suggest styling the alert box instead of headmsg and using our own custom message which includes the bold text. [00:25:29] 3MobileFrontend / 3Feature requests: top of article messy on phones and inconsistent with tablet - 10https://bugzilla.wikimedia.org/71450#c2 (10Jon) Kaity, this is a big chunk of work and should probably be turned into a story. Not really actionable at current time. [00:25:30] 3MobileFrontend / 3stable: Watchlist doesn't redirect to login on mobile - 10https://bugzilla.wikimedia.org/71206 (10Jon) 5PATC>3RESO/FIX [00:25:32] 3MobileFrontend / 3Hygiene: Inconsistency: Editor uses back icon for closing overlay, talk uses X - 10https://bugzilla.wikimedia.org/71203 (10Jon) a:3Jon [00:26:21] (03CR) 10Alex Monk: "Which patches?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151779 (https://bugzilla.wikimedia.org/66732) (owner: 10Dbrant) [00:27:22] (03PS3) 10Jdlrobson: Use standard image sizes on nearby, search and watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165408 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [00:27:28] (03CR) 10Jdlrobson: [C: 032] Use standard image sizes on nearby, search and watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165408 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [00:28:04] (03Merged) 10jenkins-bot: Use standard image sizes on nearby, search and watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165408 (https://bugzilla.wikimedia.org/58285) (owner: 10Bmansurov) [00:28:58] 3MobileFrontend / 3Hygiene: Minimize number of thumb sizes used in MobileFrontend extension - 10https://bugzilla.wikimedia.org/58285 (10Jon) 5PATC>3RESO/FIX [00:29:13] 3MobileFrontend / 3stable: Browser test: cancel button changes - 10https://bugzilla.wikimedia.org/71613 (10Jon) 5PATC>3RESO/FIX [00:29:15] 3MobileFrontend / 3stable: Login form duplicate messages - 10https://bugzilla.wikimedia.org/71771 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16699 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16699&action=edit Duplicate error messages Navigate to Special:Watchlist whilst n... [00:29:28] 3MobileFrontend / 3stable: Login form duplicate messages - 10https://bugzilla.wikimedia.org/71771#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/dDj3Id6L [00:29:55] (03PS4) 10Jdlrobson: Hygiene: Refactor tests / jshintrc to not use globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165369 (https://bugzilla.wikimedia.org/71714) [00:30:06] (03PS6) 10Jdlrobson: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) [00:30:13] (03PS4) 10Jdlrobson: Never hit the API when running QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) [00:30:18] (03PS5) 10Jdlrobson: Hygiene: Refactor tests / jshintrc to not use globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165369 (https://bugzilla.wikimedia.org/71714) [00:30:56] (03PS9) 10Jdlrobson: Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 [00:46:06] (03CR) 10Robmoen: [C: 032] "For some reason the markAsAllWatched param name hurt my brain. I can't help but feel like we could find something more suitable, but I l" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165398 (https://bugzilla.wikimedia.org/70078) (owner: 10Jdlrobson) [00:47:18] (03Merged) 10jenkins-bot: Allow watching of missing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165398 (https://bugzilla.wikimedia.org/70078) (owner: 10Jdlrobson) [00:48:58] 3MobileFrontend / 3stable: mobile watchlist shows deleted articles in the full list with a white star - 10https://bugzilla.wikimedia.org/70078 (10Jon) 5PATC>3RESO/FIX [00:49:13] me gotta go and see the sister [00:49:16] see you all tomorrow [00:49:24] good productive day :) [00:56:42] (03PS10) 10Robmoen: Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 (owner: 10Jdlrobson) [00:57:00] (03CR) 10Robmoen: [C: 032] Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 (owner: 10Jdlrobson) [00:57:41] (03Merged) 10jenkins-bot: Hygiene: Toggle classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/163889 (owner: 10Jdlrobson) [00:58:11] bah, he just left [00:58:52] (03PS7) 10Robmoen: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [00:59:40] (del/undel) 00:59, 8 October 2014 Legoktm (talk | contribs | block) changed group membership for User:Jdlrobson from (none) to template editor (wishes to help out make templates more mobile-friendly :) (Tag: HHVM) [01:05:35] (03PS2) 10Dbrant: [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [01:07:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 (owner: 10Dbrant) [01:12:30] (03PS3) 10Dbrant: [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [01:22:42] kaldari: ironically, i could have tested the database locked bug myself today, because that appears to be the case right now :-P [01:22:53] on beta labs [01:23:23] Maryana: Yes, all of labs has been caput today :( [01:23:58] sigh [01:42:40] (03PS4) 10Dbrant: [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [02:06:17] (03PS1) 10Robmoen: Split out content less into features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) [02:07:07] (03CR) 10jenkins-bot: [V: 04-1] Split out content less into features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) (owner: 10Robmoen) [02:10:12] (03CR) 10Robmoen: [C: 04-1] "Oops.. broke things" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) (owner: 10Robmoen) [02:24:40] (03PS5) 10Dbrant: [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [05:30:28] 3MobileFrontend / 3Feature requests: Provide a TOC on pages (devices) without JavaScript - 10https://bugzilla.wikimedia.org/53454#c2 (10Liangent) (In reply to Jon from comment #1) > Who is "they" ? Pages displayed in browsers without JavaScript. [05:44:57] (03CR) 10Florianschmidtwelzow: [C: 031] Never hit the API when running QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) (owner: 10Jdlrobson) [07:24:44] (03PS3) 10Florianschmidtwelzow: WIP: Getting rid of own Login template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165248 [07:26:06] (03CR) 10Florianschmidtwelzow: [C: 04-1] "A big minus 1." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165248 (owner: 10Florianschmidtwelzow) [09:26:03] morning all [10:11:01] (03CR) 10Phuedx: [C: 04-1] "LGTM. -1 because we might be able to tackle the binding between the MobileSpecialPage and SkinMinerva classes, not because there's a probl" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [11:24:04] going out for lunch [13:02:15] 3MobileFrontend / 3stable: Audio tags shouldn't have height. Look cramped in mobile. - 10https://bugzilla.wikimedia.org/71365 (10Sam Smith) a:3Sam Smith [13:57:59] 3MobileFrontend / 3stable: Audio tags shouldn't have height. Look cramped in mobile. - 10https://bugzilla.wikimedia.org/71365#c2 (10Sam Smith) The audio tags are created by the TimedMediaTransformOutput class in the TimedMediaHandler extension. The TimedMediaTransformOutput can create tags for both audio an... [14:00:58] 3MobileFrontend / 3stable: Audio tags shouldn't have height. Look cramped in mobile. - 10https://bugzilla.wikimedia.org/71365#c3 (10Brion Vibber) See also bug 61823 (ogv.js player integration) -- the last patchset on it adds a mobile media player overlay for audio and video, using ogv.js on Safari or the nat... [14:17:04] espresso time! [14:30:45] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165483 [14:32:57] (03CR) 10Dbrant: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165483 (owner: 10Dbrant) [15:13:50] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164673 (https://bugzilla.wikimedia.org/71206) (owner: 10Bmansurov) [15:19:27] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [15:34:05] * bearND waves at dbrant and YuviPanda|food [15:34:30] hey bearND! [15:35:29] bearND: so, there were no problems with the new scripts! however, there seems to be one thing that's missing (or not totally clear): [15:35:59] bearND: the bumped commit doesn't seem to be getting its own tag. how are we handling this now? [15:38:01] dbrant: hmm, good point. I thought we wouldn't need a tag for it since we tag the actual releases. But I could be convinced otherwise. [15:39:31] bearND: so then, when we want to make a Production build later, are you saying that we'll checkout the Beta tag that was just made, and build off that? [15:39:56] bearND: (I'm fine with that, as long as that was your intention) [15:43:06] dbrant: yes, that was my intention. I just wanted to keep it simple. [15:43:51] bearND: alright then! we're all good [15:44:13] dbrant: btw, not sure if you saw my post yesterday. There is a newer revision of the Android SDK API 19 Platform (rev 4) available. You might want to update it so we're on the same [15:44:23] bearND: yep, i got it! [15:44:29] great! [15:44:32] dbrant: have you started a patch to bring disambig/page issues to all releases? [15:45:08] i think this is what Deskana wanted to add to the beta so we can move this to the next prod release [15:46:54] bearND: ah, good point indeed... lol Let me do that, and then we'll just push another beta apk ;) [15:47:22] Heja. There is the "Wikipedia App" project in Wikimedia Bugzilla which has two "Target Milestones" called "1.1" and "1.2". Are both releases in the past? Sorry but I don't know your versioning scheme... [15:47:28] dbrant: good [15:48:06] andre__: yes, both are in the past. On Android we have 2.0-x and iOS has 4.0 now [15:48:13] thanks. so I can disable them. [15:48:29] andre__: yes [15:57:49] (03PS1) 10Dbrant: Make Nearby and PageIssues/Disambig available in production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165500 [15:59:08] bearND: ^ [15:59:24] dbrant: looking... [16:01:58] (03PS4) 10Florianschmidtwelzow: WIP: Getting rid of own Login template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165248 [16:04:22] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Still needs some work." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165248 (owner: 10Florianschmidtwelzow) [16:13:04] dbrant: re: your patch: Looks like there is no need to add isBeta to the payload anymore on the Java side (in PageViewFragment). [16:14:13] 3MobileFrontend / 3Feature requests: Provide toclimit-2 and .toclevel-1 support in tablet table of contents - 10https://bugzilla.wikimedia.org/71726#c5 (10Florian) I'm not sure what the advantage of this is (or would be). The ToC is the basic element where the user can orient when reading the article, so why... [16:14:44] bearND: well, I left it there because it's acting as the feature-toggle on the JS side. Even though it's not used for anything right now, I think it should be made available in JS for future beta features. [16:16:06] dbrant: that's fine then. [16:18:54] (03PS2) 10BearND: Make Nearby and PageIssues/Disambig available in production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165500 (owner: 10Dbrant) [16:19:00] (03CR) 10BearND: [C: 032] Make Nearby and PageIssues/Disambig available in production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165500 (owner: 10Dbrant) [16:19:35] (03Merged) 10jenkins-bot: Make Nearby and PageIssues/Disambig available in production. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165500 (owner: 10Dbrant) [16:37:38] bearND: ok, re-bumping and re-releasing beta... [16:37:51] dbrant: sure [16:38:25] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165506 [16:39:14] dbrant: not sure how the (--push) script will hold up if there is already a tag [16:39:26] dbrant: you might need to do those manually [16:40:17] bearND: yep, I'll just manually make a tag with the same name + "_2" at the end [16:40:59] dbrant: ok, and then push the tag [16:41:04] right [16:41:31] (03CR) 10Dbrant: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165506 (owner: 10Dbrant) [16:59:10] kristenlans, anyone mobile standup, I get "You're not allowed to join this video call" [16:59:54] bearND: done! I'm also making a simple script to facilitate signing/aligning the final APK... [17:00:07] spagewmf: weird... [17:00:16] spagewmf: are you in office or remote? [17:00:21] bearND: onething I'm not certain about: is the keystore "alias" name supposed to be secure? (or can I hardcode it in the script?) [17:00:28] in office. Maryana's signing in instead [17:00:44] dbrant: the Gradle build does the zipaligning already [17:00:47] Cool :-) [17:01:01] dbrant: not sure about the alias [17:01:11] dbrant: but better be safe than sorry [17:01:37] bearND: but doesn't the file become un-aligned after signing? [17:01:49] kristenlans: getting "You're not allowed to join this video call" when i try and join the stand up [17:02:00] phuedx: are you joining the hangout? [17:02:05] dbrant: The Gradle build handles signing as well [17:02:14] sorry I see your message [17:02:18] dbrant: it's a one-stop shop :) [17:02:18] we'll invite you [17:02:22] spagewmf: ta [17:02:37] we've invited you, check your e-mail [17:03:44] bearND: hmm! i'll have to see how that's done. Do we document this somewhere? [17:04:23] dbrant: it's at the bottom of the wikipedia/build.gradle file [17:04:36] dbrant: look at the comments for the last section [17:05:32] dbrant: if you build release bits (run the Gradle task assembleXYZRelease) it uses the credentials from the properties file [17:06:20] bearND: well, that's it then! thanks [17:06:35] we've got a great new system [17:08:02] dbrant: I talked with Adam about adding a level of indirection so that you could specify a file on an external disk that could be on a separately encrypted file system [17:08:55] that could be good, too [17:09:14] dbrant: probably would just updated the last block of the build.gradle file [17:09:23] update [17:13:52] (03CR) 10Jhobs: [C: 04-1] "Spoke with dfoy and there are some changes to content and phrasing, so expect a new patch soon." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [17:16:04] you guys online yet? :D [17:17:31] there ya are [17:27:55] bmansurov: https://office.wikimedia.org/wiki/Engineering/Mobile/Testing_Devices [17:29:17] phuedx: Found your email, so I'm assuming that the hours you mentioned are in London time, correct? [17:29:34] kaldari: doh! forgot timezones [17:29:35] derp [17:29:36] bst [17:31:56] spagewmf: I'm transitioning off the apps team into ops (fully out by nov 3), and hence am not on any card :) [17:32:17] Yuvi man on the move [17:35:28] Deskana: also got feedback that loading indicator is maybe too dark… could easily tweak it [17:35:47] phuedx: OK, looks like your hours by SF time are 2am to noon. [17:36:41] spagewmf: :) [17:37:04] Thanks for standup coverage spagewmf! [17:40:16] (03PS10) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [17:40:18] (03PS4) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [17:40:20] (03PS2) 10Jdlrobson: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 [17:40:22] (03PS2) 10Jdlrobson: Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 [17:40:30] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [17:40:47] (03Abandoned) 10Jdlrobson: Hygiene: Use iconClass helper in Special classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [17:40:52] (03CR) 10Jdlrobson: Hygiene: Use iconClass helper in Special classes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164413 (owner: 10Jdlrobson) [17:41:00] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [17:41:05] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 (owner: 10Jdlrobson) [17:41:11] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 (owner: 10Jdlrobson) [17:42:01] (03CR) 10Jdlrobson: [C: 04-1] "Looks very componentised :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) (owner: 10Robmoen) [17:43:47] Deskana: i created a card for that bug report: https://trello.com/c/VhTHoaKI/33-chinese-user-reports-articles-won-t-download [17:43:55] (03PS5) 10Jdlrobson: Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) [17:44:17] (03PS12) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [17:44:23] (03PS6) 10Jdlrobson: Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 (https://bugzilla.wikimedia.org/71715) [17:51:15] dbrant: YuviPanda: Deskana: alpha build is working again [17:51:25] yay!! [17:51:28] bearND: yay [17:51:35] bearND: was it just the toollabs outage that affected it? [17:52:08] YuviPanda: probably a combination of that and moving to Gradle [17:52:46] YuviPanda: The Gradle build needed more env vars set: JAVA_HOME, ANDROID_SDK, and TERM [17:52:57] ah [17:53:09] I guess gradle isn't as memory hoggy as maven? [17:53:30] YuviPanda: not sure about that [17:53:38] hmm [17:54:02] YuviPanda: if you want to try out lower mem settings for the job feel free. [17:54:08] yeah, will do... [17:54:15] did you commit / merge any changes to build.py? [17:54:41] YuviPanda: I basically did a git reset --hard HEAD^ to force a new build on the tools server [17:54:52] inside the wikipedia directory of course [17:55:11] hmm, ok [17:55:17] YuviPanda: I did commit some changes yesterday [17:55:40] ah, cool [17:56:19] YuviPanda: but will also add my todays' changes, although they are probably more cosmetic. The beginning of the script output the current time stamp to stdout and stderr [17:56:32] Krinkle, around? [17:56:34] ah, that's useful [18:00:02] Krinkle, seems like opera mini editing is broken :( [18:00:09] i suspect its the same with IE6 [18:07:51] (03PS1) 10Jdlrobson: Hygiene: Remove dead View.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165521 [18:07:53] (03PS1) 10Jdlrobson: Hygiene: Run jsduck on Mantle documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165522 [18:09:27] IE6? :O [18:10:05] (03PS1) 10Jhobs: Refactor browser tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 [18:15:04] (03PS2) 10Jdlrobson: Hygiene: Run jsduck on Mantle documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165522 [18:16:29] * phuedx has a chocolate muffin and some milk [18:16:32] dinner! [18:19:16] MaxSem, jdlrobson2, brion, bmansurov, phuedx: If you guys want API improvements to mediawiki please vote for it at https://office.wikimedia.org/wiki/Project_Ideas_Oct_2014#What_projects_should_WMF_Prod.2FEng_be_working_on.3F [18:19:27] (03CR) 10Jhobs: Refactor browser tests (031 comment) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 (owner: 10Jhobs) [18:20:19] jdlrobson2: nice work extracting the iconClass helper [18:20:23] phuedx: :D [18:20:27] (03CR) 10Florianschmidtwelzow: [C: 04-1] Hygiene: Introduce generic switcher (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 (owner: 10Jdlrobson) [18:20:34] phuedx: i figured we could use it for other things in future [18:20:40] kaldari|2: yarrrp [18:21:02] also, as you've pointed out, it's definitely the place for [18:22:17] (03CR) 10Yurik: "Minor comments." (034 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 (owner: 10Jhobs) [18:23:50] kaldari|2: lolz https://gerrit.wikimedia.org/r/165521 [18:23:55] jdlrobson2: do you have any opinion on where base styles for the audio element should live? [18:24:08] phuedx: i guess in the extension that creates them [18:24:13] i think they should use skin styles [18:24:30] maybe vector and monobook only [18:24:40] or even kill them - they seem like bizarre styles [18:25:09] (03CR) 10Florianschmidtwelzow: "> Note: We add template partials to both VE Overlay and wikitext overlay" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 (owner: 10Jdlrobson) [18:26:13] 3MobileFrontend / 3stable: Login form duplicate messages - 10https://bugzilla.wikimedia.org/71771#c4 (10Jon) Florna seems to have made a start to this - might be some ideas there - https://gerrit.wikimedia.org/r/#/c/165248/4 [18:26:47] jdlrobson: Florna? :P [18:27:15] (03CR) 10Jhobs: "Replied to comments, patch on the way with tab fixing." (033 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 (owner: 10Jhobs) [18:27:59] 3MobileFrontend / 3stable: Login form duplicate messages - 10https://bugzilla.wikimedia.org/71771#c5 (10Florian) Yeah, it was an idea (before i saw this bug today), maybe we can use it someway :) Comments are welcome! [18:28:58] kaity: you there? [18:29:29] (03CR) 10Kaldari: [C: 04-1] "I know this may seem pedantic, but for the benefit of our new developers, could we add a note about this to the classes that extend View i" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165521 (owner: 10Jdlrobson) [18:29:37] jdlrobson2: hey [18:29:43] (03CR) 10Florianschmidtwelzow: "Info: I1267c838aaa93d3ec4b22577fe959764ba2d11f3" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [18:30:28] Why when I load VE and click the switcher, is 'Edit' blue when it carries no action. I mean it's not progressive.. clicking does nothing. It's very confusing. [18:30:37] yurikR1: the header(:header...) line just refers to a
tag in the document [18:30:40] shouldn't it be the other way round? [18:30:51] yurikR1: just like a(...) refers to an anchor tag [18:30:53] jdlrobson2: see my comment :) [18:31:02] FlorianSW: yeh that's what inspired this discussion :) [18:31:04] yurikR1: still want me to comment it though? [18:31:17] jdlrobson2: ah, ok :D [18:31:36] kaity: i can come to your desk if you want to see what i'm talking about [18:31:38] jhobs, oh, i thought that was some command to alter the header. Up to you - if others might have a question like that :) [18:31:40] jdlrobson2: ah, you're talking to kaity, that i haven't seen :) [18:31:58] jhobs, headers being X-CS, etc [18:32:24] yurikR1: eh, I think it would be a little unnecessary since it follows the syntax of "tagname(:variable_name, params)" [18:32:32] up to you [18:33:53] yurikR1: as far as the gitignore file goes, I'm not sure what I can do about that without having an "untracked files" warning every time I commit if I remove it [18:34:12] where are those files from? [18:34:12] yurikR1: which would also mean I couldn't use commit -a anymore [18:34:24] -a only adds files that are already in the repo [18:34:36] iirc [18:34:51] yurikR1: Node.js, used to auto-convert the LESS into CSS [18:35:08] hmm.. any way to dump them into some official "temp" dir? [18:35:22] if not, go ahea [18:35:51] I mean, I could create a .tmp and add that to .gitignore instead if that would be better [18:36:45] I could also install Node.js at the home level instead of project, but it would still generate the CSS files either way [18:39:41] (03CR) 10Kaldari: [C: 032] "Need to backport Rob's changes to Mantle, but not a blocker." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165521 (owner: 10Jdlrobson) [18:39:43] (03PS2) 10Jhobs: Refactor browser tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 [18:40:14] (03Merged) 10jenkins-bot: Hygiene: Remove dead View.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165521 (owner: 10Jdlrobson) [18:42:44] (03CR) 10Kaldari: [C: 032] Hygiene: Run jsduck on Mantle documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165522 (owner: 10Jdlrobson) [18:43:18] (03Merged) 10jenkins-bot: Hygiene: Run jsduck on Mantle documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165522 (owner: 10Jdlrobson) [18:43:33] 3MobileFrontend / 3Hygiene: Documentation: JS Documentation out of date since OOJS move - 10https://bugzilla.wikimedia.org/71250 (10Andre Klapper) [18:51:30] (03PS7) 10Jdlrobson: Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 (https://bugzilla.wikimedia.org/71715) [18:51:32] (03PS11) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [18:51:34] (03PS13) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [18:51:36] (03PS3) 10Jdlrobson: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 [18:51:38] (03PS9) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [18:51:40] (03PS3) 10Jdlrobson: Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 [18:52:09] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [18:52:31] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 (owner: 10Jdlrobson) [18:52:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 (owner: 10Jdlrobson) [18:55:26] aand labs down again [18:57:40] i'm gonna have a break before the meeting [18:58:08] oh good, you're joining! [18:58:14] (03PS2) 10Yurik: Allow multiple img fonts (one per lang) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144872 [18:58:24] Maryana: yarrrp [18:58:36] i have things for you (possibly, maybe) [18:58:41] (03CR) 10Yurik: Allow multiple img fonts (one per lang) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144872 (owner: 10Yurik) [18:58:42] but yes, go break [18:58:43] 3MobileFrontend / 3Feature requests: Table borders are always shown - 10https://bugzilla.wikimedia.org/37222#c6 (10Jon) 5REOP>3UNCO We recently submitted a change that would hide the borders on tables within tables. I'm not sure if this will help... Could you override the style on mobile using MediaWiki... [18:58:45] * phuedx runs for the hills [18:59:09] kaldari|2: jdlrobson2 either of ya know the pw for the admin account on beta labs? [18:59:13] pm plz [19:00:34] 3MobileFrontend / 3Feature requests: Table borders are always shown - 10https://bugzilla.wikimedia.org/37222#c7 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ScJYJdnL [19:01:16] 3MobileFrontend / 3Feature requests: Table borders are always shown - 10https://bugzilla.wikimedia.org/37222#c8 (10Jon) Patch in question that tweaked the styles was https://gerrit.wikimedia.org/r/165120 [19:03:58] 3MobileFrontend / 3stable: Safari on iPad crashes when viewing large articles? - 10https://bugzilla.wikimedia.org/68845#c9 (10Jon) 5NEW>3UNCO Can anyone reproduce this? [19:06:40] (03CR) 10Kaldari: [C: 04-1] "See earlier comments" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [19:08:13] 3MobileFrontend / 3stable: Site notices look crappy on mobile - 10https://bugzilla.wikimedia.org/65395#c13 (10Jon) 5REOP>3RESO/WOR There don't seem to be any banners on Wikivoyage right now. I'm not sure if there is anything else we can do here. [19:12:33] yurikR1: does ZeroBanner replace all the URLs with the interstitial in the php or in interstitial.js? Figured I'd check with you real quick before I go hunting [19:13:01] php does that [19:13:28] yurikR1: Hmm... that's unfortunate. Guess I'll have to do the one for the info screen manually [19:13:41] yurikR1: dan wants the link to show the interstitial instead of saying "free" or "not free" [19:14:13] i don't think this is a good approach - its better to show "read more free of charge" [19:14:32] or "read more, regular data charges may apply" [19:14:46] tell him to talk to UX ppl [19:14:53] yurikR1: brought that up too and he said it might change in the future when we show it to carolynn, but this is the way he wants it now [19:15:06] yurikR1: tech details are gone too [19:15:17] grr, ok, i will talk to him :) [19:33:08] mhurd: Let's not let perfect be the enemy of the good about the loading indicator! Better to finalise the release candidate so we can get our QA group testing it. [19:38:57] mhurd: Just wrapping my work up at home then I'm coming in to meet Andy. [19:44:50] (03PS5) 10Jhobs: Redesign Zero info screen [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 [19:45:09] yurikR1: ^ (going to lunch, will check comments if there are any when I get back) [19:45:47] jhobs, thx [19:46:01] dfoy is offline, can't geta hold of him [19:46:27] kaldari|2, who should i talk to about adding an item to the mobile menu? [19:47:00] i would like zero info screen to be available from the menu, but it might be good for the UX ppl to look at it first [19:54:43] 3MobileFrontend / 3stable: Audio tags shouldn't have height. Look cramped in mobile. - 10https://bugzilla.wikimedia.org/71365 (10Jon) 5NEW>3ASSI [19:58:28] 3MobileFrontend / 3stable: No placeholders on account creation or login forms in Opera Mini - 10https://bugzilla.wikimedia.org/68758#c4 (10Jon) Opera Mini 5-7 doesn't support placeholders or media queries. I'd suggest adding labels and using a media query to hide them. [20:00:29] 3MobileFrontend / 3stable: No placeholders on account creation or login forms in Opera Mini - 10https://bugzilla.wikimedia.org/68758#c5 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/uyLAu4Q2 [20:01:47] mhurd: Is there any reason there is no automated testing target in the ios wikipedia project? [20:02:16] MaxSem: coming? [20:04:16] yurikR1: I would talk to Maryana about that. FWIW, the server side code lives in SpecialMobileMenu.php. [20:04:52] Maryana: admin account? [20:12:17] (03CR) 10Dr0ptp4kt: "This passes on my machine with export MEDIAWIKI_URL=https://zero.wikimedia.org/wiki/" (033 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 (owner: 10Jhobs) [20:15:51] (03PS6) 10Dbrant: [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [20:16:27] Saltymule: we had issues with testing async objects pre-Xcode 6, which didn’t support async testing directly. the stopgap we came up with was too hack-ish. We’re presently switching the networking code over to AFNetworking which has test coverage, and we’re re-architecting the storage layer from the ground up to get away from coredata concurrency flakiness and this new data layer has tests being written as we speak :) [20:18:03] Saltymule: oh, and we’ll be cleaning out the hacky testing cruft as soon as these 2 refactors wrap up [20:19:12] kaldari jdlrobson maxsem bmansurov phuedx: http://hatjitsu.wmflabs.org/04711 [20:19:37] Saltymule: sorry this isn’t in place now. i realize it’s less than ideal and makes things harder for you. [20:19:54] Maryana, ping :) [20:23:34] (03PS1) 10MaxSem: SECURITY: Don't add POST data to footer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165599 (https://bugzilla.wikimedia.org/70009) [20:23:58] (03CR) 10MaxSem: [C: 032] "Already live on cluster." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165599 (https://bugzilla.wikimedia.org/70009) (owner: 10MaxSem) [20:24:16] (03PS1) 10MaxSem: SECURITY: Don't add POST data to footer links [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/165600 (https://bugzilla.wikimedia.org/70009) [20:24:32] (03Merged) 10jenkins-bot: SECURITY: Don't add POST data to footer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165599 (https://bugzilla.wikimedia.org/70009) (owner: 10MaxSem) [20:24:34] (03CR) 10MaxSem: [C: 032] SECURITY: Don't add POST data to footer links [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/165600 (https://bugzilla.wikimedia.org/70009) (owner: 10MaxSem) [20:24:48] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Don't add POST data to footer links [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/165600 (https://bugzilla.wikimedia.org/70009) (owner: 10MaxSem) [20:26:21] (03CR) 10MaxSem: [V: 032] SECURITY: Don't add POST data to footer links [extensions/MobileFrontend] (REL1_23) - 10https://gerrit.wikimedia.org/r/165600 (https://bugzilla.wikimedia.org/70009) (owner: 10MaxSem) [20:50:55] (03PS1) 10Dbrant: [WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [20:51:19] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 (owner: 10Dbrant) [20:55:37] (03PS2) 10Dbrant: [WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [21:09:10] (03CR) 10Jhobs: "Addressed Adam's comments." (033 comments) [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 (owner: 10Jhobs) [21:11:10] (03PS3) 10Dbrant: [WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [21:11:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 (owner: 10Dbrant) [21:12:14] first wikipedia monument to be installed in poland ... http://armenpress.am/eng/news/779338/author-of-wikipedia%E2%80%99s-first-monument-is-armenian.html [21:13:19] (03PS4) 10Dbrant: [WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [21:13:27] yurikR1: cool! [21:15:50] (03PS3) 10Jhobs: Refactor browser tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 [21:16:15] 3MobileFrontend / 3General/Unknown: User's password in response html - 10https://bugzilla.wikimedia.org/70009 (10Chris Steipp) 5NEW>3RESO/FIX a:5security>3None [21:16:28] gonna slink off to bed [21:17:21] (03PS4) 10Jhobs: Refactor browser tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 [21:19:22] yurikR1 & dr0ptp4kt: if you could review ^ again, it should be in a good spot now [21:19:54] marxarelli: mind taking a look, too? ^^ [21:20:37] dr0ptp4kt: sure thing [21:20:44] marxarelli: thx [21:23:15] (03PS1) 10Kaldari: Hygiene: Fix typo in param comment for onEventLoggingRegisterSchemas [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165615 [21:23:28] mhurd: Our guests for Specialist's Guild are here. Can you go greet them? I think they're with Tomasz. [21:23:35] mhurd: Tomasz just said they were here. [21:26:58] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Fix typo in param comment for onEventLoggingRegisterSchemas [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165615 (owner: 10Kaldari) [21:33:44] (03CR) 10Phuedx: [C: 032] "Whoops." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165615 (owner: 10Kaldari) [21:34:03] k… now i'm slinking [21:34:20] (03Merged) 10jenkins-bot: Hygiene: Fix typo in param comment for onEventLoggingRegisterSchemas [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165615 (owner: 10Kaldari) [21:36:24] jdlrobson2: is it a good practice to link to external resource in a commit message? [21:37:15] depends bmansurov [21:37:21] does it add value for the person reviewing the commit? [21:37:27] would it be better as an inline comment in the code? [21:38:06] jdlrobson2: it’s a link to a forume page where someone had a similar issue, but no solutions yet. maybe in the future someone else will post a solution and thus be useful? [21:38:16] jdlrobson2: ok [21:42:36] (03PS1) 10Jdlrobson: Use desktop login form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 [21:44:29] 3MobileFrontend / 3stable: No placeholders on account creation or login forms in Opera Mini - 10https://bugzilla.wikimedia.org/68758#c6 (10Jon) https://gerrit.wikimedia.org/r/165634 will take care of this if it was to move to stable. I think we need to kill our custom login code. [21:44:29] 3MobileFrontend / 3stable: Login form duplicate messages - 10https://bugzilla.wikimedia.org/71771#c6 (10Jon) 5NEW>3ASSI https://gerrit.wikimedia.org/r/165634 will take care of this if it was to move to stable. I think we need to kill our custom login code. [21:45:53] (03PS1) 10Bmansurov: Fix overlay height in iOS 8 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165637 (https://bugzilla.wikimedia.org/71725) [21:49:39] (03PS2) 10Jdlrobson: Fix overlay height in iOS 8 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165637 (https://bugzilla.wikimedia.org/71725) (owner: 10Bmansurov) [21:49:46] ^ careful on the commit message length bmansurov :) [21:51:05] jdlrobson2: ok, thanks for fixing it [21:51:43] (03CR) 10Jdlrobson: [C: 04-1] Fix overlay height in iOS 8 (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165637 (https://bugzilla.wikimedia.org/71725) (owner: 10Bmansurov) [21:56:27] (03PS14) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [22:01:07] bmansurov: up for dinner either tonight or tomorrow ? [22:01:34] tfinc: sure, either one works for me [22:08:03] (03PS3) 10Bmansurov: Fix overlay height in iOS 8 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165637 (https://bugzilla.wikimedia.org/71725) [22:25:40] tfinc: Do we have an iOS 6 device we can lend to the testers? [22:25:49] tfinc: That old iPhone on your desk is iOS 6, right? [22:26:08] likely, i haven't put in in the inventory yet [22:27:43] (03PS1) 10Dbrant: [WIP] hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 [22:27:53] vbamba Deskana: what’s on the docket for design review tonight? [22:28:23] kristenlans: Search! Making sure that everything is estimable. [22:28:31] kristenlans: Should be quick since we all generally agree on the designs. [22:28:35] Deskana: excellent [22:29:19] dbrant: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7865951 - looks like onCatch in EditPreviewFragment also isn't handling api exceptions [22:29:49] Krenair: indeed; will look into [22:30:53] did you guys see my patches to java-mwapi and wikipedia? [22:32:41] kristenlans: trying to join the hangout ... [22:33:03] tfinc: people have been having trouble today... [22:33:13] its stuck at "Trying to join the call. Please wait..." [22:34:06] tfinc: hmmm not sure what to do there. Refresha dn rejoin? [22:34:21] yeah, i've done that a couple of times already [22:34:34] Let’s try the batcvae!!! [22:34:44] https://plus.google.com/hangouts/_/event/c5p2pudvb8s6ckluqf56v791em4 [22:57:58] (03CR) 10BearND: "Would you add some more info about the smarts?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 (owner: 10Dbrant) [22:59:40] (03PS2) 10Jdlrobson: Use desktop login/account creation form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 [23:08:35] (03PS3) 10Jdlrobson: Use desktop login/account creation form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 [23:12:53] (03Restored) 10Bmansurov: Make sure headings with role button also have the heading role [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [23:13:10] (03PS2) 10Bmansurov: Add role 'button' to section heading text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [23:23:23] (03CR) 10RobLa: [C: 04-1] "At a minimum, I think this needs a detailed email to wikitech-l, if not an actual RFC. This is a pretty big change to our model, hence Da" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/162850 (owner: 10Yurik) [23:27:54] Maryana: any suggestions on what to work on next? [23:28:35] bmansurov: hmm.. are you ready for some code review? :) [23:28:49] sure [23:47:43] (03PS5) 10Jhobs: Refactor browser tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 [23:48:49] dr0ptp4kt: ^ should be final unless you run into anything. Took a bit longer because I edited the portal so we wouldn't have any failing/pending tests :) [23:49:09] jhobs: it's painful, i know [23:49:49] dr0ptp4kt: nah it's actually not too bad. Kind of cathartic in a way. What took longest was just rewriting the lua state machine a bit [23:49:52] (03CR) 10Bmansurov: [C: 031] Hygiene: Refactor tests / jshintrc to not use globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165369 (https://bugzilla.wikimedia.org/71714) (owner: 10Jdlrobson)