[00:06:05] (03PS6) 10Jhobs: Redesign Zero info screen [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 [00:06:56] (03PS1) 10Dr0ptp4kt: Try to redirect ineligible zerodot more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165659 [00:07:23] (03CR) 10Jhobs: "Hopefully this should be the one to go through :)" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [00:10:24] (03CR) 10Bmansurov: [C: 031] Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 (owner: 10Jdlrobson) [00:12:29] (03CR) 10Jdlrobson: "TheDj any thoughts on this?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [00:13:42] (03CR) 10Dr0ptp4kt: [C: 032] Refactor browser tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 (owner: 10Jhobs) [00:13:56] (03Merged) 10jenkins-bot: Refactor browser tests [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165524 (owner: 10Jhobs) [00:30:30] (03PS1) 10Jdlrobson: Yet another wikigrok footer tweak [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165664 (https://bugzilla.wikimedia.org/71577) [00:30:46] dbrant|food: mikiwedia, eh? [00:31:15] 3Wikipedia App / 3iOS App: iOS app: Trying to clear saved pages caused a crash - 10https://bugzilla.wikimedia.org/71850 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None 1) Save a single page for offline 2) Go to saved pages 3) Press the rubbish bin icon to delete that 4) Crash! This just happened to M... [00:33:02] (03PS2) 10Dr0ptp4kt: Try to redirect ineligible zerodot more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165659 [00:43:19] Deskana: hey! how did you even find that?? [00:43:26] Deskana: I couldn't pass that up... [00:46:23] (03CR) 10Jdlrobson: [C: 032] Fix overlay height in iOS 8 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165637 (https://bugzilla.wikimedia.org/71725) (owner: 10Bmansurov) [00:46:56] (03Merged) 10jenkins-bot: Fix overlay height in iOS 8 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165637 (https://bugzilla.wikimedia.org/71725) (owner: 10Bmansurov) [00:48:30] kaldari|2: could you merge https://gerrit.wikimedia.org/r/165664 so we make the train? [00:49:25] (03CR) 10Kaldari: [C: 032] Yet another wikigrok footer tweak [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165664 (https://bugzilla.wikimedia.org/71577) (owner: 10Jdlrobson) [00:50:12] (03Merged) 10jenkins-bot: Yet another wikigrok footer tweak [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165664 (https://bugzilla.wikimedia.org/71577) (owner: 10Jdlrobson) [00:50:34] (03PS6) 10Jdlrobson: Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) [00:54:03] (03PS1) 10Mhurd: Fix for occasional crash when clearing saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/165668 [00:54:37] jdlrobson2: I tried to catch you yesterday, but I gave your volunteer account on enwp template editor rights [00:55:18] (03PS1) 10Bmansurov: WIP: Rearrange templates folder so that is is consistent with javascripts and less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165669 (https://bugzilla.wikimedia.org/71523) [00:55:19] hey legoktm yeh i saw. thanks for that. I'm still concerned about the bigger picture here. Things like shared global templates and style tags/shared stylesheets in templates are much needed for this problem to go away [00:56:03] yeah, we need global templates [00:56:06] dbrant: #wikimedia-staff [00:56:07] and global modules [00:56:47] dbrant: Someone mentioned it in there. [00:57:05] Deskana: lol yep, I see [01:02:09] (03PS1) 10Jdlrobson: Show user talk pages in watchlist talk tab [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165670 (https://bugzilla.wikimedia.org/68369) [01:49:43] 3MobileFrontend / 3alpha: problems with footer formatting in WikiGrok dialog B - 10https://bugzilla.wikimedia.org/71577 (10Jon) 5PATC>3RESO/FIX [04:27:43] 3MobileFrontend / 3General/Unknown: In beta labs, tapping into wikitext editor creates empty screen - 10https://bugzilla.wikimedia.org/71725 (10Jon) 5PATC>3RESO/FIX [04:28:37] (03CR) 10Yurik: "one last thing :)" (031 comment) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [04:38:43] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570#c5 (10Jon) Florian personally I'd remove the hidden class in alpha. It seems unnecessary and is wrong anyway ( some articles will have talk pages but no topic page prop value ) [05:24:08] (03CR) 10Florianschmidtwelzow: "Looks awesome! But one thing:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 (owner: 10Jdlrobson) [05:46:10] (03PS1) 10Florianschmidtwelzow: Revert partially: "Show talk button only when JS enabled or talk page not empty" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165694 (https://bugzilla.wikimedia.org/71570) [05:46:44] (03CR) 10jenkins-bot: [V: 04-1] Revert partially: "Show talk button only when JS enabled or talk page not empty" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165694 (https://bugzilla.wikimedia.org/71570) (owner: 10Florianschmidtwelzow) [05:47:27] (03PS1) 10Florianschmidtwelzow: Remove obsolete hidden class from common-js.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165695 [05:50:12] (03PS2) 10Florianschmidtwelzow: Revert partially: "Show talk button only when JS enabled or talk page not empty" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165694 (https://bugzilla.wikimedia.org/71570) [06:15:14] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570#c6 (10Florian) Hmm, i don't know, if this colidates with bug 67819. But it's more important, that a user can see any talk page, if there is one. [07:09:14] (03PS3) 10Yurik: Allow multiple img fonts (one per lang) [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144872 [08:16:24] (03PS1) 10Yurik: Downloaded open source font from http://unifoundry.com/unifont.html [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165699 [08:20:43] (03CR) 10Yurik: [C: 04-2] "I'm trying to solve it with http://unifoundry.com/unifont.html" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/144872 (owner: 10Yurik) [10:42:21] (03CR) 10Phuedx: [C: 04-1] "Nice! This is a good start at moving to mw-ui-icon." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [13:04:27] oh, this one is interesting: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7866782#9331024 [13:04:44] it's the damn handleStopActivity crash again, but this time not on 2.3. [14:53:57] (03PS7) 10Dbrant: [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [14:59:30] (03PS1) 10Esanders: Remove oo-ui toolbar border [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165737 [15:30:48] (03Abandoned) 10Florianschmidtwelzow: WIP: Getting rid of own Login template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165248 (owner: 10Florianschmidtwelzow) [15:31:56] (03CR) 10Florianschmidtwelzow: "MaxSem, can you take a look at this again? I still can't find the reason, why the test fails :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [15:37:32] (03PS5) 10Dbrant: [WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [15:43:41] (03PS6) 10Dbrant: [very WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [15:44:14] (03CR) 10jenkins-bot: [V: 04-1] [very WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 (owner: 10Dbrant) [15:46:18] (03PS7) 10Dbrant: [very WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [15:47:03] (03PS2) 10Dbrant: [WIP] hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 [16:13:35] (03PS3) 10Dbrant: [WIP] hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 [17:01:14] 3Wikipedia App / 3General/Unknown: pressing back from article accessed via nearby does not display nearby list - 10https://bugzilla.wikimedia.org/71567#c3 (10Dmitry Brant) NB: on Android this will be handled by the refactoring (fragment-izing) changes that we're making. https://gerrit.wikimedia.org/r/161935 [17:08:33] (03PS1) 10Jdlrobson: Tools: Ignore WIP patches in `make gerrit` command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165758 [17:10:21] (03CR) 10Jdlrobson: [C: 032] Remove oo-ui toolbar border [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165737 (owner: 10Esanders) [17:10:55] (03Merged) 10jenkins-bot: Remove oo-ui toolbar border [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165737 (owner: 10Esanders) [17:14:44] (03CR) 10Jdlrobson: [C: 032] "WFM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165694 (https://bugzilla.wikimedia.org/71570) (owner: 10Florianschmidtwelzow) [17:15:15] (03Merged) 10jenkins-bot: Revert partially: "Show talk button only when JS enabled or talk page not empty" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165694 (https://bugzilla.wikimedia.org/71570) (owner: 10Florianschmidtwelzow) [17:16:10] (03PS2) 10Jdlrobson: Hygiene: Remove obsolete hidden class from common-js.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165695 (owner: 10Florianschmidtwelzow) [17:16:18] (03CR) 10Jdlrobson: [C: 032] "Thanks Florian!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165695 (owner: 10Florianschmidtwelzow) [17:16:20] (03PS2) 10Bmansurov: Rearrange templates folder so that is is consistent with javascripts and less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165669 (https://bugzilla.wikimedia.org/71523) [17:16:43] 3MobileFrontend / 3General/Unknown: If Javascript is disabled and an article doesn't have a talk page, we shouldn't show the talk page icon - 10https://bugzilla.wikimedia.org/67819#c4 (10Florian) 5RESO/FIX>3REOP Partially reverted in https://gerrit.wikimedia.org/r/165694 We need to think about how we ca... [17:16:51] (03Merged) 10jenkins-bot: Hygiene: Remove obsolete hidden class from common-js.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165695 (owner: 10Florianschmidtwelzow) [17:17:37] (03PS7) 10Jhobs: Redesign Zero info screen [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 [17:20:12] (03CR) 10Jhobs: "I think even if we do end up using some of these strings again the wording will change substantially, thus requiring new translations anyw" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [17:20:14] (03PS1) 10Jdlrobson: Hygiene: Remove unnecessary template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165759 [17:20:26] (03CR) 10Yurik: [C: 032] Redesign Zero info screen [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [17:20:41] (03Merged) 10jenkins-bot: Redesign Zero info screen [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165162 (owner: 10Jhobs) [17:22:18] (03CR) 10Jdlrobson: [C: 032] Rearrange templates folder so that is is consistent with javascripts and less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165669 (https://bugzilla.wikimedia.org/71523) (owner: 10Bmansurov) [17:22:48] (03PS8) 10Jdlrobson: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) [17:22:50] (03Merged) 10jenkins-bot: Rearrange templates folder so that is is consistent with javascripts and less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165669 (https://bugzilla.wikimedia.org/71523) (owner: 10Bmansurov) [17:24:13] (03PS15) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [17:24:35] (03PS8) 10Jdlrobson: Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 (https://bugzilla.wikimedia.org/71715) [17:26:30] 3MobileFrontend / 3Hygiene: Hygiene: Rearrange templates folder so that is is consistent with javascripts and less - 10https://bugzilla.wikimedia.org/71523 (10Jon) 5PATC>3RESO/FIX [17:27:13] 3MobileFrontend / 3stable: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - 10https://bugzilla.wikimedia.org/54885#c18 (10Jon) 5PATC>3NEW What is the status of this bug now? [17:28:43] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570 (10Jon) 5PATC>3RESO/FIX [17:30:28] 3MobileFrontend / 3stable: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - 10https://bugzilla.wikimedia.org/54885#c19 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/gtF11D1B [17:30:43] 3MobileFrontend / 3stable: No placeholders on account creation or login forms in Opera Mini - 10https://bugzilla.wikimedia.org/68758 (10Jon) 5NEW>3ASSI [17:32:35] (03PS4) 10Dbrant: [WIP] hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 [17:33:22] prtksxna: meeting! [17:49:08] (03CR) 10Kaldari: [C: 032] Tools: Ignore WIP patches in `make gerrit` command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165758 (owner: 10Jdlrobson) [17:49:42] (03Merged) 10jenkins-bot: Tools: Ignore WIP patches in `make gerrit` command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165758 (owner: 10Jdlrobson) [17:50:55] jdlrobson2: we seem to have a ton of Make commands defined, but I don't even know what half of them do. Could you add descriptions to them some day when you have time? [17:51:12] kaldari: add a hygiene bug [17:51:24] i want to explore moving to grunt as well [17:52:36] kaldari: adding your face (or whatever that thing is) to a few techy cards in ready for signoff [17:52:55] if you have a minute, poke at em to make sure they're done, plz :) [17:53:21] and when you're back in the office, help fix my vagrant so i can help you more on QA stuffs [17:53:26] Maryana: Sure [17:53:31] 3MobileFrontend / 3General/Unknown: Make commands in MobileFrontend need documentation - 10https://bugzilla.wikimedia.org/71892 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None We have a lot of make commands defined in the Makefile, but I don't know what half of them do. Would be good to add descrip... [17:54:24] (03CR) 10Bmansurov: [C: 031] Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) (owner: 10Jdlrobson) [17:55:29] 3MobileFrontend / 3General/Unknown: Make commands in MobileFrontend need documentation - 10https://bugzilla.wikimedia.org/71892#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/EGQ4R8iF [17:57:24] (03CR) 10Phuedx: [C: 032] Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 (https://bugzilla.wikimedia.org/71715) (owner: 10Jdlrobson) [17:58:28] 3MobileFrontend / 3Uploads: Upload overlay doesn't load. - 10https://bugzilla.wikimedia.org/71715 (10Sam Smith) 5PATC>3RESO/FIX [18:00:14] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570 (10Florian) [18:00:15] 3MobileFrontend / 3General/Unknown: If Javascript is disabled and an article doesn't have a talk page, we shouldn't show the talk page icon - 10https://bugzilla.wikimedia.org/67819 (10Florian) [18:03:57] (03CR) 10Bmansurov: [C: 032] Hygiene: Remove unnecessary template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165759 (owner: 10Jdlrobson) [18:04:30] (03Merged) 10jenkins-bot: Hygiene: Remove unnecessary template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165759 (owner: 10Jdlrobson) [18:08:59] off topic, late night share: does anyone like post-metal or shoegazey metal? [18:09:24] (03PS2) 10Robmoen: Split out content less into features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) [18:09:24] what is that i don't even [18:09:30] phuedx: examples? [18:09:38] funny you should ask [18:10:24] rosetta, of which i am a total fanboy, describe 'emselves as "metal for astronauts" [18:10:48] they're releasing a new album now-ish and this is a track off of it: http://noisey.vice.com/blog/rosetta-soot-stream [18:11:05] i've been listening to it on repeat [18:11:22] MaxSem: ^ [18:11:29] innteresting [18:11:48] (03PS3) 10Jdlrobson: Split out content less into features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) (owner: 10Robmoen) [18:12:03] also: http://en.wikipedia.org/wiki/Post-metal [18:12:08] "metalgaze" [18:12:09] <3 [18:12:33] oof, so many weasel words [18:12:56] (03CR) 10Bmansurov: [C: 04-1] Show user talk pages in watchlist talk tab (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165670 (https://bugzilla.wikimedia.org/68369) (owner: 10Jdlrobson) [18:13:07] * MaxSem listens [18:13:16] * Maryana goes to the list of post-metal bands [18:13:25] i think boris is the only one on this list i've heard of [18:13:27] i am old [18:13:51] * dbrant puts on some Massive Attack, like a normal person :p [18:13:56] :D [18:14:01] Pink Floyd + a quiet death grunt in background.... o_0 [18:14:09] dbrant: <3 massive attack [18:14:24] Maryana: yay! Portishead? [18:14:34] * phuedx would highly recommend *shels, russian circles, cult of luna, pelican, red sparowes, mouth of the architect, isis [18:14:39] yes, i grew up in the 90s [18:14:48] lol of course, same [18:15:09] iirc, the first scrobble was a portishead track [18:15:10] (03PS9) 10Jdlrobson: Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 (https://bugzilla.wikimedia.org/71715) [18:15:13] speaking of, who's coming to eyehategod in oakland with me? :) [18:15:24] nov. 1 [18:15:24] (03CR) 10Jdlrobson: [C: 032] "cherrypicked dependency not needed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 (https://bugzilla.wikimedia.org/71715) (owner: 10Jdlrobson) [18:15:57] Therion, Amon Amarth, Dethklok, Blind Guardian, Gamma Ray, Paradise Lost, Powerwolf, Candlemass, Sabaton [18:16:14] Dethklok! [18:16:16] dethklok is not a real band :-P [18:16:22] it is [18:16:28] it has 3 albums [18:16:29] Powerwolf! [18:16:32] band enough for me [18:16:46] (I liek the name, haven’t listened) [18:16:46] dragonforce! [18:16:53] lulz [18:16:53] are we just shouting things now? :) [18:17:09] standard music discussion [18:17:16] yes. DEATH TO OUR ENEMIES! [18:17:22] what have you done to us, phuedx [18:17:36] infiltrate. destroy. have a cup of coffee. [18:17:42] <3 [18:18:01] (03PS12) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [18:18:08] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [18:18:19] jdlrobson2: sorry about that teeny tiny nitpick :/ [18:18:27] (03CR) 10Jdlrobson: [C: 04-1] "rebase needed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [18:18:35] (03CR) 10Jdlrobson: [C: 04-1] "rebase needed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [18:18:49] i hesitated about pushing the button [18:19:26] Maryana, can go... [18:20:16] kristenlans, https://www.youtube.com/watch?v=BC5VesTbFhg ;P [18:20:44] (03PS2) 10Jdlrobson: Show user talk pages in watchlist talk tab [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165670 (https://bugzilla.wikimedia.org/68369) [18:21:00] * kristenlans turns down her volume before pressing play [18:22:37] Maryana: otoh there's beautiful icelandic minimal techno: https://soundcloud.com/erasedtapes/kiasmos-burnt-edit [18:23:06] (03Merged) 10jenkins-bot: Regression: Fix upload overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164383 (https://bugzilla.wikimedia.org/71715) (owner: 10Jdlrobson) [18:23:22] techno-metal should be a thing [18:23:24] it has to be a thing [18:23:33] "Unfortunately, this video is not available in Germany, beecause it may contain music, for which we can not unify with GEMA." Yeah :D [18:24:13] btw FlorianSW, are you coming to the MW architecture summit? [18:25:17] MaxSem: in 2015? Is there a date/country? :) [18:26:12] USA USA USA [18:26:33] Deskana: yeah, but the USA is big, really BIG! :D [18:26:47] SFO SFO SFO [18:27:02] (03PS1) 10Bmansurov: Set initial keyboard height [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165769 [18:27:27] Deskana: hmm, that's a trip... have you the date? :) [18:27:55] FlorianSW: I think this is it: https://www.mediawiki.org/wiki/MediaWiki_Developer_Summit_2015 [18:29:03] Deskana: aha, thanks But next year i wanted to make a trip to New York, and two trips in the USA :/ [18:29:17] alright dudes, am off for a boulder [18:29:25] AWAY! [18:30:10] (03CR) 10Jdlrobson: [C: 04-1] "Something went wrong with the h1 first heading..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) (owner: 10Robmoen) [18:30:37] thedj: you there? keen to work out what to do about https://gerrit.wikimedia.org/r/148363 [18:31:52] I'm about to try to kick the Finance department out of a room [18:31:56] I predict this will not work [18:32:10] And they will vaguely ask us to go elsewhere [18:32:53] Just so you know... [18:33:35] Deskana: big thanks for this :) i think there will be other chances (i HOPE!) [18:34:13] 3MobileFrontend / 3stable: Audio tags shouldn't have height. Look cramped in mobile. - 10https://bugzilla.wikimedia.org/71365 (10Jon) 5PATC>3RESO/FIX [18:34:40] (03CR) 10Jdlrobson: [C: 032] Set initial keyboard height [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165769 (owner: 10Bmansurov) [18:34:51] (03PS16) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [18:35:00] (03PS4) 10Robmoen: Split out content less into features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) [18:35:17] (03CR) 10Robmoen: "Ooops yeah, I know what went wrong there. I overlooked pre-content h1 needing font-family" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) (owner: 10Robmoen) [18:35:30] And now we're having technical problems. [18:35:31] (03PS17) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [18:35:34] Deskana: 10-4 we’re just chilling [18:35:54] We're going to have to reboot the Mac Mini... [18:36:09] Deskana: get a windows :P [18:36:20] * FlorianSW waits for some shitstorm [18:36:20] :D [18:36:44] FlorianSW: Tell that to IT. ;) [18:37:37] :P [18:39:51] (03PS13) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [18:39:53] (03PS4) 10Jdlrobson: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 [18:39:55] (03PS10) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [18:40:00] (03PS4) 10Jdlrobson: Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 [18:40:27] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [18:40:31] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 (owner: 10Jdlrobson) [18:40:40] brion: Joining the iteration review? [18:40:45] (03CR) 10jenkins-bot: [V: 04-1] Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [18:42:33] (03Merged) 10jenkins-bot: Set initial keyboard height [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165769 (owner: 10Bmansurov) [18:43:06] (03PS14) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [18:43:08] (03PS18) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [18:43:10] (03PS5) 10Jdlrobson: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 [18:43:12] (03PS11) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [18:43:48] (03Abandoned) 10Jdlrobson: Make advanced wikitext that is not content gray [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/157106 (owner: 10Jdlrobson) [18:43:52] http://hatjitsu.wmflabs.org/65550 [18:43:56] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [18:43:59] (03Abandoned) 10Jdlrobson: WIP: Syntax highlight nested html and template code. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/157107 (owner: 10Jdlrobson) [18:44:01] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [18:44:08] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 (owner: 10Jdlrobson) [18:44:23] (03CR) 10jenkins-bot: [V: 04-1] Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [18:44:43] http://hatjitsu.wmflabs.org/65550 [18:46:35] argggh jenkins [18:46:42] (03PS5) 10Robmoen: Split out content less into features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) [18:46:53] splitting out ^ [18:47:08] rmoen: hang on [18:47:11] i found a better way to check [18:47:15] ok [18:47:19] wget 'http://localhost:8080/w/load.php?modules=skins.minerva.content.styles&only=styles&debug=true' -O 1.css [18:47:20] before your patch [18:47:22] wget 'http://localhost:8080/w/load.php?modules=skins.minerva.content.styles&only=styles&debug=true' -O 2.css [18:47:23] after [18:47:27] diff 1.css 2.css > foo.diff [18:47:31] now going through the diff [18:48:15] jdlrobson2: ok cool. I was learning how to make a git patch of my commit then i can then interactively add portions to sep. commits ;) [18:48:25] ohh feel free to do that [18:48:29] that sounds cool and useful [18:48:30] jdlrobson2: which was going to be sorta fun [18:48:34] ;0 [18:48:34] i'm all for granualirtiy [18:49:19] jdlrobson2: yeah i work in chunks like that but sometimes would really like a good way to break it up. This will be useful [18:49:28] rmoen: i guess there's a minor change order might matter [18:49:30] so good to break it up [18:49:37] easier to revert [18:49:46] there's a typo anyway.. :) [18:49:46] @noflisp [18:49:52] @noflisp wooo [18:50:14] lol, ham handed [18:50:20] (03CR) 10Jdlrobson: [C: 04-1] "beware @noflisp !" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) (owner: 10Robmoen) [18:50:21] i blame big fingers [18:50:39] i'll do my clever diffing when it's more granular [18:50:41] should be fun [18:50:59] ok cool [18:56:43] 3MobileFrontend / 3stable: MobileFrontend doesn't remember user choice (mobile/desktop) in some use cases - 10https://bugzilla.wikimedia.org/54885#c20 (10Kelson [Emmanuel Engelhart]) Thank you Jon for your patience. I just failed to give enough time to provide a correct patch here (I'm not so familiar with t... [18:57:12] jdlrobson2: while working on https://gerrit.wikimedia.org/r/#/c/164733/ i saw, that Html::input doesn't have a check for UseMWUIEverywhere, so there is no mw-ui-inline in it, but it should, if i understand this correct? :) [18:57:31] FlorianSW: that's correct [18:57:36] the input css is not loaded [18:57:42] so it's fine for the markup to be like that [18:57:47] as it will not have any effect [18:57:57] the only thing we need to worry about with the global is buttons [18:58:02] as button styles are enabled on all pages [18:58:32] jdlrobson2: ok :) [18:59:03] vbamba: have a few minutes to hangout today? [18:59:54] (03PS5) 10Jdlrobson: Never hit the API when running QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) [19:02:15] 3MobileFrontend / 3Hygiene: Make commands in MobileFrontend need documentation - 10https://bugzilla.wikimedia.org/71892 (10Jon) a:3Jon [19:03:13] 3MobileFrontend / 3stable: Accessibility of headers broken due to accessibility enhancements - 10https://bugzilla.wikimedia.org/68371 (10Jon) [19:03:43] 3MobileFrontend / 3General/Unknown: Accessing Wikipedia.org on (http://en.wikipedia.org/wiki/Vitamin_C) causes screen overlap. - 10https://bugzilla.wikimedia.org/69936 (10Jon) 5UNCO>3RESO/WOR [19:15:36] dbrant: Can do 3pm PST. its a bit of a jammed morning [19:15:39] or tomorrow morning [19:16:08] vbamba: no problem; tomorrow morning, then [19:16:44] 3MobileFrontend / 3Hygiene: Make commands in MobileFrontend need documentation - 10https://bugzilla.wikimedia.org/71892 (10Andre Klapper) [19:35:40] (03Abandoned) 10Robmoen: Split out content less into features [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165421 (https://bugzilla.wikimedia.org/65622) (owner: 10Robmoen) [19:36:32] Heads up, be prepared for commit spam [19:37:03] (03PS1) 10Robmoen: Split out thumbnail content less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165850 [19:37:22] (03PS1) 10Robmoen: Split out full image specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165851 [19:37:34] (03PS1) 10Robmoen: Split out gallery specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165852 [19:37:49] (03PS1) 10Robmoen: Split out link specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 [19:38:17] (03PS1) 10Robmoen: Split out heading specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165854 [19:38:32] (03PS1) 10Robmoen: Split out blockquote specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165855 [19:38:47] (03PS1) 10Robmoen: Split out list specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165856 [19:39:01] (03PS1) 10Robmoen: Split out table specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 [19:39:21] (03PS1) 10Robmoen: Split out text specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165858 [19:40:32] (03CR) 10Bmansurov: [C: 031] Split out blockquote specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165855 (owner: 10Robmoen) [19:40:33] (03PS2) 10Robmoen: Split out full image specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165851 [19:40:51] (03PS2) 10Robmoen: Split out gallery specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165852 [19:40:56] (03PS2) 10Robmoen: Split out link specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 [19:41:00] (03PS2) 10Robmoen: Split out heading specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165854 [19:41:04] (03PS2) 10Robmoen: Split out blockquote specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165855 [19:41:08] (03PS2) 10Robmoen: Split out list specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165856 [19:41:12] (03PS2) 10Robmoen: Split out table specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 [19:41:16] (03PS2) 10Robmoen: Split out text specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165858 [19:41:25] There [19:43:00] rmoen: how did you do that? did you have different branches, and you just submitted them for a review one by one, or is there an easier way? [19:43:22] bmansurov: afaik there is no easy way, i worked on them all locally [19:43:27] then pushed one at a time [19:43:40] rmoen: ok thanks [19:44:11] bmansurov: i started with trying to make a patch from my first chunk commit and splitting it up but proved to be difficult to edit each commit, by doing git add --patch [19:44:27] i see [19:44:38] so i just reset head soft, kept the new files and made a commit for each [19:45:06] cool [19:49:29] 3MobileFrontend / 3General/Unknown: Mobile sites are causing a lot of 404s in production - 10https://bugzilla.wikimedia.org/71571#c2 (10Jon) Any ideas Max? [19:49:33] (03PS3) 10Jdlrobson: Hygiene: Split out text specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165858 (owner: 10Robmoen) [19:50:03] (03PS2) 10Jdlrobson: Hygiene: Split out thumbnail content less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165850 (owner: 10Robmoen) [19:51:44] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out thumbnail content less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165850 (owner: 10Robmoen) [19:52:15] (03Merged) 10jenkins-bot: Hygiene: Split out thumbnail content less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165850 (owner: 10Robmoen) [19:52:19] (03PS3) 10Jdlrobson: Hygiene: Split out full image specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165851 (owner: 10Robmoen) [19:52:21] (03PS4) 10Jdlrobson: Hygiene: Split out full image specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165851 (owner: 10Robmoen) [19:52:52] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out full image specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165851 (owner: 10Robmoen) [19:53:23] (03Merged) 10jenkins-bot: Hygiene: Split out full image specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165851 (owner: 10Robmoen) [19:53:34] (03PS3) 10Jdlrobson: Hygiene: Split out gallery specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165852 (owner: 10Robmoen) [19:53:39] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split out gallery specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165852 (owner: 10Robmoen) [19:53:41] (03PS4) 10Jdlrobson: Hygiene: Split out gallery specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165852 (owner: 10Robmoen) [19:55:26] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out gallery specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165852 (owner: 10Robmoen) [19:55:58] (03Merged) 10jenkins-bot: Hygiene: Split out gallery specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165852 (owner: 10Robmoen) [19:56:16] (03PS3) 10Jdlrobson: Hygiene: Split out link specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 (owner: 10Robmoen) [19:56:20] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split out link specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 (owner: 10Robmoen) [19:56:24] (03PS4) 10Jdlrobson: Hygiene: Split out link specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 (owner: 10Robmoen) [19:59:54] holy code review, batman! [20:00:06] brb foods [20:01:10] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Split out link specific less (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 (owner: 10Robmoen) [20:01:18] (03PS3) 10Jdlrobson: Hygiene: Split out heading specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165854 (owner: 10Robmoen) [20:01:23] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split out heading specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165854 (owner: 10Robmoen) [20:03:31] 3MobileFrontend / 3General/Unknown: Mobile sites are causing a lot of 404s in production - 10https://bugzilla.wikimedia.org/71571 (10Max Semenik) a:3Dario Taraborelli [20:03:39] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out heading specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165854 (owner: 10Robmoen) [20:04:10] (03PS4) 10Jdlrobson: Hygiene: Split out heading specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165854 (owner: 10Robmoen) [20:04:52] (03PS3) 10Jdlrobson: Hygiene: Split out blockquote specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165855 (owner: 10Robmoen) [20:04:55] (03PS4) 10Jdlrobson: Hygiene: Split out blockquote specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165855 (owner: 10Robmoen) [20:04:59] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out blockquote specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165855 (owner: 10Robmoen) [20:05:07] (03PS3) 10Jdlrobson: Hygiene: Split out list specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165856 (owner: 10Robmoen) [20:05:11] (03PS4) 10Jdlrobson: Hygiene: Split out list specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165856 (owner: 10Robmoen) [20:05:59] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Split out list specific less (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165856 (owner: 10Robmoen) [20:06:08] (03PS3) 10Jdlrobson: Hygiene: Split out table specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 (owner: 10Robmoen) [20:06:12] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split out table specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 (owner: 10Robmoen) [20:06:46] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out table specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 (owner: 10Robmoen) [20:06:49] (03PS4) 10Jdlrobson: Hygiene: Split out table specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 (owner: 10Robmoen) [20:07:37] (03PS4) 10Jdlrobson: Hygiene: Split out text specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165858 (owner: 10Robmoen) [20:07:41] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out text specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165858 (owner: 10Robmoen) [20:08:06] (03PS19) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [20:10:44] jdlrobson2, code review MONSTER! [20:10:55] (03PS12) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [20:11:02] (03PS15) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [20:11:07] (03PS6) 10Jdlrobson: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 [20:11:32] (03CR) 10jenkins-bot: [V: 04-1] Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [20:11:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [20:11:46] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 (owner: 10Jdlrobson) [20:12:50] (03PS8) 10Dbrant: [very WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [20:36:11] Deskana: not sure if you are the right person but latest alpha download returns 404 [20:36:33] YuviPanda: ^ [20:36:47] matanya: which URL are you using? [20:37:08] http://tools.wmflabs.org/wikipedia-android-builds/runs/latest/wikipedia.apk [20:37:12] matanya: hmm, to me too. [20:37:14] let me go check [20:40:07] YuviPanda: matanya: sorry, that was probably my change for the Gradle build [20:40:19] I think the file name needs to be changed [20:40:21] bearND: is it putting the wikipedia.apk in a different place? [20:40:24] ah, I see [20:40:50] bearND: no worries, just fix :) [20:40:51] we need to change the sh.cp call to make sure that the name is wikipedia.apk [20:40:52] bearND: yeah, I see that it has the date timestamp in it... [20:41:01] bearND: want me to do it or do you want to do it? [20:41:30] YuviPanda: if you could do it would be great [20:41:45] also commit the change and push it [20:42:09] bearND: yea, will do [20:42:19] YuviPanda: thank you [20:42:22] matanya: in the meantime, you can use wikipedia-2.0-alpha-2014-10-08.apk as the filename.. [20:43:49] YuviPanda: thanks, no rush if i get it tomorrow, it is very late anyway [20:44:39] YuviPanda: you probably also want to rename the current apk file so it works right away [20:44:48] and not have to wait for another build [20:45:04] bearND: yeah, will do [20:47:31] (03CR) 10Robmoen: Hygiene: Split out link specific less (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 (owner: 10Robmoen) [20:48:31] (03PS5) 10Robmoen: Hygiene: Split out list specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165856 [20:49:04] (03PS1) 10Dbrant: Make content horizontally scrollable on a per-section basis. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165870 [20:58:25] maxsem jdlrobson kaldari bmansurov: are you still up for doing some code documentation during hygiene day tomorrow? [20:58:54] kristenlans: yes [21:00:26] (03PS5) 10Robmoen: Hygiene: Split out link specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 [21:02:10] bmansurov: cool. I see ther are laready a few docuemntation cards in flight! :-) [21:02:45] kristenlans: yes, I’m working on one of them, I think Jon on another [21:03:00] (03CR) 10Robmoen: Hygiene: Split out link specific less (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 (owner: 10Robmoen) [21:05:16] bmansurov: awesome, feel free to add more cards as you see fit. [21:07:00] kristenlans: ok [21:07:24] rmoen: you there? [21:07:30] jdlrobson: aye [21:07:30] sorry i didn't explain well on https://gerrit.wikimedia.org/r/#/c/165853/5/less/common.less [21:07:54] basically i was suggesting doing a { text-decoration: none; color: @linkColor; &:visited { color: #5a3696; } ... &.new { [21:07:57] not sticking it in content [21:08:12] i see [21:08:23] i just thought why we were there we might as well tidy it up [21:08:35] jdlrobson: yeah i'll undo my latest [21:08:41] sorry dude! :D [21:08:48] no big whoop [21:08:59] (03PS9) 10Jdlrobson: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) [21:09:02] jdlrobson: what time you in tomorrow ? [21:09:17] jdlrobson: and do you need a lift ? [21:09:33] (03CR) 10jenkins-bot: [V: 04-1] Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [21:09:47] pick up would be awesome but i do arrive at 10:49 p.m. not sure if it's better to meet you somewhere in town [21:09:56] i will be traveling light [21:09:56] Sadly the only uber / lyft in my hood is my pickup :) [21:10:12] i have a truck :) [21:10:26] I'll come snag you up [21:13:29] woo! :D [21:14:27] (03PS6) 10Robmoen: Hygiene: Split out link specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 [21:19:20] (03PS5) 10Robmoen: Hygiene: Split out heading specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165854 [21:19:41] (03PS5) 10Robmoen: Hygiene: Split out blockquote specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165855 [21:19:50] (03PS6) 10Robmoen: Hygiene: Split out list specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165856 [21:20:03] (03PS5) 10Robmoen: Hygiene: Split out table specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 [21:20:11] (03PS5) 10Robmoen: Hygiene: Split out text specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165858 [21:22:13] jdlrobson: how can I use less variables in javascript? [21:24:42] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out link specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 (owner: 10Robmoen) [21:25:12] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out list specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165856 (owner: 10Robmoen) [21:25:20] (03Merged) 10jenkins-bot: Hygiene: Split out link specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165853 (owner: 10Robmoen) [21:25:22] (03Merged) 10jenkins-bot: Hygiene: Split out heading specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165854 (owner: 10Robmoen) [21:25:24] (03Merged) 10jenkins-bot: Hygiene: Split out blockquote specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165855 (owner: 10Robmoen) [21:25:46] (03Merged) 10jenkins-bot: Hygiene: Split out list specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165856 (owner: 10Robmoen) [21:25:48] (03PS10) 10Jdlrobson: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) [21:25:50] (03PS5) 10Jdlrobson: Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 [21:25:55] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split out table specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 (owner: 10Robmoen) [21:25:57] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Split out text specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165858 (owner: 10Robmoen) [21:26:25] (03CR) 10jenkins-bot: [V: 04-1] Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [21:26:33] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 (owner: 10Jdlrobson) [21:29:12] (03PS5) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [21:29:27] hey bmansurov [21:29:41] you can't use less variables in js [21:29:44] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [21:29:57] jdlrobson: ok [21:30:03] look at wgMFDeviceWidthTablet to see how we currently share variables that need to be in js and less [21:30:36] (03CR) 10Jdlrobson: Hygiene: Split out table specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 (owner: 10Robmoen) [21:30:42] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 (owner: 10Robmoen) [21:30:50] jdlrobson: as my last task today :D https://gerrit.wikimedia.org/r/#/c/165144 have you read my comment? I would say, that you can extend templatePartials (so you can add the switcher to EditOverlayBase.js) [21:30:51] (03CR) 10Jdlrobson: [C: 032] Hygiene: Split out table specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 (owner: 10Robmoen) [21:31:00] FlorianSW: looking [21:31:16] FlorianSW: see my commit message [21:31:26] (03Merged) 10jenkins-bot: Hygiene: Split out table specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165857 (owner: 10Robmoen) [21:31:29] (03Merged) 10jenkins-bot: Hygiene: Split out text specific less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165858 (owner: 10Robmoen) [21:31:44] (03PS20) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [21:32:28] 3MobileFrontend / 3Hygiene: Hygiene: common.less and main.less are dumping grounds and need tidying up - 10https://bugzilla.wikimedia.org/65622#c3 (10Jon) 5PATC>3RESO/FIX much nicer [21:32:32] (03PS13) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [21:32:41] where is kaldari today [21:33:03] (03CR) 10jenkins-bot: [V: 04-1] Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [21:33:58] jdlrobson: ehh, i think i have overlook the second part with the close button :/ Sorry for the confusion :) [21:34:16] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570#c9 (10Jon) 5RESO/FIX>3REOP Doesn't actually seem to have fixed it on alpha. [21:34:57] (03Abandoned) 10Jdlrobson: Experimental: Undo button on diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125747 (owner: 10Kaldari) [21:38:17] jdlrobson: he's out getting his grill [21:38:28] Maryana: oohhh yehh [21:38:28] (03PS16) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [21:38:28] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570#c10 (10Florian) (In reply to Jon from comment #9) > on alpha. Because i left the alpha code (see commit message) as an alpha feature, not good? [21:38:30] (03PS6) 10Jdlrobson: WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [21:38:32] (03PS7) 10Jdlrobson: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 [21:38:34] (03PS14) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [21:38:36] (03PS11) 10Jdlrobson: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) [21:38:38] (03PS6) 10Jdlrobson: Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 [21:39:05] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [21:39:10] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw-ui-icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [21:39:12] jdlrobson: so will you & rob be joining from the same hangout for standup tomorrow? :) [21:39:21] Maryana: i'm in office tomo [21:39:25] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 (owner: 10Jdlrobson) [21:39:25] i'm leaving evening [21:39:28] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570#c11 (10Jon) Should remove it. Not sure why it needs to be hidden in alpha. As stated before, that page property value is not always set - especially with Flow pages :) [21:39:32] (03CR) 10jenkins-bot: [V: 04-1] Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [21:39:38] (03CR) 10jenkins-bot: [V: 04-1] Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [21:39:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 (owner: 10Jdlrobson) [21:39:43] aw, i was kind of hoping for 1 screen 2 faces [21:39:47] :) [21:39:50] (03PS12) 10Jdlrobson: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) [21:40:23] (03CR) 10jenkins-bot: [V: 04-1] Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [21:40:30] argg wtf jenkins [21:41:16] (03CR) 10Jdlrobson: [C: 04-1] "this needs a rebase now sadly" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [21:41:17] jdlrobson: you're being punished for 101 characters on one line?! [21:41:23] is that it? [21:41:31] (icons for skins and special pages) [21:41:33] it's qunit mobile [21:41:35] https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/5665/console [21:42:13] waittt my spinner went awol [21:42:19] phuedx: go to sleep :-P [21:42:20] 21:40:12 Exception thrown by mobile.startup [21:42:20] 21:40:12 ResourceLoaderTemplateModule::getTemplateScript: template not found: "spinner.hogan" ResourceLoaderTemplateModule::getTemplateScript: template not found: "spinner.hogan" [21:42:27] what's sleep? [21:42:34] where is it? [21:42:37] jdlrobson: i'm checking in w/james about VE stuffs at 3 - want to join? [21:42:40] how do i get there? [21:43:10] step 1: bed [21:43:14] step 2: ...? [21:43:17] step 3: profit! [21:43:39] jdlrobson: or if you don't want to join, have any issues for me to bring up? [21:43:51] Maryana: i'm completely out of the loop with ve stuff tbh [21:43:57] meee too [21:44:05] that's kinda the point of the checkin, i guess? [21:44:27] shrug [21:44:27] if you think i'll be useful i can be there i guess but that means i need to grab coffee now.. [21:44:43] it's up to you. i know you were asking about some of the bugs.. [21:44:56] so if you want the status update from the source, you should join [21:45:04] if you don't so much care, i can take the meeting hit for you [21:47:34] Maryana: i was more confused with we had bugs under our product [21:47:59] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570#c12 (10Florian) a:3Florian Ok, will do it tomorrow :) [21:48:19] ok, gotcha [21:48:25] don't worry about it then :) [21:50:30] (03PS21) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [21:50:32] (03PS13) 10Jdlrobson: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) [21:50:34] (03PS6) 10Jdlrobson: Never hit the API when running QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) [21:50:49] (03PS15) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [21:50:58] (03PS17) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [21:51:02] (03PS1) 10Bmansurov: Scroll to top of the editor with keyboard keys [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) [21:51:37] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [21:51:40] (03CR) 10jenkins-bot: [V: 04-1] Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [21:51:46] arershashashah [21:51:52] (03CR) 10jenkins-bot: [V: 04-1] Scroll to top of the editor with keyboard keys [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) (owner: 10Bmansurov) [21:54:57] wth has happened [21:55:12] all hell is breaking loose [21:57:45] (03PS2) 10Bmansurov: Scroll to top of the editor with keyboard keys [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) [21:59:34] in dependency hell [22:00:15] (03PS7) 10Jdlrobson: Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) [22:00:37] (03CR) 10Jdlrobson: [C: 04-1] "spinner.hogan isn't added and resources are in a messy state" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [22:01:47] (03PS5) 10Dbrant: [WIP] hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 [22:06:40] (03PS16) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [22:06:54] (03PS18) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [22:07:02] (03PS8) 10Jdlrobson: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 [22:07:08] (03PS7) 10Jdlrobson: Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 [22:07:28] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [22:14:56] kristenlans: oh, did you actually get the testflight invite again? i just noticed it gave me a “already a member” message [22:15:29] kristenlans: if not try this: http://tflig.ht/1dhqz8j [22:16:01] mhurd: I did NOT get it. Will try sign up via the form :-) [22:16:30] kristenlans: ah! gotcha. let me know if you have any issues [22:16:52] thanks mhurd [22:19:19] Oh, I forgot that Kaldari si gettign his new grill today! [22:21:49] Maryana maxsem phuedx rmoen bmansurov: since we miss standup on Monday due to holiday, are you cool to move it to Tuesday? [22:22:00] I’m thinking it might be a good idea, particularly to keep the communication flowing with our new team members [22:22:02] * brion away [22:22:08] * brion not away [22:22:11] kristenlans: fine by me [22:22:11] * brion push wrong button [22:22:14] y not just kill it? [22:22:14] hey guys, feeling more like a human again [22:22:23] brion: \0/ [22:22:26] lol @ brion [22:22:44] kristenlans: sure [22:22:46] * rmoen not laughing at brion anymore [22:22:55] heheheh [22:22:58] [22:23:13] brion: heya! [22:23:38] * brion looks over sprint 42 prios [22:24:15] brion: we fully expect to pull in the additional refactor stuff too [22:24:22] spiff [22:24:26] brion: for now i just estimated with the andoid cards since things seemed roughly same between android [22:24:58] yeah, most of the search stuff sounds about right [22:25:01] brion: let me know if any of the estimates seem off [22:25:02] yay [22:25:03] not super huge individidually [22:25:12] but they combine into an awesome feeature :D [22:25:55] hi dbrant, can I ask you a question about SearchAriclesFragment? [22:26:06] bearND: yep! [22:26:31] (03PS14) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [22:26:55] dbrant: cool. I'm basically trying to understand the concept of the instance variable isSearchActive [22:27:05] (03CR) 10jenkins-bot: [V: 04-1] Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [22:27:54] dbrant: in the implementation of startSearch() I'm not sure why the "&& isSearchActive" part is in "if (Utils.compareStrings(term, lastSearchedText) && isSearchActive)" [22:28:53] bearND: it basically indicates whether the search drop-down panel is currently shown. [22:29:31] bearND: (that is, the search results list, or search network error, etc) [22:29:39] dbrant: ok, I guess if I make this whole thing a dynamic fragment then it seem to be kinda mood [22:30:05] bearND: yes, that's probably right [22:30:27] dbrant: ah, ok then. thanks [22:31:07] bearND: sure; let me know if I can do anything else [22:33:17] bearND: dbrant hey whatever’s serving up the app css seems to have conked out: i now get “Problematic modules: mobile.app.pagestyles.ios:error” in the css file and broken rendering on all pages. is the css android is requesting also broken? [22:33:58] mhurd: curious... checking [22:34:27] mhurd: dbrant: I don't think we download any styles dynamically until 2019 [22:34:33] https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=mobile.app.pagestyles.ios&only=styles&skin=vector [22:34:50] YuviPanda|zzz: dbrant bearND ^ [22:35:10] Deskana: ^ app down! [22:35:28] bearND: mhurd: ahh right, the Android app isn't yet set to download styles from the server. that's why we haven't noticed this. [22:36:30] dbrant: that’s good! new ios app installs are broken until this is fixed… hmm… [22:36:45] assuming something got deployed that broke this? [22:38:29] MaxSem: hey did mobile web have any deployments earlier today? [22:38:50] mhurd: the iOS app doesn't bundle some default styles? [22:39:10] bearND: yes but it updates them if more than 24 hrs have elapsed [22:39:19] kristenlans: late to the party, but we've got a scheduling conflict at 10 on tuesday [22:39:29] me, max, & kaldari are chatting w/wikidata [22:39:38] oh snap! [22:39:50] mhurd: ah, i see. [22:40:01] Maryana: would you know if any mobile web stuff was deployed earlier today? apps css broke :( [22:40:08] eek [22:40:10] lemme check [22:40:18] Maryana: https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=mobile.app.pagestyles.ios&only=styles&skin=vector [22:40:29] this? https://trello.com/c/DuNBaRDB/20-ios-android-mobilefrontend-styles-unconditionally-adding-borders-to-tables [22:40:38] Maryana: Mind if bmansurov jdlrobson phuedx rmoen and I carry on? [22:40:57] kristenlans – yeah, i guess that still leaves half the team :) [22:41:00] we're so big now! [22:41:10] Ginormous! [22:41:22] kristenlans: i lost context ;/ [22:41:34] oh, mvm [22:41:43] heheh sorry rmoen, just talkign about stnadup on Tuesday. It’s on. [22:41:45] Maryana: that’s such a small change… not sure how that would cause the mobile apps css file to now be blank [22:41:54] kristenlans: sounds good [22:42:03] mhurd: yeah, i didn't think that would be it [22:42:30] Maryana: dbrant any ideas how to go about debugging this? [22:42:32] but that's the only thing i can think of that touched css [22:42:52] mhurd: I know very little of that side of things :( [22:42:59] dbrant: same [22:43:37] where'd jon go? [22:44:58] kaldari: apps css is borked – did anything roll out on the train today from us that might've borked it? [22:45:20] Maryana: I'll check [22:45:27] danke [22:48:02] Maryana: it was probably https://gerrit.wikimedia.org/r/#/c/164143/ [22:48:56] ah [22:48:58] thanks [22:49:02] brion, YuviPanda|zzz: ^ [22:49:17] mhurd's on it [22:49:25] cool [22:53:20] mhurd: kaldari: in that case we need to change MobileApp.php in MobileApp extension accordingly. It has paths like ../MobileFrontend/less/common/reset.less [22:53:46] dbrant: kaldari jon’s on it [22:54:40] mhurd: cool. (assuming you meant me, hehe) [22:54:46] ^ [22:54:54] bearND: you too :) [22:57:48] MaxSem: mhurd https://gerrit.wikimedia.org/r/165917 [22:59:45] jdlrobson2: Did the FrontEndStandards meeting happen today? [23:00:26] jdlrobson2: I received the invitation to it while I was asleep and the etherpad is empty [23:02:00] kaldari: would you care to chime in on https://trello.com/c/M7lzCG08/21-bug-66819-allow-end-users-to-view-images-compresses-to-decrease-page-load-times when you have sec.. Couple questions /thoughts [23:02:13] pretty please :) [23:02:22] sure [23:02:34] jdlrobson2: Also, can you come to -operations? SWAT deploy for our reverts [23:02:37] i tried to ping Maryana but she had just left. [23:03:24] kaldari: ty [23:03:29] brb [23:05:24] jdlrobson2: Ah, the invitation I got was for next week. [23:05:38] prtksxna: you missed your lightning deploy [23:05:59] jdlrobson2: Yes the one before right now. Misread timezone stuff :'( [23:06:19] jdlrobson2: MaxSem just +2'd the backports to 1.25wmf2 [23:08:23] dbrant: are you using android studio now? i was wondering if i should "rebuild" my android development setup per the README in the wikipedia for android repo [23:08:54] (03PS19) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [23:09:10] (03PS9) 10Jdlrobson: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 [23:09:18] (03PS8) 10Jdlrobson: Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 [23:09:35] dr0ptp4kt: yep! I've switched to Android Studio, and it works brilliantly with the new Gradle system. [23:09:53] dr0ptp4kt: (that bearND built out) [23:10:01] dbrant, sweet. hopefully i didn't compile anything strange that an rm -rf won't take care of :) [23:10:18] dr0ptp4kt: we're not using the Maven build anymore. I would still keep IntelliJ around for other things. But we're mostly using AndroidStudio for the Android app now. [23:10:35] dr0ptp4kt: when you're using the README you can skip the Maven parts [23:10:44] bearND: cool [23:10:59] dr0ptp4kt: When I get some time I'll update the README to remove references to Maven [23:11:44] (03PS15) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [23:12:19] rmoen: replied on the card [23:12:27] dr0ptp4kt: speaking of that... are you reclaiming responsibility for building the custom APKs for our partners? or shall I do that? [23:13:18] dbrant: i'll do it. if i'm out, then you mind being backup? [23:13:23] dbrant: not like you have a choice [23:13:33] dr0ptp4kt: lol sure, anytime [23:13:43] dbrant: thanks again for doing that while i was out [23:13:49] of course! [23:14:30] (03PS3) 10Brion VIBBER: Support DISPLAYTITLE in article view [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164756 (https://bugzilla.wikimedia.org/63971) (owner: 10Saltymule) [23:14:52] dbrant: bearND showed me a little of the gradle stuff. i'm going to dig into that to understand it better, and also get those other build types into gradle build config files. may need your help when i get to that point. our plan right now is to make the amazon build after the search feature has been deployed out to stable and gone through its paces a bit [23:14:58] ...in case you were wondering [23:15:15] dr0ptp4kt: ok, sounds good [23:15:44] (03PS3) 10Bmansurov: Scroll to top of the editor with keyboard keys [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) [23:17:06] dr0ptp4kt: amazon shouldn't be a problem. I have already added a flavor for it to the Gradle build. So, all you have to do it say ./gradlew -q clean assembleAmazonRelease if you want to try it manually. Or better use the make-release.py --amazon. [23:17:31] bearND: thx! [23:18:18] kaldari: ty [23:18:29] dr0ptp4kt: for others we would either add some more flavors, or I'll hack something together that does the right thing using some variables (so we don't end up with a gazillion of flavors) [23:18:56] dr0ptp4kt: like a custom [23:19:00] flavor [23:20:46] bearND: word. hey, did you follow all of the brew doctor things? i'm updating xquartz, but wasn't sure if the other warning-level things needed addressing. i did add /usr/local/bin to the path as it insructed, knowing full well it may break something else :) [23:21:39] MaxSem: you need to puppet lint it seems on https://gerrit.wikimedia.org/r/#/c/165359/ [23:21:50] jdlrobson2: https://en.wikipedia.org/wiki/Special:Contributions <-- blue button intentional? [23:22:15] legoktm: wasn't intended :-S but equally not the end of the world [23:22:33] agreed, few people are upset though https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Enormous_blue_search_button [23:23:33] legoktm: well this is good feedback. Let me read and send to the mailing list [23:24:14] thanks, I'll leave it in your hands :) [23:24:19] thanks legoktm for letting me know [23:24:26] jdlrobson2: Why did it change though? [23:24:37] prtksxna: I'm not sure i'll take a look [23:25:50] dr0ptp4kt: it's been a while that i ran it. so haven't done the xquartz update yet. [23:27:11] dr0ptp4kt: as long as the brew install android step succeeds and you have an updated brew installation i would stress about it [23:27:17] wouldn't [23:28:11] (03PS1) 10Mhurd: Prevent app from using css if 200 response but error message found. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/165928 [23:29:15] brion: hey couple tiny patches for you :) [23:29:24] woo! [23:30:08] brion: the app css is broken right now, but jon patched it and max is deploying fix [23:30:46] brion: the patch above give extra check to prevent css corruption of this kind in future [23:30:47] :( [23:30:56] :D [23:31:03] brion: thankfully we caught it within a couple hours [23:31:31] brion: ok to aim for doing market build tomorrow? [23:31:44] i think so yeah lemme finish going through patches [23:31:50] weeeee! [23:32:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Looks good, merging. Thanks for the patch!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/164756 (https://bugzilla.wikimedia.org/63971) (owner: 10Saltymule) [23:34:24] jdlrobson2: https://gerrit.wikimedia.org/r/#/c/163775/ [23:34:34] (03CR) 10Brion VIBBER: [C: 032 V: 032] "I wonder if we can make this more robust to different types of stuff.... really this needs a server-side fix to make that not a 200 respon" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/165928 (owner: 10Mhurd) [23:34:49] brion: exactly :) [23:34:54] (03PS2) 10Brion VIBBER: Fix for occasional crash when clearing saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/165668 (owner: 10Mhurd) [23:35:19] are the blue angels doing their thing? i hear some damn loud jets [23:35:26] and i’m like way the hell across town [23:35:41] brion: huh i heard a weird noise a minute ago... [23:35:42] can’t see anything as it’s foggy ;) [23:36:33] brion: Yeah, they are. [23:36:42] They were over San Leandro some time last week. [23:36:44] 10-year old brion is very excited [23:36:56] 35-year old brion is like “why is the government spending money on this? let private industry do air shows” [23:37:22] * brion has become old [23:37:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for occasional crash when clearing saved pages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/165668 (owner: 10Mhurd) [23:38:03] Aaand they're back. [23:38:04] mhurd: ok that looks like all open patches :D [23:38:06] brion: oh wow that was loud [23:38:14] hehe [23:38:17] brion: yay! thanks! [23:38:24] they must be flying across the city or somethin [23:38:33] brion: back to afnetworky stuff :) [23:38:36] \o/ [23:38:54] dbrant: Do we have something like this patch in Android? https://gerrit.wikimedia.org/r/#/c/165928/ [23:39:39] Deskana: checking [23:40:19] dbrant: ^ that patch was a quick hack. as brion said, on the server we should probably not be returning a 200 response type if there was an error [23:40:38] dbrant: If not, we should sneak something like that in. bits is currently serving internal errors which is causing no CSS to display on the iOS app :( [23:40:53] there may be a reason for it, possibly caching purposes…. but it’s damn annoying [23:41:26] The way I see it is that our users are getting a CSS-less experience, so if we have to put quick hacks into the app to prevent that, then so be it! [23:41:33] SERVERS BE DAMNED [23:41:46] damn the torpedoes [23:41:56] CSS IS LIFE [23:41:58] CSS IS HAPPINESS [23:42:00] CSS IS ALMIGHTY [23:42:10] * brion meditates in the CSS Zen Garden [23:42:13] Deskana: mhurd: yep, looks like the Android app would have the same issue. If the server response was 200, it will overwrite the CSS with whatever it gets. [23:42:22] dbrant: quick hack plz [23:42:35] yeah i was wondering for a bit why i was seeing times new roman [23:42:42] brion: haha [23:43:02] just add a light gray background and it’s like the web of 1995 [23:43:05] brion: took me about a half hour to realize it wasn’t my afnetwork stuff [23:43:10] heh [23:44:12] Wikipedia Mobile v1.995 [23:44:48] * brion laughs again at MS skipping Windows 9 due to bad version checks looking for 95 and 98 [23:45:22] dbrant: But yeah, it'd be good if you could sneak in a quick patch to make sure that our users won't get a CSS-less experience if this happens again. :) [23:45:34] * Deskana goes to make a card. [23:46:00] Wow, I can't type. [23:46:11] I just wrote "terusn" instead of "returns" [23:47:21] dbrant: https://trello.com/c/UoYKkXSN/19-do-not-overwrite-app-css-if-the-server-returns-a-200-response-type :) [23:47:45] Deskana: thanks for making the card [23:48:40] mhurd: That's an Android one, let me make an iOS one too. [23:49:41] Done, and... the patch is merged so I just put it right in the done column. [23:49:48] Wow, that was pointless. :D [23:49:59] Deskana: no good to keep track of what we did :) [23:50:15] haha i meant “no, it’s good…" [23:50:21] Yeah, certainly doesn't hurt to take the 20 seconds to make the card. [23:51:27] dbrant: android studio is telling me install build tools revision 20.0.0 despite having set the project to "Use customizable gradle wrapper". comply? [23:51:53] dbrant: Thanks for hopping right on that card. :) [23:51:56] dr0ptp4kt: yep [23:52:07] comply-ing [23:52:35] dbrant: i did set the jdk to the android api level 19, hope that's ok [23:52:50] dbrant: that was a separate error [23:52:57] dr0ptp4kt: yep, that's correct [23:53:13] (03PS7) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [23:53:15] (03PS1) 10Jdlrobson: Hygiene: Introduce Icon.js abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 [23:54:52] dbrant: now of course the ui is giving me a nice notice that tools 23 is available. i'll ignore that for now. the gradle build complained about not having support-v4.20.0.0 and appcompat-v7.20.0.0. should i use the 'install repository and sync project' option for each? [23:55:01] (03CR) 10jenkins-bot: [V: 04-1] Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [23:55:18] dr0ptp4kt: yes, i believe so [23:56:47] (03CR) 10Jdlrobson: [C: 04-1] "* Needs icon library" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [23:57:08] dbrant: after doing the first one - support-v4.20.0.0, no errors [23:58:37] dbrant: Did you say that Google Play Services must be installed on the user's device to receive push notifications? [23:58:56] Deskana: right, only for push notifications