[00:00:59] 3Wikipedia App / 3iOS App: iOS app doesn't support {{DISPLAYTITLE:}} - 10https://bugzilla.wikimedia.org/63971#c3 (10Brion Vibber) 5PATC>3RESO/FIX This has been merged and will appear in the next alpha and the next store release. Thanks Saltymule! [00:02:07] (03PS1) 10Dbrant: Check for "internal error" when fetching styles from server. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165939 [00:02:44] Deskana: ^ [00:02:50] dbrant: Thanks so much. :) [00:08:34] dbrant|brb: i built using the devDebug build, and it runs well on this physical device. yay [00:09:54] dbrant|brb: did we ever reset the 'do not fetch until this date' date on the android app? [00:09:58] or is it still set to 2019? [00:10:47] brion: While you're around, could you give a quick status update on your file system refactoring? [00:10:56] brion: Trying to figure out how much we're carrying over into sprint 42. [00:11:17] Deskana: likely to spill over, but coming along [00:12:10] brion: Is our board an accurate representation of the state of things? [00:12:26] The sprint 41 board, that is. [00:12:45] yep. the three cards are kinda going in parallel :D [00:12:53] eg i’m building unit tests along with the objects [00:13:22] though the file structure should finish earlier [00:15:16] (03PS1) 10Robmoen: Add alpha feature to provide zero like image quality reduction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165941 (https://bugzilla.wikimedia.org/66819) [00:15:52] (03CR) 10jenkins-bot: [V: 04-1] Add alpha feature to provide zero like image quality reduction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165941 (https://bugzilla.wikimedia.org/66819) (owner: 10Robmoen) [00:17:51] (03CR) 10Robmoen: [C: 04-1] "WIP; in backlog" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165941 (https://bugzilla.wikimedia.org/66819) (owner: 10Robmoen) [00:23:43] (03PS1) 10Jhobs: Add reset less file [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165944 [00:25:42] (03PS2) 10Jhobs: Add reset less file [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165944 [00:27:00] (03CR) 10Jhobs: "Guess it added you as reviewer Kaldari since I fetched your original branch. Feel free to review if you want, but you don't have to." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165944 (owner: 10Jhobs) [00:27:43] 3Wikipedia App / 3General/Unknown: iOS & Android: MobileFrontend styles unconditionally adding borders to tables - 10https://bugzilla.wikimedia.org/68579#c6 (10Monte Hurd) Created attachment 16740 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16740&action=edit World War II article table with borders... [00:30:10] (03PS3) 10Dr0ptp4kt: Try to redirect ineligible zerodot more nicely [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165659 [00:30:32] (03PS3) 10Jhobs: Add reset less file [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165944 [00:35:09] (03CR) 10Jhobs: "Yuri: I'd like to get this merged asap. I plan to use the following dev cycle when writing less/css from now on:" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165944 (owner: 10Jhobs) [00:51:58] 3MobileFrontend / 3Hygiene: Documentation: JS Documentation out of date since OOJS move - 10https://bugzilla.wikimedia.org/71250 (10Jon) 5PATC>3RESO/FIX [00:55:13] (03PS1) 10Dr0ptp4kt: Return background and foreground color with message [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165947 [01:16:18] (03CR) 10Jaredzimmerman: "Super cool Rob. Excited to test this out. Do we have any instrumentation in place to see…" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165941 (https://bugzilla.wikimedia.org/66819) (owner: 10Robmoen) [01:42:01] 3Wikipedia App / 3General/Unknown: Set up monitoring for the app's server-side CSS dependencies - 10https://bugzilla.wikimedia.org/71905 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None There was an outage today because the MobileApp extension referred to a file in MobileFrontend which was moved, and h... [01:42:30] 3Wikipedia App / 3General/Unknown: Set up monitoring for the app's server-side CSS dependencies - 10https://bugzilla.wikimedia.org/71905#c1 (10Dan Garry) a:3Yuvi Panda Yuvi said he'd look in to this for us. :-) [01:44:14] 3Wikipedia App / 3MobileApp extension: Set up monitoring for the app's server-side CSS dependencies - 10https://bugzilla.wikimedia.org/71905 (10Dan Garry) [05:15:36] (03PS2) 10BearND: [WIP] Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 [05:15:41] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 (owner: 10BearND) [05:28:27] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 (owner: 10Jdlrobson) [07:06:30] (03PS1) 10Florianschmidtwelzow: Revert "Show talk button only when JS enabled or talk page not empty" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165980 (https://bugzilla.wikimedia.org/71570) [07:25:43] 3MobileFrontend / 3Feature requests: Language menu (of pages) should show variants based on page language instead of site language - 10https://bugzilla.wikimedia.org/66159 (10Jon) [07:26:31] 3MobileFrontend / 3Uploads: Upstream getToken code in MobileFrontend into core - 10https://bugzilla.wikimedia.org/64636 (10Jon) a:5Jon>3None [08:56:46] 3Wikipedia App / 3Android App: the languages list shows the languages in a suboptimal way - 10https://bugzilla.wikimedia.org/66917#c2 (10Trilok Tourani) (In reply to Amir E. Aharoni from comment #0) > 2. The article name is not shown at all. It is shown in the mobile web site > and it's a good feature. I w... [09:45:52] (03CR) 10Phuedx: [C: 032] Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [14:45:13] (03PS18) 10Dbrant: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 [14:46:38] (03PS13) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 [15:02:33] (03PS3) 10Dbrant: [WIP] Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 (owner: 10BearND) [15:06:23] hey bearND! [15:06:33] bearND: I've done the rebasing [15:06:51] (03CR) 10Phuedx: [C: 04-1] "This isn't quite complete:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) (owner: 10Jdlrobson) [15:06:52] dbrant: great! [15:08:05] bearND: so, I think I know how we can do the hiding/showing of the actionbar when scrolling, and I could also do the ActionBarToggle... [15:08:45] dbrant: ok, that would be great [15:09:42] bearND: alright! i'll do another patch (dependent on yours) [15:10:06] dbrant: cool. that's a long chain of dependencies [15:10:57] bearND: yes indeed. but the end is in sight! it's looking pretty good [15:12:29] dbrant: what do you think about having the search action be collapsed by default? That would avoid the issue with the transition of the search EditText between PageViewFragment and SearchFragment [15:12:59] dbrant: then I would just switch to the SearchFragment when one clicks on the search action [15:14:09] bearND: sure, that would make sense. It would even be a bit more consistent with other apps. [15:18:06] dbrant: good. I'll work on that then. Should simplify things. [15:54:20] bearND: in your next patch, would you mind putting back the 48dp spacing in the NavDrawer / WebView / ToC? [15:55:04] bearND: I've got the actionbar hiding working, but it needs the padding back. [15:55:05] dbrant: are you sure you need it in NavDrawer and ToC? [15:55:12] bearND: yep [15:55:14] 3MobileFrontend / 3stable: Toolbox on talk page breaks reading experience, looks strange - 10https://bugzilla.wikimedia.org/71047#c2 (10Bahodir Mansurov) I see there is no special class assigned for toolboxes, the table has the 'infobox' class though. If we hide toolboxes, then we may cause other problems by... [15:55:31] dbrant: ok, then I'll revert those parts [16:09:14] (03CR) 10MaxSem: [C: 04-2] "Note that doing this in PHP would require varying cache by the new cookie and thus an ops review. Blocking until that happened. An alterna" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165941 (https://bugzilla.wikimedia.org/66819) (owner: 10Robmoen) [16:25:30] (03PS1) 10Dbrant: [WIP] Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 [16:27:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 (owner: 10Dbrant) [16:31:26] (03PS1) 10Bmansurov: Make watchstar tooltip visible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166060 (https://bugzilla.wikimedia.org/71711) [16:32:02] (03PS4) 10BearND: [WIP] Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 [16:32:24] dbrant: brought back the extra padding for action bar [16:32:36] bearND: awesome [16:35:13] 3MobileFrontend / 3stable: Toolbox on talk page breaks reading experience, looks strange - 10https://bugzilla.wikimedia.org/71047#c3 (10Jon) I'll take this one. probably best for me to edit their template. [16:44:02] MaxSem: you there? [16:44:28] yup [16:45:05] MaxSem: I’d like to display math forumales in my local environment, but what I see now is just some forumula text, not the rendered formula. how can I fix that? [16:45:33] enable-role math [16:45:41] MaxSem: thanks [16:50:20] (03CR) 10Robmoen: "Yeah this has been moved to the backlog. So I just pushed in what I had for this. No schema changes have been made for determining adopti" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165941 (https://bugzilla.wikimedia.org/66819) (owner: 10Robmoen) [16:55:13] MaxSem: going ot the standup? [16:55:32] yup [16:57:21] MaxSem: it’s about time [16:59:52] (03PS1) 10Jdlrobson: Ensure nomobile always gets applied [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166063 [17:00:30] (03PS2) 10Dbrant: [WIP] Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 [17:00:50] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 (owner: 10Dbrant) [17:09:04] (03PS1) 10Phuedx: Document the commands in the Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166064 (https://bugzilla.wikimedia.org/71892) [17:09:21] (03PS3) 10Dbrant: [WIP] Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 [17:16:43] 3MobileFrontend / 3stable: Toolbox on talk page breaks reading experience, looks strange - 10https://bugzilla.wikimedia.org/71047#c4 (10Jon) 5NEW>3RESO/WOR I have edited the template to be .nomobile element (hidden on mobile) [17:16:57] (03PS20) 10Jdlrobson: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 [17:19:01] (03CR) 10Jdlrobson: [C: 032] "This could be cherry picked. Didn't need dependencies." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [17:19:32] (03Merged) 10jenkins-bot: Hygiene: Cleanup PHP generation of icons for skins and special pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164409 (owner: 10Jdlrobson) [17:19:45] yurikR: I think there may be a bug with the graph extension. The 1px by 1px graph tag we include in the header to make the graphs work is actually rendering at 1px by 22px [17:20:01] jdlrobson: pew pew [17:20:07] mergin' them patches [17:20:08] pew pew pew [17:20:42] jhobs, very likely more than one bug there :) graph will need a lot of work to become a good feature [17:20:55] let me know if you find the reason for it [17:21:20] yurikR: I can get around it via CSS for now, but I just wanted to make you aware of it in case you run across anything that looks suspicious [17:21:22] (03CR) 10Jdlrobson: "Shoot this should be a dependency of https://gerrit.wikimedia.org/r/164141" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) (owner: 10Jdlrobson) [17:21:27] btw, in all reality we shouldn't rely on the 1x1 graph - its a workaround of some other bug [17:21:33] yeah [17:22:44] (03PS22) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [17:22:46] (03PS14) 10Jdlrobson: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) [17:22:48] (03PS7) 10Jdlrobson: Never hit the API when running QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) [17:25:30] (03CR) 10Jdlrobson: [C: 032] Document the commands in the Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166064 (https://bugzilla.wikimedia.org/71892) (owner: 10Phuedx) [17:26:03] (03Merged) 10jenkins-bot: Document the commands in the Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166064 (https://bugzilla.wikimedia.org/71892) (owner: 10Phuedx) [17:27:19] (03CR) 10Jdlrobson: [C: 032] Revert "Show talk button only when JS enabled or talk page not empty" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165980 (https://bugzilla.wikimedia.org/71570) (owner: 10Florianschmidtwelzow) [17:27:23] (03CR) 10jenkins-bot: [V: 04-1] Revert "Show talk button only when JS enabled or talk page not empty" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165980 (https://bugzilla.wikimedia.org/71570) (owner: 10Florianschmidtwelzow) [17:28:11] (03Abandoned) 10Jdlrobson: Add alpha feature to provide zero like image quality reduction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165941 (https://bugzilla.wikimedia.org/66819) (owner: 10Robmoen) [17:29:19] rmoen: If you do any significant LESS refactoring, you'll probably want to let the apps team know about it since they reuse some of our CSS, i.e. especially if you rename or move any existing LESS files. [17:29:25] (03CR) 10Jdlrobson: "Florian are you still waiting on maxsem for this patch?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [17:29:41] (03PS3) 10Jdlrobson: Show user talk pages in watchlist talk tab [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165670 (https://bugzilla.wikimedia.org/68369) [17:29:43] (03CR) 10Kaldari: [C: 032] Ensure nomobile always gets applied [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166063 (owner: 10Jdlrobson) [17:30:07] (03CR) 10Florianschmidtwelzow: "Still waiting :) The test cases should pass with the given data :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/154873 (owner: 10Florianschmidtwelzow) [17:30:18] (03Merged) 10jenkins-bot: Ensure nomobile always gets applied [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166063 (owner: 10Jdlrobson) [17:35:07] mhurd, https://www.youtube.com/watch?v=GbtlPCbhVGw [17:36:51] kaldari|2: ok. Shall I send an email about the latest less refactor? [17:38:47] MaxSem: https://www.youtube.com/watch?v=xemLz_fR1Ac [17:38:57] mhurd: brion: FYI, there are no new translations for the iOS app [17:39:12] bearND: cool thanks! [17:39:12] ok [17:39:17] thanks for checking :D [17:41:02] (03PS1) 10Mhurd: Fix for infobox relocation leaving parent table with empty space. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/166066 [17:41:07] brion: ^ [17:41:23] dbrant: bearND ^ [17:41:49] mhurd: will check out! [17:42:06] INFOBOXEEEEEEEEEEEEEEEEEEES [17:42:11] * Deskana releases his inner Captain Kirk [17:42:13] whee [17:43:01] looks sane enough' [17:43:09] MaxSem: I'm genuinely sat here listening to kpop while you're linking to metal. [17:43:09] though if someone puts a table in a table in a table…. :D [17:43:29] brion: oh hang on a sec i can make it work for that too... [17:43:36] it’s turtles all the way down [17:43:42] hehe [17:43:45] Deskana, glad that I linked you to something better;P [17:46:31] (03PS3) 10Jdlrobson: WIP: Use Desktop Echo overlay code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/153615 [17:49:10] jdlrobson, kaldari|2: to https://lists.wikimedia.org/pipermail/wikitech-l/2014-October/078948.html What do you think about a "Mobile preview" button in the editor, which opens a new tab with a preview of the edited content in mobile view? [17:49:39] (03CR) 10Jdlrobson: [C: 032] Make watchstar tooltip visible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166060 (https://bugzilla.wikimedia.org/71711) (owner: 10Bmansurov) [17:49:49] FlorianSW: in meeting [17:50:10] (03Merged) 10jenkins-bot: Make watchstar tooltip visible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166060 (https://bugzilla.wikimedia.org/71711) (owner: 10Bmansurov) [17:50:15] kaldari|2: k [17:54:43] 3MobileFrontend / 3Hygiene: Consolidate Special:Uploads and Special:UploadWizard code - 10https://bugzilla.wikimedia.org/62638 (10Jon) [17:54:54] (03PS2) 10Mhurd: Fix for infobox relocation leaving parent table with empty space. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/166066 [17:54:57] brion: ^ [17:56:07] dbrant: bearND amended the infobox mover to not just move immediate parent table of infobox, but most distant ancestor table encountered before the lead section div is encountered [17:56:20] mhurd: nice! [17:56:30] VLC guys will be back in town later this month, I’m gonna meet with them oct 23 and talk about possible iOS app integration for audio/video playback \o/ [17:56:36] hopefully we can make it very simple to drop it in [17:56:43] 3MobileFrontend / 3Hygiene: [Tracking] Repurpose MobileFrontend as Minerva skin - 10https://bugzilla.wikimedia.org/69366#c5 (10Jon) This is a better reflection of the long term goal. One day MobileFrontend will just be a skin. Lots to do before we get to that stage though. [17:56:43] brion: ooooh! awesome! [17:57:13] 3MobileFrontend / 3Hygiene: [Tracking] Repurpose MobileFrontend as Minerva skin - 10https://bugzilla.wikimedia.org/69366 (10Jon) [17:57:57] (03CR) 10Jhobs: [C: 031] "Not sure EXACTLY what I'm looking at, but it runs fine on web and syntax looks fine to me, so +1." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165947 (owner: 10Dr0ptp4kt) [17:57:58] 3MobileFrontend / 3Hygiene: [Tracking] Migrate css rules in hacks.less into templates. - 10https://bugzilla.wikimedia.org/64578#c1 (10Jon) This is going to require https://www.mediawiki.org/wiki/Requests_for_comment/Allow_styling_in_templates [17:59:03] 3MobileFrontend / 3Hygiene: [Tracking] Move Nearby code to Geodata extension - 10https://bugzilla.wikimedia.org/64316 (10Jon) [17:59:15] (03PS2) 10Dbrant: Check for "internal error" when fetching styles from server. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165939 [17:59:28] 3MobileFrontend / 3Hygiene: [Tracking] Consolidate code for MediaViewer across desktop and mobile - 10https://bugzilla.wikimedia.org/63504 (10Jon) [18:00:00] (03PS3) 10Dbrant: Check for "internal error" when fetching styles from server. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165939 [18:00:59] 3MobileFrontend / 3stable: Page list item tooltip interferes with watch icon tooltip - 10https://bugzilla.wikimedia.org/71711 (10Jon) 5PATC>3RESO/FIX [18:06:18] (03PS2) 10Florianschmidtwelzow: Revert "Show talk button only when JS enabled or talk page not empty" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165980 (https://bugzilla.wikimedia.org/71570) [18:07:13] 3MobileFrontend / 3Feature requests: Provide toclimit-2 and .toclevel-1 support in tablet table of contents - 10https://bugzilla.wikimedia.org/71726#c6 (10Jon) 5NEW>3RESO/WON After discussing with other MobileFrontend developers we will not be adding classes to support this kind of thing. If you want to... [18:08:28] 3MobileFrontend / 3Hygiene: [Tracking] Consolidate Special:Uploads and Special:UploadWizard code - 10https://bugzilla.wikimedia.org/62638 (10Florian) [18:08:43] 3MobileFrontend / 3Feature requests: Table borders are always shown - 10https://bugzilla.wikimedia.org/37222#c9 (10Jon) I need more feedback on this bug guys. Is there a way we can identify which tables should have borders and which shouldn't? It seems templates should be able to specify their styles using... [18:10:15] ok lemme find that patch again :D [18:11:21] mhurd: should work, lemme fire it up on a few test pages [18:11:27] brion: yay! [18:11:58] 3MobileFrontend / 3Feature requests: Deprecate redlink removal (enable redlinks in stable) - 10https://bugzilla.wikimedia.org/69849 (10Jon) [18:11:58] 3MobileFrontend / 3Feature requests: Link to 'create a new article' if no related Article is found in search - 10https://bugzilla.wikimedia.org/68289#c2 (10Jon) 5UNCO>3NEW The new page workflow is terrible right now and we don't want to encourage new page creation until that is improved (we currently hid... [18:12:53] (03CR) 10Jdlrobson: [C: 032] Revert "Show talk button only when JS enabled or talk page not empty" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165980 (https://bugzilla.wikimedia.org/71570) (owner: 10Florianschmidtwelzow) [18:13:27] (03Merged) 10jenkins-bot: Revert "Show talk button only when JS enabled or talk page not empty" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165980 (https://bugzilla.wikimedia.org/71570) (owner: 10Florianschmidtwelzow) [18:14:20] mhurd: ok what was a page that had the infobox-in-a-table issue? [18:14:40] world war II [18:14:43] 3MobileFrontend / 3Feature requests: Tracking: Watchlist features available on desktop that aren't on mobile yet - 10https://bugzilla.wikimedia.org/56817 (10Jon) [18:14:44] brion: ^ [18:14:52] (03PS1) 10Bmansurov: Wrap math formulas in a scrollable div [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166075 (https://bugzilla.wikimedia.org/66679) [18:15:02] nice, looks good [18:15:12] mhurd: Just FYI, I'm sat on the other side of the 3rd floor, but if you want me for anything then I am interruptible so just come on over. [18:15:20] Deskana: ah cool thanks! [18:15:28] (03CR) 10jenkins-bot: [V: 04-1] Wrap math formulas in a scrollable div [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166075 (https://bugzilla.wikimedia.org/66679) (owner: 10Bmansurov) [18:15:28] 3MobileFrontend / 3Feature requests: [Tracking] Deprecate redlink removal (enable redlinks in stable) - 10https://bugzilla.wikimedia.org/69849 (10Jon) [18:15:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks good, no explode on random articles and does the reparenting correctly on [[World War II]]" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/166066 (owner: 10Mhurd) [18:15:58] (03CR) 10MaxSem: "First, I would attempted to do it with JS only, and get usage stats. Then, asses usage and decide if we want to go into varnishes for that" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165941 (https://bugzilla.wikimedia.org/66819) (owner: 10Robmoen) [18:15:58] brion: woohoo! [18:16:10] ok no other outstanding patches presently [18:16:11] (03PS2) 10Bmansurov: Wrap math formulas in a scrollable div [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166075 (https://bugzilla.wikimedia.org/66679) [18:16:17] mhurd: ready to make an updated testflight build? [18:16:22] brion: ya! [18:16:25] \o/ [18:16:32] ok you do that then i’ll prep the store build :D [18:16:43] 3MobileFrontend / 3alpha: Talk icon doesn't show up for pages with Flow boards in alpha - 10https://bugzilla.wikimedia.org/71570 (10Florian) 5PATC>3RESO/FIX [18:16:49] brion: k [18:17:41] (03CR) 10Florianschmidtwelzow: [C: 04-1] Wrap math formulas in a scrollable div (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166075 (https://bugzilla.wikimedia.org/66679) (owner: 10Bmansurov) [18:24:24] (03CR) 10Jdlrobson: [C: 04-1] Wrap math formulas in a scrollable div (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166075 (https://bugzilla.wikimedia.org/66679) (owner: 10Bmansurov) [18:27:17] kaldari|2: https://trello.com/c/VXC7O1kP/38-spike-investigate-expanding-wikigrok-scope [18:27:29] I'm so hungry. [18:28:38] MaxSem: ping [18:30:45] 3MobileFrontend / 3beta: Can't easily add new section to user talk page - 10https://bugzilla.wikimedia.org/70614 (10Jon) 5NEW>3ASSI a:3Jon [18:34:00] 3MobileFrontend / 3stable: Talk: "Return to "Foo" page." appears on talk page needs design love - 10https://bugzilla.wikimedia.org/71919 (10Jon) 3NEW p:3Unprio s:3normal a:3None It looks odd. We can do better. http://en.m.wikipedia.beta.wmflabs.org/wiki/Talk:Lettuce [18:35:28] 3MobileFrontend / 3stable: Talk: "Return to "Foo" page." appears on talk page needs design love - 10https://bugzilla.wikimedia.org/71919#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/O19j82e7 [18:36:16] brion: i cut the testflight build, but only invited you and me for now. i’m gonna test for a few minutes then fire off the rest of the invites. have minute to check too? [18:48:26] moment [18:48:26] (03PS1) 10Dbrant: Fix for infobox relocation leaving parent table with empty space. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166078 [18:50:09] (03CR) 10jenkins-bot: [V: 04-1] Fix for infobox relocation leaving parent table with empty space. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166078 (owner: 10Dbrant) [18:51:03] (03PS2) 10Dbrant: Fix for infobox relocation leaving parent table with empty space. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166078 [18:51:06] mhurd: looks good on 6/7/8 [18:51:18] poosh it out! [18:53:35] brion: hehe will do! [18:53:36] jdlrobson: should rebasing the qunit change get rid of the api hits i saw? [18:53:37] mhurd: i’m gonna grab a quick lunch then head down to the office for the afternoon [18:53:43] and we’ll prep the store release [18:53:43] brion: k see ya! [18:54:22] Deskana: testflight pushed [18:56:19] w00t [19:00:20] mmmm be back in a bit, just had a small lipro battery catch on fire in my office [19:04:00] ! [19:04:40] (03CR) 10Phuedx: "The rebase got rid of the extraneous HTTP requests. However, I'm now seeing the following error when I run the tests:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) (owner: 10Jdlrobson) [19:04:59] MaxSem: Lemme know as soon as that's in gerrit, so I can move my API code in there as well. [19:05:27] MaxSem: it's currently just on GitHub [19:06:48] (03CR) 10Phuedx: "I'm seeing the same error on master." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) (owner: 10Jdlrobson) [19:07:08] (03CR) 10Phuedx: [C: 032] Never hit the API when running QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) (owner: 10Jdlrobson) [19:08:04] brion: could you recommend an article which uses a different displaytitle? (had to incorporate the displaytitle patch into the aftnetworking refactor and need to test…) [19:08:26] mhurd: ‘iPhone’ for caps and ‘H.M.S. Pinafore’ for italics [19:08:37] brion: woohoo thx! [19:10:44] (03PS1) 10Jdlrobson: WIP: Add add discussion button to talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166079 (https://bugzilla.wikimedia.org/71711) [19:13:30] https://gerrit.wikimedia.org/r/166080 :)))) [19:13:45] 3MobileFrontend / 3alpha: Preferred languages code in alpha broken - 10https://bugzilla.wikimedia.org/71920 (10Jon) 3NEW p:3Unprio s:3normal a:3None In alpha we used to track languages you used, store them and then sort the language overlay based on your commonly used languages. This appears to thro... [19:15:43] 3MobileFrontend / 3alpha: Preferred languages code in alpha broken - 10https://bugzilla.wikimedia.org/71920#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/h973Gdxd [19:19:10] lunch and errands… back before 2 [19:19:30] gonna head off [19:19:33] g'night folks [19:19:37] see y'all on tuesday [19:20:40] sweet dreams phuedx [19:21:08] MaxSem: i'll be dreaming about https://github.com/google/recki-ct [19:24:05] MaxSem: the "Mobile view" link in the footer of the desktop site is always http://, if the page itself is http://, right? Are there any cases, where https:// is used? [19:25:31] hmm [19:25:43] shouldn't be [19:27:15] MaxSem: because of https://www.mediawiki.org/wiki/Thread:Extension_talk:MobileFrontend/%22Mobile_view%22_link_in_footer_is_https,_my_server_doesn%27t_support_that [19:27:23] :/ [19:27:45] ok off to office, see y’all in a whiles [19:51:36] (03PS1) 10Florianschmidtwelzow: WIP/POC: Add mobile preview button to EditPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166089 [20:04:03] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Used as an EXAMPLE for:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166089 (owner: 10Florianschmidtwelzow) [20:15:07] heheheh 4.0.4 version not found ;) [20:17:19] We should codename our builds [20:17:38] Wikipedia Mobile 4.0 (Codename: Bad Request) [20:17:50] Wikipedia Mobile 4.0.1 (Codename: Unauthorised) [20:18:00] Our next release will be codenamed Method Not Allowed. [20:20:21] hehe [20:20:29] having some code signing issues. why am i not surprised? [20:20:31] brion: Deskana: Android app is in the 200 range, hehe ;) [20:20:31] * brion stab stab stab [20:21:22] Haha [20:21:29] Wikipedia v2.0 (Codename: OK) [20:33:24] new provisioning profile didn’t help [20:33:27] what the hell dude [20:40:13] whoa rob's laptop batter exploded?! [20:50:04] ok deleting some old certs and hoping that helps [20:50:13] awjr: he has all the excitement! [21:27:47] bmansurov: have you had a chance to meet andrew otto who's also visiting the office from NY ? [21:29:34] tfinc: i'm ready for checkin whenever you are. Sitting in a coffee shop with decent wifi (hopes) [21:32:46] rmoen: ok [21:34:13] rmoen: hangout added. i really miss the auto add hangout option. they must have disabled it recently [21:35:08] tfinc: here [21:35:59] tfinc: yes, we've met. I think we'll catch up more in NYC co-working space [21:42:50] i’m just going to start twisting random knobs until the code signing works [21:50:31] Maryana: If you wanna make a limn wishlist for bmansurov, I'll work on making a preliminary wikigrok wishlist (which we can fine-tune on Tuesday) [21:50:40] fantastico [21:50:55] getting folks to focus on the 'grok also means less work for you [21:50:59] fewer things to review :) [21:51:27] so maybe you can write some code one day [22:23:15] Maryana: that is, compounding minute-ly, not minutely. don't want to be a cheapskate, y'know [22:23:22] :) [22:24:22] mhurd: yo [22:31:46] (03CR) 10MaxSem: [C: 032] Add boilerplate [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166080 (owner: 10MaxSem) [22:32:32] (03CR) 10MaxSem: [V: 032] Add boilerplate [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166080 (owner: 10MaxSem) [22:33:37] (03PS1) 10MaxSem: WIP: get suggestions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 [22:45:53] Maryana: does MFE have formal sprints with planning/review sessions (and if so, how often)? [22:46:02] yes indeed [22:46:07] 2-week sprints [22:46:17] with a planning session each week [22:46:27] jhobs: ^ [22:48:13] Maryana: do you tend to review during the planning sessions as well, or is review more informal? I'm hoping to start sitting in on either your review or planning sessions so I can keep up to date on what MFE is working on :) [22:48:47] yeah, you should totally sit in on any team meeting [22:49:55] cool, mind throwing me a calendar invite for your sprint planning then? Hopefully it won't conflict with zero [22:50:04] will do [22:50:19] here's the documentation of all our various & sundry meetings: https://www.mediawiki.org/wiki/Mobile_web/Team/Development_cycle [22:57:08] (03PS5) 10BearND: [WIP] Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 [23:00:26] (03PS8) 10Jdlrobson: Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) [23:08:32] (03PS2) 10MaxSem: WIP: get suggestions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 [23:39:53] (03PS6) 10BearND: [WIP] Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 [23:43:46] kaldari|2: do we have someone in the office who can walk me through the wikibase SQL data model? [23:44:33] DarTar: MaxSem might know a little bit. Daniel Kinsler is probably the best person to talk to though. [23:44:40] although he's not in the office obviously [23:44:53] kaldari|2: but he’s going to visit next week? [23:45:01] (Daniel) [23:45:14] or did I get it wrong? [23:45:26] DarTar, the data model is not really SQL. it's just blobs of JSON stored in pages [23:45:54] the amount of information available directly in DB is quite limited [23:45:56] MaxSem: I know, I’m referring to the wb_* tables [23:46:03] but what do you need DarTar? [23:46:57] kaldari|2 and I are discussing how to model a schema for wikigrok and trying to be frugal about what data to store there, assuming we can join log data with data from the wikidatawiki DB [23:47:39] it sounds like unless we parse JSON blobs this is not going to happen [23:48:28] MaxSem: ^