[00:01:22] https://bugzilla.wikimedia.org/show_bug.cgi?id=71938#c2 lol :P [00:03:38] Krenair: There are actually two items for the login item in the NavDrawerFragment, and they are switched out depending on logged in status [00:03:48] yes [00:03:58] / Do login / logout swap [00:04:28] ^ is a comment right before that swap happens inside NavDrawerFragment [00:04:37] I don't understand why I can't hold the username to cause it to be highlighted like the other items though [00:06:00] interesting [00:06:12] I had not noticed that issue before [00:10:44] Krenair: the LinearLayout for nav_item_username doesn't have android:background="@drawable/nav_item_background" set [00:11:01] But I think it's probably on purpose since there is no action associated with it [00:12:18] Yes, but even if I add one... [00:12:40] add that* [00:13:12] Krenair: if you add the background attribute as above then it does the highlighting of the item [00:13:26] doesn't work for me [00:17:23] Krenair: I had that same issue with PACKAGE_NAME but I switched to Gradle and Android Studio so it went away. [00:17:24] Krenair: oh, you also need to add R.id.nav_item_username to the list of actions (ACTION_ITEMS_ALL) in the Java code [00:17:50] just don't do a short click unless you have also a case statment for it in onClick() [00:18:46] did that already, no luck [00:19:00] Deskana: Krenair: BTW: I just checked that it also works in IntelliJ. So, you have the option between AS or IntelliJ [00:19:38] bearND: I thought it would, but since the instructions seemed to prefer the pair of Gradle and Android Studio I figured I'd just switch. :) [00:20:43] bearND, I stuck Log.d("Wikipedia", "Clicked username"); in my onClick case [00:20:52] But don't see that in the console [00:22:57] when I wrote the README entries for Gradle I initially had issues with the automated tests getting recognized by IntelliJ, but that issue has since been solved. If one has the Ultimate edition of IntelliJ it probably makes sense to keep using it, for the non-Java language features. But if I were to chose between the Community edition of IntelliJ and AS I'd probably prefer AS. Just my opinion. [00:24:14] bearND, actually if I stick a log entry in the onActivityCreated method I still don't see anything in the console [00:25:39] Krenair: When you say console you mean the Android tab at the bottom (Cmd-6), right? IF so, what Filter have you selected? And what build variant are you building? [00:25:57] Krenair: Make sure you switch to devDebug in build variants. [00:26:20] Krenair: I added some code but was build alphaDebug and it caused some very, very strange issues. [00:26:43] the logcat box at the bottom [00:26:43] Krenair: One of those issues was that I was adding Log.d() calls and they weren't appearing the log... [00:28:02] I'm looking at the 'debug' log level [00:32:05] Deskana: The alphaDebug build variant should be ok. Even the filer "app: org.wikipedia" should show the entries. At least it works for me. [00:32:40] bearND: Weird. When I was using alphaDebug, changes I was making weren't being reflected in the build. :/ [00:33:01] bearND: For example, I commented out the NearbyAdapter from NearbyActivity and yet it continued to work properly. [00:33:24] And my new activity was somehow showing History entries in its ListView instead of the proper ones. [00:36:13] Deskana: Did you do a clean build after commenting out the NearbyAdapter? You realize that this is its own inner class [00:36:51] Deskana: I don't understand the History entries issue [00:37:09] bearND: Me neither, switching to devDebug fixed the issue and it started displaying the correct entries. [00:37:22] Deskana: Do you mean it showed history entries in the NearbyActivity? [00:37:30] bearND: No, in my new activity. [00:37:47] Deskana: What's the new activity for? [00:37:56] Watchlist! [00:38:46] Deskana: Cool. BTW, please be aware that soon we are getting away from activities and using fragments instead. But hopefully the transition shouldn't be too painful. [00:39:21] bearND: Yeah, I did consider waiting until afterwards and just writing this as a Fragment, but I figured that learning how to rewrite an Activity into a Fragment is a useful thing to learn for me. [00:40:12] I switched it to devDebug and now get this trying to run: [00:40:17] local path: /home/alex/Development/WikipediaAndroid/wikipedia/build/outputs/apk/wikipedia-2.0-dev-2014-10-11.apk [00:40:17] remote path: /data/local/tmp/org.wikipedia [00:40:17] Local path doesn't exist. [00:41:59] Krenair: that's strange. A few things to try are checking if the file really exists. And also to try Build>Clean or Build>Rebuild Project [00:42:25] Why is it looking for yesterday's apk? :/ [00:42:28] wikipedia-2.0-dev-2014-10-12.apk exists, not 2014-10-11 [00:42:54] bearND: I've written my fetch task and it's retrieving the data I want from the API, so I'm now on to trying to massage that into something that I can display. Fun times! :) [00:44:41] Deskana: :) [00:45:26] Krenair: not sure why it's looking for the old file. I might have to change the build.gradle file to not use the time stamp in the apk file name anymore. [00:46:22] It causes old files to stick around :( [00:46:48] But would have to still see how that works with our release process. [00:47:06] It's still looking for yesterday's file. WTF? [00:50:54] Time zone difference? :/ [00:50:59] It's still yesterday here in the US. :P [00:51:32] * Krenair prepares pitchforks in case that's the issue [01:04:54] something I did fixed it :/ [01:08:10] Holy fuck it works. [01:08:21] I've actually got it hooked up to the API and displaying watchlist entries. [01:13:01] nice :) [01:14:13] bearND: Slight process question here... [01:14:41] bearND: Should I commit this? It's pretty useless to the user in the state it's in, but it does actually work in a literal sense. [01:25:26] Deskana: sure, just put a [WIP] at the beginning of the commit message. I also recommend having a separate local branch for it before you commit. So, you could switch back to master and play with newer code changes yourself. [01:25:57] Yeah, I'm already in "watchlist" branch in my local repo. [01:48:38] (03PS1) 10Deskana: [WIP] Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [01:50:33] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [01:51:22] bearND, why do we have ACTION_ITEMS_LOGGED_IN_ONLY/loggedInOnyActionViews at all? [01:51:58] Is it just so we don't give nav_item_username a click listener? [01:58:33] (03PS2) 10Deskana: [WIP] Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [02:11:55] (03CR) 10Alex Monk: "Dbrant?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/151779 (https://bugzilla.wikimedia.org/66732) (owner: 10Dbrant) [02:12:31] 3Wikipedia App / 3Android App: App occasionally closes when too much Activity state is stored. - 10https://bugzilla.wikimedia.org/66732 (10Alex Monk) 5PATC>3ASSI a:3Dmitry Brant [02:15:39] Deskana, shouldn't we have a warning when trying to edit while logged out? :/ [02:16:17] Krenair: We used to, nobody paid any attention to it at all. [02:16:32] see https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7870710 [02:17:24] The issue about being logged out but appearing logged in is a bug that needs fixing for sure. [02:17:47] We've not been able to diagnose it so far. [02:18:54] There is a warning in the edit workflow if you're logged out but it's in the small sprint. [02:19:47] also, I notice trying to edit transcluded sections returns a network error [02:20:10] e.g. on en:User:Krenair (WMF) [02:20:32] Indeed, that's been tricky too because of the way the API deals with them [02:20:58] But article have transcluded sections so rarely that that's not been a big priority [02:24:05] What about the Nearby thing being blank? [02:29:57] I've never experienced that myself, so I'm unsure what to suggest. [02:30:32] I'll rummage around in the device cabinet at work and see if I can find an HTC phone, but even that is still quite vague. [02:39:14] Deskana: what do you think of making the username text on the menu link to their user page then? [02:39:46] Well, there'd be no way for them to create it if it didn't already exist. [02:40:01] And page creation isn't something we can invest time in right now. [02:42:16] I mean, in principle it's a good idea. But it ends up being more work than we can take on. :) [03:03:28] Krenair: I think you are correct. YuviPanda would probably know better. [03:05:41] (03PS7) 10BearND: [WIP] Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 [04:29:31] 3Wikipedia App / 3Android App: NullPointerException at org.wikipedia.beta.createaccount.CreateAccountActivity - 10https://bugzilla.wikimedia.org/67019#c5 (10Alex Monk) Eventually fixed by https://gerrit.wikimedia.org/r/#/c/141717/ which seems to have dealt with https://ticket.wikimedia.org/otrs/index.pl?Acti... [05:25:00] 3Wikipedia App / 3Android App: add "Special:Nearby" feature to app - 10https://bugzilla.wikimedia.org/71949#c2 (10Bernd Sitzmann) Not on Monday since its a holiday here. But most likely Tuesday. [15:25:17] (03PS5) 10Dbrant: [WIP] Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 [18:02:42] aha! [18:02:49] itunes connect is taking my uploads now [18:02:56] now i gotta undo some of the tweaks i did sigh :D [19:07:52] What the fuck. [19:07:54] I just deleted a load of code and yet it's still successfully executing. [19:07:56] Despite not existing anymore. [19:08:51] I think there's something wrong with this build script. :/ [19:09:49] 2.0-dev-2014-10-11 [19:09:52] That's the wrong build. [19:14:10] Deskana, same issue as I ran into? [19:14:19] Krenair: I think so. [19:15:40] Deskana, when did you open the IDE? [19:15:56] Krenair: Except in my case I actually had a build from yesterday somewhere, so it was successfully putting it on my device. [19:16:15] I fixed it by doing Build -> Rebuild Project [19:16:50] Krenair: Hmm, don't know. I think it was this morning but it's possible I had it open overnight. [19:17:54] btw I found https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7864331 - not sure if it's the app or not [19:18:34] Oh, and actually I managed to reproduce the error from yesterday. [19:18:46] The one where the guy said nearby was just sat spinning doing nothing [19:18:54] oh, yeah [19:19:07] I think there's a problem with the exception handling; if you're in airplane mode it does that. [19:19:18] It should be displaying an error instead, but it's not [19:19:23] I'll take a look at that later today [19:19:43] yep, I can reproduce that as well [19:23:57] There's no edit button on the main page? What could possibly go wrong? :P [19:24:09] Krenair: I'll tell Bernd about these issues so he can take a look some time. [19:24:26] Krenair: Since it seems we were just experiencing facets of the same issue. [19:24:33] Krenair: Let me know if that rebuild thing works for you. [19:24:59] Oh, I think I just restarted the IDE and cleaned the project or something. [19:25:02] I got it working in the end. [19:27:53] Off to lunch. [19:30:18] 3Wikipedia App / 3Android App: Enabling airplane mode while switching to edit preview/summary screen causes crash - 10https://bugzilla.wikimedia.org/71986 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None EditPreviewFragment does not catch ApiException, just rethrows these java.lang.RuntimeException: o... [21:21:43] (03PS1) 10Yurik: Fixed file perm on Gemfile per bug 71932 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/166352 [22:18:22] (03PS1) 10MaxSem: Fix file permissions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166356 (https://bugzilla.wikimedia.org/71938) [23:11:22] (03CR) 10Yurik: "I don't object to passing colors to the app per-se, but I think we have a bigger problem here - the message may contain multiple languages" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165947 (owner: 10Dr0ptp4kt)