[00:06:25] Krenair: hello [00:09:49] bearND, I gave up trying to get idea to open the existing wikipedia android project I had, re-cloned the repo and trying to import it now [00:09:56] however, I'm getting this: [00:10:01] Artifact 'de.keyboardsurfer.android.widget:crouton:1.8.4:crouton.aar' not found. [00:11:24] hmm, strange. dbrant had issues with finding version 1.8.3 and moved it to 1.8.4. [00:11:41] Krenair: just to be sure i understand: this is with AS or IDEA? [00:12:08] IDEA on this machine [00:12:42] oh wait. he's moved it to 1.8.5 [00:13:01] Krenair: i was off by one subversion number [00:13:33] Krenair: try to make sure you have the latest repo. If you can't move the version number to 1.8.5 [00:14:06] (and I don't mean svn, hehe) [00:14:50] haha, yeah, I had to read that several times. [00:14:51] (03PS3) 10Alex Monk: Drag some Wikipedia domain stuff into the Site class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/164876 [01:17:36] (03PS8) 10BearND: Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 [01:17:38] (03CR) 10jenkins-bot: [V: 04-1] Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 (owner: 10BearND) [01:18:10] (03CR) 10BearND: Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 (owner: 10BearND) [01:19:13] (03PS19) 10BearND: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [03:10:35] (03PS5) 10Deskana: [WIP] Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [03:17:29] (03PS6) 10Deskana: Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [05:30:29] (03PS1) 10Deskana: Update to new saved pages icon. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166530 [06:49:17] 3Wikipedia App / 3Android App: [Fulltext Search] Submit forces Search Overlay - 10https://bugzilla.wikimedia.org/72015 (10Florian) 3NEW p:3Unprio s:3normal a:3None If you ype something in search bar and pressing the submit key, you will see the search result page, even, if there is an exact match in... [06:50:02] 3Wikipedia App / 3Android App: [Fulltext Search] Keyboard does not dismiss - 10https://bugzilla.wikimedia.org/72016 (10Florian) 3NEW p:3Unprio s:3normal a:3None (OTRS: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7878326) If you type something in the search bar and pres... [06:50:45] 3Wikipedia App / 3Android App: [Fulltext Search] Keyboard does not dismiss - 10https://bugzilla.wikimedia.org/72016#c1 (10Florian) 5NEW>3UNCO should be hidden when press submit ;) (actually this i can not confirm, because i haven't my device here) [06:52:18] 3Wikipedia App / 3Android App: [Fulltext Search] Improve overlay design - 10https://bugzilla.wikimedia.org/72017 (10Florian) 3NEW p:3Unprio s:3enhanc a:3None (OTRS: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7878326) The result overlay for the fulltext search looks no... [06:52:45] 3Wikipedia App / 3Android App: [Fulltext Search] Submit forces Search Overlay - 10https://bugzilla.wikimedia.org/72015 (10Florian) [06:52:45] 3Wikipedia App / 3Android App: [Fulltext Search] Improve overlay design - 10https://bugzilla.wikimedia.org/72017 (10Florian) [06:53:00] 3Wikipedia App / 3Android App: [Fulltext Search] Keyboard does not dismiss - 10https://bugzilla.wikimedia.org/72016 (10Florian) [06:53:00] 3Wikipedia App / 3Android App: [Fulltext Search] Keyboard does not dismiss - 10https://bugzilla.wikimedia.org/72016 (10Florian) [06:53:01] 3Wikipedia App / 3Android App: [Fulltext Search] Submit forces Search Overlay - 10https://bugzilla.wikimedia.org/72015 (10Florian) [10:12:54] (03CR) 10Phuedx: [C: 032] Fix file permissions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166356 (https://bugzilla.wikimedia.org/71938) (owner: 10MaxSem) [10:13:39] (03Merged) 10jenkins-bot: Fix file permissions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166356 (https://bugzilla.wikimedia.org/71938) (owner: 10MaxSem) [11:31:48] 3Wikipedia App / 3Android App: Add option to turn off images - 10https://bugzilla.wikimedia.org/72031 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None Requested by a friend living somewhat out of the city with very poor internet. A simple option to turn off image loading. Would be accomplished by sim... [12:16:51] (03CR) 10Phuedx: [C: 031] Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [13:22:29] (03CR) 10Phuedx: [C: 04-1] "See inline for a minor I missed the first time around." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [14:25:39] (03PS14) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 [14:28:32] (03PS9) 10Dbrant: Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 (owner: 10BearND) [14:29:39] (03PS6) 10Dbrant: [WIP] Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 [14:31:53] (03CR) 10Phuedx: [C: 031] "One template to rule them all…" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [14:32:40] (03PS7) 10Dbrant: Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 [14:47:45] 3Wikipedia App / 3Android App: [Fulltext Search] Keyboard does not dismiss - 10https://bugzilla.wikimedia.org/72016#c2 (10Alex Monk) 5UNCO>3NEW Confirmed. [14:52:53] (03CR) 10Phuedx: [C: 032] Show user talk pages in watchlist talk tab [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165670 (https://bugzilla.wikimedia.org/68369) (owner: 10Jdlrobson) [14:55:44] (03Merged) 10jenkins-bot: Show user talk pages in watchlist talk tab [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165670 (https://bugzilla.wikimedia.org/68369) (owner: 10Jdlrobson) [14:56:15] "one template to rule them all" :P [14:57:32] 3Wikipedia App / 3Android App: Title of [[zh:Wikipedia:简繁一多对应校验表]] shows "false" - 10https://bugzilla.wikimedia.org/72037#c1 (10Andre Klapper) Please post full URLs in the comment: https://zh.wikipedia.org/wiki/Wikipedia:%E7%AE%80%E7%B9%81%E4%B8%80%E5%A4%9A%E5%AF%B9%E5%BA%94%E6%A0%A1%E9%AA%8C%E8%A1%A8 [15:20:08] (03PS1) 10Florianschmidtwelzow: Make sure, loading circle is really visible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 [15:23:58] hey bearND! [15:24:09] hey dbrant! [15:24:58] bearND: the actionbar stuff is looking very good; it's 99% there! When do you think we should have the Great Merging? [15:26:28] dbrant: i think we could do it now. There are a few issues we should fix soon: (1) ToC icon in action bar is invisible when in dark mode; probably other icons (like the W icon) need to be adjusted as well. [15:27:07] (2) I think when in SearchArticleFragment we should show the up arrow instead of the hamburger [15:27:32] (3) Find in Page needs to be converted to a Contextual Action Bar [15:28:38] bearND: alright, I've got a checklist of items to iron out after we merge. I'll add (2) and (3). [15:28:59] dbrant: yes, please share your checklist [15:29:37] dbrant: should we do the prod release first? [15:30:12] bearND: yes, let's. [15:33:10] bearND: https://etherpad.wikimedia.org/p/actionbar_checklist [15:34:07] dbrant: that's a good list [15:34:35] (03CR) 10Florianschmidtwelzow: Make "Read as wiki page" in talk Overlay to footer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166197 (owner: 10Florianschmidtwelzow) [15:35:25] dbrant: Have you seen any critical issues from the latest beta? [15:36:46] I used it a bit over the weekend and it seems fine to me. [15:36:58] bearND: nope... there was only one crash (if i'm not mistaken) for the latest beta, and it was reported by Krenair, having to do with not catching ApiException when fetching the edit preview. [15:37:14] bearND: I have a patch for it [15:45:22] dbrant: do you want to use the same code for prod as for the latest beta? [15:46:59] bearND: yes, although... would you have an issue with cherrypicking that patch on top of it? [15:48:51] dbrant: Then we could just use the latest from master. The only other changes are a small string change and the empty page treatment for nearby. [15:49:31] bearND: alright then, I'm all for that. [15:50:03] If that's the case I'll do another TWN import. We can do both beta and prod releases. [15:51:04] bearND: sure! [15:55:32] (03CR) 10Phuedx: [C: 04-1] "Minor comment issue inline." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 (owner: 10Jdlrobson) [15:58:19] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166586 [15:59:46] 3MobileFrontend / 3stable: Talk pages difficult to follow in mobile watch list - 10https://bugzilla.wikimedia.org/68369 (10Jon) 5PATC>3RESO/FIX [16:01:42] gonna make a cup of tea [16:03:48] bearND: so now, when I refresh the Gradle build, it modifies the stuff in the gradle wrapper folder... are we supposed to commit those updates? [16:04:21] dbrant: hmm, that's strange [16:04:40] dbrant: what are the changes. I haven't seen any on my end yet [16:06:44] (03CR) 10BearND: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166586 (owner: 10BearND) [16:06:48] bearND: binary differences in the gradle-wrapper.jar file, and in the .properties file the "distributionUrl" changed to "https" instead of "http" [16:07:00] (03Merged) 10jenkins-bot: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166586 (owner: 10BearND) [16:07:44] dbrant: does it still point to gradle-1.12? [16:07:58] dbrant: and do you still have AS 0.8.9? [16:08:10] bearND: yes, and it does. [16:09:00] bearND: maybe it's a Windows thing :( there's no difference on my Macbook. [16:09:18] dbrant: could be [16:09:39] dbrant: then I wouldn't check it in [16:10:00] dbrant: you do all releases from your Mac, right? [16:10:10] bearND: yep, definitely [16:10:18] dbrant: ok, good [16:11:32] dbrant: For the store we should have some blurp about the new location permissions. That we use them for the nearby feature only. [16:11:41] Deskana: ^ [16:13:09] * Deskana thinks. [16:13:29] Deskana: Would you mind drafting something to add to the store description about permissions used? [16:13:37] Sure. [16:13:44] Let's also make it the top item in the "What's New" for the APK. [16:14:03] Deskana: sure (cc dbrant) [16:14:11] yep [16:15:30] dbrant: would you like me to do the beta and prod releases, or would you like to do them yourself? [16:16:18] I have to think about a way of doing this that doesn't make it sound more scary than it is [16:16:28] dbrant: oh wait, we still need to merge your patch [16:16:41] bearND: right; just this: https://gerrit.wikimedia.org/r/166366 [16:16:56] (03PS2) 10BearND: Catch ApiException in Edit preview task. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166366 (https://bugzilla.wikimedia.org/71986) (owner: 10Dbrant) [16:20:18] bearND: how about you -> beta, me -> prod ? [16:20:41] dbrant: sounds good [16:20:53] (03CR) 10BearND: [C: 032] Catch ApiException in Edit preview task. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166366 (https://bugzilla.wikimedia.org/71986) (owner: 10Dbrant) [16:21:10] (03Merged) 10jenkins-bot: Catch ApiException in Edit preview task. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166366 (https://bugzilla.wikimedia.org/71986) (owner: 10Dbrant) [16:22:06] dbrant: lol, when I verified this ^ I was wondering for a second why the W0 crouton appears over the action bar. Then I realized that we haven't merged the action bar stuff. So used to seeing the action bar changes. [16:22:27] ha!! [16:23:22] I'm not going to put anything in the description about location services. [16:23:26] Honestly I was only making it worse. [16:23:40] I was either saying something so weak that it sounded creepy, or saying something so strong that I'd have to get legal to check whether it's right or not :/ [16:24:05] In particular, we are actually storing their location because we store all API requests [16:24:11] So I can't say "We don't keep it" [16:24:37] Deskana: but only when one uses the Nearby feature, not anywhere else [16:24:39] And I also can't guarantee that the data won't be used by other people in the WMF in line with the privacy policy, so I couldn't promise that either [16:25:09] Right, so we can put that in the What's New [16:25:24] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166595 [16:25:45] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166595 (owner: 10BearND) [16:26:02] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166595 (owner: 10BearND) [16:26:44] mmmm tea [16:28:15] bearND, dbrant: Sent you both emails with the copy. Gotta dash, see you at the standup! [16:45:32] 3MobileFrontend / 3General/Unknown: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71938 (10Max Semenik) 5PATC>3RESO/FIX [16:54:59] sorry MaxSem, i forgot to update the bug [17:01:01] 3MobileFrontend / 3General/Unknown: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71938 (10Sam Reed (reedy)) [17:03:10] dbrant: beta is puslished [17:03:14] published [17:03:43] bearND: \o/ building/testing prod now... [17:04:42] (03PS2) 10Reedy: Fixed file perm on Gemfile [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/166352 (https://bugzilla.wikimedia.org/71932) (owner: 10Yurik) [17:04:47] (03PS3) 10Reedy: Fixed file perm on Gemfile [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/166352 (https://bugzilla.wikimedia.org/71932) (owner: 10Yurik) [17:04:52] (03CR) 10Reedy: [C: 032] Fixed file perm on Gemfile [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/166352 (https://bugzilla.wikimedia.org/71932) (owner: 10Yurik) [17:05:12] (03Merged) 10jenkins-bot: Fixed file perm on Gemfile [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/166352 (https://bugzilla.wikimedia.org/71932) (owner: 10Yurik) [17:08:22] dbrant: reviewing the first two fragment patches [17:10:14] aw man i thought i could push the accep agreement button [17:10:22] but it was on a different account :D [17:10:42] * brion somehow created an extra publisher account at some point and has no idea how to delete it [17:17:11] bearND yuvipanda|BRB stnading [17:17:24] Krenair: coming [17:17:29] kristenlans: ^ [17:22:00] 3MobileFrontend / 3Feature requests: Add 'more' button at end of watch list, to look further in history - 10https://bugzilla.wikimedia.org/68368#c8 (10Bahodir Mansurov) *** Bug 71961 has been marked as a duplicate of this bug. *** [17:22:00] 3MobileFrontend / 3stable: only top 50 articles on my watchlist show page images - 10https://bugzilla.wikimedia.org/71961#c2 (10Bahodir Mansurov) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68368 *** [17:26:04] dr0ptp4kt: reconfirming because of the confusion between calendar invites and emails; Standup has been moved to the weekly review meeting, correct? [17:27:00] jhobs: yeah. i'll cancel the 1330 eastern / 1030 i sent earlier [17:28:00] 3Wikipedia App / 3Android App: Enabling airplane mode while switching to edit preview/summary screen causes crash - 10https://bugzilla.wikimedia.org/71986 (10Alex Monk) 5PATC>3RESO/FIX [17:33:58] tfinc: Is that iPhone 4S in your bag? [17:34:00] tfinc: Andy will be here in an hour and I'd like to give it to him, but I don't want to root through your bag. :) [17:34:19] kaldari, MaxSem: can we check in some time today on WikiGrok data model werk? I had a good conversation with ori on Friday on the limits of EL for capturing hierarchical data for version B and I also have some privacy-related concerns that halfak brought up that I’d like to review quickly with you guys [17:34:43] sure [17:34:57] I'm in a meeting with WD floks btw:) [17:35:16] 3MobileFrontend / 3stable: only top 50 articles on my watchlist show page images - 10https://bugzilla.wikimedia.org/71961#c3 (10Jon) 5RESO/DUP>3REOP Not the same bug. We purposely only load 50 page images on the watchlist A-Z for performance reasons but we should probably explore loading them with JS. Th... [17:35:48] kaldari, MaxSem: 30 minutes at 1pm seems to work for everybody, I’ll send you an invite [17:36:20] actually, 1.30 works best [17:39:10] (03PS15) 10Jdlrobson: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) [17:39:12] (03CR) 10Jdlrobson: Remove all the ajax related things. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [17:40:24] (03CR) 10Jdlrobson: Hygiene: Page list thumbnails are not icons (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 (owner: 10Jdlrobson) [17:40:30] (03PS10) 10Jdlrobson: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 [17:40:36] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 (owner: 10Jdlrobson) [17:40:41] (03PS11) 10Jdlrobson: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 [17:45:12] bearND: There's something... very strange going on with my Gradle builds. [17:45:17] bearND: Sometimes it just puts the wrong APK on my device. [17:45:44] kristenlans: sorry, I missed it by a few minutes (was in a damn tunnel...) I emailed in [17:46:23] Deskana: Krenair had the same issue a couple of days ago. And I've run into it myself as well. I have any idea how to fix it. [17:46:35] bearND: I can fix this by selecting "Rebuild Project" then building again. [17:46:35] No worries yuvipanda, sw your email [17:46:40] Deskana: I'm goin got not use the time stamp in the file name of the apk anymore [17:46:42] bearND: So there's that workaround, at least. [17:46:49] any idea -> an idea, bearND ? [17:47:09] that sounds like a workaround rather than a fix [17:47:28] (03CR) 10Jdlrobson: [C: 04-1] Make "Read as wiki page" in talk Overlay to footer (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166197 (owner: 10Florianschmidtwelzow) [17:47:30] Krenair: yes, thanks for the correction. My typing is terrible today [17:48:18] Krenair: Well, as long as the apk file name doesn't change anymore that problem should not happen [17:49:02] yes but it sounds like there's a deeper problem [17:49:14] and you're just avoiding it rather than fixing it [17:49:40] (03CR) 10Jdlrobson: [C: 04-1] Make sure, loading circle is really visible (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 (owner: 10Florianschmidtwelzow) [17:50:08] (03PS9) 10Jdlrobson: Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) [17:50:41] Krenair: ok, workaround it is then [17:54:59] mhurd: Do you have a few moments at 11:30? Andy from Specialists Guild will be here and he's having a few issues with TestFlight. [17:55:25] Deskana: sure! [17:55:32] Deskana: just ping me [17:55:43] mhurd: Will do. Just giving you advance notice. ;) [17:55:53] Deskana: cool thanks! [17:59:08] dbrant: So when you've got your Grand Merging completed and everthing is fragmentised, I'll rebase my watchlist work and turn it in to a fragment instead, then it can be reviewed. [17:59:22] Deskana: yep, sounds good [17:59:58] (03CR) 10Deskana: [C: 04-2] "Waiting until everything is fragmentised. Once that's done, I'll rebase this onto master and fragmentise it, and it can be reviewed then." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [18:04:45] 3MobileFrontend / 3General/Unknown: User's password in response html - 10https://bugzilla.wikimedia.org/70009#c8 (10Jon) Good catch. That's nasty. [18:10:58] hey bmansurov how was your long weekend? [18:11:15] jdlrobson2: not bad [18:14:01] (03Abandoned) 10Dr0ptp4kt: Update app description. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/150088 (owner: 10Dr0ptp4kt) [18:14:17] ... [18:14:18] Inbofox. [18:14:25] What a typo. [18:18:53] Maryana: what's that bug number? [18:19:03] kaldari: https://bugzilla.wikimedia.org/show_bug.cgi?id=52385 [18:22:35] (03CR) 10Bmansurov: [C: 031] Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [18:25:54] (03PS1) 10Jhobs: Add tests for home page [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/166616 [18:25:56] (03CR) 10Dr0ptp4kt: "Let's discuss this afternoon for the different use cases for apps versus browser user agents." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165947 (owner: 10Dr0ptp4kt) [18:27:06] Deskana: bearND|food: production build released :-O [18:27:34] "what's new" description = exactly 500/500 characters! [18:28:51] dbrant: exciting! [18:28:58] dbrant: efficiency! [18:29:11] dbrant: \O/ [18:29:41] dbrant: bearND|food congrats! :) [18:30:26] Deskana: are you meeting andy? [18:31:06] mhurd: I'd assumed he'd be brought up, but I guess I should go down. [18:31:14] MaxSem: hey time for quick api question? [18:31:17] mhurd: I'll go check. [18:32:45] dbrant: just joining our meeting [18:32:51] need a minute [18:33:02] vbamba: np [18:36:42] i'm having some trouble joining hangouts [18:52:31] dbrant: I think this might b working [18:52:37] can you try joining the hangout now [19:02:17] dbrant: w00t for new prod release! [19:09:08] mhurd: https://en.wikipedia.org/wiki/SMART_criteria [19:34:47] congrats on pushing the new Android release. [19:34:56] thx! [19:34:58] I've been enjoying the nearby feature on Beta lately. [19:35:14] the one thing I really wish it had was a map mode, now that I've actually had some experience using it. [19:35:29] on the roadmap ;) [19:35:36] I figured. :) [19:36:28] since I the first *real holiday* in forever yesterday (no work AND kids still in school), I went on a nice photo ride. [19:36:37] kaldari: as you might have suspected, there was an error running our new edits-monthly-new-active SQL, I'm looking into it now [19:37:12] I had to switch back and forth between the Beta and the Unvisited app (and Google Maps) [19:37:42] i see! [19:37:44] I was also realizing yesterday that there aren't any good Wikipedia article overlays for online maps, anymore. I couldn't find out how to make that happen on OSM, and Google apparently disabled theirs. [19:38:28] milimetric: Thanks! [19:39:12] dbrant: btw, I wonder if we could add a maps link into the nearby view. geo:// is supported, I think... [19:39:25] so tapping that would open up in google maps [19:39:41] YuviPanda: that would be super handy. [19:39:49] YuviPanda: indeed; mhurd mentioned that they're doing it on long-press in iOS. [19:40:04] it's standard as well, https://en.wikipedia.org/wiki/Geo_URI so yay [19:40:07] There was no way I could find in either Unvisited or Wikipedia Beta that could pass the coordinates on to another app. [19:40:48] we could do that in long press as well... [19:41:30] YuviPanda: yep, could be an 'easy' card/bug... [19:41:46] and maybe add a GEO icon of some sort to articles (maybe in the TOC drawer) so you can tap to open the geo URI? [19:42:35] yeah, congrats on the new release guys [19:42:37] it would be frustrating if you could *only* get to a map from Nearby articles. [19:43:28] dbrant, gerrit kept your -1 on https://gerrit.wikimedia.org/r/#/c/164876/ :/ [19:43:37] Btw there were some more issues I was planning to report - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7839091 shows some code only catching UnknownHostException [19:43:37] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7850307 - involved code rethrows ApiException [19:44:37] Krenair: hmm, curious [19:45:00] can't remember when it does/doesn't do that [19:45:15] MaxSem: in what situation does the api return 'abusefilter'? [19:45:27] Krenair: will look into; thanks! [19:45:40] when edit triggers AbuseFilter [19:45:44] Presumably when an edit hits an abusefilter? [19:46:08] MaxSem: I want to reproduce the issue to see how this looks, is there a way to make the backend return abusefilter? [19:46:18] phuedx: any issues with me cherry picking and merging https://gerrit.wikimedia.org/r/#/c/165345/7 ? [19:46:22] i don't like patches just sitting around [19:46:34] bmansurov, install abusefilter on your wiki, create one to match an edit, make the edit? [19:46:35] it needs https://gerrit.wikimedia.org/r/#/c/164141/14 for the bug to be complete mind you [19:46:41] install it, create a rule that blocks your edit [19:47:00] i'm just a little fed up of rebasing :) [19:47:05] Krenair and MaxSem thanks [19:48:30] kaldari: let me know if you want me to make this change, but I described the problem here: https://github.com/wikimedia/analytics-limn-mobile-data/commit/9751c27713269fdb0ef7f51f71249dc009666c69 [19:48:46] (see my note after line 39) [19:50:00] milimetric: ah, thanks. I'll make a patch. [20:19:02] 3MobileFrontend / 3Hygiene: abuse filter action button does not conform to the styleguide - 10https://bugzilla.wikimedia.org/72049 (10Bahodir Mansurov) 3NEW p:3Unprio s:3normal a:3Jon Created attachment 16764 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16764&action=edit got it button doesn... [20:25:02] (03PS1) 10Yuvipanda: Nearby: Open an intent with geo:// URL if item is long pressed [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166636 [20:25:06] dbrant|brb: bearND|food ragesoss ^ [20:25:15] however, with gradle the app refuses to build for me on IntelliJ... [20:26:33] YuviPanda: i'll take a look at it [20:26:46] bearND: thanks! [20:28:12] bearND: note that I haven't actually tested it, because of build failing [20:28:25] YuviPanda: ok [20:28:27] now I have 'could not resolve all dependencies' [20:28:50] YuviPanda: which dependencies does it have issues with? [20:28:52] bearND: and maven install fails because it can't fine PACKAGE_NAME in BuildConfig [20:29:18] Did you update your Android SDK as mentioned in the README.mediawiki? [20:29:30] ah, that's probably it :) [20:29:38] YuviPanda: android update sdk -u --filter "tools,platform-tools,build-tools-20.0.0,android-19,extra-android-m2repository" [20:29:51] yeah running that now [20:29:55] YuviPanda: if you run this it should do the update for you [20:30:04] heh, I am fairly rusty... [20:31:36] mhurd: online? hmm [20:31:48] no hangout link on that meeting [20:38:04] YuviPanda: does it work after the update? [20:49:32] 3MobileFrontend / 3stable: abuse filter action button does not conform to the styleguide - 10https://bugzilla.wikimedia.org/72049#c1 (10Jon) a:5Jon>3None Sounds like a styling regression to me. [20:49:32] Maryana: I’ll need your input on some schema decisions, can I grab you at the end of the day? [20:49:42] sure [20:49:57] (this is after talking to kaldari and MaxSem about pros and cons of EL vs a MW table) [20:49:59] i'm hoping to be done with my p.m. chunk of meetings around 5 [20:50:05] bearND|brb: nope, still at ' > Could not resolve com.android.support:appcompat-v7:20.0.0.' [20:50:06] ok good [20:50:30] 3MobileFrontend / 3stable: abuse filter action button does not conform to the styleguide - 10https://bugzilla.wikimedia.org/72049#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/VdpFmjSA [20:54:10] MaxSem: kaldari ping. dartar tells me WikiGrok is writing to a customdb in labsdb from prod. Just wanted to poke and make sure you let ops/sean know before you do that [20:54:51] YuviPanda: I've told Robh in ops, but haven't advertised it further. [20:55:03] YuviPanda: can you try to refresh your gradle cache (http://stackoverflow.com/questions/13565082/how-can-i-force-gradle-to-redownload-dependencies)? [20:55:06] kaldari: an email to ops@ would probably be nice and prevent future surprises. [20:55:11] What. [20:55:19] YuviPanda: will do. [20:55:47] kaldari: thanks. I'm personally not sure that's the best idea, since labsdb is tuned very differently than prod ones, but sean / others would know better. [20:55:55] kaldari: I was asking if that could be a 3rd option on the table among those that we were considering (pure EL vs mixed EL + prod table) [20:56:25] but I’m fine abusing EL if that’s the only way to store this data :) [20:57:35] YuviPanda: It'll be getting like 5 hits a day for the time being, so not something we need to worry about as far as scalability. Obviously once it's no longer a prototype we won't be using a labs db. [20:58:16] jdlrobson: in answer to your earlier question: go for it [20:58:31] (after the meetin's, obvs) [20:58:32] kaldari: true, but still. Do email ops@ :) [20:59:05] DarTar: I assume the labs db wouldn't be robust enough to be a 3rd option, but I could ask some ops people for their opinion if you think it's worth investigating. [21:00:09] kaldari: yes, I’m basically thinking: what if we continued along the same lines as the current approach but save MaxSem some headaches about prod tables [21:00:19] I guess asking wouldn’t hurt [21:00:29] but I’ll come up with a pure EL proposal to see what it looks like [21:00:33] bearND: cleared local cache, redownloading the internet now... [21:01:44] bearND: still the same missing dependency :( [21:04:24] https://etherpad.wikimedia.org/p/MobileWeb-Retrospective [21:04:44] YuviPanda: wanna try commandline? ./gradlew clean assembleDevDebug [21:05:20] bearND: yeah, I was trying ./gradlew build... [21:05:28] bearND: and same error... [21:06:00] hmm [21:12:00] milimetric: how long should it take after that fix was merged before the data file is actually generated? Does that happen once a day? once an hour? [21:12:29] kaldari: I've been looking at it on and off, and I don't see it [21:12:39] it should get updated by puppet and re-run every 30 minutes [21:13:20] ooh - the log got stuff appended, one sec [21:17:15] YuviPanda: the com.android.support:appcompat-v7:20.0.0 aar file should come from your Android SDK installation (the extra-android-m2repository) [21:17:40] bearND: yeah, that installed fine... [21:18:02] YuviPanda: do you see the aar file? Is ANDROID_HOME set? [21:18:19] #wikimedia-research [21:18:34] bearND: ANDROID_HOME is set, let me find the aar [21:20:44] Krenair: bearND: lol that was fast: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=7880235 [21:21:19] sigh. [21:21:26] YuviPanda: should be in $ANDROID_HOME/extras/android/m2repository/com/android/support/appcompat-v7/20.0. [21:21:38] 0 [21:21:57] bearND: hmm, I've v19 but not 20 [21:22:02] I ran the command, hmm [21:22:06] let me just install it from teh GUI [21:22:07] dbrant, I saw another one of those a while back [21:23:19] Deskana: dbrant: you guys are getting questions about why location is needed on reviews of r84 [21:23:59] Krenair: what you saw was just from beta. Now it's on production. [21:24:03] Yep. [21:24:06] :( kaldari it's clearly broken [21:24:21] but I don't know why [21:25:02] i think this code has officially become too confusing to debug, we need to clean up that repo [21:30:23] (03CR) 10Yurik: [C: 032] Return background and foreground color with message [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165947 (owner: 10Dr0ptp4kt) [21:30:42] (03Merged) 10jenkins-bot: Return background and foreground color with message [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165947 (owner: 10Dr0ptp4kt) [21:31:25] milimetric: underlying that, I wonder if we can find a solution to the 'need to UNION all the things' problem [21:31:55] dbrant: haven't been able to get hangout going [21:32:11] tfinc: yeah, something's going on with hangouts :( [21:32:23] dbrant: making a new one, invitation sent [21:36:39] dbrant: http://mobile-reportcard.wmflabs.org/#other-graphs-tab [21:47:19] YuviPanda: the problem with that repo is the lack of tests or decent logging. Or clean code. It's used so much it deserves some love. I'm too swamped to be able to keep context switching to it and debugging issues. [21:49:32] milimetric: yeah, agreed. I didn't expect it to grow like this when I quickly hacked it up... [22:11:40] (03CR) 10Robmoen: [C: 032] Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) (owner: 10Jdlrobson) [22:12:27] (03Merged) 10jenkins-bot: Push microtap to stable. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164402 (https://bugzilla.wikimedia.org/46012) (owner: 10Jdlrobson) [22:15:13] (03PS1) 10BearND: Use constant apk file name in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166683 [22:16:26] (03CR) 10jenkins-bot: [V: 04-1] Use constant apk file name in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166683 (owner: 10BearND) [22:18:02] (03PS6) 10Florianschmidtwelzow: Use Generic Overlay-footer template for links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166197 [22:19:54] (03CR) 10Florianschmidtwelzow: Use Generic Overlay-footer template for links (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166197 (owner: 10Florianschmidtwelzow) [22:21:50] (03PS7) 10Florianschmidtwelzow: Use Generic Overlay-footer template for links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166197 [22:24:00] (03CR) 10BearND: [C: 032] "Great idea! Now one can bring up the location in Google Maps or Earth or ..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166636 (owner: 10Yuvipanda) [22:24:16] (03Merged) 10jenkins-bot: Nearby: Open an intent with geo:// URL if item is long pressed [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166636 (owner: 10Yuvipanda) [22:24:41] tfinc: I'll respond to them. [22:25:40] (03PS2) 10BearND: Use constant apk file name in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166683 [22:26:07] (03PS3) 10BearND: Use constant apk file name in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166683 [22:26:22] (03CR) 10Florianschmidtwelzow: Make sure, loading circle is really visible (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 (owner: 10Florianschmidtwelzow) [22:26:58] bearND: btw, did you test that? I didn't (yet) [22:28:52] YuviPanda|zzz: yes, i've tested it. It works great. I brought up Google Maps with it [22:28:59] bearND: wheee, nice :D [22:29:08] bearND: happy I can still write Android code that works in the first try :) [22:29:37] YuviPanda|zzz: bearND: :) not so fast, it crashes when there's no Maps app installed [22:29:49] dbrant: hah :D yeah, need to handle that. [22:30:12] dbrant: let me fix that [22:32:10] dbrant: good point. I like the feature even better with Google Earth. One can go from one nearby location to another, then the transition between locations is pretty cool [22:32:41] (03PS1) 10Yuvipanda: Nearby: Don't crash on long press if no maps application is present [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166684 [22:33:16] dbrant: bearND ^ [22:33:47] YuviPanda|zzz: cool. I'll let dbrant verify + merge that [22:33:53] cool :) [22:36:03] (03CR) 10Dbrant: [C: 032] Nearby: Don't crash on long press if no maps application is present [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166684 (owner: 10Yuvipanda) [22:36:12] dbrant: ty :) [22:37:15] dbrant|brb: are you cool with me merging the first couple of fragment patches? [22:37:33] bearND: absolutely! [22:37:39] ok [22:39:04] * Deskana braces himself for The Great Merge of 2014. [22:40:18] god help us. [22:41:04] dbrant|brb: Q about the empty catch block in https://gerrit.wikimedia.org/r/#/c/161483/19/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java [22:41:16] Why won't it happen? [22:42:03] line 150 [22:43:43] bearND: it 'could' throw a ClassNotFoundException. But I don't believe it will. [22:53:33] YuviPanda|zzz: totally, and that wasn't by any means a knock on your work on it. I think it has provided amazing ROI so far. It's just time for some more investment. [22:53:40] yeah [22:53:52] I'll try to get kevinator to agree :) [22:54:01] phuedx, https://gerrit.wikimedia.org/r/#/c/166148/ [22:54:14] milimetric: :D I think having it exploit the fact that our schemas are well defined would be a good thing, so it can do the UNIONs by itself, with appropriate null values [22:55:22] 3MobileFrontend / 3Feature requests: Use touchend instead of click event where possible - 10https://bugzilla.wikimedia.org/46012 (10Jon) 5PATC>3RESO/FIX [22:56:10] My early work with Saiku and Mondrian has been very promising. Hopefully that can underlie data dog tasks like limn-mobile-data [22:56:35] (03PS20) 10BearND: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [22:57:20] kristenlans: Maryana kaldari|2 MaxSem kaity moizsyed phuedx bmansurov rmoen > http://etherpad.wikimedia.org/p/G_ [22:57:51] (03CR) 10BearND: [C: 04-1] "minor nit" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [22:58:40] dbrant|brb: are you still around? [22:59:52] Deskana: thanks [23:00:27] mhurd: Can you respond to Andy's question about saved pages migration? Not sure what the best way to get old builds installed is. [23:04:15] Deskana: hmm not sure about that... [23:04:27] old builds that is [23:04:46] MaxSem: ta [23:04:54] mhurd: It may just be worth making it explicit that we only want them to test that f23ionefwiubf4biu2asfk askl ffgkl 3n4 [23:04:56] ... [23:05:23] wat [23:06:13] My laptop totally froze for 10 seconds. [23:06:19] haha [23:06:36] mhurd: Anyway, it may be worth noting to him that he only need check that each time he downloads a new app [23:06:43] i.e. each new TestFlight release [23:06:53] Deskana: that sounds ok for now [23:09:09] Phew, that sprint naming session was intense. I need to go listen to some Powerwolf cranked up to 11. [23:09:09] (03PS8) 10Jdlrobson: Never hit the API when running QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) [23:09:25] (03CR) 10Jdlrobson: [C: 032] Never hit the API when running QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) (owner: 10Jdlrobson) [23:09:58] (03Merged) 10jenkins-bot: Never hit the API when running QUnit tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165345 (https://bugzilla.wikimedia.org/64635) (owner: 10Jdlrobson) [23:13:00] \o/ [23:15:09] (03CR) 10Phuedx: [C: 032] Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [23:15:45] (03Merged) 10jenkins-bot: Remove all the ajax related things. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164141 (https://bugzilla.wikimedia.org/45299) (owner: 10Jdlrobson) [23:17:39] (03CR) 10Phuedx: [C: 032] Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 (owner: 10Jdlrobson) [23:18:33] c-c-c-c combo breaker! [23:19:46] MaxSem, kaldari|2: my bad, we’re talking at 5, sending you an invite [23:19:51] bring popcorn [23:20:04] (03CR) 10Phuedx: "Is this related to bug 45299 as well?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [23:20:10] (03Merged) 10jenkins-bot: Hygiene: Page list thumbnails are not icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165143 (owner: 10Jdlrobson) [23:20:36] okie [23:20:38] i'm done [23:20:42] g'night folks [23:23:08] G’night phuedx, thanks for burning the midnight il [23:23:11] oil [23:28:07] (03PS2) 10Bmansurov: WIP: Add missing JavaScript documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165257 [23:28:46] (03PS3) 10Bmansurov: Add missing JavaScript documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165257 [23:32:21] jdlrobso_: have we decided to promote this? https://trello.com/c/B1doOIPh/2-1-push-previous-and-next-buttons-on-mobile-diff-to-stable [23:33:01] bmansurov: yup [23:33:07] 3MobileFrontend / 3Hygiene: QUnit tests hit API - 10https://bugzilla.wikimedia.org/64635 (10Jon) 5PATC>3RESO/FIX [23:39:13] (03PS1) 10Bmansurov: Push previous and next buttons on mobile diff to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166698 [23:44:23] jdlrobso_: does this really need analysis? Can I just work on it? https://trello.com/c/VdpFmjSA/49-bug-72049-abuse-filter-action-button-does-not-conform-to-the-styleguide [23:45:05] Seemingly random question (but related to WikiGrok): What is the most famous band in history that had both male and female members? [23:45:20] abba [23:45:26] Thanks! [23:50:40] @bmansurov, that’s probably ready for dev, I just wanted to run it by Maryana since she wasn’t able to atend stnadup this AM. [23:51:54] yeah, lgtm [23:52:20] but i don't think it's especially urgent, and we've got a lot of stuff to do for this sprint [23:56:19] kaldari|2: mamas and papas would be another choice [23:56:33] globally, I think Abba wins [23:56:41] srsly vagrant blows right now [23:57:18] kaldari|2: prob :) [23:59:05] kaldari|2 i think i'm delerious from having 6 straight hours of meetings, but "was napoleon a hatmaking?" is the funniest thing of all time [23:59:18] bmansurov, jdlrobso_: For context, just sent an email to the Wikidata team about how Bug 52564 will cause WikiGrok to ask absurd questions like "Was Abba female?" or "Was Michael Phelps a swimming?" [23:59:27] haha [23:59:37] ;) [23:59:50] ok, the michael phelps one is even better