[00:03:47] DarTar: where are you?? [00:05:48] (03PS1) 10Bmansurov: Hygiene: Abuse filter action button does not conform to the styleguide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166702 (https://bugzilla.wikimedia.org/72049) [00:14:23] 3MobileFrontend / 3Hygiene: Standardize page-loaded event across stable/beta/alpha - 10https://bugzilla.wikimedia.org/45299 (10Jon) 5PATC>3RESO/FIX [00:27:13] 3Wikipedia App / 3Android App: Nearby crash: Comparison method violates its general contract - 10https://bugzilla.wikimedia.org/72066 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None java.lang.IllegalArgumentException: Comparison method violates its general contract! at java.util.TimSort.mergeHi(T... [00:28:13] (03PS23) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [02:21:54] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Version B is not recording data on Tool Labs. BTW, there is now an api2.php that supports recording multiple claims at once, if you want to try it... [02:23:03] (03PS21) 10Dbrant: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 [02:30:45] (03PS15) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 [05:09:54] (03PS1) 10BearND: Fix crash in sorting of nearby pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166714 [05:20:47] (03CR) 10BearND: [C: 04-1] Make page browsing into a Fragment. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [05:48:33] (03PS1) 10Krinkle: Don't add #undefined as redirectHash [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/166716 (https://bugzilla.wikimedia.org/71573) [05:52:52] 3MobileFrontend / 3stable: #undefined hash appended on page views - 10https://bugzilla.wikimedia.org/71573#c5 (10Krinkle) *** Bug 72071 has been marked as a duplicate of this bug. *** [05:52:52] 3MobileFrontend / 3General/Unknown: MobileFrontend: Articles get "#undefined" force appended to the url - 10https://bugzilla.wikimedia.org/72071#c1 (10Krinkle) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 71573 *** [05:52:54] 3MobileFrontend / 3General/Unknown: MobileFrontend: Articles get "#undefined" force appended to the url - 10https://bugzilla.wikimedia.org/72071 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None https://en.m.wikipedia.org/wiki/Black_Peter https://en.m.wikipedia.org/wiki/Black_Peter#undefined https://en.m... [05:53:22] 3MobileFrontend / 3stable: MobileFrontend: Page views get "#undefined" hash force appended - 10https://bugzilla.wikimedia.org/71573 (10Krinkle) [05:53:22] 3MobileFrontend / 3stable: MobileFrontend: Page view get "#undefined" hash force appended - 10https://bugzilla.wikimedia.org/71573 (10Krinkle) 5PATC>3RESO/FIX p:5Unprio>3High [05:54:37] 3MobileFrontend / 3stable: MobileFrontend: Page views get "#undefined" hash force appended - 10https://bugzilla.wikimedia.org/71573#c6 (10Krinkle) Please backport fixes for regressions like these. This has been in production for over a week! (In reply to Krinkle from comment #0) > https://en.m.wikipedia.org... [06:57:09] (03CR) 10Florianschmidtwelzow: [C: 04-1] "I don't know much about AbuseFilterOverlay (and really has to look into it, how it looks), but i think the "Got it" button should be progr" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166702 (https://bugzilla.wikimedia.org/72049) (owner: 10Bmansurov) [09:40:22] 3Wikipedia App / 3Android App: Crash caused by pressing Retry button on connection issue error - 10https://bugzilla.wikimedia.org/70834#c10 (10Alex Monk) 5RESO/FIX>3REOP What about https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7881250 then? [09:56:54] 3Wikipedia App / 3General/Unknown: Simple Wikisource app, search and epub output - 10https://bugzilla.wikimedia.org/72077 (10billinghurst) 3NEW p:3Unprio s:3normal a:3None My thoughts for a mobile app for the Wikisources is something that allows for a search in the language of interest then pulls a d... [09:57:07] 3Wikipedia App / 3General/Unknown: Simple Wikisource app, search and epub output - 10https://bugzilla.wikimedia.org/72077 (10billinghurst) [10:34:07] hey all [10:34:12] made up for some sleep [10:34:19] *made up for the lack of sleep [10:40:42] sleep is for the weak! [10:40:54] * brion yawns [12:06:37] 3Wikipedia App / 3General/Unknown: Simple Wikisource app, search and epub output - 10https://bugzilla.wikimedia.org/72077#c1 (10Andre Klapper) Could you explain why this was filed under "Wikipedia App" as this seems to be about Wikisource? Does somebody plan to work on a Wikisource app? [12:53:05] bearND, local path: /home/alex/Git/Wikimedia/WikipediaAndroid/wikipedia/build/intermediates/classes/alpha/debug/wikipedia.apk [12:53:06] remote path: /data/local/tmp/org.wikipedia [12:53:06] Local path doesn't exist. [12:53:17] * Krenair doesn't understand how building the app could be so difficult [13:01:12] It claims to have finished compiling, but not apk was produced [13:22:17] (03PS6) 10Phuedx: Hygiene: Refactor tests / jshintrc to not use globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165369 (https://bugzilla.wikimedia.org/71714) (owner: 10Jdlrobson) [13:22:37] (03CR) 10Phuedx: "PS6 is a rebase." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165369 (https://bugzilla.wikimedia.org/71714) (owner: 10Jdlrobson) [13:27:18] (03PS22) 10Dbrant: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 [13:31:05] (03PS23) 10Dbrant: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 [13:35:51] (03CR) 10Phuedx: [C: 032] Hygiene: Refactor tests / jshintrc to not use globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165369 (https://bugzilla.wikimedia.org/71714) (owner: 10Jdlrobson) [13:36:24] (03Merged) 10jenkins-bot: Hygiene: Refactor tests / jshintrc to not use globals [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165369 (https://bugzilla.wikimedia.org/71714) (owner: 10Jdlrobson) [13:37:37] 3MobileFrontend / 3Hygiene: JSHint: Clean up .jshintignore - 10https://bugzilla.wikimedia.org/71714 (10Sam Smith) 5PATC>3RESO/FIX [13:47:12] (03CR) 10Phuedx: [C: 032] Push previous and next buttons on mobile diff to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166698 (owner: 10Bmansurov) [13:47:48] (03Merged) 10jenkins-bot: Push previous and next buttons on mobile diff to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166698 (owner: 10Bmansurov) [13:48:32] (03CR) 10Dbrant: [C: 032] Fix crash in sorting of nearby pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166714 (owner: 10BearND) [13:49:31] bearND: yeah sorry, when I started modifying that exception, I remembered that there were 4 others that can be thrown! [13:51:02] bearND: the IDE automatically asked if I want to switch the language level to 7... it didn't seem to modify any project files. [13:52:55] dbrant: I eventually found a place in the project settings where to change it but I don't want to make a change like that as part of this patch. [13:53:18] dbrant: anyways, i'm ready to merge this if you are [13:53:29] bearND: yep! [13:53:40] (03PS24) 10BearND: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [13:54:19] (03CR) 10BearND: [C: 032] Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [13:54:52] (03Merged) 10jenkins-bot: Make page browsing into a Fragment. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161483 (owner: 10Dbrant) [13:55:28] dbrant: https://gerrit.wikimedia.org/r/#/c/161935/ needs manual rebasing [13:55:39] bearND: \o/ doing... [14:02:36] (03CR) 10Phuedx: Hygiene: Abuse filter action button does not conform to the styleguide (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166702 (https://bugzilla.wikimedia.org/72049) (owner: 10Bmansurov) [14:23:28] bearND: it's not letting me push the rebased update... (remote rejected -> change closed). Sounds like we should have rebased before merging the first one :( It might need to be a new change-id. [14:24:27] dbrant: I did a rebase before i merged [14:25:02] bearND: I mean a rebase of the second dependent patch before merging the first. [14:32:49] dbrant: no, i don't think that's the problem. I've been seeing dependency issues with this patch before [14:33:46] dbrant: try this: grab the patch from gerrit, create a new branch, then git branch --set-upstream-to=origin/master [14:34:02] then git rebase --interactive [14:34:23] I saw two commits while there should have been only one. [14:35:31] remove the extra "Make page browsing into a Fragment" patch; may have to run it with git rebase --skip afterwards [14:36:03] dbrant: i gotta run for a bit but will be back in around 15-20 min. [14:36:12] bearND: ok, np [14:42:35] (03PS16) 10Dbrant: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 [14:48:32] bearND: I think I've wrangled it. ^ [15:00:40] dbrant: ok, back now. checking the new patch set [15:12:07] dbrant: The tick color change in NearbyFragment (line 541) probably needs to be reverted [15:12:42] but I'd be ok with a separate patch for that. up to you [15:14:51] bearND: I'll change it if you have additional notes... otherwise separate patch. I was actually hoping to convince Vibha to keep that color. [15:15:33] dbrant: still looking [15:17:50] (03CR) 10BearND: [C: 032] Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 (owner: 10Dbrant) [15:17:53] \o/ [15:17:57] bearND, dbrant: (OTRS question) are you working on a material design for the wikipedia app? No, right? [15:18:20] FlorianSW: not at present... [15:18:34] (03Merged) 10jenkins-bot: Turn other Activities into Fragments [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/161935 (owner: 10Dbrant) [15:18:35] dbrant: are there plans to do?! [15:19:40] (03PS10) 10BearND: Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 [15:19:52] dbrant: ^ rebased [15:20:21] FlorianSW: well, once Android L is released, we might experiment with making Material be the default theme on L devices... but certainly not a priority right now. [15:20:38] dbrant: ah, ok :) thanks [15:21:35] bearND: looking! [15:52:05] (03CR) 10Dbrant: [C: 04-1] "a couple things" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 (owner: 10BearND) [15:58:28] dbrant: ok, going to fix the issues [16:06:13] So Android L is Lollipop it seems [16:10:40] bearND: btw line 292 in SearchArticlesFragment also crashes when lastSearchedText is null. [16:29:25] FlorianSW: I've updated the "what's new" text for the other languages in the Play Store. Thanks for pointing that out! For some of the languages the description was still from the old Phonegap app :O [16:29:50] dbrant: :O thanks for the update! [16:30:54] FlorianSW: what would be the best way to get the "what's new" text actually translated into the other languages? (something having to do with TWN?) [16:31:00] cc bearND ^ [16:31:24] dbrant: hmm, twn isn't the right place i think :/ [16:31:47] maybe Siebrand can say something to this? [16:32:26] hach... he isn't here :/ [16:32:40] FlorianSW: ok, i'll touch base with him [16:33:10] dbrant: i think, if there is no good solution, an english "What's new" is much better as no info :) [16:33:20] of course :) [16:36:32] dbrant: I had cleared out the German what's new to see how this behaves. I haven't been able to find a way to remove the translated What's New entries. [16:36:37] cc FlorianSW [16:37:16] bearND: you mean the old ones? or completly remove the section? [16:41:42] FlorianSW: just this morning when I saw your email I emptied out the text in the What's New section for de. I was looking for a way to remove the translations inside What's New. There were old and in English anyways [16:42:21] bearND: hmm [16:43:57] dbrant: did you copy the English text to the other translations? [16:44:41] bearND: I did, but you bring up a good point about seeing what happens if we just leave them empty... [16:45:09] dbrant: i did that for de, and it also shows the updated English What's new [16:45:26] it took a while to propagate but i see it now [16:45:30] bearND: well then, that will be even better [16:45:59] bearND: I'll clear them out [16:46:00] (03CR) 10Phuedx: [C: 031] "This LGTM. Should we do the usual cherry-pick to master and merge?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 (owner: 10Jdlrobson) [16:46:10] dbrant: FlorianSW: https://play.google.com/store/apps/details?id=org.wikipedia&hl=de [16:46:47] bearND: mom, have you said, you translated the de what's new? [16:47:57] FlorianSW: I'm not your mom. ;) No I just removed the text there completely (select-all, delete). [16:48:16] bearND: :D mom -> moment :D lol [16:48:21] lol [16:57:11] (03CR) 10Jdlrobson: [C: 04-1] "I have concerns about this slowing down the editor on older devices." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) (owner: 10Bmansurov) [16:58:37] 3MobileFrontend / 3stable: MobileFrontend: Page views get "#undefined" hash force appended - 10https://bugzilla.wikimedia.org/71573#c7 (10Jon) Mmm.. What is your criteria for backporting regressions Krinkle? We only lightning deploy when we have a serious problem - e.g. hitting servers, functionality broken.... [16:59:53] (03CR) 10Jdlrobson: [C: 04-1] "Do we really need to lightning deploy this when it will go out tomorrow?" [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/166716 (https://bugzilla.wikimedia.org/71573) (owner: 10Krinkle) [17:00:07] (03CR) 10Phuedx: "I like this a lot." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 (owner: 10Jdlrobson) [17:01:36] rmoen standup tiiiime! [17:01:39] (03CR) 10Robmoen: Scroll to top of the editor with keyboard keys (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) (owner: 10Bmansurov) [17:02:33] (03PS11) 10BearND: Use real Action Bar for search bar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 [17:03:20] dbrant: ^ got rid of SearchViewCompat and created a method for the empty check since I also don't want to run the query when one just enters white spaces [17:03:47] bearND: processing... [17:05:45] * brion yawns [17:05:54] did some overnight refactoring [17:05:59] need to refactor my sleep patterns :D [17:15:47] brion: you're missing the concrete sleep class [17:16:04] that’s the one where you sleep with the fishes? [17:16:11] just extend the doze class [17:17:15] it's ok to laugh at your own jokes, right? [17:17:21] especially when they're so dern funny [17:18:15] (03PS9) 10Jdlrobson: Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 [17:20:49] (03PS6) 10Jdlrobson: Use desktop login/account creation form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 (https://bugzilla.wikimedia.org/68758) [17:21:03] class Sleep extends Nap implements IUnconscious; [17:21:12] (03PS17) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [17:21:35] (03CR) 10Jdlrobson: [C: 04-1] "needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 (owner: 10Jdlrobson) [17:22:36] (03CR) 10Phuedx: [C: 032] Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 (owner: 10Jdlrobson) [17:22:41] boom [17:22:49] (03PS4) 10Jdlrobson: Documentation: Editor files and Toast [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165257 (owner: 10Bmansurov) [17:22:55] (03CR) 10Jdlrobson: [C: 032] Documentation: Editor files and Toast [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165257 (owner: 10Bmansurov) [17:23:10] (03Merged) 10jenkins-bot: Hygiene: Introduce generic switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165144 (owner: 10Jdlrobson) [17:23:29] (03Merged) 10jenkins-bot: Documentation: Editor files and Toast [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165257 (owner: 10Bmansurov) [17:25:14] jdlrobson: https://gerrit.wikimedia.org/r/#/c/164126/ looks good, i asked a question about aria roles for spinners on it [17:25:42] that could be for another patch, if necessary [17:26:52] (03CR) 10Jdlrobson: Hygiene: Abuse filter action button does not conform to the styleguide (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166702 (https://bugzilla.wikimedia.org/72049) (owner: 10Bmansurov) [17:27:15] phuedx: will take a look once i've gone through all the non-me patches :) [17:27:22] 3Wikipedia App / 3Android App: add "Special:Nearby" feature to app - 10https://bugzilla.wikimedia.org/71949 (10Bernd Sitzmann) 5NEW>3RESO/FIX [17:27:25] cool.io [17:35:22] 3Wikipedia App / 3Android App: Nearby crash: Comparison method violates its general contract - 10https://bugzilla.wikimedia.org/72066#c3 (10Dan Garry) 5PATC>3RESO/FIX Should be fixed by this. [17:37:07] 3Wikipedia App / 3Android App: [Fulltext Search] Submit forces Search Overlay - 10https://bugzilla.wikimedia.org/72015#c1 (10Dan Garry) 5NEW>3RESO/INV We're actually substantially reworking our entire search system this sprint. Take a look at this to see what it will look like: https://trello.com/c/lxaSx... [17:37:22] 3Wikipedia App / 3Android App: [Fulltext Search] Keyboard does not dismiss - 10https://bugzilla.wikimedia.org/72016#c3 (10Dan Garry) 5NEW>3RESO/INV We're actually substantially reworking our entire search system this sprint. Take a look at this to see what it will look like: https://trello.com/c/lxaSxOCd... [17:37:23] 3Wikipedia App / 3Android App: [Fulltext Search] Improve overlay design - 10https://bugzilla.wikimedia.org/72017#c1 (10Dan Garry) 5NEW>3RESO/INV We're actually substantially reworking our entire search system this sprint. Take a look at this to see what it will look like: https://trello.com/c/lxaSxOCd/46... [17:38:44] (03CR) 10Dbrant: [C: 032] "for great justice." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/163274 (owner: 10BearND) [17:38:58] \o/ [17:39:08] just one more to go! [17:39:14] Take off every Action Bar [17:39:21] You know what you doing [17:39:23] (03PS8) 10BearND: Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 (owner: 10Dbrant) [17:39:39] make your time... [17:40:28] You have no chance to onStop() make your onDestroy() [17:40:29] Haha [17:40:33] *ha ha ha [17:42:37] (03CR) 10Jdlrobson: [C: 04-1] "sorry more feedback.. i took a closer look." (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [17:42:40] (03PS4) 10Bmansurov: Scroll to top of the editor with keyboard keys [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) [17:45:48] FlorianSW: https://trello.com/jonrobson1/recommend do you want to join trello so we can add you to cards you are working on? [17:46:58] (03PS8) 10Jdlrobson: Use Generic Overlay-footer template for links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166197 (owner: 10Florianschmidtwelzow) [17:47:40] jdlrobson: https://trello.com/florian255 [17:47:49] jdlrobson: let's try it :) [17:48:00] YuviPanda: the alpha build has some weird issues. [17:48:19] yey :) FlorianSW any bugs you are currently working on that i should know about ? [17:48:26] YuviPanda: in build.err I see KeyboardInterrupt [17:48:41] YuviPanda: any idea what's going on? [17:49:51] jdlrobson: actually nothing [17:50:29] (03CR) 10Bmansurov: "comments on jon's comments" (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [17:50:46] FlorianSW: https://bugzilla.wikimedia.org/show_bug.cgi?id=72069 would be a useful one [17:53:33] dbrant: Looks like we don't need the offset at the beginning of the page, toc, and nav drawer. I see tons of extra space [17:54:35] bearND: really? it's needed on my device... does the actionbar retract when you scroll down? [17:54:47] jdlrobson: sounds good [17:55:02] (03CR) 10Bmansurov: Add role 'button' to section heading text (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [17:55:14] dbrant: hmm, ok, it works on my 4.4 device but not on my 2.3 device [17:55:19] (03CR) 10Jdlrobson: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [17:55:24] FlorianSW: have you been following the wikigrok stuff? [17:55:29] it's pretty exciting [17:56:49] (03CR) 10Jdlrobson: [C: 032] "Love it :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166197 (owner: 10Florianschmidtwelzow) [17:56:54] (03PS9) 10Jdlrobson: Hygiene: Use Generic Overlay-footer template for links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166197 (owner: 10Florianschmidtwelzow) [17:57:33] (03PS24) 10Jdlrobson: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 [17:57:38] dbrant: reinstalling on my gb device, just in case [17:57:46] phuedx: rmoen kaldari would be great if one of you could look at https://gerrit.wikimedia.org/r/#/c/164125/ [17:58:28] issyl0: i've seen you lurking for some time. You were interested in Wikidata during Wikimania right? [17:59:10] dbrant: hmm, I'm still seeing the issue on my GB device [17:59:17] bearND: standby, I think I know the cause... [17:59:35] ok [18:00:18] (03CR) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [18:00:47] jdlrobson: a little bit, some gerrit changes, but which data wikigrokb doesn't log? [18:01:10] apparently none whatsoever. I haven't had a look yet but kaldari just reported it [18:01:14] i'm guessing there is a validation issue [18:02:06] (03CR) 10Krinkle: "Well, had you not waited a week first... It'll still get it in production a day earlier. It's cheap to back port, why wouldn't we?" [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/166716 (https://bugzilla.wikimedia.org/71573) (owner: 10Krinkle) [18:02:22] (03PS2) 10Krinkle: Don't add #undefined as redirectHash [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/166716 (https://bugzilla.wikimedia.org/71573) [18:05:27] bearND: working on it... I'll wait for your other notes before submitting an update. (but assume that one is fixed) [18:05:45] dbrant: i got no other notes [18:05:56] besides this [18:06:12] ok then! will finish in a jiffy. [18:06:20] cool [18:08:11] (03CR) 10Jdlrobson: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [18:09:10] (03CR) 10Jdlrobson: "I'd say it's cheaper to minimise deployments and code new things personally. If you want to feel free but I think it's a waste of time :)" [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/166716 (https://bugzilla.wikimedia.org/71573) (owner: 10Krinkle) [18:09:25] (03CR) 10Jdlrobson: Hygiene: Use Generic Overlay-footer template for links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166197 (owner: 10Florianschmidtwelzow) [18:09:34] (03CR) 10Jdlrobson: [C: 032] "attempt #2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166197 (owner: 10Florianschmidtwelzow) [18:10:06] (03Merged) 10jenkins-bot: Hygiene: Use Generic Overlay-footer template for links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166197 (owner: 10Florianschmidtwelzow) [18:13:38] What. [18:13:46] Why are the two search APIs so inconsistent with each other? [18:14:06] Why do we even have two separate APIs? [18:14:38] Shouldn't we just have one, where you can specify a mode (e.g. &mode=opensearch)? [18:14:45] jdlrobson: Sorry, looking in a sec. On the phone with my dad, he had an accident last night and is pretty shaken up. [18:14:54] You get totally different JSON back from null queries to the two APIs. [18:15:02] * Deskana sighs. [18:15:52] 3MobileFrontend / 3stable: Safari on iPad crashes when viewing large articles? - 10https://bugzilla.wikimedia.org/68845#c10 (10Jon) 5UNCO>3RESO/WOR Please reopen if this is still being experienced. [18:16:05] One outputs a JSON array and the other a JSON object, too. So they even failed at the first step of consistency. [18:16:06] jdlrobson: i'll take a look at that pactch [18:16:08] *patch [18:17:53] (03CR) 10Jdlrobson: [C: 04-1] "I can confirm this fixes the problem but it still needs some tweaks." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) (owner: 10Bmansurov) [18:17:59] milimetric: you around? [18:18:21] hi jdlrobson yes [18:18:36] milimetric: so i'm taking a look at https://trello.com/c/PWnBPhuT/5-5-mobile-reportcard-revamp [18:18:41] "http://mobile-reportcard.wmflabs.org/graphs/edits-monthly-active-2014 – backfill with accurate historical data (the numbers look off, and what does 2014 mean in the x axis labels??)" [18:18:52] are you looking at this do you need any help? [18:19:18] 2014 means January 2014 [18:19:25] d3 does automatic labeling [18:19:42] which is a *lot* harder than it sounds for all time ranges [18:20:15] yeh also the thing that is confusing is there is no data pre Jan 2014 [18:20:15] what i'm looking at right now is why the query that Ryan checked in Friday, which works perfectly, is breaking the whole system and causing all the datafiles to remain stale [18:20:21] and for some reason it shows that on the x axis [18:20:31] milimetric: you can link me to that patch [18:21:23] jdlrobson: i'm checking in new patches now to try and figure it out, because it's making no sense, but the original change was: https://gerrit.wikimedia.org/r/#/c/166401/ [18:22:05] jdlrobson: as far as pre-2014 data, I'm not sure - is it possible that the data got deleted from the database but those old results are generated from last year when we stood this system up? [18:22:20] milimetric: the new schema only came in january 2014 [18:22:31] so it needs to just not show pre jan 2014 [18:22:39] is there a way to configure the x-axis? [18:23:04] milimetric: this patch looks weird [18:23:04] https://gerrit.wikimedia.org/r/#/c/166401/1 [18:23:06] why only 2 files? [18:24:29] (03CR) 10Yurik: [C: 032] Downloaded open source font from http://unifoundry.com/unifont.html [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165699 (owner: 10Yurik) [18:24:50] (03Merged) 10jenkins-bot: Downloaded open source font from http://unifoundry.com/unifont.html [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165699 (owner: 10Yurik) [18:25:50] jdlrobson: i think ryan submitted the other files separately [18:26:41] jdlrobson: you can configure the time range of the x axis, from the datasource, but it seems to me like that data is just from the last part of december, 2013, judging by the numbers [18:26:52] so maybe the schema started towards the end of 2013? [18:27:55] milimetric: that's correct [18:28:09] how do we configure it? [18:29:19] (03PS18) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [18:29:32] jdlrobson: i'll make a patch now [18:30:22] milimetric: sweet thanks [18:30:46] jhobs, i was looking at https://gerrit.wikimedia.org/r/#/c/165944/ -- where are you using that resource? [18:31:18] so FlorianSW if you want to work on something that's on that trello board i added to you, just add your face to the card and move it over to "in development" [18:32:25] yurikR: it should be included on the portal by loading it with resource loader, no? [18:32:30] (03CR) 10Yurik: [C: 04-2] "Per our meeting, lets persue the unified approach. Let me know if this changes." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165659 (owner: 10Dr0ptp4kt) [18:32:53] jhobs, but we have to explicitly tell resourceloader to send it to the client [18:33:11] jdlrobson: ok :) [18:33:26] yurikR: ah, i thought that was handled by defining the module [18:34:34] jdlrobson: I'm trying to add 'jquery.throttle-debounce' to 'moble.editor.common' dependencies, but I'm getting an error that reads 'unknown dependency'. What am I doing wrong? [18:34:41] (03PS9) 10Dbrant: Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 [18:35:07] bmansuro_: so in mobile we have all JavaScript in core turned off my default [18:35:07] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c1 (10Florian) Can you give an example URL and what data should be logged and which isn't logged? (Or is the data, already should be logged in DialogB, not logged?). [18:35:14] jhobs, search for $out->addModules( 'zeroportal.config' ); [18:35:23] i wasn't suggesting doing this now but usually what we do when we need a library is take a look at the code [18:35:42] bmansurov: jquery.throttle-debounce isn't loaded on mobile devices [18:35:43] check it isn't too big/it is supported on mobile [18:35:54] 3Wikipedia App / 3General/Unknown: Simple Wikisource app, search and epub output - 10https://bugzilla.wikimedia.org/72077#c2 (10Dan Garry) 5NEW>3RESO/INV This is invalid. This component is for bugs and feature requests in the Wikipedia app, not for requests for new apps. [18:36:24] and when we are confident about the code and the library's maintainability we enable it by submitting a patch to core that changes the ResourceLoader module to have 'target's => array( 'desktop', 'mobile' ) [18:36:37] exact :) [18:36:42] bmansuro_: any questions? [18:36:50] so basically all javascript code is desktop only by default [18:36:54] unless we tell it otherwise [18:37:01] jdlrobson: since I'm on it I thought I should do it now. It looks like the library is only tested on desktop browsers [18:37:04] we don't want to dump code into mobile that is not generically useful [18:37:17] bmansuro_: so i'd suggest not bothering for the time being [18:37:22] jdlrobson: ok [18:37:48] FlorianSW: thanks [18:38:12] Deskana: re: API, OpenSearch was because Microsoft (I think?) paid us / cajoled us into implementing. It is a 'search standard', so different from our internal API [18:38:22] http://www.opensearch.org/Home [18:39:37] jdlrobson: can you elaborate on "It's also probably better here since it's a function to define it inline "? [18:40:06] bmansuro_: rather than var x = function() {} [18:40:09] do function x() { } [18:40:15] inside the code block [18:40:21] milimetric: ImportError: No module named MySQLdb [18:40:22] (03CR) 10Dr0ptp4kt: "Upon testing against production yesterday with a real IPv6 IP in the TESTON configuration modified to have the "DIRECT" ipset -mapped con" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/165659 (owner: 10Dr0ptp4kt) [18:40:34] jdlrobson: is it because the function is inside the code block? [18:40:35] did we switch how the sql stuff works in the limn graphs? [18:40:58] jdlrobson: i don't think so - but it's possible upgrades on the server are what's screwing us up [18:41:10] bmansuro_: function declarations at the top of the code block where variables are defined are usually bad [18:41:16] var x; x = function() {} would also work [18:41:21] I'm looking for this timespan thing, sorry, much harder than i thought [18:41:22] whatever you think makes more sense for readability [18:41:29] milimetric: :-S how so? [18:41:55] like, limn is refusing to grab the timespan i'm giving it, so now I have to figure out why [18:42:16] ^^^^^^^^^^^ yurikR (https://gerrit.wikimedia.org/r/165659), see comment. can you reproduce? see the TESTON wiki rev history for what i did. mdot was in fact showing the banners, but zerodot was showing the warning instead of redirecting to mdot in production [18:43:15] jdlrobson: isn't setting delay to 0 equal to not throttling at all? [18:44:53] (03PS4) 10Yurik: Add reset less file [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165944 (owner: 10Jhobs) [18:45:08] (03CR) 10Yurik: [C: 032] Add reset less file [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165944 (owner: 10Jhobs) [18:45:21] bmansuro_: yeh i guess it won't help that much 250 is probably sufficient [18:45:37] i'm not sure how quick people can type :) [18:45:45] (03Merged) 10jenkins-bot: Add reset less file [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/165944 (owner: 10Jhobs) [18:45:57] thanks yurikR [18:48:20] Great: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7881816 [18:48:28] (03PS5) 10Bmansurov: Scroll to top of the editor with keyboard keys [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) [18:48:34] ah jdlrobson there's a bug in limn [18:48:45] it's not using the correct type of metric for that data [18:48:48] so it doesn't have timespans [18:48:50] milimetric: i can't seem to get my limn working. python complaints [18:49:06] python? it's a node server... [18:49:26] you mean limn-mobile-data? [18:50:15] milimetric: yeh the pythondata ImportError: No module named MySQLdb [18:50:22] not sure why this has suddenly cropped up and can't seem to instal it [18:53:01] milimetric: oh wait. I think mysql isn't installed on this machine for some reason [18:54:05] yurikR: file uploading is disabled for zero.wikimedia.org. I have some SVGs to upload, but I'm not sure they belong on commons. What would you recommend? [18:54:23] yurikR: just include them in the extension files? [18:54:28] jhobs, i will enable it shortly [18:54:40] yurikR: ok [18:58:58] bearND|food: ready! https://gerrit.wikimedia.org/r/#/c/166058/ [19:01:15] ugh jdlrobson figured it out - ryan was just trying to be clean by factoring out some parameters but that breaks how the sql is being executed, and how it reads the cursor's description to figure out the column header row [19:01:26] i'll submit a patch shortly and everything should be ok [19:06:08] ok jdlrobson, the graphs should generate normally now [19:07:09] as for that graph that starts way earlier, i can either fix the bug in limn or... we can get ops to change the file and you can change the config for it to start on 2014-01-01 [19:07:32] i'm probably not touching limn anytime soon, and this doesn't sound urgent enough to mess with ops, but feel free to contradict [19:08:58] milimetric: why can't we change the config on a graph per graph basis? [19:09:30] you mean the limn config or the python generation config? [19:09:37] you can, in both cases [19:09:51] if you change the limn config, it would be for the datasource, and because of the bug I mentioned, limn ignores it :/ [19:10:12] if you change the python generator config, it would stop generating data for those old dates, but the csv file still has those dates [19:10:19] milimetric: did you open a bug on bugzilla? [19:10:20] in the first case, i'd need to fix the bug [19:10:39] in the second case, i'd need to get ops to delete the first records in that csv file [19:10:51] i'll open a bug for the limn issue, sure [19:11:18] milimetric: i see. [19:11:21] milimetric: python generate.py -c scripts/config.yaml mobile -g 'edits-monthly-new-active' -f FORCE [19:11:25] can you run that on the machine? [19:11:32] that will delete the csv file and rerun it [19:12:21] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=72088 [19:12:41] jdlrobson: I can't do that because my user doesn't have permits to mess with that file at all [19:12:47] :-/ [19:12:48] if i had permits, I would just change the file manually [19:13:04] milimetric: so the problem is there is an csv file with empty dates pre dec 2012? [19:13:10] *2013 [19:13:13] yes [19:13:27] i can get ops to change it though, is it important enough to ping them? [19:13:31] milimetric: couldn't we just write a patch that when generating clears empty dates? [19:13:41] ^ Maryana thoughts [19:13:51] oh, yeah, we could do that too [19:13:58] but I'm really hating how nasty this code has gotten [19:14:06] milimetric: haha :) [19:14:07] it's completely unreadable imo [19:14:19] yeh it's pretty nasty [19:14:35] ok, lemme think if i can make an easy hack [19:16:05] milimetric: i can ping mutante [19:16:21] (03CR) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [19:16:27] ok jdlrobson, i'll make the change to the config then [19:17:46] milimetric: where is it running? [19:17:49] labs [19:17:53] ? [19:17:53] no [19:17:55] stat1003 [19:17:59] but where you talking? [19:18:01] -ops? [19:18:08] in real life :) [19:18:17] heh [19:18:37] yep, stat1003, file is in ... hang on [19:19:12] jdlrobson: /a/limn-public-data/mobile/datafiles/edits-monthly-active-2014.csv [19:19:53] hold up though jdlrobson [19:20:31] if he deletes it now, and the new config is not loaded, it won't matter, the old config would make it re-generate [19:20:49] i just self-merged the config, i'll let you know when it's deployed by puppet to stat1003 [19:20:57] milimetric: should be fixed [19:21:02] :( [19:23:23] milimetric: we edited that csv file [19:23:29] but it still is showing the old [19:23:53] (03CR) 10Jhobs: "Reminder that I don't have +2 power to self-merge my tests, so if this looks good to you feel free to merge." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/166616 (owner: 10Jhobs) [19:24:40] Hahha, just noticed the background of mobile web current sprint board: https://trello.com/b/qqky83B2/mobile-web-current-sprint-33-groundhog-day [19:25:39] bearND: ready! [19:26:04] dbrant: yep. checking... [19:28:06] jdlrobson: that file gets rsynced over to stat100...something else [19:28:53] also though, you didn't wait for me to explain, this system is totally fubar, we had to make the config change first and wait for puppet to run [19:28:57] i'm not sure what'll happen now [19:29:03] milimetric: yeh this is all very confusing lol [19:29:04] it's ok though [19:29:11] i've been asking toby for a year to work on a better system [19:29:13] i now have a confused mutante and a confused kaldari [19:29:14] and it's going to happen [19:29:14] and a confused me [19:29:30] it's ok, i'm not confused [19:29:32] milimetric: heads up i may have another commit for you soon, i'm doing limn graph voodoo [19:29:33] i'm just pissed [19:29:57] edits-monthly-new-active is apparently the graph we need, apparently edits-monthly-active-2014 is getting removed [19:30:05] lol [19:30:20] ok, now i'm my anger became funny [19:30:39] right - that's the graph I worked on with kaldari (-new) [19:30:46] so that's the one i was working to fix this morning [19:30:47] milimetric: okay so i think i know what's going on here. Let's sync up around 1pm PST [19:30:50] and it's being generated now [19:31:00] k, all should be fine though [19:31:09] just take out the old graph from the dashboard and put in the new one [19:32:30] dbrant: why doesn't PageActivity extend ThemedActionBarActivity anymore? [19:32:31] milimetric: yeh i'll do that bit [19:34:16] bearND: because, annoyingly, setting FEATURE_ACTION_BAR_OVERLAY must be done before setDisplayHomeAsUpEnabled, which is an integral part of ThemedActionBarActivity... [19:34:20] milimetric: is andrew otto helping you out with cleaning up this mess? [19:34:32] jdlrobson: no, why do you ask? [19:34:44] this is solely my responsibility, for entirely self-inflicted reasons [19:35:02] isn't he supposed to be ops/analytics guy no? [19:35:07] and you mentioned puppet [19:35:19] oh, all that doesn't matter if you guys are removing this graph [19:35:24] dbrant: ah, good to know [19:35:25] the other graph is fine [19:35:51] if you care, the process is: [19:35:53] so the other weird thing about this graph you set up with kaldari [19:35:56] * commit / merge code [19:35:58] is monthly graphs don't work that way [19:36:08] * puppet pulls it and updates the repo on stat1003 [19:36:13] * cron runs and creates datafiles [19:36:15] it's doing queries on a daily basis lolz [19:36:19] * rsync runs and moves datafiles to public dir. [19:36:47] jdlrobson: it's not a monthly graph, i think that was a misunderstanding kaldari had when he got the code from DarTar [19:36:55] oh so we want a daily graph? [19:37:09] this is a daily computed number that's a rolling number of people who registered and made 5 edits in the last 30 days [19:37:18] so I changed the config to execute this graph hourly [19:37:24] so what is the output meant to be? [19:37:30] a line graph per day [19:37:32] dbrant: drum roll.... [19:37:32] or per month? [19:37:40] (03CR) 10BearND: [C: 032] Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 (owner: 10Dbrant) [19:37:55] dbrant: Deskana: tataaaa ^ [19:38:01] yay!!! [19:38:04] jdlrobson: it's per day [19:38:28] on each day, it counts the number of editors who registered at most 30 days ago and made 5 edits since then [19:38:34] hence "rolling" active editors [19:39:20] (03Merged) 10jenkins-bot: Real ActionBar part II [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166058 (owner: 10Dbrant) [19:39:25] dbrant: Deskana: kristenlans: how do you want to handle the to dos in https://etherpad.wikimedia.org/p/actionbar_checklist? [19:40:36] jhobs, could you take a look at production wiki - seems like i can't click on the banner any more [19:40:44] er... holy crap that limn graph is taking forever... it might not be done for a few days [19:40:50] *the sql query that is [19:41:04] milimetric, use graph ext ;) [19:41:41] yurikR: heh, that's, sadly, not the problem here [19:41:53] I'd love to just blame everything on limn, i really would, but this is 100% data gathering [19:42:02] bearND: do you want to put your name by the item(s) you'll take care of? and if it's significant enough, make a trello card? [19:42:05] and we are in the Freaking stone age with data gathering [19:42:46] dbrant: ok [19:43:08] jhobs, i think it is even a bigger problem - all external links are not working [19:43:17] dbrant: we should probably ask vbamba to help with the ToC icon [19:43:27] dbrant bearnd: that sounds good to me. JUst ping me and Deskana if you end up makign a card. [19:43:36] yurikR: i'm not even seeing the banner at https://en.m.wikipedia.org/wiki/Main_Page?X-CS=ON with TESTON header set for X-CS [19:44:00] jhobs, try to use HTTP, not https, and do it from a privacy mode [19:44:07] just to see if it works [19:44:49] kristenlans: k [19:45:06] yurikR: still no [19:45:18] bearND: and I've ordered them in rough priority. [19:45:45] YuviPanda: would you take a look why the alpha build acting up? Weird stack traces in the build.err file. [19:45:57] bearND: oh, yeah, looking. [19:46:03] YuviPanda: thanks! [19:46:10] jhobs, weird, i am seeing banners. Than again, my ip is registered [19:46:14] as a zero portal [19:47:04] yurikR: I guess, but I'm pretty sure I used to see banners this way [19:47:28] jhobs, btw, i had to force refresh to get the latest, might be a caching issue [19:47:39] yurikR: been forcing refresh [19:48:21] yurikR: currently have User-Agent: android-mobile and X-CS: TESTON [19:51:13] jhobs, trying from another ip (my home is registered as orange) [19:53:28] jhobs, try another xcs, like 250-99 [19:53:31] yurikR: local dev environment still works just fine for me after pulling latest on all branches [19:53:35] yurikR: one sec [19:54:08] yurikR: that worked and i was able to click on the banner [19:54:44] yurikR: but the infoscreen isn't enabled for that [19:54:57] that partner* [19:55:12] i suspect that the TESTON gets weird treatment in varnish [19:55:21] i remember there was some logic for it [19:55:36] yurikR: that or it got modified recently, I think I remember seeing an email saying it was modified [19:55:54] so are you not able to click on the banner for 250-99? [19:56:10] btw, we really ought to migrate the main "warning" screen to the cool new interface :) [19:56:30] oh, and enable the "outside" click [19:56:35] yurikR1: so are you not able to click on the banner for 250-99? [19:56:51] no, works ok. I think it was a browser refresh issue at first [19:56:59] yurikR1: and I agree on the interstitial [19:57:12] do you know about the "outside click" thing? [19:57:19] i was told the ooui supports it [19:57:22] dbrant: would you take a look at https://gerrit.wikimedia.org/r/#/c/166683/? [19:57:35] yurikR1: not sure what you mean by that [19:57:36] bearND: ah yes... [19:58:02] yurikR1: like attaching the click handler to the document body instead of the element? [19:59:12] jhobs, i think its an option of ooui - to be able to cancel a popup dialog by clicking on the area outside of it [19:59:25] similar to how you cancel image viewing in facebook [19:59:30] yurikR1: oh you mean click on the modal to hide it [19:59:43] on the modal? [19:59:51] yurikR1: must be new, because iirc trevor said they were working on it when I did the OOUI stuff [20:00:06] yurikR1: yeah the modal is the gradient overlay thing [20:00:12] outside the dialog [20:00:25] gotcha. I thought they already had it [20:00:57] i'm just glad they moved to using the mediawiki skin by default [20:01:15] the animation looks better and it fits mobile frontend's theme better [20:01:57] (03PS1) 10Dbrant: Force overflow menu icon to be shown. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166807 [20:02:58] (03PS4) 10Dbrant: Use constant apk file name in Gradle build [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166683 (owner: 10BearND) [20:10:44] milimetric https://gerrit.wikimedia.org/r/166859 [20:10:46] works [20:13:21] bearND: hmm, interesting. that seems to be gradle failing on the exec hosts, and working fine on the dev box... [20:13:38] jdlrobson: maybe you forgot to git add the new graph [20:13:43] (comments posted) [20:13:45] bearND: I'm wondering if we should just get a VM and put this on that instead of futzing around with toollabs and the grid engine [20:14:10] (03CR) 10Dbrant: [C: 032] "lgtm!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166683 (owner: 10BearND) [20:14:29] milimetric: whoops [20:14:33] i didn't fully commit [20:14:41] i obviously have commitment issues [20:15:06] jdlrobson: looks like you have to rebase too [20:15:22] (03PS16) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [20:15:28] (03CR) 10jenkins-bot: [V: 04-1] Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [20:16:15] YuviPanda: are the issues related to the TERM setting maybe? [20:17:11] ^ milimetric [20:17:20] patch updated [20:17:29] the graph is autogenerated by the script [20:17:39] i manually removed the start and end as suggested though [20:18:03] bearND: why would gradle care about TERM? [20:18:50] YuviPanda: https://issues.gradle.org/browse/GRADLE-2634 [20:19:39] (03PS17) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [20:20:19] (03CR) 10jenkins-bot: [V: 04-1] Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [20:20:28] YuviPanda: I had some issues with it initially, but then found a StackOverflow page that mentioned TERM, and that helped for a while. I'm just not sure what value to set it on toollabs [20:21:35] YuviPanda: what does your VM proposal entail? Does this mean going to Jenkins? [20:22:08] (03PS18) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [20:23:34] Maryana, do we need more than 1 suggestion per property? e.g. 2 occupations per person [20:23:49] bearND: nope, we'll use the exact same code, except on the 'mobile' labs project. [20:24:09] MaxSem: for wikigrok version b? [20:24:18] whatever [20:24:22] YuviPanda: ah, why did we get the KeyboardInterrupt? [20:24:47] bearND: I think it just received the same signal for terminating the process and interpreted that as keyboardinterrupt [20:25:10] YuviPanda: was it running too long? [20:25:17] so milimetric we just need to generate it now right? [20:25:26] gonna take a while i guess [20:25:51] personally, I think that without references and property specializers, 2 claims per property is helluva confusing... not to say that we e.g. don't log concurrent claims [20:26:10] bearND: I don't know.... [20:26:39] I'm investigating, but toollabs has been consistently problematic... [20:26:49] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [20:26:57] (03PS1) 10Ori.livneh: Fix undefined variable: $parserOutput in ApiMobileView::getData [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166867 [20:26:59] MaxSem: for now, while we're just testing all of this and not actually sending anything to wikidata, yes [20:27:12] Maryana, so... [20:27:13] ? [20:27:23] YuviPanda: ok, i assume you're investigating a mobile labs project? [20:27:33] yes, we want to serve more than one suggestion per property, if possible [20:27:37] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c2 (10Jon) When I use Version B I notice a request is made to: https://tools.wmflabs.org/wikigrok/api.php?callback=jQuery1111028615760314278305_1413399567110&action=record_answer&format=json&subject_id=Q... [20:28:39] what is rubocop? why is it failing? https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-bundle-rubocop/18/console [20:29:08] ok [20:29:37] jdlrobson: yeah, it's been generating for a while, since before your lunch [20:30:01] but yeah, it'll take a really long time, I think it's like 1 minute per day and there are almost 300 days [20:30:03] (03CR) 10Bmansurov: "So the consensus is to edit the template and not fix it with a CSS hack?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166075 (https://bugzilla.wikimedia.org/66679) (owner: 10Bmansurov) [20:30:55] 3Wikipedia App / 3Android App: NPE in NearbyActivity.setupGeomagneticField - 10https://bugzilla.wikimedia.org/72091 (10Bernd Sitzmann) 3NEW p:3Unprio s:3normal a:3None APP_VERSION_NAME=2.0-r-2014-10-14 Caused by: java.lang.NullPointerException at org.wikipedia.nearby.NearbyActivity.setupGeomagneticF... [20:31:01] milimetric: yeh it will take a long long time [20:31:14] milimetric: is cron job disabled? [20:31:23] we don't want it to regenerate every hour until it's up to date :) [20:31:47] jdlrobson: i think way back someone made sure a new cron didn't start if the old one was running [20:32:11] bearND: yeah, I am now :) I think it'll simplify our lives. [20:32:12] thedj: hi, could you please review this? https://gerrit.wikimedia.org/r/#/c/148363/ thanks [20:32:49] YuviPanda: simple is goooood [20:33:05] jdlrobson: it looks ok from just reading the logs, looks like it's not re-starting the generation [20:33:12] YuviPanda: Would it be possible to also run the tests in an Android emulator? [20:35:21] bearND: potentially, but I think it'll be a *massive* pain to set up [20:35:29] since we'll be virtualizing ARM on top of virtualized x86 [20:37:09] YuviPanda: btw, the build script should be slightly changed to account for the constant apk file names (as https://gerrit.wikimedia.org/r/166683 got merged recently) [20:37:22] the sh.cp step [20:37:23] yeah, I forgot to fix that... [20:37:38] that was just merged 30 min ago [20:40:07] (03PS1) 10Dbrant: Highlight the Nav list item that is currently shown. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166870 [20:41:19] dbrant: Deskana: kristenlans: created https://trello.com/c/sMgxnqzp/32-search-refactor-fallout-integrate-find-in-page-with-contextual-actionbar [20:49:41] (03CR) 10BearND: [C: 032] Highlight the Nav list item that is currently shown. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166870 (owner: 10Dbrant) [20:50:00] (03Merged) 10jenkins-bot: Highlight the Nav list item that is currently shown. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166870 (owner: 10Dbrant) [20:51:15] (03PS2) 10BearND: Force overflow menu icon to be shown. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166807 (owner: 10Dbrant) [20:55:03] (03CR) 10Florianschmidtwelzow: [C: 031] Fix undefined variable: $parserOutput in ApiMobileView::getData [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166867 (owner: 10Ori.livneh) [20:57:45] (03CR) 10BearND: [C: 04-1] "How do we make it work on GB?" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166807 (owner: 10Dbrant) [21:00:13] (03PS3) 10BearND: Fix for infobox relocation leaving parent table with empty space. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166078 (owner: 10Dbrant) [21:03:23] (03CR) 10BearND: [C: 032] Fix for infobox relocation leaving parent table with empty space. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166078 (owner: 10Dbrant) [21:03:44] (03Merged) 10jenkins-bot: Fix for infobox relocation leaving parent table with empty space. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166078 (owner: 10Dbrant) [21:04:00] (03PS2) 10BearND: Make content horizontally scrollable on a per-section basis. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165870 (owner: 10Dbrant) [21:05:07] vbamba: Ping! Meeting time in Elder. [21:05:40] Deskana: do you happen to know a page with overly wide tables so I can test ^^? [21:06:22] bearND: Not off the top of my head. [21:06:30] ok [21:07:04] nm, i found one [21:08:37] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c3 (10Florian) There is a difference in the call of recordOccupation() function of WikiGrokApi. (Unhappily there is no documentation :P). The function is defined to take 3 arguments (occupationId, occupat... [21:09:37] kaldari, Maryana: I'm curious, why are we not targeting tablets / desktop for WikiGrok ? [21:09:56] we just don't have the designer resources to explore that for the time being [21:09:59] but we totally should [21:10:32] rmoen: The main reason is figuring out the layout and positioning when we have things like floated infoboxes and tables of contents in the same space. [21:11:00] kaldari: i see [21:11:06] rmoen: If design can give us direction on that, we can activate on tablet as well. [21:11:13] bearND: any idea of a rough estimate for https://trello.com/c/sMgxnqzp/32-search-refactor-fallout-integrate-find-in-page-with-contextual-actionbar [21:11:37] kaity: ^ [21:11:49] kaldari: i've been testing it in desktop. I have this feature flag that enables it. You think its reasonable to push that in to gerrit ? [21:11:52] kristenlans: not sure yet. 1 or 2 [21:12:31] bearND: OK, just wanted to do a quick check to make sure it wasn’t a 13 or somethign crazy :P [21:12:36] rmoen: sure, we can always take it back out later. [21:12:39] disabled by default of of course [21:12:43] -of [21:12:43] yeah [21:13:04] kristenlans: on second thought, let's start with 21 [21:13:18] kaldari: ? [21:13:24] kaldari: sweet. I think it will aid with testing [21:13:44] bearND: ;) [21:14:07] arrg, vagrant reloads !! [21:14:15] kaity: We were talking about how we can't put WikiGrok on tablet until we have some design input on how it should flow with floated infoboxes and table of contents in the same space. [21:14:27] kaity: Where's Moiz? [21:14:37] kaldari: he's in an apps meeting [21:14:40] ah [21:14:46] kaldari: sounds good, we'll look into! [21:14:51] thanks! [21:15:00] kaldari: I agree it should be on tablets of course [21:15:19] kaity: especially since we need to get a bigger pool of users [21:15:27] yep! [21:21:33] bearND: I've a VM up and running (android-build.eqiad.wmflabs) that's currently building the gradle build... [21:21:35] let's see how that goes [21:21:41] if that works out fine I'll just setup the cronjob etc there [21:21:46] Maryana: friendly reminder to add me to the sprint retrospective calendar invite :) [21:21:59] YuviPanda: \o/ [21:22:23] bearND: what's the command to build the alpha version again? [21:22:37] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c4 (10Ryan Kaldari) @Florian: That code just lives on Tool Labs right now (for testing). The code is at https://github.com/kaldari/WikiGrokAPI (with some limited documentation). api2.php (which handles mu... [21:22:47] FlorianSW: ^ [21:22:52] YuviPanda: it's in the build.py script, starts with ./gradlew [21:23:48] bearND: hmm, I don't see those commited. [21:24:08] YuviPanda: gradle = sh.Command('./gradlew') [21:24:15] gradle('-q', 'clean', 'assembleAlphaDebug', _env=env) [21:24:45] (03PS1) 10Robmoen: Feature flag to permit wikiGrok on all devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166885 [21:24:48] bearND: not at https://github.com/wikimedia/labs-tools-wikipedia-android-builds [21:24:58] I see you haven't pushed them [21:25:08] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c5 (10Jon) Florian your diagnosis towards the JS bit sounds about right :) Florian yup to the documentation we have a TODO note to sort this out this week :) [21:25:26] (03CR) 10jenkins-bot: [V: 04-1] Feature flag to permit wikiGrok on all devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166885 (owner: 10Robmoen) [21:26:32] kaldari: thanks :) On a first look it seems, that the missing correct "bit" is one of the reason, why no data is logged, compared with the other missing data :) [21:26:50] (03CR) 10MaxSem: [C: 032] Fix undefined variable: $parserOutput in ApiMobileView::getData [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166867 (owner: 10Ori.livneh) [21:27:03] YuviPanda: where should i push these changes to? I've been pushing to ssh://myusername@gerrit.wikimedia.org:29418/labs/tools/wikipedia-android-builds [21:27:34] FlorianSW: Ah, yes [21:27:44] bearND: hmm, are they showing up on gerrit? if they are you need to +2 them as well.. [21:28:04] That part was originally written for WikiGrok version A. Guess I should change the default to 1.... [21:29:34] FlorianSW: It's changed now [21:29:41] YuviPanda: I thought we didn't have to go through review for those [21:29:45] kaldari: hmm, $occupation_id isn't true, too? [21:29:56] default is an empty string, which is interpreted as false [21:29:57] bearND: indeed, which is why you can +2 them yourself :) [21:30:06] kaldari: https://github.com/kaldari/WikiGrokAPI/blob/master/api.php#L99 [21:30:12] FlorianSW: Yeah, if occupation_id isn't set, it won't work. That needs to be passed [21:30:27] ok, because dialog b doesn't pass it :) [21:30:37] that should be changed, too [21:30:44] FlorianSW: Yeah, it needs to. [21:30:56] otherwise, it doesn't make any sense to record it. [21:31:05] YuviPanda: ok, doing so right now [21:31:09] bearND: cool :) [21:31:11] i can't really work on this today and/or tomorrow, i'm still working on get back my "old" dev environment :/ [21:31:21] FlorianSW: The 'correct' param is optional though [21:31:24] kaldari: ^ yes, right [21:31:30] ok [21:31:41] YuviPanda: hmm, weird. the first patch needs a rebase [21:31:47] (03PS2) 10Robmoen: Feature flag to permit wikiGrok on all devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166885 [21:31:50] Feel free to add a note to the bug in the meantime [21:31:54] FlorianSW: ^ [21:32:10] kaldari: jap :) [21:32:14] milimetric: still running http://mobile-reportcard.wmflabs.org/graphs/edits-monthly-new-active ? [21:32:17] FlorianSW: nevermind, you already did :) [21:32:34] (03Merged) 10jenkins-bot: Fix undefined variable: $parserOutput in ApiMobileView::getData [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166867 (owner: 10Ori.livneh) [21:33:21] (03CR) 10Jdlrobson: "I like the idea but not sure about the variable name in the js. Doesn't really describe what it does well." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166885 (owner: 10Robmoen) [21:34:08] (03PS3) 10Dbrant: Force overflow menu icon to be shown. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166807 [21:35:20] YuviPanda: ohoh: on the labs server: Your branch is behind 'origin/master' by 11 commits, and can be fast-forwarded. [21:35:29] when i try to pull [21:35:46] i mean checkout master [21:35:59] YuviPanda: should i pull? [21:36:05] bearND: hmm? you need to push from the labs server to gerrit, right? [21:36:18] YuviPanda: yes [21:36:23] bearND: just do a 'git review' and see what happens... [21:36:30] bearND: also, http://android-builds.wmflabs.org/ :) [21:36:31] err [21:36:38] bearND: http://android-builds.wmflabs.org/wikipedia.apk [21:36:51] so it builds fine. Just need to setup cronjob and clone the build code, etc [21:36:57] FlorianSW: That API code is going to be retired pretty soon though. We're switching the data recording over to use Event Logging instead (so that it's scalable, but still easily hackable). It's kind of an abuse of Event Logging, but a good solution for the time being :) [21:37:08] YuviPanda: remote rejected] HEAD -> refs/for/master/master (no new changes) [21:37:40] kaldari: great :) [21:37:55] lolwut [21:37:57] * YuviPanda checks [21:38:21] bearND: ah, they're already pushed [21:38:21] bearND: https://gerrit.wikimedia.org/r/#/q/project:labs/tools/wikipedia-android-builds,n,z [21:39:04] YuviPanda: yes, I saw that. The first patch needs a manual rebase [21:41:03] bearND: aah, I see. Then yeah, git fetch origin, git rebase origin/master, resolve conflicts, then git review again... [21:42:47] YuviPanda: sounds good. but now I suddenly have unstaged changes. Did you modify the build.py script on the server? [21:43:00] no... [21:43:19] (03CR) 10Jdlrobson: "This has nothing to do with templates." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166075 (https://bugzilla.wikimedia.org/66679) (owner: 10Bmansurov) [21:43:23] damn, i really should read error messages :/ ("double" answer in bugzilla) [21:43:26] I see them too, no idea how that happened... [21:43:33] kaldari: https://bugzilla.wikimedia.org/show_bug.cgi?id=72069#c7 [21:43:34] (03CR) 10Jdlrobson: [C: 04-1] "need to rebase. sad face." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 (https://bugzilla.wikimedia.org/68758) (owner: 10Jdlrobson) [21:44:22] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c6 (10Ryan Kaldari) I added more error handling to the API just now. WikiGrok version B definitely needs to pass the occupation_id. The 'correct' param, however, is optional. [21:44:25] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c7 (10Florian) Kaldari and i discusses to make the "correct" param to an optional one, so it's not blocking the recording of an answer. Still neded is the occupation_id and occupation param, which should... [21:45:35] YuviPanda: can you take a look at the diffs of build.py on tools.wikipedia-android-builds? [21:45:45] they don't make any sense to me [21:45:55] jdlrobson: "sad face" -> http://sd.keepcalm-o-matic.co.uk/i/keep-calm-and-laugh-with-me-12.png [21:48:06] jdlrobson: http://datasets.wikimedia.org//limn-public-data/mobile/datafiles/edits-monthly-new-active.csv [21:48:09] woo hoo! [21:48:15] kaldari: yay [21:48:16] :) [21:48:38] yeehaw! [21:48:40] bearND: huh, I wonder if it was just the diff of all your changes... [21:48:47] note to self: remember that I just rejoyced that a query ran, and that I didn't time-travel to before I could program [21:48:48] bearND: since git log makes it look at my last change... [21:48:55] bearND: I'm just going to stash and dig into reflog [21:49:15] bearND: see now [21:50:05] (03PS1) 10Robmoen: hygiene: WikiGrok api documentation typo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166892 [21:50:13] (03CR) 10Jdlrobson: [C: 031] "The code looks fine but I don't really understand this bug still and why it is happening. Is it browser specific, is there any links you c" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) (owner: 10Bmansurov) [21:51:02] jdlrobson + kaldari: I just deployed the graphs too: http://mobile-reportcard.wmflabs.org/graphs/edits-monthly-new-active [21:51:20] (03CR) 10Jdlrobson: [C: 04-1] "oh shoot i found an issue with code" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) (owner: 10Bmansurov) [21:51:23] btw, that's kind of INSANE :) [21:51:30] 2k rolling new active!! [21:51:39] Your branch and 'origin/master' have diverged, and have 4 and 2 different commits each, respectively [21:51:46] \o/ [21:51:53] YuviPanda: ^ is what i get from git status [21:52:00] milimetric: awesome [21:52:03] ^ Maryana [21:52:07] i know, right, you guys rule [21:52:14] #mobile4eva [21:53:53] (03PS2) 10Jdlrobson: Hygiene: WikiGrok api documentation typo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166892 (owner: 10Robmoen) [21:53:57] lol wut [21:53:59] (03CR) 10Jdlrobson: [C: 032] Hygiene: WikiGrok api documentation typo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166892 (owner: 10Robmoen) [21:54:18] bearND: can you look at git log and verify that's all the commits you made? I can perform some surgery to make it be fine, I think... [21:54:39] (03Merged) 10jenkins-bot: Hygiene: WikiGrok api documentation typo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166892 (owner: 10Robmoen) [21:55:03] YuviPanda: checking... [21:55:45] YuviPanda: Yes, looks like it's all there [21:55:46] (03PS2) 10Jdlrobson: Hygiene: Introduce Icon.js abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 [21:57:17] bearND: ok! [21:58:09] YuviPanda: would you share what kind of surgery you are performing on git? [21:58:46] bearND: right now I just did a 'git rebase origin/master' [21:58:53] to see what the problems are [22:01:20] bearND: does the gradle build not require an explicit call to prepare-release done in build.py? [22:01:50] YuviPanda: yes, that step is not needed anymore. We're using Git flavors instead [22:01:55] ocol [22:01:56] Gradle flavors [22:01:57] *cool [22:02:04] bearND: I'm just doing a rebase and resolving conflicts [22:02:52] bearND: rebased [22:02:54] try pushing? [22:03:00] (03CR) 10Jdlrobson: [C: 04-1] Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [22:03:09] YuviPanda: I've removed the prepare script and replaced it with a very simple bump script and a make-release.py script in the apps repo [22:03:19] bearND: cool :) [22:03:55] the make-release script also runs the build (but I have not set it up for alpha because it's basically just runnign gradlew [22:04:09] it doesn't need the tagging and other stuff [22:04:21] for alpha [22:05:13] another coll thing is, that if you say make-release.py --prod it builds both the 'r' and the 'releasesprod' apks at the same time [22:06:09] nice! [22:06:20] bearND: things have definitely gotten much cooler since I 'moved to the background' :) [22:09:35] YuviPanda: i wouldn't say that. Just that it's nice to do a "fg YuviPanda" every now and then [22:09:46] :D :D [22:11:30] MaxSem: When you're working on the claim generating scripts, make sure that you aren't excluding items that already have that claim type recorded (like Magnus does), since we may want to ask for additional claims or even verification of claims that are already made. [22:12:03] kaldari, that's my next step - this has to be done differently;) [22:12:14] cool [22:13:19] (03CR) 10BearND: [C: 04-1] "The the big svg under [[China#Administrative divisions]] gets chopped off. That did not happen before this patch." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165870 (owner: 10Dbrant) [22:17:48] (03CR) 10Bmansurov: Scroll to top of the editor with keyboard keys (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) (owner: 10Bmansurov) [22:19:30] (03PS7) 10Jdlrobson: Use desktop login/account creation form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 (https://bugzilla.wikimedia.org/68758) [22:20:01] (03CR) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [22:20:22] (03PS19) 10Jdlrobson: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 [22:20:24] (03PS3) 10Jdlrobson: Hygiene: Introduce Icon.js abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 [22:20:34] (03PS4) 10BearND: Force overflow menu icon to be shown. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166807 (owner: 10Dbrant) [22:23:26] (03CR) 10BearND: [C: 032] Force overflow menu icon to be shown. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166807 (owner: 10Dbrant) [22:23:47] (03Merged) 10jenkins-bot: Force overflow menu icon to be shown. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166807 (owner: 10Dbrant) [22:29:07] yurikR: zero.wikimedia.org/Special:ZeroPortal?s=b let me know what you think about the map (it's live-rendered using your graph extension) [22:31:28] (03PS1) 10Jdlrobson: Hygiene: Merge wikigrokeval and wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166899 [22:31:39] jhobs, looks good! We will need to change the data source for that map though - so that it only shows the launched partners [22:31:51] and so that the numbers are dynamic [22:32:17] yeah I figured the numbers for sure; I didn't know the map included non-launched partners though [22:32:30] yellow is unlaunched [22:32:45] it will be the same map, just need a different data soure [22:33:03] i will make something for that soon [22:33:57] yurikR: if you could make sure it's also simple to set the width and/or height, that would be helpful too. I'd like to be able to make it wider [22:34:17] yurikR: and it's currently not rendering to the full width of the canvas element [22:34:55] this is due to how maps are rendered - i think there are other params in the graph to control for topojson rendering [22:35:02] will need to experiment with that [22:36:08] yurikR: cool, keep me updated :) [22:37:18] MaxSem: just sent you some notes I made a while back about Magnus's scripts in case it's useful. [22:37:50] ...when I'm finishing? :P [22:41:07] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c8 (10Jon) We need to get a fix out before the next deployment train so I might pick this up Florian if that's okay. But thanks for making it easier for me to work out how :) [22:44:25] YuviPanda: can i do a git review on the tools server? [22:44:38] bearND: yes you should now... [22:47:04] YuviPanda: done. Are you going to get us access to the new build server? [22:47:53] bearND: sure! It's not puppetized yet, but that shouldn't prevent us from starting to use it... [22:48:13] bearND: you need to configure ssh access via https://wikitech.wikimedia.org/wiki/Help:Access [22:48:40] YuviPanda: what are the implications of "not puppetized yet"? [22:49:00] bearND: well, if the instance goes away tomorrow, we'll have to do the setup manually. [22:49:41] bearND: I added you to the 'mobile' project, and made you projectadmin as well (so you can add others) [22:49:53] YuviPanda: thanks [22:50:01] bearND: once you've the proxycommand setup (as described in that link), ssh android-build.eqiad.wmflabs should work [22:50:18] bearND: the current setup is in /home/yuvipanda, should be completely moved to /srv (which should also be faster, since that's local storage and not NFS) [22:50:30] Hey, everyone. [22:50:31] bearND: I can puppetize / set this up tomorrow if you don't have the itme [22:50:32] *time [22:50:43] Does anyone know if phuedx has a staff account on the main wikis? [22:51:11] YuviPanda: no idea how to puppetize [22:51:33] (03PS1) 10Jdlrobson: Fix WikiGrokB saving [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166907 (https://bugzilla.wikimedia.org/72069) [22:51:33] bearND: you can just set it up locally without having to worry about it, if you want to. But I'll have to puppetize it anyway, so if you do it now it's kinda superfluous... [22:54:59] YuviPanda: I'm in [22:56:51] superm401, it doesn't look like it to me... [22:57:19] Thanks, Krenair [22:58:37] (03PS19) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [22:58:44] mhurd, ok if we talk tomorrow instead? [23:01:06] (03CR) 10MaxSem: [C: 032] Don't add #undefined as redirectHash [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/166716 (https://bugzilla.wikimedia.org/71573) (owner: 10Krinkle) [23:01:12] YuviPanda: i'll let you do the setup and migration to the new build setup tomorrow. It's very late for you. [23:01:22] YuviPanda: Thank you. [23:04:31] jhobs, the instructions were right there on that page (a bit confusing, but still there) - you just had to create a licenses page (i copied it from enwiki) https://zero.wikimedia.org/wiki/MediaWiki:Licenses [23:05:00] yurikR: haha yeah I actually just noticed that and was reading that page right now [23:05:13] jhobs, refresh it :) [23:05:26] (03Merged) 10jenkins-bot: Don't add #undefined as redirectHash [extensions/MobileFrontend] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/166716 (https://bugzilla.wikimedia.org/71573) (owner: 10Krinkle) [23:05:29] (03PS2) 10Jdlrobson: Fix WikiGrokB saving [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166907 (https://bugzilla.wikimedia.org/72069) [23:05:33] yurikR: yeah, thanks for copying that over. Is everything I upload considered freely licensed though? [23:05:39] yurikR: I wasn't sure if the SVGs counted [23:05:57] no idea - always depends on the source :) [23:06:22] i'm sure there is a rule for WMF content [23:07:11] Hey MaxSem I'm trying to turn on the beta mode but when I hit save the beta checkbox is still unchecked. Do you know why? [23:07:22] MaxSem: it's in my development environment [23:07:35] check cookies? [23:08:00] MaxSem: I think they are enabled, because I'm logged in [23:08:15] but are beta cookies getting set? [23:08:26] how I can check it? [23:12:08] MaxSem: so my localhost is setting 7 cookeies and none of them has the word beta [23:13:05] bmansuro_: i have the same issue am explaining it to MaxSem [23:13:27] jdlrobson: ok let me know if you guys solve it [23:13:29] looking [23:19:02] (03CR) 10Kaldari: [C: 04-1] Feature flag to permit wikiGrok on all devices (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166885 (owner: 10Robmoen) [23:22:07] 3MobileFrontend / 3stable: MobileFrontend: Page views get "#undefined" hash force appended - 10https://bugzilla.wikimedia.org/71573#c9 (10Krinkle) (In reply to Jon from comment #7) > Mmm.. What is your criteria for backporting regressions Krinkle? > We only lightning deploy when we have a serious problem - e... [23:28:52] 3MobileFrontend / 3stable: MobileFrontend: Page views get "#undefined" hash force appended - 10https://bugzilla.wikimedia.org/71573#c10 (10Jon) Krinkle I would suggest a productive way of taking this forward would be to start a wiki page highlighting what kinds of changes deserve lightning deploys. This was... [23:34:21] kaldari: do you have any instructions on how to install the WikiGrokAPI to my local environment? [23:36:12] bmansuro_: You don't really need to. You can access the API from anywhere (including your localhost). It records the host, so we can filter out developers :) [23:36:18] from the results I mean [23:36:53] bmansuro_: And there's not much need to do further development on the API since we're going to abandon it soon. [23:37:14] kaldari: can you you have the onboarding list ready to go for joaquin by friday? he's eager to start looking at bits, i already have him looking at https://www.mediawiki.org/wiki/Mobile_web/Team [23:37:21] kaldari: i see, i'm not interested in the api per se, but I want to get wikigrok working on my machine [23:37:48] bmansuro_: Just consider the WikiGrok API to be a 3rd party API [23:38:13] you don't need a local copy of it to use/develop WikiGrok [23:38:55] tfinc: You mean the list of links/resources or list of onboarding steps? [23:39:21] kaldari: latter [23:39:33] kaldari: similar to http://etherpad.wikimedia.org/p/FrontEndDevOnboarding [23:39:35] kaldari: is there a documentation where I can read on this? [23:39:45] bmansuro_: But if you want to set up a local copy you can clone it from GitHub [23:39:56] from your repo [23:40:00] yeah [23:40:00] ? [23:40:03] ok [23:41:08] kaldari: do you develop locally? [23:42:07] 3MobileFrontend / 3stable: MobileFrontend: Page views get "#undefined" hash force appended - 10https://bugzilla.wikimedia.org/71573#c11 (10Krinkle) (In reply to Jon from comment #10) > Krinkle I would suggest a productive way of taking this forward would be to > start a wiki page highlighting what kinds of c... [23:43:37] bmansuro_: Yeah, but all that code is going to be abandoned within the next couple weeks (in favor of using EventLogging (https://www.mediawiki.org/wiki/Extension:EventLogging) [23:44:18] well, for the data recording side I mean. MaxSem is currently writing the replacement code for the claim suggestions. [23:44:45] which will live in the new WikiGrok extension [23:45:11] kaldari: sure, I need to get the WikiGrok prototype working locally according to https://trello.com/c/LJgUge1b/16-learn-to-grok [23:45:40] bmansuro_: unfortunately, almost everything related to WikiGrok is currently up in the air and changing quickly so it's hard to document :( [23:45:52] kaldari: ok thanks [23:49:10] jdlrobson: were you able to get beta working locally? [23:49:28] bmansuro_: i think OuKB (MaxSem) found a bug [23:49:50] kaldari: let me know if that change worked [23:49:50] bmansuro_: Hmm, I'm not sure exactly what 'create prototype' means there, that could mean several different things, since WikiGrok has several different components. Lemme check with Maryana. [23:49:55] What's OuKB, you mean KGB? [23:49:58] tfinc: One sec.... [23:50:28] kaldari: thanks, my goals is to create and article and see A/B versions working in it. [23:50:33] and -> an [23:51:19] bmansuro_: definitely don't need to have a local copy of the WikiGrok API for that. [23:51:43] bmansuro_: One important thing I forgot to put in the documentation.... [23:51:59] kaldari: use betalabs then? even when wokring on cards? [23:53:19] bmansuro_: No, the WikiGrok code in MobileFrontend interfaces the WikiGrok API on Tool Labs, which is fine regardless of where the MobileFrontend instance is running from (as long as you have internet access). [23:54:06] kaldari: but it doesn't work with any article does it? I need specific types of articles created locally, right? [23:54:32] bmansuro_: Correct. I'm adding doucmentation on how to do local testing now... sorry I forgot that part.... [23:54:40] kaldari: thanks [23:56:17] kaldari: did you see an api2 save? [23:56:26] bmansuro_: OuKB is a username [23:56:58] jdlrobson: one sec. Haven't saved the change yet.