[00:02:18] (03PS1) 10Jdlrobson: Make wikigrok show multiple occupation suggestions when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166919 [00:02:19] any sign? [00:02:20] (03PS1) 10MaxSem: Fix switching back from alpha to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166920 [00:02:32] jdlrobson, ^^^ [00:03:37] bmansuro_: See https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok#Local_testing [00:03:46] kaldari: thank you [00:10:20] (03CR) 10Jdlrobson: [C: 031] "Special:MobileOptions doesn't work for me for some reason so can't test." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166920 (owner: 10MaxSem) [00:10:22] (03PS1) 10Jdlrobson: Hygiene: Avoid string concatenation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166923 [00:11:37] 3MobileFrontend / 3stable: MobileFrontend: Page views get "#undefined" hash force appended - 10https://bugzilla.wikimedia.org/71573#c12 (10Jon) Krinkle I understand you. I just don't agree with you that it warrants a lightning deploy. The URL still points to the same resource they wanted to share. We will ju... [00:20:28] (03PS3) 10Kaldari: Fix WikiGrokB saving [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166907 (https://bugzilla.wikimedia.org/72069) (owner: 10Jdlrobson) [00:20:53] (03CR) 10Kaldari: [C: 032] Fix WikiGrokB saving [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166907 (https://bugzilla.wikimedia.org/72069) (owner: 10Jdlrobson) [00:23:23] * OuKB diagnoses himself with deploitis: sudo git update && sudo git upgrade [00:23:36] (03PS2) 10Jdlrobson: Make wikigrok show multiple occupation suggestions when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166919 [00:24:10] (03CR) 10jenkins-bot: [V: 04-1] Make wikigrok show multiple occupation suggestions when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166919 (owner: 10Jdlrobson) [00:27:00] mhurd: did you manage to get a 6 plus case for us? [00:27:02] we just got it in [00:29:54] jdlrobson: do you know if the issue with enabling beta locally has been fixed? [00:34:45] dbrant|brb: bearND mhurd https://gerrit.wikimedia.org/r/#/c/166924/ to account for mobilefrontend path changes in mobileapp [00:35:20] YuviPanda: Great! Thank you! [00:35:26] yw [00:35:29] can't seem to sleep... [00:35:31] might as well do this [00:37:48] YuviPanda: you should check with brion how to refactor sleep patterns ;) [00:38:01] bearND: heh :) I should! [00:38:09] bearND: but the fact that I'm almost constantly travelling fucks it up even more [00:40:55] kaldari: can you point me at someone who has a nationality suggestion? [00:41:24] jdlrobson: sure, one sec... [00:41:29] jhobs, did you see the .less change? [00:43:17] yurikR: i saw your changes to the config file, yes [00:43:17] jdlrobson: Q16917029 (Magnus Burton, Sweden) [00:43:29] kaldari: thanks! [00:45:16] jdlrobson: Added item examples at https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok#Local_testing [00:45:37] dr0ptp4kt, is dfoy around [00:46:15] yurikR: not in office. don't see on chats [00:46:20] yurikR: urgent? [00:46:23] (03PS1) 10BearND: Hygiene: Back to PageActivity using ThemedActionBarActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166927 [00:46:25] no, its ok [00:46:28] thx [00:46:39] yurikR, dr0ptp4kt : how would you guys feel about setting up a backend service to request an SVG file with a certain fill/background color for zero? I could simply create alternate versions of the files but a service might be a better idea for future [00:46:41] yurikR: cool [00:47:01] yurikR, dr0ptp4kt: or does it sound unnecessary? [00:47:18] jhobs, isn't it being done as part of oojs? [00:47:43] yurikR: is it? I'll take a look at their documentation [00:47:45] jhobs: talking about w0 end user experience, portal, or both? [00:48:19] dr0ptp4kt: portal. Basically so I could use SVGs as background images and change the color simply via URL rather than create multiple PNG versions [00:48:33] dr0ptp4kt: could potentially be both though if there were other uses [00:49:08] greg-g: Any idea why this won't merge: https://gerrit.wikimedia.org/r/#/c/166907/ [00:50:20] jhobs: for mock banners to display to partner portal users, right? i think that sounds okay. maybe we can discuss with the leftover time during the standup tomorrow? [00:50:31] (03PS3) 10MaxSem: WIP: get suggestions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 [00:50:52] (03Merged) 10jenkins-bot: Fix WikiGrokB saving [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166907 (https://bugzilla.wikimedia.org/72069) (owner: 10Jdlrobson) [00:51:03] kaldari, phuedx ^^^ - would appreaciate a review [00:51:15] dr0ptp4kt: actually that wasn't the usage I had in mind, but it's definitely another one if we want to serve SVG banners in the future for some reason [00:51:22] jhobs: btw, i caught by chance on email that you were looking for a code review on the tests stuff in zeroportal. do i have that right? [00:51:38] dr0ptp4kt: my current usage is just for some icons [00:51:53] dr0ptp4kt: yeah I think I added you to that one, I don't think it was just by chance haha [00:52:11] dr0ptp4kt: oh, okay, so the point being that if you want to modify colors on the fly it's very easy to do so :) [00:52:51] dr0ptp4kt: yeah, basically with SVG if you include the inline path definitions in HTML, you can change the color via CSS very easily, but when using an img tag or setting background-image to an SVG, you can't [00:53:28] dr0ptp4kt: so the backend service would simply take a parameter or two for foreground/background color and apply the changes before returning the image to the client [00:54:11] dr0ptp4kt: it's not an urgent thing by any means, but I wanted to see if you both thought it was worth considering before I do the extra work of creating multiple images (just to have it potentially reverted further down the road) [00:54:29] dr0ptp4kt: I think discussing it at the standup tomorrow is a good idea [00:55:20] jhobs: sounds ok to me, provided the input filtering for the color parameters is strict, but yeah, let's talk with yurikR on that tomorrow in case there's some other existing facility to do that sort of thing [00:56:11] dr0ptp4kt: sounds good. I'll mention it to trevor too to see if oojs-ui is doing something like that already like yurikR mentioned [00:56:24] do you happen to know his IRC handle? [00:56:38] (i'm assuming it's TrevorP but want to be sure) [00:56:45] jhobs: one second [00:56:51] er, minute [00:56:52] jhobs, office.wikimedia.org/wiki/Contact_list [00:57:06] yurikR: right, forgot about that, thanks [00:57:12] np ) [01:03:17] kaldari: how can I enable the alpha mode through the localSettings.php file? is that even possible? [01:04:20] bmansuro_: Set $wgMFEnableBeta = true; [01:04:31] kaldari: thanks [01:05:02] bmansuro_: That enables alpha and beta modes (confusing, but at least documented: https://www.mediawiki.org/wiki/Extension:MobileFrontend#Configuration_settings) [01:05:19] kaldari: great! [01:06:43] bmansuro_: also there are 2 ways to enter alpha mode when it's enabled. Either switch on beta mode and then experimental mode in the Settings interface, or add '?mobileaction=alpha' to the end of the URL. [01:07:16] kaldari: The first method is not working and I think MaxSem found a bug. Not sure if he fixed it [01:07:23] bmansuro_: I got Maryana to clarify the Learn WikiGrok card. It should be more clear now. [01:07:33] kaldari: thanks [01:18:52] (03PS1) 10Jdlrobson: Show nationality suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 [01:21:10] (03PS2) 10Jdlrobson: Show nationality suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 [01:24:50] Notice: Undefined index: propid in /data/project/wikigrok/public_html/api2.php on line 95 [01:27:10] Fatal error: Cannot use object of type stdClass as array in /data/project/wikigrok/public_html/api2.php on line 95 [01:27:13] ^ kaldari [01:27:19] claims:[{"correct":true,"prop":"occupations","propid":"P106","value":"politician","valueid":"Q82955"},{"correct":true,"prop":"occupations","propid":"P106","value":"sociologist","valueid":"Q2306091"}] [01:28:45] (03PS3) 10Jdlrobson: Show nationality suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 [01:28:47] (03PS3) 10Jdlrobson: Make wikigrok show multiple occupation suggestions when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166919 [01:28:50] (03CR) 10jenkins-bot: [V: 04-1] Show nationality suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 (owner: 10Jdlrobson) [01:28:53] (03CR) 10jenkins-bot: [V: 04-1] Make wikigrok show multiple occupation suggestions when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166919 (owner: 10Jdlrobson) [01:32:22] (03PS4) 10Jdlrobson: Show nationality suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 [01:32:27] (03CR) 10jenkins-bot: [V: 04-1] Show nationality suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 (owner: 10Jdlrobson) [02:22:40] (03CR) 10Dbrant: [C: 032] Hygiene: Back to PageActivity using ThemedActionBarActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166927 (owner: 10BearND) [02:23:00] dbrant|brb: ty [02:23:43] bearND: np, that's much better [02:25:04] (03PS1) 10Dbrant: Fix and update ActionBar icons for Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166935 [02:25:27] (03CR) 10jenkins-bot: [V: 04-1] Fix and update ActionBar icons for Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166935 (owner: 10Dbrant) [02:26:31] (03PS2) 10Dbrant: Fix and update ActionBar icons for Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166935 [02:38:49] (03PS1) 10Dbrant: Fix top margin in fragments to account for ActionBar overlay. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166938 [02:41:11] dbrant|brb: are you going to remove the ic_drawer.png files in the icon patch, too? [02:42:48] bearND: the ic_drawer drawables are actually used by the ActionBarToggle, they just don't need to come from an SVG. (i'd like them to be pixel-perfect) [02:48:24] dbrant|brb: if they are not coming from an svg, where are they coming from? [02:49:30] bearND: I used one of those "generators": http://romannurik.github.io/AndroidAssetStudio/icons-nav-drawer-indicator.html#theme=light&color=33b5e5%2C40 [02:50:49] dbrant|brb: good to know. just noticed we have several ldpi pngs missing [02:52:49] bearND: won't it just take the hdpi image / 2? [02:54:09] dbrant|brb: probably. it still theoretically could cause differences, but this one is its own "class" of icons. So should not matter much. [02:54:54] when did the ls on the two drawables folder it looked like there was more difference at first glance, but it only one other image that's missing in ldpi: ic_pageimage_placeholder.png [02:55:08] that one is probably ok, too [03:37:16] (03PS1) 10Dbrant: Update WP Zero hint in SearchView, and a bit of cleanup. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166940 [03:39:32] (03PS2) 10Dbrant: Update WP Zero hint in SearchView, and a bit of cleanup. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166940 [03:45:17] (03CR) 10BearND: [C: 04-1] "I'm getting "sh.CommandNotFound: pngcrush"" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166935 (owner: 10Dbrant) [03:54:50] (03CR) 10BearND: [C: 032] "lgtm. Thanks for the cleanup!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166940 (owner: 10Dbrant) [03:55:10] (03Merged) 10jenkins-bot: Update WP Zero hint in SearchView, and a bit of cleanup. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166940 (owner: 10Dbrant) [03:57:29] (03PS2) 10BearND: Fix top margin in fragments to account for ActionBar overlay. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166938 (owner: 10Dbrant) [04:01:28] (03CR) 10BearND: [C: 032] "Awesome! Bonus points for using @dimens." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166938 (owner: 10Dbrant) [04:01:48] (03Merged) 10jenkins-bot: Fix top margin in fragments to account for ActionBar overlay. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166938 (owner: 10Dbrant) [04:22:52] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c9 (10Florian) I don't want to block this, so feel free to do so :) [04:53:27] (03PS3) 10Robmoen: Feature flag to permit wikiGrok on all devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166885 [05:00:37] (03PS7) 10Deskana: Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [05:00:59] (03CR) 10jenkins-bot: [V: 04-1] Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [05:04:07] (03PS8) 10Deskana: Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [05:04:51] Come on Jenkins. [05:04:54] You know I love you. [05:09:52] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c10 (10Jon) 5NEW>3RESO/FIX https://gerrit.wikimedia.org/r/166907 [05:19:06] (03CR) 10Florianschmidtwelzow: [C: 031] "Oops :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166920 (owner: 10MaxSem) [05:20:16] (03CR) 10Florianschmidtwelzow: [C: 031] "LGTM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166923 (owner: 10Jdlrobson) [05:42:52] (03PS9) 10Deskana: Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [05:47:29] (03PS10) 10Deskana: Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [05:49:22] (03CR) 10Deskana: "Now that the fragmentisation is complete, this is ready to be reviewed!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [08:03:20] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [08:03:23] (03PS7) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 [08:08:37] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/71326 (owner: 10Hashar) [08:17:59] (03PS1) 10Ebrahim: Fix false new notification and remove double format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 [08:22:24] (03PS2) 10Ebrahim: Fix false new notification and remove double format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 [08:31:44] (03CR) 10Ebrahim: "formatNotificationCount is getting formatNum once and one of them is useless however this is to fix this issue: https://en.m.wikipedia.org" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 (owner: 10Ebrahim) [08:33:56] (03CR) 10Florianschmidtwelzow: [C: 04-1] Fix false new notification and remove double format (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 (owner: 10Ebrahim) [08:35:00] (03PS3) 10Ebrahim: Fix false new notification and remove double format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 [08:37:13] (03CR) 10Florianschmidtwelzow: [C: 04-1] "same comment as ps2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 (owner: 10Ebrahim) [09:57:28] (03CR) 10Phuedx: "> Is this related to bug 45299 as well?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [09:57:39] (03CR) 10Phuedx: [C: 032] Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [09:58:15] (03Merged) 10jenkins-bot: Standardise ajax loading method [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164126 (owner: 10Jdlrobson) [11:44:06] (03CR) 10Dbrant: [C: 032] Update to new saved pages icon. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166530 (owner: 10Deskana) [11:58:35] (03PS3) 10Dbrant: Fix and update ActionBar icons for Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166935 [12:14:07] (03PS1) 10Dbrant: Fix Bus register/unregister balance. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166985 [12:25:52] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c11 (10Florian) Just to clarify: Kaldari means, that there is NO data logged, right? Or just, that it isn't logged, that version b is used? *confused* [12:27:02] (03PS1) 10Dbrant: Catch more general ApiException in Nearby task. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166987 [12:58:43] (03PS1) 10Dbrant: Show home-as-up icon instead of hamburger when searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166992 [13:10:11] weird - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7883972 [13:23:11] Krenair: patched and fixed - https://bugzilla.wikimedia.org/72066 [13:31:00] dbrant, ah right, I had been looking at the fixed code. [13:31:05] no wonder I thought it was weird :) [13:44:02] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7874672 has some stuff in common with https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7881816 [13:44:04] not sure if it's more useful [13:47:36] (03CR) 10Phuedx: [C: 04-1] "How about sub-classing Icon to hide away the tagName parameter and, in the case of links, allow a helper method to keep the implementation" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 (owner: 10Jdlrobson) [15:02:54] dbrant, have been wondering how to reproduce https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7881035 [15:03:22] Krenair: no idea :( [15:03:25] (MissingResourceException: No 3-letter country code for locale: zz_ZZ from the Locale.getISO3Country call in Nearby) [15:03:53] We can catch the error like in https://stackoverflow.com/questions/13612710/java-util-missingresourceexception-couldnt-find-3-letter-country-code-for-cs [15:06:20] Since the result will just be defaulting the person to metric (how terrible!) [15:09:08] http://blog.danlew.net/2014/04/16/android-localization-tips/ mentions zz_ZZ as "Accented English", not sure how to use it... [15:13:45] Krenair: yeah, a simple try/catch around it would be sufficient. [15:14:01] Krenair: a patch would be most welcome [15:27:15] hey bearND! [15:27:26] bearND: plenty of stuff in the queue :) [15:29:32] hey dbrant: already looking at gerrit [15:30:35] (03CR) 10BearND: [C: 032] Fix Bus register/unregister balance. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166985 (owner: 10Dbrant) [15:32:26] (03Merged) 10jenkins-bot: Fix Bus register/unregister balance. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166985 (owner: 10Dbrant) [15:34:18] dbrant: is there a bug or OTRS report for https://gerrit.wikimedia.org/r/#/c/166987? [15:34:41] (03PS2) 10BearND: Catch more general ApiException in Nearby task. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166987 (owner: 10Dbrant) [15:36:38] (03PS1) 10Alex Monk: Catch MissingResourceException because of [Developer] Accented English locale in Nearby [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167006 [15:36:59] (03CR) 10jenkins-bot: [V: 04-1] Catch MissingResourceException because of [Developer] Accented English locale in Nearby [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167006 (owner: 10Alex Monk) [15:40:20] (03CR) 10BearND: [C: 032] "good idea" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166987 (owner: 10Dbrant) [15:40:26] bearND: could have sworn I saw one in OTRS, but now can't find it... [15:40:39] (03Merged) 10jenkins-bot: Catch more general ApiException in Nearby task. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166987 (owner: 10Dbrant) [15:40:50] dbrant: it makes sense though, so ii +2'd it [15:41:43] (03PS2) 10BearND: Show home-as-up icon instead of hamburger when searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166992 (owner: 10Dbrant) [15:45:42] (03PS2) 10Alex Monk: Catch MissingResourceException because of [Developer] Accented English locale in Nearby [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167006 [15:55:01] dbrant, does your device have that language then? [15:56:14] (03CR) 10BearND: [C: 04-1] "Good catch with the action bar staying hidden in history, etc." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166992 (owner: 10Dbrant) [15:56:28] Krenair: yep, I can set it to Accented English, and reproduce the crash [15:58:45] (03PS8) 10Dbrant: [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [15:59:50] (03CR) 10Dbrant: [C: 032] Catch MissingResourceException because of [Developer] Accented English locale in Nearby [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167006 (owner: 10Alex Monk) [16:11:22] (03PS3) 10Dbrant: Show home-as-up icon instead of hamburger when searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166992 [16:12:04] bearND: ^ should be better [16:13:41] (03PS4) 10BearND: Fix and update ActionBar icons for Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166935 (owner: 10Dbrant) [16:13:56] (03CR) 10BearND: [C: 032] Fix and update ActionBar icons for Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166935 (owner: 10Dbrant) [16:14:31] (03Merged) 10jenkins-bot: Fix and update ActionBar icons for Night mode. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166935 (owner: 10Dbrant) [16:28:32] (03CR) 10BearND: [C: 04-1] Show home-as-up icon instead of hamburger when searching. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166992 (owner: 10Dbrant) [16:31:24] (03PS4) 10Dbrant: Show home-as-up icon instead of hamburger when searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166992 [16:31:31] bearND: ^ done! [16:43:19] (03PS5) 10BearND: Show home-as-up icon instead of hamburger when searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166992 (owner: 10Dbrant) [16:43:35] (03CR) 10BearND: [C: 032] Show home-as-up icon instead of hamburger when searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166992 (owner: 10Dbrant) [16:43:56] (03Merged) 10jenkins-bot: Show home-as-up icon instead of hamburger when searching. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166992 (owner: 10Dbrant) [16:47:55] (03CR) 10Jdlrobson: [C: 04-1] "Fix the spelling mistake and then feel free to +2 yourself." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166885 (owner: 10Robmoen) [16:52:40] MaxSem: Hi [16:52:48] yo [16:53:25] {{#ifeq:{{ safesubst:#if: {{ safesubst:#switch: [16:53:27] MaxSem: I've imported a page with its templates from wikpedia to my local environment, but the page doesn't render correctly. Errors like this: [16:53:32] ^ [16:53:48] MaxSem: how can I find out what extension is missing? Or why this is happening? [16:54:23] ParserFunctions [16:54:34] how? Google it! ;) [16:55:09] MaxSem: thanks, that's what I needed [16:56:19] bmansurov: i'm putting it on today's list (role button etc) [16:56:33] thedj: thanks! [17:05:49] (03PS4) 10Ebrahim: Fix false new notification and remove double format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 [17:10:11] Maryana, jdlrobson, MaxSem: This is my only day without meetings, so I'm working from home [17:10:26] :) [17:10:43] lucky… enjoy! [17:15:01] gonna give george a bath and get him to bed [17:22:28] dbrant: switch to http://www.genymotion.com/ for your next demo. its significantly faster [17:22:33] and works pretty much the same [17:22:50] plus it plugs into android studio and i imagine intellij [17:30:26] Maryana: Is Jon out today? [17:31:10] no, he's here :) [17:46:49] (03CR) 10Kaldari: [C: 04-1] Hygiene: Merge wikigrokeval and wikigrok (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166899 (owner: 10Jdlrobson) [17:52:13] MaxSem: what would be a better category fir this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=69765 ? :) [17:52:20] (03PS4) 10Robmoen: Feature flag to permit wikiGrok on all devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166885 [17:52:35] (03PS5) 10Ebrahim: Fix false new notification and remove double format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 [17:52:43] FlorianSW, RT would be most noticeable for ops [17:53:20] MaxSem: ok, there is just one problem :P In bugzilla no good place? [17:53:48] prolly not [17:54:29] MaxSem: ok :) then i will try to find someone who can report this in rt in #wikimedia-operations next time :) Thanks [17:54:35] best wouuld be to post to RT (via email to ops-requests@wikimedia.org and cc mobile-tech) [17:54:38] (03CR) 10Robmoen: [C: 032] Feature flag to permit wikiGrok on all devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166885 (owner: 10Robmoen) [17:54:50] MaxSem: oh, ok :) [17:57:39] (03CR) 10Jdlrobson: "Hey Ebrahim is there a bug associated with this? How do I replicate the problem this fixes?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 (owner: 10Ebrahim) [17:58:54] 3MobileFrontend / 3stable: headings info on any page no longer expand/collapse - 10https://bugzilla.wikimedia.org/72142 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16789 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16789&action=edit sections always expanded On any... [18:00:36] (03CR) 10Florianschmidtwelzow: [C: 031] "Fixes the problem and LGTM, but a bug report would be great, as Jon said :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 (owner: 10Ebrahim) [18:03:01] vbamba: Ping! Retrospective. :) [18:03:48] brion are you retrospecting? [18:04:08] kristenlans: i’m in the frontend standards group meeting, will join y’all in 15 mins :D [18:04:25] (03CR) 10Florianschmidtwelzow: "Probably seperate the list styling from page-list, LanguageOverlay is using page-list, too (without to list pages), NotificationsOverlay h" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 (owner: 10Florianschmidtwelzow) [18:04:28] brion: 10-4 [18:04:49] (03Merged) 10jenkins-bot: Feature flag to permit wikiGrok on all devices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166885 (owner: 10Robmoen) [18:06:15] (03CR) 10Kaldari: [C: 04-1] Hygiene: Cleanup drawer markup (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [18:06:26] https://etherpad.wikimedia.org/p/MobileAppRetrospective [18:07:38] (03CR) 10Kaldari: [C: 032] Hygiene: Cleanup drawer markup (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [18:08:15] (03Merged) 10jenkins-bot: Hygiene: Cleanup drawer markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164125 (owner: 10Jdlrobson) [18:24:08] (03CR) 10Ebrahim: "> same comment as ps2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 (owner: 10Ebrahim) [18:35:22] (03PS6) 10Jdlrobson: Fix false new notification and remove double format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 (https://bugzilla.wikimedia.org/72143) (owner: 10Ebrahim) [18:35:40] 3MobileFrontend / 3stable: Issue with zero notifications on persian wikis - 10https://bugzilla.wikimedia.org/72143 (10Jon) 3NEW p:3Unprio s:3normal a:3None Setup a MediaWiki with Echo and MobileFrontend then set user language to Persian (like https://en.m.wikipedia.org/wiki/Main_Page?uselang=fa while... [18:41:17] (03CR) 10MaxSem: [C: 032] Fix false new notification and remove double format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 (https://bugzilla.wikimedia.org/72143) (owner: 10Ebrahim) [18:41:28] MaxSem: waaaiittt [18:41:43] there was a reason we were doing $this->getLanguage()->formatNum( $count ) ) [18:41:49] (03Merged) 10jenkins-bot: Fix false new notification and remove double format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 (https://bugzilla.wikimedia.org/72143) (owner: 10Ebrahim) [18:42:08] kaldari: do you remember why? [18:42:18] i'm worried this is going to introduce a regression.. [18:42:21] (03CR) 10Alex Monk: Fix false new notification and remove double format (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 (https://bugzilla.wikimedia.org/72143) (owner: 10Ebrahim) [18:42:27] jdlrobso_: why what? [18:42:37] $this->getLanguage()->formatNum( $count ) ) < kaldari [18:42:41] jdlrobso_, yes, I just commented on that [18:42:41] has just been replaced with $count [18:42:45] You merged it too quickly for me :) [18:42:54] bad MaxSem [18:43:01] WINWINWIN [18:43:06] Krenair: i'll revert [18:43:13] (03CR) 10Florianschmidtwelzow: Fix false new notification and remove double format (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166960 (https://bugzilla.wikimedia.org/72143) (owner: 10Ebrahim) [18:43:14] jdlrobso_: Is that for the notification count? [18:43:14] I remember fighting this bug in Echo. :( [18:43:23] (03PS1) 10Jdlrobson: Revert "Fix false new notification and remove double format" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167039 [18:43:43] https://en.m.wikipedia.org/wiki/Main_Page?uselang=fa < isn't that the persian version of 0 ? [18:43:44] jdlrobso_, Echo already formats it [18:44:00] well, if zero, it shouldn't show the number [18:44:00] jdlrobso_, I guess removing that formatNum call made languages with non-English numbers (e.g. Persian - fa) show the English digits? [18:44:13] jdlrobso_: I believe it's removed since bmansuro_ fixed the broken code in MF that wasn't properly formatting the number (due to bypassing the API) [18:44:33] (03CR) 10Florianschmidtwelzow: [C: 04-1] "> This disables localisation of numbers" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167039 (owner: 10Jdlrobson) [18:44:36] so it previously double-formatted [18:44:39] https://en.wiktionary.org/wiki/%DB%B0 < MaxSem [18:44:52] jdlrobso_, Krenair: That's handled by Echo [18:45:04] http://i.imgur.com/AjUUAX1.png < there is nothing wrong with this then no? That is the number zero [18:45:07] jdlrobso_, aaaand? [18:45:10] kaldari: it's not [18:45:26] jdlrobso_: yes it is [18:45:29] we should not show 0 in a red rect [18:45:53] jdlrobso_, see EchoNotificationController::formatNotificationCount() [18:45:55] jdlrobso_: But originally we were bypassing that completely, now we're only bypassing the last part [18:46:13] but this will stop any other numbers getting translated in the process [18:46:24] jdlrobso_: That's why we we're getting '99+' eariler as well, but it's fixed now [18:46:33] we're = weren't [18:46:56] jdlrobso_: no it won't see EchoNotificationController::formatNotificationCount() [18:47:11] jdlrobso_: it handles everything for us [18:47:12] i'm very confused now [18:47:17] kaldari, jdlrobso_: https://github.com/wikimedia/mediawiki-extensions-Echo/blob/55ef794d747e1b35cfb0f3f9736bbeea7f1112fb/controller/NotificationController.php#L35 [18:47:27] oh wait we override $count [18:47:28] there is already a formatNum :) [18:47:31] just for us :P [18:47:35] that's sucky [18:47:40] $count = EchoNotificationController::formatNotificationCount [18:47:50] that should be renamed to $countLabel [18:48:22] (03Abandoned) 10Jdlrobson: Revert "Fix false new notification and remove double format" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167039 (owner: 10Jdlrobson) [18:48:29] It is possible to set $count = ''; only, when there is no echo :) [18:48:55] it's not a label i think :/ [18:49:38] (03PS1) 10Jdlrobson: Hygiene: Make notification code more readable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167041 [18:49:42] ^ this makes it more readable at least for me [18:50:37] 3MobileFrontend / 3stable: Issue with zero notifications on persian wikis - 10https://bugzilla.wikimedia.org/72143 (10Jon) 5PATC>3RESO/FIX [18:51:48] (03CR) 10Jdlrobson: "In a follow up patch maybe? :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 (owner: 10Jdlrobson) [18:51:50] (03CR) 10Florianschmidtwelzow: "i have no problem with this rename :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167041 (owner: 10Jdlrobson) [18:51:55] (03CR) 10Florianschmidtwelzow: [C: 031] Hygiene: Make notification code more readable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167041 (owner: 10Jdlrobson) [18:52:17] (03PS4) 10Jdlrobson: Hygiene: Introduce Icon.js abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 [18:53:21] kaldari: wtf? :) https://gerrit.wikimedia.org/r/#/c/166899/1/javascripts/modules/wikigrok/wikigrok.js [18:53:23] not sure what you mean [18:53:50] there is no self in this context [18:53:57] plus i'm only moving the code from one place to another [18:54:16] jdlrobso_: I know, you'll have to declare self=this up higher [18:54:23] kaldari: there is no self.. [18:54:29] it's an initialisation script [18:54:40] it needs to get the id [18:54:57] it oh wait you mean use wikiDataId [18:55:04] the variable above? [18:55:12] yeah, just use the one that's already set [18:55:25] sorry I didn't explain that well [18:55:43] ok done [18:55:43] (03PS2) 10Jdlrobson: Hygiene: Merge wikigrokeval and wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166899 [18:55:48] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Merge wikigrokeval and wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166899 (owner: 10Jdlrobson) [18:56:07] (03CR) 10Kaldari: [C: 032] Hygiene: Make notification code more readable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167041 (owner: 10Jdlrobson) [18:56:40] (03Merged) 10jenkins-bot: Hygiene: Make notification code more readable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167041 (owner: 10Jdlrobson) [18:56:57] bmansuro_: in terms of whitespace problems you've been having i don't think jshint has an option for that but feel free to write a pre-commit hook or explore that [18:57:53] jdlrobso_: the whitespace convention that we use is confusing itself, because why put a space after ( but not after [ ? [18:59:22] 3MobileFrontend / 3stable: On action=info page headings do not expand/collapse - 10https://bugzilla.wikimedia.org/72142#c1 (10Jon) I expect it's been happening much longer than that... the MobileFormatter doesn't run on this page but the JS loads so the tables do not get wrapped in divs. Toggling javascript... [18:59:52] 3MobileFrontend / 3alpha: WikiGrok version B not recording data - 10https://bugzilla.wikimedia.org/72069#c12 (10Jon) Yeh data was not getting saved when you completed wikigrok dialog b. [19:00:23] bmansuro_: [foo] notation only has one parameter, the spaces help readability of different parameters [19:00:44] the space after the keyword distinguishes keywords from functions [19:00:47] there is logic to the madness :) [19:01:12] jdlrobso_: ^ then i think, your patch doesn't solve this bug :/ There will be still no occupationId, which isn't optional [19:01:12] jdlrobso_: [a, b, c]? [19:01:24] jdlrobso_: https://bugzilla.wikimedia.org/show_bug.cgi?id=72069#c12 [19:01:40] https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Whitespace [19:02:28] bmansuro_: make a proposal on the talk page for arrays. [foo] notation [19:02:51] jdlrobso_: i'm actually against using spaces inside parenthesis [19:02:57] jdlrobso_: the wikigrokeval stuff looks good now (justed tested it). If you rebase it, I'll merge [19:02:58] Keywords followed by a "(" (left parenthesis) must be separated by one space. This gives visual distinction between keywords and function invocations. < that's the current justification [19:03:16] bmansuro_: i don't make the rules consensus does :) [19:03:34] jdlrobso_: ok, i'll try and add a jshint rule [19:03:50] kaldari: :) [19:04:52] bmansuro_: If you ever want to suggest changing the coding conventions, just post a comment at https://www.mediawiki.org/wiki/Manual_talk:Coding_conventions/PHP or https://www.mediawiki.org/wiki/Manual_talk:Coding_conventions/JavaScript [19:05:34] kaldari: thanks, I will. but do you think it's realistic that if a convention is accepted, we'll reformat the existing code? [19:08:54] bmansuro_: we did for other things so it's realistic :) [19:09:03] for example we used to fail jshint like crazy :) [19:09:44] i see [19:09:45] jdlrobso_, kaldari: i want to push to review a change for this card: https://trello.com/c/G31kBxoD/10-2-wikigrok-version-b-ux-changes how do i link to it? Or no link (like for a bug report?) [19:10:01] FlorianSW: add your face to the card [19:10:10] and move it to the in dev/code review column [19:10:14] i did already jdlrobso_ :) [19:10:16] it makes sure no one else picks it up [19:10:21] and then paste the link in the comments :) [19:10:35] ok :) [19:10:41] bmansuro_: usually when a coding convention is changed, it mostly just applies to new code, although occassionally people go through and convert old code as well. [19:10:51] (03PS1) 10Florianschmidtwelzow: WikiGrok version b UX changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167053 [19:11:05] bmansuro_: thus why we try not to change the coding conventions too often :) [19:11:30] kaldari: ok [19:12:36] (03PS2) 10Florianschmidtwelzow: WikiGrok version b UX changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167053 [19:13:06] (03PS13) 10Dbrant: Implement syntax highlighting in Edit window. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/137684 [19:15:36] (03PS9) 10Dbrant: [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [19:16:20] (03PS9) 10Dbrant: [very WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [19:19:47] (03CR) 10Jdlrobson: [C: 04-1] "Doesn't seem to be working. I've worked out why." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [19:25:35] kaldari: in order to construct a claim like this (Was this person a [cast member, role] in this [movie, TV show]?) we need both the list of occupations related to movies and list of movies, am I right? [19:28:10] sounds like it. There is a property 'field of work' that might be useful here, like 'field of work: movies' for an occupation. [19:28:27] bmansuro_: although I have no idea if that's used consistantly at this point [19:30:08] bmansuro_: we could either compile a hard list of movie-related occupations and use that, or make sure that all those occupations have 'field of work: movies(?)' assigned to them in wikidata. [19:31:16] bmansurov: there are 2 of you! :) [19:31:36] bmansurov: did you see my replies? [19:31:36] (03CR) 10Jdlrobson: [C: 04-1] "Thanks Florian!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167053 (owner: 10Florianschmidtwelzow) [19:32:18] kaldari: i don't understand how. the last one I saw was: kaldari: sounds like it. [19:32:40] bmansurov: yeah, you missed a few other replies... [19:33:07] bmansurov: although I have no idea if that's used consistantly at this point [19:33:22] bmansurov: we could either compile a hard list of movie-related occupations and use that, or make sure that all those occupations have 'field of work: movies(?)' assigned to them in wikidata. [19:34:02] (03PS6) 10Dbrant: [WIP] hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 [19:34:12] bmansurov: to do that actual queries we would need to use http://wdq.wmflabs.org/ in the short term, and Max's replacement later. [19:35:02] kaldari: ok [19:35:34] bmansurov: unfortunately, http://wdq.wmflabs.org/ is the only thing that let's us do complex queries against Wikidata right now, but it's kind of a hack written by a volunteer (Magnus) [19:36:24] bmansurov: and it sounds like the wikidata team (at WMDE) isn't going to add support for such queries any time soon :( [19:36:41] kaldari: i see [19:36:55] (03CR) 10Florianschmidtwelzow: "Really no option for the user to close the overlay without reading more about Wikidata? :o" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167053 (owner: 10Florianschmidtwelzow) [19:37:28] (03PS7) 10Dbrant: [WIP] hide IPA. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165650 [19:37:34] jdlrobso_: ^ [19:37:58] FlorianSW: really. they can just skim past it :) [19:38:03] bmansurov: Also keep in mind that none of these 'generate potential claims' queries will need to be executed in real time. They will likely be slow and have to be cached, but that will be handled at a higher level. [19:38:17] jdlrobso_: ok :) [19:38:42] kaldari: I think the site already claims that the data may be old [19:39:39] bmansurov: Yeah, their data is old and the data we generate from it will also be cached, so we have 2 levels of staleness :( But hopefully this sort of data won't change very often. [19:40:24] bmansurov: So even if both layers regenerate once a day, probably won't be too horrible. [19:40:44] kaldari: yeah [19:40:59] bmansurov: although I should find out from Magnus how stale that data actually is [19:41:18] Lunch! [19:49:26] (03PS3) 10Florianschmidtwelzow: WikiGrok version b UX changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167053 [19:53:06] (03PS8) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [19:53:08] (03PS5) 10Jdlrobson: Hygiene: Introduce Icon.js abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 [19:53:39] (03CR) 10jenkins-bot: [V: 04-1] Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [20:07:16] (03PS9) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [20:08:06] (03CR) 10jenkins-bot: [V: 04-1] Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [20:16:08] (03CR) 10Jdlrobson: [C: 04-1] "* When closing tell me more, I still see wikigrok (it should remove it)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167053 (owner: 10Florianschmidtwelzow) [20:18:47] kristenlans: howdy [20:19:11] kaldari_lunch: yo! [20:19:12] (03CR) 10Jdlrobson: [C: 032] "Ignore second comment. The first comment is still a problem but that can be done in a separate patchset." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167053 (owner: 10Florianschmidtwelzow) [20:19:49] (03Merged) 10jenkins-bot: WikiGrok version b UX changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167053 (owner: 10Florianschmidtwelzow) [20:21:10] kristenlans: sorry, I didn't realize I was needed for that meeting [20:21:39] kristenlans: my bad [20:21:43] kaldari_lunch: no problem, sorry if it was unclear. Do you want to convene now-ish or try to reschedule? [20:21:45] (03CR) 10Florianschmidtwelzow: "> Ignore second comment. The first comment is still a problem but that can be done in a separate patchset." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167053 (owner: 10Florianschmidtwelzow) [20:21:55] kaity|away: nowish is great [20:22:23] kaldari: 10-4 moizsyed Maryana …ACTIVATE! [20:22:32] err [20:22:35] moiz wandered off [20:22:36] haha [20:22:38] to work on design [20:22:38] alright [20:22:42] let's reschedule [20:22:43] im coming back [20:22:50] you don't really have anything to demo, though, right? [20:22:54] no i dont [20:22:58] well then [20:23:00] in that case... [20:23:14] i'd rather do this in person, too, honestly [20:23:27] yeah [20:23:30] in person is better [20:23:34] moizsyed, Maryana: sorry, my bad for not realizing I was supposed to go to this meeting :P [20:23:39] np [20:23:41] thats ok [20:23:49] moiz wasn't ready, either ;) [20:24:07] Maryana: i thought i mentioned it yesterday that I wont have much to show today [20:24:21] i'm just teasin [20:24:24] it's fine [20:24:28] let's try tomorrow, ok? [20:24:31] you better :) [20:24:34] Maryana, moizsyed, kristenlans: I'm open tomorrow [20:24:34] tomorrow is good [20:24:47] (03PS1) 10Jdlrobson: Cleanup WikiGrok dialog b footer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167063 [20:25:23] kaldari Maryana moizsyed moved to tomorrow! [20:25:30] accepted [20:25:33] thanks kristenlans! [20:25:49] thank YOU moizsyed [20:26:00] kristenlans: thanks! [20:32:05] (03CR) 10Dr0ptp4kt: [C: 032] Add tests for home page [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/166616 (owner: 10Jhobs) [20:32:29] (03Merged) 10jenkins-bot: Add tests for home page [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/166616 (owner: 10Jhobs) [20:40:49] bmansurov_, phuedx: updated the local testing instructions for WikiGrok per Rob's new config var: https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok#Local_testing [20:41:02] kaldari: cool [20:49:30] dbrant|brb, bearND, YuviPanda|zzzz: Do you know what event_source='blocked' is in the MobileWikiAppCreateAccount schema? [20:51:46] mhurd: I setup this quick landing page for Wikipedia app http://moizsyed.github.io/WikipediaiOS/ [20:52:08] moizsyed: whoa! awesome!!!! [20:52:09] you can share that on twitter and other places to encourage people to download [20:52:32] will do! [20:55:25] (03PS6) 10Jdlrobson: Hygiene: Introduce Icon.js abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 [20:56:42] (03PS3) 10Jdlrobson: Hygiene: Merge wikigrokeval and wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166899 [20:57:13] moizsyed: <3 [21:01:54] 3Wikipedia App / 3Android App: 404 when trying to download new alpha - 10https://bugzilla.wikimedia.org/72151 (10matanya) 3NEW p:3Unprio s:3normal a:3None https://tools.wmflabs.org/wikipedia-android-builds/runs/latest/wikipedia.apk returns 404 when trying to download new build due to wrong file nami... [21:10:33] Deskana: no idea why blocked is in the create account schema. I don't see it used in the Android code. In Android we only use the blocked source from the login schema. [21:10:45] as far as I can see [21:11:21] Grepping throug the code I also noticed an interesting sounding string resource: "You cannot create an account because your account is blocked" [21:11:41] sounds weird [21:11:48] bearND: Deskana: CreateAccountActivity.java : 200 [21:12:04] * Deskana looks [21:12:51] dbrant|brb: that's where the string resource i just mentioned is used, but i don't see the funnel stuff for what Deskana was asking [21:13:34] bearND: Deskana: the funnel call would happen at line 290 [21:14:13] ah, thanks dbrant|brb [21:14:25] So what's the user flow here? [21:16:15] How does one come to the account creation screen from a blocked message? [21:17:18] Deskana: I suppose it means that the user came "back" to the account creation screen (from the account creation screen) because they were blocked. [21:18:50] Okay, I'll try and verify that. [21:18:51] Thanks. :) [21:22:26] (03PS1) 10Jdlrobson: Make opting into beta/alpha work on localhost [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 [21:23:01] (03CR) 10jenkins-bot: [V: 04-1] Make opting into beta/alpha work on localhost [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 (owner: 10Jdlrobson) [21:26:00] (03PS2) 10Jdlrobson: Fix switching back from alpha to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166920 (owner: 10MaxSem) [21:27:13] (03CR) 10Jdlrobson: [C: 032] Fix switching back from alpha to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166920 (owner: 10MaxSem) [21:27:45] (03Merged) 10jenkins-bot: Fix switching back from alpha to beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166920 (owner: 10MaxSem) [21:28:16] (03PS2) 10MaxSem: Hygiene: Avoid string concatenation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166923 (owner: 10Jdlrobson) [21:28:27] yurikR: given the access control on the "partner" logins for zero.wikimedia.org, can you think of a reason we couldn't put the test login into jenkins for automated job runs? the main thing we'd need to avoid is introducing code that would let that test id be able to modify ips without stage gating by a human, i think. [21:28:30] (03CR) 10MaxSem: [C: 032] Hygiene: Avoid string concatenation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166923 (owner: 10Jdlrobson) [21:28:33] Deskana: maybe those string resources provide some insight: "You cannot create an account because your IP is blocked", "You cannot create an account because your account is blocked" [21:28:58] bearND: I was actually the one that added those when I overhauled the API error response handling ;) [21:29:07] (03Merged) 10jenkins-bot: Hygiene: Avoid string concatenation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166923 (owner: 10Jdlrobson) [21:29:47] bearND: The thing about those is that they should be dead-ends. You're already on the account creation screen, so I don't see how that could be a "source" like onboarding and edit workflow are. [21:30:00] dr0ptp4kt, can we think of a way to make login private somehow? I would rather not publish it, but you are right, it is not that big of a deal (at least not yet) [21:31:18] sounds weird [21:31:21] Sorry, what's weird about that? [21:32:02] Krenair: about "You cannot create an account because your account is blocked"? [21:32:05] yes [21:32:33] You can create accounts while logged in, but not if you're blocked. [21:32:38] yurikR: i _believe_ the credential would still be stored in a private location, but i think it has more to do with the hosting environment. i'm gonna check on that thread what the risk is, although you and i seem to be on the same page [21:32:40] (as crazy as that sounds) [21:32:47] How is that crazy...? [21:33:07] Krenair: Can you do that on other major web properties? [21:33:17] What, create accounts while logged in? [21:33:32] Krenair: Yeah. [21:33:45] Haha. [21:34:00] * Deskana must've missed the joke. [21:34:14] Deskana: Can you edit most pages on other major web properties? [21:34:53] Okay, this isn't a constructive conversation for us to be having. Thanks for your input, Krenair. :) [21:35:23] 3MobileFrontend / 3stable: List of languages looks strange when mixes RTL and LTR languages - 10https://bugzilla.wikimedia.org/64617 (10Jon) [21:36:02] MediaWiki lets ordinary users do a lot of things that would usually be reserved for administrators on most other sites. [21:36:45] And actually yes, I can create a new google account while logged in. [21:38:01] kaldari: where was the list of things that you want the wd api to do? [21:38:04] i'm sure i saw one [21:38:54] 3Wikipedia App / 3Android App: 404 when trying to download new alpha - 10https://bugzilla.wikimedia.org/72151#c1 (10Bernd Sitzmann) a:3Yuvi Panda AFAIK, Yuvi is working on this. [21:45:41] MaxSem: It's been almost a month, but I haven't obtained a cloak yet. Who should I talk to to get one? [21:46:13] don't worry, I've been told that this is "normal" :P [21:47:39] MaxSem: ok thanks [21:49:39] phuedx: ooh wat, there's a list? [21:49:50] i thought there was a list [21:49:55] i'm likely mistaken [21:50:02] there are like 5 different wikidata dreamlists [21:50:43] some of it is in that doc i shared w/mobile-tech [21:50:50] but that's a bit outdated at this point [21:50:56] that's probably what i was thinking of [21:51:05] i can reshare if you can't find it [21:51:13] googledocs, how do they work? [21:51:42] like all things google: magic and advertising [21:51:53] Magnets, how do they work ? [21:52:24] magic and advertising [21:53:01] sorry i've been quiet all day folks. been grepping through the grok and the datas for the spike. I'm doing my best to answer the questions. I think I need to understand WikiData more. Got the Grok bit down mostly [21:53:11] Grepping through grok docs [21:53:23] grep the grok and then git the gerrit [21:53:24] grokking through the greps [21:53:39] Yeap i'm gonna make a grok rap [21:53:47] Grok-hop [21:54:03] CAN I GET A REEEEE BASE? [21:54:04] the winner of today's ultranerd prize, ladies and gentlemen ^ [21:54:20] ohhh, dan the dark horse pulled through by a hair! [21:54:23] :) [21:54:57] man, i'm now regretting not having trolled y'all hard with the learn to grok stuff. should've asked you to figure out what a snak is [21:55:04] because NOBODY KNOWS [21:55:04] Rebasin' onto master since 2014 [21:55:06] dude [21:55:10] WAT is SNAK [21:55:15] greppa: drink, distilled sweat from the brow of a developer desperately trying to find uses of a variable [21:55:15] still learning that one [21:55:29] I like snaks [21:55:56] snaks are what you need when your brain is melting from trying to figure out whether something is a claim or a statement [21:56:06] we need flash cards, basically [21:56:38] Introducing "RESET HARD", for when alcohol doesn't cause you to blackout enough any more. [21:57:12] a snak is a value assigned to an entity with a property without a reference (!!!???) [21:57:18] multinterrobang [21:57:48] i just keep coming back to this: https://en.wikipedia.org/wiki/Celestial_Emporium_of_Benevolent_Knowledge [21:58:04] I fixed a typo in the documentation. So far, that's what i've done today. [21:58:37] We need to start a class WikiData for dummies or something [21:58:45] I'd sit in on that [22:00:40] did the research spike help you any, phuedx? [22:00:59] help in the sense of help make any of this slightly less abstract/ambiguous? [22:01:26] Maryana: i gleaned enough terminology to be dangerous [22:01:32] oh dear [22:01:39] but i'd used the wikidataquery thing before [22:01:55] i should spend more time grokking docs [22:02:12] rmoen: with a quiz at the end? :) [22:02:25] yeah [22:03:10] would it help if this was all more hands-on? [22:03:10] Maryana: the spike has led me to understand our current grok system, and leaving me with a small list of questions that can hopefully be answered. (still drafting that) [22:03:29] ok, that's not too bad, actually [22:03:52] i was half-expecting to hear "the spike has led me to conclude that i'd rather shoot myself in the face than work on this. bang." [22:04:14] I still have some reading to do. I may end up there. [22:04:25] there's /always/ learning to do [22:05:10] (03PS20) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [22:05:22] yeah, i dunno how you guys prefer to do the learning part. i think it's different for different devs – like jon would want to just dive in and build something, but kaldari would go read the docs [22:05:44] (03CR) 10jenkins-bot: [V: 04-1] Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [22:06:08] i read code [22:06:27] i've got a copy of wikidataquery and i'm going through that too [22:06:33] (03PS21) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [22:06:58] i read docs for terminology [22:07:03] then once i'm fluent i read code [22:07:17] (03CR) 10jenkins-bot: [V: 04-1] Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [22:07:21] s/fluent/know enough to be dangerous/ [22:08:00] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [22:10:58] gonna go watch something and then sleep [22:11:00] g'night folks [22:11:06] phuedx: gnight [22:11:25] night phuedx! [22:11:32] thanks for the grokin [22:26:57] Maryana: you need offee? [22:27:05] yes, offee is my favorite [22:27:14] cool let's go for offee or ea [22:27:14] mmm offeeee [22:27:15] (03CR) 10Kaldari: [C: 032] Hygiene: Merge wikigrokeval and wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166899 (owner: 10Jdlrobson) [22:27:19] ew no [22:27:21] no ea [22:27:24] only offee [22:27:25] :) [22:27:59] (03CR) 10Jdlrobson: [C: 04-1] "apart from that i think this looksgood" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [22:29:48] (03CR) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [22:39:20] (03Merged) 10jenkins-bot: Hygiene: Merge wikigrokeval and wikigrok [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166899 (owner: 10Jdlrobson) [22:40:41] (03CR) 10Bmansurov: "I don't think there is any need for this patch. Some other changes seem to have fixed the issue." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) (owner: 10Bmansurov) [22:41:13] (03PS4) 10MaxSem: WIP: get suggestions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 [22:42:11] (03CR) 10Bmansurov: Hygiene: Abuse filter action button does not conform to the styleguide (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166702 (https://bugzilla.wikimedia.org/72049) (owner: 10Bmansurov) [22:43:30] (03PS1) 10Dbrant: Use built-in ProgressBar inside the ActionBar when loading page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167118 [22:45:05] (03PS2) 10Bmansurov: Make abuse filter button progressive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166702 (https://bugzilla.wikimedia.org/72049) [22:45:07] (03CR) 10jenkins-bot: [V: 04-1] Use built-in ProgressBar inside the ActionBar when loading page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167118 (owner: 10Dbrant) [22:59:06] (03PS5) 10MaxSem: WIP: get suggestions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 [22:59:23] (03CR) 10Jdlrobson: [C: 032] Make abuse filter button progressive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166702 (https://bugzilla.wikimedia.org/72049) (owner: 10Bmansurov) [23:03:49] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166702 (https://bugzilla.wikimedia.org/72049) (owner: 10Bmansurov) [23:03:53] (03CR) 10Jdlrobson: [C: 032] Make abuse filter button progressive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166702 (https://bugzilla.wikimedia.org/72049) (owner: 10Bmansurov) [23:05:20] (03CR) 10Jdlrobson: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [23:06:34] (03PS2) 10Jdlrobson: Make opting into beta/alpha work on localhost [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 [23:07:07] (03CR) 10jenkins-bot: [V: 04-1] Make opting into beta/alpha work on localhost [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 (owner: 10Jdlrobson) [23:07:23] bmansurov: btw i forgot to say - the fact beta/alpha doesn't work for you is because you are running off localhost use http://127.0.0.1:8080/ instead [23:08:09] jdlrobson: thanks, good to know [23:12:23] (03Merged) 10jenkins-bot: Make abuse filter button progressive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166702 (https://bugzilla.wikimedia.org/72049) (owner: 10Bmansurov) [23:14:54] 3MobileFrontend / 3Hygiene: Hygiene: localTemplateBasePath should be the same as localBasePath - 10https://bugzilla.wikimedia.org/72161 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon localTemplateBasePath should be the same as localBasePath When templates are in core localTemplateBasePath will no longer ex... [23:15:07] 3MobileFrontend / 3stable: abuse filter action button does not conform to the styleguide - 10https://bugzilla.wikimedia.org/72049 (10Jon) 5PATC>3RESO/FIX [23:49:50] jdlrobson: you there? [23:51:07] bmansurov: sure what's up [23:51:52] jdlrobson: i think the toggle js tests are not constructed well and should actually fail. rather than selecting 'h2', we should select '.section-heading' [23:52:16] bmansurov: sounds like we need a browser test :) [23:52:41] jdlrobson: but we when I do so, the result is 0 elements, because the html that's constructed in makeSections is wrapped in a div [23:53:01] and in toggle.js we're adding 'section-heading' to direct children of #content [23:53:19] jdlrobson: just wanted to point out, something we need to think about later [23:53:28] k [23:59:41] jdlrobson: bmansurov that is eerily similar to https://bugzilla.wikimedia.org/show_bug.cgi?id=72142, shown by a browser test