[00:00:42] chrismcmahon: that's a different problem. I'm not even sure if that was ever meant to work [00:01:07] 3MobileFrontend / 3stable: On action=info page headings do not expand/collapse - 10https://bugzilla.wikimedia.org/72142#c2 (10Chris McMahon) I have this test passing as of 13 October [00:01:22] jdlrobson: yeah, it's odd, I updated the bz issue [00:02:12] (03PS2) 10Dbrant: Use built-in ProgressBar inside the ActionBar when loading page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167118 [00:04:55] (03PS22) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [00:16:21] (03CR) 10Bmansurov: "I've created another bug for this: https://bugzilla.wikimedia.org/show_bug.cgi?id=72165" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166075 (https://bugzilla.wikimedia.org/66679) (owner: 10Bmansurov) [00:16:34] (03Abandoned) 10Bmansurov: Wrap math formulas in a scrollable div [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166075 (https://bugzilla.wikimedia.org/66679) (owner: 10Bmansurov) [00:39:44] MaxSem: hey, when I run 'make phpunit' I see 'No tests executed!'. Do you know why? [00:40:05] someone broke it? [00:40:24] no error messages [00:40:46] do it from core: cd tests/phpunit && php phpunit.php --group=MobileFrontend [00:41:31] MaxSem: thanks, it's working now [00:42:58] (03PS6) 10MaxSem: WIP: get suggestions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 [01:06:48] (03PS3) 10Dbrant: Use built-in ProgressBar inside the ActionBar when loading page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167118 [01:08:16] (03PS4) 10Jdlrobson: Make wikigrok show multiple occupation suggestions when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166919 [01:08:50] (03CR) 10jenkins-bot: [V: 04-1] Make wikigrok show multiple occupation suggestions when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166919 (owner: 10Jdlrobson) [01:09:08] (03PS5) 10Jdlrobson: Show nationality suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 [01:13:48] (03PS4) 10Dbrant: Use built-in ProgressBar inside the ActionBar when loading page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167118 [01:22:25] bearND: haha didn’t realize i was in wrong channel :) [01:22:52] mhurd: lolz [01:24:44] MaxSem: thanks again for the search ordering patch: https://gerrit.wikimedia.org/r/#/c/158011/2/javascripts/modules/search/SearchApi.js [01:24:59] :) [01:25:09] MaxSem: app now uses same params [01:25:29] mhurd: you mean iOS app [01:25:45] bearND: oh yea :) won’t be live for a bit [01:25:54] Android still needs to update [01:26:15] bearND: given apple’s review times you guys will probably go live first [01:41:56] tfinc: https://wikimediafoundation.org/wiki/User:DBrant_(WMF)/Nearby_blog_post [02:46:23] (03PS1) 10BearND: WIP: Find in Page as CAB and ActionProvider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167164 [03:21:30] (03PS5) 10Kaldari: Make wikigrok show multiple occupation suggestions when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166919 (owner: 10Jdlrobson) [03:21:42] (03CR) 10Kaldari: [C: 032] Make wikigrok show multiple occupation suggestions when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166919 (owner: 10Jdlrobson) [03:22:16] (03Merged) 10jenkins-bot: Make wikigrok show multiple occupation suggestions when available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166919 (owner: 10Jdlrobson) [04:41:49] (03PS2) 10BearND: Find in Page as CAB and ActionProvider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167164 [05:44:05] (03PS3) 10BearND: Find in Page as CAB and ActionProvider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167164 [05:45:28] (03PS4) 10BearND: Find in Page as CAB and ActionProvider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167164 [05:50:10] (03PS5) 10BearND: Find in Page as CAB and ActionProvider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167164 [06:20:19] (03CR) 10BearND: "Awesome feature." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167118 (owner: 10Dbrant) [08:58:16] morning al [08:58:22] morning all [08:58:27] al aswell, obvs [08:58:48] [08:59:30] * YuviPanda wonders if phuedx will valiantly follow a semblance of sun-set biological clock or will succumb to the IRC set biological-clock [09:01:35] YuviPanda: it's been hard [09:01:42] yeaaaah. [09:01:51] i've found myself drifting into irc-clock land [09:01:54] yup. [09:02:00] you'll be deep in CR and then find it's 4AM [09:02:10] and after a few times of this go 'fuck it' and start sleeping at 8AM... [09:02:19] you do have kids to regulate you as well, though... [09:02:51] you say regulate [09:03:08] haha :) [09:03:10] you mean "they don't care when you go to sleep, they care that you're awake at 7 am" [09:03:12] ;) [09:04:00] phuedx: :D yeaaaah. it does regulate waking hours [09:25:12] phuedx: considering the timing of the mobile standup wrt london times, eventually a lot of money :) [09:25:39] :) [09:26:14] i'll buy everyone a drink when i get to sf ;) [09:26:21] not you though, ops boy! [09:27:01] phuedx: :( [09:27:37] do you think we'll ever see each other again? you in ops, me in friggin' london all the time [09:27:39] :P [09:29:00] phuedx: heh, I'll probably be in London / Glasgow a bit over the years, actually... [09:29:11] considering my girlfriend lives there. [09:29:21] * phuedx totally forgot [09:29:31] phuedx: also you guys have a big blue cock on trafalgar square. [09:29:32] wtf [09:29:39] * phuedx hasn't ever been to glasgow [09:29:49] i think it's an elaborate joke [09:29:53] I hope so [09:29:59] I was wondering what drugs I had taken... [09:30:10] i just don't know who it's on and when we find out [09:30:35] heh [09:31:42] brb -- cereal [09:31:48] * phuedx hasn't had cereal in ages [09:32:19] phuedx: add sugar to frosties + milk. BEST THING EVER [09:32:23] I need to find frosties in India [09:32:32] you put sugar on frosties?! [09:32:39] BUT THEY ARE SUGAR [09:32:45] phuedx: not enough sugar. [09:32:58] you're a monster [09:33:02] phuedx: also I do frosties in 'rounds'. So that the sugar from the first round soaks into the milk making the second round even better. [09:33:09] phuedx: I'm a tall kid :) [09:33:18] … [09:33:39] you're not a monster, you're a genius [09:34:46] cereously (i'm also a monster) though, cereal [09:35:34] :D [09:41:20] NOM NOM [10:13:53] (03CR) 10Phuedx: Hygiene: Introduce Icon.js abstraction (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 (owner: 10Jdlrobson) [10:15:32] (03PS7) 10Phuedx: Hygiene: Introduce Icon.js abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 (owner: 10Jdlrobson) [10:18:51] (03CR) 10Phuedx: "PS7 fixes the minor issues with PS6." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 (owner: 10Jdlrobson) [10:21:25] (03CR) 10Phuedx: [C: 032] "I'm happy to merge this and build on it later. Nice work!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 (owner: 10Jdlrobson) [10:21:58] (03Merged) 10jenkins-bot: Hygiene: Introduce Icon.js abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165937 (owner: 10Jdlrobson) [11:32:51] (03CR) 10Phuedx: "The feature LGTM but I couldn't get it to show without removing the call to apiWikiGrok.getPossibleOccupations in modules/wikigrok/wikigro" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 (owner: 10Jdlrobson) [11:32:59] (03CR) 10Phuedx: [C: 04-1] Show nationality suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 (owner: 10Jdlrobson) [11:36:22] 3Wikipedia App / 3Android App: Text Looks garbled when using Bengali - 10https://bugzilla.wikimedia.org/66125#c8 (10Andre Klapper) Rabimba: Is this still an issue? [13:08:51] (03PS1) 10Amire80: Rephrase the error_network_error string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167197 [13:46:07] (03PS1) 10Dbrant: Update prefix search query to be consistent with Mobile Web. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167201 [13:53:08] (03PS2) 10Dbrant: Update prefix search query to be consistent with Mobile Web. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167201 [14:24:45] (03PS5) 10Dbrant: Use built-in ProgressBar inside the ActionBar when loading page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167118 [14:39:39] (03PS1) 10Dbrant: Fix/improve Bridge uninitialization. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167208 [14:48:27] dbrant: http://android-builds.wmflabs.org/ :) [14:48:34] am finishing up the puppetization... [14:49:09] YuviPanda: awesome!! [14:49:51] dbrant: not on toollabs, also not on NFS, so should be faster. [14:50:10] YuviPanda: ah, brilliant [14:50:20] dbrant: and we've full root on the machine as well... [14:52:28] YuviPanda: do I have access to log on to it? [14:52:42] dbrant: no, I gave bearND access to it. let me give you access as well [14:58:29] yay isp issues! [14:58:29] Hi FlorianSW [14:58:44] hey Krenair :) How are you? [14:58:47] Okay [14:58:55] I've just been reviewing some of your mobile queue responses [14:59:28] I understand English isn't your first language [14:59:35] But please could you try using a spell checker or something? [14:59:58] Kreanir: sure [15:00:03] :) [15:45:06] (03CR) 10Dbrant: [C: 04-1] "excellent; just very minor nits." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167164 (owner: 10BearND) [15:50:50] bearND, dbrant: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7839091 and https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7850307 look like the same crash [15:51:15] API exception (connectexception) when fetching data from wikipedia [15:51:19] for nearby [15:56:13] Krenair: yep, we've merged a fix for it: https://gerrit.wikimedia.org/r/166987 [15:57:42] ah ok, closed those then [15:57:55] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7835042 - any idea about this? [15:57:56] thanks! [16:07:53] 3MobileFrontend / 3Feature requests: Table borders are always shown - 10https://bugzilla.wikimedia.org/37222#c10 (10Erasmo Barresi) Simply stated, only the tables that have borders in the desktop version should have them in the mobile version. But maybe this is of no help from a technical point of view. [16:13:24] 3MobileFrontend / 3stable: On Firefox for Android the labels for checkboxes in the settings screen overlap with the boxes themselves - 10https://bugzilla.wikimedia.org/72189 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Created attachment 16797 --> https://bugzilla.wikimedia.org/attachment.c... [16:26:46] (03CR) 10BearND: Find in Page as CAB and ActionProvider (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167164 (owner: 10BearND) [16:27:04] (03PS6) 10BearND: Find in Page as CAB and ActionProvider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167164 [16:31:19] tfinc: having trouble connecting to the hangout [16:31:25] ok for you? [16:31:28] phuedx: looks like google is failing at starting the hangout [16:31:33] i'll start a new one [16:31:50] phuedx: invite sent [16:32:49] (03CR) 10Dbrant: [C: 032] Find in Page as CAB and ActionProvider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167164 (owner: 10BearND) [16:44:37] 3MobileFrontend / 3stable: On Firefox for Android the labels for checkboxes in the settings screen overlap with the boxes themselves - 10https://bugzilla.wikimedia.org/72189#c1 (10Jon) 5NEW>3RESO/DUP Also see https://bugzilla.mozilla.org/show_bug.cgi?id=1083536 *** This bug has been marked as a duplicat... [16:49:50] (03CR) 10BearND: [C: 04-1] "Great. Just some minor nits." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167201 (owner: 10Dbrant) [16:50:49] dbrant: https://gerrit.wikimedia.org/r/#/c/167118/ needs a manual rebase [16:51:30] bearND: doing... [16:55:57] (03PS6) 10Dbrant: Use built-in ProgressBar inside the ActionBar when loading page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167118 [16:56:06] bearND: ^ [16:56:49] bearND: the style of the progressbar comes from the default Holo theme. If we want to, I think we can change the style in our theme xml. [17:08:21] (03PS3) 10Dbrant: Update prefix search query to be consistent with Mobile Web. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167201 [17:10:30] bearND: what did you mean by "Not the order is the same as on Mobile Web"? [17:10:46] dbrant: oops, that was a typo [17:10:53] i meant to say "now" [17:11:00] bearND: lol ok! [17:11:04] sorry [17:11:40] (03CR) 10BearND: [C: 032] Use built-in ProgressBar inside the ActionBar when loading page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167118 (owner: 10Dbrant) [17:11:58] (03Merged) 10jenkins-bot: Use built-in ProgressBar inside the ActionBar when loading page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167118 (owner: 10Dbrant) [17:15:52] 3MobileFrontend / 3Feature requests: Table borders are always shown - 10https://bugzilla.wikimedia.org/37222#c11 (10Jon) I need some specific examples of pages that have this problem so I can dig into this more.. can you provide some more details :) [17:18:22] (03PS4) 10BearND: Update prefix search query to be consistent with Mobile Web. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167201 (owner: 10Dbrant) [17:20:39] 3MobileFrontend / 3Hygiene: Hygiene: localTemplateBasePath should be the same as localBasePath - 10https://bugzilla.wikimedia.org/72161#c1 (10Jon) 5NEW>3RESO/INV On second thoughts, this is not actionable right now. Latest patchset means this is unnecessary. [17:22:16] (03PS10) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [17:22:43] kaldari: could you please take a look at https://trello.com/c/lWdrFAlj/50-5-rework-mobilewebwikigrok-schema-separate-client-side-events-from-server-side-events and add more any other info that I may need? Thanks [17:23:02] bmansurov: https://gerrit.wikimedia.org/r/165256 would be suitable for your first +2 review :) [17:23:03] (03CR) 10jenkins-bot: [V: 04-1] Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [17:23:18] bmansurov: Will do... [17:23:33] kaldari: thanks [17:23:44] jdlrobson2: cool [17:24:46] (03CR) 10BearND: [C: 032] Update prefix search query to be consistent with Mobile Web. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167201 (owner: 10Dbrant) [17:26:24] (03Merged) 10jenkins-bot: Update prefix search query to be consistent with Mobile Web. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167201 (owner: 10Dbrant) [17:30:51] (03PS2) 10BearND: Fix/improve Bridge uninitialization. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167208 (owner: 10Dbrant) [17:31:27] bmansurov: https://gerrit.wikimedia.org/r/165256 would be suitable for your first +2 review :) [17:31:42] whoops that was meant for my command prompt ignore ;-) [17:32:09] jdlrobson2: not so fast, you won't get your +2 from me so easily [17:32:18] :)) [17:39:41] (03PS6) 10Jdlrobson: Show nationality suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 [17:40:14] (03CR) 10jenkins-bot: [V: 04-1] Show nationality suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 (owner: 10Jdlrobson) [17:41:19] dbrant: what's the strange behavior you menation in commit message of https://gerrit.wikimedia.org/r/#/c/167208? [17:42:49] bearND: saw http://android-builds.wmflabs.org/ [17:42:49] ? [17:43:00] it doesn't actually build fully yet... [17:43:15] working on it [17:43:22] YuviPanda: you're alive! [17:43:37] bearND: heh :) [17:43:49] YuviPanda: I only see the "Welcome to nginx!" message [17:43:57] bearND: hard refresh? [17:44:01] also https://gerrit.wikimedia.org/r/#/c/167198/ sets it up [17:44:14] YuviPanda: now it's better [17:44:29] fetching... [17:44:57] bearND: so, after a while of browsing various pages, and going back and forth between fragments (especially when the page has not finished loading), subsequent WebViews would just become unresponsive, and show nothing but a blank white page. I actually had to force-close the app to make the WebViews show anything again. [17:44:58] yeah that part isn't done yet [17:46:25] bearND: originally I added those calls when I was grasping at straws for ways of deallocating memory when the fragment goes away. But I think we've got it figured out now. [17:47:15] YuviPanda: where are the files? still in your home dir? [17:47:30] bearND: nope, /srv. owned by android-build user. [17:47:36] dbrant: ah, cool [17:47:39] YuviPanda: nice! [17:48:00] bearND: yeah, and /srv will also be used for building. it's local filesystem so should be faster than the homedir we used previously (which was on NFS) [17:49:00] bmansurov: so we need to increase your confidence in code review. What's the main thing that stops you from +2ing at the moment and how can I help get you more confident about that? [17:49:25] dbrant: one more quick q about the patch. In line 111 you removed throwing the RuntimeException. Wouldn't a case like this be indicative of a bug in our app? [17:49:59] YuviPanda: where are the log files? [17:50:02] jdlrobson2: I think confidence will come once I'm comfortable with different aspects of code [17:50:25] bearND: as I said, work in progress. [17:51:34] (03CR) 10Jdlrobson: [C: 04-1] Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [17:52:03] bmansurov: when you review feel free to ask for tests that increase your confidence, and ask how you can replicate issues/test things if it is not clear from the commit message/bug [17:52:23] personally i think we learn a lot through failure [17:52:37] jdlrobson2: ok [17:53:06] (03CR) 10Dbrant: [C: 04-1] "Looks good in general! but will look in greater detail later..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [17:53:31] really the criteria for merging is 1) the code meets coding standards, has adequate enough testing giving the change and where it goes out to (e.g. alpha/beta/stable) [17:53:51] 2) the code does what it claims to in the commit message [17:54:25] 3) it doesn't break any existing functionality around the site [17:54:32] the 3rd one is the trickiest one for you i'm guessing? [17:54:40] bearND: I'll update the patch to convey my intention a bit better [17:55:07] dbrant: great [17:55:19] dbrant: btw, i rebased earlier [17:55:26] (03CR) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [17:56:21] (03PS23) 10Bmansurov: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) [17:56:27] (03PS3) 10Jdlrobson: Make opting into beta/alpha work on localhost [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 [17:57:04] (03CR) 10jenkins-bot: [V: 04-1] Make opting into beta/alpha work on localhost [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 (owner: 10Jdlrobson) [17:57:21] bmansurov: For [3] it requires experience to know what touches what. You need to know the files and how they relate to other features. A quick manual test of the feature usually surfaces any problems - if in doubt just test key workflows like editing, search and if in serious doubt ask or simply just +1 [17:58:10] (03PS4) 10Jdlrobson: Make opting into beta/alpha work on localhost [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 [17:58:26] bearND: I'm also adjusting this patch as I go along to make it work with the new setup https://gerrit.wikimedia.org/r/#/c/167212/ [17:58:34] kristenlans: hey! PM for a minute? [17:58:41] (03CR) 10jenkins-bot: [V: 04-1] Make opting into beta/alpha work on localhost [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 (owner: 10Jdlrobson) [18:00:06] jdlrobson2: you're right #3 requires experience, which I'm getting. hopefully I'll be able to +2 starting today [18:00:28] bmansurov: i'd encourage you to ask yourself what's stopping me from +2ing this and then ask those questions :) [18:00:54] i want to make you more confident. It will also ensure you are kept busy - >50% of my time is spent code reviewing so i rarely run out of stuff :) [18:01:21] i sometimes only +1 when there are php changes that i want MaxSem to check out [18:01:39] jdlrobson2: I know what's stopping me. For example, your fix about getting alpha/beta working on localhost looked easy enough to +2, but I'm not very familiar with the backend, and I don't want things to break. [18:08:44] bearND: http://android-builds.wmflabs.org/ has last successful build working again :) [18:08:50] I just need to set up logs properly now [18:09:00] YuviPanda: \o/. Thanks! [18:09:36] (03CR) 10Bmansurov: Cleanup WikiGrok dialog b footer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167063 (owner: 10Jdlrobson) [18:09:49] bearND: I'll switch the script to use the logging module, and put the output in /srv/logs. Also will put full output of the build there in the log, to make things easier. [18:10:01] nice [18:10:07] but am off now :) see ya later! [18:10:18] later [18:11:40] i got dropped off the call [18:11:50] Deskana|Away: kristenlans: brion: i dropped off as well [18:11:58] we're working on getting y'all back up [18:12:02] uno secundo [18:12:11] Hangounts hasve been failing much recently [18:12:23] :( [18:12:39] there we go [18:12:47] hmm, hangouts appears to be borked [18:13:28] (03CR) 10Bmansurov: Make opting into beta/alpha work on localhost (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 (owner: 10Jdlrobson) [18:14:11] brion: most of us are back now [18:14:31] there weo go [18:14:34] \o/ [18:16:24] bmansurov: Trello card has been updated [18:16:36] kaldari: thanks [18:17:21] legoktm: thanks for the link to yuri's rfc [18:17:27] is that actually getting any traction? [18:17:43] MaxSem: kaldari - have y'all seen this? https://www.mediawiki.org/wiki/Requests_for_comment/Wikidata_API [18:18:34] (03PS5) 10Jdlrobson: Make opting into beta/alpha work on localhost [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 [18:18:45] (03CR) 10Jdlrobson: Make opting into beta/alpha work on localhost (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 (owner: 10Jdlrobson) [18:18:49] bmansurov: You may want to get EventLogging running locally for this task. There are instructions at https://www.mediawiki.org/wiki/Extension:EventLogging and ori should be able to assist if you have questions (he wrote most of EventLogging). [18:19:13] kaldari: ok [18:19:32] bmansurov: you can also reach out to dario - he's DarTar on IRC [18:19:49] Maryana: ok thanks [18:20:27] bmansurov: Getting EventLogging running locally can be challenging, so if you feel like you're spending too much time thrashing on that, you can probably complete the card without actually testing it and let someone else do the testing for you. [18:20:42] Maryana, yep - something like that. ideally, much more is needed for full functionality [18:20:58] kaldari - yeah, isn't he going to need stat1001 access, too..? [18:20:59] bmansurov: But in the long run, it will be useful if you have it running locally [18:21:05] e.g., ops ticket, waiting [18:21:10] kaldari: I'll spend 5-10 mins and see how it oges [18:22:03] kaldari, eh - we don't have an EL role with local logging? [18:22:50] MaxSem: We might. I don't know. [18:24:12] bmansurov: Looks like ori isn't on this channel, but he should be in #wikimedia-dev or #wikimedia-tech [18:24:40] ok [18:26:08] bmansurov, Maryana: he doesn't need access to stat1001 if he's running the EventLogging server locally. [18:26:35] bmansurov, Maryana: although we should get him access to that server anyway. [18:26:47] right. at some point he'll probably want to go digging through the real data ;) [18:26:52] yeah [18:27:01] oh, ori's at the offsite [18:27:12] singing kumbaya around a campfire with all of platform [18:35:27] ok aheading to office :) [18:41:24] Deskana|Away: bearND: it looks like an event does indeed get logged, even when the ToC is opened programmatically :( [18:50:21] http://developer.android.com/about/versions/android-5.0.html :) [18:50:40] dbrant: bearND --^ [18:50:59] tfinc: yes indeed! [18:51:22] tfinc: yeah! [18:51:35] woooo [18:51:46] everybody update yer sdkssss [18:52:44] I see it in SDK manager :) [18:53:16] no 5.0 device images at https://developers.google.com/android/nexus/images yet though [18:53:52] web audio, webgl, and webrtc in the webview? bitchin’ [18:54:08] if only they could backport that to the people who will be stuck on older versions forever *cough8 [18:55:20] very happy to see Project Volta taking shape [18:55:23] and the new JobScheduler [18:55:33] Project Don’t Run Down The Damn Battery [18:55:41] and we finally get dumpsys batterystats [18:56:16] Screen pinning! [18:56:20] hmmm they have ‘preview’ images for nexus 5 at http://developer.android.com/preview/index.html [18:56:24] that'll be very useful for demos [18:56:28] i’ll wait for the official update :D [18:58:34] * tfinc debates about flashing one of our nexus 5 to tinker with it [18:58:45] we have 2 that are not currently in use [18:59:00] that or we nudge Deskana|Away to upgrade his Nexus7 [18:59:00] yes!! [19:00:21] too bad they don’t have a nexus 4 preview image, i flash that thing all the time. my nexus 5 has data i want to keep :D [19:13:22] (03PS3) 10Dbrant: Fix/improve Bridge uninitialization. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167208 [19:13:54] bearND: ^ a little better [19:14:09] checking... [19:20:51] dbrant: any good hints to test this? [19:22:54] bearND: hmm... well, prior to the patch, try going back and forth through a bunch of pages, and see if the webview starts becoming blank. [19:23:10] bearND: otherwise, there isn't really anything noticeable. [19:26:18] no luck reproducing it but the code makes sense [19:26:30] (03CR) 10BearND: [C: 032] Fix/improve Bridge uninitialization. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167208 (owner: 10Dbrant) [19:26:52] bearND: thx! [19:27:15] (03Merged) 10jenkins-bot: Fix/improve Bridge uninitialization. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167208 (owner: 10Dbrant) [19:31:32] (03PS1) 10BearND: Alpha updater update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167295 [19:32:19] dbrant: ^ [19:32:34] bearND: checking [19:32:37] mmmmm lunch [19:38:33] (03CR) 10Dbrant: [C: 032] Alpha updater update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167295 (owner: 10BearND) [19:38:55] (03Merged) 10jenkins-bot: Alpha updater update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167295 (owner: 10BearND) [19:41:44] dbrant: any idea how to fix the location of the error croutons? [19:42:43] bearND: i'll think about it... maybe there's a way to put them on top of the ActionBar? [19:44:46] cool [19:45:40] (03PS1) 10BearND: Avoid meltdown in setupGeomagneticField [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167299 [19:46:36] (03CR) 10Yuvipanda: "Should be https" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167295 (owner: 10BearND) [19:46:40] bearND|food: dbrant ^ [19:48:18] YuviPanda|zzz: going to update the patch [19:48:24] cool [20:02:35] (03PS1) 10BearND: Back to using https for alpha updater [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167303 [20:02:50] kaldari Moizyana: we are ready fro design review when you are [20:05:57] jdlrobson2: BTW, it looks like the button formatting on step 2 of Wikigrok B is wonky [20:06:14] kaldari|2: there's allreeeaddy a patch for it [20:06:18] yay [20:06:18] do code review :P [20:06:25] https://gerrit.wikimedia.org/r/167063 [20:06:31] jdlrobson2: I will as soon as I'm not in a meeting :) [20:06:41] kaldari: in https://meta.wikimedia.org/wiki/Schema:MobileWebWikiGrok page impressions talks about "eligible users". Are they the users who see a wikigrok question? Is that what it means? [20:06:56] yes, exactly [20:06:59] ok thanks [20:07:39] bmansurov_: So this event can be logged at the point in the code where it decides that the page will actually load the Wikigrok interface. [20:07:51] bmansurov_: which is in wikigrok.js [20:07:56] kaldari|2: ok [20:12:43] kristenlans: kaity|away http://etherpad.wikimedia.org/p/mobile_web_design_review [20:13:07] Maryaa: thanks :-) [20:14:46] kaldari|2: https://github.com/kaldari/WikiGrokAPI/pull/1 [20:15:23] kaldari|2: it's pretty epic [20:26:50] kaldari|2: any ideas how I can create anonymous hash of userToken? [20:28:35] (03CR) 10Dbrant: [C: 032] Back to using https for alpha updater [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167303 (owner: 10BearND) [20:33:01] (03PS7) 10Jdlrobson: Show nationality and occupation suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 [20:33:03] (03PS1) 10Jdlrobson: WikiGrok B shouldn't depend on user having an occupation. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167309 [20:59:02] kaldari|2: also, why does it have to be an anonymous hash of userName? can it be some random number plus timestamp? [20:59:45] kaldari|2: or do we want to be able to identify users across sessions? [21:03:22] 3Wikipedia App / 3Android App: 404 when trying to download new alpha - 10https://bugzilla.wikimedia.org/72151#c2 (10Bernd Sitzmann) https://android-builds.wmflabs.org/ is the new build site for alpha. I've added the new URL to the latest code. But the apk there hasn't been updated yet to reflect that. I bel... [21:15:57] (03PS1) 10Jdlrobson: Add margins around checkboxes when together [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167314 [21:20:12] (03PS8) 10Jdlrobson: Show nationality and occupation suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 [21:21:44] (03PS2) 10Jdlrobson: Wikigrok UX changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167314 [21:22:12] (03PS2) 10Jdlrobson: Cleanup WikiGrok dialog b footer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167063 [21:22:21] (03Abandoned) 10Jdlrobson: Cleanup WikiGrok dialog b footer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167063 (owner: 10Jdlrobson) [21:30:21] "The latest update is impeccable. Runs great and the menu on the left on related topics is very successful" very nice to see that dbrant Deskana|Away bearND|food [21:31:03] this one cracks me up too "Much more agile than the browser" [21:31:39] bmansurov_: that's a bug [21:31:49] tfinc: yep, I get a kick out of those! [21:32:20] https://gerrit.wikimedia.org/r/165256 < bmansurov_ [21:32:26] they are supposed to be on separate lines [21:33:29] jdlrobson2: I created the trello card because of kaldari|2's comment [21:33:41] where was kaldari|2 's comment? [21:33:48] gerrit [21:33:54] in the above link you just gave me [21:34:08] you don't need to create a card for those sort of things. Just ping them on irc [21:34:15] or email [21:34:30] oki [21:35:17] jdlrobson2, bmansurov_: also that wasn't exactly what I meant. I definitely think they should be on separate lines, but maybe just as regular links and not 100% width block elements. [21:35:57] kaldari|2: ok i see, you just don't want the extra whitespace to be clickable? [21:35:58] as the clickable area is dramatically different [21:36:07] bmansurov_: exactly [21:36:11] * tfinc charges up one of our spare nexus5's to flash them with Lollipop [21:36:18] kaldari|2: that makes sense [21:36:35] kaldari|2: they are not 100% elements though with this change.. [21:37:06] * bearND keeps forgetting to change the nick, lol [21:37:33] tfinc: where is that feedback from? [21:37:42] bearND: play store ratings for r84 [21:38:24] tfinc: they should see the latest bits. Will be a big improvement of that [21:38:30] :) [21:39:18] kaldari|2: well i mean we could make them display: inline-block and it would have same meaning [21:39:31] actually scrap that [21:39:45] i just wished we had the alpha build working properly, but even this mornings update shows the new action bar stuff, with search and find in page using contextual action bars [21:47:33] bearND: whats busted with it? [21:48:51] YuviPanda|zzz: moved the build from tools to a new VM in labs: https://android-builds.wmflabs.org/ [21:49:08] it took too much resources for tools [21:49:13] tfinc: ^ [21:50:12] i mean it was too resource hungry; he's still in the process of migrating everything over; e.g. the build need to be kicked off automatically through cron [21:57:22] excellent ... "writing 'system'..." [21:57:54] bearND: ahh ok, will we need a real machine in the future? [21:58:07] Lollipop is alive ... [21:58:26] their using the android wear start up animation now [21:58:27] tfinc: we'll see how this one goes [21:58:38] 3MobileFrontend / 3stable: S60 crashes on Wikipedia - 10https://bugzilla.wikimedia.org/61385#c7 (10Jon) 5NEW>3RESO/WON We can't locate this device to fix the problem. If anyone reading this experiences the same problem please let us know some how and we'll try to fix it. [22:08:22] hey mobile people [22:08:29] you guys instrument everything with event logging like a boss [22:08:34] :D [22:08:39] so did you come up with some best practices around this? [22:08:57] like - keeping schema defaults organized somewhere, etc. [22:09:09] … not really [22:09:23] but we're going to get some help from a new member of the product team to do an audit [22:09:36] which would be a good starting point for that type of work :) [22:09:48] ok, cool, i feel like that'd be a good thing to socialize around the org [22:09:52] as people use the tool more [22:10:28] feel free to loop me in if you feel that sort of discussion needs to happen and I'll try to centralize it [22:15:18] (03CR) 10Kaldari: [C: 032] Wikigrok UX changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167314 (owner: 10Jdlrobson) [22:15:52] (03Merged) 10jenkins-bot: Wikigrok UX changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167314 (owner: 10Jdlrobson) [22:35:59] (03CR) 10Kaldari: [C: 04-1] Show nationality and occupation suggestions (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 (owner: 10Jdlrobson) [22:42:28] (03PS9) 10Jdlrobson: Show nationality and occupation suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 [22:42:39] (03PS10) 10Jdlrobson: Show nationality and occupation suggestions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166930 [22:55:24] Back. Sorry, had to go to the doctor today. [22:55:27] tfinc: I could try upgrading my Nexus 7, or the Nexus 4 I have on loan. [22:55:42] Deskana: no need [22:55:52] Deskana: to be sorry about that [22:56:05] Deskana: its up to you. the Nexus5 is running fine with Lollipop for testing [23:07:34]