[00:00:01] (03CR) 10jenkins-bot: [V: 04-1] WIP: Update WikiGrok logging according to new Schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [00:02:50] (03PS2) 10Bmansurov: WIP: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [00:04:48] (03PS1) 10Jdlrobson: Tools: make qunit output cleaner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167352 [00:04:50] (03PS1) 10Jdlrobson: Hygiene: Cleanup the toggling test code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 [00:05:00] bmansurov_: ^ you'll like both of these [00:05:24] (03CR) 10Jdlrobson: [C: 032] "I really hate the toggle tests but I did a follow up to move this along." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [00:06:01] jdlrobson2: ok [00:06:11] bmansurov_: https://gerrit.wikimedia.org/r/#/c/165896/ < so the problem is fixed? [00:06:45] jdlrobson2: looked like so when I tested the master branch [00:07:28] still broken for me bmansurov_ [00:07:30] on latest master [00:07:47] jdlrobson2: that's weird, i'll recheck [00:10:29] jdlrobson2: can you review this please: https://gerrit.wikimedia.org/r/167349 [00:10:37] bmansurov_: no way i'm done for the weekend you should finish too :) [00:10:53] i'll take a look monday just make sure it's on the card and in the right column :) [00:10:54] jdlrobson2: sure, when you come back [00:11:16] (03Merged) 10jenkins-bot: Remember expanded sections on page reload or when going back to the previous page. Add QUnit tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/164000 (https://bugzilla.wikimedia.org/69351) (owner: 10Bmansurov) [00:11:16] jdlrobson2: i didn't move it to the review column because couldn't figure out how to hash [00:14:41] (03PS1) 10BearND: Anchor crouton position in Nearby [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167354 [13:46:16] (03PS2) 10Florianschmidtwelzow: Seperate list style from page-list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 [13:48:47] (03PS1) 10Florianschmidtwelzow: Make sure, loading circle is really visible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167377 [13:51:40] (03PS3) 10Florianschmidtwelzow: Seperate list style from page-list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 [13:59:05] (03PS2) 10Florianschmidtwelzow: Make sure, loading circle is really visible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167377 [14:22:56] (03PS1) 10Florianschmidtwelzow: Toggle sections only in article view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167379 (https://bugzilla.wikimedia.org/72142) [14:25:24] (03PS1) 10Florianschmidtwelzow: Remove tablet.scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167380 [14:27:13] (03CR) 10Florianschmidtwelzow: [C: 04-1] Toggle sections only in article view (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167379 (https://bugzilla.wikimedia.org/72142) (owner: 10Florianschmidtwelzow) [14:28:03] (03PS2) 10Florianschmidtwelzow: Toggle sections only in article view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167379 (https://bugzilla.wikimedia.org/72142) [16:12:32] (03CR) 10Bmansurov: [C: 04-1] "toggled sections are not restored after page reload" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 (owner: 10Jdlrobson) [16:17:15] (03CR) 10Bmansurov: [C: 032] Tools: make qunit output cleaner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167352 (owner: 10Jdlrobson) [16:17:50] (03Merged) 10jenkins-bot: Tools: make qunit output cleaner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167352 (owner: 10Jdlrobson) [17:18:09] 3MobileFrontend / 3alpha: Preferred languages code in alpha broken - 10https://bugzilla.wikimedia.org/71920#c2 (10Florian) 5NEW>3ASSI a:3Florian -> Uncaught TypeError: Cannot read property 'de' of undefined (mf-translator.js:14) Caused by: If2e745f7bc7bb6bf24fb9b533f4b46dc5aad348b [17:43:25] (03PS1) 10Esanders: Fix gap between focus highlight and rounded border on login page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167395 [17:48:50] (03PS1) 10Florianschmidtwelzow: Fix undefined var in mf-translator.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167397 (https://bugzilla.wikimedia.org/71920) [17:49:24] (03CR) 10jenkins-bot: [V: 04-1] Fix undefined var in mf-translator.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167397 (https://bugzilla.wikimedia.org/71920) (owner: 10Florianschmidtwelzow) [17:51:38] (03CR) 10Florianschmidtwelzow: [C: 031] "LGTM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167395 (owner: 10Esanders) [17:56:18] (03PS2) 10Florianschmidtwelzow: Fix undefined var in mf-translator.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167397 (https://bugzilla.wikimedia.org/71920) [19:00:38] 3MobileFrontend / 3stable: Talk: "Return to "Foo" page." appears on talk page needs design love - 10https://bugzilla.wikimedia.org/71919#c2 (10Florian) Created attachment 16802 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16802&action=edit neutral button Maybe just a neutral button? [19:14:15] (03PS1) 10Florianschmidtwelzow: Use special message for some namespaces for "return" link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167402 (https://bugzilla.wikimedia.org/61113) [19:27:40] 3MobileFrontend / 3stable: Last modified bar Gray is too light - 10https://bugzilla.wikimedia.org/72223 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16803 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16803&action=edit can barely notice background is different. [19:40:54] (03PS1) 10Florianschmidtwelzow: Don't use a too light gray for top-bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167403 (https://bugzilla.wikimedia.org/72223) [21:33:14] Deskana: ping, you here? [21:35:23] FlorianSW: I am. [21:36:01] Deskana: great :) Can you ad hoc say, if the Android app has a maximum limit for the cache size? [21:36:53] FlorianSW: I don't know, you'd have to ask Dmitry. I'm not an engineer. :) [21:37:34] Deskana: i know, but you're the only (online) one i can find from the app team :P So, no ask, no win :D [21:37:58] Indeed! [21:39:11] but thanks :)