[03:20:53] (03PS11) 10Deskana: Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [07:25:11] 3Wikipedia App / 3Android App: Formula looks grabled on small screen devices and black theme - 10https://bugzilla.wikimedia.org/72250 (10Florian) 3NEW p:3Unprio s:3normal a:3None Created attachment 16812 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16812&action=edit example Comes from OTRS... [07:25:22] 3Wikipedia App / 3Android App: Formula looks grabled on small screen devices and black theme - 10https://bugzilla.wikimedia.org/72250 (10Florian) 5NEW>3UNCO [08:10:22] yo [08:55:07] (03CR) 10Phuedx: [C: 04-1] "Good start. A couple of minors inline." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [10:13:09] (03CR) 10Daniel Kinzler: "I find the code quite hard to read & review, mainly because some of the methods are big and complex. Please split them into private functi" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 (owner: 10MaxSem) [14:06:04] (03PS1) 10Phuedx: WIP Add the WikiGrokResponse API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 [14:43:51] (03CR) 10Dbrant: [C: 032] Avoid meltdown in setupGeomagneticField [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167299 (owner: 10BearND) [14:43:59] (03PS2) 10Phuedx: WIP Add the WikiGrokResponse API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 [14:45:09] (03CR) 10Dbrant: [C: 032] Anchor crouton position in Nearby [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167354 (owner: 10BearND) [14:48:28] (03PS3) 10Phuedx: Add the WikiGrokResponse API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 [14:56:55] (03PS4) 10Phuedx: WIP Add the WikiGrokResponse API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 [16:17:40] (03CR) 10Jdlrobson: [C: 04-1] "I'm not sure how I feel about this. 'page-list' gave semantic meaning to the list - it's a list of pages." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 (owner: 10Florianschmidtwelzow) [16:19:43] (03CR) 10Jdlrobson: "I worry this might be /too/ dark. Let me check with a designer what they think." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167403 (https://bugzilla.wikimedia.org/72223) (owner: 10Florianschmidtwelzow) [16:26:46] (03CR) 10Jdlrobson: [C: 04-1] "Thanks for this Florian." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167380 (owner: 10Florianschmidtwelzow) [16:34:35] jdlrobson2: about the change ^: what you mean with "note encouraging us to not use this". Still use tablet.scripts and set only a FIXME or remove tablet.scripts (like the change) and add a FIXME (maybe with a link to the bug) [16:35:22] FlorianSW: i just think we need to rethink all of the application.js code. The problem with listing mobile.toc there is as soon as we decide to add more tablet specific modules that file could balloon [16:35:33] at least mobile.tablet is consistent with mobile.stable, mobile.beta, mobile.alpha [16:36:30] right, but i have a little problem with a module which only has a dependency to one other module :/ it looks like it blows up the dependency tree without any reason :( [16:45:00] 3Wikipedia App / 3Android App: NPE in NearbyActivity.setupGeomagneticField - 10https://bugzilla.wikimedia.org/72091 (10Alex Monk) 5PATC>3RESO/FIX [16:45:04] 3Wikipedia App / 3Android App: android.content.ActivityNotFoundException: No Activity found to handle Intent (WEB_SEARCH and CHOOSER) - 10https://bugzilla.wikimedia.org/70528#c1 (10Alex Monk) Also for VIEW: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7893169 [16:50:38] FlorianSW: which dependency is blowing things up? [16:51:09] tablet.scripts :) [16:51:17] jdlrobson2 ^ [16:51:18] nothing should depend on tablet.scripts [16:51:29] it's only purpose is for it to depend on things [16:51:41] how is it blowing things up FlorianSW ? [16:52:25] (03PS1) 10BearND: WIP: Update for Android 5.0 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167612 [16:54:18] (03PS7) 10MaxSem: WIP: get suggestions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 [16:55:10] jdlrobson2: It feels wrong to have a module which has only a dependency to one other module. It would have more sense, if there are more modules, but for now, there is only one module :) I hope you understand, it sounds creepy what i say :) [16:55:47] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167614 [17:08:22] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/jwKSYQ [17:08:22] 13WikipediaMobile/06master 143e0a390 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [17:11:22] (03PS2) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167614 [17:11:24] (03CR) 10jenkins-bot: [V: 04-1] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167614 (owner: 10BearND) [17:12:21] * rmoen grocks out [17:14:43] (03Abandoned) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167614 (owner: 10BearND) [17:15:29] Maryana: heading into office now got sidetracked on templating stuff/code review. be with you shortly [17:18:28] time to get george to bed [17:29:39] Deskana|Away: regarding the emulator, make sure to install the Intel accelerator (HAXM) via the SDK manager, and also enable "use host GPU" within the AVD configuration. That way the emulator will run at near-native speed. [17:32:37] dr0ptp4kt: on friday dan was showing me some dashboards of different zero carriers & the languages their users were accessing.. any chance you know the link to that? :) [17:33:45] it's on the zero.wikimedia.org domain. want me to create you an account? [17:33:50] Maryana: ^ [17:34:00] yes plz! [17:34:09] Maryana: k [17:34:46] Maryana: which username? [17:35:00] Maryana: it's a private wiki, but same username as sul probably a good idea [17:35:32] sure – Maryan (WMF) is my staff account on all the other wikis [17:35:36] *Maryana [17:35:44] helps to know how to spell your own name ;) [17:35:52] (03PS1) 10BearND: Minor translation fix [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167622 [17:38:45] oh and i almost forgot — iOS 8.1 drops today [17:38:52] im updating my ipad [17:39:14] kristenlans: joaquin's email is jhernandez@wikimedia.org. Can you add his to calendar invites, trello boards, etc. [17:39:14] Maryana: acct created [17:39:22] his=him [17:39:38] Kaldari: thanks! Will do. [17:40:04] dr0ptp4kt: ty! [17:40:11] Maryana: yw [17:43:24] kaldari: i just subscribed joaquin to mobile-l, but he should prolly be on mobile-tech, too… i don't know who the admin of that list is, tho [17:43:53] tfinc: Is that you? ^ [17:44:12] Kaldari: When you have a moment, can you ask joaquin what his trello usernae is (if he has an existing one)? There are about seven jhernandez variations that come up in trello when I go to add him to mobile web boards. [17:44:48] kaldari maryana: Both tomasz and I are mobile-tech admins. [17:45:50] kaldari: yup, thats why i'm listed here http://etherpad.wikimedia.org/p/MobileWebOnboarding to do it [17:46:39] tfinc: Cool. Joaquin's email is jhernandez@wikimedia.org. [17:47:26] kaldari tfinc et al: FYI Joaquin’s email isn’t coming up yet for calendar invites. May take a bit to propagate through the system™ [17:47:56] kristenlans: yup [17:48:09] 3Wikipedia App / 3Android App: location arrow sometimes pointing opposite direction in Nearby? - 10https://bugzilla.wikimedia.org/72269 (10Luis Villa (personal-for work use lvilla@wikimedia.org)) 3UNCO p:3Unprio s:3major a:3None This unfortunately isn't consistent/reproducible, but this weekend I fir... [17:49:01] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167402 (https://bugzilla.wikimedia.org/61113) (owner: 10Florianschmidtwelzow) [17:50:10] (03CR) 10Siebrand: [C: 032] Minor translation fix [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167622 (owner: 10BearND) [17:50:41] (03Merged) 10jenkins-bot: Minor translation fix [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167622 (owner: 10BearND) [17:52:01] (03PS1) 10BearND: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167625 [17:52:33] (03CR) 10BearND: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167625 (owner: 10BearND) [17:53:17] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167625 (owner: 10BearND) [17:54:00] jdlrobson2: i tried to follow my thoughts, which has caused me to want to remove tablet.scripts. But it seems, i can't :( I'm still not happy with this, but i think "your words opened my eyes" ;) in some other way. Thanks! :) [17:55:13] jdlrobson2: i tried to follow my thoughts, which has caused me to want to remove tablet.scripts. But it seems, i can't :( I'm still not happy with this, but i think "your words opened my eyes" ;) in some other way. Thanks! :) [17:56:40] (03Abandoned) 10Florianschmidtwelzow: Remove tablet.scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167380 (owner: 10Florianschmidtwelzow) [17:57:03] kaldari: he's added now [17:57:14] intro email sent too [18:00:12] (03CR) 10Kaldari: [C: 04-1] WIP: get suggestions (035 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 (owner: 10MaxSem) [18:00:26] 3MobileFrontend / 3stable: Add some margin/padding to search ajax loader - 10https://bugzilla.wikimedia.org/72272 (10Jon) 3NEW p:3Unprio s:3normal a:3None It should have same margins as the text. To replicate: Type a search term in search bar, a loader appears but the top of the loader image touches... [18:01:42] (03CR) 10Florianschmidtwelzow: Use special message for some namespaces for "return" link (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167402 (https://bugzilla.wikimedia.org/61113) (owner: 10Florianschmidtwelzow) [18:03:02] (03CR) 10Jdlrobson: [C: 032] Fix undefined var in mf-translator.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167397 (https://bugzilla.wikimedia.org/71920) (owner: 10Florianschmidtwelzow) [18:03:04] kristenlans: his username is just @joaquin on trello [18:03:16] kaldari: thank ye [18:03:38] 3MobileFrontend / 3alpha: Preferred languages code in alpha broken - 10https://bugzilla.wikimedia.org/71920 (10Jon) 5PATC>3RESO/FIX [18:03:53] (03Merged) 10jenkins-bot: Fix undefined var in mf-translator.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167397 (https://bugzilla.wikimedia.org/71920) (owner: 10Florianschmidtwelzow) [18:08:16] kristenlans: ok i stand corrected. We have a broken bingle. I raised a bug but it hasn't shown up [18:08:18] i know why [18:08:34] jdlrobson2: why? [18:08:39] we renamed the "In Analysis" column from "Needs analysis" [18:08:45] OH SNAP! [18:08:48] do we want to use "In analysis" [18:08:52] i can reconfigure it [18:09:24] jdlrobson2: Let’s switch it back to whatever makes bugello happy ;-) [18:09:30] i just made it happy [18:09:37] 3MobileFrontend / 3stable: Add some margin/padding to search ajax loader - 10https://bugzilla.wikimedia.org/72272#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/kY3oKNeO [18:09:40] we just need to be super careful we use the same names for each in analysis column :) [18:09:41] jdlrobson2: cool, thanks for the catch :D [18:09:47] we are back online :) [18:09:52] (03PS3) 10Bmansurov: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [18:11:44] yo [18:12:16] bmansurov: hey did you work out the hash stuff? [18:12:45] jdlrobson2: yes, please review if you can https://gerrit.wikimedia.org/r/#/c/167349/ [18:13:03] (03CR) 10Jdlrobson: [C: 032] Toggle sections only in article view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167379 (https://bugzilla.wikimedia.org/72142) (owner: 10Florianschmidtwelzow) [18:13:37] (03Merged) 10jenkins-bot: Toggle sections only in article view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167379 (https://bugzilla.wikimedia.org/72142) (owner: 10Florianschmidtwelzow) [18:14:26] bmansurov: that looks better [18:14:53] 3MobileFrontend / 3stable: On action=info page headings do not expand/collapse - 10https://bugzilla.wikimedia.org/72142 (10Jon) 5PATC>3RESO/FIX [18:14:56] phuedx: yes, I made the changes you suggested [18:15:11] jdlrobson2: i did a quick code review (i.e. no testing) earlier today [18:15:21] sweet [18:15:21] (03CR) 10Siebrand: Use special message for some namespaces for "return" link (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167402 (https://bugzilla.wikimedia.org/61113) (owner: 10Florianschmidtwelzow) [18:15:30] i'll test again later if you don't get round to it [18:15:36] s/again// [18:15:59] ok [18:16:52] (03CR) 10Florianschmidtwelzow: Use special message for some namespaces for "return" link (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167402 (https://bugzilla.wikimedia.org/61113) (owner: 10Florianschmidtwelzow) [18:19:59] (03PS2) 10Florianschmidtwelzow: Use special message for some namespaces for "return" link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167402 (https://bugzilla.wikimedia.org/61113) [18:23:22] (03CR) 10Florianschmidtwelzow: [C: 04-1] Update WikiGrok logging according to the new schema changes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [18:23:37] bearND: http://android-builds.wmflabs.org/ seems updating... [18:23:42] from the cron, even [18:23:49] bmansurov: what’s your wiki username? [18:24:10] DarTar: Bmansurov (WMF) [18:24:23] YuviPanda: good. That wasn't the case last week. [18:24:44] bearND: yeah, it still needs some care, and the patch isn't merged yet. I'll work on it this week along with my ops stuff [18:24:58] still haven't replaced logging... [18:25:23] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167402 (https://bugzilla.wikimedia.org/61113) (owner: 10Florianschmidtwelzow) [18:26:03] YuviPanda: Would you copy the new apk to the old server so that people get updates? From then on it should automatically pick from the new server [18:26:46] bearND: I think I should just issue a redirect from the old address [18:26:55] (03CR) 10Jdlrobson: [C: 032] Fix gap between focus highlight and rounded border on login page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167395 (owner: 10Esanders) [18:26:56] so our links elsewhere kinda work too [18:26:56] bmansurov: cool, I’ll ping you and kaldari on some comments I am leaving re: schemas and hashing [18:27:15] DarTar: ok [18:27:32] (03Merged) 10jenkins-bot: Fix gap between focus highlight and rounded border on login page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167395 (owner: 10Esanders) [18:27:51] bearND: 27:41 E/adb: Failed to get the adb version: Cannot run program "adb": error=2, No such file or directory [18:27:57] bearND: I get that when I try to use ASM. [18:28:37] bmansurov: I see your userpage is a redlink on Meta, but you should receive notifications [18:29:30] (03CR) 10Jdlrobson: [C: 032] Use special message for some namespaces for "return" link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167402 (https://bugzilla.wikimedia.org/61113) (owner: 10Florianschmidtwelzow) [18:30:03] (03Merged) 10jenkins-bot: Use special message for some namespaces for "return" link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167402 (https://bugzilla.wikimedia.org/61113) (owner: 10Florianschmidtwelzow) [18:30:09] (03PS5) 10Phuedx: Add the WikiGrokResponse API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 [18:30:44] (03CR) 10jenkins-bot: [V: 04-1] Add the WikiGrokResponse API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 (owner: 10Phuedx) [18:30:45] Deskana: do you have adb in your PATH? [18:31:22] kaldari, bmansurov: did you reach a final conclusion on what element to use for widgetOffset and scrollOffset? If so, that should probably go in the field desc itself (the more this is self-documenting, the better) [18:31:54] bearND: Hmm, I guess not actually. [18:32:24] DarTar: I think we agreed to use the WikiGrok dialog for that [18:32:38] DarTar, bmansurov: I assume scrollOffset is not related to any elements, as the simplest thing to look at is simply how many pixels the user has scrolled. [18:32:39] bmansurov: for both fields? [18:33:09] DarTar: yes, that's how it's currently implemented. Do you think I should use something else? [18:33:16] Deskana: asm requires the Android SDK to be installed [18:33:17] kaldari: so is that the top of the viewport? [18:33:59] (03PS6) 10Phuedx: Add the WikiGrokResponse API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 [18:34:10] bearND: Deskana it also requires adb to be in your PATH [18:34:38] in other words, I’d like to document: (1) when the impression is fired (what element needs to be visible) and (2) how each offset is exactly calculated [18:35:06] DarTar: bmansurov will need to answer that though since he's writing the code. I have to run unfortunately... [18:35:58] DarTar: 1) the impression is fired once at least half of the WikiGrok dialog is visible (both horizontal and vertical halves) [18:36:30] DarTar: thanks for your responses on the wikigrokresponse schema [18:36:34] i'll update my implementation [18:36:44] phuedx: yw [18:36:45] also, thanks for pointing me eventcapsule! [18:37:08] 3MobileFrontend / 3Feature requests: The message Mobile-frontend-talk-back-to-page is confusing outside of the main Talk space - 10https://bugzilla.wikimedia.org/61113 (10Jon) 5PATC>3RESO/FIX [18:37:12] DarTar: 2) Widget offset is the distance between the top of the widget and the top of the viewport; Scroll offset is the distance between top of the viewport and top of the page [18:37:33] bmansurov: excellent, [18:37:34] (03PS1) 10Jdlrobson: Use the svg version in beta for issues icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167634 (https://bugzilla.wikimedia.org/67423) [18:37:57] do you mind if I update the desc? I guess we haven’t finalized the rev_id to be deployed yet, right? [18:39:13] (03PS7) 10Phuedx: Add the WikiGrokResponse API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 [18:39:25] DarTar: nope, ^ that change is tracking the number though [18:39:31] be kind to me is what i'm saying ;) [18:42:09] phuedx: ic, do you want me to hold off? I’d like the docs to be in a good shape before we finalize the rev_id, (there should be strictly no change to the instrumentation other than the rev_id – I’m just mnodifying the desc fieldsa). I can take care of this right now if that’s ok and not too late [18:43:12] (03PS4) 10Bmansurov: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [18:43:40] phuedx: sorry, I’m back [18:44:33] DarTar: change away, i'll put a note on the change that the revId needs to be finalised before merge [18:44:44] phuedx: fantastic [18:45:18] (03CR) 10Florianschmidtwelzow: [C: 04-1] Update WikiGrok logging according to the new schema changes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [18:45:53] DarTar: or we could finalise before we deploy, w/e, we'll make sure the schemas are correct :) [18:47:12] (03PS5) 10Bmansurov: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [18:47:58] (03CR) 10jenkins-bot: [V: 04-1] Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [18:53:03] phuedx, bmansurov, kaldari: https://meta.wikimedia.org/w/index.php?title=Schema%3AMobileWebWikiGrok&diff=10263893&oldid=10231593 [18:53:12] I think this captures all we said [18:53:12] (03CR) 10Florianschmidtwelzow: [C: 04-1] Update WikiGrok logging according to the new schema changes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [18:53:51] and just to clarify, both measurements are captured for all events, not just widget-impressions, correct? [18:54:47] (at the very least widgetOffset should be fired with page-impression for those events when the user doesn’t see the widget) [18:55:24] brb [18:55:56] DarTar: no, but I can capture it for all events [18:56:58] DarTar: I think the widget offset description should be changed. It is the distance between the top of the widget and the top of the VIEWPORT (not page) [19:00:04] (03PS2) 10Siebrand: Rephrase the error_network_error string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167197 (owner: 10Amire80) [19:00:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167197 (owner: 10Amire80) [19:02:51] bearND: yay on beta :) [19:03:00] :) [19:08:26] bearND: I got the screen monitor working but the resolution is incorrect. [19:08:31] bearND: Any ideas on how to fix that? [19:09:01] Deskana: if you right-click there shoul dbe a menu you can zoom [19:09:03] set zoom [19:09:12] Ahhhh [19:09:13] Thanks [19:09:22] Deskana: for me I usually have to resize the window once right after start [19:09:44] then it'll spring to the right size for me [19:10:24] Small pox article would be a good example :) [Not safe for lunch] [19:12:31] It's all working! Thanks bearND, brion. :) [19:18:36] (03PS11) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [19:19:11] (03CR) 10jenkins-bot: [V: 04-1] Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [19:19:36] bearND, YuviPanda: Is there a mximum cache size for the Android app? There is a user on OTRS, who had 50 MB cache and data size for Wikipedia app. Or is the cache controlled by Android itself? [19:21:31] (03PS12) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [19:21:59] FlorianSW: I think it's set by the system. dbrant or bearND would know better. [19:22:27] ok, thanks uviPanda. Hope bearND or dbrant has an answer :) [19:23:44] :) [19:24:37] (03Abandoned) 10Jdlrobson: WIP: Preference search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/159514 (owner: 10Jdlrobson) [19:27:57] (03CR) 10Jdlrobson: [C: 04-1] "Can you make this fix without the list class (just use page list for time being)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167377 (owner: 10Florianschmidtwelzow) [19:30:07] 3MobileFrontend / 3stable: Last modified bar Gray is too light - 10https://bugzilla.wikimedia.org/72223#c2 (10Jon) Created attachment 16824 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16824&action=edit Kaity/Moiz is this an improvement or not? [19:36:52] 3MobileFrontend / 3stable: Talk: "Return to "Foo" page." appears on talk page needs design love - 10https://bugzilla.wikimedia.org/71919#c3 (10Jon) I was thinking more to whether the link should be so prominent. The main issue seems to be the proximity to "About this talk page" I meant to link to https://en... [19:39:07] 3MobileFrontend / 3stable: Add some margin/padding to search ajax loader - 10https://bugzilla.wikimedia.org/72272#c2 (10Jon) This also effects Wikigrok when you click next. [19:41:04] FlorianSW: the cache is indeed controlled by the Android OS itself. We don't have control of it (nor would we want to). [19:41:36] dbrant: ok, like i thought :) Thanks! [19:50:48] g'night folks [19:50:54] brb [19:51:05] jdlrobson: your patches are first on my toreview list for tomo morning [19:51:13] or maybe later tonight if i can't sleep ;) [19:51:26] (03CR) 10Florianschmidtwelzow: "sure :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167377 (owner: 10Florianschmidtwelzow) [19:56:58] dbrant: bearND hey what query parameters are you guys using to get edit token? [19:57:47] checking... [19:57:48] dbrant: bearND i’m seeing this error message: "action=tokens has been deprecated. Please use action=query&meta=tokens instead" [19:58:32] the parameters ios had been using were action=tokens type=edit [19:59:23] mhurd: we're using the same as you are [19:59:34] Deskana|Away: just wanted to clear something up from the showcase; I was suggesting making most of the features toggleable in settings in the BETA app only, that way we can get hard numbers on usage and how many people revert features that we can use to make informed decisions for production [19:59:42] (03PS3) 10Florianschmidtwelzow: ake sure, loading circle is really visible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167377 [19:59:50] bearND: if that error msg is to be believed we’ll need to update... [20:00:12] bearND: rather, it was a warning msg [20:01:11] mhurd: when do you get the warning? [20:01:19] bearND: when i update the parameters, i now only get a “csrftoken” key in the response. will confirm w max that this is what we should use... [20:01:42] bearND: when i print out the raw response from the query. [20:02:25] mhurd: ok, keep dbrant and me in the loop, whatever you figure out we'll probably have to do the same [20:04:00] (03PS4) 10Florianschmidtwelzow: Seperate list style from page-list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 [20:04:45] (03PS4) 10Florianschmidtwelzow: Make sure, loading circle is really visible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167377 [20:04:58] jdlrobson: ^ thanks for review :) [20:05:22] (03CR) 10Jdlrobson: [C: 032] Make sure, loading circle is really visible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167377 (owner: 10Florianschmidtwelzow) [20:05:57] (03Merged) 10jenkins-bot: Make sure, loading circle is really visible [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167377 (owner: 10Florianschmidtwelzow) [20:06:09] bearND: max showed me this: https://www.mediawiki.org/wiki/API:Meta#tokens [20:06:24] thx Jon! :) [20:07:03] bearND: it looks like “edittoken” is now “csrftoken” [20:07:28] bearND: according to that docs link. max confirmed this [20:13:37] 3Wikipedia App / 3Android App: Formula looks grabled on small screen devices and black theme - 10https://bugzilla.wikimedia.org/72250#c1 (10Florian) 5UNCO>3NEW Confirmed on HTC Wildfire S (3,2" like the tipo). [20:20:26] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [20:21:17] (03PS1) 10Jhernandez: Testtesttest [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167658 [20:23:09] (03PS6) 10Bmansurov: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [20:23:42] (03CR) 10Jhernandez: "Test." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167658 (owner: 10Jhernandez) [20:25:21] (03PS2) 10Jhernandez: Testtesttest [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167658 [20:25:48] bmansurov: I’m in a meeting but hack away and I’ll follow up [20:26:05] DarTar: ok [20:31:54] dbrant: any questions on the edit token change? [20:37:21] mhurd: I don't believe so.... am I correct that the new API call is already available in the current version of MW, but the old call will be removed in the upcoming version? [20:37:39] dbrant: MaxSem ^ does this sound right max? [20:38:22] really depends... migration timeline can vary greatly [20:38:41] you can assume that the old style will not be gone for a few months [20:38:54] cool [20:38:58] (if not years) [20:39:06] but ok to switch to new style now? [20:39:12] however, it's best to switch to the new style [20:39:38] because every app version stays on some users devices [20:40:11] so you want to keep the app working even for older versions for longer [20:46:56] (03PS1) 10Bmansurov: Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 [20:55:30] dbrant, bearND: Let's focus on the search stuff for now then, we're already behind on that. We'll try and work this in to an upcoming sprint. [20:55:58] Deskana: roger [21:03:26] kristenlans: We're just about to kick Abbey out of the room. :) [21:05:39] (03CR) 10Florianschmidtwelzow: [C: 031] "looks much better" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [21:05:59] kristenlans: You're both silent and not transmitting video, FYI. [21:22:02] (03PS1) 10BearND: Fix PreviewTaskTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167704 [21:27:12] tfinc, kristenlans: [21:27:12] https://www.mediawiki.org/wiki/Wikimedia_Engineering/2014-15_Goals [21:27:19] Thanks [21:28:05] (03CR) 10Siebrand: "i18n/L10n reviewed." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161368 (https://bugzilla.wikimedia.org/70989) (owner: 10Florianschmidtwelzow) [21:31:03] vbamba: meeting looks like it’s runnign over, may be a few mins late [21:50:21] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166089 (owner: 10Florianschmidtwelzow) [21:58:36] joakino: http://en.m.wikipedia.beta.wmflabs.org/ [22:10:40] 3Wikipedia App / 3Android App: Crashes caused by opening Wikipedia links from Facebook app - 10https://bugzilla.wikimedia.org/72283 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None In particular, the Facebook app: STACK_TRACE=java.lang.RuntimeException: Unable to start activity ComponentInfo{org.wikipe... [22:12:06] (03CR) 10Deskana: "Reply to comment." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [22:22:00] dbrant|bbl, bearND, YuviPanda|zzz: How do I get an APK out of Android Studio? [22:22:17] dbrant|bbl, bearND, YuviPanda|zzz: I just ran a build with Gradle, but I don't want to put it on my device, I want to email it to someone. [22:22:32] (03CR) 10Siebrand: Add watchlist functionality. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [22:23:39] (03CR) 10Deskana: "Reply." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [22:27:21] Deskana: look in the wikipedia/build/outputs/apk. Pick the latest one. I would skip the "unaligned" ones. [22:27:56] bearND: I only have "intermediates". [22:28:15] That's the only thing in that directory. [22:28:18] /build/intermediates/ [22:28:31] Deskana: I would just hit the run button, then it'll produce the output folder, too [22:28:38] (03PS1) 10Robmoen: Give spinner same margins as search result text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167719 (https://bugzilla.wikimedia.org/72272) [22:28:56] or debug would do it, too, of course [22:31:01] bearND: Hmm, still not there. I only have intermediates. [22:31:42] Deskana: the above was for Android Studio. If you prefer command line then I've got a list of commands compiled for you at https://github.com/wikimedia/apps-android-wikipedia#Useful_Gradle_commands [22:31:51] Yeah, I was using Android stuido. [22:31:53] Wait a sec... [22:32:38] Yeah, there's ntohing in that fold afterwards. :/ [22:32:53] *nothing in that folder [22:32:54] Weird. [22:33:41] Deskana: wanna jump to the batcave? [22:34:26] bearND: Maybe tomorrow. I probably should be focussing on my actual job anyway. :-p [22:35:00] Deskana: ok, you can also try the commandline ^ [22:35:11] bearND: Will do. Thanks. [22:44:39] (03PS7) 10Bmansurov: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [22:46:40] (03PS8) 10Bmansurov: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [22:51:14] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [22:52:31] (03CR) 10jenkins-bot: [V: 04-1] Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [22:59:41] (03PS9) 10Bmansurov: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [23:09:07] (03CR) 10Jdlrobson: [C: 031] "The code looks fine to me. Kaldari/MaxSem care to take a closer look?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 (owner: 10Phuedx) [23:12:04] (03CR) 10Jdlrobson: [C: 032] "Seems to fix the loader in all the places I can think of it being invoked." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167719 (https://bugzilla.wikimedia.org/72272) (owner: 10Robmoen) [23:12:43] (03Merged) 10jenkins-bot: Give spinner same margins as search result text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167719 (https://bugzilla.wikimedia.org/72272) (owner: 10Robmoen) [23:14:24] 3MobileFrontend / 3alpha: Wikigrok loader to close to right of panel - 10https://bugzilla.wikimedia.org/72286 (10Jon) 3NEW p:3Unprio s:3normal a:3None Click next. The loader doesn't have a right margin and looks cramped up against the right of the screen. [23:15:23] 3MobileFrontend / 3alpha: Wikigrok loader to close to right of panel - 10https://bugzilla.wikimedia.org/72286#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/u8kjkOqI [23:20:04] (03CR) 10Jdlrobson: [C: 04-1] Update WikiGrok logging according to the new schema changes (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [23:20:20] (03PS5) 10Jdlrobson: Seperate list style from page-list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 (owner: 10Florianschmidtwelzow) [23:21:10] (03CR) 10Jdlrobson: [C: 04-1] "I'm not sure how I feel about this. 'page-list' gave semantic meaning to the list - it's a list of pages." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 (owner: 10Florianschmidtwelzow) [23:25:57] (03CR) 10Jdlrobson: [C: 04-1] Limit the number of tag suggestions displayed in the WikiGrok panel to 6 (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [23:26:19] (03Abandoned) 10Jdlrobson: Testtesttest [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167658 (owner: 10Jhernandez) [23:26:26] (03CR) 10Bmansurov: [C: 032] Make opting into beta/alpha work on localhost [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 (owner: 10Jdlrobson) [23:27:04] (03Merged) 10jenkins-bot: Make opting into beta/alpha work on localhost [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167106 (owner: 10Jdlrobson) [23:33:04] (03CR) 10Jdlrobson: [C: 04-1] "Use 14" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167403 (https://bugzilla.wikimedia.org/72223) (owner: 10Florianschmidtwelzow) [23:34:40] (03CR) 10MaxSem: [C: 04-2] "Per discussion with Kaldari, this should go to Extension:WikiGrok. Also see inline comments." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 (owner: 10Phuedx) [23:37:56] bmansurov, I was telling kaldari that I’m totally lost on the offset instrumentation, do you have a moment to chat over voice? [23:38:11] DarTar: yes 2mins [23:38:26] alright, cool – let me find a room [23:39:20] scrap that, I’m at a table with a whiteboard behind me [23:39:21] ping me when you’re ready [23:41:55] kaldari|2: is there a reference schema for the wikigame db somewhere ? [23:43:14] DarTar: hangout? [23:44:13] bmansurov: yes, 1 sec [23:47:13] bmansurov: do you have a skype id? [23:47:17] no idea what’s going on [23:47:23] m6ahodir [23:47:35] k cool [23:48:23] bmansurov: sent an invite