[00:14:17] (03PS10) 10Bmansurov: WIP: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [00:15:33] (03PS1) 10Dbrant: [WIP] Ability to switch between prefix- and full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 [00:16:56] jdlrobson: are you gonna send a note out to the mailing list w/outcomes of what to grok? [00:17:33] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Ability to switch between prefix- and full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 (owner: 10Dbrant) [00:20:27] rmoen: Sorry was in meetings. Which DB are you refering to? The DB for the suggestions or the DB for the results? [00:21:25] DarTar, bmansurov: Were you guys able to work out the offset stuff? Let me know if I can help. I'm finally done with meetings for today :) [00:22:16] kaldari|2: yes, we’re good [00:22:26] kaldari|2: but I want you to sanity check one last thing [00:22:32] where are you hiding? [00:23:13] DarTar: at my desk now [00:24:02] kaldari|2: alright, can you come over to the table in front of diderot for a sec? [00:24:11] new fancy diagram to show you :) [00:24:21] sure... [00:37:56] 3Wikipedia App / 3Android App: Android app doesn't have the 'X' to remove typed text in Saved pages or History - 10https://bugzilla.wikimedia.org/72288 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None 1. Tap W 2. Tap Saved pages 3. Type anything Notice how there is not 'X to clear your input text.... [00:46:07] 3MobileFrontend / 3stable: Add some margin/padding to search ajax loader - 10https://bugzilla.wikimedia.org/72272 (10Jon) 5PATC>3RESO/FIX [00:51:40] bmansurov: your idea of viewports as a unit was approved, I have a picture and some notes to share [00:51:51] DarTar: great [01:00:29] kaldari|2: i think we can declare victory on your wikidata query service spike [01:00:38] unless you really really want to add more to it [01:01:07] Maryana: MaxSem says he's going to look over it tomorrow morning for sanity check. [01:01:14] ok, cool [01:01:56] I looked at it today already, but am too sleepy for this looing to have any effect [01:02:06] :) [01:12:39] 3MobileFrontend / 3General/Unknown: Mobile sites are causing a lot of 404s in production - 10https://bugzilla.wikimedia.org/71571#c3 (10Jon) Update Max? [01:13:53] 3MobileFrontend / 3Hygiene: Standardise on our grey colours - 10https://bugzilla.wikimedia.org/65381#c9 (10Jon) 5PATC>3RESO/FIX This is done. [01:16:08] 3MobileFrontend / 3alpha: Wikigrok loader too close to right of panel - 10https://bugzilla.wikimedia.org/72286 (10Jon) [01:17:44] bmansurov: I like your viewports idea. That will make the data more human-readable, i.e. '<1' mean widget was in view port, '~2' means they had to scroll 2 pages down. [01:17:59] (03PS2) 10Dbrant: [WIP] Ability to switch between prefix- and full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 [01:18:06] instead of having to calculate difference of pixels [01:18:28] (03PS1) 10Deskana: Only fire onboarding 'start' event the first time the activity is created. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167737 [01:22:02] kaldari|2: that was DarTar's idea ;) [04:05:27] (03PS3) 10Dbrant: [WIP] Ability to switch between prefix- and full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 [05:18:28] (03PS2) 10Florianschmidtwelzow: Don't use a too light gray for top-bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167403 (https://bugzilla.wikimedia.org/72223) [05:32:22] 3MobileFrontend / 3stable: Talk: "Return to "Foo" page." appears on talk page needs design love - 10https://bugzilla.wikimedia.org/71919#c4 (10Florian) Ah, ok, you mean in beta :) I'm unsure, which link is less important as the other (so which should be at the less prominent place at the bottom and which at... [05:35:47] (03PS1) 10Florianschmidtwelzow: Fix i18n [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167746 [05:36:27] (03CR) 10Florianschmidtwelzow: Fixes for Talk feature (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161368 (https://bugzilla.wikimedia.org/70989) (owner: 10Florianschmidtwelzow) [05:59:06] (03PS2) 10Deskana: Only fire onboarding 'start' event the first time the activity is created. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167737 [10:33:34] (03CR) 10Phuedx: "Bmansurov: if you could abandon this patch and resolve the bug as WONTFIX, then we can move the card across. Woo!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) (owner: 10Bmansurov) [12:05:57] (03CR) 10Raimond Spekking: [C: 032] Fix i18n [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167746 (owner: 10Florianschmidtwelzow) [12:09:31] (03Merged) 10jenkins-bot: Fix i18n [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167746 (owner: 10Florianschmidtwelzow) [13:33:03] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167797 (https://bugzilla.wikimedia.org/69245) [13:34:46] (03CR) 10Zfilipin: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167797 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [14:16:22] (03CR) 10Phuedx: [C: 031] "This LGTM. Bmansurov, Robmoen, Kaldari: want to take a look?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 (https://bugzilla.wikimedia.org/68758) (owner: 10Jdlrobson) [14:52:40] 3MobileFrontend / 3General/Unknown: Special:Nearby broken for desktop on enwiki - 10https://bugzilla.wikimedia.org/72313 (10Aaron Halfaker) 3NEW p:3Unprio s:3normal a:3None https://en.wikipedia.org/wiki/Special:Nearby (fails with JS error) https://en.m.wikipedia.org/wiki/Special:Nearby (works) JS Er... [14:55:42] 3MobileFrontend / 3General/Unknown: Special:Nearby broken for desktop on enwiki - 10https://bugzilla.wikimedia.org/72313#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ltdiMTbD [15:31:35] (03CR) 10Dbrant: [C: 032] Fix PreviewTaskTest [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167704 (owner: 10BearND) [15:33:25] (03CR) 10Dbrant: [C: 032] Rephrase the error_network_error string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167197 (owner: 10Amire80) [15:37:13] (03PS8) 10Phuedx: Add the WikiGrokResponse API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 [15:38:09] (03CR) 10Phuedx: Add the WikiGrokResponse API (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 (owner: 10Phuedx) [15:39:22] 3Wikipedia App / 3Android App: JSONException: Value (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/167825 (https://bugzilla.wikimedia.org/69245) [15:45:18] (03CR) 10Dbrant: [C: 04-1] "extremely minor nit." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167737 (owner: 10Deskana) [15:46:53] 3Wikipedia App / 3Android App: NPE when pageimages.PageImageSaveTask.onFinish calls data.ContentPersister.upsert - 10https://bugzilla.wikimedia.org/68895#c4 (10Alex Monk) What about https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7894669 ? [15:46:57] (03PS3) 10Deskana: Only fire onboarding 'start' event the first time the activity is created. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167737 [15:47:04] dbrant: Fixed! :) [15:47:39] (03CR) 10Dbrant: [C: 032] Only fire onboarding 'start' event the first time the activity is created. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167737 (owner: 10Deskana) [15:47:48] I love my IRC client. [15:47:54] CODE REVIEW +32! [15:48:02] it's that good! [15:48:04] !!!!one [15:48:47] (03PS1) 10Zfilipin: Prepare repository for running RuboCop after every push to Gerrit [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/167826 (https://bugzilla.wikimedia.org/69245) [15:49:24] bey bearND! [15:49:27] *hey [15:49:28] (03CR) 10Zfilipin: "check experimental" [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/167826 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [15:50:41] bearND: here's my stuff so far: https://gerrit.wikimedia.org/r/167732 -- if you're working on recent searches, you may want to base on top of it :) [15:50:43] hi dbrant [15:51:27] dbrant: i'll chek it out [15:52:11] dbrant: why not keep the search fragment in the backstack? [15:54:23] 3Wikipedia App / 3Android App: NPE from data.ContentPersister.upser t - 10https://bugzilla.wikimedia.org/68895 (10Alex Monk) 5RESO/INV>3REOP [15:54:56] bearND: so, that's not set in stone, and I could change it back if necessary, but it was feeling like a bit of a "heavy" transition when the search icon was clicked. This way, the search fragment pops up instantaneously on top of the current topmost fragment. And when the search is dismissed, the topmost fragment doesn't need to be reloaded. [15:58:29] bearND: this would also follow the "pattern" that only the items accessible from the Nav menu are placed on the backstack. [16:01:21] dbrant: yeah, I didn't like the transition between the page and the search fragment, and felt it was a bit heavy, too. I did like the ability to go back to the search results. Will see how it feels with recent search implemented. [16:05:40] (03PS1) 10Phuedx: Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 [16:06:13] (03Abandoned) 10Phuedx: Add the WikiGrokResponse API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167574 (owner: 10Phuedx) [16:09:23] 3MobileFrontend / 3Feature requests: Table borders are always shown - 10https://bugzilla.wikimedia.org/37222#c12 (10Erasmo Barresi) For instance, take a look at https://en.wikisource.org/wiki/Alice%27s_Adventures_in_Wonderland_(1866) . Template:Header uses a table, but not all the borders have to be shown. B... [16:15:53] 3MobileFrontend / 3General/Unknown: Special:Nearby broken for desktop on enwiki - 10https://bugzilla.wikimedia.org/72313#c2 (10Jon) uh oh. (grumbles about there being no basic browser tests due to technical restrictions) [16:24:04] (03CR) 10Jforrester: [C: 032] "CI change; no code affected yet." [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/167826 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:24:22] (03CR) 10Jforrester: [C: 032] "CI change; no code affected yet." [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/167825 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:24:29] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/167826 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:24:45] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/167825 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:26:36] (03CR) 10Jforrester: [C: 032] "CI change; no code affected yet." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167797 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:28:29] (03CR) 10Siebrand: "Thank you, Florian." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161368 (https://bugzilla.wikimedia.org/70989) (owner: 10Florianschmidtwelzow) [16:32:41] (03Merged) 10jenkins-bot: Prepare repository for running RuboCop after every push to Gerrit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167797 (https://bugzilla.wikimedia.org/69245) (owner: 10Zfilipin) [16:51:05] Good morning joakino! [16:51:18] Hi! [16:51:32] It’s official: https://www.mediawiki.org/wiki/Mobile_web/Team :-) [16:52:38] cool! :D [16:53:01] \o/ [16:53:24] judging from the picture, joakino is invisible O_O [16:54:09] Joakino: do you know if you wil be able to get an official WMF photo taken while you’re in SF? [16:54:49] no idea [16:57:34] there is a couple of weeks ahead, so whenever you want [16:58:17] joakino: Cool, I have asked HR folks is there are any photo sessions planned while you’re here (cc’ed you). [16:58:40] ok, great! [16:59:18] joakino: welcome :) [16:59:47] FlorianSW: thanks! [16:59:48] joakino: if you want to get an IRC cloak, check out https://meta.wikimedia.org/wiki/IRC/Cloaks#Obtaining_a_cloak [17:00:05] (03CR) 10Florianschmidtwelzow: "I thanks you :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/161368 (https://bugzilla.wikimedia.org/70989) (owner: 10Florianschmidtwelzow) [17:01:51] kaldari|2: talking about cloaks, I haven't received mine yet. Who should I talk to? [17:02:32] joakino: Welcome to the Foundation. Looking forward to working with you. [17:02:55] bmansurov: thanks! [17:16:11] activity!!! [17:16:25] (03PS1) 10Dbrant: Catch exception when an unknown Parcelable is in our intent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167833 (https://bugzilla.wikimedia.org/72283) [17:16:27] HELLO EVERYONE HOW ARE YOU I AM WELL THANKS JUST DOING SOME CODE REVIEW [17:18:18] *tumbleweed* [17:20:29] also, hey joakino_ :) [17:22:40] 3MobileFrontend / 3stable: Regression: This page has issues - 10https://bugzilla.wikimedia.org/72320 (10Jon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16829 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16829&action=edit before This page has issues is not displaying correctly. It'... [17:22:44] phuedx: hello, glad you're well [17:23:08] 3MobileFrontend / 3stable: Regression: This page has issues - 10https://bugzilla.wikimedia.org/72320#c1 (10Jon) Created attachment 16830 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16830&action=edit after [17:25:23] 3MobileFrontend / 3stable: Regression: This page has issues - 10https://bugzilla.wikimedia.org/72320#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/0RrE1jkl [17:26:26] 3MobileFrontend / 3Hygiene: QA: Update Scenario: Check more button exists browser test - 10https://bugzilla.wikimedia.org/72321 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon This visits the page info page to check if a page has more than 50 edits. It should instead verify this information using the API. Th... [17:28:40] 3MobileFrontend / 3stable: Regression: Hash doesn't reveal section - 10https://bugzilla.wikimedia.org/72322 (10Jon) 3NEW p:3Unprio s:3normal a:3None Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_section_test_page#Section_2A on a mobile screen. Expected: Section 2A should be expanded. Ac... [17:30:53] 3MobileFrontend / 3stable: Regression: Hash doesn't reveal section - 10https://bugzilla.wikimedia.org/72322#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/WBGV4Nem [17:33:14] bmansurov: hey bmansurov you there? [17:33:23] jdlrobson: yes [17:33:45] bmansurov: I just looked at the browser tests and we had a bunch of regressions. One relates to the toggling code [17:33:52] so I think it might be triggered by the change you made [17:33:52] 3Wikipedia App / 3Android App: the languages list shows the languages in a suboptimal way - 10https://bugzilla.wikimedia.org/66917#c3 (10Dmitry Brant) Hi Trilok, Your contribution would be most welcome! The issue is that, when you click on "Read in other languages" in the app, it brings up a list of language... [17:34:07] jdlrobson: saving toggled sections? [17:34:09] https://trello.com/c/WBGV4Nem < bmansurov would you be able to take a look [17:34:18] also are you familiar with how to run the browser tests? [17:34:30] i can't remember if we got you setup with those [17:34:44] (03CR) 10Phuedx: [C: 04-1] "A couple of minors inline. Next up: testing!" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [17:34:50] jdlrobson: ok I'll handle that, can you tell me a little about browser tests? [17:36:26] bmansurov: Are you actually working on 4 different cards at once? We usually try to just have 1 or 2 cards in 'In Dev' for each developer. [17:37:00] kaldari|2: no, i'm going to be working on them throughout the day [17:37:13] kaldari|2: i'll put back some of them [17:37:31] bmansurov: there's also code review comments iirc [17:37:49] brb -- george's bedtime [17:38:51] night george phuedx :) [17:39:09] bmansurov: yeh it's good to take just one card at a time - especially given we have a huge team [17:39:39] bmansurov: in terms of running browser tests... [17:40:24] bmansurov: cd tests/browser [17:40:47] cat README and it should tell you all you need to know [17:41:38] To run this particular browser test - bundle exec cucumber features/toggling.feature [17:41:40] 3MobileFrontend / 3stable: "Desktop" link doesn't work on User pages on mobile - 10https://bugzilla.wikimedia.org/72323 (10Moiz Syed) 3NEW p:3Unprio s:3major a:3None If you go to https://en.m.wikipedia.org/wiki/Special:UserProfile/Sue_Gardner and click the "Desktop" link at the bottom, everything bre... [17:41:57] a quick grep for "Respect the hash" (the test that is failing) shows you that is the place to look [17:42:10] Have a read of the readme and let me know if anything isn't clear there [17:42:18] jdlrobson: ok thanks [17:43:08] 3Wikipedia App / 3Android App: Last updated text shows time in the future - 10https://bugzilla.wikimedia.org/70388#c1 (10Dmitry Brant) Is this still reproducible? If not, I'll close. [17:44:23] (03PS11) 10Bmansurov: WIP: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [17:45:23] 3MobileFrontend / 3stable: "Desktop" link doesn't work on User pages on mobile - 10https://bugzilla.wikimedia.org/72323#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/NZPGIO91 [17:46:23] MaxSem: ping [17:46:36] pong [17:46:45] MaxSem: may I PM you? [17:46:53] sure [17:50:37] 3MobileFrontend / 3stable: "Desktop" link doesn't work on User pages on mobile - 10https://bugzilla.wikimedia.org/72323#c2 (10Jon) This is by design. As the page says "This page is not available on desktop. Please click the mobile view link at the bottom of the page." We cannot guarantee support for the des... [17:51:53] 3MobileFrontend / 3stable: "Desktop" link doesn't work on User pages on mobile - 10https://bugzilla.wikimedia.org/72323#c3 (10Jon) Created attachment 16831 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16831&action=edit Special:Userprofile on desktop [17:52:37] 3Wikipedia App / 3Android App: android.os.TransactionTooLargeException (when editing a large page?) - 10https://bugzilla.wikimedia.org/66872#c3 (10Dmitry Brant) 5NEW>3RESO/FIX Should be fixed by https://gerrit.wikimedia.org/r/#/c/161483/ [17:52:47] (03CR) 10Jdlrobson: [C: 032] Don't use a too light gray for top-bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167403 (https://bugzilla.wikimedia.org/72223) (owner: 10Florianschmidtwelzow) [17:52:53] (03PS3) 10Jdlrobson: Don't use a too light gray for top-bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167403 (https://bugzilla.wikimedia.org/72223) (owner: 10Florianschmidtwelzow) [17:54:47] (03PS4) 10Jdlrobson: Don't use a too light gray for top-bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167403 (https://bugzilla.wikimedia.org/72223) (owner: 10Florianschmidtwelzow) [17:56:20] (03CR) 10Jdlrobson: [C: 031] Don't use a too light gray for top-bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167403 (https://bugzilla.wikimedia.org/72223) (owner: 10Florianschmidtwelzow) [17:56:25] (03CR) 10Jdlrobson: [C: 032] Don't use a too light gray for top-bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167403 (https://bugzilla.wikimedia.org/72223) (owner: 10Florianschmidtwelzow) [17:56:40] 3Wikipedia App / 3Android App: Android: ToC button should not just disappear when an article has no sections - 10https://bugzilla.wikimedia.org/66296#c3 (10Dmitry Brant) 5NEW>3RESO/FIX Marking as fixed, given our new implementation of ToC onboarding. [17:57:01] (03Merged) 10jenkins-bot: Don't use a too light gray for top-bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167403 (https://bugzilla.wikimedia.org/72223) (owner: 10Florianschmidtwelzow) [17:57:43] woo, got my broken unit tests working again! i’ll come into the office around noonish and continue [17:57:48] debugger for the win [17:58:07] 3MobileFrontend / 3stable: Last modified bar Gray is too light - 10https://bugzilla.wikimedia.org/72223 (10Jon) 5PATC>3RESO/FIX [18:15:08] 3Wikipedia App / 3Android App: Line appears again when a saved page is being edited while offline - 10https://bugzilla.wikimedia.org/66738#c1 (10Dmitry Brant) 5NEW>3RESO/FIX Fixed by the recent refactoring into fragments. [18:16:02] jdlrobson: I'm reading through the browser test README and I don't quite understand tihs sentence: https://gist.github.com/anonymous/6b2af4d567cdd8d7dc57, can you explain it to me? [18:17:25] 3Wikipedia App / 3Android App: The app crashes when a broken IPv6 connection exists, and doesn't fall back to IPv4 gracefully - 10https://bugzilla.wikimedia.org/67089#c1 (10Dmitry Brant) 5NEW>3RESO/FIX Should be fixed by https://gerrit.wikimedia.org/r/#/c/165246/ and others. [18:20:52] (03CR) 10Siebrand: [C: 032] Correct spelling for Wi-Fi [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/167851 (owner: 10L10n-bot) [18:21:52] 3Wikipedia App / 3Android App: Page footer is sometimes at the top - 10https://bugzilla.wikimedia.org/67317#c2 (10Dmitry Brant) 5NEW>3RESO/FIX Should be fixed by the recent refactoring into fragments. https://gerrit.wikimedia.org/r/#/c/161483/ (but please reopen if still reproducible) [18:23:27] yo [18:24:00] bmansurov: has your question about edit count been addressed? [18:25:22] 3Wikipedia App / 3Android App: Add a magnify image to search bar - 10https://bugzilla.wikimedia.org/68309#c1 (10Dmitry Brant) 5NEW>3RESO/FIX Fixed by our recent refactor into fragments. https://gerrit.wikimedia.org/r/163274 [18:25:39] phuedx: no [18:26:02] bmansurov: create a new account and edit a few pages [18:26:31] then, before you `bundle exec cucumber`, export MEDIAWIKI_USER= [18:26:31] phuedx: I've already created "Selenium_newuser", should I create a new one? [18:26:38] no, that's good [18:26:43] phuedx: ok [18:26:49] and then export MEDIAWIKI_PASSWORD= [18:26:59] so: [18:27:08] * phuedx export MEDIAWIKI_USER=… [18:27:15] ok, silly irc client [18:27:50] phuedx: got it, thanks [18:28:21] you could also put those export statements in yer .{bash,zsh}_profile [18:29:02] great [18:29:04] which i /always/ fail to do [18:29:07] always [18:29:27] Dan-Garry:android-wikipedia dgarry$ git checkout amster [18:29:29] * Deskana sighs [18:29:33] phuedx: you just like to keep your environment variables clean ;) [18:29:41] My Northern accent is now working its way into my git usage [18:29:41] yeah! that! [18:29:47] 'amster [18:30:02] Deskana: more colloquialisms in commit messages [18:30:13] also, bonus points for funny shell aliases [18:30:31] /commands [18:31:25] apt-cache show sl [18:31:42] My friend once aliased javac to j-to-tha-compizzle [18:33:38] hahaha [18:33:52] face [18:34:26] haha oops [18:35:08] 3Wikipedia App / 3Android App: Add config to set the duration time of display screen on - 10https://bugzilla.wikimedia.org/68805#c1 (10Dmitry Brant) 5NEW>3RESO/WON I don't see this happening, for the following reasons: - Keeping the screen on would require a new Permission for the app, which our users wo... [18:35:56] jdlrobson: does https://trello.com/c/heq83aF0/56-use-desktop-login-form-in-alpha-prep-work need design sign off? [18:36:06] phuedx: nah [18:36:23] phuedx: there is a card in the backlog to look at the output and suggest new work [18:37:09] including "maybe we should revert it"? if so, that's a sign off card! ;) [18:40:11] (03PS2) 10Jdlrobson: Use the svg version in beta for issues icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167634 (https://bugzilla.wikimedia.org/67423) [18:41:42] phuedx: nah it's alpha only [18:43:35] vbamba: foods? [18:44:06] jdlrobson: i think there's a typo in https://gerrit.wikimedia.org/r/#/c/165634/7 (userlogin.less) [18:44:22] apart from that it's mergeable [18:44:28] phuedx: correct alpha [18:44:29] as you say, it's alphaphapha [18:44:32] Maryana: lemme know when you have time to go over the Wikidata query specs [18:44:42] can i fix that and then +2 phuedx? [18:45:01] suresies [18:45:31] kaldari|2: i made the mistake of starting to code read the wdq server [18:45:47] it's fascinating, but i stayed up late :/ [18:46:36] (/late/) [18:46:41] phuedx: Yeah, MaxSem has looked at it too. Sounds like it's a beast [18:48:11] yeah, i think few comments would do it a world of good ;) [18:49:22] 3Wikipedia App / 3Android App: Last updated text shows time in the future - 10https://bugzilla.wikimedia.org/70388#c2 (10matanya) 5NEW>3RESO/WOR no longer, can be closed. [18:51:34] kaldari|2: i've got a wall of meetings till 4:30, but i could chat over lunch if you want :) [18:51:35] (03PS1) 10MaxSem: Fix undefined variable: $parserOutput in ApiMobileView::getData [extensions/MobileFrontend] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167861 [18:51:42] (03PS3) 10Jdlrobson: Use the svg version in beta for issues icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167634 (https://bugzilla.wikimedia.org/67423) [18:52:06] Maryana: sure [18:53:20] (03CR) 10Ori.livneh: [C: 032] Fix undefined variable: $parserOutput in ApiMobileView::getData [extensions/MobileFrontend] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167861 (owner: 10MaxSem) [18:53:23] kaldari|2: i'm chatting w/dartar now but will be free at 12 [18:53:30] don't leave for food w/o me! [18:53:33] (03PS8) 10Jdlrobson: Use desktop login/account creation form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 (https://bugzilla.wikimedia.org/68758) [18:53:42] (03CR) 10Jdlrobson: Use desktop login/account creation form in alpha (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 (https://bugzilla.wikimedia.org/68758) (owner: 10Jdlrobson) [18:54:03] (03PS4) 10Jdlrobson: Fix regression and use the svg version in beta for issues icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167634 (https://bugzilla.wikimedia.org/67423) [18:55:05] (03CR) 10Phuedx: [C: 032] Use desktop login/account creation form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 (https://bugzilla.wikimedia.org/68758) (owner: 10Jdlrobson) [18:55:11] pew pew pew [18:55:28] (03Merged) 10jenkins-bot: Fix undefined variable: $parserOutput in ApiMobileView::getData [extensions/MobileFrontend] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167861 (owner: 10MaxSem) [18:55:44] (03Merged) 10jenkins-bot: Use desktop login/account creation form in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165634 (https://bugzilla.wikimedia.org/68758) (owner: 10Jdlrobson) [18:58:36] there should be a code review column is large klaxxon [18:58:40] ^ kristenlans [18:59:22] phuedx: heheh totally. [19:00:44] There *is* a work in progress limiting plugin for trello, if you guys are interested. We could set a threshold for code review. I think if it goes over it turns the column ANGRY RED :x [19:01:15] (03CR) 10Kaldari: [C: 04-1] "This will load all of the WikiGrok dialog code on every page. We need to do some sort of check within wikigrok.js to only load the dialog " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167309 (owner: 10Jdlrobson) [19:01:43] (03PS1) 10MaxSem: Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167867 [19:03:52] kristenlans: nah, if we ever get to swarm on stuff that might bite us [19:05:21] (which i'd like to do, small patches, all workin' together, that'd be good fun) [19:07:11] kristenlans: sorry, i misread [19:07:24] code review should be angry red all the time! [19:07:38] RAGIN’ CODE REVIEW! [19:08:02] sponsored by mountain dew [19:10:15] (03PS1) 10Dbrant: Fix intermittent NPE in DrawerLayout. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167871 (https://bugzilla.wikimedia.org/67808) [19:14:05] Anyone else have an issue with provisioning WikiGrok role ? I'm getting. Error: Could not find class ::role::wikibase for mediawiki-vagrant.dev on node mediawiki-vagrant.dev [19:15:06] bmansurov: sorry that I kept you waiting, I just finished reviewing with Maryana the overall plan for the offset instrumentation and we’re good to go. The only blocker is figuring out how to log a float in a schema, I don’t think I’ve ever done that [19:15:23] rmoen: i get that, i installed the extension manually but haven't fiddled with it much [19:15:36] i just ported a working patch to it [19:15:39] nothing fancy [19:15:39] 3Wikipedia App / 3Android App: App occasionally closes when too much Activity state is stored. - 10https://bugzilla.wikimedia.org/66732 (10Dmitry Brant) 5PATC>3RESO/FIX [19:15:45] phuedx: i see [19:15:56] DarTar: ok, I'll start implementing the new changes [19:16:06] phuedx: I was about to test your change actually :) [19:17:07] rmoen: i'm not sure who to speak to about the role [19:17:18] bmansurov: hold off until I’ve made the last changes [19:17:22] emailing about it is on my todo list but i got deep into review [19:17:56] MaxSem, kaldari|2, jdlrobson: who should we talk to about the wikigrok vagrant role? [19:17:58] DarTar: sure, let me know when you're done [19:18:03] I'm probably going to just checkout the extension [19:19:09] phuedx: I think folks are probably at lunch [19:19:22] boo [19:21:11] rmoen: email' [19:21:14] wow [19:21:15] emailin' [19:21:22] bmansurov: will do [19:24:07] dbrant, my inbox and my sanity thank you for https://gerrit.wikimedia.org/r/#/c/167871/ [19:24:32] Krenair: :) let's hope that does it. [19:24:40] yeah :) [19:26:47] (03CR) 10Phuedx: [C: 032] Fix regression and use the svg version in beta for issues icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167634 (https://bugzilla.wikimedia.org/67423) (owner: 10Jdlrobson) [19:27:09] (03PS1) 10Jdlrobson: Hygiene: More icon abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 [19:27:28] (03Merged) 10jenkins-bot: Fix regression and use the svg version in beta for issues icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167634 (https://bugzilla.wikimedia.org/67423) (owner: 10Jdlrobson) [19:27:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: More icon abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 (owner: 10Jdlrobson) [19:28:22] kristenlans: Wrapping an email up, then coming to chat to you. [19:28:36] Deskana: excellent [19:31:43] ok, i'm gonna head off [19:31:46] g'night folks [19:32:48] (03PS2) 10Jdlrobson: Hygiene: More icon abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 [19:32:50] (03PS13) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [19:33:29] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: More icon abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 (owner: 10Jdlrobson) [19:33:40] phuedx, I thought we had one:) [19:35:30] (03PS3) 10Jdlrobson: Hygiene: More icon abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 [19:35:49] (03PS14) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [19:36:05] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: More icon abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 (owner: 10Jdlrobson) [19:36:36] (03CR) 10Robmoen: [C: 031] "LG2M" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [19:52:54] (03PS1) 10Robmoen: Square up dimensions of WikiGrok spinner for even padding around [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167893 (https://bugzilla.wikimedia.org/72286) [19:53:10] (03PS4) 10Jdlrobson: Hygiene: More icon abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 [19:53:12] (03PS15) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [19:53:31] (03CR) 10jenkins-bot: [V: 04-1] Square up dimensions of WikiGrok spinner for even padding around [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167893 (https://bugzilla.wikimedia.org/72286) (owner: 10Robmoen) [19:54:45] ^ don't look ;/ silly me [19:54:55] (03PS2) 10Robmoen: Square up dimensions of WikiGrok spinner for even padding around [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167893 (https://bugzilla.wikimedia.org/72286) [19:55:16] (03PS5) 10Jdlrobson: Hygiene: More icon abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 [19:55:18] (03PS16) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [19:55:42] (03PS1) 10Bmansurov: Toggle expanded sections only if they are not already expanded. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167895 (https://bugzilla.wikimedia.org/72322) [19:56:47] (03CR) 10Jdlrobson: [C: 04-1] Square up dimensions of WikiGrok spinner for even padding around (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167893 (https://bugzilla.wikimedia.org/72286) (owner: 10Robmoen) [19:58:25] 3Wikipedia App / 3Android App: When trying to create an account, Android mobile app doesn't show error messages from AntiSpoof extension, blocking registration with no explanation - 10https://bugzilla.wikimedia.org/72331 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None When trying to create an... [19:59:16] (03CR) 10Jdlrobson: [C: 04-1] Fix undefined index 'lastmodifiedby' notices (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167867 (owner: 10MaxSem) [20:00:16] (03CR) 10Robmoen: [C: 04-2] Square up dimensions of WikiGrok spinner for even padding around (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167893 (https://bugzilla.wikimedia.org/72286) (owner: 10Robmoen) [20:00:21] (03CR) 10Jdlrobson: [C: 04-1] "All fixes to regressions should have tests so they don't break again." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167895 (https://bugzilla.wikimedia.org/72322) (owner: 10Bmansurov) [20:02:04] (03Abandoned) 10Bmansurov: Scroll to top of the editor with keyboard keys [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) (owner: 10Bmansurov) [20:03:01] (03PS2) 10MaxSem: Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167867 [20:04:23] hey guys, why don't I see the 'wontfix' option in bugzilla? I'd like to close this bug as 'wontfix' but I can't: https://bugzilla.wikimedia.org/show_bug.cgi?id=69092 [20:04:38] phuedx, do you think the way you initialize autoload classes in https://gerrit.wikimedia.org/r/#/c/167829/1/WikiGrok.php is better? [20:04:48] bmansurov, it's under RESOLVED [20:05:04] (03CR) 10Jdlrobson: Toggle expanded sections only if they are not already expanded. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167895 (https://bugzilla.wikimedia.org/72322) (owner: 10Bmansurov) [20:05:15] ^ bmansurov we need a fix for that asap. This is why we test things out in stable first [20:05:26] MaxSem: thanks [20:05:27] the code is running on stable mode for mobile [20:05:43] M.isBetaGroupMember && !M.isWideScreen() is true when in stable and not on tablet [20:05:51] (03PS3) 10Robmoen: Add margin to WikiGrok spinner for even padding around [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167893 (https://bugzilla.wikimedia.org/72286) [20:05:52] 3MobileFrontend / 3General/Unknown: Can't scroll to top in editing window - 10https://bugzilla.wikimedia.org/69092#c8 (10Bahodir Mansurov) 5PATC>3RESO/WON Looks like it has been fixed by other changes. [20:07:38] 3MobileFrontend / 3General/Unknown: Can't scroll to top in editing window - 10https://bugzilla.wikimedia.org/69092#c9 (10Jon) 5RESO/WON>3REOP It's not fixed Baha. I can still replicate it on latest master. Are you sure you understand the bug correctly? Also WONTFIX is only reserved for bugs we know are... [20:08:08] (03CR) 10Jdlrobson: "As stated earlier it's still broken." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165896 (https://bugzilla.wikimedia.org/69092) (owner: 10Bmansurov) [20:09:34] rmoen: that was fast [20:09:41] (03PS2) 10Bmansurov: Toggle expanded sections only if they are not already expanded. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167895 (https://bugzilla.wikimedia.org/72322) [20:09:41] where does .45em come from. Any ideas? [20:10:27] .45em makes it centered. There is .6 padding on the footer pane. Which gives it the 45px height, but .45em is what is perfectly centered. [20:10:38] jdlrobso_: when was the last time you tried to replicate it? I just tested it on chrome (emulated iphone) and it worked fine. [20:10:39] jdlrobso_: so to answer, idk [20:10:53] bmansurov: just this minute [20:11:00] on desktop Chrome [20:11:28] jdlrobso_: can you help me replicate it? [20:11:30] rmoen: mmm. If you can find a logical reason would be cool to use a variable, if not i'll merge later today [20:11:33] bmansurov: 1s [20:11:35] kaity: For a dialog that is just displaying an error message and has an 'OK' button to dismiss, is the 'OK' button progressive or just a regular button? [20:11:43] bmansurov: can you add a test for https://gerrit.wikimedia.org/r/#/c/167895/2/javascripts/modules/toggling/toggle.js [20:12:09] i'm keen to get this merged as I want the M.isBetaGroupMember() fix asap but the new case should have a new test. Could you split out into 2 patches? [20:12:09] jdlrobso_: I open the editor, page down a couple of times and hit the up key multiple times until I see the first line and I see it [20:12:22] jdlrobso_: ok [20:12:23] kaldari|2: you mean blue or green? [20:12:42] kaity: no, blue or white [20:12:53] kaldari|2: blue progressive [20:12:57] bmansurov: as for the textarea problem we can explore that after this is fixed but I simply focus the text area, scroll down a little, then hold key up till it gets to the top [20:13:00] and the top line is obscured [20:13:08] kaity: cool, that was my guess :) [20:13:13] (03PS1) 10Bmansurov: Typo fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167904 [20:13:15] jdlrobso_: logical reason is that it centers it. .license element is also hard coded with a margin-right 4.2em. [20:13:17] kaldari|2: thanks! [20:13:23] (03CR) 10MaxSem: [C: 04-1] "Please put everything into namespace WikiGrok like https://gerrit.wikimedia.org/r/166148 does. At least class EventLogger is almost guaran" (034 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [20:13:34] phuedx, almost there:) [20:14:23] 3Wikipedia App / 3Generic: App stops responding after being used for a while - 10https://bugzilla.wikimedia.org/64450#c9 (10Dmitry Brant) 5REOP>3RESO/FIX nope. [20:14:46] rmoen: guess it relates to the image icon [20:14:50] (03CR) 10Jdlrobson: [C: 032] Add margin to WikiGrok spinner for even padding around [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167893 (https://bugzilla.wikimedia.org/72286) (owner: 10Robmoen) [20:14:54] jdlrobso_: https://gerrit.wikimedia.org/r/167904 [20:15:24] (03Merged) 10jenkins-bot: Add margin to WikiGrok spinner for even padding around [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167893 (https://bugzilla.wikimedia.org/72286) (owner: 10Robmoen) [20:16:08] 3MobileFrontend / 3alpha: Wikigrok loader too close to right of panel - 10https://bugzilla.wikimedia.org/72286 (10Jon) 5PATC>3RESO/FIX [20:16:23] 3Wikipedia App / 3Generic: tap the search box, no cursor indicating for the search - 10https://bugzilla.wikimedia.org/61871#c3 (10Dmitry Brant) 5NEW>3RESO/FIX Won't happen anymore, since we've refactored how the search field appears. [20:16:36] (03PS2) 10Jdlrobson: Typo fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167904 (owner: 10Bmansurov) [20:16:43] (03CR) 10Jdlrobson: [C: 032] Typo fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167904 (owner: 10Bmansurov) [20:17:08] thanks bmansurov [20:17:17] (03PS3) 10Jdlrobson: Toggle expanded sections only if they are not already expanded. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167895 (https://bugzilla.wikimedia.org/72322) (owner: 10Bmansurov) [20:17:37] 3MobileFrontend / 3beta: Regression: Hash doesn't reveal section - 10https://bugzilla.wikimedia.org/72322#c3 (10Jon) Now the problem is only effecting beta. [20:17:55] (03CR) 10Jdlrobson: [C: 04-1] "Please add a test to catch this case." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167895 (https://bugzilla.wikimedia.org/72322) (owner: 10Bmansurov) [20:18:12] (03CR) 10jenkins-bot: [V: 04-1] Toggle expanded sections only if they are not already expanded. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167895 (https://bugzilla.wikimedia.org/72322) (owner: 10Bmansurov) [20:18:20] (03CR) 10Jdlrobson: [C: 032] Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167867 (owner: 10MaxSem) [20:20:23] 3Wikipedia App / 3Generic: [Android] Jump to section doesn't work from google search results - 10https://bugzilla.wikimedia.org/63453#c1 (10Dmitry Brant) 5NEW>3RESO/FIX Fixed in current version of the app. [20:20:36] (03CR) 10jenkins-bot: [V: 04-1] Typo fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167904 (owner: 10Bmansurov) [20:21:16] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167904 (owner: 10Bmansurov) [20:21:29] (03CR) 10jenkins-bot: [V: 04-1] Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167867 (owner: 10MaxSem) [20:22:22] lol, zuul is overflowing with poop again [20:23:22] 3Wikipedia App / 3Generic: On phones with bumper cases and slim bezels, it is hard to pull out drawers - 10https://bugzilla.wikimedia.org/65004#c1 (10Dmitry Brant) 5NEW>3RESO/FIX Fixed in current version. [20:26:41] Hey mobile, there's some feedback about your "media viewer" https://www.mediawiki.org/wiki/Extension_talk:Media_Viewer/About#Responsiveness [20:26:52] I'm not sure if it's a bug you know about or whatnot :) [20:28:07] hey ragesoss: I don't seem to be on the default CC list for new Android bugs... who can add me to the default? [20:29:46] dbrant: Andre is the main person for that. [20:30:10] although I don't see him around today. [20:30:31] ragesoss: ok, thanks! I'll ping him [20:30:35] dbrant: maybe ask greg-g. At the least, he'll know who else can help. [20:30:46] * greg-g looks around [21:00:42] MaxSem: better? [21:00:50] oic, we do it another way in MobileFrontend [21:04:42] (03PS4) 10Bmansurov: Toggle expanded sections only if they are not already expanded. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167895 (https://bugzilla.wikimedia.org/72322) [21:12:10] (03PS1) 10Kaldari: Add error handling to WikiDataApi::getLabels for WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167949 [21:22:38] (03PS2) 10Phuedx: Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 [21:24:10] (03CR) 10Phuedx: Add the WikiGrokResponse API (034 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [21:25:36] ok [21:25:41] i really am going to go now [21:25:46] * phuedx disappears in a cloud of smoke [21:27:51] (03PS2) 10Kaldari: Adding error handling to WikiDataApi::getLabels for WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167949 [21:29:25] 3Wikipedia App / 3Generic: Move from maven to Gradle - 10https://bugzilla.wikimedia.org/63366 (10Dmitry Brant) 5NEW>3RESO/FIX [21:30:36] (03CR) 10Jdlrobson: Typo fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167904 (owner: 10Bmansurov) [21:30:39] (03PS3) 10Jdlrobson: Typo fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167904 (owner: 10Bmansurov) [21:30:44] (03CR) 10Jdlrobson: [C: 032] Typo fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167904 (owner: 10Bmansurov) [21:31:11] (03PS3) 10Jdlrobson: Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167867 (owner: 10MaxSem) [21:31:22] (03Merged) 10jenkins-bot: Typo fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167904 (owner: 10Bmansurov) [21:33:28] (03PS5) 10Jdlrobson: Toggle expanded sections only if they are not already expanded. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167895 (https://bugzilla.wikimedia.org/72322) (owner: 10Bmansurov) [21:33:32] (03CR) 10Kaldari: [C: 032] Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167867 (owner: 10MaxSem) [21:34:07] (03Merged) 10jenkins-bot: Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167867 (owner: 10MaxSem) [21:34:36] (03CR) 10Jdlrobson: [C: 032] Toggle expanded sections only if they are not already expanded. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167895 (https://bugzilla.wikimedia.org/72322) (owner: 10Bmansurov) [21:35:13] (03Merged) 10jenkins-bot: Toggle expanded sections only if they are not already expanded. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167895 (https://bugzilla.wikimedia.org/72322) (owner: 10Bmansurov) [21:35:15] (03CR) 10MaxSem: Add the WikiGrokResponse API (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [21:38:58] (03CR) 10Jdlrobson: [C: 04-1] "I have no idea why you would do this or why it would be useful." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167949 (owner: 10Kaldari) [21:39:33] (03CR) 10Jdlrobson: Adding error handling to WikiDataApi::getLabels for WikiGrok version A (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167949 (owner: 10Kaldari) [21:40:08] 3MobileFrontend / 3General/Unknown: MobileFrontend: Blue "issues" icon should have HiDPI version (or SVG) - 10https://bugzilla.wikimedia.org/67423 (10Jon) 5PATC>3RESO/FIX [21:40:52] 3MobileFrontend / 3beta: Regression: Hash doesn't reveal section - 10https://bugzilla.wikimedia.org/72322 (10Jon) 5PATC>3RESO/FIX [21:41:37] 3MobileFrontend / 3stable: Login form duplicate messages - 10https://bugzilla.wikimedia.org/71771#c9 (10Jon) 5PATC>3ASSI This is now live in alpha. Need to propagate these changes to stable. [21:42:22] 3MobileFrontend / 3stable: Page list item tooltip interferes with watch icon tooltip - 10https://bugzilla.wikimedia.org/71711#c5 (10Jon) 5PATC>3RESO/FIX Wrong bug associated with this patch. [21:43:08] 3MobileFrontend / 3Feature requests: Icons missing/broken on old Nokia phones (X3, C3) - 10https://bugzilla.wikimedia.org/50326#c5 (10Jon) This is now live in alpha. Need to propagate these changes to stable. [21:43:23] 3MobileFrontend / 3stable: Regression: This page has issues - 10https://bugzilla.wikimedia.org/72320 (10Jon) 5PATC>3RESO/FIX [21:43:38] 3MobileFrontend / 3Hygiene: Make commands in MobileFrontend need documentation - 10https://bugzilla.wikimedia.org/71892 (10Jon) 5PATC>3RESO/FIX [21:43:40] (03PS2) 10Jdlrobson: WIP: Add add discussion button to talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166079 (https://bugzilla.wikimedia.org/70614) [21:44:23] 3MobileFrontend / 3stable: No placeholders on account creation or login forms in Opera Mini - 10https://bugzilla.wikimedia.org/68758#c9 (10Jon) 5PATC>3ASSI New login form in alpha solves this issues. Need to get these changes into stable. [21:45:22] 3MobileFrontend / 3stable: Going back to previous page doesn't remember expanded sections - 10https://bugzilla.wikimedia.org/69351#c6 (10Jon) 5PATC>3ASSI This code is now in the beta mode of the site. It will need to be pushed to stable to be considered fixed. [21:48:23] (03PS4) 10Dbrant: Ability to switch between prefix- and full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 [21:51:22] 3MobileFrontend / 3Feature requests: Table borders are always shown - 10https://bugzilla.wikimedia.org/37222#c13 (10Jon) 5UNCO>3RESO/FIX This looks like an issue with wikisource. Wikisource has various rules in https://en.wikisource.org/wiki/MediaWiki:Common.css which are not being loaded in https://en.... [21:58:40] (03PS1) 10Kaldari: Hygiene: Removing version parameter from WikiGrokApi::recordClaims() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167962 [22:05:29] (03PS3) 10Kaldari: Adding error handling to askWikidataQuestion for WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167949 [22:13:25] (03PS2) 10Bmansurov: Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 [22:14:02] (03CR) 10jenkins-bot: [V: 04-1] Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [22:15:11] (03PS3) 10Bmansurov: Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 [22:18:09] mhurd: http://www.amazon.com/gp/product/B00KT7DOR0/ref=oh_aui_detailpage_o00_s00?ie=UTF8&psc=1 [22:25:36] DarTar: can you explain what EventCapsule is? [22:26:19] kaldari|2: the meta-schema that defines all fields that are collected by default for all events [22:27:00] DarTar: got it. [22:28:15] DarTar: So the point of the host field wasn't actually to know the host, but just to have a quick way to see which records were tests and which were real. Would it be better to add a 'test' field that is just binary? [22:30:52] (03CR) 10Bmansurov: [C: 032] Hygiene: Removing version parameter from WikiGrokApi::recordClaims() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167962 (owner: 10Kaldari) [22:31:26] (03Merged) 10jenkins-bot: Hygiene: Removing version parameter from WikiGrokApi::recordClaims() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167962 (owner: 10Kaldari) [22:31:52] DarTar: honestly, I'm not even sure how EventLogging works on places like Beta Labs. Is it using it's own EventLogging server/tables or the main ones or none? [22:32:00] (03PS1) 10MaxSem: Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167968 [22:32:58] (03PS1) 10MaxSem: Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167969 [22:33:08] (03CR) 10MaxSem: [C: 032] Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167968 (owner: 10MaxSem) [22:33:20] (03CR) 10MaxSem: [C: 032] Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167969 (owner: 10MaxSem) [22:33:43] (03Merged) 10jenkins-bot: Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] (wmf/1.25wmf3) - 10https://gerrit.wikimedia.org/r/167968 (owner: 10MaxSem) [22:33:50] kaldari|2: no, there’s no difference between different hosts / site versions. All data is written into the same db [22:33:57] (03Merged) 10jenkins-bot: Fix undefined index 'lastmodifiedby' notices [extensions/MobileFrontend] (wmf/1.25wmf4) - 10https://gerrit.wikimedia.org/r/167969 (owner: 10MaxSem) [22:34:19] (03PS1) 10Jhernandez: Use :8080 in Makefile and tasks as default url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167970 [22:36:53] (03PS2) 10Jdlrobson: Hygiene: Cleanup the toggling test code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 [22:36:56] (03PS1) 10Jdlrobson: Hygiene: Refactor pageImage.js to be a method on PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167971 [22:36:57] (03PS1) 10Jdlrobson: WIP: Make watchlist load page images beyond top 50 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167972 [22:37:30] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup the toggling test code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 (owner: 10Jdlrobson) [22:37:39] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Refactor pageImage.js to be a method on PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167971 (owner: 10Jdlrobson) [22:37:46] (03CR) 10jenkins-bot: [V: 04-1] WIP: Make watchlist load page images beyond top 50 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167972 (owner: 10Jdlrobson) [22:38:14] (03PS2) 10Jdlrobson: Make watchlist load page images beyond top 50 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167972 (https://bugzilla.wikimedia.org/71961) [22:38:48] (03CR) 10jenkins-bot: [V: 04-1] Make watchlist load page images beyond top 50 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167972 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [22:41:35] (03PS1) 10Robmoen: Move wgMFThumbnailSizes to js hooks as its used outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167974 (https://bugzilla.wikimedia.org/72313) [22:42:10] (03CR) 10Bmansurov: [C: 031] "Not sure if these should also be changed:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167970 (owner: 10Jhernandez) [22:42:11] DarTar: what are your thoughts on my testing question above? [22:45:58] kaldari|2: anyway I can reference the schema for the tables listed here ? https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok#Claim_suggestions [22:46:21] I sent an email last night but it must have slipped through the cracks [22:47:49] (03CR) 10Jdlrobson: [C: 032] Use :8080 in Makefile and tasks as default url (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167970 (owner: 10Jhernandez) [22:48:24] (03Merged) 10jenkins-bot: Use :8080 in Makefile and tasks as default url [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167970 (owner: 10Jhernandez) [22:56:03] (03CR) 10Jdlrobson: [C: 032] Adding error handling to askWikidataQuestion for WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167949 (owner: 10Kaldari) [22:56:39] (03Merged) 10jenkins-bot: Adding error handling to askWikidataQuestion for WikiGrok version A [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167949 (owner: 10Kaldari) [22:57:19] (03PS3) 10Jdlrobson: Hygiene: Cleanup the toggling test code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 [22:59:28] (03CR) 10Kaldari: [C: 04-1] "Somehow the schema was missing fields for subject and subjectId. I've added those now. See https://meta.wikimedia.org/wiki/Schema:MobileWe" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [23:00:49] (03CR) 10Kaldari: "The testing field is optional, BTW, so we probably should just leave it null unless we explicitly know that the submission is a test." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [23:03:53] (03CR) 10Bmansurov: [C: 04-1] "In additions to the inline comments, I think the following should be removed from 'less/modules/toggle.less'" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 (owner: 10Jdlrobson) [23:04:55] (03CR) 10Bmansurov: "please ignore my comment about removing .open-block, I was wrong." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 (owner: 10Jdlrobson) [23:05:38] (03PS2) 10Kaldari: WikiGrok B shouldn't depend on user having an occupation. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167309 (owner: 10Jdlrobson) [23:06:26] (03CR) 10Bmansurov: Hygiene: Cleanup the toggling test code (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 (owner: 10Jdlrobson) [23:06:58] (03CR) 10Jdlrobson: [C: 04-1] "A few issues with this when there are less than 6 labels." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [23:07:42] (03CR) 10Kaldari: [C: 032] WikiGrok B shouldn't depend on user having an occupation. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167309 (owner: 10Jdlrobson) [23:08:49] jdlrobson: when you say "This line is difficult to read. I'd suggest caching the variable. " what variable do you mean? [23:08:56] (03CR) 10Jdlrobson: [C: 032] "LD ?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167974 (https://bugzilla.wikimedia.org/72313) (owner: 10Robmoen) [23:10:15] bmansurov: i mean i find it really hard to read that line of code :-) [23:10:36] result.push( array[ Math.round( Math.random() * ( arrayLength - 1 ) ) ] ) [23:10:45] too many parenthesizes [23:16:53] jdlrobson: what is LD? [23:16:55] (03PS1) 10Jdlrobson: Fix history browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167983 (https://bugzilla.wikimedia.org/72321) [23:17:14] oh duh [23:17:18] rmoen: :) [23:17:21] :) [23:17:27] greg-g: Any idea why this isn't merging: https://gerrit.wikimedia.org/r/#/c/167309/1 [23:17:34] (03PS2) 10Jdlrobson: Hygiene: Refactor pageImage.js to be a method on PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167971 [23:17:36] (03PS3) 10Jdlrobson: Make watchlist load page images beyond top 50 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167972 (https://bugzilla.wikimedia.org/71961) [23:17:50] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167309 (owner: 10Jdlrobson) [23:18:24] (03CR) 10jenkins-bot: [V: 04-1] Make watchlist load page images beyond top 50 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167972 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [23:19:22] 3MobileFrontend / 3General/Unknown: Special:Nearby broken for desktop on enwiki - 10https://bugzilla.wikimedia.org/72313 (10Jon) 5PATC>3RESO/FIX [23:20:44] (03CR) 10Kaldari: [C: 032] Fix history browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167983 (https://bugzilla.wikimedia.org/72321) (owner: 10Jdlrobson) [23:21:58] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167983 (https://bugzilla.wikimedia.org/72321) (owner: 10Jdlrobson) [23:22:19] (03CR) 10Jdlrobson: Move wgMFThumbnailSizes to js hooks as its used outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167974 (https://bugzilla.wikimedia.org/72313) (owner: 10Robmoen) [23:22:24] (03CR) 10Jdlrobson: [C: 032] Move wgMFThumbnailSizes to js hooks as its used outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167974 (https://bugzilla.wikimedia.org/72313) (owner: 10Robmoen) [23:22:50] (03CR) 10Jdlrobson: [C: 032] WikiGrok B shouldn't depend on user having an occupation. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167309 (owner: 10Jdlrobson) [23:22:50] kaldari|2: asking the wrong guy, ask in -qa :) [23:25:06] greg-g: Who should I ask? [23:25:44] (03Merged) 10jenkins-bot: WikiGrok B shouldn't depend on user having an occupation. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167309 (owner: 10Jdlrobson) [23:25:48] (03Merged) 10jenkins-bot: Move wgMFThumbnailSizes to js hooks as its used outside Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167974 (https://bugzilla.wikimedia.org/72313) (owner: 10Robmoen) [23:32:22] kaldari|2: the -qa channel or the -operations channel (think: do you ask rob-la about an error in mediawiki core?) [23:32:24] (03Merged) 10jenkins-bot: Fix history browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167983 (https://bugzilla.wikimedia.org/72321) (owner: 10Jdlrobson) [23:37:26] (03PS4) 10Bmansurov: Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 [23:38:00] (03CR) 10jenkins-bot: [V: 04-1] Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [23:38:51] (03CR) 10Bmansurov: "recheck, please?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [23:40:40] (03PS5) 10Bmansurov: Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 [23:41:17] (03CR) 10jenkins-bot: [V: 04-1] Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [23:45:11] DarTar: any updates on the new schema? [23:46:39] 3MobileFrontend / 3stable: opening sidebar menu doesn't work correctly on iOS 8+ Safari because of Safari's controls can cover the menu click area - 10https://bugzilla.wikimedia.org/71575#c10 (10Jon) 5UNCO>3RESO/WON I looked at this with James, and although the UX is horrible I am sure this will effect o... [23:49:28] bmansurov: oh god, I promised this 8 hours ago :( [23:49:47] hacking it now, the float support discussion (see engineering list) was the main blocker [23:50:30] DarTar: ok cool [23:52:42] (03PS1) 10Dr0ptp4kt: Support colorized zero-rating croutons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167987 [23:53:05] (03CR) 10Kaldari: [C: 04-1] WIP: Update WikiGrok logging according to the new schema changes (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [23:53:23] bmansurov, kaldari|2: https://meta.wikimedia.org/w/index.php?title=Schema%3AMobileWebWikiGrok&diff=10278582&oldid=10265207 [23:53:32] ok? [23:54:03] DarTar: thanks [23:54:30] np, there are a few more questions on the talk page that need some love [23:54:35] DarTar: looks fine to me. I think bmansurov may have to update the code to make the scrollOffset measured in viewports. [23:54:52] 3MobileFrontend / 3Hygiene: QA: Update Scenario: Check more button exists browser test - 10https://bugzilla.wikimedia.org/72321 (10Jon) 5PATC>3RESO/FIX [23:54:54] cool, thanks guys [23:55:04] DarTar: Also, I made some changes to the Results schema. Could you take a look? [23:55:09] bmansurov, kaldari|2: https://meta.wikimedia.org/wiki/Schema_talk:MobileWebWikiGrok [23:55:13] ah ok [23:55:29] sure [23:55:37] DarTar: https://meta.wikimedia.org/w/index.php?title=Schema%3AMobileWebWikiGrokResponse&diff=10278193&oldid=10262608 [23:55:40] bmansurov, kaldari|2: https://meta.wikimedia.org/wiki/Schema_talk:MobileWebWikiGrokResponse [23:56:04] bearND, dbrant|bbl: mind reviewing https://gerrit.wikimedia.org/r/167987 ? [23:56:17] kaldari|2: subject: yes, good catch [23:56:57] kaldari|2: did you see my note on valueSelected on the talk page? [23:57:19] that’s the rationale for “required” [23:57:20] DarTar: I'm confused about the selected field. Can we discuss? [23:57:41] sure, I’m sitting in front of the big WP logo near the entrance [23:58:32] (03CR) 10Jdlrobson: Hygiene: Cleanup the toggling test code (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 (owner: 10Jdlrobson) [23:58:43] (03PS4) 10Jdlrobson: Hygiene: Cleanup the toggling test code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 [23:58:58] dr0ptp4kt: will take a peek later [23:59:59] bearND: thx