[00:05:44] bmansurov: making one more change to the schema, after talking to kaldari|2 and moiz [00:05:54] DarTar: sure [00:06:58] (03PS5) 10BearND: [WIP] Ability to switch between prefix- and full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 (owner: 10Dbrant) [00:06:59] (03PS1) 10BearND: Recent searches [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167991 [00:07:48] (03CR) 10jenkins-bot: [V: 04-1] Recent searches [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167991 (owner: 10BearND) [00:10:13] DarTar: FYI, I'm rounding the offsets to the nearest hundredth. Is that cool? [00:12:08] bmansurov: wfm [00:12:32] great [00:14:16] (03PS2) 10BearND: Recent searches [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167991 [00:15:41] (03CR) 10jenkins-bot: [V: 04-1] Recent searches [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167991 (owner: 10BearND) [00:17:00] (03PS3) 10BearND: Recent searches [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167991 [00:20:32] (03PS1) 10Jdlrobson: Hygiene: Documentation cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167998 [00:20:47] (03PS12) 10Bmansurov: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [00:23:40] (03Abandoned) 10BearND: Recent searches [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167991 (owner: 10BearND) [00:27:19] (03PS1) 10Jdlrobson: Documentation: Document all the classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168001 [00:27:36] kaldari|2, bmansurov: marked issues that I think are closed as {{done}} https://meta.wikimedia.org/wiki/Schema_talk:MobileWebWikiGrokResponse [00:27:53] (03PS1) 10BearND: Recent searches [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168002 [00:27:57] there’s one open issue related to the last question on that page that kaldari|2 with relay to the team [00:30:06] DarTar: since the userToken is persistent, I think the way you described works fine [00:30:45] kaldari|2: it does but it’s problematic, privacy-wise [00:30:55] sorry, that was for bmansurov [00:32:29] DarTar, bmansurov: added some additional comments at https://meta.wikimedia.org/wiki/Schema_talk:MobileWebWikiGrokResponse#Event_lookup_for_users_with_a_completed_response [00:32:34] DarTar: given the way we construct the userToken, it is not that easy to figure out the username from the token. but, you're right, once figured out, it will be problematic [00:33:04] bmansurov: well, we have a 1:1 mapping from userId to userToken for all stored responses [00:33:36] so technically we could reconstruct the entire browsing history for a userId (limited to articles with WikiGrok enabled) [00:33:46] which is a no go [00:33:55] DarTar: i see [00:34:04] (03PS1) 10Jdlrobson: Hygiene: Surface warnings for missing documentation in jsduck command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168005 [00:34:21] bmansurov: check kaldari|2’s proposal [00:34:48] I second #2 and I don’t see any reason not to do that, but we’ll need to make sure Maryana/Howie etc are ok with it [00:35:24] I have to leave the office in a moment but can follow up later or on the lists [00:36:31] ttyl folks [00:36:39] later Danny_B [00:36:41] oops [00:37:56] 3MobileFrontend / 3General/Unknown: Documentation warnings for JavaScript - 10https://bugzilla.wikimedia.org/72341 (10Jon) 3NEW p:3Unprio s:3normal a:3None Warning: Warning type no_doc is deprecated, use nodoc(class,public) instead Warning: Warning type no_doc_member is deprecated, use nodoc(member... [00:38:22] 3MobileFrontend / 3General/Unknown: Documentation warnings for JavaScript - 10https://bugzilla.wikimedia.org/72341#c1 (10Jon) The above can be generated by `make jsduck` after checking out https://gerrit.wikimedia.org/r/168005 [00:40:38] (03PS2) 10Jdlrobson: Hygiene: Surface warnings for missing documentation in jsduck command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168005 [00:48:31] (03CR) 10Bmansurov: [C: 032] Hygiene: Surface warnings for missing documentation in jsduck command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168005 (owner: 10Jdlrobson) [00:50:31] (03CR) 10MaxSem: [C: 04-1] Add the WikiGrokResponse API (033 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [00:50:58] (03CR) 10MaxSem: "(-1 is due to unneded parameter, the rest is pure discussion)" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [00:51:20] (03CR) 10Bmansurov: [C: 032] Hygiene: Documentation cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167998 (owner: 10Jdlrobson) [00:51:49] (03CR) 10Kaldari: "Sorry to move the goalposts on you, but the schema has been revised extensively after several conversations with Dario and Maryana. Please" [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [01:24:08] (03CR) 10Jdlrobson: [C: 04-1] "Just some minor documentation moans." (036 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 (owner: 10MaxSem) [01:32:54] (03CR) 10Kaldari: [C: 04-1] Update WikiGrok logging according to the new schema changes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [01:33:52] (03CR) 10Jdlrobson: [C: 04-1] "http://localhost:8080/w/load.php?debug=false&lang=en&modules=startup&only=scripts&skin=minerva&target=mobile&* is also throwing a 500 exce" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [01:34:55] (03CR) 10Jhernandez: [C: 031] Hygiene: Documentation cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167998 (owner: 10Jdlrobson) [01:37:18] (03CR) 10Jhernandez: [C: 031] Hygiene: Surface warnings for missing documentation in jsduck command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168005 (owner: 10Jdlrobson) [01:40:50] (03PS1) 10Robmoen: WIP: New WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [01:40:55] (03CR) 10jenkins-bot: [V: 04-1] WIP: New WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [01:42:10] (03CR) 10Jdlrobson: [C: 04-1] "Failing tests" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [01:42:16] Boo, will rebase tomorrow and follow up with changes to api [01:46:32] (03CR) 10Robmoen: "Will rebase and followup tomorrow." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [03:41:42] (03PS6) 10BearND: Ability to switch between prefix- and full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 (owner: 10Dbrant) [04:44:09] (03CR) 10BearND: "cherry-picked PS4" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 (owner: 10Dbrant) [04:46:46] (03PS1) 10Deskana: Fix all funnels to only fire 'start' events the first time they're created. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168040 [04:49:18] (03PS12) 10Deskana: Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [04:49:38] (03CR) 10Deskana: "Addressed Siebrand's concerns. Should be good to go now." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [05:04:35] (03CR) 10BearND: [C: 04-1] "Almost there. Just some minor layout issues." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 (owner: 10Dbrant) [05:06:33] (03PS2) 10BearND: Recent searches [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168002 [05:35:22] 3Wikipedia App / 3Android App: When trying to create an account, Android mobile app doesn't show error messages from AntiSpoof extension, blocking registration with no explanation - 10https://bugzilla.wikimedia.org/72331#c1 (10Dan Garry) Confirmed. I tried to create De5kana, and the app just said it couldn't... [05:49:04] (03CR) 10BearND: "One more thing: when searching for " " (one or more spaces) it results in a network error." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 (owner: 10Dbrant) [05:50:55] (03PS3) 10BearND: Recent searches [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168002 [05:54:37] (03CR) 10BearND: [C: 032] "nice! :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167871 (https://bugzilla.wikimedia.org/67808) (owner: 10Dbrant) [05:54:58] (03Merged) 10jenkins-bot: Fix intermittent NPE in DrawerLayout. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167871 (https://bugzilla.wikimedia.org/67808) (owner: 10Dbrant) [05:55:47] (03PS2) 10BearND: Catch exception when an unknown Parcelable is in our intent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167833 (https://bugzilla.wikimedia.org/72283) (owner: 10Dbrant) [05:57:26] (03CR) 10BearND: [C: 032] Catch exception when an unknown Parcelable is in our intent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167833 (https://bugzilla.wikimedia.org/72283) (owner: 10Dbrant) [05:57:46] (03Merged) 10jenkins-bot: Catch exception when an unknown Parcelable is in our intent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167833 (https://bugzilla.wikimedia.org/72283) (owner: 10Dbrant) [07:26:24] 3Wikipedia App / 3Android App: Crashes caused by opening Wikipedia links from Facebook app - 10https://bugzilla.wikimedia.org/72283 (10Alex Monk) 5PATC>3RESO/FIX [10:12:22] 3Wikipedia App / 3Android App: NPEs from android.support.v4.widget.DrawerLayout.isContentView ? - 10https://bugzilla.wikimedia.org/67808 (10Alex Monk) 5PATC>3RESO/FIX [11:04:10] 3Wikipedia App / 3Android App: Code tag margins too big, overlapping borders - 10https://bugzilla.wikimedia.org/72354 (10Svick) 3NEW p:3Unprio s:3normal a:3None Created attachment 16840 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16840&action=edit Screenshot from the app Code tags show wi... [11:18:53] 3Wikipedia App / 3Android App: Code tag margins too big, overlapping borders - 10https://bugzilla.wikimedia.org/72354#c1 (10Svick) BTW, the screenshot is from [[Blackboard_bold#Encoding]]. [11:20:25] 3Wikipedia App / 3Android App: Code tag margins too big, overlapping borders - 10https://bugzilla.wikimedia.org/72354 (10Svick) [11:37:27] Yay, I got the feedback queue down to 21 pages. [11:37:33] (wait, ****.) [11:46:38] 3Wikipedia App / 3Android App: Code tag margins too big, overlapping borders - 10https://bugzilla.wikimedia.org/72354#c2 (10Alex Monk) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 49033 *** [11:46:38] 3MobileFrontend / 3Feature requests: MobileFrontend: Inline code tags styled very large in articles - 10https://bugzilla.wikimedia.org/49033#c10 (10Alex Monk) *** Bug 72354 has been marked as a duplicate of this bug. *** [12:06:32] (03PS3) 10Phuedx: Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 [12:08:14] (03CR) 10Phuedx: Add the WikiGrokResponse API (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [12:30:07] (03PS4) 10Phuedx: Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 [12:37:57] (03CR) 10Phuedx: "Kaldari: wgDBname and the host are recorded as part of Schema:EventCapsule (see Dario's response to my question about including host [0])." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [12:39:37] (03CR) 10Phuedx: Add the WikiGrokResponse API (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [13:37:33] 330ish starting tickets, subtract 264 total in the android feedback queue now. 66 done. [13:44:18] (03CR) 10Florianschmidtwelzow: WIP: Add add discussion button to talk pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166079 (https://bugzilla.wikimedia.org/70614) (owner: 10Jdlrobson) [14:00:58] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7898273 - lol, ios [14:01:19] and there's still 6 tickets in https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketQueue;QueueID=323;View=Preview waiting for someone like Deskana to look into [14:33:23] (03CR) 10Phuedx: [C: 04-1] "I like this a lot! A major and a minor documentation error inline." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 (owner: 10Jdlrobson) [15:36:42] * bearND waves at dbrant [15:36:55] bearND: hey hey [15:37:23] how's it going with the full-text search toggle patch? [15:38:28] bearND: working on your comments now! I haven't considered RTL implications... [15:39:34] dbrant: for the white space stuff you could use SearchArticlesFragment.isValidQuery() [15:39:54] ah yes [16:04:19] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [16:07:55] (03PS2) 10BearND: Support colorized zero-rating croutons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167987 (owner: 10Dr0ptp4kt) [16:08:34] (03CR) 10BearND: "rebased manually" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167987 (owner: 10Dr0ptp4kt) [16:09:33] (03CR) 10BearND: [C: 032] Support colorized zero-rating croutons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167987 (owner: 10Dr0ptp4kt) [16:10:26] (03Merged) 10jenkins-bot: Support colorized zero-rating croutons [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167987 (owner: 10Dr0ptp4kt) [16:10:44] (03PS2) 10BearND: Fix all funnels to only fire 'start' events the first time they're created. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168040 (owner: 10Deskana) [16:16:38] (03CR) 10BearND: [C: 032] Fix all funnels to only fire 'start' events the first time they're created. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168040 (owner: 10Deskana) [16:17:16] (03Merged) 10jenkins-bot: Fix all funnels to only fire 'start' events the first time they're created. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168040 (owner: 10Deskana) [16:58:44] dbrant: hey! I am going to miss standup today, have nothing to report. hope that's ok :) [16:58:48] kristenlans: ^ [16:59:53] (03CR) 10Kaldari: "@Phuedx: I think so. Will elaborate later..." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [17:00:27] YuviPanda: no worries [17:11:48] moizsyed: do we have screenshots of the current version (b) of WikiGrok on Commons? [17:11:55] I can’t find them [17:12:59] Maryana: ^ ? [17:15:11] no, not yet [17:15:31] i can upload some, though [17:15:50] was waiting for the patch to go through to limit the number of tags, since right now it looks kind of janky :) [17:16:04] Maryana: yeah that’d be great, I’m starting to flesh out the page on Meta and could use some screenshots of the final designs [17:16:23] DarTar: I can send you a mock, its not on commons tho [17:16:45] moizsyed: upload it and make the wikis happy! [17:16:57] DarTar: doing it now [17:17:02] <3 [17:17:06] moizsyed: can you take a look at https://trello.com/c/N2mUO2nE/60-onboarding-wikidata-task some time soon? [17:17:32] kaldari: yeah lets talk about this today [17:17:48] MARKTRACEUR: HAPPY CAPS LOCK DAY [17:18:04] kaldari: when can you talk hosts? [17:20:24] phuedx: Yeah, I agree we don't need the host, but we could still benefit from filtering out some of the test cases. Typically, when I'm testing WikiGrok, I just always use the same article (MegaMan) and force the wikidata ID to one of the ones listsed at https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok#Local_testing... [17:20:37] kaldari: the idea with that task was for 90% developer art :) [17:20:50] and maybe 10% input from moizsyed if he has the time [17:21:26] Maryana: If you and moizsyed are fine with that, it's fine with me [17:21:48] kaldari, phuedx: I created a BZ ticket to find a better way to filter out test events https://bugzilla.wikimedia.org/show_bug.cgi?id=72365 [17:22:02] input welcome (not something that’s going to happen soon anyway) [17:22:43] phuedx: so we could mark all of those as test cases. In the long term, DarTar has some ideas for other solutions. [17:23:26] phuedx: You don't actually have to instrument the test handling as part of that card, just make the API be able to handle it. [17:23:38] phuedx: does that sound like a good plan? [17:25:21] jdlrobson: YAYYYY [17:29:38] jdlrobson: how can I run qunit-mobile tests locally? what's the command? [17:30:12] sorry kaldari [17:30:21] d/c [17:30:38] (i think bt are tinkering with lines) [17:30:59] brion: have a sec? [17:31:02] (i've been d/c'ed randomly for the last two days) [17:31:19] mhurd: i’m sitting in on the scrum of scrums but i can irc chat for a few minutes while other folks talk :D [17:31:39] brion: cool! the question is about the file NSURLRequest+DictionaryRequest.m [17:32:01] brion: the line is this one: [request addValue:@"application/x-www-form-urlencoded; charset=UTF-8" forHTTPHeaderField:@"Content-Type"]; [17:32:12] hmmmmm [17:32:23] not 100% sure that’s needed, but …. it may be :D [17:32:25] for the post req and this one for the get: [request addValue:@"application/x-www-form-urlencoded" forHTTPHeaderField:@"Content-Type"]; [17:32:33] phuedx: so we could mark all of those as test cases. In the long term, DarTar has some ideas for other solutions. [17:32:37] phuedx: You don't actually have to instrument the test handling as part of that card, just make the API be able to handle it. [17:32:41] brion: would it hurt to use the first one for both cases? [17:32:48] phuedx: does that sound like a good plan? [17:32:54] kaldari, kaldari|2, DarTar: my thing is that on a vagrant instance, wgDBname will be devwiki [17:33:05] brion: the first one specifies the charset [17:33:11] but i guess i shouldn't rely on that being true for everyone [17:33:21] mhurd: i think it should only add the Content-Type on POST requests [17:33:27] i don’t think it should actually be doing it on GETs [17:33:42] kaldari|2: i'm alright with the explicit flag, i just feel like i've missed something :) [17:33:48] phuedx: Yeah, I agree we don't need the host, but we could still benefit from filtering out some of the test cases. Typically, when I'm testing WikiGrok, I just always use the same article (MegaMan) and force the wikidata ID to one of the ones listsed at https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok#Local_testing... [17:33:50] phuedx: indeed, we have a ton of test events in EL with arbitrary hostnames and/or wiki DB names [17:34:07] phuedx: maybe you missed that one too [17:34:19] kaldari|2, DarTar: i'll add the test flag and bump the schema rev id [17:34:40] YuviPanda: just so that i can understand your moves Today -> Mon ? [17:34:44] mhurd: yeah on the POST it should include it with charset, and on GET it shouldn’t be there at all [17:34:51] brion: that’s where it gets tricky - will have to see if i can specify different headers for gets vs posts w/ afnetworking [17:35:10] bmansurov: https://gerrit.wikimedia.org/r/#/c/167697/ needs more work [17:35:11] phuedx, kaldari|2: it looks like the head revision of the response schema has all we need, check it out [17:35:12] should be able to doit conditionally somehow yeah :D [17:35:37] jdlrobson: what else does it need besides failing tests? [17:35:38] mhurd: on the plus side, if you can’t do it conditionally i don’t think it hurts anything to have the header [17:35:46] mhurd: and it would be safe to use the same one (with charset) for both :D [17:35:57] *to have the header on GET [17:36:21] phuedx: So does that make sense? I can write up the details in an email if it's easier. [17:36:29] DarTar: https://commons.wikimedia.org/wiki/File:Wikidata_Tagging.png [17:36:31] brion: it i can use the one w charset on both i can easily do so… [17:36:35] *if* [17:36:45] mhurd: yeah that should work fine [17:36:46] DarTar: sorry im in a meeting, took a lot of time [17:36:52] moizsyed: thanks man [17:37:07] kaldari|2: yeah, i was assuming wgDBname would be enough, but we're not in control of it [17:37:09] an explicit flag makes sense [17:37:19] brion: do you recall what “x-www-form-urlencoded” does? [17:37:30] phuedx, kaldari|2: should we add a “testing” flag to the interaction log too (not just the response log)? [17:37:38] mhurd: that specifies which form submission mode is used for the POST data [17:37:49] jdlrobson: qunit-mobile is failing and I don't know how to run it locally, can you help? [17:37:52] brion: ya just found the docs... [17:37:53] mhurd: it’s the default type as it happens, so it might also work without the header ;) [17:38:03] mhurd: but there are other types, like multipart which is used for file uploads [17:38:07] brion: it seems to! :) [17:38:32] DarTar: yeah, that's probably a good idea [17:38:34] DarTar: that makes sense to me [17:38:41] brb -- george's bedtime [17:38:49] moizsyed: sorry to be a pain, but do we have the same series of screenshots for the workflow of version A too? [17:38:50] brion: nothing seems to not work presently w/o it… should i just leave it off since it’s default? [17:39:02] Make sure bmansurov gets pinged if you change the regular schema [17:39:04] DarTar: sure let me upload that too [17:39:13] moizsyed: thanks [17:39:28] kaldari|2: sure [17:39:30] brion: then if we get any funkiness w the testflight release we can look at re-adding it? [17:39:53] mhurd: yeah let’s do that :D [17:39:55] simple is good [17:39:55] bmansurov: the qunit tests are failing because the tests do not work :) [17:40:00] bmansurov: you run them with `make qunit` [17:40:03] brion: yea! :) [17:40:09] jdlrobson: it's not qunit, it's qunit-mobile [17:40:14] jdlrobson: qunit tests are not failing [17:40:17] bmansurov: same thing [17:40:29] brion: i like it! [17:40:31] tfinc: yeah, today to tuesday [17:40:33] tfinc: couldn't find any free slot on your calendar till tehn [17:40:50] * YuviPanda has spotty internet, IRC and gerrit are ok chat will be a bit hard [17:40:56] k, move it again as you only moved it on my calendar [17:40:58] err [17:41:00] on your* [17:41:00] jdlrobson: so when I do `make-qunit` I get 0 failed. but when I push for a review jenkins tests fail [17:41:19] bmansurov: I think it is to do with setup/teardown [17:41:22] navigate to http://localhost:8080/wiki/Special:JavaScriptTest/qunit# [17:41:22] tfinc: ok, let me just cancel and re-create [17:41:55] dbrant, bearND: haaai [17:42:13] jdlrobson: ok thanks [17:42:27] Deskana: ohai [17:42:47] dbrant, bearND: So, we now have this release process which we should use to guide us here: https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Release_process [17:43:26] DarTar: https://commons.wikimedia.org/wiki/File:Wikidata_Tagging_A.png [17:43:55] (03PS6) 10Jdlrobson: Hygiene: More icon abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 [17:43:58] (03CR) 10Jdlrobson: Hygiene: More icon abstraction (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 (owner: 10Jdlrobson) [17:44:10] dbrant, bearND: I'm a little uneasy about rushing to push something out there when the cards are still in code review and all I've seen are mocks. :-) [17:44:31] (03CR) 10Jdlrobson: [C: 032] "Trigger jenkins" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167998 (owner: 10Jdlrobson) [17:44:44] (03PS2) 10Jdlrobson: Hygiene: Documentation cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167998 [17:44:52] (03CR) 10Jdlrobson: [C: 032] "cherry picked to master" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167998 (owner: 10Jdlrobson) [17:44:58] (03PS2) 10Jdlrobson: Documentation: Document all the classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168001 [17:45:28] (03PS3) 10Jdlrobson: Hygiene: Surface warnings for missing documentation in jsduck command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168005 [17:45:33] (03Merged) 10jenkins-bot: Hygiene: Documentation cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167998 (owner: 10Jdlrobson) [17:45:35] (03PS4) 10Jdlrobson: Hygiene: Surface warnings for missing documentation in jsduck command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168005 [17:45:43] (03CR) 10Jdlrobson: [C: 032] "cherry picked to master" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168005 (owner: 10Jdlrobson) [17:45:52] Deskana: understandable. Although we're only talking about submitting an "unpublished" version to be reviewed by Google. If they "approve" the version that we submit, will it necessarily mean that we need to publish that exact version on the Play Store? [17:46:21] (03Merged) 10jenkins-bot: Hygiene: Surface warnings for missing documentation in jsduck command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168005 (owner: 10Jdlrobson) [17:46:26] dbrant, bearND: This is a little unclear to me. I can't imagine that us asking to be featured, them saying yes, then us going "Uh... perhaps later?" would go down very well... [17:46:59] dbrant, bearND: On the other hand, there's no guarantee they'll say yes anyway. [17:48:26] moizsyed: awesome [17:49:11] phuedx, bmansurov, kaldari|2: https://meta.wikimedia.org/wiki/Schema_talk:MobileWebWikiGrok#Test_flag [17:50:01] DarTar: hi, when the userEditCount is null, do you prefer me not to send this variable or send 0 or some other value? [17:50:22] bmansurov: can it ever be NULL for logged in users? [17:50:23] * Deskana scratches his head and thinks. [17:50:46] Deskana: your call; I suppose all this new code could use a little time to "settle down"... [17:50:53] it should be NULL if it’s missing (i.e. when we roll it out to anons), have a non-null value otherwise [17:50:54] DarTar: I'm not sure but some tests are failing, maybe because the user is not logged in [17:51:00] dbrant, bearND: I feel like we're safer by not rushing to the finish line. We can always submit a follow-up build later with our new search stuff in it. :-) [17:51:23] kaldari|2: There's a spider hanging in mid-air between us! [17:51:38] bmansurov: right. It’s not required, so that’s the expected behavior [17:51:53] if it fails for logged in users, tho, that might be a problem [17:51:54] 3MobileFrontend / 3Hygiene: QA: Scenario: Successful edit reloads language button test fails - 10https://bugzilla.wikimedia.org/72368 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon The feature is not broken but the browser test is. timed out after 5 seconds, waiting for {:class=>"toast", :tag_name=>"div"}... [17:51:55] DarTar: ok [17:52:38] dbrant, bearND: Let's go with that. Search can have time to settle, as dbrant says. [17:53:58] dbrant, bearND: So, if you guys could use the time I set aside in that calendar invite to upload the APK so I can send the email to Google telling them we think we're ready, then I'd appreciate that! [17:54:20] Deskana: dbrant: if that's the case then we should use the beta bits from this Monday [17:54:40] Deskana: bearND: yep, agreed [17:55:22] 3MobileFrontend / 3Hygiene: QA: Scenario: Successful edit reloads language button test fails - 10https://bugzilla.wikimedia.org/72368#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/xnGnfpAT [17:55:24] 3MobileFrontend / 3Hygiene: QA: Scenario: Successful edit reloads language button test fails - 10https://bugzilla.wikimedia.org/72368#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/3Pyv5voz [17:55:24] 3MobileFrontend / 3Hygiene: QA: Scenario: Successful edit reloads language button test fails - 10https://bugzilla.wikimedia.org/72368 (10Jon) [17:56:23] (03CR) 10Jdlrobson: [C: 04-1] "I'm not 100% happy with this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167972 (https://bugzilla.wikimedia.org/71961) (owner: 10Jdlrobson) [17:56:38] dbrant: ok, i can make a build and upload it, so you can focuse on the search patch. I still want to get this merged asap. So we can make the subsequent patches dependent on already merged stuff. [17:57:04] bearND: fabulous :) [17:57:18] dbrant: We still should have some blurp in the what's new section. If you or Deskana have some down time feel free to compile a list. [17:58:17] bearND, dbrant: I can do that. Is it just the fragment refactoring, mostly? [17:58:24] (and then associated UX changes) [17:59:35] maryana MaxSem or anyone in office: do you see Sarah R nearby? [17:59:48] kristenlans: i do not [17:59:54] crapstix [18:00:04] need her? [18:00:32] DarTar: can you let analytics team know that I can’t edit health check calendar event to add video call and am trying to find someone who can? [18:00:59] Maryana: yes, kind fo desparately ;-) [18:03:57] Deskana: I sent you an email with the list of all changes since the last prod release until the bump for last beta [18:04:09] bearND: Thanks. :) [18:04:58] (03PS6) 10Bmansurov: Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 [18:05:17] Deskana: so, yeah, mainly the refactoring thingies, plus some minor Nearby changes [18:05:33] (03CR) 10jenkins-bot: [V: 04-1] Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [18:05:47] back [18:07:54] (03CR) 10Kaldari: Update WikiGrok logging according to the new schema changes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [18:09:11] (03PS7) 10Bmansurov: Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 [18:13:10] (03CR) 10Kaldari: [C: 04-1] Add the WikiGrokResponse API (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [18:18:31] Wow, what a captcha. [18:18:53] We've apparently started inserting the names of staff members into our captcha generator. ^_^ [18:19:08] * Deskana uploads picture. [18:19:28] http://i.imgur.com/K1uM4uS.png [18:20:10] haha [18:21:48] ooh that’s the phone running andorid 5? [18:22:05] geometric icons are geometric [18:23:26] Deskana: sent you an apk via email, and uploaded the draft apk. gotta run. [18:23:38] bearND: Thanks! Just finishing the What's New now. [18:23:53] brion: Yeah! It's taking a bit of getting used to... [18:24:59] i’m sooo tempted to get a nexus 9 [18:25:05] but i’m trying to cut down on my device habit ;) [18:25:59] brion: It's better for you that a drug habit... but probably not much cheaper! [18:26:12] hey kid, you want a tablet? first time’s free [18:26:18] awwww yiss [18:26:56] dbrant, bearND|bbl: I sent the What's New around. Many of the patches that "fix" things actually don't result in a fix for the users (e.g. "force overflow menu to display", well, it was previously doing that anyway ;-)) [18:27:19] dbrant, bearND|bbl: So it basically just focusses on the changes that the users will see. But still, let me know if you think I missed anything important. [18:27:32] (03PS5) 10Phuedx: Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 [18:27:46] (03CR) 10Phuedx: Add the WikiGrokResponse API (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [18:27:57] dbrant: While I have your attention... [18:28:11] dbrant: What's your impression of this? https://bugzilla.wikimedia.org/show_bug.cgi?id=72331 [18:29:18] dbrant: Here's the output of the API if you try to create an account called "De5kana": http://pastebin.com/6LGiAmVJ [18:29:32] dbrant: The code that's returned is actually a generic one for "account creation aborted by extension" [18:29:57] Deskana: yeah, we would need a more comprehensive reply from the API... [18:30:10] dbrant: Do you use the API sandbox, btw? [18:30:17] Deskana: yep [18:30:25] dbrant: That was my first time using it. It seems pretty neat. [18:30:43] Deskana: we could go down the route of parsing the html info for certain keywords, but that will get sticky fast. [18:30:49] NOPE [18:30:59] I'm giving that one a NOPE [18:31:02] :) [18:31:15] dbrant: Perhaps you could file a bug against the API in Bugzilla specifying what exactly we want from the API? Like the name of the extension that aborted the creation? [18:31:31] You'd think that that would be relatively easy to add into the output... [18:31:35] Deskana: right :) so, we would need some additional keywords in the API. Yep, I can file a bug. [18:32:36] dbrant: Cheers. :) [18:33:16] (03CR) 10Jdlrobson: [C: 04-1] "Wikigrok A is still broken. When I click yes." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [18:34:15] jdlrobson: can you give me the wikidataid= get variable for testing wikigrok A locally? [18:35:08] bmansurov: use the same one as Wikigrok B [18:35:12] e.g. http://localhost:8080/wiki/Anne%20Dallas%20Dudley?mobileaction=beta&wikidataid=Q3784220 [18:35:18] just do it in beta [18:35:19] (03CR) 10Phuedx: [C: 032] Hygiene: More icon abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 (owner: 10Jdlrobson) [18:35:23] jdlrobson: ok thanks [18:35:57] (03PS7) 10Dbrant: Ability to switch between prefix- and full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 [18:36:04] pew pew pew [18:36:41] (03Merged) 10jenkins-bot: Hygiene: More icon abstraction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167881 (owner: 10Jdlrobson) [18:44:22] (03PS1) 10Jdlrobson: Create nearby refresh icon with Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168129 [18:44:25] ^ phuedx [18:46:35] (03PS17) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) [18:47:36] (03CR) 10jenkins-bot: [V: 04-1] Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [18:53:33] (03PS4) 10Dbrant: Recent searches [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168002 (owner: 10BearND) [18:58:20] jdlrobson: that change drops the use of 'main-header-button', is that right? [18:59:16] which afaict is use to toggle visibility of buttons when the main menu is open [19:04:18] (03PS18) 10Jdlrobson: Create new SVG icons library [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 [19:04:20] (03PS1) 10Jdlrobson: Hygiene: Remove unused files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168136 [19:04:21] phuedx: mm let me take a look [19:04:22] (03PS1) 10Jdlrobson: Hygiene: Use icon in cleanup overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168137 [19:04:24] (03PS1) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) [19:04:25] i'm split them up a bit more [19:05:02] (03CR) 10jenkins-bot: [V: 04-1] Create new SVG icons library [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (owner: 10Jdlrobson) [19:05:10] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use icon in cleanup overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168137 (owner: 10Jdlrobson) [19:05:25] (03CR) 10jenkins-bot: [V: 04-1] Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [19:06:13] (03PS2) 10Jdlrobson: Create nearby refresh icon with Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168129 [19:06:26] 3Wikipedia App / 3Android App: Android app isn't consistent with 'Could not reach the network' message - 10https://bugzilla.wikimedia.org/72371 (10Tomasz Finc) 3NEW p:3Unprio s:3normal a:3None I've seen a couple of them in the app when in airplane mode * Toast notification when tapping random * Arti... [19:06:30] (03PS2) 10Jdlrobson: Hygiene: Remove unused files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168136 [19:06:38] (03PS19) 10Jdlrobson: Create new SVG icons library [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 [19:07:14] (03CR) 10jenkins-bot: [V: 04-1] Create new SVG icons library [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (owner: 10Jdlrobson) [19:09:44] (03CR) 10Phuedx: [C: 032] Create nearby refresh icon with Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168129 (owner: 10Jdlrobson) [19:09:52] pew pew pew [19:09:55] right [19:10:03] i'm going to have a break before the meetin' [19:10:18] (03Merged) 10jenkins-bot: Create nearby refresh icon with Icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168129 (owner: 10Jdlrobson) [19:14:44] (03PS13) 10Bmansurov: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [19:18:51] bearND: Search is ready for review, if you are! [19:19:31] dbrant: already looking [19:20:23] (03PS14) 10Robmoen: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [19:20:42] ^ rebased [19:20:53] (03CR) 10BearND: [C: 032] "a big load of awesomeness :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 (owner: 10Dbrant) [19:21:09] \o/ [19:21:14] (03Merged) 10jenkins-bot: Ability to switch between prefix- and full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 (owner: 10Dbrant) [19:21:16] w00t! [19:21:50] bearND: checking out yours... [19:22:20] thx [19:24:02] (03CR) 10Bmansurov: "jdlrobson, I don't see the error you see when I click yes. I see an ajax request with the following response from the server: jQuery111106" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [19:31:13] (03CR) 10Florianschmidtwelzow: [C: 04-1] Update WikiGrok logging according to the new schema changes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [19:32:18] (03CR) 10Bmansurov: Update WikiGrok logging according to the new schema changes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [19:32:34] (03CR) 10Florianschmidtwelzow: [C: 031] Documentation: Document all the classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168001 (owner: 10Jdlrobson) [19:33:09] (03CR) 10Florianschmidtwelzow: Update WikiGrok logging according to the new schema changes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [19:35:43] MaxSem: If you have a free minute, can you take a look at this change: https://gerrit.wikimedia.org/r/#/c/154873/ ? [19:35:58] sure [19:38:04] (03CR) 10Florianschmidtwelzow: "right :/ Maybe we should find a good name for the usage of this class? It's not for all lists, it's for lists in overlays, maybe overlay-l" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/166580 (owner: 10Florianschmidtwelzow) [19:38:29] MaxSem: thanks :) The problem is, like i wrote in the comments, that i can't figure out, why two tests fail :( [19:39:03] (03PS20) 10Jdlrobson: Create new SVG icons library [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 [19:39:16] (03PS2) 10Jdlrobson: Hygiene: Use icon in cleanup overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168137 [19:39:22] (03PS2) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) [19:41:22] dbrant: What's the nature of the error I'm seeing in Google Play? [19:41:36] (03PS1) 10BearND: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168144 [19:41:50] dbrant: "This configuration cannot be published for the following reason(s): " [19:41:55] bearND: ^ [19:43:31] Deskana: I started getting that once I uploaded the draft [19:43:32] Deskana: it's just a warning that version 84 is still "active", and if we activate 85, then that's the one that will be served to users, instead of 84. [19:47:43] (03CR) 10Bmansurov: [C: 032] Hygiene: Remove unused files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168136 (owner: 10Jdlrobson) [19:48:20] (03Merged) 10jenkins-bot: Hygiene: Remove unused files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168136 (owner: 10Jdlrobson) [19:49:27] dbrant: Okay, cool. [19:49:30] dbrant: I'll email Google now then! [19:50:16] (03CR) 10BearND: [C: 032] Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168144 (owner: 10BearND) [19:50:36] (03Merged) 10jenkins-bot: Manual import of translations from TWN [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168144 (owner: 10BearND) [19:51:40] Deskana: take a pass on https://www.rainforestqa.com/ [19:51:51] i met with their CTO yesterday and asked to be put on their alpha [19:52:41] (03PS8) 10MaxSem: WIP: get suggestions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 [19:53:53] (03CR) 10Dbrant: [C: 04-1] "just a couple things." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168002 (owner: 10BearND) [19:54:26] (03PS1) 10BearND: Fix W0 test [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168146 [19:54:55] dbrant, bearND: Emailing the Googles. [19:55:11] Deskana: :D [20:02:04] (03PS21) 10Jdlrobson: Create new SVG icons library [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 [20:02:05] (03PS3) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) [20:02:07] (03PS3) 10Jdlrobson: Hygiene: Use icon in cleanup overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168137 [20:05:19] http://hatjitsu.wmflabs.org/86383 [20:17:19] (03CR) 10BearND: Recent searches (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168002 (owner: 10BearND) [20:17:35] (03PS5) 10BearND: Recent searches [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168002 [20:17:35] ryasmeen: done! [20:17:56] dbrant: ^ updated according to your feedback [20:38:19] (03CR) 10Dbrant: [C: 032] "yay!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168002 (owner: 10BearND) [20:39:12] bearND: i'm sure there will be a few styling tweaks from designers, but it's working great! [20:41:19] hello everyone, I have a question please: I am creating my own wikimedia site and want to know if there is an app to acces it on android like the wikipedia official app [20:42:10] i think it's "can i easily change the WP app to work with my own mediawiki" [20:42:28] it was relatively easy in the commons app.. once tried [20:42:50] thanks, reading the site now [20:43:03] it helps to know how to ask the question :P [20:44:02] but there it was just the upload server address more or less [20:44:24] i dunno how much you would have to change in the WP app [20:44:56] yeah, me neither that is why i am trying to find a shortcut.. [20:45:00] Pamphagus: it's not too difficult, and we actually have changes in the queue that will make it even simpler. For now (assuming you're familiar with Java code), look to the Site.java class. [20:45:07] a generic "mediawiki" app would be a cool thing [20:45:20] which gives people config options vs. editing code and compiling [20:45:28] dbrant: :) [20:45:41] that sounds reat [20:45:44] great [20:46:03] dbrant: thanks, I am trying to find where the app is now [20:46:51] Pamphagus: if you're referring to the code repo, it's here: https://gerrit.wikimedia.org/r/#/admin/projects/apps/android/wikipedia [20:47:18] Deskana: https://wikimediafoundation.org/wiki/User:DBrant_(WMF)/Nearby_blog_post#What_do_you_think.3F [20:52:29] dbrant: mhurd: heads up that i'm pushing the nearby blog post to comms [20:52:32] link above [20:54:10] dbrant: where is the site.java class you mentioned? [20:54:48] it is not urgent for me to ge the app working, as long as i know it can be done. I dont want to put a lot of effort on my site when it can only be accessed via a desktop [20:55:12] tfinc: dbrant: there's a typo in the email address of the blog post. I'm requesting an account on that site so I cannot correct it right now. [20:57:23] bearND: good catch, fixed now [20:57:29] tfinc: excellent; but Maryana had also mentioned that she might spruce up the prose a little bit... [20:57:45] we've waited long enough on this, i think its fine and we need to get this out [20:57:47] tfinc: thanks [20:59:23] Pamphagus, see wikipedia/src/main/java/org/wikipedia/Site.java in the git repository [20:59:49] thanks [21:00:05] you may also want to see https://gerrit.wikimedia.org/r/#/c/164876/ [21:00:26] Pamphagus: and refer to the README.mediawiki file for a quick guide on getting started with development. [21:02:04] Unfortunately last time I checked, that file was mac-specific. [21:02:29] Does your whole team run os x or something? [21:02:45] I had to do a couple of things differently to get it working on ubuntu, iirc [21:03:24] Krenair: yep, for the most part. The file should address Ubuntu equally. If you've seen any discrepancies, do let us know [21:04:11] tfinc: dbrant https://meta.wikimedia.org/wiki/Wikimedia_Blog/Drafts/Apps_Nearby [21:04:17] i started turning this into narrative form [21:04:34] dbrant, 1st instruction: install brew [21:04:37] dbrant: Did you file that bug against the API? [21:04:45] so please point comms there :) [21:04:46] Maryana: that already happened with the existing post https://meta.wikimedia.org/wiki/Wikimedia_Blog/Drafts/Apps_Nearby [21:05:12] Krenair: alright, it is indeed pretty mac-heavy :( [21:05:14] ? [21:05:19] tfinc: not sure what you mean [21:05:41] Deskana: sorry! getting around to it... [21:05:42] err [21:05:49] https://wikimediafoundation.org/wiki/User:DBrant_(WMF)/Nearby_blog_post#What_do_you_think.3F [21:05:54] thank you all, I will copy the links you gave me and look into them later. Most likely by the time i do the reading do the changes and produce my wiki, you will have implemented it in a new version :P [21:05:54] dbrant: No worries. Please CC me when you file it. :)_ [21:05:59] Maryana: https://wikimediafoundation.org/wiki/User:DBrant_(WMF)/Nearby_blog_post [21:06:53] oh, ok [21:07:07] that's the problem w/multiple wikis [21:08:02] Maryana: indeed, it makes things confusing [21:08:20] i just sent the post to Tilman for review [21:09:36] tfinc: Maryana: sorry, next time I'll know to start a draft under meta/Wikimedia_Blog/Drafts [21:10:30] Deskana: which API bug are you talking about? [21:10:36] goodnight / morning all, thanks [21:11:13] am gonna head orf [21:11:19] dbrant: no worries :) [21:11:20] it's 10 pm and i'm beat [21:11:21] phuedx: one sec... [21:11:23] your draft looks good to me [21:11:37] * phuedx waits [21:11:39] phuedx: no orfing [21:12:03] MaxSem: what's the proper Bugzilla product for filing a bug/feature regarding the API? [21:12:31] phuedx: So I refined to the Acceptance Criteria in WikiGrok Roulette to clarify that we will only be doing the same EL stuff we're doing for the other versions (i.e. no schema changes or new EL code). How does that look? [21:12:48] * phuedx looks [21:12:56] bearND: when the "createaccount" action fails for whatever reason, it doesn't give a specific enough reason for the failure. [21:13:13] dbrant, depending on what the product's api you're talikng about [21:13:14] phuedx: Maryana says we don't need to do any complicated session tracking for the MVP [21:13:48] kaldari|2, Maryana: okie poke (i agree) [21:13:52] yeah, just having taps on next grouped by persistent anon token is fine [21:14:05] cool [21:14:28] phuedx: Jon doesn't want it split out, so hopefully this will work as a compromise [21:14:42] so, wait, actually – should we just use a persistent anon token instead of a userid hash for logged in folks? [21:14:52] Maryana: yes [21:14:59] well, that's easy [21:15:01] let's do that [21:15:05] MaxSem: regarding the "createaccount" action, when it fails, we would like it to return the name of the extension that caused it to fail. (since the error "code" is not specific enough, and we don't want to use the html "info" text...) [21:15:09] if you want to disconnect the two sets of events [21:15:41] kaldari|2, Maryana: that card looks ok [21:15:46] also, jdlrobson [21:15:54] MaxSem: dbrant: I might need to file one against the API, too. I need "prop=pageprops" in "list=search" to return the wikidata ID (aka. wikibase_item). Currently it does so only in "list=prefixsearch" [21:15:55] phuedx: does 8 sound OK for estimation? [21:16:04] dbrant, MediaWiki > API but pretty sure I submitted a more generic version of it like 7 years ago:) [21:16:17] Deskana: ^ [21:16:20] i'd say 5-8 [21:16:27] kaldari|2: can i take "each anonymous user should have a unique hash" out of https://trello.com/c/HlIE01me/60-show-wikigrok-to-readers-in-alpha-beta and turn it into its own card for both logged in & non-logged in? [21:16:27] danger 5, easy 8 [21:16:39] that was for bearND [21:16:43] phuedx: awesome. your're free to retire now :) [21:16:50] thanks, phuedx [21:17:23] jdlrobson: i get that eventlogging didn't seem like an obvious choice to break out [21:17:32] maybe it wasn't the right choice [21:17:50] but it was worth taking a look at to try and make the piece of work smaller [21:18:06] phuedx: I know don't worry :) [21:18:06] MaxSem: how do i get the wikidata id in "list=search"? [21:18:07] a large set of small, well-defined cards will be ideal for a large group of engineers [21:18:16] phuedx: +1 [21:18:26] to paraphrase you :) [21:18:34] We need to get in the habit of microtasking [21:18:57] absolument [21:19:08] bearND, prop=pageprops&ppprop=wikibase_item [21:19:40] once we start producing stories that are all 1, 2, and 3 feels large, then we're on the right track [21:20:08] jdlrobson: how's that mw-ui-icon patch looking? [21:20:12] * phuedx wants to get it merged! [21:20:39] phuedx: should be good to go now [21:20:44] ok [21:20:48] (i made them as tiny as i possibly could) [21:20:50] i'll take a look in the morning [21:21:10] phuedx: I added a FIXME.txt to the icon library to remind myself to port us to a nice shared global icon repository [21:21:53] \o/ [21:21:54] DarTar: have a sec to chat? [21:22:14] Deskana: https://bugzilla.wikimedia.org/show_bug.cgi?id=72387 [21:22:18] brion: i think it’s time for me to submit the networking refactor... [21:22:36] DarTar some of the devs had some concerns about using a user hash & we're trying to figure out another potential solution [21:22:42] in the spirit of capslock day: wrap yer ears around this: http://asiwyfa.bandcamp.com/track/beautifuluniversemasterchampion [21:22:43] MaxSem: Thanks. Can you provide a full example? I still don't get the Wikidata ID with https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&list=search&prop=pageprops&format=json&srsearch=in&srnamespace=0&srprop=redirecttitle&srlimit=10&ppprop=wikibase_item [21:22:46] g'night folks [21:22:53] nite! [21:23:01] mhurd: \o/ [21:23:12] i’ll look it over later this afternoon :D [21:23:16] brion: the only know issue is hooking up the MCCMNC header, but i’ll chat with adam tomorrow about it... [21:23:21] ok [21:23:31] just put ‘work in progress’ in the summary so w edon’t merge it by mistake ;) [21:24:13] brion: or merge and patch the MCCMNC the next day? your call [21:24:54] either way [21:25:00] brion: thinking about cutting a beta today (pre-merge) to give us a little head start on testing it… sound ok? [21:25:16] i just hate regressions ;) [21:25:20] dbrant: Thanks! Eager to see what happens with this now since this is our first ask of the API. [21:25:24] but yeah a beta should be fine, it’ll mostly be non-zero folks :D [21:25:30] brion: haha me too :0 [21:26:48] (03PS1) 10Mhurd: Transition to AFNetworking from MWNetworkOp. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 [21:27:25] brion: ^ apologies in advance :) [21:27:57] hehe [21:30:24] mhurd: its exciting to see that land [21:30:45] joakino: do you have an android device to test on for you work or will you need one ? [21:31:23] tfinc: i've got a nexus 5, i'm good [21:31:36] joakino: k [21:34:55] 3Wikipedia App / 3General/Unknown: teste 22102014 - 10https://bugzilla.wikimedia.org/72388 (10Adriana) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16855 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16855&action=edit test 22102014 teste [21:36:46] Maryana: http://www.memrise.com/home/ [21:38:36] sweeeet [21:38:38] thanks tfinc [21:39:12] joakino: $wgMFNearbyEndpoint = 'https://en.m.wikipedia.org/w/api.php'; [21:39:52] 3Wikipedia App / 3General/Unknown: teste 22102014 - 10https://bugzilla.wikimedia.org/72388 (10Dmitry Brant) 5UNCO>3RESO/INV [21:39:54] $wgMFEnableWikiGrok = true; [21:39:54] $wgMFEnableWikiGrokOnAllDevices = true; [21:40:44] http://localhost:8080/wiki/Anne Dallas Dudley?mobileaction=alpha&wikidataid=Q3784220 < joakino [21:40:47] Maryana: i use it almost every day and it takes the majority of my on pub trans cycles free time [21:40:57] ooooh it has verb conjugation! [21:41:03] i have wanted this so badly [21:41:14] that's one thing duolingo is not so good on [21:41:50] Maryana: and at least for languages like japanese its smart and understand different character sets and when to use them or not use them [21:42:08] tfinc: very cathartic to have it done :) [21:42:41] i like Duolingo and i talked with their team at I/O .. they love us [21:42:45] let me know if you want an intro Maryana [21:42:58] yess [21:43:26] Maryana: shoot me a mail and i'll spin something up [21:44:47] mw.config.get( 'wgMFEnableWikiGrokOnAllDevices' ) [21:48:35] ryasmeen: did you get all set up on testflight? [21:52:06] (03CR) 10Jdlrobson: [C: 032] Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [21:52:21] Hey mhurd, yeah I just registered on testflight [21:52:43] (03Merged) 10jenkins-bot: Limit the number of tag suggestions displayed in the WikiGrok panel to 6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167697 (owner: 10Bmansurov) [21:56:25] 3Wikipedia App / 3Android App: 22102014 - 10https://bugzilla.wikimedia.org/72391 (10Adriana) 3UNCO p:3Unprio s:3normal a:3None Erro de dados [22:05:25] TrevorParscal: I updated the patchset with your feedback [22:05:33] and the wiki page is now up to date [22:05:36] for https://www.mediawiki.org/wiki/Requests_for_comment/HTML_templating_library [22:13:41] 3Wikipedia App / 3Android App: 22102014 2 - 10https://bugzilla.wikimedia.org/72394 (10Adriana) 3UNCO p:3Unprio s:3normal a:3None Erro de salvamento [22:13:51] (03CR) 10Jhernandez: [C: 031] Hygiene: Refactor pageImage.js to be a method on PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167971 (owner: 10Jdlrobson) [22:13:52] 3Wikipedia App / 3Android App: 22102014 - 10https://bugzilla.wikimedia.org/72391 (10Adriana) 5UNCO>3RESO/FIX [22:15:10] 3MobileFrontend / 3General/Unknown: Cannot open VE for a specific page and the error "TypeError: lastSection is undefined" appears in the console - 10https://bugzilla.wikimedia.org/72395 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16856 --> https://bugzilla.wikimedia.org... [22:15:23] 3MobileFrontend / 3General/Unknown: Cannot open VE for a specific page and the error "TypeError: lastSection is undefined" appears in the console - 10https://bugzilla.wikimedia.org/72395#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/3ycdjooK [22:16:24] 3MobileFrontend / 3General/Unknown: Cannot open VE for a specific page and the error "TypeError: lastSection is undefined" appears in the console - 10https://bugzilla.wikimedia.org/72395 (10Rummana Yasmeen) 5NEW>3ASSI a:3Jon [22:20:28] (03PS2) 10Robmoen: WIP: New WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [22:21:56] kaldari|2: bmansurov is https://gerrit.wikimedia.org/r/#/c/167349/14 ready ? I'm about to base my change ^ off it unless we can get this merged [22:22:42] rmoen: I think so, but it needs a final review [22:23:07] rmoen: i got a note that your travel is set, message the team to let them know when your in town [22:23:26] tfinc: ok [22:24:22] tfinc: had planned on it. It was all finalized about an hour ago [22:25:08] MaxSem: any idea how to do an API request to do a full-text search together with wikidata IDs? [22:25:10] 3Wikipedia App / 3Android App: 22102014 3 - 10https://bugzilla.wikimedia.org/72400 (10Adriana) 3UNCO p:3Unprio s:3normal a:3None salvamento [22:45:34] jdlrobson: can you send me that link to the data of most clicked items in mobile nav you were showing me yesterday? [22:51:33] (03PS1) 10Jhernandez: Load nearby by url coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [22:51:38] (03CR) 10jenkins-bot: [V: 04-1] Load nearby by url coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (owner: 10Jhernandez) [22:53:22] 3MobileFrontend / 3General/Unknown: Cannot open VE for a specific page and the error "TypeError: lastSection is undefined" appears in the console - 10https://bugzilla.wikimedia.org/72395#c2 (10Jon) Seems to be a bug in the section.js code Offending line is assignToParent( lastSection.children, section ); Wou... [22:53:44] kaity: mobile-reportcard.wmflabs.org [22:56:23] (03CR) 10Bmansurov: [C: 032] Hygiene: Cleanup the toggling test code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 (owner: 10Jdlrobson) [22:56:28] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup the toggling test code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 (owner: 10Jdlrobson) [22:57:39] jdlrobson: in general who needs to rebase: reviewer or patch owner? [22:58:02] bmansurov: technically patch owner, but i sometimes rebase to move things along quicker especially when they are simple [22:58:09] bmansurov: i can take a look in a minute [22:58:15] ok [23:00:30] (03PS2) 10Jhernandez: Load nearby by url coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [23:02:08] 3Wikipedia App / 3Android App: 22102014 3 - 10https://bugzilla.wikimedia.org/72400 (10Dmitry Brant) 5UNCO>3RESO/INV [23:06:23] 3Wikipedia App / 3Android App: 22102014 2 - 10https://bugzilla.wikimedia.org/72394#c1 (10Dmitry Brant) Can you be more specific about the error that you see? [23:12:10] http://etherpad.wikimedia.org/p/design_review_10_22 [23:16:32] http://etherpad.wikimedia.org/p/design_review_10_22 [23:27:06] mhurd, I cant download the latest testflight build in my device [23:27:24] (03PS3) 10Jhernandez: Load nearby by url coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [23:31:15] ryasmeen: We're in a meeting right now. We'll get back to you ASAP. :) [23:31:36] oops ! sure Deskana :) [23:32:21] ryasmeen: No worries. :) [23:34:56] (03PS3) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [23:34:58] (03PS15) 10Robmoen: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [23:35:40] Uhm. not sure what happened there. ^ bmansurov [23:35:44] DarTar: got out of my meeting early – want to talk now? [23:36:00] rmoen: did you want to +2? [23:36:16] bmansurov: i just rebased my patch on yours and rebased it onto master so maybe it was a rebase [23:36:24] ok [23:37:48] (03CR) 10Robmoen: "This fails getting. Status Code:500 hphp_invoke. Not entirely sure why at the moment." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [23:38:28] jdlrobson: howdy [23:38:33] https://gerrit.wikimedia.org/r/167114 < kaldari|2 can i get your eyes on this [23:38:51] https://gerrit.wikimedia.org/r/168018 < jdlrobson can I get your eyes on this ? [23:38:52] 3Wikipedia App / 3Android App: 22102014 - 10https://bugzilla.wikimedia.org/72391 (10Alex Monk) 5RESO/FIX>3RESO/INV [23:38:58] :) [23:49:33] (03CR) 10Brion VIBBER: "some inline comments on the fetcher classes, mostly looking good so far! a few minor style quibbles mostly at this point. ;) will look ove" (0314 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 (owner: 10Mhurd) [23:50:05] brion: yay! i found a bug in ios6 w search results thumbnails. fixing now [23:50:12] fun times :D [23:50:17] brion: :) [23:50:41] overall i’m way happier with how the fetcher classes look than the old operations classes [23:50:45] much clearer as to what’s going on [23:51:07] now my eyes are glazing over, i can’t read any more code today ;)) [23:53:56] kaldari|2: do you happen to know if a) there's a glam mailing list, b) if it's active, and c) if the wiki loves foo folks use it? [23:54:55] Maryana: yes, yes. yes [23:55:01] great! [23:55:03] what is the list? [23:55:07] that was the invisible d [23:58:14] (03CR) 10Mhurd: "Great catches! Will amend! :)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 (owner: 10Mhurd) [23:58:23] brion: ^ [23:58:26] (03CR) 10Bmansurov: [C: 032] Documentation: Document all the classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168001 (owner: 10Jdlrobson) [23:58:42] brion: thank you sooooo much for going over all of that! [23:59:06] (03Merged) 10jenkins-bot: Documentation: Document all the classes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168001 (owner: 10Jdlrobson)