[00:07:20] (03PS4) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [00:07:25] (03CR) 10jenkins-bot: [V: 04-1] Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [00:10:16] (03PS5) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [00:10:18] (03PS16) 10Robmoen: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [00:24:05] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/167732 (owner: 10Dbrant) [00:40:44] (03PS1) 10Jhernandez: Add loading by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168226 [00:41:20] (03CR) 10jenkins-bot: [V: 04-1] Add loading by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168226 (owner: 10Jhernandez) [01:07:19] (03PS2) 10Jhernandez: Add loading by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168226 [01:11:37] (03PS2) 10Mhurd: Transition to AFNetworking from MWNetworkOp. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 [01:13:23] (03CR) 10Mhurd: "Amended initial commit to fix iOS 6 and 7 search and nearby thumbnail bug." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 (owner: 10Mhurd) [01:15:13] (03PS3) 10Mhurd: Transition to AFNetworking from MWNetworkOp. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 [01:21:15] 3Wikipedia App / 3iOS App: The page gets deleted from Recent sections too, if deleted for the "Saved Pages" section - 10https://bugzilla.wikimedia.org/72412 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Launch the iOS Wikipedia app 2.Browse through some random articles 3... [01:23:09] 3Wikipedia App / 3iOS App: The page gets deleted from Recent sections too, if deleted for the "Saved Pages" section - 10https://bugzilla.wikimedia.org/72412 (10Rummana Yasmeen) 5NEW>3ASSI a:3Monte Hurd [01:25:48] (03PS1) 10Jdlrobson: Use ResourceLoaderFileModule for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 [01:25:50] (03PS1) 10Jdlrobson: Use mw.template exclusively for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168232 [01:26:32] (03CR) 10jenkins-bot: [V: 04-1] Use mw.template exclusively for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168232 (owner: 10Jdlrobson) [01:26:37] (03CR) 10jenkins-bot: [V: 04-1] Use ResourceLoaderFileModule for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 (owner: 10Jdlrobson) [01:27:33] (03PS2) 10Jdlrobson: WIP: Use mw.template exclusively for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168232 [01:27:41] (03CR) 10Jdlrobson: [C: 04-2] "Blocked on Ia63d6b6868f23a773e4a41daa0036d4bf2cd6724" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 (owner: 10Jdlrobson) [01:27:51] (03CR) 10Jdlrobson: [C: 04-2] "Blocked on Ia63d6b6868f23a773e4a41daa0036d4bf2cd6724" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168232 (owner: 10Jdlrobson) [01:28:08] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw.template exclusively for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168232 (owner: 10Jdlrobson) [01:33:26] (03CR) 10Jdlrobson: [C: 04-1] Load nearby by url coordinates (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (owner: 10Jhernandez) [03:06:15] (03PS10) 10Dbrant: [WIP] Lead images! [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165348 [03:09:19] (03PS10) 10Dbrant: [very WIP] Make infoboxes (and other tables) collapsible. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/165605 [05:37:33] (03CR) 10Florianschmidtwelzow: Implement WikiGrok response API (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [05:40:25] 3Wikipedia App / 3Android App: When trying to create an account, Android mobile app doesn't show error messages from AntiSpoof extension, blocking registration with no explanation - 10https://bugzilla.wikimedia.org/72331#c2 (10Dan Garry) Depends on bug 72387. [06:48:10] 3Wikipedia App / 3Android App: 22102014 2 - 10https://bugzilla.wikimedia.org/72394#c2 (10Andre Klapper) 5UNCO>3RESO/INV This is a production bug database used by the Wikimedia community to develop Wikipedia, MediaWiki, and other products. It is not a test system or something to play with. Use http://lan... [11:05:21] (03PS6) 10Phuedx: Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 [11:06:16] (03CR) 10Phuedx: "PS6 fixes a fatal error that Robmoen discovered while building the client for the API." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [11:11:43] (03CR) 10Phuedx: Implement WikiGrok response API (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [14:24:05] (03CR) 10Phuedx: [C: 04-1] "This is definitely easier to parse. However, the are regressions:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [14:28:23] (03CR) 10Phuedx: [C: 032] "I'm happy to merge this as it's simply foundation code." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (owner: 10Jdlrobson) [14:30:29] (03Merged) 10jenkins-bot: Create new SVG icons library [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/165096 (owner: 10Jdlrobson) [14:58:20] (03CR) 10Phuedx: [C: 032] Hygiene: Use icon in cleanup overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168137 (owner: 10Jdlrobson) [14:58:26] pew pew pew [14:58:56] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use icon in cleanup overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168137 (owner: 10Jdlrobson) [15:07:47] (03PS4) 10Phuedx: Hygiene: Use icon in cleanup overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168137 (owner: 10Jdlrobson) [15:08:01] (03CR) 10Phuedx: "PS4 is a rebase." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168137 (owner: 10Jdlrobson) [15:10:39] (03CR) 10Phuedx: [C: 032] Hygiene: Use icon in cleanup overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168137 (owner: 10Jdlrobson) [15:11:15] (03Merged) 10jenkins-bot: Hygiene: Use icon in cleanup overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168137 (owner: 10Jdlrobson) [15:15:51] hey Krenair [15:15:54] mibad [15:15:57] hey kristenlans [15:16:02] kr [15:16:46] Hyello! [15:19:24] (03PS1) 10Dbrant: Update hamburger icon for RTL. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168300 [15:30:48] phuedx: we’re very close to finding some saner meeting times for the whole team, FYI [15:31:17] ah cool [15:31:25] :) [15:31:42] 9-10 pm was a little rough last night [15:31:49] i was a little grouchy [15:32:31] Yeah that doesn’t sound like fun! [16:11:02] dbrant: Deskana|Away: any idea how to get wikidata IDs from a full text search request? I don't think there is a direct way. [16:12:01] bearND: yeah, from what I've seen so far, it doesn't look like there's a way yet. [16:12:57] bearND: what's the full text search API request you're making? [16:13:02] can it be used as a generator? [16:13:30] https://en.wikipedia.org/w/api.php?action=query&generator=search&gsrsearch=meaning&prop=pageprops&format=jsonfm [16:13:40] is that what you want? [16:16:36] legoktm: thank you. that looks promising [16:17:03] legoktm: bearND: it does indeed! [16:17:16] :) [16:17:20] generators are extremely powerful [16:17:21] https://www.mediawiki.org/wiki/API:Query#Generators [16:21:31] legoktm: bearND: of course, the ultimate would be if the response actually contained the wikidata description (or other data), not just the ID [16:21:47] legoktm: wow. that is what I needed. The order of the results is different but from what I've seen seem better. [16:22:18] and what dbrant just said. yeah, that would be the ultimate goal, to get the wikidata description [16:22:20] dbrant: someone would need to implement https://www.mediawiki.org/wiki/Requests_for_comment/Wikidata_API to make that possible [16:22:39] specifically the prop=wikibase module at the bottom [16:23:39] doing it cross-wiki would be...interesting [16:26:02] (03CR) 10Dbrant: [C: 032] Fix W0 test [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168146 (owner: 10BearND) [16:29:45] (03PS1) 10Dbrant: Fix possible crash when fetching Edit token. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168313 [16:32:25] (03PS2) 10Dbrant: Fix possible crash when fetching Edit token. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168313 (https://bugzilla.wikimedia.org/71331) [16:33:20] (03CR) 10BearND: "Where did you get the from or how did you make them?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168300 (owner: 10Dbrant) [16:34:59] moizsyed: I forgot to invite you to the researcg group :( [16:35:04] we’re about to discuss wikigrok [16:35:08] wanna join? [16:35:16] it’s in Diderot (or hangout) [16:35:53] i'll join the hangout [16:36:17] send me the calender event [16:36:48] DarTar: send me the hangout link [16:36:53] done [16:43:54] (03CR) 10Dbrant: "The original LTR icons come from here: http://developer.android.com/design/downloads/index.html" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168300 (owner: 10Dbrant) [16:47:53] 3Wikipedia App / 3Android App: JSONException: Value 3PATC https://gerrit.wikimedia.org/r/168313 [16:51:52] 3Wikipedia App / 3Android App: JSONException: Value (03CR) 10BearND: [C: 032] Fix possible crash when fetching Edit token. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168313 (https://bugzilla.wikimedia.org/71331) (owner: 10Dbrant) [16:59:40] (03Merged) 10jenkins-bot: Fix possible crash when fetching Edit token. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168313 (https://bugzilla.wikimedia.org/71331) (owner: 10Dbrant) [17:02:44] (03PS2) 10BearND: Update hamburger icon for RTL. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168300 (owner: 10Dbrant) [17:03:02] (03CR) 10BearND: [C: 032] Update hamburger icon for RTL. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168300 (owner: 10Dbrant) [17:03:23] (03Merged) 10jenkins-bot: Update hamburger icon for RTL. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168300 (owner: 10Dbrant) [17:07:02] (03CR) 10Jdlrobson: [C: 04-1] "Minor code style issue. Haven't checked if it works yet but code looks fine." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [17:16:09] dr0ptp4kt: time to chat later this morning? [17:16:36] mhurd: yep, anytime but 1100-1115 is good [17:16:41] (03PS17) 10Bmansurov: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 [17:17:48] (03PS6) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [17:24:34] (03CR) 10Kaldari: [C: 04-1] Add the WikiGrokResponse API (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [17:25:26] phuedx: One minor comment on the WikiGrok API. Lemme know what you think and then hopefully we can get it merged. [17:26:49] (03PS7) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [17:31:12] (03PS4) 10Jhernandez: Load nearby by url coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [17:34:55] (03PS1) 10Robmoen: Mobile mode getter and implement in schemas and WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168336 [17:40:42] hallo [17:44:16] (03PS1) 10Jdlrobson: Introduce jscs tool to the repository for code style checking. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168339 [17:45:09] can anybody please remind me why is editing enabled on mobile web only for registered users? [17:45:25] it's enabled in the app afaik [17:47:14] (03CR) 10Bmansurov: Add role 'button' to section heading text (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [17:48:23] Deskana|Away, kaldari: for you ^ aharoni|mobile my recollection is the barriers to entry for the vandal are higher on the app than the mobile web. but i think there's interest in exposing public-ip-logged editing for mobile web if vandalism doesn't turn out to be a problem. i think it's in alpha maybe even at this point. [17:48:50] aharoni|mobile: sorry for delay, i don't usually read the scrollback too much unless my handle is mentioned, but i happened to catch it this time [17:54:29] (03PS2) 10Jdlrobson: Introduce jscs tool to the repository for code style checking. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168339 [17:54:31] (03PS1) 10Jdlrobson: Hygiene: function( -> function ( [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168342 [17:54:45] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: function( -> function ( [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168342 (owner: 10Jdlrobson) [17:57:25] (03CR) 10Jhernandez: [C: 032] Introduce jscs tool to the repository for code style checking. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168339 (owner: 10Jdlrobson) [18:00:30] (03PS1) 10Jdlrobson: Hygiene: jscs fix indents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168344 [18:00:36] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: jscs fix indents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168344 (owner: 10Jdlrobson) [18:04:39] (03PS1) 10Dbrant: Make sure fragments that use a Loader have unique IDs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168349 [18:05:02] bearND: ^^ critical [18:05:17] (03PS4) 10Mhurd: Transition to AFNetworking from MWNetworkOp. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 [18:06:50] dbrant: good. Let's use some higher numbers, though. 0 is too easily used [18:07:29] bearND: 100+ ? [18:08:26] (03Merged) 10jenkins-bot: Introduce jscs tool to the repository for code style checking. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168339 (owner: 10Jdlrobson) [18:10:58] (03PS2) 10Jdlrobson: Hygiene: jscs fix indents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168344 [18:11:00] (03PS1) 10Jdlrobson: Hygiene: Remove unnecessary spaces after key names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168351 [18:11:07] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: jscs fix indents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168344 (owner: 10Jdlrobson) [18:11:13] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove unnecessary spaces after key names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168351 (owner: 10Jdlrobson) [18:11:15] (03PS2) 10Dbrant: Make sure fragments that use a Loader have unique IDs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168349 [18:12:11] bearND: ^ [18:13:31] dbrant: good [18:15:26] (03CR) 10BearND: [C: 032] Make sure fragments that use a Loader have unique IDs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168349 (owner: 10Dbrant) [18:15:32] (03PS2) 10Jdlrobson: Hygiene: function( -> function ( [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168342 [18:15:34] (03PS2) 10Jdlrobson: Hygiene: Remove unnecessary spaces after key names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168351 [18:16:18] (03Merged) 10jenkins-bot: Make sure fragments that use a Loader have unique IDs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168349 (owner: 10Dbrant) [18:18:00] hey kaldari [18:18:04] i'll take a look now [18:18:07] stupid internet [18:18:45] kaldari: i'm fine with that suggestion [18:18:54] i wasn't sure if there was a naming pattern [18:21:46] (03CR) 10Jhernandez: [C: 032] Hygiene: Refactor pageImage.js to be a method on PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167971 (owner: 10Jdlrobson) [18:22:52] (03PS3) 10Jdlrobson: Hygiene: jscs fix indents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168344 [18:22:54] (03PS1) 10Jdlrobson: Hygiene: Avoid camel case complaints [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168356 [18:22:59] phuedx: We haven't really used namespacing before, so we tend to rely heavily on class prefixing. Personally, I like prefixing better, but I'm fine with either. [18:24:23] (03CR) 10Jhernandez: [C: 032] Hygiene: Remove unnecessary spaces after key names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168351 (owner: 10Jdlrobson) [18:24:46] (03PS7) 10Phuedx: Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 [18:25:00] phuedx, MaxSem: I was thinking about starting a thread on Wikitech-l about conventions for PHP namespacing. Do you think that would be a good idea? [18:25:19] there already was one a while back I thought? [18:25:24] (03Merged) 10jenkins-bot: Hygiene: Remove unnecessary spaces after key names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168351 (owner: 10Jdlrobson) [18:25:33] http://www.gossamer-threads.com/lists/wiki/wikitech/476296 [18:25:48] legoktm: oh yeah, was there any consensus? There's nothing mentioned at https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP [18:26:22] kaldari, my main worry wrt WikiGrok is that creating a NS for one file is overengineering [18:26:47] (03CR) 10Phuedx: Add the WikiGrokResponse API (032 comments) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [18:26:50] kaldari: there was an implicit consensus that no one had any issues with \MediaWiki\Extensions\OAuth [18:27:06] when we have a lot of files, subnamespaces make sense [18:27:29] legoktm, ewwww [18:27:36] looks super fucking ugly [18:27:46] legoktm: ack, that seems like an awful idea :P [18:28:03] read the whole thread :P [18:29:07] MaxSem: overengineering? you ain't seen nothing yet! [18:30:10] indeed, we don't even have IAbstractEnterpriseXmlPatternFactorySingleton :P [18:30:44] (03CR) 10Jhernandez: [C: 032] Hygiene: function( -> function ( [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168342 (owner: 10Jdlrobson) [18:32:02] So 'PSR-4 compliant' means that it has to reflect the directory structure correct? [18:32:18] (03CR) 10Jhernandez: [C: 032] Hygiene: jscs fix indents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168344 (owner: 10Jdlrobson) [18:32:24] HE SAID PSR, GET HIM!!1 [18:32:49] I didn't say it was a good idea :) [18:32:56] I just want to understand what it is [18:34:45] (03Merged) 10jenkins-bot: Hygiene: function( -> function ( [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168342 (owner: 10Jdlrobson) [18:34:47] (03Merged) 10jenkins-bot: Hygiene: jscs fix indents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168344 (owner: 10Jdlrobson) [18:35:37] kaldari: yes and class names must follow \[]\ [18:35:47] (03PS1) 10Jdlrobson: Hygiene: Missing newline after opening curly brace [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168361 [18:35:49] (03PS1) 10Jdlrobson: Hygiene: Operator stickiness coding style [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168362 [18:35:51] (03PS1) 10Jdlrobson: Hygiene: Remove Illegal space after key [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168363 [18:35:53] (03PS1) 10Jdlrobson: Hygiene: Remove trailing commas [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168364 [18:36:05] c-c-c-c-combo breaker! [18:37:12] phuedx: I'm confused. Which is it? \[]\ or \\ or some combination of the two? [18:37:30] http://hatjitsu.wmflabs.org/52785 [18:37:52] (03CR) 10Jhernandez: [C: 032] Hygiene: Avoid camel case complaints [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168356 (owner: 10Jdlrobson) [18:37:56] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168364 (owner: 10Jdlrobson) [18:38:29] (03Merged) 10jenkins-bot: Hygiene: Avoid camel case complaints [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168356 (owner: 10Jdlrobson) [18:38:31] \MediaWiki\Extensions\MobileFrontend\Includes\StuffDoer [18:38:33] kaldari: a combination of the two [18:39:18] ack, it's like PHP is becoming Java [18:39:54] because the \MediaWiki\Foo\Bar\Baz namespace could be mapped to /path/to/mediawiki/foo-bar-baz-src/Bar/Baz [18:39:55] \o/ [18:40:56] gonna go for a boulder [18:41:04] bbl [18:41:32] (03PS1) 10Jdlrobson: Hygiene: Use single quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168365 [18:41:34] (03PS1) 10Jdlrobson: Hygiene: Remove unnecessary quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168366 [18:41:52] (03CR) 10Jhernandez: [C: 032] Hygiene: Missing newline after opening curly brace [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168361 (owner: 10Jdlrobson) [18:42:29] (03Merged) 10jenkins-bot: Hygiene: Missing newline after opening curly brace [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168361 (owner: 10Jdlrobson) [18:42:53] (03CR) 10MaxSem: [C: 032] Hygiene: Operator stickiness coding style [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168362 (owner: 10Jdlrobson) [18:43:02] (03CR) 10Jhernandez: [C: 032] Hygiene: Operator stickiness coding style [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168362 (owner: 10Jdlrobson) [18:43:13] (03CR) 10Siebrand: "More i18n review" (0310 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168364 (owner: 10Jdlrobson) [18:43:15] (03CR) 10MaxSem: [C: 032] Hygiene: Remove Illegal space after key [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168363 (owner: 10Jdlrobson) [18:43:28] (03Merged) 10jenkins-bot: Hygiene: Operator stickiness coding style [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168362 (owner: 10Jdlrobson) [18:43:47] (03Merged) 10jenkins-bot: Hygiene: Remove Illegal space after key [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168363 (owner: 10Jdlrobson) [18:44:36] (03CR) 10MaxSem: [C: 032] Hygiene: Remove trailing commas [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168364 (owner: 10Jdlrobson) [18:44:56] (03CR) 10Jhernandez: [C: 032] Hygiene: Use single quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168365 (owner: 10Jdlrobson) [18:45:11] (03Merged) 10jenkins-bot: Hygiene: Remove trailing commas [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168364 (owner: 10Jdlrobson) [18:45:22] (03CR) 10MaxSem: [C: 032] Hygiene: Use single quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168365 (owner: 10Jdlrobson) [18:45:33] (03Merged) 10jenkins-bot: Hygiene: Use single quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168365 (owner: 10Jdlrobson) [18:46:13] (03CR) 10MaxSem: [C: 032] Hygiene: Remove unnecessary quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168366 (owner: 10Jdlrobson) [18:46:15] (03CR) 10Jhernandez: [C: 032] Hygiene: Remove unnecessary quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168366 (owner: 10Jdlrobson) [18:47:42] (03Merged) 10jenkins-bot: Hygiene: Remove unnecessary quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168366 (owner: 10Jdlrobson) [18:48:15] (03PS1) 10Jdlrobson: Hygiene: var declarations at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168373 [18:48:17] (03PS1) 10Jdlrobson: Hygiene: Line breaks and indents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168374 [18:48:19] (03PS1) 10Jdlrobson: HYGIENE: Don't run jscs on README.md file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168375 [18:48:58] (03CR) 10Kaldari: [C: 031] "Looks good to me." [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [18:48:58] mhurd: oh snap, i think we missed each other for the morning. but i'm here. my next meeting is 1430-1500, but i'm available otherwise. [18:49:33] MaxSem: https://gerrit.wikimedia.org/r/#/c/167829/ looks good to me now, do you have any further suggestions before it's merged? [18:49:40] (03PS1) 10Jdlrobson: Hygiene: Add spaces after keywords [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168378 [18:49:55] dr0ptp4kt: cool! will catch you later - in meeting [18:50:40] well, I still oppose using too many namespaces for such a short project, but not going to demand that you go over my dead body to merge this:) [18:51:38] (03CR) 10Jhernandez: [C: 032] Hygiene: var declarations at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168373 (owner: 10Jdlrobson) [18:52:16] (03Merged) 10jenkins-bot: Hygiene: var declarations at top [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168373 (owner: 10Jdlrobson) [18:52:22] MaxSem, phuedx: I'm not a fan either, personally, but since there aren't any coding conventions about it, I don't feel like it's objectionable. [18:53:11] (03CR) 10Jhernandez: [C: 032] Hygiene: Line breaks and indents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168374 (owner: 10Jdlrobson) [18:53:46] (03Merged) 10jenkins-bot: Hygiene: Line breaks and indents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168374 (owner: 10Jdlrobson) [18:53:56] (03CR) 10Jhernandez: [C: 032] HYGIENE: Don't run jscs on README.md file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168375 (owner: 10Jdlrobson) [18:54:31] (03Merged) 10jenkins-bot: HYGIENE: Don't run jscs on README.md file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168375 (owner: 10Jdlrobson) [18:54:50] (03CR) 10Jhernandez: [C: 032] Hygiene: Add spaces after keywords [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168378 (owner: 10Jdlrobson) [18:55:25] (03Merged) 10jenkins-bot: Hygiene: Add spaces after keywords [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168378 (owner: 10Jdlrobson) [18:55:30] (03PS1) 10Jdlrobson: Hygiene: Curly braces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168380 [18:55:32] (03PS1) 10Jdlrobson: Hygiene: Array padding [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168381 [18:55:34] (03PS1) 10Jdlrobson: Hygiene: Add jscs pre commit hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168382 [18:55:39] ^ there you go bmansurov and joakino your coding styling fears are over :) [18:57:53] bmansurov: `make jscs` that is [18:58:10] 3MobileFrontend / 3Hygiene: Get Grunt setup in MobileFrontend - 10https://bugzilla.wikimedia.org/72443 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon VisualEditor team is using a grunt file. Flow have also moved to one of these. One of the benefits of the Gruntfile is Jenkins will run `grunt test` on every... [18:58:30] jdlrobson, joakino thanks [18:59:20] (03PS5) 10Jdlrobson: Hygiene: Cleanup the toggling test code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 [18:59:29] (03PS6) 10Jdlrobson: Hygiene: Cleanup the toggling test code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 [18:59:41] (03CR) 10Jdlrobson: [C: 032] "Rebased and cherry picked to master" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 (owner: 10Jdlrobson) [19:00:15] (03Merged) 10jenkins-bot: Hygiene: Cleanup the toggling test code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167353 (owner: 10Jdlrobson) [19:00:38] 3MobileFrontend / 3Hygiene: Get Grunt setup in MobileFrontend - 10https://bugzilla.wikimedia.org/72443#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ecXDbChX [19:01:38] (03CR) 10Jhernandez: [C: 032] Hygiene: Curly braces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168380 (owner: 10Jdlrobson) [19:02:10] (03PS3) 10Jdlrobson: Hygiene: Refactor pageImage.js to be a method on PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167971 [19:02:12] (03Merged) 10jenkins-bot: Hygiene: Curly braces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168380 (owner: 10Jdlrobson) [19:02:26] (03CR) 10Jdlrobson: [C: 032] "cherry picked and merged" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167971 (owner: 10Jdlrobson) [19:03:03] (03Merged) 10jenkins-bot: Hygiene: Refactor pageImage.js to be a method on PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167971 (owner: 10Jdlrobson) [19:03:10] (03CR) 10Jhernandez: [C: 032] Hygiene: Array padding [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168381 (owner: 10Jdlrobson) [19:03:45] (03Merged) 10jenkins-bot: Hygiene: Array padding [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168381 (owner: 10Jdlrobson) [19:04:19] (03CR) 10Jhernandez: [C: 032] Hygiene: Add jscs pre commit hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168382 (owner: 10Jdlrobson) [19:04:54] (03Merged) 10jenkins-bot: Hygiene: Add jscs pre commit hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168382 (owner: 10Jdlrobson) [19:05:39] kaldari & phuedx: also, does the API really needs to be supplied the user token when it already knows it? [19:08:26] MaxSem: Probably not, but it's fine to support it for now since we already have code to pass it from the client [19:08:41] :) [19:09:18] * MaxSem doesn't like exposing more user info in URLs than needed... [19:10:16] (03PS8) 10Kaldari: Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [19:10:36] MaxSem: I changed the class names. Wanna +2 it? [19:10:57] MaxSem: oops, forgot to change the file names... [19:12:14] (03PS9) 10Kaldari: Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [19:12:41] MaxSem: OK, should be good now [19:12:51] jdlrobson: are there any cases where there are more than one 'h1's on a page? some other h1 except for the page title? [19:13:07] bmansurov: brb i'm going for some lunch [19:13:08] bmansurov: It's possible, but exceedingly rare [19:13:11] it is possible though yes [19:13:24] ok thanks guys [19:17:05] (03PS8) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [19:17:12] (03CR) 10jenkins-bot: [V: 04-1] Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [19:32:55] (03PS18) 10Robmoen: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [19:33:55] bmansurov: ^ resolved conflicts [19:34:11] ok [19:36:12] (03CR) 10Robmoen: [C: 032] Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [19:36:49] (03Merged) 10jenkins-bot: Update WikiGrok logging according to the new schema changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/167349 (owner: 10Bmansurov) [19:38:59] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/-n9GOg [19:38:59] 13WikipediaMobile/06master 144ad700e 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [19:49:38] (03PS9) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [19:55:38] (03PS1) 10Bmansurov: Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) [19:55:43] (03CR) 10jenkins-bot: [V: 04-1] Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) (owner: 10Bmansurov) [19:59:03] (03PS1) 10Robmoen: hygiene: coding style spacing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168400 [20:06:35] (03CR) 10MaxSem: Add the WikiGrokResponse API (031 comment) [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [20:09:29] (03PS2) 10Bmansurov: Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) [20:10:22] (03CR) 10jenkins-bot: [V: 04-1] Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) (owner: 10Bmansurov) [20:11:32] (03PS3) 10Bmansurov: Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) [20:12:03] (03PS2) 10Robmoen: Mobile mode getter and implement in schemas and WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168336 [20:13:39] 3MobileFrontend / 3General/Unknown: Cannot open VE for a specific page and the error "TypeError: lastSection is undefined" appears in the console - 10https://bugzilla.wikimedia.org/72395#c4 (10Bahodir Mansurov) The error has been fixed. However, when I hit the edit button, the editor doesn't just shows part... [20:14:38] 3MobileFrontend / 3General/Unknown: Cannot open VE for a specific page and the error "TypeError: lastSection is undefined" appears in the console - 10https://bugzilla.wikimedia.org/72395#c5 (10Bahodir Mansurov) Typo in "the editor doesn't just shows" above. It should read "the editor just shows" [20:38:55] (03PS10) 10Kaldari: Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [20:40:25] (03PS5) 10Jhernandez: Load nearby by url coordinates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [20:40:27] (03PS3) 10Jhernandez: Add loading by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168226 [20:40:50] (03PS5) 10Brion VIBBER: Transition to AFNetworking from MWNetworkOp. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 (owner: 10Mhurd) [20:42:28] (03CR) 10Brion VIBBER: "I changed the way the cocoapods projects are included in the project in a way that should be easier to update if they change in future." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 (owner: 10Mhurd) [20:49:59] (03CR) 10MaxSem: [C: 032] Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [20:58:43] (03PS6) 10Brion VIBBER: Transition to AFNetworking from MWNetworkOp. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 (owner: 10Mhurd) [20:59:20] (03CR) 10Brion VIBBER: "and updated the notes file" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 (owner: 10Mhurd) [21:00:28] (03PS7) 10Mhurd: Transition to AFNetworking from MWNetworkOp. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 [21:00:52] (03PS6) 10Jhernandez: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [21:02:16] (03Abandoned) 10Jhernandez: Add loading by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168226 (owner: 10Jhernandez) [21:10:37] (03CR) 10Brion VIBBER: [C: 032] "Ok this seems to be working pretty well now -- a few minor tweaks remain like fixing the MNC/MCC headers but that can be done as separate " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168191 (owner: 10Mhurd) [21:13:02] (03PS2) 10Jdlrobson: Use ResourceLoaderFileModule for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 [21:13:37] (03CR) 10jenkins-bot: [V: 04-1] Use ResourceLoaderFileModule for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 (owner: 10Jdlrobson) [21:15:43] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/167342/ is making jenkins happy [21:16:57] joakino: let [21:17:07] let's leave at 4.45pm today [21:17:15] I locked myself out of Wordpress. [21:17:15] jdlrobson: ok! [21:17:19] * Deskana sighs. [21:21:13] bmansurov: i see your patch that got merged as some code styling issues can you fix? [21:21:21] you can run `make jscs` now to see them :) [21:21:39] jdlrobson: which patch? [21:22:04] If2ecbf559ce5b4a34ddd39ac8e7872471d4ef559 [21:22:10] https://gerrit.wikimedia.org/r/#/c/167349/ [21:23:05] thanks for fixing that minor kaldari [21:23:06] (03CR) 10MaxSem: [V: 032] Add the WikiGrokResponse API [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/167829 (owner: 10Phuedx) [21:23:23] blergh, WG is not registered with jerkins [21:23:37] woo [21:23:50] MaxSem: new extension is new [21:23:50] phuedx: You're still awake! [21:24:02] kaldari: just got back from climbimbimbing [21:24:34] (03CR) 10Jdlrobson: [C: 04-1] "This fixes the issue but could you please write a qunit test to describe the issue so this doesn't break again? Thanks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) (owner: 10Bmansurov) [21:26:33] (03PS1) 10Bmansurov: Code styling fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168471 [21:29:06] ok [21:29:13] fruit tea time and then bed! [21:29:24] local maxima of awakeness [21:29:26] g'night folks [21:29:49] (03PS7) 10Jhernandez: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [21:30:28] bmansurov: jdlrobson the wikigrok style errors [21:30:32] hah [21:32:11] bmansurov: thanks i couldn't commit without that :) [21:32:33] (03PS2) 10Jdlrobson: Hygiene: Code styling fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168471 (owner: 10Bmansurov) [21:32:38] (03CR) 10Jdlrobson: [C: 032] Hygiene: Code styling fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168471 (owner: 10Bmansurov) [21:33:17] (03Merged) 10jenkins-bot: Hygiene: Code styling fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168471 (owner: 10Bmansurov) [21:35:45] (03PS1) 10Jdlrobson: Hygiene: Add JSDuck validation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168489 [21:35:50] ^ kaldari :D [21:39:02] brb [21:40:55] 3Wikipedia App / 3General/Unknown: Include Install ID--in all MobileWikiApp schemas (same name in all schemas) - 10https://bugzilla.wikimedia.org/72457 (10Jon Katz) 3NEW p:3Unprio s:3normal a:3None First bug write, so apologies if I am breaking protocol. Currently the app install id is included in a... [21:42:40] (03PS8) 10Jhernandez: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [21:46:17] (03PS2) 10Jdlrobson: Hygiene: coding style spacing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168400 (owner: 10Robmoen) [21:46:43] rmoen: just a quick check are you setup with the `make installhooks` (same question to phuedx if still awake) [21:46:55] (03CR) 10Jdlrobson: [C: 032] "Mm.. how do we get jscs to pick this up?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168400 (owner: 10Robmoen) [21:47:30] (03Merged) 10jenkins-bot: Hygiene: coding style spacing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168400 (owner: 10Robmoen) [21:48:20] jdlrobson: i'm not [21:49:00] jdlrobson: i've ran 'make installhooks' in mobilefrontend. that all i need to do ? [21:49:07] yup you are good then :) [21:49:20] i added jscs to pick up coding issues [21:49:24] Nice [21:49:24] want to check it is running when you commit [21:49:38] next step getting a Gruntfile up and running [21:49:45] yeah [21:50:47] jdlrobson: since the WikiGrok response api has been merged, i think 167829 is ready to go. would you mind taking a look ? [21:51:23] jdlrobson: i mean 168018 [21:52:22] rmoen: sure just pushing my way through the queue now [21:53:11] cool [21:54:09] (03CR) 10Jdlrobson: "Yeh there are a bunch of issues with the new icons that I was hoping to resolve in alpha, which of these do you think are you the most pre" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [21:54:46] (03CR) 10Jdlrobson: [C: 031] "Do you want to use Router in a follow up patch?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (owner: 10Jhernandez) [21:58:52] TrevorParscal: that template patch got +1ed by Matmarex if you want to push the trigger :) [22:00:44] MaxSem: Error: Could not find class ::role::wikibase for mediawiki-vagrant on node mediawiki-vagrant [22:00:51] when i vagrant enable-role wikigrok [22:01:54] shouldn't wikigrok also enable wikidata? [22:02:02] (03CR) 10Jdlrobson: [C: 04-1] "Please run `make jscs` to keep to coding standards" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [22:04:25] jdlrobson: to get WikiGrok running on vagrant you have to git pull in vagrant dir [22:05:00] i had the same issue then max patched WikiGrok in vagrant [22:06:18] (03CR) 10Robmoen: Implement WikiGrok response API (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [22:17:53] (03PS9) 10Jhernandez: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [22:18:12] (03PS10) 10Jhernandez: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [22:19:47] jdlrobson: finally, ^, if you can, have a look pls [22:20:09] (03PS10) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [22:20:46] (03PS11) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [22:21:02] (03PS3) 10Robmoen: Mobile mode getter and implement in schemas and WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168336 [22:23:50] jdlrobson, cd vagrant && git pull && vagrant provission [22:27:34] (03PS4) 10Bmansurov: Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) [22:29:28] (03PS1) 10Jdlrobson: Don't let textarea grow bigger than the current window [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168499 (https://bugzilla.wikimedia.org/69092) [22:30:58] jdlrobson: how can I make 'read in another language' link show up on a page? [22:35:52] MaxSem: you there? [22:36:01] yup [22:36:29] MaxSem: how can I make a page in 2 different languages so that I see the 'read in another language' link when I visit one of them? [22:43:24] (03CR) 10Kaldari: [C: 04-1] Implement WikiGrok response API (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [22:46:10] bmansurov: hey [22:46:12] (03CR) 10Jhernandez: [C: 032] "Seems to be fixed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168499 (https://bugzilla.wikimedia.org/69092) (owner: 10Jdlrobson) [22:46:14] bmansurov: use the browser tests [22:46:22] cd tests/browser [22:46:31] jdlrobson: I'm trying to manually reproduce the issue [22:46:33] cat README [22:46:43] it will allow you to test locally any of the features [22:46:48] (03Merged) 10jenkins-bot: Don't let textarea grow bigger than the current window [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168499 (https://bugzilla.wikimedia.org/69092) (owner: 10Jdlrobson) [22:46:54] bundle exec cucumber features/language.feature will test languages for you [22:47:12] but note the setup instructions in the README [22:47:24] if you haven't got browser tests up and running I highly recommend it - it will save you lots and lots of time [22:47:43] jdlrobson: I have already got them up and running, I want to see if I can recreate the issue myself [22:48:47] (03CR) 10Jhernandez: [C: 032] Hygiene: Add JSDuck validation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168489 (owner: 10Jdlrobson) [22:49:16] bmansurov: but you said you can't get the language button to show? [22:49:25] (03Merged) 10jenkins-bot: Hygiene: Add JSDuck validation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168489 (owner: 10Jdlrobson) [22:49:32] jdlrobson: yes [22:49:41] bmansurov: have you followed the setup section in the readme? [22:49:46] in particular INSERT INTO interwiki (iw_prefix, iw_url, iw_local, iw_trans) VALUES ("es", "http://wikifoo.org/es/index.php/$1", 0, 0); [22:49:58] jdlrobson: oh yeah, that gave me an error [22:50:56] bmansurov: what error? [22:51:22] Warning (Code 1364): Field 'iw_api' doesn't have a default value [22:51:22] Warning (Code 1364): Field 'iw_wikiid' doesn't have a default value [22:51:57] that's a warning :) [22:52:07] bmansurov: and did you run the language.feature browser test? [22:52:18] jdlrobson: yep, all 3 passed [22:53:31] jdlrobson: i think the problem is in editor_wikitext_saving.feature [22:56:17] (03PS3) 10Jdlrobson: Use ResourceLoaderFileModule for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 [22:56:43] bmansurov: okay so you have a page with blue read in another language link? [22:56:57] (03CR) 10jenkins-bot: [V: 04-1] Use ResourceLoaderFileModule for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 (owner: 10Jdlrobson) [22:57:02] jdlrobson: yes now I have it [22:57:12] good [22:57:18] so the issue is the browser test failing now? [22:57:30] i assume you are working on https://trello.com/c/xnGnfpAT/78-bug-72368-qa-scenario-successful-edit-reloads-language-button-test-fails [22:58:17] jdlrobson: yes, and the test in the card passes, but the test before it fails [22:58:37] which test scenario is failing? [22:58:43] Scenario: Successful edit on page without languages shows no language button [bug 63675] [23:00:37] jdlrobson: ok, it fails because the language I'm using has different alphabets, latin and cyrillic, and the language button is always visible [23:01:59] bmansurov: they all pass for me [23:02:01] jdlrobson: when I switch to 'en' all tests pass, so I think the bug is invalid [23:02:03] yep [23:02:06] bmansurov: which browser are you using [23:02:16] for testing? [23:02:17] firefox [23:02:26] let me try chrome quickly [23:03:56] bmansurov: looks like you are right. https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/ is passing [23:04:01] feel free to RESOLVED invalid [23:04:06] k [23:04:54] 3MobileFrontend / 3Hygiene: QA: Scenario: Successful edit reloads language button test fails - 10https://bugzilla.wikimedia.org/72368 (10Bahodir Mansurov) 5NEW>3RESO/INV [23:06:09] brion: wow there were a ton of translation updates in that last batch! [23:06:13] (03PS4) 10Jdlrobson: Use ResourceLoaderFileModule for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 [23:06:17] sweet [23:06:48] mhurd: Let me know when the TestFlight build goes out so I can email Andy. [23:06:50] (03CR) 10jenkins-bot: [V: 04-1] Use ResourceLoaderFileModule for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 (owner: 10Jdlrobson) [23:07:05] Deskana: should be ready in a minute or 2... [23:07:15] \o/ [23:08:12] (03CR) 10Jdlrobson: [C: 031] "Looks good just testing and taking a closer look" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) (owner: 10Bmansurov) [23:10:49] Deskana: something to maybe do tomorrow - Andy had said having a way in-app to confirm what version is being used would be really helpful to them... [23:13:50] brion: Deskana testflight build cut [23:13:54] woooo [23:15:49] joakino https://translatewiki.net/wiki/Special:Translate?group=ext-mobilefrontend&language=es&filter=%21translated&action=translate [23:16:45] (03CR) 10Jdlrobson: [C: 04-1] "The test doesn't seem to catch the edge case. I applied just the test file to the current master branch and it passes there too. Expected:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) (owner: 10Bmansurov) [23:18:33] (03PS1) 10Bmansurov: Record whether a WikiGrok response is a test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168516 [23:18:36] (03CR) 10Jdlrobson: [C: 032] Mobile mode getter and implement in schemas and WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168336 (owner: 10Robmoen) [23:21:59] mhurd: Strange, I didn't get the notification. [23:22:25] Deskana: it can take a few min [23:22:27] (03CR) 10Jdlrobson: [C: 031] "Haven't tested this. Someone please check this is in fact logging data before +2ing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168516 (owner: 10Bmansurov) [23:23:23] 3MobileFrontend / 3General/Unknown: Can't scroll to top in editing window - 10https://bugzilla.wikimedia.org/69092 (10Jon) 5PATC>3RESO/FIX [23:23:31] * Deskana taps his fingers impatiently. [23:33:13] * Deskana is still tapping his fingers impatiently. [23:34:12] (03CR) 10Jdlrobson: [C: 04-1] Load nearby by url coordinates and load by page title (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (owner: 10Jhernandez) [23:35:03] jdlrobson: Do you have any idea why textarea borders would have disappeared recently in MF? We remove them in reset.less, but I think it's always been that way. Was something else changed recently? [23:35:43] (03PS12) 10Robmoen: Implement WikiGrok response API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 [23:36:09] (03CR) 10Robmoen: Implement WikiGrok response API (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [23:36:22] (03PS4) 10Robmoen: Mobile mode getter and implement in schemas and WikiGrokResponseApi [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168336 [23:37:16] mhurd: I'm thinking I'm not going to get this email. :/ [23:38:16] Deskana: it has taken as long as 45 min in the past. [23:38:35] Deskana: if you go to “testflightapp.com” in safari do you see the new build? [23:38:37] Deskana: just go to http://testflightapp.com on your safari, it should show you the current version :D [23:38:51] * Deskana looks [23:39:16] Yeah, it's there. [23:39:20] Okay, I'll email Andy. [23:39:29] Deskana: so i just responded to 6 or 7 of the testflight feedback emails [23:40:45] Deskana: do you get cc’d when i do this? [23:40:55] mhurd: Yeah, they're coming into my inbox. [23:41:01] Deskana: cool! [23:44:16] (03PS5) 10Bmansurov: Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) [23:46:14] (03PS6) 10Bmansurov: Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) [23:47:41] (03PS7) 10Bmansurov: Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) [23:49:55] 3MobileFrontend / 3stable: Regression: Summary field in editor is missing styling - 10https://bugzilla.wikimedia.org/72463 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None See screenshot. For some reason the summary field in the editor no longer has appropriate styling. It's supposed to have a bord... [23:50:22] 3MobileFrontend / 3stable: Regression: Summary field in editor is missing styling - 10https://bugzilla.wikimedia.org/72463#c1 (10Ryan Kaldari) Created attachment 16871 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16871&action=edit screenshot of summary interface [23:50:35] (03PS1) 10Kaldari: Fix summary field in mobile editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168524 (https://bugzilla.wikimedia.org/72463) [23:50:38] 3MobileFrontend / 3stable: Regression: Summary field in editor is missing styling - 10https://bugzilla.wikimedia.org/72463#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/iZsd0UBQ [23:52:58] (03PS8) 10Bmansurov: Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) [23:53:59] (03PS9) 10Bmansurov: Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395)