[00:08:53] 3Wikipedia App / 3Android App: SecurityException: Permission denied (missing INTERNET permission?) - 10https://bugzilla.wikimedia.org/67948#c7 (10Alex Monk) Looks like this is still happening? https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7902644 [00:10:53] 3Wikipedia App / 3Android App: SecurityException: Permission denied (missing INTERNET permission?) - 10https://bugzilla.wikimedia.org/67948#c8 (10Dmitry Brant) Looking into it now... there may be an edge case (or two) where we make network requests outside of java-mwapi, and failing to account for SecurityEx... [00:11:53] 3Wikipedia App / 3Android App: android.content.ActivityNotFoundException: No Activity found to handle Intent (WEB_SEARCH and CHOOSER) - 10https://bugzilla.wikimedia.org/70528#c2 (10Alex Monk) This one is probably more important: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=7901589 [00:13:02] (03PS9) 10MaxSem: Backend for picking questions [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/166148 [00:13:17] not a WIP anymore ^_^ [00:14:32] mhurd: https://trello.com/c/N8gsS2mU/38-ios-app-credits-screen-needs-improvement [00:14:40] mhurd: Image/rationale linked in the comments. [00:15:08] (03CR) 10Bmansurov: [C: 032] Fix summary field in mobile editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168524 (https://bugzilla.wikimedia.org/72463) (owner: 10Kaldari) [00:15:42] (03Merged) 10jenkins-bot: Fix summary field in mobile editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168524 (https://bugzilla.wikimedia.org/72463) (owner: 10Kaldari) [00:17:04] (03CR) 10Kaldari: [C: 04-2] "Have to wait on https://bugzilla.wikimedia.org/show_bug.cgi?id=72465" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [00:23:51] I fixed that stupid problem on the Barack Obama article where someone took the disambiguation info out of the hatnote: https://en.wikipedia.org/w/index.php?title=Barack_Obama&diff=630865695&oldid=630827903 [00:24:05] dbrant|brb, bearND, mhurd, vbamba, moizsyed ^^ [00:24:14] It now wraps up properly in the app again. [00:24:18] Deskana: hehe [00:24:31] Deskana: haha nice! [00:24:59] :) [00:31:40] (03CR) 10Kaldari: [C: 032] Record whether a WikiGrok response is a test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168516 (owner: 10Bmansurov) [00:32:16] (03Merged) 10jenkins-bot: Record whether a WikiGrok response is a test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168516 (owner: 10Bmansurov) [01:04:53] (03PS1) 10Mhurd: Re-added cell carrier header. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168527 [01:09:40] (03PS2) 10Mhurd: Re-added cell carrier header. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168527 [01:14:11] Where's brion, I need someone to explain why Esperanto ruins everything [01:24:04] (03PS1) 10Dbrant: Catch remaining cases of SecurityException. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168530 [04:43:06] (03PS13) 10Deskana: Add watchlist functionality. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 [04:44:28] (03CR) 10Deskana: "Did a manual rebase. No other changed since the last patch set." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [05:27:32] (03PS1) 10BearND: Add Wikidata descriptions to full text results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168544 [05:29:05] (03PS1) 10Deskana: Update README. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168545 [09:04:52] yo [09:20:18] joakino: you're awake? [09:31:19] (03CR) 10Phuedx: "Jdlrobson: should this change be upstreamed as well?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168499 (https://bugzilla.wikimedia.org/69092) (owner: 10Jdlrobson) [09:35:27] (03CR) 10Phuedx: "* Clicking the notification icon doesn't hide it while the notifications are loading" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [11:37:56] 3MobileFrontend / 3alpha: Missing line break in anonymous editing link - 10https://bugzilla.wikimedia.org/72474 (10Florian) 3NEW p:3Unprio s:3normal a:3None Created attachment 16878 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16878&action=edit missing line break (Signup edit without login)... [11:39:53] 3MobileFrontend / 3stable: Regression: Summary and captcha field in editor is missing styling - 10https://bugzilla.wikimedia.org/72463#c5 (10Florian) Captcha input field, too. [11:40:23] 3MobileFrontend / 3alpha: Missing line break in anonymous editing link - 10https://bugzilla.wikimedia.org/72474#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/vCbdm4YM [11:42:39] 3MobileFrontend / 3alpha: Missing line break in anonymous editing link - 10https://bugzilla.wikimedia.org/72474 (10Florian) a:3Florian [11:44:21] (03PS1) 10Florianschmidtwelzow: Remove special styling of captcha input field in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168573 (https://bugzilla.wikimedia.org/72463) [12:00:17] (03PS1) 10Florianschmidtwelzow: Add workaround for missing diblock display [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168576 (https://bugzilla.wikimedia.org/72474) [12:52:38] 3Wikipedia App / 3iOS App: iOS app doesn't support {{DISPLAYTITLE:}} - 10https://bugzilla.wikimedia.org/63971#c4 (10Amir E. Aharoni) 5RESO/FIX>3REOP It also needs to support in some other contexts. An immediate one is the top of the table of contents. Another one is search results autocompletion. In b... [13:14:18] (03PS1) 10Dbrant: Implement remote killswitch for disabling full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168580 [13:53:19] (03PS2) 10Dbrant: Catch remaining cases of SecurityException. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168530 [13:54:26] 3Wikipedia App / 3Android App: editing preview is in LTR on RTL wikis in the Android app - 10https://bugzilla.wikimedia.org/72476 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Set Wkipedia language to Hebrew. Edit an article. Save. Observed: the previewed article content's direction is LTR. Ex... [13:54:26] 3Wikipedia App / 3Localization/Translation/Language: RTL bugs in the Wikimedia Mobile Android app (tracking) - 10https://bugzilla.wikimedia.org/34166 (10Amir E. Aharoni) [13:54:53] 3Wikipedia App / 3Android App: editing preview is in LTR on RTL wikis in the Android app - 10https://bugzilla.wikimedia.org/72476#c1 (10Amir E. Aharoni) (By "Save", I mean the first step of saving, which shows canned edit summaries and preview.) [14:01:17] (03PS2) 10Dbrant: Implement remote killswitch for disabling full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168580 [14:21:53] (03PS1) 10Phuedx: Make subject_id param a string [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/168588 [14:25:49] (03CR) 10Phuedx: [C: 031] "This LGTM. Tested locally by using WikiGrok and tailing the EventLogging log." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168018 (owner: 10Robmoen) [14:36:04] (03PS1) 10Dbrant: Fix directionality of edit preview (for RTL) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168590 (https://bugzilla.wikimedia.org/72476) [14:42:06] dbrant++ Thanks for https://gerrit.wikimedia.org/r/#/c/168590/ ! [14:42:17] aharoni: anytime! [14:47:19] (03PS1) 10Dbrant: Refresh of bundled styles from MobileApp. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168592 (https://bugzilla.wikimedia.org/66322) [14:58:24] (03CR) 10Phuedx: [C: 032] Remove special styling of captcha input field in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168573 (https://bugzilla.wikimedia.org/72463) (owner: 10Florianschmidtwelzow) [14:59:00] (03Merged) 10jenkins-bot: Remove special styling of captcha input field in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168573 (https://bugzilla.wikimedia.org/72463) (owner: 10Florianschmidtwelzow) [15:00:27] 3MobileFrontend / 3stable: Regression: Summary and captcha field in editor is missing styling - 10https://bugzilla.wikimedia.org/72463 (10Sam Smith) 5PATC>3RESO/FIX [15:02:53] 3MobileFrontend / 3stable: Regression: Summary and captcha field in editor is missing styling - 10https://bugzilla.wikimedia.org/72463#c8 (10Jon) 5RESO/FIX>3REOP Note input styles are currently not loaded on all pages and probably should be so bug is not fixed. [15:15:09] 3MobileFrontend / 3stable: Regression: Summary and captcha field in editor is missing styling - 10https://bugzilla.wikimedia.org/72463#c9 (10Florian) @Jon: You mean mw-ui-input? It's a dependency for mobile.editor in Kaldari's change: https://gerrit.wikimedia.org/r/#/c/168524/1/includes/Resources.php [15:17:01] (03PS2) 10Florianschmidtwelzow: Add workaround for missing "block" display [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168576 (https://bugzilla.wikimedia.org/72474) [15:20:10] 3MobileFrontend / 3stable: Regression: Summary and captcha field in editor is missing styling - 10https://bugzilla.wikimedia.org/72463#c10 (10Jon) 5REOP>3RESO/FIX Errg I just saw your patch. That said the input CSS module contains a lot of cruft not relevant to mobile. We may want to revisit this conside... [16:08:09] (03PS1) 10Dbrant: Catch possible exception when clicking Preference with intent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168605 (https://bugzilla.wikimedia.org/70528) [16:09:32] (03PS1) 10Florianschmidtwelzow: Add handling of code tags in content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168606 (https://bugzilla.wikimedia.org/49033) [16:27:38] 3MobileFrontend / 3stable: Login page buttons looks unstyled - 10https://bugzilla.wikimedia.org/72482 (10Florian) 5NEW>3UNCO [16:27:41] 3MobileFrontend / 3stable: Login page buttons looks unstyled - 10https://bugzilla.wikimedia.org/72482 (10Florian) 3NEW p:3Unprio s:3normal a:3None Created attachment 16885 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16885&action=edit unstyled login buttons Tested on master, but can't repr... [16:30:23] 3MobileFrontend / 3stable: Login page buttons looks unstyled - 10https://bugzilla.wikimedia.org/72482#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/UApsh7Kd [16:35:00] (03CR) 10BearND: [C: 032] Catch remaining cases of SecurityException. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168530 (owner: 10Dbrant) [16:35:24] (03Merged) 10jenkins-bot: Catch remaining cases of SecurityException. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168530 (owner: 10Dbrant) [16:37:43] (03PS2) 10BearND: Catch possible exception when clicking Preference with intent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168605 (https://bugzilla.wikimedia.org/70528) (owner: 10Dbrant) [16:41:04] (03CR) 10BearND: [C: 032] Catch possible exception when clicking Preference with intent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168605 (https://bugzilla.wikimedia.org/70528) (owner: 10Dbrant) [16:41:26] (03Merged) 10jenkins-bot: Catch possible exception when clicking Preference with intent. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168605 (https://bugzilla.wikimedia.org/70528) (owner: 10Dbrant) [16:43:32] (03PS3) 10BearND: Implement remote killswitch for disabling full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168580 (owner: 10Dbrant) [16:45:08] bearND, hey [16:45:28] bearND, so this means if the user has no browser and tries to open the privacy policy, they get an error instead? [16:45:51] you might want to put that past legal. [16:46:21] Krenair: that would be the case, yes. But it's better than a crash! [16:46:48] true, this is an improvement [16:46:53] but still sounds... [16:46:59] probably not good :) [16:47:44] Krenair: we should indeed ask legal. Ideally we should probably bundle the policy along with the app, and display it ourselves... [16:48:24] Krenair: but localization, updates, etc. would get really complicated [16:48:33] dbrant, if you would support sites other than wikipedia, you could go straight there :) [16:50:15] it's just another wiki page, but hosted on the foundation domain rather than wikipedia [16:50:39] (03CR) 10BearND: [C: 032] Implement remote killswitch for disabling full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168580 (owner: 10Dbrant) [16:51:03] (03Merged) 10jenkins-bot: Implement remote killswitch for disabling full-text search. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168580 (owner: 10Dbrant) [16:51:11] (03PS2) 10BearND: Fix directionality of edit preview (for RTL) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168590 (https://bugzilla.wikimedia.org/72476) (owner: 10Dbrant) [16:52:52] 3MobileFrontend / 3beta: Login page buttons looks unstyled - 10https://bugzilla.wikimedia.org/72482#c2 (10Jon) It looks funky in beta but fine in stable. [16:53:08] 3MobileFrontend / 3beta: Login page buttons looks unstyled - 10https://bugzilla.wikimedia.org/72482#c3 (10Jon) Created attachment 16886 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16886&action=edit In beta [16:53:23] 3MobileFrontend / 3beta: Login page buttons looks unstyled - 10https://bugzilla.wikimedia.org/72482 (10Jon) 5UNCO>3NEW [16:53:38] 3MobileFrontend / 3beta: Login page buttons looks unstyled in beta - 10https://bugzilla.wikimedia.org/72482 (10Jon) [16:55:23] 3MobileFrontend / 3beta: Login page buttons looks unstyled in beta - 10https://bugzilla.wikimedia.org/72482#c4 (10Florian) (In reply to Jon from comment #3) > Created attachment 16886 [details] > In beta Argh, yeah, my fault, i haven't seen, that i'm in beta :) [16:56:13] (03CR) 10Jdlrobson: [C: 04-1] "Should be in text.less with other rules." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168606 (https://bugzilla.wikimedia.org/49033) (owner: 10Florianschmidtwelzow) [16:57:45] (03PS1) 10Florianschmidtwelzow: Use login page design in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168615 (https://bugzilla.wikimedia.org/72482) [16:59:17] (03CR) 10Jdlrobson: [C: 04-1] Add workaround for missing "block" display (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168576 (https://bugzilla.wikimedia.org/72474) (owner: 10Florianschmidtwelzow) [16:59:54] (03CR) 10Jdlrobson: [C: 032] Use login page design in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168615 (https://bugzilla.wikimedia.org/72482) (owner: 10Florianschmidtwelzow) [17:00:45] (03PS1) 10Florianschmidtwelzow: Use login page design in beta [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168616 (https://bugzilla.wikimedia.org/72482) [17:01:39] 3MobileFrontend / 3beta: Login page buttons looks unstyled in beta - 10https://bugzilla.wikimedia.org/72482#c7 (10Florian) Reproduced on betalabs and mw.org (1.25wmf5), makes it to a blocker. https://m.mediawiki.org/wiki/Special:UserLogin?mobileaction=beta [17:02:02] (03Merged) 10jenkins-bot: Use login page design in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168615 (https://bugzilla.wikimedia.org/72482) (owner: 10Florianschmidtwelzow) [17:03:30] (03CR) 10BearND: [C: 04-1] "Could be improved further." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168590 (https://bugzilla.wikimedia.org/72476) (owner: 10Dbrant) [17:05:26] (03PS2) 10BearND: Refresh of bundled styles from MobileApp. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168592 (https://bugzilla.wikimedia.org/66322) (owner: 10Dbrant) [17:07:30] (03PS3) 10Florianschmidtwelzow: Add workaround for missing "block" display [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168576 (https://bugzilla.wikimedia.org/72474) [17:07:42] (03CR) 10BearND: [C: 032] Refresh of bundled styles from MobileApp. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168592 (https://bugzilla.wikimedia.org/66322) (owner: 10Dbrant) [17:08:04] (03Merged) 10jenkins-bot: Refresh of bundled styles from MobileApp. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168592 (https://bugzilla.wikimedia.org/66322) (owner: 10Dbrant) [17:08:24] bearND: thx for all that! [17:09:00] (03PS4) 10Florianschmidtwelzow: Add workaround for missing "block" display [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168576 (https://bugzilla.wikimedia.org/72474) [17:09:23] dbrant: thank you for the many bug fixes [17:10:27] dbrant: https://gerrit.wikimedia.org/r/#/c/168544/ is pretty much ready to go. I'll just add some tests [17:16:00] kaldari: around? [17:16:23] FlorianSW: he should be soonish [17:16:30] we've just finished our stand up meetin [17:16:32] *' [17:16:56] phuedx: ah, ok :) [17:16:59] thanks [17:19:23] 3MobileFrontend / 3beta: Login page buttons looks unstyled in beta - 10https://bugzilla.wikimedia.org/72482 (10Jon) 5PATC>3RESO/FIX [17:20:24] 3MobileFrontend / 3beta: Login page buttons looks unstyled in beta - 10https://bugzilla.wikimedia.org/72482#c9 (10Jon) Not sure about it being a blocker. It only effects the beta mode of our site and no functionality is broken. Can you flag to the mailing list? We can make a decision there whether this needs... [17:21:03] (03CR) 10Jhernandez: Load nearby by url coordinates and load by page title (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (owner: 10Jhernandez) [17:22:04] (03CR) 10Jdlrobson: [C: 04-1] Add workaround for missing "block" display (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168576 (https://bugzilla.wikimedia.org/72474) (owner: 10Florianschmidtwelzow) [17:23:38] (03PS2) 10Florianschmidtwelzow: Add handling of code tags in content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168606 (https://bugzilla.wikimedia.org/49033) [17:25:00] (03CR) 10Florianschmidtwelzow: Add workaround for missing "block" display (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168576 (https://bugzilla.wikimedia.org/72474) (owner: 10Florianschmidtwelzow) [17:25:20] (03PS5) 10Florianschmidtwelzow: Add workaround for missing "block" display [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168576 (https://bugzilla.wikimedia.org/72474) [17:25:25] 3MobileFrontend / 3stable: Regression: Section edit links always show as locked - 10https://bugzilla.wikimedia.org/72484 (10Jon) 3NEW p:3Unprio s:3normal a:3None You can click them and edit but they look like they are locked from editing. Probably a regression as a result of the icon changes. [17:25:38] jdlrobson: you want to talk icons? [17:26:12] (03CR) 10Kaldari: [C: 032] Make subject_id param a string [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/168588 (owner: 10Phuedx) [17:26:15] merge FlorianSW's patch first, then we'll chat [17:26:24] thanks [17:26:30] hoom [17:26:38] kaldari isn't here but he's mergin' [17:27:23] 3MobileFrontend / 3stable: Regression: Section edit links always show as locked - 10https://bugzilla.wikimedia.org/72484#c1 (10Jon) This is live on mediawiki.org [17:28:07] (03CR) 10Jdlrobson: [C: 032] "Perfect." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) (owner: 10Bmansurov) [17:28:45] (03Merged) 10jenkins-bot: Fix transforming sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168398 (https://bugzilla.wikimedia.org/72395) (owner: 10Bmansurov) [17:28:51] (03CR) 10Jdlrobson: [C: 04-1] "rebase issue?" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168606 (https://bugzilla.wikimedia.org/49033) (owner: 10Florianschmidtwelzow) [17:29:54] 3MobileFrontend / 3General/Unknown: Cannot open VE for a specific page and the error "TypeError: lastSection is undefined" appears in the console - 10https://bugzilla.wikimedia.org/72395 (10Jon) 5PATC>3RESO/FIX [17:30:37] 3MobileFrontend / 3stable: Regression: Section edit links always show as locked - 10https://bugzilla.wikimedia.org/72484#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/IkImNhGV [17:31:15] bearND: able to hop on ghangout? [17:31:24] 3MobileFrontend / 3beta: Login page buttons looks unstyled in beta - 10https://bugzilla.wikimedia.org/72482#c10 (10Ryan Kaldari) Agree with Jon that it's probably not a blocker (since it only affects Beta). [17:31:32] (03CR) 10Jdlrobson: [C: 032] Add workaround for missing "block" display [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168576 (https://bugzilla.wikimedia.org/72474) (owner: 10Florianschmidtwelzow) [17:32:11] (03Merged) 10jenkins-bot: Add workaround for missing "block" display [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168576 (https://bugzilla.wikimedia.org/72474) (owner: 10Florianschmidtwelzow) [17:32:29] kaldari: did you see https://github.com/kaldari/WikiGrokAPI/pull/2 ? it's exciting :) [17:32:37] 3MobileFrontend / 3beta: Login page buttons looks unstyled in beta - 10https://bugzilla.wikimedia.org/72482#c11 (10Florian) Thanks kaldari :) Mail already sent :( https://lists.wikimedia.org/pipermail/mobile-l/2014-October/008205.html [17:32:53] 3MobileFrontend / 3alpha: Missing line break in anonymous editing link - 10https://bugzilla.wikimedia.org/72474 (10Florian) 5PATC>3RESO/FIX [17:33:43] jdlrobson, phuedx: wow, that's awesome [17:33:58] ? [17:34:03] kaldari: ^ [17:34:07] (03CR) 10Florianschmidtwelzow: "no rebase-issue. The rules only affect .content elements, so i think they're better in text.less?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168606 (https://bugzilla.wikimedia.org/49033) (owner: 10Florianschmidtwelzow) [17:34:55] phuedx: The dob dod code [17:35:11] Dobdods for everyone! [17:35:48] yeah, moar tables plz [17:35:55] or moar flags plz [17:35:59] pick one :) [17:36:39] (03PS2) 10Deskana: Update README. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168545 [17:36:52] (03Abandoned) 10Florianschmidtwelzow: Use login page design in beta [extensions/MobileFrontend] (wmf/1.25wmf5) - 10https://gerrit.wikimedia.org/r/168616 (https://bugzilla.wikimedia.org/72482) (owner: 10Florianschmidtwelzow) [17:37:00] phuedx: I'll go ahead and create the new tables [17:37:07] brion: ^ should be good to be merged [17:41:21] doddobdobies [17:42:05] (03CR) 10Jdlrobson: "The edit icons are ui elements so should be there. THey have nothing to do with text." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168606 (https://bugzilla.wikimedia.org/49033) (owner: 10Florianschmidtwelzow) [17:43:23] 3MobileFrontend / 3Feature requests: [Tracking] Deprecate redlink removal (enable redlinks in stable) - 10https://bugzilla.wikimedia.org/69849#c2 (10James Forrester) *** Bug 72467 has been marked as a duplicate of this bug. *** [17:43:37] jdlrobson, kaldari: brb -- george's bedtime [17:44:27] jdlrobson kaldari: since maryana isn’t here to weigh in on lightning deploy for section edit lock, wonderign what are the criteria by which LD decision are usually evaluated (eg #users impacted, type of users impacted…)? Or is it more off the cuff? [17:45:01] kristenlans: https://wikitech.wikimedia.org/wiki/SWAT_deploys [17:45:59] kristenlans: I'm not the PM of the Mobile Webz team, but I'd say something like this is worth getting fixed ASAP. [17:46:19] kristenlans: greg-g would be a good person to speak to. :) [17:46:35] kristenlans: thanks for the ping, just replied to the email. [17:47:17] Cool. Deskana: looks like a go, Jon and Kaldari are on it. [17:48:34] kaldari: do you know any wikidata claim ID that has nationalities? [17:49:05] bmansurov: check the Wikidata page on mediawiki.org. It has IDs for all the test cases. [17:49:32] bmansurov: Sorry I meant the WikiGrok page: https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok [17:49:48] kaldari: thanks [17:55:10] phuedx: I can't seem to get mysqldump to work on Tool Labs (to get the SQL to clone the table), do you know any other way to get it or should I ping someone in the labs channel? [17:56:08] (03CR) 10Brion VIBBER: [C: 032] Update README. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168545 (owner: 10Deskana) [17:57:41] (03PS3) 10Florianschmidtwelzow: Add handling of code tags in content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168606 (https://bugzilla.wikimedia.org/49033) [17:58:26] bearND: you there? [17:58:30] netsplits blargh? [17:58:44] dr0ptp4kt: yes [17:58:51] bearND: able to do a ghangout? [17:59:04] dr0ptp4kt: sure [17:59:11] bearND: ok, i'll call you [18:00:14] 3MobileFrontend / 3stable: Nearby doesn't remember back behaviour - 10https://bugzilla.wikimedia.org/72486 (10Jon) 3NEW p:3Unprio s:3normal a:3None Go to Special:Nearby Scroll down page to bottom entry Click it Click back button You are thrown back at the top of the page Expected: I should see the l... [18:00:38] 3MobileFrontend / 3stable: Nearby doesn't remember back behaviour - 10https://bugzilla.wikimedia.org/72486#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/FnTiDjM5 [18:01:25] dbrant: you able to hop on the google hangout after a bit? [18:02:00] dr0ptp4kt: sure, feel free to call whenever [18:05:16] (03CR) 10Jdlrobson: [C: 032] "WFM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168606 (https://bugzilla.wikimedia.org/49033) (owner: 10Florianschmidtwelzow) [18:05:51] (03Merged) 10jenkins-bot: Add handling of code tags in content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168606 (https://bugzilla.wikimedia.org/49033) (owner: 10Florianschmidtwelzow) [18:10:15] (03PS3) 10Mhurd: Re-added cell carrier header. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168527 [18:11:18] dr0ptp4kt: ^ amended the MCCMNC patch to remove 2 now-unused files [18:11:25] mhurd, brion: Do you know of any bugs in the iOS app that would be good for someone who's not coded in C for eight years and has never coded in Objective C? :) [18:11:28] * Deskana is talking about himself. [18:11:45] dbrant: we had to drop off the call, so may call you later, actually. or if i get ancy, will call you in not too long. [18:11:52] :D [18:11:56] mhurd: thanks, will look [18:12:05] yes. there’s a styling issue i haven’t had a chance to track down [18:12:10] mhurd: may be a little bit, but won't keep it waiting too long [18:12:21] dr0ptp4kt: no rush [18:12:56] Deskana: stop by my desk later and i can explain the bug [18:13:40] mhurd: I'm working from home today, gotta go to the doctor's in an hour. I'll chat with you on Monday. :) [18:13:53] Deskana: oh i forgot :) [18:14:01] Deskana: sounds good! [18:16:05] Deskana: you could give https://trello.com/c/df6bUsll/705-ios-credits-page-should-credit-translators-with-a-link-to-twn a try [18:17:08] need to add entries to the rowData method in CredtisViewController, list a url to link to, and maybe localize a string [18:17:24] brion: Sounds like a good start. [18:18:01] brion: Thanks. :) [18:18:05] :D [18:19:10] Oh yeah, I forgot I managed to totally freeze the app on my phone last night. :D [18:19:34] kaldari: i don't know another way [18:19:41] (it's been a while since i fiddled with tables) [18:20:24] (03CR) 10MaxSem: [C: 032 V: 032] Make subject_id param a string [extensions/WikiGrok] - 10https://gerrit.wikimedia.org/r/168588 (owner: 10Phuedx) [18:26:06] Deskana: oh that translate credits story will be done with this: https://trello.com/c/N8gsS2mU/38-ios-app-credits-screen-needs-improvement [18:26:11] Deskana: which i’m doing now [18:27:04] mhurd: No problem. I actually learned a lot just from looking at it. [18:27:13] cool :) [18:28:26] jdlrobson: ICONS!!!111onetwo3 [18:28:40] tfinc: I notice we're not requiring a degree in the job posting. Doesn't that stop us from procuring an H-1B for an application from overseas? [18:28:59] Deskana: which posting iOS ? [18:29:02] tfinc: Yeah. [18:29:49] AFAIK you need to explicitly state in public posting that the job requires a degree in order to get an H-1B. [18:30:15] That doesn't stop you from taking a candidate that doesn't have a degree. [18:30:46] MaxSem: actually, would it make more sense to just add WikiGrok to the main extension list anyway? Or do you think testing it on Beta Labs first is the best thing to do? [18:30:51] * Deskana shrugs. [18:30:51] Deskana: you can get an H1B through a degree *OR* work experience [18:31:09] phuedx: icons! yeh sorry [18:31:26] phuedx: so yeh i know the icons stuff is a bit rough around the edges but that's why i'm putting it in alpha [18:31:43] tfinc: True, but H-1Bs by work require 12 years experience. [18:31:55] tfinc: Which is why we just say degree. [18:31:56] phuedx: thanks for all those comments - i'm gonna fix those up now [18:32:03] then i'm gonna work on the other problems whilst in alpha [18:32:06] and move to beta [18:32:11] jdlrobson: suresies [18:32:13] tfinc: I'll take it up with Emily, I guess. I'd hate for us to shoot ourselves in the foot for getting good candidates from abroad. [18:32:14] then eventually deprecate the old ones worry about caching etc [18:32:31] MaxSem: I was thinking it wouldn't hurt to put it in the main list and then just enable it on Beta Labs first. [18:32:31] i'm not sure if all of 'em were minor anyway [18:32:37] i don't want to block that patch too hard [18:32:38] phuedx: are all the issues you listed in alpha or stable? [18:32:43] alpha [18:33:02] MaxSem: As I assume the Beta Labs list is in addition to the main list. [18:33:39] mhurd: hey monte [18:33:51] moizsyed: hey! [18:36:30] phuedx: looking. Seems there are a few related issues in stable too :- [18:36:40] hrrm [18:36:46] cross 'em off if you seem 'em [18:37:06] must have not flicked back and forth well enough [18:37:08] :/ [18:41:36] (03PS1) 10Phuedx: Fix edit section icon regression [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168637 (https://bugzilla.wikimedia.org/72484) [18:41:46] ^ jdlrobson, kaldari: sorry i missed that during review [18:42:13] also, y'know, the rest of the team :) [18:43:41] jdlrobson: i'm sorta ok with spacing issues and the like [18:43:48] but the watchstar definitely seemed odd [18:43:53] /borked [18:45:00] * Deskana looks at JonKatz. [18:45:35] haha. I got a few questions about our "log" database for mobile apps [18:45:52] what is the timezone for the timestamp? [18:47:40] (03PS3) 10Dbrant: Fix directionality of edit preview (for RTL) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168590 (https://bugzilla.wikimedia.org/72476) [18:48:00] bearND: ^ updated per your comments. (except flipping the CC icon. pretty sure that should stay the same) [18:48:04] Seems like there is a lag in what I am entering in my phone and seeing that show up in the log. wondering what time I should be checking for. [18:48:18] dbrant: sounds good [18:49:14] JonKatz: So the database you're looking it, AFAIK, a replica of the actual database. Replication lag typically runs at a few seconds, but in cases of extreme server pressure it can go up to hours or even days. [18:49:22] JonKatz: Is the timestamp of the entry correct? [18:49:35] (03PS4) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) [18:49:41] (03CR) 10jenkins-bot: [V: 04-1] Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) (owner: 10Jdlrobson) [18:50:01] seems like latest timestamp I just saw was for: 20141024183947 [18:50:29] dr0ptp4kt: what do you think about adding the URL to the onHeaderCheck() interface method? [18:50:40] if its 7 hours ahead of here, that makes it roughly 10 minutes behind. [18:50:56] (03PS5) 10Jdlrobson: Use mw-ui-icon in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168138 (https://bugzilla.wikimedia.org/64101) [18:50:58] ^ phuedx :D some of the icons in alpha are appearing smaller than they should. Haven't worked out if this is font-size specific or icon library specific though. [18:51:24] jdlrobson: i'm alright with solving that after main merge [18:51:42] phuedx: new tables created [18:51:47] kaldari: \o/ [18:52:13] i'm not 100% if that script will run without changes – please gimme review!!! [18:52:53] it's not good review if it's not scathing criticism of my code [18:53:21] phuedx: main thing is we don't break stable :) [18:53:33] phuedx: i can check if kaldari cannot [18:53:41] just fixing up my templates in core patch [18:54:37] wouldn't it be sweet if we cleared the board down [18:55:18] phuedx: I can test it using a temp api3 file before merging your pull request... [18:55:41] cool :) [18:55:59] am gonna break for a rest [18:56:07] jdlrobson: i'll look at ps5 laterz [18:57:05] bearND: that could work. so we'd modify ApiResult.java to expose the url (Api has a geturl type method), then modify Api.java to invoke the callback with that field, right? [18:57:15] bearND: if it's faster to discuss on video, let's do that :) [18:57:38] JonKatz: So the timestamp is right, seven hour offset not withstanding (timestamps are UTC). [18:58:12] (03PS1) 10Dbrant: Fix "logout" preference after crash fix. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168640 [18:58:16] JonKatz: It'll just be replication lag then I guess. [18:59:41] dr0ptp4kt: I'm talking about changing the signature of onHeaderCheck to also include the api URL, so we don't need to expose more than necessary [19:00:40] bearND: yeah, that's cool. for that matter we could even just expose the host. but a full uri is fine, too. am i looking at the right files for the changes/ [19:00:55] s/\//\?/ bearND [19:08:58] phuedx: Running the update script now. I had to bump the memory limit to 400M since 200M wasn't enough :P [19:09:55] phuedx: and the config path was wrong, but I fixed that [19:11:03] phuedx: Looks like the script is working. No idea how long it will take to complete though. [19:11:50] phuedx: So far, the results look legit. [19:12:08] Ok if I pickup the grunt card ? [19:12:40] Going to have a go at if if nobody else is. jdlrobso_, phuedx, kaldari [19:12:55] rmoen: go for it. I think joakino has some experience with grunt [19:12:58] rmoen: cool w me [19:12:59] so maybe the two of you can pair on it [19:14:28] kaldari: do you know any potential DOB or DOD claim IDs? the wikigrok wiki page doesn't mention anything about those. [19:23:39] dr0ptp4kt: I think you're looking the right files. would you like to jump on a hangout? [19:30:51] (03PS1) 10BearND: Add URL parameter to onHeaderCheck() [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/168647 [19:31:05] dr0ptp4kt: dbrant|brb ^ [19:32:55] (03CR) 10Jdlrobson: [C: 04-1] Fix edit section icon regression (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168637 (https://bugzilla.wikimedia.org/72484) (owner: 10Phuedx) [19:42:18] (03CR) 10BearND: [C: 032] Fix directionality of edit preview (for RTL) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168590 (https://bugzilla.wikimedia.org/72476) (owner: 10Dbrant) [19:43:37] (03Merged) 10jenkins-bot: Fix directionality of edit preview (for RTL) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168590 (https://bugzilla.wikimedia.org/72476) (owner: 10Dbrant) [19:44:01] (03PS2) 10BearND: Fix "logout" preference after crash fix. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168640 (owner: 10Dbrant) [19:51:10] (03PS3) 10Jdlrobson: WIP: Use mw.template exclusively for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168232 [19:51:12] (03PS5) 10Jdlrobson: Use ResourceLoaderFileModule for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 [19:51:51] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use mw.template exclusively for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168232 (owner: 10Jdlrobson) [19:51:55] (03CR) 10jenkins-bot: [V: 04-1] Use ResourceLoaderFileModule for templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168231 (owner: 10Jdlrobson) [19:52:48] (03PS1) 10Robmoen: Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 [19:53:09] (03CR) 10Dbrant: [C: 032 V: 032] Add URL parameter to onHeaderCheck() [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/168647 (owner: 10BearND) [19:53:44] (03PS2) 10Robmoen: Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 [19:54:26] Deskana: when I look at the install id in the savedpages and appearancesettings schemas, there is 0 overlap. is it possible they are using different ids? [19:54:46] (03CR) 10jenkins-bot: [V: 04-1] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [19:55:22] * Deskana looks at the code. [19:56:08] Deskana: This is the query I was using-/*looks for users that appear in both appearance settings and saved pages in a specific time period*/ [19:56:08] select * from MobileWikiAppAppearanceSettings_9378399 l [19:56:08] left join MobileWikiAppSavedPages_8909354 r [19:56:08] on l.event_appearanceAppInstallID = r.event_savedPagesAppInstallToken [19:56:08] where r.wiki ='enwiki' [19:56:09] and (r.timestamp between 20141024182000 and 20141024191000) [19:56:09] order by event_appearanceAppInstallID desc, l.timestamp desc [19:56:10] ; [19:56:24] oh shit--sorry about the formatting [19:57:32] JonKatz: It does look like they're both generated from different sources... [19:58:41] Deskana: ok cool--your call on how we tease it out with team [19:59:39] 3MobileFrontend / 3Feature requests: MobileFrontend: Inline code tags styled very large in articles - 10https://bugzilla.wikimedia.org/49033 (10Jon) 5PATC>3RESO/FIX [20:00:03] phuedx: script finished running and results look good. [20:00:41] (03PS1) 10Bmansurov: Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 [20:00:52] phuedx: I'm going to try out the API code now... [20:00:56] rmoen: i've done some of it, ping me when you need review or anything [20:01:59] dbrant|brb: Was that intentional? I always assumed there was a single install ID, not that it was unique per schema. [20:02:22] joakino: I've got it running jshint and jscs just trying to get it to recognize the config at the moment. Trying "validateIndentation": "\t" but it still complains about spaces [20:02:51] I'll push it and would appreciate your thoughts [20:03:12] Deskana: the last time I spoke with YuviPanda about this, he insisted that it should be unique per schema. [20:03:20] (03PS3) 10Robmoen: Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 [20:03:21] joakino: ^ [20:03:43] rmoen: i'm going to have a look [20:03:53] Deskana: I think the reasoning was that, if we have the same ID for all schemas, we would risk de-anonymizing the user. [20:03:56] (03CR) 10jenkins-bot: [V: 04-1] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [20:04:13] ty, i'm going to grab some lunch with my mom and fiance. [20:04:16] brb [20:07:18] Deskana: some of the links on this page are out of date: https://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering/Contribute [20:07:44] Deskana: i would fix ‘em but in middle of something [20:08:01] mhurd: Sure, I can take care of that. [20:08:05] Deskana: thanks! [20:08:32] dbrant|brb: Thanks. I think Howie, Toby and I should probably have a proper chat about what our principles should be here. [20:08:42] dbrant|brb: We've been winging it really and it seems like it's starting to cause confusion. [20:08:48] Deskana: agreed [20:08:52] (03CR) 10BearND: [C: 032] Fix "logout" preference after crash fix. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168640 (owner: 10Dbrant) [20:08:58] Deskana: figured i should pass this along - links to phonegap source etc [20:09:10] bearND: went to lunch. back now [20:09:17] (03Merged) 10jenkins-bot: Fix "logout" preference after crash fix. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168640 (owner: 10Dbrant) [20:09:21] mhurd: mcc-mnc sampling working [20:10:03] (03PS11) 10Jhernandez: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [20:10:39] (03CR) 10jenkins-bot: [V: 04-1] Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (owner: 10Jhernandez) [20:11:14] dr0ptp4kt: i'll be ready in a few [20:13:13] dr0ptp4kt: but you can check out the java api patch: https://gerrit.wikimedia.org/r/#/c/168647/ (merged) [20:14:13] bearND: thanks! i was wondering if i should make those changes :) [20:19:33] dr0ptp4kt: ok, i'm ready now if you want to hangout and go over the changes [20:21:39] bearND: no need on this. the code is clear. that said, anything i need to do to ensure that gradle gets the latest version of java-mwapi? [20:22:55] dr0ptp4kt: once we all agree, and dbrant already has since he merged it, I'll upload the new jar file to the Maven team repo [20:23:20] bearND: i agree, too. [20:25:52] dr0ptp4kt: ok, i'm going to upload the jar file [20:26:11] (03CR) 10Jhernandez: Setup Gruntfile to run jshint and jscs (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [20:26:28] bearND: k, lemme know when ready [20:27:36] jdlrobson, kaldari - so do we need an emergency deploy for edit buttons today? [20:28:06] MaxSem: Doesn't have to be today, but soon [20:28:48] ok let's stick to monday then:) [20:29:55] MaxSem: This could be interesting for you :) https://www.mediawiki.org/wiki/Thread:Extension_talk:PageImages/Wrong_image [20:30:06] thx [20:30:25] (03PS2) 10Jdlrobson: Fix edit section icon regression [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168637 (https://bugzilla.wikimedia.org/72484) (owner: 10Phuedx) [20:30:25] I think because the first picture is too wide? [20:30:26] np :) [20:31:21] (03CR) 10Jdlrobson: [C: 031] "added some documentation. Happy to +2 this. Will leave a little time in case someone wants to review my documentation :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168637 (https://bugzilla.wikimedia.org/72484) (owner: 10Phuedx) [20:32:15] dbrant|brb: It's my understanding that we send an install ID with every request to the API. That's how Analytics identified uniques. Can you point me to the bit of code that does that? [20:33:47] dbrant: I assumed it was in ApiTask since everything extends that, but I don't see it. [20:34:28] Deskana: not every request to the API, but every Page load. Look at PageViewFragmentInternal.java, line 653 [20:34:31] (03CR) 10Florianschmidtwelzow: [C: 031] "Maybe add the bug number, but not really necessary, it's understandable for me :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168637 (https://bugzilla.wikimedia.org/72484) (owner: 10Phuedx) [20:34:39] dbrant: Ahhh, thanks. [20:36:01] dbrant: I see it. Thanks. [20:36:20] dr0ptp4kt: dbrant: new java-mwapi is up. You probably want to run this command to make sure the SNAPSHOT dependenciy to the java-mwapi gets updated: ./gradlew --refresh-dependencies [20:36:36] when i said up, i meant uploaded [20:36:52] bearND: cool, thanks! [20:39:15] dbrant: dr0ptp4kt: you might also need to trigger a Gradle sync in Android Studio. In the toolbar, there's a Gradle icon with an arrow pointing down (~ the fifth toolbar icon from the right) [20:40:24] dbrant: dr0ptp4kt: I also brlew away my ~/.m2/repository/org/mediawiki/api folder but that's probably not needed [20:40:28] blew [20:40:58] i see; i'll do that, as well [20:42:02] (03CR) 10Jdlrobson: [C: 032] "good enough for me :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168637 (https://bugzilla.wikimedia.org/72484) (owner: 10Phuedx) [20:42:57] Deskana: and note that the installID in that instance is also different from the IDs in our other schemas. [20:43:28] (03Merged) 10jenkins-bot: Fix edit section icon regression [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168637 (https://bugzilla.wikimedia.org/72484) (owner: 10Phuedx) [20:43:37] (03PS2) 10BearND: Add Wikidata descriptions to full text results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168544 [20:43:51] (03PS3) 10BearND: Add Wikidata descriptions to full text results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168544 [20:44:19] bearND: thx. i had to rm -f that same api folder to get it to not complain about signature mismatches, even after running the gradlew and button click [20:44:46] dr0ptp4kt: good to know [20:47:01] (03CR) 10Jdlrobson: [C: 04-1] Support different types of claims in WikiGrok version A. (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [20:48:31] (03CR) 10Kaldari: [C: 04-1] Support different types of claims in WikiGrok version A. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [20:48:58] dr0ptp4kt: would you take a look at the changes in https://gerrit.wikimedia.org/r/#/c/168544/ from patch set 1 to patch set 2? Those are the ones for W0 [20:49:04] https://gerrit.wikimedia.org/r/#/c/168544/1..2/wikipedia/src/main/java/org/wikipedia/zero/WikipediaZeroHandler.java [20:50:43] mhurd: ^ you might want to know about this, too [20:50:44] bearND: ha, that's two patches i started on and won't submit! [20:51:17] dr0ptp4kt: sorry [20:51:22] bearND: :) [20:51:40] Joakino, do you have a sense of what you want your work hours will be when you get back home? [20:52:26] kristenlans: I still haven't thought about it, I'll have to check the meetings times and figure something out [20:55:02] (03CR) 10Dr0ptp4kt: Add Wikidata descriptions to full text results (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168544 (owner: 10BearND) [20:55:33] joakino: I’m about to send out some updates on meeting times that shoudl be a little better, but still probably not ideal for you. When you get the mail, take a look at those times, and we can try to shuffle things around more if need be. :-) [20:55:34] bearND: ^ [20:55:48] bearND: i mean ^^^ now [20:56:03] dr0ptp4kt: good, i'll make the changes [20:57:00] kristenlans: Until I'm in Spain its going to be a bit difficult to judge, do you mind if I come back to you about this after the 3rd Nov? [20:57:40] joakino: yes, no rush, just want to let you know that we will try hard to make it work for everyone :-) [20:57:59] kristenlans: thanks a lot! i really appreciate it [20:59:32] (03CR) 10Jdlrobson: [C: 04-1] "Doesn't seem to work for me on Chrome when I test it out..." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (owner: 10Jhernandez) [21:00:05] (03CR) 10Dbrant: "see inline; Also, when the wikidata description is more than one line, the second line gets cut off." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168544 (owner: 10BearND) [21:00:41] dbrant: I think there's probably some code cleanup that can be done here. It doesn't make sense that the readActionID is stored a different way from the rest of the IDs. [21:00:46] dbrant: Perhaps my project this weekend. :) [21:00:58] Deskana: by all means! [21:02:23] joakino_: https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript [21:13:22] kaldari: fyi, the wikigrok api freaks out when a wrong key is sent to it https://gist.github.com/anonymous/8db78adb768886b4e3c8 [21:15:15] (03PS1) 10Jdlrobson: Generate WikiGrok prefix correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168695 [21:17:57] (03PS2) 10Bmansurov: Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 [21:18:19] mhurd: wanna come over here for a sec? [21:18:22] er min [21:18:25] er 2 min [21:20:03] mhurd: The longer you take to go over, the longer he'll want you for. [21:21:34] kaldari: did the script complete? [21:21:36] bmansurov: why can't you just use this.one( 'show' then ? [21:21:46] phuedx: yes [21:21:46] phuedx: it's having strange results [21:21:51] (03PS4) 10BearND: Add Wikidata descriptions to full text results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168544 [21:21:53] phuedx: http://imgur.com/NO8pwfl [21:21:59] phuedx: but see my comments on the pull request [21:22:18] jdlrobson: yes i should do that, I'll do it in a separate patch [21:22:36] bmansurov: also initialize only ever runs once [21:22:37] dr0ptp4kt: dbrant|bbl: ^^ should address your previous comments [21:22:43] so i don't understand why it's an issue [21:23:02] jdlrobson: yes, but the dialog itself is shown and hidden multiple times, no? [21:23:44] kaldari, jdlrobson: what do you think it should return? [21:23:57] these are wikidata items with no date of birth/death [21:24:01] what should the api say? [21:24:03] phuedx: an ISO data probably [21:24:08] ok [21:24:10] I mean ISO date [21:24:36] given that the table is populated with random dates, that shouldn't be an issue ;) [21:24:56] jdlrobson: how can I get articles show up in Special:Nearby locally? [21:25:04] phuedx: ? [21:25:20] at the moment the api simply says "yes this item is a person and doesn't have a date of birth" [21:25:28] yeah [21:25:44] so it's good for picking items, but not offering suggestions [21:25:52] by returning its id if that's the case, otherwise an empty list [21:26:38] phuedx: See the page I'm building at https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok/Claim_suggestions [21:26:56] kaldari: i was about to ask if there was a page defining a reasonable suggestion [21:27:30] phuedx: Nope, that's the fun part though :) [21:27:48] kaldari: i was going to suggest infobox data on the client [21:28:01] persondata? [21:28:44] phuedx: https://en.wikipedia.org/wiki/Wikipedia:Persondata [21:29:14] yowza [21:29:21] phuedx: unfortunately, none of those are ISO dates [21:29:25] yup [21:29:33] and may contain "early" [21:29:36] and "late" [21:29:49] phuedx: I know the date of birth and date of death parameters are format restricted on Wikidata, but I don't know the details. [21:30:36] phuedx: Looks like it's 'Data type: Time', whatever that means [21:31:21] bmansurov: yeh looks like you want to use once [21:31:28] kaldari: when in doubt, i look at the wdt datamodel [21:31:34] kaldari: https://github.com/Wikidata/Wikidata-Toolkit/blob/master/wdtk-datamodel/src/main/java/org/wikidata/wdtk/datamodel/implementation/TimeValueImpl.java [21:31:49] (03CR) 10Jdlrobson: [C: 04-1] Support different types of claims in WikiGrok version A. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [21:31:55] phuedx: We may need to punt on this one pending further investigation. [21:32:26] kaldari, jdlrobson: will wikigrok show the dob/dod questions if the data is made available? [21:32:42] phuedx: yup if we merge that change [21:32:43] phuedx: I think so [21:32:45] they will magically show up [21:32:45] (i'm a mergist, despite my behaviour on jon's icon patch) [21:32:47] eep [21:32:55] then punt away! [21:33:01] that's how i replicated the funny screenshot :) [21:33:51] well that serves you right, for writing code that can handle multiple types of response from a single api call [21:33:57] doesn't it!? [21:34:40] Jon's code is too smart for it's own good ;) [21:34:47] (03PS3) 10Bmansurov: Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 [21:34:55] alright, kaldari, jdlrobson: maybe close the pr with a note on it and write a spike for each source of date info? [21:35:41] phuedx: Sounds like a plan. [21:36:14] tfinc, mhurd: Just got an email from Andy. It seems like we'll hear back from The Specialists Guild on Monday. Quite a quick turnaround, really. [21:36:30] nice [21:36:52] Deskana: whoa that’s great! [21:37:29] (03CR) 10Dr0ptp4kt: [C: 032] Re-added cell carrier header. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/168527 (owner: 10Mhurd) [21:40:03] kaldari: spikes created: https://trello.com/c/n3aCKHev/74-spike-could-we-extract-dob-dod-suggestions-from-persondata and https://trello.com/c/myINl5By/75-spike-could-we-extract-dob-dod-suggestions-from-infoboxes [21:40:08] could maybe merge 'em into one [21:40:41] (03CR) 10Dr0ptp4kt: "The zero-rating related header inspection part looks good to me." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168544 (owner: 10BearND) [21:40:45] (03CR) 10Jdlrobson: [C: 04-1] "Could we also wire up the existing Makefile so it uses grunt instead for jshint / jscs ?" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [21:40:55] actually, ima merge 'em [21:41:07] dr0ptp4kt: thx! [21:41:20] phuedx: While you're at it, add birth and death categories too (which is probably the cheapest method) [21:42:05] phuedx: and lead sentence while we're at it (maybe using the extracts API) [21:43:33] mhurd: for the iOS Wikipedia repo, do you recall whether one has to click 'publish and submit'? i hit 'publish'. a lot of other repos once going through the ci process then take care of the submit part. but if i need to hit 'publish and submit', i'll happily do so. [21:44:21] (03CR) 10Jdlrobson: Add role 'button' to section heading text (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/148363 (https://bugzilla.wikimedia.org/68371) (owner: 10Hoo man) [21:50:25] kaldari: when does your change to enable the wikigrok extension go live? [21:50:33] i see it's been merged [21:51:39] phuedx: meh, I'm poking on that. it looks like it's going to take longer than I hoped, but I'm shooting for some time next week. [21:52:15] phuedx: I should have started to ball rolling earlier [21:52:52] phuedx: or Max should have let you build in MF for the timebeing :P [21:53:12] but no rush I guess [21:55:15] cool :) [21:55:20] as you say, no rush [21:55:36] it'd be a bit more annoying to migrate later on, maybe [22:00:43] alright, g'night folks [22:14:01] goodnight phuedx [22:26:03] (03PS1) 10Bmansurov: Restore scroll position on Special:Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) [22:26:57] (03PS5) 10BearND: Add Wikidata descriptions to full text results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168544 [22:26:59] (03PS1) 10BearND: Only check W0 headers for m.wikipedia.org [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168709 [22:27:03] rmoen: ping: https://trello.com/c/dM97PKsJ/13-spike-investigate-expanding-wikigrok-scope-movies-and-tv-shows [22:27:16] looking [22:27:35] kaldari: thanks [22:28:25] dr0ptp4kt: I split up the previous patch into two so the build breaking stuff can be merged separately [22:28:26] https://gerrit.wikimedia.org/r/168709 [22:28:33] kaldari: I'll change that up and post it on the wiki/list [22:28:47] rmoen: Thanks! [22:29:00] dr0ptp4kt: can you +2 that part since dbrant|bbl doesn't seem to be around? [22:29:09] (03CR) 10jenkins-bot: [V: 04-1] Restore scroll position on Special:Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) (owner: 10Bmansurov) [22:29:17] rmoen: I just realized that all of this spike information is going to quickly get lots unless we centralize it somewhere. [22:29:26] lots=lost [22:29:26] (03CR) 10Dr0ptp4kt: [V: 032] Only check W0 headers for m.wikipedia.org [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168709 (owner: 10BearND) [22:29:30] bearND: done [22:29:31] rigth [22:30:14] dr0ptp4kt: it needs a Code-Review: +2 (verified is not enough) [22:31:39] (03CR) 10Bmansurov: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) (owner: 10Bmansurov) [22:32:52] rmoen: Just made some edits to that page. Hope I don't merge conflict :) [22:33:06] kaldari: you're good [22:34:27] bmansurov: Could you transfer your spike results from https://trello.com/c/qf8vEwP3/12-spike-investigate-expanding-wikigrok-scope-biographies into this wiki page: https://www.mediawiki.org/wiki/Extension:MobileFrontend/WikiGrok/Claim_suggestions [22:34:39] (03PS4) 10Robmoen: Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 [22:35:28] (03CR) 10jenkins-bot: [V: 04-1] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [22:37:23] kaldari: ok [22:37:26] (03PS1) 10Jdlrobson: Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 [22:37:28] (03PS1) 10BearND: Fix LoginTaskTests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168712 [22:38:17] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Rename articleList->PageList for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 (owner: 10Jdlrobson) [22:40:05] (03CR) 10Jdlrobson: [C: 04-1] Restore scroll position on Special:Nearby (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) (owner: 10Bmansurov) [22:41:53] (03PS5) 10Robmoen: Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 [22:42:19] (03CR) 10Robmoen: Setup Gruntfile to run jshint and jscs (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [22:42:30] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168605 (https://bugzilla.wikimedia.org/70528) (owner: 10Dbrant) [22:42:40] (03CR) 10jenkins-bot: [V: 04-1] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [22:42:53] (03PS12) 10Jhernandez: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 [22:43:41] (03CR) 10jenkins-bot: [V: 04-1] Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (owner: 10Jhernandez) [22:43:44] (03CR) 10Jdlrobson: [C: 032] Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [22:44:11] (03CR) 10Jhernandez: Load nearby by url coordinates and load by page title (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (owner: 10Jhernandez) [22:44:31] (03CR) 10jenkins-bot: [V: 04-1] Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [22:44:53] (03PS6) 10Robmoen: Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 [22:44:56] ^ linted [22:45:26] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [22:45:38] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (owner: 10Jhernandez) [22:45:40] (03PS2) 10Bmansurov: Restore scroll position on Special:Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) [22:45:42] (03CR) 10jenkins-bot: [V: 04-1] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [22:46:41] (03CR) 10jenkins-bot: [V: 04-1] Restore scroll position on Special:Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) (owner: 10Bmansurov) [22:53:17] kaldari: I've added the trello card info to the wiki [22:53:26] bmansurov: Thanks! [22:55:22] (03PS13) 10Jdlrobson: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (https://bugzilla.wikimedia.org/49413) (owner: 10Jhernandez) [22:56:30] (03CR) 10jenkins-bot: [V: 04-1] Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (https://bugzilla.wikimedia.org/49413) (owner: 10Jhernandez) [22:58:08] joakino: https://www.mediawiki.org/wiki/Mobile_web/Coding_conventions [22:59:56] (03PS14) 10Jdlrobson: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (owner: 10Jhernandez) [23:00:16] (03PS15) 10Jdlrobson: Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (https://bugzilla.wikimedia.org/49413) (owner: 10Jhernandez) [23:01:07] (03CR) 10jenkins-bot: [V: 04-1] Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (https://bugzilla.wikimedia.org/49413) (owner: 10Jhernandez) [23:01:34] (03CR) 10Jdlrobson: [C: 032] Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (https://bugzilla.wikimedia.org/49413) (owner: 10Jhernandez) [23:02:09] (03CR) 10Jdlrobson: [C: 04-1] "This breaks with I29bf5b25f8a02659a81cbd10227a9175b1517f32 you'll need to rebase on top of it I'm afraid and be careful not to break the n" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) (owner: 10Bmansurov) [23:02:14] (03CR) 10Kaldari: [C: 04-1] Support different types of claims in WikiGrok version A. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [23:02:36] (03CR) 10jenkins-bot: [V: 04-1] Load nearby by url coordinates and load by page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168208 (https://bugzilla.wikimedia.org/49413) (owner: 10Jhernandez) [23:03:28] (03PS1) 10Jhernandez: Tools: JS beautify code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168718 [23:04:14] (03CR) 10Bmansurov: [C: 032] Generate WikiGrok prefix correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168695 (owner: 10Jdlrobson) [23:04:17] (03CR) 10jenkins-bot: [V: 04-1] Tools: JS beautify code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168718 (owner: 10Jhernandez) [23:06:17] (03PS4) 10Bmansurov: Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 [23:06:43] bmansurov: don't believe everything kaldari tells you :P [23:07:01] jdlrobson: why not? [23:07:06] (03CR) 10jenkins-bot: [V: 04-1] Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [23:07:15] (03CR) 10Jdlrobson: [C: 04-1] Support different types of claims in WikiGrok version A. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [23:07:48] (03CR) 10jenkins-bot: [V: 04-1] Generate WikiGrok prefix correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168695 (owner: 10Jdlrobson) [23:08:06] jdlrobson: why can't we use one? [23:08:12] (03CR) 10Robmoen: Setup Gruntfile to run jshint and jscs (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [23:09:34] jenkins is MAD [23:09:54] (03PS7) 10Robmoen: Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 [23:09:54] rawr jenkins! [23:10:34] irony, jshint doesn't like my jshint inline configuration [23:10:41] (03CR) 10jenkins-bot: [V: 04-1] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [23:10:54] jeeez [23:11:17] qunit failure now... [23:13:58] bmansurov: one is an alias to OO.EventEmitter.once. I'm in the process of setting up a deprecation notice [23:14:08] https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/OO.EventEmitter-method-once < bmansurov [23:14:15] joakino: what does grunt-contrib-watch do ? [23:14:44] Seeing it in other wmf configs and the npm docs don't really explain it [23:14:55] jdlrobson: ok thanks [23:15:10] rmoen: that's for watching files [23:15:35] rmoen: so if you run grunt watch, it stays waiting for file changes, and when some file changes it triggers the defined tasks [23:15:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/166274 (owner: 10Deskana) [23:15:58] joakino: oh thats interesting [23:16:06] rmoen: it is super awesome for auto running tests, linters, beautifiers when files change without having to run them manually [23:16:37] joakino: right like uglify when certain files change.. Awesome [23:17:23] yep, for example, every time a js file changes, we do the whole carrousel -> beautify | jscs | jshint | qunit [23:17:46] rmoen: ^ [23:17:51] got it [23:17:55] kaldari: https://gerrit.wikimedia.org/r/168722 can you merge that asap ? [23:18:16] (03PS5) 10Bmansurov: Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 [23:18:39] (03CR) 10Robmoen: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [23:19:05] (03CR) 10jenkins-bot: [V: 04-1] Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [23:19:29] (03CR) 10jenkins-bot: [V: 04-1] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [23:26:11] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168711 (owner: 10Jdlrobson) [23:27:23] (03CR) 10Kaldari: [C: 032] Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [23:28:12] (03CR) 10jenkins-bot: [V: 04-1] Support different types of claims in WikiGrok version A. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168663 (owner: 10Bmansurov) [23:33:55] (03PS6) 10BearND: Add Wikidata descriptions to full text results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168544 [23:34:19] (03CR) 10jenkins-bot: [V: 04-1] Add Wikidata descriptions to full text results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168544 (owner: 10BearND) [23:35:20] I assume everyone knows some of the qunit tests are broken ? I'm looking into it [23:36:46] (03PS7) 10BearND: Add Wikidata descriptions to full text results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/168544 [23:37:09] (03PS8) 10Robmoen: Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 [23:37:19] or maybe my branch is outdated [23:37:56] (03CR) 10jenkins-bot: [V: 04-1] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [23:38:40] guess not [23:46:37] (03CR) 10Bmansurov: "This patch becomes useless once I rebase on top of that patch. Any ideas how I can store the scroll position? I thought about using localS" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168708 (https://bugzilla.wikimedia.org/72486) (owner: 10Bmansurov) [23:48:45] rmoen: i don't know if somebody answered but jenkins is angry and doesnt let phantom live, so no verifications from it [23:49:28] (03CR) 10Jdlrobson: [C: 04-1] "Comment aside this looks good to go." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [23:49:29] joakino: didn't know that, but that makes sense as its complaining about phantom [23:49:47] I'm just going off the fact I have two qunit failures in master on local wiki [23:49:48] rmoen: yeh i think the Jenkins complaint is a false positive [23:49:50] http://127.0.0.1:8080/wiki/Special:JavaScriptTest/qunit# [23:50:12] having to do with toggle.js [23:50:27] rmoen: that looks unrelated but looks like a problem with bad setup/teardown [23:50:37] bmansurov wrote those tests [23:51:11] jdlrobson: yeah its unrelated to phantom, i'm just mentioning it [23:51:38] https://bugzilla.wikimedia.org/show_bug.cgi?id=72505 < rmoen joakino [23:53:31] rmoen: all 382 qunit tests past on my local master [23:53:31] (03PS9) 10Robmoen: Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 [23:54:19] (03CR) 10jenkins-bot: [V: 04-1] Setup Gruntfile to run jshint and jscs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/168656 (owner: 10Robmoen) [23:54:29] bmansurov: hmmm i'm only showing 140 tests in mobile view mode [23:54:54] rmoen: hmm, i ran the tests in terminal, why are they different? [23:55:46] bmansurov: maybe its counting all assertions in terminal ? [23:55:59] rmoen: maybe, but all tests are passing in terminal [23:56:48] bmansurov: maybe its localized to me, but i'm on head of master so i have no clue why that would be [23:57:12] rmoen: I see some tests fail in firefox too